ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/loader.C
(Generate patch)

Comparing deliantra/server/common/loader.C (file contents):
Revision 1.97 by root, Wed Aug 1 19:15:49 2007 UTC vs.
Revision 1.142 by root, Mon Nov 9 17:39:05 2009 UTC

1/* 1/*
2 * This file is part of Crossfire TRT, the Roguelike Realtime MORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007 Marc Alexander Lehmann / Robin Redeker / the Crossfire TRT team 4 * Copyright (©) 2005,2006,2007,2008,2009 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2002,2007 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2002,2007 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 * 7 *
8 * Crossfire TRT is free software: you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify it under
9 * it under the terms of the GNU General Public License as published by 9 * the terms of the Affero GNU General Public License as published by the
10 * the Free Software Foundation, either version 3 of the License, or 10 * Free Software Foundation, either version 3 of the License, or (at your
11 * (at your option) any later version. 11 * option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the Affero GNU General Public License
19 * along with this program. If not, see <http://www.gnu.org/licenses/>. 19 * and the GNU General Public License along with this program. If not, see
20 * <http://www.gnu.org/licenses/>.
20 * 21 *
21 * The authors can be reached via e-mail to <crossfire@schmorp.de> 22 * The authors can be reached via e-mail to <support@deliantra.net>
22 */ 23 */
23
24/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
25 sub/add_weight will transcend the environment updating the carrying
26 variable. */
27 24
28#include <global.h> 25#include <global.h>
29#include <loader.h> 26#include <loader.h>
30#include <sproto.h> 27#include <sproto.h>
31 28
32///////////////////////////////////////////////////////////////////////////// 29/////////////////////////////////////////////////////////////////////////////
30
31extern archetype *loading_arch;
32
33//+GPL
33 34
34/* This table is only necessary to convert objects that existed before the 35/* This table is only necessary to convert objects that existed before the
35 * spell object conversion to the new object. It was not practical 36 * spell object conversion to the new object. It was not practical
36 * to go through every mapping looking for every potion, rod, wand, etc 37 * to go through every mapping looking for every potion, rod, wand, etc
37 * that had a sp set and update to the new value. So this maps the 38 * that had a sp set and update to the new value. So this maps the
… …
167 "spell_magic_drain", /* 122 */ 168 "spell_magic_drain", /* 122 */
168 "spell_counterspell", /* 123 */ 169 "spell_counterspell", /* 123 */
169 "spell_disarm", /* 124 */ 170 "spell_disarm", /* 124 */
170 "spell_cure_confusion", /* 125 */ 171 "spell_cure_confusion", /* 125 */
171 "spell_restoration", /* 126 */ 172 "spell_restoration", /* 126 */
172 "was summon evil monster", /* 127 *//* Not implenented as nothing used it */ 173 "spell_summon_devil", /* 127 *//* Not implenented as nothing used it */
173 "spell_counterwall", /* 128 */ 174 "spell_counterwall", /* 128 */
174 "spell_cause_light_wounds", /* 129 */ 175 "spell_cause_light_wounds", /* 129 */
175 "spell_cause_medium_wounds", /* 130 */ 176 "spell_cause_medium_wounds", /* 130 */
176 "spell_cause_heavy_wounds", /* 131 */ 177 "spell_cause_heavy_wounds", /* 131 */
177 "spell_charm_monsters", /* 132 */ 178 "spell_charm_monsters", /* 132 */
… …
249 "spell_cause_rabies", /* 204 */ 250 "spell_cause_rabies", /* 204 */
250 "spell_glyph", /* 205 */ 251 "spell_glyph", /* 205 */
251 NULL 252 NULL
252}; 253};
253 254
254extern bool loading_arch;
255
256/* This function checks the object after it has been loaded (when we 255/* This function checks the object after it has been loaded (when we
257 * get the 'end' in the input stream). This function can be used to 256 * get the 'end' in the input stream). This function can be used to
258 * deal with legacy objects where fields may have changed. It can also be used 257 * deal with legacy objects where fields may have changed. It can also be used
259 * to check for objects to make sure there are no common errors. 258 * to check for objects to make sure there are no common errors.
260 */ 259 */
261void 260void
262object::post_load_check () 261object::post_load_check ()
263{ 262{
264 if (type >= NUM_TYPES) 263 if (type >= NUM_TYPES)
265 { 264 {
266 LOG (llevError, "%s: type out of range, resetting to 0.\n", debug_desc ()); 265 LOG (llevError, "ITEMBUG: %s: type out of range, resetting to 0.\n", debug_desc ());
267 type = 0; 266 type = 0;
268 } 267 }
269 268
270 switch (type) 269 switch (type)
271 { 270 {
… …
273 case WAND: 272 case WAND:
274 case ROD: 273 case ROD:
275 case HORN: 274 case HORN:
276 if (slot [body_range].info != -1) 275 if (slot [body_range].info != -1)
277 { 276 {
278 LOG (llevError, "%s: body_range %d != -1\n", debug_desc (), slot [body_range].info); 277 LOG (llevError, "ITEMBUG: %s: body_range %d != -1\n", debug_desc (), slot [body_range].info);
279 slot [body_range].info = -1; 278 slot [body_range].info = -1;
280 } 279 }
281 break; 280 break;
282 281
283 case WEAPON: 282 case WEAPON:
284 if (slot [body_combat].info != -1) 283 if (slot [body_combat].info != -1)
285 { 284 {
286 LOG (llevError, "%s: body_combat %d != -1\n", debug_desc (), slot [body_combat].info); 285 LOG (llevError, "ITEMBUG: %s: body_combat %d != -1\n", debug_desc (), slot [body_combat].info);
287 slot [body_combat].info = -1; 286 slot [body_combat].info = -1;
288 } 287 }
289 break; 288 break;
290 289
291 case SHIELD: 290 case SHIELD:
292 if (slot [body_shield].info != -1) 291 if (slot [body_shield].info != -1)
293 { 292 {
294 LOG (llevError, "%s: body_shield %d != -1\n", debug_desc (), slot [body_shield].info); 293 LOG (llevError, "ITEMBUG: %s: body_shield %d != -1\n", debug_desc (), slot [body_shield].info);
295 slot [body_shield].info = -1; 294 slot [body_shield].info = -1;
296 } 295 }
297 break; 296 break;
298 297
299 case PLAYER: 298 case PLAYER:
300 if (slot [body_shield].info != 1) 299 if (slot [body_shield].info != 1)
301 { 300 {
302 LOG (llevError, "%s: body_shield %d != 1\n", debug_desc (), slot [body_shield].info); 301 LOG (llevError, "ITEMBUG: %s: body_shield %d != 1\n", debug_desc (), slot [body_shield].info);
303 slot [body_shield].info = 1; 302 slot [body_shield].info = 1;
304 } 303 }
305 304
306 if (slot [body_combat].info != 1) 305 if (slot [body_combat].info != 1)
307 { 306 {
308 LOG (llevError, "%s: body_combat %d != 1\n", debug_desc (), slot [body_combat].info); 307 LOG (llevError, "ITEMBUG: %s: body_combat %d != 1\n", debug_desc (), slot [body_combat].info);
309 slot [body_combat].info = 1; 308 slot [body_combat].info = 1;
310 } 309 }
311 310
312 if (slot [body_range].info != 1) 311 if (slot [body_range].info != 1)
313 { 312 {
314 LOG (llevError, "%s: body_range %d != 1\n", debug_desc (), slot [body_range].info); 313 LOG (llevError, "ITEMBUG: %s: body_range %d != 1\n", debug_desc (), slot [body_range].info);
315 slot [body_range].info = 1; 314 slot [body_range].info = 1;
316 } 315 }
317 break; 316 break;
318 } 317 }
319 318
… …
342 * not in the ideal fashion. 341 * not in the ideal fashion.
343 */ 342 */
344 if (loading_arch && (type == WEAPON || type == BOW || type == ROD || type == HORN || type == WAND)) 343 if (loading_arch && (type == WEAPON || type == BOW || type == ROD || type == HORN || type == WAND))
345 { 344 {
346 if (!skill) 345 if (!skill)
347 LOG (llevError, "Weapon %s lacks a skill.\n", debug_desc ()); 346 LOG (llevError, "ITEMBUG: weapon %s lacks a skill.\n", debug_desc ());
348 else if ((!strcmp (skill, "one handed weapons") && slot[body_arm].info != -1) || 347 else if ((skill == shstr_one_handed_weapons && slot[body_arm].info != -1) ||
349 (!strcmp (skill, "two handed weapons") && slot[body_arm].info != -2)) 348 (skill == shstr_two_handed_weapons && slot[body_arm].info != -2))
350 LOG (llevError, "weapon %s arm usage does not match skill: %d, %s\n", debug_desc (), slot[body_arm].info, &skill); 349 LOG (llevError, "ITEMBUG: weapon %s arm usage does not match skill: %d, %s\n", debug_desc (), slot[body_arm].info, &skill);
351 } 350 }
352 351
353 /* We changed last_heal to gen_sp_armour, which is what it 352 /* We changed last_heal to gen_sp_armour, which is what it
354 * really does for many objects. Need to catch any in maps 353 * really does for many objects. Need to catch any in maps
355 * that may have an old value. 354 * that may have an old value.
… …
361 || type == AMULET || type == GIRDLE 360 || type == AMULET || type == GIRDLE
362 || type == BRACERS || type == CLOAK) 361 || type == BRACERS || type == CLOAK)
363 { 362 {
364 if (last_heal) 363 if (last_heal)
365 { 364 {
366 LOG (llevDebug, "Object %s still has last_heal set, not gen_sp_armour\n", debug_desc ()); 365 LOG (llevError, "ITEMBUG: object %s still has last_heal set, not gen_sp_armour\n", debug_desc ());
367 gen_sp_armour = last_heal; 366 gen_sp_armour = last_heal;
368 last_heal = 0; 367 last_heal = 0;
369 } 368 }
370 369
371 int ip = calc_item_power (this, 0); 370 int ip = calc_item_power (this, 0);
372 371
373 /* Legacy objects from before item power was in the game */ 372 /* Legacy objects from before item power was in the game */
374 if (!item_power && ip) 373 if (!item_power && ip)
375 { 374 {
376 if (ip > 3) 375 if (ip > 3)
377 LOG (llevDebug, "Object %s had no item power, using %d\n", debug_desc (), ip); 376 LOG (llevDebug, "ITEMBUG: Object %s had no item power, using %d\n", debug_desc (), ip);
378 377
379 item_power = ip; 378 item_power = ip;
380 } 379 }
381 380
382 /* Check for possibly bogus values. Has to meet both these criteria - 381 /* Check for possibly bogus values. Has to meet both these criteria -
… …
389 if (ip > 2 * item_power && ip > (item_power + 3)) 388 if (ip > 2 * item_power && ip > (item_power + 3))
390 LOG (llevDebug, "Object %s seems to have too low item power? %d > %d\n", debug_desc (), ip, item_power); 389 LOG (llevDebug, "Object %s seems to have too low item power? %d > %d\n", debug_desc (), ip, item_power);
391#endif 390#endif
392 } 391 }
393 392
394 /* Old spellcasting object - need to load in the appropiate object */ 393 /* old style spellcasting object (pretty common) - need to load in the appropiate object */
395 if ((type == ROD || type == WAND || type == SCROLL || type == HORN || type == FIREWALL || 394 /* (schmorp) old really doesn't mean old, imho, just a more compact way to store such objects */
395 if ((type == ROD
396 || type == WAND
397 || type == SCROLL
398 || type == HORN
399 || type == FIREWALL
396 /* POTIONS and ALTARS don't always cast spells, but if they do, update them */ 400 /* POTIONS and ALTARS don't always cast spells, but if they do, update them */
397 ((type == POTION || type == ALTAR) && stats.sp)) && !inv && !loading_arch) 401 || ((type == POTION || type == ALTAR) && stats.sp)) // watchout: sp = 0 is still magic bullet.
402 && !inv
403 && !loading_arch
404 && stats.sp) // watchout: old magic bullet stuff directly on the map is going to break here!
405 // TODO: at least one watchout-comments is redundant - investigate/remove
398 { 406 {
407 // TODO: fix firewall object on map
399 /* Fireall is bizarre in that spell type was stored in dam. Rest are 'normal' 408 /* Firewall is bizarre in that spell type was stored in dam. Rest are 'normal'
400 * in that spell was stored in sp. 409 * in that spell was stored in sp.
401 */ 410 */
411 //LOG (llevError, "old spellcasting object found: %s", debug_desc ());
402 object *tmp = get_archetype (spell_mapping[type == FIREWALL ? stats.dam : stats.sp]); 412 object *tmp = get_archetype (spell_mapping[type == FIREWALL ? stats.dam : stats.sp]);
403 insert_ob_in_ob (tmp, this); 413 insert_ob_in_ob (tmp, this);
404 randomitems = NULL; /* So another spell isn't created for this object */ 414 randomitems = 0;
405 } 415 }
406 416
407 /* spellbooks & runes use slaying. But not to arch name, but to spell name */ 417 /* spellbooks & runes use slaying. But not to arch name, but to spell name */
408 if ((type == SPELLBOOK || type == RUNE) && slaying && !inv && !loading_arch) 418 if ((type == SPELLBOOK || type == RUNE) && slaying && !inv && !loading_arch)
409 { 419 {
420 LOG (llevError, "ITEMBUG: spellbook/rune found without inv but slaying: %s", debug_desc ());
410 object *tmp = get_archetype_by_object_name (slaying); 421 object *tmp = get_archetype_by_object_name (slaying);
411 insert_ob_in_ob (tmp, this); 422 insert_ob_in_ob (tmp, this);
412 randomitems = NULL; /* So another spell isn't created for this object */ 423 randomitems = 0; /* So another spell isn't created for this object */
413 /* without this, value is all screwed up */ 424 /* without this, value is all screwed up */
414 value = arch->value * inv->value; 425 value = arch->value * inv->value;
415 } 426 }
416 427
417 if (QUERY_FLAG (this, FLAG_MONSTER)) 428 if (QUERY_FLAG (this, FLAG_MONSTER))
418 { 429 {
419 if (stats.hp > stats.maxhp) 430 if (stats.hp > stats.maxhp)
420 { 431 {
421 LOG (llevDebug, "Monster %s has hp set higher than maxhp (%d>%d)\n", debug_desc (), stats.hp, stats.maxhp); 432 LOG (llevInfo, "ITEMBUG: monster %s has hp set higher than maxhp (%d>%d)\n", debug_desc (), stats.hp, stats.maxhp);
422 stats.maxhp = stats.hp; 433 stats.maxhp = stats.hp;
423 } 434 }
424 435
425 /* The archs just need to be updated for this */ 436 /* The archs just need to be updated for this */
426 if (move_type == 0) 437 if (move_type == 0)
427 move_type = MOVE_WALK; 438 move_type = MOVE_WALK;
428 } 439 }
429 440
430 if ((QUERY_FLAG (this, FLAG_GENERATOR) && QUERY_FLAG (this, FLAG_CONTENT_ON_GEN)) || type == CREATOR || type == CONVERTER) 441 if ((QUERY_FLAG (this, FLAG_GENERATOR) && QUERY_FLAG (this, FLAG_CONTENT_ON_GEN)) || type == CREATOR || type == CONVERTER)
431 {
432 /* Object will duplicate it's content as part of the 442 /* Object will duplicate it's content as part of the
433 * generation process. To do this, we must flag inventory 443 * generation process. To do this, we must flag inventory
434 * so it remains unevaluated concerning the randomitems and 444 * so it remains unevaluated concerning the randomitems and
435 * the living (a demonlord shouldn't cast from inside generator!) 445 * the living (a demonlord shouldn't cast from inside generator!)
436 */ 446 */
447 /* ??? this *should* be done elsewhere, e.g. after map loading etc. */
437 flag_inv (this, FLAG_IS_A_TEMPLATE); 448 flag_inv (this, FLAG_IS_A_TEMPLATE);
438 }
439 449
440 /* Handle player movers. We use move_type for player movers 450 /* Handle player movers. We use move_type for player movers
441 * because they operate on their own time (move_on 451 * because they operate on their own time (move_on
442 * would potentially cause them to be triggered when someone steps 452 * would potentially cause them to be triggered when someone steps
443 * on them). If move_type is set, presume person knows what they 453 * on them). If move_type is set, presume person knows what they
444 * are doing, otherwise, set move_type based on maxhp value. 454 * are doing, otherwise, set move_type based on maxhp value.
445 */ 455 */
446 if (type == PLAYERMOVER) 456 if (type == PLAYERMOVER)
447 { 457 {
448 if (!move_type) 458 if (!move_type)
… …
453 stats.maxhp = 0; 463 stats.maxhp = 0;
454 } 464 }
455 else 465 else
456 move_type = MOVE_WALK; 466 move_type = MOVE_WALK;
457 } 467 }
468 }
469
470 // if the object has an animation, try to provide a default face
471 if (has_anim ())
472 {
473 const animation &anim_ob = anim ();
474
475 if (anim_speed)
476 // if this item is time-animated, force the last frame
477 animate_object (this, 0);
478 else if (flag [FLAG_MONSTER])
479 // if it is a monster, set appropriate facing
480 animate_object (this, direction);
458 } 481 }
459} 482}
460 483
461static void 484static void
462set_move (MoveType &mt, const char *str) 485set_move (MoveType &mt, const char *str)
… …
510 533
511 goto next; 534 goto next;
512 } 535 }
513 } 536 }
514 537
515 LOG (llevDebug, "common/loader.C: set_move - unknown move string '%s'\n", str); 538 LOG (llevError, "common/loader.C: set_move - unknown move string '%s'\n", str);
516 539
517next: ; 540next: ;
518 } 541 }
519} 542}
543
544//-GPL
520 545
521#define GET_FLAG(op,flg) op->flag [flg] = f.get_bool () 546#define GET_FLAG(op,flg) op->flag [flg] = f.get_bool ()
522 547
523bool 548bool
524object::parse_kv (object_thawer &f) 549object::parse_kv (object_thawer &f)
525{ 550{
526 object *op_inv = inv; 551 object *op_inv = inv;
552 key_value *last_kv = key_values;
527 553
528 for (;;) 554 for (;;)
529 { 555 {
530 switch (f.kw) 556 switch (f.kw)
531 { 557 {
532 case KW_uuid: 558 case KW_uuid:
533 if (const char *s = f.get_str ()) 559 if (const char *s = f.get_str ())
534 { 560 if (!uuid.parse (s))
535 unsigned int version;
536 unsigned long long seq;
537
538 if (2 == sscanf (s, "<%d.%llx>", &version, &seq) && version == 1)
539 { 561 {
540 uuid.seq = seq; 562 f.parse_warn ("unparseable uuid");
541 break; 563 uuid = UUID::gen ();
542 } 564 }
543 }
544
545 uuid = gen_uuid ();
546 break; 565 break;
547 566
548 case KW_oid: 567 case KW_oid:
549 f.get (this, f.get_sint32 ()); 568 f.get (this, f.get_sint32 ());
550 break; 569 break;
… …
556 575
557 case KW_attach: f.get_ornull (attach); break; 576 case KW_attach: f.get_ornull (attach); break;
558 case KW_skill: f.get_ornull (skill); break; 577 case KW_skill: f.get_ornull (skill); break;
559 case KW_race: f.get_ornull (race); break; 578 case KW_race: f.get_ornull (race); break;
560 case KW_slaying: f.get_ornull (slaying); break; 579 case KW_slaying: f.get_ornull (slaying); break;
580 case KW_tag: f.get_ornull (tag); break;
561 581
562 case KW_arch: 582 case KW_arch:
563 {
564 object *tmp = object::read (f); 583 if (object *tmp = object::read (f))
565 tmp->deactivate ();
566
567 { 584 {
585 tmp->deactivate ();
586
568 // was: insert_ob_in_ob (tmp, op); 587 // was: insert_ob_in_ob (tmp, op);
569 // but manually adding it can improve map loading times a lot 588 // but manually adding it can improve map loading times a lot
570 // also, appending instead of prepending keeps the 589 // also, appending instead of prepending keeps the
571 // save ordering the same between repeated load/saves. 590 // save ordering the same between repeated load/saves.
591 // and finally we do not want any funny effects
572 CLEAR_FLAG (tmp, FLAG_OBJ_ORIGINAL); 592 CLEAR_FLAG (tmp, FLAG_OBJ_ORIGINAL);
573 CLEAR_FLAG (tmp, FLAG_REMOVED); 593 CLEAR_FLAG (tmp, FLAG_REMOVED);
574 594
575 if (!op_inv) 595 if (!op_inv)
576 { 596 {
… …
588 608
589 tmp->below = 0; 609 tmp->below = 0;
590 tmp->env = this; 610 tmp->env = this;
591 op_inv = tmp; 611 op_inv = tmp;
592 } 612 }
593 } 613 else
614 LOG (llevError, "ERROR: couldn't load inventory object, file corrupted?\n");
615
594 continue; 616 continue;
595 617
596 case KW_other_arch: 618 case KW_other_arch:
597 other_arch =
598 loading_arch 619 if (loading_arch == this)
599 ? archetype::get (f.get_str ()) 620 archetype::postpone_arch_ref (loading_arch->other_arch, f.get_str ());
621 else
622 {
600 : archetype::find (f.get_str ()); 623 other_arch = archetype::find (f.get_str ());
601 624
602 if (!other_arch) 625 if (!other_arch)
603 LOG (llevError, "%s uses unknown other_arch '%s'.\n", debug_desc (), f.get_str ()); 626 f.parse_warn (format ("%s uses unknown other_arch '%s'.\n", debug_desc (), f.get_str ()));
627 }
628 break;
629
630 case KW_owner:
631 f.delayed_deref (this, owner, f.get_str ());
604 break; 632 break;
605 633
606 case KW_animation: 634 case KW_animation:
607 { 635 {
608 CLEAR_FLAG (this, FLAG_ANIMATE); 636 CLEAR_FLAG (this, FLAG_ANIMATE);
609 animation_id = 0; 637 animation_id = 0;
610 638
611 const char *str = f.get_str (); 639 const char *str = f.get_str ();
612 if (str && (animation_id = find_animation (str))) 640 if (str && (animation_id = find_animation (str)))
613 SET_FLAG (this, FLAG_ANIMATE); 641 SET_FLAG (this, FLAG_ANIMATE); //TODO: should not be forced to true here
614 } 642 }
615 break; 643 break;
616 644
617 case KW_last_heal: f.get (last_heal); break; 645 case KW_last_heal: f.get (last_heal); break;
618 case KW_last_sp: f.get (last_sp); break; 646 case KW_last_sp: f.get (last_sp); break;
… …
639 face = face_find (f.get_str ()); 667 face = face_find (f.get_str ());
640 break; 668 break;
641 669
642 case KW_sound: 670 case KW_sound:
643 sound = sound_find (f.get_str ()); 671 sound = sound_find (f.get_str ());
672 if (!sound)
673 f.parse_warn ("sound not found");
644 break; 674 break;
645 675
646 case KW_sound_destroy: 676 case KW_sound_destroy:
647 sound_destroy = sound_find (f.get_str ()); 677 sound_destroy = sound_find (f.get_str ());
678 if (!sound_destroy)
679 f.parse_warn ("sound not found");
648 break; 680 break;
649 681
650 case KW_x: f.get (x); break; 682 case KW_x: f.get (x); break;
651 case KW_y: f.get (y); break; 683 case KW_y: f.get (y); break;
652 684
… …
803 case KW_is_turnable: GET_FLAG (this, FLAG_IS_TURNABLE); break; 835 case KW_is_turnable: GET_FLAG (this, FLAG_IS_TURNABLE); break;
804 case KW_is_used_up: GET_FLAG (this, FLAG_IS_USED_UP); break; 836 case KW_is_used_up: GET_FLAG (this, FLAG_IS_USED_UP); break;
805 case KW_alive: GET_FLAG (this, FLAG_ALIVE); break; 837 case KW_alive: GET_FLAG (this, FLAG_ALIVE); break;
806 case KW_applied: GET_FLAG (this, FLAG_APPLIED); break; 838 case KW_applied: GET_FLAG (this, FLAG_APPLIED); break;
807 case KW_unpaid: GET_FLAG (this, FLAG_UNPAID); break; 839 case KW_unpaid: GET_FLAG (this, FLAG_UNPAID); break;
840 case KW_player_sold: GET_FLAG (this, FLAG_PLAYER_SOLD); break;
808 case KW_is_animated: GET_FLAG (this, FLAG_ANIMATE); break; 841 case KW_is_animated: GET_FLAG (this, FLAG_ANIMATE); break;
809 case KW_no_pick: GET_FLAG (this, FLAG_NO_PICK); break; 842 case KW_no_pick: GET_FLAG (this, FLAG_NO_PICK); break;
810 case KW_reflecting: GET_FLAG (this, FLAG_REFLECTING); break; 843 case KW_reflecting: GET_FLAG (this, FLAG_REFLECTING); break;
811 case KW_changing: GET_FLAG (this, FLAG_CHANGING); break; 844 case KW_changing: GET_FLAG (this, FLAG_CHANGING); break;
812 case KW_splitting: GET_FLAG (this, FLAG_SPLITTING); break; 845 case KW_splitting: GET_FLAG (this, FLAG_SPLITTING); break;
… …
912 case KW_anim_speed: f.get (anim_speed); break; 945 case KW_anim_speed: f.get (anim_speed); break;
913 case KW_container: f.get (weight_limit); break; 946 case KW_container: f.get (weight_limit); break;
914 case KW_will_apply: f.get (will_apply); break; 947 case KW_will_apply: f.get (will_apply); break;
915 case KW_attack_movement: f.get (attack_movement); break; 948 case KW_attack_movement: f.get (attack_movement); break;
916 case KW_move_state: f.get (move_status); break; 949 case KW_move_state: f.get (move_status); break;
917 case KW_expmul: f.get (expmul); break; 950 //case KW_expmul: f.get (expmul); break;//D declared const for the time being
918 case KW_glow_radius: f.get (glow_radius); break; 951 case KW_glow_radius: f.get (glow_radius); break;
919 case KW_weapontype: f.get (weapontype); break; 952 case KW_weapontype: f.get (weapontype); break;
920 case KW_tooltype: f.get (tooltype); break;
921 case KW_casting_time: f.get (casting_time); break; 953 case KW_casting_time: f.get (casting_time); break;
954
955 // elevation is deprecated
922 case KW_elevation: f.get (elevation); break; 956 case KW_elevation: break;
957
923 case KW_smoothlevel: f.get (smoothlevel); smoothlevel = clamp (smoothlevel, 0, 255); break; 958 case KW_smoothlevel: f.get (smoothlevel); smoothlevel = clamp (smoothlevel, 0, 255); break;
924 case KW_client_type: f.get (client_type); break; 959 case KW_client_type: f.get (client_type); break;
925 case KW_duration: f.get (duration); break; 960 case KW_duration: f.get (duration); break;
926 case KW_range: f.get (range); break; 961 case KW_range: f.get (range); break;
927 case KW_range_modifier: f.get (range_modifier); break; 962 case KW_range_modifier: f.get (range_modifier); break;
… …
946 case KW_body_waist: slot[body_waist] .info = f.get_sint32 (); break; 981 case KW_body_waist: slot[body_waist] .info = f.get_sint32 (); break;
947 case KW_can_apply: 982 case KW_can_apply:
948 break; 983 break;
949 984
950 case KW_connected: 985 case KW_connected:
951 add_button_link (this, map, f.get_sint32 ()); 986 {
987 shstr connected;
988
989 f.get (connected);
990 add_link (map, connected);
991 }
952 break; 992 break;
953 993
954 case KW_randomitems: 994 case KW_randomitems:
955 if (f.get_str ()) 995 if (f.get_str ())
956 { 996 {
… …
958 loading_arch 998 loading_arch
959 ? treasurelist::get (f.get_str ()) 999 ? treasurelist::get (f.get_str ())
960 : treasurelist::find (f.get_str ()); 1000 : treasurelist::find (f.get_str ());
961 1001
962 if (!randomitems) 1002 if (!randomitems)
1003 {
963 LOG (llevError, "%s uses unknown randomitems '%s'.\n", debug_desc (), f.get_str ()); 1004 LOG (llevError, "%s uses unknown randomitems '%s'.\n", debug_desc (), f.get_str ());
1005 randomitems = treasurelist::get (shstr_none); // avoid crashes
1006 }
964 } 1007 }
965 else 1008 else
966 randomitems = 0; 1009 randomitems = 0;
967 break; 1010 break;
968 1011
… …
984 1027
985 f.next (); 1028 f.next ();
986 return true; 1029 return true;
987 1030
988 case KW_ERROR: 1031 case KW_ERROR:
989 set_ob_key_value (this, f.kw_str, f.value, true); 1032 // append as key value pair (do not use kv_set as it prepends)
1033 // we also do not even try to find old values, duplicate keys stay duplicate
1034 {
1035 key_value *kv = new key_value;
1036
1037 kv->next = 0;
1038 kv->key = shstr (f.kw_str);
1039 kv->value = shstr (f.value);
1040
1041 if (!last_kv)
1042 key_values = last_kv = kv;
1043 else
1044 {
1045 while (last_kv->next)
1046 last_kv = last_kv->next;
1047
1048 last_kv->next = kv;
1049 last_kv = kv;
1050 }
1051 }
990 //fprintf (stderr, "addkv(%s,%s)\n", f.kw_str, f.value);//D 1052 //fprintf (stderr, "addkv(%s,%s)\n", f.kw_str, f.value);//D
991 break; 1053 break;
992 1054
993 default: 1055 default:
994 if (!f.parse_error ("object", name)) 1056 if (!f.parse_error ("object", name))
… …
1008 archetype *arch = archetype::find (f.get_str ()); 1070 archetype *arch = archetype::find (f.get_str ());
1009 1071
1010 if (!arch) 1072 if (!arch)
1011 { 1073 {
1012 LOG (llevError, "object refering to nonexistant archetype '%s'.\n", f.get_str ()); 1074 LOG (llevError, "object refering to nonexistant archetype '%s'.\n", f.get_str ());
1013 arch = archetype::find ("earthwall"); 1075 arch = archetype::find (shstr_earthwall);
1014 } 1076 }
1015 1077
1016 assert (arch); //D maybe use exception handling of sorts? 1078 assert (arch); //D maybe use exception handling of sorts?
1017 1079
1018 f.next (); 1080 f.next ();
1019 1081
1020 object *op = object::create (); 1082 object *op = arch->instance ();
1021
1022 op->map = map; 1083 op->map = map;
1023 arch->copy_to (op);
1024 // copy_to activates, this should be fixed properly 1084 // instance() activates, this should be fixed properly
1025 op->deactivate (); 1085 op->deactivate ();
1026 1086
1027 if (!op->parse_kv (f)) 1087 if (!op->parse_kv (f))
1028 { 1088 {
1029 op->destroy (true); 1089 op->destroy ();
1030 return 0; 1090 return 0;
1031 } 1091 }
1032 1092
1033 op->post_load_check (); 1093 op->post_load_check ();
1034 return op; 1094 return op;
… …
1043int 1103int
1044set_variable (object *op, char *buf) 1104set_variable (object *op, char *buf)
1045{ 1105{
1046 object_thawer f (buf, (AV *)0); 1106 object_thawer f (buf, (AV *)0);
1047 1107
1048 f.next ();
1049 return op->parse_kv (f); 1108 return op->parse_kv (f);
1050} 1109}
1051 1110
1052/* This returns a string of the integer movement type */
1053#if 0
1054// unused function
1055static char *
1056get_string_move_type (MoveType mt)
1057{
1058 static char retbuf[MAX_BUF], retbuf_all[MAX_BUF];
1059 int i, all_count = 0, count;
1060
1061 strcpy (retbuf, "");
1062 strcpy (retbuf_all, " all");
1063
1064 /* Quick check, and probably fairly common */
1065 if (mt == MOVE_ALL)
1066 return retbuf_all + 1;
1067 if (mt == 0)
1068 {
1069 strcpy (retbuf, "0");
1070 return retbuf;
1071 }
1072
1073 /* We basically slide the bits down. Why look at MOVE_ALL?
1074 * because we may want to return a string like 'all -swim',
1075 * and if we just looked at mt, we couldn't get that.
1076 */
1077 for (i = MOVE_ALL, count = 0; i != 0; i >>= 1, count++)
1078 {
1079 if (mt & (1 << count))
1080 {
1081 strcat (retbuf, " ");
1082 strcat (retbuf, move_name[count]);
1083 }
1084 else
1085 {
1086 strcat (retbuf_all, " -");
1087 strcat (retbuf_all, move_name[count]);
1088 all_count++;
1089 }
1090 }
1091 /* Basically, if there is a single negation, return it, eg
1092 * 'all -swim'. But more than that, just return the
1093 * enumerated values. It doesn't make sense to return
1094 * 'all -walk -fly_low' - it is shorter to return 'fly_high swim'
1095 */
1096 if (all_count <= 1)
1097 return retbuf_all + 1;
1098 else
1099 return retbuf + 1;
1100}
1101#endif
1102
1103// compare *op against *tmp and output differences 1111// compare *op against *arch and output differences
1104static void 1112static void
1105write_diff (object_freezer &f, object *op, object *tmp) 1113write_diff (object_freezer &f, object *op, object *arch)
1106{ 1114{
1107 static const keyword resist_save[NROFATTACKS] = { 1115 static const keyword resist_save[NROFATTACKS] = {
1108# define def(uc, lc, name, plus, change) KW_resist_ ## lc, 1116# define def(uc, lc, name, plus, change) KW_resist_ ## lc,
1109# include "attackinc.h" 1117# include "attackinc.h"
1110# undef def 1118# undef def
… …
1240 /* 110 */ 1248 /* 110 */
1241 KW_destroy_on_death, 1249 KW_destroy_on_death,
1242 KW_NULL, 1250 KW_NULL,
1243 }; 1251 };
1244 1252
1245 int i;
1246
1247 /* This saves the key/value lists. We do it first so that any 1253 /* This saves the key/value lists. We do it first so that any
1248 * keys that match field names will be overwritten by the loader. 1254 * keys that match field names will be overwritten by the loader.
1249 */ 1255 */
1250 for (key_value *my_field = op->key_values; my_field; my_field = my_field->next) 1256 for (key_value *kv = op->key_values; kv; kv = kv->next)
1251 { 1257 if (!arch->key_values || arch->kv (kv->key) != kv->value)
1252 /* Find the field in the opposing member. */ 1258 f.put (kv->key, kv->value);
1253 key_value *arch_field = get_ob_key_link (tmp, my_field->key);
1254 1259
1255 /* If there's no partnering field, or it's got a different value, save our field. */ 1260 if (op->uuid)
1256 if (!arch_field || my_field->value != arch_field->value)
1257 f.put (my_field->key, my_field->value);
1258 } 1261 {
1262 // highly optimised - this is often 25% of all data written
1263 char *cur = f.force (sizeof ("uuid ") + UUID::MAX_LEN + 1);
1264 char *ptr = cur;
1259 1265
1260 /* We don't need to worry about the arch's extra fields - they 1266 memcpy (ptr, "uuid ", sizeof ("uuid ") - 1);
1261 * will get taken care of the copy_to method. 1267 ptr += sizeof ("uuid ") - 1;
1262 */ 1268 ptr = op->uuid.append (ptr);
1269 *ptr++ = '\n';
1263 1270
1264 { 1271 f.alloc (ptr - cur);
1265 char uids[64];
1266 snprintf (uids, sizeof (uids), "<1.%llx>", (unsigned long long)op->uuid.seq);
1267 f.put (KW_uuid, (const char *)uids);
1268 } 1272 }
1269 1273
1270#define CMP_OUT(v) if (op->v != tmp->v) f.put (KW_ ## v, op->v) 1274#define CMP_OUT(v) if (expect_false (op->v != arch->v)) f.put (KW_ ## v, op->v)
1271#define CMP_OUT2(k,v) if (op->v != tmp->v) f.put (KW_ ## k, op->v) 1275#define CMP_OUT2(k,v) if (expect_false (op->v != arch->v)) f.put (KW_ ## k, op->v)
1276
1277 CMP_OUT (x);
1278 CMP_OUT (y);
1279
1280 CMP_OUT (type);
1281 CMP_OUT (subtype);
1282 CMP_OUT (direction);
1272 1283
1273 CMP_OUT (name); 1284 CMP_OUT (name);
1274 CMP_OUT (name_pl); 1285 CMP_OUT (name_pl);
1275 CMP_OUT (custom_name); 1286
1287 CMP_OUT (speed);
1288 CMP_OUT (speed_left);
1289
1276 CMP_OUT (title); 1290 CMP_OUT (title);
1277 CMP_OUT (race); 1291 CMP_OUT (race);
1278 CMP_OUT (slaying); 1292 CMP_OUT (slaying);
1293 CMP_OUT (skill);
1294
1295 CMP_OUT (tag);
1296 CMP_OUT (custom_name);
1297
1298 if (object *owner = op->owner)
1299 f.put (KW_owner, static_cast<const char *>(owner->ref ()));
1300
1301 // memory, attacked_by, chosen_skill, spellitem, spell, current_weapon, arch not saved
1302
1279 CMP_OUT (other_arch); 1303 CMP_OUT (other_arch);
1280 1304
1281 if (op->msg != tmp->msg ) f.put (KW_msg , KW_endmsg , op->msg ); 1305 if (op->msg != arch->msg ) f.put (KW_msg , KW_endmsg , op->msg );
1282 if (op->lore != tmp->lore) f.put (KW_lore, KW_endlore, op->lore); 1306 if (op->lore != arch->lore) f.put (KW_lore, KW_endlore, op->lore);
1283 1307
1284 if (op->face != tmp->face ) f.put (KW_face , op->face ? &faces [op->face ] : 0); 1308 if (op->face != arch->face ) f.put (KW_face , op->face ? &faces [op->face ] : 0);
1285 if (op->sound != tmp->sound ) f.put (KW_sound , op->sound ? &faces [op->sound ] : 0); 1309 if (op->sound != arch->sound ) f.put (KW_sound , op->sound ? &faces [op->sound ] : 0);
1286 if (op->sound_destroy != tmp->sound_destroy) f.put (KW_sound_destroy, op->sound_destroy ? &faces [op->sound_destroy] : 0); 1310 if (op->sound_destroy != arch->sound_destroy) f.put (KW_sound_destroy, op->sound_destroy ? &faces [op->sound_destroy] : 0);
1287 1311
1288 if (op->animation_id != tmp->animation_id) 1312 if (op->animation_id != arch->animation_id)
1289 if (op->animation_id) 1313 if (op->has_anim ())
1314 f.put (KW_animation, op->anim ().name);
1315 else
1290 { 1316 {
1291 f.put (KW_animation, animations[GET_ANIM_ID (op)].name); 1317 f.put (KW_animation, (const char *)0);
1292 1318 op->flag [FLAG_ANIMATE] = false; // TODO: why force to false here?
1293 if (!QUERY_FLAG (op, FLAG_ANIMATE))
1294 f.put (KW_is_animated, (sint32)0);
1295 } 1319 }
1296 else
1297 f.put (KW_animation, (const char *)0);
1298 1320
1299 CMP_OUT2 (str, stats.Str); 1321 CMP_OUT2 (str, stats.Str);
1300 CMP_OUT2 (dex, stats.Dex); 1322 CMP_OUT2 (dex, stats.Dex);
1301 CMP_OUT2 (con, stats.Con); 1323 CMP_OUT2 (con, stats.Con);
1302 CMP_OUT2 (wis, stats.Wis); 1324 CMP_OUT2 (wis, stats.Wis);
… …
1311 CMP_OUT2 (grace, stats.grace); 1333 CMP_OUT2 (grace, stats.grace);
1312 CMP_OUT2 (maxgrace, stats.maxgrace); 1334 CMP_OUT2 (maxgrace, stats.maxgrace);
1313 CMP_OUT2 (exp, stats.exp); 1335 CMP_OUT2 (exp, stats.exp);
1314 1336
1315 CMP_OUT (perm_exp); 1337 CMP_OUT (perm_exp);
1316 CMP_OUT (expmul); 1338 //CMP_OUT (expmul);
1317 1339
1318 CMP_OUT2 (food, stats.food); 1340 CMP_OUT2 (food, stats.food);
1319 CMP_OUT2 (dam, stats.dam); 1341 CMP_OUT2 (dam, stats.dam);
1320 CMP_OUT2 (luck, stats.luck); 1342 CMP_OUT2 (luck, stats.luck);
1321 CMP_OUT2 (wc, stats.wc); 1343 CMP_OUT2 (wc, stats.wc);
1322 CMP_OUT2 (ac, stats.ac); 1344 CMP_OUT2 (ac, stats.ac);
1323 1345
1324 CMP_OUT (x);
1325 CMP_OUT (y);
1326 CMP_OUT (speed);
1327 CMP_OUT (speed_left);
1328 CMP_OUT2 (move_state, move_status); 1346 CMP_OUT2 (move_state, move_status);
1329 CMP_OUT (attack_movement); 1347 CMP_OUT (attack_movement);
1330 CMP_OUT (nrof); 1348 CMP_OUT (nrof);
1331 CMP_OUT (level); 1349 CMP_OUT (level);
1332 CMP_OUT (direction);
1333 CMP_OUT (type);
1334 CMP_OUT (subtype);
1335 CMP_OUT (attacktype); 1350 CMP_OUT (attacktype);
1336 1351
1352 // using memcmp here seems to be a loss - us gcc vectorising?
1337 for (i = 0; i < NROFATTACKS; i++) 1353 for (int i = 0; i < NROFATTACKS; i++)
1338 if (op->resist[i] != tmp->resist[i]) 1354 if (expect_false (op->resist[i] != arch->resist[i]))
1339 f.put (resist_save[i], op->resist[i]); 1355 f.put (resist_save[i], op->resist[i]);
1340 1356
1341 CMP_OUT (path_attuned); 1357 CMP_OUT (path_attuned);
1342 CMP_OUT (path_repelled); 1358 CMP_OUT (path_repelled);
1343 CMP_OUT (path_denied); 1359 CMP_OUT (path_denied);
… …
1353 CMP_OUT (last_sp); 1369 CMP_OUT (last_sp);
1354 CMP_OUT (last_grace); 1370 CMP_OUT (last_grace);
1355 CMP_OUT (last_eat); 1371 CMP_OUT (last_eat);
1356 CMP_OUT (glow_radius); 1372 CMP_OUT (glow_radius);
1357 1373
1358 if (QUERY_FLAG (op, FLAG_IS_LINKED) && (i = get_button_value (op))) 1374 if (op->flag [FLAG_IS_LINKED])
1375 if (auto (ol, op->find_link ()))
1359 f.put (KW_connected, i); 1376 f.put (KW_connected, ol->id);
1360 1377
1361 CMP_OUT (randomitems); 1378 CMP_OUT (randomitems);
1362 CMP_OUT2 (container, weight_limit); 1379 CMP_OUT2 (container, weight_limit);
1363 1380
1364 CMP_OUT (run_away); 1381 CMP_OUT (run_away);
1365 CMP_OUT (pick_up); 1382 CMP_OUT (pick_up);
1366 CMP_OUT (will_apply); 1383 CMP_OUT (will_apply);
1367 CMP_OUT (smoothlevel); 1384 CMP_OUT (smoothlevel);
1368 CMP_OUT (weapontype); 1385 CMP_OUT (weapontype);
1369 CMP_OUT (tooltype);
1370 CMP_OUT (elevation);
1371 CMP_OUT (client_type); 1386 CMP_OUT (client_type);
1372 CMP_OUT (item_power); 1387 CMP_OUT (item_power);
1373 CMP_OUT (duration); 1388 CMP_OUT (duration);
1374 CMP_OUT (range); 1389 CMP_OUT (range);
1375 CMP_OUT (range_modifier); 1390 CMP_OUT (range_modifier);
… …
1383 CMP_OUT (move_on); 1398 CMP_OUT (move_on);
1384 CMP_OUT (move_off); 1399 CMP_OUT (move_off);
1385 CMP_OUT (move_slow); 1400 CMP_OUT (move_slow);
1386 CMP_OUT (move_slow_penalty); 1401 CMP_OUT (move_slow_penalty);
1387 1402
1388 if (op->flag != tmp->flag) 1403 // obj_original is the only commonly differing flag between archetype
1404 // and object, so special-case it here to be able to skip the loop
1405 object::flags_t diff = op->flag ^ arch->flag;
1406
1407 if (expect_true (diff.any ()))
1408 {
1409 if (expect_false (diff.reset (FLAG_OBJ_ORIGINAL).any ()) || 1)
1410 {
1411 // some other flags differ, too
1389 for (i = 0; i <= NUM_FLAGS; i++) 1412 for (int i = 0; i < NUM_FLAGS; i++)
1390 if (flag_names [i] && op->flag [i] != tmp->flag [i]) 1413 if (expect_false (flag_names [i] && op->flag [i] != arch->flag [i]))
1391 f.put (flag_names [i], op->flag [i] ? "1" : "0"); 1414 f.put (flag_names [i], op->flag [i] ? "1" : "0");
1415 }
1416 else
1417 {
1418 // only obj_original differs
1419 f.put (flag_names [FLAG_OBJ_ORIGINAL], op->flag [FLAG_OBJ_ORIGINAL] ? "1" : "0");
1420 }
1421 }
1392 1422
1393 // save body locations 1423 // save body locations. gcc's memcmp does an abysmal job when used
1394 for (i = 0; i < NUM_BODY_LOCATIONS; i++) 1424 for (int i = 0; i < NUM_BODY_LOCATIONS; i++)
1395 if (op->slot[i].info != tmp->slot[i].info) 1425 if (expect_false (op->slot[i].info != arch->slot[i].info))
1396 f.put (body_locations[i].save_name, op->slot[i].info); 1426 f.put (body_locations[i].save_name, op->slot[i].info);
1397} 1427}
1398 1428
1399/* 1429/*
1400 * Dumps all variables in an object to a file. 1430 * Dumps all variables in an object to a file.
… …
1402 * the only place this is not set is when saving the player. 1432 * the only place this is not set is when saving the player.
1403 */ 1433 */
1404bool 1434bool
1405object::write (object_freezer &f) 1435object::write (object_freezer &f)
1406{ 1436{
1407 /* Even if the object does have an owner, it would seem that we should 1437 if (is_arch ())
1408 * still save it. 1438 {
1409 */ 1439 f.put (KW_object, arch->archname);
1410 if (owner) 1440 write_diff (f, this, archetype::empty);
1411 return true; 1441 }
1412 1442 else
1413 archetype *at = arch ? (archetype *)arch : empty_archetype; 1443 {
1414
1415 f.put (KW_arch, at->archname); 1444 f.put (KW_arch, arch->archname);
1416 write_diff (f, this, at); 1445 write_diff (f, this, arch);
1446 }
1417 1447
1418 for (object *tmp = inv; tmp; tmp = tmp->below) 1448 for (object *tmp = inv; tmp; tmp = tmp->below)
1419 tmp->write (f); 1449 tmp->write (f);
1420 1450
1421 f.put (this); 1451 f.put (this);
… …
1426 1456
1427///////////////////////////////////////////////////////////////////////////// 1457/////////////////////////////////////////////////////////////////////////////
1428 1458
1429// generic resource file load, 1459// generic resource file load,
1430// currently supports: region, treasures, archetypes 1460// currently supports: region, treasures, archetypes
1461bool
1431bool load_resource_file (const char *filename) 1462load_resource_file_ (const char *filename)
1432{ 1463{
1433 object_thawer f (filename); 1464 object_thawer f (filename);
1434
1435 bool success = false;
1436 bool seen_arch = false;
1437
1438 f.next ();
1439 1465
1440 for (;;) 1466 for (;;)
1441 { 1467 {
1442 switch (f.kw) 1468 switch (f.kw)
1443 { 1469 {
1444 case KW_region: 1470 case KW_region:
1445 if (!region::read (f)) 1471 if (!region::read (f))
1446 goto finish; 1472 return false;
1447 break; 1473 break;
1448 1474
1449 case KW_treasure: 1475 case KW_treasure:
1450 case KW_treasureone: 1476 case KW_treasureone:
1451 if (!treasurelist::read (f)) 1477 if (!treasurelist::read (f))
1452 goto finish; 1478 return false;
1453 break; 1479 break;
1454 1480
1455 case KW_object: 1481 case KW_object:
1456 seen_arch = true;
1457 if (!archetype::read (f)) 1482 if (!archetype::read (f))
1458 goto finish; 1483 return false;
1459 break; 1484 break;
1460 1485
1461 case KW_EOF: 1486 case KW_EOF:
1462 success = true; 1487 return true;
1463 goto finish;
1464 1488
1465 default: 1489 default:
1466 if (!f.parse_error ("resource file")) 1490 if (!f.parse_error ("resource file"))
1467 goto finish; 1491 return false;
1468 1492
1469 f.next (); 1493 f.next ();
1470 break; 1494 break;
1471 } 1495 }
1472 } 1496 }
1473
1474finish:
1475 if (seen_arch)
1476 init_archetype_pointers ();
1477
1478 return success;
1479} 1497}
1480 1498

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines