--- deliantra/server/common/loader.l 2006/05/11 19:07:40 1.3 +++ deliantra/server/common/loader.l 2006/08/13 17:16:00 1.7 @@ -59,7 +59,7 @@ * NULL entries in this table are valid - to denote objects that should * not be updated for whatever reason. */ -const char *const spell_mapping[] = { +const char *spell_mapping[] = { "spell_magic_bullet", /* 0 */ "spell_small_fireball", /* 1 */ "spell_medium_fireball", /* 2 */ @@ -335,17 +335,17 @@ char info2[256 * 3]; char *p = info; - p += snprintf (p, 256, "%s%s%s=%d", + p += snprintf (p, 256, "%d=\"%s%s%s\"", + op->count, op->name ? op->name : "(anon)", op->title ? " " : "", - op->title ? op->title : "", - op->count); + op->title ? op->title : ""); if (op->env) p += snprintf (p, 256, "(in %s)", op_debug_info_ (op->env, info2)); if (op->map) - p += snprintf (p, 256, "(%d+%d@%s)", op->x, op->y, op->map->path); + p += snprintf (p, 256, "(on %s@%d+%d)", op->map->path, op->x, op->y); return info; } @@ -645,13 +645,17 @@ ^msg{WS}$ { BEGIN( MESSAGE ); msgbuf[0]='\0'; } ^endmsg{WS}$ { BEGIN( INITIAL ); - op->msg=add_string(msgbuf); /* Just print a warning so we can be reasonably safe * about not overflowing the buffer. */ - if (strlen(op->msg) > (HUGE_BUF/2)) - LOG(llevDebug, "\n\tWarning message length > %d (max allowed=%d): %d\n>%.80s<\n", - HUGE_BUF/2, HUGE_BUF, strlen(op->msg),op->msg); + if (strlen(msgbuf) >= HUGE_BUF) + { + LOG(llevDebug, "\n\tError message length >= %d: %d\n>%.80s<\n", + HUGE_BUF, strlen(op->msg),op->msg); + op->msg = add_string ("ERROR, please report: string too long, winged.\n"); + } + else + op->msg = add_string (msgbuf); } .* {strcat(msgbuf, yytext); strcat(msgbuf,"\n"); } @@ -982,7 +986,7 @@ /* Old style resistances */ ^immune{S} set_protection(op, IVAL, RESIST_IMMUNE); ^protected{S} set_protection(op, IVAL, RESIST_PROT); -^vulnerable{S} set_protection(op, IVAL, RESIST_VULN); +^vulnerable{S} set_protection(op, IVAL, (uint16) RESIST_VULN); /* old values - keep them around for now, but they should be removed at some point */ ^has_ready_rod{S} SET_OR_CLEAR_FLAG(op, FLAG_READY_RANGE, IVAL); @@ -1031,7 +1035,7 @@ ^can_dam_armour{S} { } ^weapontype{S} op->weapontype = IVAL; ^tooltype{S} op->tooltype = IVAL; -^casting_time{S} op->casting_time = FVAL; +^casting_time{S} op->casting_time = (sint16) FVAL; ^elevation{S} op->elevation = IVAL; ^smoothlevel{S} op->smoothlevel = IVAL; ^client_type{S} op->client_type = IVAL; @@ -1645,17 +1649,11 @@ */ static int already_run = 0; static int flag_lens[NUM_FLAGS]; - static char buf2[HUGE_BUF]; - static char buf[HUGE_BUF]; - char* fastbuf; + char buf2[4096]; // / was HUFE_BUF, which was hugely incorrect, as is this value, but much less so + static char buf[128*1024]; // < the assumption is that every object always fits. fixing this bug, however + char* fastbuf; // \ requires a large rewrite of the code, so its left to the next total rewrite. int tmp; int i; -#if 0 -/*Memory polluting code. Should help detect problems, very slow*/ - for (i=0;imove_slow_penalty != op2->move_slow_penalty) { - FAST_SAVE_LONG(fastbuf,"move_slow_penalty ",op->move_slow_penalty,18); + FAST_SAVE_LONG(fastbuf,"move_slow_penalty ",(long) op->move_slow_penalty,18); } if (!COMPARE_FLAGS(op,op2)) {