[ViewVC] Diff of: cvs/deliantra/server/common/map.C

Comparing deliantra/server/common/map.C (file contents):
Revision 1.147 by root, Mon Sep 29 10:20:48 2008 UTC vs.
Revision 1.154 by root, Wed Dec 24 01:37:24 2008 UTC

 #include <unistd.h>
 #include "global.h"
 #include "loader.h"
 #include "path.h"
+sint8 maptile::outdoor_darkness;
 /* This rolls up wall, blocks_magic, blocks_view, etc, all into
  * one function that just returns a P_.. value (see map.h)
  * it will also do map translation for tiled maps, returning
  * new values into newmap, nx, and ny.  Any and all of those
                     ms.flags_ = 0;
                   }
                 else
                   {
                     f.parse_warn (format ("object %s out of range", op->debug_desc ()));
-                    op->destroy_inv (false); // be explicit about dropping
-                    op->destroy (true);
+                    op->destroy ();
                   }
               }
             continue;
           if (QUERY_FLAG (op, FLAG_IS_FLOOR) && QUERY_FLAG (op, FLAG_UNIQUE))
             unique = 1;
           if (op->head_ () == op && (QUERY_FLAG (op, FLAG_UNIQUE) || unique))
-            {
-              op->destroy_inv (false);
-              op->destroy (true);
+            op->destroy ();
-            }
           op = above;
         }
     }
 }
             op->flag [FLAG_REMOVED] = true;
             object *head = op->head_ ();
             if (op == head)
-              {
-                op->destroy_inv (false);
-                op->destroy (true);
+              op->destroy ();
-              }
             else if (head->map != op->map)
               {
                 LOG (llevDebug, "bad luck for object crossing map borders: %s", head->debug_desc ());
-                head->destroy (true);
+                head->destroy ();
               }
           }
       sfree0 (spaces, size ());
     }
               destroy = 1;
           }
         /* adjust overall chance below */
         if (destroy && rndm (0, 1))
-          op->destroy (true);
+          op->destroy ();
       }
 }
 /*
  * Updates every button on the map (by calling update_button() for them).
 /*
  * This routine is supposed to find out the difficulty of the map.
  * difficulty does not have a lot to do with character level,
  * but does have a lot to do with treasure on the map.
  *
- * Difficulty can now be set by the map creature.  If the value stored
+ * Difficulty can now be set by the map creator. If the value stored
- * in the map is zero, then use this routine.  Maps should really
+ * in the map is zero, then use this routine. Maps should really
- * have a difficulty set than using this function - human calculation
+ * have a difficulty set rather than using this function - human calculation
- * is much better than this functions guesswork.
+ * is much better than this function's guesswork.
  */
 int
 maptile::estimate_difficulty () const
 {
   long monster_cnt = 0;
  * postive values make it darker, negative make it brighter
  */
 int
 maptile::change_map_light (int change)
 {
-  int new_level = darkness + change;
   /* Nothing to do */
-  if (!change || (new_level <= 0 && darkness == 0) || (new_level >= MAX_DARKNESS && darkness >= MAX_DARKNESS))
+  if (!change)
     return 0;
   /* inform all players on the map */
   if (change > 0)
     new_info_map (NDI_BLACK | NDI_UNIQUE, this, "It becomes darker.");
   else
     new_info_map (NDI_BLACK | NDI_UNIQUE, this, "It becomes brighter.");
-  /* Do extra checking.  since darkness is a unsigned value,
+  darkness = clamp (darkness + change, -MAX_DARKNESS, MAX_DARKNESS);
-   * we need to be extra careful about negative values.
-   * In general, the checks below are only needed if change
-   * is not +/-1
-   */
-  if (new_level < 0)
-    darkness = 0;
-  else if (new_level >= MAX_DARKNESS)
-    darkness = MAX_DARKNESS;
-  else
-    darkness = new_level;
   /* All clients need to get re-updated for the change */
   update_all_map_los (this);
   return 1;
  */
 void
 mapspace::update_ ()
 {
   object *last = 0;
-  uint8 flags = P_UPTODATE, light = 0, anywhere = 0;
+  uint8 flags = P_UPTODATE, anywhere = 0;
+  sint8 light = 0;
   MoveType move_block = 0, move_slow = 0, move_on = 0, move_off = 0, move_allow = 0;
   //object *middle = 0;
   //object *top    = 0;
   //object *floor  = 0;
   object *&middle = faces_obj[1] = 0;
   object *&floor  = faces_obj[2] = 0;
   for (object *tmp = bot; tmp; last = tmp, tmp = tmp->above)
     {
-      /* This could be made additive I guess (two lights better than
+      // Lights are additive, up to MAX_LIGHT_RADIUS, see los.C)
-       * one). But if so, it shouldn't be a simple additive - 2
-       * light bulbs do not illuminate twice as far as once since
-       * it is a dissapation factor that is cubed.
-       */
-      light = max (light, tmp->glow_radius);
+      light += tmp->glow_radius;
       /* This call is needed in order to update objects the player
        * is standing in that have animations (ie, grass, fire, etc).
        * However, it also causes the look window to be re-drawn
        * 3 times each time the player moves, because many of the
       if (tmp->type == SAFE_GROUND)          flags |= P_SAFE;
       if (QUERY_FLAG (tmp, FLAG_ALIVE))      flags |= P_IS_ALIVE;
       if (QUERY_FLAG (tmp, FLAG_DAMNED))     flags |= P_NO_CLERIC;
     }
-  this->light      = light;
+  this->light      = min (light, MAX_LIGHT_RADIUS);
   this->flags_     = flags;
   this->move_block = move_block & ~move_allow;
   this->move_on    = move_on;
   this->move_off   = move_off;
   this->move_slow  = move_slow;
 maptile::play_sound (faceidx sound, int x, int y) const
 {
   if (!sound)
     return;
-  for_all_players (pl)
+  for_all_players_on_map (pl, this)
-    if (pl->ob->map == this)
-      if (client *ns = pl->ns)
+    if (client *ns = pl->ns)
-        {
+      {
-          int dx = x - pl->ob->x;
+        int dx = x - pl->ob->x;
-          int dy = y - pl->ob->y;
+        int dy = y - pl->ob->y;
-          int distance = idistance (dx, dy);
+        int distance = idistance (dx, dy);
-          if (distance <= MAX_SOUND_DISTANCE)
+        if (distance <= MAX_SOUND_DISTANCE)
-            ns->play_sound (sound, dx, dy);
+          ns->play_sound (sound, dx, dy);
-        }
+      }
 }

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing deliantra/server/common/map.C (file contents): Revision 1.147 by root, Mon Sep 29 10:20:48 2008 UTC vs. Revision 1.154 by root, Wed Dec 24 01:37:24 2008 UTC

Diff Legend

Comparing deliantra/server/common/map.C (file contents):
Revision 1.147 by root, Mon Sep 29 10:20:48 2008 UTC vs.
Revision 1.154 by root, Wed Dec 24 01:37:24 2008 UTC