ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/map.C
(Generate patch)

Comparing deliantra/server/common/map.C (file contents):
Revision 1.85 by root, Wed Feb 7 23:50:01 2007 UTC vs.
Revision 1.102 by root, Thu May 17 21:32:08 2007 UTC

1/* 1/*
2 * CrossFire, A Multiplayer game for X-windows 2 * CrossFire, A Multiplayer game
3 * 3 *
4 * Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team 4 * Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team
5 * Copyright (C) 2001-2003 Mark Wedel & Crossfire Development Team 5 * Copyright (C) 2001-2003 Mark Wedel & Crossfire Development Team
6 * Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (C) 1992 Frank Tore Johansen
7 * 7 *
… …
174 * let the player through (inventory checkers for example) 174 * let the player through (inventory checkers for example)
175 */ 175 */
176 if (!(mflags & P_IS_ALIVE) && !OB_TYPE_MOVE_BLOCK (ob, blocked)) 176 if (!(mflags & P_IS_ALIVE) && !OB_TYPE_MOVE_BLOCK (ob, blocked))
177 return 0; 177 return 0;
178 178
179 if (ob->head != NULL)
180 ob = ob->head; 179 ob = ob->head_ ();
181 180
182 /* We basically go through the stack of objects, and if there is 181 /* We basically go through the stack of objects, and if there is
183 * some other object that has NO_PASS or FLAG_ALIVE set, return 182 * some other object that has NO_PASS or FLAG_ALIVE set, return
184 * true. If we get through the entire stack, that must mean 183 * true. If we get through the entire stack, that must mean
185 * ob is blocking it, so return 0. 184 * ob is blocking it, so return 0.
… …
215 else 214 else
216 { 215 {
217 /* Broke apart a big nasty if into several here to make 216 /* Broke apart a big nasty if into several here to make
218 * this more readable. first check - if the space blocks 217 * this more readable. first check - if the space blocks
219 * movement, can't move here. 218 * movement, can't move here.
220 * second - if a monster, can't move there, unles it is a 219 * second - if a monster, can't move there, unless it is a
221 * hidden dm 220 * hidden dm
222 */ 221 */
223 if (OB_MOVE_BLOCK (ob, tmp)) 222 if (OB_MOVE_BLOCK (ob, tmp))
224 return 1; 223 return 1;
225 if (QUERY_FLAG (tmp, FLAG_ALIVE) && tmp->head != ob && tmp != ob && 224
226 tmp->type != DOOR && !(QUERY_FLAG (tmp, FLAG_WIZ) && tmp->contr->hidden)) 225 if (QUERY_FLAG (tmp, FLAG_ALIVE)
226 && tmp->head_ () != ob
227 && tmp != ob
228 && tmp->type != DOOR
229 && !tmp->flag [FLAG_WIZ]
230 && tmp->contr->hidden)
227 return 1; 231 return 1;
228 } 232 }
229 233
230 } 234 }
231 return 0; 235 return 0;
… …
344} 348}
345 349
346/* link_multipart_objects go through all the objects on the map looking 350/* link_multipart_objects go through all the objects on the map looking
347 * for objects whose arch says they are multipart yet according to the 351 * for objects whose arch says they are multipart yet according to the
348 * info we have, they only have the head (as would be expected when 352 * info we have, they only have the head (as would be expected when
349 * they are saved). We do have to look for the old maps that did save 353 * they are saved).
350 * the more sections and not re-add sections for them.
351 */ 354 */
352void 355void
353maptile::link_multipart_objects () 356maptile::link_multipart_objects ()
354{ 357{
355 if (!spaces) 358 if (!spaces)
356 return; 359 return;
357 360
358 for (mapspace *ms = spaces + size (); ms-- > spaces; ) 361 for (mapspace *ms = spaces + size (); ms-- > spaces; )
359 for (object *tmp = ms->bot; tmp; ) 362 for (object *op = ms->bot; op; op = op->above)
360 { 363 {
361 object *above = tmp->above;
362
363 /* already multipart - don't do anything more */ 364 /* already multipart - don't do anything more */
364 if (!tmp->head && !tmp->more) 365 if (op->head_ () == op && !op->more && op->arch->more)
365 { 366 {
366 /* If there is nothing more to this object, this for loop 367 op->remove ();
367 * won't do anything. 368 op->expand_tail ();
368 */
369 archetype *at;
370 object *last, *op;
371 for (at = tmp->arch->more, last = tmp;
372 at;
373 at = at->more, last = op)
374 {
375 op = arch_to_object (at);
376
377 /* update x,y coordinates */
378 op->x += tmp->x;
379 op->y += tmp->y;
380 op->head = tmp;
381 op->map = this;
382 last->more = op;
383 op->name = tmp->name;
384 op->title = tmp->title;
385
386 /* we could link all the parts onto tmp, and then just
387 * call insert_ob_in_map once, but the effect is the same,
388 * as insert_ob_in_map will call itself with each part, and
389 * the coding is simpler to just to it here with each part.
390 */
391 insert_ob_in_map (op, op->map, tmp, INS_NO_MERGE | INS_ABOVE_FLOOR_ONLY | INS_NO_WALK_ON); 369 insert (op, op->x, op->y, 0, INS_NO_MERGE | INS_ABOVE_FLOOR_ONLY | INS_NO_WALK_ON);
392 }
393 } 370 }
394
395 tmp = above;
396 } 371 }
397} 372}
398 373
399/* 374/*
400 * Loads (ands parses) the objects into a given map from the specified 375 * Loads (ands parses) the objects into a given map from the specified
401 * file pointer. 376 * file pointer.
402 * mapflags is the same as we get with load_original_map
403 */ 377 */
404bool 378bool
405maptile::_load_objects (object_thawer &thawer) 379maptile::_load_objects (object_thawer &f)
406{ 380{
407 int unique; 381 for (;;)
408 object *op, *prev = NULL, *last_more = NULL, *otmp;
409
410 op = object::create ();
411 op->map = this; /* To handle buttons correctly */
412
413 while (int i = load_object (thawer, op, 0))
414 { 382 {
415 /* if the archetype for the object is null, means that we 383 coroapi::cede_to_tick_every (100); // cede once in a while
416 * got an invalid object. Don't do anything with it - the game 384
417 * or editor will not be able to do anything with it either. 385 switch (f.kw)
418 */
419 if (op->arch == NULL)
420 { 386 {
421 LOG (llevDebug, "Discarding object without arch: %s\n", op->name ? (const char *) op->name : "(null)"); 387 case KW_arch:
422 continue; 388 if (object *op = object::read (f, this))
423 }
424
425 switch (i)
426 { 389 {
427 case LL_NORMAL: 390 if (op->inv)
391 sum_weight (op);
392
428 insert_ob_in_map (op, this, op, INS_NO_MERGE | INS_NO_WALK_ON | INS_ON_TOP | INS_MAP_LOAD); 393 insert_ob_in_map (op, this, op, INS_NO_MERGE | INS_NO_WALK_ON | INS_ON_TOP | INS_MAP_LOAD);
394 }
429 395
430 if (op->inv) 396 continue;
431 sum_weight (op);
432 397
433 prev = op, last_more = op;
434 break;
435
436 case LL_MORE: 398 case KW_EOF:
437 insert_ob_in_map (op, this, op, INS_NO_MERGE | INS_NO_WALK_ON | INS_ABOVE_FLOOR_ONLY); 399 return true;
438 op->head = prev, last_more->more = op, last_more = op; 400
401 default:
402 if (!f.parse_error ("map file"))
403 return false;
439 break; 404 break;
440 } 405 }
441 406
442 op = object::create (); 407 f.next ();
443 op->map = this;
444 }
445
446 op->destroy ();
447
448#if 0
449 for (i = 0; i < width; i++)
450 for (j = 0; j < height; j++)
451 {
452 unique = 0;
453 /* check for unique items, or unique squares */
454 for (otmp = GET_MAP_OB (m, i, j); otmp; otmp = otmp->above)
455 {
456 if (QUERY_FLAG (otmp, FLAG_UNIQUE) || QUERY_FLAG (otmp, FLAG_OBJ_SAVE_ON_OVL))
457 unique = 1;
458
459 if (!(mapflags & (MAP_OVERLAY | MAP_PLAYER_UNIQUE) || unique))
460 SET_FLAG (otmp, FLAG_OBJ_ORIGINAL);
461 }
462 } 408 }
463#endif
464 409
465 return true; 410 return true;
466} 411}
467 412
468void 413void
469maptile::activate () 414maptile::activate ()
470{ 415{
416 active = true;
417
471 if (!spaces) 418 if (spaces)
472 return;
473
474 for (mapspace *ms = spaces + size (); ms-- > spaces; ) 419 for (mapspace *ms = spaces + size (); ms-- > spaces; )
475 for (object *op = ms->bot; op; op = op->above) 420 for (object *op = ms->bot; op; op = op->above)
476 op->activate_recursive (); 421 op->activate_recursive ();
477} 422}
478 423
479void 424void
480maptile::deactivate () 425maptile::deactivate ()
481{ 426{
427 active = false;
428
482 if (!spaces) 429 if (spaces)
483 return;
484
485 for (mapspace *ms = spaces + size (); ms-- > spaces; ) 430 for (mapspace *ms = spaces + size (); ms-- > spaces; )
486 for (object *op = ms->bot; op; op = op->above) 431 for (object *op = ms->bot; op; op = op->above)
487 op->deactivate_recursive (); 432 op->deactivate_recursive ();
488} 433}
489 434
490bool 435bool
491maptile::_save_objects (object_freezer &freezer, int flags) 436maptile::_save_objects (object_freezer &f, int flags)
492{ 437{
493 static int cede_count = 0; 438 coroapi::cede_to_tick ();
494 439
495 if (flags & IO_HEADER) 440 if (flags & IO_HEADER)
496 _save_header (freezer); 441 _save_header (f);
497 442
498 if (!spaces) 443 if (!spaces)
499 return false; 444 return false;
500 445
501 for (int i = 0; i < size (); ++i) 446 for (int i = 0; i < size (); ++i)
502 { 447 {
503#if 0 // temporarily disabled for improved(?) stability, schmorp #TODO#d#//D
504 if (cede_count >= 500)
505 {
506 cede_count = 0;
507 coroapi::cede ();
508 }
509#endif
510
511 int unique = 0; 448 int unique = 0;
512 for (object *op = spaces [i].bot; op; op = op->above) 449 for (object *op = spaces [i].bot; op; op = op->above)
513 { 450 {
514 // count per-object, but cede only when modification-safe
515 cede_count++;
516
517 if (op->flag [FLAG_UNIQUE] && op->flag [FLAG_IS_FLOOR]) 451 if (op->flag [FLAG_UNIQUE] && op->flag [FLAG_IS_FLOOR])
518 unique = 1; 452 unique = 1;
519 453
520 if (!op->can_map_save ()) 454 if (!op->can_map_save ())
521 continue; 455 continue;
522 456
523 if (unique || op->flag [FLAG_UNIQUE]) 457 if (unique || op->flag [FLAG_UNIQUE])
524 { 458 {
525 if (flags & IO_UNIQUES) 459 if (flags & IO_UNIQUES)
526 save_object (freezer, op, 1); 460 op->write (f);
527 } 461 }
528 else if (flags & IO_OBJECTS) 462 else if (flags & IO_OBJECTS)
529 save_object (freezer, op, 1); 463 op->write (f);
530 } 464 }
531 } 465 }
466
467 coroapi::cede_to_tick ();
532 468
533 return true; 469 return true;
534} 470}
535 471
536bool 472bool
537maptile::_load_objects (const char *path, bool skip_header) 473maptile::_load_objects (const char *path, bool skip_header)
538{ 474{
539 object_thawer thawer (path); 475 object_thawer f (path);
540 476
541 if (!thawer) 477 if (!f)
542 return false; 478 return false;
479
480 f.next ();
543 481
544 if (skip_header) 482 if (skip_header)
545 for (;;) 483 for (;;)
546 { 484 {
547 keyword kw = thawer.get_kv (); 485 keyword kw = f.kw;
548 486 f.skip ();
549 if (kw == KW_end) 487 if (kw == KW_end)
550 break; 488 break;
551
552 thawer.skip_kv (kw);
553 } 489 }
554 490
555 return _load_objects (thawer); 491 return _load_objects (f);
556} 492}
557 493
558bool 494bool
559maptile::_save_objects (const char *path, int flags) 495maptile::_save_objects (const char *path, int flags)
560{ 496{
… …
803 739
804 case KW_end: 740 case KW_end:
805 return true; 741 return true;
806 742
807 default: 743 default:
808 if (!thawer.parse_error (kw, "map", 0)) 744 if (!thawer.parse_error ("map", 0))
809 return false; 745 return false;
810 break; 746 break;
811 } 747 }
812 } 748 }
813 749
… …
841 object *above = op->above; 777 object *above = op->above;
842 778
843 if (QUERY_FLAG (op, FLAG_IS_FLOOR) && QUERY_FLAG (op, FLAG_UNIQUE)) 779 if (QUERY_FLAG (op, FLAG_IS_FLOOR) && QUERY_FLAG (op, FLAG_UNIQUE))
844 unique = 1; 780 unique = 1;
845 781
846 if (op->head == NULL && (QUERY_FLAG (op, FLAG_UNIQUE) || unique)) 782 if (op->head_ () == op && (QUERY_FLAG (op, FLAG_UNIQUE) || unique))
847 { 783 {
848 op->destroy_inv (false); 784 op->destroy_inv (false);
849 op->destroy (); 785 op->destroy ();
850 } 786 }
851 787
… …
934 free (regionmap), regionmap = 0; 870 free (regionmap), regionmap = 0;
935 871
936 if (spaces) 872 if (spaces)
937 { 873 {
938 for (mapspace *ms = spaces + size (); ms-- > spaces; ) 874 for (mapspace *ms = spaces + size (); ms-- > spaces; )
939 while (object *op = ms->bot) 875 while (object *op = ms->bot->head_ ())
940 { 876 {
941 if (op->head)
942 op = op->head;
943
944 op->destroy_inv (false); 877 op->destroy_inv (false);
945 op->destroy (); 878 op->destroy ();
946 } 879 }
947 880
948 sfree (spaces, size ()), spaces = 0; 881 sfree (spaces, size ()), spaces = 0;
… …
1109void 1042void
1110mapspace::update_ () 1043mapspace::update_ ()
1111{ 1044{
1112 object *tmp, *last = 0; 1045 object *tmp, *last = 0;
1113 uint8 flags = P_UPTODATE, light = 0, anywhere = 0; 1046 uint8 flags = P_UPTODATE, light = 0, anywhere = 0;
1114 facetile *top, *floor, *middle;
1115 object *top_obj, *floor_obj, *middle_obj;
1116 MoveType move_block = 0, move_slow = 0, move_on = 0, move_off = 0, move_allow = 0; 1047 MoveType move_block = 0, move_slow = 0, move_on = 0, move_off = 0, move_allow = 0;
1117 1048
1118 middle = blank_face; 1049 //object *middle = 0;
1119 top = blank_face; 1050 //object *top = 0;
1120 floor = blank_face; 1051 //object *floor = 0;
1121 1052 // this seems to generate better code than using locals, above
1122 middle_obj = 0; 1053 object *&top = faces_obj[0] = 0;
1123 top_obj = 0; 1054 object *&middle = faces_obj[1] = 0;
1124 floor_obj = 0; 1055 object *&floor = faces_obj[2] = 0;
1125 1056
1126 for (tmp = bot; tmp; last = tmp, tmp = tmp->above) 1057 for (tmp = bot; tmp; last = tmp, tmp = tmp->above)
1127 { 1058 {
1128 /* This could be made additive I guess (two lights better than 1059 /* This could be made additive I guess (two lights better than
1129 * one). But if so, it shouldn't be a simple additive - 2 1060 * one). But if so, it shouldn't be a simple additive - 2
… …
1142 * Always put the player down for drawing. 1073 * Always put the player down for drawing.
1143 */ 1074 */
1144 if (!tmp->invisible) 1075 if (!tmp->invisible)
1145 { 1076 {
1146 if ((tmp->type == PLAYER || QUERY_FLAG (tmp, FLAG_MONSTER))) 1077 if ((tmp->type == PLAYER || QUERY_FLAG (tmp, FLAG_MONSTER)))
1147 {
1148 top = tmp->face;
1149 top_obj = tmp; 1078 top = tmp;
1150 }
1151 else if (QUERY_FLAG (tmp, FLAG_IS_FLOOR)) 1079 else if (QUERY_FLAG (tmp, FLAG_IS_FLOOR))
1152 { 1080 {
1153 /* If we got a floor, that means middle and top were below it, 1081 /* If we got a floor, that means middle and top were below it,
1154 * so should not be visible, so we clear them. 1082 * so should not be visible, so we clear them.
1155 */ 1083 */
1156 middle = blank_face; 1084 middle = 0;
1157 top = blank_face; 1085 top = 0;
1158 floor = tmp->face;
1159 floor_obj = tmp; 1086 floor = tmp;
1160 } 1087 }
1161 /* Flag anywhere have high priority */ 1088 /* Flag anywhere have high priority */
1162 else if (QUERY_FLAG (tmp, FLAG_SEE_ANYWHERE)) 1089 else if (QUERY_FLAG (tmp, FLAG_SEE_ANYWHERE))
1163 { 1090 {
1164 middle = tmp->face;
1165
1166 middle_obj = tmp; 1091 middle = tmp;
1167 anywhere = 1; 1092 anywhere = 1;
1168 } 1093 }
1169 /* Find the highest visible face around. If equal 1094 /* Find the highest visible face around. If equal
1170 * visibilities, we still want the one nearer to the 1095 * visibilities, we still want the one nearer to the
1171 * top 1096 * top
1172 */ 1097 */
1173 else if (middle == blank_face || (tmp->face->visibility > middle->visibility && !anywhere)) 1098 else if (!middle || (::faces [tmp->face].visibility > ::faces [middle->face].visibility && !anywhere))
1174 {
1175 middle = tmp->face;
1176 middle_obj = tmp; 1099 middle = tmp;
1177 }
1178 } 1100 }
1179 1101
1180 if (tmp == tmp->above) 1102 if (tmp == tmp->above)
1181 { 1103 {
1182 LOG (llevError, "Error in structure of map\n"); 1104 LOG (llevError, "Error in structure of map\n");
… …
1217 * middle face. This should not happen, as we already have the 1139 * middle face. This should not happen, as we already have the
1218 * else statement above so middle should not get set. OTOH, it 1140 * else statement above so middle should not get set. OTOH, it
1219 * may be possible for the faces to match but be different objects. 1141 * may be possible for the faces to match but be different objects.
1220 */ 1142 */
1221 if (top == middle) 1143 if (top == middle)
1222 middle = blank_face; 1144 middle = 0;
1223 1145
1224 /* There are three posibilities at this point: 1146 /* There are three posibilities at this point:
1225 * 1) top face is set, need middle to be set. 1147 * 1) top face is set, need middle to be set.
1226 * 2) middle is set, need to set top. 1148 * 2) middle is set, need to set top.
1227 * 3) neither middle or top is set - need to set both. 1149 * 3) neither middle or top is set - need to set both.
… …
1232 /* Once we get to a floor, stop, since we already have a floor object */ 1154 /* Once we get to a floor, stop, since we already have a floor object */
1233 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR)) 1155 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR))
1234 break; 1156 break;
1235 1157
1236 /* If two top faces are already set, quit processing */ 1158 /* If two top faces are already set, quit processing */
1237 if ((top != blank_face) && (middle != blank_face)) 1159 if (top && middle)
1238 break; 1160 break;
1239 1161
1240 /* Only show visible faces */ 1162 /* Only show visible faces */
1241 if (!tmp->invisible) 1163 if (!tmp->invisible)
1242 { 1164 {
1243 /* Fill in top if needed */ 1165 /* Fill in top if needed */
1244 if (top == blank_face) 1166 if (!top)
1245 { 1167 {
1246 top = tmp->face;
1247 top_obj = tmp; 1168 top = tmp;
1248 if (top == middle) 1169 if (top == middle)
1249 middle = blank_face; 1170 middle = 0;
1250 } 1171 }
1251 else 1172 else
1252 { 1173 {
1253 /* top is already set - we should only get here if 1174 /* top is already set - we should only get here if
1254 * middle is not set 1175 * middle is not set
1255 * 1176 *
1256 * Set the middle face and break out, since there is nothing 1177 * Set the middle face and break out, since there is nothing
1257 * more to fill in. We don't check visiblity here, since 1178 * more to fill in. We don't check visiblity here, since
1258 * 1179 *
1259 */ 1180 */
1260 if (tmp->face != top) 1181 if (tmp != top)
1261 { 1182 {
1262 middle = tmp->face;
1263 middle_obj = tmp; 1183 middle = tmp;
1264 break; 1184 break;
1265 } 1185 }
1266 } 1186 }
1267 } 1187 }
1268 } 1188 }
1269 1189
1270 if (middle == floor) 1190 if (middle == floor)
1271 middle = blank_face; 1191 middle = 0;
1272 1192
1273 if (top == middle) 1193 if (top == middle)
1274 middle = blank_face; 1194 middle = 0;
1275 1195
1276 faces [0] = top; faces_obj [0] = top != blank_face ? top_obj : 0; 1196#if 0
1277 faces [1] = middle; faces_obj [1] = middle != blank_face ? middle_obj : 0; 1197 faces_obj [0] = top;
1278 faces [2] = floor; faces_obj [2] = floor != blank_face ? floor_obj : 0; 1198 faces_obj [1] = middle;
1199 faces_obj [2] = floor;
1200#endif
1279} 1201}
1280 1202
1281uint64 1203uint64
1282mapspace::volume () const 1204mapspace::volume () const
1283{ 1205{
… …
1581get_rangevector (object *op1, object *op2, rv_vector * retval, int flags) 1503get_rangevector (object *op1, object *op2, rv_vector * retval, int flags)
1582{ 1504{
1583 if (!adjacent_map (op1->map, op2->map, &retval->distance_x, &retval->distance_y)) 1505 if (!adjacent_map (op1->map, op2->map, &retval->distance_x, &retval->distance_y))
1584 { 1506 {
1585 /* be conservative and fill in _some_ data */ 1507 /* be conservative and fill in _some_ data */
1586 retval->distance = 100000; 1508 retval->distance = 10000;
1587 retval->distance_x = 32767; 1509 retval->distance_x = 10000;
1588 retval->distance_y = 32767; 1510 retval->distance_y = 10000;
1589 retval->direction = 0; 1511 retval->direction = 0;
1590 retval->part = 0; 1512 retval->part = 0;
1591 } 1513 }
1592 else 1514 else
1593 { 1515 {
… …
1598 1520
1599 best = op1; 1521 best = op1;
1600 /* If this is multipart, find the closest part now */ 1522 /* If this is multipart, find the closest part now */
1601 if (!(flags & 0x1) && op1->more) 1523 if (!(flags & 0x1) && op1->more)
1602 { 1524 {
1603 object *tmp;
1604 int best_distance = retval->distance_x * retval->distance_x + retval->distance_y * retval->distance_y, tmpi; 1525 int best_distance = retval->distance_x * retval->distance_x + retval->distance_y * retval->distance_y, tmpi;
1605 1526
1606 /* we just take the offset of the piece to head to figure 1527 /* we just take the offset of the piece to head to figure
1607 * distance instead of doing all that work above again 1528 * distance instead of doing all that work above again
1608 * since the distance fields we set above are positive in the 1529 * since the distance fields we set above are positive in the
1609 * same axis as is used for multipart objects, the simply arithmetic 1530 * same axis as is used for multipart objects, the simply arithmetic
1610 * below works. 1531 * below works.
1611 */ 1532 */
1612 for (tmp = op1->more; tmp != NULL; tmp = tmp->more) 1533 for (object *tmp = op1->more; tmp; tmp = tmp->more)
1613 { 1534 {
1614 tmpi = (op1->x - tmp->x + retval->distance_x) * (op1->x - tmp->x + retval->distance_x) + 1535 tmpi = (op1->x - tmp->x + retval->distance_x) * (op1->x - tmp->x + retval->distance_x) +
1615 (op1->y - tmp->y + retval->distance_y) * (op1->y - tmp->y + retval->distance_y); 1536 (op1->y - tmp->y + retval->distance_y) * (op1->y - tmp->y + retval->distance_y);
1616 if (tmpi < best_distance) 1537 if (tmpi < best_distance)
1617 { 1538 {
… …
1626 retval->distance_y += op1->y - best->y; 1547 retval->distance_y += op1->y - best->y;
1627 } 1548 }
1628 } 1549 }
1629 1550
1630 retval->part = best; 1551 retval->part = best;
1631 retval->distance = idistance (retval->distance_x, retval->distance_y); 1552 retval->distance = upos_max (abs (retval->distance_x), abs (retval->distance_y));
1632 retval->direction = find_dir_2 (-retval->distance_x, -retval->distance_y); 1553 retval->direction = find_dir_2 (-retval->distance_x, -retval->distance_y);
1633 } 1554 }
1634} 1555}
1635 1556
1636/* this is basically the same as get_rangevector above, but instead of 1557/* this is basically the same as get_rangevector above, but instead of
… …
1704 return default_region; 1625 return default_region;
1705 1626
1706 return ::region::default_region (); 1627 return ::region::default_region ();
1707} 1628}
1708 1629
1630/* picks a random object from a style map.
1631 * Redone by MSW so it should be faster and not use static
1632 * variables to generate tables.
1633 */
1634object *
1635maptile::pick_random_object () const
1636{
1637 /* while returning a null object will result in a crash, that
1638 * is actually preferable to an infinite loop. That is because
1639 * most servers will automatically restart in case of crash.
1640 * Change the logic on getting the random space - shouldn't make
1641 * any difference, but this seems clearer to me.
1642 */
1643 for (int i = 1000; --i;)
1644 {
1645 object *pick = at (rndm (width), rndm (height)).bot;
1709 1646
1647 // do not prefer big monsters just because they are big.
1648 if (pick && pick->head_ () == pick)
1649 return pick->head_ ();
1650 }
1651
1652 // instead of crashing in the unlikely(?) case, try to return *something*
1653 return get_archetype ("blocked");
1654}
1655

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines