[ViewVC] Diff of: cvs/deliantra/server/common/map.C

Comparing deliantra/server/common/map.C (file contents):
Revision 1.64 by root, Mon Jan 1 12:28:45 2007 UTC vs.
Revision 1.74 by root, Sun Jan 14 23:35:03 2007 UTC

 /*
     CrossFire, A Multiplayer game for X-windows
+    Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team
     Copyright (C) 2001-2003 Mark Wedel & Crossfire Development Team
     Copyright (C) 1992 Frank Tore Johansen
     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
  * Loads (ands parses) the objects into a given map from the specified
  * file pointer.
  * mapflags is the same as we get with load_original_map
  */
 bool
-maptile::load_objects (object_thawer &thawer)
+maptile::_load_objects (object_thawer &thawer)
 {
   int unique;
   object *op, *prev = NULL, *last_more = NULL, *otmp;
   op = object::create ();
     for (object *op = ms->bot; op; op = op->above)
       op->deactivate_recursive ();
 }
 bool
-maptile::save_objects (object_freezer &freezer, int flags)
+maptile::_save_objects (object_freezer &freezer, int flags)
 {
+  static int cede_count = 0;
   if (flags & IO_HEADER)
-    save_header (freezer);
+    _save_header (freezer);
   if (!spaces)
     return false;
   for (int i = 0; i < size (); ++i)
     {
+#if 0 // temporarily disabled for improved(?) stability, schmorp #TODO#d#//D
+      if (cede_count >= 500)
+        {
+          cede_count = 0;
+          coroapi::cede ();
+        }
+#endif
       int unique = 0;
       for (object *op = spaces [i].bot; op; op = op->above)
         {
+          // count per-object, but cede only when modification-safe
+          cede_count++;
           if (op->flag [FLAG_UNIQUE] && op->flag [FLAG_IS_FLOOR])
             unique = 1;
           if (!op->can_map_save ())
             continue;
   return true;
 }
 bool
-maptile::load_objects (const char *path, bool skip_header)
+maptile::_load_objects (const char *path, bool skip_header)
 {
   object_thawer thawer (path);
   if (!thawer)
     return false;
           break;
         thawer.skip_kv (kw);
       }
-  return load_objects (thawer);
+  return _load_objects (thawer);
 }
 bool
-maptile::save_objects (const char *path, int flags)
+maptile::_save_objects (const char *path, int flags)
 {
   object_freezer freezer;
-  if (!save_objects (freezer, flags))
+  if (!_save_objects (freezer, flags))
     return false;
   return freezer.save (path);
 }
  * This could be done in lex (like the object loader), but I think
  * currently, there are few enough fields this is not a big deal.
  * MSW 2001-07-01
  */
 bool
-maptile::load_header (object_thawer &thawer)
+maptile::_load_header (object_thawer &thawer)
 {
-  char buf[HUGE_BUF], msgbuf[HUGE_BUF], maplorebuf[HUGE_BUF], *key = NULL, *value, *end;
-  int msgpos = 0;
-  int maplorepos = 0;
   for (;;)
     {
       keyword kw = thawer.get_kv ();
       switch (kw)
             LOG (llevError, "%s: end of file while reading map header, aborting header load.\n", &path);
             return false;
           case KW_end:
             return true;
+          default:
+          case KW_ERROR:
+            LOG (llevError, "%s: skipping errornous line (%s) while reading map header.\n", &path, thawer.last_keyword);
+            break;
           case KW_msg:
             thawer.get_ml (KW_endmsg, msg);
             break;
           case KW_tile_path_1: thawer.get (tile_path [0]); break;
           case KW_tile_path_2: thawer.get (tile_path [1]); break;
           case KW_tile_path_3: thawer.get (tile_path [2]); break;
           case KW_tile_path_4: thawer.get (tile_path [3]); break;
-          default:
-            LOG (llevError, "%s: skipping unknown key in map header: %s\n", &path, keyword_str [kw]);
-            break;
         }
     }
   abort ();
 }
 bool
-maptile::load_header (const char *path)
+maptile::_load_header (const char *path)
 {
   object_thawer thawer (path);
   if (!thawer)
     return false;
-  return load_header (thawer);
+  return _load_header (thawer);
 }
 /******************************************************************************
  * This is the start of unique map handling code
  *****************************************************************************/
         }
     }
 }
 bool
-maptile::save_header (object_freezer &freezer)
+maptile::_save_header (object_freezer &freezer)
 {
 #define MAP_OUT(k)    freezer.put (KW_ ## k, k)
 #define MAP_OUT2(k,v) freezer.put (KW_ ## k, v)
   MAP_OUT2 (arch, "map");
   return true;
 }
 bool
-maptile::save_header (const char *path)
+maptile::_save_header (const char *path)
 {
   object_freezer freezer;
-  if (!save_header (freezer))
+  if (!_save_header (freezer))
     return false;
   return freezer.save (path);
 }
  */
 void
 mapspace::update_ ()
 {
   object *tmp, *last = 0;
-  uint8 flags = 0, light = 0, anywhere = 0;
+  uint8 flags = P_UPTODATE, light = 0, anywhere = 0;
   New_Face *top, *floor, *middle;
   object *top_obj, *floor_obj, *middle_obj;
   MoveType move_block = 0, move_slow = 0, move_on = 0, move_off = 0, move_allow = 0;
   middle = blank_face;
       /* If two top faces are already set, quit processing */
       if ((top != blank_face) && (middle != blank_face))
         break;
-      /* Only show visible faces, unless its the editor - show all */
+      /* Only show visible faces */
-      if (!tmp->invisible || editor)
+      if (!tmp->invisible)
         {
           /* Fill in top if needed */
           if (top == blank_face)
             {
               top = tmp->face;
   faces [0] = top;    faces_obj [0] = top    != blank_face ? top_obj    : 0;
   faces [1] = middle; faces_obj [1] = middle != blank_face ? middle_obj : 0;
   faces [2] = floor;  faces_obj [2] = floor  != blank_face ? floor_obj  : 0;
 }
-/* this updates the orig_map->tile_map[tile_num] value after loading
+/* this updates the orig_map->tile_map[tile_num] value after finding
- * the map.  It also takes care of linking back the freshly loaded
+ * the map.  It also takes care of linking back the freshly found
  * maps tile_map values if it tiles back to this one.  It returns
- * the value of orig_map->tile_map[tile_num].  It really only does this
+ * the value of orig_map->tile_map[tile_num].
- * so that it is easier for calling functions to verify success.
  */
-static maptile *
+static inline maptile *
-load_and_link_tiled_map (maptile *orig_map, int tile_num)
+find_and_link (maptile *orig_map, int tile_num)
 {
+  maptile *mp = orig_map->tile_map [tile_num];
+  if (!mp)
+    {
-  maptile *mp = orig_map->load_map_sync (orig_map->tile_path [tile_num], orig_map);
+      mp = orig_map->find_sync (orig_map->tile_path [tile_num], orig_map);
-  if (!mp || mp->in_memory != MAP_IN_MEMORY)
+      if (!mp)
-    {
+        {
-      // emergency mode, manufacture a dummy map, this creates a memleak, but thats fine
+          // emergency mode, manufacture a dummy map, this creates a memleak, but thats fine
-      LOG (llevError, "FATAL: cannot load tiled map %s from %s, leaking memory and worse!\n",
+          LOG (llevError, "FATAL: cannot load tiled map %s from %s, leaking memory and worse!\n",
-           &orig_map->tile_path[tile_num], &orig_map->path);
+               &orig_map->tile_path[tile_num], &orig_map->path);
-      mp = new maptile (1, 1);
+          mp = new maptile (1, 1);
-      mp->alloc ();
+          mp->alloc ();
-      mp->in_memory = MAP_IN_MEMORY;
+          mp->in_memory = MAP_IN_MEMORY;
+        }
     }
   int dest_tile = (tile_num + 2) % 4;
-  orig_map->tile_map[tile_num] = mp;
+  orig_map->tile_map [tile_num] = mp;
   // optimisation: back-link map to origin map if euclidean
   //TODO: non-euclidean maps MUST GO
   if (orig_map->tile_map[tile_num]->tile_path[dest_tile] == orig_map->path)
     orig_map->tile_map[tile_num]->tile_map[dest_tile] = orig_map;
   return mp;
+}
+static inline void
+load_and_link (maptile *orig_map, int tile_num)
+{
+  find_and_link (orig_map, tile_num)->load_sync ();
 }
 /* this returns TRUE if the coordinates (x,y) are out of
  * map m.  This function also takes into account any
  * tiling considerations, loading adjacant maps as needed.
     {
       if (!m->tile_path[3])
         return 1;
       if (!m->tile_map[3] || m->tile_map[3]->in_memory != MAP_IN_MEMORY)
-        load_and_link_tiled_map (m, 3);
+        find_and_link (m, 3);
       return out_of_map (m->tile_map[3], x + m->tile_map[3]->width, y);
     }
   if (x >= m->width)
     {
       if (!m->tile_path[1])
         return 1;
       if (!m->tile_map[1] || m->tile_map[1]->in_memory != MAP_IN_MEMORY)
-        load_and_link_tiled_map (m, 1);
+        find_and_link (m, 1);
       return out_of_map (m->tile_map[1], x - m->width, y);
     }
   if (y < 0)
     {
       if (!m->tile_path[0])
         return 1;
       if (!m->tile_map[0] || m->tile_map[0]->in_memory != MAP_IN_MEMORY)
-        load_and_link_tiled_map (m, 0);
+        find_and_link (m, 0);
       return out_of_map (m->tile_map[0], x, y + m->tile_map[0]->height);
     }
   if (y >= m->height)
     {
       if (!m->tile_path[2])
         return 1;
       if (!m->tile_map[2] || m->tile_map[2]->in_memory != MAP_IN_MEMORY)
-        load_and_link_tiled_map (m, 2);
+        find_and_link (m, 2);
       return out_of_map (m->tile_map[2], x, y - m->height);
     }
   /* Simple case - coordinates are within this local
 /* This is basically the same as out_of_map above, but
  * instead we return NULL if no map is valid (coordinates
  * out of bounds and no tiled map), otherwise it returns
  * the map as that the coordinates are really on, and
- * updates x and y to be the localized coordinates.
+ * updates x and y to be the localised coordinates.
  * Using this is more efficient of calling out_of_map
  * and then figuring out what the real map is
  */
 maptile *
-get_map_from_coord (maptile *m, sint16 *x, sint16 *y)
+maptile::xy_find (sint16 &x, sint16 &y)
 {
-  if (*x < 0)
+  if (x < 0)
     {
-      if (!m->tile_path[3])
+      if (!tile_path[3])
         return 0;
-      if (!m->tile_map[3] || m->tile_map[3]->in_memory != MAP_IN_MEMORY)
+      find_and_link (this, 3);
-        load_and_link_tiled_map (m, 3);
-      *x += m->tile_map[3]->width;
+      x += tile_map[3]->width;
-      return (get_map_from_coord (m->tile_map[3], x, y));
+      return tile_map[3]->xy_find (x, y);
     }
-  if (*x >= m->width)
+  if (x >= width)
     {
-      if (!m->tile_path[1])
+      if (!tile_path[1])
         return 0;
-      if (!m->tile_map[1] || m->tile_map[1]->in_memory != MAP_IN_MEMORY)
+      find_and_link (this, 1);
-        load_and_link_tiled_map (m, 1);
-      *x -= m->width;
+      x -= width;
-      return (get_map_from_coord (m->tile_map[1], x, y));
+      return tile_map[1]->xy_find (x, y);
     }
-  if (*y < 0)
+  if (y < 0)
     {
-      if (!m->tile_path[0])
+      if (!tile_path[0])
         return 0;
-      if (!m->tile_map[0] || m->tile_map[0]->in_memory != MAP_IN_MEMORY)
+      find_and_link (this, 0);
-        load_and_link_tiled_map (m, 0);
-      *y += m->tile_map[0]->height;
+      y += tile_map[0]->height;
-      return (get_map_from_coord (m->tile_map[0], x, y));
+      return tile_map[0]->xy_find (x, y);
     }
-  if (*y >= m->height)
+  if (y >= height)
     {
-      if (!m->tile_path[2])
+      if (!tile_path[2])
         return 0;
-      if (!m->tile_map[2] || m->tile_map[2]->in_memory != MAP_IN_MEMORY)
+      find_and_link (this, 2);
-        load_and_link_tiled_map (m, 2);
-      *y -= m->height;
+      y -= height;
-      return (get_map_from_coord (m->tile_map[2], x, y));
+      return tile_map[2]->xy_find (x, y);
     }
   /* Simple case - coordinates are within this local
    * map.
    */
-  return m;
+  return this;
 }
 /**
  * Return whether map2 is adjacent to map1. If so, store the distance from
  * map1 to map2 in dx/dy.
 adjacent_map (const maptile *map1, const maptile *map2, int *dx, int *dy)
 {
   if (!map1 || !map2)
     return 0;
+  //TODO: this doesn't actually check corretcly when intermediate maps are not loaded
+  //fix: compare paths instead (this is likely faster, too!)
   if (map1 == map2)
     {
       *dx = 0;
       *dy = 0;
     }
     }
   else
     return 0;
   return 1;
+}
+maptile *
+maptile::xy_load (sint16 &x, sint16 &y)
+{
+  maptile *map = xy_find (x, y);
+  if (map)
+    map->load_sync ();
+  return map;
+}
+maptile *
+get_map_from_coord (maptile *m, sint16 *x, sint16 *y)
+{
+  return m->xy_load (*x, *y);
 }
 /* From map.c
  * This is used by get_player to determine where the other
  * creature is.  get_rangevector takes into account map tiling,

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing deliantra/server/common/map.C (file contents): Revision 1.64 by root, Mon Jan 1 12:28:45 2007 UTC vs. Revision 1.74 by root, Sun Jan 14 23:35:03 2007 UTC

Diff Legend

Comparing deliantra/server/common/map.C (file contents):
Revision 1.64 by root, Mon Jan 1 12:28:45 2007 UTC vs.
Revision 1.74 by root, Sun Jan 14 23:35:03 2007 UTC