[ViewVC] Diff of: cvs/deliantra/server/common/object.C

Comparing deliantra/server/common/object.C (file contents):
Revision 1.300 by root, Mon Nov 9 03:08:23 2009 UTC vs.
Revision 1.310 by root, Thu Dec 17 01:04:37 2009 UTC

   CALL_CALL ("cf::write_uuid", G_DISCARD);
   CALL_END;
 }
 static void
-read_uuid (void)
+read_uuid ()
 {
   char filename[MAX_BUF];
   sprintf (filename, "%s/uuid", settings.localdir);
  * Improvements made with merge:  Better checking on potion, and also
  * check weight
  */
 bool object::can_merge_slow (object *ob1, object *ob2)
 {
-  /* A couple quicksanity checks */
+  /* A couple quick sanity checks */
   if (ob1 == ob2
       || ob1->type  != ob2->type
-      || fabs (ob1->speed - ob2->speed) >= MIN_ACTIVE_SPEED
       || ob1->value != ob2->value
-      || ob1->name  != ob2->name)
+      || ob1->name  != ob2->name
+      || fabs (ob1->speed - ob2->speed) >= MIN_ACTIVE_SPEED)
     return 0;
   /* Do not merge objects if nrof would overflow, assume nrof
    * is always 0 .. 2**31-1 */
   if (ob1->nrof > 0x7fffffff - ob2->nrof)
       || ob1->magic        != ob2->magic
       || ob1->slaying      != ob2->slaying
       || ob1->skill        != ob2->skill
       || ob1->value        != ob2->value
       || ob1->animation_id != ob2->animation_id
-      || (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependent on each other
+      || (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependend on each other
       || ob1->client_type  != ob2->client_type
-      || ob1->materialname != ob2->materialname
+      || ob1->material     != ob2->material
       || ob1->lore         != ob2->lore
       || ob1->subtype      != ob2->subtype
       || ob1->move_type    != ob2->move_type
       || ob1->move_block   != ob2->move_block
       || ob1->move_allow   != ob2->move_allow
               tail = new_link;
             }
         }
     }
-  if (speed < 0)
-    dst->speed_left -= rndm ();
   dst->activate ();
 }
 void
 object::instantiate ()
 {
   if (!uuid.seq) // HACK
     uuid = UUID::gen ();
+  // TODO: unclean state changes, should nt be done in copy_to AND instantiate
+  if (flag [FLAG_RANDOM_SPEED] && speed)
+    speed_left = - speed - rndm (); // TODO animation
+  else
-  speed_left = -0.1f;
+    speed_left = -1.;
   /* copy the body_info to the body_used - this is only really
    * need for monsters, but doesn't hurt to do it for everything.
    * by doing so, when a monster is created, it has good starting
    * values for the body_used info, so when items are created
    * for it, they can be properly equipped.
 object *
 object::clone ()
 {
   object *neu = create ();
   copy_to (neu);
+  // TODO: unclean state changes, should not be done in clone AND instantiate
+  if (neu->flag [FLAG_RANDOM_SPEED] && neu->speed)
+    neu->speed_left = - neu->speed - rndm (); // TODO animation
   neu->map = map; // not copied by copy_to
   return neu;
 }
 /*
 object::object ()
 {
   SET_FLAG (this, FLAG_REMOVED);
   //expmul = 1.0; declared const for the time being
-  face = blank_face;
+  face     = blank_face;
+  material = MATERIAL_NULL;
 }
 object::~object ()
 {
   unlink ();
       above = 0;
       below = 0;
       env   = 0;
-      /* NO_FIX_PLAYER is set when a great many changes are being
+      if (pl && pl->is_player ())
-       * made to players inventory.  If set, avoiding the call
-       * to save cpu time.
-       */
-      if (pl)
-        if (pl->is_player () && (glow_radius || !QUERY_FLAG (pl, FLAG_NO_FIX_PLAYER)))
-          {
+        {
-            pl->update_stats ();
+          pl->contr->queue_stats_update ();
-            if (glow_radius && pl->is_on_map ())
+          if (glow_radius && pl->is_on_map ())
-              update_all_los (pl->map, pl->x, pl->y);
+            update_all_los (pl->map, pl->x, pl->y);
-          }
+        }
     }
   else if (map)
     {
       map->dirty = true;
       mapspace &ms = this->ms ();
   object *prev = this;
   for (archetype *at = (archetype *)arch->more; at; at = (archetype *)at->more)
     {
-      object *op = arch_to_object (at);
+      object *op = at->instance ();
       op->name    = name;
       op->name_pl = name_pl;
       op->title   = title;
   for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
     if (tmp->arch->archname == archname)       /* same archetype */
       tmp->destroy ();
-  object *tmp = arch_to_object (archetype::find (archname));
+  object *tmp = archetype::find (archname)->instance ();
   tmp->x = op->x;
   tmp->y = op->y;
   insert_ob_in_map (tmp, op->map, op, 0);
     return where->env->insert (this);
   else
     return where->map->insert (this, where->x, where->y, originator, flags);
 }
-// check whether we can put this into the map, respect max_nrof, max_volume, max_items
+// check whether we can put this into the map, respect max_volume, max_items
 bool
 object::can_drop_at (maptile *m, int x, int y, object *originator)
 {
   mapspace &ms = m->at (x, y);
   int items = ms.items ();
   if (!items // testing !items ensures we can drop at least one item
       || (items < m->max_items
-          && ms.volume () < m->max_volume
+          && ms.volume () < m->max_volume))
-          && nrof <= m->max_nrof))
     return true;
   if (originator && originator->is_player ())
     originator->contr->failmsg (format (
        "No matter how hard you try, you just cannot put the %s here H<Try to remove some items from the floor first.>",
   if (op->glow_radius && is_on_map ())
     {
       update_stats ();
       update_all_los (map, x, y);
     }
-  else if (is_player () && !flag [FLAG_NO_FIX_PLAYER])
+  else if (is_player ())
     // if this is a player's inventory, update stats
-    update_stats ();
+    contr->queue_stats_update ();
   INVOKE_OBJECT (INSERT, this);
   return op;
 }
 {
   return map ? map->region (x, y)
              : region::default_region ();
 }
-const materialtype_t *
-object::dominant_material () const
-{
-  if (materialtype_t *mt = name_to_material (materialname))
-    return mt;
-  return name_to_material (shstr_unknown);
-}
 void
 object::open_container (object *new_container)
 {
   if (container == new_container)
     return;
       // TODO: this does not seem to serve any purpose anymore?
 #if 0
       // insert the "Close Container" object.
       if (archetype *closer = new_container->other_arch)
         {
-          object *closer = arch_to_object (new_container->other_arch);
+          object *closer = new_container->other_arch->instance ();
           closer->flag [FLAG_NO_MAP_SAVE] = 1;
           new_container->insert (closer);
         }
 #endif

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing deliantra/server/common/object.C (file contents): Revision 1.300 by root, Mon Nov 9 03:08:23 2009 UTC vs. Revision 1.310 by root, Thu Dec 17 01:04:37 2009 UTC

Diff Legend

Comparing deliantra/server/common/object.C (file contents):
Revision 1.300 by root, Mon Nov 9 03:08:23 2009 UTC vs.
Revision 1.310 by root, Thu Dec 17 01:04:37 2009 UTC