ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.10 by root, Thu Aug 31 17:54:14 2006 UTC vs.
Revision 1.29 by root, Mon Sep 11 12:38:36 2006 UTC

1/*
2 * static char *rcsid_object_c =
3 * "$Id: object.C,v 1.10 2006/08/31 17:54:14 root Exp $";
4 */
5 1
6/* 2/*
7 CrossFire, A Multiplayer game for X-windows 3 CrossFire, A Multiplayer game for X-windows
8 4
9 Copyright (C) 2001 Mark Wedel & Crossfire Development Team 5 Copyright (C) 2001 Mark Wedel & Crossfire Development Team
… …
28 24
29/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects. 25/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
30 sub/add_weight will transcend the environment updating the carrying 26 sub/add_weight will transcend the environment updating the carrying
31 variable. */ 27 variable. */
32#include <global.h> 28#include <global.h>
33#ifndef WIN32 /* ---win32 exclude headers */
34#include <stdio.h> 29#include <stdio.h>
35#include <sys/types.h> 30#include <sys/types.h>
36#include <sys/uio.h> 31#include <sys/uio.h>
37#endif /* win32 */
38#include <object.h> 32#include <object.h>
39#include <funcpoint.h> 33#include <funcpoint.h>
40#include <skills.h> 34#include <skills.h>
41#include <loader.h> 35#include <loader.h>
42#ifdef MEMORY_DEBUG 36
43int nroffreeobjects = 0;
44int nrofallocobjects = 0; 37int nrofallocobjects = 0;
45#undef OBJ_EXPAND
46#define OBJ_EXPAND 1
47#else
48object objarray[STARTMAX]; /* All objects, allocated this way at first */
49int nroffreeobjects = STARTMAX; /* How many OBs allocated and free (free) */
50int nrofallocobjects = STARTMAX; /* How many OBs allocated (free + used) */
51#endif
52 38
53object *objects; /* Pointer to the list of used objects */ 39object *objects; /* Pointer to the list of used objects */
54object *free_objects; /* Pointer to the list of unused objects */
55object *active_objects; /* List of active objects that need to be processed */ 40object *active_objects; /* List of active objects that need to be processed */
56 41
57short freearr_x[SIZEOFFREE]= 42short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
58 {0,0,1,1,1,0,-1,-1,-1,0,1,2,2,2,2,2,1,0,-1,-2,-2,-2,-2,-2,-1,
59 0,1,2,3,3,3,3,3,3,3,2,1,0,-1,-2,-3,-3,-3,-3,-3,-3,-3,-2,-1}; 43 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1
60short freearr_y[SIZEOFFREE]= 44};
61 {0,-1,-1,0,1,1,1,0,-1,-2,-2,-2,-1,0,1,2,2,2,2,2,1,0,-1,-2,-2, 45short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
62 -3,-3,-3,-3,-2,-1,0,1,2,3,3,3,3,3,3,3,2,1,0,-1,-2,-3,-3,-3}; 46 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3
63int maxfree[SIZEOFFREE]= 47};
64 {0,9,10,13,14,17,18,21,22,25,26,27,30,31,32,33,36,37,39,39,42,43,44,45, 48int maxfree[SIZEOFFREE] = { 0, 9, 10, 13, 14, 17, 18, 21, 22, 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45,
65 48,49,49,49,49,49,49,49,49,49,49,49,49,49,49,49,49,49,49,49,49,49,49,49,49}; 49 48, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
50};
66int freedir[SIZEOFFREE]= { 51int freedir[SIZEOFFREE] = {
67 0,1,2,3,4,5,6,7,8,1,2,2,2,3,4,4,4,5,6,6,6,7,8,8,8, 52 0, 1, 2, 3, 4, 5, 6, 7, 8, 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,
68 1,2,2,2,2,2,3,4,4,4,4,4,5,6,6,6,6,6,7,8,8,8,8,8}; 53 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8
69 54};
70 55
71/* Returns TRUE if every key_values in wants has a partner with the same value in has. */ 56/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
57static int
72static int compare_ob_value_lists_one(const object * wants, const object * has) { 58compare_ob_value_lists_one (const object *wants, const object *has)
59{
73 key_value * wants_field; 60 key_value *wants_field;
74 61
75 /* n-squared behaviour (see get_ob_key_link()), but I'm hoping both 62 /* n-squared behaviour (see get_ob_key_link()), but I'm hoping both
76 * objects with lists are rare, and lists stay short. If not, use a 63 * objects with lists are rare, and lists stay short. If not, use a
77 * different structure or at least keep the lists sorted... 64 * different structure or at least keep the lists sorted...
78 */ 65 */
79 66
80 /* For each field in wants, */ 67 /* For each field in wants, */
81 for (wants_field = wants->key_values; wants_field != NULL; wants_field = wants_field->next) { 68 for (wants_field = wants->key_values; wants_field != NULL; wants_field = wants_field->next)
69 {
82 key_value * has_field; 70 key_value *has_field;
83 71
84 /* Look for a field in has with the same key. */ 72 /* Look for a field in has with the same key. */
85 has_field = get_ob_key_link(has, wants_field->key); 73 has_field = get_ob_key_link (has, wants_field->key);
74
75 if (has_field == NULL)
86 76 {
87 if (has_field == NULL) {
88 /* No field with that name. */ 77 /* No field with that name. */
89 return FALSE; 78 return FALSE;
90 }
91 79 }
80
92 /* Found the matching field. */ 81 /* Found the matching field. */
93 if (has_field->value != wants_field->value) { 82 if (has_field->value != wants_field->value)
83 {
94 /* Values don't match, so this half of the comparison is false. */ 84 /* Values don't match, so this half of the comparison is false. */
95 return FALSE; 85 return FALSE;
96 } 86 }
97 87
98 /* If we get here, we found a match. Now for the next field in wants. */ 88 /* If we get here, we found a match. Now for the next field in wants. */
99 }
100 89 }
90
101 /* If we get here, every field in wants has a matching field in has. */ 91 /* If we get here, every field in wants has a matching field in has. */
102 return TRUE; 92 return TRUE;
103} 93}
104 94
105/* Returns TRUE if ob1 has the same key_values as ob2. */ 95/* Returns TRUE if ob1 has the same key_values as ob2. */
96static int
106static int compare_ob_value_lists(const object * ob1, const object * ob2) { 97compare_ob_value_lists (const object *ob1, const object *ob2)
98{
107 /* However, there may be fields in has which aren't partnered in wants, 99 /* However, there may be fields in has which aren't partnered in wants,
108 * so we need to run the comparison *twice*. :( 100 * so we need to run the comparison *twice*. :(
109 */ 101 */
110 return compare_ob_value_lists_one(ob1, ob2) && compare_ob_value_lists_one(ob2, ob1); 102 return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1);
111} 103}
112 104
113/* Function examines the 2 objects given to it, and returns true if 105/* Function examines the 2 objects given to it, and returns true if
114 * they can be merged together. 106 * they can be merged together.
115 * 107 *
… …
121 * 113 *
122 * Improvements made with merge: Better checking on potion, and also 114 * Improvements made with merge: Better checking on potion, and also
123 * check weight 115 * check weight
124 */ 116 */
125 117
126int CAN_MERGE(object *ob1, object *ob2) { 118bool object::can_merge (object *ob1, object *ob2)
127 119{
128 /* A couple quicksanity checks */ 120 /* A couple quicksanity checks */
129 if ((ob1 == ob2) || (ob1->type != ob2->type)) return 0; 121 if ((ob1 == ob2) || (ob1->type != ob2->type))
122 return 0;
130 123
131 if (ob1->speed != ob2->speed) return 0; 124 if (ob1->speed != ob2->speed)
132 /* Note sure why the following is the case - either the object has to 125 return 0;
133 * be animated or have a very low speed. Is this an attempted monster 126
134 * check? 127 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that
128 * value could not be stored in a sint32 (which unfortunately sometimes is
129 * used to store nrof).
135 */ 130 */
136 if (!QUERY_FLAG(ob1,FLAG_ANIMATE) && FABS((ob1)->speed) > MIN_ACTIVE_SPEED) 131 if (ob1->nrof + ob2->nrof >= 1UL << 31)
132 return 0;
133
134 /* If the objects have been identified, set the BEEN_APPLIED flag.
135 * This is to the comparison of the flags below will be OK. We
136 * just can't ignore the been applied or identified flags, as they
137 * are not equal - just if it has been identified, the been_applied
138 * flags lose any meaning.
139 */
140 if (QUERY_FLAG (ob1, FLAG_IDENTIFIED))
141 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
142
143 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
144 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
145
146
147 /* the 0x400000 on flags2 is FLAG_INV_LOCK. I don't think something
148 * being locked in inventory should prevent merging.
149 * 0x4 in flags3 is CLIENT_SENT
150 */
151 if ((ob1->arch != ob2->arch) ||
152 (ob1->flags[0] != ob2->flags[0]) ||
153 (ob1->flags[1] != ob2->flags[1]) ||
154 ((ob1->flags[2] & ~0x400000) != (ob2->flags[2] & ~0x400000)) ||
155 ((ob1->flags[3] & ~0x4) != (ob2->flags[3] & ~0x4)) ||
156 (ob1->name != ob2->name) ||
157 (ob1->title != ob2->title) ||
158 (ob1->msg != ob2->msg) ||
159 (ob1->weight != ob2->weight) ||
160 (memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist)) != 0) ||
161 (memcmp (&ob1->stats, &ob2->stats, sizeof (ob1->stats)) != 0) ||
162 (ob1->attacktype != ob2->attacktype) ||
163 (ob1->magic != ob2->magic) ||
164 (ob1->slaying != ob2->slaying) ||
165 (ob1->skill != ob2->skill) ||
166 (ob1->value != ob2->value) ||
167 (ob1->animation_id != ob2->animation_id) ||
168 (ob1->client_type != ob2->client_type) ||
169 (ob1->materialname != ob2->materialname) ||
170 (ob1->lore != ob2->lore) ||
171 (ob1->subtype != ob2->subtype) ||
172 (ob1->move_type != ob2->move_type) ||
173 (ob1->move_block != ob2->move_block) ||
174 (ob1->move_allow != ob2->move_allow) ||
175 (ob1->move_on != ob2->move_on) ||
176 (ob1->move_off != ob2->move_off) || (ob1->move_slow != ob2->move_slow) || (ob1->move_slow_penalty != ob2->move_slow_penalty))
177 return 0;
178
179 /* This is really a spellbook check - really, we should
180 * check all objects in the inventory.
181 */
182 if (ob1->inv || ob2->inv)
183 {
184 /* if one object has inventory but the other doesn't, not equiv */
185 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv))
137 return 0; 186 return 0;
138 187
139 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that 188 /* Now check to see if the two inventory objects could merge */
140 * value could not be stored in a sint32 (which unfortunately sometimes is 189 if (!CAN_MERGE (ob1->inv, ob2->inv))
141 * used to store nrof).
142 */
143 if (ob1->nrof+ob2->nrof >= 1UL<<31)
144 return 0; 190 return 0;
145 191
146 /* This is really a spellbook check - really, we should
147 * check all objects in the inventory.
148 */
149 if (ob1->inv || ob2->inv) {
150 /* if one object has inventory but the other doesn't, not equiv */
151 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv)) return 0;
152
153 /* Now check to see if the two inventory objects could merge */
154 if (!CAN_MERGE(ob1->inv, ob2->inv)) return 0;
155
156 /* inventory ok - still need to check rest of this object to see 192 /* inventory ok - still need to check rest of this object to see
157 * if it is valid. 193 * if it is valid.
158 */ 194 */
159 } 195 }
160 196
161 /* If the objects have been identified, set the BEEN_APPLIED flag.
162 * This is to the comparison of the flags below will be OK. We
163 * just can't ignore the been applied or identified flags, as they
164 * are not equal - just if it has been identified, the been_applied
165 * flags lose any meaning.
166 */
167 if (QUERY_FLAG(ob1, FLAG_IDENTIFIED))
168 SET_FLAG(ob1, FLAG_BEEN_APPLIED);
169
170 if (QUERY_FLAG(ob2, FLAG_IDENTIFIED))
171 SET_FLAG(ob2, FLAG_BEEN_APPLIED);
172
173
174 /* the 0x400000 on flags2 is FLAG_INV_LOCK. I don't think something
175 * being locked in inventory should prevent merging.
176 * 0x4 in flags3 is CLIENT_SENT
177 */
178 if ((ob1->arch != ob2->arch) ||
179 (ob1->flags[0] != ob2->flags[0]) ||
180 (ob1->flags[1] != ob2->flags[1]) ||
181 ((ob1->flags[2] & ~0x400000) != (ob2->flags[2] & ~ 0x400000)) ||
182 ((ob1->flags[3] & ~0x4) != (ob2->flags[3] & ~0x4)) ||
183 (ob1->name != ob2->name) ||
184 (ob1->title != ob2->title) ||
185 (ob1->msg != ob2->msg) ||
186 (ob1->weight != ob2->weight) ||
187 (memcmp(&ob1->resist, &ob2->resist, sizeof(ob1->resist))!=0) ||
188 (memcmp(&ob1->stats, &ob2->stats, sizeof(ob1->stats))!=0) ||
189 (ob1->attacktype != ob2->attacktype) ||
190 (ob1->magic != ob2->magic) ||
191 (ob1->slaying != ob2->slaying) ||
192 (ob1->skill != ob2->skill) ||
193 (ob1->value != ob2->value) ||
194 (ob1->animation_id != ob2->animation_id) ||
195 (ob1->client_type != ob2->client_type) ||
196 (ob1->materialname != ob2->materialname) ||
197 (ob1->lore != ob2->lore) ||
198 (ob1->subtype != ob2->subtype) ||
199 (ob1->move_type != ob2->move_type) ||
200 (ob1->move_block != ob2->move_block) ||
201 (ob1->move_allow != ob2->move_allow) ||
202 (ob1->move_on != ob2->move_on) ||
203 (ob1->move_off != ob2->move_off) ||
204 (ob1->move_slow != ob2->move_slow) ||
205 (ob1->move_slow_penalty != ob2->move_slow_penalty)
206 )
207 return 0;
208
209 /* Don't merge objects that are applied. With the new 'body' code, 197 /* Don't merge objects that are applied. With the new 'body' code,
210 * it is possible for most any character to have more than one of 198 * it is possible for most any character to have more than one of
211 * some items equipped, and we don't want those to merge. 199 * some items equipped, and we don't want those to merge.
212 */ 200 */
213 if (QUERY_FLAG(ob1, FLAG_APPLIED) || QUERY_FLAG(ob2, FLAG_APPLIED)) 201 if (QUERY_FLAG (ob1, FLAG_APPLIED) || QUERY_FLAG (ob2, FLAG_APPLIED))
202 return 0;
203
204 /* Note sure why the following is the case - either the object has to
205 * be animated or have a very low speed. Is this an attempted monster
206 * check?
207 */
208 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && FABS ((ob1)->speed) > MIN_ACTIVE_SPEED)
209 return 0;
210
211 switch (ob1->type)
212 {
213 case SCROLL:
214 if (ob1->level != ob2->level)
215 return 0;
216 break;
217 }
218
219 if (ob1->key_values != NULL || ob2->key_values != NULL)
220 {
221 /* At least one of these has key_values. */
222 if ((ob1->key_values == NULL) != (ob2->key_values == NULL))
223 /* One has fields, but the other one doesn't. */
214 return 0; 224 return 0;
215
216 switch (ob1->type) {
217 case SCROLL:
218 if (ob1->level != ob2->level) return 0;
219 break;
220
221 }
222 if (ob1->key_values != NULL || ob2->key_values != NULL) {
223 /* At least one of these has key_values. */
224 if ((ob1->key_values == NULL) != (ob2->key_values == NULL)) {
225 /* One has fields, but the other one doesn't. */
226 return 0;
227 } else if (!compare_ob_value_lists(ob1, ob2)) { 225 else if (!compare_ob_value_lists (ob1, ob2))
228 return 0; 226 return 0;
229 } 227 }
228
229 //TODO: generate an event or call into perl for additional checks
230 if (ob1->self || ob2->self)
230 } 231 {
232 ob1->optimise ();
233 ob2->optimise ();
231 234
235 if (ob1->self || ob2->self)
236 return 0;
237 }
238
232 /* Everything passes, must be OK. */ 239 /* Everything passes, must be OK. */
233 return 1; 240 return 1;
234} 241}
235 242
236/* 243/*
237 * sum_weight() is a recursive function which calculates the weight 244 * sum_weight() is a recursive function which calculates the weight
238 * an object is carrying. It goes through in figures out how much 245 * an object is carrying. It goes through in figures out how much
239 * containers are carrying, and sums it up. 246 * containers are carrying, and sums it up.
240 */ 247 */
241signed long sum_weight(object *op) { 248long
249sum_weight (object *op)
250{
242 signed long sum; 251 long sum;
243 object *inv; 252 object *inv;
253
244 for(sum = 0, inv = op->inv; inv != NULL; inv = inv->below) { 254 for (sum = 0, inv = op->inv; inv != NULL; inv = inv->below)
255 {
245 if (inv->inv) 256 if (inv->inv)
246 sum_weight(inv); 257 sum_weight (inv);
247 sum += inv->carrying + inv->weight * (inv->nrof ? inv->nrof : 1); 258 sum += inv->carrying + inv->weight * (inv->nrof ? inv->nrof : 1);
248 } 259 }
249 if (op->type == CONTAINER && op->stats.Str) 260 if (op->type == CONTAINER && op->stats.Str)
250 sum = (sum * (100 - op->stats.Str))/100; 261 sum = (sum * (100 - op->stats.Str)) / 100;
251 if(op->carrying != sum) 262 if (op->carrying != sum)
252 op->carrying = sum; 263 op->carrying = sum;
253 return sum; 264 return sum;
254} 265}
255 266
256/** 267/**
257 * Return the outermost environment object for a given object. 268 * Return the outermost environment object for a given object.
258 */ 269 */
259 270
271object *
260object *object_get_env_recursive (object *op) { 272object_get_env_recursive (object *op)
273{
261 while (op->env != NULL) 274 while (op->env != NULL)
262 op = op->env; 275 op = op->env;
263 return op; 276 return op;
264} 277}
265 278
266/* 279/*
267 * Eneq(@csd.uu.se): Since we can have items buried in a character we need 280 * Eneq(@csd.uu.se): Since we can have items buried in a character we need
268 * a better check. We basically keeping traversing up until we can't 281 * a better check. We basically keeping traversing up until we can't
269 * or find a player. 282 * or find a player.
270 */ 283 */
271 284
285object *
272object *is_player_inv (object *op) { 286is_player_inv (object *op)
287{
273 for (;op!=NULL&&op->type!=PLAYER; op=op->env) 288 for (; op != NULL && op->type != PLAYER; op = op->env)
274 if (op->env==op) 289 if (op->env == op)
275 op->env = NULL; 290 op->env = NULL;
276 return op; 291 return op;
277} 292}
278 293
279/* 294/*
280 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump. 295 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
281 * Some error messages. 296 * Some error messages.
282 * The result of the dump is stored in the static global errmsg array. 297 * The result of the dump is stored in the static global errmsg array.
283 */ 298 */
284 299
300void
285void dump_object2(object *op) { 301dump_object2 (object *op)
302{
286errmsg[0] = 0; 303 errmsg[0] = 0;
287return; 304 return;
288 //TODO//D#d# 305 //TODO//D#d#
289#if 0 306#if 0
290 char *cp; 307 char *cp;
308
291/* object *tmp;*/ 309/* object *tmp;*/
292 310
293 if(op->arch!=NULL) { 311 if (op->arch != NULL)
312 {
294 strcat(errmsg,"arch "); 313 strcat (errmsg, "arch ");
295 strcat(errmsg,op->arch->name?op->arch->name:"(null)"); 314 strcat (errmsg, op->arch->name ? op->arch->name : "(null)");
296 strcat(errmsg,"\n"); 315 strcat (errmsg, "\n");
297 if((cp=get_ob_diff(op,&empty_archetype->clone))!=NULL) 316 if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
298 strcat(errmsg,cp); 317 strcat (errmsg, cp);
299#if 0 318# if 0
300 /* Don't dump player diffs - they are too long, mostly meaningless, and 319 /* Don't dump player diffs - they are too long, mostly meaningless, and
301 * will overflow the buffer. 320 * will overflow the buffer.
302 * Changed so that we don't dump inventory either. This may 321 * Changed so that we don't dump inventory either. This may
303 * also overflow the buffer. 322 * also overflow the buffer.
304 */ 323 */
305 if(op->type!=PLAYER && (cp=get_ob_diff(op,&empty_archetype->clone))!=NULL) 324 if (op->type != PLAYER && (cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
306 strcat(errmsg,cp); 325 strcat (errmsg, cp);
307 for (tmp=op->inv; tmp; tmp=tmp->below) 326 for (tmp = op->inv; tmp; tmp = tmp->below)
308 dump_object2(tmp); 327 dump_object2 (tmp);
328# endif
329 strcat (errmsg, "end\n");
330 }
331 else
332 {
333 strcat (errmsg, "Object ");
334 if (op->name == NULL)
335 strcat (errmsg, "(null)");
336 else
337 strcat (errmsg, op->name);
338 strcat (errmsg, "\n");
339# if 0
340 if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
341 strcat (errmsg, cp);
342 for (tmp = op->inv; tmp; tmp = tmp->below)
343 dump_object2 (tmp);
344# endif
345 strcat (errmsg, "end\n");
346 }
309#endif 347#endif
310 strcat(errmsg,"end\n");
311 } else {
312 strcat(errmsg,"Object ");
313 if (op->name==NULL) strcat(errmsg, "(null)");
314 else strcat(errmsg,op->name);
315 strcat(errmsg,"\n");
316#if 0
317 if((cp=get_ob_diff(op,&empty_archetype->clone))!=NULL)
318 strcat(errmsg,cp);
319 for (tmp=op->inv; tmp; tmp=tmp->below)
320 dump_object2(tmp);
321#endif
322 strcat(errmsg,"end\n");
323 }
324#endif
325} 348}
326 349
327/* 350/*
328 * Dumps an object. Returns output in the static global errmsg array. 351 * Dumps an object. Returns output in the static global errmsg array.
329 */ 352 */
330 353
354void
331void dump_object(object *op) { 355dump_object (object *op)
356{
332 if(op==NULL) { 357 if (op == NULL)
358 {
333 strcpy(errmsg,"[NULL pointer]"); 359 strcpy (errmsg, "[NULL pointer]");
334 return; 360 return;
335 } 361 }
336 errmsg[0]='\0'; 362 errmsg[0] = '\0';
337 dump_object2(op); 363 dump_object2 (op);
338} 364}
339 365
366void
340void dump_all_objects(void) { 367dump_all_objects (void)
368{
341 object *op; 369 object *op;
370
342 for(op=objects;op!=NULL;op=op->next) { 371 for (op = objects; op != NULL; op = op->next)
372 {
343 dump_object(op); 373 dump_object (op);
344 fprintf(logfile, "Object %d\n:%s\n", op->count, errmsg); 374 fprintf (logfile, "Object %d\n:%s\n", op->count, errmsg);
345 } 375 }
346} 376}
347 377
348/* 378/*
349 * get_nearest_part(multi-object, object 2) returns the part of the 379 * get_nearest_part(multi-object, object 2) returns the part of the
350 * multi-object 1 which is closest to the second object. 380 * multi-object 1 which is closest to the second object.
351 * If it's not a multi-object, it is returned. 381 * If it's not a multi-object, it is returned.
352 */ 382 */
353 383
384object *
354object *get_nearest_part(object *op, const object *pl) { 385get_nearest_part (object *op, const object *pl)
386{
355 object *tmp,*closest; 387 object *tmp, *closest;
356 int last_dist,i; 388 int last_dist, i;
389
357 if(op->more==NULL) 390 if (op->more == NULL)
358 return op; 391 return op;
359 for(last_dist=distance(op,pl),closest=op,tmp=op->more;tmp!=NULL;tmp=tmp->more) 392 for (last_dist = distance (op, pl), closest = op, tmp = op->more; tmp != NULL; tmp = tmp->more)
360 if((i=distance(tmp,pl))<last_dist) 393 if ((i = distance (tmp, pl)) < last_dist)
361 closest=tmp,last_dist=i; 394 closest = tmp, last_dist = i;
362 return closest; 395 return closest;
363} 396}
364 397
365/* 398/*
366 * Returns the object which has the count-variable equal to the argument. 399 * Returns the object which has the count-variable equal to the argument.
367 */ 400 */
368 401
402object *
369object *find_object(tag_t i) { 403find_object (tag_t i)
404{
370 object *op; 405 object *op;
406
371 for(op=objects;op!=NULL;op=op->next) 407 for (op = objects; op != NULL; op = op->next)
372 if(op->count==i) 408 if (op->count == i)
373 break; 409 break;
374 return op; 410 return op;
375} 411}
376 412
377/* 413/*
378 * Returns the first object which has a name equal to the argument. 414 * Returns the first object which has a name equal to the argument.
379 * Used only by the patch command, but not all that useful. 415 * Used only by the patch command, but not all that useful.
380 * Enables features like "patch <name-of-other-player> food 999" 416 * Enables features like "patch <name-of-other-player> food 999"
381 */ 417 */
382 418
419object *
383object *find_object_name(const char *str) { 420find_object_name (const char *str)
421{
384 const char *name=add_string(str); 422 const char *name = shstr::find (str);
385 object *op; 423 object *op;
424
386 for(op=objects;op!=NULL;op=op->next) 425 for (op = objects; op != NULL; op = op->next)
387 if(op->name==name) 426 if (&op->name == name)
388 break; 427 break;
389 free_string(name); 428
390 return op; 429 return op;
391} 430}
392 431
432void
393void free_all_object_data(void) { 433free_all_object_data ()
394#ifdef MEMORY_DEBUG 434{
395 object *op, *next; 435 LOG (llevDebug, "%d allocated objects\n", nrofallocobjects);
396
397 for (op=free_objects; op!=NULL; ) {
398 next=op->next;
399 free(op);
400 nrofallocobjects--;
401 nroffreeobjects--;
402 op=next;
403 }
404#endif
405 LOG(llevDebug,"%d allocated objects, %d free objects, STARMAX=%d\n",
406 nrofallocobjects, nroffreeobjects,STARTMAX);
407} 436}
408 437
409/* 438/*
410 * Returns the object which this object marks as being the owner. 439 * Returns the object which this object marks as being the owner.
411 * A id-scheme is used to avoid pointing to objects which have been 440 * A id-scheme is used to avoid pointing to objects which have been
… …
415 * prompt, he is removed, and we don't want to treat him as an owner of 444 * prompt, he is removed, and we don't want to treat him as an owner of
416 * anything, so check removed flag. I don't expect that this should break 445 * anything, so check removed flag. I don't expect that this should break
417 * anything - once an object is removed, it is basically dead anyways. 446 * anything - once an object is removed, it is basically dead anyways.
418 */ 447 */
419 448
449object *
420object *get_owner(object *op) { 450get_owner (object *op)
451{
421 if(op->owner==NULL) 452 if (op->owner == NULL)
422 return NULL;
423
424 if (!QUERY_FLAG(op->owner,FLAG_FREED) && !QUERY_FLAG(op->owner, FLAG_REMOVED) &&
425 op->owner->count==op->ownercount)
426 return op->owner;
427
428 op->owner=NULL;
429 op->ownercount=0;
430 return NULL; 453 return NULL;
431}
432 454
455 if (!QUERY_FLAG (op->owner, FLAG_FREED) && !QUERY_FLAG (op->owner, FLAG_REMOVED) && op->owner->count == op->ownercount)
456 return op->owner;
457
458 op->owner = NULL;
459 op->ownercount = 0;
460 return NULL;
461}
462
463void
433void clear_owner(object *op) 464clear_owner (object *op)
434{ 465{
435 if (!op) return; 466 if (!op)
467 return;
436 468
437 if (op->owner && op->ownercount == op->owner->count) 469 if (op->owner && op->ownercount == op->owner->count)
438 op->owner->refcount--; 470 op->owner->refcount--;
439 471
440 op->owner = NULL; 472 op->owner = NULL;
441 op->ownercount = 0; 473 op->ownercount = 0;
442} 474}
443
444
445 475
446/* 476/*
447 * Sets the owner and sets the skill and exp pointers to owner's current 477 * Sets the owner and sets the skill and exp pointers to owner's current
448 * skill and experience objects. 478 * skill and experience objects.
449 */ 479 */
480void
450void set_owner (object *op, object *owner) 481set_owner (object *op, object *owner)
451{ 482{
452 if(owner==NULL||op==NULL) 483 if (owner == NULL || op == NULL)
453 return; 484 return;
454 485
455 /* next line added to allow objects which own objects */ 486 /* next line added to allow objects which own objects */
456 /* Add a check for ownercounts in here, as I got into an endless loop 487 /* Add a check for ownercounts in here, as I got into an endless loop
457 * with the fireball owning a poison cloud which then owned the 488 * with the fireball owning a poison cloud which then owned the
458 * fireball. I believe that was caused by one of the objects getting 489 * fireball. I believe that was caused by one of the objects getting
459 * freed and then another object replacing it. Since the ownercounts 490 * freed and then another object replacing it. Since the ownercounts
460 * didn't match, this check is valid and I believe that cause is valid. 491 * didn't match, this check is valid and I believe that cause is valid.
461 */ 492 */
462 while (owner->owner && owner!=owner->owner && 493 while (owner->owner && owner != owner->owner && owner->ownercount == owner->owner->count)
463 owner->ownercount==owner->owner->count) owner=owner->owner; 494 owner = owner->owner;
464 495
465 /* IF the owner still has an owner, we did not resolve to a final owner. 496 /* IF the owner still has an owner, we did not resolve to a final owner.
466 * so lets not add to that. 497 * so lets not add to that.
467 */ 498 */
468 if (owner->owner) return; 499 if (owner->owner)
500 return;
469 501
470 op->owner=owner; 502 op->owner = owner;
471 503
472 op->ownercount=owner->count; 504 op->ownercount = owner->count;
473 owner->refcount++; 505 owner->refcount++;
474
475} 506}
476 507
477/* Set the owner to clone's current owner and set the skill and experience 508/* Set the owner to clone's current owner and set the skill and experience
478 * objects to clone's objects (typically those objects that where the owner's 509 * objects to clone's objects (typically those objects that where the owner's
479 * current skill and experience objects at the time when clone's owner was 510 * current skill and experience objects at the time when clone's owner was
… …
482 * Use this function if player created an object (e.g. fire bullet, swarm 513 * Use this function if player created an object (e.g. fire bullet, swarm
483 * spell), and this object creates further objects whose kills should be 514 * spell), and this object creates further objects whose kills should be
484 * accounted for the player's original skill, even if player has changed 515 * accounted for the player's original skill, even if player has changed
485 * skills meanwhile. 516 * skills meanwhile.
486 */ 517 */
518void
487void copy_owner (object *op, object *clone) 519copy_owner (object *op, object *clone)
488{ 520{
489 object *owner = get_owner (clone); 521 object *owner = get_owner (clone);
522
490 if (owner == NULL) { 523 if (owner == NULL)
524 {
491 /* players don't have owners - they own themselves. Update 525 /* players don't have owners - they own themselves. Update
492 * as appropriate. 526 * as appropriate.
493 */ 527 */
494 if (clone->type == PLAYER) owner=clone; 528 if (clone->type == PLAYER)
529 owner = clone;
530 else
495 else return; 531 return;
496 } 532 }
533
497 set_owner(op, owner); 534 set_owner (op, owner);
498
499}
500
501/*
502 * Resets vital variables in an object
503 */
504
505void reset_object(object *op) {
506
507 op->name = NULL;
508 op->name_pl = NULL;
509 op->title = NULL;
510 op->race = NULL;
511 op->slaying = NULL;
512 op->skill = NULL;
513 op->msg = NULL;
514 op->materialname = NULL;
515 op->lore = NULL;
516 clear_object(op);
517} 535}
518 536
519/* Zero the key_values on op, decrementing the shared-string 537/* Zero the key_values on op, decrementing the shared-string
520 * refcounts and freeing the links. 538 * refcounts and freeing the links.
521 */ 539 */
540static void
522static void free_key_values(object * op) { 541free_key_values (object *op)
523 key_value * i; 542{
524 key_value * next = NULL; 543 for (key_value *i = op->key_values; i != 0;)
525 544 {
526 if (op->key_values == NULL) return; 545 key_value *next = i->next;
546 delete i;
547
548 i = next;
527 549 }
528 for (i = op->key_values; i != NULL; i = next) { 550
529 /* Store next *first*. */
530 next = i->next;
531
532 if (i->key) FREE_AND_CLEAR_STR(i->key);
533 if (i->value) FREE_AND_CLEAR_STR(i->value);
534 i->next = NULL;
535 free(i);
536 }
537
538 op->key_values = NULL; 551 op->key_values = 0;
539} 552}
540 553
554void object::clear ()
555{
556 attachable_base::clear ();
557
558 free_key_values (this);
559
560 clear_owner (this);
561
562 name = 0;
563 name_pl = 0;
564 title = 0;
565 race = 0;
566 slaying = 0;
567 skill = 0;
568 msg = 0;
569 lore = 0;
570 custom_name = 0;
571 materialname = 0;
572
573 memset (static_cast < object_pod * >(this), 0, sizeof (object_pod));
574
575 SET_FLAG (this, FLAG_REMOVED);
576}
577
578void object::clone (object *destination)
579{
580 *(object_copy *) destination = *this;
581 *(object_pod *) destination = *this;
582
583 if (self || cb)
584 INVOKE_OBJECT (CLONE, this, ARG_OBJECT (destination));
585}
541 586
542/* 587/*
543 * clear_object() frees everything allocated by an object, and also 588 * clear_object() frees everything allocated by an object, and also
544 * clears all variables and flags to default settings. 589 * clears all variables and flags to default settings.
545 */ 590 */
546 591
592void
547void clear_object(object *op) { 593clear_object (object *op)
594{
548 op->clear (); 595 op->clear ();
549 596
550 event *evt;
551 event *evt2;
552
553 /* redo this to be simpler/more efficient. Was also seeing
554 * crashes in the old code. Move this to the top - am
555 * seeing periodic crashes in this code, and would like to have
556 * as much info available as possible (eg, object name).
557 */
558 for (evt = op->events; evt; evt=evt2) {
559 evt2 = evt->next;
560
561 if (evt->hook != NULL) FREE_AND_CLEAR_STR(evt->hook);
562 if (evt->plugin != NULL) FREE_AND_CLEAR_STR(evt->plugin);
563 if (evt->options != NULL) FREE_AND_CLEAR_STR(evt->options);
564
565 free(evt);
566 }
567 op->events = NULL;
568
569 free_key_values(op);
570
571 /* the memset will clear all these values for us, but we need
572 * to reduce the refcount on them.
573 */
574 if (op->name!=NULL) FREE_AND_CLEAR_STR(op->name);
575 if (op->name_pl!=NULL) FREE_AND_CLEAR_STR(op->name_pl);
576 if (op->title != NULL) FREE_AND_CLEAR_STR(op->title);
577 if (op->race!=NULL) FREE_AND_CLEAR_STR(op->race);
578 if (op->slaying!=NULL) FREE_AND_CLEAR_STR(op->slaying);
579 if (op->skill!=NULL) FREE_AND_CLEAR_STR(op->skill);
580 if (op->msg!=NULL) FREE_AND_CLEAR_STR(op->msg);
581 if (op->lore!=NULL) FREE_AND_CLEAR_STR(op->lore);
582 if (op->materialname!= NULL) FREE_AND_CLEAR_STR(op->materialname);
583
584
585 memset((void*)op, 0, sizeof (object_special));
586 /* Below here, we clear things that are not done by the memset,
587 * or set default values that are not zero.
588 */
589 /* This is more or less true */
590 SET_FLAG(op, FLAG_REMOVED);
591
592
593 op->contr = NULL; 597 op->contr = NULL;
594 op->below=NULL; 598 op->below = NULL;
595 op->above=NULL; 599 op->above = NULL;
596 op->inv=NULL; 600 op->inv = NULL;
597 op->events=NULL;
598 op->container=NULL; 601 op->container = NULL;
599 op->env=NULL; 602 op->env = NULL;
600 op->more=NULL; 603 op->more = NULL;
601 op->head=NULL; 604 op->head = NULL;
602 op->map=NULL; 605 op->map = NULL;
603 op->refcount=0; 606 op->refcount = 0;
604 op->active_next = NULL; 607 op->active_next = NULL;
605 op->active_prev = NULL; 608 op->active_prev = NULL;
606 /* What is not cleared is next, prev, and count */ 609 /* What is not cleared is next, prev, and count */
607 610
608 op->expmul=1.0; 611 op->expmul = 1.0;
609 op->face = blank_face; 612 op->face = blank_face;
610 op->attacked_by_count = (tag_t) -1; 613 op->attacked_by_count = -1;
614
611 if (settings.casting_time) 615 if (settings.casting_time)
612 op->casting_time = -1; 616 op->casting_time = -1;
613
614} 617}
615 618
616/* 619/*
617 * copy object first frees everything allocated by the second object, 620 * copy object first frees everything allocated by the second object,
618 * and then copies the contends of the first object into the second 621 * and then copies the contends of the first object into the second
… …
620 * data that is malloc'd needs to be re-malloc/copied. Otherwise, 623 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
621 * if the first object is freed, the pointers in the new object 624 * if the first object is freed, the pointers in the new object
622 * will point at garbage. 625 * will point at garbage.
623 */ 626 */
624 627
628void
625void copy_object(object *op2, object *op) { 629copy_object (object *op2, object *op)
626 int is_freed=QUERY_FLAG(op,FLAG_FREED),is_removed=QUERY_FLAG(op,FLAG_REMOVED); 630{
627 event *evt, *evt2, *evt_new; 631 bool is_freed = QUERY_FLAG (op, FLAG_FREED);
632 bool is_removed = QUERY_FLAG (op, FLAG_REMOVED);
628 633
629 op->clear ();
630
631 /* Decrement the refcounts, but don't bother zeroing the fields;
632 they'll be overwritten by memcpy. */
633 if(op->name!=NULL) free_string(op->name);
634 if(op->name_pl!=NULL) free_string(op->name_pl);
635 if(op->title!=NULL) free_string(op->title);
636 if(op->race!=NULL) free_string(op->race);
637 if(op->slaying!=NULL) free_string(op->slaying);
638 if(op->skill!=NULL) free_string(op->skill);
639 if(op->msg!=NULL) free_string(op->msg);
640 if(op->lore!=NULL) free_string(op->lore);
641 if(op->materialname != NULL) free_string(op->materialname);
642 if(op->custom_name != NULL) free_string(op->custom_name);
643
644 /* Basically, same code as from clear_object() */
645 for (evt = op->events; evt; evt=evt2) {
646 evt2 = evt->next;
647
648 if (evt->hook != NULL) FREE_AND_CLEAR_STR(evt->hook);
649 if (evt->plugin != NULL) FREE_AND_CLEAR_STR(evt->plugin);
650 if (evt->options != NULL) FREE_AND_CLEAR_STR(evt->options);
651
652 free(evt);
653 }
654 op->events = NULL;
655
656 free_key_values(op);
657
658 *(object_special *)op = *(object_special *)op2;
659 op2->clone (op); 634 op2->clone (op);
660 635
661 if(is_freed) SET_FLAG(op,FLAG_FREED); 636 if (is_freed)
662 if(is_removed) SET_FLAG(op,FLAG_REMOVED); 637 SET_FLAG (op, FLAG_FREED);
663 if(op->name!=NULL) add_refcount(op->name); 638 if (is_removed)
664 if(op->name_pl!=NULL) add_refcount(op->name_pl); 639 SET_FLAG (op, FLAG_REMOVED);
665 if(op->title!=NULL) add_refcount(op->title);
666 if(op->race!=NULL) add_refcount(op->race);
667 if(op->slaying!=NULL) add_refcount(op->slaying);
668 if(op->skill!=NULL) add_refcount(op->skill);
669 if(op->lore!=NULL) add_refcount(op->lore);
670 if(op->msg!=NULL) add_refcount(op->msg);
671 if(op->custom_name!=NULL) add_refcount(op->custom_name);
672 if (op->materialname != NULL) add_refcount(op->materialname);
673 640
674 if((op2->speed<0) && !editor) 641 if (op2->speed < 0)
675 op->speed_left=op2->speed_left-RANDOM()%200/100.0; 642 op->speed_left = op2->speed_left - RANDOM () % 200 / 100.0;
676 643
677 /* Copy over event information */
678 evt2 = NULL;
679 for (evt = op2->events; evt; evt=evt->next) {
680 evt_new = (event *) malloc(sizeof(event));
681 memcpy(evt_new, evt, sizeof(event));
682 if (evt_new->hook) add_refcount(evt_new->hook);
683 if (evt_new->plugin) add_refcount(evt_new->plugin);
684 if (evt_new->options) add_refcount(evt_new->options);
685 evt_new->next = NULL;
686
687 /* Try to be a little clever here, and store away the
688 * last event we copied, so that its simpler to update the
689 * pointer.
690 */
691 if (evt2)
692 evt2->next = evt_new;
693 else
694 op->events = evt_new;
695
696 evt2 = evt_new;
697 }
698 /* Copy over key_values, if any. */ 644 /* Copy over key_values, if any. */
699 if (op2->key_values != NULL) { 645 if (op2->key_values)
646 {
700 key_value * tail = NULL; 647 key_value *tail = 0;
701 key_value * i; 648 key_value *i;
702 649
703 op->key_values = NULL; 650 op->key_values = 0;
704 651
705 for (i = op2->key_values; i != NULL; i = i->next) { 652 for (i = op2->key_values; i; i = i->next)
706 key_value * new_link = (key_value *) malloc(sizeof(key_value)); 653 {
654 key_value *new_link = new key_value;
707 655
708 new_link->next = NULL; 656 new_link->next = 0;
709 new_link->key = add_refcount(i->key); 657 new_link->key = i->key;
710 if (i->value)
711 new_link->value = add_refcount(i->value); 658 new_link->value = i->value;
712 else
713 new_link->value = NULL;
714 659
715 /* Try and be clever here, too. */ 660 /* Try and be clever here, too. */
716 if (op->key_values == NULL) { 661 if (!op->key_values)
662 {
717 op->key_values = new_link; 663 op->key_values = new_link;
718 tail = new_link; 664 tail = new_link;
719 } else {
720 tail->next = new_link;
721 tail = new_link;
722 } 665 }
666 else
667 {
668 tail->next = new_link;
669 tail = new_link;
723 } 670 }
671 }
724 } 672 }
725 673
726 update_ob_speed(op); 674 update_ob_speed (op);
727}
728
729/*
730 * expand_objects() allocates more objects for the list of unused objects.
731 * It is called from get_object() if the unused list is empty.
732 */
733
734void expand_objects(void) {
735 int i;
736 object *obj;
737 obj = (object *) CALLOC(OBJ_EXPAND,sizeof(object));
738
739 if(obj==NULL)
740 fatal(OUT_OF_MEMORY);
741 free_objects=obj;
742 obj[0].prev=NULL;
743 obj[0].next= &obj[1],
744 SET_FLAG(&(obj[0]), FLAG_REMOVED);
745 SET_FLAG(&(obj[0]), FLAG_FREED);
746
747 for(i=1;i<OBJ_EXPAND-1;i++) {
748 obj[i].next= &obj[i+1],
749 obj[i].prev= &obj[i-1],
750 SET_FLAG(&(obj[i]), FLAG_REMOVED);
751 SET_FLAG(&(obj[i]), FLAG_FREED);
752 }
753 obj[OBJ_EXPAND-1].prev= &obj[OBJ_EXPAND-2],
754 obj[OBJ_EXPAND-1].next=NULL,
755 SET_FLAG(&(obj[OBJ_EXPAND-1]), FLAG_REMOVED);
756 SET_FLAG(&(obj[OBJ_EXPAND-1]), FLAG_FREED);
757
758 nrofallocobjects += OBJ_EXPAND;
759 nroffreeobjects += OBJ_EXPAND;
760}
761
762/*
763 * get_object() grabs an object from the list of unused objects, makes
764 * sure it is initialised, and returns it.
765 * If there are no free objects, expand_objects() is called to get more.
766 */
767
768object *get_object(void) {
769 object *op;
770
771 if(free_objects==NULL) {
772 expand_objects();
773 }
774 op=free_objects;
775#ifdef MEMORY_DEBUG
776 /* The idea is hopefully by doing a realloc, the memory
777 * debugging program will now use the current stack trace to
778 * report leaks.
779 */
780 op = realloc(op, sizeof(object));
781 SET_FLAG(op, FLAG_REMOVED);
782 SET_FLAG(op, FLAG_FREED);
783#endif
784
785 if(!QUERY_FLAG(op,FLAG_FREED)) {
786 LOG(llevError,"Fatal: Getting busy object.\n");
787 }
788 free_objects=op->next;
789 if(free_objects!=NULL)
790 free_objects->prev=NULL;
791 op->count= ++ob_count;
792 op->name=NULL;
793 op->name_pl=NULL;
794 op->title=NULL;
795 op->race=NULL;
796 op->slaying=NULL;
797 op->skill = NULL;
798 op->lore=NULL;
799 op->msg=NULL;
800 op->materialname=NULL;
801 op->next=objects;
802 op->prev=NULL;
803 op->active_next = NULL;
804 op->active_prev = NULL;
805 if(objects!=NULL)
806 objects->prev=op;
807 objects=op;
808 clear_object(op);
809 SET_FLAG(op,FLAG_REMOVED);
810 nroffreeobjects--;
811 return op;
812} 675}
813 676
814/* 677/*
815 * If an object with the IS_TURNABLE() flag needs to be turned due 678 * If an object with the IS_TURNABLE() flag needs to be turned due
816 * to the closest player being on the other side, this function can 679 * to the closest player being on the other side, this function can
817 * be called to update the face variable, _and_ how it looks on the map. 680 * be called to update the face variable, _and_ how it looks on the map.
818 */ 681 */
819 682
683void
820void update_turn_face(object *op) { 684update_turn_face (object *op)
685{
821 if(!QUERY_FLAG(op,FLAG_IS_TURNABLE)||op->arch==NULL) 686 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || op->arch == NULL)
822 return; 687 return;
823 SET_ANIMATION(op, op->direction); 688 SET_ANIMATION (op, op->direction);
824 update_object(op,UP_OBJ_FACE); 689 update_object (op, UP_OBJ_FACE);
825} 690}
826 691
827/* 692/*
828 * Updates the speed of an object. If the speed changes from 0 to another 693 * Updates the speed of an object. If the speed changes from 0 to another
829 * value, or vice versa, then add/remove the object from the active list. 694 * value, or vice versa, then add/remove the object from the active list.
830 * This function needs to be called whenever the speed of an object changes. 695 * This function needs to be called whenever the speed of an object changes.
831 */ 696 */
832 697
698void
833void update_ob_speed(object *op) { 699update_ob_speed (object *op)
700{
834 extern int arch_init; 701 extern int arch_init;
835 702
836 /* No reason putting the archetypes objects on the speed list, 703 /* No reason putting the archetypes objects on the speed list,
837 * since they never really need to be updated. 704 * since they never really need to be updated.
838 */ 705 */
839 706
840 if (QUERY_FLAG(op, FLAG_FREED) && op->speed) { 707 if (QUERY_FLAG (op, FLAG_FREED) && op->speed)
708 {
841 LOG(llevError,"Object %s is freed but has speed.\n", op->name); 709 LOG (llevError, "Object %s is freed but has speed.\n", &op->name);
842#ifdef MANY_CORES 710#ifdef MANY_CORES
843 abort(); 711 abort ();
844#else 712#else
845 op->speed = 0; 713 op->speed = 0;
846#endif 714#endif
847 } 715 }
848 if (arch_init) { 716 if (arch_init)
717 {
718 return;
719 }
720 if (FABS (op->speed) > MIN_ACTIVE_SPEED)
721 {
722 /* If already on active list, don't do anything */
723 if (op->active_next || op->active_prev || op == active_objects)
849 return; 724 return;
850 }
851 if (FABS(op->speed)>MIN_ACTIVE_SPEED) {
852 /* If already on active list, don't do anything */
853 if (op->active_next || op->active_prev || op==active_objects)
854 return;
855 725
856 /* process_events() expects us to insert the object at the beginning 726 /* process_events() expects us to insert the object at the beginning
857 * of the list. */ 727 * of the list. */
858 op->active_next = active_objects; 728 op->active_next = active_objects;
859 if (op->active_next!=NULL) 729 if (op->active_next != NULL)
860 op->active_next->active_prev = op; 730 op->active_next->active_prev = op;
861 active_objects = op; 731 active_objects = op;
732 }
733 else
862 } 734 {
863 else {
864 /* If not on the active list, nothing needs to be done */ 735 /* If not on the active list, nothing needs to be done */
865 if (!op->active_next && !op->active_prev && op!=active_objects) 736 if (!op->active_next && !op->active_prev && op != active_objects)
866 return; 737 return;
867 738
868 if (op->active_prev==NULL) { 739 if (op->active_prev == NULL)
740 {
869 active_objects = op->active_next; 741 active_objects = op->active_next;
870 if (op->active_next!=NULL) 742 if (op->active_next != NULL)
871 op->active_next->active_prev = NULL; 743 op->active_next->active_prev = NULL;
744 }
745 else
872 } 746 {
873 else {
874 op->active_prev->active_next = op->active_next; 747 op->active_prev->active_next = op->active_next;
875 if (op->active_next) 748 if (op->active_next)
876 op->active_next->active_prev = op->active_prev; 749 op->active_next->active_prev = op->active_prev;
877 } 750 }
878 op->active_next = NULL; 751 op->active_next = NULL;
879 op->active_prev = NULL; 752 op->active_prev = NULL;
880 } 753 }
881} 754}
882 755
883/* This function removes object 'op' from the list of active 756/* This function removes object 'op' from the list of active
884 * objects. 757 * objects.
… …
886 * reference maps where you don't want an object that isn't 759 * reference maps where you don't want an object that isn't
887 * in play chewing up cpu time getting processed. 760 * in play chewing up cpu time getting processed.
888 * The reverse of this is to call update_ob_speed, which 761 * The reverse of this is to call update_ob_speed, which
889 * will do the right thing based on the speed of the object. 762 * will do the right thing based on the speed of the object.
890 */ 763 */
764void
891void remove_from_active_list(object *op) 765remove_from_active_list (object *op)
892{ 766{
893 /* If not on the active list, nothing needs to be done */ 767 /* If not on the active list, nothing needs to be done */
894 if (!op->active_next && !op->active_prev && op!=active_objects) 768 if (!op->active_next && !op->active_prev && op != active_objects)
895 return; 769 return;
896 770
897 if (op->active_prev==NULL) { 771 if (op->active_prev == NULL)
772 {
898 active_objects = op->active_next; 773 active_objects = op->active_next;
899 if (op->active_next!=NULL) 774 if (op->active_next != NULL)
900 op->active_next->active_prev = NULL; 775 op->active_next->active_prev = NULL;
776 }
777 else
901 } 778 {
902 else {
903 op->active_prev->active_next = op->active_next; 779 op->active_prev->active_next = op->active_next;
904 if (op->active_next) 780 if (op->active_next)
905 op->active_next->active_prev = op->active_prev; 781 op->active_next->active_prev = op->active_prev;
906 } 782 }
907 op->active_next = NULL; 783 op->active_next = NULL;
908 op->active_prev = NULL; 784 op->active_prev = NULL;
909} 785}
910 786
911/* 787/*
912 * update_object() updates the array which represents the map. 788 * update_object() updates the array which represents the map.
913 * It takes into account invisible objects (and represent squares covered 789 * It takes into account invisible objects (and represent squares covered
… …
928 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update 804 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update
929 * as that is easier than trying to look at what may have changed. 805 * as that is easier than trying to look at what may have changed.
930 * UP_OBJ_FACE: only the objects face has changed. 806 * UP_OBJ_FACE: only the objects face has changed.
931 */ 807 */
932 808
809void
933void update_object(object *op, int action) { 810update_object (object *op, int action)
811{
934 int update_now=0, flags; 812 int update_now = 0, flags;
935 MoveType move_on, move_off, move_block, move_slow; 813 MoveType move_on, move_off, move_block, move_slow;
936 814
937 if (op == NULL) { 815 if (op == NULL)
816 {
938 /* this should never happen */ 817 /* this should never happen */
939 LOG(llevDebug,"update_object() called for NULL object.\n"); 818 LOG (llevDebug, "update_object() called for NULL object.\n");
940 return; 819 return;
941 }
942 820 }
821
943 if(op->env!=NULL) { 822 if (op->env != NULL)
823 {
944 /* Animation is currently handled by client, so nothing 824 /* Animation is currently handled by client, so nothing
945 * to do in this case. 825 * to do in this case.
946 */ 826 */
947 return; 827 return;
948 } 828 }
949 829
950 /* If the map is saving, don't do anything as everything is 830 /* If the map is saving, don't do anything as everything is
951 * going to get freed anyways. 831 * going to get freed anyways.
952 */ 832 */
953 if (!op->map || op->map->in_memory == MAP_SAVING) return; 833 if (!op->map || op->map->in_memory == MAP_SAVING)
954 834 return;
835
955 /* make sure the object is within map boundaries */ 836 /* make sure the object is within map boundaries */
956 if (op->x < 0 || op->x >= MAP_WIDTH(op->map) || 837 if (op->x < 0 || op->x >= MAP_WIDTH (op->map) || op->y < 0 || op->y >= MAP_HEIGHT (op->map))
957 op->y < 0 || op->y >= MAP_HEIGHT(op->map)) { 838 {
958 LOG(llevError,"update_object() called for object out of map!\n"); 839 LOG (llevError, "update_object() called for object out of map!\n");
959#ifdef MANY_CORES 840#ifdef MANY_CORES
960 abort(); 841 abort ();
961#endif 842#endif
962 return; 843 return;
963 }
964 844 }
845
965 flags = GET_MAP_FLAGS(op->map, op->x, op->y); 846 flags = GET_MAP_FLAGS (op->map, op->x, op->y);
966 SET_MAP_FLAGS(op->map, op->x, op->y, flags | P_NEED_UPDATE); 847 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NEED_UPDATE);
967 move_slow = GET_MAP_MOVE_SLOW(op->map, op->x, op->y); 848 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
968 move_on = GET_MAP_MOVE_ON(op->map, op->x, op->y); 849 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
969 move_block = GET_MAP_MOVE_BLOCK(op->map, op->x, op->y); 850 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
970 move_off = GET_MAP_MOVE_OFF(op->map, op->x, op->y); 851 move_off = GET_MAP_MOVE_OFF (op->map, op->x, op->y);
971 852
972 if (action == UP_OBJ_INSERT) { 853 if (action == UP_OBJ_INSERT)
854 {
973 if (QUERY_FLAG(op, FLAG_BLOCKSVIEW) && !(flags & P_BLOCKSVIEW)) 855 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(flags & P_BLOCKSVIEW))
974 update_now=1; 856 update_now = 1;
975 857
976 if (QUERY_FLAG(op, FLAG_NO_MAGIC) && !(flags & P_NO_MAGIC)) 858 if (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(flags & P_NO_MAGIC))
977 update_now=1; 859 update_now = 1;
978 860
979 if (QUERY_FLAG(op, FLAG_DAMNED) && !(flags & P_NO_CLERIC)) 861 if (QUERY_FLAG (op, FLAG_DAMNED) && !(flags & P_NO_CLERIC))
980 update_now=1; 862 update_now = 1;
981 863
982 if (QUERY_FLAG(op, FLAG_ALIVE) && !(flags & P_IS_ALIVE)) 864 if (QUERY_FLAG (op, FLAG_ALIVE) && !(flags & P_IS_ALIVE))
983 update_now=1; 865 update_now = 1;
984 866
867 if (op->type == SAFE_GROUND && !(flags & P_SAFE))
868 update_now = 1;
869
985 if ((move_on | op->move_on) != move_on) update_now=1; 870 if ((move_on | op->move_on) != move_on)
871 update_now = 1;
872
986 if ((move_off | op->move_off) != move_off) update_now=1; 873 if ((move_off | op->move_off) != move_off)
874 update_now = 1;
875
987 /* This isn't perfect, but I don't expect a lot of objects to 876 /* This isn't perfect, but I don't expect a lot of objects to
988 * to have move_allow right now. 877 * to have move_allow right now.
989 */ 878 */
990 if (((move_block | op->move_block) & ~op->move_allow) != move_block) 879 if (((move_block | op->move_block) & ~op->move_allow) != move_block)
991 update_now=1; 880 update_now = 1;
881
992 if ((move_slow | op->move_slow) != move_slow) update_now=1; 882 if ((move_slow | op->move_slow) != move_slow)
883 update_now = 1;
993 } 884 }
994 /* if the object is being removed, we can't make intelligent 885 /* if the object is being removed, we can't make intelligent
995 * decisions, because remove_ob can't really pass the object 886 * decisions, because remove_ob can't really pass the object
996 * that is being removed. 887 * that is being removed.
997 */ 888 */
998 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) { 889 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
999 update_now=1; 890 update_now = 1;
1000 } else if (action == UP_OBJ_FACE) { 891 else if (action == UP_OBJ_FACE)
1001 /* Nothing to do for that case */ 892 /* Nothing to do for that case */ ;
1002 }
1003 else { 893 else
1004 LOG(llevError,"update_object called with invalid action: %d\n", action); 894 LOG (llevError, "update_object called with invalid action: %d\n", action);
1005 }
1006 895
1007 if (update_now) { 896 if (update_now)
897 {
1008 SET_MAP_FLAGS(op->map, op->x, op->y, flags | P_NO_ERROR | P_NEED_UPDATE); 898 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NO_ERROR | P_NEED_UPDATE);
1009 update_position(op->map, op->x, op->y); 899 update_position (op->map, op->x, op->y);
1010 } 900 }
1011 901
1012 if(op->more!=NULL) 902 if (op->more != NULL)
1013 update_object(op->more, action); 903 update_object (op->more, action);
1014} 904}
1015 905
906static unordered_vector < object *>mortals;
907static
908std::vector < object *>
909 freed;
910
911void object::free_mortals ()
912{
913 for (unordered_vector < object *>::iterator i = mortals.begin (); i != mortals.end ();)
914 if (!(*i)->refcount)
915 {
916 freed.push_back (*i);
917 mortals.erase (i);
918 }
919 else
920 ++i;
921}
922
923object::object ()
924{
925 SET_FLAG (this, FLAG_REMOVED);
926
927 expmul = 1.0;
928 face = blank_face;
929 attacked_by_count = -1;
930}
931
932object::~object ()
933{
934 free_key_values (this);
935}
936
937void object::link ()
938{
939 count = ++ob_count;
940
941 prev = 0;
942 next = objects;
943
944 if (objects)
945 objects->prev = this;
946
947 objects = this;
948}
949
950void object::unlink ()
951{
952 count = 0;
953
954 /* Remove this object from the list of used objects */
955 if (prev)
956 {
957 prev->next = next;
958 prev = 0;
959 }
960
961 if (next)
962 {
963 next->prev = prev;
964 next = 0;
965 }
966
967 if (this == objects)
968 objects = next;
969}
970
971object *object::create ()
972{
973 object *
974 op;
975
976 if (freed.empty ())
977 op = new object;
978
979 else
980 {
981 // highly annoying, but the only way to get it stable right now
982 op = freed.back ();
983 freed.pop_back ();
984 op->~object ();
985 new ((void *) op) object;
986 }
987
988 op->link ();
989 return op;
990}
1016 991
1017/* 992/*
1018 * free_object() frees everything allocated by an object, removes 993 * free_object() frees everything allocated by an object, removes
1019 * it from the list of used objects, and puts it on the list of 994 * it from the list of used objects, and puts it on the list of
1020 * free objects. The IS_FREED() flag is set in the object. 995 * free objects. The IS_FREED() flag is set in the object.
… …
1022 * this function to succeed. 997 * this function to succeed.
1023 * 998 *
1024 * If free_inventory is set, free inventory as well. Else drop items in 999 * If free_inventory is set, free inventory as well. Else drop items in
1025 * inventory to the ground. 1000 * inventory to the ground.
1026 */ 1001 */
1027 1002void object::free (bool free_inventory)
1028void free_object(object *ob) { 1003{
1029 free_object2(ob, 0);
1030}
1031void free_object2(object *ob, int free_inventory) {
1032 object *tmp,*op;
1033
1034 ob->clear ();
1035
1036 if (!QUERY_FLAG(ob,FLAG_REMOVED)) {
1037 LOG(llevDebug,"Free object called with non removed object\n");
1038 dump_object(ob);
1039#ifdef MANY_CORES
1040 abort();
1041#endif
1042 }
1043 if(QUERY_FLAG(ob,FLAG_FRIENDLY)) {
1044 LOG(llevMonster,"Warning: tried to free friendly object.\n");
1045 remove_friendly_object(ob);
1046 }
1047 if(QUERY_FLAG(ob,FLAG_FREED)) { 1004 if (QUERY_FLAG (this, FLAG_FREED))
1048 dump_object(ob);
1049 LOG(llevError,"Trying to free freed object.\n%s\n",errmsg);
1050 return; 1005 return;
1006
1007 if (!QUERY_FLAG (this, FLAG_REMOVED))
1008 remove_ob (this);
1009
1010 if (QUERY_FLAG (this, FLAG_FRIENDLY))
1011 remove_friendly_object (this);
1012
1013 SET_FLAG (this, FLAG_FREED);
1014
1015 if (more)
1051 } 1016 {
1052 if(ob->more!=NULL) { 1017 more->free (free_inventory);
1053 free_object2(ob->more, free_inventory); 1018 more = 0;
1054 ob->more=NULL; 1019 }
1020
1021 if (inv)
1055 } 1022 {
1056 if (ob->inv) {
1057 /* Only if the space blocks everything do we not process - 1023 /* Only if the space blocks everything do we not process -
1058 * if some form of movemnt is allowed, let objects 1024 * if some form of movement is allowed, let objects
1059 * drop on that space. 1025 * drop on that space.
1060 */ 1026 */
1061 if (free_inventory || ob->map==NULL || ob->map->in_memory!=MAP_IN_MEMORY || 1027 if (free_inventory || !map || map->in_memory != MAP_IN_MEMORY || (GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL))
1062 (GET_MAP_MOVE_BLOCK(ob->map, ob->x, ob->y) == MOVE_ALL)) 1028 {
1029 object *op = inv;
1030
1031 while (op)
1063 { 1032 {
1064 op=ob->inv;
1065 while(op!=NULL) {
1066 tmp=op->below; 1033 object *tmp = op->below;
1067 remove_ob(op);
1068 free_object2(op, free_inventory); 1034 op->free (free_inventory);
1069 op=tmp; 1035 op = tmp;
1070 } 1036 }
1071 } 1037 }
1038 else
1072 else { /* Put objects in inventory onto this space */ 1039 { /* Put objects in inventory onto this space */
1073 op=ob->inv; 1040 object *op = inv;
1041
1074 while(op!=NULL) { 1042 while (op)
1043 {
1075 tmp=op->below; 1044 object *tmp = op->below;
1045
1076 remove_ob(op); 1046 remove_ob (op);
1077 if(QUERY_FLAG(op,FLAG_STARTEQUIP)||QUERY_FLAG(op,FLAG_NO_DROP) || 1047
1078 op->type==RUNE || op->type==TRAP || QUERY_FLAG(op,FLAG_IS_A_TEMPLATE)) 1048 if (QUERY_FLAG (op, FLAG_STARTEQUIP)
1049 || QUERY_FLAG (op, FLAG_NO_DROP) || op->type == RUNE || op->type == TRAP || QUERY_FLAG (op, FLAG_IS_A_TEMPLATE))
1079 free_object(op); 1050 free_object (op);
1080 else { 1051 else
1052 {
1081 op->x=ob->x; 1053 op->x = x;
1082 op->y=ob->y; 1054 op->y = y;
1083 insert_ob_in_map(op,ob->map,NULL,0); /* Insert in same map as the envir */ 1055 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
1084 } 1056 }
1057
1085 op=tmp; 1058 op = tmp;
1086 } 1059 }
1087 } 1060 }
1088 } 1061 }
1062
1063 clear_owner (this);
1064
1089 /* Remove object from the active list */ 1065 /* Remove object from the active list */
1090 ob->speed = 0; 1066 speed = 0;
1091 update_ob_speed(ob); 1067 update_ob_speed (this);
1092 1068
1093 SET_FLAG(ob, FLAG_FREED); 1069 unlink ();
1094 ob->count = 0;
1095 1070
1096 /* Remove this object from the list of used objects */ 1071 mortals.push_back (this);
1097 if(ob->prev==NULL) {
1098 objects=ob->next;
1099 if(objects!=NULL)
1100 objects->prev=NULL;
1101 }
1102 else {
1103 ob->prev->next=ob->next;
1104 if(ob->next!=NULL)
1105 ob->next->prev=ob->prev;
1106 }
1107
1108 if(ob->name!=NULL) FREE_AND_CLEAR_STR(ob->name);
1109 if(ob->name_pl!=NULL) FREE_AND_CLEAR_STR(ob->name_pl);
1110 if(ob->title!=NULL) FREE_AND_CLEAR_STR(ob->title);
1111 if(ob->race!=NULL) FREE_AND_CLEAR_STR(ob->race);
1112 if(ob->slaying!=NULL) FREE_AND_CLEAR_STR(ob->slaying);
1113 if(ob->skill!=NULL) FREE_AND_CLEAR_STR(ob->skill);
1114 if(ob->lore!=NULL) FREE_AND_CLEAR_STR(ob->lore);
1115 if(ob->msg!=NULL) FREE_AND_CLEAR_STR(ob->msg);
1116 if(ob->materialname!=NULL) FREE_AND_CLEAR_STR(ob->materialname);
1117
1118
1119 /* Why aren't events freed? */
1120 free_key_values(ob);
1121
1122#if 0 /* MEMORY_DEBUG*/
1123 /* This is a nice idea. Unfortunately, a lot of the code in crossfire
1124 * presumes the freed_object will stick around for at least a little
1125 * bit
1126 */
1127 /* this is necessary so that memory debugging programs will
1128 * be able to accurately report source of malloc. If we recycle
1129 * objects, then some other area may be doing the get_object
1130 * and not freeing it, but the original one that malloc'd the
1131 * object will get the blame.
1132 */
1133 free(ob);
1134#else
1135
1136 /* Now link it with the free_objects list: */
1137 ob->prev=NULL;
1138 ob->next=free_objects;
1139 if(free_objects!=NULL)
1140 free_objects->prev=ob;
1141 free_objects=ob;
1142 nroffreeobjects++;
1143#endif
1144}
1145
1146/*
1147 * count_free() returns the number of objects on the list of free objects.
1148 */
1149
1150int count_free(void) {
1151 int i=0;
1152 object *tmp=free_objects;
1153 while(tmp!=NULL)
1154 tmp=tmp->next, i++;
1155 return i;
1156}
1157
1158/*
1159 * count_used() returns the number of objects on the list of used objects.
1160 */
1161
1162int count_used(void) {
1163 int i=0;
1164 object *tmp=objects;
1165 while(tmp!=NULL)
1166 tmp=tmp->next, i++;
1167 return i;
1168}
1169
1170/*
1171 * count_active() returns the number of objects on the list of active objects.
1172 */
1173
1174int count_active(void) {
1175 int i=0;
1176 object *tmp=active_objects;
1177 while(tmp!=NULL)
1178 tmp=tmp->active_next, i++;
1179 return i;
1180} 1072}
1181 1073
1182/* 1074/*
1183 * sub_weight() recursively (outwards) subtracts a number from the 1075 * sub_weight() recursively (outwards) subtracts a number from the
1184 * weight of an object (and what is carried by it's environment(s)). 1076 * weight of an object (and what is carried by it's environment(s)).
1185 */ 1077 */
1186 1078
1079void
1187void sub_weight (object *op, signed long weight) { 1080sub_weight (object *op, signed long weight)
1081{
1188 while (op != NULL) { 1082 while (op != NULL)
1083 {
1189 if (op->type == CONTAINER) { 1084 if (op->type == CONTAINER)
1085 {
1190 weight=(signed long)(weight*(100-op->stats.Str)/100); 1086 weight = (signed long) (weight * (100 - op->stats.Str) / 100);
1191 } 1087 }
1192 op->carrying-=weight; 1088 op->carrying -= weight;
1193 op = op->env; 1089 op = op->env;
1194 } 1090 }
1195} 1091}
1196 1092
1197/* remove_ob(op): 1093/* remove_ob(op):
1198 * This function removes the object op from the linked list of objects 1094 * This function removes the object op from the linked list of objects
1199 * which it is currently tied to. When this function is done, the 1095 * which it is currently tied to. When this function is done, the
… …
1201 * environment, the x and y coordinates will be updated to 1097 * environment, the x and y coordinates will be updated to
1202 * the previous environment. 1098 * the previous environment.
1203 * Beware: This function is called from the editor as well! 1099 * Beware: This function is called from the editor as well!
1204 */ 1100 */
1205 1101
1102void
1206void remove_ob(object *op) { 1103remove_ob (object *op)
1207 object *tmp,*last=NULL; 1104{
1208 object *otmp; 1105 object *
1209 tag_t tag; 1106 tmp, *
1107 last = NULL;
1108 object *
1109 otmp;
1110
1111 tag_t
1112 tag;
1113 int
1210 int check_walk_off; 1114 check_walk_off;
1211 mapstruct *m; 1115 mapstruct *
1212 sint16 x,y;
1213 1116 m;
1214 1117
1118 sint16
1119 x,
1120 y;
1121
1215 if(QUERY_FLAG(op,FLAG_REMOVED)) { 1122 if (QUERY_FLAG (op, FLAG_REMOVED))
1216 dump_object(op); 1123 return;
1217 LOG(llevError,"Trying to remove removed object.\n%s\n",errmsg);
1218 1124
1219 /* Changed it to always dump core in this case. As has been learned
1220 * in the past, trying to recover from errors almost always
1221 * make things worse, and this is a real error here - something
1222 * that should not happen.
1223 * Yes, if this was a mission critical app, trying to do something
1224 * to recover may make sense, but that is because failure of the app
1225 * may have other disastrous problems. Cf runs out of a script
1226 * so is easily enough restarted without any real problems.
1227 * MSW 2001-07-01
1228 */
1229 abort();
1230 }
1231 if(op->more!=NULL)
1232 remove_ob(op->more);
1233
1234 SET_FLAG(op, FLAG_REMOVED); 1125 SET_FLAG (op, FLAG_REMOVED);
1235 1126
1127 if (op->more != NULL)
1128 remove_ob (op->more);
1129
1236 /* 1130 /*
1237 * In this case, the object to be removed is in someones 1131 * In this case, the object to be removed is in someones
1238 * inventory. 1132 * inventory.
1239 */ 1133 */
1240 if(op->env!=NULL) { 1134 if (op->env != NULL)
1135 {
1241 if(op->nrof) 1136 if (op->nrof)
1242 sub_weight(op->env, op->weight*op->nrof); 1137 sub_weight (op->env, op->weight * op->nrof);
1243 else 1138 else
1244 sub_weight(op->env, op->weight+op->carrying); 1139 sub_weight (op->env, op->weight + op->carrying);
1245 1140
1246 /* NO_FIX_PLAYER is set when a great many changes are being 1141 /* NO_FIX_PLAYER is set when a great many changes are being
1247 * made to players inventory. If set, avoiding the call 1142 * made to players inventory. If set, avoiding the call
1248 * to save cpu time. 1143 * to save cpu time.
1249 */ 1144 */
1250 if ((otmp=is_player_inv(op->env))!=NULL && otmp->contr && 1145 if ((otmp = is_player_inv (op->env)) != NULL && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1251 !QUERY_FLAG(otmp,FLAG_NO_FIX_PLAYER))
1252 fix_player(otmp); 1146 fix_player (otmp);
1253 1147
1254 if(op->above!=NULL) 1148 if (op->above != NULL)
1255 op->above->below=op->below; 1149 op->above->below = op->below;
1256 else 1150 else
1257 op->env->inv=op->below; 1151 op->env->inv = op->below;
1258 1152
1259 if(op->below!=NULL) 1153 if (op->below != NULL)
1260 op->below->above=op->above; 1154 op->below->above = op->above;
1261 1155
1262 /* we set up values so that it could be inserted into 1156 /* we set up values so that it could be inserted into
1263 * the map, but we don't actually do that - it is up 1157 * the map, but we don't actually do that - it is up
1264 * to the caller to decide what we want to do. 1158 * to the caller to decide what we want to do.
1265 */ 1159 */
1266 op->x=op->env->x,op->y=op->env->y; 1160 op->x = op->env->x, op->y = op->env->y;
1267 op->ox=op->x,op->oy=op->y;
1268 op->map=op->env->map; 1161 op->map = op->env->map;
1269 op->above=NULL,op->below=NULL; 1162 op->above = NULL, op->below = NULL;
1270 op->env=NULL; 1163 op->env = NULL;
1164 }
1165 else if (op->map)
1166 {
1167 x = op->x;
1168 y = op->y;
1169 m = get_map_from_coord (op->map, &x, &y);
1170
1171 if (!m)
1172 {
1173 LOG (llevError, "remove_ob called when object was on map but appears to not be within valid coordinates? %s (%d,%d)\n",
1174 op->map->path, op->x, op->y);
1175 /* in old days, we used to set x and y to 0 and continue.
1176 * it seems if we get into this case, something is probablye
1177 * screwed up and should be fixed.
1178 */
1179 abort ();
1180 }
1181
1182 if (op->map != m)
1183 LOG (llevDebug, "remove_ob: Object not really on map it claimed to be on? %s != %s, %d,%d != %d,%d\n",
1184 op->map->path, m->path, op->x, op->y, x, y);
1185
1186 /* Re did the following section of code - it looks like it had
1187 * lots of logic for things we no longer care about
1188 */
1189
1190 /* link the object above us */
1191 if (op->above)
1192 op->above->below = op->below;
1193 else
1194 SET_MAP_TOP (m, x, y, op->below); /* we were top, set new top */
1195
1196 /* Relink the object below us, if there is one */
1197 if (op->below)
1198 op->below->above = op->above;
1199 else
1200 {
1201 /* Nothing below, which means we need to relink map object for this space
1202 * use translated coordinates in case some oddness with map tiling is
1203 * evident
1204 */
1205 if (GET_MAP_OB (m, x, y) != op)
1206 {
1207 dump_object (op);
1208 LOG (llevError,
1209 "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", errmsg);
1210 dump_object (GET_MAP_OB (m, x, y));
1211 LOG (llevError, "%s\n", errmsg);
1212 }
1213
1214 SET_MAP_OB (m, x, y, op->above); /* goes on above it. */
1215 }
1216
1217 op->above = 0;
1218 op->below = 0;
1219
1220 if (op->map->in_memory == MAP_SAVING)
1271 return; 1221 return;
1272 }
1273 1222
1274 /* If we get here, we are removing it from a map */
1275 if (op->map == NULL) return;
1276
1277 x = op->x;
1278 y = op->y;
1279 m = get_map_from_coord(op->map, &x, &y);
1280
1281 if (!m) {
1282 LOG(llevError,"remove_ob called when object was on map but appears to not be within valid coordinates? %s (%d,%d)\n",
1283 op->map->path, op->x, op->y);
1284 /* in old days, we used to set x and y to 0 and continue.
1285 * it seems if we get into this case, something is probablye
1286 * screwed up and should be fixed.
1287 */
1288 abort();
1289 }
1290 if (op->map != m) {
1291 LOG(llevDebug,"remove_ob: Object not really on map it claimed to be on? %s != %s, %d,%d != %d,%d\n",
1292 op->map->path, m->path, op->x, op->y, x, y);
1293 }
1294
1295 /* Re did the following section of code - it looks like it had
1296 * lots of logic for things we no longer care about
1297 */
1298
1299 /* link the object above us */
1300 if (op->above)
1301 op->above->below=op->below;
1302 else
1303 SET_MAP_TOP(m,x,y,op->below); /* we were top, set new top */
1304
1305 /* Relink the object below us, if there is one */
1306 if(op->below) {
1307 op->below->above=op->above;
1308 } else {
1309 /* Nothing below, which means we need to relink map object for this space
1310 * use translated coordinates in case some oddness with map tiling is
1311 * evident
1312 */
1313 if(GET_MAP_OB(m,x,y)!=op) {
1314 dump_object(op);
1315 LOG(llevError,"remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", errmsg);
1316 dump_object(GET_MAP_OB(m,x,y));
1317 LOG(llevError,"%s\n",errmsg);
1318 }
1319 SET_MAP_OB(m,x,y,op->above); /* goes on above it. */
1320 }
1321 op->above=NULL;
1322 op->below=NULL;
1323
1324 if (op->map->in_memory == MAP_SAVING)
1325 return;
1326
1327 tag = op->count; 1223 tag = op->count;
1328 check_walk_off = ! QUERY_FLAG (op, FLAG_NO_APPLY); 1224 check_walk_off = !QUERY_FLAG (op, FLAG_NO_APPLY);
1225
1329 for(tmp=GET_MAP_OB(m,x,y);tmp!=NULL;tmp=tmp->above) { 1226 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above)
1227 {
1330 /* No point updating the players look faces if he is the object 1228 /* No point updating the players look faces if he is the object
1331 * being removed. 1229 * being removed.
1332 */ 1230 */
1333 1231
1334 if(tmp->type==PLAYER && tmp!=op) { 1232 if (tmp->type == PLAYER && tmp != op)
1233 {
1335 /* If a container that the player is currently using somehow gets 1234 /* If a container that the player is currently using somehow gets
1336 * removed (most likely destroyed), update the player view 1235 * removed (most likely destroyed), update the player view
1337 * appropriately. 1236 * appropriately.
1338 */ 1237 */
1339 if (tmp->container==op) { 1238 if (tmp->container == op)
1239 {
1340 CLEAR_FLAG(op, FLAG_APPLIED); 1240 CLEAR_FLAG (op, FLAG_APPLIED);
1341 tmp->container=NULL; 1241 tmp->container = NULL;
1242 }
1243
1244 tmp->contr->socket.update_look = 1;
1342 } 1245 }
1343 tmp->contr->socket.update_look=1; 1246
1344 }
1345 /* See if player moving off should effect something */ 1247 /* See if player moving off should effect something */
1346 if (check_walk_off && ((op->move_type & tmp->move_off) && 1248 if (check_walk_off && ((op->move_type & tmp->move_off) && (op->move_type & ~tmp->move_off & ~tmp->move_block) == 0))
1347 (op->move_type & ~tmp->move_off & ~tmp->move_block)==0)) { 1249 {
1348
1349 move_apply(tmp, op, NULL); 1250 move_apply (tmp, op, NULL);
1251
1350 if (was_destroyed (op, tag)) { 1252 if (was_destroyed (op, tag))
1253 {
1351 LOG (llevError, "BUG: remove_ob(): name %s, archname %s destroyed " 1254 LOG (llevError, "BUG: remove_ob(): name %s, archname %s destroyed " "leaving object\n", &tmp->name, &tmp->arch->name);
1352 "leaving object\n", tmp->name, tmp->arch->name); 1255 }
1353 } 1256 }
1354 }
1355 1257
1356 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */ 1258 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */
1357 1259
1358 if(tmp->above == tmp) 1260 if (tmp->above == tmp)
1359 tmp->above = NULL; 1261 tmp->above = NULL;
1262
1360 last=tmp; 1263 last = tmp;
1361 } 1264 }
1265
1362 /* last == NULL of there are no objects on this space */ 1266 /* last == NULL of there are no objects on this space */
1363 if (last==NULL) { 1267 if (last == NULL)
1268 {
1364 /* set P_NEED_UPDATE, otherwise update_position will complain. In theory, 1269 /* set P_NEED_UPDATE, otherwise update_position will complain. In theory,
1365 * we could preserve the flags (GET_MAP_FLAGS), but update_position figures 1270 * we could preserve the flags (GET_MAP_FLAGS), but update_position figures
1366 * those out anyways, and if there are any flags set right now, they won't 1271 * those out anyways, and if there are any flags set right now, they won't
1367 * be correct anyways. 1272 * be correct anyways.
1368 */ 1273 */
1369 SET_MAP_FLAGS(op->map, op->x, op->y, P_NEED_UPDATE); 1274 SET_MAP_FLAGS (op->map, op->x, op->y, P_NEED_UPDATE);
1370 update_position(op->map, op->x, op->y); 1275 update_position (op->map, op->x, op->y);
1371 } 1276 }
1372 else 1277 else
1373 update_object(last, UP_OBJ_REMOVE); 1278 update_object (last, UP_OBJ_REMOVE);
1374 1279
1375 if(QUERY_FLAG(op,FLAG_BLOCKSVIEW)|| (op->glow_radius != 0)) 1280 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) || (op->glow_radius != 0))
1376 update_all_los(op->map, op->x, op->y); 1281 update_all_los (op->map, op->x, op->y);
1377 1282 }
1378} 1283}
1379 1284
1380/* 1285/*
1381 * merge_ob(op,top): 1286 * merge_ob(op,top):
1382 * 1287 *
… …
1384 * merges op to the first matching object. 1289 * merges op to the first matching object.
1385 * If top is NULL, it is calculated. 1290 * If top is NULL, it is calculated.
1386 * Returns pointer to object if it succeded in the merge, otherwise NULL 1291 * Returns pointer to object if it succeded in the merge, otherwise NULL
1387 */ 1292 */
1388 1293
1294object *
1389object *merge_ob(object *op, object *top) { 1295merge_ob (object *op, object *top)
1296{
1390 if(!op->nrof) 1297 if (!op->nrof)
1391 return 0; 1298 return 0;
1299
1392 if(top==NULL) 1300 if (top == NULL)
1393 for(top=op;top!=NULL&&top->above!=NULL;top=top->above); 1301 for (top = op; top != NULL && top->above != NULL; top = top->above);
1302
1394 for(;top!=NULL;top=top->below) { 1303 for (; top != NULL; top = top->below)
1304 {
1395 if(top==op) 1305 if (top == op)
1396 continue; 1306 continue;
1397 if (CAN_MERGE(op,top)) 1307 if (CAN_MERGE (op, top))
1398 { 1308 {
1399 top->nrof+=op->nrof; 1309 top->nrof += op->nrof;
1310
1400/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/ 1311/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/
1401 op->weight = 0; /* Don't want any adjustements now */ 1312 op->weight = 0; /* Don't want any adjustements now */
1402 remove_ob(op); 1313 remove_ob (op);
1403 free_object(op); 1314 free_object (op);
1404 return top; 1315 return top;
1405 } 1316 }
1406 } 1317 }
1318
1407 return NULL; 1319 return NULL;
1408} 1320}
1409 1321
1410/* 1322/*
1411 * same as insert_ob_in_map except it handle separate coordinates and do a clean 1323 * same as insert_ob_in_map except it handle separate coordinates and do a clean
1412 * job preparing multi-part monsters 1324 * job preparing multi-part monsters
1413 */ 1325 */
1326object *
1414object *insert_ob_in_map_at(object *op, mapstruct *m, object *originator, int flag, int x, int y){ 1327insert_ob_in_map_at (object *op, mapstruct *m, object *originator, int flag, int x, int y)
1328{
1415 object* tmp; 1329 object *tmp;
1330
1416 if (op->head) 1331 if (op->head)
1417 op=op->head; 1332 op = op->head;
1333
1418 for (tmp=op;tmp;tmp=tmp->more){ 1334 for (tmp = op; tmp; tmp = tmp->more)
1335 {
1419 tmp->x=x+tmp->arch->clone.x; 1336 tmp->x = x + tmp->arch->clone.x;
1420 tmp->y=y+tmp->arch->clone.y; 1337 tmp->y = y + tmp->arch->clone.y;
1421 } 1338 }
1339
1422 return insert_ob_in_map (op, m, originator, flag); 1340 return insert_ob_in_map (op, m, originator, flag);
1423} 1341}
1424 1342
1425/* 1343/*
1426 * insert_ob_in_map (op, map, originator, flag): 1344 * insert_ob_in_map (op, map, originator, flag):
1427 * This function inserts the object in the two-way linked list 1345 * This function inserts the object in the two-way linked list
… …
1441 * new object if 'op' was merged with other object 1359 * new object if 'op' was merged with other object
1442 * NULL if 'op' was destroyed 1360 * NULL if 'op' was destroyed
1443 * just 'op' otherwise 1361 * just 'op' otherwise
1444 */ 1362 */
1445 1363
1364object *
1446object *insert_ob_in_map (object *op, mapstruct *m, object *originator, int flag) 1365insert_ob_in_map (object *op, mapstruct *m, object *originator, int flag)
1447{ 1366{
1448 object *tmp, *top, *floor=NULL; 1367 object *tmp, *top, *floor = NULL;
1449 sint16 x,y; 1368 sint16 x, y;
1450 1369
1451 if (QUERY_FLAG (op, FLAG_FREED)) { 1370 if (QUERY_FLAG (op, FLAG_FREED))
1371 {
1452 LOG (llevError, "Trying to insert freed object!\n"); 1372 LOG (llevError, "Trying to insert freed object!\n");
1373 return NULL;
1374 }
1375
1376 if (m == NULL)
1377 {
1378 dump_object (op);
1379 LOG (llevError, "Trying to insert in null-map!\n%s\n", errmsg);
1380 return op;
1381 }
1382
1383 if (out_of_map (m, op->x, op->y))
1384 {
1385 dump_object (op);
1386 LOG (llevError, "Trying to insert object outside the map.\n%s\n", errmsg);
1387#ifdef MANY_CORES
1388 /* Better to catch this here, as otherwise the next use of this object
1389 * is likely to cause a crash. Better to find out where it is getting
1390 * improperly inserted.
1391 */
1392 abort ();
1393#endif
1394 return op;
1395 }
1396
1397 if (!QUERY_FLAG (op, FLAG_REMOVED))
1398 {
1399 dump_object (op);
1400 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", errmsg);
1401 return op;
1402 }
1403
1404 if (op->more != NULL)
1405 {
1406 /* The part may be on a different map. */
1407
1408 object *more = op->more;
1409
1410 /* We really need the caller to normalize coordinates - if
1411 * we set the map, that doesn't work if the location is within
1412 * a map and this is straddling an edge. So only if coordinate
1413 * is clear wrong do we normalize it.
1414 */
1415 if (OUT_OF_REAL_MAP (more->map, more->x, more->y))
1416 more->map = get_map_from_coord (m, &more->x, &more->y);
1417 else if (!more->map)
1418 {
1419 /* For backwards compatibility - when not dealing with tiled maps,
1420 * more->map should always point to the parent.
1421 */
1422 more->map = m;
1423 }
1424
1425 if (insert_ob_in_map (more, more->map, originator, flag) == NULL)
1426 {
1427 if (!op->head)
1428 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n");
1429
1430 return NULL;
1431 }
1432 }
1433
1434 CLEAR_FLAG (op, FLAG_REMOVED);
1435
1436 /* Ideally, the caller figures this out. However, it complicates a lot
1437 * of areas of callers (eg, anything that uses find_free_spot would now
1438 * need extra work
1439 */
1440 op->map = get_map_from_coord (m, &op->x, &op->y);
1441 x = op->x;
1442 y = op->y;
1443
1444 /* this has to be done after we translate the coordinates.
1445 */
1446 if (op->nrof && !(flag & INS_NO_MERGE))
1447 for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above)
1448 if (CAN_MERGE (op, tmp))
1449 {
1450 op->nrof += tmp->nrof;
1451 remove_ob (tmp);
1452 free_object (tmp);
1453 }
1454
1455 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1456 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1457
1458 if (!QUERY_FLAG (op, FLAG_ALIVE))
1459 CLEAR_FLAG (op, FLAG_NO_STEAL);
1460
1461 if (flag & INS_BELOW_ORIGINATOR)
1462 {
1463 if (originator->map != op->map || originator->x != op->x || originator->y != op->y)
1464 {
1465 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1466 abort ();
1467 }
1468
1469 op->above = originator;
1470 op->below = originator->below;
1471
1472 if (op->below)
1473 op->below->above = op;
1474 else
1475 SET_MAP_OB (op->map, op->x, op->y, op);
1476
1477 /* since *below* originator, no need to update top */
1478 originator->below = op;
1479 }
1480 else
1481 {
1482 /* If there are other objects, then */
1483 if ((!(flag & INS_MAP_LOAD)) && ((top = GET_MAP_OB (op->map, op->x, op->y)) != NULL))
1484 {
1485 object *last = NULL;
1486
1487 /*
1488 * If there are multiple objects on this space, we do some trickier handling.
1489 * We've already dealt with merging if appropriate.
1490 * Generally, we want to put the new object on top. But if
1491 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
1492 * floor, we want to insert above that and no further.
1493 * Also, if there are spell objects on this space, we stop processing
1494 * once we get to them. This reduces the need to traverse over all of
1495 * them when adding another one - this saves quite a bit of cpu time
1496 * when lots of spells are cast in one area. Currently, it is presumed
1497 * that flying non pickable objects are spell objects.
1498 */
1499
1500 while (top != NULL)
1501 {
1502 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))
1503 floor = top;
1504
1505 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))
1506 {
1507 /* We insert above top, so we want this object below this */
1508 top = top->below;
1509 break;
1510 }
1511
1512 last = top;
1513 top = top->above;
1514 }
1515
1516 /* Don't want top to be NULL, so set it to the last valid object */
1517 top = last;
1518
1519 /* We let update_position deal with figuring out what the space
1520 * looks like instead of lots of conditions here.
1521 * makes things faster, and effectively the same result.
1522 */
1523
1524 /* Have object 'fall below' other objects that block view.
1525 * Unless those objects are exits, type 66
1526 * If INS_ON_TOP is used, don't do this processing
1527 * Need to find the object that in fact blocks view, otherwise
1528 * stacking is a bit odd.
1529 */
1530 if (!(flag & INS_ON_TOP) &&
1531 (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_BLOCKSVIEW) && (op->face && !op->face->visibility))
1532 {
1533 for (last = top; last != floor; last = last->below)
1534 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1535 break;
1536 /* Check to see if we found the object that blocks view,
1537 * and make sure we have a below pointer for it so that
1538 * we can get inserted below this one, which requires we
1539 * set top to the object below us.
1540 */
1541 if (last && last->below && last != floor)
1542 top = last->below;
1543 }
1544 } /* If objects on this space */
1545
1546 if (flag & INS_MAP_LOAD)
1547 top = GET_MAP_TOP (op->map, op->x, op->y);
1548
1549 if (flag & INS_ABOVE_FLOOR_ONLY)
1550 top = floor;
1551
1552 /* Top is the object that our object (op) is going to get inserted above.
1553 */
1554
1555 /* First object on this space */
1556 if (!top)
1557 {
1558 op->above = GET_MAP_OB (op->map, op->x, op->y);
1559
1560 if (op->above)
1561 op->above->below = op;
1562
1563 op->below = NULL;
1564 SET_MAP_OB (op->map, op->x, op->y, op);
1565 }
1566 else
1567 { /* get inserted into the stack above top */
1568 op->above = top->above;
1569
1570 if (op->above)
1571 op->above->below = op;
1572
1573 op->below = top;
1574 top->above = op;
1575 }
1576
1577 if (op->above == NULL)
1578 SET_MAP_TOP (op->map, op->x, op->y, op);
1579 } /* else not INS_BELOW_ORIGINATOR */
1580
1581 if (op->type == PLAYER)
1582 op->contr->do_los = 1;
1583
1584 /* If we have a floor, we know the player, if any, will be above
1585 * it, so save a few ticks and start from there.
1586 */
1587 if (!(flag & INS_MAP_LOAD))
1588 for (tmp = floor ? floor : GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above)
1589 if (tmp->type == PLAYER)
1590 tmp->contr->socket.update_look = 1;
1591
1592 /* If this object glows, it may affect lighting conditions that are
1593 * visible to others on this map. But update_all_los is really
1594 * an inefficient way to do this, as it means los for all players
1595 * on the map will get recalculated. The players could very well
1596 * be far away from this change and not affected in any way -
1597 * this should get redone to only look for players within range,
1598 * or just updating the P_NEED_UPDATE for spaces within this area
1599 * of effect may be sufficient.
1600 */
1601 if (MAP_DARKNESS (op->map) && (op->glow_radius != 0))
1602 update_all_los (op->map, op->x, op->y);
1603
1604 /* updates flags (blocked, alive, no magic, etc) for this map space */
1605 update_object (op, UP_OBJ_INSERT);
1606
1607 /* Don't know if moving this to the end will break anything. However,
1608 * we want to have update_look set above before calling this.
1609 *
1610 * check_move_on() must be after this because code called from
1611 * check_move_on() depends on correct map flags (so functions like
1612 * blocked() and wall() work properly), and these flags are updated by
1613 * update_object().
1614 */
1615
1616 /* if this is not the head or flag has been passed, don't check walk on status */
1617 if (!(flag & INS_NO_WALK_ON) && !op->head)
1618 {
1619 if (check_move_on (op, originator))
1453 return NULL; 1620 return NULL;
1454 }
1455 if(m==NULL) {
1456 dump_object(op);
1457 LOG(llevError,"Trying to insert in null-map!\n%s\n",errmsg);
1458 return op;
1459 }
1460 if(out_of_map(m,op->x,op->y)) {
1461 dump_object(op);
1462 LOG(llevError,"Trying to insert object outside the map.\n%s\n", errmsg);
1463#ifdef MANY_CORES
1464 /* Better to catch this here, as otherwise the next use of this object
1465 * is likely to cause a crash. Better to find out where it is getting
1466 * improperly inserted.
1467 */
1468 abort();
1469#endif
1470 return op;
1471 }
1472 if(!QUERY_FLAG(op,FLAG_REMOVED)) {
1473 dump_object(op);
1474 LOG(llevError,"Trying to insert (map) inserted object.\n%s\n", errmsg);
1475 return op;
1476 }
1477 if(op->more!=NULL) {
1478 /* The part may be on a different map. */
1479 1621
1480 object *more = op->more;
1481
1482 /* We really need the caller to normalize coordinates - if
1483 * we set the map, that doesn't work if the location is within
1484 * a map and this is straddling an edge. So only if coordinate
1485 * is clear wrong do we normalize it.
1486 */
1487 if (OUT_OF_REAL_MAP(more->map, more->x, more->y)) {
1488 /* Debugging information so you can see the last coordinates this object had */
1489 more->ox = more->x;
1490 more->oy = more->y;
1491 more->map = get_map_from_coord(m, &more->x, &more->y);
1492 } else if (!more->map) {
1493 /* For backwards compatibility - when not dealing with tiled maps,
1494 * more->map should always point to the parent.
1495 */
1496 more->map = m;
1497 }
1498
1499 if (insert_ob_in_map(more, more->map, originator, flag) == NULL) {
1500 if ( ! op->head)
1501 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n");
1502 return NULL;
1503 }
1504 }
1505 CLEAR_FLAG(op,FLAG_REMOVED);
1506
1507 /* Debugging information so you can see the last coordinates this object had */
1508 op->ox=op->x;
1509 op->oy=op->y;
1510
1511 /* Ideally, the caller figures this out. However, it complicates a lot
1512 * of areas of callers (eg, anything that uses find_free_spot would now
1513 * need extra work
1514 */
1515 op->map=get_map_from_coord(m, &op->x, &op->y);
1516 x = op->x;
1517 y = op->y;
1518
1519 /* this has to be done after we translate the coordinates.
1520 */
1521 if(op->nrof && !(flag & INS_NO_MERGE)) {
1522 for(tmp=GET_MAP_OB(op->map,x,y);tmp!=NULL;tmp=tmp->above)
1523 if (CAN_MERGE(op,tmp)) {
1524 op->nrof+=tmp->nrof;
1525 remove_ob(tmp);
1526 free_object(tmp);
1527 }
1528 }
1529
1530 CLEAR_FLAG(op,FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1531 CLEAR_FLAG(op, FLAG_INV_LOCKED);
1532 if (!QUERY_FLAG(op, FLAG_ALIVE))
1533 CLEAR_FLAG(op, FLAG_NO_STEAL);
1534
1535 if (flag & INS_BELOW_ORIGINATOR) {
1536 if (originator->map != op->map || originator->x != op->x ||
1537 originator->y != op->y) {
1538 LOG(llevError,"insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1539 abort();
1540 }
1541 op->above = originator;
1542 op->below = originator->below;
1543 if (op->below) op->below->above = op;
1544 else SET_MAP_OB(op->map, op->x, op->y, op);
1545 /* since *below* originator, no need to update top */
1546 originator->below = op;
1547 } else {
1548 /* If there are other objects, then */
1549 if((! (flag & INS_MAP_LOAD)) && ((top=GET_MAP_OB(op->map,op->x,op->y))!=NULL)) {
1550 object *last=NULL;
1551 /*
1552 * If there are multiple objects on this space, we do some trickier handling.
1553 * We've already dealt with merging if appropriate.
1554 * Generally, we want to put the new object on top. But if
1555 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
1556 * floor, we want to insert above that and no further.
1557 * Also, if there are spell objects on this space, we stop processing
1558 * once we get to them. This reduces the need to traverse over all of
1559 * them when adding another one - this saves quite a bit of cpu time
1560 * when lots of spells are cast in one area. Currently, it is presumed
1561 * that flying non pickable objects are spell objects.
1562 */
1563
1564 while (top != NULL) {
1565 if (QUERY_FLAG(top, FLAG_IS_FLOOR) ||
1566 QUERY_FLAG(top, FLAG_OVERLAY_FLOOR)) floor = top;
1567 if (QUERY_FLAG(top, FLAG_NO_PICK)
1568 && (top->move_type & (MOVE_FLY_LOW |MOVE_FLY_HIGH))
1569 && !QUERY_FLAG(top, FLAG_IS_FLOOR))
1570 {
1571 /* We insert above top, so we want this object below this */
1572 top=top->below;
1573 break;
1574 }
1575 last = top;
1576 top = top->above;
1577 }
1578 /* Don't want top to be NULL, so set it to the last valid object */
1579 top = last;
1580
1581 /* We let update_position deal with figuring out what the space
1582 * looks like instead of lots of conditions here.
1583 * makes things faster, and effectively the same result.
1584 */
1585
1586 /* Have object 'fall below' other objects that block view.
1587 * Unless those objects are exits, type 66
1588 * If INS_ON_TOP is used, don't do this processing
1589 * Need to find the object that in fact blocks view, otherwise
1590 * stacking is a bit odd.
1591 */
1592 if (!(flag & INS_ON_TOP) &&
1593 (get_map_flags(op->map, NULL, op->x, op->y, NULL, NULL) & P_BLOCKSVIEW) &&
1594 (op->face && !op->face->visibility)) {
1595 for (last=top; last != floor; last=last->below)
1596 if (QUERY_FLAG(last, FLAG_BLOCKSVIEW)&&(last->type != EXIT)) break;
1597 /* Check to see if we found the object that blocks view,
1598 * and make sure we have a below pointer for it so that
1599 * we can get inserted below this one, which requires we
1600 * set top to the object below us.
1601 */
1602 if (last && last->below && last != floor) top=last->below;
1603 }
1604 } /* If objects on this space */
1605 if (flag & INS_MAP_LOAD)
1606 top = GET_MAP_TOP(op->map,op->x,op->y);
1607 if (flag & INS_ABOVE_FLOOR_ONLY) top = floor;
1608
1609 /* Top is the object that our object (op) is going to get inserted above.
1610 */
1611
1612 /* First object on this space */
1613 if (!top) {
1614 op->above = GET_MAP_OB(op->map, op->x, op->y);
1615 if (op->above) op->above->below = op;
1616 op->below = NULL;
1617 SET_MAP_OB(op->map, op->x, op->y, op);
1618 } else { /* get inserted into the stack above top */
1619 op->above = top->above;
1620 if (op->above) op->above->below = op;
1621 op->below = top;
1622 top->above = op;
1623 }
1624 if (op->above==NULL)
1625 SET_MAP_TOP(op->map,op->x, op->y, op);
1626 } /* else not INS_BELOW_ORIGINATOR */
1627
1628 if(op->type==PLAYER)
1629 op->contr->do_los=1;
1630
1631 /* If we have a floor, we know the player, if any, will be above
1632 * it, so save a few ticks and start from there.
1633 */
1634 if (!(flag & INS_MAP_LOAD))
1635 for(tmp=floor?floor:GET_MAP_OB(op->map,op->x,op->y);tmp!=NULL;tmp=tmp->above) {
1636 if (tmp->type == PLAYER)
1637 tmp->contr->socket.update_look=1;
1638 }
1639
1640 /* If this object glows, it may affect lighting conditions that are
1641 * visible to others on this map. But update_all_los is really
1642 * an inefficient way to do this, as it means los for all players
1643 * on the map will get recalculated. The players could very well
1644 * be far away from this change and not affected in any way -
1645 * this should get redone to only look for players within range,
1646 * or just updating the P_NEED_UPDATE for spaces within this area
1647 * of effect may be sufficient.
1648 */
1649 if(MAP_DARKNESS(op->map) && (op->glow_radius != 0))
1650 update_all_los(op->map, op->x, op->y);
1651
1652
1653 /* updates flags (blocked, alive, no magic, etc) for this map space */
1654 update_object(op,UP_OBJ_INSERT);
1655
1656
1657 /* Don't know if moving this to the end will break anything. However,
1658 * we want to have update_look set above before calling this.
1659 *
1660 * check_move_on() must be after this because code called from
1661 * check_move_on() depends on correct map flags (so functions like
1662 * blocked() and wall() work properly), and these flags are updated by
1663 * update_object().
1664 */
1665
1666 /* if this is not the head or flag has been passed, don't check walk on status */
1667
1668 if (!(flag & INS_NO_WALK_ON) && !op->head) {
1669 if (check_move_on(op, originator))
1670 return NULL;
1671
1672 /* If we are a multi part object, lets work our way through the check 1622 /* If we are a multi part object, lets work our way through the check
1673 * walk on's. 1623 * walk on's.
1674 */ 1624 */
1675 for (tmp=op->more; tmp!=NULL; tmp=tmp->more) 1625 for (tmp = op->more; tmp != NULL; tmp = tmp->more)
1676 if (check_move_on (tmp, originator)) 1626 if (check_move_on (tmp, originator))
1677 return NULL; 1627 return NULL;
1678 } 1628 }
1629
1679 return op; 1630 return op;
1680} 1631}
1681 1632
1682/* this function inserts an object in the map, but if it 1633/* this function inserts an object in the map, but if it
1683 * finds an object of its own type, it'll remove that one first. 1634 * finds an object of its own type, it'll remove that one first.
1684 * op is the object to insert it under: supplies x and the map. 1635 * op is the object to insert it under: supplies x and the map.
1685 */ 1636 */
1637void
1686void replace_insert_ob_in_map(const char *arch_string, object *op) { 1638replace_insert_ob_in_map (const char *arch_string, object *op)
1639{
1687 object *tmp; 1640 object *
1688 object *tmp1; 1641 tmp;
1642 object *
1643 tmp1;
1689 1644
1690 /* first search for itself and remove any old instances */ 1645 /* first search for itself and remove any old instances */
1691 1646
1692 for(tmp=GET_MAP_OB(op->map,op->x,op->y); tmp!=NULL; tmp=tmp->above) { 1647 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above)
1648 {
1693 if(!strcmp(tmp->arch->name,arch_string)) /* same archetype */ { 1649 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */
1650 {
1694 remove_ob(tmp); 1651 remove_ob (tmp);
1695 free_object(tmp); 1652 free_object (tmp);
1696 } 1653 }
1697 } 1654 }
1698 1655
1699 tmp1=arch_to_object(find_archetype(arch_string)); 1656 tmp1 = arch_to_object (find_archetype (arch_string));
1700 1657
1701 1658 tmp1->x = op->x;
1702 tmp1->x = op->x; tmp1->y = op->y; 1659 tmp1->y = op->y;
1703 insert_ob_in_map(tmp1,op->map,op,0); 1660 insert_ob_in_map (tmp1, op->map, op, 0);
1704} 1661}
1705 1662
1706/* 1663/*
1707 * get_split_ob(ob,nr) splits up ob into two parts. The part which 1664 * get_split_ob(ob,nr) splits up ob into two parts. The part which
1708 * is returned contains nr objects, and the remaining parts contains 1665 * is returned contains nr objects, and the remaining parts contains
1709 * the rest (or is removed and freed if that number is 0). 1666 * the rest (or is removed and freed if that number is 0).
1710 * On failure, NULL is returned, and the reason put into the 1667 * On failure, NULL is returned, and the reason put into the
1711 * global static errmsg array. 1668 * global static errmsg array.
1712 */ 1669 */
1713 1670
1671object *
1714object *get_split_ob(object *orig_ob, uint32 nr) { 1672get_split_ob (object *orig_ob, uint32 nr)
1715 object *newob; 1673{
1674 object *
1675 newob;
1676 int
1716 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0); 1677 is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1717 1678
1718 if(orig_ob->nrof<nr) { 1679 if (orig_ob->nrof < nr)
1719 sprintf(errmsg,"There are only %d %ss.", 1680 {
1720 orig_ob->nrof?orig_ob->nrof:1, orig_ob->name); 1681 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1721 return NULL; 1682 return NULL;
1722 } 1683 }
1684
1723 newob = object_create_clone(orig_ob); 1685 newob = object_create_clone (orig_ob);
1686
1724 if((orig_ob->nrof-=nr)<1) { 1687 if ((orig_ob->nrof -= nr) < 1)
1688 {
1725 if ( ! is_removed) 1689 if (!is_removed)
1726 remove_ob(orig_ob); 1690 remove_ob (orig_ob);
1727 free_object2(orig_ob, 1); 1691 free_object2 (orig_ob, 1);
1728 } 1692 }
1729 else if ( ! is_removed) { 1693 else if (!is_removed)
1694 {
1730 if(orig_ob->env!=NULL) 1695 if (orig_ob->env != NULL)
1731 sub_weight (orig_ob->env,orig_ob->weight*nr); 1696 sub_weight (orig_ob->env, orig_ob->weight * nr);
1732 if (orig_ob->env == NULL && orig_ob->map->in_memory!=MAP_IN_MEMORY) { 1697 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY)
1698 {
1733 strcpy(errmsg, "Tried to split object whose map is not in memory."); 1699 strcpy (errmsg, "Tried to split object whose map is not in memory.");
1734 LOG(llevDebug,
1735 "Error, Tried to split object whose map is not in memory.\n"); 1700 LOG (llevDebug, "Error, Tried to split object whose map is not in memory.\n");
1736 return NULL; 1701 return NULL;
1737 } 1702 }
1738 } 1703 }
1704
1739 newob->nrof=nr; 1705 newob->nrof = nr;
1740 1706
1741 return newob; 1707 return newob;
1742} 1708}
1743 1709
1744/* 1710/*
1745 * decrease_ob_nr(object, number) decreases a specified number from 1711 * decrease_ob_nr(object, number) decreases a specified number from
1746 * the amount of an object. If the amount reaches 0, the object 1712 * the amount of an object. If the amount reaches 0, the object
1747 * is subsequently removed and freed. 1713 * is subsequently removed and freed.
1748 * 1714 *
1749 * Return value: 'op' if something is left, NULL if the amount reached 0 1715 * Return value: 'op' if something is left, NULL if the amount reached 0
1750 */ 1716 */
1751 1717
1718object *
1752object *decrease_ob_nr (object *op, uint32 i) 1719decrease_ob_nr (object *op, uint32 i)
1753{ 1720{
1754 object *tmp; 1721 object *tmp;
1755 player *pl; 1722 player *pl;
1756 1723
1757 if (i == 0) /* objects with op->nrof require this check */ 1724 if (i == 0) /* objects with op->nrof require this check */
1758 return op; 1725 return op;
1759 1726
1760 if (i > op->nrof) 1727 if (i > op->nrof)
1761 i = op->nrof; 1728 i = op->nrof;
1762 1729
1763 if (QUERY_FLAG (op, FLAG_REMOVED)) 1730 if (QUERY_FLAG (op, FLAG_REMOVED))
1731 op->nrof -= i;
1732 else if (op->env != NULL)
1733 {
1734 /* is this object in the players inventory, or sub container
1735 * therein?
1736 */
1737 tmp = is_player_inv (op->env);
1738 /* nope. Is this a container the player has opened?
1739 * If so, set tmp to that player.
1740 * IMO, searching through all the players will mostly
1741 * likely be quicker than following op->env to the map,
1742 * and then searching the map for a player.
1743 */
1744 if (!tmp)
1745 {
1746 for (pl = first_player; pl; pl = pl->next)
1747 if (pl->ob->container == op->env)
1748 break;
1749 if (pl)
1750 tmp = pl->ob;
1751 else
1752 tmp = NULL;
1753 }
1754
1755 if (i < op->nrof)
1756 {
1757 sub_weight (op->env, op->weight * i);
1758 op->nrof -= i;
1759 if (tmp)
1760 {
1761 esrv_send_item (tmp, op);
1762 }
1763 }
1764 else
1765 {
1766 remove_ob (op);
1767 op->nrof = 0;
1768 if (tmp)
1769 {
1770 esrv_del_item (tmp->contr, op->count);
1771 }
1772 }
1764 { 1773 }
1774 else
1775 {
1776 object *above = op->above;
1777
1778 if (i < op->nrof)
1765 op->nrof -= i; 1779 op->nrof -= i;
1766 } 1780 else
1767 else if (op->env != NULL)
1768 {
1769 /* is this object in the players inventory, or sub container
1770 * therein?
1771 */
1772 tmp = is_player_inv (op->env);
1773 /* nope. Is this a container the player has opened?
1774 * If so, set tmp to that player.
1775 * IMO, searching through all the players will mostly
1776 * likely be quicker than following op->env to the map,
1777 * and then searching the map for a player.
1778 */
1779 if (!tmp) {
1780 for (pl=first_player; pl; pl=pl->next)
1781 if (pl->ob->container == op->env) break;
1782 if (pl) tmp=pl->ob;
1783 else tmp=NULL;
1784 } 1781 {
1785
1786 if (i < op->nrof) {
1787 sub_weight (op->env, op->weight * i);
1788 op->nrof -= i;
1789 if (tmp) {
1790 esrv_send_item(tmp, op);
1791 }
1792 } else {
1793 remove_ob (op); 1782 remove_ob (op);
1794 op->nrof = 0; 1783 op->nrof = 0;
1795 if (tmp) {
1796 esrv_del_item(tmp->contr, op->count);
1797 } 1784 }
1798 }
1799 }
1800 else
1801 {
1802 object *above = op->above;
1803 1785
1804 if (i < op->nrof) {
1805 op->nrof -= i;
1806 } else {
1807 remove_ob (op);
1808 op->nrof = 0;
1809 }
1810 /* Since we just removed op, op->above is null */ 1786 /* Since we just removed op, op->above is null */
1811 for (tmp = above; tmp != NULL; tmp = tmp->above) 1787 for (tmp = above; tmp != NULL; tmp = tmp->above)
1812 if (tmp->type == PLAYER) { 1788 if (tmp->type == PLAYER)
1789 {
1813 if (op->nrof) 1790 if (op->nrof)
1814 esrv_send_item(tmp, op); 1791 esrv_send_item (tmp, op);
1815 else 1792 else
1816 esrv_del_item(tmp->contr, op->count); 1793 esrv_del_item (tmp->contr, op->count);
1817 } 1794 }
1818 } 1795 }
1819 1796
1820 if (op->nrof) { 1797 if (op->nrof)
1821 return op; 1798 return op;
1822 } else { 1799 else
1800 {
1823 free_object (op); 1801 free_object (op);
1824 return NULL; 1802 return NULL;
1825 } 1803 }
1826} 1804}
1827 1805
1828/* 1806/*
1829 * add_weight(object, weight) adds the specified weight to an object, 1807 * add_weight(object, weight) adds the specified weight to an object,
1830 * and also updates how much the environment(s) is/are carrying. 1808 * and also updates how much the environment(s) is/are carrying.
1831 */ 1809 */
1832 1810
1811void
1833void add_weight (object *op, signed long weight) { 1812add_weight (object *op, signed long weight)
1813{
1834 while (op!=NULL) { 1814 while (op != NULL)
1815 {
1835 if (op->type == CONTAINER) { 1816 if (op->type == CONTAINER)
1836 weight=(signed long)(weight*(100-op->stats.Str)/100); 1817 weight = (signed long) (weight * (100 - op->stats.Str) / 100);
1837 } 1818
1838 op->carrying+=weight; 1819 op->carrying += weight;
1839 op=op->env; 1820 op = op->env;
1840 } 1821 }
1841} 1822}
1842 1823
1843/* 1824/*
1844 * insert_ob_in_ob(op,environment): 1825 * insert_ob_in_ob(op,environment):
1845 * This function inserts the object op in the linked list 1826 * This function inserts the object op in the linked list
… …
1852 * 1833 *
1853 * The function returns now pointer to inserted item, and return value can 1834 * The function returns now pointer to inserted item, and return value can
1854 * be != op, if items are merged. -Tero 1835 * be != op, if items are merged. -Tero
1855 */ 1836 */
1856 1837
1838object *
1857object *insert_ob_in_ob(object *op,object *where) { 1839insert_ob_in_ob (object *op, object *where)
1858 object *tmp, *otmp; 1840{
1841 object *
1842 tmp, *
1843 otmp;
1859 1844
1860 if(!QUERY_FLAG(op,FLAG_REMOVED)) { 1845 if (!QUERY_FLAG (op, FLAG_REMOVED))
1846 {
1861 dump_object(op); 1847 dump_object (op);
1862 LOG(llevError,"Trying to insert (ob) inserted object.\n%s\n", errmsg); 1848 LOG (llevError, "Trying to insert (ob) inserted object.\n%s\n", errmsg);
1863 return op; 1849 return op;
1864 } 1850 }
1851
1865 if(where==NULL) { 1852 if (where == NULL)
1853 {
1866 dump_object(op); 1854 dump_object (op);
1867 LOG(llevError,"Trying to put object in NULL.\n%s\n", errmsg); 1855 LOG (llevError, "Trying to put object in NULL.\n%s\n", errmsg);
1868 return op; 1856 return op;
1869 } 1857 }
1858
1870 if (where->head) { 1859 if (where->head)
1871 LOG(llevDebug, 1860 {
1872 "Warning: Tried to insert object wrong part of multipart object.\n"); 1861 LOG (llevDebug, "Warning: Tried to insert object wrong part of multipart object.\n");
1873 where = where->head; 1862 where = where->head;
1874 } 1863 }
1864
1875 if (op->more) { 1865 if (op->more)
1866 {
1876 LOG(llevError, "Tried to insert multipart object %s (%d)\n", 1867 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);
1877 op->name, op->count);
1878 return op; 1868 return op;
1879 } 1869 }
1870
1880 CLEAR_FLAG(op, FLAG_OBJ_ORIGINAL); 1871 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL);
1881 CLEAR_FLAG(op, FLAG_REMOVED); 1872 CLEAR_FLAG (op, FLAG_REMOVED);
1882 if(op->nrof) { 1873 if (op->nrof)
1874 {
1883 for(tmp=where->inv;tmp!=NULL;tmp=tmp->below) 1875 for (tmp = where->inv; tmp != NULL; tmp = tmp->below)
1884 if ( CAN_MERGE(tmp,op) ) { 1876 if (CAN_MERGE (tmp, op))
1877 {
1885 /* return the original object and remove inserted object 1878 /* return the original object and remove inserted object
1886 (client needs the original object) */ 1879 (client needs the original object) */
1887 tmp->nrof += op->nrof; 1880 tmp->nrof += op->nrof;
1888 /* Weight handling gets pretty funky. Since we are adding to 1881 /* Weight handling gets pretty funky. Since we are adding to
1889 * tmp->nrof, we need to increase the weight. 1882 * tmp->nrof, we need to increase the weight.
1890 */ 1883 */
1891 add_weight (where, op->weight*op->nrof); 1884 add_weight (where, op->weight * op->nrof);
1892 SET_FLAG(op, FLAG_REMOVED); 1885 SET_FLAG (op, FLAG_REMOVED);
1893 free_object(op); /* free the inserted object */ 1886 free_object (op); /* free the inserted object */
1894 op = tmp; 1887 op = tmp;
1895 remove_ob (op); /* and fix old object's links */ 1888 remove_ob (op); /* and fix old object's links */
1896 CLEAR_FLAG(op, FLAG_REMOVED); 1889 CLEAR_FLAG (op, FLAG_REMOVED);
1897 break; 1890 break;
1898 } 1891 }
1899 1892
1900 /* I assume combined objects have no inventory 1893 /* I assume combined objects have no inventory
1901 * We add the weight - this object could have just been removed 1894 * We add the weight - this object could have just been removed
1902 * (if it was possible to merge). calling remove_ob will subtract 1895 * (if it was possible to merge). calling remove_ob will subtract
1903 * the weight, so we need to add it in again, since we actually do 1896 * the weight, so we need to add it in again, since we actually do
1904 * the linking below 1897 * the linking below
1905 */ 1898 */
1906 add_weight (where, op->weight*op->nrof); 1899 add_weight (where, op->weight * op->nrof);
1900 }
1907 } else 1901 else
1908 add_weight (where, (op->weight+op->carrying)); 1902 add_weight (where, (op->weight + op->carrying));
1909 1903
1910 otmp=is_player_inv(where); 1904 otmp = is_player_inv (where);
1911 if (otmp&&otmp->contr!=NULL) { 1905 if (otmp && otmp->contr != NULL)
1906 {
1912 if (!QUERY_FLAG(otmp,FLAG_NO_FIX_PLAYER)) 1907 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1913 fix_player(otmp); 1908 fix_player (otmp);
1914 } 1909 }
1915 1910
1916 op->map=NULL; 1911 op->map = NULL;
1917 op->env=where; 1912 op->env = where;
1918 op->above=NULL; 1913 op->above = NULL;
1919 op->below=NULL; 1914 op->below = NULL;
1920 op->x=0,op->y=0; 1915 op->x = 0, op->y = 0;
1921 op->ox=0,op->oy=0;
1922 1916
1923 /* reset the light list and los of the players on the map */ 1917 /* reset the light list and los of the players on the map */
1924 if((op->glow_radius!=0)&&where->map) 1918 if ((op->glow_radius != 0) && where->map)
1925 { 1919 {
1926#ifdef DEBUG_LIGHTS 1920#ifdef DEBUG_LIGHTS
1927 LOG(llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", 1921 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1928 op->name);
1929#endif /* DEBUG_LIGHTS */ 1922#endif /* DEBUG_LIGHTS */
1923 if (MAP_DARKNESS (where->map))
1930 if (MAP_DARKNESS(where->map)) update_all_los(where->map, where->x, where->y); 1924 update_all_los (where->map, where->x, where->y);
1931 } 1925 }
1932 1926
1933 /* Client has no idea of ordering so lets not bother ordering it here. 1927 /* Client has no idea of ordering so lets not bother ordering it here.
1934 * It sure simplifies this function... 1928 * It sure simplifies this function...
1935 */ 1929 */
1936 if (where->inv==NULL) 1930 if (where->inv == NULL)
1937 where->inv=op; 1931 where->inv = op;
1938 else { 1932 else
1933 {
1939 op->below = where->inv; 1934 op->below = where->inv;
1940 op->below->above = op; 1935 op->below->above = op;
1941 where->inv = op; 1936 where->inv = op;
1942 } 1937 }
1943 return op; 1938 return op;
1944} 1939}
1945 1940
1946/* 1941/*
1947 * Checks if any objects has a move_type that matches objects 1942 * Checks if any objects has a move_type that matches objects
… …
1962 * MSW 2001-07-08: Check all objects on space, not just those below 1957 * MSW 2001-07-08: Check all objects on space, not just those below
1963 * object being inserted. insert_ob_in_map may not put new objects 1958 * object being inserted. insert_ob_in_map may not put new objects
1964 * on top. 1959 * on top.
1965 */ 1960 */
1966 1961
1962int
1967int check_move_on (object *op, object *originator) 1963check_move_on (object *op, object *originator)
1968{ 1964{
1969 object *tmp; 1965 object *
1970 tag_t tag; 1966 tmp;
1971 mapstruct *m=op->map; 1967 tag_t
1968 tag;
1969 mapstruct *
1970 m = op->map;
1971 int
1972 int x=op->x, y=op->y; 1972 x = op->x, y = op->y;
1973 MoveType move_on, move_slow, move_block;
1974 1973
1974 MoveType
1975 move_on,
1976 move_slow,
1977 move_block;
1978
1975 if(QUERY_FLAG(op,FLAG_NO_APPLY)) 1979 if (QUERY_FLAG (op, FLAG_NO_APPLY))
1976 return 0; 1980 return 0;
1977 1981
1978 tag = op->count; 1982 tag = op->count;
1979 1983
1980 move_on = GET_MAP_MOVE_ON(op->map, op->x, op->y); 1984 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
1981 move_slow = GET_MAP_MOVE_SLOW(op->map, op->x, op->y); 1985 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
1982 move_block = GET_MAP_MOVE_BLOCK(op->map, op->x, op->y); 1986 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
1983 1987
1984 /* if nothing on this space will slow op down or be applied, 1988 /* if nothing on this space will slow op down or be applied,
1985 * no need to do checking below. have to make sure move_type 1989 * no need to do checking below. have to make sure move_type
1986 * is set, as lots of objects don't have it set - we treat that 1990 * is set, as lots of objects don't have it set - we treat that
1987 * as walking. 1991 * as walking.
1988 */ 1992 */
1989 if (op->move_type && !(op->move_type & move_on) && !(op->move_type & move_slow)) 1993 if (op->move_type && !(op->move_type & move_on) && !(op->move_type & move_slow))
1990 return 0; 1994 return 0;
1991 1995
1992 /* This is basically inverse logic of that below - basically, 1996 /* This is basically inverse logic of that below - basically,
1993 * if the object can avoid the move on or slow move, they do so, 1997 * if the object can avoid the move on or slow move, they do so,
1994 * but can't do it if the alternate movement they are using is 1998 * but can't do it if the alternate movement they are using is
1995 * blocked. Logic on this seems confusing, but does seem correct. 1999 * blocked. Logic on this seems confusing, but does seem correct.
1996 */ 2000 */
1997 if ((op->move_type & ~move_on & ~move_block) != 0 && 2001 if ((op->move_type & ~move_on & ~move_block) != 0 && (op->move_type & ~move_slow & ~move_block) != 0)
1998 (op->move_type & ~move_slow & ~move_block) != 0) return 0; 2002 return 0;
1999 2003
2000 /* The objects have to be checked from top to bottom. 2004 /* The objects have to be checked from top to bottom.
2001 * Hence, we first go to the top: 2005 * Hence, we first go to the top:
2002 */ 2006 */
2003 2007
2004 for (tmp=GET_MAP_OB(op->map, op->x, op->y); tmp!=NULL && 2008 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL && tmp->above != NULL; tmp = tmp->above)
2005 tmp->above!=NULL; tmp=tmp->above) { 2009 {
2006 /* Trim the search when we find the first other spell effect 2010 /* Trim the search when we find the first other spell effect
2007 * this helps performance so that if a space has 50 spell objects, 2011 * this helps performance so that if a space has 50 spell objects,
2008 * we don't need to check all of them. 2012 * we don't need to check all of them.
2009 */ 2013 */
2010 if ((tmp->move_type & MOVE_FLY_LOW) && QUERY_FLAG(tmp, FLAG_NO_PICK)) break; 2014 if ((tmp->move_type & MOVE_FLY_LOW) && QUERY_FLAG (tmp, FLAG_NO_PICK))
2015 break;
2016 }
2017
2018 for (; tmp; tmp = tmp->below)
2011 } 2019 {
2012 for(;tmp!=NULL; tmp=tmp->below) { 2020 if (tmp == op)
2013 if (tmp == op) continue; /* Can't apply yourself */ 2021 continue; /* Can't apply yourself */
2014 2022
2015 /* Check to see if one of the movement types should be slowed down. 2023 /* Check to see if one of the movement types should be slowed down.
2016 * Second check makes sure that the movement types not being slowed 2024 * Second check makes sure that the movement types not being slowed
2017 * (~slow_move) is not blocked on this space - just because the 2025 * (~slow_move) is not blocked on this space - just because the
2018 * space doesn't slow down swimming (for example), if you can't actually 2026 * space doesn't slow down swimming (for example), if you can't actually
2019 * swim on that space, can't use it to avoid the penalty. 2027 * swim on that space, can't use it to avoid the penalty.
2020 */ 2028 */
2021 if (!QUERY_FLAG(op, FLAG_WIZPASS)) { 2029 if (!QUERY_FLAG (op, FLAG_WIZPASS))
2030 {
2022 if ((!op->move_type && tmp->move_slow & MOVE_WALK) || 2031 if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
2023 ((op->move_type & tmp->move_slow) &&
2024 (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0)) { 2032 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
2033 {
2025 2034
2026 float diff; 2035 float
2027
2028 diff = tmp->move_slow_penalty*FABS(op->speed); 2036 diff = tmp->move_slow_penalty * FABS (op->speed);
2037
2029 if (op->type == PLAYER) { 2038 if (op->type == PLAYER)
2030 if ((QUERY_FLAG(tmp, FLAG_IS_HILLY) && find_skill_by_number(op, SK_CLIMBING)) || 2039 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) ||
2031 (QUERY_FLAG(tmp, FLAG_IS_WOODED) && find_skill_by_number(op, SK_WOODSMAN))) { 2040 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN)))
2032 diff /= 4.0; 2041 diff /= 4.0;
2033 } 2042
2034 }
2035 op->speed_left -= diff; 2043 op->speed_left -= diff;
2036 } 2044 }
2037 } 2045 }
2038 2046
2039 /* Basically same logic as above, except now for actual apply. */ 2047 /* Basically same logic as above, except now for actual apply. */
2040 if ((!op->move_type && tmp->move_on & MOVE_WALK) || 2048 if ((!op->move_type && tmp->move_on & MOVE_WALK) ||
2041 ((op->move_type & tmp->move_on) &&
2042 (op->move_type & ~tmp->move_on & ~tmp->move_block)==0)) { 2049 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0))
2043 2050 {
2044 move_apply(tmp, op, originator); 2051 move_apply (tmp, op, originator);
2052
2045 if (was_destroyed (op, tag)) 2053 if (was_destroyed (op, tag))
2046 return 1; 2054 return 1;
2047 2055
2048 /* what the person/creature stepped onto has moved the object 2056 /* what the person/creature stepped onto has moved the object
2049 * someplace new. Don't process any further - if we did, 2057 * someplace new. Don't process any further - if we did,
2050 * have a feeling strange problems would result. 2058 * have a feeling strange problems would result.
2051 */ 2059 */
2052 if (op->map != m || op->x != x || op->y != y) return 0; 2060 if (op->map != m || op->x != x || op->y != y)
2061 return 0;
2053 } 2062 }
2054 } 2063 }
2064
2055 return 0; 2065 return 0;
2056} 2066}
2057 2067
2058/* 2068/*
2059 * present_arch(arch, map, x, y) searches for any objects with 2069 * present_arch(arch, map, x, y) searches for any objects with
2060 * a matching archetype at the given map and coordinates. 2070 * a matching archetype at the given map and coordinates.
2061 * The first matching object is returned, or NULL if none. 2071 * The first matching object is returned, or NULL if none.
2062 */ 2072 */
2063 2073
2074object *
2064object *present_arch(const archetype *at, mapstruct *m, int x, int y) { 2075present_arch (const archetype *at, mapstruct *m, int x, int y)
2076{
2065 object *tmp; 2077 object *
2078 tmp;
2079
2066 if(m==NULL || out_of_map(m,x,y)) { 2080 if (m == NULL || out_of_map (m, x, y))
2081 {
2067 LOG(llevError,"Present_arch called outside map.\n"); 2082 LOG (llevError, "Present_arch called outside map.\n");
2068 return NULL; 2083 return NULL;
2069 } 2084 }
2070 for(tmp=GET_MAP_OB(m,x,y); tmp != NULL; tmp = tmp->above) 2085 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above)
2071 if(tmp->arch == at) 2086 if (tmp->arch == at)
2072 return tmp; 2087 return tmp;
2073 return NULL; 2088 return NULL;
2074} 2089}
2075 2090
2076/* 2091/*
2077 * present(type, map, x, y) searches for any objects with 2092 * present(type, map, x, y) searches for any objects with
2078 * a matching type variable at the given map and coordinates. 2093 * a matching type variable at the given map and coordinates.
2079 * The first matching object is returned, or NULL if none. 2094 * The first matching object is returned, or NULL if none.
2080 */ 2095 */
2081 2096
2097object *
2082object *present(unsigned char type,mapstruct *m, int x,int y) { 2098present (unsigned char type, mapstruct *m, int x, int y)
2099{
2083 object *tmp; 2100 object *
2101 tmp;
2102
2084 if(out_of_map(m,x,y)) { 2103 if (out_of_map (m, x, y))
2104 {
2085 LOG(llevError,"Present called outside map.\n"); 2105 LOG (llevError, "Present called outside map.\n");
2086 return NULL; 2106 return NULL;
2087 } 2107 }
2088 for(tmp=GET_MAP_OB(m,x,y);tmp!=NULL;tmp=tmp->above) 2108 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above)
2089 if(tmp->type==type) 2109 if (tmp->type == type)
2090 return tmp; 2110 return tmp;
2091 return NULL; 2111 return NULL;
2092} 2112}
2093 2113
2094/* 2114/*
2095 * present_in_ob(type, object) searches for any objects with 2115 * present_in_ob(type, object) searches for any objects with
2096 * a matching type variable in the inventory of the given object. 2116 * a matching type variable in the inventory of the given object.
2097 * The first matching object is returned, or NULL if none. 2117 * The first matching object is returned, or NULL if none.
2098 */ 2118 */
2099 2119
2120object *
2100object *present_in_ob(unsigned char type, const object *op) { 2121present_in_ob (unsigned char type, const object *op)
2122{
2101 object *tmp; 2123 object *
2124 tmp;
2125
2102 for(tmp=op->inv;tmp!=NULL;tmp=tmp->below) 2126 for (tmp = op->inv; tmp != NULL; tmp = tmp->below)
2103 if(tmp->type==type) 2127 if (tmp->type == type)
2104 return tmp; 2128 return tmp;
2105 return NULL; 2129 return NULL;
2106} 2130}
2107 2131
2108/* 2132/*
… …
2118 * the object name, not the archetype name. this is so that the 2142 * the object name, not the archetype name. this is so that the
2119 * spell code can use one object type (force), but change it's name 2143 * spell code can use one object type (force), but change it's name
2120 * to be unique. 2144 * to be unique.
2121 */ 2145 */
2122 2146
2147object *
2123object *present_in_ob_by_name(int type, const char *str, const object *op) { 2148present_in_ob_by_name (int type, const char *str, const object *op)
2149{
2124 object *tmp; 2150 object *
2151 tmp;
2125 2152
2126 for(tmp=op->inv; tmp!=NULL; tmp=tmp->below) { 2153 for (tmp = op->inv; tmp != NULL; tmp = tmp->below)
2154 {
2127 if ((type==-1 || tmp->type==type) && (!strcmp(str, tmp->name))) 2155 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name)))
2128 return tmp; 2156 return tmp;
2129 } 2157 }
2130 return NULL; 2158 return NULL;
2131} 2159}
2132 2160
2133/* 2161/*
2134 * present_arch_in_ob(archetype, object) searches for any objects with 2162 * present_arch_in_ob(archetype, object) searches for any objects with
2135 * a matching archetype in the inventory of the given object. 2163 * a matching archetype in the inventory of the given object.
2136 * The first matching object is returned, or NULL if none. 2164 * The first matching object is returned, or NULL if none.
2137 */ 2165 */
2138 2166
2167object *
2139object *present_arch_in_ob(const archetype *at, const object *op) { 2168present_arch_in_ob (const archetype *at, const object *op)
2169{
2140 object *tmp; 2170 object *
2171 tmp;
2172
2141 for(tmp=op->inv;tmp!=NULL;tmp=tmp->below) 2173 for (tmp = op->inv; tmp != NULL; tmp = tmp->below)
2142 if( tmp->arch == at) 2174 if (tmp->arch == at)
2143 return tmp; 2175 return tmp;
2144 return NULL; 2176 return NULL;
2145} 2177}
2146 2178
2147/* 2179/*
2148 * activate recursively a flag on an object inventory 2180 * activate recursively a flag on an object inventory
2149 */ 2181 */
2182void
2150void flag_inv(object*op, int flag){ 2183flag_inv (object *op, int flag)
2184{
2151 object *tmp; 2185 object *
2186 tmp;
2187
2152 if(op->inv) 2188 if (op->inv)
2153 for(tmp = op->inv; tmp != NULL; tmp = tmp->below){ 2189 for (tmp = op->inv; tmp != NULL; tmp = tmp->below)
2190 {
2154 SET_FLAG(tmp, flag); 2191 SET_FLAG (tmp, flag);
2155 flag_inv(tmp,flag); 2192 flag_inv (tmp, flag);
2156 } 2193 }
2157}/* 2194} /*
2158 * desactivate recursively a flag on an object inventory 2195 * desactivate recursively a flag on an object inventory
2159 */ 2196 */
2197void
2160void unflag_inv(object*op, int flag){ 2198unflag_inv (object *op, int flag)
2199{
2161 object *tmp; 2200 object *
2201 tmp;
2202
2162 if(op->inv) 2203 if (op->inv)
2163 for(tmp = op->inv; tmp != NULL; tmp = tmp->below){ 2204 for (tmp = op->inv; tmp != NULL; tmp = tmp->below)
2205 {
2164 CLEAR_FLAG(tmp, flag); 2206 CLEAR_FLAG (tmp, flag);
2165 unflag_inv(tmp,flag); 2207 unflag_inv (tmp, flag);
2166 } 2208 }
2167} 2209}
2168 2210
2169/* 2211/*
2170 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in 2212 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in
2171 * all it's inventory (recursively). 2213 * all it's inventory (recursively).
2172 * If checksums are used, a player will get set_cheat called for 2214 * If checksums are used, a player will get set_cheat called for
2173 * him/her-self and all object carried by a call to this function. 2215 * him/her-self and all object carried by a call to this function.
2174 */ 2216 */
2175 2217
2218void
2176void set_cheat(object *op) { 2219set_cheat (object *op)
2220{
2177 SET_FLAG(op, FLAG_WAS_WIZ); 2221 SET_FLAG (op, FLAG_WAS_WIZ);
2178 flag_inv(op, FLAG_WAS_WIZ); 2222 flag_inv (op, FLAG_WAS_WIZ);
2179} 2223}
2180 2224
2181/* 2225/*
2182 * find_free_spot(object, map, x, y, start, stop) will search for 2226 * find_free_spot(object, map, x, y, start, stop) will search for
2183 * a spot at the given map and coordinates which will be able to contain 2227 * a spot at the given map and coordinates which will be able to contain
… …
2198 * to know if the space in question will block the object. We can't use 2242 * to know if the space in question will block the object. We can't use
2199 * the archetype because that isn't correct if the monster has been 2243 * the archetype because that isn't correct if the monster has been
2200 * customized, changed states, etc. 2244 * customized, changed states, etc.
2201 */ 2245 */
2202 2246
2247int
2203int find_free_spot(const object *ob, mapstruct *m,int x,int y,int start,int stop) { 2248find_free_spot (const object *ob, mapstruct *m, int x, int y, int start, int stop)
2249{
2250 int
2251 i,
2204 int i,index=0, flag; 2252 index = 0, flag;
2253 static int
2205 static int altern[SIZEOFFREE]; 2254 altern[SIZEOFFREE];
2206 2255
2207 for(i=start;i<stop;i++) { 2256 for (i = start; i < stop; i++)
2257 {
2208 flag = ob_blocked(ob,m,x+freearr_x[i],y+freearr_y[i]); 2258 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]);
2209 if(!flag) 2259 if (!flag)
2210 altern[index++]=i; 2260 altern[index++] = i;
2211 2261
2212 /* Basically, if we find a wall on a space, we cut down the search size. 2262 /* Basically, if we find a wall on a space, we cut down the search size.
2213 * In this way, we won't return spaces that are on another side of a wall. 2263 * In this way, we won't return spaces that are on another side of a wall.
2214 * This mostly work, but it cuts down the search size in all directions - 2264 * This mostly work, but it cuts down the search size in all directions -
2215 * if the space being examined only has a wall to the north and empty 2265 * if the space being examined only has a wall to the north and empty
2216 * spaces in all the other directions, this will reduce the search space 2266 * spaces in all the other directions, this will reduce the search space
2217 * to only the spaces immediately surrounding the target area, and 2267 * to only the spaces immediately surrounding the target area, and
2218 * won't look 2 spaces south of the target space. 2268 * won't look 2 spaces south of the target space.
2219 */ 2269 */
2220 else if ((flag & AB_NO_PASS) && maxfree[i]<stop) 2270 else if ((flag & AB_NO_PASS) && maxfree[i] < stop)
2221 stop=maxfree[i]; 2271 stop = maxfree[i];
2222 } 2272 }
2223 if(!index) return -1; 2273 if (!index)
2274 return -1;
2224 return altern[RANDOM()%index]; 2275 return altern[RANDOM () % index];
2225} 2276}
2226 2277
2227/* 2278/*
2228 * find_first_free_spot(archetype, mapstruct, x, y) works like 2279 * find_first_free_spot(archetype, mapstruct, x, y) works like
2229 * find_free_spot(), but it will search max number of squares. 2280 * find_free_spot(), but it will search max number of squares.
2230 * But it will return the first available spot, not a random choice. 2281 * But it will return the first available spot, not a random choice.
2231 * Changed 0.93.2: Have it return -1 if there is no free spot available. 2282 * Changed 0.93.2: Have it return -1 if there is no free spot available.
2232 */ 2283 */
2233 2284
2285int
2234int find_first_free_spot(const object *ob, mapstruct *m,int x,int y) { 2286find_first_free_spot (const object *ob, mapstruct *m, int x, int y)
2287{
2288 int
2235 int i; 2289 i;
2290
2236 for(i=0;i<SIZEOFFREE;i++) { 2291 for (i = 0; i < SIZEOFFREE; i++)
2292 {
2237 if(!ob_blocked(ob,m,x+freearr_x[i],y+freearr_y[i])) 2293 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]))
2238 return i; 2294 return i;
2239 } 2295 }
2240 return -1; 2296 return -1;
2241} 2297}
2242 2298
2243/* 2299/*
2244 * The function permute(arr, begin, end) randomly reorders the array 2300 * The function permute(arr, begin, end) randomly reorders the array
2245 * arr[begin..end-1]. 2301 * arr[begin..end-1].
2246 */ 2302 */
2303static void
2247static void permute(int *arr, int begin, int end) 2304permute (int *arr, int begin, int end)
2248{ 2305{
2249 int i, j, tmp, len; 2306 int
2307 i,
2308 j,
2309 tmp,
2310 len;
2250 2311
2251 len = end-begin; 2312 len = end - begin;
2252 for(i = begin; i < end; i++) 2313 for (i = begin; i < end; i++)
2253 { 2314 {
2254 j = begin+RANDOM()%len; 2315 j = begin + RANDOM () % len;
2255 2316
2256 tmp = arr[i]; 2317 tmp = arr[i];
2257 arr[i] = arr[j]; 2318 arr[i] = arr[j];
2258 arr[j] = tmp; 2319 arr[j] = tmp;
2259 } 2320 }
2260} 2321}
2261 2322
2262/* new function to make monster searching more efficient, and effective! 2323/* new function to make monster searching more efficient, and effective!
2263 * This basically returns a randomized array (in the passed pointer) of 2324 * This basically returns a randomized array (in the passed pointer) of
2264 * the spaces to find monsters. In this way, it won't always look for 2325 * the spaces to find monsters. In this way, it won't always look for
2265 * monsters to the north first. However, the size of the array passed 2326 * monsters to the north first. However, the size of the array passed
2266 * covers all the spaces, so within that size, all the spaces within 2327 * covers all the spaces, so within that size, all the spaces within
2267 * the 3x3 area will be searched, just not in a predictable order. 2328 * the 3x3 area will be searched, just not in a predictable order.
2268 */ 2329 */
2330void
2269void get_search_arr(int *search_arr) 2331get_search_arr (int *search_arr)
2270{ 2332{
2333 int
2271 int i; 2334 i;
2272 2335
2273 for(i = 0; i < SIZEOFFREE; i++) 2336 for (i = 0; i < SIZEOFFREE; i++)
2274 { 2337 {
2275 search_arr[i] = i; 2338 search_arr[i] = i;
2276 } 2339 }
2277 2340
2278 permute(search_arr, 1, SIZEOFFREE1+1); 2341 permute (search_arr, 1, SIZEOFFREE1 + 1);
2279 permute(search_arr, SIZEOFFREE1+1, SIZEOFFREE2+1); 2342 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1);
2280 permute(search_arr, SIZEOFFREE2+1, SIZEOFFREE); 2343 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE);
2281} 2344}
2282 2345
2283/* 2346/*
2284 * find_dir(map, x, y, exclude) will search some close squares in the 2347 * find_dir(map, x, y, exclude) will search some close squares in the
2285 * given map at the given coordinates for live objects. 2348 * given map at the given coordinates for live objects.
… …
2291 * is actually want is going to try and move there. We need this info 2354 * is actually want is going to try and move there. We need this info
2292 * because we have to know what movement the thing looking to move 2355 * because we have to know what movement the thing looking to move
2293 * there is capable of. 2356 * there is capable of.
2294 */ 2357 */
2295 2358
2359int
2296int find_dir(mapstruct *m, int x, int y, object *exclude) { 2360find_dir (mapstruct *m, int x, int y, object *exclude)
2361{
2362 int
2363 i,
2297 int i,max=SIZEOFFREE, mflags; 2364 max = SIZEOFFREE, mflags;
2365
2298 sint16 nx, ny; 2366 sint16 nx, ny;
2299 object *tmp; 2367 object *
2368 tmp;
2300 mapstruct *mp; 2369 mapstruct *
2370 mp;
2371
2301 MoveType blocked, move_type; 2372 MoveType blocked, move_type;
2302 2373
2303 if (exclude && exclude->head) { 2374 if (exclude && exclude->head)
2375 {
2304 exclude = exclude->head; 2376 exclude = exclude->head;
2305 move_type = exclude->move_type; 2377 move_type = exclude->move_type;
2306 } else { 2378 }
2379 else
2380 {
2307 /* If we don't have anything, presume it can use all movement types. */ 2381 /* If we don't have anything, presume it can use all movement types. */
2308 move_type=MOVE_ALL; 2382 move_type = MOVE_ALL;
2383 }
2384
2385 for (i = 1; i < max; i++)
2309 } 2386 {
2310
2311 for(i=1;i<max;i++) {
2312 mp = m; 2387 mp = m;
2313 nx = x + freearr_x[i]; 2388 nx = x + freearr_x[i];
2314 ny = y + freearr_y[i]; 2389 ny = y + freearr_y[i];
2315 2390
2316 mflags = get_map_flags(m, &mp, nx, ny, &nx, &ny); 2391 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);
2317 if (mflags & P_OUT_OF_MAP) { 2392 if (mflags & P_OUT_OF_MAP)
2393 {
2318 max = maxfree[i]; 2394 max = maxfree[i];
2395 }
2319 } else { 2396 else
2397 {
2320 blocked = GET_MAP_MOVE_BLOCK(mp, nx, ny); 2398 blocked = GET_MAP_MOVE_BLOCK (mp, nx, ny);
2321 2399
2322 if ((move_type & blocked) == move_type) { 2400 if ((move_type & blocked) == move_type)
2401 {
2323 max=maxfree[i]; 2402 max = maxfree[i];
2403 }
2324 } else if (mflags & P_IS_ALIVE) { 2404 else if (mflags & P_IS_ALIVE)
2405 {
2325 for (tmp=GET_MAP_OB(mp,nx,ny); tmp!= NULL; tmp=tmp->above) { 2406 for (tmp = GET_MAP_OB (mp, nx, ny); tmp != NULL; tmp = tmp->above)
2326 if ((QUERY_FLAG(tmp,FLAG_MONSTER) || tmp->type==PLAYER) && 2407 {
2327 (tmp != exclude ||(tmp->head && tmp->head != exclude))) { 2408 if ((QUERY_FLAG (tmp, FLAG_MONSTER) || tmp->type == PLAYER) && (tmp != exclude || (tmp->head && tmp->head != exclude)))
2409 {
2328 break; 2410 break;
2329 } 2411 }
2330 } 2412 }
2331 if(tmp) { 2413 if (tmp)
2414 {
2332 return freedir[i]; 2415 return freedir[i];
2333 } 2416 }
2334 } 2417 }
2335 } 2418 }
2336 } 2419 }
2337 return 0; 2420 return 0;
2338} 2421}
2339 2422
2340/* 2423/*
2341 * distance(object 1, object 2) will return the square of the 2424 * distance(object 1, object 2) will return the square of the
2342 * distance between the two given objects. 2425 * distance between the two given objects.
2343 */ 2426 */
2344 2427
2428int
2345int distance(const object *ob1, const object *ob2) { 2429distance (const object *ob1, const object *ob2)
2430{
2346 int i; 2431 int
2347 i= (ob1->x - ob2->x)*(ob1->x - ob2->x)+ 2432 i;
2348 (ob1->y - ob2->y)*(ob1->y - ob2->y); 2433
2434 i = (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2349 return i; 2435 return i;
2350} 2436}
2351 2437
2352/* 2438/*
2353 * find_dir_2(delta-x,delta-y) will return a direction in which 2439 * find_dir_2(delta-x,delta-y) will return a direction in which
2354 * an object which has subtracted the x and y coordinates of another 2440 * an object which has subtracted the x and y coordinates of another
2355 * object, needs to travel toward it. 2441 * object, needs to travel toward it.
2356 */ 2442 */
2357 2443
2444int
2358int find_dir_2(int x, int y) { 2445find_dir_2 (int x, int y)
2446{
2359 int q; 2447 int
2448 q;
2360 2449
2361 if(y) 2450 if (y)
2362 q=x*100/y; 2451 q = x * 100 / y;
2363 else if (x) 2452 else if (x)
2364 q= -300*x; 2453 q = -300 * x;
2365 else 2454 else
2366 return 0; 2455 return 0;
2367 2456
2368 if(y>0) { 2457 if (y > 0)
2458 {
2369 if(q < -242) 2459 if (q < -242)
2370 return 3 ; 2460 return 3;
2371 if (q < -41) 2461 if (q < -41)
2372 return 2 ; 2462 return 2;
2373 if (q < 41) 2463 if (q < 41)
2374 return 1 ; 2464 return 1;
2375 if (q < 242) 2465 if (q < 242)
2376 return 8 ; 2466 return 8;
2377 return 7 ; 2467 return 7;
2378 } 2468 }
2379 2469
2380 if (q < -242) 2470 if (q < -242)
2381 return 7 ; 2471 return 7;
2382 if (q < -41) 2472 if (q < -41)
2383 return 6 ; 2473 return 6;
2384 if (q < 41) 2474 if (q < 41)
2385 return 5 ; 2475 return 5;
2386 if (q < 242) 2476 if (q < 242)
2387 return 4 ; 2477 return 4;
2388 2478
2389 return 3 ; 2479 return 3;
2390} 2480}
2391 2481
2392/* 2482/*
2393 * absdir(int): Returns a number between 1 and 8, which represent 2483 * absdir(int): Returns a number between 1 and 8, which represent
2394 * the "absolute" direction of a number (it actually takes care of 2484 * the "absolute" direction of a number (it actually takes care of
2395 * "overflow" in previous calculations of a direction). 2485 * "overflow" in previous calculations of a direction).
2396 */ 2486 */
2397 2487
2488int
2398int absdir(int d) { 2489absdir (int d)
2399 while(d<1) d+=8; 2490{
2400 while(d>8) d-=8; 2491 while (d < 1)
2492 d += 8;
2493 while (d > 8)
2494 d -= 8;
2401 return d; 2495 return d;
2402} 2496}
2403 2497
2404/* 2498/*
2405 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is 2499 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is
2406 * between two directions (which are expected to be absolute (see absdir()) 2500 * between two directions (which are expected to be absolute (see absdir())
2407 */ 2501 */
2408 2502
2503int
2409int dirdiff(int dir1, int dir2) { 2504dirdiff (int dir1, int dir2)
2505{
2410 int d; 2506 int
2507 d;
2508
2411 d = abs(dir1 - dir2); 2509 d = abs (dir1 - dir2);
2412 if(d>4) 2510 if (d > 4)
2413 d = 8 - d; 2511 d = 8 - d;
2414 return d; 2512 return d;
2415} 2513}
2416 2514
2417/* peterm: 2515/* peterm:
… …
2422 * direction 4, 14, or 16 to get back to where we are. 2520 * direction 4, 14, or 16 to get back to where we are.
2423 * Moved from spell_util.c to object.c with the other related direction 2521 * Moved from spell_util.c to object.c with the other related direction
2424 * functions. 2522 * functions.
2425 */ 2523 */
2426 2524
2525int
2427int reduction_dir[SIZEOFFREE][3] = { 2526 reduction_dir[SIZEOFFREE][3] = {
2428 {0,0,0}, /* 0 */ 2527 {0, 0, 0}, /* 0 */
2429 {0,0,0}, /* 1 */ 2528 {0, 0, 0}, /* 1 */
2430 {0,0,0}, /* 2 */ 2529 {0, 0, 0}, /* 2 */
2431 {0,0,0}, /* 3 */ 2530 {0, 0, 0}, /* 3 */
2432 {0,0,0}, /* 4 */ 2531 {0, 0, 0}, /* 4 */
2433 {0,0,0}, /* 5 */ 2532 {0, 0, 0}, /* 5 */
2434 {0,0,0}, /* 6 */ 2533 {0, 0, 0}, /* 6 */
2435 {0,0,0}, /* 7 */ 2534 {0, 0, 0}, /* 7 */
2436 {0,0,0}, /* 8 */ 2535 {0, 0, 0}, /* 8 */
2437 {8,1,2}, /* 9 */ 2536 {8, 1, 2}, /* 9 */
2438 {1,2,-1}, /* 10 */ 2537 {1, 2, -1}, /* 10 */
2439 {2,10,12}, /* 11 */ 2538 {2, 10, 12}, /* 11 */
2440 {2,3,-1}, /* 12 */ 2539 {2, 3, -1}, /* 12 */
2441 {2,3,4}, /* 13 */ 2540 {2, 3, 4}, /* 13 */
2442 {3,4,-1}, /* 14 */ 2541 {3, 4, -1}, /* 14 */
2443 {4,14,16}, /* 15 */ 2542 {4, 14, 16}, /* 15 */
2444 {5,4,-1}, /* 16 */ 2543 {5, 4, -1}, /* 16 */
2445 {4,5,6}, /* 17 */ 2544 {4, 5, 6}, /* 17 */
2446 {6,5,-1}, /* 18 */ 2545 {6, 5, -1}, /* 18 */
2447 {6,20,18}, /* 19 */ 2546 {6, 20, 18}, /* 19 */
2448 {7,6,-1}, /* 20 */ 2547 {7, 6, -1}, /* 20 */
2449 {6,7,8}, /* 21 */ 2548 {6, 7, 8}, /* 21 */
2450 {7,8,-1}, /* 22 */ 2549 {7, 8, -1}, /* 22 */
2451 {8,22,24}, /* 23 */ 2550 {8, 22, 24}, /* 23 */
2452 {8,1,-1}, /* 24 */ 2551 {8, 1, -1}, /* 24 */
2453 {24,9,10}, /* 25 */ 2552 {24, 9, 10}, /* 25 */
2454 {9,10,-1}, /* 26 */ 2553 {9, 10, -1}, /* 26 */
2455 {10,11,-1}, /* 27 */ 2554 {10, 11, -1}, /* 27 */
2456 {27,11,29}, /* 28 */ 2555 {27, 11, 29}, /* 28 */
2457 {11,12,-1}, /* 29 */ 2556 {11, 12, -1}, /* 29 */
2458 {12,13,-1}, /* 30 */ 2557 {12, 13, -1}, /* 30 */
2459 {12,13,14}, /* 31 */ 2558 {12, 13, 14}, /* 31 */
2460 {13,14,-1}, /* 32 */ 2559 {13, 14, -1}, /* 32 */
2461 {14,15,-1}, /* 33 */ 2560 {14, 15, -1}, /* 33 */
2462 {33,15,35}, /* 34 */ 2561 {33, 15, 35}, /* 34 */
2463 {16,15,-1}, /* 35 */ 2562 {16, 15, -1}, /* 35 */
2464 {17,16,-1}, /* 36 */ 2563 {17, 16, -1}, /* 36 */
2465 {18,17,16}, /* 37 */ 2564 {18, 17, 16}, /* 37 */
2466 {18,17,-1}, /* 38 */ 2565 {18, 17, -1}, /* 38 */
2467 {18,19,-1}, /* 39 */ 2566 {18, 19, -1}, /* 39 */
2468 {41,19,39}, /* 40 */ 2567 {41, 19, 39}, /* 40 */
2469 {19,20,-1}, /* 41 */ 2568 {19, 20, -1}, /* 41 */
2470 {20,21,-1}, /* 42 */ 2569 {20, 21, -1}, /* 42 */
2471 {20,21,22}, /* 43 */ 2570 {20, 21, 22}, /* 43 */
2472 {21,22,-1}, /* 44 */ 2571 {21, 22, -1}, /* 44 */
2473 {23,22,-1}, /* 45 */ 2572 {23, 22, -1}, /* 45 */
2474 {45,47,23}, /* 46 */ 2573 {45, 47, 23}, /* 46 */
2475 {23,24,-1}, /* 47 */ 2574 {23, 24, -1}, /* 47 */
2476 {24,9,-1}}; /* 48 */ 2575 {24, 9, -1}
2576}; /* 48 */
2477 2577
2478/* Recursive routine to step back and see if we can 2578/* Recursive routine to step back and see if we can
2479 * find a path to that monster that we found. If not, 2579 * find a path to that monster that we found. If not,
2480 * we don't bother going toward it. Returns 1 if we 2580 * we don't bother going toward it. Returns 1 if we
2481 * can see a direct way to get it 2581 * can see a direct way to get it
2482 * Modified to be map tile aware -.MSW 2582 * Modified to be map tile aware -.MSW
2483 */ 2583 */
2484
2485 2584
2585
2586int
2486int can_see_monsterP(mapstruct *m, int x, int y,int dir) { 2587can_see_monsterP (mapstruct *m, int x, int y, int dir)
2588{
2487 sint16 dx, dy; 2589 sint16 dx, dy;
2590 int
2488 int mflags; 2591 mflags;
2489 2592
2593 if (dir < 0)
2490 if(dir<0) return 0; /* exit condition: invalid direction */ 2594 return 0; /* exit condition: invalid direction */
2491 2595
2492 dx = x + freearr_x[dir]; 2596 dx = x + freearr_x[dir];
2493 dy = y + freearr_y[dir]; 2597 dy = y + freearr_y[dir];
2494 2598
2495 mflags = get_map_flags(m, &m, dx, dy, &dx, &dy); 2599 mflags = get_map_flags (m, &m, dx, dy, &dx, &dy);
2496 2600
2497 /* This functional arguably was incorrect before - it was 2601 /* This functional arguably was incorrect before - it was
2498 * checking for P_WALL - that was basically seeing if 2602 * checking for P_WALL - that was basically seeing if
2499 * we could move to the monster - this is being more 2603 * we could move to the monster - this is being more
2500 * literal on if we can see it. To know if we can actually 2604 * literal on if we can see it. To know if we can actually
2501 * move to the monster, we'd need the monster passed in or 2605 * move to the monster, we'd need the monster passed in or
2502 * at least its move type. 2606 * at least its move type.
2503 */ 2607 */
2504 if (mflags & (P_OUT_OF_MAP | P_BLOCKSVIEW)) return 0; 2608 if (mflags & (P_OUT_OF_MAP | P_BLOCKSVIEW))
2609 return 0;
2505 2610
2506 /* yes, can see. */ 2611 /* yes, can see. */
2507 if(dir < 9) return 1; 2612 if (dir < 9)
2613 return 1;
2508 return can_see_monsterP(m, x, y, reduction_dir[dir][0]) | 2614 return can_see_monsterP (m, x, y, reduction_dir[dir][0]) |
2509 can_see_monsterP(m,x,y, reduction_dir[dir][1]) | 2615 can_see_monsterP (m, x, y, reduction_dir[dir][1]) | can_see_monsterP (m, x, y, reduction_dir[dir][2]);
2510 can_see_monsterP(m,x,y, reduction_dir[dir][2]);
2511} 2616}
2512 2617
2513 2618
2514 2619
2515/* 2620/*
2516 * can_pick(picker, item): finds out if an object is possible to be 2621 * can_pick(picker, item): finds out if an object is possible to be
2517 * picked up by the picker. Returnes 1 if it can be 2622 * picked up by the picker. Returnes 1 if it can be
2518 * picked up, otherwise 0. 2623 * picked up, otherwise 0.
2519 * 2624 *
… …
2521 * core dumps if they do. 2626 * core dumps if they do.
2522 * 2627 *
2523 * Add a check so we can't pick up invisible objects (0.93.8) 2628 * Add a check so we can't pick up invisible objects (0.93.8)
2524 */ 2629 */
2525 2630
2631int
2526int can_pick(const object *who, const object *item) { 2632can_pick (const object *who, const object *item)
2633{
2527 return /*QUERY_FLAG(who,FLAG_WIZ)||*/ 2634 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2528 (item->weight>0&&!QUERY_FLAG(item,FLAG_NO_PICK)&& 2635 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2529 !QUERY_FLAG(item,FLAG_ALIVE)&&!item->invisible && 2636 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));
2530 (who->type==PLAYER||item->weight<who->weight/3));
2531} 2637}
2532 2638
2533 2639
2534/* 2640/*
2535 * create clone from object to another 2641 * create clone from object to another
2536 */ 2642 */
2643object *
2537object *object_create_clone (object *asrc) { 2644object_create_clone (object *asrc)
2645{
2646 object *
2538 object *dst = NULL,*tmp,*src,*part,*prev, *item; 2647 dst = NULL, *tmp, *src, *part, *prev, *item;
2539 2648
2649 if (!asrc)
2540 if(!asrc) return NULL; 2650 return NULL;
2541 src = asrc; 2651 src = asrc;
2542 if(src->head) 2652 if (src->head)
2543 src = src->head; 2653 src = src->head;
2544 2654
2545 prev = NULL; 2655 prev = NULL;
2546 for(part = src; part; part = part->more) { 2656 for (part = src; part; part = part->more)
2657 {
2547 tmp = get_object(); 2658 tmp = get_object ();
2548 copy_object(part,tmp); 2659 copy_object (part, tmp);
2549 tmp->x -= src->x; 2660 tmp->x -= src->x;
2550 tmp->y -= src->y; 2661 tmp->y -= src->y;
2551 if(!part->head) { 2662 if (!part->head)
2663 {
2552 dst = tmp; 2664 dst = tmp;
2553 tmp->head = NULL; 2665 tmp->head = NULL;
2666 }
2554 } else { 2667 else
2668 {
2555 tmp->head = dst; 2669 tmp->head = dst;
2556 } 2670 }
2557 tmp->more = NULL; 2671 tmp->more = NULL;
2558 if(prev) 2672 if (prev)
2559 prev->more = tmp; 2673 prev->more = tmp;
2560 prev = tmp; 2674 prev = tmp;
2561 } 2675 }
2676
2562 /*** copy inventory ***/ 2677 /*** copy inventory ***/
2563 for(item = src->inv; item; item = item->below) { 2678 for (item = src->inv; item; item = item->below)
2679 {
2564 (void) insert_ob_in_ob(object_create_clone(item),dst); 2680 (void) insert_ob_in_ob (object_create_clone (item), dst);
2565 } 2681 }
2566 2682
2567 return dst; 2683 return dst;
2568} 2684}
2569 2685
2570/* return true if the object was destroyed, 0 otherwise */ 2686/* return true if the object was destroyed, 0 otherwise */
2687int
2571int was_destroyed (const object *op, tag_t old_tag) 2688was_destroyed (const object *op, tag_t old_tag)
2572{ 2689{
2573 /* checking for FLAG_FREED isn't necessary, but makes this function more 2690 /* checking for FLAG_FREED isn't necessary, but makes this function more
2574 * robust */ 2691 * robust */
2575 return op->count != old_tag || QUERY_FLAG (op, FLAG_FREED); 2692 return op->count != old_tag || QUERY_FLAG (op, FLAG_FREED);
2576} 2693}
2577 2694
2578/* GROS - Creates an object using a string representing its content. */ 2695/* GROS - Creates an object using a string representing its content. */
2696
2579/* Basically, we save the content of the string to a temp file, then call */ 2697/* Basically, we save the content of the string to a temp file, then call */
2698
2580/* load_object on it. I admit it is a highly inefficient way to make things, */ 2699/* load_object on it. I admit it is a highly inefficient way to make things, */
2700
2581/* but it was simple to make and allows reusing the load_object function. */ 2701/* but it was simple to make and allows reusing the load_object function. */
2702
2582/* Remember not to use load_object_str in a time-critical situation. */ 2703/* Remember not to use load_object_str in a time-critical situation. */
2704
2583/* Also remember that multiparts objects are not supported for now. */ 2705/* Also remember that multiparts objects are not supported for now. */
2584 2706
2707object *
2585object* load_object_str(const char *obstr) 2708load_object_str (const char *obstr)
2586{ 2709{
2587 object *op; 2710 object *
2711 op;
2712 char
2588 char filename[MAX_BUF]; 2713 filename[MAX_BUF];
2714
2589 sprintf(filename,"%s/cfloadobstr2044",settings.tmpdir); 2715 sprintf (filename, "%s/cfloadobstr2044", settings.tmpdir);
2590 2716
2717 FILE *
2591 FILE *tempfile=fopen(filename,"w"); 2718 tempfile = fopen (filename, "w");
2719
2592 if (tempfile == NULL) 2720 if (tempfile == NULL)
2593 { 2721 {
2594 LOG(llevError,"Error - Unable to access load object temp file\n"); 2722 LOG (llevError, "Error - Unable to access load object temp file\n");
2595 return NULL; 2723 return NULL;
2596 }; 2724 };
2597 fprintf(tempfile,obstr); 2725 fprintf (tempfile, obstr);
2598 fclose(tempfile); 2726 fclose (tempfile);
2599 2727
2600 op=get_object(); 2728 op = get_object ();
2601 2729
2602 object_thawer thawer (filename); 2730 object_thawer thawer (filename);
2731
2603 if (thawer) 2732 if (thawer)
2604 load_object(thawer,op,LO_NEWFILE,0); 2733 load_object (thawer, op, 0);
2734
2605 LOG(llevDebug," load str completed, object=%s\n",op->name); 2735 LOG (llevDebug, " load str completed, object=%s\n", &op->name);
2606 CLEAR_FLAG(op,FLAG_REMOVED); 2736 CLEAR_FLAG (op, FLAG_REMOVED);
2607 2737
2608 return op; 2738 return op;
2609} 2739}
2610 2740
2611/* This returns the first object in who's inventory that 2741/* This returns the first object in who's inventory that
2612 * has the same type and subtype match. 2742 * has the same type and subtype match.
2613 * returns NULL if no match. 2743 * returns NULL if no match.
2614 */ 2744 */
2745object *
2615object *find_obj_by_type_subtype(const object *who, int type, int subtype) 2746find_obj_by_type_subtype (const object *who, int type, int subtype)
2616{ 2747{
2617 object *tmp; 2748 object *
2749 tmp;
2618 2750
2619 for (tmp=who->inv; tmp; tmp=tmp->below) 2751 for (tmp = who->inv; tmp; tmp = tmp->below)
2620 if (tmp->type == type && tmp->subtype == subtype) return tmp; 2752 if (tmp->type == type && tmp->subtype == subtype)
2753 return tmp;
2621 2754
2622 return NULL; 2755 return NULL;
2623} 2756}
2624 2757
2625/* If ob has a field named key, return the link from the list, 2758/* If ob has a field named key, return the link from the list,
2626 * otherwise return NULL. 2759 * otherwise return NULL.
2627 * 2760 *
2628 * key must be a passed in shared string - otherwise, this won't 2761 * key must be a passed in shared string - otherwise, this won't
2629 * do the desired thing. 2762 * do the desired thing.
2630 */ 2763 */
2764key_value *
2631key_value * get_ob_key_link(const object * ob, const char * key) { 2765get_ob_key_link (const object *ob, const char *key)
2766{
2632 key_value * link; 2767 key_value *
2633 2768 link;
2769
2634 for (link = ob->key_values; link != NULL; link = link->next) { 2770 for (link = ob->key_values; link != NULL; link = link->next)
2771 {
2635 if (link->key == key) { 2772 if (link->key == key)
2773 {
2636 return link; 2774 return link;
2637 } 2775 }
2638 }
2639 2776 }
2777
2640 return NULL; 2778 return NULL;
2641} 2779}
2642 2780
2643/* 2781/*
2644 * Returns the value of op has an extra_field for key, or NULL. 2782 * Returns the value of op has an extra_field for key, or NULL.
2645 * 2783 *
2646 * The argument doesn't need to be a shared string. 2784 * The argument doesn't need to be a shared string.
2647 * 2785 *
2648 * The returned string is shared. 2786 * The returned string is shared.
2649 */ 2787 */
2788const char *
2650const char * get_ob_key_value(const object * op, const char * const key) { 2789get_ob_key_value (const object *op, const char *const key)
2790{
2651 key_value * link; 2791 key_value *
2652 const char * canonical_key; 2792 link;
2653 2793 const char *
2794 canonical_key;
2795
2654 canonical_key = find_string(key); 2796 canonical_key = shstr::find (key);
2655 2797
2656 if (canonical_key == NULL) { 2798 if (canonical_key == NULL)
2799 {
2657 /* 1. There being a field named key on any object 2800 /* 1. There being a field named key on any object
2658 * implies there'd be a shared string to find. 2801 * implies there'd be a shared string to find.
2659 * 2. Since there isn't, no object has this field. 2802 * 2. Since there isn't, no object has this field.
2660 * 3. Therefore, *this* object doesn't have this field. 2803 * 3. Therefore, *this* object doesn't have this field.
2661 */ 2804 */
2662 return NULL; 2805 return NULL;
2663 } 2806 }
2664 2807
2665 /* This is copied from get_ob_key_link() above - 2808 /* This is copied from get_ob_key_link() above -
2666 * only 4 lines, and saves the function call overhead. 2809 * only 4 lines, and saves the function call overhead.
2667 */ 2810 */
2668 for (link = op->key_values; link != NULL; link = link->next) { 2811 for (link = op->key_values; link != NULL; link = link->next)
2812 {
2669 if (link->key == canonical_key) { 2813 if (link->key == canonical_key)
2814 {
2670 return link->value; 2815 return link->value;
2671 } 2816 }
2672 } 2817 }
2673 return NULL; 2818 return NULL;
2674} 2819}
2675 2820
2676 2821
2677/* 2822/*
2678 * Updates the canonical_key in op to value. 2823 * Updates the canonical_key in op to value.
… …
2682 * Unless add_key is TRUE, it won't add fields, only change the value of existing 2827 * Unless add_key is TRUE, it won't add fields, only change the value of existing
2683 * keys. 2828 * keys.
2684 * 2829 *
2685 * Returns TRUE on success. 2830 * Returns TRUE on success.
2686 */ 2831 */
2832int
2687int set_ob_key_value_s(object * op, const char * canonical_key, const char * value, int add_key) { 2833set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2834{
2835 key_value *
2688 key_value * field = NULL, *last=NULL; 2836 field = NULL, *last = NULL;
2689 2837
2690 for (field=op->key_values; field != NULL; field=field->next) { 2838 for (field = op->key_values; field != NULL; field = field->next)
2839 {
2691 if (field->key != canonical_key) { 2840 if (field->key != canonical_key)
2841 {
2692 last = field; 2842 last = field;
2693 continue; 2843 continue;
2694 } 2844 }
2695 2845
2696 if (field->value) FREE_AND_CLEAR_STR(field->value);
2697 if (value) 2846 if (value)
2698 field->value = add_string(value); 2847 field->value = value;
2699 else { 2848 else
2849 {
2700 /* Basically, if the archetype has this key set, 2850 /* Basically, if the archetype has this key set,
2701 * we need to store the null value so when we save 2851 * we need to store the null value so when we save
2702 * it, we save the empty value so that when we load, 2852 * it, we save the empty value so that when we load,
2703 * we get this value back again. 2853 * we get this value back again.
2704 */ 2854 */
2705 if (get_ob_key_link(&op->arch->clone, canonical_key)) 2855 if (get_ob_key_link (&op->arch->clone, canonical_key))
2706 field->value = NULL; 2856 field->value = 0;
2707 else { 2857 else
2708 /* Delete this link */ 2858 {
2709 if (field->key) FREE_AND_CLEAR_STR(field->key); 2859 if (last)
2710 if (field->value) FREE_AND_CLEAR_STR(field->value);
2711 if (last) last->next = field->next; 2860 last->next = field->next;
2861 else
2712 else op->key_values = field->next; 2862 op->key_values = field->next;
2863
2713 free(field); 2864 delete field;
2714 } 2865 }
2715 } 2866 }
2716 return TRUE; 2867 return TRUE;
2717 } 2868 }
2718 /* IF we get here, key doesn't exist */ 2869 /* IF we get here, key doesn't exist */
2719 2870
2720 /* No field, we'll have to add it. */ 2871 /* No field, we'll have to add it. */
2872
2873 if (!add_key)
2721 2874 {
2722 if (!add_key) {
2723 return FALSE; 2875 return FALSE;
2724 } 2876 }
2725 /* There isn't any good reason to store a null 2877 /* There isn't any good reason to store a null
2726 * value in the key/value list. If the archetype has 2878 * value in the key/value list. If the archetype has
2727 * this key, then we should also have it, so shouldn't 2879 * this key, then we should also have it, so shouldn't
2728 * be here. If user wants to store empty strings, 2880 * be here. If user wants to store empty strings,
2729 * should pass in "" 2881 * should pass in ""
2730 */ 2882 */
2731 if (value == NULL) return TRUE; 2883 if (value == NULL)
2732
2733 field = (key_value *) malloc(sizeof(key_value));
2734
2735 field->key = add_refcount(canonical_key);
2736 field->value = add_string(value);
2737 /* Usual prepend-addition. */
2738 field->next = op->key_values;
2739 op->key_values = field;
2740
2741 return TRUE; 2884 return TRUE;
2885
2886 field = new key_value;
2887
2888 field->key = canonical_key;
2889 field->value = value;
2890 /* Usual prepend-addition. */
2891 field->next = op->key_values;
2892 op->key_values = field;
2893
2894 return TRUE;
2742} 2895}
2743 2896
2744/* 2897/*
2745 * Updates the key in op to value. 2898 * Updates the key in op to value.
2746 * 2899 *
… …
2748 * and not add new ones. 2901 * and not add new ones.
2749 * In general, should be little reason FALSE is ever passed in for add_key 2902 * In general, should be little reason FALSE is ever passed in for add_key
2750 * 2903 *
2751 * Returns TRUE on success. 2904 * Returns TRUE on success.
2752 */ 2905 */
2906int
2753int set_ob_key_value(object * op, const char * key, const char * value, int add_key) { 2907set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2754 const char * canonical_key = NULL; 2908{
2755 int floating_ref = FALSE; 2909 shstr key_ (key);
2756 int ret; 2910
2757
2758 /* HACK This mess is to make sure set_ob_value() passes a shared string
2759 * to get_ob_key_link(), without leaving a leaked refcount.
2760 */
2761
2762 canonical_key = find_string(key);
2763 if (canonical_key == NULL) {
2764 canonical_key = add_string(key);
2765 floating_ref = TRUE;
2766 }
2767
2768 ret = set_ob_key_value_s(op, canonical_key, value, add_key); 2911 return set_ob_key_value_s (op, key_, value, add_key);
2769
2770 if (floating_ref) {
2771 free_string(canonical_key);
2772 }
2773
2774 return ret;
2775} 2912}

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines