ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.26 by root, Mon Sep 11 11:46:52 2006 UTC vs.
Revision 1.122 by root, Wed Jan 24 22:42:48 2007 UTC

1
2/* 1/*
3 * static char *rcsid_object_c =
4 * "$Id: object.C,v 1.26 2006/09/11 11:46:52 root Exp $";
5 */
6
7/*
8 CrossFire, A Multiplayer game for X-windows 2 * CrossFire, A Multiplayer game for X-windows
9 3 *
4 * Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team
10 Copyright (C) 2001 Mark Wedel & Crossfire Development Team 5 * Copyright (C) 2001 Mark Wedel & Crossfire Development Team
11 Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (C) 1992 Frank Tore Johansen
12 7 *
13 This program is free software; you can redistribute it and/or modify 8 * This program is free software; you can redistribute it and/or modify
14 it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
15 the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation; either version 2 of the License, or
16 (at your option) any later version. 11 * (at your option) any later version.
17 12 *
18 This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
19 but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
20 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
21 GNU General Public License for more details. 16 * GNU General Public License for more details.
22 17 *
23 You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
24 along with this program; if not, write to the Free Software 19 * along with this program; if not, write to the Free Software
25 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
26 21 *
27 The authors can be reached via e-mail at crossfire-devel@real-time.com 22 * The authors can be reached via e-mail at <crossfire@schmorp.de>
28*/ 23 */
29 24
30/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects. 25/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
31 sub/add_weight will transcend the environment updating the carrying 26 sub/add_weight will transcend the environment updating the carrying
32 variable. */ 27 variable. */
33#include <global.h> 28#include <global.h>
34#ifndef WIN32 /* ---win32 exclude headers */
35# include <stdio.h> 29#include <stdio.h>
36# include <sys/types.h> 30#include <sys/types.h>
37# include <sys/uio.h> 31#include <sys/uio.h>
38#endif /* win32 */
39#include <object.h> 32#include <object.h>
40#include <funcpoint.h> 33#include <funcpoint.h>
41#include <skills.h>
42#include <loader.h> 34#include <loader.h>
35
36#include <bitset>
37
43int nrofallocobjects = 0; 38int nrofallocobjects = 0;
39static UUID uuid;
40const uint64 UUID_SKIP = 1<<19;
44 41
45object *objects; /* Pointer to the list of used objects */ 42objectvec objects;
46object *active_objects; /* List of active objects that need to be processed */ 43activevec actives;
47 44
48short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 45short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
49 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1 46 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1
50}; 47};
51short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, 48short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
57int freedir[SIZEOFFREE] = { 54int freedir[SIZEOFFREE] = {
58 0, 1, 2, 3, 4, 5, 6, 7, 8, 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8, 55 0, 1, 2, 3, 4, 5, 6, 7, 8, 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,
59 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8 56 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8
60}; 57};
61 58
59static void
60write_uuid (void)
61{
62 char filename1[MAX_BUF], filename2[MAX_BUF];
63
64 sprintf (filename1, "%s/uuid", settings.localdir);
65 sprintf (filename2, "%s/uuid~", settings.localdir);
66
67 FILE *fp;
68
69 if (!(fp = fopen (filename2, "w")))
70 {
71 LOG (llevError, "ERROR: cannot open %s for writing, unable to write UUID!\n", filename2);
72 return;
73 }
74
75 fprintf (fp, "<1,%llx>\n", (unsigned long long)uuid.seq + UUID_SKIP * 2);
76 fclose (fp);
77 rename (filename2, filename1);
78}
79
80static void
81read_uuid (void)
82{
83 char filename[MAX_BUF];
84
85 sprintf (filename, "%s/uuid", settings.localdir);
86
87 FILE *fp;
88
89 if (!(fp = fopen (filename, "r")))
90 {
91 if (errno == ENOENT)
92 {
93 LOG (llevInfo, "RESET uid to 1\n");
94 uuid.seq = 0;
95 write_uuid ();
96 return;
97 }
98
99 LOG (llevError, "FATAL: cannot open %s for reading!\n", filename);
100 _exit (1);
101 }
102
103 int version;
104 unsigned long long uid;
105 if (2 != fscanf (fp, "<%d,%llx>\n", &version, &uid) || version != 1)
106 {
107 LOG (llevError, "FATAL: error reading uid from %s!\n", filename);
108 _exit (1);
109 }
110
111 uuid.seq = uid;
112 write_uuid ();
113 LOG (llevDebug, "read UID: %" PRId64 "\n", uid);
114 fclose (fp);
115}
116
117UUID
118gen_uuid ()
119{
120 UUID uid;
121
122 uid.seq = ++uuid.seq;
123
124 if (!(uuid.seq & (UUID_SKIP - 1)))
125 write_uuid ();
126
127 return uid;
128}
129
130void
131init_uuid ()
132{
133 read_uuid ();
134}
135
62/* Returns TRUE if every key_values in wants has a partner with the same value in has. */ 136/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
63static int 137static int
64compare_ob_value_lists_one (const object *wants, const object *has) 138compare_ob_value_lists_one (const object *wants, const object *has)
65{ 139{
66 key_value *wants_field; 140 key_value *wants_field;
69 * objects with lists are rare, and lists stay short. If not, use a 143 * objects with lists are rare, and lists stay short. If not, use a
70 * different structure or at least keep the lists sorted... 144 * different structure or at least keep the lists sorted...
71 */ 145 */
72 146
73 /* For each field in wants, */ 147 /* For each field in wants, */
74 for (wants_field = wants->key_values; wants_field != NULL; wants_field = wants_field->next) 148 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)
75 { 149 {
76 key_value *has_field; 150 key_value *has_field;
77 151
78 /* Look for a field in has with the same key. */ 152 /* Look for a field in has with the same key. */
79 has_field = get_ob_key_link (has, wants_field->key); 153 has_field = get_ob_key_link (has, wants_field->key);
113 * 187 *
114 * Note that this function appears a lot longer than the macro it 188 * Note that this function appears a lot longer than the macro it
115 * replaces - this is mostly for clarity - a decent compiler should hopefully 189 * replaces - this is mostly for clarity - a decent compiler should hopefully
116 * reduce this to the same efficiency. 190 * reduce this to the same efficiency.
117 * 191 *
118 * Check nrof variable *before* calling CAN_MERGE() 192 * Check nrof variable *before* calling can_merge()
119 * 193 *
120 * Improvements made with merge: Better checking on potion, and also 194 * Improvements made with merge: Better checking on potion, and also
121 * check weight 195 * check weight
122 */ 196 */
123
124bool object::can_merge (object *ob1, object *ob2) 197bool object::can_merge_slow (object *ob1, object *ob2)
125{ 198{
126 /* A couple quicksanity checks */ 199 /* A couple quicksanity checks */
127 if ((ob1 == ob2) || (ob1->type != ob2->type)) 200 if (ob1 == ob2
201 || ob1->type != ob2->type
202 || ob1->speed != ob2->speed
203 || ob1->value != ob2->value
204 || ob1->name != ob2->name)
128 return 0; 205 return 0;
129 206
130 if (ob1->speed != ob2->speed) 207 //TODO: this ain't working well, use nicer and correct overflow check
131 return 0;
132
133 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that 208 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that
134 * value could not be stored in a sint32 (which unfortunately sometimes is 209 * value could not be stored in a sint32 (which unfortunately sometimes is
135 * used to store nrof). 210 * used to store nrof).
136 */ 211 */
137 if (ob1->nrof + ob2->nrof >= 1UL << 31) 212 if (ob1->nrof + ob2->nrof >= 1UL << 31)
147 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 222 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
148 223
149 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 224 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
150 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 225 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
151 226
152 227 if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any ()
153 /* the 0x400000 on flags2 is FLAG_INV_LOCK. I don't think something 228 || ob1->arch != ob2->arch
154 * being locked in inventory should prevent merging.
155 * 0x4 in flags3 is CLIENT_SENT
156 */
157 if ((ob1->arch != ob2->arch) ||
158 (ob1->flags[0] != ob2->flags[0]) ||
159 (ob1->flags[1] != ob2->flags[1]) ||
160 ((ob1->flags[2] & ~0x400000) != (ob2->flags[2] & ~0x400000)) ||
161 ((ob1->flags[3] & ~0x4) != (ob2->flags[3] & ~0x4)) ||
162 (ob1->name != ob2->name) || 229 || ob1->name != ob2->name
163 (ob1->title != ob2->title) || 230 || ob1->title != ob2->title
164 (ob1->msg != ob2->msg) || 231 || ob1->msg != ob2->msg
165 (ob1->weight != ob2->weight) || 232 || ob1->weight != ob2->weight
166 (memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist)) != 0) || 233 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
167 (memcmp (&ob1->stats, &ob2->stats, sizeof (ob1->stats)) != 0) || 234 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
168 (ob1->attacktype != ob2->attacktype) || 235 || ob1->attacktype != ob2->attacktype
169 (ob1->magic != ob2->magic) || 236 || ob1->magic != ob2->magic
170 (ob1->slaying != ob2->slaying) || 237 || ob1->slaying != ob2->slaying
171 (ob1->skill != ob2->skill) || 238 || ob1->skill != ob2->skill
172 (ob1->value != ob2->value) || 239 || ob1->value != ob2->value
173 (ob1->animation_id != ob2->animation_id) || 240 || ob1->animation_id != ob2->animation_id
174 (ob1->client_type != ob2->client_type) || 241 || ob1->client_type != ob2->client_type
175 (ob1->materialname != ob2->materialname) || 242 || ob1->materialname != ob2->materialname
176 (ob1->lore != ob2->lore) || 243 || ob1->lore != ob2->lore
177 (ob1->subtype != ob2->subtype) || 244 || ob1->subtype != ob2->subtype
178 (ob1->move_type != ob2->move_type) || 245 || ob1->move_type != ob2->move_type
179 (ob1->move_block != ob2->move_block) || 246 || ob1->move_block != ob2->move_block
180 (ob1->move_allow != ob2->move_allow) || 247 || ob1->move_allow != ob2->move_allow
181 (ob1->move_on != ob2->move_on) || 248 || ob1->move_on != ob2->move_on
182 (ob1->move_off != ob2->move_off) || (ob1->move_slow != ob2->move_slow) || (ob1->move_slow_penalty != ob2->move_slow_penalty)) 249 || ob1->move_off != ob2->move_off
250 || ob1->move_slow != ob2->move_slow
251 || ob1->move_slow_penalty != ob2->move_slow_penalty)
183 return 0; 252 return 0;
184 253
185 /* This is really a spellbook check - really, we should 254 /* This is really a spellbook check - really, we should
186 * check all objects in the inventory. 255 * check all objects in the inventory.
187 */ 256 */
190 /* if one object has inventory but the other doesn't, not equiv */ 259 /* if one object has inventory but the other doesn't, not equiv */
191 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv)) 260 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv))
192 return 0; 261 return 0;
193 262
194 /* Now check to see if the two inventory objects could merge */ 263 /* Now check to see if the two inventory objects could merge */
195 if (!CAN_MERGE (ob1->inv, ob2->inv)) 264 if (!object::can_merge (ob1->inv, ob2->inv))
196 return 0; 265 return 0;
197 266
198 /* inventory ok - still need to check rest of this object to see 267 /* inventory ok - still need to check rest of this object to see
199 * if it is valid. 268 * if it is valid.
200 */ 269 */
209 278
210 /* Note sure why the following is the case - either the object has to 279 /* Note sure why the following is the case - either the object has to
211 * be animated or have a very low speed. Is this an attempted monster 280 * be animated or have a very low speed. Is this an attempted monster
212 * check? 281 * check?
213 */ 282 */
214 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && FABS ((ob1)->speed) > MIN_ACTIVE_SPEED) 283 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && ob1->has_active_speed ())
215 return 0; 284 return 0;
216 285
217 switch (ob1->type) 286 switch (ob1->type)
218 { 287 {
219 case SCROLL: 288 case SCROLL:
220 if (ob1->level != ob2->level) 289 if (ob1->level != ob2->level)
221 return 0; 290 return 0;
222 break; 291 break;
223 } 292 }
224 293
225 if (ob1->key_values != NULL || ob2->key_values != NULL) 294 if (ob1->key_values != NULL || ob2->key_values != NULL)
226 { 295 {
227 /* At least one of these has key_values. */ 296 /* At least one of these has key_values. */
249/* 318/*
250 * sum_weight() is a recursive function which calculates the weight 319 * sum_weight() is a recursive function which calculates the weight
251 * an object is carrying. It goes through in figures out how much 320 * an object is carrying. It goes through in figures out how much
252 * containers are carrying, and sums it up. 321 * containers are carrying, and sums it up.
253 */ 322 */
254signed long 323long
255sum_weight (object *op) 324sum_weight (object *op)
256{ 325{
257 signed long sum; 326 long sum;
258 object *inv; 327 object *inv;
259 328
260 for (sum = 0, inv = op->inv; inv != NULL; inv = inv->below) 329 for (sum = 0, inv = op->inv; inv != NULL; inv = inv->below)
261 { 330 {
262 if (inv->inv) 331 if (inv->inv)
263 sum_weight (inv); 332 sum_weight (inv);
264 sum += inv->carrying + inv->weight * (inv->nrof ? inv->nrof : 1); 333 sum += inv->carrying + inv->weight * (inv->nrof ? inv->nrof : 1);
265 } 334 }
335
266 if (op->type == CONTAINER && op->stats.Str) 336 if (op->type == CONTAINER && op->stats.Str)
267 sum = (sum * (100 - op->stats.Str)) / 100; 337 sum = (sum * (100 - op->stats.Str)) / 100;
338
268 if (op->carrying != sum) 339 if (op->carrying != sum)
269 op->carrying = sum; 340 op->carrying = sum;
341
270 return sum; 342 return sum;
271} 343}
272 344
273/** 345/**
274 * Return the outermost environment object for a given object. 346 * Return the outermost environment object for a given object.
281 op = op->env; 353 op = op->env;
282 return op; 354 return op;
283} 355}
284 356
285/* 357/*
286 * Eneq(@csd.uu.se): Since we can have items buried in a character we need
287 * a better check. We basically keeping traversing up until we can't
288 * or find a player.
289 */
290
291object *
292is_player_inv (object *op)
293{
294 for (; op != NULL && op->type != PLAYER; op = op->env)
295 if (op->env == op)
296 op->env = NULL;
297 return op;
298}
299
300/*
301 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump. 358 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
302 * Some error messages. 359 * Some error messages.
303 * The result of the dump is stored in the static global errmsg array. 360 * The result of the dump is stored in the static global errmsg array.
304 */ 361 */
305 362
306void 363char *
307dump_object2 (object *op)
308{
309 errmsg[0] = 0;
310 return;
311 //TODO//D#d#
312#if 0
313 char *cp;
314
315/* object *tmp;*/
316
317 if (op->arch != NULL)
318 {
319 strcat (errmsg, "arch ");
320 strcat (errmsg, op->arch->name ? op->arch->name : "(null)");
321 strcat (errmsg, "\n");
322 if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
323 strcat (errmsg, cp);
324# if 0
325 /* Don't dump player diffs - they are too long, mostly meaningless, and
326 * will overflow the buffer.
327 * Changed so that we don't dump inventory either. This may
328 * also overflow the buffer.
329 */
330 if (op->type != PLAYER && (cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
331 strcat (errmsg, cp);
332 for (tmp = op->inv; tmp; tmp = tmp->below)
333 dump_object2 (tmp);
334# endif
335 strcat (errmsg, "end\n");
336 }
337 else
338 {
339 strcat (errmsg, "Object ");
340 if (op->name == NULL)
341 strcat (errmsg, "(null)");
342 else
343 strcat (errmsg, op->name);
344 strcat (errmsg, "\n");
345# if 0
346 if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
347 strcat (errmsg, cp);
348 for (tmp = op->inv; tmp; tmp = tmp->below)
349 dump_object2 (tmp);
350# endif
351 strcat (errmsg, "end\n");
352 }
353#endif
354}
355
356/*
357 * Dumps an object. Returns output in the static global errmsg array.
358 */
359
360void
361dump_object (object *op) 364dump_object (object *op)
362{ 365{
363 if (op == NULL) 366 if (!op)
364 { 367 return strdup ("[NULLOBJ]");
365 strcpy (errmsg, "[NULL pointer]");
366 return;
367 }
368 errmsg[0] = '\0';
369 dump_object2 (op);
370}
371 368
372void 369 object_freezer freezer;
373dump_all_objects (void) 370 save_object (freezer, op, 1);
374{ 371 return freezer.as_string ();
375 object *op;
376
377 for (op = objects; op != NULL; op = op->next)
378 {
379 dump_object (op);
380 fprintf (logfile, "Object %d\n:%s\n", op->count, errmsg);
381 }
382} 372}
383 373
384/* 374/*
385 * get_nearest_part(multi-object, object 2) returns the part of the 375 * get_nearest_part(multi-object, object 2) returns the part of the
386 * multi-object 1 which is closest to the second object. 376 * multi-object 1 which is closest to the second object.
402} 392}
403 393
404/* 394/*
405 * Returns the object which has the count-variable equal to the argument. 395 * Returns the object which has the count-variable equal to the argument.
406 */ 396 */
407
408object * 397object *
409find_object (tag_t i) 398find_object (tag_t i)
410{ 399{
411 object *op; 400 for_all_objects (op)
412
413 for (op = objects; op != NULL; op = op->next)
414 if (op->count == i) 401 if (op->count == i)
415 break;
416 return op; 402 return op;
403
404 return 0;
417} 405}
418 406
419/* 407/*
420 * Returns the first object which has a name equal to the argument. 408 * Returns the first object which has a name equal to the argument.
421 * Used only by the patch command, but not all that useful. 409 * Used only by the patch command, but not all that useful.
422 * Enables features like "patch <name-of-other-player> food 999" 410 * Enables features like "patch <name-of-other-player> food 999"
423 */ 411 */
424
425object * 412object *
426find_object_name (const char *str) 413find_object_name (const char *str)
427{ 414{
428 const char *name = shstr::find (str); 415 shstr_cmp str_ (str);
429 object *op; 416 object *op;
430 417
431 for (op = objects; op != NULL; op = op->next) 418 for_all_objects (op)
432 if (&op->name == name) 419 if (op->name == str_)
433 break; 420 break;
434 421
435 return op; 422 return op;
436} 423}
437 424
440{ 427{
441 LOG (llevDebug, "%d allocated objects\n", nrofallocobjects); 428 LOG (llevDebug, "%d allocated objects\n", nrofallocobjects);
442} 429}
443 430
444/* 431/*
445 * Returns the object which this object marks as being the owner.
446 * A id-scheme is used to avoid pointing to objects which have been
447 * freed and are now reused. If this is detected, the owner is
448 * set to NULL, and NULL is returned.
449 * Changed 2004-02-12 - if the player is setting at the play again
450 * prompt, he is removed, and we don't want to treat him as an owner of
451 * anything, so check removed flag. I don't expect that this should break
452 * anything - once an object is removed, it is basically dead anyways.
453 */
454
455object *
456get_owner (object *op)
457{
458 if (op->owner == NULL)
459 return NULL;
460
461 if (!QUERY_FLAG (op->owner, FLAG_FREED) && !QUERY_FLAG (op->owner, FLAG_REMOVED) && op->owner->count == op->ownercount)
462 return op->owner;
463
464 op->owner = NULL;
465 op->ownercount = 0;
466 return NULL;
467}
468
469void
470clear_owner (object *op)
471{
472 if (!op)
473 return;
474
475 if (op->owner && op->ownercount == op->owner->count)
476 op->owner->refcount--;
477
478 op->owner = NULL;
479 op->ownercount = 0;
480}
481
482/*
483 * Sets the owner and sets the skill and exp pointers to owner's current 432 * Sets the owner and sets the skill and exp pointers to owner's current
484 * skill and experience objects. 433 * skill and experience objects.
485 */ 434 */
486void 435void
487set_owner (object *op, object *owner) 436object::set_owner (object *owner)
488{ 437{
489 if (owner == NULL || op == NULL) 438 if (!owner)
490 return; 439 return;
491 440
492 /* next line added to allow objects which own objects */ 441 /* next line added to allow objects which own objects */
493 /* Add a check for ownercounts in here, as I got into an endless loop 442 /* Add a check for ownercounts in here, as I got into an endless loop
494 * with the fireball owning a poison cloud which then owned the 443 * with the fireball owning a poison cloud which then owned the
495 * fireball. I believe that was caused by one of the objects getting 444 * fireball. I believe that was caused by one of the objects getting
496 * freed and then another object replacing it. Since the ownercounts 445 * freed and then another object replacing it. Since the ownercounts
497 * didn't match, this check is valid and I believe that cause is valid. 446 * didn't match, this check is valid and I believe that cause is valid.
498 */ 447 */
499 while (owner->owner && owner != owner->owner && owner->ownercount == owner->owner->count) 448 while (owner->owner)
500 owner = owner->owner; 449 owner = owner->owner;
501 450
502 /* IF the owner still has an owner, we did not resolve to a final owner.
503 * so lets not add to that.
504 */
505 if (owner->owner)
506 return;
507
508 op->owner = owner; 451 this->owner = owner;
509
510 op->ownercount = owner->count;
511 owner->refcount++;
512}
513
514/* Set the owner to clone's current owner and set the skill and experience
515 * objects to clone's objects (typically those objects that where the owner's
516 * current skill and experience objects at the time when clone's owner was
517 * set - not the owner's current skill and experience objects).
518 *
519 * Use this function if player created an object (e.g. fire bullet, swarm
520 * spell), and this object creates further objects whose kills should be
521 * accounted for the player's original skill, even if player has changed
522 * skills meanwhile.
523 */
524void
525copy_owner (object *op, object *clone)
526{
527 object *owner = get_owner (clone);
528
529 if (owner == NULL)
530 {
531 /* players don't have owners - they own themselves. Update
532 * as appropriate.
533 */
534 if (clone->type == PLAYER)
535 owner = clone;
536 else
537 return;
538 }
539
540 set_owner (op, owner);
541} 452}
542 453
543/* Zero the key_values on op, decrementing the shared-string 454/* Zero the key_values on op, decrementing the shared-string
544 * refcounts and freeing the links. 455 * refcounts and freeing the links.
545 */ 456 */
555 } 466 }
556 467
557 op->key_values = 0; 468 op->key_values = 0;
558} 469}
559 470
560void object::clear ()
561{
562 attachable_base::clear ();
563
564 free_key_values (this);
565
566 clear_owner (this);
567
568 name = 0;
569 name_pl = 0;
570 title = 0;
571 race = 0;
572 slaying = 0;
573 skill = 0;
574 msg = 0;
575 lore = 0;
576 custom_name = 0;
577 materialname = 0;
578
579 memset (static_cast < object_pod * >(this), 0, sizeof (object_pod));
580
581 SET_FLAG (this, FLAG_REMOVED);
582}
583
584void object::clone (object *destination)
585{
586 *(object_copy *) destination = *this;
587 *(object_pod *) destination = *this;
588
589 if (self || cb)
590 INVOKE_OBJECT (CLONE, this, ARG_OBJECT (destination));
591}
592
593/* 471/*
594 * clear_object() frees everything allocated by an object, and also
595 * clears all variables and flags to default settings.
596 */
597
598void
599clear_object (object *op)
600{
601 op->clear ();
602
603 op->contr = NULL;
604 op->below = NULL;
605 op->above = NULL;
606 op->inv = NULL;
607 op->container = NULL;
608 op->env = NULL;
609 op->more = NULL;
610 op->head = NULL;
611 op->map = NULL;
612 op->refcount = 0;
613 op->active_next = NULL;
614 op->active_prev = NULL;
615 /* What is not cleared is next, prev, and count */
616
617 op->expmul = 1.0;
618 op->face = blank_face;
619 op->attacked_by_count = -1;
620
621 if (settings.casting_time)
622 op->casting_time = -1;
623}
624
625/*
626 * copy object first frees everything allocated by the second object, 472 * copy_to first frees everything allocated by the dst object,
627 * and then copies the contends of the first object into the second 473 * and then copies the contents of itself into the second
628 * object, allocating what needs to be allocated. Basically, any 474 * object, allocating what needs to be allocated. Basically, any
629 * data that is malloc'd needs to be re-malloc/copied. Otherwise, 475 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
630 * if the first object is freed, the pointers in the new object 476 * if the first object is freed, the pointers in the new object
631 * will point at garbage. 477 * will point at garbage.
632 */ 478 */
633
634void 479void
635copy_object (object *op2, object *op) 480object::copy_to (object *dst)
636{ 481{
637 bool is_freed = QUERY_FLAG (op, FLAG_FREED); 482 bool is_freed = QUERY_FLAG (dst, FLAG_FREED);
638 bool is_removed = QUERY_FLAG (op, FLAG_REMOVED); 483 bool is_removed = QUERY_FLAG (dst, FLAG_REMOVED);
639 484
640 op2->clone (op); 485 *(object_copy *)dst = *this;
641 486
642 if (is_freed) 487 if (is_freed)
643 SET_FLAG (op, FLAG_FREED); 488 SET_FLAG (dst, FLAG_FREED);
489
644 if (is_removed) 490 if (is_removed)
645 SET_FLAG (op, FLAG_REMOVED); 491 SET_FLAG (dst, FLAG_REMOVED);
646 492
647 if (op2->speed < 0) 493 if (speed < 0)
648 op->speed_left = op2->speed_left - RANDOM () % 200 / 100.0; 494 dst->speed_left = speed_left - rndm ();
649 495
650 /* Copy over key_values, if any. */ 496 /* Copy over key_values, if any. */
651 if (op2->key_values) 497 if (key_values)
652 { 498 {
653 key_value *tail = 0; 499 key_value *tail = 0;
654 key_value *i; 500 key_value *i;
655 501
656 op->key_values = 0; 502 dst->key_values = 0;
657 503
658 for (i = op2->key_values; i; i = i->next) 504 for (i = key_values; i; i = i->next)
659 { 505 {
660 key_value *new_link = new key_value; 506 key_value *new_link = new key_value;
661 507
662 new_link->next = 0; 508 new_link->next = 0;
663 new_link->key = i->key; 509 new_link->key = i->key;
664 new_link->value = i->value; 510 new_link->value = i->value;
665 511
666 /* Try and be clever here, too. */ 512 /* Try and be clever here, too. */
667 if (!op->key_values) 513 if (!dst->key_values)
668 { 514 {
669 op->key_values = new_link; 515 dst->key_values = new_link;
670 tail = new_link; 516 tail = new_link;
671 } 517 }
672 else 518 else
673 { 519 {
674 tail->next = new_link; 520 tail->next = new_link;
675 tail = new_link; 521 tail = new_link;
676 } 522 }
677 } 523 }
678 } 524 }
679 525
680 update_ob_speed (op); 526 dst->set_speed (dst->speed);
527}
528
529object *
530object::clone ()
531{
532 object *neu = create ();
533 copy_to (neu);
534 return neu;
681} 535}
682 536
683/* 537/*
684 * If an object with the IS_TURNABLE() flag needs to be turned due 538 * If an object with the IS_TURNABLE() flag needs to be turned due
685 * to the closest player being on the other side, this function can 539 * to the closest player being on the other side, this function can
686 * be called to update the face variable, _and_ how it looks on the map. 540 * be called to update the face variable, _and_ how it looks on the map.
687 */ 541 */
688
689void 542void
690update_turn_face (object *op) 543update_turn_face (object *op)
691{ 544{
692 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || op->arch == NULL) 545 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || !op->arch)
693 return; 546 return;
547
694 SET_ANIMATION (op, op->direction); 548 SET_ANIMATION (op, op->direction);
695 update_object (op, UP_OBJ_FACE); 549 update_object (op, UP_OBJ_FACE);
696} 550}
697 551
698/* 552/*
699 * Updates the speed of an object. If the speed changes from 0 to another 553 * Updates the speed of an object. If the speed changes from 0 to another
700 * value, or vice versa, then add/remove the object from the active list. 554 * value, or vice versa, then add/remove the object from the active list.
701 * This function needs to be called whenever the speed of an object changes. 555 * This function needs to be called whenever the speed of an object changes.
702 */ 556 */
703
704void 557void
705update_ob_speed (object *op) 558object::set_speed (float speed)
706{ 559{
707 extern int arch_init; 560 if (flag [FLAG_FREED] && speed)
708
709 /* No reason putting the archetypes objects on the speed list,
710 * since they never really need to be updated.
711 */
712
713 if (QUERY_FLAG (op, FLAG_FREED) && op->speed)
714 { 561 {
715 LOG (llevError, "Object %s is freed but has speed.\n", &op->name); 562 LOG (llevError, "Object %s is freed but has speed.\n", &name);
716#ifdef MANY_CORES
717 abort ();
718#else
719 op->speed = 0; 563 speed = 0;
720#endif
721 }
722 if (arch_init)
723 { 564 }
724 return;
725 }
726 if (FABS (op->speed) > MIN_ACTIVE_SPEED)
727 {
728 /* If already on active list, don't do anything */
729 if (op->active_next || op->active_prev || op == active_objects)
730 return;
731 565
732 /* process_events() expects us to insert the object at the beginning 566 this->speed = speed;
733 * of the list. */ 567
734 op->active_next = active_objects; 568 if (has_active_speed ())
735 if (op->active_next != NULL) 569 activate ();
736 op->active_next->active_prev = op;
737 active_objects = op;
738 }
739 else 570 else
740 { 571 deactivate ();
741 /* If not on the active list, nothing needs to be done */
742 if (!op->active_next && !op->active_prev && op != active_objects)
743 return;
744
745 if (op->active_prev == NULL)
746 {
747 active_objects = op->active_next;
748 if (op->active_next != NULL)
749 op->active_next->active_prev = NULL;
750 }
751 else
752 {
753 op->active_prev->active_next = op->active_next;
754 if (op->active_next)
755 op->active_next->active_prev = op->active_prev;
756 }
757 op->active_next = NULL;
758 op->active_prev = NULL;
759 }
760} 572}
761 573
762/* This function removes object 'op' from the list of active
763 * objects.
764 * This should only be used for style maps or other such
765 * reference maps where you don't want an object that isn't
766 * in play chewing up cpu time getting processed.
767 * The reverse of this is to call update_ob_speed, which
768 * will do the right thing based on the speed of the object.
769 */
770void
771remove_from_active_list (object *op)
772{
773 /* If not on the active list, nothing needs to be done */
774 if (!op->active_next && !op->active_prev && op != active_objects)
775 return;
776
777 if (op->active_prev == NULL)
778 {
779 active_objects = op->active_next;
780 if (op->active_next != NULL)
781 op->active_next->active_prev = NULL;
782 }
783 else
784 {
785 op->active_prev->active_next = op->active_next;
786 if (op->active_next)
787 op->active_next->active_prev = op->active_prev;
788 }
789 op->active_next = NULL;
790 op->active_prev = NULL;
791}
792
793/* 574/*
794 * update_object() updates the array which represents the map. 575 * update_object() updates the the map.
795 * It takes into account invisible objects (and represent squares covered 576 * It takes into account invisible objects (and represent squares covered
796 * by invisible objects by whatever is below them (unless it's another 577 * by invisible objects by whatever is below them (unless it's another
797 * invisible object, etc...) 578 * invisible object, etc...)
798 * If the object being updated is beneath a player, the look-window 579 * If the object being updated is beneath a player, the look-window
799 * of that player is updated (this might be a suboptimal way of 580 * of that player is updated (this might be a suboptimal way of
800 * updating that window, though, since update_object() is called _often_) 581 * updating that window, though, since update_object() is called _often_)
801 * 582 *
802 * action is a hint of what the caller believes need to be done. 583 * action is a hint of what the caller believes need to be done.
803 * For example, if the only thing that has changed is the face (due to
804 * an animation), we don't need to call update_position until that actually
805 * comes into view of a player. OTOH, many other things, like addition/removal
806 * of walls or living creatures may need us to update the flags now.
807 * current action are: 584 * current action are:
808 * UP_OBJ_INSERT: op was inserted 585 * UP_OBJ_INSERT: op was inserted
809 * UP_OBJ_REMOVE: op was removed 586 * UP_OBJ_REMOVE: op was removed
810 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update 587 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update
811 * as that is easier than trying to look at what may have changed. 588 * as that is easier than trying to look at what may have changed.
812 * UP_OBJ_FACE: only the objects face has changed. 589 * UP_OBJ_FACE: only the objects face has changed.
813 */ 590 */
814
815void 591void
816update_object (object *op, int action) 592update_object (object *op, int action)
817{ 593{
818 int update_now = 0, flags;
819 MoveType move_on, move_off, move_block, move_slow; 594 MoveType move_on, move_off, move_block, move_slow;
820 595
821 if (op == NULL) 596 if (op == NULL)
822 { 597 {
823 /* this should never happen */ 598 /* this should never happen */
824 LOG (llevDebug, "update_object() called for NULL object.\n"); 599 LOG (llevDebug, "update_object() called for NULL object.\n");
825 return; 600 return;
826 } 601 }
827 602
828 if (op->env != NULL) 603 if (op->env)
829 { 604 {
830 /* Animation is currently handled by client, so nothing 605 /* Animation is currently handled by client, so nothing
831 * to do in this case. 606 * to do in this case.
832 */ 607 */
833 return; 608 return;
838 */ 613 */
839 if (!op->map || op->map->in_memory == MAP_SAVING) 614 if (!op->map || op->map->in_memory == MAP_SAVING)
840 return; 615 return;
841 616
842 /* make sure the object is within map boundaries */ 617 /* make sure the object is within map boundaries */
843 if (op->x < 0 || op->x >= MAP_WIDTH (op->map) || op->y < 0 || op->y >= MAP_HEIGHT (op->map)) 618 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
844 { 619 {
845 LOG (llevError, "update_object() called for object out of map!\n"); 620 LOG (llevError, "update_object() called for object out of map!\n");
846#ifdef MANY_CORES 621#ifdef MANY_CORES
847 abort (); 622 abort ();
848#endif 623#endif
849 return; 624 return;
850 } 625 }
851 626
852 flags = GET_MAP_FLAGS (op->map, op->x, op->y); 627 mapspace &m = op->ms ();
853 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NEED_UPDATE);
854 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
855 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
856 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
857 move_off = GET_MAP_MOVE_OFF (op->map, op->x, op->y);
858 628
629 if (!(m.flags_ & P_UPTODATE))
630 /* nop */;
859 if (action == UP_OBJ_INSERT) 631 else if (action == UP_OBJ_INSERT)
860 { 632 {
633 // this is likely overkill, TODO: revisit (schmorp)
861 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(flags & P_BLOCKSVIEW)) 634 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
862 update_now = 1;
863
864 if (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(flags & P_NO_MAGIC)) 635 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
865 update_now = 1; 636 || (op->type == PLAYER && !(m.flags_ & P_PLAYER))
866 637 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
638 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
867 if (QUERY_FLAG (op, FLAG_DAMNED) && !(flags & P_NO_CLERIC)) 639 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
868 update_now = 1;
869
870 if (QUERY_FLAG (op, FLAG_ALIVE) && !(flags & P_IS_ALIVE))
871 update_now = 1;
872
873 if (op->type == SAFE_GROUND && !(flags & P_SAFE))
874 update_now = 1;
875
876 if ((move_on | op->move_on) != move_on) 640 || (m.move_on | op->move_on ) != m.move_on
877 update_now = 1;
878
879 if ((move_off | op->move_off) != move_off) 641 || (m.move_off | op->move_off ) != m.move_off
880 update_now = 1; 642 || (m.move_slow | op->move_slow) != m.move_slow
881
882 /* This isn't perfect, but I don't expect a lot of objects to 643 /* This isn't perfect, but I don't expect a lot of objects to
883 * to have move_allow right now. 644 * to have move_allow right now.
884 */ 645 */
885 if (((move_block | op->move_block) & ~op->move_allow) != move_block) 646 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
886 update_now = 1; 647 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
887 648 m.flags_ = 0;
888 if ((move_slow | op->move_slow) != move_slow)
889 update_now = 1;
890 } 649 }
891 /* if the object is being removed, we can't make intelligent 650 /* if the object is being removed, we can't make intelligent
892 * decisions, because remove_ob can't really pass the object 651 * decisions, because remove_ob can't really pass the object
893 * that is being removed. 652 * that is being removed.
894 */ 653 */
895 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 654 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
896 { 655 m.flags_ = 0;
897 update_now = 1;
898 }
899 else if (action == UP_OBJ_FACE) 656 else if (action == UP_OBJ_FACE)
900 {
901 /* Nothing to do for that case */ 657 /* Nothing to do for that case */ ;
902 }
903 else 658 else
904 {
905 LOG (llevError, "update_object called with invalid action: %d\n", action); 659 LOG (llevError, "update_object called with invalid action: %d\n", action);
906 }
907 660
908 if (update_now)
909 {
910 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NO_ERROR | P_NEED_UPDATE);
911 update_position (op->map, op->x, op->y);
912 }
913
914 if (op->more != NULL) 661 if (op->more)
915 update_object (op->more, action); 662 update_object (op->more, action);
916}
917
918static unordered_vector<object *> mortals;
919static std::vector<object *> freed;
920
921void object::free_mortals ()
922{
923 for (unordered_vector<object *>::iterator i = mortals.begin (); i != mortals.end (); )
924 if (!(*i)->refcount)
925 {
926 freed.push_back (*i);
927 mortals.erase (i);
928 }
929 else
930 ++i;
931} 663}
932 664
933object::object () 665object::object ()
934{ 666{
935 SET_FLAG (this, FLAG_REMOVED); 667 SET_FLAG (this, FLAG_REMOVED);
936 668
937 expmul = 1.0; 669 expmul = 1.0;
938 face = blank_face; 670 face = blank_face;
939 attacked_by_count = -1;
940} 671}
941 672
942object::~object () 673object::~object ()
943{ 674{
675 unlink ();
676
944 free_key_values (this); 677 free_key_values (this);
945} 678}
946 679
680static int object_count;
681
947void object::link () 682void object::link ()
948{ 683{
684 assert (!index);//D
685 uuid = gen_uuid ();
949 count = ++ob_count; 686 count = ++object_count;
950 687
951 prev = 0; 688 refcnt_inc ();
952 next = objects; 689 objects.insert (this);
953
954 if (objects)
955 objects->prev = this;
956
957 objects = this;
958} 690}
959 691
960void object::unlink () 692void object::unlink ()
961{ 693{
962 count = 0;
963
964 /* Remove this object from the list of used objects */
965 if (prev)
966 {
967 prev->next = next;
968 prev = 0;
969 }
970
971 if (next) 694 if (!index)
972 { 695 return;
973 next->prev = prev; 696
974 next = 0; 697 objects.erase (this);
698 refcnt_dec ();
699}
700
701void
702object::activate ()
703{
704 /* If already on active list, don't do anything */
705 if (active)
706 return;
707
708 if (has_active_speed ())
709 actives.insert (this);
710}
711
712void
713object::activate_recursive ()
714{
715 activate ();
716
717 for (object *op = inv; op; op = op->below)
718 op->activate_recursive ();
719}
720
721/* This function removes object 'op' from the list of active
722 * objects.
723 * This should only be used for style maps or other such
724 * reference maps where you don't want an object that isn't
725 * in play chewing up cpu time getting processed.
726 * The reverse of this is to call update_ob_speed, which
727 * will do the right thing based on the speed of the object.
728 */
729void
730object::deactivate ()
731{
732 /* If not on the active list, nothing needs to be done */
733 if (!active)
734 return;
735
736 actives.erase (this);
737}
738
739void
740object::deactivate_recursive ()
741{
742 for (object *op = inv; op; op = op->below)
743 op->deactivate_recursive ();
744
745 deactivate ();
746}
747
748void
749object::set_flag_inv (int flag, int value)
750{
751 for (object *op = inv; op; op = op->below)
975 } 752 {
753 op->flag [flag] = value;
754 op->set_flag_inv (flag, value);
755 }
756}
976 757
977 if (this == objects) 758/*
978 objects = next; 759 * Remove and free all objects in the inventory of the given object.
760 * object.c ?
761 */
762void
763object::destroy_inv (bool drop_to_ground)
764{
765 // need to check first, because the checks below might segfault
766 // as we might be on an invalid mapspace and crossfire code
767 // is too buggy to ensure that the inventory is empty.
768 // corollary: if you create arrows etc. with stuff in tis inventory,
769 // cf will crash below with off-map x and y
770 if (!inv)
771 return;
772
773 /* Only if the space blocks everything do we not process -
774 * if some form of movement is allowed, let objects
775 * drop on that space.
776 */
777 if (!drop_to_ground
778 || !map
779 || map->in_memory != MAP_IN_MEMORY
780 || map->nodrop
781 || ms ().move_block == MOVE_ALL)
782 {
783 while (inv)
784 {
785 inv->destroy_inv (drop_to_ground);
786 inv->destroy ();
787 }
788 }
789 else
790 { /* Put objects in inventory onto this space */
791 while (inv)
792 {
793 object *op = inv;
794
795 if (op->flag [FLAG_STARTEQUIP]
796 || op->flag [FLAG_NO_DROP]
797 || op->type == RUNE
798 || op->type == TRAP
799 || op->flag [FLAG_IS_A_TEMPLATE]
800 || op->flag [FLAG_DESTROY_ON_DEATH])
801 op->destroy ();
802 else
803 map->insert (op, x, y);
804 }
805 }
979} 806}
980 807
981object *object::create () 808object *object::create ()
982{ 809{
983 object *op;
984
985 if (freed.empty ())
986 op = new object; 810 object *op = new object;
987 else
988 {
989 // highly annoying, but the only way to get it stable right now
990 op = freed.back (); freed.pop_back ();
991 op->~object ();
992 new ((void *)op) object;
993 }
994
995 op->link (); 811 op->link ();
996 return op; 812 return op;
997} 813}
998 814
999/* 815void
1000 * free_object() frees everything allocated by an object, removes 816object::do_destroy ()
1001 * it from the list of used objects, and puts it on the list of
1002 * free objects. The IS_FREED() flag is set in the object.
1003 * The object must have been removed by remove_ob() first for
1004 * this function to succeed.
1005 *
1006 * If free_inventory is set, free inventory as well. Else drop items in
1007 * inventory to the ground.
1008 */
1009void object::free (bool free_inventory)
1010{ 817{
1011 if (!QUERY_FLAG (this, FLAG_REMOVED)) 818 attachable::do_destroy ();
1012 {
1013 LOG (llevDebug, "Free object called with non removed object\n");
1014 dump_object (this);
1015#ifdef MANY_CORES
1016 abort ();
1017#endif
1018 }
1019 819
1020 if (QUERY_FLAG (this, FLAG_FRIENDLY)) 820 if (flag [FLAG_IS_LINKED])
1021 { 821 remove_button_link (this);
1022 LOG (llevMonster, "Warning: tried to free friendly object.\n"); 822
823 if (flag [FLAG_FRIENDLY])
1023 remove_friendly_object (this); 824 remove_friendly_object (this);
1024 }
1025 825
1026 if (QUERY_FLAG (this, FLAG_FREED)) 826 if (!flag [FLAG_REMOVED])
827 remove ();
828
829 destroy_inv (true);
830
831 deactivate ();
832 unlink ();
833
834 flag [FLAG_FREED] = 1;
835
836 // hack to ensure that freed objects still have a valid map
837 {
838 static maptile *freed_map; // freed objects are moved here to avoid crashes
839
840 if (!freed_map)
1027 { 841 {
1028 dump_object (this); 842 freed_map = new maptile;
1029 LOG (llevError, "Trying to free freed object.\n%s\n", errmsg); 843
1030 return; 844 freed_map->name = "/internal/freed_objects_map";
845 freed_map->width = 3;
846 freed_map->height = 3;
847
848 freed_map->alloc ();
849 freed_map->in_memory = MAP_IN_MEMORY;
1031 } 850 }
851
852 map = freed_map;
853 x = 1;
854 y = 1;
855 }
856
857 head = 0;
1032 858
1033 if (more) 859 if (more)
1034 { 860 {
1035 more->free (free_inventory); 861 more->destroy ();
1036 more = 0; 862 more = 0;
1037 } 863 }
1038 864
1039 if (inv) 865 // clear those pointers that likely might have circular references to us
1040 { 866 owner = 0;
1041 /* Only if the space blocks everything do we not process - 867 enemy = 0;
1042 * if some form of movement is allowed, let objects 868 attacked_by = 0;
1043 * drop on that space. 869}
1044 */
1045 if (free_inventory || !map || map->in_memory != MAP_IN_MEMORY || (GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL))
1046 {
1047 object *
1048 op = inv;
1049 870
1050 while (op) 871void
1051 { 872object::destroy (bool destroy_inventory)
1052 object * 873{
1053 tmp = op->below; 874 if (destroyed ())
875 return;
1054 876
1055 remove_ob (op); 877 if (destroy_inventory)
1056 op->free (free_inventory); 878 destroy_inv (false);
1057 op = tmp;
1058 }
1059 }
1060 else
1061 { /* Put objects in inventory onto this space */
1062 object *
1063 op = inv;
1064 879
1065 while (op) 880 attachable::destroy ();
1066 {
1067 object *
1068 tmp = op->below;
1069
1070 remove_ob (op);
1071
1072 if (QUERY_FLAG (op, FLAG_STARTEQUIP)
1073 || QUERY_FLAG (op, FLAG_NO_DROP) || op->type == RUNE || op->type == TRAP || QUERY_FLAG (op, FLAG_IS_A_TEMPLATE))
1074 free_object (op);
1075 else
1076 {
1077 op->x = x;
1078 op->y = y;
1079 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
1080 }
1081
1082 op = tmp;
1083 }
1084 }
1085 }
1086
1087 clear_owner (this);
1088
1089 /* Remove object from the active list */
1090 speed = 0;
1091 update_ob_speed (this);
1092
1093 unlink ();
1094
1095 SET_FLAG (this, FLAG_FREED);
1096
1097 mortals.push_back (this);
1098} 881}
1099 882
1100/* 883/*
1101 * sub_weight() recursively (outwards) subtracts a number from the 884 * sub_weight() recursively (outwards) subtracts a number from the
1102 * weight of an object (and what is carried by it's environment(s)). 885 * weight of an object (and what is carried by it's environment(s)).
1103 */ 886 */
1104
1105void 887void
1106sub_weight (object *op, signed long weight) 888sub_weight (object *op, signed long weight)
1107{ 889{
1108 while (op != NULL) 890 while (op != NULL)
1109 { 891 {
1110 if (op->type == CONTAINER) 892 if (op->type == CONTAINER)
1111 {
1112 weight = (signed long) (weight * (100 - op->stats.Str) / 100); 893 weight = (signed long) (weight * (100 - op->stats.Str) / 100);
1113 } 894
1114 op->carrying -= weight; 895 op->carrying -= weight;
1115 op = op->env; 896 op = op->env;
1116 } 897 }
1117} 898}
1118 899
1119/* remove_ob(op): 900/* op->remove ():
1120 * This function removes the object op from the linked list of objects 901 * This function removes the object op from the linked list of objects
1121 * which it is currently tied to. When this function is done, the 902 * which it is currently tied to. When this function is done, the
1122 * object will have no environment. If the object previously had an 903 * object will have no environment. If the object previously had an
1123 * environment, the x and y coordinates will be updated to 904 * environment, the x and y coordinates will be updated to
1124 * the previous environment. 905 * the previous environment.
1125 * Beware: This function is called from the editor as well! 906 * Beware: This function is called from the editor as well!
1126 */ 907 */
1127
1128void 908void
1129remove_ob (object *op) 909object::remove_slow ()
1130{ 910{
1131 object *tmp, *last = NULL; 911 object *tmp, *last = 0;
1132 object *otmp; 912 object *otmp;
1133 913
1134 tag_t tag;
1135 int check_walk_off;
1136 mapstruct *m;
1137
1138 sint16 x, y;
1139
1140 if (QUERY_FLAG (op, FLAG_REMOVED)) 914 if (QUERY_FLAG (this, FLAG_REMOVED))
1141 { 915 return;
1142 dump_object (op);
1143 LOG (llevError, "Trying to remove removed object.\n%s\n", errmsg);
1144 916
1145 /* Changed it to always dump core in this case. As has been learned
1146 * in the past, trying to recover from errors almost always
1147 * make things worse, and this is a real error here - something
1148 * that should not happen.
1149 * Yes, if this was a mission critical app, trying to do something
1150 * to recover may make sense, but that is because failure of the app
1151 * may have other disastrous problems. Cf runs out of a script
1152 * so is easily enough restarted without any real problems.
1153 * MSW 2001-07-01
1154 */
1155 abort ();
1156 }
1157
1158 if (op->more != NULL)
1159 remove_ob (op->more);
1160
1161 SET_FLAG (op, FLAG_REMOVED); 917 SET_FLAG (this, FLAG_REMOVED);
918 INVOKE_OBJECT (REMOVE, this);
919
920 if (more)
921 more->remove ();
1162 922
1163 /* 923 /*
1164 * In this case, the object to be removed is in someones 924 * In this case, the object to be removed is in someones
1165 * inventory. 925 * inventory.
1166 */ 926 */
1167 if (op->env != NULL) 927 if (env)
1168 { 928 {
1169 if (op->nrof) 929 if (nrof)
1170 sub_weight (op->env, op->weight * op->nrof); 930 sub_weight (env, weight * nrof);
1171 else 931 else
1172 sub_weight (op->env, op->weight + op->carrying); 932 sub_weight (env, weight + carrying);
1173 933
1174 /* NO_FIX_PLAYER is set when a great many changes are being 934 /* NO_FIX_PLAYER is set when a great many changes are being
1175 * made to players inventory. If set, avoiding the call 935 * made to players inventory. If set, avoiding the call
1176 * to save cpu time. 936 * to save cpu time.
1177 */ 937 */
1178 if ((otmp = is_player_inv (op->env)) != NULL && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 938 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1179 fix_player (otmp); 939 otmp->update_stats ();
1180 940
1181 if (op->above != NULL) 941 if (above)
1182 op->above->below = op->below; 942 above->below = below;
1183 else 943 else
1184 op->env->inv = op->below; 944 env->inv = below;
1185 945
1186 if (op->below != NULL) 946 if (below)
1187 op->below->above = op->above; 947 below->above = above;
1188 948
1189 /* we set up values so that it could be inserted into 949 /* we set up values so that it could be inserted into
1190 * the map, but we don't actually do that - it is up 950 * the map, but we don't actually do that - it is up
1191 * to the caller to decide what we want to do. 951 * to the caller to decide what we want to do.
1192 */ 952 */
1193 op->x = op->env->x, op->y = op->env->y; 953 x = env->x, y = env->y;
1194 op->map = op->env->map; 954 map = env->map;
1195 op->above = NULL, op->below = NULL; 955 above = 0, below = 0;
1196 op->env = NULL; 956 env = 0;
1197 return;
1198 }
1199
1200 /* If we get here, we are removing it from a map */
1201 if (op->map == NULL)
1202 return;
1203
1204 x = op->x;
1205 y = op->y;
1206 m = get_map_from_coord (op->map, &x, &y);
1207
1208 if (!m)
1209 { 957 }
1210 LOG (llevError, "remove_ob called when object was on map but appears to not be within valid coordinates? %s (%d,%d)\n", 958 else if (map)
1211 op->map->path, op->x, op->y);
1212 /* in old days, we used to set x and y to 0 and continue.
1213 * it seems if we get into this case, something is probablye
1214 * screwed up and should be fixed.
1215 */
1216 abort ();
1217 } 959 {
1218 if (op->map != m) 960 if (type == PLAYER)
1219 {
1220 LOG (llevDebug, "remove_ob: Object not really on map it claimed to be on? %s != %s, %d,%d != %d,%d\n",
1221 op->map->path, m->path, op->x, op->y, x, y);
1222 }
1223
1224 /* Re did the following section of code - it looks like it had
1225 * lots of logic for things we no longer care about
1226 */
1227
1228 /* link the object above us */
1229 if (op->above)
1230 op->above->below = op->below;
1231 else
1232 SET_MAP_TOP (m, x, y, op->below); /* we were top, set new top */
1233
1234 /* Relink the object below us, if there is one */
1235 if (op->below)
1236 op->below->above = op->above;
1237 else
1238 {
1239 /* Nothing below, which means we need to relink map object for this space
1240 * use translated coordinates in case some oddness with map tiling is
1241 * evident
1242 */
1243 if (GET_MAP_OB (m, x, y) != op)
1244 { 961 {
1245 dump_object (op); 962 --map->players;
1246 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", 963 map->touch ();
1247 errmsg);
1248 dump_object (GET_MAP_OB (m, x, y));
1249 LOG (llevError, "%s\n", errmsg);
1250 } 964 }
1251 965
1252 SET_MAP_OB (m, x, y, op->above); /* goes on above it. */ 966 map->dirty = true;
1253 } 967 mapspace &ms = this->ms ();
1254 968
1255 op->above = NULL; 969 /* link the object above us */
1256 op->below = NULL; 970 if (above)
971 above->below = below;
972 else
973 ms.top = below; /* we were top, set new top */
1257 974
1258 if (op->map->in_memory == MAP_SAVING) 975 /* Relink the object below us, if there is one */
1259 return; 976 if (below)
1260 977 below->above = above;
1261 tag = op->count; 978 else
1262 check_walk_off = !QUERY_FLAG (op, FLAG_NO_APPLY);
1263
1264 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above)
1265 {
1266 /* No point updating the players look faces if he is the object
1267 * being removed.
1268 */
1269
1270 if (tmp->type == PLAYER && tmp != op)
1271 { 979 {
1272 /* If a container that the player is currently using somehow gets 980 /* Nothing below, which means we need to relink map object for this space
1273 * removed (most likely destroyed), update the player view 981 * use translated coordinates in case some oddness with map tiling is
1274 * appropriately. 982 * evident
1275 */ 983 */
1276 if (tmp->container == op) 984 if (GET_MAP_OB (map, x, y) != this)
985 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
986
987 ms.bot = above; /* goes on above it. */
988 }
989
990 above = 0;
991 below = 0;
992
993 if (map->in_memory == MAP_SAVING)
994 return;
995
996 int check_walk_off = !flag [FLAG_NO_APPLY];
997
998 for (tmp = ms.bot; tmp; tmp = tmp->above)
999 {
1000 /* No point updating the players look faces if he is the object
1001 * being removed.
1002 */
1003
1004 if (tmp->type == PLAYER && tmp != this)
1277 { 1005 {
1278 CLEAR_FLAG (op, FLAG_APPLIED); 1006 /* If a container that the player is currently using somehow gets
1007 * removed (most likely destroyed), update the player view
1008 * appropriately.
1009 */
1010 if (tmp->container == this)
1011 {
1012 flag [FLAG_APPLIED] = 0;
1279 tmp->container = NULL; 1013 tmp->container = 0;
1014 }
1015
1016 if (tmp->contr->ns)
1017 tmp->contr->ns->floorbox_update ();
1280 } 1018 }
1281 1019
1282 tmp->contr->socket.update_look = 1; 1020 /* See if object moving off should effect something */
1021 if (check_walk_off
1022 && ((move_type & tmp->move_off)
1023 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0))
1024 {
1025 move_apply (tmp, this, 0);
1026
1027 if (destroyed ())
1028 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1029 }
1030
1031 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */
1032 //TODO: why is this horrible hacka fix? get rid of this code=bug! (schmorp)
1033 if (tmp->above == tmp)
1034 tmp->above = 0;
1035
1036 last = tmp;
1283 } 1037 }
1284 /* See if player moving off should effect something */
1285 if (check_walk_off && ((op->move_type & tmp->move_off) && (op->move_type & ~tmp->move_off & ~tmp->move_block) == 0))
1286 {
1287 move_apply (tmp, op, NULL);
1288 1038
1289 if (was_destroyed (op, tag))
1290 {
1291 LOG (llevError, "BUG: remove_ob(): name %s, archname %s destroyed " "leaving object\n", &tmp->name, &tmp->arch->name);
1292 }
1293 }
1294
1295 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */
1296
1297 if (tmp->above == tmp)
1298 tmp->above = NULL;
1299
1300 last = tmp;
1301 }
1302
1303 /* last == NULL of there are no objects on this space */ 1039 /* last == NULL if there are no objects on this space */
1304 if (last == NULL) 1040 //TODO: this makes little sense, why only update the topmost object?
1305 { 1041 if (!last)
1306 /* set P_NEED_UPDATE, otherwise update_position will complain. In theory, 1042 map->at (x, y).flags_ = 0;
1307 * we could preserve the flags (GET_MAP_FLAGS), but update_position figures
1308 * those out anyways, and if there are any flags set right now, they won't
1309 * be correct anyways.
1310 */
1311 SET_MAP_FLAGS (op->map, op->x, op->y, P_NEED_UPDATE);
1312 update_position (op->map, op->x, op->y);
1313 }
1314 else 1043 else
1315 update_object (last, UP_OBJ_REMOVE); 1044 update_object (last, UP_OBJ_REMOVE);
1316 1045
1317 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) || (op->glow_radius != 0)) 1046 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1318 update_all_los (op->map, op->x, op->y); 1047 update_all_los (map, x, y);
1048 }
1319} 1049}
1320 1050
1321/* 1051/*
1322 * merge_ob(op,top): 1052 * merge_ob(op,top):
1323 * 1053 *
1324 * This function goes through all objects below and including top, and 1054 * This function goes through all objects below and including top, and
1325 * merges op to the first matching object. 1055 * merges op to the first matching object.
1326 * If top is NULL, it is calculated. 1056 * If top is NULL, it is calculated.
1327 * Returns pointer to object if it succeded in the merge, otherwise NULL 1057 * Returns pointer to object if it succeded in the merge, otherwise NULL
1328 */ 1058 */
1329
1330object * 1059object *
1331merge_ob (object *op, object *top) 1060merge_ob (object *op, object *top)
1332{ 1061{
1333 if (!op->nrof) 1062 if (!op->nrof)
1334 return 0; 1063 return 0;
1335 if (top == NULL) 1064
1065 if (top)
1336 for (top = op; top != NULL && top->above != NULL; top = top->above); 1066 for (top = op; top && top->above; top = top->above)
1067 ;
1068
1337 for (; top != NULL; top = top->below) 1069 for (; top; top = top->below)
1338 { 1070 {
1339 if (top == op) 1071 if (top == op)
1340 continue; 1072 continue;
1341 if (CAN_MERGE (op, top)) 1073
1074 if (object::can_merge (op, top))
1342 { 1075 {
1343 top->nrof += op->nrof; 1076 top->nrof += op->nrof;
1344 1077
1345/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/ 1078/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/
1346 op->weight = 0; /* Don't want any adjustements now */ 1079 op->weight = 0; /* Don't want any adjustements now */
1347 remove_ob (op); 1080 op->destroy ();
1348 free_object (op);
1349 return top; 1081 return top;
1350 } 1082 }
1351 } 1083 }
1084
1352 return NULL; 1085 return 0;
1353} 1086}
1354 1087
1355/* 1088/*
1356 * same as insert_ob_in_map except it handle separate coordinates and do a clean 1089 * same as insert_ob_in_map except it handles separate coordinates and does a clean
1357 * job preparing multi-part monsters 1090 * job preparing multi-part monsters.
1358 */ 1091 */
1359object * 1092object *
1360insert_ob_in_map_at (object *op, mapstruct *m, object *originator, int flag, int x, int y) 1093insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1361{ 1094{
1362 object *
1363 tmp;
1364
1365 if (op->head)
1366 op = op->head;
1367 for (tmp = op; tmp; tmp = tmp->more) 1095 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1368 { 1096 {
1369 tmp->x = x + tmp->arch->clone.x; 1097 tmp->x = x + tmp->arch->clone.x;
1370 tmp->y = y + tmp->arch->clone.y; 1098 tmp->y = y + tmp->arch->clone.y;
1371 } 1099 }
1100
1372 return insert_ob_in_map (op, m, originator, flag); 1101 return insert_ob_in_map (op, m, originator, flag);
1373} 1102}
1374 1103
1375/* 1104/*
1376 * insert_ob_in_map (op, map, originator, flag): 1105 * insert_ob_in_map (op, map, originator, flag):
1390 * Return value: 1119 * Return value:
1391 * new object if 'op' was merged with other object 1120 * new object if 'op' was merged with other object
1392 * NULL if 'op' was destroyed 1121 * NULL if 'op' was destroyed
1393 * just 'op' otherwise 1122 * just 'op' otherwise
1394 */ 1123 */
1395
1396object * 1124object *
1397insert_ob_in_map (object *op, mapstruct *m, object *originator, int flag) 1125insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1398{ 1126{
1399 object *tmp, *top, *floor = NULL; 1127 object *tmp, *top, *floor = NULL;
1400 sint16 x, y;
1401 1128
1402 if (QUERY_FLAG (op, FLAG_FREED)) 1129 if (QUERY_FLAG (op, FLAG_FREED))
1403 { 1130 {
1404 LOG (llevError, "Trying to insert freed object!\n"); 1131 LOG (llevError, "Trying to insert freed object!\n");
1405 return NULL; 1132 return NULL;
1406 } 1133 }
1407 1134
1408 if (m == NULL) 1135 if (!QUERY_FLAG (op, FLAG_REMOVED))
1136 LOG (llevError, "Trying to insert already inserted object %s\n", op->debug_desc ());
1137
1138 op->remove ();
1139
1140 if (!m)
1409 { 1141 {
1410 dump_object (op); 1142 char *dump = dump_object (op);
1411 LOG (llevError, "Trying to insert in null-map!\n%s\n", errmsg); 1143 LOG (llevError, "Trying to insert in null-map!\n%s\n", dump);
1144 free (dump);
1412 return op; 1145 return op;
1413 } 1146 }
1414 1147
1415 if (out_of_map (m, op->x, op->y)) 1148 if (out_of_map (m, op->x, op->y))
1416 { 1149 {
1417 dump_object (op); 1150 char *dump = dump_object (op);
1418 LOG (llevError, "Trying to insert object outside the map.\n%s\n", errmsg); 1151 LOG (llevError, "Trying to insert object outside the map.\n%s\n", dump);
1419#ifdef MANY_CORES 1152#ifdef MANY_CORES
1420 /* Better to catch this here, as otherwise the next use of this object 1153 /* Better to catch this here, as otherwise the next use of this object
1421 * is likely to cause a crash. Better to find out where it is getting 1154 * is likely to cause a crash. Better to find out where it is getting
1422 * improperly inserted. 1155 * improperly inserted.
1423 */ 1156 */
1424 abort (); 1157 abort ();
1425#endif 1158#endif
1159 free (dump);
1426 return op; 1160 return op;
1427 } 1161 }
1428 1162
1429 if (!QUERY_FLAG (op, FLAG_REMOVED))
1430 {
1431 dump_object (op);
1432 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", errmsg);
1433 return op;
1434 }
1435
1436 if (op->more != NULL)
1437 {
1438 /* The part may be on a different map. */
1439
1440 object *more = op->more; 1163 if (object *more = op->more)
1441 1164 {
1442 /* We really need the caller to normalize coordinates - if
1443 * we set the map, that doesn't work if the location is within
1444 * a map and this is straddling an edge. So only if coordinate
1445 * is clear wrong do we normalize it.
1446 */
1447 if (OUT_OF_REAL_MAP (more->map, more->x, more->y))
1448 more->map = get_map_from_coord (m, &more->x, &more->y);
1449 else if (!more->map)
1450 {
1451 /* For backwards compatibility - when not dealing with tiled maps,
1452 * more->map should always point to the parent.
1453 */
1454 more->map = m;
1455 }
1456
1457 if (insert_ob_in_map (more, more->map, originator, flag) == NULL) 1165 if (!insert_ob_in_map (more, m, originator, flag))
1458 { 1166 {
1459 if (!op->head) 1167 if (!op->head)
1460 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n"); 1168 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n");
1461 1169
1462 return NULL; 1170 return 0;
1463 } 1171 }
1464 } 1172 }
1465 1173
1466 CLEAR_FLAG (op, FLAG_REMOVED); 1174 CLEAR_FLAG (op, FLAG_REMOVED);
1467 1175
1468 /* Ideally, the caller figures this out. However, it complicates a lot 1176 /* Ideally, the caller figures this out. However, it complicates a lot
1469 * of areas of callers (eg, anything that uses find_free_spot would now 1177 * of areas of callers (eg, anything that uses find_free_spot would now
1470 * need extra work 1178 * need extra work
1471 */ 1179 */
1472 op->map = get_map_from_coord (m, &op->x, &op->y); 1180 if (!xy_normalise (m, op->x, op->y))
1473 x = op->x; 1181 return 0;
1474 y = op->y; 1182
1183 op->map = m;
1184 mapspace &ms = op->ms ();
1475 1185
1476 /* this has to be done after we translate the coordinates. 1186 /* this has to be done after we translate the coordinates.
1477 */ 1187 */
1478 if (op->nrof && !(flag & INS_NO_MERGE)) 1188 if (op->nrof && !(flag & INS_NO_MERGE))
1479 for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above) 1189 for (tmp = ms.bot; tmp; tmp = tmp->above)
1480 if (CAN_MERGE (op, tmp)) 1190 if (object::can_merge (op, tmp))
1481 { 1191 {
1482 op->nrof += tmp->nrof; 1192 op->nrof += tmp->nrof;
1483 remove_ob (tmp); 1193 tmp->destroy ();
1484 free_object (tmp);
1485 } 1194 }
1486 1195
1487 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1196 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1488 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1197 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1489 1198
1502 op->below = originator->below; 1211 op->below = originator->below;
1503 1212
1504 if (op->below) 1213 if (op->below)
1505 op->below->above = op; 1214 op->below->above = op;
1506 else 1215 else
1507 SET_MAP_OB (op->map, op->x, op->y, op); 1216 ms.bot = op;
1508 1217
1509 /* since *below* originator, no need to update top */ 1218 /* since *below* originator, no need to update top */
1510 originator->below = op; 1219 originator->below = op;
1511 } 1220 }
1512 else 1221 else
1513 { 1222 {
1223 top = ms.bot;
1224
1514 /* If there are other objects, then */ 1225 /* If there are other objects, then */
1515 if ((!(flag & INS_MAP_LOAD)) && ((top = GET_MAP_OB (op->map, op->x, op->y)) != NULL)) 1226 if ((!(flag & INS_MAP_LOAD)) && top)
1516 { 1227 {
1517 object *last = NULL; 1228 object *last = 0;
1518 1229
1519 /* 1230 /*
1520 * If there are multiple objects on this space, we do some trickier handling. 1231 * If there are multiple objects on this space, we do some trickier handling.
1521 * We've already dealt with merging if appropriate. 1232 * We've already dealt with merging if appropriate.
1522 * Generally, we want to put the new object on top. But if 1233 * Generally, we want to put the new object on top. But if
1526 * once we get to them. This reduces the need to traverse over all of 1237 * once we get to them. This reduces the need to traverse over all of
1527 * them when adding another one - this saves quite a bit of cpu time 1238 * them when adding another one - this saves quite a bit of cpu time
1528 * when lots of spells are cast in one area. Currently, it is presumed 1239 * when lots of spells are cast in one area. Currently, it is presumed
1529 * that flying non pickable objects are spell objects. 1240 * that flying non pickable objects are spell objects.
1530 */ 1241 */
1531 1242 for (top = ms.bot; top; top = top->above)
1532 while (top != NULL)
1533 { 1243 {
1534 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1244 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))
1535 floor = top; 1245 floor = top;
1536 1246
1537 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1247 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))
1540 top = top->below; 1250 top = top->below;
1541 break; 1251 break;
1542 } 1252 }
1543 1253
1544 last = top; 1254 last = top;
1545 top = top->above;
1546 } 1255 }
1547 1256
1548 /* Don't want top to be NULL, so set it to the last valid object */ 1257 /* Don't want top to be NULL, so set it to the last valid object */
1549 top = last; 1258 top = last;
1550 1259
1557 * Unless those objects are exits, type 66 1266 * Unless those objects are exits, type 66
1558 * If INS_ON_TOP is used, don't do this processing 1267 * If INS_ON_TOP is used, don't do this processing
1559 * Need to find the object that in fact blocks view, otherwise 1268 * Need to find the object that in fact blocks view, otherwise
1560 * stacking is a bit odd. 1269 * stacking is a bit odd.
1561 */ 1270 */
1562 if (!(flag & INS_ON_TOP) && 1271 if (!(flag & INS_ON_TOP)
1563 (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_BLOCKSVIEW) && (op->face && !op->face->visibility)) 1272 && ms.flags () & P_BLOCKSVIEW
1273 && (op->face && !op->face->visibility))
1564 { 1274 {
1565 for (last = top; last != floor; last = last->below) 1275 for (last = top; last != floor; last = last->below)
1566 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1276 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1567 break; 1277 break;
1278
1568 /* Check to see if we found the object that blocks view, 1279 /* Check to see if we found the object that blocks view,
1569 * and make sure we have a below pointer for it so that 1280 * and make sure we have a below pointer for it so that
1570 * we can get inserted below this one, which requires we 1281 * we can get inserted below this one, which requires we
1571 * set top to the object below us. 1282 * set top to the object below us.
1572 */ 1283 */
1574 top = last->below; 1285 top = last->below;
1575 } 1286 }
1576 } /* If objects on this space */ 1287 } /* If objects on this space */
1577 1288
1578 if (flag & INS_MAP_LOAD) 1289 if (flag & INS_MAP_LOAD)
1579 top = GET_MAP_TOP (op->map, op->x, op->y); 1290 top = ms.top;
1580 1291
1581 if (flag & INS_ABOVE_FLOOR_ONLY) 1292 if (flag & INS_ABOVE_FLOOR_ONLY)
1582 top = floor; 1293 top = floor;
1583 1294
1584 /* Top is the object that our object (op) is going to get inserted above. 1295 /* Top is the object that our object (op) is going to get inserted above.
1585 */ 1296 */
1586 1297
1587 /* First object on this space */ 1298 /* First object on this space */
1588 if (!top) 1299 if (!top)
1589 { 1300 {
1590 op->above = GET_MAP_OB (op->map, op->x, op->y); 1301 op->above = ms.bot;
1591 1302
1592 if (op->above) 1303 if (op->above)
1593 op->above->below = op; 1304 op->above->below = op;
1594 1305
1595 op->below = NULL; 1306 op->below = 0;
1596 SET_MAP_OB (op->map, op->x, op->y, op); 1307 ms.bot = op;
1597 } 1308 }
1598 else 1309 else
1599 { /* get inserted into the stack above top */ 1310 { /* get inserted into the stack above top */
1600 op->above = top->above; 1311 op->above = top->above;
1601 1312
1604 1315
1605 op->below = top; 1316 op->below = top;
1606 top->above = op; 1317 top->above = op;
1607 } 1318 }
1608 1319
1609 if (op->above == NULL) 1320 if (!op->above)
1610 SET_MAP_TOP (op->map, op->x, op->y, op); 1321 ms.top = op;
1611 } /* else not INS_BELOW_ORIGINATOR */ 1322 } /* else not INS_BELOW_ORIGINATOR */
1612 1323
1613 if (op->type == PLAYER) 1324 if (op->type == PLAYER)
1325 {
1614 op->contr->do_los = 1; 1326 op->contr->do_los = 1;
1327 ++op->map->players;
1328 op->map->touch ();
1329 }
1330
1331 op->map->dirty = true;
1615 1332
1616 /* If we have a floor, we know the player, if any, will be above 1333 /* If we have a floor, we know the player, if any, will be above
1617 * it, so save a few ticks and start from there. 1334 * it, so save a few ticks and start from there.
1618 */ 1335 */
1619 if (!(flag & INS_MAP_LOAD)) 1336 if (!(flag & INS_MAP_LOAD))
1620 for (tmp = floor ? floor : GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1337 if (object *pl = ms.player ())
1621 if (tmp->type == PLAYER) 1338 if (pl->contr->ns)
1622 tmp->contr->socket.update_look = 1; 1339 pl->contr->ns->floorbox_update ();
1623 1340
1624 /* If this object glows, it may affect lighting conditions that are 1341 /* If this object glows, it may affect lighting conditions that are
1625 * visible to others on this map. But update_all_los is really 1342 * visible to others on this map. But update_all_los is really
1626 * an inefficient way to do this, as it means los for all players 1343 * an inefficient way to do this, as it means los for all players
1627 * on the map will get recalculated. The players could very well 1344 * on the map will get recalculated. The players could very well
1628 * be far away from this change and not affected in any way - 1345 * be far away from this change and not affected in any way -
1629 * this should get redone to only look for players within range, 1346 * this should get redone to only look for players within range,
1630 * or just updating the P_NEED_UPDATE for spaces within this area 1347 * or just updating the P_UPTODATE for spaces within this area
1631 * of effect may be sufficient. 1348 * of effect may be sufficient.
1632 */ 1349 */
1633 if (MAP_DARKNESS (op->map) && (op->glow_radius != 0)) 1350 if (op->map->darkness && (op->glow_radius != 0))
1634 update_all_los (op->map, op->x, op->y); 1351 update_all_los (op->map, op->x, op->y);
1635 1352
1636 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1353 /* updates flags (blocked, alive, no magic, etc) for this map space */
1637 update_object (op, UP_OBJ_INSERT); 1354 update_object (op, UP_OBJ_INSERT);
1638 1355
1356 INVOKE_OBJECT (INSERT, op);
1357
1639 /* Don't know if moving this to the end will break anything. However, 1358 /* Don't know if moving this to the end will break anything. However,
1640 * we want to have update_look set above before calling this. 1359 * we want to have floorbox_update called before calling this.
1641 * 1360 *
1642 * check_move_on() must be after this because code called from 1361 * check_move_on() must be after this because code called from
1643 * check_move_on() depends on correct map flags (so functions like 1362 * check_move_on() depends on correct map flags (so functions like
1644 * blocked() and wall() work properly), and these flags are updated by 1363 * blocked() and wall() work properly), and these flags are updated by
1645 * update_object(). 1364 * update_object().
1647 1366
1648 /* if this is not the head or flag has been passed, don't check walk on status */ 1367 /* if this is not the head or flag has been passed, don't check walk on status */
1649 if (!(flag & INS_NO_WALK_ON) && !op->head) 1368 if (!(flag & INS_NO_WALK_ON) && !op->head)
1650 { 1369 {
1651 if (check_move_on (op, originator)) 1370 if (check_move_on (op, originator))
1652 return NULL; 1371 return 0;
1653 1372
1654 /* If we are a multi part object, lets work our way through the check 1373 /* If we are a multi part object, lets work our way through the check
1655 * walk on's. 1374 * walk on's.
1656 */ 1375 */
1657 for (tmp = op->more; tmp != NULL; tmp = tmp->more) 1376 for (tmp = op->more; tmp != NULL; tmp = tmp->more)
1658 if (check_move_on (tmp, originator)) 1377 if (check_move_on (tmp, originator))
1659 return NULL; 1378 return 0;
1660 } 1379 }
1661 1380
1662 return op; 1381 return op;
1663} 1382}
1664 1383
1665/* this function inserts an object in the map, but if it 1384/* this function inserts an object in the map, but if it
1666 * finds an object of its own type, it'll remove that one first. 1385 * finds an object of its own type, it'll remove that one first.
1667 * op is the object to insert it under: supplies x and the map. 1386 * op is the object to insert it under: supplies x and the map.
1668 */ 1387 */
1669void 1388void
1670replace_insert_ob_in_map (const char *arch_string, object *op) 1389replace_insert_ob_in_map (const char *arch_string, object *op)
1671{ 1390{
1672 object *tmp;
1673 object *tmp1; 1391 object *tmp, *tmp1;
1674 1392
1675 /* first search for itself and remove any old instances */ 1393 /* first search for itself and remove any old instances */
1676 1394
1677 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1395 for (tmp = op->ms ().bot; tmp; tmp = tmp->above)
1678 {
1679 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */ 1396 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */
1680 { 1397 tmp->destroy ();
1681 remove_ob (tmp);
1682 free_object (tmp);
1683 }
1684 }
1685 1398
1686 tmp1 = arch_to_object (find_archetype (arch_string)); 1399 tmp1 = arch_to_object (archetype::find (arch_string));
1687 1400
1688 tmp1->x = op->x; 1401 tmp1->x = op->x;
1689 tmp1->y = op->y; 1402 tmp1->y = op->y;
1690 insert_ob_in_map (tmp1, op->map, op, 0); 1403 insert_ob_in_map (tmp1, op->map, op, 0);
1404}
1405
1406object *
1407object::insert_at (object *where, object *originator, int flags)
1408{
1409 where->map->insert (this, where->x, where->y, originator, flags);
1691} 1410}
1692 1411
1693/* 1412/*
1694 * get_split_ob(ob,nr) splits up ob into two parts. The part which 1413 * get_split_ob(ob,nr) splits up ob into two parts. The part which
1695 * is returned contains nr objects, and the remaining parts contains 1414 * is returned contains nr objects, and the remaining parts contains
1696 * the rest (or is removed and freed if that number is 0). 1415 * the rest (or is removed and freed if that number is 0).
1697 * On failure, NULL is returned, and the reason put into the 1416 * On failure, NULL is returned, and the reason put into the
1698 * global static errmsg array. 1417 * global static errmsg array.
1699 */ 1418 */
1700
1701object * 1419object *
1702get_split_ob (object *orig_ob, uint32 nr) 1420get_split_ob (object *orig_ob, uint32 nr)
1703{ 1421{
1704 object * 1422 object *newob;
1705 newob;
1706 int
1707 is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0); 1423 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1708 1424
1709 if (orig_ob->nrof < nr) 1425 if (orig_ob->nrof < nr)
1710 { 1426 {
1711 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name); 1427 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1712 return NULL; 1428 return NULL;
1713 } 1429 }
1430
1714 newob = object_create_clone (orig_ob); 1431 newob = object_create_clone (orig_ob);
1432
1715 if ((orig_ob->nrof -= nr) < 1) 1433 if ((orig_ob->nrof -= nr) < 1)
1716 { 1434 orig_ob->destroy (1);
1717 if (!is_removed)
1718 remove_ob (orig_ob);
1719 free_object2 (orig_ob, 1);
1720 }
1721 else if (!is_removed) 1435 else if (!is_removed)
1722 { 1436 {
1723 if (orig_ob->env != NULL) 1437 if (orig_ob->env != NULL)
1724 sub_weight (orig_ob->env, orig_ob->weight * nr); 1438 sub_weight (orig_ob->env, orig_ob->weight * nr);
1725 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY) 1439 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY)
1727 strcpy (errmsg, "Tried to split object whose map is not in memory."); 1441 strcpy (errmsg, "Tried to split object whose map is not in memory.");
1728 LOG (llevDebug, "Error, Tried to split object whose map is not in memory.\n"); 1442 LOG (llevDebug, "Error, Tried to split object whose map is not in memory.\n");
1729 return NULL; 1443 return NULL;
1730 } 1444 }
1731 } 1445 }
1446
1732 newob->nrof = nr; 1447 newob->nrof = nr;
1733 1448
1734 return newob; 1449 return newob;
1735} 1450}
1736 1451
1743 */ 1458 */
1744 1459
1745object * 1460object *
1746decrease_ob_nr (object *op, uint32 i) 1461decrease_ob_nr (object *op, uint32 i)
1747{ 1462{
1748 object * 1463 object *tmp;
1749 tmp;
1750 player *
1751 pl;
1752 1464
1753 if (i == 0) /* objects with op->nrof require this check */ 1465 if (i == 0) /* objects with op->nrof require this check */
1754 return op; 1466 return op;
1755 1467
1756 if (i > op->nrof) 1468 if (i > op->nrof)
1757 i = op->nrof; 1469 i = op->nrof;
1758 1470
1759 if (QUERY_FLAG (op, FLAG_REMOVED)) 1471 if (QUERY_FLAG (op, FLAG_REMOVED))
1760 {
1761 op->nrof -= i; 1472 op->nrof -= i;
1762 }
1763 else if (op->env != NULL) 1473 else if (op->env)
1764 { 1474 {
1765 /* is this object in the players inventory, or sub container 1475 /* is this object in the players inventory, or sub container
1766 * therein? 1476 * therein?
1767 */ 1477 */
1768 tmp = is_player_inv (op->env); 1478 tmp = op->in_player ();
1769 /* nope. Is this a container the player has opened? 1479 /* nope. Is this a container the player has opened?
1770 * If so, set tmp to that player. 1480 * If so, set tmp to that player.
1771 * IMO, searching through all the players will mostly 1481 * IMO, searching through all the players will mostly
1772 * likely be quicker than following op->env to the map, 1482 * likely be quicker than following op->env to the map,
1773 * and then searching the map for a player. 1483 * and then searching the map for a player.
1774 */ 1484 */
1775 if (!tmp) 1485 if (!tmp)
1776 { 1486 for_all_players (pl)
1777 for (pl = first_player; pl; pl = pl->next)
1778 if (pl->ob->container == op->env) 1487 if (pl->ob->container == op->env)
1488 {
1489 tmp = pl->ob;
1779 break; 1490 break;
1780 if (pl)
1781 tmp = pl->ob;
1782 else
1783 tmp = NULL;
1784 } 1491 }
1785 1492
1786 if (i < op->nrof) 1493 if (i < op->nrof)
1787 { 1494 {
1788 sub_weight (op->env, op->weight * i); 1495 sub_weight (op->env, op->weight * i);
1789 op->nrof -= i; 1496 op->nrof -= i;
1790 if (tmp) 1497 if (tmp)
1791 {
1792 esrv_send_item (tmp, op); 1498 esrv_send_item (tmp, op);
1793 }
1794 } 1499 }
1795 else 1500 else
1796 { 1501 {
1797 remove_ob (op); 1502 op->remove ();
1798 op->nrof = 0; 1503 op->nrof = 0;
1799 if (tmp) 1504 if (tmp)
1800 {
1801 esrv_del_item (tmp->contr, op->count); 1505 esrv_del_item (tmp->contr, op->count);
1802 }
1803 } 1506 }
1804 } 1507 }
1805 else 1508 else
1806 { 1509 {
1807 object *
1808 above = op->above; 1510 object *above = op->above;
1809 1511
1810 if (i < op->nrof) 1512 if (i < op->nrof)
1811 {
1812 op->nrof -= i; 1513 op->nrof -= i;
1813 }
1814 else 1514 else
1815 { 1515 {
1816 remove_ob (op); 1516 op->remove ();
1817 op->nrof = 0; 1517 op->nrof = 0;
1818 } 1518 }
1519
1819 /* Since we just removed op, op->above is null */ 1520 /* Since we just removed op, op->above is null */
1820 for (tmp = above; tmp != NULL; tmp = tmp->above) 1521 for (tmp = above; tmp; tmp = tmp->above)
1821 if (tmp->type == PLAYER) 1522 if (tmp->type == PLAYER)
1822 { 1523 {
1823 if (op->nrof) 1524 if (op->nrof)
1824 esrv_send_item (tmp, op); 1525 esrv_send_item (tmp, op);
1825 else 1526 else
1826 esrv_del_item (tmp->contr, op->count); 1527 esrv_del_item (tmp->contr, op->count);
1827 } 1528 }
1828 } 1529 }
1829 1530
1830 if (op->nrof) 1531 if (op->nrof)
1831 {
1832 return op; 1532 return op;
1833 }
1834 else 1533 else
1835 { 1534 {
1836 free_object (op); 1535 op->destroy ();
1837 return NULL; 1536 return 0;
1838 } 1537 }
1839} 1538}
1840 1539
1841/* 1540/*
1842 * add_weight(object, weight) adds the specified weight to an object, 1541 * add_weight(object, weight) adds the specified weight to an object,
1847add_weight (object *op, signed long weight) 1546add_weight (object *op, signed long weight)
1848{ 1547{
1849 while (op != NULL) 1548 while (op != NULL)
1850 { 1549 {
1851 if (op->type == CONTAINER) 1550 if (op->type == CONTAINER)
1852 {
1853 weight = (signed long) (weight * (100 - op->stats.Str) / 100); 1551 weight = (signed long) (weight * (100 - op->stats.Str) / 100);
1854 } 1552
1855 op->carrying += weight; 1553 op->carrying += weight;
1856 op = op->env; 1554 op = op->env;
1857 } 1555 }
1858} 1556}
1859 1557
1558object *
1559insert_ob_in_ob (object *op, object *where)
1560{
1561 if (!where)
1562 {
1563 char *dump = dump_object (op);
1564 LOG (llevError, "Trying to put object in NULL.\n%s\n", dump);
1565 free (dump);
1566 return op;
1567 }
1568
1569 if (where->head)
1570 {
1571 LOG (llevDebug, "Warning: Tried to insert object into wrong part of multipart object.\n");
1572 where = where->head;
1573 }
1574
1575 return where->insert (op);
1576}
1577
1860/* 1578/*
1861 * insert_ob_in_ob(op,environment): 1579 * env->insert (op)
1862 * This function inserts the object op in the linked list 1580 * This function inserts the object op in the linked list
1863 * inside the object environment. 1581 * inside the object environment.
1864 * 1582 *
1865 * Eneq(@csd.uu.se): Altered insert_ob_in_ob to make things picked up enter
1866 * the inventory at the last position or next to other objects of the same
1867 * type.
1868 * Frank: Now sorted by type, archetype and magic!
1869 *
1870 * The function returns now pointer to inserted item, and return value can 1583 * The function returns now pointer to inserted item, and return value can
1871 * be != op, if items are merged. -Tero 1584 * be != op, if items are merged. -Tero
1872 */ 1585 */
1873 1586
1874object * 1587object *
1875insert_ob_in_ob (object *op, object *where) 1588object::insert (object *op)
1876{ 1589{
1877 object * 1590 object *tmp, *otmp;
1878 tmp, *
1879 otmp;
1880 1591
1881 if (!QUERY_FLAG (op, FLAG_REMOVED)) 1592 if (!QUERY_FLAG (op, FLAG_REMOVED))
1882 { 1593 op->remove ();
1883 dump_object (op); 1594
1884 LOG (llevError, "Trying to insert (ob) inserted object.\n%s\n", errmsg);
1885 return op;
1886 }
1887 if (where == NULL)
1888 {
1889 dump_object (op);
1890 LOG (llevError, "Trying to put object in NULL.\n%s\n", errmsg);
1891 return op;
1892 }
1893 if (where->head)
1894 {
1895 LOG (llevDebug, "Warning: Tried to insert object wrong part of multipart object.\n");
1896 where = where->head;
1897 }
1898 if (op->more) 1595 if (op->more)
1899 { 1596 {
1900 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count); 1597 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);
1901 return op; 1598 return op;
1902 } 1599 }
1600
1903 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL); 1601 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL);
1904 CLEAR_FLAG (op, FLAG_REMOVED); 1602 CLEAR_FLAG (op, FLAG_REMOVED);
1905 if (op->nrof) 1603 if (op->nrof)
1906 { 1604 {
1907 for (tmp = where->inv; tmp != NULL; tmp = tmp->below) 1605 for (tmp = inv; tmp != NULL; tmp = tmp->below)
1908 if (CAN_MERGE (tmp, op)) 1606 if (object::can_merge (tmp, op))
1909 { 1607 {
1910 /* return the original object and remove inserted object 1608 /* return the original object and remove inserted object
1911 (client needs the original object) */ 1609 (client needs the original object) */
1912 tmp->nrof += op->nrof; 1610 tmp->nrof += op->nrof;
1913 /* Weight handling gets pretty funky. Since we are adding to 1611 /* Weight handling gets pretty funky. Since we are adding to
1914 * tmp->nrof, we need to increase the weight. 1612 * tmp->nrof, we need to increase the weight.
1915 */ 1613 */
1916 add_weight (where, op->weight * op->nrof); 1614 add_weight (this, op->weight * op->nrof);
1917 SET_FLAG (op, FLAG_REMOVED); 1615 SET_FLAG (op, FLAG_REMOVED);
1918 free_object (op); /* free the inserted object */ 1616 op->destroy (); /* free the inserted object */
1919 op = tmp; 1617 op = tmp;
1920 remove_ob (op); /* and fix old object's links */ 1618 op->remove (); /* and fix old object's links */
1921 CLEAR_FLAG (op, FLAG_REMOVED); 1619 CLEAR_FLAG (op, FLAG_REMOVED);
1922 break; 1620 break;
1923 } 1621 }
1924 1622
1925 /* I assume combined objects have no inventory 1623 /* I assume combined objects have no inventory
1926 * We add the weight - this object could have just been removed 1624 * We add the weight - this object could have just been removed
1927 * (if it was possible to merge). calling remove_ob will subtract 1625 * (if it was possible to merge). calling remove_ob will subtract
1928 * the weight, so we need to add it in again, since we actually do 1626 * the weight, so we need to add it in again, since we actually do
1929 * the linking below 1627 * the linking below
1930 */ 1628 */
1931 add_weight (where, op->weight * op->nrof); 1629 add_weight (this, op->weight * op->nrof);
1932 } 1630 }
1933 else 1631 else
1934 add_weight (where, (op->weight + op->carrying)); 1632 add_weight (this, (op->weight + op->carrying));
1935 1633
1936 otmp = is_player_inv (where); 1634 otmp = this->in_player ();
1937 if (otmp && otmp->contr != NULL) 1635 if (otmp && otmp->contr)
1938 {
1939 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1636 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1940 fix_player (otmp); 1637 otmp->update_stats ();
1941 }
1942 1638
1943 op->map = NULL; 1639 op->map = 0;
1944 op->env = where; 1640 op->env = this;
1945 op->above = NULL; 1641 op->above = 0;
1946 op->below = NULL; 1642 op->below = 0;
1947 op->x = 0, op->y = 0; 1643 op->x = 0, op->y = 0;
1948 1644
1949 /* reset the light list and los of the players on the map */ 1645 /* reset the light list and los of the players on the map */
1950 if ((op->glow_radius != 0) && where->map) 1646 if ((op->glow_radius != 0) && map)
1951 { 1647 {
1952#ifdef DEBUG_LIGHTS 1648#ifdef DEBUG_LIGHTS
1953 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name); 1649 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1954#endif /* DEBUG_LIGHTS */ 1650#endif /* DEBUG_LIGHTS */
1955 if (MAP_DARKNESS (where->map)) 1651 if (map->darkness)
1956 update_all_los (where->map, where->x, where->y); 1652 update_all_los (map, x, y);
1957 } 1653 }
1958 1654
1959 /* Client has no idea of ordering so lets not bother ordering it here. 1655 /* Client has no idea of ordering so lets not bother ordering it here.
1960 * It sure simplifies this function... 1656 * It sure simplifies this function...
1961 */ 1657 */
1962 if (where->inv == NULL) 1658 if (!inv)
1963 where->inv = op; 1659 inv = op;
1964 else 1660 else
1965 { 1661 {
1966 op->below = where->inv; 1662 op->below = inv;
1967 op->below->above = op; 1663 op->below->above = op;
1968 where->inv = op; 1664 inv = op;
1969 } 1665 }
1666
1667 INVOKE_OBJECT (INSERT, this);
1668
1970 return op; 1669 return op;
1971} 1670}
1972 1671
1973/* 1672/*
1974 * Checks if any objects has a move_type that matches objects 1673 * Checks if any objects has a move_type that matches objects
1988 * 1687 *
1989 * MSW 2001-07-08: Check all objects on space, not just those below 1688 * MSW 2001-07-08: Check all objects on space, not just those below
1990 * object being inserted. insert_ob_in_map may not put new objects 1689 * object being inserted. insert_ob_in_map may not put new objects
1991 * on top. 1690 * on top.
1992 */ 1691 */
1993
1994int 1692int
1995check_move_on (object *op, object *originator) 1693check_move_on (object *op, object *originator)
1996{ 1694{
1997 object *tmp; 1695 object *tmp;
1998 tag_t tag;
1999 mapstruct *m = op->map; 1696 maptile *m = op->map;
2000 int x = op->x, y = op->y; 1697 int x = op->x, y = op->y;
2001 1698
2002 MoveType move_on, move_slow, move_block; 1699 MoveType move_on, move_slow, move_block;
2003 1700
2004 if (QUERY_FLAG (op, FLAG_NO_APPLY)) 1701 if (QUERY_FLAG (op, FLAG_NO_APPLY))
2005 return 0; 1702 return 0;
2006
2007 tag = op->count;
2008 1703
2009 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y); 1704 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
2010 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y); 1705 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
2011 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y); 1706 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
2012 1707
2028 1723
2029 /* The objects have to be checked from top to bottom. 1724 /* The objects have to be checked from top to bottom.
2030 * Hence, we first go to the top: 1725 * Hence, we first go to the top:
2031 */ 1726 */
2032 1727
2033 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL && tmp->above != NULL; tmp = tmp->above) 1728 for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
2034 { 1729 {
2035 /* Trim the search when we find the first other spell effect 1730 /* Trim the search when we find the first other spell effect
2036 * this helps performance so that if a space has 50 spell objects, 1731 * this helps performance so that if a space has 50 spell objects,
2037 * we don't need to check all of them. 1732 * we don't need to check all of them.
2038 */ 1733 */
2055 { 1750 {
2056 if ((!op->move_type && tmp->move_slow & MOVE_WALK) || 1751 if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
2057 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0)) 1752 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
2058 { 1753 {
2059 1754
1755 float
2060 float diff = tmp->move_slow_penalty * FABS (op->speed); 1756 diff = tmp->move_slow_penalty * fabs (op->speed);
2061 1757
2062 if (op->type == PLAYER) 1758 if (op->type == PLAYER)
2063 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) || 1759 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) ||
2064 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN))) 1760 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN)))
2065 diff /= 4.0; 1761 diff /= 4.0;
2072 if ((!op->move_type && tmp->move_on & MOVE_WALK) || 1768 if ((!op->move_type && tmp->move_on & MOVE_WALK) ||
2073 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0)) 1769 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0))
2074 { 1770 {
2075 move_apply (tmp, op, originator); 1771 move_apply (tmp, op, originator);
2076 1772
2077 if (was_destroyed (op, tag)) 1773 if (op->destroyed ())
2078 return 1; 1774 return 1;
2079 1775
2080 /* what the person/creature stepped onto has moved the object 1776 /* what the person/creature stepped onto has moved the object
2081 * someplace new. Don't process any further - if we did, 1777 * someplace new. Don't process any further - if we did,
2082 * have a feeling strange problems would result. 1778 * have a feeling strange problems would result.
2092/* 1788/*
2093 * present_arch(arch, map, x, y) searches for any objects with 1789 * present_arch(arch, map, x, y) searches for any objects with
2094 * a matching archetype at the given map and coordinates. 1790 * a matching archetype at the given map and coordinates.
2095 * The first matching object is returned, or NULL if none. 1791 * The first matching object is returned, or NULL if none.
2096 */ 1792 */
2097
2098object * 1793object *
2099present_arch (const archetype *at, mapstruct *m, int x, int y) 1794present_arch (const archetype *at, maptile *m, int x, int y)
2100{ 1795{
2101 object *
2102 tmp;
2103
2104 if (m == NULL || out_of_map (m, x, y)) 1796 if (!m || out_of_map (m, x, y))
2105 { 1797 {
2106 LOG (llevError, "Present_arch called outside map.\n"); 1798 LOG (llevError, "Present_arch called outside map.\n");
2107 return NULL; 1799 return NULL;
2108 } 1800 }
2109 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1801
1802 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
2110 if (tmp->arch == at) 1803 if (tmp->arch == at)
2111 return tmp; 1804 return tmp;
1805
2112 return NULL; 1806 return NULL;
2113} 1807}
2114 1808
2115/* 1809/*
2116 * present(type, map, x, y) searches for any objects with 1810 * present(type, map, x, y) searches for any objects with
2117 * a matching type variable at the given map and coordinates. 1811 * a matching type variable at the given map and coordinates.
2118 * The first matching object is returned, or NULL if none. 1812 * The first matching object is returned, or NULL if none.
2119 */ 1813 */
2120
2121object * 1814object *
2122present (unsigned char type, mapstruct *m, int x, int y) 1815present (unsigned char type, maptile *m, int x, int y)
2123{ 1816{
2124 object *
2125 tmp;
2126
2127 if (out_of_map (m, x, y)) 1817 if (out_of_map (m, x, y))
2128 { 1818 {
2129 LOG (llevError, "Present called outside map.\n"); 1819 LOG (llevError, "Present called outside map.\n");
2130 return NULL; 1820 return NULL;
2131 } 1821 }
2132 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1822
1823 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
2133 if (tmp->type == type) 1824 if (tmp->type == type)
2134 return tmp; 1825 return tmp;
1826
2135 return NULL; 1827 return NULL;
2136} 1828}
2137 1829
2138/* 1830/*
2139 * present_in_ob(type, object) searches for any objects with 1831 * present_in_ob(type, object) searches for any objects with
2140 * a matching type variable in the inventory of the given object. 1832 * a matching type variable in the inventory of the given object.
2141 * The first matching object is returned, or NULL if none. 1833 * The first matching object is returned, or NULL if none.
2142 */ 1834 */
2143
2144object * 1835object *
2145present_in_ob (unsigned char type, const object *op) 1836present_in_ob (unsigned char type, const object *op)
2146{ 1837{
2147 object *
2148 tmp;
2149
2150 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1838 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2151 if (tmp->type == type) 1839 if (tmp->type == type)
2152 return tmp; 1840 return tmp;
1841
2153 return NULL; 1842 return NULL;
2154} 1843}
2155 1844
2156/* 1845/*
2157 * present_in_ob (type, str, object) searches for any objects with 1846 * present_in_ob (type, str, object) searches for any objects with
2165 * str is the string to match against. Note that we match against 1854 * str is the string to match against. Note that we match against
2166 * the object name, not the archetype name. this is so that the 1855 * the object name, not the archetype name. this is so that the
2167 * spell code can use one object type (force), but change it's name 1856 * spell code can use one object type (force), but change it's name
2168 * to be unique. 1857 * to be unique.
2169 */ 1858 */
2170
2171object * 1859object *
2172present_in_ob_by_name (int type, const char *str, const object *op) 1860present_in_ob_by_name (int type, const char *str, const object *op)
2173{ 1861{
2174 object *
2175 tmp;
2176
2177 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1862 for (object *tmp = op->inv; tmp; tmp = tmp->below)
2178 {
2179 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name))) 1863 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name)))
2180 return tmp; 1864 return tmp;
2181 } 1865
2182 return NULL; 1866 return 0;
2183} 1867}
2184 1868
2185/* 1869/*
2186 * present_arch_in_ob(archetype, object) searches for any objects with 1870 * present_arch_in_ob(archetype, object) searches for any objects with
2187 * a matching archetype in the inventory of the given object. 1871 * a matching archetype in the inventory of the given object.
2188 * The first matching object is returned, or NULL if none. 1872 * The first matching object is returned, or NULL if none.
2189 */ 1873 */
2190
2191object * 1874object *
2192present_arch_in_ob (const archetype *at, const object *op) 1875present_arch_in_ob (const archetype *at, const object *op)
2193{ 1876{
2194 object *
2195 tmp;
2196
2197 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1877 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2198 if (tmp->arch == at) 1878 if (tmp->arch == at)
2199 return tmp; 1879 return tmp;
1880
2200 return NULL; 1881 return NULL;
2201} 1882}
2202 1883
2203/* 1884/*
2204 * activate recursively a flag on an object inventory 1885 * activate recursively a flag on an object inventory
2205 */ 1886 */
2206void 1887void
2207flag_inv (object *op, int flag) 1888flag_inv (object *op, int flag)
2208{ 1889{
2209 object *
2210 tmp;
2211
2212 if (op->inv) 1890 if (op->inv)
2213 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1891 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2214 { 1892 {
2215 SET_FLAG (tmp, flag); 1893 SET_FLAG (tmp, flag);
2216 flag_inv (tmp, flag); 1894 flag_inv (tmp, flag);
2217 } 1895 }
2218} /* 1896}
1897
1898/*
2219 * desactivate recursively a flag on an object inventory 1899 * deactivate recursively a flag on an object inventory
2220 */ 1900 */
2221void 1901void
2222unflag_inv (object *op, int flag) 1902unflag_inv (object *op, int flag)
2223{ 1903{
2224 object *
2225 tmp;
2226
2227 if (op->inv) 1904 if (op->inv)
2228 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1905 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2229 { 1906 {
2230 CLEAR_FLAG (tmp, flag); 1907 CLEAR_FLAG (tmp, flag);
2231 unflag_inv (tmp, flag); 1908 unflag_inv (tmp, flag);
2232 } 1909 }
2233} 1910}
2236 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in 1913 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in
2237 * all it's inventory (recursively). 1914 * all it's inventory (recursively).
2238 * If checksums are used, a player will get set_cheat called for 1915 * If checksums are used, a player will get set_cheat called for
2239 * him/her-self and all object carried by a call to this function. 1916 * him/her-self and all object carried by a call to this function.
2240 */ 1917 */
2241
2242void 1918void
2243set_cheat (object *op) 1919set_cheat (object *op)
2244{ 1920{
2245 SET_FLAG (op, FLAG_WAS_WIZ); 1921 SET_FLAG (op, FLAG_WAS_WIZ);
2246 flag_inv (op, FLAG_WAS_WIZ); 1922 flag_inv (op, FLAG_WAS_WIZ);
2265 * because arch_blocked (now ob_blocked) needs to know the movement type 1941 * because arch_blocked (now ob_blocked) needs to know the movement type
2266 * to know if the space in question will block the object. We can't use 1942 * to know if the space in question will block the object. We can't use
2267 * the archetype because that isn't correct if the monster has been 1943 * the archetype because that isn't correct if the monster has been
2268 * customized, changed states, etc. 1944 * customized, changed states, etc.
2269 */ 1945 */
2270
2271int 1946int
2272find_free_spot (const object *ob, mapstruct *m, int x, int y, int start, int stop) 1947find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)
2273{ 1948{
2274 int
2275 i,
2276 index = 0, flag; 1949 int index = 0, flag;
2277 static int
2278 altern[SIZEOFFREE]; 1950 int altern[SIZEOFFREE];
2279 1951
2280 for (i = start; i < stop; i++) 1952 for (int i = start; i < stop; i++)
2281 { 1953 {
2282 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]); 1954 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]);
2283 if (!flag) 1955 if (!flag)
2284 altern[index++] = i; 1956 altern [index++] = i;
2285 1957
2286 /* Basically, if we find a wall on a space, we cut down the search size. 1958 /* Basically, if we find a wall on a space, we cut down the search size.
2287 * In this way, we won't return spaces that are on another side of a wall. 1959 * In this way, we won't return spaces that are on another side of a wall.
2288 * This mostly work, but it cuts down the search size in all directions - 1960 * This mostly work, but it cuts down the search size in all directions -
2289 * if the space being examined only has a wall to the north and empty 1961 * if the space being examined only has a wall to the north and empty
2290 * spaces in all the other directions, this will reduce the search space 1962 * spaces in all the other directions, this will reduce the search space
2291 * to only the spaces immediately surrounding the target area, and 1963 * to only the spaces immediately surrounding the target area, and
2292 * won't look 2 spaces south of the target space. 1964 * won't look 2 spaces south of the target space.
2293 */ 1965 */
2294 else if ((flag & AB_NO_PASS) && maxfree[i] < stop) 1966 else if ((flag & P_NO_PASS) && maxfree[i] < stop)
2295 stop = maxfree[i]; 1967 stop = maxfree[i];
2296 } 1968 }
1969
2297 if (!index) 1970 if (!index)
2298 return -1; 1971 return -1;
1972
2299 return altern[RANDOM () % index]; 1973 return altern[RANDOM () % index];
2300} 1974}
2301 1975
2302/* 1976/*
2303 * find_first_free_spot(archetype, mapstruct, x, y) works like 1977 * find_first_free_spot(archetype, maptile, x, y) works like
2304 * find_free_spot(), but it will search max number of squares. 1978 * find_free_spot(), but it will search max number of squares.
2305 * But it will return the first available spot, not a random choice. 1979 * But it will return the first available spot, not a random choice.
2306 * Changed 0.93.2: Have it return -1 if there is no free spot available. 1980 * Changed 0.93.2: Have it return -1 if there is no free spot available.
2307 */ 1981 */
2308
2309int 1982int
2310find_first_free_spot (const object *ob, mapstruct *m, int x, int y) 1983find_first_free_spot (const object *ob, maptile *m, int x, int y)
2311{ 1984{
2312 int
2313 i;
2314
2315 for (i = 0; i < SIZEOFFREE; i++) 1985 for (int i = 0; i < SIZEOFFREE; i++)
2316 {
2317 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i])) 1986 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]))
2318 return i; 1987 return i;
2319 } 1988
2320 return -1; 1989 return -1;
2321} 1990}
2322 1991
2323/* 1992/*
2324 * The function permute(arr, begin, end) randomly reorders the array 1993 * The function permute(arr, begin, end) randomly reorders the array
2325 * arr[begin..end-1]. 1994 * arr[begin..end-1].
1995 * now uses a fisher-yates shuffle, old permute was broken
2326 */ 1996 */
2327static void 1997static void
2328permute (int *arr, int begin, int end) 1998permute (int *arr, int begin, int end)
2329{ 1999{
2330 int 2000 arr += begin;
2331 i,
2332 j,
2333 tmp,
2334 len;
2335
2336 len = end - begin; 2001 end -= begin;
2337 for (i = begin; i < end; i++)
2338 {
2339 j = begin + RANDOM () % len;
2340 2002
2341 tmp = arr[i]; 2003 while (--end)
2342 arr[i] = arr[j]; 2004 swap (arr [end], arr [RANDOM () % (end + 1)]);
2343 arr[j] = tmp;
2344 }
2345} 2005}
2346 2006
2347/* new function to make monster searching more efficient, and effective! 2007/* new function to make monster searching more efficient, and effective!
2348 * This basically returns a randomized array (in the passed pointer) of 2008 * This basically returns a randomized array (in the passed pointer) of
2349 * the spaces to find monsters. In this way, it won't always look for 2009 * the spaces to find monsters. In this way, it won't always look for
2352 * the 3x3 area will be searched, just not in a predictable order. 2012 * the 3x3 area will be searched, just not in a predictable order.
2353 */ 2013 */
2354void 2014void
2355get_search_arr (int *search_arr) 2015get_search_arr (int *search_arr)
2356{ 2016{
2357 int 2017 int i;
2358 i;
2359 2018
2360 for (i = 0; i < SIZEOFFREE; i++) 2019 for (i = 0; i < SIZEOFFREE; i++)
2361 {
2362 search_arr[i] = i; 2020 search_arr[i] = i;
2363 }
2364 2021
2365 permute (search_arr, 1, SIZEOFFREE1 + 1); 2022 permute (search_arr, 1, SIZEOFFREE1 + 1);
2366 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1); 2023 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1);
2367 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE); 2024 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE);
2368} 2025}
2377 * Perhaps incorrectly, but I'm making the assumption that exclude 2034 * Perhaps incorrectly, but I'm making the assumption that exclude
2378 * is actually want is going to try and move there. We need this info 2035 * is actually want is going to try and move there. We need this info
2379 * because we have to know what movement the thing looking to move 2036 * because we have to know what movement the thing looking to move
2380 * there is capable of. 2037 * there is capable of.
2381 */ 2038 */
2382
2383int 2039int
2384find_dir (mapstruct *m, int x, int y, object *exclude) 2040find_dir (maptile *m, int x, int y, object *exclude)
2385{ 2041{
2386 int
2387 i,
2388 max = SIZEOFFREE, mflags; 2042 int i, max = SIZEOFFREE, mflags;
2389 sint16 2043
2390 nx, 2044 sint16 nx, ny;
2391 ny;
2392 object * 2045 object *tmp;
2393 tmp; 2046 maptile *mp;
2394 mapstruct * 2047
2395 mp; 2048 MoveType blocked, move_type;
2396 MoveType
2397 blocked,
2398 move_type;
2399 2049
2400 if (exclude && exclude->head) 2050 if (exclude && exclude->head)
2401 { 2051 {
2402 exclude = exclude->head; 2052 exclude = exclude->head;
2403 move_type = exclude->move_type; 2053 move_type = exclude->move_type;
2413 mp = m; 2063 mp = m;
2414 nx = x + freearr_x[i]; 2064 nx = x + freearr_x[i];
2415 ny = y + freearr_y[i]; 2065 ny = y + freearr_y[i];
2416 2066
2417 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2067 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);
2068
2418 if (mflags & P_OUT_OF_MAP) 2069 if (mflags & P_OUT_OF_MAP)
2419 {
2420 max = maxfree[i]; 2070 max = maxfree[i];
2421 }
2422 else 2071 else
2423 { 2072 {
2424 blocked = GET_MAP_MOVE_BLOCK (mp, nx, ny); 2073 mapspace &ms = mp->at (nx, ny);
2074
2075 blocked = ms.move_block;
2425 2076
2426 if ((move_type & blocked) == move_type) 2077 if ((move_type & blocked) == move_type)
2427 {
2428 max = maxfree[i]; 2078 max = maxfree[i];
2429 }
2430 else if (mflags & P_IS_ALIVE) 2079 else if (mflags & P_IS_ALIVE)
2431 { 2080 {
2432 for (tmp = GET_MAP_OB (mp, nx, ny); tmp != NULL; tmp = tmp->above) 2081 for (tmp = ms.bot; tmp; tmp = tmp->above)
2433 { 2082 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)
2434 if ((QUERY_FLAG (tmp, FLAG_MONSTER) || tmp->type == PLAYER) && (tmp != exclude || (tmp->head && tmp->head != exclude))) 2083 && (tmp != exclude || (tmp->head && tmp->head != exclude)))
2435 {
2436 break; 2084 break;
2437 } 2085
2438 }
2439 if (tmp) 2086 if (tmp)
2440 {
2441 return freedir[i]; 2087 return freedir[i];
2442 }
2443 } 2088 }
2444 } 2089 }
2445 } 2090 }
2091
2446 return 0; 2092 return 0;
2447} 2093}
2448 2094
2449/* 2095/*
2450 * distance(object 1, object 2) will return the square of the 2096 * distance(object 1, object 2) will return the square of the
2451 * distance between the two given objects. 2097 * distance between the two given objects.
2452 */ 2098 */
2453
2454int 2099int
2455distance (const object *ob1, const object *ob2) 2100distance (const object *ob1, const object *ob2)
2456{ 2101{
2457 int
2458 i;
2459
2460 i = (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y); 2102 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2461 return i;
2462} 2103}
2463 2104
2464/* 2105/*
2465 * find_dir_2(delta-x,delta-y) will return a direction in which 2106 * find_dir_2(delta-x,delta-y) will return a direction in which
2466 * an object which has subtracted the x and y coordinates of another 2107 * an object which has subtracted the x and y coordinates of another
2467 * object, needs to travel toward it. 2108 * object, needs to travel toward it.
2468 */ 2109 */
2469
2470int 2110int
2471find_dir_2 (int x, int y) 2111find_dir_2 (int x, int y)
2472{ 2112{
2473 int 2113 int q;
2474 q;
2475 2114
2476 if (y) 2115 if (y)
2477 q = x * 100 / y; 2116 q = x * 100 / y;
2478 else if (x) 2117 else if (x)
2479 q = -300 * x; 2118 q = -300 * x;
2504 2143
2505 return 3; 2144 return 3;
2506} 2145}
2507 2146
2508/* 2147/*
2509 * absdir(int): Returns a number between 1 and 8, which represent
2510 * the "absolute" direction of a number (it actually takes care of
2511 * "overflow" in previous calculations of a direction).
2512 */
2513
2514int
2515absdir (int d)
2516{
2517 while (d < 1)
2518 d += 8;
2519 while (d > 8)
2520 d -= 8;
2521 return d;
2522}
2523
2524/*
2525 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is 2148 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is
2526 * between two directions (which are expected to be absolute (see absdir()) 2149 * between two directions (which are expected to be absolute (see absdir())
2527 */ 2150 */
2528
2529int 2151int
2530dirdiff (int dir1, int dir2) 2152dirdiff (int dir1, int dir2)
2531{ 2153{
2532 int 2154 int d;
2533 d;
2534 2155
2535 d = abs (dir1 - dir2); 2156 d = abs (dir1 - dir2);
2536 if (d > 4) 2157 if (d > 4)
2537 d = 8 - d; 2158 d = 8 - d;
2159
2538 return d; 2160 return d;
2539} 2161}
2540 2162
2541/* peterm: 2163/* peterm:
2542 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster. 2164 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster.
2545 * This basically means that if direction is 15, then it could either go 2167 * This basically means that if direction is 15, then it could either go
2546 * direction 4, 14, or 16 to get back to where we are. 2168 * direction 4, 14, or 16 to get back to where we are.
2547 * Moved from spell_util.c to object.c with the other related direction 2169 * Moved from spell_util.c to object.c with the other related direction
2548 * functions. 2170 * functions.
2549 */ 2171 */
2550
2551int
2552 reduction_dir[SIZEOFFREE][3] = { 2172int reduction_dir[SIZEOFFREE][3] = {
2553 {0, 0, 0}, /* 0 */ 2173 {0, 0, 0}, /* 0 */
2554 {0, 0, 0}, /* 1 */ 2174 {0, 0, 0}, /* 1 */
2555 {0, 0, 0}, /* 2 */ 2175 {0, 0, 0}, /* 2 */
2556 {0, 0, 0}, /* 3 */ 2176 {0, 0, 0}, /* 3 */
2557 {0, 0, 0}, /* 4 */ 2177 {0, 0, 0}, /* 4 */
2605 * find a path to that monster that we found. If not, 2225 * find a path to that monster that we found. If not,
2606 * we don't bother going toward it. Returns 1 if we 2226 * we don't bother going toward it. Returns 1 if we
2607 * can see a direct way to get it 2227 * can see a direct way to get it
2608 * Modified to be map tile aware -.MSW 2228 * Modified to be map tile aware -.MSW
2609 */ 2229 */
2610
2611
2612int 2230int
2613can_see_monsterP (mapstruct *m, int x, int y, int dir) 2231can_see_monsterP (maptile *m, int x, int y, int dir)
2614{ 2232{
2615 sint16 2233 sint16 dx, dy;
2616 dx,
2617 dy;
2618 int
2619 mflags; 2234 int mflags;
2620 2235
2621 if (dir < 0) 2236 if (dir < 0)
2622 return 0; /* exit condition: invalid direction */ 2237 return 0; /* exit condition: invalid direction */
2623 2238
2624 dx = x + freearr_x[dir]; 2239 dx = x + freearr_x[dir];
2637 return 0; 2252 return 0;
2638 2253
2639 /* yes, can see. */ 2254 /* yes, can see. */
2640 if (dir < 9) 2255 if (dir < 9)
2641 return 1; 2256 return 1;
2257
2642 return can_see_monsterP (m, x, y, reduction_dir[dir][0]) | 2258 return can_see_monsterP (m, x, y, reduction_dir[dir][0])
2643 can_see_monsterP (m, x, y, reduction_dir[dir][1]) | can_see_monsterP (m, x, y, reduction_dir[dir][2]); 2259 | can_see_monsterP (m, x, y, reduction_dir[dir][1])
2260 | can_see_monsterP (m, x, y, reduction_dir[dir][2]);
2644} 2261}
2645
2646
2647 2262
2648/* 2263/*
2649 * can_pick(picker, item): finds out if an object is possible to be 2264 * can_pick(picker, item): finds out if an object is possible to be
2650 * picked up by the picker. Returnes 1 if it can be 2265 * picked up by the picker. Returnes 1 if it can be
2651 * picked up, otherwise 0. 2266 * picked up, otherwise 0.
2662 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2277 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2663 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2278 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2664 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2279 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));
2665} 2280}
2666 2281
2667
2668/* 2282/*
2669 * create clone from object to another 2283 * create clone from object to another
2670 */ 2284 */
2671object * 2285object *
2672object_create_clone (object *asrc) 2286object_create_clone (object *asrc)
2673{ 2287{
2674 object *
2675 dst = NULL, *tmp, *src, *part, *prev, *item; 2288 object *dst = 0, *tmp, *src, *part, *prev, *item;
2676 2289
2677 if (!asrc) 2290 if (!asrc)
2678 return NULL; 2291 return 0;
2292
2679 src = asrc; 2293 src = asrc;
2680 if (src->head) 2294 if (src->head)
2681 src = src->head; 2295 src = src->head;
2682 2296
2683 prev = NULL; 2297 prev = 0;
2684 for (part = src; part; part = part->more) 2298 for (part = src; part; part = part->more)
2685 { 2299 {
2686 tmp = get_object (); 2300 tmp = part->clone ();
2687 copy_object (part, tmp);
2688 tmp->x -= src->x; 2301 tmp->x -= src->x;
2689 tmp->y -= src->y; 2302 tmp->y -= src->y;
2303
2690 if (!part->head) 2304 if (!part->head)
2691 { 2305 {
2692 dst = tmp; 2306 dst = tmp;
2693 tmp->head = NULL; 2307 tmp->head = 0;
2694 } 2308 }
2695 else 2309 else
2696 {
2697 tmp->head = dst; 2310 tmp->head = dst;
2698 } 2311
2699 tmp->more = NULL; 2312 tmp->more = 0;
2313
2700 if (prev) 2314 if (prev)
2701 prev->more = tmp; 2315 prev->more = tmp;
2316
2702 prev = tmp; 2317 prev = tmp;
2703 } 2318 }
2704 2319
2705 /*** copy inventory ***/
2706 for (item = src->inv; item; item = item->below) 2320 for (item = src->inv; item; item = item->below)
2707 {
2708 (void) insert_ob_in_ob (object_create_clone (item), dst); 2321 insert_ob_in_ob (object_create_clone (item), dst);
2709 }
2710 2322
2711 return dst; 2323 return dst;
2712} 2324}
2713 2325
2714/* return true if the object was destroyed, 0 otherwise */
2715int
2716was_destroyed (const object *op, tag_t old_tag)
2717{
2718 /* checking for FLAG_FREED isn't necessary, but makes this function more
2719 * robust */
2720 return op->count != old_tag || QUERY_FLAG (op, FLAG_FREED);
2721}
2722
2723/* GROS - Creates an object using a string representing its content. */ 2326/* GROS - Creates an object using a string representing its content. */
2724
2725/* Basically, we save the content of the string to a temp file, then call */ 2327/* Basically, we save the content of the string to a temp file, then call */
2726
2727/* load_object on it. I admit it is a highly inefficient way to make things, */ 2328/* load_object on it. I admit it is a highly inefficient way to make things, */
2728
2729/* but it was simple to make and allows reusing the load_object function. */ 2329/* but it was simple to make and allows reusing the load_object function. */
2730
2731/* Remember not to use load_object_str in a time-critical situation. */ 2330/* Remember not to use load_object_str in a time-critical situation. */
2732
2733/* Also remember that multiparts objects are not supported for now. */ 2331/* Also remember that multiparts objects are not supported for now. */
2734
2735object * 2332object *
2736load_object_str (const char *obstr) 2333load_object_str (const char *obstr)
2737{ 2334{
2738 object * 2335 object *op;
2739 op;
2740 char
2741 filename[MAX_BUF]; 2336 char filename[MAX_BUF];
2742 2337
2743 sprintf (filename, "%s/cfloadobstr2044", settings.tmpdir); 2338 sprintf (filename, "%s/cfloadobstr2044", settings.tmpdir);
2744 2339
2745 FILE *
2746 tempfile = fopen (filename, "w"); 2340 FILE *tempfile = fopen (filename, "w");
2747 2341
2748 if (tempfile == NULL) 2342 if (tempfile == NULL)
2749 { 2343 {
2750 LOG (llevError, "Error - Unable to access load object temp file\n"); 2344 LOG (llevError, "Error - Unable to access load object temp file\n");
2751 return NULL; 2345 return NULL;
2752 }; 2346 }
2347
2753 fprintf (tempfile, obstr); 2348 fprintf (tempfile, obstr);
2754 fclose (tempfile); 2349 fclose (tempfile);
2755 2350
2756 op = get_object (); 2351 op = object::create ();
2757 2352
2758 object_thawer 2353 object_thawer thawer (filename);
2759 thawer (filename);
2760 2354
2761 if (thawer) 2355 if (thawer)
2762 load_object (thawer, op, 0); 2356 load_object (thawer, op, 0);
2763 2357
2764 LOG (llevDebug, " load str completed, object=%s\n", &op->name); 2358 LOG (llevDebug, " load str completed, object=%s\n", &op->name);
2772 * returns NULL if no match. 2366 * returns NULL if no match.
2773 */ 2367 */
2774object * 2368object *
2775find_obj_by_type_subtype (const object *who, int type, int subtype) 2369find_obj_by_type_subtype (const object *who, int type, int subtype)
2776{ 2370{
2777 object *
2778 tmp;
2779
2780 for (tmp = who->inv; tmp; tmp = tmp->below) 2371 for (object *tmp = who->inv; tmp; tmp = tmp->below)
2781 if (tmp->type == type && tmp->subtype == subtype) 2372 if (tmp->type == type && tmp->subtype == subtype)
2782 return tmp; 2373 return tmp;
2783 2374
2784 return NULL; 2375 return 0;
2785} 2376}
2786 2377
2787/* If ob has a field named key, return the link from the list, 2378/* If ob has a field named key, return the link from the list,
2788 * otherwise return NULL. 2379 * otherwise return NULL.
2789 * 2380 *
2791 * do the desired thing. 2382 * do the desired thing.
2792 */ 2383 */
2793key_value * 2384key_value *
2794get_ob_key_link (const object *ob, const char *key) 2385get_ob_key_link (const object *ob, const char *key)
2795{ 2386{
2796 key_value *
2797 link;
2798
2799 for (link = ob->key_values; link != NULL; link = link->next) 2387 for (key_value *link = ob->key_values; link; link = link->next)
2800 {
2801 if (link->key == key) 2388 if (link->key == key)
2802 {
2803 return link; 2389 return link;
2804 }
2805 }
2806 2390
2807 return NULL; 2391 return 0;
2808} 2392}
2809 2393
2810/* 2394/*
2811 * Returns the value of op has an extra_field for key, or NULL. 2395 * Returns the value of op has an extra_field for key, or NULL.
2812 * 2396 *
2815 * The returned string is shared. 2399 * The returned string is shared.
2816 */ 2400 */
2817const char * 2401const char *
2818get_ob_key_value (const object *op, const char *const key) 2402get_ob_key_value (const object *op, const char *const key)
2819{ 2403{
2820 key_value * 2404 key_value *link;
2821 link; 2405 shstr_cmp canonical_key (key);
2822 const char *
2823 canonical_key;
2824 2406
2825 canonical_key = shstr::find (key);
2826
2827 if (canonical_key == NULL) 2407 if (!canonical_key)
2828 { 2408 {
2829 /* 1. There being a field named key on any object 2409 /* 1. There being a field named key on any object
2830 * implies there'd be a shared string to find. 2410 * implies there'd be a shared string to find.
2831 * 2. Since there isn't, no object has this field. 2411 * 2. Since there isn't, no object has this field.
2832 * 3. Therefore, *this* object doesn't have this field. 2412 * 3. Therefore, *this* object doesn't have this field.
2833 */ 2413 */
2834 return NULL; 2414 return 0;
2835 } 2415 }
2836 2416
2837 /* This is copied from get_ob_key_link() above - 2417 /* This is copied from get_ob_key_link() above -
2838 * only 4 lines, and saves the function call overhead. 2418 * only 4 lines, and saves the function call overhead.
2839 */ 2419 */
2840 for (link = op->key_values; link != NULL; link = link->next) 2420 for (link = op->key_values; link; link = link->next)
2841 {
2842 if (link->key == canonical_key) 2421 if (link->key == canonical_key)
2843 {
2844 return link->value; 2422 return link->value;
2845 } 2423
2846 }
2847 return NULL; 2424 return 0;
2848} 2425}
2849 2426
2850 2427
2851/* 2428/*
2852 * Updates the canonical_key in op to value. 2429 * Updates the canonical_key in op to value.
2859 * Returns TRUE on success. 2436 * Returns TRUE on success.
2860 */ 2437 */
2861int 2438int
2862set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key) 2439set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2863{ 2440{
2864 key_value *
2865 field = NULL, *last = NULL; 2441 key_value *field = NULL, *last = NULL;
2866 2442
2867 for (field = op->key_values; field != NULL; field = field->next) 2443 for (field = op->key_values; field != NULL; field = field->next)
2868 { 2444 {
2869 if (field->key != canonical_key) 2445 if (field->key != canonical_key)
2870 { 2446 {
2888 if (last) 2464 if (last)
2889 last->next = field->next; 2465 last->next = field->next;
2890 else 2466 else
2891 op->key_values = field->next; 2467 op->key_values = field->next;
2892 2468
2893 delete
2894 field; 2469 delete field;
2895 } 2470 }
2896 } 2471 }
2897 return TRUE; 2472 return TRUE;
2898 } 2473 }
2899 /* IF we get here, key doesn't exist */ 2474 /* IF we get here, key doesn't exist */
2900 2475
2901 /* No field, we'll have to add it. */ 2476 /* No field, we'll have to add it. */
2902 2477
2903 if (!add_key) 2478 if (!add_key)
2904 {
2905 return FALSE; 2479 return FALSE;
2906 } 2480
2907 /* There isn't any good reason to store a null 2481 /* There isn't any good reason to store a null
2908 * value in the key/value list. If the archetype has 2482 * value in the key/value list. If the archetype has
2909 * this key, then we should also have it, so shouldn't 2483 * this key, then we should also have it, so shouldn't
2910 * be here. If user wants to store empty strings, 2484 * be here. If user wants to store empty strings,
2911 * should pass in "" 2485 * should pass in ""
2934 * Returns TRUE on success. 2508 * Returns TRUE on success.
2935 */ 2509 */
2936int 2510int
2937set_ob_key_value (object *op, const char *key, const char *value, int add_key) 2511set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2938{ 2512{
2939 shstr
2940 key_ (key); 2513 shstr key_ (key);
2941 2514
2942 return set_ob_key_value_s (op, key_, value, add_key); 2515 return set_ob_key_value_s (op, key_, value, add_key);
2943} 2516}
2517
2518object::depth_iterator::depth_iterator (object *container)
2519: iterator_base (container)
2520{
2521 while (item->inv)
2522 item = item->inv;
2523}
2524
2525void
2526object::depth_iterator::next ()
2527{
2528 if (item->below)
2529 {
2530 item = item->below;
2531
2532 while (item->inv)
2533 item = item->inv;
2534 }
2535 else
2536 item = item->env;
2537}
2538
2539
2540const char *
2541object::flag_desc (char *desc, int len) const
2542{
2543 char *p = desc;
2544 bool first = true;
2545
2546 *p = 0;
2547
2548 for (int i = 0; i < NUM_FLAGS; i++)
2549 {
2550 if (len <= 10) // magic constant!
2551 {
2552 snprintf (p, len, ",...");
2553 break;
2554 }
2555
2556 if (flag [i])
2557 {
2558 int cnt = snprintf (p, len, "%s%d", first ? "" : ",", i);
2559 len -= cnt;
2560 p += cnt;
2561 first = false;
2562 }
2563 }
2564
2565 return desc;
2566}
2567
2568// return a suitable string describing an object in enough detail to find it
2569const char *
2570object::debug_desc (char *info) const
2571{
2572 char flagdesc[512];
2573 char info2[256 * 4];
2574 char *p = info;
2575
2576 p += snprintf (p, 512, "{cnt:%d,uuid:<1,%" PRIx64 ">,name:\"%s\"%s%s,flags:[%s],type:%d}",
2577 count, uuid.seq,
2578 &name,
2579 title ? "\",title:\"" : "",
2580 title ? (const char *)title : "",
2581 flag_desc (flagdesc, 512), type);
2582
2583 if (env)
2584 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2585
2586 if (map)
2587 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2588
2589 return info;
2590}
2591
2592const char *
2593object::debug_desc () const
2594{
2595 static char info[256 * 4];
2596 return debug_desc (info);
2597}
2598
2599const char *
2600object::debug_desc2 () const
2601{
2602 static char info[256 * 4];
2603 return debug_desc (info);
2604}
2605

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines