ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.223 by root, Wed Apr 30 08:29:31 2008 UTC vs.
Revision 1.291 by root, Mon Oct 12 14:00:57 2009 UTC

1/* 1/*
2 * This file is part of Deliantra, the Roguelike Realtime MMORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team 4 * Copyright (©) 2005,2006,2007,2008,2009 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 * 7 *
8 * Deliantra is free software: you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify it under
9 * it under the terms of the GNU General Public License as published by 9 * the terms of the Affero GNU General Public License as published by the
10 * the Free Software Foundation, either version 3 of the License, or 10 * Free Software Foundation, either version 3 of the License, or (at your
11 * (at your option) any later version. 11 * option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the Affero GNU General Public License
19 * along with this program. If not, see <http://www.gnu.org/licenses/>. 19 * and the GNU General Public License along with this program. If not, see
20 * <http://www.gnu.org/licenses/>.
20 * 21 *
21 * The authors can be reached via e-mail to <support@deliantra.net> 22 * The authors can be reached via e-mail to <support@deliantra.net>
22 */ 23 */
23 24
24#include <global.h> 25#include <global.h>
32#include <bitset> 33#include <bitset>
33 34
34UUID UUID::cur; 35UUID UUID::cur;
35static uint64_t seq_next_save; 36static uint64_t seq_next_save;
36static const uint64 UUID_GAP = 1<<19; 37static const uint64 UUID_GAP = 1<<19;
38uint32_t mapspace::smellcount = 10000;
37 39
38objectvec objects; 40objectvec objects;
39activevec actives; 41activevec actives;
40 42
41short freearr_x[SIZEOFFREE] = { 43short freearr_x[SIZEOFFREE] = {
139 141
140/* Returns TRUE if every key_values in wants has a partner with the same value in has. */ 142/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
141static bool 143static bool
142compare_ob_value_lists_one (const object *wants, const object *has) 144compare_ob_value_lists_one (const object *wants, const object *has)
143{ 145{
144 key_value *wants_field;
145
146 /* n-squared behaviour (see get_ob_key_link()), but I'm hoping both 146 /* n-squared behaviour (see kv_get), but I'm hoping both
147 * objects with lists are rare, and lists stay short. If not, use a 147 * objects with lists are rare, and lists stay short. If not, use a
148 * different structure or at least keep the lists sorted... 148 * different structure or at least keep the lists sorted...
149 */ 149 */
150 150
151 /* For each field in wants, */ 151 /* For each field in wants, */
152 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next) 152 for (key_value *kv = wants->key_values; kv; kv = kv->next)
153 { 153 if (has->kv_get (kv->key) != kv->value)
154 key_value *has_field; 154 return false;
155
156 /* Look for a field in has with the same key. */
157 has_field = get_ob_key_link (has, wants_field->key);
158
159 if (!has_field)
160 return 0; /* No field with that name. */
161
162 /* Found the matching field. */
163 if (has_field->value != wants_field->value)
164 return 0; /* Values don't match, so this half of the comparison is false. */
165
166 /* If we get here, we found a match. Now for the next field in wants. */
167 }
168 155
169 /* If we get here, every field in wants has a matching field in has. */ 156 /* If we get here, every field in wants has a matching field in has. */
170 return 1; 157 return true;
171} 158}
172 159
173/* Returns TRUE if ob1 has the same key_values as ob2. */ 160/* Returns TRUE if ob1 has the same key_values as ob2. */
174static bool 161static bool
175compare_ob_value_lists (const object *ob1, const object *ob2) 162compare_ob_value_lists (const object *ob1, const object *ob2)
176{ 163{
177 /* However, there may be fields in has which aren't partnered in wants, 164 /* However, there may be fields in has which aren't partnered in wants,
178 * so we need to run the comparison *twice*. :( 165 * so we need to run the comparison *twice*. :(
179 */ 166 */
180 return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1); 167 return compare_ob_value_lists_one (ob1, ob2)
168 && compare_ob_value_lists_one (ob2, ob1);
181} 169}
182 170
183/* Function examines the 2 objects given to it, and returns true if 171/* Function examines the 2 objects given to it, and returns true if
184 * they can be merged together. 172 * they can be merged together.
185 * 173 *
200 || ob1->speed != ob2->speed 188 || ob1->speed != ob2->speed
201 || ob1->value != ob2->value 189 || ob1->value != ob2->value
202 || ob1->name != ob2->name) 190 || ob1->name != ob2->name)
203 return 0; 191 return 0;
204 192
205 /* Do not merge objects if nrof would overflow. First part checks 193 /* Do not merge objects if nrof would overflow, assume nrof
206 * for unsigned overflow (2c), second part checks whether the result 194 * is always 0 .. 2**31-1 */
207 * would fit into a 32 bit signed int, which is often used to hold 195 if (ob1->nrof > 0x7fffffff - ob2->nrof)
208 * nrof values.
209 */
210 if (~ob1->nrof < ob2->nrof || ob1->nrof + ob2->nrof > (1UL << 31))
211 return 0; 196 return 0;
212 197
213 /* If the objects have been identified, set the BEEN_APPLIED flag. 198 /* If the objects have been identified, set the BEEN_APPLIED flag.
214 * This is to the comparison of the flags below will be OK. We 199 * This is to the comparison of the flags below will be OK. We
215 * just can't ignore the been applied or identified flags, as they 200 * just can't ignore the been applied or identified flags, as they
220 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 205 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
221 206
222 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 207 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
223 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 208 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
224 209
225 if (ob1->arch->name != ob2->arch->name 210 if (ob1->arch->archname != ob2->arch->archname
226 || ob1->name != ob2->name 211 || ob1->name != ob2->name
227 || ob1->title != ob2->title 212 || ob1->title != ob2->title
228 || ob1->msg != ob2->msg 213 || ob1->msg != ob2->msg
229 || ob1->weight != ob2->weight 214 || ob1->weight != ob2->weight
230 || ob1->attacktype != ob2->attacktype 215 || ob1->attacktype != ob2->attacktype
231 || ob1->magic != ob2->magic 216 || ob1->magic != ob2->magic
232 || ob1->slaying != ob2->slaying 217 || ob1->slaying != ob2->slaying
233 || ob1->skill != ob2->skill 218 || ob1->skill != ob2->skill
234 || ob1->value != ob2->value 219 || ob1->value != ob2->value
235 || ob1->animation_id != ob2->animation_id 220 || ob1->animation_id != ob2->animation_id
221 || (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependent on each other
236 || ob1->client_type != ob2->client_type 222 || ob1->client_type != ob2->client_type
237 || ob1->materialname != ob2->materialname 223 || ob1->materialname != ob2->materialname
238 || ob1->lore != ob2->lore 224 || ob1->lore != ob2->lore
239 || ob1->subtype != ob2->subtype 225 || ob1->subtype != ob2->subtype
240 || ob1->move_type != ob2->move_type 226 || ob1->move_type != ob2->move_type
248 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats))) 234 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
249 return 0; 235 return 0;
250 236
251 if ((ob1->flag ^ ob2->flag) 237 if ((ob1->flag ^ ob2->flag)
252 .reset (FLAG_INV_LOCKED) 238 .reset (FLAG_INV_LOCKED)
253 .reset (FLAG_CLIENT_SENT)
254 .reset (FLAG_REMOVED) 239 .reset (FLAG_REMOVED)
255 .any ()) 240 .any ())
256 return 0; 241 return 0;
257 242
258 /* This is really a spellbook check - we should in general 243 /* This is really a spellbook check - we should in general
340 { 325 {
341 // see if we are in a container of sorts 326 // see if we are in a container of sorts
342 if (env) 327 if (env)
343 { 328 {
344 // the player inventory itself is always visible 329 // the player inventory itself is always visible
345 if (env->type == PLAYER) 330 if (env->is_player ())
346 return env; 331 return env;
347 332
348 // else a player could have our env open 333 // else a player could have our env open
349 object *envest = env->outer_env (); 334 object *envest = env->outer_env_or_self ();
350 335
351 // the player itself is always on a map, so we will find him here 336 // the player itself is always on a map, so we will find him here
352 // even if our inv is in a player. 337 // even if our inv is in a player.
353 if (envest->is_on_map ()) 338 if (envest->is_on_map ())
354 if (object *pl = envest->ms ().player ()) 339 if (object *pl = envest->ms ().player ())
358 else 343 else
359 { 344 {
360 // maybe there is a player standing on the same mapspace 345 // maybe there is a player standing on the same mapspace
361 // this will catch the case where "this" is a player 346 // this will catch the case where "this" is a player
362 if (object *pl = ms ().player ()) 347 if (object *pl = ms ().player ())
348 if ((!pl->container && pl->contr->ns && !pl->contr->ns->update_look)
363 if (!pl->container || this == pl->container) 349 || this == pl->container)
364 return pl; 350 return pl;
365 } 351 }
366 } 352 }
367 353
368 return 0; 354 return 0;
369} 355}
370 356
371// adjust weight per container type ("of holding") 357// adjust weight per container type ("of holding")
372static sint32 358static sint32
373weight_adjust (object *op, sint32 weight) 359weight_adjust_for (object *op, sint32 weight)
374{ 360{
375 return op->type == CONTAINER 361 return op->type == CONTAINER
376 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str) 362 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str)
377 : weight; 363 : weight;
378} 364}
384static void 370static void
385adjust_weight (object *op, sint32 weight) 371adjust_weight (object *op, sint32 weight)
386{ 372{
387 while (op) 373 while (op)
388 { 374 {
375 // adjust by actual difference to account for rounding errors
376 // i.e. (w2 - w1) / f != w2 / f - w1 / f and the latter is correct
389 weight = weight_adjust (op, weight); 377 weight = weight_adjust_for (op, op->carrying)
378 - weight_adjust_for (op, op->carrying - weight);
390 379
391 if (!weight) 380 if (!weight)
392 return; 381 return;
393 382
394 op->carrying += weight; 383 op->carrying += weight;
417 op->update_weight (); 406 op->update_weight ();
418 407
419 sum += op->total_weight (); 408 sum += op->total_weight ();
420 } 409 }
421 410
422 sum = weight_adjust (this, sum); 411 sum = weight_adjust_for (this, sum);
423 412
424 if (sum != carrying) 413 if (sum != carrying)
425 { 414 {
426 carrying = sum; 415 carrying = sum;
427 416
441 return strdup ("[NULLOBJ]"); 430 return strdup ("[NULLOBJ]");
442 431
443 object_freezer freezer; 432 object_freezer freezer;
444 op->write (freezer); 433 op->write (freezer);
445 return freezer.as_string (); 434 return freezer.as_string ();
435}
436
437char *
438object::as_string ()
439{
440 return dump_object (this);
446} 441}
447 442
448/* 443/*
449 * get_nearest_part(multi-object, object 2) returns the part of the 444 * get_nearest_part(multi-object, object 2) returns the part of the
450 * multi-object 1 which is closest to the second object. 445 * multi-object 1 which is closest to the second object.
489 */ 484 */
490object * 485object *
491find_object_name (const char *str) 486find_object_name (const char *str)
492{ 487{
493 shstr_cmp str_ (str); 488 shstr_cmp str_ (str);
494 object *op;
495 489
490 if (str_)
496 for_all_objects (op) 491 for_all_objects (op)
497 if (op->name == str_) 492 if (op->name == str_)
498 break; 493 return op;
499 494
500 return op; 495 return 0;
501} 496}
502 497
503/* 498/*
504 * Sets the owner and sets the skill and exp pointers to owner's current 499 * Sets the owner and sets the skill and exp pointers to owner's current
505 * skill and experience objects. 500 * skill and experience objects.
567 update_stats (); 562 update_stats ();
568 563
569 new_draw_info_format (NDI_UNIQUE, 0, this, 564 new_draw_info_format (NDI_UNIQUE, 0, this,
570 "You try to balance all your items at once, " 565 "You try to balance all your items at once, "
571 "but the %s is just too much for your body. " 566 "but the %s is just too much for your body. "
572 "[You need to unapply some items first.]", &ob->name); 567 "[You need to unapply some items first - use the 'body' command to see "
568 "how many items you cna wera on a specific body part.]", &ob->name);
573 return false; 569 return false;
574 } 570 }
575 571
576 //new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name); 572 //new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name);
577 } 573 }
603 } 599 }
604 600
605 op->key_values = 0; 601 op->key_values = 0;
606} 602}
607 603
608object & 604/*
609object::operator =(const object &src) 605 * copy_to first frees everything allocated by the dst object,
606 * and then copies the contents of itself into the second
607 * object, allocating what needs to be allocated. Basically, any
608 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
609 * if the first object is freed, the pointers in the new object
610 * will point at garbage.
611 */
612void
613object::copy_to (object *dst)
610{ 614{
611 bool is_freed = flag [FLAG_FREED]; 615 dst->remove ();
612 bool is_removed = flag [FLAG_REMOVED];
613
614 *(object_copy *)this = src; 616 *(object_copy *)dst = *this;
615
616 flag [FLAG_FREED] = is_freed;
617 flag [FLAG_REMOVED] = is_removed; 617 dst->flag [FLAG_REMOVED] = true;
618 618
619 /* Copy over key_values, if any. */ 619 /* Copy over key_values, if any. */
620 if (src.key_values) 620 if (key_values)
621 { 621 {
622 key_value *tail = 0; 622 key_value *tail = 0;
623 key_values = 0; 623 dst->key_values = 0;
624 624
625 for (key_value *i = src.key_values; i; i = i->next) 625 for (key_value *i = key_values; i; i = i->next)
626 { 626 {
627 key_value *new_link = new key_value; 627 key_value *new_link = new key_value;
628 628
629 new_link->next = 0; 629 new_link->next = 0;
630 new_link->key = i->key; 630 new_link->key = i->key;
631 new_link->value = i->value; 631 new_link->value = i->value;
632 632
633 /* Try and be clever here, too. */ 633 /* Try and be clever here, too. */
634 if (!key_values) 634 if (!dst->key_values)
635 { 635 {
636 key_values = new_link; 636 dst->key_values = new_link;
637 tail = new_link; 637 tail = new_link;
638 } 638 }
639 else 639 else
640 { 640 {
641 tail->next = new_link; 641 tail->next = new_link;
642 tail = new_link; 642 tail = new_link;
643 } 643 }
644 } 644 }
645 } 645 }
646}
647
648/*
649 * copy_to first frees everything allocated by the dst object,
650 * and then copies the contents of itself into the second
651 * object, allocating what needs to be allocated. Basically, any
652 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
653 * if the first object is freed, the pointers in the new object
654 * will point at garbage.
655 */
656void
657object::copy_to (object *dst)
658{
659 *dst = *this;
660 646
661 if (speed < 0) 647 if (speed < 0)
662 dst->speed_left -= rndm (); 648 dst->speed_left -= rndm ();
663 649
664 dst->set_speed (dst->speed); 650 dst->activate ();
665} 651}
666 652
667void 653void
668object::instantiate () 654object::instantiate ()
669{ 655{
686object * 672object *
687object::clone () 673object::clone ()
688{ 674{
689 object *neu = create (); 675 object *neu = create ();
690 copy_to (neu); 676 copy_to (neu);
677 neu->map = map; // not copied by copy_to
691 return neu; 678 return neu;
692} 679}
693 680
694/* 681/*
695 * If an object with the IS_TURNABLE() flag needs to be turned due 682 * If an object with the IS_TURNABLE() flag needs to be turned due
780 else if (action == UP_OBJ_INSERT) 767 else if (action == UP_OBJ_INSERT)
781 { 768 {
782 // this is likely overkill, TODO: revisit (schmorp) 769 // this is likely overkill, TODO: revisit (schmorp)
783 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW)) 770 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
784 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC)) 771 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
785 || (op->type == PLAYER && !(m.flags_ & P_PLAYER)) 772 || (op->is_player () && !(m.flags_ & P_PLAYER))
786 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE)) 773 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
787 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE)) 774 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
788 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC)) 775 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
789 || (m.move_on | op->move_on ) != m.move_on 776 || (m.move_on | op->move_on ) != m.move_on
790 || (m.move_off | op->move_off ) != m.move_off 777 || (m.move_off | op->move_off ) != m.move_off
791 || (m.move_slow | op->move_slow) != m.move_slow 778 || (m.move_slow | op->move_slow) != m.move_slow
792 /* This isn't perfect, but I don't expect a lot of objects to 779 /* This isn't perfect, but I don't expect a lot of objects to
793 * to have move_allow right now. 780 * have move_allow right now.
794 */ 781 */
795 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block 782 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
796 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp) 783 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
797 m.flags_ = 0; 784 m.invalidate ();
798 } 785 }
799 /* if the object is being removed, we can't make intelligent 786 /* if the object is being removed, we can't make intelligent
800 * decisions, because remove_ob can't really pass the object 787 * decisions, because remove_ob can't really pass the object
801 * that is being removed. 788 * that is being removed.
802 */ 789 */
803 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 790 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
804 m.flags_ = 0; 791 m.invalidate ();
805 else if (action == UP_OBJ_FACE) 792 else if (action == UP_OBJ_FACE)
806 /* Nothing to do for that case */ ; 793 /* Nothing to do for that case */ ;
807 else 794 else
808 LOG (llevError, "update_object called with invalid action: %d\n", action); 795 LOG (llevError, "update_object called with invalid action: %d\n", action);
809 796
813 800
814object::object () 801object::object ()
815{ 802{
816 SET_FLAG (this, FLAG_REMOVED); 803 SET_FLAG (this, FLAG_REMOVED);
817 804
818 expmul = 1.0; 805 //expmul = 1.0; declared const for the time being
819 face = blank_face; 806 face = blank_face;
820} 807}
821 808
822object::~object () 809object::~object ()
823{ 810{
853 /* If already on active list, don't do anything */ 840 /* If already on active list, don't do anything */
854 if (active) 841 if (active)
855 return; 842 return;
856 843
857 if (has_active_speed ()) 844 if (has_active_speed ())
845 {
846 if (flag [FLAG_FREED])
847 LOG (llevError | logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
848
858 actives.insert (this); 849 actives.insert (this);
850 }
859} 851}
860 852
861void 853void
862object::activate_recursive () 854object::activate_recursive ()
863{ 855{
924 * drop on that space. 916 * drop on that space.
925 */ 917 */
926 if (!drop_to_ground 918 if (!drop_to_ground
927 || !map 919 || !map
928 || map->in_memory != MAP_ACTIVE 920 || map->in_memory != MAP_ACTIVE
929 || map->nodrop 921 || map->no_drop
930 || ms ().move_block == MOVE_ALL) 922 || ms ().move_block == MOVE_ALL)
931 { 923 {
932 while (inv) 924 while (inv)
933 {
934 inv->destroy_inv (false);
935 inv->destroy (); 925 inv->destroy ();
936 }
937 } 926 }
938 else 927 else
939 { /* Put objects in inventory onto this space */ 928 { /* Put objects in inventory onto this space */
940 while (inv) 929 while (inv)
941 { 930 {
945 || op->flag [FLAG_NO_DROP] 934 || op->flag [FLAG_NO_DROP]
946 || op->type == RUNE 935 || op->type == RUNE
947 || op->type == TRAP 936 || op->type == TRAP
948 || op->flag [FLAG_IS_A_TEMPLATE] 937 || op->flag [FLAG_IS_A_TEMPLATE]
949 || op->flag [FLAG_DESTROY_ON_DEATH]) 938 || op->flag [FLAG_DESTROY_ON_DEATH])
950 op->destroy (true); 939 op->destroy ();
951 else 940 else
952 map->insert (op, x, y); 941 map->insert (op, x, y);
953 } 942 }
954 } 943 }
955} 944}
963 952
964static struct freed_map : maptile 953static struct freed_map : maptile
965{ 954{
966 freed_map () 955 freed_map ()
967 { 956 {
968 path = "<freed objects map>"; 957 path = "<freed objects map>";
969 name = "/internal/freed_objects_map"; 958 name = "/internal/freed_objects_map";
970 width = 3; 959 width = 3;
971 height = 3; 960 height = 3;
972 nodrop = 1; 961 no_drop = 1;
962 no_reset = 1;
973 963
974 alloc (); 964 alloc ();
975 in_memory = MAP_ACTIVE; 965 in_memory = MAP_ACTIVE;
976 } 966 }
967
968 ~freed_map ()
969 {
970 destroy ();
971 }
977} freed_map; // freed objects are moved here to avoid crashes 972} freed_map; // freed objects are moved here to avoid crashes
978 973
979void 974void
980object::do_destroy () 975object::do_destroy ()
981{ 976{
982 if (flag [FLAG_IS_LINKED]) 977 if (flag [FLAG_IS_LINKED])
983 remove_button_link (this); 978 remove_link ();
984 979
985 if (flag [FLAG_FRIENDLY]) 980 if (flag [FLAG_FRIENDLY])
986 remove_friendly_object (this); 981 remove_friendly_object (this);
987 982
988 remove (); 983 remove ();
1013 attacked_by = 0; 1008 attacked_by = 0;
1014 current_weapon = 0; 1009 current_weapon = 0;
1015} 1010}
1016 1011
1017void 1012void
1018object::destroy (bool destroy_inventory) 1013object::destroy ()
1019{ 1014{
1020 if (destroyed ()) 1015 if (destroyed ())
1021 return; 1016 return;
1022 1017
1023 if (!is_head () && !head->destroyed ()) 1018 if (!is_head () && !head->destroyed ())
1024 { 1019 {
1025 LOG (llevError | logBacktrace, "tried to destroy the tail of an object"); 1020 LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
1026 head->destroy (destroy_inventory); 1021 head->destroy ();
1027 return; 1022 return;
1028 } 1023 }
1029 1024
1030 destroy_inv (!destroy_inventory); 1025 destroy_inv (false);
1031 1026
1032 if (is_head ()) 1027 if (is_head ())
1033 if (sound_destroy) 1028 if (sound_destroy)
1034 play_sound (sound_destroy); 1029 play_sound (sound_destroy);
1035 else if (flag [FLAG_MONSTER]) 1030 else if (flag [FLAG_MONSTER])
1072 esrv_del_item (pl->contr, count); 1067 esrv_del_item (pl->contr, count);
1073 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed 1068 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
1074 1069
1075 adjust_weight (env, -total_weight ()); 1070 adjust_weight (env, -total_weight ());
1076 1071
1077 *(above ? &above->below : &env->inv) = below; 1072 object *pl = in_player ();
1078
1079 if (below)
1080 below->above = above;
1081 1073
1082 /* we set up values so that it could be inserted into 1074 /* we set up values so that it could be inserted into
1083 * the map, but we don't actually do that - it is up 1075 * the map, but we don't actually do that - it is up
1084 * to the caller to decide what we want to do. 1076 * to the caller to decide what we want to do.
1085 */ 1077 */
1086 map = env->map; 1078 map = env->map;
1087 x = env->x; 1079 x = env->x;
1088 y = env->y; 1080 y = env->y;
1081
1082 // make sure cmov optimisation is applicable
1083 *(above ? &above->below : &env->inv) = below;
1084 *(below ? &below->above : &above ) = above; // &above is just a dummy
1085
1089 above = 0; 1086 above = 0;
1090 below = 0; 1087 below = 0;
1091 env = 0; 1088 env = 0;
1092 1089
1093 /* NO_FIX_PLAYER is set when a great many changes are being 1090 /* NO_FIX_PLAYER is set when a great many changes are being
1094 * made to players inventory. If set, avoiding the call 1091 * made to players inventory. If set, avoiding the call
1095 * to save cpu time. 1092 * to save cpu time.
1096 */ 1093 */
1097 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1094 if (pl)
1095 if (pl->is_player () && (glow_radius || !QUERY_FLAG (pl, FLAG_NO_FIX_PLAYER)))
1096 {
1098 otmp->update_stats (); 1097 pl->update_stats ();
1098
1099 if (glow_radius && pl->is_on_map ())
1100 update_all_los (pl->map, pl->x, pl->y);
1101 }
1099 } 1102 }
1100 else if (map) 1103 else if (map)
1101 { 1104 {
1102 map->dirty = true; 1105 map->dirty = true;
1103 mapspace &ms = this->ms (); 1106 mapspace &ms = this->ms ();
1104 1107
1105 if (object *pl = ms.player ()) 1108 if (object *pl = ms.player ())
1106 { 1109 {
1107 if (type == PLAYER) // this == pl(!) 1110 if (is_player ())
1108 { 1111 {
1112 if (!flag [FLAG_WIZPASS])
1113 ms.smell = ++mapspace::smellcount; // remember the smell of the player
1114
1109 // leaving a spot always closes any open container on the ground 1115 // leaving a spot always closes any open container on the ground
1110 if (container && !container->env) 1116 if (container && !container->env)
1111 // this causes spurious floorbox updates, but it ensures 1117 // this causes spurious floorbox updates, but it ensures
1112 // that the CLOSE event is being sent. 1118 // that the CLOSE event is being sent.
1113 close_container (); 1119 close_container ();
1123 1129
1124 esrv_del_item (pl->contr, count); 1130 esrv_del_item (pl->contr, count);
1125 } 1131 }
1126 1132
1127 /* link the object above us */ 1133 /* link the object above us */
1128 if (above) 1134 // re-link, make sure compiler can easily use cmove
1129 above->below = below; 1135 *(above ? &above->below : &ms.top) = below;
1130 else 1136 *(below ? &below->above : &ms.bot) = above;
1131 ms.top = below; /* we were top, set new top */
1132
1133 /* Relink the object below us, if there is one */
1134 if (below)
1135 below->above = above;
1136 else
1137 {
1138 /* Nothing below, which means we need to relink map object for this space
1139 * use translated coordinates in case some oddness with map tiling is
1140 * evident
1141 */
1142 if (GET_MAP_OB (map, x, y) != this)
1143 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1144
1145 ms.bot = above; /* goes on above it. */
1146 }
1147 1137
1148 above = 0; 1138 above = 0;
1149 below = 0; 1139 below = 0;
1140
1141 ms.invalidate ();
1150 1142
1151 if (map->in_memory == MAP_SAVING) 1143 if (map->in_memory == MAP_SAVING)
1152 return; 1144 return;
1153 1145
1154 int check_walk_off = !flag [FLAG_NO_APPLY]; 1146 int check_walk_off = !flag [FLAG_NO_APPLY];
1161 * appropriately. 1153 * appropriately.
1162 */ 1154 */
1163 pl->close_container (); 1155 pl->close_container ();
1164 1156
1165 //TODO: the floorbox prev/next might need updating 1157 //TODO: the floorbox prev/next might need updating
1166 esrv_del_item (pl->contr, count); 1158 //esrv_del_item (pl->contr, count);
1159 //TODO: update floorbox to preserve ordering
1160 if (pl->contr->ns)
1161 pl->contr->ns->floorbox_update ();
1167 } 1162 }
1168 1163
1169 for (tmp = ms.bot; tmp; tmp = tmp->above) 1164 for (tmp = ms.bot; tmp; tmp = tmp->above)
1170 { 1165 {
1171 /* No point updating the players look faces if he is the object 1166 /* No point updating the players look faces if he is the object
1184 } 1179 }
1185 1180
1186 last = tmp; 1181 last = tmp;
1187 } 1182 }
1188 1183
1189 /* last == NULL if there are no objects on this space */ 1184 if (affects_los ())
1190 //TODO: this makes little sense, why only update the topmost object?
1191 if (!last)
1192 map->at (x, y).flags_ = 0;
1193 else
1194 update_object (last, UP_OBJ_REMOVE);
1195
1196 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1197 update_all_los (map, x, y); 1185 update_all_los (map, x, y);
1198 } 1186 }
1199} 1187}
1200 1188
1201/* 1189/*
1225 esrv_update_item (UPD_NROF, pl, top); 1213 esrv_update_item (UPD_NROF, pl, top);
1226 1214
1227 op->weight = 0; // cancel the addition above 1215 op->weight = 0; // cancel the addition above
1228 op->carrying = 0; // must be 0 already 1216 op->carrying = 0; // must be 0 already
1229 1217
1230 op->destroy (1); 1218 op->destroy ();
1231 1219
1232 return top; 1220 return top;
1233 } 1221 }
1234 1222
1235 return 0; 1223 return 0;
1263 * job preparing multi-part monsters. 1251 * job preparing multi-part monsters.
1264 */ 1252 */
1265object * 1253object *
1266insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1254insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1267{ 1255{
1256 op->remove ();
1257
1268 for (object *tmp = op->head_ (); tmp; tmp = tmp->more) 1258 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1269 { 1259 {
1270 tmp->x = x + tmp->arch->x; 1260 tmp->x = x + tmp->arch->x;
1271 tmp->y = y + tmp->arch->y; 1261 tmp->y = y + tmp->arch->y;
1272 } 1262 }
1295 * just 'op' otherwise 1285 * just 'op' otherwise
1296 */ 1286 */
1297object * 1287object *
1298insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1288insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1299{ 1289{
1300 assert (!op->flag [FLAG_FREED]);
1301
1302 op->remove (); 1290 op->remove ();
1291
1292 if (m == &freed_map)//D TODO: remove soon
1293 {//D
1294 LOG (llevError | logBacktrace, "tries to insret object on freed objects map: %s", op->debug_desc ());//D
1295 }//D
1303 1296
1304 /* Ideally, the caller figures this out. However, it complicates a lot 1297 /* Ideally, the caller figures this out. However, it complicates a lot
1305 * of areas of callers (eg, anything that uses find_free_spot would now 1298 * of areas of callers (eg, anything that uses find_free_spot would now
1306 * need extra work 1299 * need extra work
1307 */ 1300 */
1301 maptile *newmap = m;
1308 if (!xy_normalise (m, op->x, op->y)) 1302 if (!xy_normalise (newmap, op->x, op->y))
1309 { 1303 {
1310 op->destroy (1); 1304 op->head_ ()->destroy ();// remove head_ once all tail object destroyers found
1311 return 0; 1305 return 0;
1312 } 1306 }
1313 1307
1314 if (object *more = op->more) 1308 if (object *more = op->more)
1315 if (!insert_ob_in_map (more, m, originator, flag)) 1309 if (!insert_ob_in_map (more, m, originator, flag))
1316 return 0; 1310 return 0;
1317 1311
1318 CLEAR_FLAG (op, FLAG_REMOVED); 1312 op->flag [FLAG_REMOVED] = false;
1319 1313 op->env = 0;
1320 op->map = m; 1314 op->map = newmap;
1315
1321 mapspace &ms = op->ms (); 1316 mapspace &ms = op->ms ();
1322 1317
1323 /* this has to be done after we translate the coordinates. 1318 /* this has to be done after we translate the coordinates.
1324 */ 1319 */
1325 if (op->nrof && !(flag & INS_NO_MERGE)) 1320 if (op->nrof && !(flag & INS_NO_MERGE))
1326 for (object *tmp = ms.bot; tmp; tmp = tmp->above) 1321 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1327 if (object::can_merge (op, tmp)) 1322 if (object::can_merge (op, tmp))
1328 { 1323 {
1329 // TODO: we atcually want to update tmp, not op, 1324 // TODO: we actually want to update tmp, not op,
1330 // but some caller surely breaks when we return tmp 1325 // but some caller surely breaks when we return tmp
1331 // from here :/ 1326 // from here :/
1332 op->nrof += tmp->nrof; 1327 op->nrof += tmp->nrof;
1333 tmp->destroy (1); 1328 tmp->destroy ();
1334 } 1329 }
1335 1330
1336 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1331 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1337 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1332 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1338 1333
1345 { 1340 {
1346 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n"); 1341 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1347 abort (); 1342 abort ();
1348 } 1343 }
1349 1344
1345 if (!originator->is_on_map ())
1346 {
1347 LOG (llevError, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
1348 op->debug_desc (), originator->debug_desc ());
1349 abort ();
1350 }
1351
1350 op->above = originator; 1352 op->above = originator;
1351 op->below = originator->below; 1353 op->below = originator->below;
1352
1353 if (op->below)
1354 op->below->above = op;
1355 else
1356 ms.bot = op;
1357
1358 /* since *below* originator, no need to update top */
1359 originator->below = op; 1354 originator->below = op;
1355
1356 *(op->below ? &op->below->above : &ms.bot) = op;
1360 } 1357 }
1361 else 1358 else
1362 { 1359 {
1363 object *top, *floor = NULL; 1360 object *floor = 0;
1364 1361 object *top = ms.top;
1365 top = ms.bot;
1366 1362
1367 /* If there are other objects, then */ 1363 /* If there are other objects, then */
1368 if (top) 1364 if (top)
1369 { 1365 {
1370 object *last = 0;
1371
1372 /* 1366 /*
1373 * If there are multiple objects on this space, we do some trickier handling. 1367 * If there are multiple objects on this space, we do some trickier handling.
1374 * We've already dealt with merging if appropriate. 1368 * We've already dealt with merging if appropriate.
1375 * Generally, we want to put the new object on top. But if 1369 * Generally, we want to put the new object on top. But if
1376 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last 1370 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
1379 * once we get to them. This reduces the need to traverse over all of 1373 * once we get to them. This reduces the need to traverse over all of
1380 * them when adding another one - this saves quite a bit of cpu time 1374 * them when adding another one - this saves quite a bit of cpu time
1381 * when lots of spells are cast in one area. Currently, it is presumed 1375 * when lots of spells are cast in one area. Currently, it is presumed
1382 * that flying non pickable objects are spell objects. 1376 * that flying non pickable objects are spell objects.
1383 */ 1377 */
1384 for (top = ms.bot; top; top = top->above) 1378 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1385 { 1379 {
1386 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1380 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) || QUERY_FLAG (tmp, FLAG_OVERLAY_FLOOR))
1387 floor = top; 1381 floor = tmp;
1388 1382
1389 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1383 if (QUERY_FLAG (tmp, FLAG_NO_PICK) && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (tmp, FLAG_IS_FLOOR))
1390 { 1384 {
1391 /* We insert above top, so we want this object below this */ 1385 /* We insert above top, so we want this object below this */
1392 top = top->below; 1386 top = tmp->below;
1393 break; 1387 break;
1394 } 1388 }
1395 1389
1396 last = top; 1390 top = tmp;
1397 } 1391 }
1398
1399 /* Don't want top to be NULL, so set it to the last valid object */
1400 top = last;
1401 1392
1402 /* We let update_position deal with figuring out what the space 1393 /* We let update_position deal with figuring out what the space
1403 * looks like instead of lots of conditions here. 1394 * looks like instead of lots of conditions here.
1404 * makes things faster, and effectively the same result. 1395 * makes things faster, and effectively the same result.
1405 */ 1396 */
1412 */ 1403 */
1413 if (!(flag & INS_ON_TOP) 1404 if (!(flag & INS_ON_TOP)
1414 && ms.flags () & P_BLOCKSVIEW 1405 && ms.flags () & P_BLOCKSVIEW
1415 && (op->face && !faces [op->face].visibility)) 1406 && (op->face && !faces [op->face].visibility))
1416 { 1407 {
1408 object *last;
1409
1417 for (last = top; last != floor; last = last->below) 1410 for (last = top; last != floor; last = last->below)
1418 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1411 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1419 break; 1412 break;
1420 1413
1421 /* Check to see if we found the object that blocks view, 1414 /* Check to see if we found the object that blocks view,
1429 } /* If objects on this space */ 1422 } /* If objects on this space */
1430 1423
1431 if (flag & INS_ABOVE_FLOOR_ONLY) 1424 if (flag & INS_ABOVE_FLOOR_ONLY)
1432 top = floor; 1425 top = floor;
1433 1426
1434 /* Top is the object that our object (op) is going to get inserted above. 1427 // insert object above top, or bottom-most if top = 0
1435 */
1436
1437 /* First object on this space */
1438 if (!top) 1428 if (!top)
1439 { 1429 {
1430 op->below = 0;
1440 op->above = ms.bot; 1431 op->above = ms.bot;
1441
1442 if (op->above)
1443 op->above->below = op;
1444
1445 op->below = 0;
1446 ms.bot = op; 1432 ms.bot = op;
1433
1434 *(op->above ? &op->above->below : &ms.top) = op;
1447 } 1435 }
1448 else 1436 else
1449 { /* get inserted into the stack above top */ 1437 {
1450 op->above = top->above; 1438 op->above = top->above;
1451
1452 if (op->above)
1453 op->above->below = op; 1439 top->above = op;
1454 1440
1455 op->below = top; 1441 op->below = top;
1456 top->above = op; 1442 *(op->above ? &op->above->below : &ms.top) = op;
1457 } 1443 }
1444 }
1458 1445
1459 if (!op->above) 1446 if (op->is_player ())
1460 ms.top = op;
1461 } /* else not INS_BELOW_ORIGINATOR */
1462
1463 if (op->type == PLAYER)
1464 { 1447 {
1465 op->contr->do_los = 1; 1448 op->contr->do_los = 1;
1466 ++op->map->players; 1449 ++op->map->players;
1467 op->map->touch (); 1450 op->map->touch ();
1468 } 1451 }
1469 1452
1470 op->map->dirty = true; 1453 op->map->dirty = true;
1471 1454
1472 if (object *pl = ms.player ()) 1455 if (object *pl = ms.player ())
1473 //TODO: the floorbox prev/next might need updating 1456 //TODO: the floorbox prev/next might need updating
1474 esrv_send_item (pl, op); 1457 //esrv_send_item (pl, op);
1458 //TODO: update floorbox to preserve ordering
1459 if (pl->contr->ns)
1460 pl->contr->ns->floorbox_update ();
1475 1461
1476 /* If this object glows, it may affect lighting conditions that are 1462 /* If this object glows, it may affect lighting conditions that are
1477 * visible to others on this map. But update_all_los is really 1463 * visible to others on this map. But update_all_los is really
1478 * an inefficient way to do this, as it means los for all players 1464 * an inefficient way to do this, as it means los for all players
1479 * on the map will get recalculated. The players could very well 1465 * on the map will get recalculated. The players could very well
1480 * be far away from this change and not affected in any way - 1466 * be far away from this change and not affected in any way -
1481 * this should get redone to only look for players within range, 1467 * this should get redone to only look for players within range,
1482 * or just updating the P_UPTODATE for spaces within this area 1468 * or just updating the P_UPTODATE for spaces within this area
1483 * of effect may be sufficient. 1469 * of effect may be sufficient.
1484 */ 1470 */
1485 if (op->map->darkness && (op->glow_radius != 0)) 1471 if (op->affects_los ())
1472 {
1473 op->ms ().invalidate ();
1486 update_all_los (op->map, op->x, op->y); 1474 update_all_los (op->map, op->x, op->y);
1475 }
1487 1476
1488 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1477 /* updates flags (blocked, alive, no magic, etc) for this map space */
1489 update_object (op, UP_OBJ_INSERT); 1478 update_object (op, UP_OBJ_INSERT);
1490 1479
1491 INVOKE_OBJECT (INSERT, op); 1480 INVOKE_OBJECT (INSERT, op);
1498 * blocked() and wall() work properly), and these flags are updated by 1487 * blocked() and wall() work properly), and these flags are updated by
1499 * update_object(). 1488 * update_object().
1500 */ 1489 */
1501 1490
1502 /* if this is not the head or flag has been passed, don't check walk on status */ 1491 /* if this is not the head or flag has been passed, don't check walk on status */
1503 if (!(flag & INS_NO_WALK_ON) && op->head_ () == op) 1492 if (!(flag & INS_NO_WALK_ON) && op->is_head ())
1504 { 1493 {
1505 if (check_move_on (op, originator)) 1494 if (check_move_on (op, originator))
1506 return 0; 1495 return 0;
1507 1496
1508 /* If we are a multi part object, lets work our way through the check 1497 /* If we are a multi part object, lets work our way through the check
1519/* this function inserts an object in the map, but if it 1508/* this function inserts an object in the map, but if it
1520 * finds an object of its own type, it'll remove that one first. 1509 * finds an object of its own type, it'll remove that one first.
1521 * op is the object to insert it under: supplies x and the map. 1510 * op is the object to insert it under: supplies x and the map.
1522 */ 1511 */
1523void 1512void
1524replace_insert_ob_in_map (const char *arch_string, object *op) 1513replace_insert_ob_in_map (shstr_tmp archname, object *op)
1525{ 1514{
1526 /* first search for itself and remove any old instances */ 1515 /* first search for itself and remove any old instances */
1527 1516
1528 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above) 1517 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1529 if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */ 1518 if (tmp->arch->archname == archname) /* same archetype */
1530 tmp->destroy (1); 1519 tmp->destroy ();
1531 1520
1532 object *tmp = arch_to_object (archetype::find (arch_string)); 1521 object *tmp = arch_to_object (archetype::find (archname));
1533 1522
1534 tmp->x = op->x; 1523 tmp->x = op->x;
1535 tmp->y = op->y; 1524 tmp->y = op->y;
1536 1525
1537 insert_ob_in_map (tmp, op->map, op, 0); 1526 insert_ob_in_map (tmp, op->map, op, 0);
1559 if (!nr) 1548 if (!nr)
1560 return true; 1549 return true;
1561 1550
1562 nr = min (nr, nrof); 1551 nr = min (nr, nrof);
1563 1552
1553 if (nrof > nr)
1554 {
1564 nrof -= nr; 1555 nrof -= nr;
1565
1566 if (nrof)
1567 {
1568 adjust_weight (env, -weight * nr); // carrying == 0 1556 adjust_weight (env, -weight * max (1, nr)); // carrying == 0
1569 1557
1570 if (object *pl = visible_to ()) 1558 if (object *pl = visible_to ())
1571 esrv_update_item (UPD_NROF, pl, this); 1559 esrv_update_item (UPD_NROF, pl, this);
1572 1560
1573 return true; 1561 return true;
1574 } 1562 }
1575 else 1563 else
1576 { 1564 {
1577 destroy (1); 1565 destroy ();
1578 return false; 1566 return false;
1579 } 1567 }
1580} 1568}
1581 1569
1582/* 1570/*
1599 } 1587 }
1600 else 1588 else
1601 { 1589 {
1602 decrease (nr); 1590 decrease (nr);
1603 1591
1604 object *op = object_create_clone (this); 1592 object *op = deep_clone ();
1605 op->nrof = nr; 1593 op->nrof = nr;
1606 return op; 1594 return op;
1607 } 1595 }
1608} 1596}
1609 1597
1659 if (object *pl = tmp->visible_to ()) 1647 if (object *pl = tmp->visible_to ())
1660 esrv_update_item (UPD_NROF, pl, tmp); 1648 esrv_update_item (UPD_NROF, pl, tmp);
1661 1649
1662 adjust_weight (this, op->total_weight ()); 1650 adjust_weight (this, op->total_weight ());
1663 1651
1664 op->destroy (1); 1652 op->destroy ();
1665 op = tmp; 1653 op = tmp;
1666 goto inserted; 1654 goto inserted;
1667 } 1655 }
1668 1656
1669 op->owner = 0; // it's his/hers now. period. 1657 op->owner = 0; // it's his/hers now. period.
1687 1675
1688 adjust_weight (this, op->total_weight ()); 1676 adjust_weight (this, op->total_weight ());
1689 1677
1690inserted: 1678inserted:
1691 /* reset the light list and los of the players on the map */ 1679 /* reset the light list and los of the players on the map */
1692 if (op->glow_radius && map && map->darkness) 1680 if (op->glow_radius && is_on_map ())
1681 {
1682 update_stats ();
1693 update_all_los (map, x, y); 1683 update_all_los (map, x, y);
1694 1684 }
1685 else if (is_player () && !flag [FLAG_NO_FIX_PLAYER])
1695 // if this is a player's inventory, update stats 1686 // if this is a player's inventory, update stats
1696 if (type == PLAYER && !flag [FLAG_NO_FIX_PLAYER])
1697 update_stats (); 1687 update_stats ();
1698 1688
1699 INVOKE_OBJECT (INSERT, this); 1689 INVOKE_OBJECT (INSERT, this);
1700 1690
1701 return op; 1691 return op;
1722 * on top. 1712 * on top.
1723 */ 1713 */
1724int 1714int
1725check_move_on (object *op, object *originator) 1715check_move_on (object *op, object *originator)
1726{ 1716{
1717 if (QUERY_FLAG (op, FLAG_NO_APPLY))
1718 return 0;
1719
1727 object *tmp; 1720 object *tmp;
1728 maptile *m = op->map; 1721 maptile *m = op->map;
1729 int x = op->x, y = op->y; 1722 int x = op->x, y = op->y;
1730 1723
1731 MoveType move_on, move_slow, move_block; 1724 mapspace &ms = m->at (x, y);
1732 1725
1733 if (QUERY_FLAG (op, FLAG_NO_APPLY)) 1726 ms.update ();
1734 return 0;
1735 1727
1736 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y); 1728 MoveType move_on = ms.move_on;
1737 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y); 1729 MoveType move_slow = ms.move_slow;
1738 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y); 1730 MoveType move_block = ms.move_block;
1739 1731
1740 /* if nothing on this space will slow op down or be applied, 1732 /* if nothing on this space will slow op down or be applied,
1741 * no need to do checking below. have to make sure move_type 1733 * no need to do checking below. have to make sure move_type
1742 * is set, as lots of objects don't have it set - we treat that 1734 * is set, as lots of objects don't have it set - we treat that
1743 * as walking. 1735 * as walking.
1754 return 0; 1746 return 0;
1755 1747
1756 /* The objects have to be checked from top to bottom. 1748 /* The objects have to be checked from top to bottom.
1757 * Hence, we first go to the top: 1749 * Hence, we first go to the top:
1758 */ 1750 */
1759 1751 for (object *next, *tmp = ms.top; tmp; tmp = next)
1760 for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1761 {
1762 /* Trim the search when we find the first other spell effect
1763 * this helps performance so that if a space has 50 spell objects,
1764 * we don't need to check all of them.
1765 */
1766 if ((tmp->move_type & MOVE_FLY_LOW) && QUERY_FLAG (tmp, FLAG_NO_PICK))
1767 break;
1768 } 1752 {
1753 next = tmp->below;
1769 1754
1770 for (; tmp; tmp = tmp->below)
1771 {
1772 if (tmp == op) 1755 if (tmp == op)
1773 continue; /* Can't apply yourself */ 1756 continue; /* Can't apply yourself */
1774 1757
1775 /* Check to see if one of the movement types should be slowed down. 1758 /* Check to see if one of the movement types should be slowed down.
1776 * Second check makes sure that the movement types not being slowed 1759 * Second check makes sure that the movement types not being slowed
1781 if (!QUERY_FLAG (op, FLAG_WIZPASS)) 1764 if (!QUERY_FLAG (op, FLAG_WIZPASS))
1782 { 1765 {
1783 if ((!op->move_type && tmp->move_slow & MOVE_WALK) || 1766 if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
1784 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0)) 1767 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
1785 { 1768 {
1786
1787 float
1788 diff = tmp->move_slow_penalty * fabs (op->speed); 1769 float diff = tmp->move_slow_penalty * fabs (op->speed);
1789 1770
1790 if (op->type == PLAYER) 1771 if (op->is_player ())
1791 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) || 1772 if ((tmp->flag [FLAG_IS_HILLY ] && find_skill_by_number (op, SK_CLIMBING)) ||
1792 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN))) 1773 (tmp->flag [FLAG_IS_WOODED] && find_skill_by_number (op, SK_WOODSMAN)))
1793 diff /= 4.0; 1774 diff /= 4.0;
1794 1775
1795 op->speed_left -= diff; 1776 op->speed_left -= diff;
1796 } 1777 }
1797 } 1778 }
1830 LOG (llevError, "Present_arch called outside map.\n"); 1811 LOG (llevError, "Present_arch called outside map.\n");
1831 return NULL; 1812 return NULL;
1832 } 1813 }
1833 1814
1834 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above) 1815 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1835 if (tmp->arch == at) 1816 if (tmp->arch->archname == at->archname)
1836 return tmp; 1817 return tmp;
1837 1818
1838 return NULL; 1819 return NULL;
1839} 1820}
1840 1821
1904 * The first matching object is returned, or NULL if none. 1885 * The first matching object is returned, or NULL if none.
1905 */ 1886 */
1906object * 1887object *
1907present_arch_in_ob (const archetype *at, const object *op) 1888present_arch_in_ob (const archetype *at, const object *op)
1908{ 1889{
1909 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below) 1890 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1910 if (tmp->arch == at) 1891 if (tmp->arch->archname == at->archname)
1911 return tmp; 1892 return tmp;
1912 1893
1913 return NULL; 1894 return NULL;
1914} 1895}
1915 1896
2003 * head of the object should correspond for the entire object. 1984 * head of the object should correspond for the entire object.
2004 */ 1985 */
2005 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block)) 1986 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))
2006 continue; 1987 continue;
2007 1988
2008 if (ob->blocked (m, pos.x, pos.y)) 1989 if (ob->blocked (pos.m, pos.x, pos.y))
2009 continue; 1990 continue;
2010 1991
2011 altern [index++] = i; 1992 altern [index++] = i;
2012 } 1993 }
2013 1994
2081 * there is capable of. 2062 * there is capable of.
2082 */ 2063 */
2083int 2064int
2084find_dir (maptile *m, int x, int y, object *exclude) 2065find_dir (maptile *m, int x, int y, object *exclude)
2085{ 2066{
2086 int i, max = SIZEOFFREE, mflags; 2067 int max = SIZEOFFREE, mflags;
2087
2088 sint16 nx, ny;
2089 object *tmp;
2090 maptile *mp;
2091
2092 MoveType blocked, move_type; 2068 MoveType move_type;
2093 2069
2094 if (exclude && exclude->head_ () != exclude) 2070 if (exclude && exclude->head_ () != exclude)
2095 { 2071 {
2096 exclude = exclude->head; 2072 exclude = exclude->head;
2097 move_type = exclude->move_type; 2073 move_type = exclude->move_type;
2100 { 2076 {
2101 /* If we don't have anything, presume it can use all movement types. */ 2077 /* If we don't have anything, presume it can use all movement types. */
2102 move_type = MOVE_ALL; 2078 move_type = MOVE_ALL;
2103 } 2079 }
2104 2080
2105 for (i = 1; i < max; i++) 2081 for (int i = 1; i < max; i++)
2106 { 2082 {
2107 mp = m; 2083 mapxy pos (m, x, y);
2108 nx = x + freearr_x[i]; 2084 pos.move (i);
2109 ny = y + freearr_y[i];
2110 2085
2111 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2086 if (!pos.normalise ())
2112
2113 if (mflags & P_OUT_OF_MAP)
2114 max = maxfree[i]; 2087 max = maxfree[i];
2115 else 2088 else
2116 { 2089 {
2117 mapspace &ms = mp->at (nx, ny); 2090 mapspace &ms = *pos;
2118 2091
2119 blocked = ms.move_block;
2120
2121 if ((move_type & blocked) == move_type) 2092 if ((move_type & ms.move_block) == move_type)
2122 max = maxfree[i]; 2093 max = maxfree [i];
2123 else if (mflags & P_IS_ALIVE) 2094 else if (ms.flags () & P_IS_ALIVE)
2124 { 2095 {
2125 for (tmp = ms.bot; tmp; tmp = tmp->above) 2096 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
2126 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER) 2097 if ((tmp->flag [FLAG_MONSTER] || tmp->is_player ())
2127 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude))) 2098 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))
2128 break;
2129
2130 if (tmp)
2131 return freedir[i]; 2099 return freedir [i];
2132 } 2100 }
2133 } 2101 }
2134 } 2102 }
2135 2103
2136 return 0; 2104 return 0;
2211 * This basically means that if direction is 15, then it could either go 2179 * This basically means that if direction is 15, then it could either go
2212 * direction 4, 14, or 16 to get back to where we are. 2180 * direction 4, 14, or 16 to get back to where we are.
2213 * Moved from spell_util.c to object.c with the other related direction 2181 * Moved from spell_util.c to object.c with the other related direction
2214 * functions. 2182 * functions.
2215 */ 2183 */
2216int reduction_dir[SIZEOFFREE][3] = { 2184const int reduction_dir[SIZEOFFREE][3] = {
2217 {0, 0, 0}, /* 0 */ 2185 {0, 0, 0}, /* 0 */
2218 {0, 0, 0}, /* 1 */ 2186 {0, 0, 0}, /* 1 */
2219 {0, 0, 0}, /* 2 */ 2187 {0, 0, 0}, /* 2 */
2220 {0, 0, 0}, /* 3 */ 2188 {0, 0, 0}, /* 3 */
2221 {0, 0, 0}, /* 4 */ 2189 {0, 0, 0}, /* 4 */
2317int 2285int
2318can_pick (const object *who, const object *item) 2286can_pick (const object *who, const object *item)
2319{ 2287{
2320 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2288 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2321 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2289 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2322 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2290 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->is_player () || item->weight < who->weight / 3));
2323} 2291}
2324 2292
2325/* 2293/*
2326 * create clone from object to another 2294 * create clone from object to another
2327 */ 2295 */
2328object * 2296object *
2329object_create_clone (object *asrc) 2297object::deep_clone ()
2330{ 2298{
2331 object *dst = 0, *tmp, *src, *prev, *item; 2299 assert (("deep_clone called on non-head object", is_head ()));
2332 2300
2333 if (!asrc) 2301 object *dst = clone ();
2334 return 0;
2335 2302
2336 src = asrc->head_ (); 2303 object *prev = dst;
2337
2338 prev = 0;
2339 for (object *part = src; part; part = part->more) 2304 for (object *part = this->more; part; part = part->more)
2340 { 2305 {
2341 tmp = part->clone (); 2306 object *tmp = part->clone ();
2342 tmp->x -= src->x;
2343 tmp->y -= src->y;
2344
2345 if (!part->head)
2346 {
2347 dst = tmp;
2348 tmp->head = 0;
2349 }
2350 else
2351 tmp->head = dst; 2307 tmp->head = dst;
2352
2353 tmp->more = 0;
2354
2355 if (prev)
2356 prev->more = tmp; 2308 prev->more = tmp;
2357
2358 prev = tmp; 2309 prev = tmp;
2359 } 2310 }
2360 2311
2361 for (item = src->inv; item; item = item->below) 2312 for (object *item = inv; item; item = item->below)
2362 insert_ob_in_ob (object_create_clone (item), dst); 2313 insert_ob_in_ob (item->deep_clone (), dst);
2363 2314
2364 return dst; 2315 return dst;
2365} 2316}
2366 2317
2367/* This returns the first object in who's inventory that 2318/* This returns the first object in who's inventory that
2376 return tmp; 2327 return tmp;
2377 2328
2378 return 0; 2329 return 0;
2379} 2330}
2380 2331
2381/* If ob has a field named key, return the link from the list, 2332shstr_tmp
2382 * otherwise return NULL. 2333object::kv_get (shstr_tmp key) const
2383 *
2384 * key must be a passed in shared string - otherwise, this won't
2385 * do the desired thing.
2386 */
2387key_value *
2388get_ob_key_link (const object *ob, const char *key)
2389{ 2334{
2390 for (key_value *link = ob->key_values; link; link = link->next) 2335 for (key_value *kv = key_values; kv; kv = kv->next)
2391 if (link->key == key) 2336 if (kv->key == key)
2392 return link;
2393
2394 return 0;
2395}
2396
2397/*
2398 * Returns the value of op has an extra_field for key, or NULL.
2399 *
2400 * The argument doesn't need to be a shared string.
2401 *
2402 * The returned string is shared.
2403 */
2404const char *
2405get_ob_key_value (const object *op, const char *const key)
2406{
2407 key_value *link;
2408 shstr_cmp canonical_key (key);
2409
2410 if (!canonical_key)
2411 {
2412 /* 1. There being a field named key on any object
2413 * implies there'd be a shared string to find.
2414 * 2. Since there isn't, no object has this field.
2415 * 3. Therefore, *this* object doesn't have this field.
2416 */
2417 return 0;
2418 }
2419
2420 /* This is copied from get_ob_key_link() above -
2421 * only 4 lines, and saves the function call overhead.
2422 */
2423 for (link = op->key_values; link; link = link->next)
2424 if (link->key == canonical_key)
2425 return link->value; 2337 return kv->value;
2426 2338
2427 return 0; 2339 return shstr ();
2428} 2340}
2429 2341
2430/* 2342void
2431 * Updates the canonical_key in op to value. 2343object::kv_set (shstr_tmp key, shstr_tmp value)
2432 *
2433 * canonical_key is a shared string (value doesn't have to be).
2434 *
2435 * Unless add_key is TRUE, it won't add fields, only change the value of existing
2436 * keys.
2437 *
2438 * Returns TRUE on success.
2439 */
2440int
2441set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2442{ 2344{
2443 key_value *field = NULL, *last = NULL; 2345 for (key_value *kv = key_values; kv; kv = kv->next)
2444 2346 if (kv->key == key)
2445 for (field = op->key_values; field != NULL; field = field->next)
2446 {
2447 if (field->key != canonical_key)
2448 { 2347 {
2449 last = field; 2348 kv->value = value;
2450 continue; 2349 return;
2451 } 2350 }
2452 2351
2453 if (value) 2352 key_value *kv = new key_value;
2454 field->value = value; 2353
2455 else 2354 kv->next = key_values;
2355 kv->key = key;
2356 kv->value = value;
2357
2358 key_values = kv;
2359}
2360
2361void
2362object::kv_del (shstr_tmp key)
2363{
2364 for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
2365 if ((*kvp)->key == key)
2456 { 2366 {
2457 /* Basically, if the archetype has this key set, 2367 key_value *kv = *kvp;
2458 * we need to store the null value so when we save 2368 *kvp = (*kvp)->next;
2459 * it, we save the empty value so that when we load, 2369 delete kv;
2460 * we get this value back again. 2370 return;
2461 */
2462 if (get_ob_key_link (op->arch, canonical_key))
2463 field->value = 0;
2464 else
2465 {
2466 if (last)
2467 last->next = field->next;
2468 else
2469 op->key_values = field->next;
2470
2471 delete field;
2472 }
2473 } 2371 }
2474 return TRUE;
2475 }
2476 /* IF we get here, key doesn't exist */
2477
2478 /* No field, we'll have to add it. */
2479
2480 if (!add_key)
2481 return FALSE;
2482
2483 /* There isn't any good reason to store a null
2484 * value in the key/value list. If the archetype has
2485 * this key, then we should also have it, so shouldn't
2486 * be here. If user wants to store empty strings,
2487 * should pass in ""
2488 */
2489 if (value == NULL)
2490 return TRUE;
2491
2492 field = new key_value;
2493
2494 field->key = canonical_key;
2495 field->value = value;
2496 /* Usual prepend-addition. */
2497 field->next = op->key_values;
2498 op->key_values = field;
2499
2500 return TRUE;
2501}
2502
2503/*
2504 * Updates the key in op to value.
2505 *
2506 * If add_key is FALSE, this will only update existing keys,
2507 * and not add new ones.
2508 * In general, should be little reason FALSE is ever passed in for add_key
2509 *
2510 * Returns TRUE on success.
2511 */
2512int
2513set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2514{
2515 shstr key_ (key);
2516
2517 return set_ob_key_value_s (op, key_, value, add_key);
2518} 2372}
2519 2373
2520object::depth_iterator::depth_iterator (object *container) 2374object::depth_iterator::depth_iterator (object *container)
2521: iterator_base (container) 2375: iterator_base (container)
2522{ 2376{
2572{ 2426{
2573 char flagdesc[512]; 2427 char flagdesc[512];
2574 char info2[256 * 4]; 2428 char info2[256 * 4];
2575 char *p = info; 2429 char *p = info;
2576 2430
2577 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s,flags:[%s],type:%d}", 2431 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2578 count, 2432 count,
2579 uuid.c_str (), 2433 uuid.c_str (),
2580 &name, 2434 &name,
2581 title ? "\",title:\"" : "", 2435 title ? ",title:\"" : "",
2582 title ? (const char *)title : "", 2436 title ? (const char *)title : "",
2437 title ? "\"" : "",
2583 flag_desc (flagdesc, 512), type); 2438 flag_desc (flagdesc, 512), type);
2584 2439
2585 if (!flag[FLAG_REMOVED] && env) 2440 if (!flag[FLAG_REMOVED] && env)
2586 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2441 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2587 2442
2643 container = 0; 2498 container = 0;
2644 2499
2645 // client needs item update to make it work, client bug requires this to be separate 2500 // client needs item update to make it work, client bug requires this to be separate
2646 esrv_update_item (UPD_FLAGS, this, old_container); 2501 esrv_update_item (UPD_FLAGS, this, old_container);
2647 2502
2648 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container)); 2503 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", old_container->query_name ());
2649 play_sound (sound_find ("chest_close")); 2504 play_sound (sound_find ("chest_close"));
2650 } 2505 }
2651 2506
2652 if (new_container) 2507 if (new_container)
2653 { 2508 {
2663 closer->flag [FLAG_NO_MAP_SAVE] = 1; 2518 closer->flag [FLAG_NO_MAP_SAVE] = 1;
2664 new_container->insert (closer); 2519 new_container->insert (closer);
2665 } 2520 }
2666#endif 2521#endif
2667 2522
2668 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container)); 2523 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", new_container->query_name ());
2669 2524
2670 // make sure the container is available, client bug requires this to be separate 2525 // make sure the container is available, client bug requires this to be separate
2671 esrv_send_item (this, new_container); 2526 esrv_send_item (this, new_container);
2672 2527
2673 new_container->flag [FLAG_APPLIED] = true; 2528 new_container->flag [FLAG_APPLIED] = true;
2681// else if (!old_container->env && contr && contr->ns) 2536// else if (!old_container->env && contr && contr->ns)
2682// contr->ns->floorbox_reset (); 2537// contr->ns->floorbox_reset ();
2683} 2538}
2684 2539
2685object * 2540object *
2686object::force_find (const shstr name) 2541object::force_find (shstr_tmp name)
2687{ 2542{
2688 /* cycle through his inventory to look for the MARK we want to 2543 /* cycle through his inventory to look for the MARK we want to
2689 * place 2544 * place
2690 */ 2545 */
2691 for (object *tmp = inv; tmp; tmp = tmp->below) 2546 for (object *tmp = inv; tmp; tmp = tmp->below)
2694 2549
2695 return 0; 2550 return 0;
2696} 2551}
2697 2552
2698void 2553void
2554object::force_set_timer (int duration)
2555{
2556 this->duration = 1;
2557 this->speed_left = -1.f;
2558
2559 this->set_speed (duration ? 1.f / duration : 0.f);
2560}
2561
2562object *
2699object::force_add (const shstr name, int duration) 2563object::force_add (shstr_tmp name, int duration)
2700{ 2564{
2701 if (object *force = force_find (name)) 2565 if (object *force = force_find (name))
2702 force->destroy (); 2566 force->destroy ();
2703 2567
2704 object *force = get_archetype (FORCE_NAME); 2568 object *force = get_archetype (FORCE_NAME);
2705 2569
2706 force->slaying = name; 2570 force->slaying = name;
2707 force->stats.food = 1;
2708 force->speed_left = -1.f;
2709 2571
2710 force->set_speed (duration ? 1.f / duration : 0.f); 2572 force->force_set_timer (duration);
2711 force->flag [FLAG_IS_USED_UP] = true; 2573
2712 force->flag [FLAG_APPLIED] = true; 2574 force->flag [FLAG_APPLIED] = true;
2713 2575
2714 insert (force); 2576 return insert (force);
2715} 2577}
2716 2578
2717void 2579void
2718object::play_sound (faceidx sound) 2580object::play_sound (faceidx sound) const
2719{ 2581{
2720 if (!sound) 2582 if (!sound)
2721 return; 2583 return;
2722 2584
2723 if (flag [FLAG_REMOVED]) 2585 if (is_on_map ())
2586 map->play_sound (sound, x, y);
2587 else if (object *pl = in_player ())
2588 pl->contr->play_sound (sound);
2589}
2590
2591void
2592object::say_msg (const char *msg) const
2593{
2594 if (is_on_map ())
2595 map->say_msg (msg, x, y);
2596 else if (object *pl = in_player ())
2597 pl->contr->play_sound (sound);
2598}
2599
2600void
2601object::make_noise ()
2602{
2603 // we do not model noise in the map, so instead put
2604 // a temporary light into the noise source
2605 // could use the map instead, but that's less reliable for our
2606 // goal, which is to make invisibility a bit harder to exploit
2607
2608 // currently only works sensibly for players
2609 if (!is_player ())
2724 return; 2610 return;
2725 2611
2726 if (env) 2612 // find old force, or create new one
2727 { 2613 object *force = force_find (shstr_noise_force);
2728 if (object *pl = in_player ()) 2614
2729 pl->contr->play_sound (sound); 2615 if (force)
2730 } 2616 force->speed_left = -1.f; // patch old speed up
2731 else 2617 else
2732 map->play_sound (sound, x, y); 2618 {
2733} 2619 force = archetype::get (shstr_noise_force);
2734 2620
2621 force->slaying = shstr_noise_force;
2622 force->stats.food = 1;
2623 force->speed_left = -1.f;
2624
2625 force->set_speed (1.f / 4.f);
2626 force->flag [FLAG_IS_USED_UP] = true;
2627 force->flag [FLAG_APPLIED] = true;
2628
2629 insert (force);
2630 }
2631}
2632

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines