ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.52 by root, Wed Sep 27 00:36:08 2006 UTC vs.
Revision 1.89 by root, Tue Dec 26 09:52:40 2006 UTC

29#include <sys/types.h> 29#include <sys/types.h>
30#include <sys/uio.h> 30#include <sys/uio.h>
31#include <object.h> 31#include <object.h>
32#include <funcpoint.h> 32#include <funcpoint.h>
33#include <loader.h> 33#include <loader.h>
34
35#include <bitset>
34 36
35int nrofallocobjects = 0; 37int nrofallocobjects = 0;
36static UUID uuid; 38static UUID uuid;
37const uint64 UUID_SKIP = 1<<19; 39const uint64 UUID_SKIP = 1<<19;
38 40
104 _exit (1); 106 _exit (1);
105 } 107 }
106 108
107 uuid.seq = uid; 109 uuid.seq = uid;
108 write_uuid (); 110 write_uuid ();
109 LOG (llevDebug, "read UID: %lld\n", uid); 111 LOG (llevDebug, "read UID: %" PRId64 "\n", uid);
110 fclose (fp); 112 fclose (fp);
111} 113}
112 114
113UUID 115UUID
114gen_uuid () 116gen_uuid ()
139 * objects with lists are rare, and lists stay short. If not, use a 141 * objects with lists are rare, and lists stay short. If not, use a
140 * different structure or at least keep the lists sorted... 142 * different structure or at least keep the lists sorted...
141 */ 143 */
142 144
143 /* For each field in wants, */ 145 /* For each field in wants, */
144 for (wants_field = wants->key_values; wants_field != NULL; wants_field = wants_field->next) 146 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)
145 { 147 {
146 key_value *has_field; 148 key_value *has_field;
147 149
148 /* Look for a field in has with the same key. */ 150 /* Look for a field in has with the same key. */
149 has_field = get_ob_key_link (has, wants_field->key); 151 has_field = get_ob_key_link (has, wants_field->key);
183 * 185 *
184 * Note that this function appears a lot longer than the macro it 186 * Note that this function appears a lot longer than the macro it
185 * replaces - this is mostly for clarity - a decent compiler should hopefully 187 * replaces - this is mostly for clarity - a decent compiler should hopefully
186 * reduce this to the same efficiency. 188 * reduce this to the same efficiency.
187 * 189 *
188 * Check nrof variable *before* calling CAN_MERGE() 190 * Check nrof variable *before* calling can_merge()
189 * 191 *
190 * Improvements made with merge: Better checking on potion, and also 192 * Improvements made with merge: Better checking on potion, and also
191 * check weight 193 * check weight
192 */ 194 */
193 195
194bool object::can_merge (object *ob1, object *ob2) 196bool object::can_merge_slow (object *ob1, object *ob2)
195{ 197{
196 /* A couple quicksanity checks */ 198 /* A couple quicksanity checks */
197 if ((ob1 == ob2) || (ob1->type != ob2->type)) 199 if (ob1 == ob2
200 || ob1->type != ob2->type
201 || ob1->speed != ob2->speed
202 || ob1->value != ob2->value
203 || ob1->name != ob2->name)
198 return 0; 204 return 0;
199 205
200 if (ob1->speed != ob2->speed) 206 //TODO: this ain't working well, use nicer and correct overflow check
201 return 0;
202
203 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that 207 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that
204 * value could not be stored in a sint32 (which unfortunately sometimes is 208 * value could not be stored in a sint32 (which unfortunately sometimes is
205 * used to store nrof). 209 * used to store nrof).
206 */ 210 */
207 if (ob1->nrof + ob2->nrof >= 1UL << 31) 211 if (ob1->nrof + ob2->nrof >= 1UL << 31)
217 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 221 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
218 222
219 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 223 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
220 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 224 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
221 225
222 226 if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any ()
223 /* the 0x400000 on flags2 is FLAG_INV_LOCK. I don't think something 227 || ob1->arch != ob2->arch
224 * being locked in inventory should prevent merging.
225 * 0x4 in flags3 is CLIENT_SENT
226 */
227 if ((ob1->arch != ob2->arch) ||
228 (ob1->flags[0] != ob2->flags[0]) ||
229 (ob1->flags[1] != ob2->flags[1]) ||
230 ((ob1->flags[2] & ~0x400000) != (ob2->flags[2] & ~0x400000)) ||
231 ((ob1->flags[3] & ~0x4) != (ob2->flags[3] & ~0x4)) ||
232 (ob1->name != ob2->name) || 228 || ob1->name != ob2->name
233 (ob1->title != ob2->title) || 229 || ob1->title != ob2->title
234 (ob1->msg != ob2->msg) || 230 || ob1->msg != ob2->msg
235 (ob1->weight != ob2->weight) || 231 || ob1->weight != ob2->weight
236 (memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist)) != 0) || 232 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
237 (memcmp (&ob1->stats, &ob2->stats, sizeof (ob1->stats)) != 0) || 233 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
238 (ob1->attacktype != ob2->attacktype) || 234 || ob1->attacktype != ob2->attacktype
239 (ob1->magic != ob2->magic) || 235 || ob1->magic != ob2->magic
240 (ob1->slaying != ob2->slaying) || 236 || ob1->slaying != ob2->slaying
241 (ob1->skill != ob2->skill) || 237 || ob1->skill != ob2->skill
242 (ob1->value != ob2->value) || 238 || ob1->value != ob2->value
243 (ob1->animation_id != ob2->animation_id) || 239 || ob1->animation_id != ob2->animation_id
244 (ob1->client_type != ob2->client_type) || 240 || ob1->client_type != ob2->client_type
245 (ob1->materialname != ob2->materialname) || 241 || ob1->materialname != ob2->materialname
246 (ob1->lore != ob2->lore) || 242 || ob1->lore != ob2->lore
247 (ob1->subtype != ob2->subtype) || 243 || ob1->subtype != ob2->subtype
248 (ob1->move_type != ob2->move_type) || 244 || ob1->move_type != ob2->move_type
249 (ob1->move_block != ob2->move_block) || 245 || ob1->move_block != ob2->move_block
250 (ob1->move_allow != ob2->move_allow) || 246 || ob1->move_allow != ob2->move_allow
251 (ob1->move_on != ob2->move_on) || 247 || ob1->move_on != ob2->move_on
252 (ob1->move_off != ob2->move_off) || (ob1->move_slow != ob2->move_slow) || (ob1->move_slow_penalty != ob2->move_slow_penalty)) 248 || ob1->move_off != ob2->move_off
249 || ob1->move_slow != ob2->move_slow
250 || ob1->move_slow_penalty != ob2->move_slow_penalty)
253 return 0; 251 return 0;
254 252
255 /* This is really a spellbook check - really, we should 253 /* This is really a spellbook check - really, we should
256 * check all objects in the inventory. 254 * check all objects in the inventory.
257 */ 255 */
260 /* if one object has inventory but the other doesn't, not equiv */ 258 /* if one object has inventory but the other doesn't, not equiv */
261 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv)) 259 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv))
262 return 0; 260 return 0;
263 261
264 /* Now check to see if the two inventory objects could merge */ 262 /* Now check to see if the two inventory objects could merge */
265 if (!CAN_MERGE (ob1->inv, ob2->inv)) 263 if (!object::can_merge (ob1->inv, ob2->inv))
266 return 0; 264 return 0;
267 265
268 /* inventory ok - still need to check rest of this object to see 266 /* inventory ok - still need to check rest of this object to see
269 * if it is valid. 267 * if it is valid.
270 */ 268 */
354 op = op->env; 352 op = op->env;
355 return op; 353 return op;
356} 354}
357 355
358/* 356/*
359 * Eneq(@csd.uu.se): Since we can have items buried in a character we need
360 * a better check. We basically keeping traversing up until we can't
361 * or find a player.
362 */
363
364object *
365is_player_inv (object *op)
366{
367 for (; op != NULL && op->type != PLAYER; op = op->env)
368 if (op->env == op)
369 op->env = NULL;
370 return op;
371}
372
373/*
374 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump. 357 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
375 * Some error messages. 358 * Some error messages.
376 * The result of the dump is stored in the static global errmsg array. 359 * The result of the dump is stored in the static global errmsg array.
377 */ 360 */
378 361
379void 362char *
380dump_object2 (object *op)
381{
382 errmsg[0] = 0;
383 return;
384 //TODO//D#d#
385#if 0
386 char *cp;
387
388/* object *tmp;*/
389
390 if (op->arch != NULL)
391 {
392 strcat (errmsg, "arch ");
393 strcat (errmsg, op->arch->name ? op->arch->name : "(null)");
394 strcat (errmsg, "\n");
395 if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
396 strcat (errmsg, cp);
397# if 0
398 /* Don't dump player diffs - they are too long, mostly meaningless, and
399 * will overflow the buffer.
400 * Changed so that we don't dump inventory either. This may
401 * also overflow the buffer.
402 */
403 if (op->type != PLAYER && (cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
404 strcat (errmsg, cp);
405 for (tmp = op->inv; tmp; tmp = tmp->below)
406 dump_object2 (tmp);
407# endif
408 strcat (errmsg, "end\n");
409 }
410 else
411 {
412 strcat (errmsg, "Object ");
413 if (op->name == NULL)
414 strcat (errmsg, "(null)");
415 else
416 strcat (errmsg, op->name);
417 strcat (errmsg, "\n");
418# if 0
419 if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
420 strcat (errmsg, cp);
421 for (tmp = op->inv; tmp; tmp = tmp->below)
422 dump_object2 (tmp);
423# endif
424 strcat (errmsg, "end\n");
425 }
426#endif
427}
428
429/*
430 * Dumps an object. Returns output in the static global errmsg array.
431 */
432
433void
434dump_object (object *op) 363dump_object (object *op)
435{ 364{
436 if (op == NULL) 365 if (!op)
437 { 366 return strdup ("[NULLOBJ]");
438 strcpy (errmsg, "[NULL pointer]");
439 return;
440 }
441 errmsg[0] = '\0';
442 dump_object2 (op);
443}
444 367
445void 368 object_freezer freezer;
446dump_all_objects (void) 369 save_object (freezer, op, 1);
447{ 370 return freezer.as_string ();
448 object *op;
449
450 for (op = object::first; op != NULL; op = op->next)
451 {
452 dump_object (op);
453 fprintf (logfile, "Object %s\n", errmsg);
454 }
455} 371}
456 372
457/* 373/*
458 * get_nearest_part(multi-object, object 2) returns the part of the 374 * get_nearest_part(multi-object, object 2) returns the part of the
459 * multi-object 1 which is closest to the second object. 375 * multi-object 1 which is closest to the second object.
479 */ 395 */
480 396
481object * 397object *
482find_object (tag_t i) 398find_object (tag_t i)
483{ 399{
484 object *op;
485
486 for (op = object::first; op != NULL; op = op->next) 400 for (object *op = object::first; op; op = op->next)
487 if (op->count == i) 401 if (op->count == i)
488 break; 402 return op;
489 403
490 return op; 404 return 0;
491} 405}
492 406
493/* 407/*
494 * Returns the first object which has a name equal to the argument. 408 * Returns the first object which has a name equal to the argument.
495 * Used only by the patch command, but not all that useful. 409 * Used only by the patch command, but not all that useful.
553 } 467 }
554 468
555 op->key_values = 0; 469 op->key_values = 0;
556} 470}
557 471
558void object::clear ()
559{
560 attachable_base::clear ();
561
562 free_key_values (this);
563
564 owner = 0;
565 name = 0;
566 name_pl = 0;
567 title = 0;
568 race = 0;
569 slaying = 0;
570 skill = 0;
571 msg = 0;
572 lore = 0;
573 custom_name = 0;
574 materialname = 0;
575 contr = 0;
576 below = 0;
577 above = 0;
578 inv = 0;
579 container = 0;
580 env = 0;
581 more = 0;
582 head = 0;
583 map = 0;
584 active_next = 0;
585 active_prev = 0;
586
587 memset (static_cast<object_pod *>(this), 0, sizeof (object_pod));
588
589 SET_FLAG (this, FLAG_REMOVED);
590
591 /* What is not cleared is next, prev, and count */
592
593 expmul = 1.0;
594 face = blank_face;
595
596 if (settings.casting_time)
597 casting_time = -1;
598}
599
600void object::clone (object *destination)
601{
602 *(object_copy *)destination = *this;
603 *(object_pod *)destination = *this;
604
605 if (self || cb)
606 INVOKE_OBJECT (CLONE, this, ARG_OBJECT (destination));
607}
608
609/* 472/*
610 * copy object first frees everything allocated by the second object, 473 * copy_to first frees everything allocated by the dst object,
611 * and then copies the contends of the first object into the second 474 * and then copies the contents of itself into the second
612 * object, allocating what needs to be allocated. Basically, any 475 * object, allocating what needs to be allocated. Basically, any
613 * data that is malloc'd needs to be re-malloc/copied. Otherwise, 476 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
614 * if the first object is freed, the pointers in the new object 477 * if the first object is freed, the pointers in the new object
615 * will point at garbage. 478 * will point at garbage.
616 */ 479 */
617void 480void
618copy_object (object *op2, object *op) 481object::copy_to (object *dst)
619{ 482{
620 bool is_freed = QUERY_FLAG (op, FLAG_FREED); 483 bool is_freed = QUERY_FLAG (dst, FLAG_FREED);
621 bool is_removed = QUERY_FLAG (op, FLAG_REMOVED); 484 bool is_removed = QUERY_FLAG (dst, FLAG_REMOVED);
622 485
623 op2->clone (op); 486 *(object_copy *)dst = *this;
624 487
625 if (is_freed) 488 if (is_freed)
626 SET_FLAG (op, FLAG_FREED); 489 SET_FLAG (dst, FLAG_FREED);
490
627 if (is_removed) 491 if (is_removed)
628 SET_FLAG (op, FLAG_REMOVED); 492 SET_FLAG (dst, FLAG_REMOVED);
629 493
630 if (op2->speed < 0) 494 if (speed < 0)
631 op->speed_left = op2->speed_left - RANDOM () % 200 / 100.0; 495 dst->speed_left = speed_left - RANDOM () % 200 / 100.0;
632 496
633 /* Copy over key_values, if any. */ 497 /* Copy over key_values, if any. */
634 if (op2->key_values) 498 if (key_values)
635 { 499 {
636 key_value *tail = 0; 500 key_value *tail = 0;
637 key_value *i; 501 key_value *i;
638 502
639 op->key_values = 0; 503 dst->key_values = 0;
640 504
641 for (i = op2->key_values; i; i = i->next) 505 for (i = key_values; i; i = i->next)
642 { 506 {
643 key_value *new_link = new key_value; 507 key_value *new_link = new key_value;
644 508
645 new_link->next = 0; 509 new_link->next = 0;
646 new_link->key = i->key; 510 new_link->key = i->key;
647 new_link->value = i->value; 511 new_link->value = i->value;
648 512
649 /* Try and be clever here, too. */ 513 /* Try and be clever here, too. */
650 if (!op->key_values) 514 if (!dst->key_values)
651 { 515 {
652 op->key_values = new_link; 516 dst->key_values = new_link;
653 tail = new_link; 517 tail = new_link;
654 } 518 }
655 else 519 else
656 { 520 {
657 tail->next = new_link; 521 tail->next = new_link;
658 tail = new_link; 522 tail = new_link;
659 } 523 }
660 } 524 }
661 } 525 }
662 526
663 update_ob_speed (op); 527 dst->set_speed (dst->speed);
528}
529
530object *
531object::clone ()
532{
533 object *neu = create ();
534 copy_to (neu);
535 return neu;
664} 536}
665 537
666/* 538/*
667 * If an object with the IS_TURNABLE() flag needs to be turned due 539 * If an object with the IS_TURNABLE() flag needs to be turned due
668 * to the closest player being on the other side, this function can 540 * to the closest player being on the other side, this function can
682 * Updates the speed of an object. If the speed changes from 0 to another 554 * Updates the speed of an object. If the speed changes from 0 to another
683 * value, or vice versa, then add/remove the object from the active list. 555 * value, or vice versa, then add/remove the object from the active list.
684 * This function needs to be called whenever the speed of an object changes. 556 * This function needs to be called whenever the speed of an object changes.
685 */ 557 */
686void 558void
687update_ob_speed (object *op) 559object::set_speed (float speed)
688{ 560{
689 extern int arch_init; 561 extern int arch_init;
690 562
691 /* No reason putting the archetypes objects on the speed list, 563 /* No reason putting the archetypes objects on the speed list,
692 * since they never really need to be updated. 564 * since they never really need to be updated.
693 */ 565 */
694 566 if (flag [FLAG_FREED] && speed)
695 if (QUERY_FLAG (op, FLAG_FREED) && op->speed)
696 { 567 {
697 LOG (llevError, "Object %s is freed but has speed.\n", &op->name); 568 LOG (llevError, "Object %s is freed but has speed.\n", &name);
698#ifdef MANY_CORES
699 abort ();
700#else
701 op->speed = 0; 569 speed = 0;
702#endif
703 } 570 }
571
572 this->speed = speed;
704 573
705 if (arch_init) 574 if (arch_init)
706 return; 575 return;
707 576
708 if (FABS (op->speed) > MIN_ACTIVE_SPEED) 577 if (FABS (speed) > MIN_ACTIVE_SPEED)
709 { 578 {
710 /* If already on active list, don't do anything */ 579 /* If already on active list, don't do anything */
711 if (op->active_next || op->active_prev || op == active_objects) 580 if (active_next || active_prev || this == active_objects)
712 return; 581 return;
713 582
714 /* process_events() expects us to insert the object at the beginning 583 /* process_events() expects us to insert the object at the beginning
715 * of the list. */ 584 * of the list. */
716 op->active_next = active_objects; 585 active_next = active_objects;
717 586
718 if (op->active_next != NULL) 587 if (active_next)
719 op->active_next->active_prev = op; 588 active_next->active_prev = this;
720 589
721 active_objects = op; 590 active_objects = this;
722 } 591 }
723 else 592 else
724 { 593 {
725 /* If not on the active list, nothing needs to be done */ 594 /* If not on the active list, nothing needs to be done */
726 if (!op->active_next && !op->active_prev && op != active_objects) 595 if (!active_next && !active_prev && this != active_objects)
727 return; 596 return;
728 597
729 if (op->active_prev == NULL) 598 if (!active_prev)
730 { 599 {
731 active_objects = op->active_next; 600 active_objects = active_next;
732 601
733 if (op->active_next != NULL) 602 if (active_next)
734 op->active_next->active_prev = NULL; 603 active_next->active_prev = 0;
735 } 604 }
736 else 605 else
737 { 606 {
738 op->active_prev->active_next = op->active_next; 607 active_prev->active_next = active_next;
739 608
740 if (op->active_next) 609 if (active_next)
741 op->active_next->active_prev = op->active_prev; 610 active_next->active_prev = active_prev;
742 } 611 }
743 612
744 op->active_next = NULL; 613 active_next = 0;
745 op->active_prev = NULL; 614 active_prev = 0;
746 } 615 }
747} 616}
748 617
749/* This function removes object 'op' from the list of active 618/* This function removes object 'op' from the list of active
750 * objects. 619 * objects.
776 op->active_next = NULL; 645 op->active_next = NULL;
777 op->active_prev = NULL; 646 op->active_prev = NULL;
778} 647}
779 648
780/* 649/*
781 * update_object() updates the array which represents the map. 650 * update_object() updates the the map.
782 * It takes into account invisible objects (and represent squares covered 651 * It takes into account invisible objects (and represent squares covered
783 * by invisible objects by whatever is below them (unless it's another 652 * by invisible objects by whatever is below them (unless it's another
784 * invisible object, etc...) 653 * invisible object, etc...)
785 * If the object being updated is beneath a player, the look-window 654 * If the object being updated is beneath a player, the look-window
786 * of that player is updated (this might be a suboptimal way of 655 * of that player is updated (this might be a suboptimal way of
787 * updating that window, though, since update_object() is called _often_) 656 * updating that window, though, since update_object() is called _often_)
788 * 657 *
789 * action is a hint of what the caller believes need to be done. 658 * action is a hint of what the caller believes need to be done.
790 * For example, if the only thing that has changed is the face (due to
791 * an animation), we don't need to call update_position until that actually
792 * comes into view of a player. OTOH, many other things, like addition/removal
793 * of walls or living creatures may need us to update the flags now.
794 * current action are: 659 * current action are:
795 * UP_OBJ_INSERT: op was inserted 660 * UP_OBJ_INSERT: op was inserted
796 * UP_OBJ_REMOVE: op was removed 661 * UP_OBJ_REMOVE: op was removed
797 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update 662 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update
798 * as that is easier than trying to look at what may have changed. 663 * as that is easier than trying to look at what may have changed.
799 * UP_OBJ_FACE: only the objects face has changed. 664 * UP_OBJ_FACE: only the objects face has changed.
800 */ 665 */
801
802void 666void
803update_object (object *op, int action) 667update_object (object *op, int action)
804{ 668{
805 int update_now = 0, flags;
806 MoveType move_on, move_off, move_block, move_slow; 669 MoveType move_on, move_off, move_block, move_slow;
807 670
808 if (op == NULL) 671 if (op == NULL)
809 { 672 {
810 /* this should never happen */ 673 /* this should never happen */
811 LOG (llevDebug, "update_object() called for NULL object.\n"); 674 LOG (llevDebug, "update_object() called for NULL object.\n");
812 return; 675 return;
813 } 676 }
814 677
815 if (op->env != NULL) 678 if (op->env)
816 { 679 {
817 /* Animation is currently handled by client, so nothing 680 /* Animation is currently handled by client, so nothing
818 * to do in this case. 681 * to do in this case.
819 */ 682 */
820 return; 683 return;
825 */ 688 */
826 if (!op->map || op->map->in_memory == MAP_SAVING) 689 if (!op->map || op->map->in_memory == MAP_SAVING)
827 return; 690 return;
828 691
829 /* make sure the object is within map boundaries */ 692 /* make sure the object is within map boundaries */
830 if (op->x < 0 || op->x >= MAP_WIDTH (op->map) || op->y < 0 || op->y >= MAP_HEIGHT (op->map)) 693 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
831 { 694 {
832 LOG (llevError, "update_object() called for object out of map!\n"); 695 LOG (llevError, "update_object() called for object out of map!\n");
833#ifdef MANY_CORES 696#ifdef MANY_CORES
834 abort (); 697 abort ();
835#endif 698#endif
836 return; 699 return;
837 } 700 }
838 701
839 flags = GET_MAP_FLAGS (op->map, op->x, op->y); 702 mapspace &m = op->ms ();
840 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NEED_UPDATE);
841 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
842 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
843 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
844 move_off = GET_MAP_MOVE_OFF (op->map, op->x, op->y);
845 703
704 if (m.flags_ & P_NEED_UPDATE)
705 /* nop */;
846 if (action == UP_OBJ_INSERT) 706 else if (action == UP_OBJ_INSERT)
847 { 707 {
708 // this is likely overkill, TODO: revisit (schmorp)
848 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(flags & P_BLOCKSVIEW)) 709 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
849 update_now = 1;
850
851 if (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(flags & P_NO_MAGIC)) 710 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
852 update_now = 1; 711 || (op->type == PLAYER && !(m.flags_ & P_PLAYER))
853 712 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
713 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
854 if (QUERY_FLAG (op, FLAG_DAMNED) && !(flags & P_NO_CLERIC)) 714 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
855 update_now = 1;
856
857 if (QUERY_FLAG (op, FLAG_ALIVE) && !(flags & P_IS_ALIVE))
858 update_now = 1;
859
860 if (op->type == SAFE_GROUND && !(flags & P_SAFE))
861 update_now = 1;
862
863 if ((move_on | op->move_on) != move_on) 715 || (m.move_on | op->move_on ) != m.move_on
864 update_now = 1;
865
866 if ((move_off | op->move_off) != move_off) 716 || (m.move_off | op->move_off ) != m.move_off
867 update_now = 1; 717 || (m.move_slow | op->move_slow) != m.move_slow
868
869 /* This isn't perfect, but I don't expect a lot of objects to 718 /* This isn't perfect, but I don't expect a lot of objects to
870 * to have move_allow right now. 719 * to have move_allow right now.
871 */ 720 */
872 if (((move_block | op->move_block) & ~op->move_allow) != move_block) 721 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
873 update_now = 1; 722 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
874 723 m.flags_ = P_NEED_UPDATE;
875 if ((move_slow | op->move_slow) != move_slow)
876 update_now = 1;
877 } 724 }
878 /* if the object is being removed, we can't make intelligent 725 /* if the object is being removed, we can't make intelligent
879 * decisions, because remove_ob can't really pass the object 726 * decisions, because remove_ob can't really pass the object
880 * that is being removed. 727 * that is being removed.
881 */ 728 */
882 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 729 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
883 update_now = 1; 730 m.flags_ = P_NEED_UPDATE;
884 else if (action == UP_OBJ_FACE) 731 else if (action == UP_OBJ_FACE)
885 /* Nothing to do for that case */ ; 732 /* Nothing to do for that case */ ;
886 else 733 else
887 LOG (llevError, "update_object called with invalid action: %d\n", action); 734 LOG (llevError, "update_object called with invalid action: %d\n", action);
888 735
889 if (update_now)
890 {
891 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NO_ERROR | P_NEED_UPDATE);
892 update_position (op->map, op->x, op->y);
893 }
894
895 if (op->more != NULL) 736 if (op->more)
896 update_object (op->more, action); 737 update_object (op->more, action);
897} 738}
898 739
899object::vector object::mortals;
900object::vector object::objects; // not yet used 740object::vector object::objects; // not yet used
901object *object::first; 741object *object::first;
902
903void object::free_mortals ()
904{
905 for (AUTODECL (i, mortals.begin ()); i != mortals.end ();)
906 if ((*i)->refcnt)
907 ++i; // further delay freeing
908 else
909 {
910 delete *i;
911 mortals.erase (i);
912 }
913
914 static int lastmortals = 0;//D
915
916 if (mortals.size() != lastmortals && lastmortals > 100)//D
917 {
918 lastmortals = mortals.size ();//D
919 LOG (llevDebug, "%d objects in mortal queue\n", lastmortals);//D
920 }
921}
922 742
923object::object () 743object::object ()
924{ 744{
925 SET_FLAG (this, FLAG_REMOVED); 745 SET_FLAG (this, FLAG_REMOVED);
926 746
958 778
959 prev = 0; 779 prev = 0;
960 next = 0; 780 next = 0;
961} 781}
962 782
783/*
784 * Remove and free all objects in the inventory of the given object.
785 * object.c ?
786 */
787void
788object::destroy_inv (bool drop_to_ground)
789{
790 /* Only if the space blocks everything do we not process -
791 * if some form of movement is allowed, let objects
792 * drop on that space.
793 */
794 if (!drop_to_ground || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL)
795 {
796 while (inv)
797 inv->destroy ();
798 }
799 else
800 { /* Put objects in inventory onto this space */
801 while (inv)
802 {
803 object *op = inv;
804
805 if (op->flag [FLAG_STARTEQUIP]
806 || op->flag [FLAG_NO_DROP]
807 || op->type == RUNE
808 || op->type == TRAP
809 || op->flag [FLAG_IS_A_TEMPLATE])
810 op->destroy ();
811 else
812 {
813 op->remove ();
814 op->x = x;
815 op->y = y;
816 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
817 }
818 }
819 }
820}
821
963object *object::create () 822object *object::create ()
964{ 823{
965 object *op = new object; 824 object *op = new object;
966 op->link (); 825 op->link ();
967 return op; 826 return op;
968} 827}
969 828
970/* 829void
971 * free_object() frees everything allocated by an object, removes 830object::do_destroy ()
972 * it from the list of used objects, and puts it on the list of
973 * free objects. The IS_FREED() flag is set in the object.
974 * The object must have been removed by remove_ob() first for
975 * this function to succeed.
976 *
977 * If destroy_inventory is set, free inventory as well. Else drop items in
978 * inventory to the ground.
979 */
980void object::destroy (bool destroy_inventory)
981{ 831{
982 if (QUERY_FLAG (this, FLAG_FREED)) 832 attachable::do_destroy ();
833
834 if (flag [FLAG_IS_LINKED])
835 remove_button_link (this);
836
837 if (flag [FLAG_FRIENDLY])
838 remove_friendly_object (this);
839
840 if (!flag [FLAG_REMOVED])
841 remove ();
842
843 if (flag [FLAG_FREED])
983 return; 844 return;
984 845
985 if (QUERY_FLAG (this, FLAG_FRIENDLY)) 846 flag [FLAG_FREED] = 1;
986 remove_friendly_object (this);
987 847
988 if (!QUERY_FLAG (this, FLAG_REMOVED)) 848 destroy_inv (true);
989 remove_ob (this); 849 set_speed (0);
850 unlink ();
990 851
991 SET_FLAG (this, FLAG_FREED); 852 // hack to ensure that freed objects still have a valid map
853 {
854 static maptile *freed_map; // freed objects are moved here to avoid crashes
855
856 if (!freed_map)
857 {
858 freed_map = new maptile;
859
860 freed_map->name = "/internal/freed_objects_map";
861 freed_map->width = 3;
862 freed_map->height = 3;
863
864 freed_map->allocate ();
865 }
866
867 map = freed_map;
868 x = 1;
869 y = 1;
870 }
871
872 head = 0;
992 873
993 if (more) 874 if (more)
994 { 875 {
995 more->destroy (destroy_inventory); 876 more->destroy ();
996 more = 0; 877 more = 0;
997 }
998
999 if (inv)
1000 {
1001 /* Only if the space blocks everything do we not process -
1002 * if some form of movement is allowed, let objects
1003 * drop on that space.
1004 */
1005 if (destroy_inventory || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL)
1006 {
1007 object *op = inv;
1008
1009 while (op)
1010 {
1011 object *tmp = op->below;
1012 op->destroy (destroy_inventory);
1013 op = tmp;
1014 }
1015 }
1016 else
1017 { /* Put objects in inventory onto this space */
1018 object *op = inv;
1019
1020 while (op)
1021 {
1022 object *tmp = op->below;
1023
1024 remove_ob (op);
1025
1026 if (QUERY_FLAG (op, FLAG_STARTEQUIP)
1027 || QUERY_FLAG (op, FLAG_NO_DROP) || op->type == RUNE || op->type == TRAP || QUERY_FLAG (op, FLAG_IS_A_TEMPLATE))
1028 free_object (op);
1029 else
1030 {
1031 op->x = x;
1032 op->y = y;
1033 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
1034 }
1035
1036 op = tmp;
1037 }
1038 }
1039 } 878 }
1040 879
1041 // clear those pointers that likely might have circular references to us 880 // clear those pointers that likely might have circular references to us
1042 owner = 0; 881 owner = 0;
1043 enemy = 0; 882 enemy = 0;
1044 attacked_by = 0; 883 attacked_by = 0;
1045 884
1046 // only relevant for players(?), but make sure of it anyways 885 // only relevant for players(?), but make sure of it anyways
1047 contr = 0; 886 contr = 0;
887}
1048 888
1049 /* Remove object from the active list */ 889void
1050 speed = 0; 890object::destroy (bool destroy_inventory)
1051 update_ob_speed (this); 891{
892 if (destroyed ())
893 return;
1052 894
1053 unlink (); 895 if (destroy_inventory)
896 destroy_inv (false);
1054 897
1055 mortals.push_back (this); 898 attachable::destroy ();
1056} 899}
1057 900
1058/* 901/*
1059 * sub_weight() recursively (outwards) subtracts a number from the 902 * sub_weight() recursively (outwards) subtracts a number from the
1060 * weight of an object (and what is carried by it's environment(s)). 903 * weight of an object (and what is carried by it's environment(s)).
1061 */ 904 */
1062
1063void 905void
1064sub_weight (object *op, signed long weight) 906sub_weight (object *op, signed long weight)
1065{ 907{
1066 while (op != NULL) 908 while (op != NULL)
1067 { 909 {
1071 op->carrying -= weight; 913 op->carrying -= weight;
1072 op = op->env; 914 op = op->env;
1073 } 915 }
1074} 916}
1075 917
1076/* remove_ob(op): 918/* op->remove ():
1077 * This function removes the object op from the linked list of objects 919 * This function removes the object op from the linked list of objects
1078 * which it is currently tied to. When this function is done, the 920 * which it is currently tied to. When this function is done, the
1079 * object will have no environment. If the object previously had an 921 * object will have no environment. If the object previously had an
1080 * environment, the x and y coordinates will be updated to 922 * environment, the x and y coordinates will be updated to
1081 * the previous environment. 923 * the previous environment.
1082 * Beware: This function is called from the editor as well! 924 * Beware: This function is called from the editor as well!
1083 */ 925 */
1084
1085void 926void
1086remove_ob (object *op) 927object::remove ()
1087{ 928{
1088 object *tmp, *last = 0; 929 object *tmp, *last = 0;
1089 object *otmp; 930 object *otmp;
1090 931
1091 int check_walk_off;
1092 maptile *m;
1093
1094 sint16 x, y;
1095
1096 if (QUERY_FLAG (op, FLAG_REMOVED)) 932 if (QUERY_FLAG (this, FLAG_REMOVED))
1097 return; 933 return;
1098 934
1099 SET_FLAG (op, FLAG_REMOVED); 935 SET_FLAG (this, FLAG_REMOVED);
936 INVOKE_OBJECT (REMOVE, this);
1100 937
1101 if (op->more != NULL) 938 if (more)
1102 remove_ob (op->more); 939 more->remove ();
1103 940
1104 /* 941 /*
1105 * In this case, the object to be removed is in someones 942 * In this case, the object to be removed is in someones
1106 * inventory. 943 * inventory.
1107 */ 944 */
1108 if (op->env != NULL) 945 if (env)
1109 { 946 {
1110 if (op->nrof) 947 if (nrof)
1111 sub_weight (op->env, op->weight * op->nrof); 948 sub_weight (env, weight * nrof);
1112 else 949 else
1113 sub_weight (op->env, op->weight + op->carrying); 950 sub_weight (env, weight + carrying);
1114 951
1115 /* NO_FIX_PLAYER is set when a great many changes are being 952 /* NO_FIX_PLAYER is set when a great many changes are being
1116 * made to players inventory. If set, avoiding the call 953 * made to players inventory. If set, avoiding the call
1117 * to save cpu time. 954 * to save cpu time.
1118 */ 955 */
1119 if ((otmp = is_player_inv (op->env)) != NULL && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 956 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1120 fix_player (otmp); 957 otmp->update_stats ();
1121 958
1122 if (op->above != NULL) 959 if (above != NULL)
1123 op->above->below = op->below; 960 above->below = below;
1124 else 961 else
1125 op->env->inv = op->below; 962 env->inv = below;
1126 963
1127 if (op->below != NULL) 964 if (below != NULL)
1128 op->below->above = op->above; 965 below->above = above;
1129 966
1130 /* we set up values so that it could be inserted into 967 /* we set up values so that it could be inserted into
1131 * the map, but we don't actually do that - it is up 968 * the map, but we don't actually do that - it is up
1132 * to the caller to decide what we want to do. 969 * to the caller to decide what we want to do.
1133 */ 970 */
1134 op->x = op->env->x, op->y = op->env->y; 971 x = env->x, y = env->y;
1135 op->map = op->env->map; 972 map = env->map;
1136 op->above = NULL, op->below = NULL; 973 above = 0, below = 0;
1137 op->env = NULL; 974 env = 0;
1138 } 975 }
1139 else if (op->map) 976 else if (map)
1140 { 977 {
1141 x = op->x;
1142 y = op->y;
1143 m = get_map_from_coord (op->map, &x, &y);
1144
1145 if (!m)
1146 {
1147 LOG (llevError, "remove_ob called when object was on map but appears to not be within valid coordinates? %s (%d,%d)\n",
1148 op->map->path, op->x, op->y);
1149 /* in old days, we used to set x and y to 0 and continue.
1150 * it seems if we get into this case, something is probablye
1151 * screwed up and should be fixed.
1152 */
1153 abort ();
1154 }
1155
1156 if (op->map != m)
1157 LOG (llevDebug, "remove_ob: Object not really on map it claimed to be on? %s != %s, %d,%d != %d,%d\n",
1158 op->map->path, m->path, op->x, op->y, x, y);
1159
1160 /* Re did the following section of code - it looks like it had 978 /* Re did the following section of code - it looks like it had
1161 * lots of logic for things we no longer care about 979 * lots of logic for things we no longer care about
1162 */ 980 */
1163 981
1164 /* link the object above us */ 982 /* link the object above us */
1165 if (op->above) 983 if (above)
1166 op->above->below = op->below; 984 above->below = below;
1167 else 985 else
1168 SET_MAP_TOP (m, x, y, op->below); /* we were top, set new top */ 986 map->at (x, y).top = below; /* we were top, set new top */
1169 987
1170 /* Relink the object below us, if there is one */ 988 /* Relink the object below us, if there is one */
1171 if (op->below) 989 if (below)
1172 op->below->above = op->above; 990 below->above = above;
1173 else 991 else
1174 { 992 {
1175 /* Nothing below, which means we need to relink map object for this space 993 /* Nothing below, which means we need to relink map object for this space
1176 * use translated coordinates in case some oddness with map tiling is 994 * use translated coordinates in case some oddness with map tiling is
1177 * evident 995 * evident
1178 */ 996 */
1179 if (GET_MAP_OB (m, x, y) != op) 997 if (GET_MAP_OB (map, x, y) != this)
1180 { 998 {
1181 dump_object (op); 999 char *dump = dump_object (this);
1182 LOG (llevError, 1000 LOG (llevError,
1183 "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", errmsg); 1001 "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", dump);
1002 free (dump);
1184 dump_object (GET_MAP_OB (m, x, y)); 1003 dump = dump_object (GET_MAP_OB (map, x, y));
1185 LOG (llevError, "%s\n", errmsg); 1004 LOG (llevError, "%s\n", dump);
1005 free (dump);
1186 } 1006 }
1187 1007
1188 SET_MAP_OB (m, x, y, op->above); /* goes on above it. */ 1008 map->at (x, y).bot = above; /* goes on above it. */
1189 } 1009 }
1190 1010
1191 op->above = 0; 1011 above = 0;
1192 op->below = 0; 1012 below = 0;
1193 1013
1194 if (op->map->in_memory == MAP_SAVING) 1014 if (map->in_memory == MAP_SAVING)
1195 return; 1015 return;
1196 1016
1197 check_walk_off = !QUERY_FLAG (op, FLAG_NO_APPLY); 1017 int check_walk_off = !flag [FLAG_NO_APPLY];
1198 1018
1199 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1019 for (tmp = GET_MAP_OB (map, x, y); tmp; tmp = tmp->above)
1200 { 1020 {
1201 /* No point updating the players look faces if he is the object 1021 /* No point updating the players look faces if he is the object
1202 * being removed. 1022 * being removed.
1203 */ 1023 */
1204 1024
1205 if (tmp->type == PLAYER && tmp != op) 1025 if (tmp->type == PLAYER && tmp != this)
1206 { 1026 {
1207 /* If a container that the player is currently using somehow gets 1027 /* If a container that the player is currently using somehow gets
1208 * removed (most likely destroyed), update the player view 1028 * removed (most likely destroyed), update the player view
1209 * appropriately. 1029 * appropriately.
1210 */ 1030 */
1211 if (tmp->container == op) 1031 if (tmp->container == this)
1212 { 1032 {
1213 CLEAR_FLAG (op, FLAG_APPLIED); 1033 flag [FLAG_APPLIED] = 0;
1214 tmp->container = NULL; 1034 tmp->container = 0;
1215 } 1035 }
1216 1036
1217 tmp->contr->socket.update_look = 1; 1037 if (tmp->contr->ns)
1038 tmp->contr->ns->floorbox_update ();
1218 } 1039 }
1219 1040
1220 /* See if player moving off should effect something */ 1041 /* See if player moving off should effect something */
1221 if (check_walk_off 1042 if (check_walk_off
1222 && ((op->move_type & tmp->move_off) 1043 && ((move_type & tmp->move_off)
1223 && (op->move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1044 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0))
1224 { 1045 {
1225 move_apply (tmp, op, NULL); 1046 move_apply (tmp, this, 0);
1226 1047
1227 if (op->destroyed ()) 1048 if (destroyed ())
1228 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ()); 1049 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1229 } 1050 }
1230 1051
1231 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */ 1052 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */
1232 1053
1233 if (tmp->above == tmp) 1054 if (tmp->above == tmp)
1234 tmp->above = NULL; 1055 tmp->above = 0;
1235 1056
1236 last = tmp; 1057 last = tmp;
1237 } 1058 }
1238 1059
1239 /* last == NULL of there are no objects on this space */ 1060 /* last == NULL of there are no objects on this space */
1240 if (last == NULL) 1061 if (!last)
1241 { 1062 map->at (x, y).flags_ = P_NEED_UPDATE;
1242 /* set P_NEED_UPDATE, otherwise update_position will complain. In theory,
1243 * we could preserve the flags (GET_MAP_FLAGS), but update_position figures
1244 * those out anyways, and if there are any flags set right now, they won't
1245 * be correct anyways.
1246 */
1247 SET_MAP_FLAGS (op->map, op->x, op->y, P_NEED_UPDATE);
1248 update_position (op->map, op->x, op->y);
1249 }
1250 else 1063 else
1251 update_object (last, UP_OBJ_REMOVE); 1064 update_object (last, UP_OBJ_REMOVE);
1252 1065
1253 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) || (op->glow_radius != 0)) 1066 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1254 update_all_los (op->map, op->x, op->y); 1067 update_all_los (map, x, y);
1255 } 1068 }
1256} 1069}
1257 1070
1258/* 1071/*
1259 * merge_ob(op,top): 1072 * merge_ob(op,top):
1267merge_ob (object *op, object *top) 1080merge_ob (object *op, object *top)
1268{ 1081{
1269 if (!op->nrof) 1082 if (!op->nrof)
1270 return 0; 1083 return 0;
1271 1084
1272 if (top == NULL) 1085 if (top)
1273 for (top = op; top != NULL && top->above != NULL; top = top->above); 1086 for (top = op; top && top->above; top = top->above)
1087 ;
1274 1088
1275 for (; top != NULL; top = top->below) 1089 for (; top; top = top->below)
1276 { 1090 {
1277 if (top == op) 1091 if (top == op)
1278 continue; 1092 continue;
1279 if (CAN_MERGE (op, top)) 1093
1094 if (object::can_merge (op, top))
1280 { 1095 {
1281 top->nrof += op->nrof; 1096 top->nrof += op->nrof;
1282 1097
1283/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/ 1098/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/
1284 op->weight = 0; /* Don't want any adjustements now */ 1099 op->weight = 0; /* Don't want any adjustements now */
1285 remove_ob (op); 1100 op->destroy ();
1286 free_object (op);
1287 return top; 1101 return top;
1288 } 1102 }
1289 } 1103 }
1290 1104
1291 return 0; 1105 return 0;
1330 * Return value: 1144 * Return value:
1331 * new object if 'op' was merged with other object 1145 * new object if 'op' was merged with other object
1332 * NULL if 'op' was destroyed 1146 * NULL if 'op' was destroyed
1333 * just 'op' otherwise 1147 * just 'op' otherwise
1334 */ 1148 */
1335
1336object * 1149object *
1337insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1150insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1338{ 1151{
1339 object *tmp, *top, *floor = NULL; 1152 object *tmp, *top, *floor = NULL;
1340 sint16 x, y; 1153 sint16 x, y;
1345 return NULL; 1158 return NULL;
1346 } 1159 }
1347 1160
1348 if (m == NULL) 1161 if (m == NULL)
1349 { 1162 {
1350 dump_object (op); 1163 char *dump = dump_object (op);
1351 LOG (llevError, "Trying to insert in null-map!\n%s\n", errmsg); 1164 LOG (llevError, "Trying to insert in null-map!\n%s\n", dump);
1165 free (dump);
1352 return op; 1166 return op;
1353 } 1167 }
1354 1168
1355 if (out_of_map (m, op->x, op->y)) 1169 if (out_of_map (m, op->x, op->y))
1356 { 1170 {
1357 dump_object (op); 1171 char *dump = dump_object (op);
1358 LOG (llevError, "Trying to insert object outside the map.\n%s\n", errmsg); 1172 LOG (llevError, "Trying to insert object outside the map.\n%s\n", dump);
1359#ifdef MANY_CORES 1173#ifdef MANY_CORES
1360 /* Better to catch this here, as otherwise the next use of this object 1174 /* Better to catch this here, as otherwise the next use of this object
1361 * is likely to cause a crash. Better to find out where it is getting 1175 * is likely to cause a crash. Better to find out where it is getting
1362 * improperly inserted. 1176 * improperly inserted.
1363 */ 1177 */
1364 abort (); 1178 abort ();
1365#endif 1179#endif
1180 free (dump);
1366 return op; 1181 return op;
1367 } 1182 }
1368 1183
1369 if (!QUERY_FLAG (op, FLAG_REMOVED)) 1184 if (!QUERY_FLAG (op, FLAG_REMOVED))
1370 { 1185 {
1371 dump_object (op); 1186 char *dump = dump_object (op);
1372 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", errmsg); 1187 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", dump);
1188 free (dump);
1373 return op; 1189 return op;
1374 } 1190 }
1375 1191
1376 if (op->more != NULL) 1192 if (op->more)
1377 { 1193 {
1378 /* The part may be on a different map. */ 1194 /* The part may be on a different map. */
1379 1195
1380 object *more = op->more; 1196 object *more = op->more;
1381 1197
1397 if (insert_ob_in_map (more, more->map, originator, flag) == NULL) 1213 if (insert_ob_in_map (more, more->map, originator, flag) == NULL)
1398 { 1214 {
1399 if (!op->head) 1215 if (!op->head)
1400 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n"); 1216 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n");
1401 1217
1402 return NULL; 1218 return 0;
1403 } 1219 }
1404 } 1220 }
1405 1221
1406 CLEAR_FLAG (op, FLAG_REMOVED); 1222 CLEAR_FLAG (op, FLAG_REMOVED);
1407 1223
1415 1231
1416 /* this has to be done after we translate the coordinates. 1232 /* this has to be done after we translate the coordinates.
1417 */ 1233 */
1418 if (op->nrof && !(flag & INS_NO_MERGE)) 1234 if (op->nrof && !(flag & INS_NO_MERGE))
1419 for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above) 1235 for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above)
1420 if (CAN_MERGE (op, tmp)) 1236 if (object::can_merge (op, tmp))
1421 { 1237 {
1422 op->nrof += tmp->nrof; 1238 op->nrof += tmp->nrof;
1423 remove_ob (tmp); 1239 tmp->destroy ();
1424 free_object (tmp);
1425 } 1240 }
1426 1241
1427 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1242 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1428 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1243 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1429 1244
1442 op->below = originator->below; 1257 op->below = originator->below;
1443 1258
1444 if (op->below) 1259 if (op->below)
1445 op->below->above = op; 1260 op->below->above = op;
1446 else 1261 else
1447 SET_MAP_OB (op->map, op->x, op->y, op); 1262 op->ms ().bot = op;
1448 1263
1449 /* since *below* originator, no need to update top */ 1264 /* since *below* originator, no need to update top */
1450 originator->below = op; 1265 originator->below = op;
1451 } 1266 }
1452 else 1267 else
1498 * If INS_ON_TOP is used, don't do this processing 1313 * If INS_ON_TOP is used, don't do this processing
1499 * Need to find the object that in fact blocks view, otherwise 1314 * Need to find the object that in fact blocks view, otherwise
1500 * stacking is a bit odd. 1315 * stacking is a bit odd.
1501 */ 1316 */
1502 if (!(flag & INS_ON_TOP) && 1317 if (!(flag & INS_ON_TOP) &&
1503 (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_BLOCKSVIEW) && (op->face && !op->face->visibility)) 1318 (get_map_flags (op->map, 0, op->x, op->y, 0, 0) & P_BLOCKSVIEW) && (op->face && !op->face->visibility))
1504 { 1319 {
1505 for (last = top; last != floor; last = last->below) 1320 for (last = top; last != floor; last = last->below)
1506 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1321 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1507 break; 1322 break;
1508 /* Check to see if we found the object that blocks view, 1323 /* Check to see if we found the object that blocks view,
1531 1346
1532 if (op->above) 1347 if (op->above)
1533 op->above->below = op; 1348 op->above->below = op;
1534 1349
1535 op->below = NULL; 1350 op->below = NULL;
1536 SET_MAP_OB (op->map, op->x, op->y, op); 1351 op->ms ().bot = op;
1537 } 1352 }
1538 else 1353 else
1539 { /* get inserted into the stack above top */ 1354 { /* get inserted into the stack above top */
1540 op->above = top->above; 1355 op->above = top->above;
1541 1356
1545 op->below = top; 1360 op->below = top;
1546 top->above = op; 1361 top->above = op;
1547 } 1362 }
1548 1363
1549 if (op->above == NULL) 1364 if (op->above == NULL)
1550 SET_MAP_TOP (op->map, op->x, op->y, op); 1365 op->ms ().top = op;
1551 } /* else not INS_BELOW_ORIGINATOR */ 1366 } /* else not INS_BELOW_ORIGINATOR */
1552 1367
1553 if (op->type == PLAYER) 1368 if (op->type == PLAYER)
1554 op->contr->do_los = 1; 1369 op->contr->do_los = 1;
1555 1370
1556 /* If we have a floor, we know the player, if any, will be above 1371 /* If we have a floor, we know the player, if any, will be above
1557 * it, so save a few ticks and start from there. 1372 * it, so save a few ticks and start from there.
1558 */ 1373 */
1559 if (!(flag & INS_MAP_LOAD)) 1374 if (!(flag & INS_MAP_LOAD))
1560 for (tmp = floor ? floor : GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1375 if (object *pl = op->ms ().player ())
1561 if (tmp->type == PLAYER) 1376 if (pl->contr->ns)
1562 tmp->contr->socket.update_look = 1; 1377 pl->contr->ns->floorbox_update ();
1563 1378
1564 /* If this object glows, it may affect lighting conditions that are 1379 /* If this object glows, it may affect lighting conditions that are
1565 * visible to others on this map. But update_all_los is really 1380 * visible to others on this map. But update_all_los is really
1566 * an inefficient way to do this, as it means los for all players 1381 * an inefficient way to do this, as it means los for all players
1567 * on the map will get recalculated. The players could very well 1382 * on the map will get recalculated. The players could very well
1568 * be far away from this change and not affected in any way - 1383 * be far away from this change and not affected in any way -
1569 * this should get redone to only look for players within range, 1384 * this should get redone to only look for players within range,
1570 * or just updating the P_NEED_UPDATE for spaces within this area 1385 * or just updating the P_NEED_UPDATE for spaces within this area
1571 * of effect may be sufficient. 1386 * of effect may be sufficient.
1572 */ 1387 */
1573 if (MAP_DARKNESS (op->map) && (op->glow_radius != 0)) 1388 if (op->map->darkness && (op->glow_radius != 0))
1574 update_all_los (op->map, op->x, op->y); 1389 update_all_los (op->map, op->x, op->y);
1575 1390
1576 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1391 /* updates flags (blocked, alive, no magic, etc) for this map space */
1577 update_object (op, UP_OBJ_INSERT); 1392 update_object (op, UP_OBJ_INSERT);
1578 1393
1394 INVOKE_OBJECT (INSERT, op);
1395
1579 /* Don't know if moving this to the end will break anything. However, 1396 /* Don't know if moving this to the end will break anything. However,
1580 * we want to have update_look set above before calling this. 1397 * we want to have floorbox_update called before calling this.
1581 * 1398 *
1582 * check_move_on() must be after this because code called from 1399 * check_move_on() must be after this because code called from
1583 * check_move_on() depends on correct map flags (so functions like 1400 * check_move_on() depends on correct map flags (so functions like
1584 * blocked() and wall() work properly), and these flags are updated by 1401 * blocked() and wall() work properly), and these flags are updated by
1585 * update_object(). 1402 * update_object().
1587 1404
1588 /* if this is not the head or flag has been passed, don't check walk on status */ 1405 /* if this is not the head or flag has been passed, don't check walk on status */
1589 if (!(flag & INS_NO_WALK_ON) && !op->head) 1406 if (!(flag & INS_NO_WALK_ON) && !op->head)
1590 { 1407 {
1591 if (check_move_on (op, originator)) 1408 if (check_move_on (op, originator))
1592 return NULL; 1409 return 0;
1593 1410
1594 /* If we are a multi part object, lets work our way through the check 1411 /* If we are a multi part object, lets work our way through the check
1595 * walk on's. 1412 * walk on's.
1596 */ 1413 */
1597 for (tmp = op->more; tmp != NULL; tmp = tmp->more) 1414 for (tmp = op->more; tmp != NULL; tmp = tmp->more)
1598 if (check_move_on (tmp, originator)) 1415 if (check_move_on (tmp, originator))
1599 return NULL; 1416 return 0;
1600 } 1417 }
1601 1418
1602 return op; 1419 return op;
1603} 1420}
1604 1421
1605/* this function inserts an object in the map, but if it 1422/* this function inserts an object in the map, but if it
1606 * finds an object of its own type, it'll remove that one first. 1423 * finds an object of its own type, it'll remove that one first.
1607 * op is the object to insert it under: supplies x and the map. 1424 * op is the object to insert it under: supplies x and the map.
1608 */ 1425 */
1609void 1426void
1610replace_insert_ob_in_map (const char *arch_string, object *op) 1427replace_insert_ob_in_map (const char *arch_string, object *op)
1611{ 1428{
1612 object * 1429 object *tmp, *tmp1;
1613 tmp;
1614 object *
1615 tmp1;
1616 1430
1617 /* first search for itself and remove any old instances */ 1431 /* first search for itself and remove any old instances */
1618 1432
1619 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1433 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above)
1620 {
1621 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */ 1434 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */
1622 { 1435 tmp->destroy ();
1623 remove_ob (tmp);
1624 free_object (tmp);
1625 }
1626 }
1627 1436
1628 tmp1 = arch_to_object (archetype::find (arch_string)); 1437 tmp1 = arch_to_object (archetype::find (arch_string));
1629 1438
1630 tmp1->x = op->x; 1439 tmp1->x = op->x;
1631 tmp1->y = op->y; 1440 tmp1->y = op->y;
1641 */ 1450 */
1642 1451
1643object * 1452object *
1644get_split_ob (object *orig_ob, uint32 nr) 1453get_split_ob (object *orig_ob, uint32 nr)
1645{ 1454{
1646 object * 1455 object *newob;
1647 newob;
1648 int
1649 is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0); 1456 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1650 1457
1651 if (orig_ob->nrof < nr) 1458 if (orig_ob->nrof < nr)
1652 { 1459 {
1653 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name); 1460 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1654 return NULL; 1461 return NULL;
1655 } 1462 }
1656 1463
1657 newob = object_create_clone (orig_ob); 1464 newob = object_create_clone (orig_ob);
1658 1465
1659 if ((orig_ob->nrof -= nr) < 1) 1466 if ((orig_ob->nrof -= nr) < 1)
1660 { 1467 orig_ob->destroy (1);
1661 if (!is_removed)
1662 remove_ob (orig_ob);
1663 free_object2 (orig_ob, 1);
1664 }
1665 else if (!is_removed) 1468 else if (!is_removed)
1666 { 1469 {
1667 if (orig_ob->env != NULL) 1470 if (orig_ob->env != NULL)
1668 sub_weight (orig_ob->env, orig_ob->weight * nr); 1471 sub_weight (orig_ob->env, orig_ob->weight * nr);
1669 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY) 1472 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY)
1689 1492
1690object * 1493object *
1691decrease_ob_nr (object *op, uint32 i) 1494decrease_ob_nr (object *op, uint32 i)
1692{ 1495{
1693 object *tmp; 1496 object *tmp;
1694 player *pl;
1695 1497
1696 if (i == 0) /* objects with op->nrof require this check */ 1498 if (i == 0) /* objects with op->nrof require this check */
1697 return op; 1499 return op;
1698 1500
1699 if (i > op->nrof) 1501 if (i > op->nrof)
1700 i = op->nrof; 1502 i = op->nrof;
1701 1503
1702 if (QUERY_FLAG (op, FLAG_REMOVED)) 1504 if (QUERY_FLAG (op, FLAG_REMOVED))
1703 op->nrof -= i; 1505 op->nrof -= i;
1704 else if (op->env != NULL) 1506 else if (op->env)
1705 { 1507 {
1706 /* is this object in the players inventory, or sub container 1508 /* is this object in the players inventory, or sub container
1707 * therein? 1509 * therein?
1708 */ 1510 */
1709 tmp = is_player_inv (op->env); 1511 tmp = op->in_player ();
1710 /* nope. Is this a container the player has opened? 1512 /* nope. Is this a container the player has opened?
1711 * If so, set tmp to that player. 1513 * If so, set tmp to that player.
1712 * IMO, searching through all the players will mostly 1514 * IMO, searching through all the players will mostly
1713 * likely be quicker than following op->env to the map, 1515 * likely be quicker than following op->env to the map,
1714 * and then searching the map for a player. 1516 * and then searching the map for a player.
1715 */ 1517 */
1716 if (!tmp) 1518 if (!tmp)
1717 { 1519 for_all_players (pl)
1718 for (pl = first_player; pl; pl = pl->next)
1719 if (pl->ob->container == op->env) 1520 if (pl->ob->container == op->env)
1521 {
1522 tmp = pl->ob;
1720 break; 1523 break;
1721 if (pl)
1722 tmp = pl->ob;
1723 else
1724 tmp = NULL;
1725 } 1524 }
1726 1525
1727 if (i < op->nrof) 1526 if (i < op->nrof)
1728 { 1527 {
1729 sub_weight (op->env, op->weight * i); 1528 sub_weight (op->env, op->weight * i);
1730 op->nrof -= i; 1529 op->nrof -= i;
1731 if (tmp) 1530 if (tmp)
1732 {
1733 esrv_send_item (tmp, op); 1531 esrv_send_item (tmp, op);
1734 }
1735 } 1532 }
1736 else 1533 else
1737 { 1534 {
1738 remove_ob (op); 1535 op->remove ();
1739 op->nrof = 0; 1536 op->nrof = 0;
1740 if (tmp) 1537 if (tmp)
1741 {
1742 esrv_del_item (tmp->contr, op->count); 1538 esrv_del_item (tmp->contr, op->count);
1743 }
1744 } 1539 }
1745 } 1540 }
1746 else 1541 else
1747 { 1542 {
1748 object *above = op->above; 1543 object *above = op->above;
1749 1544
1750 if (i < op->nrof) 1545 if (i < op->nrof)
1751 op->nrof -= i; 1546 op->nrof -= i;
1752 else 1547 else
1753 { 1548 {
1754 remove_ob (op); 1549 op->remove ();
1755 op->nrof = 0; 1550 op->nrof = 0;
1756 } 1551 }
1757 1552
1758 /* Since we just removed op, op->above is null */ 1553 /* Since we just removed op, op->above is null */
1759 for (tmp = above; tmp != NULL; tmp = tmp->above) 1554 for (tmp = above; tmp; tmp = tmp->above)
1760 if (tmp->type == PLAYER) 1555 if (tmp->type == PLAYER)
1761 { 1556 {
1762 if (op->nrof) 1557 if (op->nrof)
1763 esrv_send_item (tmp, op); 1558 esrv_send_item (tmp, op);
1764 else 1559 else
1768 1563
1769 if (op->nrof) 1564 if (op->nrof)
1770 return op; 1565 return op;
1771 else 1566 else
1772 { 1567 {
1773 free_object (op); 1568 op->destroy ();
1774 return NULL; 1569 return 0;
1775 } 1570 }
1776} 1571}
1777 1572
1778/* 1573/*
1779 * add_weight(object, weight) adds the specified weight to an object, 1574 * add_weight(object, weight) adds the specified weight to an object,
1791 op->carrying += weight; 1586 op->carrying += weight;
1792 op = op->env; 1587 op = op->env;
1793 } 1588 }
1794} 1589}
1795 1590
1591object *
1592insert_ob_in_ob (object *op, object *where)
1593{
1594 if (!where)
1595 {
1596 char *dump = dump_object (op);
1597 LOG (llevError, "Trying to put object in NULL.\n%s\n", dump);
1598 free (dump);
1599 return op;
1600 }
1601
1602 if (where->head)
1603 {
1604 LOG (llevDebug, "Warning: Tried to insert object into wrong part of multipart object.\n");
1605 where = where->head;
1606 }
1607
1608 return where->insert (op);
1609}
1610
1796/* 1611/*
1797 * insert_ob_in_ob(op,environment): 1612 * env->insert (op)
1798 * This function inserts the object op in the linked list 1613 * This function inserts the object op in the linked list
1799 * inside the object environment. 1614 * inside the object environment.
1800 * 1615 *
1801 * Eneq(@csd.uu.se): Altered insert_ob_in_ob to make things picked up enter
1802 * the inventory at the last position or next to other objects of the same
1803 * type.
1804 * Frank: Now sorted by type, archetype and magic!
1805 *
1806 * The function returns now pointer to inserted item, and return value can 1616 * The function returns now pointer to inserted item, and return value can
1807 * be != op, if items are merged. -Tero 1617 * be != op, if items are merged. -Tero
1808 */ 1618 */
1809 1619
1810object * 1620object *
1811insert_ob_in_ob (object *op, object *where) 1621object::insert (object *op)
1812{ 1622{
1813 object * 1623 object *tmp, *otmp;
1814 tmp, *
1815 otmp;
1816 1624
1817 if (!QUERY_FLAG (op, FLAG_REMOVED)) 1625 if (!QUERY_FLAG (op, FLAG_REMOVED))
1818 { 1626 op->remove ();
1819 dump_object (op);
1820 LOG (llevError, "Trying to insert (ob) inserted object.\n%s\n", errmsg);
1821 return op;
1822 }
1823
1824 if (where == NULL)
1825 {
1826 dump_object (op);
1827 LOG (llevError, "Trying to put object in NULL.\n%s\n", errmsg);
1828 return op;
1829 }
1830
1831 if (where->head)
1832 {
1833 LOG (llevDebug, "Warning: Tried to insert object wrong part of multipart object.\n");
1834 where = where->head;
1835 }
1836 1627
1837 if (op->more) 1628 if (op->more)
1838 { 1629 {
1839 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count); 1630 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);
1840 return op; 1631 return op;
1842 1633
1843 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL); 1634 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL);
1844 CLEAR_FLAG (op, FLAG_REMOVED); 1635 CLEAR_FLAG (op, FLAG_REMOVED);
1845 if (op->nrof) 1636 if (op->nrof)
1846 { 1637 {
1847 for (tmp = where->inv; tmp != NULL; tmp = tmp->below) 1638 for (tmp = inv; tmp != NULL; tmp = tmp->below)
1848 if (CAN_MERGE (tmp, op)) 1639 if (object::can_merge (tmp, op))
1849 { 1640 {
1850 /* return the original object and remove inserted object 1641 /* return the original object and remove inserted object
1851 (client needs the original object) */ 1642 (client needs the original object) */
1852 tmp->nrof += op->nrof; 1643 tmp->nrof += op->nrof;
1853 /* Weight handling gets pretty funky. Since we are adding to 1644 /* Weight handling gets pretty funky. Since we are adding to
1854 * tmp->nrof, we need to increase the weight. 1645 * tmp->nrof, we need to increase the weight.
1855 */ 1646 */
1856 add_weight (where, op->weight * op->nrof); 1647 add_weight (this, op->weight * op->nrof);
1857 SET_FLAG (op, FLAG_REMOVED); 1648 SET_FLAG (op, FLAG_REMOVED);
1858 free_object (op); /* free the inserted object */ 1649 op->destroy (); /* free the inserted object */
1859 op = tmp; 1650 op = tmp;
1860 remove_ob (op); /* and fix old object's links */ 1651 op->remove (); /* and fix old object's links */
1861 CLEAR_FLAG (op, FLAG_REMOVED); 1652 CLEAR_FLAG (op, FLAG_REMOVED);
1862 break; 1653 break;
1863 } 1654 }
1864 1655
1865 /* I assume combined objects have no inventory 1656 /* I assume combined objects have no inventory
1866 * We add the weight - this object could have just been removed 1657 * We add the weight - this object could have just been removed
1867 * (if it was possible to merge). calling remove_ob will subtract 1658 * (if it was possible to merge). calling remove_ob will subtract
1868 * the weight, so we need to add it in again, since we actually do 1659 * the weight, so we need to add it in again, since we actually do
1869 * the linking below 1660 * the linking below
1870 */ 1661 */
1871 add_weight (where, op->weight * op->nrof); 1662 add_weight (this, op->weight * op->nrof);
1872 } 1663 }
1873 else 1664 else
1874 add_weight (where, (op->weight + op->carrying)); 1665 add_weight (this, (op->weight + op->carrying));
1875 1666
1876 otmp = is_player_inv (where); 1667 otmp = this->in_player ();
1877 if (otmp && otmp->contr != NULL) 1668 if (otmp && otmp->contr)
1878 {
1879 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1669 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1880 fix_player (otmp); 1670 otmp->update_stats ();
1881 }
1882 1671
1883 op->map = NULL; 1672 op->map = 0;
1884 op->env = where; 1673 op->env = this;
1885 op->above = NULL; 1674 op->above = 0;
1886 op->below = NULL; 1675 op->below = 0;
1887 op->x = 0, op->y = 0; 1676 op->x = 0, op->y = 0;
1888 1677
1889 /* reset the light list and los of the players on the map */ 1678 /* reset the light list and los of the players on the map */
1890 if ((op->glow_radius != 0) && where->map) 1679 if ((op->glow_radius != 0) && map)
1891 { 1680 {
1892#ifdef DEBUG_LIGHTS 1681#ifdef DEBUG_LIGHTS
1893 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name); 1682 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1894#endif /* DEBUG_LIGHTS */ 1683#endif /* DEBUG_LIGHTS */
1895 if (MAP_DARKNESS (where->map)) 1684 if (map->darkness)
1896 update_all_los (where->map, where->x, where->y); 1685 update_all_los (map, x, y);
1897 } 1686 }
1898 1687
1899 /* Client has no idea of ordering so lets not bother ordering it here. 1688 /* Client has no idea of ordering so lets not bother ordering it here.
1900 * It sure simplifies this function... 1689 * It sure simplifies this function...
1901 */ 1690 */
1902 if (where->inv == NULL) 1691 if (!inv)
1903 where->inv = op; 1692 inv = op;
1904 else 1693 else
1905 { 1694 {
1906 op->below = where->inv; 1695 op->below = inv;
1907 op->below->above = op; 1696 op->below->above = op;
1908 where->inv = op; 1697 inv = op;
1909 } 1698 }
1699
1700 INVOKE_OBJECT (INSERT, this);
1701
1910 return op; 1702 return op;
1911} 1703}
1912 1704
1913/* 1705/*
1914 * Checks if any objects has a move_type that matches objects 1706 * Checks if any objects has a move_type that matches objects
1965 1757
1966 /* The objects have to be checked from top to bottom. 1758 /* The objects have to be checked from top to bottom.
1967 * Hence, we first go to the top: 1759 * Hence, we first go to the top:
1968 */ 1760 */
1969 1761
1970 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL && tmp->above != NULL; tmp = tmp->above) 1762 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp && tmp->above; tmp = tmp->above)
1971 { 1763 {
1972 /* Trim the search when we find the first other spell effect 1764 /* Trim the search when we find the first other spell effect
1973 * this helps performance so that if a space has 50 spell objects, 1765 * this helps performance so that if a space has 50 spell objects,
1974 * we don't need to check all of them. 1766 * we don't need to check all of them.
1975 */ 1767 */
2030/* 1822/*
2031 * present_arch(arch, map, x, y) searches for any objects with 1823 * present_arch(arch, map, x, y) searches for any objects with
2032 * a matching archetype at the given map and coordinates. 1824 * a matching archetype at the given map and coordinates.
2033 * The first matching object is returned, or NULL if none. 1825 * The first matching object is returned, or NULL if none.
2034 */ 1826 */
2035
2036object * 1827object *
2037present_arch (const archetype *at, maptile *m, int x, int y) 1828present_arch (const archetype *at, maptile *m, int x, int y)
2038{ 1829{
2039 object *
2040 tmp;
2041
2042 if (m == NULL || out_of_map (m, x, y)) 1830 if (m == NULL || out_of_map (m, x, y))
2043 { 1831 {
2044 LOG (llevError, "Present_arch called outside map.\n"); 1832 LOG (llevError, "Present_arch called outside map.\n");
2045 return NULL; 1833 return NULL;
2046 } 1834 }
1835
2047 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1836 for (object *tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above)
2048 if (tmp->arch == at) 1837 if (tmp->arch == at)
2049 return tmp; 1838 return tmp;
1839
2050 return NULL; 1840 return NULL;
2051} 1841}
2052 1842
2053/* 1843/*
2054 * present(type, map, x, y) searches for any objects with 1844 * present(type, map, x, y) searches for any objects with
2055 * a matching type variable at the given map and coordinates. 1845 * a matching type variable at the given map and coordinates.
2056 * The first matching object is returned, or NULL if none. 1846 * The first matching object is returned, or NULL if none.
2057 */ 1847 */
2058
2059object * 1848object *
2060present (unsigned char type, maptile *m, int x, int y) 1849present (unsigned char type, maptile *m, int x, int y)
2061{ 1850{
2062 object *
2063 tmp;
2064
2065 if (out_of_map (m, x, y)) 1851 if (out_of_map (m, x, y))
2066 { 1852 {
2067 LOG (llevError, "Present called outside map.\n"); 1853 LOG (llevError, "Present called outside map.\n");
2068 return NULL; 1854 return NULL;
2069 } 1855 }
1856
2070 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1857 for (object *tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above)
2071 if (tmp->type == type) 1858 if (tmp->type == type)
2072 return tmp; 1859 return tmp;
1860
2073 return NULL; 1861 return NULL;
2074} 1862}
2075 1863
2076/* 1864/*
2077 * present_in_ob(type, object) searches for any objects with 1865 * present_in_ob(type, object) searches for any objects with
2078 * a matching type variable in the inventory of the given object. 1866 * a matching type variable in the inventory of the given object.
2079 * The first matching object is returned, or NULL if none. 1867 * The first matching object is returned, or NULL if none.
2080 */ 1868 */
2081
2082object * 1869object *
2083present_in_ob (unsigned char type, const object *op) 1870present_in_ob (unsigned char type, const object *op)
2084{ 1871{
2085 object *
2086 tmp;
2087
2088 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1872 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2089 if (tmp->type == type) 1873 if (tmp->type == type)
2090 return tmp; 1874 return tmp;
1875
2091 return NULL; 1876 return NULL;
2092} 1877}
2093 1878
2094/* 1879/*
2095 * present_in_ob (type, str, object) searches for any objects with 1880 * present_in_ob (type, str, object) searches for any objects with
2103 * str is the string to match against. Note that we match against 1888 * str is the string to match against. Note that we match against
2104 * the object name, not the archetype name. this is so that the 1889 * the object name, not the archetype name. this is so that the
2105 * spell code can use one object type (force), but change it's name 1890 * spell code can use one object type (force), but change it's name
2106 * to be unique. 1891 * to be unique.
2107 */ 1892 */
2108
2109object * 1893object *
2110present_in_ob_by_name (int type, const char *str, const object *op) 1894present_in_ob_by_name (int type, const char *str, const object *op)
2111{ 1895{
2112 object *
2113 tmp;
2114
2115 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1896 for (object *tmp = op->inv; tmp; tmp = tmp->below)
2116 {
2117 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name))) 1897 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name)))
2118 return tmp; 1898 return tmp;
2119 } 1899
2120 return NULL; 1900 return 0;
2121} 1901}
2122 1902
2123/* 1903/*
2124 * present_arch_in_ob(archetype, object) searches for any objects with 1904 * present_arch_in_ob(archetype, object) searches for any objects with
2125 * a matching archetype in the inventory of the given object. 1905 * a matching archetype in the inventory of the given object.
2126 * The first matching object is returned, or NULL if none. 1906 * The first matching object is returned, or NULL if none.
2127 */ 1907 */
2128
2129object * 1908object *
2130present_arch_in_ob (const archetype *at, const object *op) 1909present_arch_in_ob (const archetype *at, const object *op)
2131{ 1910{
2132 object *
2133 tmp;
2134
2135 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1911 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2136 if (tmp->arch == at) 1912 if (tmp->arch == at)
2137 return tmp; 1913 return tmp;
1914
2138 return NULL; 1915 return NULL;
2139} 1916}
2140 1917
2141/* 1918/*
2142 * activate recursively a flag on an object inventory 1919 * activate recursively a flag on an object inventory
2143 */ 1920 */
2144void 1921void
2145flag_inv (object *op, int flag) 1922flag_inv (object *op, int flag)
2146{ 1923{
2147 object *
2148 tmp;
2149
2150 if (op->inv) 1924 if (op->inv)
2151 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1925 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2152 { 1926 {
2153 SET_FLAG (tmp, flag); 1927 SET_FLAG (tmp, flag);
2154 flag_inv (tmp, flag); 1928 flag_inv (tmp, flag);
2155 } 1929 }
2156} /* 1930}
1931
1932/*
2157 * desactivate recursively a flag on an object inventory 1933 * deactivate recursively a flag on an object inventory
2158 */ 1934 */
2159void 1935void
2160unflag_inv (object *op, int flag) 1936unflag_inv (object *op, int flag)
2161{ 1937{
2162 object *
2163 tmp;
2164
2165 if (op->inv) 1938 if (op->inv)
2166 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1939 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2167 { 1940 {
2168 CLEAR_FLAG (tmp, flag); 1941 CLEAR_FLAG (tmp, flag);
2169 unflag_inv (tmp, flag); 1942 unflag_inv (tmp, flag);
2170 } 1943 }
2171} 1944}
2174 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in 1947 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in
2175 * all it's inventory (recursively). 1948 * all it's inventory (recursively).
2176 * If checksums are used, a player will get set_cheat called for 1949 * If checksums are used, a player will get set_cheat called for
2177 * him/her-self and all object carried by a call to this function. 1950 * him/her-self and all object carried by a call to this function.
2178 */ 1951 */
2179
2180void 1952void
2181set_cheat (object *op) 1953set_cheat (object *op)
2182{ 1954{
2183 SET_FLAG (op, FLAG_WAS_WIZ); 1955 SET_FLAG (op, FLAG_WAS_WIZ);
2184 flag_inv (op, FLAG_WAS_WIZ); 1956 flag_inv (op, FLAG_WAS_WIZ);
2203 * because arch_blocked (now ob_blocked) needs to know the movement type 1975 * because arch_blocked (now ob_blocked) needs to know the movement type
2204 * to know if the space in question will block the object. We can't use 1976 * to know if the space in question will block the object. We can't use
2205 * the archetype because that isn't correct if the monster has been 1977 * the archetype because that isn't correct if the monster has been
2206 * customized, changed states, etc. 1978 * customized, changed states, etc.
2207 */ 1979 */
2208
2209int 1980int
2210find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop) 1981find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)
2211{ 1982{
2212 int
2213 i,
2214 index = 0, flag; 1983 int index = 0, flag;
2215 static int
2216 altern[SIZEOFFREE]; 1984 int altern[SIZEOFFREE];
2217 1985
2218 for (i = start; i < stop; i++) 1986 for (int i = start; i < stop; i++)
2219 { 1987 {
2220 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]); 1988 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]);
2221 if (!flag) 1989 if (!flag)
2222 altern[index++] = i; 1990 altern [index++] = i;
2223 1991
2224 /* Basically, if we find a wall on a space, we cut down the search size. 1992 /* Basically, if we find a wall on a space, we cut down the search size.
2225 * In this way, we won't return spaces that are on another side of a wall. 1993 * In this way, we won't return spaces that are on another side of a wall.
2226 * This mostly work, but it cuts down the search size in all directions - 1994 * This mostly work, but it cuts down the search size in all directions -
2227 * if the space being examined only has a wall to the north and empty 1995 * if the space being examined only has a wall to the north and empty
2228 * spaces in all the other directions, this will reduce the search space 1996 * spaces in all the other directions, this will reduce the search space
2229 * to only the spaces immediately surrounding the target area, and 1997 * to only the spaces immediately surrounding the target area, and
2230 * won't look 2 spaces south of the target space. 1998 * won't look 2 spaces south of the target space.
2231 */ 1999 */
2232 else if ((flag & AB_NO_PASS) && maxfree[i] < stop) 2000 else if ((flag & P_NO_PASS) && maxfree[i] < stop)
2233 stop = maxfree[i]; 2001 stop = maxfree[i];
2234 } 2002 }
2003
2235 if (!index) 2004 if (!index)
2236 return -1; 2005 return -1;
2006
2237 return altern[RANDOM () % index]; 2007 return altern[RANDOM () % index];
2238} 2008}
2239 2009
2240/* 2010/*
2241 * find_first_free_spot(archetype, maptile, x, y) works like 2011 * find_first_free_spot(archetype, maptile, x, y) works like
2242 * find_free_spot(), but it will search max number of squares. 2012 * find_free_spot(), but it will search max number of squares.
2243 * But it will return the first available spot, not a random choice. 2013 * But it will return the first available spot, not a random choice.
2244 * Changed 0.93.2: Have it return -1 if there is no free spot available. 2014 * Changed 0.93.2: Have it return -1 if there is no free spot available.
2245 */ 2015 */
2246
2247int 2016int
2248find_first_free_spot (const object *ob, maptile *m, int x, int y) 2017find_first_free_spot (const object *ob, maptile *m, int x, int y)
2249{ 2018{
2250 int
2251 i;
2252
2253 for (i = 0; i < SIZEOFFREE; i++) 2019 for (int i = 0; i < SIZEOFFREE; i++)
2254 {
2255 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i])) 2020 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]))
2256 return i; 2021 return i;
2257 } 2022
2258 return -1; 2023 return -1;
2259} 2024}
2260 2025
2261/* 2026/*
2262 * The function permute(arr, begin, end) randomly reorders the array 2027 * The function permute(arr, begin, end) randomly reorders the array
2263 * arr[begin..end-1]. 2028 * arr[begin..end-1].
2029 * now uses a fisher-yates shuffle, old permute was broken
2264 */ 2030 */
2265static void 2031static void
2266permute (int *arr, int begin, int end) 2032permute (int *arr, int begin, int end)
2267{ 2033{
2268 int 2034 arr += begin;
2269 i,
2270 j,
2271 tmp,
2272 len;
2273
2274 len = end - begin; 2035 end -= begin;
2275 for (i = begin; i < end; i++)
2276 {
2277 j = begin + RANDOM () % len;
2278 2036
2279 tmp = arr[i]; 2037 while (--end)
2280 arr[i] = arr[j]; 2038 swap (arr [end], arr [RANDOM () % (end + 1)]);
2281 arr[j] = tmp;
2282 }
2283} 2039}
2284 2040
2285/* new function to make monster searching more efficient, and effective! 2041/* new function to make monster searching more efficient, and effective!
2286 * This basically returns a randomized array (in the passed pointer) of 2042 * This basically returns a randomized array (in the passed pointer) of
2287 * the spaces to find monsters. In this way, it won't always look for 2043 * the spaces to find monsters. In this way, it won't always look for
2290 * the 3x3 area will be searched, just not in a predictable order. 2046 * the 3x3 area will be searched, just not in a predictable order.
2291 */ 2047 */
2292void 2048void
2293get_search_arr (int *search_arr) 2049get_search_arr (int *search_arr)
2294{ 2050{
2295 int 2051 int i;
2296 i;
2297 2052
2298 for (i = 0; i < SIZEOFFREE; i++) 2053 for (i = 0; i < SIZEOFFREE; i++)
2299 {
2300 search_arr[i] = i; 2054 search_arr[i] = i;
2301 }
2302 2055
2303 permute (search_arr, 1, SIZEOFFREE1 + 1); 2056 permute (search_arr, 1, SIZEOFFREE1 + 1);
2304 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1); 2057 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1);
2305 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE); 2058 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE);
2306} 2059}
2315 * Perhaps incorrectly, but I'm making the assumption that exclude 2068 * Perhaps incorrectly, but I'm making the assumption that exclude
2316 * is actually want is going to try and move there. We need this info 2069 * is actually want is going to try and move there. We need this info
2317 * because we have to know what movement the thing looking to move 2070 * because we have to know what movement the thing looking to move
2318 * there is capable of. 2071 * there is capable of.
2319 */ 2072 */
2320
2321int 2073int
2322find_dir (maptile *m, int x, int y, object *exclude) 2074find_dir (maptile *m, int x, int y, object *exclude)
2323{ 2075{
2324 int
2325 i,
2326 max = SIZEOFFREE, mflags; 2076 int i, max = SIZEOFFREE, mflags;
2327 2077
2328 sint16 nx, ny; 2078 sint16 nx, ny;
2329 object * 2079 object *tmp;
2330 tmp;
2331 maptile * 2080 maptile *mp;
2332 mp;
2333 2081
2334 MoveType blocked, move_type; 2082 MoveType blocked, move_type;
2335 2083
2336 if (exclude && exclude->head) 2084 if (exclude && exclude->head)
2337 { 2085 {
2349 mp = m; 2097 mp = m;
2350 nx = x + freearr_x[i]; 2098 nx = x + freearr_x[i];
2351 ny = y + freearr_y[i]; 2099 ny = y + freearr_y[i];
2352 2100
2353 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2101 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);
2102
2354 if (mflags & P_OUT_OF_MAP) 2103 if (mflags & P_OUT_OF_MAP)
2355 {
2356 max = maxfree[i]; 2104 max = maxfree[i];
2357 }
2358 else 2105 else
2359 { 2106 {
2360 blocked = GET_MAP_MOVE_BLOCK (mp, nx, ny); 2107 mapspace &ms = mp->at (nx, ny);
2108
2109 blocked = ms.move_block;
2361 2110
2362 if ((move_type & blocked) == move_type) 2111 if ((move_type & blocked) == move_type)
2363 {
2364 max = maxfree[i]; 2112 max = maxfree[i];
2365 }
2366 else if (mflags & P_IS_ALIVE) 2113 else if (mflags & P_IS_ALIVE)
2367 { 2114 {
2368 for (tmp = GET_MAP_OB (mp, nx, ny); tmp != NULL; tmp = tmp->above) 2115 for (tmp = ms.bot; tmp; tmp = tmp->above)
2369 { 2116 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)
2370 if ((QUERY_FLAG (tmp, FLAG_MONSTER) || tmp->type == PLAYER) && (tmp != exclude || (tmp->head && tmp->head != exclude))) 2117 && (tmp != exclude || (tmp->head && tmp->head != exclude)))
2371 {
2372 break; 2118 break;
2373 } 2119
2374 }
2375 if (tmp) 2120 if (tmp)
2376 {
2377 return freedir[i]; 2121 return freedir[i];
2378 }
2379 } 2122 }
2380 } 2123 }
2381 } 2124 }
2125
2382 return 0; 2126 return 0;
2383} 2127}
2384 2128
2385/* 2129/*
2386 * distance(object 1, object 2) will return the square of the 2130 * distance(object 1, object 2) will return the square of the
2387 * distance between the two given objects. 2131 * distance between the two given objects.
2388 */ 2132 */
2389
2390int 2133int
2391distance (const object *ob1, const object *ob2) 2134distance (const object *ob1, const object *ob2)
2392{ 2135{
2393 int
2394 i;
2395
2396 i = (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y); 2136 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2397 return i;
2398} 2137}
2399 2138
2400/* 2139/*
2401 * find_dir_2(delta-x,delta-y) will return a direction in which 2140 * find_dir_2(delta-x,delta-y) will return a direction in which
2402 * an object which has subtracted the x and y coordinates of another 2141 * an object which has subtracted the x and y coordinates of another
2403 * object, needs to travel toward it. 2142 * object, needs to travel toward it.
2404 */ 2143 */
2405
2406int 2144int
2407find_dir_2 (int x, int y) 2145find_dir_2 (int x, int y)
2408{ 2146{
2409 int 2147 int q;
2410 q;
2411 2148
2412 if (y) 2149 if (y)
2413 q = x * 100 / y; 2150 q = x * 100 / y;
2414 else if (x) 2151 else if (x)
2415 q = -300 * x; 2152 q = -300 * x;
2450int 2187int
2451absdir (int d) 2188absdir (int d)
2452{ 2189{
2453 while (d < 1) 2190 while (d < 1)
2454 d += 8; 2191 d += 8;
2192
2455 while (d > 8) 2193 while (d > 8)
2456 d -= 8; 2194 d -= 8;
2195
2457 return d; 2196 return d;
2458} 2197}
2459 2198
2460/* 2199/*
2461 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is 2200 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is
2463 */ 2202 */
2464 2203
2465int 2204int
2466dirdiff (int dir1, int dir2) 2205dirdiff (int dir1, int dir2)
2467{ 2206{
2468 int 2207 int d;
2469 d;
2470 2208
2471 d = abs (dir1 - dir2); 2209 d = abs (dir1 - dir2);
2472 if (d > 4) 2210 if (d > 4)
2473 d = 8 - d; 2211 d = 8 - d;
2212
2474 return d; 2213 return d;
2475} 2214}
2476 2215
2477/* peterm: 2216/* peterm:
2478 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster. 2217 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster.
2481 * This basically means that if direction is 15, then it could either go 2220 * This basically means that if direction is 15, then it could either go
2482 * direction 4, 14, or 16 to get back to where we are. 2221 * direction 4, 14, or 16 to get back to where we are.
2483 * Moved from spell_util.c to object.c with the other related direction 2222 * Moved from spell_util.c to object.c with the other related direction
2484 * functions. 2223 * functions.
2485 */ 2224 */
2486
2487int
2488 reduction_dir[SIZEOFFREE][3] = { 2225int reduction_dir[SIZEOFFREE][3] = {
2489 {0, 0, 0}, /* 0 */ 2226 {0, 0, 0}, /* 0 */
2490 {0, 0, 0}, /* 1 */ 2227 {0, 0, 0}, /* 1 */
2491 {0, 0, 0}, /* 2 */ 2228 {0, 0, 0}, /* 2 */
2492 {0, 0, 0}, /* 3 */ 2229 {0, 0, 0}, /* 3 */
2493 {0, 0, 0}, /* 4 */ 2230 {0, 0, 0}, /* 4 */
2541 * find a path to that monster that we found. If not, 2278 * find a path to that monster that we found. If not,
2542 * we don't bother going toward it. Returns 1 if we 2279 * we don't bother going toward it. Returns 1 if we
2543 * can see a direct way to get it 2280 * can see a direct way to get it
2544 * Modified to be map tile aware -.MSW 2281 * Modified to be map tile aware -.MSW
2545 */ 2282 */
2546
2547
2548int 2283int
2549can_see_monsterP (maptile *m, int x, int y, int dir) 2284can_see_monsterP (maptile *m, int x, int y, int dir)
2550{ 2285{
2551 sint16 dx, dy; 2286 sint16 dx, dy;
2552 int
2553 mflags; 2287 int mflags;
2554 2288
2555 if (dir < 0) 2289 if (dir < 0)
2556 return 0; /* exit condition: invalid direction */ 2290 return 0; /* exit condition: invalid direction */
2557 2291
2558 dx = x + freearr_x[dir]; 2292 dx = x + freearr_x[dir];
2571 return 0; 2305 return 0;
2572 2306
2573 /* yes, can see. */ 2307 /* yes, can see. */
2574 if (dir < 9) 2308 if (dir < 9)
2575 return 1; 2309 return 1;
2310
2576 return can_see_monsterP (m, x, y, reduction_dir[dir][0]) | 2311 return can_see_monsterP (m, x, y, reduction_dir[dir][0])
2577 can_see_monsterP (m, x, y, reduction_dir[dir][1]) | can_see_monsterP (m, x, y, reduction_dir[dir][2]); 2312 | can_see_monsterP (m, x, y, reduction_dir[dir][1])
2313 | can_see_monsterP (m, x, y, reduction_dir[dir][2]);
2578} 2314}
2579
2580
2581 2315
2582/* 2316/*
2583 * can_pick(picker, item): finds out if an object is possible to be 2317 * can_pick(picker, item): finds out if an object is possible to be
2584 * picked up by the picker. Returnes 1 if it can be 2318 * picked up by the picker. Returnes 1 if it can be
2585 * picked up, otherwise 0. 2319 * picked up, otherwise 0.
2596 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2330 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2597 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2331 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2598 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2332 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));
2599} 2333}
2600 2334
2601
2602/* 2335/*
2603 * create clone from object to another 2336 * create clone from object to another
2604 */ 2337 */
2605object * 2338object *
2606object_create_clone (object *asrc) 2339object_create_clone (object *asrc)
2607{ 2340{
2608 object *
2609 dst = NULL, *tmp, *src, *part, *prev, *item; 2341 object *dst = 0, *tmp, *src, *part, *prev, *item;
2610 2342
2611 if (!asrc) 2343 if (!asrc)
2612 return NULL; 2344 return 0;
2345
2613 src = asrc; 2346 src = asrc;
2614 if (src->head) 2347 if (src->head)
2615 src = src->head; 2348 src = src->head;
2616 2349
2617 prev = NULL; 2350 prev = 0;
2618 for (part = src; part; part = part->more) 2351 for (part = src; part; part = part->more)
2619 { 2352 {
2620 tmp = get_object (); 2353 tmp = part->clone ();
2621 copy_object (part, tmp);
2622 tmp->x -= src->x; 2354 tmp->x -= src->x;
2623 tmp->y -= src->y; 2355 tmp->y -= src->y;
2356
2624 if (!part->head) 2357 if (!part->head)
2625 { 2358 {
2626 dst = tmp; 2359 dst = tmp;
2627 tmp->head = NULL; 2360 tmp->head = 0;
2628 } 2361 }
2629 else 2362 else
2630 {
2631 tmp->head = dst; 2363 tmp->head = dst;
2632 } 2364
2633 tmp->more = NULL; 2365 tmp->more = 0;
2366
2634 if (prev) 2367 if (prev)
2635 prev->more = tmp; 2368 prev->more = tmp;
2369
2636 prev = tmp; 2370 prev = tmp;
2637 } 2371 }
2638 2372
2639 for (item = src->inv; item; item = item->below) 2373 for (item = src->inv; item; item = item->below)
2640 insert_ob_in_ob (object_create_clone (item), dst); 2374 insert_ob_in_ob (object_create_clone (item), dst);
2646/* Basically, we save the content of the string to a temp file, then call */ 2380/* Basically, we save the content of the string to a temp file, then call */
2647/* load_object on it. I admit it is a highly inefficient way to make things, */ 2381/* load_object on it. I admit it is a highly inefficient way to make things, */
2648/* but it was simple to make and allows reusing the load_object function. */ 2382/* but it was simple to make and allows reusing the load_object function. */
2649/* Remember not to use load_object_str in a time-critical situation. */ 2383/* Remember not to use load_object_str in a time-critical situation. */
2650/* Also remember that multiparts objects are not supported for now. */ 2384/* Also remember that multiparts objects are not supported for now. */
2651
2652object * 2385object *
2653load_object_str (const char *obstr) 2386load_object_str (const char *obstr)
2654{ 2387{
2655 object *op; 2388 object *op;
2656 char filename[MAX_BUF]; 2389 char filename[MAX_BUF];
2666 } 2399 }
2667 2400
2668 fprintf (tempfile, obstr); 2401 fprintf (tempfile, obstr);
2669 fclose (tempfile); 2402 fclose (tempfile);
2670 2403
2671 op = get_object (); 2404 op = object::create ();
2672 2405
2673 object_thawer thawer (filename); 2406 object_thawer thawer (filename);
2674 2407
2675 if (thawer) 2408 if (thawer)
2676 load_object (thawer, op, 0); 2409 load_object (thawer, op, 0);
2686 * returns NULL if no match. 2419 * returns NULL if no match.
2687 */ 2420 */
2688object * 2421object *
2689find_obj_by_type_subtype (const object *who, int type, int subtype) 2422find_obj_by_type_subtype (const object *who, int type, int subtype)
2690{ 2423{
2691 object *tmp;
2692
2693 for (tmp = who->inv; tmp; tmp = tmp->below) 2424 for (object *tmp = who->inv; tmp; tmp = tmp->below)
2694 if (tmp->type == type && tmp->subtype == subtype) 2425 if (tmp->type == type && tmp->subtype == subtype)
2695 return tmp; 2426 return tmp;
2696 2427
2697 return NULL; 2428 return 0;
2698} 2429}
2699 2430
2700/* If ob has a field named key, return the link from the list, 2431/* If ob has a field named key, return the link from the list,
2701 * otherwise return NULL. 2432 * otherwise return NULL.
2702 * 2433 *
2704 * do the desired thing. 2435 * do the desired thing.
2705 */ 2436 */
2706key_value * 2437key_value *
2707get_ob_key_link (const object *ob, const char *key) 2438get_ob_key_link (const object *ob, const char *key)
2708{ 2439{
2709 key_value *link;
2710
2711 for (link = ob->key_values; link != NULL; link = link->next) 2440 for (key_value *link = ob->key_values; link; link = link->next)
2712 if (link->key == key) 2441 if (link->key == key)
2713 return link; 2442 return link;
2714 2443
2715 return NULL; 2444 return 0;
2716} 2445}
2717 2446
2718/* 2447/*
2719 * Returns the value of op has an extra_field for key, or NULL. 2448 * Returns the value of op has an extra_field for key, or NULL.
2720 * 2449 *
2760 * Returns TRUE on success. 2489 * Returns TRUE on success.
2761 */ 2490 */
2762int 2491int
2763set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key) 2492set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2764{ 2493{
2765 key_value *
2766 field = NULL, *last = NULL; 2494 key_value *field = NULL, *last = NULL;
2767 2495
2768 for (field = op->key_values; field != NULL; field = field->next) 2496 for (field = op->key_values; field != NULL; field = field->next)
2769 { 2497 {
2770 if (field->key != canonical_key) 2498 if (field->key != canonical_key)
2771 { 2499 {
2799 /* IF we get here, key doesn't exist */ 2527 /* IF we get here, key doesn't exist */
2800 2528
2801 /* No field, we'll have to add it. */ 2529 /* No field, we'll have to add it. */
2802 2530
2803 if (!add_key) 2531 if (!add_key)
2804 {
2805 return FALSE; 2532 return FALSE;
2806 } 2533
2807 /* There isn't any good reason to store a null 2534 /* There isn't any good reason to store a null
2808 * value in the key/value list. If the archetype has 2535 * value in the key/value list. If the archetype has
2809 * this key, then we should also have it, so shouldn't 2536 * this key, then we should also have it, so shouldn't
2810 * be here. If user wants to store empty strings, 2537 * be here. If user wants to store empty strings,
2811 * should pass in "" 2538 * should pass in ""

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines