ViewVC Help

View File | Revision Log | Show Annotations | Download File

/cvs/deliantra/server/common/object.C

Comparing deliantra/server/common/object.C (file contents):
Revision 1.217 by root, Wed Apr 23 07:13:23 2008 UTC vs.
Revision 1.296 by root, Fri Nov 6 13:31:47 2009 UTC

1	/*	1	/*
2	* This file is part of Deliantra, the Roguelike Realtime MMORPG.	2	* This file is part of Deliantra, the Roguelike Realtime MMORPG.
3	*	3	*
4	* Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team	4	* Copyright (©) 2005,2006,2007,2008,2009 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5	* Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team	5	* Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team
6	* Copyright (©) 1992,2007 Frank Tore Johansen	6	* Copyright (©) 1992,2007 Frank Tore Johansen
7	*	7	*
8	* Deliantra is free software: you can redistribute it and/or modify	8	* Deliantra is free software: you can redistribute it and/or modify it under
9	* it under the terms of the GNU General Public License as published by	9	* the terms of the Affero GNU General Public License as published by the
10	* the Free Software Foundation, either version 3 of the License, or	10	* Free Software Foundation, either version 3 of the License, or (at your
11	* (at your option) any later version.	11	* option) any later version.
12	*	12	*
13	* This program is distributed in the hope that it will be useful,	13	* This program is distributed in the hope that it will be useful,
14	* but WITHOUT ANY WARRANTY; without even the implied warranty of	14	* but WITHOUT ANY WARRANTY; without even the implied warranty of
15	* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the	15	* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16	* GNU General Public License for more details.	16	* GNU General Public License for more details.
17	*	17	*
18	* You should have received a copy of the GNU General Public License	18	* You should have received a copy of the Affero GNU General Public License
19	* along with this program. If not, see <http://www.gnu.org/licenses/>.	19	* and the GNU General Public License along with this program. If not, see
		20	* <http://www.gnu.org/licenses/>.
20	*	21	*
21	* The authors can be reached via e-mail to <support@deliantra.net>	22	* The authors can be reached via e-mail to <support@deliantra.net>
22	*/	23	*/
23		24
24	#include <global.h>	25	#include <global.h>
…		…
32	#include <bitset>	33	#include <bitset>
33		34
34	UUID UUID::cur;	35	UUID UUID::cur;
35	static uint64_t seq_next_save;	36	static uint64_t seq_next_save;
36	static const uint64 UUID_GAP = 1<<19;	37	static const uint64 UUID_GAP = 1<<19;
		38	uint32_t mapspace::smellcount = 10000;
37		39
38	objectvec objects;	40	objectvec objects;
39	activevec actives;	41	activevec actives;
		42
		43	//+GPL
40		44
41	short freearr_x[SIZEOFFREE] = {	45	short freearr_x[SIZEOFFREE] = {
42	0,	46	0,
43	0, 1, 1, 1, 0, -1, -1, -1,	47	0, 1, 1, 1, 0, -1, -1, -1,
44	0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,	48	0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
…		…
48	0,	52	0,
49	-1, -1, 0, 1, 1, 1, 0, -1,	53	-1, -1, 0, 1, 1, 1, 0, -1,
50	-2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,	54	-2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
51	-3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3	55	-3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3
52	};	56	};
53	int maxfree[SIZEOFFREE] = {
54	0,
55	9, 10, 13, 14, 17, 18, 21, 22,
56	25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
57	49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
58	};
59	int freedir[SIZEOFFREE] = {	57	int freedir[SIZEOFFREE] = {
60	0,	58	0,
61	1, 2, 3, 4, 5, 6, 7, 8,	59	1, 2, 3, 4, 5, 6, 7, 8,
62	1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,	60	1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,
63	1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8	61	1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8
		62	};
		63
		64	static int maxfree[SIZEOFFREE] = {
		65	0,
		66	9, 10, 13, 14, 17, 18, 21, 22,
		67	25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
		68	49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
64	};	69	};
65		70
66	static void	71	static void
67	write_uuid (uval64 skip, bool sync)	72	write_uuid (uval64 skip, bool sync)
68	{	73	{
…		…
139		144
140	/* Returns TRUE if every key_values in wants has a partner with the same value in has. */	145	/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
141	static bool	146	static bool
142	compare_ob_value_lists_one (const object *wants, const object *has)	147	compare_ob_value_lists_one (const object *wants, const object *has)
143	{	148	{
144	key_value *wants_field;
145
146	/* n-squared behaviour (see get_ob_key_link()), but I'm hoping both	149	/* n-squared behaviour (see kv_get), but I'm hoping both
147	* objects with lists are rare, and lists stay short. If not, use a	150	* objects with lists are rare, and lists stay short. If not, use a
148	* different structure or at least keep the lists sorted...	151	* different structure or at least keep the lists sorted...
149	*/	152	*/
150		153
151	/* For each field in wants, */	154	/* For each field in wants, */
152	for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)	155	for (key_value *kv = wants->key_values; kv; kv = kv->next)
153	{	156	if (has->kv_get (kv->key) != kv->value)
154	key_value *has_field;	157	return false;
155
156	/* Look for a field in has with the same key. */
157	has_field = get_ob_key_link (has, wants_field->key);
158
159	if (!has_field)
160	return 0; /* No field with that name. */
161
162	/* Found the matching field. */
163	if (has_field->value != wants_field->value)
164	return 0; /* Values don't match, so this half of the comparison is false. */
165
166	/* If we get here, we found a match. Now for the next field in wants. */
167	}
168		158
169	/* If we get here, every field in wants has a matching field in has. */	159	/* If we get here, every field in wants has a matching field in has. */
170	return 1;	160	return true;
171	}	161	}
172		162
173	/* Returns TRUE if ob1 has the same key_values as ob2. */	163	/* Returns TRUE if ob1 has the same key_values as ob2. */
174	static bool	164	static bool
175	compare_ob_value_lists (const object *ob1, const object *ob2)	165	compare_ob_value_lists (const object *ob1, const object *ob2)
176	{	166	{
177	/* However, there may be fields in has which aren't partnered in wants,	167	/* However, there may be fields in has which aren't partnered in wants,
178	* so we need to run the comparison *twice*. :(	168	* so we need to run the comparison *twice*. :(
179	*/	169	*/
180	return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1);	170	return compare_ob_value_lists_one (ob1, ob2)
		171	&& compare_ob_value_lists_one (ob2, ob1);
181	}	172	}
182		173
183	/* Function examines the 2 objects given to it, and returns true if	174	/* Function examines the 2 objects given to it, and returns true if
184	* they can be merged together.	175	* they can be merged together.
185	*	176	*
…		…
200	|| ob1->speed != ob2->speed	191	|| ob1->speed != ob2->speed
201	|| ob1->value != ob2->value	192	|| ob1->value != ob2->value
202	|| ob1->name != ob2->name)	193	|| ob1->name != ob2->name)
203	return 0;	194	return 0;
204		195
205	/* Do not merge objects if nrof would overflow. First part checks	196	/* Do not merge objects if nrof would overflow, assume nrof
206	* for unsigned overflow (2c), second part checks whether the result	197	* is always 0 .. 2**31-1 */
207	* would fit into a 32 bit signed int, which is often used to hold	198	if (ob1->nrof > 0x7fffffff - ob2->nrof)
208	* nrof values.
209	*/
210	if (~ob1->nrof < ob2->nrof || ob1->nrof + ob2->nrof > (1UL << 31))
211	return 0;	199	return 0;
212		200
213	/* If the objects have been identified, set the BEEN_APPLIED flag.	201	/* If the objects have been identified, set the BEEN_APPLIED flag.
214	* This is to the comparison of the flags below will be OK. We	202	* This is to the comparison of the flags below will be OK. We
215	* just can't ignore the been applied or identified flags, as they	203	* just can't ignore the been applied or identified flags, as they
…		…
220	SET_FLAG (ob1, FLAG_BEEN_APPLIED);	208	SET_FLAG (ob1, FLAG_BEEN_APPLIED);
221		209
222	if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))	210	if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
223	SET_FLAG (ob2, FLAG_BEEN_APPLIED);	211	SET_FLAG (ob2, FLAG_BEEN_APPLIED);
224		212
225	if (ob1->arch->name != ob2->arch->name	213	if (ob1->arch->archname != ob2->arch->archname
226	|| ob1->name != ob2->name	214	|| ob1->name != ob2->name
227	|| ob1->title != ob2->title	215	|| ob1->title != ob2->title
228	|| ob1->msg != ob2->msg	216	|| ob1->msg != ob2->msg
229	|| ob1->weight != ob2->weight	217	|| ob1->weight != ob2->weight
230	|| ob1->attacktype != ob2->attacktype	218	|| ob1->attacktype != ob2->attacktype
231	|| ob1->magic != ob2->magic	219	|| ob1->magic != ob2->magic
232	|| ob1->slaying != ob2->slaying	220	|| ob1->slaying != ob2->slaying
233	|| ob1->skill != ob2->skill	221	|| ob1->skill != ob2->skill
234	|| ob1->value != ob2->value	222	|| ob1->value != ob2->value
235	|| ob1->animation_id != ob2->animation_id	223	|| ob1->animation_id != ob2->animation_id
		224	|| (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependent on each other
236	|| ob1->client_type != ob2->client_type	225	|| ob1->client_type != ob2->client_type
237	|| ob1->materialname != ob2->materialname	226	|| ob1->materialname != ob2->materialname
238	|| ob1->lore != ob2->lore	227	|| ob1->lore != ob2->lore
239	|| ob1->subtype != ob2->subtype	228	|| ob1->subtype != ob2->subtype
240	|| ob1->move_type != ob2->move_type	229	|| ob1->move_type != ob2->move_type
…		…
248	|| memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))	237	|| memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
249	return 0;	238	return 0;
250		239
251	if ((ob1->flag ^ ob2->flag)	240	if ((ob1->flag ^ ob2->flag)
252	.reset (FLAG_INV_LOCKED)	241	.reset (FLAG_INV_LOCKED)
253	.reset (FLAG_CLIENT_SENT)
254	.reset (FLAG_REMOVED)	242	.reset (FLAG_REMOVED)
255	.any ())	243	.any ())
256	return 0;	244	return 0;
257		245
258	/* This is really a spellbook check - we should in general	246	/* This is really a spellbook check - we should in general
…		…
334		322
335	// find player who can see this object	323	// find player who can see this object
336	object *	324	object *
337	object::visible_to () const	325	object::visible_to () const
338	{	326	{
339	if (!flag [FLAG_REMOVED])	327	if (client_visible () && !flag [FLAG_REMOVED])
340	{	328	{
341	// see if we are in a container of sorts	329	// see if we are in a container of sorts
342	if (env)	330	if (env)
343	{	331	{
344	// the player inventory itself is always visible	332	// the player inventory itself is always visible
345	if (env->type == PLAYER)	333	if (env->is_player ())
346	return env;	334	return env;
347		335
348	// else a player could have our env open	336	// else a player could have our env open
349	object *envest = env->outer_env ();	337	object *envest = env->outer_env_or_self ();
350		338
351	// the player itself is always on a map, so we will find him here	339	// the player itself is always on a map, so we will find him here
352	// even if our inv is in a player.	340	// even if our inv is in a player.
353	if (envest->is_on_map ())	341	if (envest->is_on_map ())
354	if (object *pl = envest->ms ().player ())	342	if (object *pl = envest->ms ().player ())
355	if (pl->container == env)	343	if (pl->container_ () == env)
356	return pl;	344	return pl;
357	}	345	}
358	else	346	else
359	{	347	{
360	// maybe there is a player standing on the same mapspace	348	// maybe there is a player standing on the same mapspace
361	// this will catch the case where "this" is a player	349	// this will catch the case where "this" is a player
362	if (object *pl = ms ().player ())	350	if (object *pl = ms ().player ())
		351	if ((pl->contr->ns && !pl->container_ () && !pl->contr->ns->update_look)
		352	|| pl->container_ () == this)
363	return pl;	353	return pl;
364	}	354	}
365	}	355	}
366		356
367	return 0;	357	return 0;
368	}	358	}
369		359
370	// adjust weight per container type ("of holding")	360	// adjust weight per container type ("of holding")
371	static sint32	361	static sint32
372	weight_adjust (object *op, sint32 weight)	362	weight_adjust_for (object *op, sint32 weight)
373	{	363	{
374	return op->type == CONTAINER	364	return op->type == CONTAINER
375	? lerp (weight, 0, 100, 0, 100 - op->stats.Str)	365	? lerp (weight, 0, 100, 0, 100 - op->stats.Str)
376	: weight;	366	: weight;
377	}	367	}
…		…
383	static void	373	static void
384	adjust_weight (object *op, sint32 weight)	374	adjust_weight (object *op, sint32 weight)
385	{	375	{
386	while (op)	376	while (op)
387	{	377	{
		378	// adjust by actual difference to account for rounding errors
		379	// i.e. (w2 - w1) / f != w2 / f - w1 / f and the latter is correct
388	weight = weight_adjust (op, weight);	380	weight = weight_adjust_for (op, op->carrying)
		381	- weight_adjust_for (op, op->carrying - weight);
389		382
390	if (!weight)	383	if (!weight)
391	return;	384	return;
392		385
393	op->carrying += weight;	386	op->carrying += weight;
…		…
416	op->update_weight ();	409	op->update_weight ();
417		410
418	sum += op->total_weight ();	411	sum += op->total_weight ();
419	}	412	}
420		413
421	sum = weight_adjust (this, sum);	414	sum = weight_adjust_for (this, sum);
422		415
423	if (sum != carrying)	416	if (sum != carrying)
424	{	417	{
425	carrying = sum;	418	carrying = sum;
426		419
…		…
442	object_freezer freezer;	435	object_freezer freezer;
443	op->write (freezer);	436	op->write (freezer);
444	return freezer.as_string ();	437	return freezer.as_string ();
445	}	438	}
446		439
447	/*	440	char *
448	* get_nearest_part(multi-object, object 2) returns the part of the	441	object::as_string ()
449	* multi-object 1 which is closest to the second object.
450	* If it's not a multi-object, it is returned.
451	*/
452	object *
453	get_nearest_part (object *op, const object *pl)
454	{	442	{
455	object *tmp, *closest;	443	return dump_object (this);
456	int last_dist, i;
457
458	if (!op->more)
459	return op;
460
461	for (last_dist = distance (op, pl), closest = op, tmp = op->more;
462	tmp;
463	tmp = tmp->more)
464	if ((i = distance (tmp, pl)) < last_dist)
465	closest = tmp, last_dist = i;
466
467	return closest;
468	}	444	}
469		445
470	/*	446	/*
471	* Returns the object which has the count-variable equal to the argument.	447	* Returns the object which has the count-variable equal to the argument.
472	* VERRRY slow.	448	* VERRRY slow.
…		…
488	*/	464	*/
489	object *	465	object *
490	find_object_name (const char *str)	466	find_object_name (const char *str)
491	{	467	{
492	shstr_cmp str_ (str);	468	shstr_cmp str_ (str);
493	object *op;
494		469
		470	if (str_)
495	for_all_objects (op)	471	for_all_objects (op)
496	if (op->name == str_)	472	if (op->name == str_)
497	break;	473	return op;
498		474
499	return op;	475	return 0;
500	}	476	}
501		477
502	/*	478	/*
503	* Sets the owner and sets the skill and exp pointers to owner's current	479	* Sets the owner and sets the skill and exp pointers to owner's current
504	* skill and experience objects.	480	* skill and experience objects.
…		…
566	update_stats ();	542	update_stats ();
567		543
568	new_draw_info_format (NDI_UNIQUE, 0, this,	544	new_draw_info_format (NDI_UNIQUE, 0, this,
569	"You try to balance all your items at once, "	545	"You try to balance all your items at once, "
570	"but the %s is just too much for your body. "	546	"but the %s is just too much for your body. "
571	"[You need to unapply some items first.]", &ob->name);	547	"[You need to unapply some items first - use the 'body' command to see "
		548	"how many items you cna wera on a specific body part.]", &ob->name);
572	return false;	549	return false;
573	}	550	}
574		551
575	//new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name);	552	//new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name);
576	}	553	}
…		…
602	}	579	}
603		580
604	op->key_values = 0;	581	op->key_values = 0;
605	}	582	}
606		583
607	object &	584	/*
608	object::operator =(const object &src)	585	* copy_to first frees everything allocated by the dst object,
		586	* and then copies the contents of itself into the second
		587	* object, allocating what needs to be allocated. Basically, any
		588	* data that is malloc'd needs to be re-malloc/copied. Otherwise,
		589	* if the first object is freed, the pointers in the new object
		590	* will point at garbage.
		591	*/
		592	void
		593	object::copy_to (object *dst)
609	{	594	{
610	bool is_freed = flag [FLAG_FREED];	595	dst->remove ();
611	bool is_removed = flag [FLAG_REMOVED];
612
613	*(object_copy *)this = src;	596	*(object_copy *)dst = *this;
614
615	flag [FLAG_FREED] = is_freed;
616	flag [FLAG_REMOVED] = is_removed;	597	dst->flag [FLAG_REMOVED] = true;
617		598
618	/* Copy over key_values, if any. */	599	/* Copy over key_values, if any. */
619	if (src.key_values)	600	if (key_values)
620	{	601	{
621	key_value *tail = 0;	602	key_value *tail = 0;
622	key_values = 0;	603	dst->key_values = 0;
623		604
624	for (key_value *i = src.key_values; i; i = i->next)	605	for (key_value *i = key_values; i; i = i->next)
625	{	606	{
626	key_value *new_link = new key_value;	607	key_value *new_link = new key_value;
627		608
628	new_link->next = 0;	609	new_link->next = 0;
629	new_link->key = i->key;	610	new_link->key = i->key;
630	new_link->value = i->value;	611	new_link->value = i->value;
631		612
632	/* Try and be clever here, too. */	613	/* Try and be clever here, too. */
633	if (!key_values)	614	if (!dst->key_values)
634	{	615	{
635	key_values = new_link;	616	dst->key_values = new_link;
636	tail = new_link;	617	tail = new_link;
637	}	618	}
638	else	619	else
639	{	620	{
640	tail->next = new_link;	621	tail->next = new_link;
641	tail = new_link;	622	tail = new_link;
642	}	623	}
643	}	624	}
644	}	625	}
645	}
646
647	/*
648	* copy_to first frees everything allocated by the dst object,
649	* and then copies the contents of itself into the second
650	* object, allocating what needs to be allocated. Basically, any
651	* data that is malloc'd needs to be re-malloc/copied. Otherwise,
652	* if the first object is freed, the pointers in the new object
653	* will point at garbage.
654	*/
655	void
656	object::copy_to (object *dst)
657	{
658	*dst = *this;
659		626
660	if (speed < 0)	627	if (speed < 0)
661	dst->speed_left -= rndm ();	628	dst->speed_left -= rndm ();
662		629
663	dst->set_speed (dst->speed);	630	dst->activate ();
664	}	631	}
665		632
666	void	633	void
667	object::instantiate ()	634	object::instantiate ()
668	{	635	{
…		…
685	object *	652	object *
686	object::clone ()	653	object::clone ()
687	{	654	{
688	object *neu = create ();	655	object *neu = create ();
689	copy_to (neu);	656	copy_to (neu);
		657	neu->map = map; // not copied by copy_to
690	return neu;	658	return neu;
691	}	659	}
692		660
693	/*	661	/*
694	* If an object with the IS_TURNABLE() flag needs to be turned due	662	* If an object with the IS_TURNABLE() flag needs to be turned due
…		…
745	* UP_OBJ_FACE: only the objects face has changed.	713	* UP_OBJ_FACE: only the objects face has changed.
746	*/	714	*/
747	void	715	void
748	update_object (object *op, int action)	716	update_object (object *op, int action)
749	{	717	{
750	if (op == NULL)	718	if (!op)
751	{	719	{
752	/* this should never happen */	720	/* this should never happen */
753	LOG (llevDebug, "update_object() called for NULL object.\n");	721	LOG (llevError | logBacktrace, "update_object() called for NULL object.\n");
754	return;	722	return;
755	}	723	}
756		724
757	if (op->env)	725	if (!op->is_on_map ())
758	{	726	{
759	/* Animation is currently handled by client, so nothing	727	/* Animation is currently handled by client, so nothing
760	* to do in this case.	728	* to do in this case.
761	*/	729	*/
762	return;	730	return;
763	}	731	}
764
765	/* If the map is saving, don't do anything as everything is
766	* going to get freed anyways.
767	*/
768	if (!op->map || op->map->in_memory == MAP_SAVING)
769	return;
770		732
771	/* make sure the object is within map boundaries */	733	/* make sure the object is within map boundaries */
772	if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)	734	if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
773	{	735	{
774	LOG (llevError, "update_object() called for object out of map!\n");	736	LOG (llevError, "update_object() called for object out of map!\n");
…		…
785	else if (action == UP_OBJ_INSERT)	747	else if (action == UP_OBJ_INSERT)
786	{	748	{
787	// this is likely overkill, TODO: revisit (schmorp)	749	// this is likely overkill, TODO: revisit (schmorp)
788	if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))	750	if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
789	|| (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))	751	|| (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
790	|| (op->type == PLAYER && !(m.flags_ & P_PLAYER))	752	|| (op->is_player () && !(m.flags_ & P_PLAYER))
791	|| (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))	753	|| (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
792	|| (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))	754	|| (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
793	|| (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))	755	|| (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
794	|| (m.move_on | op->move_on ) != m.move_on	756	|| (m.move_on | op->move_on ) != m.move_on
795	|| (m.move_off | op->move_off ) != m.move_off	757	|| (m.move_off | op->move_off ) != m.move_off
796	|| (m.move_slow | op->move_slow) != m.move_slow	758	|| (m.move_slow | op->move_slow) != m.move_slow
797	/* This isn't perfect, but I don't expect a lot of objects to	759	/* This isn't perfect, but I don't expect a lot of objects to
798	* to have move_allow right now.	760	* have move_allow right now.
799	*/	761	*/
800	|| ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block	762	|| ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
801	|| 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)	763	|| 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
802	m.flags_ = 0;	764	m.invalidate ();
803	}	765	}
804	/* if the object is being removed, we can't make intelligent	766	/* if the object is being removed, we can't make intelligent
805	* decisions, because remove_ob can't really pass the object	767	* decisions, because remove_ob can't really pass the object
806	* that is being removed.	768	* that is being removed.
807	*/	769	*/
808	else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)	770	else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
809	m.flags_ = 0;	771	m.invalidate ();
810	else if (action == UP_OBJ_FACE)	772	else if (action == UP_OBJ_FACE)
811	/* Nothing to do for that case */ ;	773	/* Nothing to do for that case */ ;
812	else	774	else
813	LOG (llevError, "update_object called with invalid action: %d\n", action);	775	LOG (llevError, "update_object called with invalid action: %d\n", action);
814		776
…		…
818		780
819	object::object ()	781	object::object ()
820	{	782	{
821	SET_FLAG (this, FLAG_REMOVED);	783	SET_FLAG (this, FLAG_REMOVED);
822		784
823	expmul = 1.0;	785	//expmul = 1.0; declared const for the time being
824	face = blank_face;	786	face = blank_face;
825	}	787	}
826		788
827	object::~object ()	789	object::~object ()
828	{	790	{
…		…
858	/* If already on active list, don't do anything */	820	/* If already on active list, don't do anything */
859	if (active)	821	if (active)
860	return;	822	return;
861		823
862	if (has_active_speed ())	824	if (has_active_speed ())
		825	{
		826	if (flag [FLAG_FREED])
		827	LOG (llevError | logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
		828
863	actives.insert (this);	829	actives.insert (this);
		830	}
864	}	831	}
865		832
866	void	833	void
867	object::activate_recursive ()	834	object::activate_recursive ()
868	{	835	{
…		…
929	* drop on that space.	896	* drop on that space.
930	*/	897	*/
931	if (!drop_to_ground	898	if (!drop_to_ground
932	|| !map	899	|| !map
933	|| map->in_memory != MAP_ACTIVE	900	|| map->in_memory != MAP_ACTIVE
934	|| map->nodrop	901	|| map->no_drop
935	|| ms ().move_block == MOVE_ALL)	902	|| ms ().move_block == MOVE_ALL)
936	{	903	{
937	while (inv)	904	while (inv)
938	{
939	inv->destroy_inv (false);
940	inv->destroy ();	905	inv->destroy ();
941	}
942	}	906	}
943	else	907	else
944	{ /* Put objects in inventory onto this space */	908	{ /* Put objects in inventory onto this space */
945	while (inv)	909	while (inv)
946	{	910	{
…		…
950	|| op->flag [FLAG_NO_DROP]	914	|| op->flag [FLAG_NO_DROP]
951	|| op->type == RUNE	915	|| op->type == RUNE
952	|| op->type == TRAP	916	|| op->type == TRAP
953	|| op->flag [FLAG_IS_A_TEMPLATE]	917	|| op->flag [FLAG_IS_A_TEMPLATE]
954	|| op->flag [FLAG_DESTROY_ON_DEATH])	918	|| op->flag [FLAG_DESTROY_ON_DEATH])
955	op->destroy (true);	919	op->destroy ();
956	else	920	else
957	map->insert (op, x, y);	921	map->insert (op, x, y);
958	}	922	}
959	}	923	}
960	}	924	}
…		…
964	object *op = new object;	928	object *op = new object;
965	op->link ();	929	op->link ();
966	return op;	930	return op;
967	}	931	}
968		932
		933	static struct freed_map : maptile
		934	{
		935	freed_map ()
		936	{
		937	path = "<freed objects map>";
		938	name = "/internal/freed_objects_map";
		939	width = 3;
		940	height = 3;
		941	no_drop = 1;
		942	no_reset = 1;
		943
		944	alloc ();
		945	in_memory = MAP_ACTIVE;
		946	}
		947
		948	~freed_map ()
		949	{
		950	destroy ();
		951	}
		952	} freed_map; // freed objects are moved here to avoid crashes
		953
969	void	954	void
970	object::do_destroy ()	955	object::do_destroy ()
971	{	956	{
972	if (flag [FLAG_IS_LINKED])	957	if (flag [FLAG_IS_LINKED])
973	remove_button_link (this);	958	remove_link ();
974		959
975	if (flag [FLAG_FRIENDLY])	960	if (flag [FLAG_FRIENDLY])
976	remove_friendly_object (this);	961	remove_friendly_object (this);
977		962
978	remove ();	963	remove ();
…		…
983	unlink ();	968	unlink ();
984		969
985	flag [FLAG_FREED] = 1;	970	flag [FLAG_FREED] = 1;
986		971
987	// hack to ensure that freed objects still have a valid map	972	// hack to ensure that freed objects still have a valid map
988	{
989	static maptile *freed_map; // freed objects are moved here to avoid crashes
990
991	if (!freed_map)
992	{
993	freed_map = new maptile;
994
995	freed_map->path = "<freed objects map>";
996	freed_map->name = "/internal/freed_objects_map";
997	freed_map->width = 3;
998	freed_map->height = 3;
999	freed_map->nodrop = 1;
1000
1001	freed_map->alloc ();
1002	freed_map->in_memory = MAP_ACTIVE;
1003	}
1004
1005	map = freed_map;	973	map = &freed_map;
1006	x = 1;	974	x = 1;
1007	y = 1;	975	y = 1;
1008	}
1009		976
1010	if (more)	977	if (more)
1011	{	978	{
1012	more->destroy ();	979	more->destroy ();
1013	more = 0;	980	more = 0;
…		…
1021	attacked_by = 0;	988	attacked_by = 0;
1022	current_weapon = 0;	989	current_weapon = 0;
1023	}	990	}
1024		991
1025	void	992	void
1026	object::destroy (bool destroy_inventory)	993	object::destroy ()
1027	{	994	{
1028	if (destroyed ())	995	if (destroyed ())
1029	return;	996	return;
1030		997
1031	destroy_inv (!destroy_inventory);	998	if (!is_head () && !head->destroyed ())
		999	{
		1000	LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
		1001	head->destroy ();
		1002	return;
		1003	}
		1004
		1005	destroy_inv (false);
1032		1006
1033	if (is_head ())	1007	if (is_head ())
1034	if (sound_destroy)	1008	if (sound_destroy)
1035	play_sound (sound_destroy);	1009	play_sound (sound_destroy);
1036	else if (flag [FLAG_MONSTER])	1010	else if (flag [FLAG_MONSTER])
…		…
1047	* the previous environment.	1021	* the previous environment.
1048	*/	1022	*/
1049	void	1023	void
1050	object::do_remove ()	1024	object::do_remove ()
1051	{	1025	{
1052	object *tmp, *last = 0;
1053	object *otmp;
1054
1055	if (flag [FLAG_REMOVED])	1026	if (flag [FLAG_REMOVED])
1056	return;	1027	return;
1057		1028
1058	INVOKE_OBJECT (REMOVE, this);	1029	INVOKE_OBJECT (REMOVE, this);
1059
1060	if (object *pl = visible_to ())
1061	esrv_del_item (pl->contr, count);
1062		1030
1063	flag [FLAG_REMOVED] = true;	1031	flag [FLAG_REMOVED] = true;
1064		1032
1065	if (more)	1033	if (more)
1066	more->remove ();	1034	more->remove ();
…		…
1069	* In this case, the object to be removed is in someones	1037	* In this case, the object to be removed is in someones
1070	* inventory.	1038	* inventory.
1071	*/	1039	*/
1072	if (env)	1040	if (env)
1073	{	1041	{
		1042	flag [FLAG_REMOVED] = false; // hack around the issue of visible_to checking flag_removed
		1043	if (object *pl = visible_to ())
		1044	esrv_del_item (pl->contr, count);
		1045	flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
		1046
1074	adjust_weight (env, -total_weight ());	1047	adjust_weight (env, -total_weight ());
1075		1048
1076	*(above ? &above->below : &env->inv) = below;	1049	object *pl = in_player ();
1077
1078	if (below)
1079	below->above = above;
1080		1050
1081	/* we set up values so that it could be inserted into	1051	/* we set up values so that it could be inserted into
1082	* the map, but we don't actually do that - it is up	1052	* the map, but we don't actually do that - it is up
1083	* to the caller to decide what we want to do.	1053	* to the caller to decide what we want to do.
1084	*/	1054	*/
1085	map = env->map;	1055	map = env->map;
1086	x = env->x;	1056	x = env->x;
1087	y = env->y;	1057	y = env->y;
		1058
		1059	// make sure cmov optimisation is applicable
		1060	*(above ? &above->below : &env->inv) = below;
		1061	*(below ? &below->above : &above ) = above; // &above is just a dummy
		1062
1088	above = 0;	1063	above = 0;
1089	below = 0;	1064	below = 0;
1090	env = 0;	1065	env = 0;
1091		1066
1092	/* NO_FIX_PLAYER is set when a great many changes are being	1067	/* NO_FIX_PLAYER is set when a great many changes are being
1093	* made to players inventory. If set, avoiding the call	1068	* made to players inventory. If set, avoiding the call
1094	* to save cpu time.	1069	* to save cpu time.
1095	*/	1070	*/
1096	if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))	1071	if (pl)
		1072	if (pl->is_player () && (glow_radius || !QUERY_FLAG (pl, FLAG_NO_FIX_PLAYER)))
		1073	{
1097	otmp->update_stats ();	1074	pl->update_stats ();
		1075
		1076	if (glow_radius && pl->is_on_map ())
		1077	update_all_los (pl->map, pl->x, pl->y);
		1078	}
1098	}	1079	}
1099	else if (map)	1080	else if (map)
1100	{	1081	{
1101	if (type == PLAYER)
1102	{
1103	// leaving a spot always closes any open container on the ground
1104	if (container && !container->env)
1105	// this causes spurious floorbox updates, but it ensures
1106	// that the CLOSE event is being sent.
1107	close_container ();
1108
1109	--map->players;
1110	map->touch ();
1111	}
1112
1113	map->dirty = true;	1082	map->dirty = true;
1114	mapspace &ms = this->ms ();	1083	mapspace &ms = this->ms ();
1115		1084
		1085	if (object *pl = ms.player ())
		1086	{
		1087	if (is_player ())
		1088	{
		1089	if (!flag [FLAG_WIZPASS])
		1090	ms.smell = ++mapspace::smellcount; // remember the smell of the player
		1091
		1092	// leaving a spot always closes any open container on the ground
		1093	if (container && !container->env)
		1094	// this causes spurious floorbox updates, but it ensures
		1095	// that the CLOSE event is being sent.
		1096	close_container ();
		1097
		1098	--map->players;
		1099	map->touch ();
		1100	}
		1101	else if (pl->container_ () == this)
		1102	{
		1103	// removing a container should close it
		1104	close_container ();
		1105	}
		1106
		1107	esrv_del_item (pl->contr, count);
		1108	}
		1109
1116	/* link the object above us */	1110	/* link the object above us */
1117	if (above)	1111	// re-link, make sure compiler can easily use cmove
1118	above->below = below;	1112	*(above ? &above->below : &ms.top) = below;
1119	else	1113	*(below ? &below->above : &ms.bot) = above;
1120	ms.top = below; /* we were top, set new top */
1121
1122	/* Relink the object below us, if there is one */
1123	if (below)
1124	below->above = above;
1125	else
1126	{
1127	/* Nothing below, which means we need to relink map object for this space
1128	* use translated coordinates in case some oddness with map tiling is
1129	* evident
1130	*/
1131	if (GET_MAP_OB (map, x, y) != this)
1132	LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1133
1134	ms.bot = above; /* goes on above it. */
1135	}
1136		1114
1137	above = 0;	1115	above = 0;
1138	below = 0;	1116	below = 0;
1139		1117
		1118	ms.invalidate ();
		1119
1140	if (map->in_memory == MAP_SAVING)	1120	if (map->in_memory == MAP_SAVING)
1141	return;	1121	return;
1142		1122
1143	int check_walk_off = !flag [FLAG_NO_APPLY];	1123	int check_walk_off = !flag [FLAG_NO_APPLY];
1144		1124
1145	if (object *pl = ms.player ())	1125	if (object *pl = ms.player ())
1146	{	1126	{
1147	if (pl->container == this)	1127	if (pl->container_ () == this)
1148	/* If a container that the player is currently using somehow gets	1128	/* If a container that the player is currently using somehow gets
1149	* removed (most likely destroyed), update the player view	1129	* removed (most likely destroyed), update the player view
1150	* appropriately.	1130	* appropriately.
1151	*/	1131	*/
1152	pl->close_container ();	1132	pl->close_container ();
1153		1133
		1134	//TODO: the floorbox prev/next might need updating
1154	esrv_del_item (pl, count);	1135	//esrv_del_item (pl->contr, count);
		1136	//TODO: update floorbox to preserve ordering
		1137	if (pl->contr->ns)
		1138	pl->contr->ns->floorbox_update ();
1155	}	1139	}
1156		1140
		1141	if (check_walk_off)
1157	for (tmp = ms.bot; tmp; tmp = tmp->above)	1142	for (object *above, *tmp = ms.bot; tmp; tmp = above)
1158	{	1143	{
		1144	above = tmp->above;
		1145
1159	/* No point updating the players look faces if he is the object	1146	/* No point updating the players look faces if he is the object
1160	* being removed.	1147	* being removed.
1161	*/	1148	*/
1162		1149
1163	/* See if object moving off should effect something */	1150	/* See if object moving off should effect something */
1164	if (check_walk_off
1165	&& ((move_type & tmp->move_off)	1151	if ((move_type & tmp->move_off)
1166	&& (move_type & ~tmp->move_off & ~tmp->move_block) == 0))	1152	&& (move_type & ~tmp->move_off & ~tmp->move_block) == 0)
1167	{
1168	move_apply (tmp, this, 0);	1153	move_apply (tmp, this, 0);
1169
1170	if (destroyed ())
1171	LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1172	}	1154	}
1173		1155
1174	last = tmp;	1156	if (affects_los ())
1175	}
1176
1177	/* last == NULL if there are no objects on this space */
1178	//TODO: this makes little sense, why only update the topmost object?
1179	if (!last)
1180	map->at (x, y).flags_ = 0;
1181	else
1182	update_object (last, UP_OBJ_REMOVE);
1183
1184	if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1185	update_all_los (map, x, y);	1157	update_all_los (map, x, y);
1186	}	1158	}
1187	}	1159	}
1188		1160
1189	/*	1161	/*
…		…
1213	esrv_update_item (UPD_NROF, pl, top);	1185	esrv_update_item (UPD_NROF, pl, top);
1214		1186
1215	op->weight = 0; // cancel the addition above	1187	op->weight = 0; // cancel the addition above
1216	op->carrying = 0; // must be 0 already	1188	op->carrying = 0; // must be 0 already
1217		1189
1218	op->destroy (1);	1190	op->destroy ();
1219		1191
1220	return top;	1192	return top;
1221	}	1193	}
1222		1194
1223	return 0;	1195	return 0;
…		…
1251	* job preparing multi-part monsters.	1223	* job preparing multi-part monsters.
1252	*/	1224	*/
1253	object *	1225	object *
1254	insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)	1226	insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1255	{	1227	{
		1228	op->remove ();
		1229
1256	for (object *tmp = op->head_ (); tmp; tmp = tmp->more)	1230	for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1257	{	1231	{
1258	tmp->x = x + tmp->arch->x;	1232	tmp->x = x + tmp->arch->x;
1259	tmp->y = y + tmp->arch->y;	1233	tmp->y = y + tmp->arch->y;
1260	}	1234	}
…		…
1283	* just 'op' otherwise	1257	* just 'op' otherwise
1284	*/	1258	*/
1285	object *	1259	object *
1286	insert_ob_in_map (object *op, maptile *m, object *originator, int flag)	1260	insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1287	{	1261	{
1288	assert (!op->flag [FLAG_FREED]);
1289
1290	object *top, *floor = NULL;
1291
1292	op->remove ();	1262	op->remove ();
		1263
		1264	if (m == &freed_map)//D TODO: remove soon
		1265	{//D
		1266	LOG (llevError | logBacktrace, "tries to insret object on freed objects map: %s", op->debug_desc ());//D
		1267	}//D
1293		1268
1294	/* Ideally, the caller figures this out. However, it complicates a lot	1269	/* Ideally, the caller figures this out. However, it complicates a lot
1295	* of areas of callers (eg, anything that uses find_free_spot would now	1270	* of areas of callers (eg, anything that uses find_free_spot would now
1296	* need extra work	1271	* need extra work
1297	*/	1272	*/
		1273	maptile *newmap = m;
1298	if (!xy_normalise (m, op->x, op->y))	1274	if (!xy_normalise (newmap, op->x, op->y))
1299	{	1275	{
1300	op->destroy (1);	1276	op->head_ ()->destroy ();// remove head_ once all tail object destroyers found
1301	return 0;	1277	return 0;
1302	}	1278	}
1303		1279
1304	if (object *more = op->more)	1280	if (object *more = op->more)
1305	if (!insert_ob_in_map (more, m, originator, flag))	1281	if (!insert_ob_in_map (more, m, originator, flag))
1306	return 0;	1282	return 0;
1307		1283
1308	CLEAR_FLAG (op, FLAG_REMOVED);	1284	op->flag [FLAG_REMOVED] = false;
1309		1285	op->env = 0;
1310	op->map = m;	1286	op->map = newmap;
		1287
1311	mapspace &ms = op->ms ();	1288	mapspace &ms = op->ms ();
1312		1289
1313	/* this has to be done after we translate the coordinates.	1290	/* this has to be done after we translate the coordinates.
1314	*/	1291	*/
1315	if (op->nrof && !(flag & INS_NO_MERGE))	1292	if (op->nrof && !(flag & INS_NO_MERGE))
1316	for (object *tmp = ms.bot; tmp; tmp = tmp->above)	1293	for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1317	if (object::can_merge (op, tmp))	1294	if (object::can_merge (op, tmp))
1318	{	1295	{
		1296	// TODO: we actually want to update tmp, not op,
		1297	// but some caller surely breaks when we return tmp
		1298	// from here :/
1319	op->nrof += tmp->nrof;	1299	op->nrof += tmp->nrof;
1320	tmp->destroy (1);	1300	tmp->destroy ();
1321	}	1301	}
1322		1302
1323	CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */	1303	CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1324	CLEAR_FLAG (op, FLAG_INV_LOCKED);	1304	CLEAR_FLAG (op, FLAG_INV_LOCKED);
1325		1305
…		…
1332	{	1312	{
1333	LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");	1313	LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1334	abort ();	1314	abort ();
1335	}	1315	}
1336		1316
		1317	if (!originator->is_on_map ())
		1318	{
		1319	LOG (llevError, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
		1320	op->debug_desc (), originator->debug_desc ());
		1321	abort ();
		1322	}
		1323
1337	op->above = originator;	1324	op->above = originator;
1338	op->below = originator->below;	1325	op->below = originator->below;
1339
1340	if (op->below)
1341	op->below->above = op;
1342	else
1343	ms.bot = op;
1344
1345	/* since *below* originator, no need to update top */
1346	originator->below = op;	1326	originator->below = op;
		1327
		1328	*(op->below ? &op->below->above : &ms.bot) = op;
1347	}	1329	}
1348	else	1330	else
1349	{	1331	{
1350	top = ms.bot;	1332	object *floor = 0;
		1333	object *top = ms.top;
1351		1334
1352	/* If there are other objects, then */	1335	/* If there are other objects, then */
1353	if (top)	1336	if (top)
1354	{	1337	{
1355	object *last = 0;
1356
1357	/*	1338	/*
1358	* If there are multiple objects on this space, we do some trickier handling.	1339	* If there are multiple objects on this space, we do some trickier handling.
1359	* We've already dealt with merging if appropriate.	1340	* We've already dealt with merging if appropriate.
1360	* Generally, we want to put the new object on top. But if	1341	* Generally, we want to put the new object on top. But if
1361	* flag contains INS_ABOVE_FLOOR_ONLY, once we find the last	1342	* flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
…		…
1364	* once we get to them. This reduces the need to traverse over all of	1345	* once we get to them. This reduces the need to traverse over all of
1365	* them when adding another one - this saves quite a bit of cpu time	1346	* them when adding another one - this saves quite a bit of cpu time
1366	* when lots of spells are cast in one area. Currently, it is presumed	1347	* when lots of spells are cast in one area. Currently, it is presumed
1367	* that flying non pickable objects are spell objects.	1348	* that flying non pickable objects are spell objects.
1368	*/	1349	*/
1369	for (top = ms.bot; top; top = top->above)	1350	for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1370	{	1351	{
1371	if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))	1352	if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) || QUERY_FLAG (tmp, FLAG_OVERLAY_FLOOR))
1372	floor = top;	1353	floor = tmp;
1373		1354
1374	if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))	1355	if (QUERY_FLAG (tmp, FLAG_NO_PICK) && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (tmp, FLAG_IS_FLOOR))
1375	{	1356	{
1376	/* We insert above top, so we want this object below this */	1357	/* We insert above top, so we want this object below this */
1377	top = top->below;	1358	top = tmp->below;
1378	break;	1359	break;
1379	}	1360	}
1380		1361
1381	last = top;	1362	top = tmp;
1382	}	1363	}
1383
1384	/* Don't want top to be NULL, so set it to the last valid object */
1385	top = last;
1386		1364
1387	/* We let update_position deal with figuring out what the space	1365	/* We let update_position deal with figuring out what the space
1388	* looks like instead of lots of conditions here.	1366	* looks like instead of lots of conditions here.
1389	* makes things faster, and effectively the same result.	1367	* makes things faster, and effectively the same result.
1390	*/	1368	*/
…		…
1397	*/	1375	*/
1398	if (!(flag & INS_ON_TOP)	1376	if (!(flag & INS_ON_TOP)
1399	&& ms.flags () & P_BLOCKSVIEW	1377	&& ms.flags () & P_BLOCKSVIEW
1400	&& (op->face && !faces [op->face].visibility))	1378	&& (op->face && !faces [op->face].visibility))
1401	{	1379	{
		1380	object *last;
		1381
1402	for (last = top; last != floor; last = last->below)	1382	for (last = top; last != floor; last = last->below)
1403	if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))	1383	if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1404	break;	1384	break;
1405		1385
1406	/* Check to see if we found the object that blocks view,	1386	/* Check to see if we found the object that blocks view,
…		…
1414	} /* If objects on this space */	1394	} /* If objects on this space */
1415		1395
1416	if (flag & INS_ABOVE_FLOOR_ONLY)	1396	if (flag & INS_ABOVE_FLOOR_ONLY)
1417	top = floor;	1397	top = floor;
1418		1398
1419	/* Top is the object that our object (op) is going to get inserted above.	1399	// insert object above top, or bottom-most if top = 0
1420	*/
1421
1422	/* First object on this space */
1423	if (!top)	1400	if (!top)
1424	{	1401	{
		1402	op->below = 0;
1425	op->above = ms.bot;	1403	op->above = ms.bot;
1426
1427	if (op->above)
1428	op->above->below = op;
1429
1430	op->below = 0;
1431	ms.bot = op;	1404	ms.bot = op;
		1405
		1406	*(op->above ? &op->above->below : &ms.top) = op;
1432	}	1407	}
1433	else	1408	else
1434	{ /* get inserted into the stack above top */	1409	{
1435	op->above = top->above;	1410	op->above = top->above;
1436
1437	if (op->above)
1438	op->above->below = op;	1411	top->above = op;
1439		1412
1440	op->below = top;	1413	op->below = top;
1441	top->above = op;	1414	*(op->above ? &op->above->below : &ms.top) = op;
1442	}	1415	}
		1416	}
1443		1417
1444	if (!op->above)	1418	if (op->is_player ())
1445	ms.top = op;
1446	} /* else not INS_BELOW_ORIGINATOR */
1447
1448	if (op->type == PLAYER)
1449	{	1419	{
1450	op->contr->do_los = 1;	1420	op->contr->do_los = 1;
1451	++op->map->players;	1421	++op->map->players;
1452	op->map->touch ();	1422	op->map->touch ();
1453	}	1423	}
1454		1424
1455	op->map->dirty = true;	1425	op->map->dirty = true;
1456		1426
1457	if (object *pl = ms.player ())	1427	if (object *pl = ms.player ())
		1428	//TODO: the floorbox prev/next might need updating
1458	esrv_send_item (pl, op);	1429	//esrv_send_item (pl, op);
		1430	//TODO: update floorbox to preserve ordering
		1431	if (pl->contr->ns)
		1432	pl->contr->ns->floorbox_update ();
1459		1433
1460	/* If this object glows, it may affect lighting conditions that are	1434	/* If this object glows, it may affect lighting conditions that are
1461	* visible to others on this map. But update_all_los is really	1435	* visible to others on this map. But update_all_los is really
1462	* an inefficient way to do this, as it means los for all players	1436	* an inefficient way to do this, as it means los for all players
1463	* on the map will get recalculated. The players could very well	1437	* on the map will get recalculated. The players could very well
1464	* be far away from this change and not affected in any way -	1438	* be far away from this change and not affected in any way -
1465	* this should get redone to only look for players within range,	1439	* this should get redone to only look for players within range,
1466	* or just updating the P_UPTODATE for spaces within this area	1440	* or just updating the P_UPTODATE for spaces within this area
1467	* of effect may be sufficient.	1441	* of effect may be sufficient.
1468	*/	1442	*/
1469	if (op->map->darkness && (op->glow_radius != 0))	1443	if (op->affects_los ())
		1444	{
		1445	op->ms ().invalidate ();
1470	update_all_los (op->map, op->x, op->y);	1446	update_all_los (op->map, op->x, op->y);
		1447	}
1471		1448
1472	/* updates flags (blocked, alive, no magic, etc) for this map space */	1449	/* updates flags (blocked, alive, no magic, etc) for this map space */
1473	update_object (op, UP_OBJ_INSERT);	1450	update_object (op, UP_OBJ_INSERT);
1474		1451
1475	INVOKE_OBJECT (INSERT, op);	1452	INVOKE_OBJECT (INSERT, op);
…		…
1482	* blocked() and wall() work properly), and these flags are updated by	1459	* blocked() and wall() work properly), and these flags are updated by
1483	* update_object().	1460	* update_object().
1484	*/	1461	*/
1485		1462
1486	/* if this is not the head or flag has been passed, don't check walk on status */	1463	/* if this is not the head or flag has been passed, don't check walk on status */
1487	if (!(flag & INS_NO_WALK_ON) && op->head_ () == op)	1464	if (!(flag & INS_NO_WALK_ON) && op->is_head ())
1488	{	1465	{
1489	if (check_move_on (op, originator))	1466	if (check_move_on (op, originator))
1490	return 0;	1467	return 0;
1491		1468
1492	/* If we are a multi part object, lets work our way through the check	1469	/* If we are a multi part object, lets work our way through the check
…		…
1503	/* this function inserts an object in the map, but if it	1480	/* this function inserts an object in the map, but if it
1504	* finds an object of its own type, it'll remove that one first.	1481	* finds an object of its own type, it'll remove that one first.
1505	* op is the object to insert it under: supplies x and the map.	1482	* op is the object to insert it under: supplies x and the map.
1506	*/	1483	*/
1507	void	1484	void
1508	replace_insert_ob_in_map (const char *arch_string, object *op)	1485	replace_insert_ob_in_map (shstr_tmp archname, object *op)
1509	{	1486	{
1510	/* first search for itself and remove any old instances */	1487	/* first search for itself and remove any old instances */
1511		1488
1512	for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)	1489	for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1513	if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */	1490	if (tmp->arch->archname == archname) /* same archetype */
1514	tmp->destroy (1);	1491	tmp->destroy ();
1515		1492
1516	object *tmp = arch_to_object (archetype::find (arch_string));	1493	object *tmp = arch_to_object (archetype::find (archname));
1517		1494
1518	tmp->x = op->x;	1495	tmp->x = op->x;
1519	tmp->y = op->y;	1496	tmp->y = op->y;
1520		1497
1521	insert_ob_in_map (tmp, op->map, op, 0);	1498	insert_ob_in_map (tmp, op->map, op, 0);
…		…
1543	if (!nr)	1520	if (!nr)
1544	return true;	1521	return true;
1545		1522
1546	nr = min (nr, nrof);	1523	nr = min (nr, nrof);
1547		1524
		1525	if (nrof > nr)
		1526	{
1548	nrof -= nr;	1527	nrof -= nr;
1549
1550	if (nrof)
1551	{
1552	adjust_weight (env, -weight * nr); // carrying == 0	1528	adjust_weight (env, -weight * max (1, nr)); // carrying == 0
1553		1529
1554	if (object *pl = visible_to ())	1530	if (object *pl = visible_to ())
1555	esrv_update_item (UPD_NROF, pl, this);	1531	esrv_update_item (UPD_NROF, pl, this);
1556		1532
1557	return true;	1533	return true;
1558	}	1534	}
1559	else	1535	else
1560	{	1536	{
1561	destroy (1);	1537	destroy ();
1562	return false;	1538	return false;
1563	}	1539	}
1564	}	1540	}
1565		1541
1566	/*	1542	/*
…		…
1583	}	1559	}
1584	else	1560	else
1585	{	1561	{
1586	decrease (nr);	1562	decrease (nr);
1587		1563
1588	object *op = object_create_clone (this);	1564	object *op = deep_clone ();
1589	op->nrof = nr;	1565	op->nrof = nr;
1590	return op;	1566	return op;
1591	}	1567	}
1592	}	1568	}
1593		1569
…		…
1643	if (object *pl = tmp->visible_to ())	1619	if (object *pl = tmp->visible_to ())
1644	esrv_update_item (UPD_NROF, pl, tmp);	1620	esrv_update_item (UPD_NROF, pl, tmp);
1645		1621
1646	adjust_weight (this, op->total_weight ());	1622	adjust_weight (this, op->total_weight ());
1647		1623
1648	op->destroy (1);	1624	op->destroy ();
1649	op = tmp;	1625	op = tmp;
1650	goto inserted;	1626	goto inserted;
1651	}	1627	}
1652		1628
1653	op->owner = 0; // it's his/hers now. period.	1629	op->owner = 0; // it's his/hers now. period.
…		…
1671		1647
1672	adjust_weight (this, op->total_weight ());	1648	adjust_weight (this, op->total_weight ());
1673		1649
1674	inserted:	1650	inserted:
1675	/* reset the light list and los of the players on the map */	1651	/* reset the light list and los of the players on the map */
1676	if (op->glow_radius && map && map->darkness)	1652	if (op->glow_radius && is_on_map ())
		1653	{
		1654	update_stats ();
1677	update_all_los (map, x, y);	1655	update_all_los (map, x, y);
1678		1656	}
		1657	else if (is_player () && !flag [FLAG_NO_FIX_PLAYER])
1679	// if this is a player's inventory, update stats	1658	// if this is a player's inventory, update stats
1680	if (type == PLAYER && !flag [FLAG_NO_FIX_PLAYER])
1681	update_stats ();	1659	update_stats ();
1682		1660
1683	INVOKE_OBJECT (INSERT, this);	1661	INVOKE_OBJECT (INSERT, this);
1684		1662
1685	return op;	1663	return op;
…		…
1706	* on top.	1684	* on top.
1707	*/	1685	*/
1708	int	1686	int
1709	check_move_on (object *op, object *originator)	1687	check_move_on (object *op, object *originator)
1710	{	1688	{
		1689	if (QUERY_FLAG (op, FLAG_NO_APPLY))
		1690	return 0;
		1691
1711	object *tmp;	1692	object *tmp;
1712	maptile *m = op->map;	1693	maptile *m = op->map;
1713	int x = op->x, y = op->y;	1694	int x = op->x, y = op->y;
1714		1695
1715	MoveType move_on, move_slow, move_block;	1696	mapspace &ms = m->at (x, y);
1716		1697
1717	if (QUERY_FLAG (op, FLAG_NO_APPLY))	1698	ms.update ();
1718	return 0;
1719		1699
1720	move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);	1700	MoveType move_on = ms.move_on;
1721	move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);	1701	MoveType move_slow = ms.move_slow;
1722	move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);	1702	MoveType move_block = ms.move_block;
1723		1703
1724	/* if nothing on this space will slow op down or be applied,	1704	/* if nothing on this space will slow op down or be applied,
1725	* no need to do checking below. have to make sure move_type	1705	* no need to do checking below. have to make sure move_type
1726	* is set, as lots of objects don't have it set - we treat that	1706	* is set, as lots of objects don't have it set - we treat that
1727	* as walking.	1707	* as walking.
…		…
1738	return 0;	1718	return 0;
1739		1719
1740	/* The objects have to be checked from top to bottom.	1720	/* The objects have to be checked from top to bottom.
1741	* Hence, we first go to the top:	1721	* Hence, we first go to the top:
1742	*/	1722	*/
1743		1723	for (object *next, *tmp = ms.top; tmp; tmp = next)
1744	for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1745	{
1746	/* Trim the search when we find the first other spell effect
1747	* this helps performance so that if a space has 50 spell objects,
1748	* we don't need to check all of them.
1749	*/
1750	if ((tmp->move_type & MOVE_FLY_LOW) && QUERY_FLAG (tmp, FLAG_NO_PICK))
1751	break;
1752	}	1724	{
		1725	next = tmp->below;
1753		1726
1754	for (; tmp; tmp = tmp->below)
1755	{
1756	if (tmp == op)	1727	if (tmp == op)
1757	continue; /* Can't apply yourself */	1728	continue; /* Can't apply yourself */
1758		1729
1759	/* Check to see if one of the movement types should be slowed down.	1730	/* Check to see if one of the movement types should be slowed down.
1760	* Second check makes sure that the movement types not being slowed	1731	* Second check makes sure that the movement types not being slowed
…		…
1765	if (!QUERY_FLAG (op, FLAG_WIZPASS))	1736	if (!QUERY_FLAG (op, FLAG_WIZPASS))
1766	{	1737	{
1767	if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||	1738	if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
1768	((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))	1739	((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
1769	{	1740	{
1770
1771	float
1772	diff = tmp->move_slow_penalty * fabs (op->speed);	1741	float diff = tmp->move_slow_penalty * fabs (op->speed);
1773		1742
1774	if (op->type == PLAYER)	1743	if (op->is_player ())
1775	if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) ||	1744	if ((tmp->flag [FLAG_IS_HILLY ] && find_skill_by_number (op, SK_CLIMBING)) ||
1776	(QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN)))	1745	(tmp->flag [FLAG_IS_WOODED] && find_skill_by_number (op, SK_WOODSMAN)))
1777	diff /= 4.0;	1746	diff /= 4.0;
1778		1747
1779	op->speed_left -= diff;	1748	op->speed_left -= diff;
1780	}	1749	}
1781	}	1750	}
…		…
1814	LOG (llevError, "Present_arch called outside map.\n");	1783	LOG (llevError, "Present_arch called outside map.\n");
1815	return NULL;	1784	return NULL;
1816	}	1785	}
1817		1786
1818	for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)	1787	for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1819	if (tmp->arch == at)	1788	if (tmp->arch->archname == at->archname)
1820	return tmp;	1789	return tmp;
1821		1790
1822	return NULL;	1791	return NULL;
1823	}	1792	}
1824		1793
…		…
1888	* The first matching object is returned, or NULL if none.	1857	* The first matching object is returned, or NULL if none.
1889	*/	1858	*/
1890	object *	1859	object *
1891	present_arch_in_ob (const archetype *at, const object *op)	1860	present_arch_in_ob (const archetype *at, const object *op)
1892	{	1861	{
1893	for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)	1862	for (object *tmp = op->inv; tmp; tmp = tmp->below)
1894	if (tmp->arch == at)	1863	if (tmp->arch->archname == at->archname)
1895	return tmp;	1864	return tmp;
1896		1865
1897	return NULL;	1866	return NULL;
1898	}	1867	}
1899		1868
…		…
1987	* head of the object should correspond for the entire object.	1956	* head of the object should correspond for the entire object.
1988	*/	1957	*/
1989	if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))	1958	if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))
1990	continue;	1959	continue;
1991		1960
1992	if (ob->blocked (m, pos.x, pos.y))	1961	if (ob->blocked (pos.m, pos.x, pos.y))
1993	continue;	1962	continue;
1994		1963
1995	altern [index++] = i;	1964	altern [index++] = i;
1996	}	1965	}
1997		1966
…		…
2065	* there is capable of.	2034	* there is capable of.
2066	*/	2035	*/
2067	int	2036	int
2068	find_dir (maptile *m, int x, int y, object *exclude)	2037	find_dir (maptile *m, int x, int y, object *exclude)
2069	{	2038	{
2070	int i, max = SIZEOFFREE, mflags;	2039	int max = SIZEOFFREE, mflags;
2071
2072	sint16 nx, ny;
2073	object *tmp;
2074	maptile *mp;
2075
2076	MoveType blocked, move_type;	2040	MoveType move_type;
2077		2041
2078	if (exclude && exclude->head_ () != exclude)	2042	if (exclude && exclude->head_ () != exclude)
2079	{	2043	{
2080	exclude = exclude->head;	2044	exclude = exclude->head;
2081	move_type = exclude->move_type;	2045	move_type = exclude->move_type;
…		…
2084	{	2048	{
2085	/* If we don't have anything, presume it can use all movement types. */	2049	/* If we don't have anything, presume it can use all movement types. */
2086	move_type = MOVE_ALL;	2050	move_type = MOVE_ALL;
2087	}	2051	}
2088		2052
2089	for (i = 1; i < max; i++)	2053	for (int i = 1; i < max; i++)
2090	{	2054	{
2091	mp = m;	2055	mapxy pos (m, x, y);
2092	nx = x + freearr_x[i];	2056	pos.move (i);
2093	ny = y + freearr_y[i];
2094		2057
2095	mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);	2058	if (!pos.normalise ())
2096
2097	if (mflags & P_OUT_OF_MAP)
2098	max = maxfree[i];	2059	max = maxfree[i];
2099	else	2060	else
2100	{	2061	{
2101	mapspace &ms = mp->at (nx, ny);	2062	mapspace &ms = *pos;
2102		2063
2103	blocked = ms.move_block;
2104
2105	if ((move_type & blocked) == move_type)	2064	if ((move_type & ms.move_block) == move_type)
2106	max = maxfree[i];	2065	max = maxfree [i];
2107	else if (mflags & P_IS_ALIVE)	2066	else if (ms.flags () & P_IS_ALIVE)
2108	{	2067	{
2109	for (tmp = ms.bot; tmp; tmp = tmp->above)	2068	for (object *tmp = ms.bot; tmp; tmp = tmp->above)
2110	if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)	2069	if ((tmp->flag [FLAG_MONSTER] || tmp->is_player ())
2111	&& (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))	2070	&& (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))
2112	break;
2113
2114	if (tmp)
2115	return freedir[i];	2071	return freedir [i];
2116	}	2072	}
2117	}	2073	}
2118	}	2074	}
2119		2075
2120	return 0;	2076	return 0;
…		…
2195	* This basically means that if direction is 15, then it could either go	2151	* This basically means that if direction is 15, then it could either go
2196	* direction 4, 14, or 16 to get back to where we are.	2152	* direction 4, 14, or 16 to get back to where we are.
2197	* Moved from spell_util.c to object.c with the other related direction	2153	* Moved from spell_util.c to object.c with the other related direction
2198	* functions.	2154	* functions.
2199	*/	2155	*/
2200	int reduction_dir[SIZEOFFREE][3] = {	2156	static const int reduction_dir[SIZEOFFREE][3] = {
2201	{0, 0, 0}, /* 0 */	2157	{0, 0, 0}, /* 0 */
2202	{0, 0, 0}, /* 1 */	2158	{0, 0, 0}, /* 1 */
2203	{0, 0, 0}, /* 2 */	2159	{0, 0, 0}, /* 2 */
2204	{0, 0, 0}, /* 3 */	2160	{0, 0, 0}, /* 3 */
2205	{0, 0, 0}, /* 4 */	2161	{0, 0, 0}, /* 4 */
…		…
2301	int	2257	int
2302	can_pick (const object *who, const object *item)	2258	can_pick (const object *who, const object *item)
2303	{	2259	{
2304	return /*QUERY_FLAG(who,FLAG_WIZ)|| */	2260	return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2305	(item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&	2261	(item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2306	!QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));	2262	!QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->is_player () || item->weight < who->weight / 3));
2307	}	2263	}
2308		2264
2309	/*	2265	/*
2310	* create clone from object to another	2266	* create clone from object to another
2311	*/	2267	*/
2312	object *	2268	object *
2313	object_create_clone (object *asrc)	2269	object::deep_clone ()
2314	{	2270	{
2315	object *dst = 0, *tmp, *src, *prev, *item;	2271	assert (("deep_clone called on non-head object", is_head ()));
2316		2272
2317	if (!asrc)	2273	object *dst = clone ();
2318	return 0;
2319		2274
2320	src = asrc->head_ ();	2275	object *prev = dst;
2321
2322	prev = 0;
2323	for (object *part = src; part; part = part->more)	2276	for (object *part = this->more; part; part = part->more)
2324	{	2277	{
2325	tmp = part->clone ();	2278	object *tmp = part->clone ();
2326	tmp->x -= src->x;
2327	tmp->y -= src->y;
2328
2329	if (!part->head)
2330	{
2331	dst = tmp;
2332	tmp->head = 0;
2333	}
2334	else
2335	tmp->head = dst;	2279	tmp->head = dst;
2336
2337	tmp->more = 0;
2338
2339	if (prev)
2340	prev->more = tmp;	2280	prev->more = tmp;
2341
2342	prev = tmp;	2281	prev = tmp;
2343	}	2282	}
2344		2283
2345	for (item = src->inv; item; item = item->below)	2284	for (object *item = inv; item; item = item->below)
2346	insert_ob_in_ob (object_create_clone (item), dst);	2285	insert_ob_in_ob (item->deep_clone (), dst);
2347		2286
2348	return dst;	2287	return dst;
2349	}	2288	}
2350		2289
2351	/* This returns the first object in who's inventory that	2290	/* This returns the first object in who's inventory that
…		…
2360	return tmp;	2299	return tmp;
2361		2300
2362	return 0;	2301	return 0;
2363	}	2302	}
2364		2303
2365	/* If ob has a field named key, return the link from the list,	2304	shstr_tmp
2366	* otherwise return NULL.	2305	object::kv_get (shstr_tmp key) const
2367	*
2368	* key must be a passed in shared string - otherwise, this won't
2369	* do the desired thing.
2370	*/
2371	key_value *
2372	get_ob_key_link (const object *ob, const char *key)
2373	{	2306	{
2374	for (key_value *link = ob->key_values; link; link = link->next)	2307	for (key_value *kv = key_values; kv; kv = kv->next)
2375	if (link->key == key)	2308	if (kv->key == key)
2376	return link;
2377
2378	return 0;
2379	}
2380
2381	/*
2382	* Returns the value of op has an extra_field for key, or NULL.
2383	*
2384	* The argument doesn't need to be a shared string.
2385	*
2386	* The returned string is shared.
2387	*/
2388	const char *
2389	get_ob_key_value (const object *op, const char *const key)
2390	{
2391	key_value *link;
2392	shstr_cmp canonical_key (key);
2393
2394	if (!canonical_key)
2395	{
2396	/* 1. There being a field named key on any object
2397	* implies there'd be a shared string to find.
2398	* 2. Since there isn't, no object has this field.
2399	* 3. Therefore, *this* object doesn't have this field.
2400	*/
2401	return 0;
2402	}
2403
2404	/* This is copied from get_ob_key_link() above -
2405	* only 4 lines, and saves the function call overhead.
2406	*/
2407	for (link = op->key_values; link; link = link->next)
2408	if (link->key == canonical_key)
2409	return link->value;	2309	return kv->value;
2410		2310
2411	return 0;	2311	return shstr ();
2412	}	2312	}
2413		2313
2414	/*	2314	void
2415	* Updates the canonical_key in op to value.	2315	object::kv_set (shstr_tmp key, shstr_tmp value)
2416	*
2417	* canonical_key is a shared string (value doesn't have to be).
2418	*
2419	* Unless add_key is TRUE, it won't add fields, only change the value of existing
2420	* keys.
2421	*
2422	* Returns TRUE on success.
2423	*/
2424	int
2425	set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2426	{	2316	{
2427	key_value *field = NULL, *last = NULL;	2317	for (key_value *kv = key_values; kv; kv = kv->next)
2428		2318	if (kv->key == key)
2429	for (field = op->key_values; field != NULL; field = field->next)
2430	{
2431	if (field->key != canonical_key)
2432	{	2319	{
2433	last = field;	2320	kv->value = value;
2434	continue;	2321	return;
2435	}	2322	}
2436		2323
2437	if (value)	2324	key_value *kv = new key_value;
2438	field->value = value;	2325
2439	else	2326	kv->next = key_values;
		2327	kv->key = key;
		2328	kv->value = value;
		2329
		2330	key_values = kv;
		2331	}
		2332
		2333	void
		2334	object::kv_del (shstr_tmp key)
		2335	{
		2336	for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
		2337	if ((*kvp)->key == key)
2440	{	2338	{
2441	/* Basically, if the archetype has this key set,	2339	key_value *kv = *kvp;
2442	* we need to store the null value so when we save	2340	*kvp = (*kvp)->next;
2443	* it, we save the empty value so that when we load,	2341	delete kv;
2444	* we get this value back again.	2342	return;
2445	*/
2446	if (get_ob_key_link (op->arch, canonical_key))
2447	field->value = 0;
2448	else
2449	{
2450	if (last)
2451	last->next = field->next;
2452	else
2453	op->key_values = field->next;
2454
2455	delete field;
2456	}
2457	}	2343	}
2458	return TRUE;
2459	}
2460	/* IF we get here, key doesn't exist */
2461
2462	/* No field, we'll have to add it. */
2463
2464	if (!add_key)
2465	return FALSE;
2466
2467	/* There isn't any good reason to store a null
2468	* value in the key/value list. If the archetype has
2469	* this key, then we should also have it, so shouldn't
2470	* be here. If user wants to store empty strings,
2471	* should pass in ""
2472	*/
2473	if (value == NULL)
2474	return TRUE;
2475
2476	field = new key_value;
2477
2478	field->key = canonical_key;
2479	field->value = value;
2480	/* Usual prepend-addition. */
2481	field->next = op->key_values;
2482	op->key_values = field;
2483
2484	return TRUE;
2485	}
2486
2487	/*
2488	* Updates the key in op to value.
2489	*
2490	* If add_key is FALSE, this will only update existing keys,
2491	* and not add new ones.
2492	* In general, should be little reason FALSE is ever passed in for add_key
2493	*
2494	* Returns TRUE on success.
2495	*/
2496	int
2497	set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2498	{
2499	shstr key_ (key);
2500
2501	return set_ob_key_value_s (op, key_, value, add_key);
2502	}	2344	}
2503		2345
2504	object::depth_iterator::depth_iterator (object *container)	2346	object::depth_iterator::depth_iterator (object *container)
2505	: iterator_base (container)	2347	: iterator_base (container)
2506	{	2348	{
…		…
2556	{	2398	{
2557	char flagdesc[512];	2399	char flagdesc[512];
2558	char info2[256 * 4];	2400	char info2[256 * 4];
2559	char *p = info;	2401	char *p = info;
2560		2402
2561	p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s,flags:[%s],type:%d}",	2403	p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2562	count,	2404	count,
2563	uuid.c_str (),	2405	uuid.c_str (),
2564	&name,	2406	&name,
2565	title ? "\",title:\"" : "",	2407	title ? ",title:\"" : "",
2566	title ? (const char *)title : "",	2408	title ? (const char *)title : "",
		2409	title ? "\"" : "",
2567	flag_desc (flagdesc, 512), type);	2410	flag_desc (flagdesc, 512), type);
2568		2411
2569	if (!flag[FLAG_REMOVED] && env)	2412	if (!flag[FLAG_REMOVED] && env)
2570	p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));	2413	p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2571		2414
…		…
2604	object::open_container (object *new_container)	2447	object::open_container (object *new_container)
2605	{	2448	{
2606	if (container == new_container)	2449	if (container == new_container)
2607	return;	2450	return;
2608		2451
2609	if (object *old_container = container)	2452	object *old_container = container;
		2453
		2454	if (old_container)
2610	{	2455	{
2611	if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))	2456	if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))
2612	return;	2457	return;
2613		2458
2614	#if 0	2459	#if 0
…		…
2616	if (object *closer = old_container->inv)	2461	if (object *closer = old_container->inv)
2617	if (closer->type == CLOSE_CON)	2462	if (closer->type == CLOSE_CON)
2618	closer->destroy ();	2463	closer->destroy ();
2619	#endif	2464	#endif
2620		2465
		2466	// make sure the container is available
		2467	esrv_send_item (this, old_container);
		2468
2621	old_container->flag [FLAG_APPLIED] = false;	2469	old_container->flag [FLAG_APPLIED] = false;
2622	container = 0;	2470	container = 0;
2623		2471
		2472	// client needs item update to make it work, client bug requires this to be separate
2624	esrv_update_item (UPD_FLAGS, this, old_container);	2473	esrv_update_item (UPD_FLAGS, this, old_container);
		2474
2625	new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container));	2475	new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", old_container->query_name ());
2626	play_sound (sound_find ("chest_close"));	2476	play_sound (sound_find ("chest_close"));
2627	}	2477	}
2628		2478
2629	if (new_container)	2479	if (new_container)
2630	{	2480	{
…		…
2640	closer->flag [FLAG_NO_MAP_SAVE] = 1;	2490	closer->flag [FLAG_NO_MAP_SAVE] = 1;
2641	new_container->insert (closer);	2491	new_container->insert (closer);
2642	}	2492	}
2643	#endif	2493	#endif
2644		2494
2645	new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container));	2495	new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", new_container->query_name ());
		2496
		2497	// make sure the container is available, client bug requires this to be separate
		2498	esrv_send_item (this, new_container);
2646		2499
2647	new_container->flag [FLAG_APPLIED] = true;	2500	new_container->flag [FLAG_APPLIED] = true;
2648	container = new_container;	2501	container = new_container;
2649		2502
		2503	// client needs flag change
2650	esrv_update_item (UPD_FLAGS, this, new_container);	2504	esrv_update_item (UPD_FLAGS, this, new_container);
2651	esrv_send_inventory (this, new_container);	2505	esrv_send_inventory (this, new_container);
2652	play_sound (sound_find ("chest_open"));	2506	play_sound (sound_find ("chest_open"));
2653	}	2507	}
		2508	// else if (!old_container->env && contr && contr->ns)
		2509	// contr->ns->floorbox_reset ();
2654	}	2510	}
2655		2511
2656	object *	2512	object *
2657	object::force_find (const shstr name)	2513	object::force_find (shstr_tmp name)
2658	{	2514	{
2659	/* cycle through his inventory to look for the MARK we want to	2515	/* cycle through his inventory to look for the MARK we want to
2660	* place	2516	* place
2661	*/	2517	*/
2662	for (object *tmp = inv; tmp; tmp = tmp->below)	2518	for (object *tmp = inv; tmp; tmp = tmp->below)
…		…
2664	return splay (tmp);	2520	return splay (tmp);
2665		2521
2666	return 0;	2522	return 0;
2667	}	2523	}
2668		2524
		2525	//-GPL
		2526
2669	void	2527	void
		2528	object::force_set_timer (int duration)
		2529	{
		2530	this->duration = 1;
		2531	this->speed_left = -1.f;
		2532
		2533	this->set_speed (duration ? 1.f / duration : 0.f);
		2534	}
		2535
		2536	object *
2670	object::force_add (const shstr name, int duration)	2537	object::force_add (shstr_tmp name, int duration)
2671	{	2538	{
2672	if (object *force = force_find (name))	2539	if (object *force = force_find (name))
2673	force->destroy ();	2540	force->destroy ();
2674		2541
2675	object *force = get_archetype (FORCE_NAME);	2542	object *force = get_archetype (FORCE_NAME);
2676		2543
2677	force->slaying = name;	2544	force->slaying = name;
2678	force->stats.food = 1;	2545	force->force_set_timer (duration);
2679	force->speed_left = -1.f;
2680
2681	force->set_speed (duration ? 1.f / duration : 0.f);
2682	force->flag [FLAG_IS_USED_UP] = true;
2683	force->flag [FLAG_APPLIED] = true;	2546	force->flag [FLAG_APPLIED] = true;
2684		2547
2685	insert (force);	2548	return insert (force);
2686	}	2549	}
2687		2550
2688	void	2551	void
2689	object::play_sound (faceidx sound)	2552	object::play_sound (faceidx sound) const
2690	{	2553	{
2691	if (!sound)	2554	if (!sound)
2692	return;	2555	return;
2693		2556
2694	if (flag [FLAG_REMOVED])	2557	if (is_on_map ())
		2558	map->play_sound (sound, x, y);
		2559	else if (object *pl = in_player ())
		2560	pl->contr->play_sound (sound);
		2561	}
		2562
		2563	void
		2564	object::say_msg (const char *msg) const
		2565	{
		2566	if (is_on_map ())
		2567	map->say_msg (msg, x, y);
		2568	else if (object *pl = in_player ())
		2569	pl->contr->play_sound (sound);
		2570	}
		2571
		2572	void
		2573	object::make_noise ()
		2574	{
		2575	// we do not model noise in the map, so instead put
		2576	// a temporary light into the noise source
		2577	// could use the map instead, but that's less reliable for our
		2578	// goal, which is to make invisibility a bit harder to exploit
		2579
		2580	// currently only works sensibly for players
		2581	if (!is_player ())
2695	return;	2582	return;
2696		2583
2697	if (env)	2584	// find old force, or create new one
2698	{	2585	object *force = force_find (shstr_noise_force);
2699	if (object *pl = in_player ())	2586
2700	pl->contr->play_sound (sound);	2587	if (force)
2701	}	2588	force->speed_left = -1.f; // patch old speed up
2702	else	2589	else
2703	map->play_sound (sound, x, y);	2590	{
2704	}	2591	force = archetype::get (shstr_noise_force);
2705		2592
		2593	force->slaying = shstr_noise_force;
		2594	force->stats.food = 1;
		2595	force->speed_left = -1.f;
		2596
		2597	force->set_speed (1.f / 4.f);
		2598	force->flag [FLAG_IS_USED_UP] = true;
		2599	force->flag [FLAG_APPLIED] = true;
		2600
		2601	insert (force);
		2602	}
		2603	}
		2604

Diff Legend

–	Removed lines
+	Added lines
<	Changed lines
>	Changed lines