ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.30 by root, Mon Sep 11 20:28:37 2006 UTC vs.
Revision 1.134 by pippijn, Thu Mar 1 12:28:16 2007 UTC

1
2/* 1/*
3 CrossFire, A Multiplayer game for X-windows 2 * CrossFire, A Multiplayer game for X-windows
4 3 *
4 * Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team
5 Copyright (C) 2001 Mark Wedel & Crossfire Development Team 5 * Copyright (C) 2001 Mark Wedel & Crossfire Development Team
6 Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (C) 1992 Frank Tore Johansen
7 7 *
8 This program is free software; you can redistribute it and/or modify 8 * This program is free software; you can redistribute it and/or modify
9 it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
10 the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation; either version 2 of the License, or
11 (at your option) any later version. 11 * (at your option) any later version.
12 12 *
13 This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 GNU General Public License for more details. 16 * GNU General Public License for more details.
17 17 *
18 You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
19 along with this program; if not, write to the Free Software 19 * along with this program; if not, write to the Free Software
20 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
21 21 *
22 The authors can be reached via e-mail at crossfire-devel@real-time.com 22 * The authors can be reached via e-mail at <crossfire@schmorp.de>
23*/ 23 */
24 24
25/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects. 25/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
26 sub/add_weight will transcend the environment updating the carrying 26 sub/add_weight will transcend the environment updating the carrying
27 variable. */ 27 variable. */
28#include <global.h> 28#include <global.h>
29#include <stdio.h> 29#include <stdio.h>
30#include <sys/types.h> 30#include <sys/types.h>
31#include <sys/uio.h> 31#include <sys/uio.h>
32#include <object.h> 32#include <object.h>
33#include <funcpoint.h> 33#include <funcpoint.h>
34#include <skills.h>
35#include <loader.h> 34#include <loader.h>
36 35
36#include <bitset>
37
37int nrofallocobjects = 0; 38int nrofallocobjects = 0;
39static UUID uuid;
40const uint64 UUID_SKIP = 1<<19;
38 41
39object *objects; /* Pointer to the list of used objects */ 42objectvec objects;
40object *active_objects; /* List of active objects that need to be processed */ 43activevec actives;
41 44
42short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 45short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
43 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1 46 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1
44}; 47};
45short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, 48short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
51int freedir[SIZEOFFREE] = { 54int freedir[SIZEOFFREE] = {
52 0, 1, 2, 3, 4, 5, 6, 7, 8, 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8, 55 0, 1, 2, 3, 4, 5, 6, 7, 8, 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,
53 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8 56 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8
54}; 57};
55 58
59static void
60write_uuid (void)
61{
62 char filename1[MAX_BUF], filename2[MAX_BUF];
63
64 sprintf (filename1, "%s/uuid", settings.localdir);
65 sprintf (filename2, "%s/uuid~", settings.localdir);
66
67 FILE *fp;
68
69 if (!(fp = fopen (filename2, "w")))
70 {
71 LOG (llevError, "ERROR: cannot open %s for writing, unable to write UUID!\n", filename2);
72 return;
73 }
74
75 fprintf (fp, "<1,%llx>\n", (unsigned long long)uuid.seq + UUID_SKIP * 2);
76 fclose (fp);
77 rename (filename2, filename1);
78}
79
80static void
81read_uuid (void)
82{
83 char filename[MAX_BUF];
84
85 sprintf (filename, "%s/uuid", settings.localdir);
86
87 FILE *fp;
88
89 if (!(fp = fopen (filename, "r")))
90 {
91 if (errno == ENOENT)
92 {
93 LOG (llevInfo, "RESET uid to 1\n");
94 uuid.seq = 0;
95 write_uuid ();
96 return;
97 }
98
99 LOG (llevError, "FATAL: cannot open %s for reading!\n", filename);
100 _exit (1);
101 }
102
103 int version;
104 unsigned long long uid;
105 if (2 != fscanf (fp, "<%d,%llx>\n", &version, &uid) || version != 1)
106 {
107 LOG (llevError, "FATAL: error reading uid from %s!\n", filename);
108 _exit (1);
109 }
110
111 uuid.seq = uid;
112 write_uuid ();
113 LOG (llevDebug, "read UID: %" PRId64 "\n", uid);
114 fclose (fp);
115}
116
117UUID
118gen_uuid ()
119{
120 UUID uid;
121
122 uid.seq = ++uuid.seq;
123
124 if (!(uuid.seq & (UUID_SKIP - 1)))
125 write_uuid ();
126
127 return uid;
128}
129
130void
131init_uuid ()
132{
133 read_uuid ();
134}
135
56/* Returns TRUE if every key_values in wants has a partner with the same value in has. */ 136/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
57static int 137static int
58compare_ob_value_lists_one (const object *wants, const object *has) 138compare_ob_value_lists_one (const object *wants, const object *has)
59{ 139{
60 key_value *wants_field; 140 key_value *wants_field;
63 * objects with lists are rare, and lists stay short. If not, use a 143 * objects with lists are rare, and lists stay short. If not, use a
64 * different structure or at least keep the lists sorted... 144 * different structure or at least keep the lists sorted...
65 */ 145 */
66 146
67 /* For each field in wants, */ 147 /* For each field in wants, */
68 for (wants_field = wants->key_values; wants_field != NULL; wants_field = wants_field->next) 148 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)
69 { 149 {
70 key_value *has_field; 150 key_value *has_field;
71 151
72 /* Look for a field in has with the same key. */ 152 /* Look for a field in has with the same key. */
73 has_field = get_ob_key_link (has, wants_field->key); 153 has_field = get_ob_key_link (has, wants_field->key);
107 * 187 *
108 * Note that this function appears a lot longer than the macro it 188 * Note that this function appears a lot longer than the macro it
109 * replaces - this is mostly for clarity - a decent compiler should hopefully 189 * replaces - this is mostly for clarity - a decent compiler should hopefully
110 * reduce this to the same efficiency. 190 * reduce this to the same efficiency.
111 * 191 *
112 * Check nrof variable *before* calling CAN_MERGE() 192 * Check nrof variable *before* calling can_merge()
113 * 193 *
114 * Improvements made with merge: Better checking on potion, and also 194 * Improvements made with merge: Better checking on potion, and also
115 * check weight 195 * check weight
116 */ 196 */
117
118bool object::can_merge (object *ob1, object *ob2) 197bool object::can_merge_slow (object *ob1, object *ob2)
119{ 198{
120 /* A couple quicksanity checks */ 199 /* A couple quicksanity checks */
121 if ((ob1 == ob2) || (ob1->type != ob2->type)) 200 if (ob1 == ob2
201 || ob1->type != ob2->type
202 || ob1->speed != ob2->speed
203 || ob1->value != ob2->value
204 || ob1->name != ob2->name)
122 return 0; 205 return 0;
123 206
124 if (ob1->speed != ob2->speed) 207 //TODO: this ain't working well, use nicer and correct overflow check
125 return 0;
126
127 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that 208 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that
128 * value could not be stored in a sint32 (which unfortunately sometimes is 209 * value could not be stored in a sint32 (which unfortunately sometimes is
129 * used to store nrof). 210 * used to store nrof).
130 */ 211 */
131 if (ob1->nrof + ob2->nrof >= 1UL << 31) 212 if (ob1->nrof + ob2->nrof >= 1UL << 31)
141 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 222 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
142 223
143 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 224 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
144 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 225 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
145 226
146 227 if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any ()
147 /* the 0x400000 on flags2 is FLAG_INV_LOCK. I don't think something 228 || ob1->arch != ob2->arch
148 * being locked in inventory should prevent merging.
149 * 0x4 in flags3 is CLIENT_SENT
150 */
151 if ((ob1->arch != ob2->arch) ||
152 (ob1->flags[0] != ob2->flags[0]) ||
153 (ob1->flags[1] != ob2->flags[1]) ||
154 ((ob1->flags[2] & ~0x400000) != (ob2->flags[2] & ~0x400000)) ||
155 ((ob1->flags[3] & ~0x4) != (ob2->flags[3] & ~0x4)) ||
156 (ob1->name != ob2->name) || 229 || ob1->name != ob2->name
157 (ob1->title != ob2->title) || 230 || ob1->title != ob2->title
158 (ob1->msg != ob2->msg) || 231 || ob1->msg != ob2->msg
159 (ob1->weight != ob2->weight) || 232 || ob1->weight != ob2->weight
160 (memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist)) != 0) || 233 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
161 (memcmp (&ob1->stats, &ob2->stats, sizeof (ob1->stats)) != 0) || 234 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
162 (ob1->attacktype != ob2->attacktype) || 235 || ob1->attacktype != ob2->attacktype
163 (ob1->magic != ob2->magic) || 236 || ob1->magic != ob2->magic
164 (ob1->slaying != ob2->slaying) || 237 || ob1->slaying != ob2->slaying
165 (ob1->skill != ob2->skill) || 238 || ob1->skill != ob2->skill
166 (ob1->value != ob2->value) || 239 || ob1->value != ob2->value
167 (ob1->animation_id != ob2->animation_id) || 240 || ob1->animation_id != ob2->animation_id
168 (ob1->client_type != ob2->client_type) || 241 || ob1->client_type != ob2->client_type
169 (ob1->materialname != ob2->materialname) || 242 || ob1->materialname != ob2->materialname
170 (ob1->lore != ob2->lore) || 243 || ob1->lore != ob2->lore
171 (ob1->subtype != ob2->subtype) || 244 || ob1->subtype != ob2->subtype
172 (ob1->move_type != ob2->move_type) || 245 || ob1->move_type != ob2->move_type
173 (ob1->move_block != ob2->move_block) || 246 || ob1->move_block != ob2->move_block
174 (ob1->move_allow != ob2->move_allow) || 247 || ob1->move_allow != ob2->move_allow
175 (ob1->move_on != ob2->move_on) || 248 || ob1->move_on != ob2->move_on
176 (ob1->move_off != ob2->move_off) || (ob1->move_slow != ob2->move_slow) || (ob1->move_slow_penalty != ob2->move_slow_penalty)) 249 || ob1->move_off != ob2->move_off
250 || ob1->move_slow != ob2->move_slow
251 || ob1->move_slow_penalty != ob2->move_slow_penalty)
177 return 0; 252 return 0;
178 253
179 /* This is really a spellbook check - really, we should 254 /* This is really a spellbook check - really, we should
180 * check all objects in the inventory. 255 * check all objects in the inventory.
181 */ 256 */
184 /* if one object has inventory but the other doesn't, not equiv */ 259 /* if one object has inventory but the other doesn't, not equiv */
185 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv)) 260 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv))
186 return 0; 261 return 0;
187 262
188 /* Now check to see if the two inventory objects could merge */ 263 /* Now check to see if the two inventory objects could merge */
189 if (!CAN_MERGE (ob1->inv, ob2->inv)) 264 if (!object::can_merge (ob1->inv, ob2->inv))
190 return 0; 265 return 0;
191 266
192 /* inventory ok - still need to check rest of this object to see 267 /* inventory ok - still need to check rest of this object to see
193 * if it is valid. 268 * if it is valid.
194 */ 269 */
203 278
204 /* Note sure why the following is the case - either the object has to 279 /* Note sure why the following is the case - either the object has to
205 * be animated or have a very low speed. Is this an attempted monster 280 * be animated or have a very low speed. Is this an attempted monster
206 * check? 281 * check?
207 */ 282 */
208 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && FABS ((ob1)->speed) > MIN_ACTIVE_SPEED) 283 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && ob1->has_active_speed ())
209 return 0; 284 return 0;
210 285
211 switch (ob1->type) 286 switch (ob1->type)
212 { 287 {
213 case SCROLL: 288 case SCROLL:
255 { 330 {
256 if (inv->inv) 331 if (inv->inv)
257 sum_weight (inv); 332 sum_weight (inv);
258 sum += inv->carrying + inv->weight * (inv->nrof ? inv->nrof : 1); 333 sum += inv->carrying + inv->weight * (inv->nrof ? inv->nrof : 1);
259 } 334 }
335
260 if (op->type == CONTAINER && op->stats.Str) 336 if (op->type == CONTAINER && op->stats.Str)
261 sum = (sum * (100 - op->stats.Str)) / 100; 337 sum = (sum * (100 - op->stats.Str)) / 100;
338
262 if (op->carrying != sum) 339 if (op->carrying != sum)
263 op->carrying = sum; 340 op->carrying = sum;
341
264 return sum; 342 return sum;
265} 343}
266 344
267/** 345/**
268 * Return the outermost environment object for a given object. 346 * Return the outermost environment object for a given object.
275 op = op->env; 353 op = op->env;
276 return op; 354 return op;
277} 355}
278 356
279/* 357/*
280 * Eneq(@csd.uu.se): Since we can have items buried in a character we need
281 * a better check. We basically keeping traversing up until we can't
282 * or find a player.
283 */
284
285object *
286is_player_inv (object *op)
287{
288 for (; op != NULL && op->type != PLAYER; op = op->env)
289 if (op->env == op)
290 op->env = NULL;
291 return op;
292}
293
294/*
295 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump. 358 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
296 * Some error messages. 359 * Some error messages.
297 * The result of the dump is stored in the static global errmsg array. 360 * The result of the dump is stored in the static global errmsg array.
298 */ 361 */
299 362char *
300void
301dump_object2 (object *op)
302{
303 errmsg[0] = 0;
304 return;
305 //TODO//D#d#
306#if 0
307 char *cp;
308
309/* object *tmp;*/
310
311 if (op->arch != NULL)
312 {
313 strcat (errmsg, "arch ");
314 strcat (errmsg, op->arch->name ? op->arch->name : "(null)");
315 strcat (errmsg, "\n");
316 if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
317 strcat (errmsg, cp);
318# if 0
319 /* Don't dump player diffs - they are too long, mostly meaningless, and
320 * will overflow the buffer.
321 * Changed so that we don't dump inventory either. This may
322 * also overflow the buffer.
323 */
324 if (op->type != PLAYER && (cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
325 strcat (errmsg, cp);
326 for (tmp = op->inv; tmp; tmp = tmp->below)
327 dump_object2 (tmp);
328# endif
329 strcat (errmsg, "end\n");
330 }
331 else
332 {
333 strcat (errmsg, "Object ");
334 if (op->name == NULL)
335 strcat (errmsg, "(null)");
336 else
337 strcat (errmsg, op->name);
338 strcat (errmsg, "\n");
339# if 0
340 if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
341 strcat (errmsg, cp);
342 for (tmp = op->inv; tmp; tmp = tmp->below)
343 dump_object2 (tmp);
344# endif
345 strcat (errmsg, "end\n");
346 }
347#endif
348}
349
350/*
351 * Dumps an object. Returns output in the static global errmsg array.
352 */
353
354void
355dump_object (object *op) 363dump_object (object *op)
356{ 364{
357 if (op == NULL) 365 if (!op)
358 { 366 return strdup ("[NULLOBJ]");
359 strcpy (errmsg, "[NULL pointer]");
360 return;
361 }
362 errmsg[0] = '\0';
363 dump_object2 (op);
364}
365 367
366void 368 object_freezer freezer;
367dump_all_objects (void) 369 op->write (freezer);
368{ 370 return freezer.as_string ();
369 object *op;
370
371 for (op = objects; op != NULL; op = op->next)
372 {
373 dump_object (op);
374 fprintf (logfile, "Object %d\n:%s\n", op->count, errmsg);
375 }
376} 371}
377 372
378/* 373/*
379 * get_nearest_part(multi-object, object 2) returns the part of the 374 * get_nearest_part(multi-object, object 2) returns the part of the
380 * multi-object 1 which is closest to the second object. 375 * multi-object 1 which is closest to the second object.
396} 391}
397 392
398/* 393/*
399 * Returns the object which has the count-variable equal to the argument. 394 * Returns the object which has the count-variable equal to the argument.
400 */ 395 */
401
402object * 396object *
403find_object (tag_t i) 397find_object (tag_t i)
404{ 398{
405 object *op; 399 for_all_objects (op)
406
407 for (op = objects; op != NULL; op = op->next)
408 if (op->count == i) 400 if (op->count == i)
409 break;
410 return op; 401 return op;
402
403 return 0;
411} 404}
412 405
413/* 406/*
414 * Returns the first object which has a name equal to the argument. 407 * Returns the first object which has a name equal to the argument.
415 * Used only by the patch command, but not all that useful. 408 * Used only by the patch command, but not all that useful.
416 * Enables features like "patch <name-of-other-player> food 999" 409 * Enables features like "patch <name-of-other-player> food 999"
417 */ 410 */
418
419object * 411object *
420find_object_name (const char *str) 412find_object_name (const char *str)
421{ 413{
422 const char *name = shstr::find (str); 414 shstr_cmp str_ (str);
423 object *op; 415 object *op;
424 416
425 for (op = objects; op != NULL; op = op->next) 417 for_all_objects (op)
426 if (&op->name == name) 418 if (op->name == str_)
427 break; 419 break;
428 420
429 return op; 421 return op;
430} 422}
431 423
432void 424void
433free_all_object_data () 425free_all_object_data ()
434{ 426{
435 LOG (llevDebug, "%d allocated objects\n", nrofallocobjects); 427 LOG (llevDebug, "%d allocated objects\n", nrofallocobjects);
436}
437
438/*
439 * Returns the object which this object marks as being the owner.
440 * A id-scheme is used to avoid pointing to objects which have been
441 * freed and are now reused. If this is detected, the owner is
442 * set to NULL, and NULL is returned.
443 * Changed 2004-02-12 - if the player is setting at the play again
444 * prompt, he is removed, and we don't want to treat him as an owner of
445 * anything, so check removed flag. I don't expect that this should break
446 * anything - once an object is removed, it is basically dead anyways.
447 */
448object *
449object::get_owner ()
450{
451 if (!owner
452 || QUERY_FLAG (owner, FLAG_FREED)
453 || QUERY_FLAG (owner, FLAG_REMOVED))
454 owner = 0;
455
456 return owner;
457} 428}
458 429
459/* 430/*
460 * Sets the owner and sets the skill and exp pointers to owner's current 431 * Sets the owner and sets the skill and exp pointers to owner's current
461 * skill and experience objects. 432 * skill and experience objects.
494 } 465 }
495 466
496 op->key_values = 0; 467 op->key_values = 0;
497} 468}
498 469
499void object::clear ()
500{
501 attachable_base::clear ();
502
503 free_key_values (this);
504
505 owner = 0;
506 name = 0;
507 name_pl = 0;
508 title = 0;
509 race = 0;
510 slaying = 0;
511 skill = 0;
512 msg = 0;
513 lore = 0;
514 custom_name = 0;
515 materialname = 0;
516 contr = 0;
517 below = 0;
518 above = 0;
519 inv = 0;
520 container = 0;
521 env = 0;
522 more = 0;
523 head = 0;
524 map = 0;
525 active_next = 0;
526 active_prev = 0;
527
528 memset (static_cast<object_pod *>(this), 0, sizeof (object_pod));
529
530 SET_FLAG (this, FLAG_REMOVED);
531
532 /* What is not cleared is next, prev, and count */
533
534 expmul = 1.0;
535 face = blank_face;
536 attacked_by_count = -1;
537
538 if (settings.casting_time)
539 casting_time = -1;
540}
541
542void object::clone (object *destination)
543{
544 *(object_copy *)destination = *this;
545 *(object_pod *)destination = *this;
546
547 if (self || cb)
548 INVOKE_OBJECT (CLONE, this, ARG_OBJECT (destination));
549}
550
551/* 470/*
552 * copy object first frees everything allocated by the second object, 471 * copy_to first frees everything allocated by the dst object,
553 * and then copies the contends of the first object into the second 472 * and then copies the contents of itself into the second
554 * object, allocating what needs to be allocated. Basically, any 473 * object, allocating what needs to be allocated. Basically, any
555 * data that is malloc'd needs to be re-malloc/copied. Otherwise, 474 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
556 * if the first object is freed, the pointers in the new object 475 * if the first object is freed, the pointers in the new object
557 * will point at garbage. 476 * will point at garbage.
558 */ 477 */
559void 478void
560copy_object (object *op2, object *op) 479object::copy_to (object *dst)
561{ 480{
562 bool is_freed = QUERY_FLAG (op, FLAG_FREED); 481 bool is_freed = QUERY_FLAG (dst, FLAG_FREED);
563 bool is_removed = QUERY_FLAG (op, FLAG_REMOVED); 482 bool is_removed = QUERY_FLAG (dst, FLAG_REMOVED);
564 483
565 op2->clone (op); 484 *(object_copy *)dst = *this;
566 485
567 if (is_freed) 486 if (is_freed)
568 SET_FLAG (op, FLAG_FREED); 487 SET_FLAG (dst, FLAG_FREED);
488
569 if (is_removed) 489 if (is_removed)
570 SET_FLAG (op, FLAG_REMOVED); 490 SET_FLAG (dst, FLAG_REMOVED);
571 491
572 if (op2->speed < 0) 492 if (speed < 0)
573 op->speed_left = op2->speed_left - RANDOM () % 200 / 100.0; 493 dst->speed_left = speed_left - rndm ();
574 494
575 /* Copy over key_values, if any. */ 495 /* Copy over key_values, if any. */
576 if (op2->key_values) 496 if (key_values)
577 { 497 {
578 key_value *tail = 0; 498 key_value *tail = 0;
579 key_value *i; 499 key_value *i;
580 500
581 op->key_values = 0; 501 dst->key_values = 0;
582 502
583 for (i = op2->key_values; i; i = i->next) 503 for (i = key_values; i; i = i->next)
584 { 504 {
585 key_value *new_link = new key_value; 505 key_value *new_link = new key_value;
586 506
587 new_link->next = 0; 507 new_link->next = 0;
588 new_link->key = i->key; 508 new_link->key = i->key;
589 new_link->value = i->value; 509 new_link->value = i->value;
590 510
591 /* Try and be clever here, too. */ 511 /* Try and be clever here, too. */
592 if (!op->key_values) 512 if (!dst->key_values)
593 { 513 {
594 op->key_values = new_link; 514 dst->key_values = new_link;
595 tail = new_link; 515 tail = new_link;
596 } 516 }
597 else 517 else
598 { 518 {
599 tail->next = new_link; 519 tail->next = new_link;
600 tail = new_link; 520 tail = new_link;
601 } 521 }
602 } 522 }
603 } 523 }
604 524
605 update_ob_speed (op); 525 dst->set_speed (dst->speed);
526}
527
528void
529object::instantiate ()
530{
531 if (!uuid.seq) // HACK
532 uuid = gen_uuid ();
533
534 speed_left = -0.1f;
535 /* copy the body_info to the body_used - this is only really
536 * need for monsters, but doesn't hurt to do it for everything.
537 * by doing so, when a monster is created, it has good starting
538 * values for the body_used info, so when items are created
539 * for it, they can be properly equipped.
540 */
541 memcpy (body_used, body_info, sizeof (body_used));
542
543 attachable::instantiate ();
544}
545
546object *
547object::clone ()
548{
549 object *neu = create ();
550 copy_to (neu);
551 return neu;
606} 552}
607 553
608/* 554/*
609 * If an object with the IS_TURNABLE() flag needs to be turned due 555 * If an object with the IS_TURNABLE() flag needs to be turned due
610 * to the closest player being on the other side, this function can 556 * to the closest player being on the other side, this function can
611 * be called to update the face variable, _and_ how it looks on the map. 557 * be called to update the face variable, _and_ how it looks on the map.
612 */ 558 */
613
614void 559void
615update_turn_face (object *op) 560update_turn_face (object *op)
616{ 561{
617 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || op->arch == NULL) 562 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || !op->arch)
618 return; 563 return;
564
619 SET_ANIMATION (op, op->direction); 565 SET_ANIMATION (op, op->direction);
620 update_object (op, UP_OBJ_FACE); 566 update_object (op, UP_OBJ_FACE);
621} 567}
622 568
623/* 569/*
624 * Updates the speed of an object. If the speed changes from 0 to another 570 * Updates the speed of an object. If the speed changes from 0 to another
625 * value, or vice versa, then add/remove the object from the active list. 571 * value, or vice versa, then add/remove the object from the active list.
626 * This function needs to be called whenever the speed of an object changes. 572 * This function needs to be called whenever the speed of an object changes.
627 */ 573 */
628
629void 574void
630update_ob_speed (object *op) 575object::set_speed (float speed)
631{ 576{
632 extern int arch_init; 577 if (flag [FLAG_FREED] && speed)
633
634 /* No reason putting the archetypes objects on the speed list,
635 * since they never really need to be updated.
636 */
637
638 if (QUERY_FLAG (op, FLAG_FREED) && op->speed)
639 { 578 {
640 LOG (llevError, "Object %s is freed but has speed.\n", &op->name); 579 LOG (llevError, "Object %s is freed but has speed.\n", &name);
641#ifdef MANY_CORES
642 abort ();
643#else
644 op->speed = 0; 580 speed = 0;
645#endif
646 }
647 if (arch_init)
648 { 581 }
649 return;
650 }
651 if (FABS (op->speed) > MIN_ACTIVE_SPEED)
652 {
653 /* If already on active list, don't do anything */
654 if (op->active_next || op->active_prev || op == active_objects)
655 return;
656 582
657 /* process_events() expects us to insert the object at the beginning 583 this->speed = speed;
658 * of the list. */ 584
659 op->active_next = active_objects; 585 if (has_active_speed ())
660 if (op->active_next != NULL) 586 activate ();
661 op->active_next->active_prev = op;
662 active_objects = op;
663 }
664 else 587 else
665 { 588 deactivate ();
666 /* If not on the active list, nothing needs to be done */
667 if (!op->active_next && !op->active_prev && op != active_objects)
668 return;
669
670 if (op->active_prev == NULL)
671 {
672 active_objects = op->active_next;
673 if (op->active_next != NULL)
674 op->active_next->active_prev = NULL;
675 }
676 else
677 {
678 op->active_prev->active_next = op->active_next;
679 if (op->active_next)
680 op->active_next->active_prev = op->active_prev;
681 }
682 op->active_next = NULL;
683 op->active_prev = NULL;
684 }
685} 589}
686 590
687/* This function removes object 'op' from the list of active
688 * objects.
689 * This should only be used for style maps or other such
690 * reference maps where you don't want an object that isn't
691 * in play chewing up cpu time getting processed.
692 * The reverse of this is to call update_ob_speed, which
693 * will do the right thing based on the speed of the object.
694 */
695void
696remove_from_active_list (object *op)
697{
698 /* If not on the active list, nothing needs to be done */
699 if (!op->active_next && !op->active_prev && op != active_objects)
700 return;
701
702 if (op->active_prev == NULL)
703 {
704 active_objects = op->active_next;
705 if (op->active_next != NULL)
706 op->active_next->active_prev = NULL;
707 }
708 else
709 {
710 op->active_prev->active_next = op->active_next;
711 if (op->active_next)
712 op->active_next->active_prev = op->active_prev;
713 }
714 op->active_next = NULL;
715 op->active_prev = NULL;
716}
717
718/* 591/*
719 * update_object() updates the array which represents the map. 592 * update_object() updates the the map.
720 * It takes into account invisible objects (and represent squares covered 593 * It takes into account invisible objects (and represent squares covered
721 * by invisible objects by whatever is below them (unless it's another 594 * by invisible objects by whatever is below them (unless it's another
722 * invisible object, etc...) 595 * invisible object, etc...)
723 * If the object being updated is beneath a player, the look-window 596 * If the object being updated is beneath a player, the look-window
724 * of that player is updated (this might be a suboptimal way of 597 * of that player is updated (this might be a suboptimal way of
725 * updating that window, though, since update_object() is called _often_) 598 * updating that window, though, since update_object() is called _often_)
726 * 599 *
727 * action is a hint of what the caller believes need to be done. 600 * action is a hint of what the caller believes need to be done.
728 * For example, if the only thing that has changed is the face (due to
729 * an animation), we don't need to call update_position until that actually
730 * comes into view of a player. OTOH, many other things, like addition/removal
731 * of walls or living creatures may need us to update the flags now.
732 * current action are: 601 * current action are:
733 * UP_OBJ_INSERT: op was inserted 602 * UP_OBJ_INSERT: op was inserted
734 * UP_OBJ_REMOVE: op was removed 603 * UP_OBJ_REMOVE: op was removed
735 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update 604 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update
736 * as that is easier than trying to look at what may have changed. 605 * as that is easier than trying to look at what may have changed.
737 * UP_OBJ_FACE: only the objects face has changed. 606 * UP_OBJ_FACE: only the objects face has changed.
738 */ 607 */
739
740void 608void
741update_object (object *op, int action) 609update_object (object *op, int action)
742{ 610{
743 int update_now = 0, flags;
744 MoveType move_on, move_off, move_block, move_slow;
745
746 if (op == NULL) 611 if (op == NULL)
747 { 612 {
748 /* this should never happen */ 613 /* this should never happen */
749 LOG (llevDebug, "update_object() called for NULL object.\n"); 614 LOG (llevDebug, "update_object() called for NULL object.\n");
750 return; 615 return;
751 } 616 }
752 617
753 if (op->env != NULL) 618 if (op->env)
754 { 619 {
755 /* Animation is currently handled by client, so nothing 620 /* Animation is currently handled by client, so nothing
756 * to do in this case. 621 * to do in this case.
757 */ 622 */
758 return; 623 return;
763 */ 628 */
764 if (!op->map || op->map->in_memory == MAP_SAVING) 629 if (!op->map || op->map->in_memory == MAP_SAVING)
765 return; 630 return;
766 631
767 /* make sure the object is within map boundaries */ 632 /* make sure the object is within map boundaries */
768 if (op->x < 0 || op->x >= MAP_WIDTH (op->map) || op->y < 0 || op->y >= MAP_HEIGHT (op->map)) 633 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
769 { 634 {
770 LOG (llevError, "update_object() called for object out of map!\n"); 635 LOG (llevError, "update_object() called for object out of map!\n");
771#ifdef MANY_CORES 636#ifdef MANY_CORES
772 abort (); 637 abort ();
773#endif 638#endif
774 return; 639 return;
775 } 640 }
776 641
777 flags = GET_MAP_FLAGS (op->map, op->x, op->y); 642 mapspace &m = op->ms ();
778 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NEED_UPDATE);
779 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
780 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
781 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
782 move_off = GET_MAP_MOVE_OFF (op->map, op->x, op->y);
783 643
644 if (!(m.flags_ & P_UPTODATE))
645 /* nop */;
784 if (action == UP_OBJ_INSERT) 646 else if (action == UP_OBJ_INSERT)
785 { 647 {
648 // this is likely overkill, TODO: revisit (schmorp)
786 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(flags & P_BLOCKSVIEW)) 649 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
787 update_now = 1;
788
789 if (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(flags & P_NO_MAGIC)) 650 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
790 update_now = 1; 651 || (op->type == PLAYER && !(m.flags_ & P_PLAYER))
791 652 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
653 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
792 if (QUERY_FLAG (op, FLAG_DAMNED) && !(flags & P_NO_CLERIC)) 654 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
793 update_now = 1;
794
795 if (QUERY_FLAG (op, FLAG_ALIVE) && !(flags & P_IS_ALIVE))
796 update_now = 1;
797
798 if (op->type == SAFE_GROUND && !(flags & P_SAFE))
799 update_now = 1;
800
801 if ((move_on | op->move_on) != move_on) 655 || (m.move_on | op->move_on ) != m.move_on
802 update_now = 1;
803
804 if ((move_off | op->move_off) != move_off) 656 || (m.move_off | op->move_off ) != m.move_off
805 update_now = 1; 657 || (m.move_slow | op->move_slow) != m.move_slow
806
807 /* This isn't perfect, but I don't expect a lot of objects to 658 /* This isn't perfect, but I don't expect a lot of objects to
808 * to have move_allow right now. 659 * to have move_allow right now.
809 */ 660 */
810 if (((move_block | op->move_block) & ~op->move_allow) != move_block) 661 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
811 update_now = 1; 662 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
812 663 m.flags_ = 0;
813 if ((move_slow | op->move_slow) != move_slow)
814 update_now = 1;
815 } 664 }
816 /* if the object is being removed, we can't make intelligent 665 /* if the object is being removed, we can't make intelligent
817 * decisions, because remove_ob can't really pass the object 666 * decisions, because remove_ob can't really pass the object
818 * that is being removed. 667 * that is being removed.
819 */ 668 */
820 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 669 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
821 update_now = 1; 670 m.flags_ = 0;
822 else if (action == UP_OBJ_FACE) 671 else if (action == UP_OBJ_FACE)
823 /* Nothing to do for that case */ ; 672 /* Nothing to do for that case */ ;
824 else 673 else
825 LOG (llevError, "update_object called with invalid action: %d\n", action); 674 LOG (llevError, "update_object called with invalid action: %d\n", action);
826 675
827 if (update_now)
828 {
829 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NO_ERROR | P_NEED_UPDATE);
830 update_position (op->map, op->x, op->y);
831 }
832
833 if (op->more != NULL) 676 if (op->more)
834 update_object (op->more, action); 677 update_object (op->more, action);
835}
836
837static unordered_vector<object *> mortals;
838static std::vector<object *> freed;
839
840void object::free_mortals ()
841{
842 for (unordered_vector<object *>::iterator i = mortals.begin (); i != mortals.end ();)
843 if ((*i)->refcnt)
844 ++i; // further delay freeing
845 else
846 {
847 freed.push_back (*i);//D
848 //delete *i;
849 mortals.erase (i);
850 }
851
852 if (mortals.size())//D
853 LOG (llevDebug, "%d objects in mortal queue\n", mortals.size());//D
854} 678}
855 679
856object::object () 680object::object ()
857{ 681{
858 SET_FLAG (this, FLAG_REMOVED); 682 SET_FLAG (this, FLAG_REMOVED);
859 683
860 expmul = 1.0; 684 expmul = 1.0;
861 face = blank_face; 685 face = blank_face;
862 attacked_by_count = -1;
863} 686}
864 687
865object::~object () 688object::~object ()
866{ 689{
690 unlink ();
691
867 free_key_values (this); 692 free_key_values (this);
868} 693}
869 694
695static int object_count;
696
870void object::link () 697void object::link ()
871{ 698{
699 assert (!index);//D
700 uuid = gen_uuid ();
872 count = ++ob_count; 701 count = ++object_count;
873 702
874 prev = 0; 703 refcnt_inc ();
875 next = objects; 704 objects.insert (this);
876
877 if (objects)
878 objects->prev = this;
879
880 objects = this;
881} 705}
882 706
883void object::unlink () 707void object::unlink ()
884{ 708{
885 count = 0;
886
887 /* Remove this object from the list of used objects */
888 if (prev)
889 {
890 prev->next = next;
891 prev = 0;
892 }
893
894 if (next) 709 if (!index)
895 { 710 return;
896 next->prev = prev; 711
897 next = 0; 712 objects.erase (this);
713 refcnt_dec ();
714}
715
716void
717object::activate ()
718{
719 /* If already on active list, don't do anything */
720 if (active)
721 return;
722
723 if (has_active_speed ())
724 actives.insert (this);
725}
726
727void
728object::activate_recursive ()
729{
730 activate ();
731
732 for (object *op = inv; op; op = op->below)
733 op->activate_recursive ();
734}
735
736/* This function removes object 'op' from the list of active
737 * objects.
738 * This should only be used for style maps or other such
739 * reference maps where you don't want an object that isn't
740 * in play chewing up cpu time getting processed.
741 * The reverse of this is to call update_ob_speed, which
742 * will do the right thing based on the speed of the object.
743 */
744void
745object::deactivate ()
746{
747 /* If not on the active list, nothing needs to be done */
748 if (!active)
749 return;
750
751 actives.erase (this);
752}
753
754void
755object::deactivate_recursive ()
756{
757 for (object *op = inv; op; op = op->below)
758 op->deactivate_recursive ();
759
760 deactivate ();
761}
762
763void
764object::set_flag_inv (int flag, int value)
765{
766 for (object *op = inv; op; op = op->below)
898 } 767 {
768 op->flag [flag] = value;
769 op->set_flag_inv (flag, value);
770 }
771}
899 772
900 if (this == objects) 773/*
901 objects = next; 774 * Remove and free all objects in the inventory of the given object.
775 * object.c ?
776 */
777void
778object::destroy_inv (bool drop_to_ground)
779{
780 // need to check first, because the checks below might segfault
781 // as we might be on an invalid mapspace and crossfire code
782 // is too buggy to ensure that the inventory is empty.
783 // corollary: if you create arrows etc. with stuff in tis inventory,
784 // cf will crash below with off-map x and y
785 if (!inv)
786 return;
787
788 /* Only if the space blocks everything do we not process -
789 * if some form of movement is allowed, let objects
790 * drop on that space.
791 */
792 if (!drop_to_ground
793 || !map
794 || map->in_memory != MAP_IN_MEMORY
795 || map->nodrop
796 || ms ().move_block == MOVE_ALL)
797 {
798 while (inv)
799 {
800 inv->destroy_inv (drop_to_ground);
801 inv->destroy ();
802 }
803 }
804 else
805 { /* Put objects in inventory onto this space */
806 while (inv)
807 {
808 object *op = inv;
809
810 if (op->flag [FLAG_STARTEQUIP]
811 || op->flag [FLAG_NO_DROP]
812 || op->type == RUNE
813 || op->type == TRAP
814 || op->flag [FLAG_IS_A_TEMPLATE]
815 || op->flag [FLAG_DESTROY_ON_DEATH])
816 op->destroy ();
817 else
818 map->insert (op, x, y);
819 }
820 }
902} 821}
903 822
904object *object::create () 823object *object::create ()
905{ 824{
906 object *
907 op;
908
909 if (freed.empty ())
910 op = new object; 825 object *op = new object;
911 else
912 {
913 // highly annoying, but the only way to get it stable right now
914 op = freed.back ();
915 freed.pop_back ();
916 op->~object ();
917 new ((void *) op) object;
918 }
919
920 op->link (); 826 op->link ();
921 return op; 827 return op;
922} 828}
923 829
924/* 830void
925 * free_object() frees everything allocated by an object, removes 831object::do_destroy ()
926 * it from the list of used objects, and puts it on the list of
927 * free objects. The IS_FREED() flag is set in the object.
928 * The object must have been removed by remove_ob() first for
929 * this function to succeed.
930 *
931 * If free_inventory is set, free inventory as well. Else drop items in
932 * inventory to the ground.
933 */
934void object::free (bool free_inventory)
935{ 832{
936 if (QUERY_FLAG (this, FLAG_FREED)) 833 attachable::do_destroy ();
834
835 if (flag [FLAG_IS_LINKED])
836 remove_button_link (this);
837
838 if (flag [FLAG_FRIENDLY])
839 {
840 remove_friendly_object (this);
841
842 if (type == GOLEM
843 && owner
844 && owner->type == PLAYER
845 && owner->contr->ranges[range_golem] == this)
846 owner->contr->ranges[range_golem] = 0;
847 }
848
849 if (!flag [FLAG_REMOVED])
850 remove ();
851
852 destroy_inv (true);
853
854 deactivate ();
855 unlink ();
856
857 flag [FLAG_FREED] = 1;
858
859 // hack to ensure that freed objects still have a valid map
860 {
861 static maptile *freed_map; // freed objects are moved here to avoid crashes
862
863 if (!freed_map)
864 {
865 freed_map = new maptile;
866
867 freed_map->name = "/internal/freed_objects_map";
868 freed_map->width = 3;
869 freed_map->height = 3;
870
871 freed_map->alloc ();
872 freed_map->in_memory = MAP_IN_MEMORY;
873 }
874
875 map = freed_map;
876 x = 1;
877 y = 1;
878 }
879
880 head = 0;
881
882 if (more)
883 {
884 more->destroy ();
885 more = 0;
886 }
887
888 // clear those pointers that likely might have circular references to us
889 owner = 0;
890 enemy = 0;
891 attacked_by = 0;
892}
893
894void
895object::destroy (bool destroy_inventory)
896{
897 if (destroyed ())
937 return; 898 return;
938 899
939 if (!QUERY_FLAG (this, FLAG_REMOVED)) 900 if (destroy_inventory)
940 remove_ob (this); 901 destroy_inv (false);
941 902
942 if (QUERY_FLAG (this, FLAG_FRIENDLY)) 903 attachable::destroy ();
943 remove_friendly_object (this);
944
945 SET_FLAG (this, FLAG_FREED);
946
947 if (more)
948 {
949 more->free (free_inventory);
950 more = 0;
951 }
952
953 if (inv)
954 {
955 /* Only if the space blocks everything do we not process -
956 * if some form of movement is allowed, let objects
957 * drop on that space.
958 */
959 if (free_inventory || !map || map->in_memory != MAP_IN_MEMORY || (GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL))
960 {
961 object *op = inv;
962
963 while (op)
964 {
965 object *tmp = op->below;
966 op->free (free_inventory);
967 op = tmp;
968 }
969 }
970 else
971 { /* Put objects in inventory onto this space */
972 object *op = inv;
973
974 while (op)
975 {
976 object *tmp = op->below;
977
978 remove_ob (op);
979
980 if (QUERY_FLAG (op, FLAG_STARTEQUIP)
981 || QUERY_FLAG (op, FLAG_NO_DROP) || op->type == RUNE || op->type == TRAP || QUERY_FLAG (op, FLAG_IS_A_TEMPLATE))
982 free_object (op);
983 else
984 {
985 op->x = x;
986 op->y = y;
987 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
988 }
989
990 op = tmp;
991 }
992 }
993 }
994
995 owner = 0;
996
997 /* Remove object from the active list */
998 speed = 0;
999 update_ob_speed (this);
1000
1001 unlink ();
1002
1003 mortals.push_back (this);
1004} 904}
1005 905
1006/* 906/*
1007 * sub_weight() recursively (outwards) subtracts a number from the 907 * sub_weight() recursively (outwards) subtracts a number from the
1008 * weight of an object (and what is carried by it's environment(s)). 908 * weight of an object (and what is carried by it's environment(s)).
1009 */ 909 */
1010
1011void 910void
1012sub_weight (object *op, signed long weight) 911sub_weight (object *op, signed long weight)
1013{ 912{
1014 while (op != NULL) 913 while (op != NULL)
1015 { 914 {
1016 if (op->type == CONTAINER) 915 if (op->type == CONTAINER)
1017 {
1018 weight = (signed long) (weight * (100 - op->stats.Str) / 100); 916 weight = (signed long) (weight * (100 - op->stats.Str) / 100);
1019 } 917
1020 op->carrying -= weight; 918 op->carrying -= weight;
1021 op = op->env; 919 op = op->env;
1022 } 920 }
1023} 921}
1024 922
1025/* remove_ob(op): 923/* op->remove ():
1026 * This function removes the object op from the linked list of objects 924 * This function removes the object op from the linked list of objects
1027 * which it is currently tied to. When this function is done, the 925 * which it is currently tied to. When this function is done, the
1028 * object will have no environment. If the object previously had an 926 * object will have no environment. If the object previously had an
1029 * environment, the x and y coordinates will be updated to 927 * environment, the x and y coordinates will be updated to
1030 * the previous environment. 928 * the previous environment.
1031 * Beware: This function is called from the editor as well!
1032 */ 929 */
1033
1034void 930void
1035remove_ob (object *op) 931object::do_remove ()
1036{ 932{
933 object *tmp, *last = 0;
1037 object * 934 object *otmp;
1038 tmp, *
1039 last = NULL;
1040 object *
1041 otmp;
1042 935
1043 tag_t
1044 tag;
1045 int
1046 check_walk_off;
1047 mapstruct *
1048 m;
1049
1050 sint16
1051 x,
1052 y;
1053
1054 if (QUERY_FLAG (op, FLAG_REMOVED)) 936 if (QUERY_FLAG (this, FLAG_REMOVED))
1055 return; 937 return;
1056 938
1057 SET_FLAG (op, FLAG_REMOVED); 939 SET_FLAG (this, FLAG_REMOVED);
940 INVOKE_OBJECT (REMOVE, this);
1058 941
1059 if (op->more != NULL) 942 if (more)
1060 remove_ob (op->more); 943 more->remove ();
1061 944
1062 /* 945 /*
1063 * In this case, the object to be removed is in someones 946 * In this case, the object to be removed is in someones
1064 * inventory. 947 * inventory.
1065 */ 948 */
1066 if (op->env != NULL) 949 if (env)
1067 { 950 {
1068 if (op->nrof) 951 if (nrof)
1069 sub_weight (op->env, op->weight * op->nrof); 952 sub_weight (env, weight * nrof);
1070 else 953 else
1071 sub_weight (op->env, op->weight + op->carrying); 954 sub_weight (env, weight + carrying);
1072 955
1073 /* NO_FIX_PLAYER is set when a great many changes are being 956 /* NO_FIX_PLAYER is set when a great many changes are being
1074 * made to players inventory. If set, avoiding the call 957 * made to players inventory. If set, avoiding the call
1075 * to save cpu time. 958 * to save cpu time.
1076 */ 959 */
1077 if ((otmp = is_player_inv (op->env)) != NULL && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 960 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1078 fix_player (otmp); 961 otmp->update_stats ();
1079 962
1080 if (op->above != NULL) 963 if (above)
1081 op->above->below = op->below; 964 above->below = below;
1082 else 965 else
1083 op->env->inv = op->below; 966 env->inv = below;
1084 967
1085 if (op->below != NULL) 968 if (below)
1086 op->below->above = op->above; 969 below->above = above;
1087 970
1088 /* we set up values so that it could be inserted into 971 /* we set up values so that it could be inserted into
1089 * the map, but we don't actually do that - it is up 972 * the map, but we don't actually do that - it is up
1090 * to the caller to decide what we want to do. 973 * to the caller to decide what we want to do.
1091 */ 974 */
1092 op->x = op->env->x, op->y = op->env->y; 975 x = env->x, y = env->y;
1093 op->map = op->env->map; 976 map = env->map;
1094 op->above = NULL, op->below = NULL; 977 above = 0, below = 0;
1095 op->env = NULL; 978 env = 0;
1096 } 979 }
1097 else if (op->map) 980 else if (map)
1098 { 981 {
1099 x = op->x; 982 if (type == PLAYER)
1100 y = op->y;
1101 m = get_map_from_coord (op->map, &x, &y);
1102
1103 if (!m)
1104 {
1105 LOG (llevError, "remove_ob called when object was on map but appears to not be within valid coordinates? %s (%d,%d)\n",
1106 op->map->path, op->x, op->y);
1107 /* in old days, we used to set x and y to 0 and continue.
1108 * it seems if we get into this case, something is probablye
1109 * screwed up and should be fixed.
1110 */
1111 abort ();
1112 } 983 {
984 // leaving a spot always closes any open container on the ground
985 if (container && !container->env)
986 // this causes spurious floorbox updates, but it ensures
987 // that the CLOSE event is being sent.
988 close_container ();
1113 989
1114 if (op->map != m) 990 --map->players;
1115 LOG (llevDebug, "remove_ob: Object not really on map it claimed to be on? %s != %s, %d,%d != %d,%d\n", 991 map->touch ();
1116 op->map->path, m->path, op->x, op->y, x, y);
1117
1118 /* Re did the following section of code - it looks like it had
1119 * lots of logic for things we no longer care about
1120 */ 992 }
993
994 map->dirty = true;
995 mapspace &ms = this->ms ();
1121 996
1122 /* link the object above us */ 997 /* link the object above us */
1123 if (op->above) 998 if (above)
1124 op->above->below = op->below; 999 above->below = below;
1125 else 1000 else
1126 SET_MAP_TOP (m, x, y, op->below); /* we were top, set new top */ 1001 ms.top = below; /* we were top, set new top */
1127 1002
1128 /* Relink the object below us, if there is one */ 1003 /* Relink the object below us, if there is one */
1129 if (op->below) 1004 if (below)
1130 op->below->above = op->above; 1005 below->above = above;
1131 else 1006 else
1132 { 1007 {
1133 /* Nothing below, which means we need to relink map object for this space 1008 /* Nothing below, which means we need to relink map object for this space
1134 * use translated coordinates in case some oddness with map tiling is 1009 * use translated coordinates in case some oddness with map tiling is
1135 * evident 1010 * evident
1136 */ 1011 */
1137 if (GET_MAP_OB (m, x, y) != op) 1012 if (GET_MAP_OB (map, x, y) != this)
1138 {
1139 dump_object (op);
1140 LOG (llevError,
1141 "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", errmsg); 1013 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1142 dump_object (GET_MAP_OB (m, x, y)); 1014
1143 LOG (llevError, "%s\n", errmsg); 1015 ms.bot = above; /* goes on above it. */
1144 } 1016 }
1145 1017
1146 SET_MAP_OB (m, x, y, op->above); /* goes on above it. */
1147 }
1148
1149 op->above = 0; 1018 above = 0;
1150 op->below = 0; 1019 below = 0;
1151 1020
1152 if (op->map->in_memory == MAP_SAVING) 1021 if (map->in_memory == MAP_SAVING)
1153 return; 1022 return;
1154 1023
1155 tag = op->count; 1024 int check_walk_off = !flag [FLAG_NO_APPLY];
1156 check_walk_off = !QUERY_FLAG (op, FLAG_NO_APPLY);
1157 1025
1158 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1026 for (tmp = ms.bot; tmp; tmp = tmp->above)
1159 { 1027 {
1160 /* No point updating the players look faces if he is the object 1028 /* No point updating the players look faces if he is the object
1161 * being removed. 1029 * being removed.
1162 */ 1030 */
1163 1031
1164 if (tmp->type == PLAYER && tmp != op) 1032 if (tmp->type == PLAYER && tmp != this)
1165 { 1033 {
1166 /* If a container that the player is currently using somehow gets 1034 /* If a container that the player is currently using somehow gets
1167 * removed (most likely destroyed), update the player view 1035 * removed (most likely destroyed), update the player view
1168 * appropriately. 1036 * appropriately.
1169 */ 1037 */
1170 if (tmp->container == op) 1038 if (tmp->container == this)
1171 { 1039 {
1172 CLEAR_FLAG (op, FLAG_APPLIED); 1040 flag [FLAG_APPLIED] = 0;
1173 tmp->container = NULL; 1041 tmp->container = 0;
1174 } 1042 }
1175 1043
1176 tmp->contr->socket.update_look = 1; 1044 if (tmp->contr->ns)
1045 tmp->contr->ns->floorbox_update ();
1177 } 1046 }
1178 1047
1179 /* See if player moving off should effect something */ 1048 /* See if object moving off should effect something */
1180 if (check_walk_off && ((op->move_type & tmp->move_off) && (op->move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1049 if (check_walk_off
1050 && ((move_type & tmp->move_off)
1051 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0))
1181 { 1052 {
1182 move_apply (tmp, op, NULL); 1053 move_apply (tmp, this, 0);
1183 1054
1184 if (was_destroyed (op, tag)) 1055 if (destroyed ())
1185 {
1186 LOG (llevError, "BUG: remove_ob(): name %s, archname %s destroyed " "leaving object\n", &tmp->name, &tmp->arch->name); 1056 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1187 }
1188 } 1057 }
1189 1058
1190 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */ 1059 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */
1191 1060 //TODO: why is this horrible hacka fix? get rid of this code=bug! (schmorp)
1192 if (tmp->above == tmp) 1061 if (tmp->above == tmp)
1193 tmp->above = NULL; 1062 tmp->above = 0;
1194 1063
1195 last = tmp; 1064 last = tmp;
1196 } 1065 }
1197 1066
1198 /* last == NULL of there are no objects on this space */ 1067 /* last == NULL if there are no objects on this space */
1068 //TODO: this makes little sense, why only update the topmost object?
1199 if (last == NULL) 1069 if (!last)
1200 { 1070 map->at (x, y).flags_ = 0;
1201 /* set P_NEED_UPDATE, otherwise update_position will complain. In theory,
1202 * we could preserve the flags (GET_MAP_FLAGS), but update_position figures
1203 * those out anyways, and if there are any flags set right now, they won't
1204 * be correct anyways.
1205 */
1206 SET_MAP_FLAGS (op->map, op->x, op->y, P_NEED_UPDATE);
1207 update_position (op->map, op->x, op->y);
1208 }
1209 else 1071 else
1210 update_object (last, UP_OBJ_REMOVE); 1072 update_object (last, UP_OBJ_REMOVE);
1211 1073
1212 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) || (op->glow_radius != 0)) 1074 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1213 update_all_los (op->map, op->x, op->y); 1075 update_all_los (map, x, y);
1214 } 1076 }
1215} 1077}
1216 1078
1217/* 1079/*
1218 * merge_ob(op,top): 1080 * merge_ob(op,top):
1220 * This function goes through all objects below and including top, and 1082 * This function goes through all objects below and including top, and
1221 * merges op to the first matching object. 1083 * merges op to the first matching object.
1222 * If top is NULL, it is calculated. 1084 * If top is NULL, it is calculated.
1223 * Returns pointer to object if it succeded in the merge, otherwise NULL 1085 * Returns pointer to object if it succeded in the merge, otherwise NULL
1224 */ 1086 */
1225
1226object * 1087object *
1227merge_ob (object *op, object *top) 1088merge_ob (object *op, object *top)
1228{ 1089{
1229 if (!op->nrof) 1090 if (!op->nrof)
1230 return 0; 1091 return 0;
1231 1092
1232 if (top == NULL) 1093 if (top)
1233 for (top = op; top != NULL && top->above != NULL; top = top->above); 1094 for (top = op; top && top->above; top = top->above)
1095 ;
1234 1096
1235 for (; top != NULL; top = top->below) 1097 for (; top; top = top->below)
1236 { 1098 {
1237 if (top == op) 1099 if (top == op)
1238 continue; 1100 continue;
1239 if (CAN_MERGE (op, top)) 1101
1102 if (object::can_merge (op, top))
1240 { 1103 {
1241 top->nrof += op->nrof; 1104 top->nrof += op->nrof;
1242 1105
1243/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/ 1106/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/
1244 op->weight = 0; /* Don't want any adjustements now */ 1107 op->weight = 0; /* Don't want any adjustements now */
1245 remove_ob (op); 1108 op->destroy ();
1246 free_object (op);
1247 return top; 1109 return top;
1248 } 1110 }
1249 } 1111 }
1250 1112
1251 return NULL; 1113 return 0;
1252} 1114}
1253 1115
1254/* 1116/*
1255 * same as insert_ob_in_map except it handle separate coordinates and do a clean 1117 * same as insert_ob_in_map except it handles separate coordinates and does a clean
1256 * job preparing multi-part monsters 1118 * job preparing multi-part monsters.
1257 */ 1119 */
1258object * 1120object *
1259insert_ob_in_map_at (object *op, mapstruct *m, object *originator, int flag, int x, int y) 1121insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1260{ 1122{
1261 object *tmp;
1262
1263 if (op->head)
1264 op = op->head;
1265
1266 for (tmp = op; tmp; tmp = tmp->more) 1123 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1267 { 1124 {
1268 tmp->x = x + tmp->arch->clone.x; 1125 tmp->x = x + tmp->arch->clone.x;
1269 tmp->y = y + tmp->arch->clone.y; 1126 tmp->y = y + tmp->arch->clone.y;
1270 } 1127 }
1271 1128
1290 * Return value: 1147 * Return value:
1291 * new object if 'op' was merged with other object 1148 * new object if 'op' was merged with other object
1292 * NULL if 'op' was destroyed 1149 * NULL if 'op' was destroyed
1293 * just 'op' otherwise 1150 * just 'op' otherwise
1294 */ 1151 */
1295
1296object * 1152object *
1297insert_ob_in_map (object *op, mapstruct *m, object *originator, int flag) 1153insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1298{ 1154{
1299 object *tmp, *top, *floor = NULL; 1155 object *tmp, *top, *floor = NULL;
1300 sint16 x, y;
1301 1156
1302 if (QUERY_FLAG (op, FLAG_FREED)) 1157 if (QUERY_FLAG (op, FLAG_FREED))
1303 { 1158 {
1304 LOG (llevError, "Trying to insert freed object!\n"); 1159 LOG (llevError, "Trying to insert freed object!\n");
1305 return NULL; 1160 return NULL;
1306 } 1161 }
1307 1162
1308 if (m == NULL) 1163 if (!QUERY_FLAG (op, FLAG_REMOVED))
1164 LOG (llevError, "Trying to insert already inserted object %s\n", op->debug_desc ());
1165
1166 op->remove ();
1167
1168 if (!m)
1309 { 1169 {
1310 dump_object (op); 1170 char *dump = dump_object (op);
1311 LOG (llevError, "Trying to insert in null-map!\n%s\n", errmsg); 1171 LOG (llevError, "Trying to insert in null-map!\n%s\n", dump);
1172 free (dump);
1312 return op; 1173 return op;
1313 } 1174 }
1314 1175
1315 if (out_of_map (m, op->x, op->y)) 1176 if (out_of_map (m, op->x, op->y))
1316 { 1177 {
1317 dump_object (op); 1178 char *dump = dump_object (op);
1318 LOG (llevError, "Trying to insert object outside the map.\n%s\n", errmsg); 1179 LOG (llevError, "Trying to insert object outside the map.\n%s\n", dump);
1319#ifdef MANY_CORES 1180#ifdef MANY_CORES
1320 /* Better to catch this here, as otherwise the next use of this object 1181 /* Better to catch this here, as otherwise the next use of this object
1321 * is likely to cause a crash. Better to find out where it is getting 1182 * is likely to cause a crash. Better to find out where it is getting
1322 * improperly inserted. 1183 * improperly inserted.
1323 */ 1184 */
1324 abort (); 1185 abort ();
1325#endif 1186#endif
1187 free (dump);
1326 return op; 1188 return op;
1327 } 1189 }
1328 1190
1329 if (!QUERY_FLAG (op, FLAG_REMOVED))
1330 {
1331 dump_object (op);
1332 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", errmsg);
1333 return op;
1334 }
1335
1336 if (op->more != NULL)
1337 {
1338 /* The part may be on a different map. */
1339
1340 object *more = op->more; 1191 if (object *more = op->more)
1341 1192 {
1342 /* We really need the caller to normalize coordinates - if
1343 * we set the map, that doesn't work if the location is within
1344 * a map and this is straddling an edge. So only if coordinate
1345 * is clear wrong do we normalize it.
1346 */
1347 if (OUT_OF_REAL_MAP (more->map, more->x, more->y))
1348 more->map = get_map_from_coord (m, &more->x, &more->y);
1349 else if (!more->map)
1350 {
1351 /* For backwards compatibility - when not dealing with tiled maps,
1352 * more->map should always point to the parent.
1353 */
1354 more->map = m;
1355 }
1356
1357 if (insert_ob_in_map (more, more->map, originator, flag) == NULL) 1193 if (!insert_ob_in_map (more, m, originator, flag))
1358 { 1194 {
1359 if (!op->head) 1195 if (!op->head)
1360 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n"); 1196 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n");
1361 1197
1362 return NULL; 1198 return 0;
1363 } 1199 }
1364 } 1200 }
1365 1201
1366 CLEAR_FLAG (op, FLAG_REMOVED); 1202 CLEAR_FLAG (op, FLAG_REMOVED);
1367 1203
1368 /* Ideally, the caller figures this out. However, it complicates a lot 1204 /* Ideally, the caller figures this out. However, it complicates a lot
1369 * of areas of callers (eg, anything that uses find_free_spot would now 1205 * of areas of callers (eg, anything that uses find_free_spot would now
1370 * need extra work 1206 * need extra work
1371 */ 1207 */
1372 op->map = get_map_from_coord (m, &op->x, &op->y); 1208 if (!xy_normalise (m, op->x, op->y))
1373 x = op->x; 1209 return 0;
1374 y = op->y; 1210
1211 op->map = m;
1212 mapspace &ms = op->ms ();
1375 1213
1376 /* this has to be done after we translate the coordinates. 1214 /* this has to be done after we translate the coordinates.
1377 */ 1215 */
1378 if (op->nrof && !(flag & INS_NO_MERGE)) 1216 if (op->nrof && !(flag & INS_NO_MERGE))
1379 for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above) 1217 for (tmp = ms.bot; tmp; tmp = tmp->above)
1380 if (CAN_MERGE (op, tmp)) 1218 if (object::can_merge (op, tmp))
1381 { 1219 {
1382 op->nrof += tmp->nrof; 1220 op->nrof += tmp->nrof;
1383 remove_ob (tmp); 1221 tmp->destroy ();
1384 free_object (tmp);
1385 } 1222 }
1386 1223
1387 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1224 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1388 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1225 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1389 1226
1402 op->below = originator->below; 1239 op->below = originator->below;
1403 1240
1404 if (op->below) 1241 if (op->below)
1405 op->below->above = op; 1242 op->below->above = op;
1406 else 1243 else
1407 SET_MAP_OB (op->map, op->x, op->y, op); 1244 ms.bot = op;
1408 1245
1409 /* since *below* originator, no need to update top */ 1246 /* since *below* originator, no need to update top */
1410 originator->below = op; 1247 originator->below = op;
1411 } 1248 }
1412 else 1249 else
1413 { 1250 {
1251 top = ms.bot;
1252
1414 /* If there are other objects, then */ 1253 /* If there are other objects, then */
1415 if ((!(flag & INS_MAP_LOAD)) && ((top = GET_MAP_OB (op->map, op->x, op->y)) != NULL)) 1254 if ((!(flag & INS_MAP_LOAD)) && top)
1416 { 1255 {
1417 object *last = NULL; 1256 object *last = 0;
1418 1257
1419 /* 1258 /*
1420 * If there are multiple objects on this space, we do some trickier handling. 1259 * If there are multiple objects on this space, we do some trickier handling.
1421 * We've already dealt with merging if appropriate. 1260 * We've already dealt with merging if appropriate.
1422 * Generally, we want to put the new object on top. But if 1261 * Generally, we want to put the new object on top. But if
1426 * once we get to them. This reduces the need to traverse over all of 1265 * once we get to them. This reduces the need to traverse over all of
1427 * them when adding another one - this saves quite a bit of cpu time 1266 * them when adding another one - this saves quite a bit of cpu time
1428 * when lots of spells are cast in one area. Currently, it is presumed 1267 * when lots of spells are cast in one area. Currently, it is presumed
1429 * that flying non pickable objects are spell objects. 1268 * that flying non pickable objects are spell objects.
1430 */ 1269 */
1431 1270 for (top = ms.bot; top; top = top->above)
1432 while (top != NULL)
1433 { 1271 {
1434 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1272 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))
1435 floor = top; 1273 floor = top;
1436 1274
1437 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1275 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))
1440 top = top->below; 1278 top = top->below;
1441 break; 1279 break;
1442 } 1280 }
1443 1281
1444 last = top; 1282 last = top;
1445 top = top->above;
1446 } 1283 }
1447 1284
1448 /* Don't want top to be NULL, so set it to the last valid object */ 1285 /* Don't want top to be NULL, so set it to the last valid object */
1449 top = last; 1286 top = last;
1450 1287
1457 * Unless those objects are exits, type 66 1294 * Unless those objects are exits, type 66
1458 * If INS_ON_TOP is used, don't do this processing 1295 * If INS_ON_TOP is used, don't do this processing
1459 * Need to find the object that in fact blocks view, otherwise 1296 * Need to find the object that in fact blocks view, otherwise
1460 * stacking is a bit odd. 1297 * stacking is a bit odd.
1461 */ 1298 */
1462 if (!(flag & INS_ON_TOP) && 1299 if (!(flag & INS_ON_TOP)
1463 (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_BLOCKSVIEW) && (op->face && !op->face->visibility)) 1300 && ms.flags () & P_BLOCKSVIEW
1301 && (op->face && !op->face->visibility))
1464 { 1302 {
1465 for (last = top; last != floor; last = last->below) 1303 for (last = top; last != floor; last = last->below)
1466 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1304 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1467 break; 1305 break;
1306
1468 /* Check to see if we found the object that blocks view, 1307 /* Check to see if we found the object that blocks view,
1469 * and make sure we have a below pointer for it so that 1308 * and make sure we have a below pointer for it so that
1470 * we can get inserted below this one, which requires we 1309 * we can get inserted below this one, which requires we
1471 * set top to the object below us. 1310 * set top to the object below us.
1472 */ 1311 */
1474 top = last->below; 1313 top = last->below;
1475 } 1314 }
1476 } /* If objects on this space */ 1315 } /* If objects on this space */
1477 1316
1478 if (flag & INS_MAP_LOAD) 1317 if (flag & INS_MAP_LOAD)
1479 top = GET_MAP_TOP (op->map, op->x, op->y); 1318 top = ms.top;
1480 1319
1481 if (flag & INS_ABOVE_FLOOR_ONLY) 1320 if (flag & INS_ABOVE_FLOOR_ONLY)
1482 top = floor; 1321 top = floor;
1483 1322
1484 /* Top is the object that our object (op) is going to get inserted above. 1323 /* Top is the object that our object (op) is going to get inserted above.
1485 */ 1324 */
1486 1325
1487 /* First object on this space */ 1326 /* First object on this space */
1488 if (!top) 1327 if (!top)
1489 { 1328 {
1490 op->above = GET_MAP_OB (op->map, op->x, op->y); 1329 op->above = ms.bot;
1491 1330
1492 if (op->above) 1331 if (op->above)
1493 op->above->below = op; 1332 op->above->below = op;
1494 1333
1495 op->below = NULL; 1334 op->below = 0;
1496 SET_MAP_OB (op->map, op->x, op->y, op); 1335 ms.bot = op;
1497 } 1336 }
1498 else 1337 else
1499 { /* get inserted into the stack above top */ 1338 { /* get inserted into the stack above top */
1500 op->above = top->above; 1339 op->above = top->above;
1501 1340
1504 1343
1505 op->below = top; 1344 op->below = top;
1506 top->above = op; 1345 top->above = op;
1507 } 1346 }
1508 1347
1509 if (op->above == NULL) 1348 if (!op->above)
1510 SET_MAP_TOP (op->map, op->x, op->y, op); 1349 ms.top = op;
1511 } /* else not INS_BELOW_ORIGINATOR */ 1350 } /* else not INS_BELOW_ORIGINATOR */
1512 1351
1513 if (op->type == PLAYER) 1352 if (op->type == PLAYER)
1353 {
1514 op->contr->do_los = 1; 1354 op->contr->do_los = 1;
1355 ++op->map->players;
1356 op->map->touch ();
1357 }
1358
1359 op->map->dirty = true;
1515 1360
1516 /* If we have a floor, we know the player, if any, will be above 1361 /* If we have a floor, we know the player, if any, will be above
1517 * it, so save a few ticks and start from there. 1362 * it, so save a few ticks and start from there.
1518 */ 1363 */
1519 if (!(flag & INS_MAP_LOAD)) 1364 if (!(flag & INS_MAP_LOAD))
1520 for (tmp = floor ? floor : GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1365 if (object *pl = ms.player ())
1521 if (tmp->type == PLAYER) 1366 if (pl->contr->ns)
1522 tmp->contr->socket.update_look = 1; 1367 pl->contr->ns->floorbox_update ();
1523 1368
1524 /* If this object glows, it may affect lighting conditions that are 1369 /* If this object glows, it may affect lighting conditions that are
1525 * visible to others on this map. But update_all_los is really 1370 * visible to others on this map. But update_all_los is really
1526 * an inefficient way to do this, as it means los for all players 1371 * an inefficient way to do this, as it means los for all players
1527 * on the map will get recalculated. The players could very well 1372 * on the map will get recalculated. The players could very well
1528 * be far away from this change and not affected in any way - 1373 * be far away from this change and not affected in any way -
1529 * this should get redone to only look for players within range, 1374 * this should get redone to only look for players within range,
1530 * or just updating the P_NEED_UPDATE for spaces within this area 1375 * or just updating the P_UPTODATE for spaces within this area
1531 * of effect may be sufficient. 1376 * of effect may be sufficient.
1532 */ 1377 */
1533 if (MAP_DARKNESS (op->map) && (op->glow_radius != 0)) 1378 if (op->map->darkness && (op->glow_radius != 0))
1534 update_all_los (op->map, op->x, op->y); 1379 update_all_los (op->map, op->x, op->y);
1535 1380
1536 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1381 /* updates flags (blocked, alive, no magic, etc) for this map space */
1537 update_object (op, UP_OBJ_INSERT); 1382 update_object (op, UP_OBJ_INSERT);
1538 1383
1384 INVOKE_OBJECT (INSERT, op);
1385
1539 /* Don't know if moving this to the end will break anything. However, 1386 /* Don't know if moving this to the end will break anything. However,
1540 * we want to have update_look set above before calling this. 1387 * we want to have floorbox_update called before calling this.
1541 * 1388 *
1542 * check_move_on() must be after this because code called from 1389 * check_move_on() must be after this because code called from
1543 * check_move_on() depends on correct map flags (so functions like 1390 * check_move_on() depends on correct map flags (so functions like
1544 * blocked() and wall() work properly), and these flags are updated by 1391 * blocked() and wall() work properly), and these flags are updated by
1545 * update_object(). 1392 * update_object().
1547 1394
1548 /* if this is not the head or flag has been passed, don't check walk on status */ 1395 /* if this is not the head or flag has been passed, don't check walk on status */
1549 if (!(flag & INS_NO_WALK_ON) && !op->head) 1396 if (!(flag & INS_NO_WALK_ON) && !op->head)
1550 { 1397 {
1551 if (check_move_on (op, originator)) 1398 if (check_move_on (op, originator))
1552 return NULL; 1399 return 0;
1553 1400
1554 /* If we are a multi part object, lets work our way through the check 1401 /* If we are a multi part object, lets work our way through the check
1555 * walk on's. 1402 * walk on's.
1556 */ 1403 */
1557 for (tmp = op->more; tmp != NULL; tmp = tmp->more) 1404 for (tmp = op->more; tmp != NULL; tmp = tmp->more)
1558 if (check_move_on (tmp, originator)) 1405 if (check_move_on (tmp, originator))
1559 return NULL; 1406 return 0;
1560 } 1407 }
1561 1408
1562 return op; 1409 return op;
1563} 1410}
1564 1411
1565/* this function inserts an object in the map, but if it 1412/* this function inserts an object in the map, but if it
1566 * finds an object of its own type, it'll remove that one first. 1413 * finds an object of its own type, it'll remove that one first.
1567 * op is the object to insert it under: supplies x and the map. 1414 * op is the object to insert it under: supplies x and the map.
1568 */ 1415 */
1569void 1416void
1570replace_insert_ob_in_map (const char *arch_string, object *op) 1417replace_insert_ob_in_map (const char *arch_string, object *op)
1571{ 1418{
1572 object * 1419 object *tmp, *tmp1;
1573 tmp;
1574 object *
1575 tmp1;
1576 1420
1577 /* first search for itself and remove any old instances */ 1421 /* first search for itself and remove any old instances */
1578 1422
1579 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1423 for (tmp = op->ms ().bot; tmp; tmp = tmp->above)
1580 {
1581 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */ 1424 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */
1582 { 1425 tmp->destroy ();
1583 remove_ob (tmp);
1584 free_object (tmp);
1585 }
1586 }
1587 1426
1588 tmp1 = arch_to_object (find_archetype (arch_string)); 1427 tmp1 = arch_to_object (archetype::find (arch_string));
1589 1428
1590 tmp1->x = op->x; 1429 tmp1->x = op->x;
1591 tmp1->y = op->y; 1430 tmp1->y = op->y;
1592 insert_ob_in_map (tmp1, op->map, op, 0); 1431 insert_ob_in_map (tmp1, op->map, op, 0);
1432}
1433
1434// XXX: function not returning object*
1435object *
1436object::insert_at (object *where, object *originator, int flags)
1437{
1438 where->map->insert (this, where->x, where->y, originator, flags);
1593} 1439}
1594 1440
1595/* 1441/*
1596 * get_split_ob(ob,nr) splits up ob into two parts. The part which 1442 * get_split_ob(ob,nr) splits up ob into two parts. The part which
1597 * is returned contains nr objects, and the remaining parts contains 1443 * is returned contains nr objects, and the remaining parts contains
1598 * the rest (or is removed and freed if that number is 0). 1444 * the rest (or is removed and freed if that number is 0).
1599 * On failure, NULL is returned, and the reason put into the 1445 * On failure, NULL is returned, and the reason put into the
1600 * global static errmsg array. 1446 * global static errmsg array.
1601 */ 1447 */
1602
1603object * 1448object *
1604get_split_ob (object *orig_ob, uint32 nr) 1449get_split_ob (object *orig_ob, uint32 nr)
1605{ 1450{
1606 object * 1451 object *newob;
1607 newob;
1608 int
1609 is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0); 1452 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1610 1453
1611 if (orig_ob->nrof < nr) 1454 if (orig_ob->nrof < nr)
1612 { 1455 {
1613 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name); 1456 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1614 return NULL; 1457 return NULL;
1615 } 1458 }
1616 1459
1617 newob = object_create_clone (orig_ob); 1460 newob = object_create_clone (orig_ob);
1618 1461
1619 if ((orig_ob->nrof -= nr) < 1) 1462 if ((orig_ob->nrof -= nr) < 1)
1620 { 1463 orig_ob->destroy (1);
1621 if (!is_removed)
1622 remove_ob (orig_ob);
1623 free_object2 (orig_ob, 1);
1624 }
1625 else if (!is_removed) 1464 else if (!is_removed)
1626 { 1465 {
1627 if (orig_ob->env != NULL) 1466 if (orig_ob->env != NULL)
1628 sub_weight (orig_ob->env, orig_ob->weight * nr); 1467 sub_weight (orig_ob->env, orig_ob->weight * nr);
1629 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY) 1468 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY)
1649 1488
1650object * 1489object *
1651decrease_ob_nr (object *op, uint32 i) 1490decrease_ob_nr (object *op, uint32 i)
1652{ 1491{
1653 object *tmp; 1492 object *tmp;
1654 player *pl;
1655 1493
1656 if (i == 0) /* objects with op->nrof require this check */ 1494 if (i == 0) /* objects with op->nrof require this check */
1657 return op; 1495 return op;
1658 1496
1659 if (i > op->nrof) 1497 if (i > op->nrof)
1660 i = op->nrof; 1498 i = op->nrof;
1661 1499
1662 if (QUERY_FLAG (op, FLAG_REMOVED)) 1500 if (QUERY_FLAG (op, FLAG_REMOVED))
1663 op->nrof -= i; 1501 op->nrof -= i;
1664 else if (op->env != NULL) 1502 else if (op->env)
1665 { 1503 {
1666 /* is this object in the players inventory, or sub container 1504 /* is this object in the players inventory, or sub container
1667 * therein? 1505 * therein?
1668 */ 1506 */
1669 tmp = is_player_inv (op->env); 1507 tmp = op->in_player ();
1670 /* nope. Is this a container the player has opened? 1508 /* nope. Is this a container the player has opened?
1671 * If so, set tmp to that player. 1509 * If so, set tmp to that player.
1672 * IMO, searching through all the players will mostly 1510 * IMO, searching through all the players will mostly
1673 * likely be quicker than following op->env to the map, 1511 * likely be quicker than following op->env to the map,
1674 * and then searching the map for a player. 1512 * and then searching the map for a player.
1675 */ 1513 */
1676 if (!tmp) 1514 if (!tmp)
1677 { 1515 for_all_players (pl)
1678 for (pl = first_player; pl; pl = pl->next)
1679 if (pl->ob->container == op->env) 1516 if (pl->ob->container == op->env)
1517 {
1518 tmp = pl->ob;
1680 break; 1519 break;
1681 if (pl)
1682 tmp = pl->ob;
1683 else
1684 tmp = NULL;
1685 } 1520 }
1686 1521
1687 if (i < op->nrof) 1522 if (i < op->nrof)
1688 { 1523 {
1689 sub_weight (op->env, op->weight * i); 1524 sub_weight (op->env, op->weight * i);
1690 op->nrof -= i; 1525 op->nrof -= i;
1691 if (tmp) 1526 if (tmp)
1692 {
1693 esrv_send_item (tmp, op); 1527 esrv_send_item (tmp, op);
1694 }
1695 } 1528 }
1696 else 1529 else
1697 { 1530 {
1698 remove_ob (op); 1531 op->remove ();
1699 op->nrof = 0; 1532 op->nrof = 0;
1700 if (tmp) 1533 if (tmp)
1701 {
1702 esrv_del_item (tmp->contr, op->count); 1534 esrv_del_item (tmp->contr, op->count);
1703 }
1704 } 1535 }
1705 } 1536 }
1706 else 1537 else
1707 { 1538 {
1708 object *above = op->above; 1539 object *above = op->above;
1709 1540
1710 if (i < op->nrof) 1541 if (i < op->nrof)
1711 op->nrof -= i; 1542 op->nrof -= i;
1712 else 1543 else
1713 { 1544 {
1714 remove_ob (op); 1545 op->remove ();
1715 op->nrof = 0; 1546 op->nrof = 0;
1716 } 1547 }
1717 1548
1718 /* Since we just removed op, op->above is null */ 1549 /* Since we just removed op, op->above is null */
1719 for (tmp = above; tmp != NULL; tmp = tmp->above) 1550 for (tmp = above; tmp; tmp = tmp->above)
1720 if (tmp->type == PLAYER) 1551 if (tmp->type == PLAYER)
1721 { 1552 {
1722 if (op->nrof) 1553 if (op->nrof)
1723 esrv_send_item (tmp, op); 1554 esrv_send_item (tmp, op);
1724 else 1555 else
1728 1559
1729 if (op->nrof) 1560 if (op->nrof)
1730 return op; 1561 return op;
1731 else 1562 else
1732 { 1563 {
1733 free_object (op); 1564 op->destroy ();
1734 return NULL; 1565 return 0;
1735 } 1566 }
1736} 1567}
1737 1568
1738/* 1569/*
1739 * add_weight(object, weight) adds the specified weight to an object, 1570 * add_weight(object, weight) adds the specified weight to an object,
1751 op->carrying += weight; 1582 op->carrying += weight;
1752 op = op->env; 1583 op = op->env;
1753 } 1584 }
1754} 1585}
1755 1586
1587object *
1588insert_ob_in_ob (object *op, object *where)
1589{
1590 if (!where)
1591 {
1592 char *dump = dump_object (op);
1593 LOG (llevError, "Trying to put object in NULL.\n%s\n", dump);
1594 free (dump);
1595 return op;
1596 }
1597
1598 if (where->head)
1599 {
1600 LOG (llevDebug, "Warning: Tried to insert object into wrong part of multipart object.\n");
1601 where = where->head;
1602 }
1603
1604 return where->insert (op);
1605}
1606
1756/* 1607/*
1757 * insert_ob_in_ob(op,environment): 1608 * env->insert (op)
1758 * This function inserts the object op in the linked list 1609 * This function inserts the object op in the linked list
1759 * inside the object environment. 1610 * inside the object environment.
1760 * 1611 *
1761 * Eneq(@csd.uu.se): Altered insert_ob_in_ob to make things picked up enter
1762 * the inventory at the last position or next to other objects of the same
1763 * type.
1764 * Frank: Now sorted by type, archetype and magic!
1765 *
1766 * The function returns now pointer to inserted item, and return value can 1612 * The function returns now pointer to inserted item, and return value can
1767 * be != op, if items are merged. -Tero 1613 * be != op, if items are merged. -Tero
1768 */ 1614 */
1769 1615
1770object * 1616object *
1771insert_ob_in_ob (object *op, object *where) 1617object::insert (object *op)
1772{ 1618{
1773 object * 1619 object *tmp, *otmp;
1774 tmp, *
1775 otmp;
1776 1620
1777 if (!QUERY_FLAG (op, FLAG_REMOVED)) 1621 if (!QUERY_FLAG (op, FLAG_REMOVED))
1778 { 1622 op->remove ();
1779 dump_object (op);
1780 LOG (llevError, "Trying to insert (ob) inserted object.\n%s\n", errmsg);
1781 return op;
1782 }
1783
1784 if (where == NULL)
1785 {
1786 dump_object (op);
1787 LOG (llevError, "Trying to put object in NULL.\n%s\n", errmsg);
1788 return op;
1789 }
1790
1791 if (where->head)
1792 {
1793 LOG (llevDebug, "Warning: Tried to insert object wrong part of multipart object.\n");
1794 where = where->head;
1795 }
1796 1623
1797 if (op->more) 1624 if (op->more)
1798 { 1625 {
1799 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count); 1626 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);
1800 return op; 1627 return op;
1802 1629
1803 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL); 1630 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL);
1804 CLEAR_FLAG (op, FLAG_REMOVED); 1631 CLEAR_FLAG (op, FLAG_REMOVED);
1805 if (op->nrof) 1632 if (op->nrof)
1806 { 1633 {
1807 for (tmp = where->inv; tmp != NULL; tmp = tmp->below) 1634 for (tmp = inv; tmp != NULL; tmp = tmp->below)
1808 if (CAN_MERGE (tmp, op)) 1635 if (object::can_merge (tmp, op))
1809 { 1636 {
1810 /* return the original object and remove inserted object 1637 /* return the original object and remove inserted object
1811 (client needs the original object) */ 1638 (client needs the original object) */
1812 tmp->nrof += op->nrof; 1639 tmp->nrof += op->nrof;
1813 /* Weight handling gets pretty funky. Since we are adding to 1640 /* Weight handling gets pretty funky. Since we are adding to
1814 * tmp->nrof, we need to increase the weight. 1641 * tmp->nrof, we need to increase the weight.
1815 */ 1642 */
1816 add_weight (where, op->weight * op->nrof); 1643 add_weight (this, op->weight * op->nrof);
1817 SET_FLAG (op, FLAG_REMOVED); 1644 SET_FLAG (op, FLAG_REMOVED);
1818 free_object (op); /* free the inserted object */ 1645 op->destroy (); /* free the inserted object */
1819 op = tmp; 1646 op = tmp;
1820 remove_ob (op); /* and fix old object's links */ 1647 op->remove (); /* and fix old object's links */
1821 CLEAR_FLAG (op, FLAG_REMOVED); 1648 CLEAR_FLAG (op, FLAG_REMOVED);
1822 break; 1649 break;
1823 } 1650 }
1824 1651
1825 /* I assume combined objects have no inventory 1652 /* I assume combined objects have no inventory
1826 * We add the weight - this object could have just been removed 1653 * We add the weight - this object could have just been removed
1827 * (if it was possible to merge). calling remove_ob will subtract 1654 * (if it was possible to merge). calling remove_ob will subtract
1828 * the weight, so we need to add it in again, since we actually do 1655 * the weight, so we need to add it in again, since we actually do
1829 * the linking below 1656 * the linking below
1830 */ 1657 */
1831 add_weight (where, op->weight * op->nrof); 1658 add_weight (this, op->weight * op->nrof);
1832 } 1659 }
1833 else 1660 else
1834 add_weight (where, (op->weight + op->carrying)); 1661 add_weight (this, (op->weight + op->carrying));
1835 1662
1836 otmp = is_player_inv (where); 1663 otmp = this->in_player ();
1837 if (otmp && otmp->contr != NULL) 1664 if (otmp && otmp->contr)
1838 {
1839 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1665 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1840 fix_player (otmp); 1666 otmp->update_stats ();
1841 }
1842 1667
1843 op->map = NULL; 1668 op->map = 0;
1844 op->env = where; 1669 op->env = this;
1845 op->above = NULL; 1670 op->above = 0;
1846 op->below = NULL; 1671 op->below = 0;
1847 op->x = 0, op->y = 0; 1672 op->x = 0, op->y = 0;
1848 1673
1849 /* reset the light list and los of the players on the map */ 1674 /* reset the light list and los of the players on the map */
1850 if ((op->glow_radius != 0) && where->map) 1675 if ((op->glow_radius != 0) && map)
1851 { 1676 {
1852#ifdef DEBUG_LIGHTS 1677#ifdef DEBUG_LIGHTS
1853 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name); 1678 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1854#endif /* DEBUG_LIGHTS */ 1679#endif /* DEBUG_LIGHTS */
1855 if (MAP_DARKNESS (where->map)) 1680 if (map->darkness)
1856 update_all_los (where->map, where->x, where->y); 1681 update_all_los (map, x, y);
1857 } 1682 }
1858 1683
1859 /* Client has no idea of ordering so lets not bother ordering it here. 1684 /* Client has no idea of ordering so lets not bother ordering it here.
1860 * It sure simplifies this function... 1685 * It sure simplifies this function...
1861 */ 1686 */
1862 if (where->inv == NULL) 1687 if (!inv)
1863 where->inv = op; 1688 inv = op;
1864 else 1689 else
1865 { 1690 {
1866 op->below = where->inv; 1691 op->below = inv;
1867 op->below->above = op; 1692 op->below->above = op;
1868 where->inv = op; 1693 inv = op;
1869 } 1694 }
1695
1696 INVOKE_OBJECT (INSERT, this);
1697
1870 return op; 1698 return op;
1871} 1699}
1872 1700
1873/* 1701/*
1874 * Checks if any objects has a move_type that matches objects 1702 * Checks if any objects has a move_type that matches objects
1888 * 1716 *
1889 * MSW 2001-07-08: Check all objects on space, not just those below 1717 * MSW 2001-07-08: Check all objects on space, not just those below
1890 * object being inserted. insert_ob_in_map may not put new objects 1718 * object being inserted. insert_ob_in_map may not put new objects
1891 * on top. 1719 * on top.
1892 */ 1720 */
1893
1894int 1721int
1895check_move_on (object *op, object *originator) 1722check_move_on (object *op, object *originator)
1896{ 1723{
1897 object * 1724 object *tmp;
1898 tmp; 1725 maptile *m = op->map;
1899 tag_t
1900 tag;
1901 mapstruct *
1902 m = op->map;
1903 int
1904 x = op->x, y = op->y; 1726 int x = op->x, y = op->y;
1905 1727
1906 MoveType 1728 MoveType move_on, move_slow, move_block;
1907 move_on,
1908 move_slow,
1909 move_block;
1910 1729
1911 if (QUERY_FLAG (op, FLAG_NO_APPLY)) 1730 if (QUERY_FLAG (op, FLAG_NO_APPLY))
1912 return 0; 1731 return 0;
1913
1914 tag = op->count;
1915 1732
1916 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y); 1733 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
1917 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y); 1734 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
1918 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y); 1735 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
1919 1736
1935 1752
1936 /* The objects have to be checked from top to bottom. 1753 /* The objects have to be checked from top to bottom.
1937 * Hence, we first go to the top: 1754 * Hence, we first go to the top:
1938 */ 1755 */
1939 1756
1940 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL && tmp->above != NULL; tmp = tmp->above) 1757 for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1941 { 1758 {
1942 /* Trim the search when we find the first other spell effect 1759 /* Trim the search when we find the first other spell effect
1943 * this helps performance so that if a space has 50 spell objects, 1760 * this helps performance so that if a space has 50 spell objects,
1944 * we don't need to check all of them. 1761 * we don't need to check all of them.
1945 */ 1762 */
1963 if ((!op->move_type && tmp->move_slow & MOVE_WALK) || 1780 if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
1964 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0)) 1781 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
1965 { 1782 {
1966 1783
1967 float 1784 float
1968 diff = tmp->move_slow_penalty * FABS (op->speed); 1785 diff = tmp->move_slow_penalty * fabs (op->speed);
1969 1786
1970 if (op->type == PLAYER) 1787 if (op->type == PLAYER)
1971 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) || 1788 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) ||
1972 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN))) 1789 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN)))
1973 diff /= 4.0; 1790 diff /= 4.0;
1980 if ((!op->move_type && tmp->move_on & MOVE_WALK) || 1797 if ((!op->move_type && tmp->move_on & MOVE_WALK) ||
1981 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0)) 1798 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0))
1982 { 1799 {
1983 move_apply (tmp, op, originator); 1800 move_apply (tmp, op, originator);
1984 1801
1985 if (was_destroyed (op, tag)) 1802 if (op->destroyed ())
1986 return 1; 1803 return 1;
1987 1804
1988 /* what the person/creature stepped onto has moved the object 1805 /* what the person/creature stepped onto has moved the object
1989 * someplace new. Don't process any further - if we did, 1806 * someplace new. Don't process any further - if we did,
1990 * have a feeling strange problems would result. 1807 * have a feeling strange problems would result.
2000/* 1817/*
2001 * present_arch(arch, map, x, y) searches for any objects with 1818 * present_arch(arch, map, x, y) searches for any objects with
2002 * a matching archetype at the given map and coordinates. 1819 * a matching archetype at the given map and coordinates.
2003 * The first matching object is returned, or NULL if none. 1820 * The first matching object is returned, or NULL if none.
2004 */ 1821 */
2005
2006object * 1822object *
2007present_arch (const archetype *at, mapstruct *m, int x, int y) 1823present_arch (const archetype *at, maptile *m, int x, int y)
2008{ 1824{
2009 object *
2010 tmp;
2011
2012 if (m == NULL || out_of_map (m, x, y)) 1825 if (!m || out_of_map (m, x, y))
2013 { 1826 {
2014 LOG (llevError, "Present_arch called outside map.\n"); 1827 LOG (llevError, "Present_arch called outside map.\n");
2015 return NULL; 1828 return NULL;
2016 } 1829 }
2017 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1830
1831 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
2018 if (tmp->arch == at) 1832 if (tmp->arch == at)
2019 return tmp; 1833 return tmp;
1834
2020 return NULL; 1835 return NULL;
2021} 1836}
2022 1837
2023/* 1838/*
2024 * present(type, map, x, y) searches for any objects with 1839 * present(type, map, x, y) searches for any objects with
2025 * a matching type variable at the given map and coordinates. 1840 * a matching type variable at the given map and coordinates.
2026 * The first matching object is returned, or NULL if none. 1841 * The first matching object is returned, or NULL if none.
2027 */ 1842 */
2028
2029object * 1843object *
2030present (unsigned char type, mapstruct *m, int x, int y) 1844present (unsigned char type, maptile *m, int x, int y)
2031{ 1845{
2032 object *
2033 tmp;
2034
2035 if (out_of_map (m, x, y)) 1846 if (out_of_map (m, x, y))
2036 { 1847 {
2037 LOG (llevError, "Present called outside map.\n"); 1848 LOG (llevError, "Present called outside map.\n");
2038 return NULL; 1849 return NULL;
2039 } 1850 }
2040 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1851
1852 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
2041 if (tmp->type == type) 1853 if (tmp->type == type)
2042 return tmp; 1854 return tmp;
1855
2043 return NULL; 1856 return NULL;
2044} 1857}
2045 1858
2046/* 1859/*
2047 * present_in_ob(type, object) searches for any objects with 1860 * present_in_ob(type, object) searches for any objects with
2048 * a matching type variable in the inventory of the given object. 1861 * a matching type variable in the inventory of the given object.
2049 * The first matching object is returned, or NULL if none. 1862 * The first matching object is returned, or NULL if none.
2050 */ 1863 */
2051
2052object * 1864object *
2053present_in_ob (unsigned char type, const object *op) 1865present_in_ob (unsigned char type, const object *op)
2054{ 1866{
2055 object *
2056 tmp;
2057
2058 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1867 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2059 if (tmp->type == type) 1868 if (tmp->type == type)
2060 return tmp; 1869 return tmp;
1870
2061 return NULL; 1871 return NULL;
2062} 1872}
2063 1873
2064/* 1874/*
2065 * present_in_ob (type, str, object) searches for any objects with 1875 * present_in_ob (type, str, object) searches for any objects with
2073 * str is the string to match against. Note that we match against 1883 * str is the string to match against. Note that we match against
2074 * the object name, not the archetype name. this is so that the 1884 * the object name, not the archetype name. this is so that the
2075 * spell code can use one object type (force), but change it's name 1885 * spell code can use one object type (force), but change it's name
2076 * to be unique. 1886 * to be unique.
2077 */ 1887 */
2078
2079object * 1888object *
2080present_in_ob_by_name (int type, const char *str, const object *op) 1889present_in_ob_by_name (int type, const char *str, const object *op)
2081{ 1890{
2082 object *
2083 tmp;
2084
2085 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1891 for (object *tmp = op->inv; tmp; tmp = tmp->below)
2086 {
2087 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name))) 1892 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name)))
2088 return tmp; 1893 return tmp;
2089 } 1894
2090 return NULL; 1895 return 0;
2091} 1896}
2092 1897
2093/* 1898/*
2094 * present_arch_in_ob(archetype, object) searches for any objects with 1899 * present_arch_in_ob(archetype, object) searches for any objects with
2095 * a matching archetype in the inventory of the given object. 1900 * a matching archetype in the inventory of the given object.
2096 * The first matching object is returned, or NULL if none. 1901 * The first matching object is returned, or NULL if none.
2097 */ 1902 */
2098
2099object * 1903object *
2100present_arch_in_ob (const archetype *at, const object *op) 1904present_arch_in_ob (const archetype *at, const object *op)
2101{ 1905{
2102 object *
2103 tmp;
2104
2105 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1906 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2106 if (tmp->arch == at) 1907 if (tmp->arch == at)
2107 return tmp; 1908 return tmp;
1909
2108 return NULL; 1910 return NULL;
2109} 1911}
2110 1912
2111/* 1913/*
2112 * activate recursively a flag on an object inventory 1914 * activate recursively a flag on an object inventory
2113 */ 1915 */
2114void 1916void
2115flag_inv (object *op, int flag) 1917flag_inv (object *op, int flag)
2116{ 1918{
2117 object *
2118 tmp;
2119
2120 if (op->inv) 1919 if (op->inv)
2121 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1920 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2122 { 1921 {
2123 SET_FLAG (tmp, flag); 1922 SET_FLAG (tmp, flag);
2124 flag_inv (tmp, flag); 1923 flag_inv (tmp, flag);
2125 } 1924 }
2126} /* 1925}
1926
1927/*
2127 * desactivate recursively a flag on an object inventory 1928 * deactivate recursively a flag on an object inventory
2128 */ 1929 */
2129void 1930void
2130unflag_inv (object *op, int flag) 1931unflag_inv (object *op, int flag)
2131{ 1932{
2132 object *
2133 tmp;
2134
2135 if (op->inv) 1933 if (op->inv)
2136 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1934 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2137 { 1935 {
2138 CLEAR_FLAG (tmp, flag); 1936 CLEAR_FLAG (tmp, flag);
2139 unflag_inv (tmp, flag); 1937 unflag_inv (tmp, flag);
2140 } 1938 }
2141} 1939}
2144 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in 1942 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in
2145 * all it's inventory (recursively). 1943 * all it's inventory (recursively).
2146 * If checksums are used, a player will get set_cheat called for 1944 * If checksums are used, a player will get set_cheat called for
2147 * him/her-self and all object carried by a call to this function. 1945 * him/her-self and all object carried by a call to this function.
2148 */ 1946 */
2149
2150void 1947void
2151set_cheat (object *op) 1948set_cheat (object *op)
2152{ 1949{
2153 SET_FLAG (op, FLAG_WAS_WIZ); 1950 SET_FLAG (op, FLAG_WAS_WIZ);
2154 flag_inv (op, FLAG_WAS_WIZ); 1951 flag_inv (op, FLAG_WAS_WIZ);
2173 * because arch_blocked (now ob_blocked) needs to know the movement type 1970 * because arch_blocked (now ob_blocked) needs to know the movement type
2174 * to know if the space in question will block the object. We can't use 1971 * to know if the space in question will block the object. We can't use
2175 * the archetype because that isn't correct if the monster has been 1972 * the archetype because that isn't correct if the monster has been
2176 * customized, changed states, etc. 1973 * customized, changed states, etc.
2177 */ 1974 */
2178
2179int 1975int
2180find_free_spot (const object *ob, mapstruct *m, int x, int y, int start, int stop) 1976find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)
2181{ 1977{
2182 int
2183 i,
2184 index = 0, flag; 1978 int index = 0, flag;
2185 static int
2186 altern[SIZEOFFREE]; 1979 int altern[SIZEOFFREE];
2187 1980
2188 for (i = start; i < stop; i++) 1981 for (int i = start; i < stop; i++)
2189 { 1982 {
2190 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]); 1983 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]);
2191 if (!flag) 1984 if (!flag)
2192 altern[index++] = i; 1985 altern [index++] = i;
2193 1986
2194 /* Basically, if we find a wall on a space, we cut down the search size. 1987 /* Basically, if we find a wall on a space, we cut down the search size.
2195 * In this way, we won't return spaces that are on another side of a wall. 1988 * In this way, we won't return spaces that are on another side of a wall.
2196 * This mostly work, but it cuts down the search size in all directions - 1989 * This mostly work, but it cuts down the search size in all directions -
2197 * if the space being examined only has a wall to the north and empty 1990 * if the space being examined only has a wall to the north and empty
2198 * spaces in all the other directions, this will reduce the search space 1991 * spaces in all the other directions, this will reduce the search space
2199 * to only the spaces immediately surrounding the target area, and 1992 * to only the spaces immediately surrounding the target area, and
2200 * won't look 2 spaces south of the target space. 1993 * won't look 2 spaces south of the target space.
2201 */ 1994 */
2202 else if ((flag & AB_NO_PASS) && maxfree[i] < stop) 1995 else if ((flag & P_NO_PASS) && maxfree[i] < stop)
2203 stop = maxfree[i]; 1996 stop = maxfree[i];
2204 } 1997 }
1998
2205 if (!index) 1999 if (!index)
2206 return -1; 2000 return -1;
2001
2207 return altern[RANDOM () % index]; 2002 return altern [rndm (index)];
2208} 2003}
2209 2004
2210/* 2005/*
2211 * find_first_free_spot(archetype, mapstruct, x, y) works like 2006 * find_first_free_spot(archetype, maptile, x, y) works like
2212 * find_free_spot(), but it will search max number of squares. 2007 * find_free_spot(), but it will search max number of squares.
2213 * But it will return the first available spot, not a random choice. 2008 * But it will return the first available spot, not a random choice.
2214 * Changed 0.93.2: Have it return -1 if there is no free spot available. 2009 * Changed 0.93.2: Have it return -1 if there is no free spot available.
2215 */ 2010 */
2216
2217int 2011int
2218find_first_free_spot (const object *ob, mapstruct *m, int x, int y) 2012find_first_free_spot (const object *ob, maptile *m, int x, int y)
2219{ 2013{
2220 int
2221 i;
2222
2223 for (i = 0; i < SIZEOFFREE; i++) 2014 for (int i = 0; i < SIZEOFFREE; i++)
2224 {
2225 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i])) 2015 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]))
2226 return i; 2016 return i;
2227 } 2017
2228 return -1; 2018 return -1;
2229} 2019}
2230 2020
2231/* 2021/*
2232 * The function permute(arr, begin, end) randomly reorders the array 2022 * The function permute(arr, begin, end) randomly reorders the array
2233 * arr[begin..end-1]. 2023 * arr[begin..end-1].
2024 * now uses a fisher-yates shuffle, old permute was broken
2234 */ 2025 */
2235static void 2026static void
2236permute (int *arr, int begin, int end) 2027permute (int *arr, int begin, int end)
2237{ 2028{
2238 int 2029 arr += begin;
2239 i,
2240 j,
2241 tmp,
2242 len;
2243
2244 len = end - begin; 2030 end -= begin;
2245 for (i = begin; i < end; i++)
2246 {
2247 j = begin + RANDOM () % len;
2248 2031
2249 tmp = arr[i]; 2032 while (--end)
2250 arr[i] = arr[j]; 2033 swap (arr [end], arr [rndm (end + 1)]);
2251 arr[j] = tmp;
2252 }
2253} 2034}
2254 2035
2255/* new function to make monster searching more efficient, and effective! 2036/* new function to make monster searching more efficient, and effective!
2256 * This basically returns a randomized array (in the passed pointer) of 2037 * This basically returns a randomized array (in the passed pointer) of
2257 * the spaces to find monsters. In this way, it won't always look for 2038 * the spaces to find monsters. In this way, it won't always look for
2260 * the 3x3 area will be searched, just not in a predictable order. 2041 * the 3x3 area will be searched, just not in a predictable order.
2261 */ 2042 */
2262void 2043void
2263get_search_arr (int *search_arr) 2044get_search_arr (int *search_arr)
2264{ 2045{
2265 int 2046 int i;
2266 i;
2267 2047
2268 for (i = 0; i < SIZEOFFREE; i++) 2048 for (i = 0; i < SIZEOFFREE; i++)
2269 {
2270 search_arr[i] = i; 2049 search_arr[i] = i;
2271 }
2272 2050
2273 permute (search_arr, 1, SIZEOFFREE1 + 1); 2051 permute (search_arr, 1, SIZEOFFREE1 + 1);
2274 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1); 2052 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1);
2275 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE); 2053 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE);
2276} 2054}
2285 * Perhaps incorrectly, but I'm making the assumption that exclude 2063 * Perhaps incorrectly, but I'm making the assumption that exclude
2286 * is actually want is going to try and move there. We need this info 2064 * is actually want is going to try and move there. We need this info
2287 * because we have to know what movement the thing looking to move 2065 * because we have to know what movement the thing looking to move
2288 * there is capable of. 2066 * there is capable of.
2289 */ 2067 */
2290
2291int 2068int
2292find_dir (mapstruct *m, int x, int y, object *exclude) 2069find_dir (maptile *m, int x, int y, object *exclude)
2293{ 2070{
2294 int
2295 i,
2296 max = SIZEOFFREE, mflags; 2071 int i, max = SIZEOFFREE, mflags;
2297 2072
2298 sint16 nx, ny; 2073 sint16 nx, ny;
2299 object * 2074 object *tmp;
2300 tmp; 2075 maptile *mp;
2301 mapstruct *
2302 mp;
2303 2076
2304 MoveType blocked, move_type; 2077 MoveType blocked, move_type;
2305 2078
2306 if (exclude && exclude->head) 2079 if (exclude && exclude->head)
2307 { 2080 {
2319 mp = m; 2092 mp = m;
2320 nx = x + freearr_x[i]; 2093 nx = x + freearr_x[i];
2321 ny = y + freearr_y[i]; 2094 ny = y + freearr_y[i];
2322 2095
2323 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2096 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);
2097
2324 if (mflags & P_OUT_OF_MAP) 2098 if (mflags & P_OUT_OF_MAP)
2325 {
2326 max = maxfree[i]; 2099 max = maxfree[i];
2327 }
2328 else 2100 else
2329 { 2101 {
2330 blocked = GET_MAP_MOVE_BLOCK (mp, nx, ny); 2102 mapspace &ms = mp->at (nx, ny);
2103
2104 blocked = ms.move_block;
2331 2105
2332 if ((move_type & blocked) == move_type) 2106 if ((move_type & blocked) == move_type)
2333 {
2334 max = maxfree[i]; 2107 max = maxfree[i];
2335 }
2336 else if (mflags & P_IS_ALIVE) 2108 else if (mflags & P_IS_ALIVE)
2337 { 2109 {
2338 for (tmp = GET_MAP_OB (mp, nx, ny); tmp != NULL; tmp = tmp->above) 2110 for (tmp = ms.bot; tmp; tmp = tmp->above)
2339 { 2111 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)
2340 if ((QUERY_FLAG (tmp, FLAG_MONSTER) || tmp->type == PLAYER) && (tmp != exclude || (tmp->head && tmp->head != exclude))) 2112 && (tmp != exclude || (tmp->head && tmp->head != exclude)))
2341 {
2342 break; 2113 break;
2343 } 2114
2344 }
2345 if (tmp) 2115 if (tmp)
2346 {
2347 return freedir[i]; 2116 return freedir[i];
2348 }
2349 } 2117 }
2350 } 2118 }
2351 } 2119 }
2120
2352 return 0; 2121 return 0;
2353} 2122}
2354 2123
2355/* 2124/*
2356 * distance(object 1, object 2) will return the square of the 2125 * distance(object 1, object 2) will return the square of the
2357 * distance between the two given objects. 2126 * distance between the two given objects.
2358 */ 2127 */
2359
2360int 2128int
2361distance (const object *ob1, const object *ob2) 2129distance (const object *ob1, const object *ob2)
2362{ 2130{
2363 int
2364 i;
2365
2366 i = (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y); 2131 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2367 return i;
2368} 2132}
2369 2133
2370/* 2134/*
2371 * find_dir_2(delta-x,delta-y) will return a direction in which 2135 * find_dir_2(delta-x,delta-y) will return a direction in which
2372 * an object which has subtracted the x and y coordinates of another 2136 * an object which has subtracted the x and y coordinates of another
2373 * object, needs to travel toward it. 2137 * object, needs to travel toward it.
2374 */ 2138 */
2375
2376int 2139int
2377find_dir_2 (int x, int y) 2140find_dir_2 (int x, int y)
2378{ 2141{
2379 int 2142 int q;
2380 q;
2381 2143
2382 if (y) 2144 if (y)
2383 q = x * 100 / y; 2145 q = x * 100 / y;
2384 else if (x) 2146 else if (x)
2385 q = -300 * x; 2147 q = -300 * x;
2410 2172
2411 return 3; 2173 return 3;
2412} 2174}
2413 2175
2414/* 2176/*
2415 * absdir(int): Returns a number between 1 and 8, which represent
2416 * the "absolute" direction of a number (it actually takes care of
2417 * "overflow" in previous calculations of a direction).
2418 */
2419
2420int
2421absdir (int d)
2422{
2423 while (d < 1)
2424 d += 8;
2425 while (d > 8)
2426 d -= 8;
2427 return d;
2428}
2429
2430/*
2431 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is 2177 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is
2432 * between two directions (which are expected to be absolute (see absdir()) 2178 * between two directions (which are expected to be absolute (see absdir())
2433 */ 2179 */
2434
2435int 2180int
2436dirdiff (int dir1, int dir2) 2181dirdiff (int dir1, int dir2)
2437{ 2182{
2438 int 2183 int d;
2439 d;
2440 2184
2441 d = abs (dir1 - dir2); 2185 d = abs (dir1 - dir2);
2442 if (d > 4) 2186 if (d > 4)
2443 d = 8 - d; 2187 d = 8 - d;
2188
2444 return d; 2189 return d;
2445} 2190}
2446 2191
2447/* peterm: 2192/* peterm:
2448 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster. 2193 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster.
2451 * This basically means that if direction is 15, then it could either go 2196 * This basically means that if direction is 15, then it could either go
2452 * direction 4, 14, or 16 to get back to where we are. 2197 * direction 4, 14, or 16 to get back to where we are.
2453 * Moved from spell_util.c to object.c with the other related direction 2198 * Moved from spell_util.c to object.c with the other related direction
2454 * functions. 2199 * functions.
2455 */ 2200 */
2456
2457int
2458 reduction_dir[SIZEOFFREE][3] = { 2201int reduction_dir[SIZEOFFREE][3] = {
2459 {0, 0, 0}, /* 0 */ 2202 {0, 0, 0}, /* 0 */
2460 {0, 0, 0}, /* 1 */ 2203 {0, 0, 0}, /* 1 */
2461 {0, 0, 0}, /* 2 */ 2204 {0, 0, 0}, /* 2 */
2462 {0, 0, 0}, /* 3 */ 2205 {0, 0, 0}, /* 3 */
2463 {0, 0, 0}, /* 4 */ 2206 {0, 0, 0}, /* 4 */
2511 * find a path to that monster that we found. If not, 2254 * find a path to that monster that we found. If not,
2512 * we don't bother going toward it. Returns 1 if we 2255 * we don't bother going toward it. Returns 1 if we
2513 * can see a direct way to get it 2256 * can see a direct way to get it
2514 * Modified to be map tile aware -.MSW 2257 * Modified to be map tile aware -.MSW
2515 */ 2258 */
2516
2517
2518int 2259int
2519can_see_monsterP (mapstruct *m, int x, int y, int dir) 2260can_see_monsterP (maptile *m, int x, int y, int dir)
2520{ 2261{
2521 sint16 dx, dy; 2262 sint16 dx, dy;
2522 int
2523 mflags; 2263 int mflags;
2524 2264
2525 if (dir < 0) 2265 if (dir < 0)
2526 return 0; /* exit condition: invalid direction */ 2266 return 0; /* exit condition: invalid direction */
2527 2267
2528 dx = x + freearr_x[dir]; 2268 dx = x + freearr_x[dir];
2541 return 0; 2281 return 0;
2542 2282
2543 /* yes, can see. */ 2283 /* yes, can see. */
2544 if (dir < 9) 2284 if (dir < 9)
2545 return 1; 2285 return 1;
2286
2546 return can_see_monsterP (m, x, y, reduction_dir[dir][0]) | 2287 return can_see_monsterP (m, x, y, reduction_dir[dir][0])
2547 can_see_monsterP (m, x, y, reduction_dir[dir][1]) | can_see_monsterP (m, x, y, reduction_dir[dir][2]); 2288 | can_see_monsterP (m, x, y, reduction_dir[dir][1])
2289 | can_see_monsterP (m, x, y, reduction_dir[dir][2]);
2548} 2290}
2549
2550
2551 2291
2552/* 2292/*
2553 * can_pick(picker, item): finds out if an object is possible to be 2293 * can_pick(picker, item): finds out if an object is possible to be
2554 * picked up by the picker. Returnes 1 if it can be 2294 * picked up by the picker. Returnes 1 if it can be
2555 * picked up, otherwise 0. 2295 * picked up, otherwise 0.
2566 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2306 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2567 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2307 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2568 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2308 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));
2569} 2309}
2570 2310
2571
2572/* 2311/*
2573 * create clone from object to another 2312 * create clone from object to another
2574 */ 2313 */
2575object * 2314object *
2576object_create_clone (object *asrc) 2315object_create_clone (object *asrc)
2577{ 2316{
2578 object *
2579 dst = NULL, *tmp, *src, *part, *prev, *item; 2317 object *dst = 0, *tmp, *src, *part, *prev, *item;
2580 2318
2581 if (!asrc) 2319 if (!asrc)
2582 return NULL; 2320 return 0;
2321
2583 src = asrc; 2322 src = asrc;
2584 if (src->head) 2323 if (src->head)
2585 src = src->head; 2324 src = src->head;
2586 2325
2587 prev = NULL; 2326 prev = 0;
2588 for (part = src; part; part = part->more) 2327 for (part = src; part; part = part->more)
2589 { 2328 {
2590 tmp = get_object (); 2329 tmp = part->clone ();
2591 copy_object (part, tmp);
2592 tmp->x -= src->x; 2330 tmp->x -= src->x;
2593 tmp->y -= src->y; 2331 tmp->y -= src->y;
2332
2594 if (!part->head) 2333 if (!part->head)
2595 { 2334 {
2596 dst = tmp; 2335 dst = tmp;
2597 tmp->head = NULL; 2336 tmp->head = 0;
2598 } 2337 }
2599 else 2338 else
2600 {
2601 tmp->head = dst; 2339 tmp->head = dst;
2602 } 2340
2603 tmp->more = NULL; 2341 tmp->more = 0;
2342
2604 if (prev) 2343 if (prev)
2605 prev->more = tmp; 2344 prev->more = tmp;
2345
2606 prev = tmp; 2346 prev = tmp;
2607 } 2347 }
2608 2348
2609 /*** copy inventory ***/
2610 for (item = src->inv; item; item = item->below) 2349 for (item = src->inv; item; item = item->below)
2611 {
2612 (void) insert_ob_in_ob (object_create_clone (item), dst); 2350 insert_ob_in_ob (object_create_clone (item), dst);
2613 }
2614 2351
2615 return dst; 2352 return dst;
2616}
2617
2618/* return true if the object was destroyed, 0 otherwise */
2619int
2620was_destroyed (const object *op, tag_t old_tag)
2621{
2622 /* checking for FLAG_FREED isn't necessary, but makes this function more
2623 * robust */
2624 return op->count != old_tag || QUERY_FLAG (op, FLAG_FREED);
2625}
2626
2627/* GROS - Creates an object using a string representing its content. */
2628
2629/* Basically, we save the content of the string to a temp file, then call */
2630
2631/* load_object on it. I admit it is a highly inefficient way to make things, */
2632
2633/* but it was simple to make and allows reusing the load_object function. */
2634
2635/* Remember not to use load_object_str in a time-critical situation. */
2636
2637/* Also remember that multiparts objects are not supported for now. */
2638
2639object *
2640load_object_str (const char *obstr)
2641{
2642 object *
2643 op;
2644 char
2645 filename[MAX_BUF];
2646
2647 sprintf (filename, "%s/cfloadobstr2044", settings.tmpdir);
2648
2649 FILE *
2650 tempfile = fopen (filename, "w");
2651
2652 if (tempfile == NULL)
2653 {
2654 LOG (llevError, "Error - Unable to access load object temp file\n");
2655 return NULL;
2656 };
2657 fprintf (tempfile, obstr);
2658 fclose (tempfile);
2659
2660 op = get_object ();
2661
2662 object_thawer thawer (filename);
2663
2664 if (thawer)
2665 load_object (thawer, op, 0);
2666
2667 LOG (llevDebug, " load str completed, object=%s\n", &op->name);
2668 CLEAR_FLAG (op, FLAG_REMOVED);
2669
2670 return op;
2671} 2353}
2672 2354
2673/* This returns the first object in who's inventory that 2355/* This returns the first object in who's inventory that
2674 * has the same type and subtype match. 2356 * has the same type and subtype match.
2675 * returns NULL if no match. 2357 * returns NULL if no match.
2676 */ 2358 */
2677object * 2359object *
2678find_obj_by_type_subtype (const object *who, int type, int subtype) 2360find_obj_by_type_subtype (const object *who, int type, int subtype)
2679{ 2361{
2680 object *
2681 tmp;
2682
2683 for (tmp = who->inv; tmp; tmp = tmp->below) 2362 for (object *tmp = who->inv; tmp; tmp = tmp->below)
2684 if (tmp->type == type && tmp->subtype == subtype) 2363 if (tmp->type == type && tmp->subtype == subtype)
2685 return tmp; 2364 return tmp;
2686 2365
2687 return NULL; 2366 return 0;
2688} 2367}
2689 2368
2690/* If ob has a field named key, return the link from the list, 2369/* If ob has a field named key, return the link from the list,
2691 * otherwise return NULL. 2370 * otherwise return NULL.
2692 * 2371 *
2694 * do the desired thing. 2373 * do the desired thing.
2695 */ 2374 */
2696key_value * 2375key_value *
2697get_ob_key_link (const object *ob, const char *key) 2376get_ob_key_link (const object *ob, const char *key)
2698{ 2377{
2699 key_value *
2700 link;
2701
2702 for (link = ob->key_values; link != NULL; link = link->next) 2378 for (key_value *link = ob->key_values; link; link = link->next)
2703 {
2704 if (link->key == key) 2379 if (link->key == key)
2705 {
2706 return link; 2380 return link;
2707 }
2708 }
2709 2381
2710 return NULL; 2382 return 0;
2711} 2383}
2712 2384
2713/* 2385/*
2714 * Returns the value of op has an extra_field for key, or NULL. 2386 * Returns the value of op has an extra_field for key, or NULL.
2715 * 2387 *
2718 * The returned string is shared. 2390 * The returned string is shared.
2719 */ 2391 */
2720const char * 2392const char *
2721get_ob_key_value (const object *op, const char *const key) 2393get_ob_key_value (const object *op, const char *const key)
2722{ 2394{
2723 key_value * 2395 key_value *link;
2724 link; 2396 shstr_cmp canonical_key (key);
2725 const char *
2726 canonical_key;
2727 2397
2728 canonical_key = shstr::find (key);
2729
2730 if (canonical_key == NULL) 2398 if (!canonical_key)
2731 { 2399 {
2732 /* 1. There being a field named key on any object 2400 /* 1. There being a field named key on any object
2733 * implies there'd be a shared string to find. 2401 * implies there'd be a shared string to find.
2734 * 2. Since there isn't, no object has this field. 2402 * 2. Since there isn't, no object has this field.
2735 * 3. Therefore, *this* object doesn't have this field. 2403 * 3. Therefore, *this* object doesn't have this field.
2736 */ 2404 */
2737 return NULL; 2405 return 0;
2738 } 2406 }
2739 2407
2740 /* This is copied from get_ob_key_link() above - 2408 /* This is copied from get_ob_key_link() above -
2741 * only 4 lines, and saves the function call overhead. 2409 * only 4 lines, and saves the function call overhead.
2742 */ 2410 */
2743 for (link = op->key_values; link != NULL; link = link->next) 2411 for (link = op->key_values; link; link = link->next)
2744 {
2745 if (link->key == canonical_key) 2412 if (link->key == canonical_key)
2746 {
2747 return link->value; 2413 return link->value;
2748 } 2414
2749 }
2750 return NULL; 2415 return 0;
2751} 2416}
2752 2417
2753 2418
2754/* 2419/*
2755 * Updates the canonical_key in op to value. 2420 * Updates the canonical_key in op to value.
2762 * Returns TRUE on success. 2427 * Returns TRUE on success.
2763 */ 2428 */
2764int 2429int
2765set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key) 2430set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2766{ 2431{
2767 key_value *
2768 field = NULL, *last = NULL; 2432 key_value *field = NULL, *last = NULL;
2769 2433
2770 for (field = op->key_values; field != NULL; field = field->next) 2434 for (field = op->key_values; field != NULL; field = field->next)
2771 { 2435 {
2772 if (field->key != canonical_key) 2436 if (field->key != canonical_key)
2773 { 2437 {
2801 /* IF we get here, key doesn't exist */ 2465 /* IF we get here, key doesn't exist */
2802 2466
2803 /* No field, we'll have to add it. */ 2467 /* No field, we'll have to add it. */
2804 2468
2805 if (!add_key) 2469 if (!add_key)
2806 {
2807 return FALSE; 2470 return FALSE;
2808 } 2471
2809 /* There isn't any good reason to store a null 2472 /* There isn't any good reason to store a null
2810 * value in the key/value list. If the archetype has 2473 * value in the key/value list. If the archetype has
2811 * this key, then we should also have it, so shouldn't 2474 * this key, then we should also have it, so shouldn't
2812 * be here. If user wants to store empty strings, 2475 * be here. If user wants to store empty strings,
2813 * should pass in "" 2476 * should pass in ""
2840{ 2503{
2841 shstr key_ (key); 2504 shstr key_ (key);
2842 2505
2843 return set_ob_key_value_s (op, key_, value, add_key); 2506 return set_ob_key_value_s (op, key_, value, add_key);
2844} 2507}
2508
2509object::depth_iterator::depth_iterator (object *container)
2510: iterator_base (container)
2511{
2512 while (item->inv)
2513 item = item->inv;
2514}
2515
2516void
2517object::depth_iterator::next ()
2518{
2519 if (item->below)
2520 {
2521 item = item->below;
2522
2523 while (item->inv)
2524 item = item->inv;
2525 }
2526 else
2527 item = item->env;
2528}
2529
2530
2531const char *
2532object::flag_desc (char *desc, int len) const
2533{
2534 char *p = desc;
2535 bool first = true;
2536
2537 *p = 0;
2538
2539 for (int i = 0; i < NUM_FLAGS; i++)
2540 {
2541 if (len <= 10) // magic constant!
2542 {
2543 snprintf (p, len, ",...");
2544 break;
2545 }
2546
2547 if (flag [i])
2548 {
2549 int cnt = snprintf (p, len, "%s%d", first ? "" : ",", i);
2550 len -= cnt;
2551 p += cnt;
2552 first = false;
2553 }
2554 }
2555
2556 return desc;
2557}
2558
2559// return a suitable string describing an object in enough detail to find it
2560const char *
2561object::debug_desc (char *info) const
2562{
2563 char flagdesc[512];
2564 char info2[256 * 4];
2565 char *p = info;
2566
2567 p += snprintf (p, 512, "{cnt:%d,uuid:<1.%" PRIx64 ">,name:\"%s\"%s%s,flags:[%s],type:%d}",
2568 count, uuid.seq,
2569 &name,
2570 title ? "\",title:\"" : "",
2571 title ? (const char *)title : "",
2572 flag_desc (flagdesc, 512), type);
2573
2574 if (env)
2575 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2576
2577 if (map)
2578 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2579
2580 return info;
2581}
2582
2583const char *
2584object::debug_desc () const
2585{
2586 static char info[256 * 4];
2587 return debug_desc (info);
2588}
2589
2590const char *
2591object::debug_desc2 () const
2592{
2593 static char info[256 * 4];
2594 return debug_desc (info);
2595}
2596
2597struct region *
2598object::region () const
2599{
2600 return map ? map->region (x, y)
2601 : region::default_region ();
2602}
2603
2604const materialtype_t *
2605object::dominant_material () const
2606{
2607 if (materialtype_t *mat = name_to_material (materialname))
2608 return mat;
2609
2610 // omfg this is slow, this has to be temporary :)
2611 shstr unknown ("unknown");
2612
2613 return name_to_material (unknown);
2614}
2615
2616void
2617object::open_container (object *new_container)
2618{
2619 if (container == new_container)
2620 return;
2621
2622 if (object *old_container = container)
2623 {
2624 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))
2625 return;
2626
2627#if 0
2628 // remove the "Close old_container" object.
2629 if (object *closer = old_container->inv)
2630 if (closer->type == CLOSE_CON)
2631 closer->destroy ();
2632#endif
2633
2634 old_container->flag [FLAG_APPLIED] = 0;
2635 container = 0;
2636
2637 esrv_update_item (UPD_FLAGS, this, old_container);
2638 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container));
2639 }
2640
2641 if (new_container)
2642 {
2643 if (INVOKE_OBJECT (OPEN, new_container, ARG_OBJECT (this)))
2644 return;
2645
2646 // TODO: this does not seem to serve any purpose anymore?
2647#if 0
2648 // insert the "Close Container" object.
2649 if (archetype *closer = new_container->other_arch)
2650 {
2651 object *closer = arch_to_object (new_container->other_arch);
2652 closer->flag [FLAG_NO_MAP_SAVE] = 1;
2653 new_container->insert (closer);
2654 }
2655#endif
2656
2657 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container));
2658
2659 new_container->flag [FLAG_APPLIED] = 1;
2660 container = new_container;
2661
2662 esrv_update_item (UPD_FLAGS, this, new_container);
2663 esrv_send_inventory (this, new_container);
2664 }
2665}
2666
2667

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines