ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.67 by root, Thu Dec 14 04:30:32 2006 UTC vs.
Revision 1.128 by root, Mon Feb 5 01:24:45 2007 UTC

1/* 1/*
2 CrossFire, A Multiplayer game for X-windows 2 * CrossFire, A Multiplayer game for X-windows
3 3 *
4 * Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team
4 Copyright (C) 2001 Mark Wedel & Crossfire Development Team 5 * Copyright (C) 2001 Mark Wedel & Crossfire Development Team
5 Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (C) 1992 Frank Tore Johansen
6 7 *
7 This program is free software; you can redistribute it and/or modify 8 * This program is free software; you can redistribute it and/or modify
8 it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
9 the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation; either version 2 of the License, or
10 (at your option) any later version. 11 * (at your option) any later version.
11 12 *
12 This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
13 but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 GNU General Public License for more details. 16 * GNU General Public License for more details.
16 17 *
17 You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
18 along with this program; if not, write to the Free Software 19 * along with this program; if not, write to the Free Software
19 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
20 21 *
21 The authors can be reached via e-mail at <crossfire@schmorp.de> 22 * The authors can be reached via e-mail at <crossfire@schmorp.de>
22*/ 23 */
23 24
24/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects. 25/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
25 sub/add_weight will transcend the environment updating the carrying 26 sub/add_weight will transcend the environment updating the carrying
26 variable. */ 27 variable. */
27#include <global.h> 28#include <global.h>
30#include <sys/uio.h> 31#include <sys/uio.h>
31#include <object.h> 32#include <object.h>
32#include <funcpoint.h> 33#include <funcpoint.h>
33#include <loader.h> 34#include <loader.h>
34 35
36#include <bitset>
37
35int nrofallocobjects = 0; 38int nrofallocobjects = 0;
36static UUID uuid; 39static UUID uuid;
37const uint64 UUID_SKIP = 1<<19; 40const uint64 UUID_SKIP = 1<<19;
38 41
39object *active_objects; /* List of active objects that need to be processed */ 42objectvec objects;
43activevec actives;
40 44
41short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 45short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
42 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1 46 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1
43}; 47};
44short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, 48short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
139 * objects with lists are rare, and lists stay short. If not, use a 143 * objects with lists are rare, and lists stay short. If not, use a
140 * different structure or at least keep the lists sorted... 144 * different structure or at least keep the lists sorted...
141 */ 145 */
142 146
143 /* For each field in wants, */ 147 /* For each field in wants, */
144 for (wants_field = wants->key_values; wants_field != NULL; wants_field = wants_field->next) 148 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)
145 { 149 {
146 key_value *has_field; 150 key_value *has_field;
147 151
148 /* Look for a field in has with the same key. */ 152 /* Look for a field in has with the same key. */
149 has_field = get_ob_key_link (has, wants_field->key); 153 has_field = get_ob_key_link (has, wants_field->key);
188 * Check nrof variable *before* calling can_merge() 192 * Check nrof variable *before* calling can_merge()
189 * 193 *
190 * Improvements made with merge: Better checking on potion, and also 194 * Improvements made with merge: Better checking on potion, and also
191 * check weight 195 * check weight
192 */ 196 */
193
194bool object::can_merge_slow (object *ob1, object *ob2) 197bool object::can_merge_slow (object *ob1, object *ob2)
195{ 198{
196 /* A couple quicksanity checks */ 199 /* A couple quicksanity checks */
197 if (ob1 == ob2 200 if (ob1 == ob2
198 || ob1->type != ob2->type 201 || ob1->type != ob2->type
219 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 222 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
220 223
221 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 224 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
222 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 225 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
223 226
224 227 if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any ()
225 /* the 0x400000 on flags2 is FLAG_INV_LOCK. I don't think something 228 || ob1->arch != ob2->arch
226 * being locked in inventory should prevent merging.
227 * 0x4 in flags3 is CLIENT_SENT
228 */
229 if ((ob1->arch != ob2->arch) ||
230 (ob1->flags[0] != ob2->flags[0]) ||
231 (ob1->flags[1] != ob2->flags[1]) ||
232 ((ob1->flags[2] & ~0x400000) != (ob2->flags[2] & ~0x400000)) ||
233 ((ob1->flags[3] & ~0x4) != (ob2->flags[3] & ~0x4)) ||
234 (ob1->name != ob2->name) || 229 || ob1->name != ob2->name
235 (ob1->title != ob2->title) || 230 || ob1->title != ob2->title
236 (ob1->msg != ob2->msg) || 231 || ob1->msg != ob2->msg
237 (ob1->weight != ob2->weight) || 232 || ob1->weight != ob2->weight
238 (memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist)) != 0) || 233 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
239 (memcmp (&ob1->stats, &ob2->stats, sizeof (ob1->stats)) != 0) || 234 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
240 (ob1->attacktype != ob2->attacktype) || 235 || ob1->attacktype != ob2->attacktype
241 (ob1->magic != ob2->magic) || 236 || ob1->magic != ob2->magic
242 (ob1->slaying != ob2->slaying) || 237 || ob1->slaying != ob2->slaying
243 (ob1->skill != ob2->skill) || 238 || ob1->skill != ob2->skill
244 (ob1->value != ob2->value) || 239 || ob1->value != ob2->value
245 (ob1->animation_id != ob2->animation_id) || 240 || ob1->animation_id != ob2->animation_id
246 (ob1->client_type != ob2->client_type) || 241 || ob1->client_type != ob2->client_type
247 (ob1->materialname != ob2->materialname) || 242 || ob1->materialname != ob2->materialname
248 (ob1->lore != ob2->lore) || 243 || ob1->lore != ob2->lore
249 (ob1->subtype != ob2->subtype) || 244 || ob1->subtype != ob2->subtype
250 (ob1->move_type != ob2->move_type) || 245 || ob1->move_type != ob2->move_type
251 (ob1->move_block != ob2->move_block) || 246 || ob1->move_block != ob2->move_block
252 (ob1->move_allow != ob2->move_allow) || 247 || ob1->move_allow != ob2->move_allow
253 (ob1->move_on != ob2->move_on) || 248 || ob1->move_on != ob2->move_on
254 (ob1->move_off != ob2->move_off) || (ob1->move_slow != ob2->move_slow) || (ob1->move_slow_penalty != ob2->move_slow_penalty)) 249 || ob1->move_off != ob2->move_off
250 || ob1->move_slow != ob2->move_slow
251 || ob1->move_slow_penalty != ob2->move_slow_penalty)
255 return 0; 252 return 0;
256 253
257 /* This is really a spellbook check - really, we should 254 /* This is really a spellbook check - really, we should
258 * check all objects in the inventory. 255 * check all objects in the inventory.
259 */ 256 */
281 278
282 /* Note sure why the following is the case - either the object has to 279 /* Note sure why the following is the case - either the object has to
283 * be animated or have a very low speed. Is this an attempted monster 280 * be animated or have a very low speed. Is this an attempted monster
284 * check? 281 * check?
285 */ 282 */
286 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && FABS ((ob1)->speed) > MIN_ACTIVE_SPEED) 283 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && ob1->has_active_speed ())
287 return 0; 284 return 0;
288 285
289 switch (ob1->type) 286 switch (ob1->type)
290 { 287 {
291 case SCROLL: 288 case SCROLL:
356 op = op->env; 353 op = op->env;
357 return op; 354 return op;
358} 355}
359 356
360/* 357/*
361 * Eneq(@csd.uu.se): Since we can have items buried in a character we need
362 * a better check. We basically keeping traversing up until we can't
363 * or find a player.
364 */
365
366object *
367is_player_inv (object *op)
368{
369 for (; op != NULL && op->type != PLAYER; op = op->env)
370 if (op->env == op)
371 op->env = NULL;
372 return op;
373}
374
375/*
376 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump. 358 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
377 * Some error messages. 359 * Some error messages.
378 * The result of the dump is stored in the static global errmsg array. 360 * The result of the dump is stored in the static global errmsg array.
379 */ 361 */
380 362
383{ 365{
384 if (!op) 366 if (!op)
385 return strdup ("[NULLOBJ]"); 367 return strdup ("[NULLOBJ]");
386 368
387 object_freezer freezer; 369 object_freezer freezer;
388 save_object (freezer, op, 3); 370 save_object (freezer, op, 1);
389 return freezer.as_string (); 371 return freezer.as_string ();
390} 372}
391 373
392/* 374/*
393 * get_nearest_part(multi-object, object 2) returns the part of the 375 * get_nearest_part(multi-object, object 2) returns the part of the
410} 392}
411 393
412/* 394/*
413 * Returns the object which has the count-variable equal to the argument. 395 * Returns the object which has the count-variable equal to the argument.
414 */ 396 */
415
416object * 397object *
417find_object (tag_t i) 398find_object (tag_t i)
418{ 399{
419 for (object *op = object::first; op; op = op->next) 400 for_all_objects (op)
420 if (op->count == i) 401 if (op->count == i)
421 return op; 402 return op;
422 403
423 return 0; 404 return 0;
424} 405}
425 406
426/* 407/*
427 * Returns the first object which has a name equal to the argument. 408 * Returns the first object which has a name equal to the argument.
428 * Used only by the patch command, but not all that useful. 409 * Used only by the patch command, but not all that useful.
429 * Enables features like "patch <name-of-other-player> food 999" 410 * Enables features like "patch <name-of-other-player> food 999"
430 */ 411 */
431
432object * 412object *
433find_object_name (const char *str) 413find_object_name (const char *str)
434{ 414{
435 shstr_cmp str_ (str); 415 shstr_cmp str_ (str);
436 object *op; 416 object *op;
437 417
438 for (op = object::first; op != NULL; op = op->next) 418 for_all_objects (op)
439 if (op->name == str_) 419 if (op->name == str_)
440 break; 420 break;
441 421
442 return op; 422 return op;
443} 423}
486 } 466 }
487 467
488 op->key_values = 0; 468 op->key_values = 0;
489} 469}
490 470
491void object::clear ()
492{
493 attachable_base::clear ();
494
495 free_key_values (this);
496
497 owner = 0;
498 name = 0;
499 name_pl = 0;
500 title = 0;
501 race = 0;
502 slaying = 0;
503 skill = 0;
504 msg = 0;
505 lore = 0;
506 custom_name = 0;
507 materialname = 0;
508 contr = 0;
509 below = 0;
510 above = 0;
511 inv = 0;
512 container = 0;
513 env = 0;
514 more = 0;
515 head = 0;
516 map = 0;
517 active_next = 0;
518 active_prev = 0;
519
520 memset (static_cast<object_pod *>(this), 0, sizeof (object_pod));
521
522 SET_FLAG (this, FLAG_REMOVED);
523
524 /* What is not cleared is next, prev, and count */
525
526 expmul = 1.0;
527 face = blank_face;
528
529 if (settings.casting_time)
530 casting_time = -1;
531}
532
533/* 471/*
534 * copy_to first frees everything allocated by the dst object, 472 * copy_to first frees everything allocated by the dst object,
535 * and then copies the contents of itself into the second 473 * and then copies the contents of itself into the second
536 * object, allocating what needs to be allocated. Basically, any 474 * object, allocating what needs to be allocated. Basically, any
537 * data that is malloc'd needs to be re-malloc/copied. Otherwise, 475 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
543{ 481{
544 bool is_freed = QUERY_FLAG (dst, FLAG_FREED); 482 bool is_freed = QUERY_FLAG (dst, FLAG_FREED);
545 bool is_removed = QUERY_FLAG (dst, FLAG_REMOVED); 483 bool is_removed = QUERY_FLAG (dst, FLAG_REMOVED);
546 484
547 *(object_copy *)dst = *this; 485 *(object_copy *)dst = *this;
548 *(object_pod *)dst = *this;
549
550 if (self || cb)
551 INVOKE_OBJECT (CLONE, this, ARG_OBJECT (dst));
552 486
553 if (is_freed) 487 if (is_freed)
554 SET_FLAG (dst, FLAG_FREED); 488 SET_FLAG (dst, FLAG_FREED);
555 489
556 if (is_removed) 490 if (is_removed)
557 SET_FLAG (dst, FLAG_REMOVED); 491 SET_FLAG (dst, FLAG_REMOVED);
558 492
559 if (speed < 0) 493 if (speed < 0)
560 dst->speed_left = speed_left - RANDOM () % 200 / 100.0; 494 dst->speed_left = speed_left - rndm ();
561 495
562 /* Copy over key_values, if any. */ 496 /* Copy over key_values, if any. */
563 if (key_values) 497 if (key_values)
564 { 498 {
565 key_value *tail = 0; 499 key_value *tail = 0;
587 tail = new_link; 521 tail = new_link;
588 } 522 }
589 } 523 }
590 } 524 }
591 525
592 update_ob_speed (dst); 526 dst->set_speed (dst->speed);
593} 527}
594 528
595object * 529object *
596object::clone () 530object::clone ()
597{ 531{
603/* 537/*
604 * If an object with the IS_TURNABLE() flag needs to be turned due 538 * If an object with the IS_TURNABLE() flag needs to be turned due
605 * to the closest player being on the other side, this function can 539 * to the closest player being on the other side, this function can
606 * be called to update the face variable, _and_ how it looks on the map. 540 * be called to update the face variable, _and_ how it looks on the map.
607 */ 541 */
608
609void 542void
610update_turn_face (object *op) 543update_turn_face (object *op)
611{ 544{
612 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || op->arch == NULL) 545 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || !op->arch)
613 return; 546 return;
547
614 SET_ANIMATION (op, op->direction); 548 SET_ANIMATION (op, op->direction);
615 update_object (op, UP_OBJ_FACE); 549 update_object (op, UP_OBJ_FACE);
616} 550}
617 551
618/* 552/*
619 * Updates the speed of an object. If the speed changes from 0 to another 553 * Updates the speed of an object. If the speed changes from 0 to another
620 * value, or vice versa, then add/remove the object from the active list. 554 * value, or vice versa, then add/remove the object from the active list.
621 * This function needs to be called whenever the speed of an object changes. 555 * This function needs to be called whenever the speed of an object changes.
622 */ 556 */
623void 557void
624update_ob_speed (object *op) 558object::set_speed (float speed)
625{ 559{
626 extern int arch_init; 560 if (flag [FLAG_FREED] && speed)
627
628 /* No reason putting the archetypes objects on the speed list,
629 * since they never really need to be updated.
630 */
631
632 if (QUERY_FLAG (op, FLAG_FREED) && op->speed)
633 { 561 {
634 LOG (llevError, "Object %s is freed but has speed.\n", &op->name); 562 LOG (llevError, "Object %s is freed but has speed.\n", &name);
635#ifdef MANY_CORES
636 abort ();
637#else
638 op->speed = 0; 563 speed = 0;
639#endif
640 }
641
642 if (arch_init)
643 return;
644
645 if (FABS (op->speed) > MIN_ACTIVE_SPEED)
646 { 564 }
647 /* If already on active list, don't do anything */
648 if (op->active_next || op->active_prev || op == active_objects)
649 return;
650 565
651 /* process_events() expects us to insert the object at the beginning 566 this->speed = speed;
652 * of the list. */
653 op->active_next = active_objects;
654 567
655 if (op->active_next != NULL) 568 if (has_active_speed ())
656 op->active_next->active_prev = op; 569 activate ();
657
658 active_objects = op;
659 }
660 else 570 else
661 { 571 deactivate ();
662 /* If not on the active list, nothing needs to be done */
663 if (!op->active_next && !op->active_prev && op != active_objects)
664 return;
665
666 if (op->active_prev == NULL)
667 {
668 active_objects = op->active_next;
669
670 if (op->active_next != NULL)
671 op->active_next->active_prev = NULL;
672 }
673 else
674 {
675 op->active_prev->active_next = op->active_next;
676
677 if (op->active_next)
678 op->active_next->active_prev = op->active_prev;
679 }
680
681 op->active_next = NULL;
682 op->active_prev = NULL;
683 }
684} 572}
685 573
686/* This function removes object 'op' from the list of active
687 * objects.
688 * This should only be used for style maps or other such
689 * reference maps where you don't want an object that isn't
690 * in play chewing up cpu time getting processed.
691 * The reverse of this is to call update_ob_speed, which
692 * will do the right thing based on the speed of the object.
693 */
694void
695remove_from_active_list (object *op)
696{
697 /* If not on the active list, nothing needs to be done */
698 if (!op->active_next && !op->active_prev && op != active_objects)
699 return;
700
701 if (op->active_prev == NULL)
702 {
703 active_objects = op->active_next;
704 if (op->active_next != NULL)
705 op->active_next->active_prev = NULL;
706 }
707 else
708 {
709 op->active_prev->active_next = op->active_next;
710 if (op->active_next)
711 op->active_next->active_prev = op->active_prev;
712 }
713 op->active_next = NULL;
714 op->active_prev = NULL;
715}
716
717/* 574/*
718 * update_object() updates the array which represents the map. 575 * update_object() updates the the map.
719 * It takes into account invisible objects (and represent squares covered 576 * It takes into account invisible objects (and represent squares covered
720 * by invisible objects by whatever is below them (unless it's another 577 * by invisible objects by whatever is below them (unless it's another
721 * invisible object, etc...) 578 * invisible object, etc...)
722 * If the object being updated is beneath a player, the look-window 579 * If the object being updated is beneath a player, the look-window
723 * of that player is updated (this might be a suboptimal way of 580 * of that player is updated (this might be a suboptimal way of
724 * updating that window, though, since update_object() is called _often_) 581 * updating that window, though, since update_object() is called _often_)
725 * 582 *
726 * action is a hint of what the caller believes need to be done. 583 * action is a hint of what the caller believes need to be done.
727 * For example, if the only thing that has changed is the face (due to
728 * an animation), we don't need to call update_position until that actually
729 * comes into view of a player. OTOH, many other things, like addition/removal
730 * of walls or living creatures may need us to update the flags now.
731 * current action are: 584 * current action are:
732 * UP_OBJ_INSERT: op was inserted 585 * UP_OBJ_INSERT: op was inserted
733 * UP_OBJ_REMOVE: op was removed 586 * UP_OBJ_REMOVE: op was removed
734 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update 587 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update
735 * as that is easier than trying to look at what may have changed. 588 * as that is easier than trying to look at what may have changed.
736 * UP_OBJ_FACE: only the objects face has changed. 589 * UP_OBJ_FACE: only the objects face has changed.
737 */ 590 */
738
739void 591void
740update_object (object *op, int action) 592update_object (object *op, int action)
741{ 593{
742 int update_now = 0, flags;
743 MoveType move_on, move_off, move_block, move_slow; 594 MoveType move_on, move_off, move_block, move_slow;
744 595
745 if (op == NULL) 596 if (op == NULL)
746 { 597 {
747 /* this should never happen */ 598 /* this should never happen */
748 LOG (llevDebug, "update_object() called for NULL object.\n"); 599 LOG (llevDebug, "update_object() called for NULL object.\n");
749 return; 600 return;
750 } 601 }
751 602
752 if (op->env != NULL) 603 if (op->env)
753 { 604 {
754 /* Animation is currently handled by client, so nothing 605 /* Animation is currently handled by client, so nothing
755 * to do in this case. 606 * to do in this case.
756 */ 607 */
757 return; 608 return;
762 */ 613 */
763 if (!op->map || op->map->in_memory == MAP_SAVING) 614 if (!op->map || op->map->in_memory == MAP_SAVING)
764 return; 615 return;
765 616
766 /* make sure the object is within map boundaries */ 617 /* make sure the object is within map boundaries */
767 if (op->x < 0 || op->x >= MAP_WIDTH (op->map) || op->y < 0 || op->y >= MAP_HEIGHT (op->map)) 618 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
768 { 619 {
769 LOG (llevError, "update_object() called for object out of map!\n"); 620 LOG (llevError, "update_object() called for object out of map!\n");
770#ifdef MANY_CORES 621#ifdef MANY_CORES
771 abort (); 622 abort ();
772#endif 623#endif
773 return; 624 return;
774 } 625 }
775 626
776 flags = GET_MAP_FLAGS (op->map, op->x, op->y); 627 mapspace &m = op->ms ();
777 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NEED_UPDATE);
778 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
779 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
780 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
781 move_off = GET_MAP_MOVE_OFF (op->map, op->x, op->y);
782 628
629 if (!(m.flags_ & P_UPTODATE))
630 /* nop */;
783 if (action == UP_OBJ_INSERT) 631 else if (action == UP_OBJ_INSERT)
784 { 632 {
633 // this is likely overkill, TODO: revisit (schmorp)
785 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(flags & P_BLOCKSVIEW)) 634 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
786 update_now = 1;
787
788 if (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(flags & P_NO_MAGIC)) 635 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
789 update_now = 1; 636 || (op->type == PLAYER && !(m.flags_ & P_PLAYER))
790 637 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
638 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
791 if (QUERY_FLAG (op, FLAG_DAMNED) && !(flags & P_NO_CLERIC)) 639 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
792 update_now = 1;
793
794 if (QUERY_FLAG (op, FLAG_ALIVE) && !(flags & P_IS_ALIVE))
795 update_now = 1;
796
797 if (op->type == SAFE_GROUND && !(flags & P_SAFE))
798 update_now = 1;
799
800 if ((move_on | op->move_on) != move_on) 640 || (m.move_on | op->move_on ) != m.move_on
801 update_now = 1;
802
803 if ((move_off | op->move_off) != move_off) 641 || (m.move_off | op->move_off ) != m.move_off
804 update_now = 1; 642 || (m.move_slow | op->move_slow) != m.move_slow
805
806 /* This isn't perfect, but I don't expect a lot of objects to 643 /* This isn't perfect, but I don't expect a lot of objects to
807 * to have move_allow right now. 644 * to have move_allow right now.
808 */ 645 */
809 if (((move_block | op->move_block) & ~op->move_allow) != move_block) 646 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
810 update_now = 1; 647 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
811 648 m.flags_ = 0;
812 if ((move_slow | op->move_slow) != move_slow)
813 update_now = 1;
814 } 649 }
815
816 /* if the object is being removed, we can't make intelligent 650 /* if the object is being removed, we can't make intelligent
817 * decisions, because remove_ob can't really pass the object 651 * decisions, because remove_ob can't really pass the object
818 * that is being removed. 652 * that is being removed.
819 */ 653 */
820 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 654 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
821 update_now = 1; 655 m.flags_ = 0;
822 else if (action == UP_OBJ_FACE) 656 else if (action == UP_OBJ_FACE)
823 /* Nothing to do for that case */ ; 657 /* Nothing to do for that case */ ;
824 else 658 else
825 LOG (llevError, "update_object called with invalid action: %d\n", action); 659 LOG (llevError, "update_object called with invalid action: %d\n", action);
826 660
827 if (update_now)
828 {
829 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NO_ERROR | P_NEED_UPDATE);
830 update_position (op->map, op->x, op->y);
831 }
832
833 if (op->more != NULL) 661 if (op->more)
834 update_object (op->more, action); 662 update_object (op->more, action);
835}
836
837object::vector object::mortals;
838object::vector object::objects; // not yet used
839object *object::first;
840
841void object::free_mortals ()
842{
843 for (AUTODECL (i, mortals.begin ()); i != mortals.end ();)
844 if ((*i)->refcnt)
845 ++i; // further delay freeing
846 else
847 {
848 delete *i;
849 mortals.erase (i);
850 }
851} 663}
852 664
853object::object () 665object::object ()
854{ 666{
855 SET_FLAG (this, FLAG_REMOVED); 667 SET_FLAG (this, FLAG_REMOVED);
858 face = blank_face; 670 face = blank_face;
859} 671}
860 672
861object::~object () 673object::~object ()
862{ 674{
675 unlink ();
676
863 free_key_values (this); 677 free_key_values (this);
864} 678}
865 679
680static int object_count;
681
866void object::link () 682void object::link ()
867{ 683{
868 count = ++ob_count; 684 assert (!index);//D
869 uuid = gen_uuid (); 685 uuid = gen_uuid ();
686 count = ++object_count;
870 687
871 prev = 0; 688 refcnt_inc ();
872 next = object::first; 689 objects.insert (this);
873
874 if (object::first)
875 object::first->prev = this;
876
877 object::first = this;
878} 690}
879 691
880void object::unlink () 692void object::unlink ()
881{ 693{
882 if (this == object::first) 694 if (!index)
883 object::first = next; 695 return;
884 696
885 /* Remove this object from the list of used objects */ 697 objects.erase (this);
886 if (prev) prev->next = next; 698 refcnt_dec ();
887 if (next) next->prev = prev; 699}
888 700
889 prev = 0; 701void
890 next = 0; 702object::activate ()
703{
704 /* If already on active list, don't do anything */
705 if (active)
706 return;
707
708 if (has_active_speed ())
709 actives.insert (this);
710}
711
712void
713object::activate_recursive ()
714{
715 activate ();
716
717 for (object *op = inv; op; op = op->below)
718 op->activate_recursive ();
719}
720
721/* This function removes object 'op' from the list of active
722 * objects.
723 * This should only be used for style maps or other such
724 * reference maps where you don't want an object that isn't
725 * in play chewing up cpu time getting processed.
726 * The reverse of this is to call update_ob_speed, which
727 * will do the right thing based on the speed of the object.
728 */
729void
730object::deactivate ()
731{
732 /* If not on the active list, nothing needs to be done */
733 if (!active)
734 return;
735
736 actives.erase (this);
737}
738
739void
740object::deactivate_recursive ()
741{
742 for (object *op = inv; op; op = op->below)
743 op->deactivate_recursive ();
744
745 deactivate ();
746}
747
748void
749object::set_flag_inv (int flag, int value)
750{
751 for (object *op = inv; op; op = op->below)
752 {
753 op->flag [flag] = value;
754 op->set_flag_inv (flag, value);
755 }
756}
757
758/*
759 * Remove and free all objects in the inventory of the given object.
760 * object.c ?
761 */
762void
763object::destroy_inv (bool drop_to_ground)
764{
765 // need to check first, because the checks below might segfault
766 // as we might be on an invalid mapspace and crossfire code
767 // is too buggy to ensure that the inventory is empty.
768 // corollary: if you create arrows etc. with stuff in tis inventory,
769 // cf will crash below with off-map x and y
770 if (!inv)
771 return;
772
773 /* Only if the space blocks everything do we not process -
774 * if some form of movement is allowed, let objects
775 * drop on that space.
776 */
777 if (!drop_to_ground
778 || !map
779 || map->in_memory != MAP_IN_MEMORY
780 || map->nodrop
781 || ms ().move_block == MOVE_ALL)
782 {
783 while (inv)
784 {
785 inv->destroy_inv (drop_to_ground);
786 inv->destroy ();
787 }
788 }
789 else
790 { /* Put objects in inventory onto this space */
791 while (inv)
792 {
793 object *op = inv;
794
795 if (op->flag [FLAG_STARTEQUIP]
796 || op->flag [FLAG_NO_DROP]
797 || op->type == RUNE
798 || op->type == TRAP
799 || op->flag [FLAG_IS_A_TEMPLATE]
800 || op->flag [FLAG_DESTROY_ON_DEATH])
801 op->destroy ();
802 else
803 map->insert (op, x, y);
804 }
805 }
891} 806}
892 807
893object *object::create () 808object *object::create ()
894{ 809{
895 object *op = new object; 810 object *op = new object;
896 op->link (); 811 op->link ();
897 return op; 812 return op;
898} 813}
899 814
900/* 815void
901 * free_object() frees everything allocated by an object, removes 816object::do_destroy ()
902 * it from the list of used objects, and puts it on the list of
903 * free objects. The IS_FREED() flag is set in the object.
904 * The object must have been removed by remove_ob() first for
905 * this function to succeed.
906 *
907 * If destroy_inventory is set, free inventory as well. Else drop items in
908 * inventory to the ground.
909 */
910void object::destroy (bool destroy_inventory)
911{ 817{
912 if (QUERY_FLAG (this, FLAG_FREED)) 818 attachable::do_destroy ();
913 return;
914 819
915 if (QUERY_FLAG (this, FLAG_FRIENDLY)) 820 if (flag [FLAG_IS_LINKED])
821 remove_button_link (this);
822
823 if (flag [FLAG_FRIENDLY])
824 {
916 remove_friendly_object (this); 825 remove_friendly_object (this);
917 826
918 if (!QUERY_FLAG (this, FLAG_REMOVED)) 827 if (type == GOLEM
828 && owner
829 && owner->type == PLAYER
830 && owner->contr->ranges[range_golem] == this)
831 owner->contr->ranges[range_golem] = 0;
832 }
833
834 if (!flag [FLAG_REMOVED])
919 remove (); 835 remove ();
920 836
921 SET_FLAG (this, FLAG_FREED); 837 destroy_inv (true);
922 838
923 if (more) 839 deactivate ();
924 { 840 unlink ();
925 more->destroy (destroy_inventory);
926 more = 0;
927 }
928 841
929 if (inv) 842 flag [FLAG_FREED] = 1;
930 {
931 /* Only if the space blocks everything do we not process -
932 * if some form of movement is allowed, let objects
933 * drop on that space.
934 */
935 if (destroy_inventory || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL)
936 {
937 object *op = inv;
938
939 while (op)
940 {
941 object *tmp = op->below;
942 op->destroy (destroy_inventory);
943 op = tmp;
944 }
945 }
946 else
947 { /* Put objects in inventory onto this space */
948 object *op = inv;
949
950 while (op)
951 {
952 object *tmp = op->below;
953
954 op->remove ();
955
956 if (QUERY_FLAG (op, FLAG_STARTEQUIP)
957 || QUERY_FLAG (op, FLAG_NO_DROP) || op->type == RUNE || op->type == TRAP || QUERY_FLAG (op, FLAG_IS_A_TEMPLATE))
958 op->destroy ();
959 else
960 {
961 op->x = x;
962 op->y = y;
963 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
964 }
965
966 op = tmp;
967 }
968 }
969 }
970 843
971 // hack to ensure that freed objects still have a valid map 844 // hack to ensure that freed objects still have a valid map
972 { 845 {
973 static maptile *freed_map; // freed objects are moved here to avoid crashes 846 static maptile *freed_map; // freed objects are moved here to avoid crashes
974 847
978 851
979 freed_map->name = "/internal/freed_objects_map"; 852 freed_map->name = "/internal/freed_objects_map";
980 freed_map->width = 3; 853 freed_map->width = 3;
981 freed_map->height = 3; 854 freed_map->height = 3;
982 855
983 freed_map->allocate (); 856 freed_map->alloc ();
857 freed_map->in_memory = MAP_IN_MEMORY;
984 } 858 }
985 859
986 map = freed_map; 860 map = freed_map;
987 x = 1; 861 x = 1;
988 y = 1; 862 y = 1;
989 } 863 }
990 864
865 head = 0;
866
867 if (more)
868 {
869 more->destroy ();
870 more = 0;
871 }
872
991 // clear those pointers that likely might have circular references to us 873 // clear those pointers that likely might have circular references to us
992 owner = 0; 874 owner = 0;
993 enemy = 0; 875 enemy = 0;
994 attacked_by = 0; 876 attacked_by = 0;
877}
995 878
996 // only relevant for players(?), but make sure of it anyways 879void
997 contr = 0; 880object::destroy (bool destroy_inventory)
881{
882 if (destroyed ())
883 return;
998 884
999 /* Remove object from the active list */ 885 if (destroy_inventory)
1000 speed = 0; 886 destroy_inv (false);
1001 update_ob_speed (this);
1002 887
1003 unlink (); 888 attachable::destroy ();
1004
1005 mortals.push_back (this);
1006} 889}
1007 890
1008/* 891/*
1009 * sub_weight() recursively (outwards) subtracts a number from the 892 * sub_weight() recursively (outwards) subtracts a number from the
1010 * weight of an object (and what is carried by it's environment(s)). 893 * weight of an object (and what is carried by it's environment(s)).
1026 * This function removes the object op from the linked list of objects 909 * This function removes the object op from the linked list of objects
1027 * which it is currently tied to. When this function is done, the 910 * which it is currently tied to. When this function is done, the
1028 * object will have no environment. If the object previously had an 911 * object will have no environment. If the object previously had an
1029 * environment, the x and y coordinates will be updated to 912 * environment, the x and y coordinates will be updated to
1030 * the previous environment. 913 * the previous environment.
1031 * Beware: This function is called from the editor as well!
1032 */ 914 */
1033void 915void
1034object::remove () 916object::do_remove ()
1035{ 917{
1036 object *tmp, *last = 0; 918 object *tmp, *last = 0;
1037 object *otmp; 919 object *otmp;
1038 920
1039 int check_walk_off;
1040
1041 if (QUERY_FLAG (this, FLAG_REMOVED)) 921 if (QUERY_FLAG (this, FLAG_REMOVED))
1042 return; 922 return;
1043 923
1044 SET_FLAG (this, FLAG_REMOVED); 924 SET_FLAG (this, FLAG_REMOVED);
925 INVOKE_OBJECT (REMOVE, this);
1045 926
1046 if (more) 927 if (more)
1047 more->remove (); 928 more->remove ();
1048 929
1049 /* 930 /*
1059 940
1060 /* NO_FIX_PLAYER is set when a great many changes are being 941 /* NO_FIX_PLAYER is set when a great many changes are being
1061 * made to players inventory. If set, avoiding the call 942 * made to players inventory. If set, avoiding the call
1062 * to save cpu time. 943 * to save cpu time.
1063 */ 944 */
1064 if ((otmp = is_player_inv (env)) != NULL && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 945 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1065 fix_player (otmp); 946 otmp->update_stats ();
1066 947
1067 if (above != NULL) 948 if (above)
1068 above->below = below; 949 above->below = below;
1069 else 950 else
1070 env->inv = below; 951 env->inv = below;
1071 952
1072 if (below != NULL) 953 if (below)
1073 below->above = above; 954 below->above = above;
1074 955
1075 /* we set up values so that it could be inserted into 956 /* we set up values so that it could be inserted into
1076 * the map, but we don't actually do that - it is up 957 * the map, but we don't actually do that - it is up
1077 * to the caller to decide what we want to do. 958 * to the caller to decide what we want to do.
1081 above = 0, below = 0; 962 above = 0, below = 0;
1082 env = 0; 963 env = 0;
1083 } 964 }
1084 else if (map) 965 else if (map)
1085 { 966 {
1086 /* Re did the following section of code - it looks like it had 967 if (type == PLAYER)
1087 * lots of logic for things we no longer care about
1088 */ 968 {
969 --map->players;
970 map->touch ();
971 }
972
973 map->dirty = true;
974 mapspace &ms = this->ms ();
1089 975
1090 /* link the object above us */ 976 /* link the object above us */
1091 if (above) 977 if (above)
1092 above->below = below; 978 above->below = below;
1093 else 979 else
1094 SET_MAP_TOP (map, x, y, below); /* we were top, set new top */ 980 ms.top = below; /* we were top, set new top */
1095 981
1096 /* Relink the object below us, if there is one */ 982 /* Relink the object below us, if there is one */
1097 if (below) 983 if (below)
1098 below->above = above; 984 below->above = above;
1099 else 985 else
1101 /* Nothing below, which means we need to relink map object for this space 987 /* Nothing below, which means we need to relink map object for this space
1102 * use translated coordinates in case some oddness with map tiling is 988 * use translated coordinates in case some oddness with map tiling is
1103 * evident 989 * evident
1104 */ 990 */
1105 if (GET_MAP_OB (map, x, y) != this) 991 if (GET_MAP_OB (map, x, y) != this)
1106 {
1107 char *dump = dump_object (this);
1108 LOG (llevError,
1109 "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", dump); 992 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1110 free (dump);
1111 dump = dump_object (GET_MAP_OB (map, x, y));
1112 LOG (llevError, "%s\n", dump);
1113 free (dump);
1114 }
1115 993
1116 SET_MAP_OB (map, x, y, above); /* goes on above it. */ 994 ms.bot = above; /* goes on above it. */
1117 } 995 }
1118 996
1119 above = 0; 997 above = 0;
1120 below = 0; 998 below = 0;
1121 999
1122 if (map->in_memory == MAP_SAVING) 1000 if (map->in_memory == MAP_SAVING)
1123 return; 1001 return;
1124 1002
1125 check_walk_off = !QUERY_FLAG (this, FLAG_NO_APPLY); 1003 int check_walk_off = !flag [FLAG_NO_APPLY];
1126 1004
1127 for (tmp = GET_MAP_OB (map, x, y); tmp; tmp = tmp->above) 1005 for (tmp = ms.bot; tmp; tmp = tmp->above)
1128 { 1006 {
1129 /* No point updating the players look faces if he is the object 1007 /* No point updating the players look faces if he is the object
1130 * being removed. 1008 * being removed.
1131 */ 1009 */
1132 1010
1136 * removed (most likely destroyed), update the player view 1014 * removed (most likely destroyed), update the player view
1137 * appropriately. 1015 * appropriately.
1138 */ 1016 */
1139 if (tmp->container == this) 1017 if (tmp->container == this)
1140 { 1018 {
1141 CLEAR_FLAG (this, FLAG_APPLIED); 1019 flag [FLAG_APPLIED] = 0;
1142 tmp->container = 0; 1020 tmp->container = 0;
1143 } 1021 }
1144 1022
1145 tmp->contr->socket->update_look = 1; 1023 if (tmp->contr->ns)
1024 tmp->contr->ns->floorbox_update ();
1146 } 1025 }
1147 1026
1148 /* See if player moving off should effect something */ 1027 /* See if object moving off should effect something */
1149 if (check_walk_off 1028 if (check_walk_off
1150 && ((move_type & tmp->move_off) 1029 && ((move_type & tmp->move_off)
1151 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1030 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0))
1152 { 1031 {
1153 move_apply (tmp, this, 0); 1032 move_apply (tmp, this, 0);
1155 if (destroyed ()) 1034 if (destroyed ())
1156 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ()); 1035 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1157 } 1036 }
1158 1037
1159 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */ 1038 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */
1160 1039 //TODO: why is this horrible hacka fix? get rid of this code=bug! (schmorp)
1161 if (tmp->above == tmp) 1040 if (tmp->above == tmp)
1162 tmp->above = 0; 1041 tmp->above = 0;
1163 1042
1164 last = tmp; 1043 last = tmp;
1165 } 1044 }
1166 1045
1167 /* last == NULL of there are no objects on this space */ 1046 /* last == NULL if there are no objects on this space */
1047 //TODO: this makes little sense, why only update the topmost object?
1168 if (!last) 1048 if (!last)
1169 { 1049 map->at (x, y).flags_ = 0;
1170 /* set P_NEED_UPDATE, otherwise update_position will complain. In theory,
1171 * we could preserve the flags (GET_MAP_FLAGS), but update_position figures
1172 * those out anyways, and if there are any flags set right now, they won't
1173 * be correct anyways.
1174 */
1175 SET_MAP_FLAGS (map, x, y, P_NEED_UPDATE);
1176 update_position (map, x, y);
1177 }
1178 else 1050 else
1179 update_object (last, UP_OBJ_REMOVE); 1051 update_object (last, UP_OBJ_REMOVE);
1180 1052
1181 if (QUERY_FLAG (this, FLAG_BLOCKSVIEW) || glow_radius) 1053 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1182 update_all_los (map, x, y); 1054 update_all_los (map, x, y);
1183 } 1055 }
1184} 1056}
1185 1057
1186/* 1058/*
1195merge_ob (object *op, object *top) 1067merge_ob (object *op, object *top)
1196{ 1068{
1197 if (!op->nrof) 1069 if (!op->nrof)
1198 return 0; 1070 return 0;
1199 1071
1200 if (top == NULL) 1072 if (top)
1201 for (top = op; top != NULL && top->above != NULL; top = top->above); 1073 for (top = op; top && top->above; top = top->above)
1074 ;
1202 1075
1203 for (; top != NULL; top = top->below) 1076 for (; top; top = top->below)
1204 { 1077 {
1205 if (top == op) 1078 if (top == op)
1206 continue; 1079 continue;
1207 1080
1208 if (object::can_merge (op, top)) 1081 if (object::can_merge (op, top))
1218 1091
1219 return 0; 1092 return 0;
1220} 1093}
1221 1094
1222/* 1095/*
1223 * same as insert_ob_in_map except it handle separate coordinates and do a clean 1096 * same as insert_ob_in_map except it handles separate coordinates and does a clean
1224 * job preparing multi-part monsters 1097 * job preparing multi-part monsters.
1225 */ 1098 */
1226object * 1099object *
1227insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1100insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1228{ 1101{
1229 object *tmp;
1230
1231 if (op->head)
1232 op = op->head;
1233
1234 for (tmp = op; tmp; tmp = tmp->more) 1102 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1235 { 1103 {
1236 tmp->x = x + tmp->arch->clone.x; 1104 tmp->x = x + tmp->arch->clone.x;
1237 tmp->y = y + tmp->arch->clone.y; 1105 tmp->y = y + tmp->arch->clone.y;
1238 } 1106 }
1239 1107
1258 * Return value: 1126 * Return value:
1259 * new object if 'op' was merged with other object 1127 * new object if 'op' was merged with other object
1260 * NULL if 'op' was destroyed 1128 * NULL if 'op' was destroyed
1261 * just 'op' otherwise 1129 * just 'op' otherwise
1262 */ 1130 */
1263
1264object * 1131object *
1265insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1132insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1266{ 1133{
1267 object *tmp, *top, *floor = NULL; 1134 object *tmp, *top, *floor = NULL;
1268 sint16 x, y;
1269 1135
1270 if (QUERY_FLAG (op, FLAG_FREED)) 1136 if (QUERY_FLAG (op, FLAG_FREED))
1271 { 1137 {
1272 LOG (llevError, "Trying to insert freed object!\n"); 1138 LOG (llevError, "Trying to insert freed object!\n");
1273 return NULL; 1139 return NULL;
1274 } 1140 }
1275 1141
1276 if (m == NULL) 1142 if (!QUERY_FLAG (op, FLAG_REMOVED))
1143 LOG (llevError, "Trying to insert already inserted object %s\n", op->debug_desc ());
1144
1145 op->remove ();
1146
1147 if (!m)
1277 { 1148 {
1278 char *dump = dump_object (op); 1149 char *dump = dump_object (op);
1279 LOG (llevError, "Trying to insert in null-map!\n%s\n", dump); 1150 LOG (llevError, "Trying to insert in null-map!\n%s\n", dump);
1280 free (dump); 1151 free (dump);
1281 return op; 1152 return op;
1294#endif 1165#endif
1295 free (dump); 1166 free (dump);
1296 return op; 1167 return op;
1297 } 1168 }
1298 1169
1299 if (!QUERY_FLAG (op, FLAG_REMOVED))
1300 {
1301 char *dump = dump_object (op);
1302 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", dump);
1303 free (dump);
1304 return op;
1305 }
1306
1307 if (op->more != NULL)
1308 {
1309 /* The part may be on a different map. */
1310
1311 object *more = op->more; 1170 if (object *more = op->more)
1312 1171 {
1313 /* We really need the caller to normalize coordinates - if
1314 * we set the map, that doesn't work if the location is within
1315 * a map and this is straddling an edge. So only if coordinate
1316 * is clear wrong do we normalize it.
1317 */
1318 if (OUT_OF_REAL_MAP (more->map, more->x, more->y))
1319 more->map = get_map_from_coord (m, &more->x, &more->y);
1320 else if (!more->map)
1321 {
1322 /* For backwards compatibility - when not dealing with tiled maps,
1323 * more->map should always point to the parent.
1324 */
1325 more->map = m;
1326 }
1327
1328 if (insert_ob_in_map (more, more->map, originator, flag) == NULL) 1172 if (!insert_ob_in_map (more, m, originator, flag))
1329 { 1173 {
1330 if (!op->head) 1174 if (!op->head)
1331 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n"); 1175 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n");
1332 1176
1333 return NULL; 1177 return 0;
1334 } 1178 }
1335 } 1179 }
1336 1180
1337 CLEAR_FLAG (op, FLAG_REMOVED); 1181 CLEAR_FLAG (op, FLAG_REMOVED);
1338 1182
1339 /* Ideally, the caller figures this out. However, it complicates a lot 1183 /* Ideally, the caller figures this out. However, it complicates a lot
1340 * of areas of callers (eg, anything that uses find_free_spot would now 1184 * of areas of callers (eg, anything that uses find_free_spot would now
1341 * need extra work 1185 * need extra work
1342 */ 1186 */
1343 op->map = get_map_from_coord (m, &op->x, &op->y); 1187 if (!xy_normalise (m, op->x, op->y))
1344 x = op->x; 1188 return 0;
1345 y = op->y; 1189
1190 op->map = m;
1191 mapspace &ms = op->ms ();
1346 1192
1347 /* this has to be done after we translate the coordinates. 1193 /* this has to be done after we translate the coordinates.
1348 */ 1194 */
1349 if (op->nrof && !(flag & INS_NO_MERGE)) 1195 if (op->nrof && !(flag & INS_NO_MERGE))
1350 for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above) 1196 for (tmp = ms.bot; tmp; tmp = tmp->above)
1351 if (object::can_merge (op, tmp)) 1197 if (object::can_merge (op, tmp))
1352 { 1198 {
1353 op->nrof += tmp->nrof; 1199 op->nrof += tmp->nrof;
1354 tmp->destroy (); 1200 tmp->destroy ();
1355 } 1201 }
1372 op->below = originator->below; 1218 op->below = originator->below;
1373 1219
1374 if (op->below) 1220 if (op->below)
1375 op->below->above = op; 1221 op->below->above = op;
1376 else 1222 else
1377 SET_MAP_OB (op->map, op->x, op->y, op); 1223 ms.bot = op;
1378 1224
1379 /* since *below* originator, no need to update top */ 1225 /* since *below* originator, no need to update top */
1380 originator->below = op; 1226 originator->below = op;
1381 } 1227 }
1382 else 1228 else
1383 { 1229 {
1230 top = ms.bot;
1231
1384 /* If there are other objects, then */ 1232 /* If there are other objects, then */
1385 if ((!(flag & INS_MAP_LOAD)) && ((top = GET_MAP_OB (op->map, op->x, op->y)) != NULL)) 1233 if ((!(flag & INS_MAP_LOAD)) && top)
1386 { 1234 {
1387 object *last = NULL; 1235 object *last = 0;
1388 1236
1389 /* 1237 /*
1390 * If there are multiple objects on this space, we do some trickier handling. 1238 * If there are multiple objects on this space, we do some trickier handling.
1391 * We've already dealt with merging if appropriate. 1239 * We've already dealt with merging if appropriate.
1392 * Generally, we want to put the new object on top. But if 1240 * Generally, we want to put the new object on top. But if
1396 * once we get to them. This reduces the need to traverse over all of 1244 * once we get to them. This reduces the need to traverse over all of
1397 * them when adding another one - this saves quite a bit of cpu time 1245 * them when adding another one - this saves quite a bit of cpu time
1398 * when lots of spells are cast in one area. Currently, it is presumed 1246 * when lots of spells are cast in one area. Currently, it is presumed
1399 * that flying non pickable objects are spell objects. 1247 * that flying non pickable objects are spell objects.
1400 */ 1248 */
1401 1249 for (top = ms.bot; top; top = top->above)
1402 while (top != NULL)
1403 { 1250 {
1404 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1251 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))
1405 floor = top; 1252 floor = top;
1406 1253
1407 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1254 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))
1410 top = top->below; 1257 top = top->below;
1411 break; 1258 break;
1412 } 1259 }
1413 1260
1414 last = top; 1261 last = top;
1415 top = top->above;
1416 } 1262 }
1417 1263
1418 /* Don't want top to be NULL, so set it to the last valid object */ 1264 /* Don't want top to be NULL, so set it to the last valid object */
1419 top = last; 1265 top = last;
1420 1266
1427 * Unless those objects are exits, type 66 1273 * Unless those objects are exits, type 66
1428 * If INS_ON_TOP is used, don't do this processing 1274 * If INS_ON_TOP is used, don't do this processing
1429 * Need to find the object that in fact blocks view, otherwise 1275 * Need to find the object that in fact blocks view, otherwise
1430 * stacking is a bit odd. 1276 * stacking is a bit odd.
1431 */ 1277 */
1432 if (!(flag & INS_ON_TOP) && 1278 if (!(flag & INS_ON_TOP)
1433 (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_BLOCKSVIEW) && (op->face && !op->face->visibility)) 1279 && ms.flags () & P_BLOCKSVIEW
1280 && (op->face && !op->face->visibility))
1434 { 1281 {
1435 for (last = top; last != floor; last = last->below) 1282 for (last = top; last != floor; last = last->below)
1436 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1283 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1437 break; 1284 break;
1285
1438 /* Check to see if we found the object that blocks view, 1286 /* Check to see if we found the object that blocks view,
1439 * and make sure we have a below pointer for it so that 1287 * and make sure we have a below pointer for it so that
1440 * we can get inserted below this one, which requires we 1288 * we can get inserted below this one, which requires we
1441 * set top to the object below us. 1289 * set top to the object below us.
1442 */ 1290 */
1444 top = last->below; 1292 top = last->below;
1445 } 1293 }
1446 } /* If objects on this space */ 1294 } /* If objects on this space */
1447 1295
1448 if (flag & INS_MAP_LOAD) 1296 if (flag & INS_MAP_LOAD)
1449 top = GET_MAP_TOP (op->map, op->x, op->y); 1297 top = ms.top;
1450 1298
1451 if (flag & INS_ABOVE_FLOOR_ONLY) 1299 if (flag & INS_ABOVE_FLOOR_ONLY)
1452 top = floor; 1300 top = floor;
1453 1301
1454 /* Top is the object that our object (op) is going to get inserted above. 1302 /* Top is the object that our object (op) is going to get inserted above.
1455 */ 1303 */
1456 1304
1457 /* First object on this space */ 1305 /* First object on this space */
1458 if (!top) 1306 if (!top)
1459 { 1307 {
1460 op->above = GET_MAP_OB (op->map, op->x, op->y); 1308 op->above = ms.bot;
1461 1309
1462 if (op->above) 1310 if (op->above)
1463 op->above->below = op; 1311 op->above->below = op;
1464 1312
1465 op->below = NULL; 1313 op->below = 0;
1466 SET_MAP_OB (op->map, op->x, op->y, op); 1314 ms.bot = op;
1467 } 1315 }
1468 else 1316 else
1469 { /* get inserted into the stack above top */ 1317 { /* get inserted into the stack above top */
1470 op->above = top->above; 1318 op->above = top->above;
1471 1319
1474 1322
1475 op->below = top; 1323 op->below = top;
1476 top->above = op; 1324 top->above = op;
1477 } 1325 }
1478 1326
1479 if (op->above == NULL) 1327 if (!op->above)
1480 SET_MAP_TOP (op->map, op->x, op->y, op); 1328 ms.top = op;
1481 } /* else not INS_BELOW_ORIGINATOR */ 1329 } /* else not INS_BELOW_ORIGINATOR */
1482 1330
1483 if (op->type == PLAYER) 1331 if (op->type == PLAYER)
1332 {
1484 op->contr->do_los = 1; 1333 op->contr->do_los = 1;
1334 ++op->map->players;
1335 op->map->touch ();
1336 }
1337
1338 op->map->dirty = true;
1485 1339
1486 /* If we have a floor, we know the player, if any, will be above 1340 /* If we have a floor, we know the player, if any, will be above
1487 * it, so save a few ticks and start from there. 1341 * it, so save a few ticks and start from there.
1488 */ 1342 */
1489 if (!(flag & INS_MAP_LOAD)) 1343 if (!(flag & INS_MAP_LOAD))
1490 for (tmp = floor ? floor : GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1344 if (object *pl = ms.player ())
1491 if (tmp->type == PLAYER) 1345 if (pl->contr->ns)
1492 tmp->contr->socket->update_look = 1; 1346 pl->contr->ns->floorbox_update ();
1493 1347
1494 /* If this object glows, it may affect lighting conditions that are 1348 /* If this object glows, it may affect lighting conditions that are
1495 * visible to others on this map. But update_all_los is really 1349 * visible to others on this map. But update_all_los is really
1496 * an inefficient way to do this, as it means los for all players 1350 * an inefficient way to do this, as it means los for all players
1497 * on the map will get recalculated. The players could very well 1351 * on the map will get recalculated. The players could very well
1498 * be far away from this change and not affected in any way - 1352 * be far away from this change and not affected in any way -
1499 * this should get redone to only look for players within range, 1353 * this should get redone to only look for players within range,
1500 * or just updating the P_NEED_UPDATE for spaces within this area 1354 * or just updating the P_UPTODATE for spaces within this area
1501 * of effect may be sufficient. 1355 * of effect may be sufficient.
1502 */ 1356 */
1503 if (MAP_DARKNESS (op->map) && (op->glow_radius != 0)) 1357 if (op->map->darkness && (op->glow_radius != 0))
1504 update_all_los (op->map, op->x, op->y); 1358 update_all_los (op->map, op->x, op->y);
1505 1359
1506 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1360 /* updates flags (blocked, alive, no magic, etc) for this map space */
1507 update_object (op, UP_OBJ_INSERT); 1361 update_object (op, UP_OBJ_INSERT);
1508 1362
1363 INVOKE_OBJECT (INSERT, op);
1364
1509 /* Don't know if moving this to the end will break anything. However, 1365 /* Don't know if moving this to the end will break anything. However,
1510 * we want to have update_look set above before calling this. 1366 * we want to have floorbox_update called before calling this.
1511 * 1367 *
1512 * check_move_on() must be after this because code called from 1368 * check_move_on() must be after this because code called from
1513 * check_move_on() depends on correct map flags (so functions like 1369 * check_move_on() depends on correct map flags (so functions like
1514 * blocked() and wall() work properly), and these flags are updated by 1370 * blocked() and wall() work properly), and these flags are updated by
1515 * update_object(). 1371 * update_object().
1517 1373
1518 /* if this is not the head or flag has been passed, don't check walk on status */ 1374 /* if this is not the head or flag has been passed, don't check walk on status */
1519 if (!(flag & INS_NO_WALK_ON) && !op->head) 1375 if (!(flag & INS_NO_WALK_ON) && !op->head)
1520 { 1376 {
1521 if (check_move_on (op, originator)) 1377 if (check_move_on (op, originator))
1522 return NULL; 1378 return 0;
1523 1379
1524 /* If we are a multi part object, lets work our way through the check 1380 /* If we are a multi part object, lets work our way through the check
1525 * walk on's. 1381 * walk on's.
1526 */ 1382 */
1527 for (tmp = op->more; tmp != NULL; tmp = tmp->more) 1383 for (tmp = op->more; tmp != NULL; tmp = tmp->more)
1528 if (check_move_on (tmp, originator)) 1384 if (check_move_on (tmp, originator))
1529 return NULL; 1385 return 0;
1530 } 1386 }
1531 1387
1532 return op; 1388 return op;
1533} 1389}
1534 1390
1535/* this function inserts an object in the map, but if it 1391/* this function inserts an object in the map, but if it
1536 * finds an object of its own type, it'll remove that one first. 1392 * finds an object of its own type, it'll remove that one first.
1537 * op is the object to insert it under: supplies x and the map. 1393 * op is the object to insert it under: supplies x and the map.
1538 */ 1394 */
1539void 1395void
1540replace_insert_ob_in_map (const char *arch_string, object *op) 1396replace_insert_ob_in_map (const char *arch_string, object *op)
1541{ 1397{
1542 object * 1398 object *tmp, *tmp1;
1543 tmp;
1544 object *
1545 tmp1;
1546 1399
1547 /* first search for itself and remove any old instances */ 1400 /* first search for itself and remove any old instances */
1548 1401
1549 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1402 for (tmp = op->ms ().bot; tmp; tmp = tmp->above)
1550 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */ 1403 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */
1551 tmp->destroy (); 1404 tmp->destroy ();
1552 1405
1553 tmp1 = arch_to_object (archetype::find (arch_string)); 1406 tmp1 = arch_to_object (archetype::find (arch_string));
1554 1407
1555 tmp1->x = op->x; 1408 tmp1->x = op->x;
1556 tmp1->y = op->y; 1409 tmp1->y = op->y;
1557 insert_ob_in_map (tmp1, op->map, op, 0); 1410 insert_ob_in_map (tmp1, op->map, op, 0);
1411}
1412
1413object *
1414object::insert_at (object *where, object *originator, int flags)
1415{
1416 where->map->insert (this, where->x, where->y, originator, flags);
1558} 1417}
1559 1418
1560/* 1419/*
1561 * get_split_ob(ob,nr) splits up ob into two parts. The part which 1420 * get_split_ob(ob,nr) splits up ob into two parts. The part which
1562 * is returned contains nr objects, and the remaining parts contains 1421 * is returned contains nr objects, and the remaining parts contains
1563 * the rest (or is removed and freed if that number is 0). 1422 * the rest (or is removed and freed if that number is 0).
1564 * On failure, NULL is returned, and the reason put into the 1423 * On failure, NULL is returned, and the reason put into the
1565 * global static errmsg array. 1424 * global static errmsg array.
1566 */ 1425 */
1567
1568object * 1426object *
1569get_split_ob (object *orig_ob, uint32 nr) 1427get_split_ob (object *orig_ob, uint32 nr)
1570{ 1428{
1571 object *newob; 1429 object *newob;
1572 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0); 1430 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1608 1466
1609object * 1467object *
1610decrease_ob_nr (object *op, uint32 i) 1468decrease_ob_nr (object *op, uint32 i)
1611{ 1469{
1612 object *tmp; 1470 object *tmp;
1613 player *pl;
1614 1471
1615 if (i == 0) /* objects with op->nrof require this check */ 1472 if (i == 0) /* objects with op->nrof require this check */
1616 return op; 1473 return op;
1617 1474
1618 if (i > op->nrof) 1475 if (i > op->nrof)
1619 i = op->nrof; 1476 i = op->nrof;
1620 1477
1621 if (QUERY_FLAG (op, FLAG_REMOVED)) 1478 if (QUERY_FLAG (op, FLAG_REMOVED))
1622 op->nrof -= i; 1479 op->nrof -= i;
1623 else if (op->env != NULL) 1480 else if (op->env)
1624 { 1481 {
1625 /* is this object in the players inventory, or sub container 1482 /* is this object in the players inventory, or sub container
1626 * therein? 1483 * therein?
1627 */ 1484 */
1628 tmp = is_player_inv (op->env); 1485 tmp = op->in_player ();
1629 /* nope. Is this a container the player has opened? 1486 /* nope. Is this a container the player has opened?
1630 * If so, set tmp to that player. 1487 * If so, set tmp to that player.
1631 * IMO, searching through all the players will mostly 1488 * IMO, searching through all the players will mostly
1632 * likely be quicker than following op->env to the map, 1489 * likely be quicker than following op->env to the map,
1633 * and then searching the map for a player. 1490 * and then searching the map for a player.
1634 */ 1491 */
1635 if (!tmp) 1492 if (!tmp)
1636 { 1493 for_all_players (pl)
1637 for (pl = first_player; pl; pl = pl->next)
1638 if (pl->ob->container == op->env) 1494 if (pl->ob->container == op->env)
1495 {
1496 tmp = pl->ob;
1639 break; 1497 break;
1640 if (pl)
1641 tmp = pl->ob;
1642 else
1643 tmp = NULL;
1644 } 1498 }
1645 1499
1646 if (i < op->nrof) 1500 if (i < op->nrof)
1647 { 1501 {
1648 sub_weight (op->env, op->weight * i); 1502 sub_weight (op->env, op->weight * i);
1649 op->nrof -= i; 1503 op->nrof -= i;
1650 if (tmp) 1504 if (tmp)
1651 {
1652 esrv_send_item (tmp, op); 1505 esrv_send_item (tmp, op);
1653 }
1654 } 1506 }
1655 else 1507 else
1656 { 1508 {
1657 op->remove (); 1509 op->remove ();
1658 op->nrof = 0; 1510 op->nrof = 0;
1659 if (tmp) 1511 if (tmp)
1660 {
1661 esrv_del_item (tmp->contr, op->count); 1512 esrv_del_item (tmp->contr, op->count);
1662 }
1663 } 1513 }
1664 } 1514 }
1665 else 1515 else
1666 { 1516 {
1667 object *above = op->above; 1517 object *above = op->above;
1673 op->remove (); 1523 op->remove ();
1674 op->nrof = 0; 1524 op->nrof = 0;
1675 } 1525 }
1676 1526
1677 /* Since we just removed op, op->above is null */ 1527 /* Since we just removed op, op->above is null */
1678 for (tmp = above; tmp != NULL; tmp = tmp->above) 1528 for (tmp = above; tmp; tmp = tmp->above)
1679 if (tmp->type == PLAYER) 1529 if (tmp->type == PLAYER)
1680 { 1530 {
1681 if (op->nrof) 1531 if (op->nrof)
1682 esrv_send_item (tmp, op); 1532 esrv_send_item (tmp, op);
1683 else 1533 else
1688 if (op->nrof) 1538 if (op->nrof)
1689 return op; 1539 return op;
1690 else 1540 else
1691 { 1541 {
1692 op->destroy (); 1542 op->destroy ();
1693 return NULL; 1543 return 0;
1694 } 1544 }
1695} 1545}
1696 1546
1697/* 1547/*
1698 * add_weight(object, weight) adds the specified weight to an object, 1548 * add_weight(object, weight) adds the specified weight to an object,
1786 add_weight (this, op->weight * op->nrof); 1636 add_weight (this, op->weight * op->nrof);
1787 } 1637 }
1788 else 1638 else
1789 add_weight (this, (op->weight + op->carrying)); 1639 add_weight (this, (op->weight + op->carrying));
1790 1640
1791 otmp = is_player_inv (this); 1641 otmp = this->in_player ();
1792 if (otmp && otmp->contr) 1642 if (otmp && otmp->contr)
1793 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1643 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1794 fix_player (otmp); 1644 otmp->update_stats ();
1795 1645
1796 op->map = NULL; 1646 op->map = 0;
1797 op->env = this; 1647 op->env = this;
1798 op->above = NULL; 1648 op->above = 0;
1799 op->below = NULL; 1649 op->below = 0;
1800 op->x = 0, op->y = 0; 1650 op->x = 0, op->y = 0;
1801 1651
1802 /* reset the light list and los of the players on the map */ 1652 /* reset the light list and los of the players on the map */
1803 if ((op->glow_radius != 0) && map) 1653 if ((op->glow_radius != 0) && map)
1804 { 1654 {
1805#ifdef DEBUG_LIGHTS 1655#ifdef DEBUG_LIGHTS
1806 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name); 1656 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1807#endif /* DEBUG_LIGHTS */ 1657#endif /* DEBUG_LIGHTS */
1808 if (MAP_DARKNESS (map)) 1658 if (map->darkness)
1809 update_all_los (map, x, y); 1659 update_all_los (map, x, y);
1810 } 1660 }
1811 1661
1812 /* Client has no idea of ordering so lets not bother ordering it here. 1662 /* Client has no idea of ordering so lets not bother ordering it here.
1813 * It sure simplifies this function... 1663 * It sure simplifies this function...
1818 { 1668 {
1819 op->below = inv; 1669 op->below = inv;
1820 op->below->above = op; 1670 op->below->above = op;
1821 inv = op; 1671 inv = op;
1822 } 1672 }
1673
1674 INVOKE_OBJECT (INSERT, this);
1823 1675
1824 return op; 1676 return op;
1825} 1677}
1826 1678
1827/* 1679/*
1842 * 1694 *
1843 * MSW 2001-07-08: Check all objects on space, not just those below 1695 * MSW 2001-07-08: Check all objects on space, not just those below
1844 * object being inserted. insert_ob_in_map may not put new objects 1696 * object being inserted. insert_ob_in_map may not put new objects
1845 * on top. 1697 * on top.
1846 */ 1698 */
1847
1848int 1699int
1849check_move_on (object *op, object *originator) 1700check_move_on (object *op, object *originator)
1850{ 1701{
1851 object *tmp; 1702 object *tmp;
1852 maptile *m = op->map; 1703 maptile *m = op->map;
1879 1730
1880 /* The objects have to be checked from top to bottom. 1731 /* The objects have to be checked from top to bottom.
1881 * Hence, we first go to the top: 1732 * Hence, we first go to the top:
1882 */ 1733 */
1883 1734
1884 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL && tmp->above != NULL; tmp = tmp->above) 1735 for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1885 { 1736 {
1886 /* Trim the search when we find the first other spell effect 1737 /* Trim the search when we find the first other spell effect
1887 * this helps performance so that if a space has 50 spell objects, 1738 * this helps performance so that if a space has 50 spell objects,
1888 * we don't need to check all of them. 1739 * we don't need to check all of them.
1889 */ 1740 */
1907 if ((!op->move_type && tmp->move_slow & MOVE_WALK) || 1758 if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
1908 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0)) 1759 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
1909 { 1760 {
1910 1761
1911 float 1762 float
1912 diff = tmp->move_slow_penalty * FABS (op->speed); 1763 diff = tmp->move_slow_penalty * fabs (op->speed);
1913 1764
1914 if (op->type == PLAYER) 1765 if (op->type == PLAYER)
1915 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) || 1766 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) ||
1916 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN))) 1767 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN)))
1917 diff /= 4.0; 1768 diff /= 4.0;
1944/* 1795/*
1945 * present_arch(arch, map, x, y) searches for any objects with 1796 * present_arch(arch, map, x, y) searches for any objects with
1946 * a matching archetype at the given map and coordinates. 1797 * a matching archetype at the given map and coordinates.
1947 * The first matching object is returned, or NULL if none. 1798 * The first matching object is returned, or NULL if none.
1948 */ 1799 */
1949
1950object * 1800object *
1951present_arch (const archetype *at, maptile *m, int x, int y) 1801present_arch (const archetype *at, maptile *m, int x, int y)
1952{ 1802{
1953 object *
1954 tmp;
1955
1956 if (m == NULL || out_of_map (m, x, y)) 1803 if (!m || out_of_map (m, x, y))
1957 { 1804 {
1958 LOG (llevError, "Present_arch called outside map.\n"); 1805 LOG (llevError, "Present_arch called outside map.\n");
1959 return NULL; 1806 return NULL;
1960 } 1807 }
1961 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1808
1809 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1962 if (tmp->arch == at) 1810 if (tmp->arch == at)
1963 return tmp; 1811 return tmp;
1812
1964 return NULL; 1813 return NULL;
1965} 1814}
1966 1815
1967/* 1816/*
1968 * present(type, map, x, y) searches for any objects with 1817 * present(type, map, x, y) searches for any objects with
1969 * a matching type variable at the given map and coordinates. 1818 * a matching type variable at the given map and coordinates.
1970 * The first matching object is returned, or NULL if none. 1819 * The first matching object is returned, or NULL if none.
1971 */ 1820 */
1972
1973object * 1821object *
1974present (unsigned char type, maptile *m, int x, int y) 1822present (unsigned char type, maptile *m, int x, int y)
1975{ 1823{
1976 object *
1977 tmp;
1978
1979 if (out_of_map (m, x, y)) 1824 if (out_of_map (m, x, y))
1980 { 1825 {
1981 LOG (llevError, "Present called outside map.\n"); 1826 LOG (llevError, "Present called outside map.\n");
1982 return NULL; 1827 return NULL;
1983 } 1828 }
1984 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1829
1830 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1985 if (tmp->type == type) 1831 if (tmp->type == type)
1986 return tmp; 1832 return tmp;
1833
1987 return NULL; 1834 return NULL;
1988} 1835}
1989 1836
1990/* 1837/*
1991 * present_in_ob(type, object) searches for any objects with 1838 * present_in_ob(type, object) searches for any objects with
1992 * a matching type variable in the inventory of the given object. 1839 * a matching type variable in the inventory of the given object.
1993 * The first matching object is returned, or NULL if none. 1840 * The first matching object is returned, or NULL if none.
1994 */ 1841 */
1995
1996object * 1842object *
1997present_in_ob (unsigned char type, const object *op) 1843present_in_ob (unsigned char type, const object *op)
1998{ 1844{
1999 object *
2000 tmp;
2001
2002 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1845 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2003 if (tmp->type == type) 1846 if (tmp->type == type)
2004 return tmp; 1847 return tmp;
1848
2005 return NULL; 1849 return NULL;
2006} 1850}
2007 1851
2008/* 1852/*
2009 * present_in_ob (type, str, object) searches for any objects with 1853 * present_in_ob (type, str, object) searches for any objects with
2017 * str is the string to match against. Note that we match against 1861 * str is the string to match against. Note that we match against
2018 * the object name, not the archetype name. this is so that the 1862 * the object name, not the archetype name. this is so that the
2019 * spell code can use one object type (force), but change it's name 1863 * spell code can use one object type (force), but change it's name
2020 * to be unique. 1864 * to be unique.
2021 */ 1865 */
2022
2023object * 1866object *
2024present_in_ob_by_name (int type, const char *str, const object *op) 1867present_in_ob_by_name (int type, const char *str, const object *op)
2025{ 1868{
2026 object *
2027 tmp;
2028
2029 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1869 for (object *tmp = op->inv; tmp; tmp = tmp->below)
2030 {
2031 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name))) 1870 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name)))
2032 return tmp; 1871 return tmp;
2033 } 1872
2034 return NULL; 1873 return 0;
2035} 1874}
2036 1875
2037/* 1876/*
2038 * present_arch_in_ob(archetype, object) searches for any objects with 1877 * present_arch_in_ob(archetype, object) searches for any objects with
2039 * a matching archetype in the inventory of the given object. 1878 * a matching archetype in the inventory of the given object.
2040 * The first matching object is returned, or NULL if none. 1879 * The first matching object is returned, or NULL if none.
2041 */ 1880 */
2042
2043object * 1881object *
2044present_arch_in_ob (const archetype *at, const object *op) 1882present_arch_in_ob (const archetype *at, const object *op)
2045{ 1883{
2046 object *
2047 tmp;
2048
2049 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1884 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2050 if (tmp->arch == at) 1885 if (tmp->arch == at)
2051 return tmp; 1886 return tmp;
1887
2052 return NULL; 1888 return NULL;
2053} 1889}
2054 1890
2055/* 1891/*
2056 * activate recursively a flag on an object inventory 1892 * activate recursively a flag on an object inventory
2057 */ 1893 */
2058void 1894void
2059flag_inv (object *op, int flag) 1895flag_inv (object *op, int flag)
2060{ 1896{
2061 object *
2062 tmp;
2063
2064 if (op->inv) 1897 if (op->inv)
2065 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1898 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2066 { 1899 {
2067 SET_FLAG (tmp, flag); 1900 SET_FLAG (tmp, flag);
2068 flag_inv (tmp, flag); 1901 flag_inv (tmp, flag);
2069 } 1902 }
2070} /* 1903}
1904
1905/*
2071 * desactivate recursively a flag on an object inventory 1906 * deactivate recursively a flag on an object inventory
2072 */ 1907 */
2073void 1908void
2074unflag_inv (object *op, int flag) 1909unflag_inv (object *op, int flag)
2075{ 1910{
2076 object *
2077 tmp;
2078
2079 if (op->inv) 1911 if (op->inv)
2080 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1912 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2081 { 1913 {
2082 CLEAR_FLAG (tmp, flag); 1914 CLEAR_FLAG (tmp, flag);
2083 unflag_inv (tmp, flag); 1915 unflag_inv (tmp, flag);
2084 } 1916 }
2085} 1917}
2088 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in 1920 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in
2089 * all it's inventory (recursively). 1921 * all it's inventory (recursively).
2090 * If checksums are used, a player will get set_cheat called for 1922 * If checksums are used, a player will get set_cheat called for
2091 * him/her-self and all object carried by a call to this function. 1923 * him/her-self and all object carried by a call to this function.
2092 */ 1924 */
2093
2094void 1925void
2095set_cheat (object *op) 1926set_cheat (object *op)
2096{ 1927{
2097 SET_FLAG (op, FLAG_WAS_WIZ); 1928 SET_FLAG (op, FLAG_WAS_WIZ);
2098 flag_inv (op, FLAG_WAS_WIZ); 1929 flag_inv (op, FLAG_WAS_WIZ);
2117 * because arch_blocked (now ob_blocked) needs to know the movement type 1948 * because arch_blocked (now ob_blocked) needs to know the movement type
2118 * to know if the space in question will block the object. We can't use 1949 * to know if the space in question will block the object. We can't use
2119 * the archetype because that isn't correct if the monster has been 1950 * the archetype because that isn't correct if the monster has been
2120 * customized, changed states, etc. 1951 * customized, changed states, etc.
2121 */ 1952 */
2122
2123int 1953int
2124find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop) 1954find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)
2125{ 1955{
2126 int
2127 i,
2128 index = 0, flag; 1956 int index = 0, flag;
2129 static int
2130 altern[SIZEOFFREE]; 1957 int altern[SIZEOFFREE];
2131 1958
2132 for (i = start; i < stop; i++) 1959 for (int i = start; i < stop; i++)
2133 { 1960 {
2134 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]); 1961 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]);
2135 if (!flag) 1962 if (!flag)
2136 altern[index++] = i; 1963 altern [index++] = i;
2137 1964
2138 /* Basically, if we find a wall on a space, we cut down the search size. 1965 /* Basically, if we find a wall on a space, we cut down the search size.
2139 * In this way, we won't return spaces that are on another side of a wall. 1966 * In this way, we won't return spaces that are on another side of a wall.
2140 * This mostly work, but it cuts down the search size in all directions - 1967 * This mostly work, but it cuts down the search size in all directions -
2141 * if the space being examined only has a wall to the north and empty 1968 * if the space being examined only has a wall to the north and empty
2142 * spaces in all the other directions, this will reduce the search space 1969 * spaces in all the other directions, this will reduce the search space
2143 * to only the spaces immediately surrounding the target area, and 1970 * to only the spaces immediately surrounding the target area, and
2144 * won't look 2 spaces south of the target space. 1971 * won't look 2 spaces south of the target space.
2145 */ 1972 */
2146 else if ((flag & AB_NO_PASS) && maxfree[i] < stop) 1973 else if ((flag & P_NO_PASS) && maxfree[i] < stop)
2147 stop = maxfree[i]; 1974 stop = maxfree[i];
2148 } 1975 }
1976
2149 if (!index) 1977 if (!index)
2150 return -1; 1978 return -1;
1979
2151 return altern[RANDOM () % index]; 1980 return altern [rndm (index)];
2152} 1981}
2153 1982
2154/* 1983/*
2155 * find_first_free_spot(archetype, maptile, x, y) works like 1984 * find_first_free_spot(archetype, maptile, x, y) works like
2156 * find_free_spot(), but it will search max number of squares. 1985 * find_free_spot(), but it will search max number of squares.
2157 * But it will return the first available spot, not a random choice. 1986 * But it will return the first available spot, not a random choice.
2158 * Changed 0.93.2: Have it return -1 if there is no free spot available. 1987 * Changed 0.93.2: Have it return -1 if there is no free spot available.
2159 */ 1988 */
2160
2161int 1989int
2162find_first_free_spot (const object *ob, maptile *m, int x, int y) 1990find_first_free_spot (const object *ob, maptile *m, int x, int y)
2163{ 1991{
2164 int
2165 i;
2166
2167 for (i = 0; i < SIZEOFFREE; i++) 1992 for (int i = 0; i < SIZEOFFREE; i++)
2168 {
2169 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i])) 1993 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]))
2170 return i; 1994 return i;
2171 } 1995
2172 return -1; 1996 return -1;
2173} 1997}
2174 1998
2175/* 1999/*
2176 * The function permute(arr, begin, end) randomly reorders the array 2000 * The function permute(arr, begin, end) randomly reorders the array
2177 * arr[begin..end-1]. 2001 * arr[begin..end-1].
2002 * now uses a fisher-yates shuffle, old permute was broken
2178 */ 2003 */
2179static void 2004static void
2180permute (int *arr, int begin, int end) 2005permute (int *arr, int begin, int end)
2181{ 2006{
2182 int 2007 arr += begin;
2183 i,
2184 j,
2185 tmp,
2186 len;
2187
2188 len = end - begin; 2008 end -= begin;
2189 for (i = begin; i < end; i++)
2190 {
2191 j = begin + RANDOM () % len;
2192 2009
2193 tmp = arr[i]; 2010 while (--end)
2194 arr[i] = arr[j]; 2011 swap (arr [end], arr [rndm (end + 1)]);
2195 arr[j] = tmp;
2196 }
2197} 2012}
2198 2013
2199/* new function to make monster searching more efficient, and effective! 2014/* new function to make monster searching more efficient, and effective!
2200 * This basically returns a randomized array (in the passed pointer) of 2015 * This basically returns a randomized array (in the passed pointer) of
2201 * the spaces to find monsters. In this way, it won't always look for 2016 * the spaces to find monsters. In this way, it won't always look for
2204 * the 3x3 area will be searched, just not in a predictable order. 2019 * the 3x3 area will be searched, just not in a predictable order.
2205 */ 2020 */
2206void 2021void
2207get_search_arr (int *search_arr) 2022get_search_arr (int *search_arr)
2208{ 2023{
2209 int 2024 int i;
2210 i;
2211 2025
2212 for (i = 0; i < SIZEOFFREE; i++) 2026 for (i = 0; i < SIZEOFFREE; i++)
2213 {
2214 search_arr[i] = i; 2027 search_arr[i] = i;
2215 }
2216 2028
2217 permute (search_arr, 1, SIZEOFFREE1 + 1); 2029 permute (search_arr, 1, SIZEOFFREE1 + 1);
2218 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1); 2030 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1);
2219 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE); 2031 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE);
2220} 2032}
2229 * Perhaps incorrectly, but I'm making the assumption that exclude 2041 * Perhaps incorrectly, but I'm making the assumption that exclude
2230 * is actually want is going to try and move there. We need this info 2042 * is actually want is going to try and move there. We need this info
2231 * because we have to know what movement the thing looking to move 2043 * because we have to know what movement the thing looking to move
2232 * there is capable of. 2044 * there is capable of.
2233 */ 2045 */
2234
2235int 2046int
2236find_dir (maptile *m, int x, int y, object *exclude) 2047find_dir (maptile *m, int x, int y, object *exclude)
2237{ 2048{
2238 int
2239 i,
2240 max = SIZEOFFREE, mflags; 2049 int i, max = SIZEOFFREE, mflags;
2241 2050
2242 sint16 nx, ny; 2051 sint16 nx, ny;
2243 object * 2052 object *tmp;
2244 tmp;
2245 maptile * 2053 maptile *mp;
2246 mp;
2247 2054
2248 MoveType blocked, move_type; 2055 MoveType blocked, move_type;
2249 2056
2250 if (exclude && exclude->head) 2057 if (exclude && exclude->head)
2251 { 2058 {
2263 mp = m; 2070 mp = m;
2264 nx = x + freearr_x[i]; 2071 nx = x + freearr_x[i];
2265 ny = y + freearr_y[i]; 2072 ny = y + freearr_y[i];
2266 2073
2267 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2074 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);
2075
2268 if (mflags & P_OUT_OF_MAP) 2076 if (mflags & P_OUT_OF_MAP)
2269 {
2270 max = maxfree[i]; 2077 max = maxfree[i];
2271 }
2272 else 2078 else
2273 { 2079 {
2274 blocked = GET_MAP_MOVE_BLOCK (mp, nx, ny); 2080 mapspace &ms = mp->at (nx, ny);
2081
2082 blocked = ms.move_block;
2275 2083
2276 if ((move_type & blocked) == move_type) 2084 if ((move_type & blocked) == move_type)
2277 {
2278 max = maxfree[i]; 2085 max = maxfree[i];
2279 }
2280 else if (mflags & P_IS_ALIVE) 2086 else if (mflags & P_IS_ALIVE)
2281 { 2087 {
2282 for (tmp = GET_MAP_OB (mp, nx, ny); tmp != NULL; tmp = tmp->above) 2088 for (tmp = ms.bot; tmp; tmp = tmp->above)
2283 { 2089 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)
2284 if ((QUERY_FLAG (tmp, FLAG_MONSTER) || tmp->type == PLAYER) && (tmp != exclude || (tmp->head && tmp->head != exclude))) 2090 && (tmp != exclude || (tmp->head && tmp->head != exclude)))
2285 {
2286 break; 2091 break;
2287 } 2092
2288 }
2289 if (tmp) 2093 if (tmp)
2290 {
2291 return freedir[i]; 2094 return freedir[i];
2292 }
2293 } 2095 }
2294 } 2096 }
2295 } 2097 }
2098
2296 return 0; 2099 return 0;
2297} 2100}
2298 2101
2299/* 2102/*
2300 * distance(object 1, object 2) will return the square of the 2103 * distance(object 1, object 2) will return the square of the
2301 * distance between the two given objects. 2104 * distance between the two given objects.
2302 */ 2105 */
2303
2304int 2106int
2305distance (const object *ob1, const object *ob2) 2107distance (const object *ob1, const object *ob2)
2306{ 2108{
2307 int
2308 i;
2309
2310 i = (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y); 2109 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2311 return i;
2312} 2110}
2313 2111
2314/* 2112/*
2315 * find_dir_2(delta-x,delta-y) will return a direction in which 2113 * find_dir_2(delta-x,delta-y) will return a direction in which
2316 * an object which has subtracted the x and y coordinates of another 2114 * an object which has subtracted the x and y coordinates of another
2317 * object, needs to travel toward it. 2115 * object, needs to travel toward it.
2318 */ 2116 */
2319
2320int 2117int
2321find_dir_2 (int x, int y) 2118find_dir_2 (int x, int y)
2322{ 2119{
2323 int 2120 int q;
2324 q;
2325 2121
2326 if (y) 2122 if (y)
2327 q = x * 100 / y; 2123 q = x * 100 / y;
2328 else if (x) 2124 else if (x)
2329 q = -300 * x; 2125 q = -300 * x;
2354 2150
2355 return 3; 2151 return 3;
2356} 2152}
2357 2153
2358/* 2154/*
2359 * absdir(int): Returns a number between 1 and 8, which represent
2360 * the "absolute" direction of a number (it actually takes care of
2361 * "overflow" in previous calculations of a direction).
2362 */
2363
2364int
2365absdir (int d)
2366{
2367 while (d < 1)
2368 d += 8;
2369 while (d > 8)
2370 d -= 8;
2371 return d;
2372}
2373
2374/*
2375 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is 2155 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is
2376 * between two directions (which are expected to be absolute (see absdir()) 2156 * between two directions (which are expected to be absolute (see absdir())
2377 */ 2157 */
2378
2379int 2158int
2380dirdiff (int dir1, int dir2) 2159dirdiff (int dir1, int dir2)
2381{ 2160{
2382 int 2161 int d;
2383 d;
2384 2162
2385 d = abs (dir1 - dir2); 2163 d = abs (dir1 - dir2);
2386 if (d > 4) 2164 if (d > 4)
2387 d = 8 - d; 2165 d = 8 - d;
2166
2388 return d; 2167 return d;
2389} 2168}
2390 2169
2391/* peterm: 2170/* peterm:
2392 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster. 2171 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster.
2395 * This basically means that if direction is 15, then it could either go 2174 * This basically means that if direction is 15, then it could either go
2396 * direction 4, 14, or 16 to get back to where we are. 2175 * direction 4, 14, or 16 to get back to where we are.
2397 * Moved from spell_util.c to object.c with the other related direction 2176 * Moved from spell_util.c to object.c with the other related direction
2398 * functions. 2177 * functions.
2399 */ 2178 */
2400
2401int
2402 reduction_dir[SIZEOFFREE][3] = { 2179int reduction_dir[SIZEOFFREE][3] = {
2403 {0, 0, 0}, /* 0 */ 2180 {0, 0, 0}, /* 0 */
2404 {0, 0, 0}, /* 1 */ 2181 {0, 0, 0}, /* 1 */
2405 {0, 0, 0}, /* 2 */ 2182 {0, 0, 0}, /* 2 */
2406 {0, 0, 0}, /* 3 */ 2183 {0, 0, 0}, /* 3 */
2407 {0, 0, 0}, /* 4 */ 2184 {0, 0, 0}, /* 4 */
2455 * find a path to that monster that we found. If not, 2232 * find a path to that monster that we found. If not,
2456 * we don't bother going toward it. Returns 1 if we 2233 * we don't bother going toward it. Returns 1 if we
2457 * can see a direct way to get it 2234 * can see a direct way to get it
2458 * Modified to be map tile aware -.MSW 2235 * Modified to be map tile aware -.MSW
2459 */ 2236 */
2460
2461
2462int 2237int
2463can_see_monsterP (maptile *m, int x, int y, int dir) 2238can_see_monsterP (maptile *m, int x, int y, int dir)
2464{ 2239{
2465 sint16 dx, dy; 2240 sint16 dx, dy;
2466 int
2467 mflags; 2241 int mflags;
2468 2242
2469 if (dir < 0) 2243 if (dir < 0)
2470 return 0; /* exit condition: invalid direction */ 2244 return 0; /* exit condition: invalid direction */
2471 2245
2472 dx = x + freearr_x[dir]; 2246 dx = x + freearr_x[dir];
2485 return 0; 2259 return 0;
2486 2260
2487 /* yes, can see. */ 2261 /* yes, can see. */
2488 if (dir < 9) 2262 if (dir < 9)
2489 return 1; 2263 return 1;
2264
2490 return can_see_monsterP (m, x, y, reduction_dir[dir][0]) | 2265 return can_see_monsterP (m, x, y, reduction_dir[dir][0])
2491 can_see_monsterP (m, x, y, reduction_dir[dir][1]) | can_see_monsterP (m, x, y, reduction_dir[dir][2]); 2266 | can_see_monsterP (m, x, y, reduction_dir[dir][1])
2267 | can_see_monsterP (m, x, y, reduction_dir[dir][2]);
2492} 2268}
2493
2494
2495 2269
2496/* 2270/*
2497 * can_pick(picker, item): finds out if an object is possible to be 2271 * can_pick(picker, item): finds out if an object is possible to be
2498 * picked up by the picker. Returnes 1 if it can be 2272 * picked up by the picker. Returnes 1 if it can be
2499 * picked up, otherwise 0. 2273 * picked up, otherwise 0.
2510 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2284 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2511 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2285 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2512 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2286 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));
2513} 2287}
2514 2288
2515
2516/* 2289/*
2517 * create clone from object to another 2290 * create clone from object to another
2518 */ 2291 */
2519object * 2292object *
2520object_create_clone (object *asrc) 2293object_create_clone (object *asrc)
2539 { 2312 {
2540 dst = tmp; 2313 dst = tmp;
2541 tmp->head = 0; 2314 tmp->head = 0;
2542 } 2315 }
2543 else 2316 else
2544 {
2545 tmp->head = dst; 2317 tmp->head = dst;
2546 }
2547 2318
2548 tmp->more = 0; 2319 tmp->more = 0;
2549 2320
2550 if (prev) 2321 if (prev)
2551 prev->more = tmp; 2322 prev->more = tmp;
2563/* Basically, we save the content of the string to a temp file, then call */ 2334/* Basically, we save the content of the string to a temp file, then call */
2564/* load_object on it. I admit it is a highly inefficient way to make things, */ 2335/* load_object on it. I admit it is a highly inefficient way to make things, */
2565/* but it was simple to make and allows reusing the load_object function. */ 2336/* but it was simple to make and allows reusing the load_object function. */
2566/* Remember not to use load_object_str in a time-critical situation. */ 2337/* Remember not to use load_object_str in a time-critical situation. */
2567/* Also remember that multiparts objects are not supported for now. */ 2338/* Also remember that multiparts objects are not supported for now. */
2568
2569object * 2339object *
2570load_object_str (const char *obstr) 2340load_object_str (const char *obstr)
2571{ 2341{
2572 object *op; 2342 object *op;
2573 char filename[MAX_BUF]; 2343 char filename[MAX_BUF];
2603 * returns NULL if no match. 2373 * returns NULL if no match.
2604 */ 2374 */
2605object * 2375object *
2606find_obj_by_type_subtype (const object *who, int type, int subtype) 2376find_obj_by_type_subtype (const object *who, int type, int subtype)
2607{ 2377{
2608 object *tmp;
2609
2610 for (tmp = who->inv; tmp; tmp = tmp->below) 2378 for (object *tmp = who->inv; tmp; tmp = tmp->below)
2611 if (tmp->type == type && tmp->subtype == subtype) 2379 if (tmp->type == type && tmp->subtype == subtype)
2612 return tmp; 2380 return tmp;
2613 2381
2614 return NULL; 2382 return 0;
2615} 2383}
2616 2384
2617/* If ob has a field named key, return the link from the list, 2385/* If ob has a field named key, return the link from the list,
2618 * otherwise return NULL. 2386 * otherwise return NULL.
2619 * 2387 *
2621 * do the desired thing. 2389 * do the desired thing.
2622 */ 2390 */
2623key_value * 2391key_value *
2624get_ob_key_link (const object *ob, const char *key) 2392get_ob_key_link (const object *ob, const char *key)
2625{ 2393{
2626 key_value *link;
2627
2628 for (link = ob->key_values; link != NULL; link = link->next) 2394 for (key_value *link = ob->key_values; link; link = link->next)
2629 if (link->key == key) 2395 if (link->key == key)
2630 return link; 2396 return link;
2631 2397
2632 return NULL; 2398 return 0;
2633} 2399}
2634 2400
2635/* 2401/*
2636 * Returns the value of op has an extra_field for key, or NULL. 2402 * Returns the value of op has an extra_field for key, or NULL.
2637 * 2403 *
2677 * Returns TRUE on success. 2443 * Returns TRUE on success.
2678 */ 2444 */
2679int 2445int
2680set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key) 2446set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2681{ 2447{
2682 key_value *
2683 field = NULL, *last = NULL; 2448 key_value *field = NULL, *last = NULL;
2684 2449
2685 for (field = op->key_values; field != NULL; field = field->next) 2450 for (field = op->key_values; field != NULL; field = field->next)
2686 { 2451 {
2687 if (field->key != canonical_key) 2452 if (field->key != canonical_key)
2688 { 2453 {
2716 /* IF we get here, key doesn't exist */ 2481 /* IF we get here, key doesn't exist */
2717 2482
2718 /* No field, we'll have to add it. */ 2483 /* No field, we'll have to add it. */
2719 2484
2720 if (!add_key) 2485 if (!add_key)
2721 {
2722 return FALSE; 2486 return FALSE;
2723 } 2487
2724 /* There isn't any good reason to store a null 2488 /* There isn't any good reason to store a null
2725 * value in the key/value list. If the archetype has 2489 * value in the key/value list. If the archetype has
2726 * this key, then we should also have it, so shouldn't 2490 * this key, then we should also have it, so shouldn't
2727 * be here. If user wants to store empty strings, 2491 * be here. If user wants to store empty strings,
2728 * should pass in "" 2492 * should pass in ""
2777 } 2541 }
2778 else 2542 else
2779 item = item->env; 2543 item = item->env;
2780} 2544}
2781 2545
2546
2547const char *
2548object::flag_desc (char *desc, int len) const
2549{
2550 char *p = desc;
2551 bool first = true;
2552
2553 *p = 0;
2554
2555 for (int i = 0; i < NUM_FLAGS; i++)
2556 {
2557 if (len <= 10) // magic constant!
2558 {
2559 snprintf (p, len, ",...");
2560 break;
2561 }
2562
2563 if (flag [i])
2564 {
2565 int cnt = snprintf (p, len, "%s%d", first ? "" : ",", i);
2566 len -= cnt;
2567 p += cnt;
2568 first = false;
2569 }
2570 }
2571
2572 return desc;
2573}
2574
2782// return a suitable string describing an objetc in enough detail to find it 2575// return a suitable string describing an object in enough detail to find it
2783const char * 2576const char *
2784object::debug_desc (char *info) const 2577object::debug_desc (char *info) const
2785{ 2578{
2579 char flagdesc[512];
2786 char info2[256 * 3]; 2580 char info2[256 * 4];
2787 char *p = info; 2581 char *p = info;
2788 2582
2789 p += snprintf (p, 256, "%d=\"%s%s%s\"", 2583 p += snprintf (p, 512, "{cnt:%d,uuid:<1.%" PRIx64 ">,name:\"%s\"%s%s,flags:[%s],type:%d}",
2790 count, 2584 count, uuid.seq,
2791 &name, 2585 &name,
2792 title ? " " : "", 2586 title ? "\",title:\"" : "",
2793 title ? (const char *)title : ""); 2587 title ? (const char *)title : "",
2588 flag_desc (flagdesc, 512), type);
2794 2589
2795 if (env) 2590 if (env)
2796 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2591 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2797 2592
2798 if (map) 2593 if (map)
2799 p += snprintf (p, 256, "(on %s@%d+%d)", map->path, x, y); 2594 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2800 2595
2801 return info; 2596 return info;
2802} 2597}
2803 2598
2804const char * 2599const char *
2805object::debug_desc () const 2600object::debug_desc () const
2806{ 2601{
2807 static char info[256 * 3]; 2602 static char info[256 * 4];
2808 return debug_desc (info); 2603 return debug_desc (info);
2809} 2604}
2810 2605
2606const char *
2607object::debug_desc2 () const
2608{
2609 static char info[256 * 4];
2610 return debug_desc (info);
2611}
2612
2613struct region *
2614object::region () const
2615{
2616 return map ? map->region (x, y)
2617 : region::default_region ();
2618}
2619

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines