ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.66 by root, Wed Dec 13 03:28:42 2006 UTC vs.
Revision 1.86 by root, Tue Dec 26 08:17:58 2006 UTC

29#include <sys/types.h> 29#include <sys/types.h>
30#include <sys/uio.h> 30#include <sys/uio.h>
31#include <object.h> 31#include <object.h>
32#include <funcpoint.h> 32#include <funcpoint.h>
33#include <loader.h> 33#include <loader.h>
34
35#include <bitset>
34 36
35int nrofallocobjects = 0; 37int nrofallocobjects = 0;
36static UUID uuid; 38static UUID uuid;
37const uint64 UUID_SKIP = 1<<19; 39const uint64 UUID_SKIP = 1<<19;
38 40
139 * objects with lists are rare, and lists stay short. If not, use a 141 * objects with lists are rare, and lists stay short. If not, use a
140 * different structure or at least keep the lists sorted... 142 * different structure or at least keep the lists sorted...
141 */ 143 */
142 144
143 /* For each field in wants, */ 145 /* For each field in wants, */
144 for (wants_field = wants->key_values; wants_field != NULL; wants_field = wants_field->next) 146 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)
145 { 147 {
146 key_value *has_field; 148 key_value *has_field;
147 149
148 /* Look for a field in has with the same key. */ 150 /* Look for a field in has with the same key. */
149 has_field = get_ob_key_link (has, wants_field->key); 151 has_field = get_ob_key_link (has, wants_field->key);
219 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 221 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
220 222
221 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 223 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
222 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 224 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
223 225
224 226 if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any ()
225 /* the 0x400000 on flags2 is FLAG_INV_LOCK. I don't think something 227 || ob1->arch != ob2->arch
226 * being locked in inventory should prevent merging.
227 * 0x4 in flags3 is CLIENT_SENT
228 */
229 if ((ob1->arch != ob2->arch) ||
230 (ob1->flags[0] != ob2->flags[0]) ||
231 (ob1->flags[1] != ob2->flags[1]) ||
232 ((ob1->flags[2] & ~0x400000) != (ob2->flags[2] & ~0x400000)) ||
233 ((ob1->flags[3] & ~0x4) != (ob2->flags[3] & ~0x4)) ||
234 (ob1->name != ob2->name) || 228 || ob1->name != ob2->name
235 (ob1->title != ob2->title) || 229 || ob1->title != ob2->title
236 (ob1->msg != ob2->msg) || 230 || ob1->msg != ob2->msg
237 (ob1->weight != ob2->weight) || 231 || ob1->weight != ob2->weight
238 (memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist)) != 0) || 232 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
239 (memcmp (&ob1->stats, &ob2->stats, sizeof (ob1->stats)) != 0) || 233 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
240 (ob1->attacktype != ob2->attacktype) || 234 || ob1->attacktype != ob2->attacktype
241 (ob1->magic != ob2->magic) || 235 || ob1->magic != ob2->magic
242 (ob1->slaying != ob2->slaying) || 236 || ob1->slaying != ob2->slaying
243 (ob1->skill != ob2->skill) || 237 || ob1->skill != ob2->skill
244 (ob1->value != ob2->value) || 238 || ob1->value != ob2->value
245 (ob1->animation_id != ob2->animation_id) || 239 || ob1->animation_id != ob2->animation_id
246 (ob1->client_type != ob2->client_type) || 240 || ob1->client_type != ob2->client_type
247 (ob1->materialname != ob2->materialname) || 241 || ob1->materialname != ob2->materialname
248 (ob1->lore != ob2->lore) || 242 || ob1->lore != ob2->lore
249 (ob1->subtype != ob2->subtype) || 243 || ob1->subtype != ob2->subtype
250 (ob1->move_type != ob2->move_type) || 244 || ob1->move_type != ob2->move_type
251 (ob1->move_block != ob2->move_block) || 245 || ob1->move_block != ob2->move_block
252 (ob1->move_allow != ob2->move_allow) || 246 || ob1->move_allow != ob2->move_allow
253 (ob1->move_on != ob2->move_on) || 247 || ob1->move_on != ob2->move_on
254 (ob1->move_off != ob2->move_off) || (ob1->move_slow != ob2->move_slow) || (ob1->move_slow_penalty != ob2->move_slow_penalty)) 248 || ob1->move_off != ob2->move_off
249 || ob1->move_slow != ob2->move_slow
250 || ob1->move_slow_penalty != ob2->move_slow_penalty)
255 return 0; 251 return 0;
256 252
257 /* This is really a spellbook check - really, we should 253 /* This is really a spellbook check - really, we should
258 * check all objects in the inventory. 254 * check all objects in the inventory.
259 */ 255 */
356 op = op->env; 352 op = op->env;
357 return op; 353 return op;
358} 354}
359 355
360/* 356/*
361 * Eneq(@csd.uu.se): Since we can have items buried in a character we need
362 * a better check. We basically keeping traversing up until we can't
363 * or find a player.
364 */
365
366object *
367is_player_inv (object *op)
368{
369 for (; op != NULL && op->type != PLAYER; op = op->env)
370 if (op->env == op)
371 op->env = NULL;
372 return op;
373}
374
375/*
376 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump. 357 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
377 * Some error messages. 358 * Some error messages.
378 * The result of the dump is stored in the static global errmsg array. 359 * The result of the dump is stored in the static global errmsg array.
379 */ 360 */
380 361
383{ 364{
384 if (!op) 365 if (!op)
385 return strdup ("[NULLOBJ]"); 366 return strdup ("[NULLOBJ]");
386 367
387 object_freezer freezer; 368 object_freezer freezer;
388 save_object (freezer, op, 3); 369 save_object (freezer, op, 1);
389 return freezer.as_string (); 370 return freezer.as_string ();
390} 371}
391 372
392/* 373/*
393 * get_nearest_part(multi-object, object 2) returns the part of the 374 * get_nearest_part(multi-object, object 2) returns the part of the
486 } 467 }
487 468
488 op->key_values = 0; 469 op->key_values = 0;
489} 470}
490 471
491void object::clear ()
492{
493 attachable_base::clear ();
494
495 free_key_values (this);
496
497 owner = 0;
498 name = 0;
499 name_pl = 0;
500 title = 0;
501 race = 0;
502 slaying = 0;
503 skill = 0;
504 msg = 0;
505 lore = 0;
506 custom_name = 0;
507 materialname = 0;
508 contr = 0;
509 below = 0;
510 above = 0;
511 inv = 0;
512 container = 0;
513 env = 0;
514 more = 0;
515 head = 0;
516 map = 0;
517 active_next = 0;
518 active_prev = 0;
519
520 memset (static_cast<object_pod *>(this), 0, sizeof (object_pod));
521
522 SET_FLAG (this, FLAG_REMOVED);
523
524 /* What is not cleared is next, prev, and count */
525
526 expmul = 1.0;
527 face = blank_face;
528
529 if (settings.casting_time)
530 casting_time = -1;
531}
532
533/* 472/*
534 * copy_to first frees everything allocated by the dst object, 473 * copy_to first frees everything allocated by the dst object,
535 * and then copies the contents of itself into the second 474 * and then copies the contents of itself into the second
536 * object, allocating what needs to be allocated. Basically, any 475 * object, allocating what needs to be allocated. Basically, any
537 * data that is malloc'd needs to be re-malloc/copied. Otherwise, 476 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
543{ 482{
544 bool is_freed = QUERY_FLAG (dst, FLAG_FREED); 483 bool is_freed = QUERY_FLAG (dst, FLAG_FREED);
545 bool is_removed = QUERY_FLAG (dst, FLAG_REMOVED); 484 bool is_removed = QUERY_FLAG (dst, FLAG_REMOVED);
546 485
547 *(object_copy *)dst = *this; 486 *(object_copy *)dst = *this;
548 *(object_pod *)dst = *this;
549
550 if (self || cb)
551 INVOKE_OBJECT (CLONE, this, ARG_OBJECT (dst));
552 487
553 if (is_freed) 488 if (is_freed)
554 SET_FLAG (dst, FLAG_FREED); 489 SET_FLAG (dst, FLAG_FREED);
555 490
556 if (is_removed) 491 if (is_removed)
626 extern int arch_init; 561 extern int arch_init;
627 562
628 /* No reason putting the archetypes objects on the speed list, 563 /* No reason putting the archetypes objects on the speed list,
629 * since they never really need to be updated. 564 * since they never really need to be updated.
630 */ 565 */
631
632 if (QUERY_FLAG (op, FLAG_FREED) && op->speed) 566 if (QUERY_FLAG (op, FLAG_FREED) && op->speed)
633 { 567 {
634 LOG (llevError, "Object %s is freed but has speed.\n", &op->name); 568 LOG (llevError, "Object %s is freed but has speed.\n", &op->name);
635#ifdef MANY_CORES
636 abort ();
637#else
638 op->speed = 0; 569 op->speed = 0;
639#endif
640 } 570 }
641 571
642 if (arch_init) 572 if (arch_init)
643 return; 573 return;
644 574
713 op->active_next = NULL; 643 op->active_next = NULL;
714 op->active_prev = NULL; 644 op->active_prev = NULL;
715} 645}
716 646
717/* 647/*
718 * update_object() updates the array which represents the map. 648 * update_object() updates the the map.
719 * It takes into account invisible objects (and represent squares covered 649 * It takes into account invisible objects (and represent squares covered
720 * by invisible objects by whatever is below them (unless it's another 650 * by invisible objects by whatever is below them (unless it's another
721 * invisible object, etc...) 651 * invisible object, etc...)
722 * If the object being updated is beneath a player, the look-window 652 * If the object being updated is beneath a player, the look-window
723 * of that player is updated (this might be a suboptimal way of 653 * of that player is updated (this might be a suboptimal way of
724 * updating that window, though, since update_object() is called _often_) 654 * updating that window, though, since update_object() is called _often_)
725 * 655 *
726 * action is a hint of what the caller believes need to be done. 656 * action is a hint of what the caller believes need to be done.
727 * For example, if the only thing that has changed is the face (due to
728 * an animation), we don't need to call update_position until that actually
729 * comes into view of a player. OTOH, many other things, like addition/removal
730 * of walls or living creatures may need us to update the flags now.
731 * current action are: 657 * current action are:
732 * UP_OBJ_INSERT: op was inserted 658 * UP_OBJ_INSERT: op was inserted
733 * UP_OBJ_REMOVE: op was removed 659 * UP_OBJ_REMOVE: op was removed
734 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update 660 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update
735 * as that is easier than trying to look at what may have changed. 661 * as that is easier than trying to look at what may have changed.
736 * UP_OBJ_FACE: only the objects face has changed. 662 * UP_OBJ_FACE: only the objects face has changed.
737 */ 663 */
738
739void 664void
740update_object (object *op, int action) 665update_object (object *op, int action)
741{ 666{
742 int update_now = 0, flags;
743 MoveType move_on, move_off, move_block, move_slow; 667 MoveType move_on, move_off, move_block, move_slow;
744 668
745 if (op == NULL) 669 if (op == NULL)
746 { 670 {
747 /* this should never happen */ 671 /* this should never happen */
748 LOG (llevDebug, "update_object() called for NULL object.\n"); 672 LOG (llevDebug, "update_object() called for NULL object.\n");
749 return; 673 return;
750 } 674 }
751 675
752 if (op->env != NULL) 676 if (op->env)
753 { 677 {
754 /* Animation is currently handled by client, so nothing 678 /* Animation is currently handled by client, so nothing
755 * to do in this case. 679 * to do in this case.
756 */ 680 */
757 return; 681 return;
762 */ 686 */
763 if (!op->map || op->map->in_memory == MAP_SAVING) 687 if (!op->map || op->map->in_memory == MAP_SAVING)
764 return; 688 return;
765 689
766 /* make sure the object is within map boundaries */ 690 /* make sure the object is within map boundaries */
767 if (op->x < 0 || op->x >= MAP_WIDTH (op->map) || op->y < 0 || op->y >= MAP_HEIGHT (op->map)) 691 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
768 { 692 {
769 LOG (llevError, "update_object() called for object out of map!\n"); 693 LOG (llevError, "update_object() called for object out of map!\n");
770#ifdef MANY_CORES 694#ifdef MANY_CORES
771 abort (); 695 abort ();
772#endif 696#endif
773 return; 697 return;
774 } 698 }
775 699
776 flags = GET_MAP_FLAGS (op->map, op->x, op->y); 700 mapspace &m = op->ms ();
777 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NEED_UPDATE);
778 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
779 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
780 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
781 move_off = GET_MAP_MOVE_OFF (op->map, op->x, op->y);
782 701
702 if (m.flags_ & P_NEED_UPDATE)
703 /* nop */;
783 if (action == UP_OBJ_INSERT) 704 else if (action == UP_OBJ_INSERT)
784 { 705 {
706 // this is likely overkill, TODO: revisit (schmorp)
785 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(flags & P_BLOCKSVIEW)) 707 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
786 update_now = 1;
787
788 if (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(flags & P_NO_MAGIC)) 708 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
789 update_now = 1; 709 || (op->type == PLAYER && !(m.flags_ & P_PLAYER))
790 710 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
711 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
791 if (QUERY_FLAG (op, FLAG_DAMNED) && !(flags & P_NO_CLERIC)) 712 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
792 update_now = 1;
793
794 if (QUERY_FLAG (op, FLAG_ALIVE) && !(flags & P_IS_ALIVE))
795 update_now = 1;
796
797 if (op->type == SAFE_GROUND && !(flags & P_SAFE))
798 update_now = 1;
799
800 if ((move_on | op->move_on) != move_on) 713 || (m.move_on | op->move_on ) != m.move_on
801 update_now = 1;
802
803 if ((move_off | op->move_off) != move_off) 714 || (m.move_off | op->move_off ) != m.move_off
804 update_now = 1; 715 || (m.move_slow | op->move_slow) != m.move_slow
805
806 /* This isn't perfect, but I don't expect a lot of objects to 716 /* This isn't perfect, but I don't expect a lot of objects to
807 * to have move_allow right now. 717 * to have move_allow right now.
808 */ 718 */
809 if (((move_block | op->move_block) & ~op->move_allow) != move_block) 719 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
810 update_now = 1; 720 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
811 721 m.flags_ = P_NEED_UPDATE;
812 if ((move_slow | op->move_slow) != move_slow)
813 update_now = 1;
814 } 722 }
815
816 /* if the object is being removed, we can't make intelligent 723 /* if the object is being removed, we can't make intelligent
817 * decisions, because remove_ob can't really pass the object 724 * decisions, because remove_ob can't really pass the object
818 * that is being removed. 725 * that is being removed.
819 */ 726 */
820 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 727 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
821 update_now = 1; 728 m.flags_ = P_NEED_UPDATE;
822 else if (action == UP_OBJ_FACE) 729 else if (action == UP_OBJ_FACE)
823 /* Nothing to do for that case */ ; 730 /* Nothing to do for that case */ ;
824 else 731 else
825 LOG (llevError, "update_object called with invalid action: %d\n", action); 732 LOG (llevError, "update_object called with invalid action: %d\n", action);
826 733
827 if (update_now)
828 {
829 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NO_ERROR | P_NEED_UPDATE);
830 update_position (op->map, op->x, op->y);
831 }
832
833 if (op->more != NULL) 734 if (op->more)
834 update_object (op->more, action); 735 update_object (op->more, action);
835} 736}
836 737
837object::vector object::mortals;
838object::vector object::objects; // not yet used 738object::vector object::objects; // not yet used
839object *object::first; 739object *object::first;
840
841void object::free_mortals ()
842{
843 for (AUTODECL (i, mortals.begin ()); i != mortals.end ();)
844 if ((*i)->refcnt)
845 ++i; // further delay freeing
846 else
847 {
848 delete *i;
849 mortals.erase (i);
850 }
851}
852 740
853object::object () 741object::object ()
854{ 742{
855 SET_FLAG (this, FLAG_REMOVED); 743 SET_FLAG (this, FLAG_REMOVED);
856 744
905 * this function to succeed. 793 * this function to succeed.
906 * 794 *
907 * If destroy_inventory is set, free inventory as well. Else drop items in 795 * If destroy_inventory is set, free inventory as well. Else drop items in
908 * inventory to the ground. 796 * inventory to the ground.
909 */ 797 */
910void object::destroy (bool destroy_inventory) 798void
799object::do_destroy ()
911{ 800{
912 if (QUERY_FLAG (this, FLAG_FREED)) 801 attachable::do_destroy ();
802
803 if (flag [FLAG_IS_LINKED])
804 remove_button_link (this);
805
806 if (flag [FLAG_FRIENDLY])
807 remove_friendly_object (this);
808
809 if (!flag [FLAG_REMOVED])
810 remove ();
811
812 if (flag [FLAG_FREED])
913 return; 813 return;
914 814
915 if (QUERY_FLAG (this, FLAG_FRIENDLY)) 815 flag [FLAG_FREED] = 1;
916 remove_friendly_object (this);
917
918 if (!QUERY_FLAG (this, FLAG_REMOVED))
919 remove ();
920
921 SET_FLAG (this, FLAG_FREED);
922
923 if (more)
924 {
925 more->destroy (destroy_inventory);
926 more = 0;
927 }
928
929 if (inv)
930 {
931 /* Only if the space blocks everything do we not process -
932 * if some form of movement is allowed, let objects
933 * drop on that space.
934 */
935 if (destroy_inventory || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL)
936 {
937 object *op = inv;
938
939 while (op)
940 {
941 object *tmp = op->below;
942 op->destroy (destroy_inventory);
943 op = tmp;
944 }
945 }
946 else
947 { /* Put objects in inventory onto this space */
948 object *op = inv;
949
950 while (op)
951 {
952 object *tmp = op->below;
953
954 op->remove ();
955
956 if (QUERY_FLAG (op, FLAG_STARTEQUIP)
957 || QUERY_FLAG (op, FLAG_NO_DROP) || op->type == RUNE || op->type == TRAP || QUERY_FLAG (op, FLAG_IS_A_TEMPLATE))
958 op->destroy ();
959 else
960 {
961 op->x = x;
962 op->y = y;
963 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
964 }
965
966 op = tmp;
967 }
968 }
969 }
970 816
971 // hack to ensure that freed objects still have a valid map 817 // hack to ensure that freed objects still have a valid map
972 { 818 {
973 static maptile *freed_map; // freed objects are moved here to avoid crashes 819 static maptile *freed_map; // freed objects are moved here to avoid crashes
974 820
986 map = freed_map; 832 map = freed_map;
987 x = 1; 833 x = 1;
988 y = 1; 834 y = 1;
989 } 835 }
990 836
837 more = 0;
838 head = 0;
839 inv = 0;
840
991 // clear those pointers that likely might have circular references to us 841 // clear those pointers that likely might have circular references to us
992 owner = 0; 842 owner = 0;
993 enemy = 0; 843 enemy = 0;
994 attacked_by = 0; 844 attacked_by = 0;
995 845
999 /* Remove object from the active list */ 849 /* Remove object from the active list */
1000 speed = 0; 850 speed = 0;
1001 update_ob_speed (this); 851 update_ob_speed (this);
1002 852
1003 unlink (); 853 unlink ();
854}
1004 855
1005 mortals.push_back (this); 856/*
857 * Remove and free all objects in the inventory of the given object.
858 * object.c ?
859 */
860void
861object::destroy_inv (bool drop_to_ground)
862{
863 if (!inv)
864 return;
865
866 /* Only if the space blocks everything do we not process -
867 * if some form of movement is allowed, let objects
868 * drop on that space.
869 */
870 if (!drop_to_ground || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL)
871 {
872 while (inv)
873 {
874 inv->destroy_inv (drop_to_ground);
875 inv->destroy ();
876 }
877 }
878 else
879 { /* Put objects in inventory onto this space */
880 while (inv)
881 {
882 object *op = inv;
883
884 if (op->flag [FLAG_STARTEQUIP]
885 || op->flag [FLAG_NO_DROP]
886 || op->type == RUNE
887 || op->type == TRAP
888 || op->flag [FLAG_IS_A_TEMPLATE])
889 op->destroy ();
890 else
891 {
892 op->remove ();
893 op->x = x;
894 op->y = y;
895 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
896 }
897 }
898 }
899}
900
901void
902object::destroy (bool destroy_inventory)
903{
904 if (destroyed ())
905 return;
906
907 if (more)
908 {
909 //TODO: non-head objects must not have inventory
910 more->destroy (destroy_inventory);
911 more = 0;
912 }
913
914 if (destroy_inventory)
915 destroy_inv (true);
916
917 attachable::destroy ();
1006} 918}
1007 919
1008/* 920/*
1009 * sub_weight() recursively (outwards) subtracts a number from the 921 * sub_weight() recursively (outwards) subtracts a number from the
1010 * weight of an object (and what is carried by it's environment(s)). 922 * weight of an object (and what is carried by it's environment(s)).
1034object::remove () 946object::remove ()
1035{ 947{
1036 object *tmp, *last = 0; 948 object *tmp, *last = 0;
1037 object *otmp; 949 object *otmp;
1038 950
1039 int check_walk_off;
1040
1041 if (QUERY_FLAG (this, FLAG_REMOVED)) 951 if (QUERY_FLAG (this, FLAG_REMOVED))
1042 return; 952 return;
1043 953
1044 SET_FLAG (this, FLAG_REMOVED); 954 SET_FLAG (this, FLAG_REMOVED);
955 INVOKE_OBJECT (REMOVE, this);
1045 956
1046 if (more) 957 if (more)
1047 more->remove (); 958 more->remove ();
1048 959
1049 /* 960 /*
1059 970
1060 /* NO_FIX_PLAYER is set when a great many changes are being 971 /* NO_FIX_PLAYER is set when a great many changes are being
1061 * made to players inventory. If set, avoiding the call 972 * made to players inventory. If set, avoiding the call
1062 * to save cpu time. 973 * to save cpu time.
1063 */ 974 */
1064 if ((otmp = is_player_inv (env)) != NULL && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 975 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1065 fix_player (otmp); 976 otmp->update_stats ();
1066 977
1067 if (above != NULL) 978 if (above != NULL)
1068 above->below = below; 979 above->below = below;
1069 else 980 else
1070 env->inv = below; 981 env->inv = below;
1089 1000
1090 /* link the object above us */ 1001 /* link the object above us */
1091 if (above) 1002 if (above)
1092 above->below = below; 1003 above->below = below;
1093 else 1004 else
1094 SET_MAP_TOP (map, x, y, below); /* we were top, set new top */ 1005 map->at (x, y).top = below; /* we were top, set new top */
1095 1006
1096 /* Relink the object below us, if there is one */ 1007 /* Relink the object below us, if there is one */
1097 if (below) 1008 if (below)
1098 below->above = above; 1009 below->above = above;
1099 else 1010 else
1111 dump = dump_object (GET_MAP_OB (map, x, y)); 1022 dump = dump_object (GET_MAP_OB (map, x, y));
1112 LOG (llevError, "%s\n", dump); 1023 LOG (llevError, "%s\n", dump);
1113 free (dump); 1024 free (dump);
1114 } 1025 }
1115 1026
1116 SET_MAP_OB (map, x, y, above); /* goes on above it. */ 1027 map->at (x, y).bot = above; /* goes on above it. */
1117 } 1028 }
1118 1029
1119 above = 0; 1030 above = 0;
1120 below = 0; 1031 below = 0;
1121 1032
1122 if (map->in_memory == MAP_SAVING) 1033 if (map->in_memory == MAP_SAVING)
1123 return; 1034 return;
1124 1035
1125 check_walk_off = !QUERY_FLAG (this, FLAG_NO_APPLY); 1036 int check_walk_off = !flag [FLAG_NO_APPLY];
1126 1037
1127 for (tmp = GET_MAP_OB (map, x, y); tmp; tmp = tmp->above) 1038 for (tmp = GET_MAP_OB (map, x, y); tmp; tmp = tmp->above)
1128 { 1039 {
1129 /* No point updating the players look faces if he is the object 1040 /* No point updating the players look faces if he is the object
1130 * being removed. 1041 * being removed.
1136 * removed (most likely destroyed), update the player view 1047 * removed (most likely destroyed), update the player view
1137 * appropriately. 1048 * appropriately.
1138 */ 1049 */
1139 if (tmp->container == this) 1050 if (tmp->container == this)
1140 { 1051 {
1141 CLEAR_FLAG (this, FLAG_APPLIED); 1052 flag [FLAG_APPLIED] = 0;
1142 tmp->container = 0; 1053 tmp->container = 0;
1143 } 1054 }
1144 1055
1145 tmp->contr->socket.update_look = 1; 1056 if (tmp->contr->ns)
1057 tmp->contr->ns->floorbox_update ();
1146 } 1058 }
1147 1059
1148 /* See if player moving off should effect something */ 1060 /* See if player moving off should effect something */
1149 if (check_walk_off 1061 if (check_walk_off
1150 && ((move_type & tmp->move_off) 1062 && ((move_type & tmp->move_off)
1164 last = tmp; 1076 last = tmp;
1165 } 1077 }
1166 1078
1167 /* last == NULL of there are no objects on this space */ 1079 /* last == NULL of there are no objects on this space */
1168 if (!last) 1080 if (!last)
1169 { 1081 map->at (x, y).flags_ = P_NEED_UPDATE;
1170 /* set P_NEED_UPDATE, otherwise update_position will complain. In theory,
1171 * we could preserve the flags (GET_MAP_FLAGS), but update_position figures
1172 * those out anyways, and if there are any flags set right now, they won't
1173 * be correct anyways.
1174 */
1175 SET_MAP_FLAGS (map, x, y, P_NEED_UPDATE);
1176 update_position (map, x, y);
1177 }
1178 else 1082 else
1179 update_object (last, UP_OBJ_REMOVE); 1083 update_object (last, UP_OBJ_REMOVE);
1180 1084
1181 if (QUERY_FLAG (this, FLAG_BLOCKSVIEW) || glow_radius) 1085 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1182 update_all_los (map, x, y); 1086 update_all_los (map, x, y);
1183 } 1087 }
1184} 1088}
1185 1089
1186/* 1090/*
1195merge_ob (object *op, object *top) 1099merge_ob (object *op, object *top)
1196{ 1100{
1197 if (!op->nrof) 1101 if (!op->nrof)
1198 return 0; 1102 return 0;
1199 1103
1200 if (top == NULL) 1104 if (top)
1201 for (top = op; top != NULL && top->above != NULL; top = top->above); 1105 for (top = op; top && top->above; top = top->above)
1106 ;
1202 1107
1203 for (; top != NULL; top = top->below) 1108 for (; top; top = top->below)
1204 { 1109 {
1205 if (top == op) 1110 if (top == op)
1206 continue; 1111 continue;
1207 1112
1208 if (object::can_merge (op, top)) 1113 if (object::can_merge (op, top))
1258 * Return value: 1163 * Return value:
1259 * new object if 'op' was merged with other object 1164 * new object if 'op' was merged with other object
1260 * NULL if 'op' was destroyed 1165 * NULL if 'op' was destroyed
1261 * just 'op' otherwise 1166 * just 'op' otherwise
1262 */ 1167 */
1263
1264object * 1168object *
1265insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1169insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1266{ 1170{
1267 object *tmp, *top, *floor = NULL; 1171 object *tmp, *top, *floor = NULL;
1268 sint16 x, y; 1172 sint16 x, y;
1302 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", dump); 1206 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", dump);
1303 free (dump); 1207 free (dump);
1304 return op; 1208 return op;
1305 } 1209 }
1306 1210
1307 if (op->more != NULL) 1211 if (op->more)
1308 { 1212 {
1309 /* The part may be on a different map. */ 1213 /* The part may be on a different map. */
1310 1214
1311 object *more = op->more; 1215 object *more = op->more;
1312 1216
1328 if (insert_ob_in_map (more, more->map, originator, flag) == NULL) 1232 if (insert_ob_in_map (more, more->map, originator, flag) == NULL)
1329 { 1233 {
1330 if (!op->head) 1234 if (!op->head)
1331 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n"); 1235 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n");
1332 1236
1333 return NULL; 1237 return 0;
1334 } 1238 }
1335 } 1239 }
1336 1240
1337 CLEAR_FLAG (op, FLAG_REMOVED); 1241 CLEAR_FLAG (op, FLAG_REMOVED);
1338 1242
1372 op->below = originator->below; 1276 op->below = originator->below;
1373 1277
1374 if (op->below) 1278 if (op->below)
1375 op->below->above = op; 1279 op->below->above = op;
1376 else 1280 else
1377 SET_MAP_OB (op->map, op->x, op->y, op); 1281 op->ms ().bot = op;
1378 1282
1379 /* since *below* originator, no need to update top */ 1283 /* since *below* originator, no need to update top */
1380 originator->below = op; 1284 originator->below = op;
1381 } 1285 }
1382 else 1286 else
1428 * If INS_ON_TOP is used, don't do this processing 1332 * If INS_ON_TOP is used, don't do this processing
1429 * Need to find the object that in fact blocks view, otherwise 1333 * Need to find the object that in fact blocks view, otherwise
1430 * stacking is a bit odd. 1334 * stacking is a bit odd.
1431 */ 1335 */
1432 if (!(flag & INS_ON_TOP) && 1336 if (!(flag & INS_ON_TOP) &&
1433 (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_BLOCKSVIEW) && (op->face && !op->face->visibility)) 1337 (get_map_flags (op->map, 0, op->x, op->y, 0, 0) & P_BLOCKSVIEW) && (op->face && !op->face->visibility))
1434 { 1338 {
1435 for (last = top; last != floor; last = last->below) 1339 for (last = top; last != floor; last = last->below)
1436 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1340 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1437 break; 1341 break;
1438 /* Check to see if we found the object that blocks view, 1342 /* Check to see if we found the object that blocks view,
1461 1365
1462 if (op->above) 1366 if (op->above)
1463 op->above->below = op; 1367 op->above->below = op;
1464 1368
1465 op->below = NULL; 1369 op->below = NULL;
1466 SET_MAP_OB (op->map, op->x, op->y, op); 1370 op->ms ().bot = op;
1467 } 1371 }
1468 else 1372 else
1469 { /* get inserted into the stack above top */ 1373 { /* get inserted into the stack above top */
1470 op->above = top->above; 1374 op->above = top->above;
1471 1375
1475 op->below = top; 1379 op->below = top;
1476 top->above = op; 1380 top->above = op;
1477 } 1381 }
1478 1382
1479 if (op->above == NULL) 1383 if (op->above == NULL)
1480 SET_MAP_TOP (op->map, op->x, op->y, op); 1384 op->ms ().top = op;
1481 } /* else not INS_BELOW_ORIGINATOR */ 1385 } /* else not INS_BELOW_ORIGINATOR */
1482 1386
1483 if (op->type == PLAYER) 1387 if (op->type == PLAYER)
1484 op->contr->do_los = 1; 1388 op->contr->do_los = 1;
1485 1389
1486 /* If we have a floor, we know the player, if any, will be above 1390 /* If we have a floor, we know the player, if any, will be above
1487 * it, so save a few ticks and start from there. 1391 * it, so save a few ticks and start from there.
1488 */ 1392 */
1489 if (!(flag & INS_MAP_LOAD)) 1393 if (!(flag & INS_MAP_LOAD))
1490 for (tmp = floor ? floor : GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1394 if (object *pl = op->ms ().player ())
1491 if (tmp->type == PLAYER) 1395 if (pl->contr->ns)
1492 tmp->contr->socket.update_look = 1; 1396 pl->contr->ns->floorbox_update ();
1493 1397
1494 /* If this object glows, it may affect lighting conditions that are 1398 /* If this object glows, it may affect lighting conditions that are
1495 * visible to others on this map. But update_all_los is really 1399 * visible to others on this map. But update_all_los is really
1496 * an inefficient way to do this, as it means los for all players 1400 * an inefficient way to do this, as it means los for all players
1497 * on the map will get recalculated. The players could very well 1401 * on the map will get recalculated. The players could very well
1498 * be far away from this change and not affected in any way - 1402 * be far away from this change and not affected in any way -
1499 * this should get redone to only look for players within range, 1403 * this should get redone to only look for players within range,
1500 * or just updating the P_NEED_UPDATE for spaces within this area 1404 * or just updating the P_NEED_UPDATE for spaces within this area
1501 * of effect may be sufficient. 1405 * of effect may be sufficient.
1502 */ 1406 */
1503 if (MAP_DARKNESS (op->map) && (op->glow_radius != 0)) 1407 if (op->map->darkness && (op->glow_radius != 0))
1504 update_all_los (op->map, op->x, op->y); 1408 update_all_los (op->map, op->x, op->y);
1505 1409
1506 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1410 /* updates flags (blocked, alive, no magic, etc) for this map space */
1507 update_object (op, UP_OBJ_INSERT); 1411 update_object (op, UP_OBJ_INSERT);
1508 1412
1413 INVOKE_OBJECT (INSERT, op);
1414
1509 /* Don't know if moving this to the end will break anything. However, 1415 /* Don't know if moving this to the end will break anything. However,
1510 * we want to have update_look set above before calling this. 1416 * we want to have floorbox_update called before calling this.
1511 * 1417 *
1512 * check_move_on() must be after this because code called from 1418 * check_move_on() must be after this because code called from
1513 * check_move_on() depends on correct map flags (so functions like 1419 * check_move_on() depends on correct map flags (so functions like
1514 * blocked() and wall() work properly), and these flags are updated by 1420 * blocked() and wall() work properly), and these flags are updated by
1515 * update_object(). 1421 * update_object().
1517 1423
1518 /* if this is not the head or flag has been passed, don't check walk on status */ 1424 /* if this is not the head or flag has been passed, don't check walk on status */
1519 if (!(flag & INS_NO_WALK_ON) && !op->head) 1425 if (!(flag & INS_NO_WALK_ON) && !op->head)
1520 { 1426 {
1521 if (check_move_on (op, originator)) 1427 if (check_move_on (op, originator))
1522 return NULL; 1428 return 0;
1523 1429
1524 /* If we are a multi part object, lets work our way through the check 1430 /* If we are a multi part object, lets work our way through the check
1525 * walk on's. 1431 * walk on's.
1526 */ 1432 */
1527 for (tmp = op->more; tmp != NULL; tmp = tmp->more) 1433 for (tmp = op->more; tmp != NULL; tmp = tmp->more)
1528 if (check_move_on (tmp, originator)) 1434 if (check_move_on (tmp, originator))
1529 return NULL; 1435 return 0;
1530 } 1436 }
1531 1437
1532 return op; 1438 return op;
1533} 1439}
1534 1440
1535/* this function inserts an object in the map, but if it 1441/* this function inserts an object in the map, but if it
1536 * finds an object of its own type, it'll remove that one first. 1442 * finds an object of its own type, it'll remove that one first.
1537 * op is the object to insert it under: supplies x and the map. 1443 * op is the object to insert it under: supplies x and the map.
1538 */ 1444 */
1539void 1445void
1540replace_insert_ob_in_map (const char *arch_string, object *op) 1446replace_insert_ob_in_map (const char *arch_string, object *op)
1541{ 1447{
1542 object * 1448 object *tmp, *tmp1;
1543 tmp;
1544 object *
1545 tmp1;
1546 1449
1547 /* first search for itself and remove any old instances */ 1450 /* first search for itself and remove any old instances */
1548 1451
1549 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1452 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above)
1550 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */ 1453 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */
1608 1511
1609object * 1512object *
1610decrease_ob_nr (object *op, uint32 i) 1513decrease_ob_nr (object *op, uint32 i)
1611{ 1514{
1612 object *tmp; 1515 object *tmp;
1613 player *pl;
1614 1516
1615 if (i == 0) /* objects with op->nrof require this check */ 1517 if (i == 0) /* objects with op->nrof require this check */
1616 return op; 1518 return op;
1617 1519
1618 if (i > op->nrof) 1520 if (i > op->nrof)
1619 i = op->nrof; 1521 i = op->nrof;
1620 1522
1621 if (QUERY_FLAG (op, FLAG_REMOVED)) 1523 if (QUERY_FLAG (op, FLAG_REMOVED))
1622 op->nrof -= i; 1524 op->nrof -= i;
1623 else if (op->env != NULL) 1525 else if (op->env)
1624 { 1526 {
1625 /* is this object in the players inventory, or sub container 1527 /* is this object in the players inventory, or sub container
1626 * therein? 1528 * therein?
1627 */ 1529 */
1628 tmp = is_player_inv (op->env); 1530 tmp = op->in_player ();
1629 /* nope. Is this a container the player has opened? 1531 /* nope. Is this a container the player has opened?
1630 * If so, set tmp to that player. 1532 * If so, set tmp to that player.
1631 * IMO, searching through all the players will mostly 1533 * IMO, searching through all the players will mostly
1632 * likely be quicker than following op->env to the map, 1534 * likely be quicker than following op->env to the map,
1633 * and then searching the map for a player. 1535 * and then searching the map for a player.
1634 */ 1536 */
1635 if (!tmp) 1537 if (!tmp)
1636 { 1538 for_all_players (pl)
1637 for (pl = first_player; pl; pl = pl->next)
1638 if (pl->ob->container == op->env) 1539 if (pl->ob->container == op->env)
1540 {
1541 tmp = pl->ob;
1639 break; 1542 break;
1640 if (pl)
1641 tmp = pl->ob;
1642 else
1643 tmp = NULL;
1644 } 1543 }
1645 1544
1646 if (i < op->nrof) 1545 if (i < op->nrof)
1647 { 1546 {
1648 sub_weight (op->env, op->weight * i); 1547 sub_weight (op->env, op->weight * i);
1649 op->nrof -= i; 1548 op->nrof -= i;
1650 if (tmp) 1549 if (tmp)
1651 {
1652 esrv_send_item (tmp, op); 1550 esrv_send_item (tmp, op);
1653 }
1654 } 1551 }
1655 else 1552 else
1656 { 1553 {
1657 op->remove (); 1554 op->remove ();
1658 op->nrof = 0; 1555 op->nrof = 0;
1659 if (tmp) 1556 if (tmp)
1660 {
1661 esrv_del_item (tmp->contr, op->count); 1557 esrv_del_item (tmp->contr, op->count);
1662 }
1663 } 1558 }
1664 } 1559 }
1665 else 1560 else
1666 { 1561 {
1667 object *above = op->above; 1562 object *above = op->above;
1673 op->remove (); 1568 op->remove ();
1674 op->nrof = 0; 1569 op->nrof = 0;
1675 } 1570 }
1676 1571
1677 /* Since we just removed op, op->above is null */ 1572 /* Since we just removed op, op->above is null */
1678 for (tmp = above; tmp != NULL; tmp = tmp->above) 1573 for (tmp = above; tmp; tmp = tmp->above)
1679 if (tmp->type == PLAYER) 1574 if (tmp->type == PLAYER)
1680 { 1575 {
1681 if (op->nrof) 1576 if (op->nrof)
1682 esrv_send_item (tmp, op); 1577 esrv_send_item (tmp, op);
1683 else 1578 else
1688 if (op->nrof) 1583 if (op->nrof)
1689 return op; 1584 return op;
1690 else 1585 else
1691 { 1586 {
1692 op->destroy (); 1587 op->destroy ();
1693 return NULL; 1588 return 0;
1694 } 1589 }
1695} 1590}
1696 1591
1697/* 1592/*
1698 * add_weight(object, weight) adds the specified weight to an object, 1593 * add_weight(object, weight) adds the specified weight to an object,
1786 add_weight (this, op->weight * op->nrof); 1681 add_weight (this, op->weight * op->nrof);
1787 } 1682 }
1788 else 1683 else
1789 add_weight (this, (op->weight + op->carrying)); 1684 add_weight (this, (op->weight + op->carrying));
1790 1685
1791 otmp = is_player_inv (this); 1686 otmp = this->in_player ();
1792 if (otmp && otmp->contr) 1687 if (otmp && otmp->contr)
1793 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1688 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1794 fix_player (otmp); 1689 otmp->update_stats ();
1795 1690
1796 op->map = NULL; 1691 op->map = 0;
1797 op->env = this; 1692 op->env = this;
1798 op->above = NULL; 1693 op->above = 0;
1799 op->below = NULL; 1694 op->below = 0;
1800 op->x = 0, op->y = 0; 1695 op->x = 0, op->y = 0;
1801 1696
1802 /* reset the light list and los of the players on the map */ 1697 /* reset the light list and los of the players on the map */
1803 if ((op->glow_radius != 0) && map) 1698 if ((op->glow_radius != 0) && map)
1804 { 1699 {
1805#ifdef DEBUG_LIGHTS 1700#ifdef DEBUG_LIGHTS
1806 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name); 1701 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1807#endif /* DEBUG_LIGHTS */ 1702#endif /* DEBUG_LIGHTS */
1808 if (MAP_DARKNESS (map)) 1703 if (map->darkness)
1809 update_all_los (map, x, y); 1704 update_all_los (map, x, y);
1810 } 1705 }
1811 1706
1812 /* Client has no idea of ordering so lets not bother ordering it here. 1707 /* Client has no idea of ordering so lets not bother ordering it here.
1813 * It sure simplifies this function... 1708 * It sure simplifies this function...
1818 { 1713 {
1819 op->below = inv; 1714 op->below = inv;
1820 op->below->above = op; 1715 op->below->above = op;
1821 inv = op; 1716 inv = op;
1822 } 1717 }
1718
1719 INVOKE_OBJECT (INSERT, this);
1823 1720
1824 return op; 1721 return op;
1825} 1722}
1826 1723
1827/* 1724/*
1879 1776
1880 /* The objects have to be checked from top to bottom. 1777 /* The objects have to be checked from top to bottom.
1881 * Hence, we first go to the top: 1778 * Hence, we first go to the top:
1882 */ 1779 */
1883 1780
1884 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL && tmp->above != NULL; tmp = tmp->above) 1781 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp && tmp->above; tmp = tmp->above)
1885 { 1782 {
1886 /* Trim the search when we find the first other spell effect 1783 /* Trim the search when we find the first other spell effect
1887 * this helps performance so that if a space has 50 spell objects, 1784 * this helps performance so that if a space has 50 spell objects,
1888 * we don't need to check all of them. 1785 * we don't need to check all of them.
1889 */ 1786 */
1944/* 1841/*
1945 * present_arch(arch, map, x, y) searches for any objects with 1842 * present_arch(arch, map, x, y) searches for any objects with
1946 * a matching archetype at the given map and coordinates. 1843 * a matching archetype at the given map and coordinates.
1947 * The first matching object is returned, or NULL if none. 1844 * The first matching object is returned, or NULL if none.
1948 */ 1845 */
1949
1950object * 1846object *
1951present_arch (const archetype *at, maptile *m, int x, int y) 1847present_arch (const archetype *at, maptile *m, int x, int y)
1952{ 1848{
1953 object *
1954 tmp;
1955
1956 if (m == NULL || out_of_map (m, x, y)) 1849 if (m == NULL || out_of_map (m, x, y))
1957 { 1850 {
1958 LOG (llevError, "Present_arch called outside map.\n"); 1851 LOG (llevError, "Present_arch called outside map.\n");
1959 return NULL; 1852 return NULL;
1960 } 1853 }
1854
1961 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1855 for (object *tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above)
1962 if (tmp->arch == at) 1856 if (tmp->arch == at)
1963 return tmp; 1857 return tmp;
1858
1964 return NULL; 1859 return NULL;
1965} 1860}
1966 1861
1967/* 1862/*
1968 * present(type, map, x, y) searches for any objects with 1863 * present(type, map, x, y) searches for any objects with
1969 * a matching type variable at the given map and coordinates. 1864 * a matching type variable at the given map and coordinates.
1970 * The first matching object is returned, or NULL if none. 1865 * The first matching object is returned, or NULL if none.
1971 */ 1866 */
1972
1973object * 1867object *
1974present (unsigned char type, maptile *m, int x, int y) 1868present (unsigned char type, maptile *m, int x, int y)
1975{ 1869{
1976 object *
1977 tmp;
1978
1979 if (out_of_map (m, x, y)) 1870 if (out_of_map (m, x, y))
1980 { 1871 {
1981 LOG (llevError, "Present called outside map.\n"); 1872 LOG (llevError, "Present called outside map.\n");
1982 return NULL; 1873 return NULL;
1983 } 1874 }
1875
1984 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1876 for (object *tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above)
1985 if (tmp->type == type) 1877 if (tmp->type == type)
1986 return tmp; 1878 return tmp;
1879
1987 return NULL; 1880 return NULL;
1988} 1881}
1989 1882
1990/* 1883/*
1991 * present_in_ob(type, object) searches for any objects with 1884 * present_in_ob(type, object) searches for any objects with
1992 * a matching type variable in the inventory of the given object. 1885 * a matching type variable in the inventory of the given object.
1993 * The first matching object is returned, or NULL if none. 1886 * The first matching object is returned, or NULL if none.
1994 */ 1887 */
1995
1996object * 1888object *
1997present_in_ob (unsigned char type, const object *op) 1889present_in_ob (unsigned char type, const object *op)
1998{ 1890{
1999 object *
2000 tmp;
2001
2002 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1891 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2003 if (tmp->type == type) 1892 if (tmp->type == type)
2004 return tmp; 1893 return tmp;
1894
2005 return NULL; 1895 return NULL;
2006} 1896}
2007 1897
2008/* 1898/*
2009 * present_in_ob (type, str, object) searches for any objects with 1899 * present_in_ob (type, str, object) searches for any objects with
2017 * str is the string to match against. Note that we match against 1907 * str is the string to match against. Note that we match against
2018 * the object name, not the archetype name. this is so that the 1908 * the object name, not the archetype name. this is so that the
2019 * spell code can use one object type (force), but change it's name 1909 * spell code can use one object type (force), but change it's name
2020 * to be unique. 1910 * to be unique.
2021 */ 1911 */
2022
2023object * 1912object *
2024present_in_ob_by_name (int type, const char *str, const object *op) 1913present_in_ob_by_name (int type, const char *str, const object *op)
2025{ 1914{
2026 object *
2027 tmp;
2028
2029 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1915 for (object *tmp = op->inv; tmp; tmp = tmp->below)
2030 {
2031 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name))) 1916 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name)))
2032 return tmp; 1917 return tmp;
2033 } 1918
2034 return NULL; 1919 return 0;
2035} 1920}
2036 1921
2037/* 1922/*
2038 * present_arch_in_ob(archetype, object) searches for any objects with 1923 * present_arch_in_ob(archetype, object) searches for any objects with
2039 * a matching archetype in the inventory of the given object. 1924 * a matching archetype in the inventory of the given object.
2040 * The first matching object is returned, or NULL if none. 1925 * The first matching object is returned, or NULL if none.
2041 */ 1926 */
2042
2043object * 1927object *
2044present_arch_in_ob (const archetype *at, const object *op) 1928present_arch_in_ob (const archetype *at, const object *op)
2045{ 1929{
2046 object *
2047 tmp;
2048
2049 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1930 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2050 if (tmp->arch == at) 1931 if (tmp->arch == at)
2051 return tmp; 1932 return tmp;
1933
2052 return NULL; 1934 return NULL;
2053} 1935}
2054 1936
2055/* 1937/*
2056 * activate recursively a flag on an object inventory 1938 * activate recursively a flag on an object inventory
2057 */ 1939 */
2058void 1940void
2059flag_inv (object *op, int flag) 1941flag_inv (object *op, int flag)
2060{ 1942{
2061 object *
2062 tmp;
2063
2064 if (op->inv) 1943 if (op->inv)
2065 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1944 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2066 { 1945 {
2067 SET_FLAG (tmp, flag); 1946 SET_FLAG (tmp, flag);
2068 flag_inv (tmp, flag); 1947 flag_inv (tmp, flag);
2069 } 1948 }
2070} /* 1949}
1950
1951/*
2071 * desactivate recursively a flag on an object inventory 1952 * deactivate recursively a flag on an object inventory
2072 */ 1953 */
2073void 1954void
2074unflag_inv (object *op, int flag) 1955unflag_inv (object *op, int flag)
2075{ 1956{
2076 object *
2077 tmp;
2078
2079 if (op->inv) 1957 if (op->inv)
2080 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1958 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2081 { 1959 {
2082 CLEAR_FLAG (tmp, flag); 1960 CLEAR_FLAG (tmp, flag);
2083 unflag_inv (tmp, flag); 1961 unflag_inv (tmp, flag);
2084 } 1962 }
2085} 1963}
2088 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in 1966 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in
2089 * all it's inventory (recursively). 1967 * all it's inventory (recursively).
2090 * If checksums are used, a player will get set_cheat called for 1968 * If checksums are used, a player will get set_cheat called for
2091 * him/her-self and all object carried by a call to this function. 1969 * him/her-self and all object carried by a call to this function.
2092 */ 1970 */
2093
2094void 1971void
2095set_cheat (object *op) 1972set_cheat (object *op)
2096{ 1973{
2097 SET_FLAG (op, FLAG_WAS_WIZ); 1974 SET_FLAG (op, FLAG_WAS_WIZ);
2098 flag_inv (op, FLAG_WAS_WIZ); 1975 flag_inv (op, FLAG_WAS_WIZ);
2117 * because arch_blocked (now ob_blocked) needs to know the movement type 1994 * because arch_blocked (now ob_blocked) needs to know the movement type
2118 * to know if the space in question will block the object. We can't use 1995 * to know if the space in question will block the object. We can't use
2119 * the archetype because that isn't correct if the monster has been 1996 * the archetype because that isn't correct if the monster has been
2120 * customized, changed states, etc. 1997 * customized, changed states, etc.
2121 */ 1998 */
2122
2123int 1999int
2124find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop) 2000find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)
2125{ 2001{
2126 int
2127 i,
2128 index = 0, flag; 2002 int index = 0, flag;
2129 static int
2130 altern[SIZEOFFREE]; 2003 int altern[SIZEOFFREE];
2131 2004
2132 for (i = start; i < stop; i++) 2005 for (int i = start; i < stop; i++)
2133 { 2006 {
2134 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]); 2007 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]);
2135 if (!flag) 2008 if (!flag)
2136 altern[index++] = i; 2009 altern [index++] = i;
2137 2010
2138 /* Basically, if we find a wall on a space, we cut down the search size. 2011 /* Basically, if we find a wall on a space, we cut down the search size.
2139 * In this way, we won't return spaces that are on another side of a wall. 2012 * In this way, we won't return spaces that are on another side of a wall.
2140 * This mostly work, but it cuts down the search size in all directions - 2013 * This mostly work, but it cuts down the search size in all directions -
2141 * if the space being examined only has a wall to the north and empty 2014 * if the space being examined only has a wall to the north and empty
2142 * spaces in all the other directions, this will reduce the search space 2015 * spaces in all the other directions, this will reduce the search space
2143 * to only the spaces immediately surrounding the target area, and 2016 * to only the spaces immediately surrounding the target area, and
2144 * won't look 2 spaces south of the target space. 2017 * won't look 2 spaces south of the target space.
2145 */ 2018 */
2146 else if ((flag & AB_NO_PASS) && maxfree[i] < stop) 2019 else if ((flag & P_NO_PASS) && maxfree[i] < stop)
2147 stop = maxfree[i]; 2020 stop = maxfree[i];
2148 } 2021 }
2022
2149 if (!index) 2023 if (!index)
2150 return -1; 2024 return -1;
2025
2151 return altern[RANDOM () % index]; 2026 return altern[RANDOM () % index];
2152} 2027}
2153 2028
2154/* 2029/*
2155 * find_first_free_spot(archetype, maptile, x, y) works like 2030 * find_first_free_spot(archetype, maptile, x, y) works like
2156 * find_free_spot(), but it will search max number of squares. 2031 * find_free_spot(), but it will search max number of squares.
2157 * But it will return the first available spot, not a random choice. 2032 * But it will return the first available spot, not a random choice.
2158 * Changed 0.93.2: Have it return -1 if there is no free spot available. 2033 * Changed 0.93.2: Have it return -1 if there is no free spot available.
2159 */ 2034 */
2160
2161int 2035int
2162find_first_free_spot (const object *ob, maptile *m, int x, int y) 2036find_first_free_spot (const object *ob, maptile *m, int x, int y)
2163{ 2037{
2164 int
2165 i;
2166
2167 for (i = 0; i < SIZEOFFREE; i++) 2038 for (int i = 0; i < SIZEOFFREE; i++)
2168 {
2169 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i])) 2039 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]))
2170 return i; 2040 return i;
2171 } 2041
2172 return -1; 2042 return -1;
2173} 2043}
2174 2044
2175/* 2045/*
2176 * The function permute(arr, begin, end) randomly reorders the array 2046 * The function permute(arr, begin, end) randomly reorders the array
2177 * arr[begin..end-1]. 2047 * arr[begin..end-1].
2048 * now uses a fisher-yates shuffle, old permute was broken
2178 */ 2049 */
2179static void 2050static void
2180permute (int *arr, int begin, int end) 2051permute (int *arr, int begin, int end)
2181{ 2052{
2182 int 2053 arr += begin;
2183 i,
2184 j,
2185 tmp,
2186 len;
2187
2188 len = end - begin; 2054 end -= begin;
2189 for (i = begin; i < end; i++)
2190 {
2191 j = begin + RANDOM () % len;
2192 2055
2193 tmp = arr[i]; 2056 while (--end)
2194 arr[i] = arr[j]; 2057 swap (arr [end], arr [RANDOM () % (end + 1)]);
2195 arr[j] = tmp;
2196 }
2197} 2058}
2198 2059
2199/* new function to make monster searching more efficient, and effective! 2060/* new function to make monster searching more efficient, and effective!
2200 * This basically returns a randomized array (in the passed pointer) of 2061 * This basically returns a randomized array (in the passed pointer) of
2201 * the spaces to find monsters. In this way, it won't always look for 2062 * the spaces to find monsters. In this way, it won't always look for
2204 * the 3x3 area will be searched, just not in a predictable order. 2065 * the 3x3 area will be searched, just not in a predictable order.
2205 */ 2066 */
2206void 2067void
2207get_search_arr (int *search_arr) 2068get_search_arr (int *search_arr)
2208{ 2069{
2209 int 2070 int i;
2210 i;
2211 2071
2212 for (i = 0; i < SIZEOFFREE; i++) 2072 for (i = 0; i < SIZEOFFREE; i++)
2213 {
2214 search_arr[i] = i; 2073 search_arr[i] = i;
2215 }
2216 2074
2217 permute (search_arr, 1, SIZEOFFREE1 + 1); 2075 permute (search_arr, 1, SIZEOFFREE1 + 1);
2218 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1); 2076 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1);
2219 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE); 2077 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE);
2220} 2078}
2229 * Perhaps incorrectly, but I'm making the assumption that exclude 2087 * Perhaps incorrectly, but I'm making the assumption that exclude
2230 * is actually want is going to try and move there. We need this info 2088 * is actually want is going to try and move there. We need this info
2231 * because we have to know what movement the thing looking to move 2089 * because we have to know what movement the thing looking to move
2232 * there is capable of. 2090 * there is capable of.
2233 */ 2091 */
2234
2235int 2092int
2236find_dir (maptile *m, int x, int y, object *exclude) 2093find_dir (maptile *m, int x, int y, object *exclude)
2237{ 2094{
2238 int
2239 i,
2240 max = SIZEOFFREE, mflags; 2095 int i, max = SIZEOFFREE, mflags;
2241 2096
2242 sint16 nx, ny; 2097 sint16 nx, ny;
2243 object * 2098 object *tmp;
2244 tmp;
2245 maptile * 2099 maptile *mp;
2246 mp;
2247 2100
2248 MoveType blocked, move_type; 2101 MoveType blocked, move_type;
2249 2102
2250 if (exclude && exclude->head) 2103 if (exclude && exclude->head)
2251 { 2104 {
2263 mp = m; 2116 mp = m;
2264 nx = x + freearr_x[i]; 2117 nx = x + freearr_x[i];
2265 ny = y + freearr_y[i]; 2118 ny = y + freearr_y[i];
2266 2119
2267 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2120 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);
2121
2268 if (mflags & P_OUT_OF_MAP) 2122 if (mflags & P_OUT_OF_MAP)
2269 {
2270 max = maxfree[i]; 2123 max = maxfree[i];
2271 }
2272 else 2124 else
2273 { 2125 {
2274 blocked = GET_MAP_MOVE_BLOCK (mp, nx, ny); 2126 mapspace &ms = mp->at (nx, ny);
2127
2128 blocked = ms.move_block;
2275 2129
2276 if ((move_type & blocked) == move_type) 2130 if ((move_type & blocked) == move_type)
2277 {
2278 max = maxfree[i]; 2131 max = maxfree[i];
2279 }
2280 else if (mflags & P_IS_ALIVE) 2132 else if (mflags & P_IS_ALIVE)
2281 { 2133 {
2282 for (tmp = GET_MAP_OB (mp, nx, ny); tmp != NULL; tmp = tmp->above) 2134 for (tmp = ms.bot; tmp; tmp = tmp->above)
2283 { 2135 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)
2284 if ((QUERY_FLAG (tmp, FLAG_MONSTER) || tmp->type == PLAYER) && (tmp != exclude || (tmp->head && tmp->head != exclude))) 2136 && (tmp != exclude || (tmp->head && tmp->head != exclude)))
2285 {
2286 break; 2137 break;
2287 } 2138
2288 }
2289 if (tmp) 2139 if (tmp)
2290 {
2291 return freedir[i]; 2140 return freedir[i];
2292 }
2293 } 2141 }
2294 } 2142 }
2295 } 2143 }
2144
2296 return 0; 2145 return 0;
2297} 2146}
2298 2147
2299/* 2148/*
2300 * distance(object 1, object 2) will return the square of the 2149 * distance(object 1, object 2) will return the square of the
2301 * distance between the two given objects. 2150 * distance between the two given objects.
2302 */ 2151 */
2303
2304int 2152int
2305distance (const object *ob1, const object *ob2) 2153distance (const object *ob1, const object *ob2)
2306{ 2154{
2307 int
2308 i;
2309
2310 i = (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y); 2155 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2311 return i;
2312} 2156}
2313 2157
2314/* 2158/*
2315 * find_dir_2(delta-x,delta-y) will return a direction in which 2159 * find_dir_2(delta-x,delta-y) will return a direction in which
2316 * an object which has subtracted the x and y coordinates of another 2160 * an object which has subtracted the x and y coordinates of another
2317 * object, needs to travel toward it. 2161 * object, needs to travel toward it.
2318 */ 2162 */
2319
2320int 2163int
2321find_dir_2 (int x, int y) 2164find_dir_2 (int x, int y)
2322{ 2165{
2323 int 2166 int q;
2324 q;
2325 2167
2326 if (y) 2168 if (y)
2327 q = x * 100 / y; 2169 q = x * 100 / y;
2328 else if (x) 2170 else if (x)
2329 q = -300 * x; 2171 q = -300 * x;
2364int 2206int
2365absdir (int d) 2207absdir (int d)
2366{ 2208{
2367 while (d < 1) 2209 while (d < 1)
2368 d += 8; 2210 d += 8;
2211
2369 while (d > 8) 2212 while (d > 8)
2370 d -= 8; 2213 d -= 8;
2214
2371 return d; 2215 return d;
2372} 2216}
2373 2217
2374/* 2218/*
2375 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is 2219 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is
2377 */ 2221 */
2378 2222
2379int 2223int
2380dirdiff (int dir1, int dir2) 2224dirdiff (int dir1, int dir2)
2381{ 2225{
2382 int 2226 int d;
2383 d;
2384 2227
2385 d = abs (dir1 - dir2); 2228 d = abs (dir1 - dir2);
2386 if (d > 4) 2229 if (d > 4)
2387 d = 8 - d; 2230 d = 8 - d;
2231
2388 return d; 2232 return d;
2389} 2233}
2390 2234
2391/* peterm: 2235/* peterm:
2392 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster. 2236 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster.
2395 * This basically means that if direction is 15, then it could either go 2239 * This basically means that if direction is 15, then it could either go
2396 * direction 4, 14, or 16 to get back to where we are. 2240 * direction 4, 14, or 16 to get back to where we are.
2397 * Moved from spell_util.c to object.c with the other related direction 2241 * Moved from spell_util.c to object.c with the other related direction
2398 * functions. 2242 * functions.
2399 */ 2243 */
2400
2401int
2402 reduction_dir[SIZEOFFREE][3] = { 2244int reduction_dir[SIZEOFFREE][3] = {
2403 {0, 0, 0}, /* 0 */ 2245 {0, 0, 0}, /* 0 */
2404 {0, 0, 0}, /* 1 */ 2246 {0, 0, 0}, /* 1 */
2405 {0, 0, 0}, /* 2 */ 2247 {0, 0, 0}, /* 2 */
2406 {0, 0, 0}, /* 3 */ 2248 {0, 0, 0}, /* 3 */
2407 {0, 0, 0}, /* 4 */ 2249 {0, 0, 0}, /* 4 */
2455 * find a path to that monster that we found. If not, 2297 * find a path to that monster that we found. If not,
2456 * we don't bother going toward it. Returns 1 if we 2298 * we don't bother going toward it. Returns 1 if we
2457 * can see a direct way to get it 2299 * can see a direct way to get it
2458 * Modified to be map tile aware -.MSW 2300 * Modified to be map tile aware -.MSW
2459 */ 2301 */
2460
2461
2462int 2302int
2463can_see_monsterP (maptile *m, int x, int y, int dir) 2303can_see_monsterP (maptile *m, int x, int y, int dir)
2464{ 2304{
2465 sint16 dx, dy; 2305 sint16 dx, dy;
2466 int
2467 mflags; 2306 int mflags;
2468 2307
2469 if (dir < 0) 2308 if (dir < 0)
2470 return 0; /* exit condition: invalid direction */ 2309 return 0; /* exit condition: invalid direction */
2471 2310
2472 dx = x + freearr_x[dir]; 2311 dx = x + freearr_x[dir];
2485 return 0; 2324 return 0;
2486 2325
2487 /* yes, can see. */ 2326 /* yes, can see. */
2488 if (dir < 9) 2327 if (dir < 9)
2489 return 1; 2328 return 1;
2329
2490 return can_see_monsterP (m, x, y, reduction_dir[dir][0]) | 2330 return can_see_monsterP (m, x, y, reduction_dir[dir][0])
2491 can_see_monsterP (m, x, y, reduction_dir[dir][1]) | can_see_monsterP (m, x, y, reduction_dir[dir][2]); 2331 | can_see_monsterP (m, x, y, reduction_dir[dir][1])
2332 | can_see_monsterP (m, x, y, reduction_dir[dir][2]);
2492} 2333}
2493
2494
2495 2334
2496/* 2335/*
2497 * can_pick(picker, item): finds out if an object is possible to be 2336 * can_pick(picker, item): finds out if an object is possible to be
2498 * picked up by the picker. Returnes 1 if it can be 2337 * picked up by the picker. Returnes 1 if it can be
2499 * picked up, otherwise 0. 2338 * picked up, otherwise 0.
2510 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2349 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2511 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2350 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2512 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2351 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));
2513} 2352}
2514 2353
2515
2516/* 2354/*
2517 * create clone from object to another 2355 * create clone from object to another
2518 */ 2356 */
2519object * 2357object *
2520object_create_clone (object *asrc) 2358object_create_clone (object *asrc)
2539 { 2377 {
2540 dst = tmp; 2378 dst = tmp;
2541 tmp->head = 0; 2379 tmp->head = 0;
2542 } 2380 }
2543 else 2381 else
2544 {
2545 tmp->head = dst; 2382 tmp->head = dst;
2546 }
2547 2383
2548 tmp->more = 0; 2384 tmp->more = 0;
2549 2385
2550 if (prev) 2386 if (prev)
2551 prev->more = tmp; 2387 prev->more = tmp;
2563/* Basically, we save the content of the string to a temp file, then call */ 2399/* Basically, we save the content of the string to a temp file, then call */
2564/* load_object on it. I admit it is a highly inefficient way to make things, */ 2400/* load_object on it. I admit it is a highly inefficient way to make things, */
2565/* but it was simple to make and allows reusing the load_object function. */ 2401/* but it was simple to make and allows reusing the load_object function. */
2566/* Remember not to use load_object_str in a time-critical situation. */ 2402/* Remember not to use load_object_str in a time-critical situation. */
2567/* Also remember that multiparts objects are not supported for now. */ 2403/* Also remember that multiparts objects are not supported for now. */
2568
2569object * 2404object *
2570load_object_str (const char *obstr) 2405load_object_str (const char *obstr)
2571{ 2406{
2572 object *op; 2407 object *op;
2573 char filename[MAX_BUF]; 2408 char filename[MAX_BUF];
2603 * returns NULL if no match. 2438 * returns NULL if no match.
2604 */ 2439 */
2605object * 2440object *
2606find_obj_by_type_subtype (const object *who, int type, int subtype) 2441find_obj_by_type_subtype (const object *who, int type, int subtype)
2607{ 2442{
2608 object *tmp;
2609
2610 for (tmp = who->inv; tmp; tmp = tmp->below) 2443 for (object *tmp = who->inv; tmp; tmp = tmp->below)
2611 if (tmp->type == type && tmp->subtype == subtype) 2444 if (tmp->type == type && tmp->subtype == subtype)
2612 return tmp; 2445 return tmp;
2613 2446
2614 return NULL; 2447 return 0;
2615} 2448}
2616 2449
2617/* If ob has a field named key, return the link from the list, 2450/* If ob has a field named key, return the link from the list,
2618 * otherwise return NULL. 2451 * otherwise return NULL.
2619 * 2452 *
2621 * do the desired thing. 2454 * do the desired thing.
2622 */ 2455 */
2623key_value * 2456key_value *
2624get_ob_key_link (const object *ob, const char *key) 2457get_ob_key_link (const object *ob, const char *key)
2625{ 2458{
2626 key_value *link;
2627
2628 for (link = ob->key_values; link != NULL; link = link->next) 2459 for (key_value *link = ob->key_values; link; link = link->next)
2629 if (link->key == key) 2460 if (link->key == key)
2630 return link; 2461 return link;
2631 2462
2632 return NULL; 2463 return 0;
2633} 2464}
2634 2465
2635/* 2466/*
2636 * Returns the value of op has an extra_field for key, or NULL. 2467 * Returns the value of op has an extra_field for key, or NULL.
2637 * 2468 *
2677 * Returns TRUE on success. 2508 * Returns TRUE on success.
2678 */ 2509 */
2679int 2510int
2680set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key) 2511set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2681{ 2512{
2682 key_value *
2683 field = NULL, *last = NULL; 2513 key_value *field = NULL, *last = NULL;
2684 2514
2685 for (field = op->key_values; field != NULL; field = field->next) 2515 for (field = op->key_values; field != NULL; field = field->next)
2686 { 2516 {
2687 if (field->key != canonical_key) 2517 if (field->key != canonical_key)
2688 { 2518 {
2716 /* IF we get here, key doesn't exist */ 2546 /* IF we get here, key doesn't exist */
2717 2547
2718 /* No field, we'll have to add it. */ 2548 /* No field, we'll have to add it. */
2719 2549
2720 if (!add_key) 2550 if (!add_key)
2721 {
2722 return FALSE; 2551 return FALSE;
2723 } 2552
2724 /* There isn't any good reason to store a null 2553 /* There isn't any good reason to store a null
2725 * value in the key/value list. If the archetype has 2554 * value in the key/value list. If the archetype has
2726 * this key, then we should also have it, so shouldn't 2555 * this key, then we should also have it, so shouldn't
2727 * be here. If user wants to store empty strings, 2556 * be here. If user wants to store empty strings,
2728 * should pass in "" 2557 * should pass in ""

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines