ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.73 by root, Wed Dec 20 01:19:11 2006 UTC vs.
Revision 1.86 by root, Tue Dec 26 08:17:58 2006 UTC

… …
141 * objects with lists are rare, and lists stay short. If not, use a 141 * objects with lists are rare, and lists stay short. If not, use a
142 * different structure or at least keep the lists sorted... 142 * different structure or at least keep the lists sorted...
143 */ 143 */
144 144
145 /* For each field in wants, */ 145 /* For each field in wants, */
146 for (wants_field = wants->key_values; wants_field != NULL; wants_field = wants_field->next) 146 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)
147 { 147 {
148 key_value *has_field; 148 key_value *has_field;
149 149
150 /* Look for a field in has with the same key. */ 150 /* Look for a field in has with the same key. */
151 has_field = get_ob_key_link (has, wants_field->key); 151 has_field = get_ob_key_link (has, wants_field->key);
… …
221 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 221 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
222 222
223 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 223 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
224 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 224 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
225 225
226 if ((ob1->flags ^ ob2->flags).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any () 226 if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any ()
227 || ob1->arch != ob2->arch 227 || ob1->arch != ob2->arch
228 || ob1->name != ob2->name 228 || ob1->name != ob2->name
229 || ob1->title != ob2->title 229 || ob1->title != ob2->title
230 || ob1->msg != ob2->msg 230 || ob1->msg != ob2->msg
231 || ob1->weight != ob2->weight 231 || ob1->weight != ob2->weight
… …
352 op = op->env; 352 op = op->env;
353 return op; 353 return op;
354} 354}
355 355
356/* 356/*
357 * Eneq(@csd.uu.se): Since we can have items buried in a character we need
358 * a better check. We basically keeping traversing up until we can't
359 * or find a player.
360 */
361
362object *
363is_player_inv (object *op)
364{
365 for (; op != NULL && op->type != PLAYER; op = op->env)
366 if (op->env == op)
367 op->env = NULL;
368 return op;
369}
370
371/*
372 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump. 357 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
373 * Some error messages. 358 * Some error messages.
374 * The result of the dump is stored in the static global errmsg array. 359 * The result of the dump is stored in the static global errmsg array.
375 */ 360 */
376 361
… …
379{ 364{
380 if (!op) 365 if (!op)
381 return strdup ("[NULLOBJ]"); 366 return strdup ("[NULLOBJ]");
382 367
383 object_freezer freezer; 368 object_freezer freezer;
384 save_object (freezer, op, 3); 369 save_object (freezer, op, 1);
385 return freezer.as_string (); 370 return freezer.as_string ();
386} 371}
387 372
388/* 373/*
389 * get_nearest_part(multi-object, object 2) returns the part of the 374 * get_nearest_part(multi-object, object 2) returns the part of the
… …
482 } 467 }
483 468
484 op->key_values = 0; 469 op->key_values = 0;
485} 470}
486 471
487void object::clear ()
488{
489 attachable_base::clear ();
490
491 free_key_values (this);
492
493 owner = 0;
494 name = 0;
495 name_pl = 0;
496 title = 0;
497 race = 0;
498 slaying = 0;
499 skill = 0;
500 msg = 0;
501 lore = 0;
502 custom_name = 0;
503 materialname = 0;
504 contr = 0;
505 below = 0;
506 above = 0;
507 inv = 0;
508 container = 0;
509 env = 0;
510 more = 0;
511 head = 0;
512 map = 0;
513 active_next = 0;
514 active_prev = 0;
515
516 memset (static_cast<object_pod *>(this), 0, sizeof (object_pod));
517
518 SET_FLAG (this, FLAG_REMOVED);
519
520 /* What is not cleared is next, prev, and count */
521
522 expmul = 1.0;
523 face = blank_face;
524
525 if (settings.casting_time)
526 casting_time = -1;
527}
528
529/* 472/*
530 * copy_to first frees everything allocated by the dst object, 473 * copy_to first frees everything allocated by the dst object,
531 * and then copies the contents of itself into the second 474 * and then copies the contents of itself into the second
532 * object, allocating what needs to be allocated. Basically, any 475 * object, allocating what needs to be allocated. Basically, any
533 * data that is malloc'd needs to be re-malloc/copied. Otherwise, 476 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
… …
539{ 482{
540 bool is_freed = QUERY_FLAG (dst, FLAG_FREED); 483 bool is_freed = QUERY_FLAG (dst, FLAG_FREED);
541 bool is_removed = QUERY_FLAG (dst, FLAG_REMOVED); 484 bool is_removed = QUERY_FLAG (dst, FLAG_REMOVED);
542 485
543 *(object_copy *)dst = *this; 486 *(object_copy *)dst = *this;
544 *(object_pod *)dst = *this;
545
546 if (self || cb)
547 INVOKE_OBJECT (CLONE, this, ARG_OBJECT (dst));
548 487
549 if (is_freed) 488 if (is_freed)
550 SET_FLAG (dst, FLAG_FREED); 489 SET_FLAG (dst, FLAG_FREED);
551 490
552 if (is_removed) 491 if (is_removed)
… …
622 extern int arch_init; 561 extern int arch_init;
623 562
624 /* No reason putting the archetypes objects on the speed list, 563 /* No reason putting the archetypes objects on the speed list,
625 * since they never really need to be updated. 564 * since they never really need to be updated.
626 */ 565 */
627
628 if (QUERY_FLAG (op, FLAG_FREED) && op->speed) 566 if (QUERY_FLAG (op, FLAG_FREED) && op->speed)
629 { 567 {
630 LOG (llevError, "Object %s is freed but has speed.\n", &op->name); 568 LOG (llevError, "Object %s is freed but has speed.\n", &op->name);
631#ifdef MANY_CORES
632 abort ();
633#else
634 op->speed = 0; 569 op->speed = 0;
635#endif
636 } 570 }
637 571
638 if (arch_init) 572 if (arch_init)
639 return; 573 return;
640 574
… …
709 op->active_next = NULL; 643 op->active_next = NULL;
710 op->active_prev = NULL; 644 op->active_prev = NULL;
711} 645}
712 646
713/* 647/*
714 * update_object() updates the array which represents the map. 648 * update_object() updates the the map.
715 * It takes into account invisible objects (and represent squares covered 649 * It takes into account invisible objects (and represent squares covered
716 * by invisible objects by whatever is below them (unless it's another 650 * by invisible objects by whatever is below them (unless it's another
717 * invisible object, etc...) 651 * invisible object, etc...)
718 * If the object being updated is beneath a player, the look-window 652 * If the object being updated is beneath a player, the look-window
719 * of that player is updated (this might be a suboptimal way of 653 * of that player is updated (this might be a suboptimal way of
720 * updating that window, though, since update_object() is called _often_) 654 * updating that window, though, since update_object() is called _often_)
721 * 655 *
722 * action is a hint of what the caller believes need to be done. 656 * action is a hint of what the caller believes need to be done.
723 * For example, if the only thing that has changed is the face (due to
724 * an animation), we don't need to call update_position until that actually
725 * comes into view of a player. OTOH, many other things, like addition/removal
726 * of walls or living creatures may need us to update the flags now.
727 * current action are: 657 * current action are:
728 * UP_OBJ_INSERT: op was inserted 658 * UP_OBJ_INSERT: op was inserted
729 * UP_OBJ_REMOVE: op was removed 659 * UP_OBJ_REMOVE: op was removed
730 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update 660 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update
731 * as that is easier than trying to look at what may have changed. 661 * as that is easier than trying to look at what may have changed.
732 * UP_OBJ_FACE: only the objects face has changed. 662 * UP_OBJ_FACE: only the objects face has changed.
733 */ 663 */
734
735void 664void
736update_object (object *op, int action) 665update_object (object *op, int action)
737{ 666{
738 int update_now = 0, flags;
739 MoveType move_on, move_off, move_block, move_slow; 667 MoveType move_on, move_off, move_block, move_slow;
740 668
741 if (op == NULL) 669 if (op == NULL)
742 { 670 {
743 /* this should never happen */ 671 /* this should never happen */
744 LOG (llevDebug, "update_object() called for NULL object.\n"); 672 LOG (llevDebug, "update_object() called for NULL object.\n");
745 return; 673 return;
746 } 674 }
747 675
748 if (op->env != NULL) 676 if (op->env)
749 { 677 {
750 /* Animation is currently handled by client, so nothing 678 /* Animation is currently handled by client, so nothing
751 * to do in this case. 679 * to do in this case.
752 */ 680 */
753 return; 681 return;
… …
758 */ 686 */
759 if (!op->map || op->map->in_memory == MAP_SAVING) 687 if (!op->map || op->map->in_memory == MAP_SAVING)
760 return; 688 return;
761 689
762 /* make sure the object is within map boundaries */ 690 /* make sure the object is within map boundaries */
763 if (op->x < 0 || op->x >= MAP_WIDTH (op->map) || op->y < 0 || op->y >= MAP_HEIGHT (op->map)) 691 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
764 { 692 {
765 LOG (llevError, "update_object() called for object out of map!\n"); 693 LOG (llevError, "update_object() called for object out of map!\n");
766#ifdef MANY_CORES 694#ifdef MANY_CORES
767 abort (); 695 abort ();
768#endif 696#endif
769 return; 697 return;
770 } 698 }
771 699
772 flags = GET_MAP_FLAGS (op->map, op->x, op->y); 700 mapspace &m = op->ms ();
773 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NEED_UPDATE);
774 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
775 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
776 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
777 move_off = GET_MAP_MOVE_OFF (op->map, op->x, op->y);
778 701
702 if (m.flags_ & P_NEED_UPDATE)
703 /* nop */;
779 if (action == UP_OBJ_INSERT) 704 else if (action == UP_OBJ_INSERT)
780 { 705 {
706 // this is likely overkill, TODO: revisit (schmorp)
781 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(flags & P_BLOCKSVIEW)) 707 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
782 update_now = 1;
783
784 if (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(flags & P_NO_MAGIC)) 708 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
785 update_now = 1; 709 || (op->type == PLAYER && !(m.flags_ & P_PLAYER))
786 710 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
711 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
787 if (QUERY_FLAG (op, FLAG_DAMNED) && !(flags & P_NO_CLERIC)) 712 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
788 update_now = 1;
789
790 if (QUERY_FLAG (op, FLAG_ALIVE) && !(flags & P_IS_ALIVE))
791 update_now = 1;
792
793 if (op->type == SAFE_GROUND && !(flags & P_SAFE))
794 update_now = 1;
795
796 if ((move_on | op->move_on) != move_on) 713 || (m.move_on | op->move_on ) != m.move_on
797 update_now = 1;
798
799 if ((move_off | op->move_off) != move_off) 714 || (m.move_off | op->move_off ) != m.move_off
800 update_now = 1; 715 || (m.move_slow | op->move_slow) != m.move_slow
801
802 /* This isn't perfect, but I don't expect a lot of objects to 716 /* This isn't perfect, but I don't expect a lot of objects to
803 * to have move_allow right now. 717 * to have move_allow right now.
804 */ 718 */
805 if (((move_block | op->move_block) & ~op->move_allow) != move_block) 719 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
806 update_now = 1; 720 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
807 721 m.flags_ = P_NEED_UPDATE;
808 if ((move_slow | op->move_slow) != move_slow)
809 update_now = 1;
810 } 722 }
811
812 /* if the object is being removed, we can't make intelligent 723 /* if the object is being removed, we can't make intelligent
813 * decisions, because remove_ob can't really pass the object 724 * decisions, because remove_ob can't really pass the object
814 * that is being removed. 725 * that is being removed.
815 */ 726 */
816 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 727 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
817 update_now = 1; 728 m.flags_ = P_NEED_UPDATE;
818 else if (action == UP_OBJ_FACE) 729 else if (action == UP_OBJ_FACE)
819 /* Nothing to do for that case */ ; 730 /* Nothing to do for that case */ ;
820 else 731 else
821 LOG (llevError, "update_object called with invalid action: %d\n", action); 732 LOG (llevError, "update_object called with invalid action: %d\n", action);
822 733
823 if (update_now)
824 {
825 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NO_ERROR | P_NEED_UPDATE);
826 update_position (op->map, op->x, op->y);
827 }
828
829 if (op->more != NULL) 734 if (op->more)
830 update_object (op->more, action); 735 update_object (op->more, action);
831} 736}
832 737
833object::vector object::mortals;
834object::vector object::objects; // not yet used 738object::vector object::objects; // not yet used
835object *object::first; 739object *object::first;
836
837void object::free_mortals ()
838{
839 for (AUTODECL (i, mortals.begin ()); i != mortals.end ();)
840 if ((*i)->refcnt)
841 ++i; // further delay freeing
842 else
843 {
844 delete *i;
845 mortals.erase (i);
846 }
847}
848 740
849object::object () 741object::object ()
850{ 742{
851 SET_FLAG (this, FLAG_REMOVED); 743 SET_FLAG (this, FLAG_REMOVED);
852 744
… …
901 * this function to succeed. 793 * this function to succeed.
902 * 794 *
903 * If destroy_inventory is set, free inventory as well. Else drop items in 795 * If destroy_inventory is set, free inventory as well. Else drop items in
904 * inventory to the ground. 796 * inventory to the ground.
905 */ 797 */
906void object::destroy (bool destroy_inventory) 798void
799object::do_destroy ()
907{ 800{
908 if (QUERY_FLAG (this, FLAG_FREED)) 801 attachable::do_destroy ();
802
803 if (flag [FLAG_IS_LINKED])
804 remove_button_link (this);
805
806 if (flag [FLAG_FRIENDLY])
807 remove_friendly_object (this);
808
809 if (!flag [FLAG_REMOVED])
810 remove ();
811
812 if (flag [FLAG_FREED])
909 return; 813 return;
910 814
911 if (QUERY_FLAG (this, FLAG_FRIENDLY)) 815 flag [FLAG_FREED] = 1;
912 remove_friendly_object (this);
913
914 if (!QUERY_FLAG (this, FLAG_REMOVED))
915 remove ();
916
917 SET_FLAG (this, FLAG_FREED);
918
919 if (more)
920 {
921 more->destroy (destroy_inventory);
922 more = 0;
923 }
924
925 if (inv)
926 {
927 /* Only if the space blocks everything do we not process -
928 * if some form of movement is allowed, let objects
929 * drop on that space.
930 */
931 if (destroy_inventory || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL)
932 {
933 object *op = inv;
934
935 while (op)
936 {
937 object *tmp = op->below;
938 op->destroy (destroy_inventory);
939 op = tmp;
940 }
941 }
942 else
943 { /* Put objects in inventory onto this space */
944 object *op = inv;
945
946 while (op)
947 {
948 object *tmp = op->below;
949
950 op->remove ();
951
952 if (QUERY_FLAG (op, FLAG_STARTEQUIP)
953 || QUERY_FLAG (op, FLAG_NO_DROP) || op->type == RUNE || op->type == TRAP || QUERY_FLAG (op, FLAG_IS_A_TEMPLATE))
954 op->destroy ();
955 else
956 {
957 op->x = x;
958 op->y = y;
959 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
960 }
961
962 op = tmp;
963 }
964 }
965 }
966 816
967 // hack to ensure that freed objects still have a valid map 817 // hack to ensure that freed objects still have a valid map
968 { 818 {
969 static maptile *freed_map; // freed objects are moved here to avoid crashes 819 static maptile *freed_map; // freed objects are moved here to avoid crashes
970 820
… …
982 map = freed_map; 832 map = freed_map;
983 x = 1; 833 x = 1;
984 y = 1; 834 y = 1;
985 } 835 }
986 836
837 more = 0;
838 head = 0;
839 inv = 0;
840
987 // clear those pointers that likely might have circular references to us 841 // clear those pointers that likely might have circular references to us
988 owner = 0; 842 owner = 0;
989 enemy = 0; 843 enemy = 0;
990 attacked_by = 0; 844 attacked_by = 0;
991 845
… …
995 /* Remove object from the active list */ 849 /* Remove object from the active list */
996 speed = 0; 850 speed = 0;
997 update_ob_speed (this); 851 update_ob_speed (this);
998 852
999 unlink (); 853 unlink ();
854}
1000 855
1001 mortals.push_back (this); 856/*
857 * Remove and free all objects in the inventory of the given object.
858 * object.c ?
859 */
860void
861object::destroy_inv (bool drop_to_ground)
862{
863 if (!inv)
864 return;
865
866 /* Only if the space blocks everything do we not process -
867 * if some form of movement is allowed, let objects
868 * drop on that space.
869 */
870 if (!drop_to_ground || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL)
871 {
872 while (inv)
873 {
874 inv->destroy_inv (drop_to_ground);
875 inv->destroy ();
876 }
877 }
878 else
879 { /* Put objects in inventory onto this space */
880 while (inv)
881 {
882 object *op = inv;
883
884 if (op->flag [FLAG_STARTEQUIP]
885 || op->flag [FLAG_NO_DROP]
886 || op->type == RUNE
887 || op->type == TRAP
888 || op->flag [FLAG_IS_A_TEMPLATE])
889 op->destroy ();
890 else
891 {
892 op->remove ();
893 op->x = x;
894 op->y = y;
895 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
896 }
897 }
898 }
899}
900
901void
902object::destroy (bool destroy_inventory)
903{
904 if (destroyed ())
905 return;
906
907 if (more)
908 {
909 //TODO: non-head objects must not have inventory
910 more->destroy (destroy_inventory);
911 more = 0;
912 }
913
914 if (destroy_inventory)
915 destroy_inv (true);
916
917 attachable::destroy ();
1002} 918}
1003 919
1004/* 920/*
1005 * sub_weight() recursively (outwards) subtracts a number from the 921 * sub_weight() recursively (outwards) subtracts a number from the
1006 * weight of an object (and what is carried by it's environment(s)). 922 * weight of an object (and what is carried by it's environment(s)).
… …
1030object::remove () 946object::remove ()
1031{ 947{
1032 object *tmp, *last = 0; 948 object *tmp, *last = 0;
1033 object *otmp; 949 object *otmp;
1034 950
1035 int check_walk_off;
1036
1037 if (QUERY_FLAG (this, FLAG_REMOVED)) 951 if (QUERY_FLAG (this, FLAG_REMOVED))
1038 return; 952 return;
1039 953
1040 SET_FLAG (this, FLAG_REMOVED); 954 SET_FLAG (this, FLAG_REMOVED);
955 INVOKE_OBJECT (REMOVE, this);
1041 956
1042 if (more) 957 if (more)
1043 more->remove (); 958 more->remove ();
1044 959
1045 /* 960 /*
… …
1055 970
1056 /* NO_FIX_PLAYER is set when a great many changes are being 971 /* NO_FIX_PLAYER is set when a great many changes are being
1057 * made to players inventory. If set, avoiding the call 972 * made to players inventory. If set, avoiding the call
1058 * to save cpu time. 973 * to save cpu time.
1059 */ 974 */
1060 if ((otmp = is_player_inv (env)) != NULL && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 975 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1061 fix_player (otmp); 976 otmp->update_stats ();
1062 977
1063 if (above != NULL) 978 if (above != NULL)
1064 above->below = below; 979 above->below = below;
1065 else 980 else
1066 env->inv = below; 981 env->inv = below;
… …
1085 1000
1086 /* link the object above us */ 1001 /* link the object above us */
1087 if (above) 1002 if (above)
1088 above->below = below; 1003 above->below = below;
1089 else 1004 else
1090 SET_MAP_TOP (map, x, y, below); /* we were top, set new top */ 1005 map->at (x, y).top = below; /* we were top, set new top */
1091 1006
1092 /* Relink the object below us, if there is one */ 1007 /* Relink the object below us, if there is one */
1093 if (below) 1008 if (below)
1094 below->above = above; 1009 below->above = above;
1095 else 1010 else
… …
1107 dump = dump_object (GET_MAP_OB (map, x, y)); 1022 dump = dump_object (GET_MAP_OB (map, x, y));
1108 LOG (llevError, "%s\n", dump); 1023 LOG (llevError, "%s\n", dump);
1109 free (dump); 1024 free (dump);
1110 } 1025 }
1111 1026
1112 SET_MAP_OB (map, x, y, above); /* goes on above it. */ 1027 map->at (x, y).bot = above; /* goes on above it. */
1113 } 1028 }
1114 1029
1115 above = 0; 1030 above = 0;
1116 below = 0; 1031 below = 0;
1117 1032
1118 if (map->in_memory == MAP_SAVING) 1033 if (map->in_memory == MAP_SAVING)
1119 return; 1034 return;
1120 1035
1121 check_walk_off = !QUERY_FLAG (this, FLAG_NO_APPLY); 1036 int check_walk_off = !flag [FLAG_NO_APPLY];
1122 1037
1123 for (tmp = GET_MAP_OB (map, x, y); tmp; tmp = tmp->above) 1038 for (tmp = GET_MAP_OB (map, x, y); tmp; tmp = tmp->above)
1124 { 1039 {
1125 /* No point updating the players look faces if he is the object 1040 /* No point updating the players look faces if he is the object
1126 * being removed. 1041 * being removed.
… …
1132 * removed (most likely destroyed), update the player view 1047 * removed (most likely destroyed), update the player view
1133 * appropriately. 1048 * appropriately.
1134 */ 1049 */
1135 if (tmp->container == this) 1050 if (tmp->container == this)
1136 { 1051 {
1137 CLEAR_FLAG (this, FLAG_APPLIED); 1052 flag [FLAG_APPLIED] = 0;
1138 tmp->container = 0; 1053 tmp->container = 0;
1139 } 1054 }
1140 1055
1056 if (tmp->contr->ns)
1141 tmp->contr->socket->floorbox_update (); 1057 tmp->contr->ns->floorbox_update ();
1142 } 1058 }
1143 1059
1144 /* See if player moving off should effect something */ 1060 /* See if player moving off should effect something */
1145 if (check_walk_off 1061 if (check_walk_off
1146 && ((move_type & tmp->move_off) 1062 && ((move_type & tmp->move_off)
… …
1160 last = tmp; 1076 last = tmp;
1161 } 1077 }
1162 1078
1163 /* last == NULL of there are no objects on this space */ 1079 /* last == NULL of there are no objects on this space */
1164 if (!last) 1080 if (!last)
1165 { 1081 map->at (x, y).flags_ = P_NEED_UPDATE;
1166 /* set P_NEED_UPDATE, otherwise update_position will complain. In theory,
1167 * we could preserve the flags (GET_MAP_FLAGS), but update_position figures
1168 * those out anyways, and if there are any flags set right now, they won't
1169 * be correct anyways.
1170 */
1171 SET_MAP_FLAGS (map, x, y, P_NEED_UPDATE);
1172 update_position (map, x, y);
1173 }
1174 else 1082 else
1175 update_object (last, UP_OBJ_REMOVE); 1083 update_object (last, UP_OBJ_REMOVE);
1176 1084
1177 if (QUERY_FLAG (this, FLAG_BLOCKSVIEW) || glow_radius) 1085 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1178 update_all_los (map, x, y); 1086 update_all_los (map, x, y);
1179 } 1087 }
1180} 1088}
1181 1089
1182/* 1090/*
… …
1191merge_ob (object *op, object *top) 1099merge_ob (object *op, object *top)
1192{ 1100{
1193 if (!op->nrof) 1101 if (!op->nrof)
1194 return 0; 1102 return 0;
1195 1103
1196 if (top == NULL) 1104 if (top)
1197 for (top = op; top != NULL && top->above != NULL; top = top->above); 1105 for (top = op; top && top->above; top = top->above)
1106 ;
1198 1107
1199 for (; top != NULL; top = top->below) 1108 for (; top; top = top->below)
1200 { 1109 {
1201 if (top == op) 1110 if (top == op)
1202 continue; 1111 continue;
1203 1112
1204 if (object::can_merge (op, top)) 1113 if (object::can_merge (op, top))
… …
1254 * Return value: 1163 * Return value:
1255 * new object if 'op' was merged with other object 1164 * new object if 'op' was merged with other object
1256 * NULL if 'op' was destroyed 1165 * NULL if 'op' was destroyed
1257 * just 'op' otherwise 1166 * just 'op' otherwise
1258 */ 1167 */
1259
1260object * 1168object *
1261insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1169insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1262{ 1170{
1263 object *tmp, *top, *floor = NULL; 1171 object *tmp, *top, *floor = NULL;
1264 sint16 x, y; 1172 sint16 x, y;
… …
1298 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", dump); 1206 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", dump);
1299 free (dump); 1207 free (dump);
1300 return op; 1208 return op;
1301 } 1209 }
1302 1210
1303 if (op->more != NULL) 1211 if (op->more)
1304 { 1212 {
1305 /* The part may be on a different map. */ 1213 /* The part may be on a different map. */
1306 1214
1307 object *more = op->more; 1215 object *more = op->more;
1308 1216
… …
1324 if (insert_ob_in_map (more, more->map, originator, flag) == NULL) 1232 if (insert_ob_in_map (more, more->map, originator, flag) == NULL)
1325 { 1233 {
1326 if (!op->head) 1234 if (!op->head)
1327 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n"); 1235 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n");
1328 1236
1329 return NULL; 1237 return 0;
1330 } 1238 }
1331 } 1239 }
1332 1240
1333 CLEAR_FLAG (op, FLAG_REMOVED); 1241 CLEAR_FLAG (op, FLAG_REMOVED);
1334 1242
… …
1368 op->below = originator->below; 1276 op->below = originator->below;
1369 1277
1370 if (op->below) 1278 if (op->below)
1371 op->below->above = op; 1279 op->below->above = op;
1372 else 1280 else
1373 SET_MAP_OB (op->map, op->x, op->y, op); 1281 op->ms ().bot = op;
1374 1282
1375 /* since *below* originator, no need to update top */ 1283 /* since *below* originator, no need to update top */
1376 originator->below = op; 1284 originator->below = op;
1377 } 1285 }
1378 else 1286 else
… …
1424 * If INS_ON_TOP is used, don't do this processing 1332 * If INS_ON_TOP is used, don't do this processing
1425 * Need to find the object that in fact blocks view, otherwise 1333 * Need to find the object that in fact blocks view, otherwise
1426 * stacking is a bit odd. 1334 * stacking is a bit odd.
1427 */ 1335 */
1428 if (!(flag & INS_ON_TOP) && 1336 if (!(flag & INS_ON_TOP) &&
1429 (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_BLOCKSVIEW) && (op->face && !op->face->visibility)) 1337 (get_map_flags (op->map, 0, op->x, op->y, 0, 0) & P_BLOCKSVIEW) && (op->face && !op->face->visibility))
1430 { 1338 {
1431 for (last = top; last != floor; last = last->below) 1339 for (last = top; last != floor; last = last->below)
1432 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1340 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1433 break; 1341 break;
1434 /* Check to see if we found the object that blocks view, 1342 /* Check to see if we found the object that blocks view,
… …
1457 1365
1458 if (op->above) 1366 if (op->above)
1459 op->above->below = op; 1367 op->above->below = op;
1460 1368
1461 op->below = NULL; 1369 op->below = NULL;
1462 SET_MAP_OB (op->map, op->x, op->y, op); 1370 op->ms ().bot = op;
1463 } 1371 }
1464 else 1372 else
1465 { /* get inserted into the stack above top */ 1373 { /* get inserted into the stack above top */
1466 op->above = top->above; 1374 op->above = top->above;
1467 1375
… …
1471 op->below = top; 1379 op->below = top;
1472 top->above = op; 1380 top->above = op;
1473 } 1381 }
1474 1382
1475 if (op->above == NULL) 1383 if (op->above == NULL)
1476 SET_MAP_TOP (op->map, op->x, op->y, op); 1384 op->ms ().top = op;
1477 } /* else not INS_BELOW_ORIGINATOR */ 1385 } /* else not INS_BELOW_ORIGINATOR */
1478 1386
1479 if (op->type == PLAYER) 1387 if (op->type == PLAYER)
1480 op->contr->do_los = 1; 1388 op->contr->do_los = 1;
1481 1389
1482 /* If we have a floor, we know the player, if any, will be above 1390 /* If we have a floor, we know the player, if any, will be above
1483 * it, so save a few ticks and start from there. 1391 * it, so save a few ticks and start from there.
1484 */ 1392 */
1485 if (!(flag & INS_MAP_LOAD)) 1393 if (!(flag & INS_MAP_LOAD))
1486 for (tmp = floor ? floor : GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1394 if (object *pl = op->ms ().player ())
1487 if (tmp->type == PLAYER) 1395 if (pl->contr->ns)
1488 tmp->contr->socket->floorbox_update (); 1396 pl->contr->ns->floorbox_update ();
1489 1397
1490 /* If this object glows, it may affect lighting conditions that are 1398 /* If this object glows, it may affect lighting conditions that are
1491 * visible to others on this map. But update_all_los is really 1399 * visible to others on this map. But update_all_los is really
1492 * an inefficient way to do this, as it means los for all players 1400 * an inefficient way to do this, as it means los for all players
1493 * on the map will get recalculated. The players could very well 1401 * on the map will get recalculated. The players could very well
1494 * be far away from this change and not affected in any way - 1402 * be far away from this change and not affected in any way -
1495 * this should get redone to only look for players within range, 1403 * this should get redone to only look for players within range,
1496 * or just updating the P_NEED_UPDATE for spaces within this area 1404 * or just updating the P_NEED_UPDATE for spaces within this area
1497 * of effect may be sufficient. 1405 * of effect may be sufficient.
1498 */ 1406 */
1499 if (MAP_DARKNESS (op->map) && (op->glow_radius != 0)) 1407 if (op->map->darkness && (op->glow_radius != 0))
1500 update_all_los (op->map, op->x, op->y); 1408 update_all_los (op->map, op->x, op->y);
1501 1409
1502 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1410 /* updates flags (blocked, alive, no magic, etc) for this map space */
1503 update_object (op, UP_OBJ_INSERT); 1411 update_object (op, UP_OBJ_INSERT);
1412
1413 INVOKE_OBJECT (INSERT, op);
1504 1414
1505 /* Don't know if moving this to the end will break anything. However, 1415 /* Don't know if moving this to the end will break anything. However,
1506 * we want to have floorbox_update called before calling this. 1416 * we want to have floorbox_update called before calling this.
1507 * 1417 *
1508 * check_move_on() must be after this because code called from 1418 * check_move_on() must be after this because code called from
… …
1513 1423
1514 /* if this is not the head or flag has been passed, don't check walk on status */ 1424 /* if this is not the head or flag has been passed, don't check walk on status */
1515 if (!(flag & INS_NO_WALK_ON) && !op->head) 1425 if (!(flag & INS_NO_WALK_ON) && !op->head)
1516 { 1426 {
1517 if (check_move_on (op, originator)) 1427 if (check_move_on (op, originator))
1518 return NULL; 1428 return 0;
1519 1429
1520 /* If we are a multi part object, lets work our way through the check 1430 /* If we are a multi part object, lets work our way through the check
1521 * walk on's. 1431 * walk on's.
1522 */ 1432 */
1523 for (tmp = op->more; tmp != NULL; tmp = tmp->more) 1433 for (tmp = op->more; tmp != NULL; tmp = tmp->more)
1524 if (check_move_on (tmp, originator)) 1434 if (check_move_on (tmp, originator))
1525 return NULL; 1435 return 0;
1526 } 1436 }
1527 1437
1528 return op; 1438 return op;
1529} 1439}
1530 1440
1531/* this function inserts an object in the map, but if it 1441/* this function inserts an object in the map, but if it
1532 * finds an object of its own type, it'll remove that one first. 1442 * finds an object of its own type, it'll remove that one first.
1533 * op is the object to insert it under: supplies x and the map. 1443 * op is the object to insert it under: supplies x and the map.
1534 */ 1444 */
1535void 1445void
1536replace_insert_ob_in_map (const char *arch_string, object *op) 1446replace_insert_ob_in_map (const char *arch_string, object *op)
1537{ 1447{
1538 object * 1448 object *tmp, *tmp1;
1539 tmp;
1540 object *
1541 tmp1;
1542 1449
1543 /* first search for itself and remove any old instances */ 1450 /* first search for itself and remove any old instances */
1544 1451
1545 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1452 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above)
1546 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */ 1453 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */
… …
1604 1511
1605object * 1512object *
1606decrease_ob_nr (object *op, uint32 i) 1513decrease_ob_nr (object *op, uint32 i)
1607{ 1514{
1608 object *tmp; 1515 object *tmp;
1609 player *pl;
1610 1516
1611 if (i == 0) /* objects with op->nrof require this check */ 1517 if (i == 0) /* objects with op->nrof require this check */
1612 return op; 1518 return op;
1613 1519
1614 if (i > op->nrof) 1520 if (i > op->nrof)
… …
1619 else if (op->env) 1525 else if (op->env)
1620 { 1526 {
1621 /* is this object in the players inventory, or sub container 1527 /* is this object in the players inventory, or sub container
1622 * therein? 1528 * therein?
1623 */ 1529 */
1624 tmp = is_player_inv (op->env); 1530 tmp = op->in_player ();
1625 /* nope. Is this a container the player has opened? 1531 /* nope. Is this a container the player has opened?
1626 * If so, set tmp to that player. 1532 * If so, set tmp to that player.
1627 * IMO, searching through all the players will mostly 1533 * IMO, searching through all the players will mostly
1628 * likely be quicker than following op->env to the map, 1534 * likely be quicker than following op->env to the map,
1629 * and then searching the map for a player. 1535 * and then searching the map for a player.
1630 */ 1536 */
1631 if (!tmp) 1537 if (!tmp)
1632 { 1538 for_all_players (pl)
1633 for (pl = first_player; pl; pl = pl->next)
1634 if (pl->ob->container == op->env) 1539 if (pl->ob->container == op->env)
1635 { 1540 {
1636 tmp = pl->ob; 1541 tmp = pl->ob;
1637 break; 1542 break;
1638 } 1543 }
1639 }
1640 1544
1641 if (i < op->nrof) 1545 if (i < op->nrof)
1642 { 1546 {
1643 sub_weight (op->env, op->weight * i); 1547 sub_weight (op->env, op->weight * i);
1644 op->nrof -= i; 1548 op->nrof -= i;
… …
1777 add_weight (this, op->weight * op->nrof); 1681 add_weight (this, op->weight * op->nrof);
1778 } 1682 }
1779 else 1683 else
1780 add_weight (this, (op->weight + op->carrying)); 1684 add_weight (this, (op->weight + op->carrying));
1781 1685
1782 otmp = is_player_inv (this); 1686 otmp = this->in_player ();
1783 if (otmp && otmp->contr) 1687 if (otmp && otmp->contr)
1784 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1688 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1785 fix_player (otmp); 1689 otmp->update_stats ();
1786 1690
1787 op->map = NULL; 1691 op->map = 0;
1788 op->env = this; 1692 op->env = this;
1789 op->above = NULL; 1693 op->above = 0;
1790 op->below = NULL; 1694 op->below = 0;
1791 op->x = 0, op->y = 0; 1695 op->x = 0, op->y = 0;
1792 1696
1793 /* reset the light list and los of the players on the map */ 1697 /* reset the light list and los of the players on the map */
1794 if ((op->glow_radius != 0) && map) 1698 if ((op->glow_radius != 0) && map)
1795 { 1699 {
1796#ifdef DEBUG_LIGHTS 1700#ifdef DEBUG_LIGHTS
1797 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name); 1701 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1798#endif /* DEBUG_LIGHTS */ 1702#endif /* DEBUG_LIGHTS */
1799 if (MAP_DARKNESS (map)) 1703 if (map->darkness)
1800 update_all_los (map, x, y); 1704 update_all_los (map, x, y);
1801 } 1705 }
1802 1706
1803 /* Client has no idea of ordering so lets not bother ordering it here. 1707 /* Client has no idea of ordering so lets not bother ordering it here.
1804 * It sure simplifies this function... 1708 * It sure simplifies this function...
… …
1809 { 1713 {
1810 op->below = inv; 1714 op->below = inv;
1811 op->below->above = op; 1715 op->below->above = op;
1812 inv = op; 1716 inv = op;
1813 } 1717 }
1718
1719 INVOKE_OBJECT (INSERT, this);
1814 1720
1815 return op; 1721 return op;
1816} 1722}
1817 1723
1818/* 1724/*
… …
1870 1776
1871 /* The objects have to be checked from top to bottom. 1777 /* The objects have to be checked from top to bottom.
1872 * Hence, we first go to the top: 1778 * Hence, we first go to the top:
1873 */ 1779 */
1874 1780
1875 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL && tmp->above != NULL; tmp = tmp->above) 1781 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp && tmp->above; tmp = tmp->above)
1876 { 1782 {
1877 /* Trim the search when we find the first other spell effect 1783 /* Trim the search when we find the first other spell effect
1878 * this helps performance so that if a space has 50 spell objects, 1784 * this helps performance so that if a space has 50 spell objects,
1879 * we don't need to check all of them. 1785 * we don't need to check all of them.
1880 */ 1786 */
… …
1935/* 1841/*
1936 * present_arch(arch, map, x, y) searches for any objects with 1842 * present_arch(arch, map, x, y) searches for any objects with
1937 * a matching archetype at the given map and coordinates. 1843 * a matching archetype at the given map and coordinates.
1938 * The first matching object is returned, or NULL if none. 1844 * The first matching object is returned, or NULL if none.
1939 */ 1845 */
1940
1941object * 1846object *
1942present_arch (const archetype *at, maptile *m, int x, int y) 1847present_arch (const archetype *at, maptile *m, int x, int y)
1943{ 1848{
1944 object *
1945 tmp;
1946
1947 if (m == NULL || out_of_map (m, x, y)) 1849 if (m == NULL || out_of_map (m, x, y))
1948 { 1850 {
1949 LOG (llevError, "Present_arch called outside map.\n"); 1851 LOG (llevError, "Present_arch called outside map.\n");
1950 return NULL; 1852 return NULL;
1951 } 1853 }
1854
1952 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1855 for (object *tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above)
1953 if (tmp->arch == at) 1856 if (tmp->arch == at)
1954 return tmp; 1857 return tmp;
1858
1955 return NULL; 1859 return NULL;
1956} 1860}
1957 1861
1958/* 1862/*
1959 * present(type, map, x, y) searches for any objects with 1863 * present(type, map, x, y) searches for any objects with
1960 * a matching type variable at the given map and coordinates. 1864 * a matching type variable at the given map and coordinates.
1961 * The first matching object is returned, or NULL if none. 1865 * The first matching object is returned, or NULL if none.
1962 */ 1866 */
1963
1964object * 1867object *
1965present (unsigned char type, maptile *m, int x, int y) 1868present (unsigned char type, maptile *m, int x, int y)
1966{ 1869{
1967 object *
1968 tmp;
1969
1970 if (out_of_map (m, x, y)) 1870 if (out_of_map (m, x, y))
1971 { 1871 {
1972 LOG (llevError, "Present called outside map.\n"); 1872 LOG (llevError, "Present called outside map.\n");
1973 return NULL; 1873 return NULL;
1974 } 1874 }
1875
1975 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1876 for (object *tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above)
1976 if (tmp->type == type) 1877 if (tmp->type == type)
1977 return tmp; 1878 return tmp;
1879
1978 return NULL; 1880 return NULL;
1979} 1881}
1980 1882
1981/* 1883/*
1982 * present_in_ob(type, object) searches for any objects with 1884 * present_in_ob(type, object) searches for any objects with
1983 * a matching type variable in the inventory of the given object. 1885 * a matching type variable in the inventory of the given object.
1984 * The first matching object is returned, or NULL if none. 1886 * The first matching object is returned, or NULL if none.
1985 */ 1887 */
1986
1987object * 1888object *
1988present_in_ob (unsigned char type, const object *op) 1889present_in_ob (unsigned char type, const object *op)
1989{ 1890{
1990 object *
1991 tmp;
1992
1993 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1891 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
1994 if (tmp->type == type) 1892 if (tmp->type == type)
1995 return tmp; 1893 return tmp;
1894
1996 return NULL; 1895 return NULL;
1997} 1896}
1998 1897
1999/* 1898/*
2000 * present_in_ob (type, str, object) searches for any objects with 1899 * present_in_ob (type, str, object) searches for any objects with
… …
2008 * str is the string to match against. Note that we match against 1907 * str is the string to match against. Note that we match against
2009 * the object name, not the archetype name. this is so that the 1908 * the object name, not the archetype name. this is so that the
2010 * spell code can use one object type (force), but change it's name 1909 * spell code can use one object type (force), but change it's name
2011 * to be unique. 1910 * to be unique.
2012 */ 1911 */
2013
2014object * 1912object *
2015present_in_ob_by_name (int type, const char *str, const object *op) 1913present_in_ob_by_name (int type, const char *str, const object *op)
2016{ 1914{
2017 object *
2018 tmp;
2019
2020 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1915 for (object *tmp = op->inv; tmp; tmp = tmp->below)
2021 {
2022 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name))) 1916 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name)))
2023 return tmp; 1917 return tmp;
2024 } 1918
2025 return NULL; 1919 return 0;
2026} 1920}
2027 1921
2028/* 1922/*
2029 * present_arch_in_ob(archetype, object) searches for any objects with 1923 * present_arch_in_ob(archetype, object) searches for any objects with
2030 * a matching archetype in the inventory of the given object. 1924 * a matching archetype in the inventory of the given object.
2031 * The first matching object is returned, or NULL if none. 1925 * The first matching object is returned, or NULL if none.
2032 */ 1926 */
2033
2034object * 1927object *
2035present_arch_in_ob (const archetype *at, const object *op) 1928present_arch_in_ob (const archetype *at, const object *op)
2036{ 1929{
2037 object *
2038 tmp;
2039
2040 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1930 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2041 if (tmp->arch == at) 1931 if (tmp->arch == at)
2042 return tmp; 1932 return tmp;
1933
2043 return NULL; 1934 return NULL;
2044} 1935}
2045 1936
2046/* 1937/*
2047 * activate recursively a flag on an object inventory 1938 * activate recursively a flag on an object inventory
2048 */ 1939 */
2049void 1940void
2050flag_inv (object *op, int flag) 1941flag_inv (object *op, int flag)
2051{ 1942{
2052 object *
2053 tmp;
2054
2055 if (op->inv) 1943 if (op->inv)
2056 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1944 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2057 { 1945 {
2058 SET_FLAG (tmp, flag); 1946 SET_FLAG (tmp, flag);
2059 flag_inv (tmp, flag); 1947 flag_inv (tmp, flag);
2060 } 1948 }
2061} /* 1949}
1950
1951/*
2062 * desactivate recursively a flag on an object inventory 1952 * deactivate recursively a flag on an object inventory
2063 */ 1953 */
2064void 1954void
2065unflag_inv (object *op, int flag) 1955unflag_inv (object *op, int flag)
2066{ 1956{
2067 object *
2068 tmp;
2069
2070 if (op->inv) 1957 if (op->inv)
2071 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1958 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2072 { 1959 {
2073 CLEAR_FLAG (tmp, flag); 1960 CLEAR_FLAG (tmp, flag);
2074 unflag_inv (tmp, flag); 1961 unflag_inv (tmp, flag);
2075 } 1962 }
2076} 1963}
… …
2079 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in 1966 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in
2080 * all it's inventory (recursively). 1967 * all it's inventory (recursively).
2081 * If checksums are used, a player will get set_cheat called for 1968 * If checksums are used, a player will get set_cheat called for
2082 * him/her-self and all object carried by a call to this function. 1969 * him/her-self and all object carried by a call to this function.
2083 */ 1970 */
2084
2085void 1971void
2086set_cheat (object *op) 1972set_cheat (object *op)
2087{ 1973{
2088 SET_FLAG (op, FLAG_WAS_WIZ); 1974 SET_FLAG (op, FLAG_WAS_WIZ);
2089 flag_inv (op, FLAG_WAS_WIZ); 1975 flag_inv (op, FLAG_WAS_WIZ);
… …
2108 * because arch_blocked (now ob_blocked) needs to know the movement type 1994 * because arch_blocked (now ob_blocked) needs to know the movement type
2109 * to know if the space in question will block the object. We can't use 1995 * to know if the space in question will block the object. We can't use
2110 * the archetype because that isn't correct if the monster has been 1996 * the archetype because that isn't correct if the monster has been
2111 * customized, changed states, etc. 1997 * customized, changed states, etc.
2112 */ 1998 */
2113
2114int 1999int
2115find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop) 2000find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)
2116{ 2001{
2117 int
2118 i,
2119 index = 0, flag; 2002 int index = 0, flag;
2120 static int
2121 altern[SIZEOFFREE]; 2003 int altern[SIZEOFFREE];
2122 2004
2123 for (i = start; i < stop; i++) 2005 for (int i = start; i < stop; i++)
2124 { 2006 {
2125 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]); 2007 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]);
2126 if (!flag) 2008 if (!flag)
2127 altern[index++] = i; 2009 altern [index++] = i;
2128 2010
2129 /* Basically, if we find a wall on a space, we cut down the search size. 2011 /* Basically, if we find a wall on a space, we cut down the search size.
2130 * In this way, we won't return spaces that are on another side of a wall. 2012 * In this way, we won't return spaces that are on another side of a wall.
2131 * This mostly work, but it cuts down the search size in all directions - 2013 * This mostly work, but it cuts down the search size in all directions -
2132 * if the space being examined only has a wall to the north and empty 2014 * if the space being examined only has a wall to the north and empty
2133 * spaces in all the other directions, this will reduce the search space 2015 * spaces in all the other directions, this will reduce the search space
2134 * to only the spaces immediately surrounding the target area, and 2016 * to only the spaces immediately surrounding the target area, and
2135 * won't look 2 spaces south of the target space. 2017 * won't look 2 spaces south of the target space.
2136 */ 2018 */
2137 else if ((flag & AB_NO_PASS) && maxfree[i] < stop) 2019 else if ((flag & P_NO_PASS) && maxfree[i] < stop)
2138 stop = maxfree[i]; 2020 stop = maxfree[i];
2139 } 2021 }
2022
2140 if (!index) 2023 if (!index)
2141 return -1; 2024 return -1;
2025
2142 return altern[RANDOM () % index]; 2026 return altern[RANDOM () % index];
2143} 2027}
2144 2028
2145/* 2029/*
2146 * find_first_free_spot(archetype, maptile, x, y) works like 2030 * find_first_free_spot(archetype, maptile, x, y) works like
2147 * find_free_spot(), but it will search max number of squares. 2031 * find_free_spot(), but it will search max number of squares.
2148 * But it will return the first available spot, not a random choice. 2032 * But it will return the first available spot, not a random choice.
2149 * Changed 0.93.2: Have it return -1 if there is no free spot available. 2033 * Changed 0.93.2: Have it return -1 if there is no free spot available.
2150 */ 2034 */
2151
2152int 2035int
2153find_first_free_spot (const object *ob, maptile *m, int x, int y) 2036find_first_free_spot (const object *ob, maptile *m, int x, int y)
2154{ 2037{
2155 int
2156 i;
2157
2158 for (i = 0; i < SIZEOFFREE; i++) 2038 for (int i = 0; i < SIZEOFFREE; i++)
2159 {
2160 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i])) 2039 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]))
2161 return i; 2040 return i;
2162 } 2041
2163 return -1; 2042 return -1;
2164} 2043}
2165 2044
2166/* 2045/*
2167 * The function permute(arr, begin, end) randomly reorders the array 2046 * The function permute(arr, begin, end) randomly reorders the array
2168 * arr[begin..end-1]. 2047 * arr[begin..end-1].
2048 * now uses a fisher-yates shuffle, old permute was broken
2169 */ 2049 */
2170static void 2050static void
2171permute (int *arr, int begin, int end) 2051permute (int *arr, int begin, int end)
2172{ 2052{
2173 int 2053 arr += begin;
2174 i,
2175 j,
2176 tmp,
2177 len;
2178
2179 len = end - begin; 2054 end -= begin;
2180 for (i = begin; i < end; i++)
2181 {
2182 j = begin + RANDOM () % len;
2183 2055
2184 tmp = arr[i]; 2056 while (--end)
2185 arr[i] = arr[j]; 2057 swap (arr [end], arr [RANDOM () % (end + 1)]);
2186 arr[j] = tmp;
2187 }
2188} 2058}
2189 2059
2190/* new function to make monster searching more efficient, and effective! 2060/* new function to make monster searching more efficient, and effective!
2191 * This basically returns a randomized array (in the passed pointer) of 2061 * This basically returns a randomized array (in the passed pointer) of
2192 * the spaces to find monsters. In this way, it won't always look for 2062 * the spaces to find monsters. In this way, it won't always look for
… …
2195 * the 3x3 area will be searched, just not in a predictable order. 2065 * the 3x3 area will be searched, just not in a predictable order.
2196 */ 2066 */
2197void 2067void
2198get_search_arr (int *search_arr) 2068get_search_arr (int *search_arr)
2199{ 2069{
2200 int 2070 int i;
2201 i;
2202 2071
2203 for (i = 0; i < SIZEOFFREE; i++) 2072 for (i = 0; i < SIZEOFFREE; i++)
2204 {
2205 search_arr[i] = i; 2073 search_arr[i] = i;
2206 }
2207 2074
2208 permute (search_arr, 1, SIZEOFFREE1 + 1); 2075 permute (search_arr, 1, SIZEOFFREE1 + 1);
2209 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1); 2076 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1);
2210 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE); 2077 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE);
2211} 2078}
… …
2220 * Perhaps incorrectly, but I'm making the assumption that exclude 2087 * Perhaps incorrectly, but I'm making the assumption that exclude
2221 * is actually want is going to try and move there. We need this info 2088 * is actually want is going to try and move there. We need this info
2222 * because we have to know what movement the thing looking to move 2089 * because we have to know what movement the thing looking to move
2223 * there is capable of. 2090 * there is capable of.
2224 */ 2091 */
2225
2226int 2092int
2227find_dir (maptile *m, int x, int y, object *exclude) 2093find_dir (maptile *m, int x, int y, object *exclude)
2228{ 2094{
2229 int
2230 i,
2231 max = SIZEOFFREE, mflags; 2095 int i, max = SIZEOFFREE, mflags;
2232 2096
2233 sint16 nx, ny; 2097 sint16 nx, ny;
2234 object * 2098 object *tmp;
2235 tmp;
2236 maptile * 2099 maptile *mp;
2237 mp;
2238 2100
2239 MoveType blocked, move_type; 2101 MoveType blocked, move_type;
2240 2102
2241 if (exclude && exclude->head) 2103 if (exclude && exclude->head)
2242 { 2104 {
… …
2254 mp = m; 2116 mp = m;
2255 nx = x + freearr_x[i]; 2117 nx = x + freearr_x[i];
2256 ny = y + freearr_y[i]; 2118 ny = y + freearr_y[i];
2257 2119
2258 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2120 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);
2121
2259 if (mflags & P_OUT_OF_MAP) 2122 if (mflags & P_OUT_OF_MAP)
2260 {
2261 max = maxfree[i]; 2123 max = maxfree[i];
2262 }
2263 else 2124 else
2264 { 2125 {
2265 blocked = GET_MAP_MOVE_BLOCK (mp, nx, ny); 2126 mapspace &ms = mp->at (nx, ny);
2127
2128 blocked = ms.move_block;
2266 2129
2267 if ((move_type & blocked) == move_type) 2130 if ((move_type & blocked) == move_type)
2268 {
2269 max = maxfree[i]; 2131 max = maxfree[i];
2270 }
2271 else if (mflags & P_IS_ALIVE) 2132 else if (mflags & P_IS_ALIVE)
2272 { 2133 {
2273 for (tmp = GET_MAP_OB (mp, nx, ny); tmp != NULL; tmp = tmp->above) 2134 for (tmp = ms.bot; tmp; tmp = tmp->above)
2274 { 2135 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)
2275 if ((QUERY_FLAG (tmp, FLAG_MONSTER) || tmp->type == PLAYER) && (tmp != exclude || (tmp->head && tmp->head != exclude))) 2136 && (tmp != exclude || (tmp->head && tmp->head != exclude)))
2276 {
2277 break; 2137 break;
2278 } 2138
2279 }
2280 if (tmp) 2139 if (tmp)
2281 {
2282 return freedir[i]; 2140 return freedir[i];
2283 }
2284 } 2141 }
2285 } 2142 }
2286 } 2143 }
2144
2287 return 0; 2145 return 0;
2288} 2146}
2289 2147
2290/* 2148/*
2291 * distance(object 1, object 2) will return the square of the 2149 * distance(object 1, object 2) will return the square of the
2292 * distance between the two given objects. 2150 * distance between the two given objects.
2293 */ 2151 */
2294
2295int 2152int
2296distance (const object *ob1, const object *ob2) 2153distance (const object *ob1, const object *ob2)
2297{ 2154{
2298 int
2299 i;
2300
2301 i = (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y); 2155 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2302 return i;
2303} 2156}
2304 2157
2305/* 2158/*
2306 * find_dir_2(delta-x,delta-y) will return a direction in which 2159 * find_dir_2(delta-x,delta-y) will return a direction in which
2307 * an object which has subtracted the x and y coordinates of another 2160 * an object which has subtracted the x and y coordinates of another
2308 * object, needs to travel toward it. 2161 * object, needs to travel toward it.
2309 */ 2162 */
2310
2311int 2163int
2312find_dir_2 (int x, int y) 2164find_dir_2 (int x, int y)
2313{ 2165{
2314 int 2166 int q;
2315 q;
2316 2167
2317 if (y) 2168 if (y)
2318 q = x * 100 / y; 2169 q = x * 100 / y;
2319 else if (x) 2170 else if (x)
2320 q = -300 * x; 2171 q = -300 * x;
… …
2355int 2206int
2356absdir (int d) 2207absdir (int d)
2357{ 2208{
2358 while (d < 1) 2209 while (d < 1)
2359 d += 8; 2210 d += 8;
2211
2360 while (d > 8) 2212 while (d > 8)
2361 d -= 8; 2213 d -= 8;
2214
2362 return d; 2215 return d;
2363} 2216}
2364 2217
2365/* 2218/*
2366 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is 2219 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is
… …
2368 */ 2221 */
2369 2222
2370int 2223int
2371dirdiff (int dir1, int dir2) 2224dirdiff (int dir1, int dir2)
2372{ 2225{
2373 int 2226 int d;
2374 d;
2375 2227
2376 d = abs (dir1 - dir2); 2228 d = abs (dir1 - dir2);
2377 if (d > 4) 2229 if (d > 4)
2378 d = 8 - d; 2230 d = 8 - d;
2231
2379 return d; 2232 return d;
2380} 2233}
2381 2234
2382/* peterm: 2235/* peterm:
2383 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster. 2236 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster.
… …
2386 * This basically means that if direction is 15, then it could either go 2239 * This basically means that if direction is 15, then it could either go
2387 * direction 4, 14, or 16 to get back to where we are. 2240 * direction 4, 14, or 16 to get back to where we are.
2388 * Moved from spell_util.c to object.c with the other related direction 2241 * Moved from spell_util.c to object.c with the other related direction
2389 * functions. 2242 * functions.
2390 */ 2243 */
2391
2392int
2393 reduction_dir[SIZEOFFREE][3] = { 2244int reduction_dir[SIZEOFFREE][3] = {
2394 {0, 0, 0}, /* 0 */ 2245 {0, 0, 0}, /* 0 */
2395 {0, 0, 0}, /* 1 */ 2246 {0, 0, 0}, /* 1 */
2396 {0, 0, 0}, /* 2 */ 2247 {0, 0, 0}, /* 2 */
2397 {0, 0, 0}, /* 3 */ 2248 {0, 0, 0}, /* 3 */
2398 {0, 0, 0}, /* 4 */ 2249 {0, 0, 0}, /* 4 */
… …
2446 * find a path to that monster that we found. If not, 2297 * find a path to that monster that we found. If not,
2447 * we don't bother going toward it. Returns 1 if we 2298 * we don't bother going toward it. Returns 1 if we
2448 * can see a direct way to get it 2299 * can see a direct way to get it
2449 * Modified to be map tile aware -.MSW 2300 * Modified to be map tile aware -.MSW
2450 */ 2301 */
2451
2452
2453int 2302int
2454can_see_monsterP (maptile *m, int x, int y, int dir) 2303can_see_monsterP (maptile *m, int x, int y, int dir)
2455{ 2304{
2456 sint16 dx, dy; 2305 sint16 dx, dy;
2457 int
2458 mflags; 2306 int mflags;
2459 2307
2460 if (dir < 0) 2308 if (dir < 0)
2461 return 0; /* exit condition: invalid direction */ 2309 return 0; /* exit condition: invalid direction */
2462 2310
2463 dx = x + freearr_x[dir]; 2311 dx = x + freearr_x[dir];
… …
2476 return 0; 2324 return 0;
2477 2325
2478 /* yes, can see. */ 2326 /* yes, can see. */
2479 if (dir < 9) 2327 if (dir < 9)
2480 return 1; 2328 return 1;
2329
2481 return can_see_monsterP (m, x, y, reduction_dir[dir][0]) | 2330 return can_see_monsterP (m, x, y, reduction_dir[dir][0])
2482 can_see_monsterP (m, x, y, reduction_dir[dir][1]) | can_see_monsterP (m, x, y, reduction_dir[dir][2]); 2331 | can_see_monsterP (m, x, y, reduction_dir[dir][1])
2332 | can_see_monsterP (m, x, y, reduction_dir[dir][2]);
2483} 2333}
2484
2485
2486 2334
2487/* 2335/*
2488 * can_pick(picker, item): finds out if an object is possible to be 2336 * can_pick(picker, item): finds out if an object is possible to be
2489 * picked up by the picker. Returnes 1 if it can be 2337 * picked up by the picker. Returnes 1 if it can be
2490 * picked up, otherwise 0. 2338 * picked up, otherwise 0.
… …
2501 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2349 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2502 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2350 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2503 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2351 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));
2504} 2352}
2505 2353
2506
2507/* 2354/*
2508 * create clone from object to another 2355 * create clone from object to another
2509 */ 2356 */
2510object * 2357object *
2511object_create_clone (object *asrc) 2358object_create_clone (object *asrc)
… …
2530 { 2377 {
2531 dst = tmp; 2378 dst = tmp;
2532 tmp->head = 0; 2379 tmp->head = 0;
2533 } 2380 }
2534 else 2381 else
2535 {
2536 tmp->head = dst; 2382 tmp->head = dst;
2537 }
2538 2383
2539 tmp->more = 0; 2384 tmp->more = 0;
2540 2385
2541 if (prev) 2386 if (prev)
2542 prev->more = tmp; 2387 prev->more = tmp;
… …
2554/* Basically, we save the content of the string to a temp file, then call */ 2399/* Basically, we save the content of the string to a temp file, then call */
2555/* load_object on it. I admit it is a highly inefficient way to make things, */ 2400/* load_object on it. I admit it is a highly inefficient way to make things, */
2556/* but it was simple to make and allows reusing the load_object function. */ 2401/* but it was simple to make and allows reusing the load_object function. */
2557/* Remember not to use load_object_str in a time-critical situation. */ 2402/* Remember not to use load_object_str in a time-critical situation. */
2558/* Also remember that multiparts objects are not supported for now. */ 2403/* Also remember that multiparts objects are not supported for now. */
2559
2560object * 2404object *
2561load_object_str (const char *obstr) 2405load_object_str (const char *obstr)
2562{ 2406{
2563 object *op; 2407 object *op;
2564 char filename[MAX_BUF]; 2408 char filename[MAX_BUF];
… …
2594 * returns NULL if no match. 2438 * returns NULL if no match.
2595 */ 2439 */
2596object * 2440object *
2597find_obj_by_type_subtype (const object *who, int type, int subtype) 2441find_obj_by_type_subtype (const object *who, int type, int subtype)
2598{ 2442{
2599 object *tmp;
2600
2601 for (tmp = who->inv; tmp; tmp = tmp->below) 2443 for (object *tmp = who->inv; tmp; tmp = tmp->below)
2602 if (tmp->type == type && tmp->subtype == subtype) 2444 if (tmp->type == type && tmp->subtype == subtype)
2603 return tmp; 2445 return tmp;
2604 2446
2605 return NULL; 2447 return 0;
2606} 2448}
2607 2449
2608/* If ob has a field named key, return the link from the list, 2450/* If ob has a field named key, return the link from the list,
2609 * otherwise return NULL. 2451 * otherwise return NULL.
2610 * 2452 *
… …
2612 * do the desired thing. 2454 * do the desired thing.
2613 */ 2455 */
2614key_value * 2456key_value *
2615get_ob_key_link (const object *ob, const char *key) 2457get_ob_key_link (const object *ob, const char *key)
2616{ 2458{
2617 key_value *link;
2618
2619 for (link = ob->key_values; link != NULL; link = link->next) 2459 for (key_value *link = ob->key_values; link; link = link->next)
2620 if (link->key == key) 2460 if (link->key == key)
2621 return link; 2461 return link;
2622 2462
2623 return NULL; 2463 return 0;
2624} 2464}
2625 2465
2626/* 2466/*
2627 * Returns the value of op has an extra_field for key, or NULL. 2467 * Returns the value of op has an extra_field for key, or NULL.
2628 * 2468 *
… …
2668 * Returns TRUE on success. 2508 * Returns TRUE on success.
2669 */ 2509 */
2670int 2510int
2671set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key) 2511set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2672{ 2512{
2673 key_value *
2674 field = NULL, *last = NULL; 2513 key_value *field = NULL, *last = NULL;
2675 2514
2676 for (field = op->key_values; field != NULL; field = field->next) 2515 for (field = op->key_values; field != NULL; field = field->next)
2677 { 2516 {
2678 if (field->key != canonical_key) 2517 if (field->key != canonical_key)
2679 { 2518 {
… …
2707 /* IF we get here, key doesn't exist */ 2546 /* IF we get here, key doesn't exist */
2708 2547
2709 /* No field, we'll have to add it. */ 2548 /* No field, we'll have to add it. */
2710 2549
2711 if (!add_key) 2550 if (!add_key)
2712 {
2713 return FALSE; 2551 return FALSE;
2714 } 2552
2715 /* There isn't any good reason to store a null 2553 /* There isn't any good reason to store a null
2716 * value in the key/value list. If the archetype has 2554 * value in the key/value list. If the archetype has
2717 * this key, then we should also have it, so shouldn't 2555 * this key, then we should also have it, so shouldn't
2718 * be here. If user wants to store empty strings, 2556 * be here. If user wants to store empty strings,
2719 * should pass in "" 2557 * should pass in ""

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines