ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.43 by root, Thu Sep 14 17:10:24 2006 UTC vs.
Revision 1.97 by elmex, Sat Dec 30 21:07:46 2006 UTC

1
2/* 1/*
3 CrossFire, A Multiplayer game for X-windows 2 CrossFire, A Multiplayer game for X-windows
4 3
5 Copyright (C) 2001 Mark Wedel & Crossfire Development Team 4 Copyright (C) 2001 Mark Wedel & Crossfire Development Team
6 Copyright (C) 1992 Frank Tore Johansen 5 Copyright (C) 1992 Frank Tore Johansen
… …
17 16
18 You should have received a copy of the GNU General Public License 17 You should have received a copy of the GNU General Public License
19 along with this program; if not, write to the Free Software 18 along with this program; if not, write to the Free Software
20 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 19 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
21 20
22 The authors can be reached via e-mail at crossfire-devel@real-time.com 21 The authors can be reached via e-mail at <crossfire@schmorp.de>
23*/ 22*/
24 23
25/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects. 24/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
26 sub/add_weight will transcend the environment updating the carrying 25 sub/add_weight will transcend the environment updating the carrying
27 variable. */ 26 variable. */
… …
31#include <sys/uio.h> 30#include <sys/uio.h>
32#include <object.h> 31#include <object.h>
33#include <funcpoint.h> 32#include <funcpoint.h>
34#include <loader.h> 33#include <loader.h>
35 34
35#include <bitset>
36
36int nrofallocobjects = 0; 37int nrofallocobjects = 0;
37static UUID uuid; 38static UUID uuid;
38const uint64 UUID_SKIP = 1<<19; 39const uint64 UUID_SKIP = 1<<19;
39 40
40object *objects; /* Pointer to the list of used objects */
41object *active_objects; /* List of active objects that need to be processed */ 41object *active_objects; /* List of active objects that need to be processed */
42 42
43short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 43short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
44 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1 44 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1
45}; 45};
… …
106 _exit (1); 106 _exit (1);
107 } 107 }
108 108
109 uuid.seq = uid; 109 uuid.seq = uid;
110 write_uuid (); 110 write_uuid ();
111 LOG (llevDebug, "read UID: %lld\n", uid); 111 LOG (llevDebug, "read UID: %" PRId64 "\n", uid);
112 fclose (fp); 112 fclose (fp);
113} 113}
114 114
115UUID 115UUID
116gen_uuid () 116gen_uuid ()
… …
141 * objects with lists are rare, and lists stay short. If not, use a 141 * objects with lists are rare, and lists stay short. If not, use a
142 * different structure or at least keep the lists sorted... 142 * different structure or at least keep the lists sorted...
143 */ 143 */
144 144
145 /* For each field in wants, */ 145 /* For each field in wants, */
146 for (wants_field = wants->key_values; wants_field != NULL; wants_field = wants_field->next) 146 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)
147 { 147 {
148 key_value *has_field; 148 key_value *has_field;
149 149
150 /* Look for a field in has with the same key. */ 150 /* Look for a field in has with the same key. */
151 has_field = get_ob_key_link (has, wants_field->key); 151 has_field = get_ob_key_link (has, wants_field->key);
… …
185 * 185 *
186 * Note that this function appears a lot longer than the macro it 186 * Note that this function appears a lot longer than the macro it
187 * replaces - this is mostly for clarity - a decent compiler should hopefully 187 * replaces - this is mostly for clarity - a decent compiler should hopefully
188 * reduce this to the same efficiency. 188 * reduce this to the same efficiency.
189 * 189 *
190 * Check nrof variable *before* calling CAN_MERGE() 190 * Check nrof variable *before* calling can_merge()
191 * 191 *
192 * Improvements made with merge: Better checking on potion, and also 192 * Improvements made with merge: Better checking on potion, and also
193 * check weight 193 * check weight
194 */ 194 */
195
196bool object::can_merge (object *ob1, object *ob2) 195bool object::can_merge_slow (object *ob1, object *ob2)
197{ 196{
198 /* A couple quicksanity checks */ 197 /* A couple quicksanity checks */
199 if ((ob1 == ob2) || (ob1->type != ob2->type)) 198 if (ob1 == ob2
199 || ob1->type != ob2->type
200 || ob1->speed != ob2->speed
201 || ob1->value != ob2->value
202 || ob1->name != ob2->name)
200 return 0; 203 return 0;
201 204
202 if (ob1->speed != ob2->speed) 205 //TODO: this ain't working well, use nicer and correct overflow check
203 return 0;
204
205 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that 206 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that
206 * value could not be stored in a sint32 (which unfortunately sometimes is 207 * value could not be stored in a sint32 (which unfortunately sometimes is
207 * used to store nrof). 208 * used to store nrof).
208 */ 209 */
209 if (ob1->nrof + ob2->nrof >= 1UL << 31) 210 if (ob1->nrof + ob2->nrof >= 1UL << 31)
… …
219 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 220 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
220 221
221 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 222 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
222 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 223 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
223 224
224 225 if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any ()
225 /* the 0x400000 on flags2 is FLAG_INV_LOCK. I don't think something 226 || ob1->arch != ob2->arch
226 * being locked in inventory should prevent merging.
227 * 0x4 in flags3 is CLIENT_SENT
228 */
229 if ((ob1->arch != ob2->arch) ||
230 (ob1->flags[0] != ob2->flags[0]) ||
231 (ob1->flags[1] != ob2->flags[1]) ||
232 ((ob1->flags[2] & ~0x400000) != (ob2->flags[2] & ~0x400000)) ||
233 ((ob1->flags[3] & ~0x4) != (ob2->flags[3] & ~0x4)) ||
234 (ob1->name != ob2->name) || 227 || ob1->name != ob2->name
235 (ob1->title != ob2->title) || 228 || ob1->title != ob2->title
236 (ob1->msg != ob2->msg) || 229 || ob1->msg != ob2->msg
237 (ob1->weight != ob2->weight) || 230 || ob1->weight != ob2->weight
238 (memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist)) != 0) || 231 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
239 (memcmp (&ob1->stats, &ob2->stats, sizeof (ob1->stats)) != 0) || 232 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
240 (ob1->attacktype != ob2->attacktype) || 233 || ob1->attacktype != ob2->attacktype
241 (ob1->magic != ob2->magic) || 234 || ob1->magic != ob2->magic
242 (ob1->slaying != ob2->slaying) || 235 || ob1->slaying != ob2->slaying
243 (ob1->skill != ob2->skill) || 236 || ob1->skill != ob2->skill
244 (ob1->value != ob2->value) || 237 || ob1->value != ob2->value
245 (ob1->animation_id != ob2->animation_id) || 238 || ob1->animation_id != ob2->animation_id
246 (ob1->client_type != ob2->client_type) || 239 || ob1->client_type != ob2->client_type
247 (ob1->materialname != ob2->materialname) || 240 || ob1->materialname != ob2->materialname
248 (ob1->lore != ob2->lore) || 241 || ob1->lore != ob2->lore
249 (ob1->subtype != ob2->subtype) || 242 || ob1->subtype != ob2->subtype
250 (ob1->move_type != ob2->move_type) || 243 || ob1->move_type != ob2->move_type
251 (ob1->move_block != ob2->move_block) || 244 || ob1->move_block != ob2->move_block
252 (ob1->move_allow != ob2->move_allow) || 245 || ob1->move_allow != ob2->move_allow
253 (ob1->move_on != ob2->move_on) || 246 || ob1->move_on != ob2->move_on
254 (ob1->move_off != ob2->move_off) || (ob1->move_slow != ob2->move_slow) || (ob1->move_slow_penalty != ob2->move_slow_penalty)) 247 || ob1->move_off != ob2->move_off
248 || ob1->move_slow != ob2->move_slow
249 || ob1->move_slow_penalty != ob2->move_slow_penalty)
255 return 0; 250 return 0;
256 251
257 /* This is really a spellbook check - really, we should 252 /* This is really a spellbook check - really, we should
258 * check all objects in the inventory. 253 * check all objects in the inventory.
259 */ 254 */
… …
262 /* if one object has inventory but the other doesn't, not equiv */ 257 /* if one object has inventory but the other doesn't, not equiv */
263 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv)) 258 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv))
264 return 0; 259 return 0;
265 260
266 /* Now check to see if the two inventory objects could merge */ 261 /* Now check to see if the two inventory objects could merge */
267 if (!CAN_MERGE (ob1->inv, ob2->inv)) 262 if (!object::can_merge (ob1->inv, ob2->inv))
268 return 0; 263 return 0;
269 264
270 /* inventory ok - still need to check rest of this object to see 265 /* inventory ok - still need to check rest of this object to see
271 * if it is valid. 266 * if it is valid.
272 */ 267 */
… …
281 276
282 /* Note sure why the following is the case - either the object has to 277 /* Note sure why the following is the case - either the object has to
283 * be animated or have a very low speed. Is this an attempted monster 278 * be animated or have a very low speed. Is this an attempted monster
284 * check? 279 * check?
285 */ 280 */
286 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && FABS ((ob1)->speed) > MIN_ACTIVE_SPEED) 281 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && ob1->has_active_speed ())
287 return 0; 282 return 0;
288 283
289 switch (ob1->type) 284 switch (ob1->type)
290 { 285 {
291 case SCROLL: 286 case SCROLL:
… …
356 op = op->env; 351 op = op->env;
357 return op; 352 return op;
358} 353}
359 354
360/* 355/*
361 * Eneq(@csd.uu.se): Since we can have items buried in a character we need
362 * a better check. We basically keeping traversing up until we can't
363 * or find a player.
364 */
365
366object *
367is_player_inv (object *op)
368{
369 for (; op != NULL && op->type != PLAYER; op = op->env)
370 if (op->env == op)
371 op->env = NULL;
372 return op;
373}
374
375/*
376 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump. 356 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
377 * Some error messages. 357 * Some error messages.
378 * The result of the dump is stored in the static global errmsg array. 358 * The result of the dump is stored in the static global errmsg array.
379 */ 359 */
380 360
381void 361char *
382dump_object2 (object *op)
383{
384 errmsg[0] = 0;
385 return;
386 //TODO//D#d#
387#if 0
388 char *cp;
389
390/* object *tmp;*/
391
392 if (op->arch != NULL)
393 {
394 strcat (errmsg, "arch ");
395 strcat (errmsg, op->arch->name ? op->arch->name : "(null)");
396 strcat (errmsg, "\n");
397 if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
398 strcat (errmsg, cp);
399# if 0
400 /* Don't dump player diffs - they are too long, mostly meaningless, and
401 * will overflow the buffer.
402 * Changed so that we don't dump inventory either. This may
403 * also overflow the buffer.
404 */
405 if (op->type != PLAYER && (cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
406 strcat (errmsg, cp);
407 for (tmp = op->inv; tmp; tmp = tmp->below)
408 dump_object2 (tmp);
409# endif
410 strcat (errmsg, "end\n");
411 }
412 else
413 {
414 strcat (errmsg, "Object ");
415 if (op->name == NULL)
416 strcat (errmsg, "(null)");
417 else
418 strcat (errmsg, op->name);
419 strcat (errmsg, "\n");
420# if 0
421 if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
422 strcat (errmsg, cp);
423 for (tmp = op->inv; tmp; tmp = tmp->below)
424 dump_object2 (tmp);
425# endif
426 strcat (errmsg, "end\n");
427 }
428#endif
429}
430
431/*
432 * Dumps an object. Returns output in the static global errmsg array.
433 */
434
435void
436dump_object (object *op) 362dump_object (object *op)
437{ 363{
438 if (op == NULL) 364 if (!op)
439 { 365 return strdup ("[NULLOBJ]");
440 strcpy (errmsg, "[NULL pointer]");
441 return;
442 }
443 errmsg[0] = '\0';
444 dump_object2 (op);
445}
446 366
447void 367 object_freezer freezer;
448dump_all_objects (void) 368 save_object (freezer, op, 1);
449{ 369 return freezer.as_string ();
450 object *op;
451
452 for (op = objects; op != NULL; op = op->next)
453 {
454 dump_object (op);
455 fprintf (logfile, "Object %d\n:%s\n", op->count, errmsg);
456 }
457} 370}
458 371
459/* 372/*
460 * get_nearest_part(multi-object, object 2) returns the part of the 373 * get_nearest_part(multi-object, object 2) returns the part of the
461 * multi-object 1 which is closest to the second object. 374 * multi-object 1 which is closest to the second object.
… …
481 */ 394 */
482 395
483object * 396object *
484find_object (tag_t i) 397find_object (tag_t i)
485{ 398{
486 object *op; 399 for (object *op = object::first; op; op = op->next)
487
488 for (op = objects; op != NULL; op = op->next)
489 if (op->count == i) 400 if (op->count == i)
490 break; 401 return op;
402
491 return op; 403 return 0;
492} 404}
493 405
494/* 406/*
495 * Returns the first object which has a name equal to the argument. 407 * Returns the first object which has a name equal to the argument.
496 * Used only by the patch command, but not all that useful. 408 * Used only by the patch command, but not all that useful.
… …
501find_object_name (const char *str) 413find_object_name (const char *str)
502{ 414{
503 shstr_cmp str_ (str); 415 shstr_cmp str_ (str);
504 object *op; 416 object *op;
505 417
506 for (op = objects; op != NULL; op = op->next) 418 for (op = object::first; op != NULL; op = op->next)
507 if (op->name == str_) 419 if (op->name == str_)
508 break; 420 break;
509 421
510 return op; 422 return op;
511} 423}
… …
554 } 466 }
555 467
556 op->key_values = 0; 468 op->key_values = 0;
557} 469}
558 470
559void object::clear ()
560{
561 attachable_base::clear ();
562
563 free_key_values (this);
564
565 owner = 0;
566 name = 0;
567 name_pl = 0;
568 title = 0;
569 race = 0;
570 slaying = 0;
571 skill = 0;
572 msg = 0;
573 lore = 0;
574 custom_name = 0;
575 materialname = 0;
576 contr = 0;
577 below = 0;
578 above = 0;
579 inv = 0;
580 container = 0;
581 env = 0;
582 more = 0;
583 head = 0;
584 map = 0;
585 active_next = 0;
586 active_prev = 0;
587
588 memset (static_cast<object_pod *>(this), 0, sizeof (object_pod));
589
590 SET_FLAG (this, FLAG_REMOVED);
591
592 /* What is not cleared is next, prev, and count */
593
594 expmul = 1.0;
595 face = blank_face;
596
597 if (settings.casting_time)
598 casting_time = -1;
599}
600
601void object::clone (object *destination)
602{
603 *(object_copy *)destination = *this;
604 *(object_pod *)destination = *this;
605
606 if (self || cb)
607 INVOKE_OBJECT (CLONE, this, ARG_OBJECT (destination));
608}
609
610/* 471/*
611 * copy object first frees everything allocated by the second object, 472 * copy_to first frees everything allocated by the dst object,
612 * and then copies the contends of the first object into the second 473 * and then copies the contents of itself into the second
613 * object, allocating what needs to be allocated. Basically, any 474 * object, allocating what needs to be allocated. Basically, any
614 * data that is malloc'd needs to be re-malloc/copied. Otherwise, 475 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
615 * if the first object is freed, the pointers in the new object 476 * if the first object is freed, the pointers in the new object
616 * will point at garbage. 477 * will point at garbage.
617 */ 478 */
618void 479void
619copy_object (object *op2, object *op) 480object::copy_to (object *dst)
620{ 481{
621 bool is_freed = QUERY_FLAG (op, FLAG_FREED); 482 bool is_freed = QUERY_FLAG (dst, FLAG_FREED);
622 bool is_removed = QUERY_FLAG (op, FLAG_REMOVED); 483 bool is_removed = QUERY_FLAG (dst, FLAG_REMOVED);
623 484
624 op2->clone (op); 485 *(object_copy *)dst = *this;
625 486
626 if (is_freed) 487 if (is_freed)
627 SET_FLAG (op, FLAG_FREED); 488 SET_FLAG (dst, FLAG_FREED);
489
628 if (is_removed) 490 if (is_removed)
629 SET_FLAG (op, FLAG_REMOVED); 491 SET_FLAG (dst, FLAG_REMOVED);
630 492
631 if (op2->speed < 0) 493 if (speed < 0)
632 op->speed_left = op2->speed_left - RANDOM () % 200 / 100.0; 494 dst->speed_left = speed_left - RANDOM () % 200 / 100.0;
633 495
634 /* Copy over key_values, if any. */ 496 /* Copy over key_values, if any. */
635 if (op2->key_values) 497 if (key_values)
636 { 498 {
637 key_value *tail = 0; 499 key_value *tail = 0;
638 key_value *i; 500 key_value *i;
639 501
640 op->key_values = 0; 502 dst->key_values = 0;
641 503
642 for (i = op2->key_values; i; i = i->next) 504 for (i = key_values; i; i = i->next)
643 { 505 {
644 key_value *new_link = new key_value; 506 key_value *new_link = new key_value;
645 507
646 new_link->next = 0; 508 new_link->next = 0;
647 new_link->key = i->key; 509 new_link->key = i->key;
648 new_link->value = i->value; 510 new_link->value = i->value;
649 511
650 /* Try and be clever here, too. */ 512 /* Try and be clever here, too. */
651 if (!op->key_values) 513 if (!dst->key_values)
652 { 514 {
653 op->key_values = new_link; 515 dst->key_values = new_link;
654 tail = new_link; 516 tail = new_link;
655 } 517 }
656 else 518 else
657 { 519 {
658 tail->next = new_link; 520 tail->next = new_link;
659 tail = new_link; 521 tail = new_link;
660 } 522 }
661 } 523 }
662 } 524 }
663 525
664 update_ob_speed (op); 526 dst->set_speed (dst->speed);
527}
528
529object *
530object::clone ()
531{
532 object *neu = create ();
533 copy_to (neu);
534 return neu;
665} 535}
666 536
667/* 537/*
668 * If an object with the IS_TURNABLE() flag needs to be turned due 538 * If an object with the IS_TURNABLE() flag needs to be turned due
669 * to the closest player being on the other side, this function can 539 * to the closest player being on the other side, this function can
670 * be called to update the face variable, _and_ how it looks on the map. 540 * be called to update the face variable, _and_ how it looks on the map.
671 */ 541 */
672
673void 542void
674update_turn_face (object *op) 543update_turn_face (object *op)
675{ 544{
676 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || op->arch == NULL) 545 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || !op->arch)
677 return; 546 return;
547
678 SET_ANIMATION (op, op->direction); 548 SET_ANIMATION (op, op->direction);
679 update_object (op, UP_OBJ_FACE); 549 update_object (op, UP_OBJ_FACE);
680} 550}
681 551
682/* 552/*
683 * Updates the speed of an object. If the speed changes from 0 to another 553 * Updates the speed of an object. If the speed changes from 0 to another
684 * value, or vice versa, then add/remove the object from the active list. 554 * value, or vice versa, then add/remove the object from the active list.
685 * This function needs to be called whenever the speed of an object changes. 555 * This function needs to be called whenever the speed of an object changes.
686 */ 556 */
687void 557void
688update_ob_speed (object *op) 558object::set_speed (float speed)
689{ 559{
690 extern int arch_init; 560 if (flag [FLAG_FREED] && speed)
691
692 /* No reason putting the archetypes objects on the speed list,
693 * since they never really need to be updated.
694 */
695
696 if (QUERY_FLAG (op, FLAG_FREED) && op->speed)
697 { 561 {
698 LOG (llevError, "Object %s is freed but has speed.\n", &op->name); 562 LOG (llevError, "Object %s is freed but has speed.\n", &name);
699#ifdef MANY_CORES
700 abort ();
701#else
702 op->speed = 0; 563 speed = 0;
703#endif
704 }
705
706 if (arch_init)
707 return;
708
709 if (FABS (op->speed) > MIN_ACTIVE_SPEED)
710 { 564 }
711 /* If already on active list, don't do anything */
712 if (op->active_next || op->active_prev || op == active_objects)
713 return;
714 565
715 /* process_events() expects us to insert the object at the beginning 566 this->speed = speed;
716 * of the list. */
717 op->active_next = active_objects;
718 567
719 if (op->active_next != NULL) 568 if (has_active_speed ())
720 op->active_next->active_prev = op; 569 activate (false);
721
722 active_objects = op;
723 }
724 else 570 else
725 { 571 deactivate (false);
726 /* If not on the active list, nothing needs to be done */
727 if (!op->active_next && !op->active_prev && op != active_objects)
728 return;
729
730 if (op->active_prev == NULL)
731 {
732 active_objects = op->active_next;
733
734 if (op->active_next != NULL)
735 op->active_next->active_prev = NULL;
736 }
737 else
738 {
739 op->active_prev->active_next = op->active_next;
740
741 if (op->active_next)
742 op->active_next->active_prev = op->active_prev;
743 }
744
745 op->active_next = NULL;
746 op->active_prev = NULL;
747 }
748} 572}
749 573
750/* This function removes object 'op' from the list of active
751 * objects.
752 * This should only be used for style maps or other such
753 * reference maps where you don't want an object that isn't
754 * in play chewing up cpu time getting processed.
755 * The reverse of this is to call update_ob_speed, which
756 * will do the right thing based on the speed of the object.
757 */
758void
759remove_from_active_list (object *op)
760{
761 /* If not on the active list, nothing needs to be done */
762 if (!op->active_next && !op->active_prev && op != active_objects)
763 return;
764
765 if (op->active_prev == NULL)
766 {
767 active_objects = op->active_next;
768 if (op->active_next != NULL)
769 op->active_next->active_prev = NULL;
770 }
771 else
772 {
773 op->active_prev->active_next = op->active_next;
774 if (op->active_next)
775 op->active_next->active_prev = op->active_prev;
776 }
777 op->active_next = NULL;
778 op->active_prev = NULL;
779}
780
781/* 574/*
782 * update_object() updates the array which represents the map. 575 * update_object() updates the the map.
783 * It takes into account invisible objects (and represent squares covered 576 * It takes into account invisible objects (and represent squares covered
784 * by invisible objects by whatever is below them (unless it's another 577 * by invisible objects by whatever is below them (unless it's another
785 * invisible object, etc...) 578 * invisible object, etc...)
786 * If the object being updated is beneath a player, the look-window 579 * If the object being updated is beneath a player, the look-window
787 * of that player is updated (this might be a suboptimal way of 580 * of that player is updated (this might be a suboptimal way of
788 * updating that window, though, since update_object() is called _often_) 581 * updating that window, though, since update_object() is called _often_)
789 * 582 *
790 * action is a hint of what the caller believes need to be done. 583 * action is a hint of what the caller believes need to be done.
791 * For example, if the only thing that has changed is the face (due to
792 * an animation), we don't need to call update_position until that actually
793 * comes into view of a player. OTOH, many other things, like addition/removal
794 * of walls or living creatures may need us to update the flags now.
795 * current action are: 584 * current action are:
796 * UP_OBJ_INSERT: op was inserted 585 * UP_OBJ_INSERT: op was inserted
797 * UP_OBJ_REMOVE: op was removed 586 * UP_OBJ_REMOVE: op was removed
798 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update 587 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update
799 * as that is easier than trying to look at what may have changed. 588 * as that is easier than trying to look at what may have changed.
800 * UP_OBJ_FACE: only the objects face has changed. 589 * UP_OBJ_FACE: only the objects face has changed.
801 */ 590 */
802
803void 591void
804update_object (object *op, int action) 592update_object (object *op, int action)
805{ 593{
806 int update_now = 0, flags;
807 MoveType move_on, move_off, move_block, move_slow; 594 MoveType move_on, move_off, move_block, move_slow;
808 595
809 if (op == NULL) 596 if (op == NULL)
810 { 597 {
811 /* this should never happen */ 598 /* this should never happen */
812 LOG (llevDebug, "update_object() called for NULL object.\n"); 599 LOG (llevDebug, "update_object() called for NULL object.\n");
813 return; 600 return;
814 } 601 }
815 602
816 if (op->env != NULL) 603 if (op->env)
817 { 604 {
818 /* Animation is currently handled by client, so nothing 605 /* Animation is currently handled by client, so nothing
819 * to do in this case. 606 * to do in this case.
820 */ 607 */
821 return; 608 return;
… …
826 */ 613 */
827 if (!op->map || op->map->in_memory == MAP_SAVING) 614 if (!op->map || op->map->in_memory == MAP_SAVING)
828 return; 615 return;
829 616
830 /* make sure the object is within map boundaries */ 617 /* make sure the object is within map boundaries */
831 if (op->x < 0 || op->x >= MAP_WIDTH (op->map) || op->y < 0 || op->y >= MAP_HEIGHT (op->map)) 618 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
832 { 619 {
833 LOG (llevError, "update_object() called for object out of map!\n"); 620 LOG (llevError, "update_object() called for object out of map!\n");
834#ifdef MANY_CORES 621#ifdef MANY_CORES
835 abort (); 622 abort ();
836#endif 623#endif
837 return; 624 return;
838 } 625 }
839 626
840 flags = GET_MAP_FLAGS (op->map, op->x, op->y); 627 mapspace &m = op->ms ();
841 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NEED_UPDATE);
842 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
843 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
844 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
845 move_off = GET_MAP_MOVE_OFF (op->map, op->x, op->y);
846 628
629 if (m.flags_ & P_NEED_UPDATE)
630 /* nop */;
847 if (action == UP_OBJ_INSERT) 631 else if (action == UP_OBJ_INSERT)
848 { 632 {
633 // this is likely overkill, TODO: revisit (schmorp)
849 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(flags & P_BLOCKSVIEW)) 634 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
850 update_now = 1;
851
852 if (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(flags & P_NO_MAGIC)) 635 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
853 update_now = 1; 636 || (op->type == PLAYER && !(m.flags_ & P_PLAYER))
854 637 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
638 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
855 if (QUERY_FLAG (op, FLAG_DAMNED) && !(flags & P_NO_CLERIC)) 639 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
856 update_now = 1;
857
858 if (QUERY_FLAG (op, FLAG_ALIVE) && !(flags & P_IS_ALIVE))
859 update_now = 1;
860
861 if (op->type == SAFE_GROUND && !(flags & P_SAFE))
862 update_now = 1;
863
864 if ((move_on | op->move_on) != move_on) 640 || (m.move_on | op->move_on ) != m.move_on
865 update_now = 1;
866
867 if ((move_off | op->move_off) != move_off) 641 || (m.move_off | op->move_off ) != m.move_off
868 update_now = 1; 642 || (m.move_slow | op->move_slow) != m.move_slow
869
870 /* This isn't perfect, but I don't expect a lot of objects to 643 /* This isn't perfect, but I don't expect a lot of objects to
871 * to have move_allow right now. 644 * to have move_allow right now.
872 */ 645 */
873 if (((move_block | op->move_block) & ~op->move_allow) != move_block) 646 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
874 update_now = 1; 647 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
875 648 m.flags_ = P_NEED_UPDATE;
876 if ((move_slow | op->move_slow) != move_slow)
877 update_now = 1;
878 } 649 }
879 /* if the object is being removed, we can't make intelligent 650 /* if the object is being removed, we can't make intelligent
880 * decisions, because remove_ob can't really pass the object 651 * decisions, because remove_ob can't really pass the object
881 * that is being removed. 652 * that is being removed.
882 */ 653 */
883 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 654 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
884 update_now = 1; 655 m.flags_ = P_NEED_UPDATE;
885 else if (action == UP_OBJ_FACE) 656 else if (action == UP_OBJ_FACE)
886 /* Nothing to do for that case */ ; 657 /* Nothing to do for that case */ ;
887 else 658 else
888 LOG (llevError, "update_object called with invalid action: %d\n", action); 659 LOG (llevError, "update_object called with invalid action: %d\n", action);
889 660
890 if (update_now)
891 {
892 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NO_ERROR | P_NEED_UPDATE);
893 update_position (op->map, op->x, op->y);
894 }
895
896 if (op->more != NULL) 661 if (op->more)
897 update_object (op->more, action); 662 update_object (op->more, action);
898} 663}
899 664
900static unordered_vector<object *> mortals; 665object::vector object::objects; // not yet used
901 666object *object::first;
902void object::free_mortals ()
903{
904 for (unordered_vector<object *>::iterator i = mortals.begin (); i != mortals.end ();)
905 if ((*i)->refcnt)
906 ++i; // further delay freeing
907 else
908 {
909 delete *i;
910 mortals.erase (i);
911 }
912
913 static int lastmortals = 0;//D
914
915 if (mortals.size() != lastmortals)//D
916 {
917 lastmortals = mortals.size ();//D
918 LOG (llevDebug, "%d objects in mortal queue\n", lastmortals);//D
919 }
920}
921 667
922object::object () 668object::object ()
923{ 669{
924 SET_FLAG (this, FLAG_REMOVED); 670 SET_FLAG (this, FLAG_REMOVED);
925 671
… …
936{ 682{
937 count = ++ob_count; 683 count = ++ob_count;
938 uuid = gen_uuid (); 684 uuid = gen_uuid ();
939 685
940 prev = 0; 686 prev = 0;
941 next = objects; 687 next = object::first;
942 688
943 if (objects) 689 if (object::first)
944 objects->prev = this; 690 object::first->prev = this;
945 691
946 objects = this; 692 object::first = this;
947} 693}
948 694
949void object::unlink () 695void object::unlink ()
950{ 696{
951 //count = 0;//D
952 if (!prev && !next) return;//D
953
954 if (this == objects) 697 if (this == object::first)
955 objects = next; 698 object::first = next;
956 699
957 /* Remove this object from the list of used objects */ 700 /* Remove this object from the list of used objects */
958 if (prev) prev->next = next; 701 if (prev) prev->next = next;
959 if (next) next->prev = prev; 702 if (next) next->prev = prev;
960 703
961 prev = 0; 704 prev = 0;
962 next = 0; 705 next = 0;
963} 706}
964 707
708void
709object::activate (bool recursive)
710{
711 if (has_active_speed ())
712 {
713 /* If already on active list, don't do anything */
714 if (active_next || active_prev || this == active_objects)
715 return;
716
717 /* process_events() expects us to insert the object at the beginning
718 * of the list. */
719 active_next = active_objects;
720
721 if (active_next)
722 active_next->active_prev = this;
723
724 active_objects = this;
725 }
726
727 if (recursive)
728 for (object *op = inv; op; op = op->above)
729 op->activate (1);
730}
731
732/* This function removes object 'op' from the list of active
733 * objects.
734 * This should only be used for style maps or other such
735 * reference maps where you don't want an object that isn't
736 * in play chewing up cpu time getting processed.
737 * The reverse of this is to call update_ob_speed, which
738 * will do the right thing based on the speed of the object.
739 */
740void
741object::deactivate (bool recursive)
742{
743 /* If not on the active list, nothing needs to be done */
744 if (!active_next && !active_prev && this != active_objects)
745 return;
746
747 if (active_prev == 0)
748 {
749 active_objects = active_next;
750 if (active_next)
751 active_next->active_prev = 0;
752 }
753 else
754 {
755 active_prev->active_next = active_next;
756 if (active_next)
757 active_next->active_prev = active_prev;
758 }
759
760 active_next = 0;
761 active_prev = 0;
762
763 if (recursive)
764 for (object *op = inv; op; op = op->above)
765 op->deactivate (1);
766}
767
768/*
769 * Remove and free all objects in the inventory of the given object.
770 * object.c ?
771 */
772void
773object::destroy_inv (bool drop_to_ground)
774{
775 // need to check first, because the checks below might segfault
776 // as we might be on an invalid mapspace and crossfire code
777 // is too buggy to ensure that the inventory is empty.
778 // corollary: if you create arrows etc. with stuff in tis inventory,
779 // cf will crash below with off-map x and y
780 if (!inv)
781 return;
782
783 /* Only if the space blocks everything do we not process -
784 * if some form of movement is allowed, let objects
785 * drop on that space.
786 */
787 if (!drop_to_ground
788 || !map
789 || map->in_memory != MAP_IN_MEMORY
790 || ms ().move_block == MOVE_ALL)
791 {
792 while (inv)
793 {
794 inv->destroy_inv (drop_to_ground);
795 inv->destroy ();
796 }
797 }
798 else
799 { /* Put objects in inventory onto this space */
800 while (inv)
801 {
802 object *op = inv;
803
804 if (op->flag [FLAG_STARTEQUIP]
805 || op->flag [FLAG_NO_DROP]
806 || op->type == RUNE
807 || op->type == TRAP
808 || op->flag [FLAG_IS_A_TEMPLATE])
809 op->destroy ();
810 else
811 map->insert (op, x, y);
812 }
813 }
814}
815
965object *object::create () 816object *object::create ()
966{ 817{
967 object *op = new object; 818 object *op = new object;
968 op->link (); 819 op->link ();
969 return op; 820 return op;
970} 821}
971 822
972/* 823void
973 * free_object() frees everything allocated by an object, removes 824object::do_destroy ()
974 * it from the list of used objects, and puts it on the list of
975 * free objects. The IS_FREED() flag is set in the object.
976 * The object must have been removed by remove_ob() first for
977 * this function to succeed.
978 *
979 * If free_inventory is set, free inventory as well. Else drop items in
980 * inventory to the ground.
981 */
982void object::free (bool free_inventory)
983{ 825{
984 if (QUERY_FLAG (this, FLAG_FREED)) 826 if (flag [FLAG_IS_LINKED])
827 remove_button_link (this);
828
829 if (flag [FLAG_FRIENDLY])
830 remove_friendly_object (this);
831
832 if (!flag [FLAG_REMOVED])
833 remove ();
834
835 if (flag [FLAG_FREED])
985 return; 836 return;
986 837
987 if (QUERY_FLAG (this, FLAG_FRIENDLY)) 838 set_speed (0);
988 remove_friendly_object (this);
989 839
990 if (!QUERY_FLAG (this, FLAG_REMOVED)) 840 flag [FLAG_FREED] = 1;
991 remove_ob (this);
992 841
993 SET_FLAG (this, FLAG_FREED); 842 attachable::do_destroy ();
843
844 destroy_inv (true);
845 unlink ();
846
847 // hack to ensure that freed objects still have a valid map
848 {
849 static maptile *freed_map; // freed objects are moved here to avoid crashes
850
851 if (!freed_map)
852 {
853 freed_map = new maptile;
854
855 freed_map->name = "/internal/freed_objects_map";
856 freed_map->width = 3;
857 freed_map->height = 3;
858
859 freed_map->alloc ();
860 }
861
862 map = freed_map;
863 x = 1;
864 y = 1;
865 }
866
867 head = 0;
994 868
995 if (more) 869 if (more)
996 { 870 {
997 more->free (free_inventory); 871 more->destroy ();
998 more = 0; 872 more = 0;
999 } 873 }
1000 874
1001 if (inv) 875 // clear those pointers that likely might have circular references to us
1002 {
1003 /* Only if the space blocks everything do we not process -
1004 * if some form of movement is allowed, let objects
1005 * drop on that space.
1006 */
1007 if (free_inventory || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL)
1008 {
1009 object *op = inv;
1010
1011 while (op)
1012 {
1013 object *tmp = op->below;
1014 op->free (free_inventory);
1015 op = tmp;
1016 }
1017 }
1018 else
1019 { /* Put objects in inventory onto this space */
1020 object *op = inv;
1021
1022 while (op)
1023 {
1024 object *tmp = op->below;
1025
1026 remove_ob (op);
1027
1028 if (QUERY_FLAG (op, FLAG_STARTEQUIP)
1029 || QUERY_FLAG (op, FLAG_NO_DROP) || op->type == RUNE || op->type == TRAP || QUERY_FLAG (op, FLAG_IS_A_TEMPLATE))
1030 free_object (op);
1031 else
1032 {
1033 op->x = x;
1034 op->y = y;
1035 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
1036 }
1037
1038 op = tmp;
1039 }
1040 }
1041 }
1042
1043 owner = 0; 876 owner = 0;
877 enemy = 0;
878 attacked_by = 0;
1044 879
1045 /* Remove object from the active list */ 880 // only relevant for players(?), but make sure of it anyways
1046 speed = 0; 881 contr = 0;
1047 update_ob_speed (this); 882}
1048 883
1049 unlink (); 884void
885object::destroy (bool destroy_inventory)
886{
887 if (destroyed ())
888 return;
1050 889
1051 mortals.push_back (this); 890 if (destroy_inventory)
891 destroy_inv (false);
892
893 attachable::destroy ();
1052} 894}
1053 895
1054/* 896/*
1055 * sub_weight() recursively (outwards) subtracts a number from the 897 * sub_weight() recursively (outwards) subtracts a number from the
1056 * weight of an object (and what is carried by it's environment(s)). 898 * weight of an object (and what is carried by it's environment(s)).
1057 */ 899 */
1058
1059void 900void
1060sub_weight (object *op, signed long weight) 901sub_weight (object *op, signed long weight)
1061{ 902{
1062 while (op != NULL) 903 while (op != NULL)
1063 { 904 {
1064 if (op->type == CONTAINER) 905 if (op->type == CONTAINER)
1065 {
1066 weight = (signed long) (weight * (100 - op->stats.Str) / 100); 906 weight = (signed long) (weight * (100 - op->stats.Str) / 100);
1067 } 907
1068 op->carrying -= weight; 908 op->carrying -= weight;
1069 op = op->env; 909 op = op->env;
1070 } 910 }
1071} 911}
1072 912
1073/* remove_ob(op): 913/* op->remove ():
1074 * This function removes the object op from the linked list of objects 914 * This function removes the object op from the linked list of objects
1075 * which it is currently tied to. When this function is done, the 915 * which it is currently tied to. When this function is done, the
1076 * object will have no environment. If the object previously had an 916 * object will have no environment. If the object previously had an
1077 * environment, the x and y coordinates will be updated to 917 * environment, the x and y coordinates will be updated to
1078 * the previous environment. 918 * the previous environment.
1079 * Beware: This function is called from the editor as well! 919 * Beware: This function is called from the editor as well!
1080 */ 920 */
1081
1082void 921void
1083remove_ob (object *op) 922object::remove ()
1084{ 923{
924 object *tmp, *last = 0;
1085 object * 925 object *otmp;
1086 tmp, *
1087 last = NULL;
1088 object *
1089 otmp;
1090 926
1091 tag_t
1092 tag;
1093 int
1094 check_walk_off;
1095 mapstruct *
1096 m;
1097
1098 sint16
1099 x,
1100 y;
1101
1102 if (QUERY_FLAG (op, FLAG_REMOVED)) 927 if (QUERY_FLAG (this, FLAG_REMOVED))
1103 return; 928 return;
1104 929
1105 SET_FLAG (op, FLAG_REMOVED); 930 SET_FLAG (this, FLAG_REMOVED);
931 INVOKE_OBJECT (REMOVE, this);
1106 932
1107 if (op->more != NULL) 933 if (more)
1108 remove_ob (op->more); 934 more->remove ();
1109 935
1110 /* 936 /*
1111 * In this case, the object to be removed is in someones 937 * In this case, the object to be removed is in someones
1112 * inventory. 938 * inventory.
1113 */ 939 */
1114 if (op->env != NULL) 940 if (env)
1115 { 941 {
1116 if (op->nrof) 942 if (nrof)
1117 sub_weight (op->env, op->weight * op->nrof); 943 sub_weight (env, weight * nrof);
1118 else 944 else
1119 sub_weight (op->env, op->weight + op->carrying); 945 sub_weight (env, weight + carrying);
1120 946
1121 /* NO_FIX_PLAYER is set when a great many changes are being 947 /* NO_FIX_PLAYER is set when a great many changes are being
1122 * made to players inventory. If set, avoiding the call 948 * made to players inventory. If set, avoiding the call
1123 * to save cpu time. 949 * to save cpu time.
1124 */ 950 */
1125 if ((otmp = is_player_inv (op->env)) != NULL && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 951 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1126 fix_player (otmp); 952 otmp->update_stats ();
1127 953
1128 if (op->above != NULL) 954 if (above)
1129 op->above->below = op->below; 955 above->below = below;
1130 else 956 else
1131 op->env->inv = op->below; 957 env->inv = below;
1132 958
1133 if (op->below != NULL) 959 if (below)
1134 op->below->above = op->above; 960 below->above = above;
1135 961
1136 /* we set up values so that it could be inserted into 962 /* we set up values so that it could be inserted into
1137 * the map, but we don't actually do that - it is up 963 * the map, but we don't actually do that - it is up
1138 * to the caller to decide what we want to do. 964 * to the caller to decide what we want to do.
1139 */ 965 */
1140 op->x = op->env->x, op->y = op->env->y; 966 x = env->x, y = env->y;
1141 op->map = op->env->map; 967 map = env->map;
1142 op->above = NULL, op->below = NULL; 968 above = 0, below = 0;
1143 op->env = NULL; 969 env = 0;
1144 } 970 }
1145 else if (op->map) 971 else if (map)
1146 { 972 {
1147 x = op->x; 973 if (type == PLAYER)
1148 y = op->y;
1149 m = get_map_from_coord (op->map, &x, &y);
1150
1151 if (!m)
1152 {
1153 LOG (llevError, "remove_ob called when object was on map but appears to not be within valid coordinates? %s (%d,%d)\n",
1154 op->map->path, op->x, op->y);
1155 /* in old days, we used to set x and y to 0 and continue.
1156 * it seems if we get into this case, something is probablye
1157 * screwed up and should be fixed.
1158 */
1159 abort ();
1160 } 974 {
1161 975 --map->players;
1162 if (op->map != m) 976 map->last_access = runtime;
1163 LOG (llevDebug, "remove_ob: Object not really on map it claimed to be on? %s != %s, %d,%d != %d,%d\n",
1164 op->map->path, m->path, op->x, op->y, x, y);
1165
1166 /* Re did the following section of code - it looks like it had
1167 * lots of logic for things we no longer care about
1168 */ 977 }
978
1169 979
1170 /* link the object above us */ 980 /* link the object above us */
1171 if (op->above) 981 if (above)
1172 op->above->below = op->below; 982 above->below = below;
1173 else 983 else
1174 SET_MAP_TOP (m, x, y, op->below); /* we were top, set new top */ 984 map->at (x, y).top = below; /* we were top, set new top */
1175 985
1176 /* Relink the object below us, if there is one */ 986 /* Relink the object below us, if there is one */
1177 if (op->below) 987 if (below)
1178 op->below->above = op->above; 988 below->above = above;
1179 else 989 else
1180 { 990 {
1181 /* Nothing below, which means we need to relink map object for this space 991 /* Nothing below, which means we need to relink map object for this space
1182 * use translated coordinates in case some oddness with map tiling is 992 * use translated coordinates in case some oddness with map tiling is
1183 * evident 993 * evident
1184 */ 994 */
1185 if (GET_MAP_OB (m, x, y) != op) 995 if (GET_MAP_OB (map, x, y) != this)
1186 { 996 {
1187 dump_object (op); 997 char *dump = dump_object (this);
1188 LOG (llevError, 998 LOG (llevError,
1189 "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", errmsg); 999 "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", dump);
1000 free (dump);
1190 dump_object (GET_MAP_OB (m, x, y)); 1001 dump = dump_object (GET_MAP_OB (map, x, y));
1191 LOG (llevError, "%s\n", errmsg); 1002 LOG (llevError, "%s\n", dump);
1003 free (dump);
1192 } 1004 }
1193 1005
1194 SET_MAP_OB (m, x, y, op->above); /* goes on above it. */ 1006 map->at (x, y).bot = above; /* goes on above it. */
1195 } 1007 }
1196 1008
1197 op->above = 0; 1009 above = 0;
1198 op->below = 0; 1010 below = 0;
1199 1011
1200 if (op->map->in_memory == MAP_SAVING) 1012 if (map->in_memory == MAP_SAVING)
1201 return; 1013 return;
1202 1014
1203 tag = op->count; 1015 int check_walk_off = !flag [FLAG_NO_APPLY];
1204 check_walk_off = !QUERY_FLAG (op, FLAG_NO_APPLY);
1205 1016
1206 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1017 for (tmp = map->at (x, y).bot; tmp; tmp = tmp->above)
1207 { 1018 {
1208 /* No point updating the players look faces if he is the object 1019 /* No point updating the players look faces if he is the object
1209 * being removed. 1020 * being removed.
1210 */ 1021 */
1211 1022
1212 if (tmp->type == PLAYER && tmp != op) 1023 if (tmp->type == PLAYER && tmp != this)
1213 { 1024 {
1214 /* If a container that the player is currently using somehow gets 1025 /* If a container that the player is currently using somehow gets
1215 * removed (most likely destroyed), update the player view 1026 * removed (most likely destroyed), update the player view
1216 * appropriately. 1027 * appropriately.
1217 */ 1028 */
1218 if (tmp->container == op) 1029 if (tmp->container == this)
1219 { 1030 {
1220 CLEAR_FLAG (op, FLAG_APPLIED); 1031 flag [FLAG_APPLIED] = 0;
1221 tmp->container = NULL; 1032 tmp->container = 0;
1222 } 1033 }
1223 1034
1224 tmp->contr->socket.update_look = 1; 1035 if (tmp->contr->ns)
1036 tmp->contr->ns->floorbox_update ();
1225 } 1037 }
1226 1038
1227 /* See if player moving off should effect something */ 1039 /* See if object moving off should effect something */
1228 if (check_walk_off && ((op->move_type & tmp->move_off) && (op->move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1040 if (check_walk_off
1041 && ((move_type & tmp->move_off)
1042 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0))
1229 { 1043 {
1230 move_apply (tmp, op, NULL); 1044 move_apply (tmp, this, 0);
1231 1045
1232 if (was_destroyed (op, tag)) 1046 if (destroyed ())
1233 {
1234 LOG (llevError, "BUG: remove_ob(): name %s, archname %s destroyed " "leaving object\n", &tmp->name, &tmp->arch->name); 1047 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1235 }
1236 } 1048 }
1237 1049
1238 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */ 1050 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */
1239 1051 //TODO: why is this horrible hacka fix? get rid of this code=bug! (schmorp)
1240 if (tmp->above == tmp) 1052 if (tmp->above == tmp)
1241 tmp->above = NULL; 1053 tmp->above = 0;
1242 1054
1243 last = tmp; 1055 last = tmp;
1244 } 1056 }
1245 1057
1246 /* last == NULL of there are no objects on this space */ 1058 /* last == NULL if there are no objects on this space */
1059 //TODO: this makes little sense, why only update the topmost object?
1247 if (last == NULL) 1060 if (!last)
1248 { 1061 map->at (x, y).flags_ = P_NEED_UPDATE;
1249 /* set P_NEED_UPDATE, otherwise update_position will complain. In theory,
1250 * we could preserve the flags (GET_MAP_FLAGS), but update_position figures
1251 * those out anyways, and if there are any flags set right now, they won't
1252 * be correct anyways.
1253 */
1254 SET_MAP_FLAGS (op->map, op->x, op->y, P_NEED_UPDATE);
1255 update_position (op->map, op->x, op->y);
1256 }
1257 else 1062 else
1258 update_object (last, UP_OBJ_REMOVE); 1063 update_object (last, UP_OBJ_REMOVE);
1259 1064
1260 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) || (op->glow_radius != 0)) 1065 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1261 update_all_los (op->map, op->x, op->y); 1066 update_all_los (map, x, y);
1262 } 1067 }
1263} 1068}
1264 1069
1265/* 1070/*
1266 * merge_ob(op,top): 1071 * merge_ob(op,top):
… …
1274merge_ob (object *op, object *top) 1079merge_ob (object *op, object *top)
1275{ 1080{
1276 if (!op->nrof) 1081 if (!op->nrof)
1277 return 0; 1082 return 0;
1278 1083
1279 if (top == NULL) 1084 if (top)
1280 for (top = op; top != NULL && top->above != NULL; top = top->above); 1085 for (top = op; top && top->above; top = top->above)
1086 ;
1281 1087
1282 for (; top != NULL; top = top->below) 1088 for (; top; top = top->below)
1283 { 1089 {
1284 if (top == op) 1090 if (top == op)
1285 continue; 1091 continue;
1286 if (CAN_MERGE (op, top)) 1092
1093 if (object::can_merge (op, top))
1287 { 1094 {
1288 top->nrof += op->nrof; 1095 top->nrof += op->nrof;
1289 1096
1290/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/ 1097/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/
1291 op->weight = 0; /* Don't want any adjustements now */ 1098 op->weight = 0; /* Don't want any adjustements now */
1292 remove_ob (op); 1099 op->destroy ();
1293 free_object (op);
1294 return top; 1100 return top;
1295 } 1101 }
1296 } 1102 }
1297 1103
1298 return NULL; 1104 return 0;
1299} 1105}
1300 1106
1301/* 1107/*
1302 * same as insert_ob_in_map except it handle separate coordinates and do a clean 1108 * same as insert_ob_in_map except it handle separate coordinates and do a clean
1303 * job preparing multi-part monsters 1109 * job preparing multi-part monsters
1304 */ 1110 */
1305object * 1111object *
1306insert_ob_in_map_at (object *op, mapstruct *m, object *originator, int flag, int x, int y) 1112insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1307{ 1113{
1308 object *tmp;
1309
1310 if (op->head)
1311 op = op->head;
1312
1313 for (tmp = op; tmp; tmp = tmp->more) 1114 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1314 { 1115 {
1315 tmp->x = x + tmp->arch->clone.x; 1116 tmp->x = x + tmp->arch->clone.x;
1316 tmp->y = y + tmp->arch->clone.y; 1117 tmp->y = y + tmp->arch->clone.y;
1317 } 1118 }
1318 1119
… …
1337 * Return value: 1138 * Return value:
1338 * new object if 'op' was merged with other object 1139 * new object if 'op' was merged with other object
1339 * NULL if 'op' was destroyed 1140 * NULL if 'op' was destroyed
1340 * just 'op' otherwise 1141 * just 'op' otherwise
1341 */ 1142 */
1342
1343object * 1143object *
1344insert_ob_in_map (object *op, mapstruct *m, object *originator, int flag) 1144insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1345{ 1145{
1346 object *tmp, *top, *floor = NULL; 1146 object *tmp, *top, *floor = NULL;
1347 sint16 x, y; 1147 sint16 x, y;
1348 1148
1349 if (QUERY_FLAG (op, FLAG_FREED)) 1149 if (QUERY_FLAG (op, FLAG_FREED))
1350 { 1150 {
1351 LOG (llevError, "Trying to insert freed object!\n"); 1151 LOG (llevError, "Trying to insert freed object!\n");
1352 return NULL; 1152 return NULL;
1353 } 1153 }
1354 1154
1355 if (m == NULL) 1155 if (!m)
1356 { 1156 {
1357 dump_object (op); 1157 char *dump = dump_object (op);
1358 LOG (llevError, "Trying to insert in null-map!\n%s\n", errmsg); 1158 LOG (llevError, "Trying to insert in null-map!\n%s\n", dump);
1159 free (dump);
1359 return op; 1160 return op;
1360 } 1161 }
1361 1162
1362 if (out_of_map (m, op->x, op->y)) 1163 if (out_of_map (m, op->x, op->y))
1363 { 1164 {
1364 dump_object (op); 1165 char *dump = dump_object (op);
1365 LOG (llevError, "Trying to insert object outside the map.\n%s\n", errmsg); 1166 LOG (llevError, "Trying to insert object outside the map.\n%s\n", dump);
1366#ifdef MANY_CORES 1167#ifdef MANY_CORES
1367 /* Better to catch this here, as otherwise the next use of this object 1168 /* Better to catch this here, as otherwise the next use of this object
1368 * is likely to cause a crash. Better to find out where it is getting 1169 * is likely to cause a crash. Better to find out where it is getting
1369 * improperly inserted. 1170 * improperly inserted.
1370 */ 1171 */
1371 abort (); 1172 abort ();
1372#endif 1173#endif
1174 free (dump);
1373 return op; 1175 return op;
1374 } 1176 }
1375 1177
1376 if (!QUERY_FLAG (op, FLAG_REMOVED)) 1178 if (!QUERY_FLAG (op, FLAG_REMOVED))
1377 { 1179 {
1378 dump_object (op); 1180 char *dump = dump_object (op);
1379 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", errmsg); 1181 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", dump);
1182 free (dump);
1380 return op; 1183 return op;
1381 } 1184 }
1382 1185
1383 if (op->more != NULL) 1186 if (op->more)
1384 { 1187 {
1385 /* The part may be on a different map. */ 1188 /* The part may be on a different map. */
1386 1189
1387 object *more = op->more; 1190 object *more = op->more;
1388 1191
… …
1404 if (insert_ob_in_map (more, more->map, originator, flag) == NULL) 1207 if (insert_ob_in_map (more, more->map, originator, flag) == NULL)
1405 { 1208 {
1406 if (!op->head) 1209 if (!op->head)
1407 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n"); 1210 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n");
1408 1211
1409 return NULL; 1212 return 0;
1410 } 1213 }
1411 } 1214 }
1412 1215
1413 CLEAR_FLAG (op, FLAG_REMOVED); 1216 CLEAR_FLAG (op, FLAG_REMOVED);
1414 1217
… …
1421 y = op->y; 1224 y = op->y;
1422 1225
1423 /* this has to be done after we translate the coordinates. 1226 /* this has to be done after we translate the coordinates.
1424 */ 1227 */
1425 if (op->nrof && !(flag & INS_NO_MERGE)) 1228 if (op->nrof && !(flag & INS_NO_MERGE))
1426 for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above) 1229 for (tmp = GET_MAP_OB (op->map, x, y); tmp; tmp = tmp->above)
1427 if (CAN_MERGE (op, tmp)) 1230 if (object::can_merge (op, tmp))
1428 { 1231 {
1429 op->nrof += tmp->nrof; 1232 op->nrof += tmp->nrof;
1430 remove_ob (tmp); 1233 tmp->destroy ();
1431 free_object (tmp);
1432 } 1234 }
1433 1235
1434 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1236 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1435 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1237 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1436 1238
… …
1449 op->below = originator->below; 1251 op->below = originator->below;
1450 1252
1451 if (op->below) 1253 if (op->below)
1452 op->below->above = op; 1254 op->below->above = op;
1453 else 1255 else
1454 SET_MAP_OB (op->map, op->x, op->y, op); 1256 op->ms ().bot = op;
1455 1257
1456 /* since *below* originator, no need to update top */ 1258 /* since *below* originator, no need to update top */
1457 originator->below = op; 1259 originator->below = op;
1458 } 1260 }
1459 else 1261 else
1460 { 1262 {
1461 /* If there are other objects, then */ 1263 /* If there are other objects, then */
1462 if ((!(flag & INS_MAP_LOAD)) && ((top = GET_MAP_OB (op->map, op->x, op->y)) != NULL)) 1264 if ((!(flag & INS_MAP_LOAD)) && ((top = GET_MAP_OB (op->map, op->x, op->y)) != NULL))
1463 { 1265 {
1464 object *last = NULL; 1266 object *last = 0;
1465 1267
1466 /* 1268 /*
1467 * If there are multiple objects on this space, we do some trickier handling. 1269 * If there are multiple objects on this space, we do some trickier handling.
1468 * We've already dealt with merging if appropriate. 1270 * We've already dealt with merging if appropriate.
1469 * Generally, we want to put the new object on top. But if 1271 * Generally, we want to put the new object on top. But if
… …
1473 * once we get to them. This reduces the need to traverse over all of 1275 * once we get to them. This reduces the need to traverse over all of
1474 * them when adding another one - this saves quite a bit of cpu time 1276 * them when adding another one - this saves quite a bit of cpu time
1475 * when lots of spells are cast in one area. Currently, it is presumed 1277 * when lots of spells are cast in one area. Currently, it is presumed
1476 * that flying non pickable objects are spell objects. 1278 * that flying non pickable objects are spell objects.
1477 */ 1279 */
1478
1479 while (top != NULL) 1280 while (top)
1480 { 1281 {
1481 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1282 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))
1482 floor = top; 1283 floor = top;
1483 1284
1484 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1285 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))
… …
1505 * If INS_ON_TOP is used, don't do this processing 1306 * If INS_ON_TOP is used, don't do this processing
1506 * Need to find the object that in fact blocks view, otherwise 1307 * Need to find the object that in fact blocks view, otherwise
1507 * stacking is a bit odd. 1308 * stacking is a bit odd.
1508 */ 1309 */
1509 if (!(flag & INS_ON_TOP) && 1310 if (!(flag & INS_ON_TOP) &&
1510 (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_BLOCKSVIEW) && (op->face && !op->face->visibility)) 1311 (get_map_flags (op->map, 0, op->x, op->y, 0, 0) & P_BLOCKSVIEW) && (op->face && !op->face->visibility))
1511 { 1312 {
1512 for (last = top; last != floor; last = last->below) 1313 for (last = top; last != floor; last = last->below)
1513 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1314 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1514 break; 1315 break;
1515 /* Check to see if we found the object that blocks view, 1316 /* Check to see if we found the object that blocks view,
… …
1537 op->above = GET_MAP_OB (op->map, op->x, op->y); 1338 op->above = GET_MAP_OB (op->map, op->x, op->y);
1538 1339
1539 if (op->above) 1340 if (op->above)
1540 op->above->below = op; 1341 op->above->below = op;
1541 1342
1542 op->below = NULL; 1343 op->below = 0;
1543 SET_MAP_OB (op->map, op->x, op->y, op); 1344 op->ms ().bot = op;
1544 } 1345 }
1545 else 1346 else
1546 { /* get inserted into the stack above top */ 1347 { /* get inserted into the stack above top */
1547 op->above = top->above; 1348 op->above = top->above;
1548 1349
… …
1551 1352
1552 op->below = top; 1353 op->below = top;
1553 top->above = op; 1354 top->above = op;
1554 } 1355 }
1555 1356
1556 if (op->above == NULL) 1357 if (!op->above)
1557 SET_MAP_TOP (op->map, op->x, op->y, op); 1358 op->ms ().top = op;
1558 } /* else not INS_BELOW_ORIGINATOR */ 1359 } /* else not INS_BELOW_ORIGINATOR */
1559 1360
1560 if (op->type == PLAYER) 1361 if (op->type == PLAYER)
1362 {
1561 op->contr->do_los = 1; 1363 op->contr->do_los = 1;
1364 ++op->map->players;
1365 op->map->last_access = runtime;
1366 }
1562 1367
1563 /* If we have a floor, we know the player, if any, will be above 1368 /* If we have a floor, we know the player, if any, will be above
1564 * it, so save a few ticks and start from there. 1369 * it, so save a few ticks and start from there.
1565 */ 1370 */
1566 if (!(flag & INS_MAP_LOAD)) 1371 if (!(flag & INS_MAP_LOAD))
1567 for (tmp = floor ? floor : GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1372 if (object *pl = op->ms ().player ())
1568 if (tmp->type == PLAYER) 1373 if (pl->contr->ns)
1569 tmp->contr->socket.update_look = 1; 1374 pl->contr->ns->floorbox_update ();
1570 1375
1571 /* If this object glows, it may affect lighting conditions that are 1376 /* If this object glows, it may affect lighting conditions that are
1572 * visible to others on this map. But update_all_los is really 1377 * visible to others on this map. But update_all_los is really
1573 * an inefficient way to do this, as it means los for all players 1378 * an inefficient way to do this, as it means los for all players
1574 * on the map will get recalculated. The players could very well 1379 * on the map will get recalculated. The players could very well
1575 * be far away from this change and not affected in any way - 1380 * be far away from this change and not affected in any way -
1576 * this should get redone to only look for players within range, 1381 * this should get redone to only look for players within range,
1577 * or just updating the P_NEED_UPDATE for spaces within this area 1382 * or just updating the P_NEED_UPDATE for spaces within this area
1578 * of effect may be sufficient. 1383 * of effect may be sufficient.
1579 */ 1384 */
1580 if (MAP_DARKNESS (op->map) && (op->glow_radius != 0)) 1385 if (op->map->darkness && (op->glow_radius != 0))
1581 update_all_los (op->map, op->x, op->y); 1386 update_all_los (op->map, op->x, op->y);
1582 1387
1583 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1388 /* updates flags (blocked, alive, no magic, etc) for this map space */
1584 update_object (op, UP_OBJ_INSERT); 1389 update_object (op, UP_OBJ_INSERT);
1585 1390
1391 INVOKE_OBJECT (INSERT, op);
1392
1586 /* Don't know if moving this to the end will break anything. However, 1393 /* Don't know if moving this to the end will break anything. However,
1587 * we want to have update_look set above before calling this. 1394 * we want to have floorbox_update called before calling this.
1588 * 1395 *
1589 * check_move_on() must be after this because code called from 1396 * check_move_on() must be after this because code called from
1590 * check_move_on() depends on correct map flags (so functions like 1397 * check_move_on() depends on correct map flags (so functions like
1591 * blocked() and wall() work properly), and these flags are updated by 1398 * blocked() and wall() work properly), and these flags are updated by
1592 * update_object(). 1399 * update_object().
… …
1594 1401
1595 /* if this is not the head or flag has been passed, don't check walk on status */ 1402 /* if this is not the head or flag has been passed, don't check walk on status */
1596 if (!(flag & INS_NO_WALK_ON) && !op->head) 1403 if (!(flag & INS_NO_WALK_ON) && !op->head)
1597 { 1404 {
1598 if (check_move_on (op, originator)) 1405 if (check_move_on (op, originator))
1599 return NULL; 1406 return 0;
1600 1407
1601 /* If we are a multi part object, lets work our way through the check 1408 /* If we are a multi part object, lets work our way through the check
1602 * walk on's. 1409 * walk on's.
1603 */ 1410 */
1604 for (tmp = op->more; tmp != NULL; tmp = tmp->more) 1411 for (tmp = op->more; tmp != NULL; tmp = tmp->more)
1605 if (check_move_on (tmp, originator)) 1412 if (check_move_on (tmp, originator))
1606 return NULL; 1413 return 0;
1607 } 1414 }
1608 1415
1609 return op; 1416 return op;
1610} 1417}
1611 1418
1612/* this function inserts an object in the map, but if it 1419/* this function inserts an object in the map, but if it
1613 * finds an object of its own type, it'll remove that one first. 1420 * finds an object of its own type, it'll remove that one first.
1614 * op is the object to insert it under: supplies x and the map. 1421 * op is the object to insert it under: supplies x and the map.
1615 */ 1422 */
1616void 1423void
1617replace_insert_ob_in_map (const char *arch_string, object *op) 1424replace_insert_ob_in_map (const char *arch_string, object *op)
1618{ 1425{
1619 object * 1426 object *tmp, *tmp1;
1620 tmp;
1621 object *
1622 tmp1;
1623 1427
1624 /* first search for itself and remove any old instances */ 1428 /* first search for itself and remove any old instances */
1625 1429
1626 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1430 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above)
1627 {
1628 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */ 1431 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */
1629 { 1432 tmp->destroy ();
1630 remove_ob (tmp);
1631 free_object (tmp);
1632 }
1633 }
1634 1433
1635 tmp1 = arch_to_object (find_archetype (arch_string)); 1434 tmp1 = arch_to_object (archetype::find (arch_string));
1636 1435
1637 tmp1->x = op->x; 1436 tmp1->x = op->x;
1638 tmp1->y = op->y; 1437 tmp1->y = op->y;
1639 insert_ob_in_map (tmp1, op->map, op, 0); 1438 insert_ob_in_map (tmp1, op->map, op, 0);
1439}
1440
1441object *
1442object::insert_at (object *where, object *originator, int flags)
1443{
1444 where->map->insert (this, where->x, where->y, originator, flags);
1640} 1445}
1641 1446
1642/* 1447/*
1643 * get_split_ob(ob,nr) splits up ob into two parts. The part which 1448 * get_split_ob(ob,nr) splits up ob into two parts. The part which
1644 * is returned contains nr objects, and the remaining parts contains 1449 * is returned contains nr objects, and the remaining parts contains
1645 * the rest (or is removed and freed if that number is 0). 1450 * the rest (or is removed and freed if that number is 0).
1646 * On failure, NULL is returned, and the reason put into the 1451 * On failure, NULL is returned, and the reason put into the
1647 * global static errmsg array. 1452 * global static errmsg array.
1648 */ 1453 */
1649
1650object * 1454object *
1651get_split_ob (object *orig_ob, uint32 nr) 1455get_split_ob (object *orig_ob, uint32 nr)
1652{ 1456{
1653 object * 1457 object *newob;
1654 newob;
1655 int
1656 is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0); 1458 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1657 1459
1658 if (orig_ob->nrof < nr) 1460 if (orig_ob->nrof < nr)
1659 { 1461 {
1660 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name); 1462 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1661 return NULL; 1463 return NULL;
1662 } 1464 }
1663 1465
1664 newob = object_create_clone (orig_ob); 1466 newob = object_create_clone (orig_ob);
1665 1467
1666 if ((orig_ob->nrof -= nr) < 1) 1468 if ((orig_ob->nrof -= nr) < 1)
1667 { 1469 orig_ob->destroy (1);
1668 if (!is_removed)
1669 remove_ob (orig_ob);
1670 free_object2 (orig_ob, 1);
1671 }
1672 else if (!is_removed) 1470 else if (!is_removed)
1673 { 1471 {
1674 if (orig_ob->env != NULL) 1472 if (orig_ob->env != NULL)
1675 sub_weight (orig_ob->env, orig_ob->weight * nr); 1473 sub_weight (orig_ob->env, orig_ob->weight * nr);
1676 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY) 1474 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY)
… …
1696 1494
1697object * 1495object *
1698decrease_ob_nr (object *op, uint32 i) 1496decrease_ob_nr (object *op, uint32 i)
1699{ 1497{
1700 object *tmp; 1498 object *tmp;
1701 player *pl;
1702 1499
1703 if (i == 0) /* objects with op->nrof require this check */ 1500 if (i == 0) /* objects with op->nrof require this check */
1704 return op; 1501 return op;
1705 1502
1706 if (i > op->nrof) 1503 if (i > op->nrof)
1707 i = op->nrof; 1504 i = op->nrof;
1708 1505
1709 if (QUERY_FLAG (op, FLAG_REMOVED)) 1506 if (QUERY_FLAG (op, FLAG_REMOVED))
1710 op->nrof -= i; 1507 op->nrof -= i;
1711 else if (op->env != NULL) 1508 else if (op->env)
1712 { 1509 {
1713 /* is this object in the players inventory, or sub container 1510 /* is this object in the players inventory, or sub container
1714 * therein? 1511 * therein?
1715 */ 1512 */
1716 tmp = is_player_inv (op->env); 1513 tmp = op->in_player ();
1717 /* nope. Is this a container the player has opened? 1514 /* nope. Is this a container the player has opened?
1718 * If so, set tmp to that player. 1515 * If so, set tmp to that player.
1719 * IMO, searching through all the players will mostly 1516 * IMO, searching through all the players will mostly
1720 * likely be quicker than following op->env to the map, 1517 * likely be quicker than following op->env to the map,
1721 * and then searching the map for a player. 1518 * and then searching the map for a player.
1722 */ 1519 */
1723 if (!tmp) 1520 if (!tmp)
1724 { 1521 for_all_players (pl)
1725 for (pl = first_player; pl; pl = pl->next)
1726 if (pl->ob->container == op->env) 1522 if (pl->ob->container == op->env)
1523 {
1524 tmp = pl->ob;
1727 break; 1525 break;
1728 if (pl)
1729 tmp = pl->ob;
1730 else
1731 tmp = NULL;
1732 } 1526 }
1733 1527
1734 if (i < op->nrof) 1528 if (i < op->nrof)
1735 { 1529 {
1736 sub_weight (op->env, op->weight * i); 1530 sub_weight (op->env, op->weight * i);
1737 op->nrof -= i; 1531 op->nrof -= i;
1738 if (tmp) 1532 if (tmp)
1739 {
1740 esrv_send_item (tmp, op); 1533 esrv_send_item (tmp, op);
1741 }
1742 } 1534 }
1743 else 1535 else
1744 { 1536 {
1745 remove_ob (op); 1537 op->remove ();
1746 op->nrof = 0; 1538 op->nrof = 0;
1747 if (tmp) 1539 if (tmp)
1748 {
1749 esrv_del_item (tmp->contr, op->count); 1540 esrv_del_item (tmp->contr, op->count);
1750 }
1751 } 1541 }
1752 } 1542 }
1753 else 1543 else
1754 { 1544 {
1755 object *above = op->above; 1545 object *above = op->above;
1756 1546
1757 if (i < op->nrof) 1547 if (i < op->nrof)
1758 op->nrof -= i; 1548 op->nrof -= i;
1759 else 1549 else
1760 { 1550 {
1761 remove_ob (op); 1551 op->remove ();
1762 op->nrof = 0; 1552 op->nrof = 0;
1763 } 1553 }
1764 1554
1765 /* Since we just removed op, op->above is null */ 1555 /* Since we just removed op, op->above is null */
1766 for (tmp = above; tmp != NULL; tmp = tmp->above) 1556 for (tmp = above; tmp; tmp = tmp->above)
1767 if (tmp->type == PLAYER) 1557 if (tmp->type == PLAYER)
1768 { 1558 {
1769 if (op->nrof) 1559 if (op->nrof)
1770 esrv_send_item (tmp, op); 1560 esrv_send_item (tmp, op);
1771 else 1561 else
… …
1775 1565
1776 if (op->nrof) 1566 if (op->nrof)
1777 return op; 1567 return op;
1778 else 1568 else
1779 { 1569 {
1780 free_object (op); 1570 op->destroy ();
1781 return NULL; 1571 return 0;
1782 } 1572 }
1783} 1573}
1784 1574
1785/* 1575/*
1786 * add_weight(object, weight) adds the specified weight to an object, 1576 * add_weight(object, weight) adds the specified weight to an object,
… …
1798 op->carrying += weight; 1588 op->carrying += weight;
1799 op = op->env; 1589 op = op->env;
1800 } 1590 }
1801} 1591}
1802 1592
1593object *
1594insert_ob_in_ob (object *op, object *where)
1595{
1596 if (!where)
1597 {
1598 char *dump = dump_object (op);
1599 LOG (llevError, "Trying to put object in NULL.\n%s\n", dump);
1600 free (dump);
1601 return op;
1602 }
1603
1604 if (where->head)
1605 {
1606 LOG (llevDebug, "Warning: Tried to insert object into wrong part of multipart object.\n");
1607 where = where->head;
1608 }
1609
1610 return where->insert (op);
1611}
1612
1803/* 1613/*
1804 * insert_ob_in_ob(op,environment): 1614 * env->insert (op)
1805 * This function inserts the object op in the linked list 1615 * This function inserts the object op in the linked list
1806 * inside the object environment. 1616 * inside the object environment.
1807 * 1617 *
1808 * Eneq(@csd.uu.se): Altered insert_ob_in_ob to make things picked up enter
1809 * the inventory at the last position or next to other objects of the same
1810 * type.
1811 * Frank: Now sorted by type, archetype and magic!
1812 *
1813 * The function returns now pointer to inserted item, and return value can 1618 * The function returns now pointer to inserted item, and return value can
1814 * be != op, if items are merged. -Tero 1619 * be != op, if items are merged. -Tero
1815 */ 1620 */
1816 1621
1817object * 1622object *
1818insert_ob_in_ob (object *op, object *where) 1623object::insert (object *op)
1819{ 1624{
1820 object * 1625 object *tmp, *otmp;
1821 tmp, *
1822 otmp;
1823 1626
1824 if (!QUERY_FLAG (op, FLAG_REMOVED)) 1627 if (!QUERY_FLAG (op, FLAG_REMOVED))
1825 { 1628 op->remove ();
1826 dump_object (op);
1827 LOG (llevError, "Trying to insert (ob) inserted object.\n%s\n", errmsg);
1828 return op;
1829 }
1830
1831 if (where == NULL)
1832 {
1833 dump_object (op);
1834 LOG (llevError, "Trying to put object in NULL.\n%s\n", errmsg);
1835 return op;
1836 }
1837
1838 if (where->head)
1839 {
1840 LOG (llevDebug, "Warning: Tried to insert object wrong part of multipart object.\n");
1841 where = where->head;
1842 }
1843 1629
1844 if (op->more) 1630 if (op->more)
1845 { 1631 {
1846 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count); 1632 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);
1847 return op; 1633 return op;
… …
1849 1635
1850 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL); 1636 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL);
1851 CLEAR_FLAG (op, FLAG_REMOVED); 1637 CLEAR_FLAG (op, FLAG_REMOVED);
1852 if (op->nrof) 1638 if (op->nrof)
1853 { 1639 {
1854 for (tmp = where->inv; tmp != NULL; tmp = tmp->below) 1640 for (tmp = inv; tmp != NULL; tmp = tmp->below)
1855 if (CAN_MERGE (tmp, op)) 1641 if (object::can_merge (tmp, op))
1856 { 1642 {
1857 /* return the original object and remove inserted object 1643 /* return the original object and remove inserted object
1858 (client needs the original object) */ 1644 (client needs the original object) */
1859 tmp->nrof += op->nrof; 1645 tmp->nrof += op->nrof;
1860 /* Weight handling gets pretty funky. Since we are adding to 1646 /* Weight handling gets pretty funky. Since we are adding to
1861 * tmp->nrof, we need to increase the weight. 1647 * tmp->nrof, we need to increase the weight.
1862 */ 1648 */
1863 add_weight (where, op->weight * op->nrof); 1649 add_weight (this, op->weight * op->nrof);
1864 SET_FLAG (op, FLAG_REMOVED); 1650 SET_FLAG (op, FLAG_REMOVED);
1865 free_object (op); /* free the inserted object */ 1651 op->destroy (); /* free the inserted object */
1866 op = tmp; 1652 op = tmp;
1867 remove_ob (op); /* and fix old object's links */ 1653 op->remove (); /* and fix old object's links */
1868 CLEAR_FLAG (op, FLAG_REMOVED); 1654 CLEAR_FLAG (op, FLAG_REMOVED);
1869 break; 1655 break;
1870 } 1656 }
1871 1657
1872 /* I assume combined objects have no inventory 1658 /* I assume combined objects have no inventory
1873 * We add the weight - this object could have just been removed 1659 * We add the weight - this object could have just been removed
1874 * (if it was possible to merge). calling remove_ob will subtract 1660 * (if it was possible to merge). calling remove_ob will subtract
1875 * the weight, so we need to add it in again, since we actually do 1661 * the weight, so we need to add it in again, since we actually do
1876 * the linking below 1662 * the linking below
1877 */ 1663 */
1878 add_weight (where, op->weight * op->nrof); 1664 add_weight (this, op->weight * op->nrof);
1879 } 1665 }
1880 else 1666 else
1881 add_weight (where, (op->weight + op->carrying)); 1667 add_weight (this, (op->weight + op->carrying));
1882 1668
1883 otmp = is_player_inv (where); 1669 otmp = this->in_player ();
1884 if (otmp && otmp->contr != NULL) 1670 if (otmp && otmp->contr)
1885 {
1886 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1671 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1887 fix_player (otmp); 1672 otmp->update_stats ();
1888 }
1889 1673
1890 op->map = NULL; 1674 op->map = 0;
1891 op->env = where; 1675 op->env = this;
1892 op->above = NULL; 1676 op->above = 0;
1893 op->below = NULL; 1677 op->below = 0;
1894 op->x = 0, op->y = 0; 1678 op->x = 0, op->y = 0;
1895 1679
1896 /* reset the light list and los of the players on the map */ 1680 /* reset the light list and los of the players on the map */
1897 if ((op->glow_radius != 0) && where->map) 1681 if ((op->glow_radius != 0) && map)
1898 { 1682 {
1899#ifdef DEBUG_LIGHTS 1683#ifdef DEBUG_LIGHTS
1900 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name); 1684 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1901#endif /* DEBUG_LIGHTS */ 1685#endif /* DEBUG_LIGHTS */
1902 if (MAP_DARKNESS (where->map)) 1686 if (map->darkness)
1903 update_all_los (where->map, where->x, where->y); 1687 update_all_los (map, x, y);
1904 } 1688 }
1905 1689
1906 /* Client has no idea of ordering so lets not bother ordering it here. 1690 /* Client has no idea of ordering so lets not bother ordering it here.
1907 * It sure simplifies this function... 1691 * It sure simplifies this function...
1908 */ 1692 */
1909 if (where->inv == NULL) 1693 if (!inv)
1910 where->inv = op; 1694 inv = op;
1911 else 1695 else
1912 { 1696 {
1913 op->below = where->inv; 1697 op->below = inv;
1914 op->below->above = op; 1698 op->below->above = op;
1915 where->inv = op; 1699 inv = op;
1916 } 1700 }
1701
1702 INVOKE_OBJECT (INSERT, this);
1703
1917 return op; 1704 return op;
1918} 1705}
1919 1706
1920/* 1707/*
1921 * Checks if any objects has a move_type that matches objects 1708 * Checks if any objects has a move_type that matches objects
… …
1935 * 1722 *
1936 * MSW 2001-07-08: Check all objects on space, not just those below 1723 * MSW 2001-07-08: Check all objects on space, not just those below
1937 * object being inserted. insert_ob_in_map may not put new objects 1724 * object being inserted. insert_ob_in_map may not put new objects
1938 * on top. 1725 * on top.
1939 */ 1726 */
1940
1941int 1727int
1942check_move_on (object *op, object *originator) 1728check_move_on (object *op, object *originator)
1943{ 1729{
1944 object * 1730 object *tmp;
1945 tmp; 1731 maptile *m = op->map;
1946 tag_t
1947 tag;
1948 mapstruct *
1949 m = op->map;
1950 int
1951 x = op->x, y = op->y; 1732 int x = op->x, y = op->y;
1952 1733
1953 MoveType 1734 MoveType move_on, move_slow, move_block;
1954 move_on,
1955 move_slow,
1956 move_block;
1957 1735
1958 if (QUERY_FLAG (op, FLAG_NO_APPLY)) 1736 if (QUERY_FLAG (op, FLAG_NO_APPLY))
1959 return 0; 1737 return 0;
1960
1961 tag = op->count;
1962 1738
1963 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y); 1739 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
1964 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y); 1740 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
1965 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y); 1741 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
1966 1742
… …
1982 1758
1983 /* The objects have to be checked from top to bottom. 1759 /* The objects have to be checked from top to bottom.
1984 * Hence, we first go to the top: 1760 * Hence, we first go to the top:
1985 */ 1761 */
1986 1762
1987 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL && tmp->above != NULL; tmp = tmp->above) 1763 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp && tmp->above; tmp = tmp->above)
1988 { 1764 {
1989 /* Trim the search when we find the first other spell effect 1765 /* Trim the search when we find the first other spell effect
1990 * this helps performance so that if a space has 50 spell objects, 1766 * this helps performance so that if a space has 50 spell objects,
1991 * we don't need to check all of them. 1767 * we don't need to check all of them.
1992 */ 1768 */
… …
2027 if ((!op->move_type && tmp->move_on & MOVE_WALK) || 1803 if ((!op->move_type && tmp->move_on & MOVE_WALK) ||
2028 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0)) 1804 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0))
2029 { 1805 {
2030 move_apply (tmp, op, originator); 1806 move_apply (tmp, op, originator);
2031 1807
2032 if (was_destroyed (op, tag)) 1808 if (op->destroyed ())
2033 return 1; 1809 return 1;
2034 1810
2035 /* what the person/creature stepped onto has moved the object 1811 /* what the person/creature stepped onto has moved the object
2036 * someplace new. Don't process any further - if we did, 1812 * someplace new. Don't process any further - if we did,
2037 * have a feeling strange problems would result. 1813 * have a feeling strange problems would result.
… …
2047/* 1823/*
2048 * present_arch(arch, map, x, y) searches for any objects with 1824 * present_arch(arch, map, x, y) searches for any objects with
2049 * a matching archetype at the given map and coordinates. 1825 * a matching archetype at the given map and coordinates.
2050 * The first matching object is returned, or NULL if none. 1826 * The first matching object is returned, or NULL if none.
2051 */ 1827 */
2052
2053object * 1828object *
2054present_arch (const archetype *at, mapstruct *m, int x, int y) 1829present_arch (const archetype *at, maptile *m, int x, int y)
2055{ 1830{
2056 object *
2057 tmp;
2058
2059 if (m == NULL || out_of_map (m, x, y)) 1831 if (m == NULL || out_of_map (m, x, y))
2060 { 1832 {
2061 LOG (llevError, "Present_arch called outside map.\n"); 1833 LOG (llevError, "Present_arch called outside map.\n");
2062 return NULL; 1834 return NULL;
2063 } 1835 }
1836
2064 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1837 for (object *tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above)
2065 if (tmp->arch == at) 1838 if (tmp->arch == at)
2066 return tmp; 1839 return tmp;
1840
2067 return NULL; 1841 return NULL;
2068} 1842}
2069 1843
2070/* 1844/*
2071 * present(type, map, x, y) searches for any objects with 1845 * present(type, map, x, y) searches for any objects with
2072 * a matching type variable at the given map and coordinates. 1846 * a matching type variable at the given map and coordinates.
2073 * The first matching object is returned, or NULL if none. 1847 * The first matching object is returned, or NULL if none.
2074 */ 1848 */
2075
2076object * 1849object *
2077present (unsigned char type, mapstruct *m, int x, int y) 1850present (unsigned char type, maptile *m, int x, int y)
2078{ 1851{
2079 object *
2080 tmp;
2081
2082 if (out_of_map (m, x, y)) 1852 if (out_of_map (m, x, y))
2083 { 1853 {
2084 LOG (llevError, "Present called outside map.\n"); 1854 LOG (llevError, "Present called outside map.\n");
2085 return NULL; 1855 return NULL;
2086 } 1856 }
1857
2087 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1858 for (object *tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above)
2088 if (tmp->type == type) 1859 if (tmp->type == type)
2089 return tmp; 1860 return tmp;
1861
2090 return NULL; 1862 return NULL;
2091} 1863}
2092 1864
2093/* 1865/*
2094 * present_in_ob(type, object) searches for any objects with 1866 * present_in_ob(type, object) searches for any objects with
2095 * a matching type variable in the inventory of the given object. 1867 * a matching type variable in the inventory of the given object.
2096 * The first matching object is returned, or NULL if none. 1868 * The first matching object is returned, or NULL if none.
2097 */ 1869 */
2098
2099object * 1870object *
2100present_in_ob (unsigned char type, const object *op) 1871present_in_ob (unsigned char type, const object *op)
2101{ 1872{
2102 object *
2103 tmp;
2104
2105 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1873 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2106 if (tmp->type == type) 1874 if (tmp->type == type)
2107 return tmp; 1875 return tmp;
1876
2108 return NULL; 1877 return NULL;
2109} 1878}
2110 1879
2111/* 1880/*
2112 * present_in_ob (type, str, object) searches for any objects with 1881 * present_in_ob (type, str, object) searches for any objects with
… …
2120 * str is the string to match against. Note that we match against 1889 * str is the string to match against. Note that we match against
2121 * the object name, not the archetype name. this is so that the 1890 * the object name, not the archetype name. this is so that the
2122 * spell code can use one object type (force), but change it's name 1891 * spell code can use one object type (force), but change it's name
2123 * to be unique. 1892 * to be unique.
2124 */ 1893 */
2125
2126object * 1894object *
2127present_in_ob_by_name (int type, const char *str, const object *op) 1895present_in_ob_by_name (int type, const char *str, const object *op)
2128{ 1896{
2129 object *
2130 tmp;
2131
2132 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1897 for (object *tmp = op->inv; tmp; tmp = tmp->below)
2133 {
2134 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name))) 1898 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name)))
2135 return tmp; 1899 return tmp;
2136 } 1900
2137 return NULL; 1901 return 0;
2138} 1902}
2139 1903
2140/* 1904/*
2141 * present_arch_in_ob(archetype, object) searches for any objects with 1905 * present_arch_in_ob(archetype, object) searches for any objects with
2142 * a matching archetype in the inventory of the given object. 1906 * a matching archetype in the inventory of the given object.
2143 * The first matching object is returned, or NULL if none. 1907 * The first matching object is returned, or NULL if none.
2144 */ 1908 */
2145
2146object * 1909object *
2147present_arch_in_ob (const archetype *at, const object *op) 1910present_arch_in_ob (const archetype *at, const object *op)
2148{ 1911{
2149 object *
2150 tmp;
2151
2152 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1912 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2153 if (tmp->arch == at) 1913 if (tmp->arch == at)
2154 return tmp; 1914 return tmp;
1915
2155 return NULL; 1916 return NULL;
2156} 1917}
2157 1918
2158/* 1919/*
2159 * activate recursively a flag on an object inventory 1920 * activate recursively a flag on an object inventory
2160 */ 1921 */
2161void 1922void
2162flag_inv (object *op, int flag) 1923flag_inv (object *op, int flag)
2163{ 1924{
2164 object *
2165 tmp;
2166
2167 if (op->inv) 1925 if (op->inv)
2168 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1926 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2169 { 1927 {
2170 SET_FLAG (tmp, flag); 1928 SET_FLAG (tmp, flag);
2171 flag_inv (tmp, flag); 1929 flag_inv (tmp, flag);
2172 } 1930 }
2173} /* 1931}
1932
1933/*
2174 * desactivate recursively a flag on an object inventory 1934 * deactivate recursively a flag on an object inventory
2175 */ 1935 */
2176void 1936void
2177unflag_inv (object *op, int flag) 1937unflag_inv (object *op, int flag)
2178{ 1938{
2179 object *
2180 tmp;
2181
2182 if (op->inv) 1939 if (op->inv)
2183 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1940 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2184 { 1941 {
2185 CLEAR_FLAG (tmp, flag); 1942 CLEAR_FLAG (tmp, flag);
2186 unflag_inv (tmp, flag); 1943 unflag_inv (tmp, flag);
2187 } 1944 }
2188} 1945}
… …
2191 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in 1948 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in
2192 * all it's inventory (recursively). 1949 * all it's inventory (recursively).
2193 * If checksums are used, a player will get set_cheat called for 1950 * If checksums are used, a player will get set_cheat called for
2194 * him/her-self and all object carried by a call to this function. 1951 * him/her-self and all object carried by a call to this function.
2195 */ 1952 */
2196
2197void 1953void
2198set_cheat (object *op) 1954set_cheat (object *op)
2199{ 1955{
2200 SET_FLAG (op, FLAG_WAS_WIZ); 1956 SET_FLAG (op, FLAG_WAS_WIZ);
2201 flag_inv (op, FLAG_WAS_WIZ); 1957 flag_inv (op, FLAG_WAS_WIZ);
… …
2220 * because arch_blocked (now ob_blocked) needs to know the movement type 1976 * because arch_blocked (now ob_blocked) needs to know the movement type
2221 * to know if the space in question will block the object. We can't use 1977 * to know if the space in question will block the object. We can't use
2222 * the archetype because that isn't correct if the monster has been 1978 * the archetype because that isn't correct if the monster has been
2223 * customized, changed states, etc. 1979 * customized, changed states, etc.
2224 */ 1980 */
2225
2226int 1981int
2227find_free_spot (const object *ob, mapstruct *m, int x, int y, int start, int stop) 1982find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)
2228{ 1983{
2229 int
2230 i,
2231 index = 0, flag; 1984 int index = 0, flag;
2232 static int
2233 altern[SIZEOFFREE]; 1985 int altern[SIZEOFFREE];
2234 1986
2235 for (i = start; i < stop; i++) 1987 for (int i = start; i < stop; i++)
2236 { 1988 {
2237 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]); 1989 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]);
2238 if (!flag) 1990 if (!flag)
2239 altern[index++] = i; 1991 altern [index++] = i;
2240 1992
2241 /* Basically, if we find a wall on a space, we cut down the search size. 1993 /* Basically, if we find a wall on a space, we cut down the search size.
2242 * In this way, we won't return spaces that are on another side of a wall. 1994 * In this way, we won't return spaces that are on another side of a wall.
2243 * This mostly work, but it cuts down the search size in all directions - 1995 * This mostly work, but it cuts down the search size in all directions -
2244 * if the space being examined only has a wall to the north and empty 1996 * if the space being examined only has a wall to the north and empty
2245 * spaces in all the other directions, this will reduce the search space 1997 * spaces in all the other directions, this will reduce the search space
2246 * to only the spaces immediately surrounding the target area, and 1998 * to only the spaces immediately surrounding the target area, and
2247 * won't look 2 spaces south of the target space. 1999 * won't look 2 spaces south of the target space.
2248 */ 2000 */
2249 else if ((flag & AB_NO_PASS) && maxfree[i] < stop) 2001 else if ((flag & P_NO_PASS) && maxfree[i] < stop)
2250 stop = maxfree[i]; 2002 stop = maxfree[i];
2251 } 2003 }
2004
2252 if (!index) 2005 if (!index)
2253 return -1; 2006 return -1;
2007
2254 return altern[RANDOM () % index]; 2008 return altern[RANDOM () % index];
2255} 2009}
2256 2010
2257/* 2011/*
2258 * find_first_free_spot(archetype, mapstruct, x, y) works like 2012 * find_first_free_spot(archetype, maptile, x, y) works like
2259 * find_free_spot(), but it will search max number of squares. 2013 * find_free_spot(), but it will search max number of squares.
2260 * But it will return the first available spot, not a random choice. 2014 * But it will return the first available spot, not a random choice.
2261 * Changed 0.93.2: Have it return -1 if there is no free spot available. 2015 * Changed 0.93.2: Have it return -1 if there is no free spot available.
2262 */ 2016 */
2263
2264int 2017int
2265find_first_free_spot (const object *ob, mapstruct *m, int x, int y) 2018find_first_free_spot (const object *ob, maptile *m, int x, int y)
2266{ 2019{
2267 int
2268 i;
2269
2270 for (i = 0; i < SIZEOFFREE; i++) 2020 for (int i = 0; i < SIZEOFFREE; i++)
2271 {
2272 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i])) 2021 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]))
2273 return i; 2022 return i;
2274 } 2023
2275 return -1; 2024 return -1;
2276} 2025}
2277 2026
2278/* 2027/*
2279 * The function permute(arr, begin, end) randomly reorders the array 2028 * The function permute(arr, begin, end) randomly reorders the array
2280 * arr[begin..end-1]. 2029 * arr[begin..end-1].
2030 * now uses a fisher-yates shuffle, old permute was broken
2281 */ 2031 */
2282static void 2032static void
2283permute (int *arr, int begin, int end) 2033permute (int *arr, int begin, int end)
2284{ 2034{
2285 int 2035 arr += begin;
2286 i,
2287 j,
2288 tmp,
2289 len;
2290
2291 len = end - begin; 2036 end -= begin;
2292 for (i = begin; i < end; i++)
2293 {
2294 j = begin + RANDOM () % len;
2295 2037
2296 tmp = arr[i]; 2038 while (--end)
2297 arr[i] = arr[j]; 2039 swap (arr [end], arr [RANDOM () % (end + 1)]);
2298 arr[j] = tmp;
2299 }
2300} 2040}
2301 2041
2302/* new function to make monster searching more efficient, and effective! 2042/* new function to make monster searching more efficient, and effective!
2303 * This basically returns a randomized array (in the passed pointer) of 2043 * This basically returns a randomized array (in the passed pointer) of
2304 * the spaces to find monsters. In this way, it won't always look for 2044 * the spaces to find monsters. In this way, it won't always look for
… …
2307 * the 3x3 area will be searched, just not in a predictable order. 2047 * the 3x3 area will be searched, just not in a predictable order.
2308 */ 2048 */
2309void 2049void
2310get_search_arr (int *search_arr) 2050get_search_arr (int *search_arr)
2311{ 2051{
2312 int 2052 int i;
2313 i;
2314 2053
2315 for (i = 0; i < SIZEOFFREE; i++) 2054 for (i = 0; i < SIZEOFFREE; i++)
2316 {
2317 search_arr[i] = i; 2055 search_arr[i] = i;
2318 }
2319 2056
2320 permute (search_arr, 1, SIZEOFFREE1 + 1); 2057 permute (search_arr, 1, SIZEOFFREE1 + 1);
2321 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1); 2058 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1);
2322 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE); 2059 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE);
2323} 2060}
… …
2332 * Perhaps incorrectly, but I'm making the assumption that exclude 2069 * Perhaps incorrectly, but I'm making the assumption that exclude
2333 * is actually want is going to try and move there. We need this info 2070 * is actually want is going to try and move there. We need this info
2334 * because we have to know what movement the thing looking to move 2071 * because we have to know what movement the thing looking to move
2335 * there is capable of. 2072 * there is capable of.
2336 */ 2073 */
2337
2338int 2074int
2339find_dir (mapstruct *m, int x, int y, object *exclude) 2075find_dir (maptile *m, int x, int y, object *exclude)
2340{ 2076{
2341 int
2342 i,
2343 max = SIZEOFFREE, mflags; 2077 int i, max = SIZEOFFREE, mflags;
2344 2078
2345 sint16 nx, ny; 2079 sint16 nx, ny;
2346 object * 2080 object *tmp;
2347 tmp; 2081 maptile *mp;
2348 mapstruct *
2349 mp;
2350 2082
2351 MoveType blocked, move_type; 2083 MoveType blocked, move_type;
2352 2084
2353 if (exclude && exclude->head) 2085 if (exclude && exclude->head)
2354 { 2086 {
… …
2366 mp = m; 2098 mp = m;
2367 nx = x + freearr_x[i]; 2099 nx = x + freearr_x[i];
2368 ny = y + freearr_y[i]; 2100 ny = y + freearr_y[i];
2369 2101
2370 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2102 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);
2103
2371 if (mflags & P_OUT_OF_MAP) 2104 if (mflags & P_OUT_OF_MAP)
2372 {
2373 max = maxfree[i]; 2105 max = maxfree[i];
2374 }
2375 else 2106 else
2376 { 2107 {
2377 blocked = GET_MAP_MOVE_BLOCK (mp, nx, ny); 2108 mapspace &ms = mp->at (nx, ny);
2109
2110 blocked = ms.move_block;
2378 2111
2379 if ((move_type & blocked) == move_type) 2112 if ((move_type & blocked) == move_type)
2380 {
2381 max = maxfree[i]; 2113 max = maxfree[i];
2382 }
2383 else if (mflags & P_IS_ALIVE) 2114 else if (mflags & P_IS_ALIVE)
2384 { 2115 {
2385 for (tmp = GET_MAP_OB (mp, nx, ny); tmp != NULL; tmp = tmp->above) 2116 for (tmp = ms.bot; tmp; tmp = tmp->above)
2386 { 2117 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)
2387 if ((QUERY_FLAG (tmp, FLAG_MONSTER) || tmp->type == PLAYER) && (tmp != exclude || (tmp->head && tmp->head != exclude))) 2118 && (tmp != exclude || (tmp->head && tmp->head != exclude)))
2388 {
2389 break; 2119 break;
2390 } 2120
2391 }
2392 if (tmp) 2121 if (tmp)
2393 {
2394 return freedir[i]; 2122 return freedir[i];
2395 }
2396 } 2123 }
2397 } 2124 }
2398 } 2125 }
2126
2399 return 0; 2127 return 0;
2400} 2128}
2401 2129
2402/* 2130/*
2403 * distance(object 1, object 2) will return the square of the 2131 * distance(object 1, object 2) will return the square of the
2404 * distance between the two given objects. 2132 * distance between the two given objects.
2405 */ 2133 */
2406
2407int 2134int
2408distance (const object *ob1, const object *ob2) 2135distance (const object *ob1, const object *ob2)
2409{ 2136{
2410 int
2411 i;
2412
2413 i = (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y); 2137 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2414 return i;
2415} 2138}
2416 2139
2417/* 2140/*
2418 * find_dir_2(delta-x,delta-y) will return a direction in which 2141 * find_dir_2(delta-x,delta-y) will return a direction in which
2419 * an object which has subtracted the x and y coordinates of another 2142 * an object which has subtracted the x and y coordinates of another
2420 * object, needs to travel toward it. 2143 * object, needs to travel toward it.
2421 */ 2144 */
2422
2423int 2145int
2424find_dir_2 (int x, int y) 2146find_dir_2 (int x, int y)
2425{ 2147{
2426 int 2148 int q;
2427 q;
2428 2149
2429 if (y) 2150 if (y)
2430 q = x * 100 / y; 2151 q = x * 100 / y;
2431 else if (x) 2152 else if (x)
2432 q = -300 * x; 2153 q = -300 * x;
… …
2467int 2188int
2468absdir (int d) 2189absdir (int d)
2469{ 2190{
2470 while (d < 1) 2191 while (d < 1)
2471 d += 8; 2192 d += 8;
2193
2472 while (d > 8) 2194 while (d > 8)
2473 d -= 8; 2195 d -= 8;
2196
2474 return d; 2197 return d;
2475} 2198}
2476 2199
2477/* 2200/*
2478 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is 2201 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is
… …
2480 */ 2203 */
2481 2204
2482int 2205int
2483dirdiff (int dir1, int dir2) 2206dirdiff (int dir1, int dir2)
2484{ 2207{
2485 int 2208 int d;
2486 d;
2487 2209
2488 d = abs (dir1 - dir2); 2210 d = abs (dir1 - dir2);
2489 if (d > 4) 2211 if (d > 4)
2490 d = 8 - d; 2212 d = 8 - d;
2213
2491 return d; 2214 return d;
2492} 2215}
2493 2216
2494/* peterm: 2217/* peterm:
2495 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster. 2218 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster.
… …
2498 * This basically means that if direction is 15, then it could either go 2221 * This basically means that if direction is 15, then it could either go
2499 * direction 4, 14, or 16 to get back to where we are. 2222 * direction 4, 14, or 16 to get back to where we are.
2500 * Moved from spell_util.c to object.c with the other related direction 2223 * Moved from spell_util.c to object.c with the other related direction
2501 * functions. 2224 * functions.
2502 */ 2225 */
2503
2504int
2505 reduction_dir[SIZEOFFREE][3] = { 2226int reduction_dir[SIZEOFFREE][3] = {
2506 {0, 0, 0}, /* 0 */ 2227 {0, 0, 0}, /* 0 */
2507 {0, 0, 0}, /* 1 */ 2228 {0, 0, 0}, /* 1 */
2508 {0, 0, 0}, /* 2 */ 2229 {0, 0, 0}, /* 2 */
2509 {0, 0, 0}, /* 3 */ 2230 {0, 0, 0}, /* 3 */
2510 {0, 0, 0}, /* 4 */ 2231 {0, 0, 0}, /* 4 */
… …
2558 * find a path to that monster that we found. If not, 2279 * find a path to that monster that we found. If not,
2559 * we don't bother going toward it. Returns 1 if we 2280 * we don't bother going toward it. Returns 1 if we
2560 * can see a direct way to get it 2281 * can see a direct way to get it
2561 * Modified to be map tile aware -.MSW 2282 * Modified to be map tile aware -.MSW
2562 */ 2283 */
2563
2564
2565int 2284int
2566can_see_monsterP (mapstruct *m, int x, int y, int dir) 2285can_see_monsterP (maptile *m, int x, int y, int dir)
2567{ 2286{
2568 sint16 dx, dy; 2287 sint16 dx, dy;
2569 int
2570 mflags; 2288 int mflags;
2571 2289
2572 if (dir < 0) 2290 if (dir < 0)
2573 return 0; /* exit condition: invalid direction */ 2291 return 0; /* exit condition: invalid direction */
2574 2292
2575 dx = x + freearr_x[dir]; 2293 dx = x + freearr_x[dir];
… …
2588 return 0; 2306 return 0;
2589 2307
2590 /* yes, can see. */ 2308 /* yes, can see. */
2591 if (dir < 9) 2309 if (dir < 9)
2592 return 1; 2310 return 1;
2311
2593 return can_see_monsterP (m, x, y, reduction_dir[dir][0]) | 2312 return can_see_monsterP (m, x, y, reduction_dir[dir][0])
2594 can_see_monsterP (m, x, y, reduction_dir[dir][1]) | can_see_monsterP (m, x, y, reduction_dir[dir][2]); 2313 | can_see_monsterP (m, x, y, reduction_dir[dir][1])
2314 | can_see_monsterP (m, x, y, reduction_dir[dir][2]);
2595} 2315}
2596
2597
2598 2316
2599/* 2317/*
2600 * can_pick(picker, item): finds out if an object is possible to be 2318 * can_pick(picker, item): finds out if an object is possible to be
2601 * picked up by the picker. Returnes 1 if it can be 2319 * picked up by the picker. Returnes 1 if it can be
2602 * picked up, otherwise 0. 2320 * picked up, otherwise 0.
… …
2613 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2331 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2614 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2332 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2615 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2333 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));
2616} 2334}
2617 2335
2618
2619/* 2336/*
2620 * create clone from object to another 2337 * create clone from object to another
2621 */ 2338 */
2622object * 2339object *
2623object_create_clone (object *asrc) 2340object_create_clone (object *asrc)
2624{ 2341{
2625 object *
2626 dst = NULL, *tmp, *src, *part, *prev, *item; 2342 object *dst = 0, *tmp, *src, *part, *prev, *item;
2627 2343
2628 if (!asrc) 2344 if (!asrc)
2629 return NULL; 2345 return 0;
2346
2630 src = asrc; 2347 src = asrc;
2631 if (src->head) 2348 if (src->head)
2632 src = src->head; 2349 src = src->head;
2633 2350
2634 prev = NULL; 2351 prev = 0;
2635 for (part = src; part; part = part->more) 2352 for (part = src; part; part = part->more)
2636 { 2353 {
2637 tmp = get_object (); 2354 tmp = part->clone ();
2638 copy_object (part, tmp);
2639 tmp->x -= src->x; 2355 tmp->x -= src->x;
2640 tmp->y -= src->y; 2356 tmp->y -= src->y;
2357
2641 if (!part->head) 2358 if (!part->head)
2642 { 2359 {
2643 dst = tmp; 2360 dst = tmp;
2644 tmp->head = NULL; 2361 tmp->head = 0;
2645 } 2362 }
2646 else 2363 else
2647 {
2648 tmp->head = dst; 2364 tmp->head = dst;
2649 } 2365
2650 tmp->more = NULL; 2366 tmp->more = 0;
2367
2651 if (prev) 2368 if (prev)
2652 prev->more = tmp; 2369 prev->more = tmp;
2370
2653 prev = tmp; 2371 prev = tmp;
2654 } 2372 }
2655 2373
2656 /*** copy inventory ***/
2657 for (item = src->inv; item; item = item->below) 2374 for (item = src->inv; item; item = item->below)
2658 {
2659 (void) insert_ob_in_ob (object_create_clone (item), dst); 2375 insert_ob_in_ob (object_create_clone (item), dst);
2660 }
2661 2376
2662 return dst; 2377 return dst;
2663} 2378}
2664 2379
2665/* return true if the object was destroyed, 0 otherwise */
2666int
2667was_destroyed (const object *op, tag_t old_tag)
2668{
2669 /* checking for FLAG_FREED isn't necessary, but makes this function more
2670 * robust */
2671 return op->count != old_tag || QUERY_FLAG (op, FLAG_FREED);
2672}
2673
2674/* GROS - Creates an object using a string representing its content. */ 2380/* GROS - Creates an object using a string representing its content. */
2675
2676/* Basically, we save the content of the string to a temp file, then call */ 2381/* Basically, we save the content of the string to a temp file, then call */
2677
2678/* load_object on it. I admit it is a highly inefficient way to make things, */ 2382/* load_object on it. I admit it is a highly inefficient way to make things, */
2679
2680/* but it was simple to make and allows reusing the load_object function. */ 2383/* but it was simple to make and allows reusing the load_object function. */
2681
2682/* Remember not to use load_object_str in a time-critical situation. */ 2384/* Remember not to use load_object_str in a time-critical situation. */
2683
2684/* Also remember that multiparts objects are not supported for now. */ 2385/* Also remember that multiparts objects are not supported for now. */
2685
2686object * 2386object *
2687load_object_str (const char *obstr) 2387load_object_str (const char *obstr)
2688{ 2388{
2689 object * 2389 object *op;
2690 op;
2691 char
2692 filename[MAX_BUF]; 2390 char filename[MAX_BUF];
2693 2391
2694 sprintf (filename, "%s/cfloadobstr2044", settings.tmpdir); 2392 sprintf (filename, "%s/cfloadobstr2044", settings.tmpdir);
2695 2393
2696 FILE *
2697 tempfile = fopen (filename, "w"); 2394 FILE *tempfile = fopen (filename, "w");
2698 2395
2699 if (tempfile == NULL) 2396 if (tempfile == NULL)
2700 { 2397 {
2701 LOG (llevError, "Error - Unable to access load object temp file\n"); 2398 LOG (llevError, "Error - Unable to access load object temp file\n");
2702 return NULL; 2399 return NULL;
2703 } 2400 }
2704 2401
2705 fprintf (tempfile, obstr); 2402 fprintf (tempfile, obstr);
2706 fclose (tempfile); 2403 fclose (tempfile);
2707 2404
2708 op = get_object (); 2405 op = object::create ();
2709 2406
2710 object_thawer thawer (filename); 2407 object_thawer thawer (filename);
2711 2408
2712 if (thawer) 2409 if (thawer)
2713 load_object (thawer, op, 0); 2410 load_object (thawer, op, 0);
… …
2723 * returns NULL if no match. 2420 * returns NULL if no match.
2724 */ 2421 */
2725object * 2422object *
2726find_obj_by_type_subtype (const object *who, int type, int subtype) 2423find_obj_by_type_subtype (const object *who, int type, int subtype)
2727{ 2424{
2728 object *
2729 tmp;
2730
2731 for (tmp = who->inv; tmp; tmp = tmp->below) 2425 for (object *tmp = who->inv; tmp; tmp = tmp->below)
2732 if (tmp->type == type && tmp->subtype == subtype) 2426 if (tmp->type == type && tmp->subtype == subtype)
2733 return tmp; 2427 return tmp;
2734 2428
2735 return NULL; 2429 return 0;
2736} 2430}
2737 2431
2738/* If ob has a field named key, return the link from the list, 2432/* If ob has a field named key, return the link from the list,
2739 * otherwise return NULL. 2433 * otherwise return NULL.
2740 * 2434 *
… …
2742 * do the desired thing. 2436 * do the desired thing.
2743 */ 2437 */
2744key_value * 2438key_value *
2745get_ob_key_link (const object *ob, const char *key) 2439get_ob_key_link (const object *ob, const char *key)
2746{ 2440{
2747 key_value *
2748 link;
2749
2750 for (link = ob->key_values; link != NULL; link = link->next) 2441 for (key_value *link = ob->key_values; link; link = link->next)
2751 {
2752 if (link->key == key) 2442 if (link->key == key)
2753 {
2754 return link; 2443 return link;
2755 }
2756 }
2757 2444
2758 return NULL; 2445 return 0;
2759} 2446}
2760 2447
2761/* 2448/*
2762 * Returns the value of op has an extra_field for key, or NULL. 2449 * Returns the value of op has an extra_field for key, or NULL.
2763 * 2450 *
… …
2803 * Returns TRUE on success. 2490 * Returns TRUE on success.
2804 */ 2491 */
2805int 2492int
2806set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key) 2493set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2807{ 2494{
2808 key_value *
2809 field = NULL, *last = NULL; 2495 key_value *field = NULL, *last = NULL;
2810 2496
2811 for (field = op->key_values; field != NULL; field = field->next) 2497 for (field = op->key_values; field != NULL; field = field->next)
2812 { 2498 {
2813 if (field->key != canonical_key) 2499 if (field->key != canonical_key)
2814 { 2500 {
… …
2842 /* IF we get here, key doesn't exist */ 2528 /* IF we get here, key doesn't exist */
2843 2529
2844 /* No field, we'll have to add it. */ 2530 /* No field, we'll have to add it. */
2845 2531
2846 if (!add_key) 2532 if (!add_key)
2847 {
2848 return FALSE; 2533 return FALSE;
2849 } 2534
2850 /* There isn't any good reason to store a null 2535 /* There isn't any good reason to store a null
2851 * value in the key/value list. If the archetype has 2536 * value in the key/value list. If the archetype has
2852 * this key, then we should also have it, so shouldn't 2537 * this key, then we should also have it, so shouldn't
2853 * be here. If user wants to store empty strings, 2538 * be here. If user wants to store empty strings,
2854 * should pass in "" 2539 * should pass in ""
… …
2903 } 2588 }
2904 else 2589 else
2905 item = item->env; 2590 item = item->env;
2906} 2591}
2907 2592
2593
2594const char *
2595object::flag_desc (char *desc, int len) const
2596{
2597 char *p = desc;
2598 bool first = true;
2599
2600 for (int i = 0; i < NUM_FLAGS; i++)
2601 {
2602 if (len <= 10) // magic constant!
2603 {
2604 snprintf (p, len, ",...");
2605 break;
2606 }
2607
2608 if (flag[i])
2609 {
2610 int cnt = snprintf (p, len, "%s%d", first ? "" : ",", i);
2611 len -= cnt;
2612 p += cnt;
2613 first = false;
2614 }
2615 }
2616
2617 return desc;
2618}
2619
2908// return a suitable string describing an objetc in enough detail to find it 2620// return a suitable string describing an objetc in enough detail to find it
2909const char * 2621const char *
2910object::debug_desc (char *info) const 2622object::debug_desc (char *info) const
2911{ 2623{
2624 char flagdesc[512];
2912 char info2[256 * 3]; 2625 char info2[256 * 4];
2913 char *p = info; 2626 char *p = info;
2914 2627
2915 p += snprintf (p, 256, "%d=\"%s%s%s\"", 2628 p += snprintf (p, 512, "{cnt:%d,uuid:<1,%" PRIx64 ">,name:\"%s%s%s\",flags:[%s],type:%d}",
2916 count, 2629 count, uuid.seq,
2917 &name, 2630 &name,
2918 title ? " " : "", 2631 title ? "\",title:" : "",
2919 title ? (const char *)title : ""); 2632 title ? (const char *)title : "",
2633 flag_desc (flagdesc, 512), type);
2920 2634
2921 if (env) 2635 if (env)
2922 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2636 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2923 2637
2924 if (map) 2638 if (map)
2925 p += snprintf (p, 256, "(on %s@%d+%d)", map->path, x, y); 2639 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2926 2640
2927 return info; 2641 return info;
2928} 2642}
2929 2643
2930const char * 2644const char *

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines