ViewVC Help

View File | Revision Log | Show Annotations | Download File

/cvs/deliantra/server/common/object.C

Comparing deliantra/server/common/object.C (file contents):
Revision 1.47 by root, Thu Sep 14 22:33:59 2006 UTC vs.
Revision 1.107 by pippijn, Sat Jan 6 14:42:29 2007 UTC

1	/*	1	/*
2	CrossFire, A Multiplayer game for X-windows	2	CrossFire, A Multiplayer game for X-windows
3		3
		4	Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team
4	Copyright (C) 2001 Mark Wedel & Crossfire Development Team	5	Copyright (C) 2001 Mark Wedel & Crossfire Development Team
5	Copyright (C) 1992 Frank Tore Johansen	6	Copyright (C) 1992 Frank Tore Johansen
6		7
7	This program is free software; you can redistribute it and/or modify	8	This program is free software; you can redistribute it and/or modify
8	it under the terms of the GNU General Public License as published by	9	it under the terms of the GNU General Public License as published by
…		…
29	#include <sys/types.h>	30	#include <sys/types.h>
30	#include <sys/uio.h>	31	#include <sys/uio.h>
31	#include <object.h>	32	#include <object.h>
32	#include <funcpoint.h>	33	#include <funcpoint.h>
33	#include <loader.h>	34	#include <loader.h>
		35
		36	#include <bitset>
34		37
35	int nrofallocobjects = 0;	38	int nrofallocobjects = 0;
36	static UUID uuid;	39	static UUID uuid;
37	const uint64 UUID_SKIP = 1<<19;	40	const uint64 UUID_SKIP = 1<<19;
38		41
…		…
104	_exit (1);	107	_exit (1);
105	}	108	}
106		109
107	uuid.seq = uid;	110	uuid.seq = uid;
108	write_uuid ();	111	write_uuid ();
109	LOG (llevDebug, "read UID: %lld\n", uid);	112	LOG (llevDebug, "read UID: %" PRId64 "\n", uid);
110	fclose (fp);	113	fclose (fp);
111	}	114	}
112		115
113	UUID	116	UUID
114	gen_uuid ()	117	gen_uuid ()
…		…
139	* objects with lists are rare, and lists stay short. If not, use a	142	* objects with lists are rare, and lists stay short. If not, use a
140	* different structure or at least keep the lists sorted...	143	* different structure or at least keep the lists sorted...
141	*/	144	*/
142		145
143	/* For each field in wants, */	146	/* For each field in wants, */
144	for (wants_field = wants->key_values; wants_field != NULL; wants_field = wants_field->next)	147	for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)
145	{	148	{
146	key_value *has_field;	149	key_value *has_field;
147		150
148	/* Look for a field in has with the same key. */	151	/* Look for a field in has with the same key. */
149	has_field = get_ob_key_link (has, wants_field->key);	152	has_field = get_ob_key_link (has, wants_field->key);
…		…
183	*	186	*
184	* Note that this function appears a lot longer than the macro it	187	* Note that this function appears a lot longer than the macro it
185	* replaces - this is mostly for clarity - a decent compiler should hopefully	188	* replaces - this is mostly for clarity - a decent compiler should hopefully
186	* reduce this to the same efficiency.	189	* reduce this to the same efficiency.
187	*	190	*
188	* Check nrof variable *before* calling CAN_MERGE()	191	* Check nrof variable *before* calling can_merge()
189	*	192	*
190	* Improvements made with merge: Better checking on potion, and also	193	* Improvements made with merge: Better checking on potion, and also
191	* check weight	194	* check weight
192	*/	195	*/
193
194	bool object::can_merge (object *ob1, object *ob2)	196	bool object::can_merge_slow (object *ob1, object *ob2)
195	{	197	{
196	/* A couple quicksanity checks */	198	/* A couple quicksanity checks */
197	if ((ob1 == ob2) || (ob1->type != ob2->type))	199	if (ob1 == ob2
		200	|| ob1->type != ob2->type
		201	|| ob1->speed != ob2->speed
		202	|| ob1->value != ob2->value
		203	|| ob1->name != ob2->name)
198	return 0;	204	return 0;
199		205
200	if (ob1->speed != ob2->speed)	206	//TODO: this ain't working well, use nicer and correct overflow check
201	return 0;
202
203	/* Do not merge objects if nrof would overflow. We use 1UL<<31 since that	207	/* Do not merge objects if nrof would overflow. We use 1UL<<31 since that
204	* value could not be stored in a sint32 (which unfortunately sometimes is	208	* value could not be stored in a sint32 (which unfortunately sometimes is
205	* used to store nrof).	209	* used to store nrof).
206	*/	210	*/
207	if (ob1->nrof + ob2->nrof >= 1UL << 31)	211	if (ob1->nrof + ob2->nrof >= 1UL << 31)
…		…
217	SET_FLAG (ob1, FLAG_BEEN_APPLIED);	221	SET_FLAG (ob1, FLAG_BEEN_APPLIED);
218		222
219	if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))	223	if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
220	SET_FLAG (ob2, FLAG_BEEN_APPLIED);	224	SET_FLAG (ob2, FLAG_BEEN_APPLIED);
221		225
222		226	if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any ()
223	/* the 0x400000 on flags2 is FLAG_INV_LOCK. I don't think something	227	|| ob1->arch != ob2->arch
224	* being locked in inventory should prevent merging.
225	* 0x4 in flags3 is CLIENT_SENT
226	*/
227	if ((ob1->arch != ob2->arch) ||
228	(ob1->flags[0] != ob2->flags[0]) ||
229	(ob1->flags[1] != ob2->flags[1]) ||
230	((ob1->flags[2] & ~0x400000) != (ob2->flags[2] & ~0x400000)) ||
231	((ob1->flags[3] & ~0x4) != (ob2->flags[3] & ~0x4)) ||
232	(ob1->name != ob2->name) ||	228	|| ob1->name != ob2->name
233	(ob1->title != ob2->title) ||	229	|| ob1->title != ob2->title
234	(ob1->msg != ob2->msg) ||	230	|| ob1->msg != ob2->msg
235	(ob1->weight != ob2->weight) ||	231	|| ob1->weight != ob2->weight
236	(memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist)) != 0) ||	232	|| memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
237	(memcmp (&ob1->stats, &ob2->stats, sizeof (ob1->stats)) != 0) ||	233	|| memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
238	(ob1->attacktype != ob2->attacktype) ||	234	|| ob1->attacktype != ob2->attacktype
239	(ob1->magic != ob2->magic) ||	235	|| ob1->magic != ob2->magic
240	(ob1->slaying != ob2->slaying) ||	236	|| ob1->slaying != ob2->slaying
241	(ob1->skill != ob2->skill) ||	237	|| ob1->skill != ob2->skill
242	(ob1->value != ob2->value) ||	238	|| ob1->value != ob2->value
243	(ob1->animation_id != ob2->animation_id) ||	239	|| ob1->animation_id != ob2->animation_id
244	(ob1->client_type != ob2->client_type) ||	240	|| ob1->client_type != ob2->client_type
245	(ob1->materialname != ob2->materialname) ||	241	|| ob1->materialname != ob2->materialname
246	(ob1->lore != ob2->lore) ||	242	|| ob1->lore != ob2->lore
247	(ob1->subtype != ob2->subtype) ||	243	|| ob1->subtype != ob2->subtype
248	(ob1->move_type != ob2->move_type) ||	244	|| ob1->move_type != ob2->move_type
249	(ob1->move_block != ob2->move_block) ||	245	|| ob1->move_block != ob2->move_block
250	(ob1->move_allow != ob2->move_allow) ||	246	|| ob1->move_allow != ob2->move_allow
251	(ob1->move_on != ob2->move_on) ||	247	|| ob1->move_on != ob2->move_on
252	(ob1->move_off != ob2->move_off) || (ob1->move_slow != ob2->move_slow) || (ob1->move_slow_penalty != ob2->move_slow_penalty))	248	|| ob1->move_off != ob2->move_off
		249	|| ob1->move_slow != ob2->move_slow
		250	|| ob1->move_slow_penalty != ob2->move_slow_penalty)
253	return 0;	251	return 0;
254		252
255	/* This is really a spellbook check - really, we should	253	/* This is really a spellbook check - really, we should
256	* check all objects in the inventory.	254	* check all objects in the inventory.
257	*/	255	*/
…		…
260	/* if one object has inventory but the other doesn't, not equiv */	258	/* if one object has inventory but the other doesn't, not equiv */
261	if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv))	259	if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv))
262	return 0;	260	return 0;
263		261
264	/* Now check to see if the two inventory objects could merge */	262	/* Now check to see if the two inventory objects could merge */
265	if (!CAN_MERGE (ob1->inv, ob2->inv))	263	if (!object::can_merge (ob1->inv, ob2->inv))
266	return 0;	264	return 0;
267		265
268	/* inventory ok - still need to check rest of this object to see	266	/* inventory ok - still need to check rest of this object to see
269	* if it is valid.	267	* if it is valid.
270	*/	268	*/
…		…
279		277
280	/* Note sure why the following is the case - either the object has to	278	/* Note sure why the following is the case - either the object has to
281	* be animated or have a very low speed. Is this an attempted monster	279	* be animated or have a very low speed. Is this an attempted monster
282	* check?	280	* check?
283	*/	281	*/
284	if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && FABS ((ob1)->speed) > MIN_ACTIVE_SPEED)	282	if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && ob1->has_active_speed ())
285	return 0;	283	return 0;
286		284
287	switch (ob1->type)	285	switch (ob1->type)
288	{	286	{
289	case SCROLL:	287	case SCROLL:
…		…
354	op = op->env;	352	op = op->env;
355	return op;	353	return op;
356	}	354	}
357		355
358	/*	356	/*
359	* Eneq(@csd.uu.se): Since we can have items buried in a character we need
360	* a better check. We basically keeping traversing up until we can't
361	* or find a player.
362	*/
363
364	object *
365	is_player_inv (object *op)
366	{
367	for (; op != NULL && op->type != PLAYER; op = op->env)
368	if (op->env == op)
369	op->env = NULL;
370	return op;
371	}
372
373	/*
374	* Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.	357	* Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
375	* Some error messages.	358	* Some error messages.
376	* The result of the dump is stored in the static global errmsg array.	359	* The result of the dump is stored in the static global errmsg array.
377	*/	360	*/
378		361
379	void	362	char *
380	dump_object2 (object *op)
381	{
382	errmsg[0] = 0;
383	return;
384	//TODO//D#d#
385	#if 0
386	char *cp;
387
388	/* object *tmp;*/
389
390	if (op->arch != NULL)
391	{
392	strcat (errmsg, "arch ");
393	strcat (errmsg, op->arch->name ? op->arch->name : "(null)");
394	strcat (errmsg, "\n");
395	if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
396	strcat (errmsg, cp);
397	# if 0
398	/* Don't dump player diffs - they are too long, mostly meaningless, and
399	* will overflow the buffer.
400	* Changed so that we don't dump inventory either. This may
401	* also overflow the buffer.
402	*/
403	if (op->type != PLAYER && (cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
404	strcat (errmsg, cp);
405	for (tmp = op->inv; tmp; tmp = tmp->below)
406	dump_object2 (tmp);
407	# endif
408	strcat (errmsg, "end\n");
409	}
410	else
411	{
412	strcat (errmsg, "Object ");
413	if (op->name == NULL)
414	strcat (errmsg, "(null)");
415	else
416	strcat (errmsg, op->name);
417	strcat (errmsg, "\n");
418	# if 0
419	if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
420	strcat (errmsg, cp);
421	for (tmp = op->inv; tmp; tmp = tmp->below)
422	dump_object2 (tmp);
423	# endif
424	strcat (errmsg, "end\n");
425	}
426	#endif
427	}
428
429	/*
430	* Dumps an object. Returns output in the static global errmsg array.
431	*/
432
433	void
434	dump_object (object *op)	363	dump_object (object *op)
435	{	364	{
436	if (op == NULL)	365	if (!op)
437	{	366	return strdup ("[NULLOBJ]");
438	strcpy (errmsg, "[NULL pointer]");
439	return;
440	}
441	errmsg[0] = '\0';
442	dump_object2 (op);
443	}
444		367
445	void	368	object_freezer freezer;
446	dump_all_objects (void)	369	save_object (freezer, op, 1);
447	{	370	return freezer.as_string ();
448	object *op;
449
450	for (op = object::first; op != NULL; op = op->next)
451	{
452	dump_object (op);
453	fprintf (logfile, "Object %d\n:%s\n", op->count, errmsg);
454	}
455	}	371	}
456		372
457	/*	373	/*
458	* get_nearest_part(multi-object, object 2) returns the part of the	374	* get_nearest_part(multi-object, object 2) returns the part of the
459	* multi-object 1 which is closest to the second object.	375	* multi-object 1 which is closest to the second object.
…		…
479	*/	395	*/
480		396
481	object *	397	object *
482	find_object (tag_t i)	398	find_object (tag_t i)
483	{	399	{
484	object *op;
485
486	for (op = object::first; op != NULL; op = op->next)	400	for (object *op = object::first; op; op = op->next)
487	if (op->count == i)	401	if (op->count == i)
488	break;	402	return op;
		403
489	return op;	404	return 0;
490	}	405	}
491		406
492	/*	407	/*
493	* Returns the first object which has a name equal to the argument.	408	* Returns the first object which has a name equal to the argument.
494	* Used only by the patch command, but not all that useful.	409	* Used only by the patch command, but not all that useful.
…		…
552	}	467	}
553		468
554	op->key_values = 0;	469	op->key_values = 0;
555	}	470	}
556		471
557	void object::clear ()
558	{
559	attachable_base::clear ();
560
561	free_key_values (this);
562
563	owner = 0;
564	name = 0;
565	name_pl = 0;
566	title = 0;
567	race = 0;
568	slaying = 0;
569	skill = 0;
570	msg = 0;
571	lore = 0;
572	custom_name = 0;
573	materialname = 0;
574	contr = 0;
575	below = 0;
576	above = 0;
577	inv = 0;
578	container = 0;
579	env = 0;
580	more = 0;
581	head = 0;
582	map = 0;
583	active_next = 0;
584	active_prev = 0;
585
586	memset (static_cast<object_pod *>(this), 0, sizeof (object_pod));
587
588	SET_FLAG (this, FLAG_REMOVED);
589
590	/* What is not cleared is next, prev, and count */
591
592	expmul = 1.0;
593	face = blank_face;
594
595	if (settings.casting_time)
596	casting_time = -1;
597	}
598
599	void object::clone (object *destination)
600	{
601	*(object_copy *)destination = *this;
602	*(object_pod *)destination = *this;
603
604	if (self || cb)
605	INVOKE_OBJECT (CLONE, this, ARG_OBJECT (destination));
606	}
607
608	/*	472	/*
609	* copy object first frees everything allocated by the second object,	473	* copy_to first frees everything allocated by the dst object,
610	* and then copies the contends of the first object into the second	474	* and then copies the contents of itself into the second
611	* object, allocating what needs to be allocated. Basically, any	475	* object, allocating what needs to be allocated. Basically, any
612	* data that is malloc'd needs to be re-malloc/copied. Otherwise,	476	* data that is malloc'd needs to be re-malloc/copied. Otherwise,
613	* if the first object is freed, the pointers in the new object	477	* if the first object is freed, the pointers in the new object
614	* will point at garbage.	478	* will point at garbage.
615	*/	479	*/
616	void	480	void
617	copy_object (object *op2, object *op)	481	object::copy_to (object *dst)
618	{	482	{
619	bool is_freed = QUERY_FLAG (op, FLAG_FREED);	483	bool is_freed = QUERY_FLAG (dst, FLAG_FREED);
620	bool is_removed = QUERY_FLAG (op, FLAG_REMOVED);	484	bool is_removed = QUERY_FLAG (dst, FLAG_REMOVED);
621		485
622	op2->clone (op);	486	*(object_copy *)dst = *this;
623		487
624	if (is_freed)	488	if (is_freed)
625	SET_FLAG (op, FLAG_FREED);	489	SET_FLAG (dst, FLAG_FREED);
		490
626	if (is_removed)	491	if (is_removed)
627	SET_FLAG (op, FLAG_REMOVED);	492	SET_FLAG (dst, FLAG_REMOVED);
628		493
629	if (op2->speed < 0)	494	if (speed < 0)
630	op->speed_left = op2->speed_left - RANDOM () % 200 / 100.0;	495	dst->speed_left = speed_left - RANDOM () % 200 / 100.0;
631		496
632	/* Copy over key_values, if any. */	497	/* Copy over key_values, if any. */
633	if (op2->key_values)	498	if (key_values)
634	{	499	{
635	key_value *tail = 0;	500	key_value *tail = 0;
636	key_value *i;	501	key_value *i;
637		502
638	op->key_values = 0;	503	dst->key_values = 0;
639		504
640	for (i = op2->key_values; i; i = i->next)	505	for (i = key_values; i; i = i->next)
641	{	506	{
642	key_value *new_link = new key_value;	507	key_value *new_link = new key_value;
643		508
644	new_link->next = 0;	509	new_link->next = 0;
645	new_link->key = i->key;	510	new_link->key = i->key;
646	new_link->value = i->value;	511	new_link->value = i->value;
647		512
648	/* Try and be clever here, too. */	513	/* Try and be clever here, too. */
649	if (!op->key_values)	514	if (!dst->key_values)
650	{	515	{
651	op->key_values = new_link;	516	dst->key_values = new_link;
652	tail = new_link;	517	tail = new_link;
653	}	518	}
654	else	519	else
655	{	520	{
656	tail->next = new_link;	521	tail->next = new_link;
657	tail = new_link;	522	tail = new_link;
658	}	523	}
659	}	524	}
660	}	525	}
661		526
662	update_ob_speed (op);	527	dst->set_speed (dst->speed);
		528	}
		529
		530	object *
		531	object::clone ()
		532	{
		533	object *neu = create ();
		534	copy_to (neu);
		535	return neu;
663	}	536	}
664		537
665	/*	538	/*
666	* If an object with the IS_TURNABLE() flag needs to be turned due	539	* If an object with the IS_TURNABLE() flag needs to be turned due
667	* to the closest player being on the other side, this function can	540	* to the closest player being on the other side, this function can
668	* be called to update the face variable, _and_ how it looks on the map.	541	* be called to update the face variable, _and_ how it looks on the map.
669	*/	542	*/
670
671	void	543	void
672	update_turn_face (object *op)	544	update_turn_face (object *op)
673	{	545	{
674	if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || op->arch == NULL)	546	if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || !op->arch)
675	return;	547	return;
		548
676	SET_ANIMATION (op, op->direction);	549	SET_ANIMATION (op, op->direction);
677	update_object (op, UP_OBJ_FACE);	550	update_object (op, UP_OBJ_FACE);
678	}	551	}
679		552
680	/*	553	/*
681	* Updates the speed of an object. If the speed changes from 0 to another	554	* Updates the speed of an object. If the speed changes from 0 to another
682	* value, or vice versa, then add/remove the object from the active list.	555	* value, or vice versa, then add/remove the object from the active list.
683	* This function needs to be called whenever the speed of an object changes.	556	* This function needs to be called whenever the speed of an object changes.
684	*/	557	*/
685	void	558	void
686	update_ob_speed (object *op)	559	object::set_speed (float speed)
687	{	560	{
688	extern int arch_init;	561	if (flag [FLAG_FREED] && speed)
689
690	/* No reason putting the archetypes objects on the speed list,
691	* since they never really need to be updated.
692	*/
693
694	if (QUERY_FLAG (op, FLAG_FREED) && op->speed)
695	{	562	{
696	LOG (llevError, "Object %s is freed but has speed.\n", &op->name);	563	LOG (llevError, "Object %s is freed but has speed.\n", &name);
697	#ifdef MANY_CORES
698	abort ();
699	#else
700	op->speed = 0;	564	speed = 0;
701	#endif
702	}
703
704	if (arch_init)
705	return;
706
707	if (FABS (op->speed) > MIN_ACTIVE_SPEED)
708	{	565	}
709	/* If already on active list, don't do anything */
710	if (op->active_next || op->active_prev || op == active_objects)
711	return;
712		566
713	/* process_events() expects us to insert the object at the beginning	567	this->speed = speed;
714	* of the list. */
715	op->active_next = active_objects;
716		568
717	if (op->active_next != NULL)	569	if (has_active_speed ())
718	op->active_next->active_prev = op;	570	activate ();
719
720	active_objects = op;
721	}
722	else	571	else
723	{	572	deactivate ();
724	/* If not on the active list, nothing needs to be done */
725	if (!op->active_next && !op->active_prev && op != active_objects)
726	return;
727
728	if (op->active_prev == NULL)
729	{
730	active_objects = op->active_next;
731
732	if (op->active_next != NULL)
733	op->active_next->active_prev = NULL;
734	}
735	else
736	{
737	op->active_prev->active_next = op->active_next;
738
739	if (op->active_next)
740	op->active_next->active_prev = op->active_prev;
741	}
742
743	op->active_next = NULL;
744	op->active_prev = NULL;
745	}
746	}	573	}
747		574
748	/* This function removes object 'op' from the list of active
749	* objects.
750	* This should only be used for style maps or other such
751	* reference maps where you don't want an object that isn't
752	* in play chewing up cpu time getting processed.
753	* The reverse of this is to call update_ob_speed, which
754	* will do the right thing based on the speed of the object.
755	*/
756	void
757	remove_from_active_list (object *op)
758	{
759	/* If not on the active list, nothing needs to be done */
760	if (!op->active_next && !op->active_prev && op != active_objects)
761	return;
762
763	if (op->active_prev == NULL)
764	{
765	active_objects = op->active_next;
766	if (op->active_next != NULL)
767	op->active_next->active_prev = NULL;
768	}
769	else
770	{
771	op->active_prev->active_next = op->active_next;
772	if (op->active_next)
773	op->active_next->active_prev = op->active_prev;
774	}
775	op->active_next = NULL;
776	op->active_prev = NULL;
777	}
778
779	/*	575	/*
780	* update_object() updates the array which represents the map.	576	* update_object() updates the the map.
781	* It takes into account invisible objects (and represent squares covered	577	* It takes into account invisible objects (and represent squares covered
782	* by invisible objects by whatever is below them (unless it's another	578	* by invisible objects by whatever is below them (unless it's another
783	* invisible object, etc...)	579	* invisible object, etc...)
784	* If the object being updated is beneath a player, the look-window	580	* If the object being updated is beneath a player, the look-window
785	* of that player is updated (this might be a suboptimal way of	581	* of that player is updated (this might be a suboptimal way of
786	* updating that window, though, since update_object() is called _often_)	582	* updating that window, though, since update_object() is called _often_)
787	*	583	*
788	* action is a hint of what the caller believes need to be done.	584	* action is a hint of what the caller believes need to be done.
789	* For example, if the only thing that has changed is the face (due to
790	* an animation), we don't need to call update_position until that actually
791	* comes into view of a player. OTOH, many other things, like addition/removal
792	* of walls or living creatures may need us to update the flags now.
793	* current action are:	585	* current action are:
794	* UP_OBJ_INSERT: op was inserted	586	* UP_OBJ_INSERT: op was inserted
795	* UP_OBJ_REMOVE: op was removed	587	* UP_OBJ_REMOVE: op was removed
796	* UP_OBJ_CHANGE: object has somehow changed. In this case, we always update	588	* UP_OBJ_CHANGE: object has somehow changed. In this case, we always update
797	* as that is easier than trying to look at what may have changed.	589	* as that is easier than trying to look at what may have changed.
798	* UP_OBJ_FACE: only the objects face has changed.	590	* UP_OBJ_FACE: only the objects face has changed.
799	*/	591	*/
800
801	void	592	void
802	update_object (object *op, int action)	593	update_object (object *op, int action)
803	{	594	{
804	int update_now = 0, flags;
805	MoveType move_on, move_off, move_block, move_slow;	595	MoveType move_on, move_off, move_block, move_slow;
806		596
807	if (op == NULL)	597	if (op == NULL)
808	{	598	{
809	/* this should never happen */	599	/* this should never happen */
810	LOG (llevDebug, "update_object() called for NULL object.\n");	600	LOG (llevDebug, "update_object() called for NULL object.\n");
811	return;	601	return;
812	}	602	}
813		603
814	if (op->env != NULL)	604	if (op->env)
815	{	605	{
816	/* Animation is currently handled by client, so nothing	606	/* Animation is currently handled by client, so nothing
817	* to do in this case.	607	* to do in this case.
818	*/	608	*/
819	return;	609	return;
…		…
824	*/	614	*/
825	if (!op->map || op->map->in_memory == MAP_SAVING)	615	if (!op->map || op->map->in_memory == MAP_SAVING)
826	return;	616	return;
827		617
828	/* make sure the object is within map boundaries */	618	/* make sure the object is within map boundaries */
829	if (op->x < 0 || op->x >= MAP_WIDTH (op->map) || op->y < 0 || op->y >= MAP_HEIGHT (op->map))	619	if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
830	{	620	{
831	LOG (llevError, "update_object() called for object out of map!\n");	621	LOG (llevError, "update_object() called for object out of map!\n");
832	#ifdef MANY_CORES	622	#ifdef MANY_CORES
833	abort ();	623	abort ();
834	#endif	624	#endif
835	return;	625	return;
836	}	626	}
837		627
838	flags = GET_MAP_FLAGS (op->map, op->x, op->y);	628	mapspace &m = op->ms ();
839	SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NEED_UPDATE);
840	move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
841	move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
842	move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
843	move_off = GET_MAP_MOVE_OFF (op->map, op->x, op->y);
844		629
		630	if (!(m.flags_ & P_UPTODATE))
		631	/* nop */;
845	if (action == UP_OBJ_INSERT)	632	else if (action == UP_OBJ_INSERT)
846	{	633	{
		634	// this is likely overkill, TODO: revisit (schmorp)
847	if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(flags & P_BLOCKSVIEW))	635	if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
848	update_now = 1;
849
850	if (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(flags & P_NO_MAGIC))	636	|| (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
851	update_now = 1;	637	|| (op->type == PLAYER && !(m.flags_ & P_PLAYER))
852		638	|| (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
		639	|| (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
853	if (QUERY_FLAG (op, FLAG_DAMNED) && !(flags & P_NO_CLERIC))	640	|| (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
854	update_now = 1;
855
856	if (QUERY_FLAG (op, FLAG_ALIVE) && !(flags & P_IS_ALIVE))
857	update_now = 1;
858
859	if (op->type == SAFE_GROUND && !(flags & P_SAFE))
860	update_now = 1;
861
862	if ((move_on | op->move_on) != move_on)	641	|| (m.move_on | op->move_on ) != m.move_on
863	update_now = 1;
864
865	if ((move_off | op->move_off) != move_off)	642	|| (m.move_off | op->move_off ) != m.move_off
866	update_now = 1;	643	|| (m.move_slow | op->move_slow) != m.move_slow
867
868	/* This isn't perfect, but I don't expect a lot of objects to	644	/* This isn't perfect, but I don't expect a lot of objects to
869	* to have move_allow right now.	645	* to have move_allow right now.
870	*/	646	*/
871	if (((move_block | op->move_block) & ~op->move_allow) != move_block)	647	|| ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
872	update_now = 1;	648	|| 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
873		649	m.flags_ = 0;
874	if ((move_slow | op->move_slow) != move_slow)
875	update_now = 1;
876	}	650	}
877	/* if the object is being removed, we can't make intelligent	651	/* if the object is being removed, we can't make intelligent
878	* decisions, because remove_ob can't really pass the object	652	* decisions, because remove_ob can't really pass the object
879	* that is being removed.	653	* that is being removed.
880	*/	654	*/
881	else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)	655	else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
882	update_now = 1;	656	m.flags_ = 0;
883	else if (action == UP_OBJ_FACE)	657	else if (action == UP_OBJ_FACE)
884	/* Nothing to do for that case */ ;	658	/* Nothing to do for that case */ ;
885	else	659	else
886	LOG (llevError, "update_object called with invalid action: %d\n", action);	660	LOG (llevError, "update_object called with invalid action: %d\n", action);
887		661
888	if (update_now)
889	{
890	SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NO_ERROR | P_NEED_UPDATE);
891	update_position (op->map, op->x, op->y);
892	}
893
894	if (op->more != NULL)	662	if (op->more)
895	update_object (op->more, action);	663	update_object (op->more, action);
896	}	664	}
897		665
898	object::vector object::mortals;
899	object::vector object::objects; // not yet used
900	object *object::first;	666	object *object::first;
901
902	void object::free_mortals ()
903	{
904	for (AUTODECL (i, mortals.begin ()); i != mortals.end ();)
905	if ((*i)->refcnt)
906	++i; // further delay freeing
907	else
908	{
909	delete *i;
910	mortals.erase (i);
911	}
912
913	static int lastmortals = 0;//D
914
915	if (mortals.size() != lastmortals)//D
916	{
917	lastmortals = mortals.size ();//D
918	LOG (llevDebug, "%d objects in mortal queue\n", lastmortals);//D
919	}
920	}
921		667
922	object::object ()	668	object::object ()
923	{	669	{
924	SET_FLAG (this, FLAG_REMOVED);	670	SET_FLAG (this, FLAG_REMOVED);
925		671
…		…
946	object::first = this;	692	object::first = this;
947	}	693	}
948		694
949	void object::unlink ()	695	void object::unlink ()
950	{	696	{
951	//count = 0;//D
952	if (!prev && !next) return;//D
953
954	if (this == object::first)	697	if (this == object::first)
955	object::first = next;	698	object::first = next;
956		699
957	/* Remove this object from the list of used objects */	700	/* Remove this object from the list of used objects */
958	if (prev) prev->next = next;	701	if (prev) prev->next = next;
…		…
960		703
961	prev = 0;	704	prev = 0;
962	next = 0;	705	next = 0;
963	}	706	}
964		707
		708	bool
		709	object::active () const
		710	{
		711	return active_next || active_prev || this == active_objects;
		712	}
		713
		714	void
		715	object::activate ()
		716	{
		717	/* If already on active list, don't do anything */
		718	if (active ())
		719	return;
		720
		721	if (has_active_speed ())
		722	{
		723	/* process_events() expects us to insert the object at the beginning
		724	* of the list. */
		725	active_next = active_objects;
		726
		727	if (active_next)
		728	active_next->active_prev = this;
		729
		730	active_objects = this;
		731	}
		732	}
		733
		734	void
		735	object::activate_recursive ()
		736	{
		737	activate ();
		738
		739	for (object *op = inv; op; op = op->below)
		740	op->activate_recursive ();
		741	}
		742
		743	/* This function removes object 'op' from the list of active
		744	* objects.
		745	* This should only be used for style maps or other such
		746	* reference maps where you don't want an object that isn't
		747	* in play chewing up cpu time getting processed.
		748	* The reverse of this is to call update_ob_speed, which
		749	* will do the right thing based on the speed of the object.
		750	*/
		751	void
		752	object::deactivate ()
		753	{
		754	/* If not on the active list, nothing needs to be done */
		755	if (!active ())
		756	return;
		757
		758	if (active_prev == 0)
		759	{
		760	active_objects = active_next;
		761	if (active_next)
		762	active_next->active_prev = 0;
		763	}
		764	else
		765	{
		766	active_prev->active_next = active_next;
		767	if (active_next)
		768	active_next->active_prev = active_prev;
		769	}
		770
		771	active_next = 0;
		772	active_prev = 0;
		773	}
		774
		775	void
		776	object::deactivate_recursive ()
		777	{
		778	for (object *op = inv; op; op = op->below)
		779	op->deactivate_recursive ();
		780
		781	deactivate ();
		782	}
		783
		784	void
		785	object::set_flag_inv (int flag, int value)
		786	{
		787	for (object *op = inv; op; op = op->below)
		788	{
		789	op->flag [flag] = value;
		790	op->set_flag_inv (flag, value);
		791	}
		792	}
		793
		794	/*
		795	* Remove and free all objects in the inventory of the given object.
		796	* object.c ?
		797	*/
		798	void
		799	object::destroy_inv (bool drop_to_ground)
		800	{
		801	// need to check first, because the checks below might segfault
		802	// as we might be on an invalid mapspace and crossfire code
		803	// is too buggy to ensure that the inventory is empty.
		804	// corollary: if you create arrows etc. with stuff in tis inventory,
		805	// cf will crash below with off-map x and y
		806	if (!inv)
		807	return;
		808
		809	/* Only if the space blocks everything do we not process -
		810	* if some form of movement is allowed, let objects
		811	* drop on that space.
		812	*/
		813	if (!drop_to_ground
		814	|| !map
		815	|| map->in_memory != MAP_IN_MEMORY
		816	|| ms ().move_block == MOVE_ALL)
		817	{
		818	while (inv)
		819	{
		820	inv->destroy_inv (drop_to_ground);
		821	inv->destroy ();
		822	}
		823	}
		824	else
		825	{ /* Put objects in inventory onto this space */
		826	while (inv)
		827	{
		828	object *op = inv;
		829
		830	if (op->flag [FLAG_STARTEQUIP]
		831	|| op->flag [FLAG_NO_DROP]
		832	|| op->type == RUNE
		833	|| op->type == TRAP
		834	|| op->flag [FLAG_IS_A_TEMPLATE])
		835	op->destroy ();
		836	else
		837	map->insert (op, x, y);
		838	}
		839	}
		840	}
		841
965	object *object::create ()	842	object *object::create ()
966	{	843	{
967	object *op = new object;	844	object *op = new object;
968	op->link ();	845	op->link ();
969	return op;	846	return op;
970	}	847	}
971		848
972	/*	849	void
973	* free_object() frees everything allocated by an object, removes	850	object::do_destroy ()
974	* it from the list of used objects, and puts it on the list of
975	* free objects. The IS_FREED() flag is set in the object.
976	* The object must have been removed by remove_ob() first for
977	* this function to succeed.
978	*
979	* If free_inventory is set, free inventory as well. Else drop items in
980	* inventory to the ground.
981	*/
982	void object::free (bool free_inventory)
983	{	851	{
984	if (QUERY_FLAG (this, FLAG_FREED))	852	if (flag [FLAG_IS_LINKED])
		853	remove_button_link (this);
		854
		855	if (flag [FLAG_FRIENDLY])
		856	remove_friendly_object (this);
		857
		858	if (!flag [FLAG_REMOVED])
		859	remove ();
		860
		861	if (flag [FLAG_FREED])
985	return;	862	return;
986		863
987	if (QUERY_FLAG (this, FLAG_FRIENDLY))	864	set_speed (0);
988	remove_friendly_object (this);
989		865
990	if (!QUERY_FLAG (this, FLAG_REMOVED))	866	flag [FLAG_FREED] = 1;
991	remove_ob (this);
992		867
993	SET_FLAG (this, FLAG_FREED);	868	attachable::do_destroy ();
		869
		870	destroy_inv (true);
		871	unlink ();
		872
		873	// hack to ensure that freed objects still have a valid map
		874	{
		875	static maptile *freed_map; // freed objects are moved here to avoid crashes
		876
		877	if (!freed_map)
		878	{
		879	freed_map = new maptile;
		880
		881	freed_map->name = "/internal/freed_objects_map";
		882	freed_map->width = 3;
		883	freed_map->height = 3;
		884
		885	freed_map->alloc ();
		886	freed_map->in_memory = MAP_IN_MEMORY;
		887	}
		888
		889	map = freed_map;
		890	x = 1;
		891	y = 1;
		892	}
		893
		894	head = 0;
994		895
995	if (more)	896	if (more)
996	{	897	{
997	more->free (free_inventory);	898	more->destroy ();
998	more = 0;	899	more = 0;
999	}
1000
1001	if (inv)
1002	{
1003	/* Only if the space blocks everything do we not process -
1004	* if some form of movement is allowed, let objects
1005	* drop on that space.
1006	*/
1007	if (free_inventory || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL)
1008	{
1009	object *op = inv;
1010
1011	while (op)
1012	{
1013	object *tmp = op->below;
1014	op->free (free_inventory);
1015	op = tmp;
1016	}
1017	}
1018	else
1019	{ /* Put objects in inventory onto this space */
1020	object *op = inv;
1021
1022	while (op)
1023	{
1024	object *tmp = op->below;
1025
1026	remove_ob (op);
1027
1028	if (QUERY_FLAG (op, FLAG_STARTEQUIP)
1029	|| QUERY_FLAG (op, FLAG_NO_DROP) || op->type == RUNE || op->type == TRAP || QUERY_FLAG (op, FLAG_IS_A_TEMPLATE))
1030	free_object (op);
1031	else
1032	{
1033	op->x = x;
1034	op->y = y;
1035	insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
1036	}
1037
1038	op = tmp;
1039	}
1040	}
1041	}	900	}
1042		901
1043	// clear those pointers that likely might have circular references to us	902	// clear those pointers that likely might have circular references to us
1044	owner = 0;	903	owner = 0;
1045	enemy = 0;	904	enemy = 0;
1046	attacked_by = 0;	905	attacked_by = 0;
1047		906
1048	/* Remove object from the active list */	907	// only relevant for players(?), but make sure of it anyways
1049	speed = 0;	908	contr = 0;
1050	update_ob_speed (this);	909	}
1051		910
1052	unlink ();	911	void
		912	object::destroy (bool destroy_inventory)
		913	{
		914	if (destroyed ())
		915	return;
1053		916
1054	mortals.push_back (this);	917	if (destroy_inventory)
		918	destroy_inv (false);
		919
		920	attachable::destroy ();
1055	}	921	}
1056		922
1057	/*	923	/*
1058	* sub_weight() recursively (outwards) subtracts a number from the	924	* sub_weight() recursively (outwards) subtracts a number from the
1059	* weight of an object (and what is carried by it's environment(s)).	925	* weight of an object (and what is carried by it's environment(s)).
1060	*/	926	*/
1061
1062	void	927	void
1063	sub_weight (object *op, signed long weight)	928	sub_weight (object *op, signed long weight)
1064	{	929	{
1065	while (op != NULL)	930	while (op != NULL)
1066	{	931	{
…		…
1070	op->carrying -= weight;	935	op->carrying -= weight;
1071	op = op->env;	936	op = op->env;
1072	}	937	}
1073	}	938	}
1074		939
1075	/* remove_ob(op):	940	/* op->remove ():
1076	* This function removes the object op from the linked list of objects	941	* This function removes the object op from the linked list of objects
1077	* which it is currently tied to. When this function is done, the	942	* which it is currently tied to. When this function is done, the
1078	* object will have no environment. If the object previously had an	943	* object will have no environment. If the object previously had an
1079	* environment, the x and y coordinates will be updated to	944	* environment, the x and y coordinates will be updated to
1080	* the previous environment.	945	* the previous environment.
1081	* Beware: This function is called from the editor as well!	946	* Beware: This function is called from the editor as well!
1082	*/	947	*/
1083
1084	void	948	void
1085	remove_ob (object *op)	949	object::remove ()
1086	{	950	{
1087	object *tmp, *last = 0;	951	object *tmp, *last = 0;
1088	object *otmp;	952	object *otmp;
1089		953
1090	tag_t tag;
1091	int check_walk_off;
1092	mapstruct *m;
1093
1094	sint16 x, y;
1095
1096	if (QUERY_FLAG (op, FLAG_REMOVED))	954	if (QUERY_FLAG (this, FLAG_REMOVED))
1097	return;	955	return;
1098		956
1099	SET_FLAG (op, FLAG_REMOVED);	957	SET_FLAG (this, FLAG_REMOVED);
		958	INVOKE_OBJECT (REMOVE, this);
1100		959
1101	if (op->more != NULL)	960	if (more)
1102	remove_ob (op->more);	961	more->remove ();
1103		962
1104	/*	963	/*
1105	* In this case, the object to be removed is in someones	964	* In this case, the object to be removed is in someones
1106	* inventory.	965	* inventory.
1107	*/	966	*/
1108	if (op->env != NULL)	967	if (env)
1109	{	968	{
1110	if (op->nrof)	969	if (nrof)
1111	sub_weight (op->env, op->weight * op->nrof);	970	sub_weight (env, weight * nrof);
1112	else	971	else
1113	sub_weight (op->env, op->weight + op->carrying);	972	sub_weight (env, weight + carrying);
1114		973
1115	/* NO_FIX_PLAYER is set when a great many changes are being	974	/* NO_FIX_PLAYER is set when a great many changes are being
1116	* made to players inventory. If set, avoiding the call	975	* made to players inventory. If set, avoiding the call
1117	* to save cpu time.	976	* to save cpu time.
1118	*/	977	*/
1119	if ((otmp = is_player_inv (op->env)) != NULL && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))	978	if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1120	fix_player (otmp);	979	otmp->update_stats ();
1121		980
1122	if (op->above != NULL)	981	if (above)
1123	op->above->below = op->below;	982	above->below = below;
1124	else	983	else
1125	op->env->inv = op->below;	984	env->inv = below;
1126		985
1127	if (op->below != NULL)	986	if (below)
1128	op->below->above = op->above;	987	below->above = above;
1129		988
1130	/* we set up values so that it could be inserted into	989	/* we set up values so that it could be inserted into
1131	* the map, but we don't actually do that - it is up	990	* the map, but we don't actually do that - it is up
1132	* to the caller to decide what we want to do.	991	* to the caller to decide what we want to do.
1133	*/	992	*/
1134	op->x = op->env->x, op->y = op->env->y;	993	x = env->x, y = env->y;
1135	op->map = op->env->map;	994	map = env->map;
1136	op->above = NULL, op->below = NULL;	995	above = 0, below = 0;
1137	op->env = NULL;	996	env = 0;
1138	}	997	}
1139	else if (op->map)	998	else if (map)
1140	{	999	{
1141	x = op->x;	1000	if (type == PLAYER)
1142	y = op->y;
1143	m = get_map_from_coord (op->map, &x, &y);
1144
1145	if (!m)
1146	{
1147	LOG (llevError, "remove_ob called when object was on map but appears to not be within valid coordinates? %s (%d,%d)\n",
1148	op->map->path, op->x, op->y);
1149	/* in old days, we used to set x and y to 0 and continue.
1150	* it seems if we get into this case, something is probablye
1151	* screwed up and should be fixed.
1152	*/
1153	abort ();
1154	}	1001	{
1155		1002	--map->players;
1156	if (op->map != m)	1003	map->touch ();
1157	LOG (llevDebug, "remove_ob: Object not really on map it claimed to be on? %s != %s, %d,%d != %d,%d\n",
1158	op->map->path, m->path, op->x, op->y, x, y);
1159
1160	/* Re did the following section of code - it looks like it had
1161	* lots of logic for things we no longer care about
1162	*/	1004	}
		1005
		1006	map->dirty = true;
1163		1007
1164	/* link the object above us */	1008	/* link the object above us */
1165	if (op->above)	1009	if (above)
1166	op->above->below = op->below;	1010	above->below = below;
1167	else	1011	else
1168	SET_MAP_TOP (m, x, y, op->below); /* we were top, set new top */	1012	map->at (x, y).top = below; /* we were top, set new top */
1169		1013
1170	/* Relink the object below us, if there is one */	1014	/* Relink the object below us, if there is one */
1171	if (op->below)	1015	if (below)
1172	op->below->above = op->above;	1016	below->above = above;
1173	else	1017	else
1174	{	1018	{
1175	/* Nothing below, which means we need to relink map object for this space	1019	/* Nothing below, which means we need to relink map object for this space
1176	* use translated coordinates in case some oddness with map tiling is	1020	* use translated coordinates in case some oddness with map tiling is
1177	* evident	1021	* evident
1178	*/	1022	*/
1179	if (GET_MAP_OB (m, x, y) != op)	1023	if (GET_MAP_OB (map, x, y) != this)
1180	{	1024	{
1181	dump_object (op);	1025	char *dump = dump_object (this);
1182	LOG (llevError,	1026	LOG (llevError,
1183	"remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", errmsg);	1027	"remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", dump);
		1028	free (dump);
1184	dump_object (GET_MAP_OB (m, x, y));	1029	dump = dump_object (GET_MAP_OB (map, x, y));
1185	LOG (llevError, "%s\n", errmsg);	1030	LOG (llevError, "%s\n", dump);
		1031	free (dump);
1186	}	1032	}
1187		1033
1188	SET_MAP_OB (m, x, y, op->above); /* goes on above it. */	1034	map->at (x, y).bot = above; /* goes on above it. */
1189	}	1035	}
1190		1036
1191	op->above = 0;	1037	above = 0;
1192	op->below = 0;	1038	below = 0;
1193		1039
1194	if (op->map->in_memory == MAP_SAVING)	1040	if (map->in_memory == MAP_SAVING)
1195	return;	1041	return;
1196		1042
1197	tag = op->count;	1043	int check_walk_off = !flag [FLAG_NO_APPLY];
1198	check_walk_off = !QUERY_FLAG (op, FLAG_NO_APPLY);
1199		1044
1200	for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above)	1045	for (tmp = map->at (x, y).bot; tmp; tmp = tmp->above)
1201	{	1046	{
1202	/* No point updating the players look faces if he is the object	1047	/* No point updating the players look faces if he is the object
1203	* being removed.	1048	* being removed.
1204	*/	1049	*/
1205		1050
1206	if (tmp->type == PLAYER && tmp != op)	1051	if (tmp->type == PLAYER && tmp != this)
1207	{	1052	{
1208	/* If a container that the player is currently using somehow gets	1053	/* If a container that the player is currently using somehow gets
1209	* removed (most likely destroyed), update the player view	1054	* removed (most likely destroyed), update the player view
1210	* appropriately.	1055	* appropriately.
1211	*/	1056	*/
1212	if (tmp->container == op)	1057	if (tmp->container == this)
1213	{	1058	{
1214	CLEAR_FLAG (op, FLAG_APPLIED);	1059	flag [FLAG_APPLIED] = 0;
1215	tmp->container = NULL;	1060	tmp->container = 0;
1216	}	1061	}
1217		1062
1218	tmp->contr->socket.update_look = 1;	1063	if (tmp->contr->ns)
		1064	tmp->contr->ns->floorbox_update ();
1219	}	1065	}
1220		1066
1221	/* See if player moving off should effect something */	1067	/* See if object moving off should effect something */
1222	if (check_walk_off && ((op->move_type & tmp->move_off) && (op->move_type & ~tmp->move_off & ~tmp->move_block) == 0))	1068	if (check_walk_off
		1069	&& ((move_type & tmp->move_off)
		1070	&& (move_type & ~tmp->move_off & ~tmp->move_block) == 0))
1223	{	1071	{
1224	move_apply (tmp, op, NULL);	1072	move_apply (tmp, this, 0);
1225		1073
1226	if (was_destroyed (op, tag))	1074	if (destroyed ())
1227	{
1228	LOG (llevError, "BUG: remove_ob(): name %s, archname %s destroyed " "leaving object\n", &tmp->name, &tmp->arch->name);	1075	LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1229	}
1230	}	1076	}
1231		1077
1232	/* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */	1078	/* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */
1233		1079	//TODO: why is this horrible hacka fix? get rid of this code=bug! (schmorp)
1234	if (tmp->above == tmp)	1080	if (tmp->above == tmp)
1235	tmp->above = NULL;	1081	tmp->above = 0;
1236		1082
1237	last = tmp;	1083	last = tmp;
1238	}	1084	}
1239		1085
1240	/* last == NULL of there are no objects on this space */	1086	/* last == NULL if there are no objects on this space */
		1087	//TODO: this makes little sense, why only update the topmost object?
1241	if (last == NULL)	1088	if (!last)
1242	{	1089	map->at (x, y).flags_ = 0;
1243	/* set P_NEED_UPDATE, otherwise update_position will complain. In theory,
1244	* we could preserve the flags (GET_MAP_FLAGS), but update_position figures
1245	* those out anyways, and if there are any flags set right now, they won't
1246	* be correct anyways.
1247	*/
1248	SET_MAP_FLAGS (op->map, op->x, op->y, P_NEED_UPDATE);
1249	update_position (op->map, op->x, op->y);
1250	}
1251	else	1090	else
1252	update_object (last, UP_OBJ_REMOVE);	1091	update_object (last, UP_OBJ_REMOVE);
1253		1092
1254	if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) || (op->glow_radius != 0))	1093	if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1255	update_all_los (op->map, op->x, op->y);	1094	update_all_los (map, x, y);
1256	}	1095	}
1257	}	1096	}
1258		1097
1259	/*	1098	/*
1260	* merge_ob(op,top):	1099	* merge_ob(op,top):
…		…
1268	merge_ob (object *op, object *top)	1107	merge_ob (object *op, object *top)
1269	{	1108	{
1270	if (!op->nrof)	1109	if (!op->nrof)
1271	return 0;	1110	return 0;
1272		1111
1273	if (top == NULL)	1112	if (top)
1274	for (top = op; top != NULL && top->above != NULL; top = top->above);	1113	for (top = op; top && top->above; top = top->above)
		1114	;
1275		1115
1276	for (; top != NULL; top = top->below)	1116	for (; top; top = top->below)
1277	{	1117	{
1278	if (top == op)	1118	if (top == op)
1279	continue;	1119	continue;
1280	if (CAN_MERGE (op, top))	1120
		1121	if (object::can_merge (op, top))
1281	{	1122	{
1282	top->nrof += op->nrof;	1123	top->nrof += op->nrof;
1283		1124
1284	/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/	1125	/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/
1285	op->weight = 0; /* Don't want any adjustements now */	1126	op->weight = 0; /* Don't want any adjustements now */
1286	remove_ob (op);	1127	op->destroy ();
1287	free_object (op);
1288	return top;	1128	return top;
1289	}	1129	}
1290	}	1130	}
1291		1131
1292	return 0;	1132	return 0;
…		…
1295	/*	1135	/*
1296	* same as insert_ob_in_map except it handle separate coordinates and do a clean	1136	* same as insert_ob_in_map except it handle separate coordinates and do a clean
1297	* job preparing multi-part monsters	1137	* job preparing multi-part monsters
1298	*/	1138	*/
1299	object *	1139	object *
1300	insert_ob_in_map_at (object *op, mapstruct *m, object *originator, int flag, int x, int y)	1140	insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1301	{	1141	{
1302	object *tmp;
1303
1304	if (op->head)
1305	op = op->head;
1306
1307	for (tmp = op; tmp; tmp = tmp->more)	1142	for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1308	{	1143	{
1309	tmp->x = x + tmp->arch->clone.x;	1144	tmp->x = x + tmp->arch->clone.x;
1310	tmp->y = y + tmp->arch->clone.y;	1145	tmp->y = y + tmp->arch->clone.y;
1311	}	1146	}
1312		1147
…		…
1331	* Return value:	1166	* Return value:
1332	* new object if 'op' was merged with other object	1167	* new object if 'op' was merged with other object
1333	* NULL if 'op' was destroyed	1168	* NULL if 'op' was destroyed
1334	* just 'op' otherwise	1169	* just 'op' otherwise
1335	*/	1170	*/
1336
1337	object *	1171	object *
1338	insert_ob_in_map (object *op, mapstruct *m, object *originator, int flag)	1172	insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1339	{	1173	{
1340	object *tmp, *top, *floor = NULL;	1174	object *tmp, *top, *floor = NULL;
1341	sint16 x, y;	1175	sint16 x, y;
1342		1176
1343	if (QUERY_FLAG (op, FLAG_FREED))	1177	if (QUERY_FLAG (op, FLAG_FREED))
1344	{	1178	{
1345	LOG (llevError, "Trying to insert freed object!\n");	1179	LOG (llevError, "Trying to insert freed object!\n");
1346	return NULL;	1180	return NULL;
1347	}	1181	}
1348		1182
1349	if (m == NULL)	1183	if (!m)
1350	{	1184	{
1351	dump_object (op);	1185	char *dump = dump_object (op);
1352	LOG (llevError, "Trying to insert in null-map!\n%s\n", errmsg);	1186	LOG (llevError, "Trying to insert in null-map!\n%s\n", dump);
		1187	free (dump);
1353	return op;	1188	return op;
1354	}	1189	}
1355		1190
1356	if (out_of_map (m, op->x, op->y))	1191	if (out_of_map (m, op->x, op->y))
1357	{	1192	{
1358	dump_object (op);	1193	char *dump = dump_object (op);
1359	LOG (llevError, "Trying to insert object outside the map.\n%s\n", errmsg);	1194	LOG (llevError, "Trying to insert object outside the map.\n%s\n", dump);
1360	#ifdef MANY_CORES	1195	#ifdef MANY_CORES
1361	/* Better to catch this here, as otherwise the next use of this object	1196	/* Better to catch this here, as otherwise the next use of this object
1362	* is likely to cause a crash. Better to find out where it is getting	1197	* is likely to cause a crash. Better to find out where it is getting
1363	* improperly inserted.	1198	* improperly inserted.
1364	*/	1199	*/
1365	abort ();	1200	abort ();
1366	#endif	1201	#endif
		1202	free (dump);
1367	return op;	1203	return op;
1368	}	1204	}
1369		1205
1370	if (!QUERY_FLAG (op, FLAG_REMOVED))	1206	if (!QUERY_FLAG (op, FLAG_REMOVED))
1371	{	1207	{
1372	dump_object (op);	1208	char *dump = dump_object (op);
1373	LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", errmsg);	1209	LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", dump);
		1210	free (dump);
1374	return op;	1211	return op;
1375	}	1212	}
1376		1213
1377	if (op->more != NULL)	1214	if (op->more)
1378	{	1215	{
1379	/* The part may be on a different map. */	1216	/* The part may be on a different map. */
1380		1217
1381	object *more = op->more;	1218	object *more = op->more;
1382		1219
1383	/* We really need the caller to normalize coordinates - if	1220	/* We really need the caller to normalise coordinates - if
1384	* we set the map, that doesn't work if the location is within	1221	* we set the map, that doesn't work if the location is within
1385	* a map and this is straddling an edge. So only if coordinate	1222	* a map and this is straddling an edge. So only if coordinate
1386	* is clear wrong do we normalize it.	1223	* is clear wrong do we normalise it.
1387	*/	1224	*/
1388	if (OUT_OF_REAL_MAP (more->map, more->x, more->y))	1225	if (OUT_OF_REAL_MAP (more->map, more->x, more->y))
1389	more->map = get_map_from_coord (m, &more->x, &more->y);	1226	more->map = get_map_from_coord (m, &more->x, &more->y);
1390	else if (!more->map)	1227	else if (!more->map)
1391	{	1228	{
…		…
1398	if (insert_ob_in_map (more, more->map, originator, flag) == NULL)	1235	if (insert_ob_in_map (more, more->map, originator, flag) == NULL)
1399	{	1236	{
1400	if (!op->head)	1237	if (!op->head)
1401	LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n");	1238	LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n");
1402		1239
1403	return NULL;	1240	return 0;
1404	}	1241	}
1405	}	1242	}
1406		1243
1407	CLEAR_FLAG (op, FLAG_REMOVED);	1244	CLEAR_FLAG (op, FLAG_REMOVED);
1408		1245
…		…
1415	y = op->y;	1252	y = op->y;
1416		1253
1417	/* this has to be done after we translate the coordinates.	1254	/* this has to be done after we translate the coordinates.
1418	*/	1255	*/
1419	if (op->nrof && !(flag & INS_NO_MERGE))	1256	if (op->nrof && !(flag & INS_NO_MERGE))
1420	for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above)	1257	for (tmp = GET_MAP_OB (op->map, x, y); tmp; tmp = tmp->above)
1421	if (CAN_MERGE (op, tmp))	1258	if (object::can_merge (op, tmp))
1422	{	1259	{
1423	op->nrof += tmp->nrof;	1260	op->nrof += tmp->nrof;
1424	remove_ob (tmp);	1261	tmp->destroy ();
1425	free_object (tmp);
1426	}	1262	}
1427		1263
1428	CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */	1264	CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1429	CLEAR_FLAG (op, FLAG_INV_LOCKED);	1265	CLEAR_FLAG (op, FLAG_INV_LOCKED);
1430		1266
…		…
1443	op->below = originator->below;	1279	op->below = originator->below;
1444		1280
1445	if (op->below)	1281	if (op->below)
1446	op->below->above = op;	1282	op->below->above = op;
1447	else	1283	else
1448	SET_MAP_OB (op->map, op->x, op->y, op);	1284	op->ms ().bot = op;
1449		1285
1450	/* since *below* originator, no need to update top */	1286	/* since *below* originator, no need to update top */
1451	originator->below = op;	1287	originator->below = op;
1452	}	1288	}
1453	else	1289	else
1454	{	1290	{
1455	/* If there are other objects, then */	1291	/* If there are other objects, then */
1456	if ((!(flag & INS_MAP_LOAD)) && ((top = GET_MAP_OB (op->map, op->x, op->y)) != NULL))	1292	if ((!(flag & INS_MAP_LOAD)) && ((top = GET_MAP_OB (op->map, op->x, op->y)) != NULL))
1457	{	1293	{
1458	object *last = NULL;	1294	object *last = 0;
1459		1295
1460	/*	1296	/*
1461	* If there are multiple objects on this space, we do some trickier handling.	1297	* If there are multiple objects on this space, we do some trickier handling.
1462	* We've already dealt with merging if appropriate.	1298	* We've already dealt with merging if appropriate.
1463	* Generally, we want to put the new object on top. But if	1299	* Generally, we want to put the new object on top. But if
…		…
1467	* once we get to them. This reduces the need to traverse over all of	1303	* once we get to them. This reduces the need to traverse over all of
1468	* them when adding another one - this saves quite a bit of cpu time	1304	* them when adding another one - this saves quite a bit of cpu time
1469	* when lots of spells are cast in one area. Currently, it is presumed	1305	* when lots of spells are cast in one area. Currently, it is presumed
1470	* that flying non pickable objects are spell objects.	1306	* that flying non pickable objects are spell objects.
1471	*/	1307	*/
1472
1473	while (top != NULL)	1308	while (top)
1474	{	1309	{
1475	if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))	1310	if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))
1476	floor = top;	1311	floor = top;
1477		1312
1478	if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))	1313	if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))
…		…
1499	* If INS_ON_TOP is used, don't do this processing	1334	* If INS_ON_TOP is used, don't do this processing
1500	* Need to find the object that in fact blocks view, otherwise	1335	* Need to find the object that in fact blocks view, otherwise
1501	* stacking is a bit odd.	1336	* stacking is a bit odd.
1502	*/	1337	*/
1503	if (!(flag & INS_ON_TOP) &&	1338	if (!(flag & INS_ON_TOP) &&
1504	(get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_BLOCKSVIEW) && (op->face && !op->face->visibility))	1339	(get_map_flags (op->map, 0, op->x, op->y, 0, 0) & P_BLOCKSVIEW) && (op->face && !op->face->visibility))
1505	{	1340	{
1506	for (last = top; last != floor; last = last->below)	1341	for (last = top; last != floor; last = last->below)
1507	if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))	1342	if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1508	break;	1343	break;
1509	/* Check to see if we found the object that blocks view,	1344	/* Check to see if we found the object that blocks view,
…		…
1531	op->above = GET_MAP_OB (op->map, op->x, op->y);	1366	op->above = GET_MAP_OB (op->map, op->x, op->y);
1532		1367
1533	if (op->above)	1368	if (op->above)
1534	op->above->below = op;	1369	op->above->below = op;
1535		1370
1536	op->below = NULL;	1371	op->below = 0;
1537	SET_MAP_OB (op->map, op->x, op->y, op);	1372	op->ms ().bot = op;
1538	}	1373	}
1539	else	1374	else
1540	{ /* get inserted into the stack above top */	1375	{ /* get inserted into the stack above top */
1541	op->above = top->above;	1376	op->above = top->above;
1542		1377
…		…
1545		1380
1546	op->below = top;	1381	op->below = top;
1547	top->above = op;	1382	top->above = op;
1548	}	1383	}
1549		1384
1550	if (op->above == NULL)	1385	if (!op->above)
1551	SET_MAP_TOP (op->map, op->x, op->y, op);	1386	op->ms ().top = op;
1552	} /* else not INS_BELOW_ORIGINATOR */	1387	} /* else not INS_BELOW_ORIGINATOR */
1553		1388
1554	if (op->type == PLAYER)	1389	if (op->type == PLAYER)
		1390	{
1555	op->contr->do_los = 1;	1391	op->contr->do_los = 1;
		1392	++op->map->players;
		1393	op->map->touch ();
		1394	}
		1395
		1396	op->map->dirty = true;
1556		1397
1557	/* If we have a floor, we know the player, if any, will be above	1398	/* If we have a floor, we know the player, if any, will be above
1558	* it, so save a few ticks and start from there.	1399	* it, so save a few ticks and start from there.
1559	*/	1400	*/
1560	if (!(flag & INS_MAP_LOAD))	1401	if (!(flag & INS_MAP_LOAD))
1561	for (tmp = floor ? floor : GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above)	1402	if (object *pl = op->ms ().player ())
1562	if (tmp->type == PLAYER)	1403	if (pl->contr->ns)
1563	tmp->contr->socket.update_look = 1;	1404	pl->contr->ns->floorbox_update ();
1564		1405
1565	/* If this object glows, it may affect lighting conditions that are	1406	/* If this object glows, it may affect lighting conditions that are
1566	* visible to others on this map. But update_all_los is really	1407	* visible to others on this map. But update_all_los is really
1567	* an inefficient way to do this, as it means los for all players	1408	* an inefficient way to do this, as it means los for all players
1568	* on the map will get recalculated. The players could very well	1409	* on the map will get recalculated. The players could very well
1569	* be far away from this change and not affected in any way -	1410	* be far away from this change and not affected in any way -
1570	* this should get redone to only look for players within range,	1411	* this should get redone to only look for players within range,
1571	* or just updating the P_NEED_UPDATE for spaces within this area	1412	* or just updating the P_UPTODATE for spaces within this area
1572	* of effect may be sufficient.	1413	* of effect may be sufficient.
1573	*/	1414	*/
1574	if (MAP_DARKNESS (op->map) && (op->glow_radius != 0))	1415	if (op->map->darkness && (op->glow_radius != 0))
1575	update_all_los (op->map, op->x, op->y);	1416	update_all_los (op->map, op->x, op->y);
1576		1417
1577	/* updates flags (blocked, alive, no magic, etc) for this map space */	1418	/* updates flags (blocked, alive, no magic, etc) for this map space */
1578	update_object (op, UP_OBJ_INSERT);	1419	update_object (op, UP_OBJ_INSERT);
1579		1420
		1421	INVOKE_OBJECT (INSERT, op);
		1422
1580	/* Don't know if moving this to the end will break anything. However,	1423	/* Don't know if moving this to the end will break anything. However,
1581	* we want to have update_look set above before calling this.	1424	* we want to have floorbox_update called before calling this.
1582	*	1425	*
1583	* check_move_on() must be after this because code called from	1426	* check_move_on() must be after this because code called from
1584	* check_move_on() depends on correct map flags (so functions like	1427	* check_move_on() depends on correct map flags (so functions like
1585	* blocked() and wall() work properly), and these flags are updated by	1428	* blocked() and wall() work properly), and these flags are updated by
1586	* update_object().	1429	* update_object().
…		…
1588		1431
1589	/* if this is not the head or flag has been passed, don't check walk on status */	1432	/* if this is not the head or flag has been passed, don't check walk on status */
1590	if (!(flag & INS_NO_WALK_ON) && !op->head)	1433	if (!(flag & INS_NO_WALK_ON) && !op->head)
1591	{	1434	{
1592	if (check_move_on (op, originator))	1435	if (check_move_on (op, originator))
1593	return NULL;	1436	return 0;
1594		1437
1595	/* If we are a multi part object, lets work our way through the check	1438	/* If we are a multi part object, lets work our way through the check
1596	* walk on's.	1439	* walk on's.
1597	*/	1440	*/
1598	for (tmp = op->more; tmp != NULL; tmp = tmp->more)	1441	for (tmp = op->more; tmp != NULL; tmp = tmp->more)
1599	if (check_move_on (tmp, originator))	1442	if (check_move_on (tmp, originator))
1600	return NULL;	1443	return 0;
1601	}	1444	}
1602		1445
1603	return op;	1446	return op;
1604	}	1447	}
1605		1448
1606	/* this function inserts an object in the map, but if it	1449	/* this function inserts an object in the map, but if it
1607	* finds an object of its own type, it'll remove that one first.	1450	* finds an object of its own type, it'll remove that one first.
1608	* op is the object to insert it under: supplies x and the map.	1451	* op is the object to insert it under: supplies x and the map.
1609	*/	1452	*/
1610	void	1453	void
1611	replace_insert_ob_in_map (const char *arch_string, object *op)	1454	replace_insert_ob_in_map (const char *arch_string, object *op)
1612	{	1455	{
1613	object *	1456	object *tmp, *tmp1;
1614	tmp;
1615	object *
1616	tmp1;
1617		1457
1618	/* first search for itself and remove any old instances */	1458	/* first search for itself and remove any old instances */
1619		1459
1620	for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above)	1460	for (tmp = op->ms ().bot; tmp; tmp = tmp->above)
1621	{
1622	if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */	1461	if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */
1623	{	1462	tmp->destroy ();
1624	remove_ob (tmp);
1625	free_object (tmp);
1626	}
1627	}
1628		1463
1629	tmp1 = arch_to_object (archetype::find (arch_string));	1464	tmp1 = arch_to_object (archetype::find (arch_string));
1630		1465
1631	tmp1->x = op->x;	1466	tmp1->x = op->x;
1632	tmp1->y = op->y;	1467	tmp1->y = op->y;
1633	insert_ob_in_map (tmp1, op->map, op, 0);	1468	insert_ob_in_map (tmp1, op->map, op, 0);
		1469	}
		1470
		1471	object *
		1472	object::insert_at (object *where, object *originator, int flags)
		1473	{
		1474	where->map->insert (this, where->x, where->y, originator, flags);
1634	}	1475	}
1635		1476
1636	/*	1477	/*
1637	* get_split_ob(ob,nr) splits up ob into two parts. The part which	1478	* get_split_ob(ob,nr) splits up ob into two parts. The part which
1638	* is returned contains nr objects, and the remaining parts contains	1479	* is returned contains nr objects, and the remaining parts contains
1639	* the rest (or is removed and freed if that number is 0).	1480	* the rest (or is removed and freed if that number is 0).
1640	* On failure, NULL is returned, and the reason put into the	1481	* On failure, NULL is returned, and the reason put into the
1641	* global static errmsg array.	1482	* global static errmsg array.
1642	*/	1483	*/
1643
1644	object *	1484	object *
1645	get_split_ob (object *orig_ob, uint32 nr)	1485	get_split_ob (object *orig_ob, uint32 nr)
1646	{	1486	{
1647	object *	1487	object *newob;
1648	newob;
1649	int
1650	is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);	1488	int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1651		1489
1652	if (orig_ob->nrof < nr)	1490	if (orig_ob->nrof < nr)
1653	{	1491	{
1654	sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);	1492	sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1655	return NULL;	1493	return NULL;
1656	}	1494	}
1657		1495
1658	newob = object_create_clone (orig_ob);	1496	newob = object_create_clone (orig_ob);
1659		1497
1660	if ((orig_ob->nrof -= nr) < 1)	1498	if ((orig_ob->nrof -= nr) < 1)
1661	{	1499	orig_ob->destroy (1);
1662	if (!is_removed)
1663	remove_ob (orig_ob);
1664	free_object2 (orig_ob, 1);
1665	}
1666	else if (!is_removed)	1500	else if (!is_removed)
1667	{	1501	{
1668	if (orig_ob->env != NULL)	1502	if (orig_ob->env != NULL)
1669	sub_weight (orig_ob->env, orig_ob->weight * nr);	1503	sub_weight (orig_ob->env, orig_ob->weight * nr);
1670	if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY)	1504	if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY)
…		…
1690		1524
1691	object *	1525	object *
1692	decrease_ob_nr (object *op, uint32 i)	1526	decrease_ob_nr (object *op, uint32 i)
1693	{	1527	{
1694	object *tmp;	1528	object *tmp;
1695	player *pl;
1696		1529
1697	if (i == 0) /* objects with op->nrof require this check */	1530	if (i == 0) /* objects with op->nrof require this check */
1698	return op;	1531	return op;
1699		1532
1700	if (i > op->nrof)	1533	if (i > op->nrof)
1701	i = op->nrof;	1534	i = op->nrof;
1702		1535
1703	if (QUERY_FLAG (op, FLAG_REMOVED))	1536	if (QUERY_FLAG (op, FLAG_REMOVED))
1704	op->nrof -= i;	1537	op->nrof -= i;
1705	else if (op->env != NULL)	1538	else if (op->env)
1706	{	1539	{
1707	/* is this object in the players inventory, or sub container	1540	/* is this object in the players inventory, or sub container
1708	* therein?	1541	* therein?
1709	*/	1542	*/
1710	tmp = is_player_inv (op->env);	1543	tmp = op->in_player ();
1711	/* nope. Is this a container the player has opened?	1544	/* nope. Is this a container the player has opened?
1712	* If so, set tmp to that player.	1545	* If so, set tmp to that player.
1713	* IMO, searching through all the players will mostly	1546	* IMO, searching through all the players will mostly
1714	* likely be quicker than following op->env to the map,	1547	* likely be quicker than following op->env to the map,
1715	* and then searching the map for a player.	1548	* and then searching the map for a player.
1716	*/	1549	*/
1717	if (!tmp)	1550	if (!tmp)
1718	{	1551	for_all_players (pl)
1719	for (pl = first_player; pl; pl = pl->next)
1720	if (pl->ob->container == op->env)	1552	if (pl->ob->container == op->env)
		1553	{
		1554	tmp = pl->ob;
1721	break;	1555	break;
1722	if (pl)
1723	tmp = pl->ob;
1724	else
1725	tmp = NULL;
1726	}	1556	}
1727		1557
1728	if (i < op->nrof)	1558	if (i < op->nrof)
1729	{	1559	{
1730	sub_weight (op->env, op->weight * i);	1560	sub_weight (op->env, op->weight * i);
1731	op->nrof -= i;	1561	op->nrof -= i;
1732	if (tmp)	1562	if (tmp)
1733	{
1734	esrv_send_item (tmp, op);	1563	esrv_send_item (tmp, op);
1735	}
1736	}	1564	}
1737	else	1565	else
1738	{	1566	{
1739	remove_ob (op);	1567	op->remove ();
1740	op->nrof = 0;	1568	op->nrof = 0;
1741	if (tmp)	1569	if (tmp)
1742	{
1743	esrv_del_item (tmp->contr, op->count);	1570	esrv_del_item (tmp->contr, op->count);
1744	}
1745	}	1571	}
1746	}	1572	}
1747	else	1573	else
1748	{	1574	{
1749	object *above = op->above;	1575	object *above = op->above;
1750		1576
1751	if (i < op->nrof)	1577	if (i < op->nrof)
1752	op->nrof -= i;	1578	op->nrof -= i;
1753	else	1579	else
1754	{	1580	{
1755	remove_ob (op);	1581	op->remove ();
1756	op->nrof = 0;	1582	op->nrof = 0;
1757	}	1583	}
1758		1584
1759	/* Since we just removed op, op->above is null */	1585	/* Since we just removed op, op->above is null */
1760	for (tmp = above; tmp != NULL; tmp = tmp->above)	1586	for (tmp = above; tmp; tmp = tmp->above)
1761	if (tmp->type == PLAYER)	1587	if (tmp->type == PLAYER)
1762	{	1588	{
1763	if (op->nrof)	1589	if (op->nrof)
1764	esrv_send_item (tmp, op);	1590	esrv_send_item (tmp, op);
1765	else	1591	else
…		…
1769		1595
1770	if (op->nrof)	1596	if (op->nrof)
1771	return op;	1597	return op;
1772	else	1598	else
1773	{	1599	{
1774	free_object (op);	1600	op->destroy ();
1775	return NULL;	1601	return 0;
1776	}	1602	}
1777	}	1603	}
1778		1604
1779	/*	1605	/*
1780	* add_weight(object, weight) adds the specified weight to an object,	1606	* add_weight(object, weight) adds the specified weight to an object,
…		…
1792	op->carrying += weight;	1618	op->carrying += weight;
1793	op = op->env;	1619	op = op->env;
1794	}	1620	}
1795	}	1621	}
1796		1622
		1623	object *
		1624	insert_ob_in_ob (object *op, object *where)
		1625	{
		1626	if (!where)
		1627	{
		1628	char *dump = dump_object (op);
		1629	LOG (llevError, "Trying to put object in NULL.\n%s\n", dump);
		1630	free (dump);
		1631	return op;
		1632	}
		1633
		1634	if (where->head)
		1635	{
		1636	LOG (llevDebug, "Warning: Tried to insert object into wrong part of multipart object.\n");
		1637	where = where->head;
		1638	}
		1639
		1640	return where->insert (op);
		1641	}
		1642
1797	/*	1643	/*
1798	* insert_ob_in_ob(op,environment):	1644	* env->insert (op)
1799	* This function inserts the object op in the linked list	1645	* This function inserts the object op in the linked list
1800	* inside the object environment.	1646	* inside the object environment.
1801	*	1647	*
1802	* Eneq(@csd.uu.se): Altered insert_ob_in_ob to make things picked up enter
1803	* the inventory at the last position or next to other objects of the same
1804	* type.
1805	* Frank: Now sorted by type, archetype and magic!
1806	*
1807	* The function returns now pointer to inserted item, and return value can	1648	* The function returns now pointer to inserted item, and return value can
1808	* be != op, if items are merged. -Tero	1649	* be != op, if items are merged. -Tero
1809	*/	1650	*/
1810		1651
1811	object *	1652	object *
1812	insert_ob_in_ob (object *op, object *where)	1653	object::insert (object *op)
1813	{	1654	{
1814	object *	1655	object *tmp, *otmp;
1815	tmp, *
1816	otmp;
1817		1656
1818	if (!QUERY_FLAG (op, FLAG_REMOVED))	1657	if (!QUERY_FLAG (op, FLAG_REMOVED))
1819	{	1658	op->remove ();
1820	dump_object (op);
1821	LOG (llevError, "Trying to insert (ob) inserted object.\n%s\n", errmsg);
1822	return op;
1823	}
1824
1825	if (where == NULL)
1826	{
1827	dump_object (op);
1828	LOG (llevError, "Trying to put object in NULL.\n%s\n", errmsg);
1829	return op;
1830	}
1831
1832	if (where->head)
1833	{
1834	LOG (llevDebug, "Warning: Tried to insert object wrong part of multipart object.\n");
1835	where = where->head;
1836	}
1837		1659
1838	if (op->more)	1660	if (op->more)
1839	{	1661	{
1840	LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);	1662	LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);
1841	return op;	1663	return op;
…		…
1843		1665
1844	CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL);	1666	CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL);
1845	CLEAR_FLAG (op, FLAG_REMOVED);	1667	CLEAR_FLAG (op, FLAG_REMOVED);
1846	if (op->nrof)	1668	if (op->nrof)
1847	{	1669	{
1848	for (tmp = where->inv; tmp != NULL; tmp = tmp->below)	1670	for (tmp = inv; tmp != NULL; tmp = tmp->below)
1849	if (CAN_MERGE (tmp, op))	1671	if (object::can_merge (tmp, op))
1850	{	1672	{
1851	/* return the original object and remove inserted object	1673	/* return the original object and remove inserted object
1852	(client needs the original object) */	1674	(client needs the original object) */
1853	tmp->nrof += op->nrof;	1675	tmp->nrof += op->nrof;
1854	/* Weight handling gets pretty funky. Since we are adding to	1676	/* Weight handling gets pretty funky. Since we are adding to
1855	* tmp->nrof, we need to increase the weight.	1677	* tmp->nrof, we need to increase the weight.
1856	*/	1678	*/
1857	add_weight (where, op->weight * op->nrof);	1679	add_weight (this, op->weight * op->nrof);
1858	SET_FLAG (op, FLAG_REMOVED);	1680	SET_FLAG (op, FLAG_REMOVED);
1859	free_object (op); /* free the inserted object */	1681	op->destroy (); /* free the inserted object */
1860	op = tmp;	1682	op = tmp;
1861	remove_ob (op); /* and fix old object's links */	1683	op->remove (); /* and fix old object's links */
1862	CLEAR_FLAG (op, FLAG_REMOVED);	1684	CLEAR_FLAG (op, FLAG_REMOVED);
1863	break;	1685	break;
1864	}	1686	}
1865		1687
1866	/* I assume combined objects have no inventory	1688	/* I assume combined objects have no inventory
1867	* We add the weight - this object could have just been removed	1689	* We add the weight - this object could have just been removed
1868	* (if it was possible to merge). calling remove_ob will subtract	1690	* (if it was possible to merge). calling remove_ob will subtract
1869	* the weight, so we need to add it in again, since we actually do	1691	* the weight, so we need to add it in again, since we actually do
1870	* the linking below	1692	* the linking below
1871	*/	1693	*/
1872	add_weight (where, op->weight * op->nrof);	1694	add_weight (this, op->weight * op->nrof);
1873	}	1695	}
1874	else	1696	else
1875	add_weight (where, (op->weight + op->carrying));	1697	add_weight (this, (op->weight + op->carrying));
1876		1698
1877	otmp = is_player_inv (where);	1699	otmp = this->in_player ();
1878	if (otmp && otmp->contr != NULL)	1700	if (otmp && otmp->contr)
1879	{
1880	if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))	1701	if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1881	fix_player (otmp);	1702	otmp->update_stats ();
1882	}
1883		1703
1884	op->map = NULL;	1704	op->map = 0;
1885	op->env = where;	1705	op->env = this;
1886	op->above = NULL;	1706	op->above = 0;
1887	op->below = NULL;	1707	op->below = 0;
1888	op->x = 0, op->y = 0;	1708	op->x = 0, op->y = 0;
1889		1709
1890	/* reset the light list and los of the players on the map */	1710	/* reset the light list and los of the players on the map */
1891	if ((op->glow_radius != 0) && where->map)	1711	if ((op->glow_radius != 0) && map)
1892	{	1712	{
1893	#ifdef DEBUG_LIGHTS	1713	#ifdef DEBUG_LIGHTS
1894	LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);	1714	LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1895	#endif /* DEBUG_LIGHTS */	1715	#endif /* DEBUG_LIGHTS */
1896	if (MAP_DARKNESS (where->map))	1716	if (map->darkness)
1897	update_all_los (where->map, where->x, where->y);	1717	update_all_los (map, x, y);
1898	}	1718	}
1899		1719
1900	/* Client has no idea of ordering so lets not bother ordering it here.	1720	/* Client has no idea of ordering so lets not bother ordering it here.
1901	* It sure simplifies this function...	1721	* It sure simplifies this function...
1902	*/	1722	*/
1903	if (where->inv == NULL)	1723	if (!inv)
1904	where->inv = op;	1724	inv = op;
1905	else	1725	else
1906	{	1726	{
1907	op->below = where->inv;	1727	op->below = inv;
1908	op->below->above = op;	1728	op->below->above = op;
1909	where->inv = op;	1729	inv = op;
1910	}	1730	}
		1731
		1732	INVOKE_OBJECT (INSERT, this);
		1733
1911	return op;	1734	return op;
1912	}	1735	}
1913		1736
1914	/*	1737	/*
1915	* Checks if any objects has a move_type that matches objects	1738	* Checks if any objects has a move_type that matches objects
…		…
1929	*	1752	*
1930	* MSW 2001-07-08: Check all objects on space, not just those below	1753	* MSW 2001-07-08: Check all objects on space, not just those below
1931	* object being inserted. insert_ob_in_map may not put new objects	1754	* object being inserted. insert_ob_in_map may not put new objects
1932	* on top.	1755	* on top.
1933	*/	1756	*/
1934
1935	int	1757	int
1936	check_move_on (object *op, object *originator)	1758	check_move_on (object *op, object *originator)
1937	{	1759	{
1938	object *	1760	object *tmp;
1939	tmp;	1761	maptile *m = op->map;
1940	tag_t
1941	tag;
1942	mapstruct *
1943	m = op->map;
1944	int
1945	x = op->x, y = op->y;	1762	int x = op->x, y = op->y;
1946		1763
1947	MoveType	1764	MoveType move_on, move_slow, move_block;
1948	move_on,
1949	move_slow,
1950	move_block;
1951		1765
1952	if (QUERY_FLAG (op, FLAG_NO_APPLY))	1766	if (QUERY_FLAG (op, FLAG_NO_APPLY))
1953	return 0;	1767	return 0;
1954
1955	tag = op->count;
1956		1768
1957	move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);	1769	move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
1958	move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);	1770	move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
1959	move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);	1771	move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
1960		1772
…		…
1976		1788
1977	/* The objects have to be checked from top to bottom.	1789	/* The objects have to be checked from top to bottom.
1978	* Hence, we first go to the top:	1790	* Hence, we first go to the top:
1979	*/	1791	*/
1980		1792
1981	for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL && tmp->above != NULL; tmp = tmp->above)	1793	for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1982	{	1794	{
1983	/* Trim the search when we find the first other spell effect	1795	/* Trim the search when we find the first other spell effect
1984	* this helps performance so that if a space has 50 spell objects,	1796	* this helps performance so that if a space has 50 spell objects,
1985	* we don't need to check all of them.	1797	* we don't need to check all of them.
1986	*/	1798	*/
…		…
2021	if ((!op->move_type && tmp->move_on & MOVE_WALK) ||	1833	if ((!op->move_type && tmp->move_on & MOVE_WALK) ||
2022	((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0))	1834	((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0))
2023	{	1835	{
2024	move_apply (tmp, op, originator);	1836	move_apply (tmp, op, originator);
2025		1837
2026	if (was_destroyed (op, tag))	1838	if (op->destroyed ())
2027	return 1;	1839	return 1;
2028		1840
2029	/* what the person/creature stepped onto has moved the object	1841	/* what the person/creature stepped onto has moved the object
2030	* someplace new. Don't process any further - if we did,	1842	* someplace new. Don't process any further - if we did,
2031	* have a feeling strange problems would result.	1843	* have a feeling strange problems would result.
…		…
2041	/*	1853	/*
2042	* present_arch(arch, map, x, y) searches for any objects with	1854	* present_arch(arch, map, x, y) searches for any objects with
2043	* a matching archetype at the given map and coordinates.	1855	* a matching archetype at the given map and coordinates.
2044	* The first matching object is returned, or NULL if none.	1856	* The first matching object is returned, or NULL if none.
2045	*/	1857	*/
2046
2047	object *	1858	object *
2048	present_arch (const archetype *at, mapstruct *m, int x, int y)	1859	present_arch (const archetype *at, maptile *m, int x, int y)
2049	{	1860	{
2050	object *
2051	tmp;
2052
2053	if (m == NULL || out_of_map (m, x, y))	1861	if (!m || out_of_map (m, x, y))
2054	{	1862	{
2055	LOG (llevError, "Present_arch called outside map.\n");	1863	LOG (llevError, "Present_arch called outside map.\n");
2056	return NULL;	1864	return NULL;
2057	}	1865	}
2058	for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above)	1866
		1867	for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
2059	if (tmp->arch == at)	1868	if (tmp->arch == at)
2060	return tmp;	1869	return tmp;
		1870
2061	return NULL;	1871	return NULL;
2062	}	1872	}
2063		1873
2064	/*	1874	/*
2065	* present(type, map, x, y) searches for any objects with	1875	* present(type, map, x, y) searches for any objects with
2066	* a matching type variable at the given map and coordinates.	1876	* a matching type variable at the given map and coordinates.
2067	* The first matching object is returned, or NULL if none.	1877	* The first matching object is returned, or NULL if none.
2068	*/	1878	*/
2069
2070	object *	1879	object *
2071	present (unsigned char type, mapstruct *m, int x, int y)	1880	present (unsigned char type, maptile *m, int x, int y)
2072	{	1881	{
2073	object *
2074	tmp;
2075
2076	if (out_of_map (m, x, y))	1882	if (out_of_map (m, x, y))
2077	{	1883	{
2078	LOG (llevError, "Present called outside map.\n");	1884	LOG (llevError, "Present called outside map.\n");
2079	return NULL;	1885	return NULL;
2080	}	1886	}
2081	for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above)	1887
		1888	for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
2082	if (tmp->type == type)	1889	if (tmp->type == type)
2083	return tmp;	1890	return tmp;
		1891
2084	return NULL;	1892	return NULL;
2085	}	1893	}
2086		1894
2087	/*	1895	/*
2088	* present_in_ob(type, object) searches for any objects with	1896	* present_in_ob(type, object) searches for any objects with
2089	* a matching type variable in the inventory of the given object.	1897	* a matching type variable in the inventory of the given object.
2090	* The first matching object is returned, or NULL if none.	1898	* The first matching object is returned, or NULL if none.
2091	*/	1899	*/
2092
2093	object *	1900	object *
2094	present_in_ob (unsigned char type, const object *op)	1901	present_in_ob (unsigned char type, const object *op)
2095	{	1902	{
2096	object *
2097	tmp;
2098
2099	for (tmp = op->inv; tmp != NULL; tmp = tmp->below)	1903	for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2100	if (tmp->type == type)	1904	if (tmp->type == type)
2101	return tmp;	1905	return tmp;
		1906
2102	return NULL;	1907	return NULL;
2103	}	1908	}
2104		1909
2105	/*	1910	/*
2106	* present_in_ob (type, str, object) searches for any objects with	1911	* present_in_ob (type, str, object) searches for any objects with
…		…
2114	* str is the string to match against. Note that we match against	1919	* str is the string to match against. Note that we match against
2115	* the object name, not the archetype name. this is so that the	1920	* the object name, not the archetype name. this is so that the
2116	* spell code can use one object type (force), but change it's name	1921	* spell code can use one object type (force), but change it's name
2117	* to be unique.	1922	* to be unique.
2118	*/	1923	*/
2119
2120	object *	1924	object *
2121	present_in_ob_by_name (int type, const char *str, const object *op)	1925	present_in_ob_by_name (int type, const char *str, const object *op)
2122	{	1926	{
2123	object *
2124	tmp;
2125
2126	for (tmp = op->inv; tmp != NULL; tmp = tmp->below)	1927	for (object *tmp = op->inv; tmp; tmp = tmp->below)
2127	{
2128	if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name)))	1928	if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name)))
2129	return tmp;	1929	return tmp;
2130	}	1930
2131	return NULL;	1931	return 0;
2132	}	1932	}
2133		1933
2134	/*	1934	/*
2135	* present_arch_in_ob(archetype, object) searches for any objects with	1935	* present_arch_in_ob(archetype, object) searches for any objects with
2136	* a matching archetype in the inventory of the given object.	1936	* a matching archetype in the inventory of the given object.
2137	* The first matching object is returned, or NULL if none.	1937	* The first matching object is returned, or NULL if none.
2138	*/	1938	*/
2139
2140	object *	1939	object *
2141	present_arch_in_ob (const archetype *at, const object *op)	1940	present_arch_in_ob (const archetype *at, const object *op)
2142	{	1941	{
2143	object *
2144	tmp;
2145
2146	for (tmp = op->inv; tmp != NULL; tmp = tmp->below)	1942	for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2147	if (tmp->arch == at)	1943	if (tmp->arch == at)
2148	return tmp;	1944	return tmp;
		1945
2149	return NULL;	1946	return NULL;
2150	}	1947	}
2151		1948
2152	/*	1949	/*
2153	* activate recursively a flag on an object inventory	1950	* activate recursively a flag on an object inventory
2154	*/	1951	*/
2155	void	1952	void
2156	flag_inv (object *op, int flag)	1953	flag_inv (object *op, int flag)
2157	{	1954	{
2158	object *
2159	tmp;
2160
2161	if (op->inv)	1955	if (op->inv)
2162	for (tmp = op->inv; tmp != NULL; tmp = tmp->below)	1956	for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2163	{	1957	{
2164	SET_FLAG (tmp, flag);	1958	SET_FLAG (tmp, flag);
2165	flag_inv (tmp, flag);	1959	flag_inv (tmp, flag);
2166	}	1960	}
2167	} /*	1961	}
		1962
		1963	/*
2168	* desactivate recursively a flag on an object inventory	1964	* deactivate recursively a flag on an object inventory
2169	*/	1965	*/
2170	void	1966	void
2171	unflag_inv (object *op, int flag)	1967	unflag_inv (object *op, int flag)
2172	{	1968	{
2173	object *
2174	tmp;
2175
2176	if (op->inv)	1969	if (op->inv)
2177	for (tmp = op->inv; tmp != NULL; tmp = tmp->below)	1970	for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2178	{	1971	{
2179	CLEAR_FLAG (tmp, flag);	1972	CLEAR_FLAG (tmp, flag);
2180	unflag_inv (tmp, flag);	1973	unflag_inv (tmp, flag);
2181	}	1974	}
2182	}	1975	}
…		…
2185	* set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in	1978	* set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in
2186	* all it's inventory (recursively).	1979	* all it's inventory (recursively).
2187	* If checksums are used, a player will get set_cheat called for	1980	* If checksums are used, a player will get set_cheat called for
2188	* him/her-self and all object carried by a call to this function.	1981	* him/her-self and all object carried by a call to this function.
2189	*/	1982	*/
2190
2191	void	1983	void
2192	set_cheat (object *op)	1984	set_cheat (object *op)
2193	{	1985	{
2194	SET_FLAG (op, FLAG_WAS_WIZ);	1986	SET_FLAG (op, FLAG_WAS_WIZ);
2195	flag_inv (op, FLAG_WAS_WIZ);	1987	flag_inv (op, FLAG_WAS_WIZ);
…		…
2214	* because arch_blocked (now ob_blocked) needs to know the movement type	2006	* because arch_blocked (now ob_blocked) needs to know the movement type
2215	* to know if the space in question will block the object. We can't use	2007	* to know if the space in question will block the object. We can't use
2216	* the archetype because that isn't correct if the monster has been	2008	* the archetype because that isn't correct if the monster has been
2217	* customized, changed states, etc.	2009	* customized, changed states, etc.
2218	*/	2010	*/
2219
2220	int	2011	int
2221	find_free_spot (const object *ob, mapstruct *m, int x, int y, int start, int stop)	2012	find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)
2222	{	2013	{
2223	int
2224	i,
2225	index = 0, flag;	2014	int index = 0, flag;
2226	static int
2227	altern[SIZEOFFREE];	2015	int altern[SIZEOFFREE];
2228		2016
2229	for (i = start; i < stop; i++)	2017	for (int i = start; i < stop; i++)
2230	{	2018	{
2231	flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]);	2019	flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]);
2232	if (!flag)	2020	if (!flag)
2233	altern[index++] = i;	2021	altern [index++] = i;
2234		2022
2235	/* Basically, if we find a wall on a space, we cut down the search size.	2023	/* Basically, if we find a wall on a space, we cut down the search size.
2236	* In this way, we won't return spaces that are on another side of a wall.	2024	* In this way, we won't return spaces that are on another side of a wall.
2237	* This mostly work, but it cuts down the search size in all directions -	2025	* This mostly work, but it cuts down the search size in all directions -
2238	* if the space being examined only has a wall to the north and empty	2026	* if the space being examined only has a wall to the north and empty
2239	* spaces in all the other directions, this will reduce the search space	2027	* spaces in all the other directions, this will reduce the search space
2240	* to only the spaces immediately surrounding the target area, and	2028	* to only the spaces immediately surrounding the target area, and
2241	* won't look 2 spaces south of the target space.	2029	* won't look 2 spaces south of the target space.
2242	*/	2030	*/
2243	else if ((flag & AB_NO_PASS) && maxfree[i] < stop)	2031	else if ((flag & P_NO_PASS) && maxfree[i] < stop)
2244	stop = maxfree[i];	2032	stop = maxfree[i];
2245	}	2033	}
		2034
2246	if (!index)	2035	if (!index)
2247	return -1;	2036	return -1;
		2037
2248	return altern[RANDOM () % index];	2038	return altern[RANDOM () % index];
2249	}	2039	}
2250		2040
2251	/*	2041	/*
2252	* find_first_free_spot(archetype, mapstruct, x, y) works like	2042	* find_first_free_spot(archetype, maptile, x, y) works like
2253	* find_free_spot(), but it will search max number of squares.	2043	* find_free_spot(), but it will search max number of squares.
2254	* But it will return the first available spot, not a random choice.	2044	* But it will return the first available spot, not a random choice.
2255	* Changed 0.93.2: Have it return -1 if there is no free spot available.	2045	* Changed 0.93.2: Have it return -1 if there is no free spot available.
2256	*/	2046	*/
2257
2258	int	2047	int
2259	find_first_free_spot (const object *ob, mapstruct *m, int x, int y)	2048	find_first_free_spot (const object *ob, maptile *m, int x, int y)
2260	{	2049	{
2261	int
2262	i;
2263
2264	for (i = 0; i < SIZEOFFREE; i++)	2050	for (int i = 0; i < SIZEOFFREE; i++)
2265	{
2266	if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]))	2051	if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]))
2267	return i;	2052	return i;
2268	}	2053
2269	return -1;	2054	return -1;
2270	}	2055	}
2271		2056
2272	/*	2057	/*
2273	* The function permute(arr, begin, end) randomly reorders the array	2058	* The function permute(arr, begin, end) randomly reorders the array
2274	* arr[begin..end-1].	2059	* arr[begin..end-1].
		2060	* now uses a fisher-yates shuffle, old permute was broken
2275	*/	2061	*/
2276	static void	2062	static void
2277	permute (int *arr, int begin, int end)	2063	permute (int *arr, int begin, int end)
2278	{	2064	{
2279	int	2065	arr += begin;
2280	i,
2281	j,
2282	tmp,
2283	len;
2284
2285	len = end - begin;	2066	end -= begin;
2286	for (i = begin; i < end; i++)
2287	{
2288	j = begin + RANDOM () % len;
2289		2067
2290	tmp = arr[i];	2068	while (--end)
2291	arr[i] = arr[j];	2069	swap (arr [end], arr [RANDOM () % (end + 1)]);
2292	arr[j] = tmp;
2293	}
2294	}	2070	}
2295		2071
2296	/* new function to make monster searching more efficient, and effective!	2072	/* new function to make monster searching more efficient, and effective!
2297	* This basically returns a randomized array (in the passed pointer) of	2073	* This basically returns a randomized array (in the passed pointer) of
2298	* the spaces to find monsters. In this way, it won't always look for	2074	* the spaces to find monsters. In this way, it won't always look for
…		…
2301	* the 3x3 area will be searched, just not in a predictable order.	2077	* the 3x3 area will be searched, just not in a predictable order.
2302	*/	2078	*/
2303	void	2079	void
2304	get_search_arr (int *search_arr)	2080	get_search_arr (int *search_arr)
2305	{	2081	{
2306	int	2082	int i;
2307	i;
2308		2083
2309	for (i = 0; i < SIZEOFFREE; i++)	2084	for (i = 0; i < SIZEOFFREE; i++)
2310	{
2311	search_arr[i] = i;	2085	search_arr[i] = i;
2312	}
2313		2086
2314	permute (search_arr, 1, SIZEOFFREE1 + 1);	2087	permute (search_arr, 1, SIZEOFFREE1 + 1);
2315	permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1);	2088	permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1);
2316	permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE);	2089	permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE);
2317	}	2090	}
…		…
2326	* Perhaps incorrectly, but I'm making the assumption that exclude	2099	* Perhaps incorrectly, but I'm making the assumption that exclude
2327	* is actually want is going to try and move there. We need this info	2100	* is actually want is going to try and move there. We need this info
2328	* because we have to know what movement the thing looking to move	2101	* because we have to know what movement the thing looking to move
2329	* there is capable of.	2102	* there is capable of.
2330	*/	2103	*/
2331
2332	int	2104	int
2333	find_dir (mapstruct *m, int x, int y, object *exclude)	2105	find_dir (maptile *m, int x, int y, object *exclude)
2334	{	2106	{
2335	int
2336	i,
2337	max = SIZEOFFREE, mflags;	2107	int i, max = SIZEOFFREE, mflags;
2338		2108
2339	sint16 nx, ny;	2109	sint16 nx, ny;
2340	object *	2110	object *tmp;
2341	tmp;	2111	maptile *mp;
2342	mapstruct *
2343	mp;
2344		2112
2345	MoveType blocked, move_type;	2113	MoveType blocked, move_type;
2346		2114
2347	if (exclude && exclude->head)	2115	if (exclude && exclude->head)
2348	{	2116	{
…		…
2360	mp = m;	2128	mp = m;
2361	nx = x + freearr_x[i];	2129	nx = x + freearr_x[i];
2362	ny = y + freearr_y[i];	2130	ny = y + freearr_y[i];
2363		2131
2364	mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);	2132	mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);
		2133
2365	if (mflags & P_OUT_OF_MAP)	2134	if (mflags & P_OUT_OF_MAP)
2366	{
2367	max = maxfree[i];	2135	max = maxfree[i];
2368	}
2369	else	2136	else
2370	{	2137	{
2371	blocked = GET_MAP_MOVE_BLOCK (mp, nx, ny);	2138	mapspace &ms = mp->at (nx, ny);
		2139
		2140	blocked = ms.move_block;
2372		2141
2373	if ((move_type & blocked) == move_type)	2142	if ((move_type & blocked) == move_type)
2374	{
2375	max = maxfree[i];	2143	max = maxfree[i];
2376	}
2377	else if (mflags & P_IS_ALIVE)	2144	else if (mflags & P_IS_ALIVE)
2378	{	2145	{
2379	for (tmp = GET_MAP_OB (mp, nx, ny); tmp != NULL; tmp = tmp->above)	2146	for (tmp = ms.bot; tmp; tmp = tmp->above)
2380	{	2147	if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)
2381	if ((QUERY_FLAG (tmp, FLAG_MONSTER) || tmp->type == PLAYER) && (tmp != exclude || (tmp->head && tmp->head != exclude)))	2148	&& (tmp != exclude || (tmp->head && tmp->head != exclude)))
2382	{
2383	break;	2149	break;
2384	}	2150
2385	}
2386	if (tmp)	2151	if (tmp)
2387	{
2388	return freedir[i];	2152	return freedir[i];
2389	}
2390	}	2153	}
2391	}	2154	}
2392	}	2155	}
		2156
2393	return 0;	2157	return 0;
2394	}	2158	}
2395		2159
2396	/*	2160	/*
2397	* distance(object 1, object 2) will return the square of the	2161	* distance(object 1, object 2) will return the square of the
2398	* distance between the two given objects.	2162	* distance between the two given objects.
2399	*/	2163	*/
2400
2401	int	2164	int
2402	distance (const object *ob1, const object *ob2)	2165	distance (const object *ob1, const object *ob2)
2403	{	2166	{
2404	int
2405	i;
2406
2407	i = (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);	2167	return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2408	return i;
2409	}	2168	}
2410		2169
2411	/*	2170	/*
2412	* find_dir_2(delta-x,delta-y) will return a direction in which	2171	* find_dir_2(delta-x,delta-y) will return a direction in which
2413	* an object which has subtracted the x and y coordinates of another	2172	* an object which has subtracted the x and y coordinates of another
2414	* object, needs to travel toward it.	2173	* object, needs to travel toward it.
2415	*/	2174	*/
2416
2417	int	2175	int
2418	find_dir_2 (int x, int y)	2176	find_dir_2 (int x, int y)
2419	{	2177	{
2420	int	2178	int q;
2421	q;
2422		2179
2423	if (y)	2180	if (y)
2424	q = x * 100 / y;	2181	q = x * 100 / y;
2425	else if (x)	2182	else if (x)
2426	q = -300 * x;	2183	q = -300 * x;
…		…
2461	int	2218	int
2462	absdir (int d)	2219	absdir (int d)
2463	{	2220	{
2464	while (d < 1)	2221	while (d < 1)
2465	d += 8;	2222	d += 8;
		2223
2466	while (d > 8)	2224	while (d > 8)
2467	d -= 8;	2225	d -= 8;
		2226
2468	return d;	2227	return d;
2469	}	2228	}
2470		2229
2471	/*	2230	/*
2472	* dirdiff(dir1, dir2) returns how many 45-degrees differences there is	2231	* dirdiff(dir1, dir2) returns how many 45-degrees differences there is
…		…
2474	*/	2233	*/
2475		2234
2476	int	2235	int
2477	dirdiff (int dir1, int dir2)	2236	dirdiff (int dir1, int dir2)
2478	{	2237	{
2479	int	2238	int d;
2480	d;
2481		2239
2482	d = abs (dir1 - dir2);	2240	d = abs (dir1 - dir2);
2483	if (d > 4)	2241	if (d > 4)
2484	d = 8 - d;	2242	d = 8 - d;
		2243
2485	return d;	2244	return d;
2486	}	2245	}
2487		2246
2488	/* peterm:	2247	/* peterm:
2489	* do LOS stuff for ball lightning. Go after the closest VISIBLE monster.	2248	* do LOS stuff for ball lightning. Go after the closest VISIBLE monster.
…		…
2492	* This basically means that if direction is 15, then it could either go	2251	* This basically means that if direction is 15, then it could either go
2493	* direction 4, 14, or 16 to get back to where we are.	2252	* direction 4, 14, or 16 to get back to where we are.
2494	* Moved from spell_util.c to object.c with the other related direction	2253	* Moved from spell_util.c to object.c with the other related direction
2495	* functions.	2254	* functions.
2496	*/	2255	*/
2497
2498	int
2499	reduction_dir[SIZEOFFREE][3] = {	2256	int reduction_dir[SIZEOFFREE][3] = {
2500	{0, 0, 0}, /* 0 */	2257	{0, 0, 0}, /* 0 */
2501	{0, 0, 0}, /* 1 */	2258	{0, 0, 0}, /* 1 */
2502	{0, 0, 0}, /* 2 */	2259	{0, 0, 0}, /* 2 */
2503	{0, 0, 0}, /* 3 */	2260	{0, 0, 0}, /* 3 */
2504	{0, 0, 0}, /* 4 */	2261	{0, 0, 0}, /* 4 */
…		…
2552	* find a path to that monster that we found. If not,	2309	* find a path to that monster that we found. If not,
2553	* we don't bother going toward it. Returns 1 if we	2310	* we don't bother going toward it. Returns 1 if we
2554	* can see a direct way to get it	2311	* can see a direct way to get it
2555	* Modified to be map tile aware -.MSW	2312	* Modified to be map tile aware -.MSW
2556	*/	2313	*/
2557
2558
2559	int	2314	int
2560	can_see_monsterP (mapstruct *m, int x, int y, int dir)	2315	can_see_monsterP (maptile *m, int x, int y, int dir)
2561	{	2316	{
2562	sint16 dx, dy;	2317	sint16 dx, dy;
2563	int
2564	mflags;	2318	int mflags;
2565		2319
2566	if (dir < 0)	2320	if (dir < 0)
2567	return 0; /* exit condition: invalid direction */	2321	return 0; /* exit condition: invalid direction */
2568		2322
2569	dx = x + freearr_x[dir];	2323	dx = x + freearr_x[dir];
…		…
2582	return 0;	2336	return 0;
2583		2337
2584	/* yes, can see. */	2338	/* yes, can see. */
2585	if (dir < 9)	2339	if (dir < 9)
2586	return 1;	2340	return 1;
		2341
2587	return can_see_monsterP (m, x, y, reduction_dir[dir][0]) |	2342	return can_see_monsterP (m, x, y, reduction_dir[dir][0])
2588	can_see_monsterP (m, x, y, reduction_dir[dir][1]) | can_see_monsterP (m, x, y, reduction_dir[dir][2]);	2343	| can_see_monsterP (m, x, y, reduction_dir[dir][1])
		2344	| can_see_monsterP (m, x, y, reduction_dir[dir][2]);
2589	}	2345	}
2590
2591
2592		2346
2593	/*	2347	/*
2594	* can_pick(picker, item): finds out if an object is possible to be	2348	* can_pick(picker, item): finds out if an object is possible to be
2595	* picked up by the picker. Returnes 1 if it can be	2349	* picked up by the picker. Returnes 1 if it can be
2596	* picked up, otherwise 0.	2350	* picked up, otherwise 0.
…		…
2607	return /*QUERY_FLAG(who,FLAG_WIZ)|| */	2361	return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2608	(item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&	2362	(item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2609	!QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));	2363	!QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));
2610	}	2364	}
2611		2365
2612
2613	/*	2366	/*
2614	* create clone from object to another	2367	* create clone from object to another
2615	*/	2368	*/
2616	object *	2369	object *
2617	object_create_clone (object *asrc)	2370	object_create_clone (object *asrc)
2618	{	2371	{
2619	object *
2620	dst = NULL, *tmp, *src, *part, *prev, *item;	2372	object *dst = 0, *tmp, *src, *part, *prev, *item;
2621		2373
2622	if (!asrc)	2374	if (!asrc)
2623	return NULL;	2375	return 0;
		2376
2624	src = asrc;	2377	src = asrc;
2625	if (src->head)	2378	if (src->head)
2626	src = src->head;	2379	src = src->head;
2627		2380
2628	prev = NULL;	2381	prev = 0;
2629	for (part = src; part; part = part->more)	2382	for (part = src; part; part = part->more)
2630	{	2383	{
2631	tmp = get_object ();	2384	tmp = part->clone ();
2632	copy_object (part, tmp);
2633	tmp->x -= src->x;	2385	tmp->x -= src->x;
2634	tmp->y -= src->y;	2386	tmp->y -= src->y;
		2387
2635	if (!part->head)	2388	if (!part->head)
2636	{	2389	{
2637	dst = tmp;	2390	dst = tmp;
2638	tmp->head = NULL;	2391	tmp->head = 0;
2639	}	2392	}
2640	else	2393	else
2641	{
2642	tmp->head = dst;	2394	tmp->head = dst;
2643	}	2395
2644	tmp->more = NULL;	2396	tmp->more = 0;
		2397
2645	if (prev)	2398	if (prev)
2646	prev->more = tmp;	2399	prev->more = tmp;
		2400
2647	prev = tmp;	2401	prev = tmp;
2648	}	2402	}
2649		2403
2650	/*** copy inventory ***/
2651	for (item = src->inv; item; item = item->below)	2404	for (item = src->inv; item; item = item->below)
2652	{
2653	(void) insert_ob_in_ob (object_create_clone (item), dst);	2405	insert_ob_in_ob (object_create_clone (item), dst);
2654	}
2655		2406
2656	return dst;	2407	return dst;
2657	}	2408	}
2658		2409
2659	/* return true if the object was destroyed, 0 otherwise */
2660	int
2661	was_destroyed (const object *op, tag_t old_tag)
2662	{
2663	/* checking for FLAG_FREED isn't necessary, but makes this function more
2664	* robust */
2665	return op->count != old_tag || QUERY_FLAG (op, FLAG_FREED);
2666	}
2667
2668	/* GROS - Creates an object using a string representing its content. */	2410	/* GROS - Creates an object using a string representing its content. */
2669
2670	/* Basically, we save the content of the string to a temp file, then call */	2411	/* Basically, we save the content of the string to a temp file, then call */
2671
2672	/* load_object on it. I admit it is a highly inefficient way to make things, */	2412	/* load_object on it. I admit it is a highly inefficient way to make things, */
2673
2674	/* but it was simple to make and allows reusing the load_object function. */	2413	/* but it was simple to make and allows reusing the load_object function. */
2675
2676	/* Remember not to use load_object_str in a time-critical situation. */	2414	/* Remember not to use load_object_str in a time-critical situation. */
2677
2678	/* Also remember that multiparts objects are not supported for now. */	2415	/* Also remember that multiparts objects are not supported for now. */
2679
2680	object *	2416	object *
2681	load_object_str (const char *obstr)	2417	load_object_str (const char *obstr)
2682	{	2418	{
2683	object *	2419	object *op;
2684	op;
2685	char
2686	filename[MAX_BUF];	2420	char filename[MAX_BUF];
2687		2421
2688	sprintf (filename, "%s/cfloadobstr2044", settings.tmpdir);	2422	sprintf (filename, "%s/cfloadobstr2044", settings.tmpdir);
2689		2423
2690	FILE *
2691	tempfile = fopen (filename, "w");	2424	FILE *tempfile = fopen (filename, "w");
2692		2425
2693	if (tempfile == NULL)	2426	if (tempfile == NULL)
2694	{	2427	{
2695	LOG (llevError, "Error - Unable to access load object temp file\n");	2428	LOG (llevError, "Error - Unable to access load object temp file\n");
2696	return NULL;	2429	return NULL;
2697	}	2430	}
2698		2431
2699	fprintf (tempfile, obstr);	2432	fprintf (tempfile, obstr);
2700	fclose (tempfile);	2433	fclose (tempfile);
2701		2434
2702	op = get_object ();	2435	op = object::create ();
2703		2436
2704	object_thawer thawer (filename);	2437	object_thawer thawer (filename);
2705		2438
2706	if (thawer)	2439	if (thawer)
2707	load_object (thawer, op, 0);	2440	load_object (thawer, op, 0);
…		…
2717	* returns NULL if no match.	2450	* returns NULL if no match.
2718	*/	2451	*/
2719	object *	2452	object *
2720	find_obj_by_type_subtype (const object *who, int type, int subtype)	2453	find_obj_by_type_subtype (const object *who, int type, int subtype)
2721	{	2454	{
2722	object *
2723	tmp;
2724
2725	for (tmp = who->inv; tmp; tmp = tmp->below)	2455	for (object *tmp = who->inv; tmp; tmp = tmp->below)
2726	if (tmp->type == type && tmp->subtype == subtype)	2456	if (tmp->type == type && tmp->subtype == subtype)
2727	return tmp;	2457	return tmp;
2728		2458
2729	return NULL;	2459	return 0;
2730	}	2460	}
2731		2461
2732	/* If ob has a field named key, return the link from the list,	2462	/* If ob has a field named key, return the link from the list,
2733	* otherwise return NULL.	2463	* otherwise return NULL.
2734	*	2464	*
…		…
2736	* do the desired thing.	2466	* do the desired thing.
2737	*/	2467	*/
2738	key_value *	2468	key_value *
2739	get_ob_key_link (const object *ob, const char *key)	2469	get_ob_key_link (const object *ob, const char *key)
2740	{	2470	{
2741	key_value *
2742	link;
2743
2744	for (link = ob->key_values; link != NULL; link = link->next)	2471	for (key_value *link = ob->key_values; link; link = link->next)
2745	{
2746	if (link->key == key)	2472	if (link->key == key)
2747	{
2748	return link;	2473	return link;
2749	}
2750	}
2751		2474
2752	return NULL;	2475	return 0;
2753	}	2476	}
2754		2477
2755	/*	2478	/*
2756	* Returns the value of op has an extra_field for key, or NULL.	2479	* Returns the value of op has an extra_field for key, or NULL.
2757	*	2480	*
…		…
2797	* Returns TRUE on success.	2520	* Returns TRUE on success.
2798	*/	2521	*/
2799	int	2522	int
2800	set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)	2523	set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2801	{	2524	{
2802	key_value *
2803	field = NULL, *last = NULL;	2525	key_value *field = NULL, *last = NULL;
2804		2526
2805	for (field = op->key_values; field != NULL; field = field->next)	2527	for (field = op->key_values; field != NULL; field = field->next)
2806	{	2528	{
2807	if (field->key != canonical_key)	2529	if (field->key != canonical_key)
2808	{	2530	{
…		…
2836	/* IF we get here, key doesn't exist */	2558	/* IF we get here, key doesn't exist */
2837		2559
2838	/* No field, we'll have to add it. */	2560	/* No field, we'll have to add it. */
2839		2561
2840	if (!add_key)	2562	if (!add_key)
2841	{
2842	return FALSE;	2563	return FALSE;
2843	}	2564
2844	/* There isn't any good reason to store a null	2565	/* There isn't any good reason to store a null
2845	* value in the key/value list. If the archetype has	2566	* value in the key/value list. If the archetype has
2846	* this key, then we should also have it, so shouldn't	2567	* this key, then we should also have it, so shouldn't
2847	* be here. If user wants to store empty strings,	2568	* be here. If user wants to store empty strings,
2848	* should pass in ""	2569	* should pass in ""
…		…
2897	}	2618	}
2898	else	2619	else
2899	item = item->env;	2620	item = item->env;
2900	}	2621	}
2901		2622
		2623
		2624	const char *
		2625	object::flag_desc (char *desc, int len) const
		2626	{
		2627	char *p = desc;
		2628	bool first = true;
		2629
		2630	*p = 0;
		2631
		2632	for (int i = 0; i < NUM_FLAGS; i++)
		2633	{
		2634	if (len <= 10) // magic constant!
		2635	{
		2636	snprintf (p, len, ",...");
		2637	break;
		2638	}
		2639
		2640	if (flag [i])
		2641	{
		2642	int cnt = snprintf (p, len, "%s%d", first ? "" : ",", i);
		2643	len -= cnt;
		2644	p += cnt;
		2645	first = false;
		2646	}
		2647	}
		2648
		2649	return desc;
		2650	}
		2651
2902	// return a suitable string describing an objetc in enough detail to find it	2652	// return a suitable string describing an object in enough detail to find it
2903	const char *	2653	const char *
2904	object::debug_desc (char *info) const	2654	object::debug_desc (char *info) const
2905	{	2655	{
		2656	char flagdesc[512];
2906	char info2[256 * 3];	2657	char info2[256 * 4];
2907	char *p = info;	2658	char *p = info;
2908		2659
2909	p += snprintf (p, 256, "%d=\"%s%s%s\"",	2660	p += snprintf (p, 512, "{cnt:%d,uuid:<1,%" PRIx64 ">,name:\"%s%s%s\",flags:[%s],type:%d}",
2910	count,	2661	count, uuid.seq,
2911	&name,	2662	&name,
2912	title ? " " : "",	2663	title ? "\",title:" : "",
2913	title ? (const char *)title : "");	2664	title ? (const char *)title : "",
		2665	flag_desc (flagdesc, 512), type);
2914		2666
2915	if (env)	2667	if (env)
2916	p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));	2668	p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2917		2669
2918	if (map)	2670	if (map)
2919	p += snprintf (p, 256, "(on %s@%d+%d)", map->path, x, y);	2671	p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2920		2672
2921	return info;	2673	return info;
2922	}	2674	}
2923		2675
2924	const char *	2676	const char *
2925	object::debug_desc () const	2677	object::debug_desc () const
2926	{	2678	{
2927	static char info[256 * 3];	2679	static char info[256 * 4];
2928	return debug_desc (info);	2680	return debug_desc (info);
2929	}	2681	}
2930		2682

Diff Legend

–	Removed lines
+	Added lines
<	Changed lines
>	Changed lines