ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.41 by root, Thu Sep 14 01:12:28 2006 UTC vs.
Revision 1.81 by root, Sat Dec 23 13:56:25 2006 UTC

1
2/* 1/*
3 CrossFire, A Multiplayer game for X-windows 2 CrossFire, A Multiplayer game for X-windows
4 3
5 Copyright (C) 2001 Mark Wedel & Crossfire Development Team 4 Copyright (C) 2001 Mark Wedel & Crossfire Development Team
6 Copyright (C) 1992 Frank Tore Johansen 5 Copyright (C) 1992 Frank Tore Johansen
17 16
18 You should have received a copy of the GNU General Public License 17 You should have received a copy of the GNU General Public License
19 along with this program; if not, write to the Free Software 18 along with this program; if not, write to the Free Software
20 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 19 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
21 20
22 The authors can be reached via e-mail at crossfire-devel@real-time.com 21 The authors can be reached via e-mail at <crossfire@schmorp.de>
23*/ 22*/
24 23
25/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects. 24/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
26 sub/add_weight will transcend the environment updating the carrying 25 sub/add_weight will transcend the environment updating the carrying
27 variable. */ 26 variable. */
31#include <sys/uio.h> 30#include <sys/uio.h>
32#include <object.h> 31#include <object.h>
33#include <funcpoint.h> 32#include <funcpoint.h>
34#include <loader.h> 33#include <loader.h>
35 34
35#include <bitset>
36
36int nrofallocobjects = 0; 37int nrofallocobjects = 0;
37static UUID uuid; 38static UUID uuid;
38const uint64 UUID_SKIP = 1<<19; 39const uint64 UUID_SKIP = 1<<19;
39 40
40object *objects; /* Pointer to the list of used objects */
41object *active_objects; /* List of active objects that need to be processed */ 41object *active_objects; /* List of active objects that need to be processed */
42 42
43short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 43short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
44 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1 44 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1
45}; 45};
106 _exit (1); 106 _exit (1);
107 } 107 }
108 108
109 uuid.seq = uid; 109 uuid.seq = uid;
110 write_uuid (); 110 write_uuid ();
111 LOG (llevDebug, "read UID: %lld\n", uid); 111 LOG (llevDebug, "read UID: %" PRId64 "\n", uid);
112 fclose (fp); 112 fclose (fp);
113} 113}
114 114
115UUID 115UUID
116gen_uuid () 116gen_uuid ()
185 * 185 *
186 * Note that this function appears a lot longer than the macro it 186 * Note that this function appears a lot longer than the macro it
187 * replaces - this is mostly for clarity - a decent compiler should hopefully 187 * replaces - this is mostly for clarity - a decent compiler should hopefully
188 * reduce this to the same efficiency. 188 * reduce this to the same efficiency.
189 * 189 *
190 * Check nrof variable *before* calling CAN_MERGE() 190 * Check nrof variable *before* calling can_merge()
191 * 191 *
192 * Improvements made with merge: Better checking on potion, and also 192 * Improvements made with merge: Better checking on potion, and also
193 * check weight 193 * check weight
194 */ 194 */
195 195
196bool object::can_merge (object *ob1, object *ob2) 196bool object::can_merge_slow (object *ob1, object *ob2)
197{ 197{
198 /* A couple quicksanity checks */ 198 /* A couple quicksanity checks */
199 if ((ob1 == ob2) || (ob1->type != ob2->type)) 199 if (ob1 == ob2
200 || ob1->type != ob2->type
201 || ob1->speed != ob2->speed
202 || ob1->value != ob2->value
203 || ob1->name != ob2->name)
200 return 0; 204 return 0;
201 205
202 if (ob1->speed != ob2->speed) 206 //TODO: this ain't working well, use nicer and correct overflow check
203 return 0;
204
205 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that 207 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that
206 * value could not be stored in a sint32 (which unfortunately sometimes is 208 * value could not be stored in a sint32 (which unfortunately sometimes is
207 * used to store nrof). 209 * used to store nrof).
208 */ 210 */
209 if (ob1->nrof + ob2->nrof >= 1UL << 31) 211 if (ob1->nrof + ob2->nrof >= 1UL << 31)
219 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 221 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
220 222
221 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 223 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
222 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 224 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
223 225
224 226 if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any ()
225 /* the 0x400000 on flags2 is FLAG_INV_LOCK. I don't think something 227 || ob1->arch != ob2->arch
226 * being locked in inventory should prevent merging.
227 * 0x4 in flags3 is CLIENT_SENT
228 */
229 if ((ob1->arch != ob2->arch) ||
230 (ob1->flags[0] != ob2->flags[0]) ||
231 (ob1->flags[1] != ob2->flags[1]) ||
232 ((ob1->flags[2] & ~0x400000) != (ob2->flags[2] & ~0x400000)) ||
233 ((ob1->flags[3] & ~0x4) != (ob2->flags[3] & ~0x4)) ||
234 (ob1->name != ob2->name) || 228 || ob1->name != ob2->name
235 (ob1->title != ob2->title) || 229 || ob1->title != ob2->title
236 (ob1->msg != ob2->msg) || 230 || ob1->msg != ob2->msg
237 (ob1->weight != ob2->weight) || 231 || ob1->weight != ob2->weight
238 (memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist)) != 0) || 232 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
239 (memcmp (&ob1->stats, &ob2->stats, sizeof (ob1->stats)) != 0) || 233 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
240 (ob1->attacktype != ob2->attacktype) || 234 || ob1->attacktype != ob2->attacktype
241 (ob1->magic != ob2->magic) || 235 || ob1->magic != ob2->magic
242 (ob1->slaying != ob2->slaying) || 236 || ob1->slaying != ob2->slaying
243 (ob1->skill != ob2->skill) || 237 || ob1->skill != ob2->skill
244 (ob1->value != ob2->value) || 238 || ob1->value != ob2->value
245 (ob1->animation_id != ob2->animation_id) || 239 || ob1->animation_id != ob2->animation_id
246 (ob1->client_type != ob2->client_type) || 240 || ob1->client_type != ob2->client_type
247 (ob1->materialname != ob2->materialname) || 241 || ob1->materialname != ob2->materialname
248 (ob1->lore != ob2->lore) || 242 || ob1->lore != ob2->lore
249 (ob1->subtype != ob2->subtype) || 243 || ob1->subtype != ob2->subtype
250 (ob1->move_type != ob2->move_type) || 244 || ob1->move_type != ob2->move_type
251 (ob1->move_block != ob2->move_block) || 245 || ob1->move_block != ob2->move_block
252 (ob1->move_allow != ob2->move_allow) || 246 || ob1->move_allow != ob2->move_allow
253 (ob1->move_on != ob2->move_on) || 247 || ob1->move_on != ob2->move_on
254 (ob1->move_off != ob2->move_off) || (ob1->move_slow != ob2->move_slow) || (ob1->move_slow_penalty != ob2->move_slow_penalty)) 248 || ob1->move_off != ob2->move_off
249 || ob1->move_slow != ob2->move_slow
250 || ob1->move_slow_penalty != ob2->move_slow_penalty)
255 return 0; 251 return 0;
256 252
257 /* This is really a spellbook check - really, we should 253 /* This is really a spellbook check - really, we should
258 * check all objects in the inventory. 254 * check all objects in the inventory.
259 */ 255 */
262 /* if one object has inventory but the other doesn't, not equiv */ 258 /* if one object has inventory but the other doesn't, not equiv */
263 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv)) 259 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv))
264 return 0; 260 return 0;
265 261
266 /* Now check to see if the two inventory objects could merge */ 262 /* Now check to see if the two inventory objects could merge */
267 if (!CAN_MERGE (ob1->inv, ob2->inv)) 263 if (!object::can_merge (ob1->inv, ob2->inv))
268 return 0; 264 return 0;
269 265
270 /* inventory ok - still need to check rest of this object to see 266 /* inventory ok - still need to check rest of this object to see
271 * if it is valid. 267 * if it is valid.
272 */ 268 */
356 op = op->env; 352 op = op->env;
357 return op; 353 return op;
358} 354}
359 355
360/* 356/*
361 * Eneq(@csd.uu.se): Since we can have items buried in a character we need
362 * a better check. We basically keeping traversing up until we can't
363 * or find a player.
364 */
365
366object *
367is_player_inv (object *op)
368{
369 for (; op != NULL && op->type != PLAYER; op = op->env)
370 if (op->env == op)
371 op->env = NULL;
372 return op;
373}
374
375/*
376 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump. 357 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
377 * Some error messages. 358 * Some error messages.
378 * The result of the dump is stored in the static global errmsg array. 359 * The result of the dump is stored in the static global errmsg array.
379 */ 360 */
380 361
381void 362char *
382dump_object2 (object *op)
383{
384 errmsg[0] = 0;
385 return;
386 //TODO//D#d#
387#if 0
388 char *cp;
389
390/* object *tmp;*/
391
392 if (op->arch != NULL)
393 {
394 strcat (errmsg, "arch ");
395 strcat (errmsg, op->arch->name ? op->arch->name : "(null)");
396 strcat (errmsg, "\n");
397 if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
398 strcat (errmsg, cp);
399# if 0
400 /* Don't dump player diffs - they are too long, mostly meaningless, and
401 * will overflow the buffer.
402 * Changed so that we don't dump inventory either. This may
403 * also overflow the buffer.
404 */
405 if (op->type != PLAYER && (cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
406 strcat (errmsg, cp);
407 for (tmp = op->inv; tmp; tmp = tmp->below)
408 dump_object2 (tmp);
409# endif
410 strcat (errmsg, "end\n");
411 }
412 else
413 {
414 strcat (errmsg, "Object ");
415 if (op->name == NULL)
416 strcat (errmsg, "(null)");
417 else
418 strcat (errmsg, op->name);
419 strcat (errmsg, "\n");
420# if 0
421 if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
422 strcat (errmsg, cp);
423 for (tmp = op->inv; tmp; tmp = tmp->below)
424 dump_object2 (tmp);
425# endif
426 strcat (errmsg, "end\n");
427 }
428#endif
429}
430
431/*
432 * Dumps an object. Returns output in the static global errmsg array.
433 */
434
435void
436dump_object (object *op) 363dump_object (object *op)
437{ 364{
438 if (op == NULL) 365 if (!op)
439 { 366 return strdup ("[NULLOBJ]");
440 strcpy (errmsg, "[NULL pointer]");
441 return;
442 }
443 errmsg[0] = '\0';
444 dump_object2 (op);
445}
446 367
447void 368 object_freezer freezer;
448dump_all_objects (void) 369 save_object (freezer, op, 3);
449{ 370 return freezer.as_string ();
450 object *op;
451
452 for (op = objects; op != NULL; op = op->next)
453 {
454 dump_object (op);
455 fprintf (logfile, "Object %d\n:%s\n", op->count, errmsg);
456 }
457} 371}
458 372
459/* 373/*
460 * get_nearest_part(multi-object, object 2) returns the part of the 374 * get_nearest_part(multi-object, object 2) returns the part of the
461 * multi-object 1 which is closest to the second object. 375 * multi-object 1 which is closest to the second object.
481 */ 395 */
482 396
483object * 397object *
484find_object (tag_t i) 398find_object (tag_t i)
485{ 399{
486 object *op; 400 for (object *op = object::first; op; op = op->next)
487
488 for (op = objects; op != NULL; op = op->next)
489 if (op->count == i) 401 if (op->count == i)
490 break; 402 return op;
403
491 return op; 404 return 0;
492} 405}
493 406
494/* 407/*
495 * Returns the first object which has a name equal to the argument. 408 * Returns the first object which has a name equal to the argument.
496 * Used only by the patch command, but not all that useful. 409 * Used only by the patch command, but not all that useful.
501find_object_name (const char *str) 414find_object_name (const char *str)
502{ 415{
503 shstr_cmp str_ (str); 416 shstr_cmp str_ (str);
504 object *op; 417 object *op;
505 418
506 for (op = objects; op != NULL; op = op->next) 419 for (op = object::first; op != NULL; op = op->next)
507 if (op->name == str_) 420 if (op->name == str_)
508 break; 421 break;
509 422
510 return op; 423 return op;
511} 424}
512 425
513void 426void
514free_all_object_data () 427free_all_object_data ()
515{ 428{
516 LOG (llevDebug, "%d allocated objects\n", nrofallocobjects); 429 LOG (llevDebug, "%d allocated objects\n", nrofallocobjects);
517}
518
519/*
520 * Returns the object which this object marks as being the owner.
521 * A id-scheme is used to avoid pointing to objects which have been
522 * freed and are now reused. If this is detected, the owner is
523 * set to NULL, and NULL is returned.
524 * Changed 2004-02-12 - if the player is setting at the play again
525 * prompt, he is removed, and we don't want to treat him as an owner of
526 * anything, so check removed flag. I don't expect that this should break
527 * anything - once an object is removed, it is basically dead anyways.
528 */
529object *
530object::get_owner ()
531{
532 if (!owner
533 || QUERY_FLAG (owner, FLAG_FREED)
534 || QUERY_FLAG (owner, FLAG_REMOVED))
535 owner = 0;
536
537 return owner;
538} 430}
539 431
540/* 432/*
541 * Sets the owner and sets the skill and exp pointers to owner's current 433 * Sets the owner and sets the skill and exp pointers to owner's current
542 * skill and experience objects. 434 * skill and experience objects.
575 } 467 }
576 468
577 op->key_values = 0; 469 op->key_values = 0;
578} 470}
579 471
580void object::clear ()
581{
582 attachable_base::clear ();
583
584 free_key_values (this);
585
586 owner = 0;
587 name = 0;
588 name_pl = 0;
589 title = 0;
590 race = 0;
591 slaying = 0;
592 skill = 0;
593 msg = 0;
594 lore = 0;
595 custom_name = 0;
596 materialname = 0;
597 contr = 0;
598 below = 0;
599 above = 0;
600 inv = 0;
601 container = 0;
602 env = 0;
603 more = 0;
604 head = 0;
605 map = 0;
606 active_next = 0;
607 active_prev = 0;
608
609 memset (static_cast<object_pod *>(this), 0, sizeof (object_pod));
610
611 SET_FLAG (this, FLAG_REMOVED);
612
613 /* What is not cleared is next, prev, and count */
614
615 expmul = 1.0;
616 face = blank_face;
617 attacked_by_count = -1;
618
619 if (settings.casting_time)
620 casting_time = -1;
621}
622
623void object::clone (object *destination)
624{
625 *(object_copy *)destination = *this;
626 *(object_pod *)destination = *this;
627
628 if (self || cb)
629 INVOKE_OBJECT (CLONE, this, ARG_OBJECT (destination));
630}
631
632/* 472/*
633 * copy object first frees everything allocated by the second object, 473 * copy_to first frees everything allocated by the dst object,
634 * and then copies the contends of the first object into the second 474 * and then copies the contents of itself into the second
635 * object, allocating what needs to be allocated. Basically, any 475 * object, allocating what needs to be allocated. Basically, any
636 * data that is malloc'd needs to be re-malloc/copied. Otherwise, 476 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
637 * if the first object is freed, the pointers in the new object 477 * if the first object is freed, the pointers in the new object
638 * will point at garbage. 478 * will point at garbage.
639 */ 479 */
640void 480void
641copy_object (object *op2, object *op) 481object::copy_to (object *dst)
642{ 482{
643 bool is_freed = QUERY_FLAG (op, FLAG_FREED); 483 bool is_freed = QUERY_FLAG (dst, FLAG_FREED);
644 bool is_removed = QUERY_FLAG (op, FLAG_REMOVED); 484 bool is_removed = QUERY_FLAG (dst, FLAG_REMOVED);
645 485
646 op2->clone (op); 486 *(object_copy *)dst = *this;
487
488 if (self || cb)
489 INVOKE_OBJECT (CLONE, this, ARG_OBJECT (dst));
647 490
648 if (is_freed) 491 if (is_freed)
649 SET_FLAG (op, FLAG_FREED); 492 SET_FLAG (dst, FLAG_FREED);
493
650 if (is_removed) 494 if (is_removed)
651 SET_FLAG (op, FLAG_REMOVED); 495 SET_FLAG (dst, FLAG_REMOVED);
652 496
653 if (op2->speed < 0) 497 if (speed < 0)
654 op->speed_left = op2->speed_left - RANDOM () % 200 / 100.0; 498 dst->speed_left = speed_left - RANDOM () % 200 / 100.0;
655 499
656 /* Copy over key_values, if any. */ 500 /* Copy over key_values, if any. */
657 if (op2->key_values) 501 if (key_values)
658 { 502 {
659 key_value *tail = 0; 503 key_value *tail = 0;
660 key_value *i; 504 key_value *i;
661 505
662 op->key_values = 0; 506 dst->key_values = 0;
663 507
664 for (i = op2->key_values; i; i = i->next) 508 for (i = key_values; i; i = i->next)
665 { 509 {
666 key_value *new_link = new key_value; 510 key_value *new_link = new key_value;
667 511
668 new_link->next = 0; 512 new_link->next = 0;
669 new_link->key = i->key; 513 new_link->key = i->key;
670 new_link->value = i->value; 514 new_link->value = i->value;
671 515
672 /* Try and be clever here, too. */ 516 /* Try and be clever here, too. */
673 if (!op->key_values) 517 if (!dst->key_values)
674 { 518 {
675 op->key_values = new_link; 519 dst->key_values = new_link;
676 tail = new_link; 520 tail = new_link;
677 } 521 }
678 else 522 else
679 { 523 {
680 tail->next = new_link; 524 tail->next = new_link;
681 tail = new_link; 525 tail = new_link;
682 } 526 }
683 } 527 }
684 } 528 }
685 529
686 update_ob_speed (op); 530 update_ob_speed (dst);
531}
532
533object *
534object::clone ()
535{
536 object *neu = create ();
537 copy_to (neu);
538 return neu;
687} 539}
688 540
689/* 541/*
690 * If an object with the IS_TURNABLE() flag needs to be turned due 542 * If an object with the IS_TURNABLE() flag needs to be turned due
691 * to the closest player being on the other side, this function can 543 * to the closest player being on the other side, this function can
799 op->active_next = NULL; 651 op->active_next = NULL;
800 op->active_prev = NULL; 652 op->active_prev = NULL;
801} 653}
802 654
803/* 655/*
804 * update_object() updates the array which represents the map. 656 * update_object() updates the the map.
805 * It takes into account invisible objects (and represent squares covered 657 * It takes into account invisible objects (and represent squares covered
806 * by invisible objects by whatever is below them (unless it's another 658 * by invisible objects by whatever is below them (unless it's another
807 * invisible object, etc...) 659 * invisible object, etc...)
808 * If the object being updated is beneath a player, the look-window 660 * If the object being updated is beneath a player, the look-window
809 * of that player is updated (this might be a suboptimal way of 661 * of that player is updated (this might be a suboptimal way of
810 * updating that window, though, since update_object() is called _often_) 662 * updating that window, though, since update_object() is called _often_)
811 * 663 *
812 * action is a hint of what the caller believes need to be done. 664 * action is a hint of what the caller believes need to be done.
813 * For example, if the only thing that has changed is the face (due to
814 * an animation), we don't need to call update_position until that actually
815 * comes into view of a player. OTOH, many other things, like addition/removal
816 * of walls or living creatures may need us to update the flags now.
817 * current action are: 665 * current action are:
818 * UP_OBJ_INSERT: op was inserted 666 * UP_OBJ_INSERT: op was inserted
819 * UP_OBJ_REMOVE: op was removed 667 * UP_OBJ_REMOVE: op was removed
820 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update 668 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update
821 * as that is easier than trying to look at what may have changed. 669 * as that is easier than trying to look at what may have changed.
822 * UP_OBJ_FACE: only the objects face has changed. 670 * UP_OBJ_FACE: only the objects face has changed.
823 */ 671 */
824
825void 672void
826update_object (object *op, int action) 673update_object (object *op, int action)
827{ 674{
828 int update_now = 0, flags;
829 MoveType move_on, move_off, move_block, move_slow; 675 MoveType move_on, move_off, move_block, move_slow;
830 676
831 if (op == NULL) 677 if (op == NULL)
832 { 678 {
833 /* this should never happen */ 679 /* this should never happen */
834 LOG (llevDebug, "update_object() called for NULL object.\n"); 680 LOG (llevDebug, "update_object() called for NULL object.\n");
835 return; 681 return;
836 } 682 }
837 683
838 if (op->env != NULL) 684 if (op->env)
839 { 685 {
840 /* Animation is currently handled by client, so nothing 686 /* Animation is currently handled by client, so nothing
841 * to do in this case. 687 * to do in this case.
842 */ 688 */
843 return; 689 return;
857 abort (); 703 abort ();
858#endif 704#endif
859 return; 705 return;
860 } 706 }
861 707
862 flags = GET_MAP_FLAGS (op->map, op->x, op->y); 708 mapspace &m = op->ms ();
863 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NEED_UPDATE);
864 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
865 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
866 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
867 move_off = GET_MAP_MOVE_OFF (op->map, op->x, op->y);
868 709
710 if (m.flags_ & P_NEED_UPDATE)
711 /* nop */;
869 if (action == UP_OBJ_INSERT) 712 else if (action == UP_OBJ_INSERT)
870 { 713 {
714 // this is likely overkill, TODO: revisit (schmorp)
871 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(flags & P_BLOCKSVIEW)) 715 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
872 update_now = 1;
873
874 if (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(flags & P_NO_MAGIC)) 716 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
875 update_now = 1; 717 || (op->type == PLAYER && !(m.flags_ & P_PLAYER))
876 718 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
719 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
877 if (QUERY_FLAG (op, FLAG_DAMNED) && !(flags & P_NO_CLERIC)) 720 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
878 update_now = 1;
879
880 if (QUERY_FLAG (op, FLAG_ALIVE) && !(flags & P_IS_ALIVE))
881 update_now = 1;
882
883 if (op->type == SAFE_GROUND && !(flags & P_SAFE))
884 update_now = 1;
885
886 if ((move_on | op->move_on) != move_on) 721 || (m.move_on | op->move_on ) != m.move_on
887 update_now = 1;
888
889 if ((move_off | op->move_off) != move_off) 722 || (m.move_off | op->move_off ) != m.move_off
890 update_now = 1; 723 || (m.move_slow | op->move_slow) != m.move_slow
891
892 /* This isn't perfect, but I don't expect a lot of objects to 724 /* This isn't perfect, but I don't expect a lot of objects to
893 * to have move_allow right now. 725 * to have move_allow right now.
894 */ 726 */
895 if (((move_block | op->move_block) & ~op->move_allow) != move_block) 727 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
896 update_now = 1; 728 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
897 729 m.flags_ = P_NEED_UPDATE;
898 if ((move_slow | op->move_slow) != move_slow)
899 update_now = 1;
900 } 730 }
901 /* if the object is being removed, we can't make intelligent 731 /* if the object is being removed, we can't make intelligent
902 * decisions, because remove_ob can't really pass the object 732 * decisions, because remove_ob can't really pass the object
903 * that is being removed. 733 * that is being removed.
904 */ 734 */
905 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 735 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
906 update_now = 1; 736 m.flags_ = P_NEED_UPDATE;
907 else if (action == UP_OBJ_FACE) 737 else if (action == UP_OBJ_FACE)
908 /* Nothing to do for that case */ ; 738 /* Nothing to do for that case */ ;
909 else 739 else
910 LOG (llevError, "update_object called with invalid action: %d\n", action); 740 LOG (llevError, "update_object called with invalid action: %d\n", action);
911 741
912 if (update_now)
913 {
914 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NO_ERROR | P_NEED_UPDATE);
915 update_position (op->map, op->x, op->y);
916 }
917
918 if (op->more != NULL) 742 if (op->more)
919 update_object (op->more, action); 743 update_object (op->more, action);
920} 744}
921 745
922static unordered_vector<object *> mortals; 746object::vector object::mortals;
923static std::vector<object *, slice_allocator <object *> > freed; 747object::vector object::objects; // not yet used
748object *object::first;
924 749
925void object::free_mortals () 750void object::free_mortals ()
926{ 751{
927 for (unordered_vector<object *>::iterator i = mortals.begin (); i != mortals.end ();) 752 for (AUTODECL (i, mortals.begin ()); i != mortals.end ();)
928 if ((*i)->refcnt) 753 if ((*i)->refcnt)
929 ++i; // further delay freeing 754 ++i; // further delay freeing
930 else 755 else
931 { 756 {
932 //printf ("free_mortal(%p,%ld,%ld)\n", *i, pticks, (*i)->count);//D
933 //freed.push_back (*i);//D
934 delete *i; 757 delete *i;
935 mortals.erase (i); 758 mortals.erase (i);
936 } 759 }
937
938 if (mortals.size() && 0)//D
939 LOG (llevDebug, "%d objects in mortal queue\n", mortals.size());//D
940} 760}
941 761
942object::object () 762object::object ()
943{ 763{
944 SET_FLAG (this, FLAG_REMOVED); 764 SET_FLAG (this, FLAG_REMOVED);
945 765
946 expmul = 1.0; 766 expmul = 1.0;
947 face = blank_face; 767 face = blank_face;
948 attacked_by_count = -1;
949} 768}
950 769
951object::~object () 770object::~object ()
952{ 771{
953 free_key_values (this); 772 free_key_values (this);
957{ 776{
958 count = ++ob_count; 777 count = ++ob_count;
959 uuid = gen_uuid (); 778 uuid = gen_uuid ();
960 779
961 prev = 0; 780 prev = 0;
962 next = objects; 781 next = object::first;
963 782
964 if (objects) 783 if (object::first)
965 objects->prev = this; 784 object::first->prev = this;
966 785
967 objects = this; 786 object::first = this;
968} 787}
969 788
970void object::unlink () 789void object::unlink ()
971{ 790{
972 //count = 0;//D
973 if (!prev && !next) return;//D
974
975 if (this == objects) 791 if (this == object::first)
976 objects = next; 792 object::first = next;
977 793
978 /* Remove this object from the list of used objects */ 794 /* Remove this object from the list of used objects */
979 if (prev) prev->next = next; 795 if (prev) prev->next = next;
980 if (next) next->prev = prev; 796 if (next) next->prev = prev;
981 797
983 next = 0; 799 next = 0;
984} 800}
985 801
986object *object::create () 802object *object::create ()
987{ 803{
988 object *op;
989
990 if (freed.empty ())
991 op = new object; 804 object *op = new object;
992 else
993 {
994 // highly annoying, but the only way to get it stable right now
995 op = freed.back ();
996 freed.pop_back ();
997 op->~object ();
998 new ((void *) op) object;
999 }
1000
1001 op->link (); 805 op->link ();
1002 return op; 806 return op;
1003} 807}
1004 808
1005/* 809/*
1007 * it from the list of used objects, and puts it on the list of 811 * it from the list of used objects, and puts it on the list of
1008 * free objects. The IS_FREED() flag is set in the object. 812 * free objects. The IS_FREED() flag is set in the object.
1009 * The object must have been removed by remove_ob() first for 813 * The object must have been removed by remove_ob() first for
1010 * this function to succeed. 814 * this function to succeed.
1011 * 815 *
1012 * If free_inventory is set, free inventory as well. Else drop items in 816 * If destroy_inventory is set, free inventory as well. Else drop items in
1013 * inventory to the ground. 817 * inventory to the ground.
1014 */ 818 */
1015void object::free (bool free_inventory) 819void object::destroy (bool destroy_inventory)
1016{ 820{
1017 if (QUERY_FLAG (this, FLAG_FREED)) 821 if (QUERY_FLAG (this, FLAG_FREED))
1018 return; 822 return;
1019 823
1020 if (QUERY_FLAG (this, FLAG_FRIENDLY)) 824 if (QUERY_FLAG (this, FLAG_FRIENDLY))
1021 remove_friendly_object (this); 825 remove_friendly_object (this);
1022 826
1023 if (!QUERY_FLAG (this, FLAG_REMOVED)) 827 if (!QUERY_FLAG (this, FLAG_REMOVED))
1024 remove_ob (this); 828 remove ();
1025 829
1026 SET_FLAG (this, FLAG_FREED); 830 SET_FLAG (this, FLAG_FREED);
1027 831
1028 //printf ("free(%p,%ld,%ld)\n", this, pticks, count);//D
1029
1030 if (more) 832 if (more)
1031 { 833 {
1032 more->free (free_inventory); 834 more->destroy (destroy_inventory);
1033 more = 0; 835 more = 0;
1034 } 836 }
1035 837
1036 if (inv) 838 if (inv)
1037 { 839 {
1038 /* Only if the space blocks everything do we not process - 840 /* Only if the space blocks everything do we not process -
1039 * if some form of movement is allowed, let objects 841 * if some form of movement is allowed, let objects
1040 * drop on that space. 842 * drop on that space.
1041 */ 843 */
1042 if (free_inventory || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL) 844 if (destroy_inventory || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL)
1043 { 845 {
1044 object *op = inv; 846 object *op = inv;
1045 847
1046 while (op) 848 while (op)
1047 { 849 {
1048 object *tmp = op->below; 850 object *tmp = op->below;
1049 op->free (free_inventory); 851 op->destroy (destroy_inventory);
1050 op = tmp; 852 op = tmp;
1051 } 853 }
1052 } 854 }
1053 else 855 else
1054 { /* Put objects in inventory onto this space */ 856 { /* Put objects in inventory onto this space */
1056 858
1057 while (op) 859 while (op)
1058 { 860 {
1059 object *tmp = op->below; 861 object *tmp = op->below;
1060 862
1061 remove_ob (op); 863 op->remove ();
1062 864
1063 if (QUERY_FLAG (op, FLAG_STARTEQUIP) 865 if (QUERY_FLAG (op, FLAG_STARTEQUIP)
1064 || QUERY_FLAG (op, FLAG_NO_DROP) || op->type == RUNE || op->type == TRAP || QUERY_FLAG (op, FLAG_IS_A_TEMPLATE)) 866 || QUERY_FLAG (op, FLAG_NO_DROP) || op->type == RUNE || op->type == TRAP || QUERY_FLAG (op, FLAG_IS_A_TEMPLATE))
1065 free_object (op); 867 op->destroy ();
1066 else 868 else
1067 { 869 {
1068 op->x = x; 870 op->x = x;
1069 op->y = y; 871 op->y = y;
1070 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */ 872 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
1073 op = tmp; 875 op = tmp;
1074 } 876 }
1075 } 877 }
1076 } 878 }
1077 879
880 // hack to ensure that freed objects still have a valid map
881 {
882 static maptile *freed_map; // freed objects are moved here to avoid crashes
883
884 if (!freed_map)
885 {
886 freed_map = new maptile;
887
888 freed_map->name = "/internal/freed_objects_map";
889 freed_map->width = 3;
890 freed_map->height = 3;
891
892 freed_map->allocate ();
893 }
894
895 map = freed_map;
896 x = 1;
897 y = 1;
898 }
899
900 // clear those pointers that likely might have circular references to us
1078 owner = 0; 901 owner = 0;
902 enemy = 0;
903 attacked_by = 0;
904
905 // only relevant for players(?), but make sure of it anyways
906 contr = 0;
1079 907
1080 /* Remove object from the active list */ 908 /* Remove object from the active list */
1081 speed = 0; 909 speed = 0;
1082 update_ob_speed (this); 910 update_ob_speed (this);
1083 911
1088 916
1089/* 917/*
1090 * sub_weight() recursively (outwards) subtracts a number from the 918 * sub_weight() recursively (outwards) subtracts a number from the
1091 * weight of an object (and what is carried by it's environment(s)). 919 * weight of an object (and what is carried by it's environment(s)).
1092 */ 920 */
1093
1094void 921void
1095sub_weight (object *op, signed long weight) 922sub_weight (object *op, signed long weight)
1096{ 923{
1097 while (op != NULL) 924 while (op != NULL)
1098 { 925 {
1099 if (op->type == CONTAINER) 926 if (op->type == CONTAINER)
1100 {
1101 weight = (signed long) (weight * (100 - op->stats.Str) / 100); 927 weight = (signed long) (weight * (100 - op->stats.Str) / 100);
1102 } 928
1103 op->carrying -= weight; 929 op->carrying -= weight;
1104 op = op->env; 930 op = op->env;
1105 } 931 }
1106} 932}
1107 933
1108/* remove_ob(op): 934/* op->remove ():
1109 * This function removes the object op from the linked list of objects 935 * This function removes the object op from the linked list of objects
1110 * which it is currently tied to. When this function is done, the 936 * which it is currently tied to. When this function is done, the
1111 * object will have no environment. If the object previously had an 937 * object will have no environment. If the object previously had an
1112 * environment, the x and y coordinates will be updated to 938 * environment, the x and y coordinates will be updated to
1113 * the previous environment. 939 * the previous environment.
1114 * Beware: This function is called from the editor as well! 940 * Beware: This function is called from the editor as well!
1115 */ 941 */
1116
1117void 942void
1118remove_ob (object *op) 943object::remove ()
1119{ 944{
945 object *tmp, *last = 0;
1120 object * 946 object *otmp;
1121 tmp, *
1122 last = NULL;
1123 object *
1124 otmp;
1125 947
1126 tag_t
1127 tag;
1128 int
1129 check_walk_off; 948 int check_walk_off;
1130 mapstruct *
1131 m;
1132 949
1133 sint16
1134 x,
1135 y;
1136
1137 if (QUERY_FLAG (op, FLAG_REMOVED)) 950 if (QUERY_FLAG (this, FLAG_REMOVED))
1138 return; 951 return;
1139 952
1140 SET_FLAG (op, FLAG_REMOVED); 953 SET_FLAG (this, FLAG_REMOVED);
1141 954
1142 if (op->more != NULL) 955 if (more)
1143 remove_ob (op->more); 956 more->remove ();
1144 957
1145 /* 958 /*
1146 * In this case, the object to be removed is in someones 959 * In this case, the object to be removed is in someones
1147 * inventory. 960 * inventory.
1148 */ 961 */
1149 if (op->env != NULL) 962 if (env)
1150 { 963 {
1151 if (op->nrof) 964 if (nrof)
1152 sub_weight (op->env, op->weight * op->nrof); 965 sub_weight (env, weight * nrof);
1153 else 966 else
1154 sub_weight (op->env, op->weight + op->carrying); 967 sub_weight (env, weight + carrying);
1155 968
1156 /* NO_FIX_PLAYER is set when a great many changes are being 969 /* NO_FIX_PLAYER is set when a great many changes are being
1157 * made to players inventory. If set, avoiding the call 970 * made to players inventory. If set, avoiding the call
1158 * to save cpu time. 971 * to save cpu time.
1159 */ 972 */
1160 if ((otmp = is_player_inv (op->env)) != NULL && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 973 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1161 fix_player (otmp); 974 otmp->update_stats ();
1162 975
1163 if (op->above != NULL) 976 if (above != NULL)
1164 op->above->below = op->below; 977 above->below = below;
1165 else 978 else
1166 op->env->inv = op->below; 979 env->inv = below;
1167 980
1168 if (op->below != NULL) 981 if (below != NULL)
1169 op->below->above = op->above; 982 below->above = above;
1170 983
1171 /* we set up values so that it could be inserted into 984 /* we set up values so that it could be inserted into
1172 * the map, but we don't actually do that - it is up 985 * the map, but we don't actually do that - it is up
1173 * to the caller to decide what we want to do. 986 * to the caller to decide what we want to do.
1174 */ 987 */
1175 op->x = op->env->x, op->y = op->env->y; 988 x = env->x, y = env->y;
1176 op->map = op->env->map; 989 map = env->map;
1177 op->above = NULL, op->below = NULL; 990 above = 0, below = 0;
1178 op->env = NULL; 991 env = 0;
1179 } 992 }
1180 else if (op->map) 993 else if (map)
1181 { 994 {
1182 x = op->x;
1183 y = op->y;
1184 m = get_map_from_coord (op->map, &x, &y);
1185
1186 if (!m)
1187 {
1188 LOG (llevError, "remove_ob called when object was on map but appears to not be within valid coordinates? %s (%d,%d)\n",
1189 op->map->path, op->x, op->y);
1190 /* in old days, we used to set x and y to 0 and continue.
1191 * it seems if we get into this case, something is probablye
1192 * screwed up and should be fixed.
1193 */
1194 abort ();
1195 }
1196
1197 if (op->map != m)
1198 LOG (llevDebug, "remove_ob: Object not really on map it claimed to be on? %s != %s, %d,%d != %d,%d\n",
1199 op->map->path, m->path, op->x, op->y, x, y);
1200
1201 /* Re did the following section of code - it looks like it had 995 /* Re did the following section of code - it looks like it had
1202 * lots of logic for things we no longer care about 996 * lots of logic for things we no longer care about
1203 */ 997 */
1204 998
1205 /* link the object above us */ 999 /* link the object above us */
1206 if (op->above) 1000 if (above)
1207 op->above->below = op->below; 1001 above->below = below;
1208 else 1002 else
1209 SET_MAP_TOP (m, x, y, op->below); /* we were top, set new top */ 1003 map->at (x, y).top = below; /* we were top, set new top */
1210 1004
1211 /* Relink the object below us, if there is one */ 1005 /* Relink the object below us, if there is one */
1212 if (op->below) 1006 if (below)
1213 op->below->above = op->above; 1007 below->above = above;
1214 else 1008 else
1215 { 1009 {
1216 /* Nothing below, which means we need to relink map object for this space 1010 /* Nothing below, which means we need to relink map object for this space
1217 * use translated coordinates in case some oddness with map tiling is 1011 * use translated coordinates in case some oddness with map tiling is
1218 * evident 1012 * evident
1219 */ 1013 */
1220 if (GET_MAP_OB (m, x, y) != op) 1014 if (GET_MAP_OB (map, x, y) != this)
1221 { 1015 {
1222 dump_object (op); 1016 char *dump = dump_object (this);
1223 LOG (llevError, 1017 LOG (llevError,
1224 "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", errmsg); 1018 "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", dump);
1019 free (dump);
1225 dump_object (GET_MAP_OB (m, x, y)); 1020 dump = dump_object (GET_MAP_OB (map, x, y));
1226 LOG (llevError, "%s\n", errmsg); 1021 LOG (llevError, "%s\n", dump);
1022 free (dump);
1227 } 1023 }
1228 1024
1229 SET_MAP_OB (m, x, y, op->above); /* goes on above it. */ 1025 map->at (x, y).bottom = above; /* goes on above it. */
1230 } 1026 }
1231 1027
1232 op->above = 0; 1028 above = 0;
1233 op->below = 0; 1029 below = 0;
1234 1030
1235 if (op->map->in_memory == MAP_SAVING) 1031 if (map->in_memory == MAP_SAVING)
1236 return; 1032 return;
1237 1033
1238 tag = op->count;
1239 check_walk_off = !QUERY_FLAG (op, FLAG_NO_APPLY); 1034 check_walk_off = !QUERY_FLAG (this, FLAG_NO_APPLY);
1240 1035
1241 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1036 for (tmp = GET_MAP_OB (map, x, y); tmp; tmp = tmp->above)
1242 { 1037 {
1243 /* No point updating the players look faces if he is the object 1038 /* No point updating the players look faces if he is the object
1244 * being removed. 1039 * being removed.
1245 */ 1040 */
1246 1041
1247 if (tmp->type == PLAYER && tmp != op) 1042 if (tmp->type == PLAYER && tmp != this)
1248 { 1043 {
1249 /* If a container that the player is currently using somehow gets 1044 /* If a container that the player is currently using somehow gets
1250 * removed (most likely destroyed), update the player view 1045 * removed (most likely destroyed), update the player view
1251 * appropriately. 1046 * appropriately.
1252 */ 1047 */
1253 if (tmp->container == op) 1048 if (tmp->container == this)
1254 { 1049 {
1255 CLEAR_FLAG (op, FLAG_APPLIED); 1050 CLEAR_FLAG (this, FLAG_APPLIED);
1256 tmp->container = NULL; 1051 tmp->container = 0;
1257 } 1052 }
1258 1053
1259 tmp->contr->socket.update_look = 1; 1054 tmp->contr->ns->floorbox_update ();
1260 } 1055 }
1261 1056
1262 /* See if player moving off should effect something */ 1057 /* See if player moving off should effect something */
1263 if (check_walk_off && ((op->move_type & tmp->move_off) && (op->move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1058 if (check_walk_off
1059 && ((move_type & tmp->move_off)
1060 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0))
1264 { 1061 {
1265 move_apply (tmp, op, NULL); 1062 move_apply (tmp, this, 0);
1266 1063
1267 if (was_destroyed (op, tag)) 1064 if (destroyed ())
1268 {
1269 LOG (llevError, "BUG: remove_ob(): name %s, archname %s destroyed " "leaving object\n", &tmp->name, &tmp->arch->name); 1065 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1270 }
1271 } 1066 }
1272 1067
1273 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */ 1068 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */
1274 1069
1275 if (tmp->above == tmp) 1070 if (tmp->above == tmp)
1276 tmp->above = NULL; 1071 tmp->above = 0;
1277 1072
1278 last = tmp; 1073 last = tmp;
1279 } 1074 }
1280 1075
1281 /* last == NULL of there are no objects on this space */ 1076 /* last == NULL of there are no objects on this space */
1282 if (last == NULL) 1077 if (!last)
1283 { 1078 map->at (x, y).flags_ = P_NEED_UPDATE;
1284 /* set P_NEED_UPDATE, otherwise update_position will complain. In theory,
1285 * we could preserve the flags (GET_MAP_FLAGS), but update_position figures
1286 * those out anyways, and if there are any flags set right now, they won't
1287 * be correct anyways.
1288 */
1289 SET_MAP_FLAGS (op->map, op->x, op->y, P_NEED_UPDATE);
1290 update_position (op->map, op->x, op->y);
1291 }
1292 else 1079 else
1293 update_object (last, UP_OBJ_REMOVE); 1080 update_object (last, UP_OBJ_REMOVE);
1294 1081
1295 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) || (op->glow_radius != 0)) 1082 if (QUERY_FLAG (this, FLAG_BLOCKSVIEW) || glow_radius)
1296 update_all_los (op->map, op->x, op->y); 1083 update_all_los (map, x, y);
1297 } 1084 }
1298} 1085}
1299 1086
1300/* 1087/*
1301 * merge_ob(op,top): 1088 * merge_ob(op,top):
1316 1103
1317 for (; top != NULL; top = top->below) 1104 for (; top != NULL; top = top->below)
1318 { 1105 {
1319 if (top == op) 1106 if (top == op)
1320 continue; 1107 continue;
1321 if (CAN_MERGE (op, top)) 1108
1109 if (object::can_merge (op, top))
1322 { 1110 {
1323 top->nrof += op->nrof; 1111 top->nrof += op->nrof;
1324 1112
1325/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/ 1113/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/
1326 op->weight = 0; /* Don't want any adjustements now */ 1114 op->weight = 0; /* Don't want any adjustements now */
1327 remove_ob (op); 1115 op->destroy ();
1328 free_object (op);
1329 return top; 1116 return top;
1330 } 1117 }
1331 } 1118 }
1332 1119
1333 return NULL; 1120 return 0;
1334} 1121}
1335 1122
1336/* 1123/*
1337 * same as insert_ob_in_map except it handle separate coordinates and do a clean 1124 * same as insert_ob_in_map except it handle separate coordinates and do a clean
1338 * job preparing multi-part monsters 1125 * job preparing multi-part monsters
1339 */ 1126 */
1340object * 1127object *
1341insert_ob_in_map_at (object *op, mapstruct *m, object *originator, int flag, int x, int y) 1128insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1342{ 1129{
1343 object *tmp; 1130 object *tmp;
1344 1131
1345 if (op->head) 1132 if (op->head)
1346 op = op->head; 1133 op = op->head;
1374 * NULL if 'op' was destroyed 1161 * NULL if 'op' was destroyed
1375 * just 'op' otherwise 1162 * just 'op' otherwise
1376 */ 1163 */
1377 1164
1378object * 1165object *
1379insert_ob_in_map (object *op, mapstruct *m, object *originator, int flag) 1166insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1380{ 1167{
1381 object *tmp, *top, *floor = NULL; 1168 object *tmp, *top, *floor = NULL;
1382 sint16 x, y; 1169 sint16 x, y;
1383 1170
1384 if (QUERY_FLAG (op, FLAG_FREED)) 1171 if (QUERY_FLAG (op, FLAG_FREED))
1387 return NULL; 1174 return NULL;
1388 } 1175 }
1389 1176
1390 if (m == NULL) 1177 if (m == NULL)
1391 { 1178 {
1392 dump_object (op); 1179 char *dump = dump_object (op);
1393 LOG (llevError, "Trying to insert in null-map!\n%s\n", errmsg); 1180 LOG (llevError, "Trying to insert in null-map!\n%s\n", dump);
1181 free (dump);
1394 return op; 1182 return op;
1395 } 1183 }
1396 1184
1397 if (out_of_map (m, op->x, op->y)) 1185 if (out_of_map (m, op->x, op->y))
1398 { 1186 {
1399 dump_object (op); 1187 char *dump = dump_object (op);
1400 LOG (llevError, "Trying to insert object outside the map.\n%s\n", errmsg); 1188 LOG (llevError, "Trying to insert object outside the map.\n%s\n", dump);
1401#ifdef MANY_CORES 1189#ifdef MANY_CORES
1402 /* Better to catch this here, as otherwise the next use of this object 1190 /* Better to catch this here, as otherwise the next use of this object
1403 * is likely to cause a crash. Better to find out where it is getting 1191 * is likely to cause a crash. Better to find out where it is getting
1404 * improperly inserted. 1192 * improperly inserted.
1405 */ 1193 */
1406 abort (); 1194 abort ();
1407#endif 1195#endif
1196 free (dump);
1408 return op; 1197 return op;
1409 } 1198 }
1410 1199
1411 if (!QUERY_FLAG (op, FLAG_REMOVED)) 1200 if (!QUERY_FLAG (op, FLAG_REMOVED))
1412 { 1201 {
1413 dump_object (op); 1202 char *dump = dump_object (op);
1414 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", errmsg); 1203 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", dump);
1204 free (dump);
1415 return op; 1205 return op;
1416 } 1206 }
1417 1207
1418 if (op->more != NULL) 1208 if (op->more != NULL)
1419 { 1209 {
1457 1247
1458 /* this has to be done after we translate the coordinates. 1248 /* this has to be done after we translate the coordinates.
1459 */ 1249 */
1460 if (op->nrof && !(flag & INS_NO_MERGE)) 1250 if (op->nrof && !(flag & INS_NO_MERGE))
1461 for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above) 1251 for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above)
1462 if (CAN_MERGE (op, tmp)) 1252 if (object::can_merge (op, tmp))
1463 { 1253 {
1464 op->nrof += tmp->nrof; 1254 op->nrof += tmp->nrof;
1465 remove_ob (tmp); 1255 tmp->destroy ();
1466 free_object (tmp);
1467 } 1256 }
1468 1257
1469 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1258 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1470 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1259 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1471 1260
1484 op->below = originator->below; 1273 op->below = originator->below;
1485 1274
1486 if (op->below) 1275 if (op->below)
1487 op->below->above = op; 1276 op->below->above = op;
1488 else 1277 else
1489 SET_MAP_OB (op->map, op->x, op->y, op); 1278 op->ms ().bottom = op;
1490 1279
1491 /* since *below* originator, no need to update top */ 1280 /* since *below* originator, no need to update top */
1492 originator->below = op; 1281 originator->below = op;
1493 } 1282 }
1494 else 1283 else
1540 * If INS_ON_TOP is used, don't do this processing 1329 * If INS_ON_TOP is used, don't do this processing
1541 * Need to find the object that in fact blocks view, otherwise 1330 * Need to find the object that in fact blocks view, otherwise
1542 * stacking is a bit odd. 1331 * stacking is a bit odd.
1543 */ 1332 */
1544 if (!(flag & INS_ON_TOP) && 1333 if (!(flag & INS_ON_TOP) &&
1545 (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_BLOCKSVIEW) && (op->face && !op->face->visibility)) 1334 (get_map_flags (op->map, 0, op->x, op->y, 0, 0) & P_BLOCKSVIEW) && (op->face && !op->face->visibility))
1546 { 1335 {
1547 for (last = top; last != floor; last = last->below) 1336 for (last = top; last != floor; last = last->below)
1548 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1337 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1549 break; 1338 break;
1550 /* Check to see if we found the object that blocks view, 1339 /* Check to see if we found the object that blocks view,
1573 1362
1574 if (op->above) 1363 if (op->above)
1575 op->above->below = op; 1364 op->above->below = op;
1576 1365
1577 op->below = NULL; 1366 op->below = NULL;
1578 SET_MAP_OB (op->map, op->x, op->y, op); 1367 op->ms ().bottom = op;
1579 } 1368 }
1580 else 1369 else
1581 { /* get inserted into the stack above top */ 1370 { /* get inserted into the stack above top */
1582 op->above = top->above; 1371 op->above = top->above;
1583 1372
1587 op->below = top; 1376 op->below = top;
1588 top->above = op; 1377 top->above = op;
1589 } 1378 }
1590 1379
1591 if (op->above == NULL) 1380 if (op->above == NULL)
1592 SET_MAP_TOP (op->map, op->x, op->y, op); 1381 op->ms ().top = op;
1593 } /* else not INS_BELOW_ORIGINATOR */ 1382 } /* else not INS_BELOW_ORIGINATOR */
1594 1383
1595 if (op->type == PLAYER) 1384 if (op->type == PLAYER)
1596 op->contr->do_los = 1; 1385 op->contr->do_los = 1;
1597 1386
1598 /* If we have a floor, we know the player, if any, will be above 1387 /* If we have a floor, we know the player, if any, will be above
1599 * it, so save a few ticks and start from there. 1388 * it, so save a few ticks and start from there.
1600 */ 1389 */
1601 if (!(flag & INS_MAP_LOAD)) 1390 if (!(flag & INS_MAP_LOAD))
1602 for (tmp = floor ? floor : GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1391 if (object *pl = op->ms ().player ())
1603 if (tmp->type == PLAYER) 1392 pl->contr->ns->floorbox_update ();
1604 tmp->contr->socket.update_look = 1;
1605 1393
1606 /* If this object glows, it may affect lighting conditions that are 1394 /* If this object glows, it may affect lighting conditions that are
1607 * visible to others on this map. But update_all_los is really 1395 * visible to others on this map. But update_all_los is really
1608 * an inefficient way to do this, as it means los for all players 1396 * an inefficient way to do this, as it means los for all players
1609 * on the map will get recalculated. The players could very well 1397 * on the map will get recalculated. The players could very well
1617 1405
1618 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1406 /* updates flags (blocked, alive, no magic, etc) for this map space */
1619 update_object (op, UP_OBJ_INSERT); 1407 update_object (op, UP_OBJ_INSERT);
1620 1408
1621 /* Don't know if moving this to the end will break anything. However, 1409 /* Don't know if moving this to the end will break anything. However,
1622 * we want to have update_look set above before calling this. 1410 * we want to have floorbox_update called before calling this.
1623 * 1411 *
1624 * check_move_on() must be after this because code called from 1412 * check_move_on() must be after this because code called from
1625 * check_move_on() depends on correct map flags (so functions like 1413 * check_move_on() depends on correct map flags (so functions like
1626 * blocked() and wall() work properly), and these flags are updated by 1414 * blocked() and wall() work properly), and these flags are updated by
1627 * update_object(). 1415 * update_object().
1643 1431
1644 return op; 1432 return op;
1645} 1433}
1646 1434
1647/* this function inserts an object in the map, but if it 1435/* this function inserts an object in the map, but if it
1648 * finds an object of its own type, it'll remove that one first. 1436 * finds an object of its own type, it'll remove that one first.
1649 * op is the object to insert it under: supplies x and the map. 1437 * op is the object to insert it under: supplies x and the map.
1650 */ 1438 */
1651void 1439void
1652replace_insert_ob_in_map (const char *arch_string, object *op) 1440replace_insert_ob_in_map (const char *arch_string, object *op)
1653{ 1441{
1654 object * 1442 object *tmp, *tmp1;
1655 tmp;
1656 object *
1657 tmp1;
1658 1443
1659 /* first search for itself and remove any old instances */ 1444 /* first search for itself and remove any old instances */
1660 1445
1661 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1446 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above)
1662 {
1663 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */ 1447 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */
1664 { 1448 tmp->destroy ();
1665 remove_ob (tmp);
1666 free_object (tmp);
1667 }
1668 }
1669 1449
1670 tmp1 = arch_to_object (find_archetype (arch_string)); 1450 tmp1 = arch_to_object (archetype::find (arch_string));
1671 1451
1672 tmp1->x = op->x; 1452 tmp1->x = op->x;
1673 tmp1->y = op->y; 1453 tmp1->y = op->y;
1674 insert_ob_in_map (tmp1, op->map, op, 0); 1454 insert_ob_in_map (tmp1, op->map, op, 0);
1675} 1455}
1683 */ 1463 */
1684 1464
1685object * 1465object *
1686get_split_ob (object *orig_ob, uint32 nr) 1466get_split_ob (object *orig_ob, uint32 nr)
1687{ 1467{
1688 object * 1468 object *newob;
1689 newob;
1690 int
1691 is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0); 1469 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1692 1470
1693 if (orig_ob->nrof < nr) 1471 if (orig_ob->nrof < nr)
1694 { 1472 {
1695 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name); 1473 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1696 return NULL; 1474 return NULL;
1697 } 1475 }
1698 1476
1699 newob = object_create_clone (orig_ob); 1477 newob = object_create_clone (orig_ob);
1700 1478
1701 if ((orig_ob->nrof -= nr) < 1) 1479 if ((orig_ob->nrof -= nr) < 1)
1702 { 1480 orig_ob->destroy (1);
1703 if (!is_removed)
1704 remove_ob (orig_ob);
1705 free_object2 (orig_ob, 1);
1706 }
1707 else if (!is_removed) 1481 else if (!is_removed)
1708 { 1482 {
1709 if (orig_ob->env != NULL) 1483 if (orig_ob->env != NULL)
1710 sub_weight (orig_ob->env, orig_ob->weight * nr); 1484 sub_weight (orig_ob->env, orig_ob->weight * nr);
1711 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY) 1485 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY)
1731 1505
1732object * 1506object *
1733decrease_ob_nr (object *op, uint32 i) 1507decrease_ob_nr (object *op, uint32 i)
1734{ 1508{
1735 object *tmp; 1509 object *tmp;
1736 player *pl;
1737 1510
1738 if (i == 0) /* objects with op->nrof require this check */ 1511 if (i == 0) /* objects with op->nrof require this check */
1739 return op; 1512 return op;
1740 1513
1741 if (i > op->nrof) 1514 if (i > op->nrof)
1742 i = op->nrof; 1515 i = op->nrof;
1743 1516
1744 if (QUERY_FLAG (op, FLAG_REMOVED)) 1517 if (QUERY_FLAG (op, FLAG_REMOVED))
1745 op->nrof -= i; 1518 op->nrof -= i;
1746 else if (op->env != NULL) 1519 else if (op->env)
1747 { 1520 {
1748 /* is this object in the players inventory, or sub container 1521 /* is this object in the players inventory, or sub container
1749 * therein? 1522 * therein?
1750 */ 1523 */
1751 tmp = is_player_inv (op->env); 1524 tmp = op->in_player ();
1752 /* nope. Is this a container the player has opened? 1525 /* nope. Is this a container the player has opened?
1753 * If so, set tmp to that player. 1526 * If so, set tmp to that player.
1754 * IMO, searching through all the players will mostly 1527 * IMO, searching through all the players will mostly
1755 * likely be quicker than following op->env to the map, 1528 * likely be quicker than following op->env to the map,
1756 * and then searching the map for a player. 1529 * and then searching the map for a player.
1757 */ 1530 */
1758 if (!tmp) 1531 if (!tmp)
1759 { 1532 for_all_players (pl)
1760 for (pl = first_player; pl; pl = pl->next)
1761 if (pl->ob->container == op->env) 1533 if (pl->ob->container == op->env)
1534 {
1535 tmp = pl->ob;
1762 break; 1536 break;
1763 if (pl)
1764 tmp = pl->ob;
1765 else
1766 tmp = NULL;
1767 } 1537 }
1768 1538
1769 if (i < op->nrof) 1539 if (i < op->nrof)
1770 { 1540 {
1771 sub_weight (op->env, op->weight * i); 1541 sub_weight (op->env, op->weight * i);
1772 op->nrof -= i; 1542 op->nrof -= i;
1773 if (tmp) 1543 if (tmp)
1774 {
1775 esrv_send_item (tmp, op); 1544 esrv_send_item (tmp, op);
1776 }
1777 } 1545 }
1778 else 1546 else
1779 { 1547 {
1780 remove_ob (op); 1548 op->remove ();
1781 op->nrof = 0; 1549 op->nrof = 0;
1782 if (tmp) 1550 if (tmp)
1783 {
1784 esrv_del_item (tmp->contr, op->count); 1551 esrv_del_item (tmp->contr, op->count);
1785 }
1786 } 1552 }
1787 } 1553 }
1788 else 1554 else
1789 { 1555 {
1790 object *above = op->above; 1556 object *above = op->above;
1791 1557
1792 if (i < op->nrof) 1558 if (i < op->nrof)
1793 op->nrof -= i; 1559 op->nrof -= i;
1794 else 1560 else
1795 { 1561 {
1796 remove_ob (op); 1562 op->remove ();
1797 op->nrof = 0; 1563 op->nrof = 0;
1798 } 1564 }
1799 1565
1800 /* Since we just removed op, op->above is null */ 1566 /* Since we just removed op, op->above is null */
1801 for (tmp = above; tmp != NULL; tmp = tmp->above) 1567 for (tmp = above; tmp; tmp = tmp->above)
1802 if (tmp->type == PLAYER) 1568 if (tmp->type == PLAYER)
1803 { 1569 {
1804 if (op->nrof) 1570 if (op->nrof)
1805 esrv_send_item (tmp, op); 1571 esrv_send_item (tmp, op);
1806 else 1572 else
1810 1576
1811 if (op->nrof) 1577 if (op->nrof)
1812 return op; 1578 return op;
1813 else 1579 else
1814 { 1580 {
1815 free_object (op); 1581 op->destroy ();
1816 return NULL; 1582 return 0;
1817 } 1583 }
1818} 1584}
1819 1585
1820/* 1586/*
1821 * add_weight(object, weight) adds the specified weight to an object, 1587 * add_weight(object, weight) adds the specified weight to an object,
1833 op->carrying += weight; 1599 op->carrying += weight;
1834 op = op->env; 1600 op = op->env;
1835 } 1601 }
1836} 1602}
1837 1603
1604object *
1605insert_ob_in_ob (object *op, object *where)
1606{
1607 if (!where)
1608 {
1609 char *dump = dump_object (op);
1610 LOG (llevError, "Trying to put object in NULL.\n%s\n", dump);
1611 free (dump);
1612 return op;
1613 }
1614
1615 if (where->head)
1616 {
1617 LOG (llevDebug, "Warning: Tried to insert object into wrong part of multipart object.\n");
1618 where = where->head;
1619 }
1620
1621 return where->insert (op);
1622}
1623
1838/* 1624/*
1839 * insert_ob_in_ob(op,environment): 1625 * env->insert (op)
1840 * This function inserts the object op in the linked list 1626 * This function inserts the object op in the linked list
1841 * inside the object environment. 1627 * inside the object environment.
1842 * 1628 *
1843 * Eneq(@csd.uu.se): Altered insert_ob_in_ob to make things picked up enter
1844 * the inventory at the last position or next to other objects of the same
1845 * type.
1846 * Frank: Now sorted by type, archetype and magic!
1847 *
1848 * The function returns now pointer to inserted item, and return value can 1629 * The function returns now pointer to inserted item, and return value can
1849 * be != op, if items are merged. -Tero 1630 * be != op, if items are merged. -Tero
1850 */ 1631 */
1851 1632
1852object * 1633object *
1853insert_ob_in_ob (object *op, object *where) 1634object::insert (object *op)
1854{ 1635{
1855 object * 1636 object *tmp, *otmp;
1856 tmp, *
1857 otmp;
1858 1637
1859 if (!QUERY_FLAG (op, FLAG_REMOVED)) 1638 if (!QUERY_FLAG (op, FLAG_REMOVED))
1860 { 1639 op->remove ();
1861 dump_object (op);
1862 LOG (llevError, "Trying to insert (ob) inserted object.\n%s\n", errmsg);
1863 return op;
1864 }
1865
1866 if (where == NULL)
1867 {
1868 dump_object (op);
1869 LOG (llevError, "Trying to put object in NULL.\n%s\n", errmsg);
1870 return op;
1871 }
1872
1873 if (where->head)
1874 {
1875 LOG (llevDebug, "Warning: Tried to insert object wrong part of multipart object.\n");
1876 where = where->head;
1877 }
1878 1640
1879 if (op->more) 1641 if (op->more)
1880 { 1642 {
1881 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count); 1643 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);
1882 return op; 1644 return op;
1884 1646
1885 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL); 1647 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL);
1886 CLEAR_FLAG (op, FLAG_REMOVED); 1648 CLEAR_FLAG (op, FLAG_REMOVED);
1887 if (op->nrof) 1649 if (op->nrof)
1888 { 1650 {
1889 for (tmp = where->inv; tmp != NULL; tmp = tmp->below) 1651 for (tmp = inv; tmp != NULL; tmp = tmp->below)
1890 if (CAN_MERGE (tmp, op)) 1652 if (object::can_merge (tmp, op))
1891 { 1653 {
1892 /* return the original object and remove inserted object 1654 /* return the original object and remove inserted object
1893 (client needs the original object) */ 1655 (client needs the original object) */
1894 tmp->nrof += op->nrof; 1656 tmp->nrof += op->nrof;
1895 /* Weight handling gets pretty funky. Since we are adding to 1657 /* Weight handling gets pretty funky. Since we are adding to
1896 * tmp->nrof, we need to increase the weight. 1658 * tmp->nrof, we need to increase the weight.
1897 */ 1659 */
1898 add_weight (where, op->weight * op->nrof); 1660 add_weight (this, op->weight * op->nrof);
1899 SET_FLAG (op, FLAG_REMOVED); 1661 SET_FLAG (op, FLAG_REMOVED);
1900 free_object (op); /* free the inserted object */ 1662 op->destroy (); /* free the inserted object */
1901 op = tmp; 1663 op = tmp;
1902 remove_ob (op); /* and fix old object's links */ 1664 op->remove (); /* and fix old object's links */
1903 CLEAR_FLAG (op, FLAG_REMOVED); 1665 CLEAR_FLAG (op, FLAG_REMOVED);
1904 break; 1666 break;
1905 } 1667 }
1906 1668
1907 /* I assume combined objects have no inventory 1669 /* I assume combined objects have no inventory
1908 * We add the weight - this object could have just been removed 1670 * We add the weight - this object could have just been removed
1909 * (if it was possible to merge). calling remove_ob will subtract 1671 * (if it was possible to merge). calling remove_ob will subtract
1910 * the weight, so we need to add it in again, since we actually do 1672 * the weight, so we need to add it in again, since we actually do
1911 * the linking below 1673 * the linking below
1912 */ 1674 */
1913 add_weight (where, op->weight * op->nrof); 1675 add_weight (this, op->weight * op->nrof);
1914 } 1676 }
1915 else 1677 else
1916 add_weight (where, (op->weight + op->carrying)); 1678 add_weight (this, (op->weight + op->carrying));
1917 1679
1918 otmp = is_player_inv (where); 1680 otmp = this->in_player ();
1919 if (otmp && otmp->contr != NULL) 1681 if (otmp && otmp->contr)
1920 {
1921 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1682 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1922 fix_player (otmp); 1683 otmp->update_stats ();
1923 }
1924 1684
1925 op->map = NULL; 1685 op->map = 0;
1926 op->env = where; 1686 op->env = this;
1927 op->above = NULL; 1687 op->above = 0;
1928 op->below = NULL; 1688 op->below = 0;
1929 op->x = 0, op->y = 0; 1689 op->x = 0, op->y = 0;
1930 1690
1931 /* reset the light list and los of the players on the map */ 1691 /* reset the light list and los of the players on the map */
1932 if ((op->glow_radius != 0) && where->map) 1692 if ((op->glow_radius != 0) && map)
1933 { 1693 {
1934#ifdef DEBUG_LIGHTS 1694#ifdef DEBUG_LIGHTS
1935 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name); 1695 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1936#endif /* DEBUG_LIGHTS */ 1696#endif /* DEBUG_LIGHTS */
1937 if (MAP_DARKNESS (where->map)) 1697 if (MAP_DARKNESS (map))
1938 update_all_los (where->map, where->x, where->y); 1698 update_all_los (map, x, y);
1939 } 1699 }
1940 1700
1941 /* Client has no idea of ordering so lets not bother ordering it here. 1701 /* Client has no idea of ordering so lets not bother ordering it here.
1942 * It sure simplifies this function... 1702 * It sure simplifies this function...
1943 */ 1703 */
1944 if (where->inv == NULL) 1704 if (!inv)
1945 where->inv = op; 1705 inv = op;
1946 else 1706 else
1947 { 1707 {
1948 op->below = where->inv; 1708 op->below = inv;
1949 op->below->above = op; 1709 op->below->above = op;
1950 where->inv = op; 1710 inv = op;
1951 } 1711 }
1712
1952 return op; 1713 return op;
1953} 1714}
1954 1715
1955/* 1716/*
1956 * Checks if any objects has a move_type that matches objects 1717 * Checks if any objects has a move_type that matches objects
1974 */ 1735 */
1975 1736
1976int 1737int
1977check_move_on (object *op, object *originator) 1738check_move_on (object *op, object *originator)
1978{ 1739{
1979 object * 1740 object *tmp;
1980 tmp; 1741 maptile *m = op->map;
1981 tag_t
1982 tag;
1983 mapstruct *
1984 m = op->map;
1985 int
1986 x = op->x, y = op->y; 1742 int x = op->x, y = op->y;
1987 1743
1988 MoveType 1744 MoveType move_on, move_slow, move_block;
1989 move_on,
1990 move_slow,
1991 move_block;
1992 1745
1993 if (QUERY_FLAG (op, FLAG_NO_APPLY)) 1746 if (QUERY_FLAG (op, FLAG_NO_APPLY))
1994 return 0; 1747 return 0;
1995
1996 tag = op->count;
1997 1748
1998 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y); 1749 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
1999 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y); 1750 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
2000 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y); 1751 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
2001 1752
2062 if ((!op->move_type && tmp->move_on & MOVE_WALK) || 1813 if ((!op->move_type && tmp->move_on & MOVE_WALK) ||
2063 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0)) 1814 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0))
2064 { 1815 {
2065 move_apply (tmp, op, originator); 1816 move_apply (tmp, op, originator);
2066 1817
2067 if (was_destroyed (op, tag)) 1818 if (op->destroyed ())
2068 return 1; 1819 return 1;
2069 1820
2070 /* what the person/creature stepped onto has moved the object 1821 /* what the person/creature stepped onto has moved the object
2071 * someplace new. Don't process any further - if we did, 1822 * someplace new. Don't process any further - if we did,
2072 * have a feeling strange problems would result. 1823 * have a feeling strange problems would result.
2084 * a matching archetype at the given map and coordinates. 1835 * a matching archetype at the given map and coordinates.
2085 * The first matching object is returned, or NULL if none. 1836 * The first matching object is returned, or NULL if none.
2086 */ 1837 */
2087 1838
2088object * 1839object *
2089present_arch (const archetype *at, mapstruct *m, int x, int y) 1840present_arch (const archetype *at, maptile *m, int x, int y)
2090{ 1841{
2091 object * 1842 object *
2092 tmp; 1843 tmp;
2093 1844
2094 if (m == NULL || out_of_map (m, x, y)) 1845 if (m == NULL || out_of_map (m, x, y))
2107 * a matching type variable at the given map and coordinates. 1858 * a matching type variable at the given map and coordinates.
2108 * The first matching object is returned, or NULL if none. 1859 * The first matching object is returned, or NULL if none.
2109 */ 1860 */
2110 1861
2111object * 1862object *
2112present (unsigned char type, mapstruct *m, int x, int y) 1863present (unsigned char type, maptile *m, int x, int y)
2113{ 1864{
2114 object * 1865 object *
2115 tmp; 1866 tmp;
2116 1867
2117 if (out_of_map (m, x, y)) 1868 if (out_of_map (m, x, y))
2257 * the archetype because that isn't correct if the monster has been 2008 * the archetype because that isn't correct if the monster has been
2258 * customized, changed states, etc. 2009 * customized, changed states, etc.
2259 */ 2010 */
2260 2011
2261int 2012int
2262find_free_spot (const object *ob, mapstruct *m, int x, int y, int start, int stop) 2013find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)
2263{ 2014{
2264 int 2015 int
2265 i, 2016 i,
2266 index = 0, flag; 2017 index = 0, flag;
2267 static int 2018 static int
2279 * if the space being examined only has a wall to the north and empty 2030 * if the space being examined only has a wall to the north and empty
2280 * spaces in all the other directions, this will reduce the search space 2031 * spaces in all the other directions, this will reduce the search space
2281 * to only the spaces immediately surrounding the target area, and 2032 * to only the spaces immediately surrounding the target area, and
2282 * won't look 2 spaces south of the target space. 2033 * won't look 2 spaces south of the target space.
2283 */ 2034 */
2284 else if ((flag & AB_NO_PASS) && maxfree[i] < stop) 2035 else if ((flag & P_NO_PASS) && maxfree[i] < stop)
2285 stop = maxfree[i]; 2036 stop = maxfree[i];
2286 } 2037 }
2038
2287 if (!index) 2039 if (!index)
2288 return -1; 2040 return -1;
2041
2289 return altern[RANDOM () % index]; 2042 return altern[RANDOM () % index];
2290} 2043}
2291 2044
2292/* 2045/*
2293 * find_first_free_spot(archetype, mapstruct, x, y) works like 2046 * find_first_free_spot(archetype, maptile, x, y) works like
2294 * find_free_spot(), but it will search max number of squares. 2047 * find_free_spot(), but it will search max number of squares.
2295 * But it will return the first available spot, not a random choice. 2048 * But it will return the first available spot, not a random choice.
2296 * Changed 0.93.2: Have it return -1 if there is no free spot available. 2049 * Changed 0.93.2: Have it return -1 if there is no free spot available.
2297 */ 2050 */
2298 2051
2299int 2052int
2300find_first_free_spot (const object *ob, mapstruct *m, int x, int y) 2053find_first_free_spot (const object *ob, maptile *m, int x, int y)
2301{ 2054{
2302 int 2055 int
2303 i; 2056 i;
2304 2057
2305 for (i = 0; i < SIZEOFFREE; i++) 2058 for (i = 0; i < SIZEOFFREE; i++)
2369 * because we have to know what movement the thing looking to move 2122 * because we have to know what movement the thing looking to move
2370 * there is capable of. 2123 * there is capable of.
2371 */ 2124 */
2372 2125
2373int 2126int
2374find_dir (mapstruct *m, int x, int y, object *exclude) 2127find_dir (maptile *m, int x, int y, object *exclude)
2375{ 2128{
2376 int 2129 int
2377 i, 2130 i,
2378 max = SIZEOFFREE, mflags; 2131 max = SIZEOFFREE, mflags;
2379 2132
2380 sint16 nx, ny; 2133 sint16 nx, ny;
2381 object * 2134 object *
2382 tmp; 2135 tmp;
2383 mapstruct * 2136 maptile *
2384 mp; 2137 mp;
2385 2138
2386 MoveType blocked, move_type; 2139 MoveType blocked, move_type;
2387 2140
2388 if (exclude && exclude->head) 2141 if (exclude && exclude->head)
2401 mp = m; 2154 mp = m;
2402 nx = x + freearr_x[i]; 2155 nx = x + freearr_x[i];
2403 ny = y + freearr_y[i]; 2156 ny = y + freearr_y[i];
2404 2157
2405 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2158 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);
2159
2406 if (mflags & P_OUT_OF_MAP) 2160 if (mflags & P_OUT_OF_MAP)
2407 {
2408 max = maxfree[i]; 2161 max = maxfree[i];
2409 }
2410 else 2162 else
2411 { 2163 {
2412 blocked = GET_MAP_MOVE_BLOCK (mp, nx, ny); 2164 blocked = GET_MAP_MOVE_BLOCK (mp, nx, ny);
2413 2165
2414 if ((move_type & blocked) == move_type) 2166 if ((move_type & blocked) == move_type)
2415 {
2416 max = maxfree[i]; 2167 max = maxfree[i];
2417 }
2418 else if (mflags & P_IS_ALIVE) 2168 else if (mflags & P_IS_ALIVE)
2419 { 2169 {
2420 for (tmp = GET_MAP_OB (mp, nx, ny); tmp != NULL; tmp = tmp->above) 2170 for (tmp = GET_MAP_OB (mp, nx, ny); tmp; tmp = tmp->above)
2421 {
2422 if ((QUERY_FLAG (tmp, FLAG_MONSTER) || tmp->type == PLAYER) && (tmp != exclude || (tmp->head && tmp->head != exclude))) 2171 if ((QUERY_FLAG (tmp, FLAG_MONSTER) || tmp->type == PLAYER) && (tmp != exclude || (tmp->head && tmp->head != exclude)))
2423 {
2424 break; 2172 break;
2425 } 2173
2426 }
2427 if (tmp) 2174 if (tmp)
2428 {
2429 return freedir[i]; 2175 return freedir[i];
2430 }
2431 } 2176 }
2432 } 2177 }
2433 } 2178 }
2179
2434 return 0; 2180 return 0;
2435} 2181}
2436 2182
2437/* 2183/*
2438 * distance(object 1, object 2) will return the square of the 2184 * distance(object 1, object 2) will return the square of the
2440 */ 2186 */
2441 2187
2442int 2188int
2443distance (const object *ob1, const object *ob2) 2189distance (const object *ob1, const object *ob2)
2444{ 2190{
2445 int 2191 int i;
2446 i;
2447 2192
2448 i = (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y); 2193 i = (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2449 return i; 2194 return i;
2450} 2195}
2451 2196
2456 */ 2201 */
2457 2202
2458int 2203int
2459find_dir_2 (int x, int y) 2204find_dir_2 (int x, int y)
2460{ 2205{
2461 int 2206 int q;
2462 q;
2463 2207
2464 if (y) 2208 if (y)
2465 q = x * 100 / y; 2209 q = x * 100 / y;
2466 else if (x) 2210 else if (x)
2467 q = -300 * x; 2211 q = -300 * x;
2593 * find a path to that monster that we found. If not, 2337 * find a path to that monster that we found. If not,
2594 * we don't bother going toward it. Returns 1 if we 2338 * we don't bother going toward it. Returns 1 if we
2595 * can see a direct way to get it 2339 * can see a direct way to get it
2596 * Modified to be map tile aware -.MSW 2340 * Modified to be map tile aware -.MSW
2597 */ 2341 */
2598
2599
2600int 2342int
2601can_see_monsterP (mapstruct *m, int x, int y, int dir) 2343can_see_monsterP (maptile *m, int x, int y, int dir)
2602{ 2344{
2603 sint16 dx, dy; 2345 sint16 dx, dy;
2604 int
2605 mflags; 2346 int mflags;
2606 2347
2607 if (dir < 0) 2348 if (dir < 0)
2608 return 0; /* exit condition: invalid direction */ 2349 return 0; /* exit condition: invalid direction */
2609 2350
2610 dx = x + freearr_x[dir]; 2351 dx = x + freearr_x[dir];
2623 return 0; 2364 return 0;
2624 2365
2625 /* yes, can see. */ 2366 /* yes, can see. */
2626 if (dir < 9) 2367 if (dir < 9)
2627 return 1; 2368 return 1;
2369
2628 return can_see_monsterP (m, x, y, reduction_dir[dir][0]) | 2370 return can_see_monsterP (m, x, y, reduction_dir[dir][0])
2629 can_see_monsterP (m, x, y, reduction_dir[dir][1]) | can_see_monsterP (m, x, y, reduction_dir[dir][2]); 2371 | can_see_monsterP (m, x, y, reduction_dir[dir][1])
2372 | can_see_monsterP (m, x, y, reduction_dir[dir][2]);
2630} 2373}
2631
2632
2633 2374
2634/* 2375/*
2635 * can_pick(picker, item): finds out if an object is possible to be 2376 * can_pick(picker, item): finds out if an object is possible to be
2636 * picked up by the picker. Returnes 1 if it can be 2377 * picked up by the picker. Returnes 1 if it can be
2637 * picked up, otherwise 0. 2378 * picked up, otherwise 0.
2648 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2389 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2649 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2390 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2650 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2391 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));
2651} 2392}
2652 2393
2653
2654/* 2394/*
2655 * create clone from object to another 2395 * create clone from object to another
2656 */ 2396 */
2657object * 2397object *
2658object_create_clone (object *asrc) 2398object_create_clone (object *asrc)
2659{ 2399{
2660 object *
2661 dst = NULL, *tmp, *src, *part, *prev, *item; 2400 object *dst = 0, *tmp, *src, *part, *prev, *item;
2662 2401
2663 if (!asrc) 2402 if (!asrc)
2664 return NULL; 2403 return 0;
2404
2665 src = asrc; 2405 src = asrc;
2666 if (src->head) 2406 if (src->head)
2667 src = src->head; 2407 src = src->head;
2668 2408
2669 prev = NULL; 2409 prev = 0;
2670 for (part = src; part; part = part->more) 2410 for (part = src; part; part = part->more)
2671 { 2411 {
2672 tmp = get_object (); 2412 tmp = part->clone ();
2673 copy_object (part, tmp);
2674 tmp->x -= src->x; 2413 tmp->x -= src->x;
2675 tmp->y -= src->y; 2414 tmp->y -= src->y;
2415
2676 if (!part->head) 2416 if (!part->head)
2677 { 2417 {
2678 dst = tmp; 2418 dst = tmp;
2679 tmp->head = NULL; 2419 tmp->head = 0;
2680 } 2420 }
2681 else 2421 else
2682 {
2683 tmp->head = dst; 2422 tmp->head = dst;
2684 } 2423
2685 tmp->more = NULL; 2424 tmp->more = 0;
2425
2686 if (prev) 2426 if (prev)
2687 prev->more = tmp; 2427 prev->more = tmp;
2428
2688 prev = tmp; 2429 prev = tmp;
2689 } 2430 }
2690 2431
2691 /*** copy inventory ***/
2692 for (item = src->inv; item; item = item->below) 2432 for (item = src->inv; item; item = item->below)
2693 {
2694 (void) insert_ob_in_ob (object_create_clone (item), dst); 2433 insert_ob_in_ob (object_create_clone (item), dst);
2695 }
2696 2434
2697 return dst; 2435 return dst;
2698} 2436}
2699 2437
2700/* return true if the object was destroyed, 0 otherwise */
2701int
2702was_destroyed (const object *op, tag_t old_tag)
2703{
2704 /* checking for FLAG_FREED isn't necessary, but makes this function more
2705 * robust */
2706 return op->count != old_tag || QUERY_FLAG (op, FLAG_FREED);
2707}
2708
2709/* GROS - Creates an object using a string representing its content. */ 2438/* GROS - Creates an object using a string representing its content. */
2710
2711/* Basically, we save the content of the string to a temp file, then call */ 2439/* Basically, we save the content of the string to a temp file, then call */
2712
2713/* load_object on it. I admit it is a highly inefficient way to make things, */ 2440/* load_object on it. I admit it is a highly inefficient way to make things, */
2714
2715/* but it was simple to make and allows reusing the load_object function. */ 2441/* but it was simple to make and allows reusing the load_object function. */
2716
2717/* Remember not to use load_object_str in a time-critical situation. */ 2442/* Remember not to use load_object_str in a time-critical situation. */
2718
2719/* Also remember that multiparts objects are not supported for now. */ 2443/* Also remember that multiparts objects are not supported for now. */
2720 2444
2721object * 2445object *
2722load_object_str (const char *obstr) 2446load_object_str (const char *obstr)
2723{ 2447{
2724 object * 2448 object *op;
2725 op;
2726 char
2727 filename[MAX_BUF]; 2449 char filename[MAX_BUF];
2728 2450
2729 sprintf (filename, "%s/cfloadobstr2044", settings.tmpdir); 2451 sprintf (filename, "%s/cfloadobstr2044", settings.tmpdir);
2730 2452
2731 FILE *
2732 tempfile = fopen (filename, "w"); 2453 FILE *tempfile = fopen (filename, "w");
2733 2454
2734 if (tempfile == NULL) 2455 if (tempfile == NULL)
2735 { 2456 {
2736 LOG (llevError, "Error - Unable to access load object temp file\n"); 2457 LOG (llevError, "Error - Unable to access load object temp file\n");
2737 return NULL; 2458 return NULL;
2738 } 2459 }
2739 2460
2740 fprintf (tempfile, obstr); 2461 fprintf (tempfile, obstr);
2741 fclose (tempfile); 2462 fclose (tempfile);
2742 2463
2743 op = get_object (); 2464 op = object::create ();
2744 2465
2745 object_thawer thawer (filename); 2466 object_thawer thawer (filename);
2746 2467
2747 if (thawer) 2468 if (thawer)
2748 load_object (thawer, op, 0); 2469 load_object (thawer, op, 0);
2758 * returns NULL if no match. 2479 * returns NULL if no match.
2759 */ 2480 */
2760object * 2481object *
2761find_obj_by_type_subtype (const object *who, int type, int subtype) 2482find_obj_by_type_subtype (const object *who, int type, int subtype)
2762{ 2483{
2763 object * 2484 object *tmp;
2764 tmp;
2765 2485
2766 for (tmp = who->inv; tmp; tmp = tmp->below) 2486 for (tmp = who->inv; tmp; tmp = tmp->below)
2767 if (tmp->type == type && tmp->subtype == subtype) 2487 if (tmp->type == type && tmp->subtype == subtype)
2768 return tmp; 2488 return tmp;
2769 2489
2777 * do the desired thing. 2497 * do the desired thing.
2778 */ 2498 */
2779key_value * 2499key_value *
2780get_ob_key_link (const object *ob, const char *key) 2500get_ob_key_link (const object *ob, const char *key)
2781{ 2501{
2782 key_value * 2502 key_value *link;
2783 link;
2784 2503
2785 for (link = ob->key_values; link != NULL; link = link->next) 2504 for (link = ob->key_values; link != NULL; link = link->next)
2786 {
2787 if (link->key == key) 2505 if (link->key == key)
2788 {
2789 return link; 2506 return link;
2790 }
2791 }
2792 2507
2793 return NULL; 2508 return NULL;
2794} 2509}
2795 2510
2796/* 2511/*

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines