ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.54 by root, Fri Nov 17 19:40:53 2006 UTC vs.
Revision 1.133 by root, Fri Feb 16 19:43:40 2007 UTC

1/* 1/*
2 CrossFire, A Multiplayer game for X-windows 2 * CrossFire, A Multiplayer game for X-windows
3 3 *
4 * Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team
4 Copyright (C) 2001 Mark Wedel & Crossfire Development Team 5 * Copyright (C) 2001 Mark Wedel & Crossfire Development Team
5 Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (C) 1992 Frank Tore Johansen
6 7 *
7 This program is free software; you can redistribute it and/or modify 8 * This program is free software; you can redistribute it and/or modify
8 it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
9 the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation; either version 2 of the License, or
10 (at your option) any later version. 11 * (at your option) any later version.
11 12 *
12 This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
13 but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 GNU General Public License for more details. 16 * GNU General Public License for more details.
16 17 *
17 You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
18 along with this program; if not, write to the Free Software 19 * along with this program; if not, write to the Free Software
19 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
20 21 *
21 The authors can be reached via e-mail at <crossfire@schmorp.de> 22 * The authors can be reached via e-mail at <crossfire@schmorp.de>
22*/ 23 */
23 24
24/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects. 25/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
25 sub/add_weight will transcend the environment updating the carrying 26 sub/add_weight will transcend the environment updating the carrying
26 variable. */ 27 variable. */
27#include <global.h> 28#include <global.h>
… …
30#include <sys/uio.h> 31#include <sys/uio.h>
31#include <object.h> 32#include <object.h>
32#include <funcpoint.h> 33#include <funcpoint.h>
33#include <loader.h> 34#include <loader.h>
34 35
36#include <bitset>
37
35int nrofallocobjects = 0; 38int nrofallocobjects = 0;
36static UUID uuid; 39static UUID uuid;
37const uint64 UUID_SKIP = 1<<19; 40const uint64 UUID_SKIP = 1<<19;
38 41
39object *active_objects; /* List of active objects that need to be processed */ 42objectvec objects;
43activevec actives;
40 44
41short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 45short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
42 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1 46 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1
43}; 47};
44short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, 48short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
… …
104 _exit (1); 108 _exit (1);
105 } 109 }
106 110
107 uuid.seq = uid; 111 uuid.seq = uid;
108 write_uuid (); 112 write_uuid ();
109 LOG (llevDebug, "read UID: %lld\n", uid); 113 LOG (llevDebug, "read UID: %" PRId64 "\n", uid);
110 fclose (fp); 114 fclose (fp);
111} 115}
112 116
113UUID 117UUID
114gen_uuid () 118gen_uuid ()
… …
139 * objects with lists are rare, and lists stay short. If not, use a 143 * objects with lists are rare, and lists stay short. If not, use a
140 * different structure or at least keep the lists sorted... 144 * different structure or at least keep the lists sorted...
141 */ 145 */
142 146
143 /* For each field in wants, */ 147 /* For each field in wants, */
144 for (wants_field = wants->key_values; wants_field != NULL; wants_field = wants_field->next) 148 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)
145 { 149 {
146 key_value *has_field; 150 key_value *has_field;
147 151
148 /* Look for a field in has with the same key. */ 152 /* Look for a field in has with the same key. */
149 has_field = get_ob_key_link (has, wants_field->key); 153 has_field = get_ob_key_link (has, wants_field->key);
… …
183 * 187 *
184 * Note that this function appears a lot longer than the macro it 188 * Note that this function appears a lot longer than the macro it
185 * replaces - this is mostly for clarity - a decent compiler should hopefully 189 * replaces - this is mostly for clarity - a decent compiler should hopefully
186 * reduce this to the same efficiency. 190 * reduce this to the same efficiency.
187 * 191 *
188 * Check nrof variable *before* calling CAN_MERGE() 192 * Check nrof variable *before* calling can_merge()
189 * 193 *
190 * Improvements made with merge: Better checking on potion, and also 194 * Improvements made with merge: Better checking on potion, and also
191 * check weight 195 * check weight
192 */ 196 */
193
194bool object::can_merge (object *ob1, object *ob2) 197bool object::can_merge_slow (object *ob1, object *ob2)
195{ 198{
196 /* A couple quicksanity checks */ 199 /* A couple quicksanity checks */
197 if ((ob1 == ob2) || (ob1->type != ob2->type)) 200 if (ob1 == ob2
201 || ob1->type != ob2->type
202 || ob1->speed != ob2->speed
203 || ob1->value != ob2->value
204 || ob1->name != ob2->name)
198 return 0; 205 return 0;
199 206
200 if (ob1->speed != ob2->speed) 207 //TODO: this ain't working well, use nicer and correct overflow check
201 return 0;
202
203 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that 208 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that
204 * value could not be stored in a sint32 (which unfortunately sometimes is 209 * value could not be stored in a sint32 (which unfortunately sometimes is
205 * used to store nrof). 210 * used to store nrof).
206 */ 211 */
207 if (ob1->nrof + ob2->nrof >= 1UL << 31) 212 if (ob1->nrof + ob2->nrof >= 1UL << 31)
… …
217 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 222 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
218 223
219 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 224 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
220 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 225 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
221 226
222 227 if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any ()
223 /* the 0x400000 on flags2 is FLAG_INV_LOCK. I don't think something 228 || ob1->arch != ob2->arch
224 * being locked in inventory should prevent merging.
225 * 0x4 in flags3 is CLIENT_SENT
226 */
227 if ((ob1->arch != ob2->arch) ||
228 (ob1->flags[0] != ob2->flags[0]) ||
229 (ob1->flags[1] != ob2->flags[1]) ||
230 ((ob1->flags[2] & ~0x400000) != (ob2->flags[2] & ~0x400000)) ||
231 ((ob1->flags[3] & ~0x4) != (ob2->flags[3] & ~0x4)) ||
232 (ob1->name != ob2->name) || 229 || ob1->name != ob2->name
233 (ob1->title != ob2->title) || 230 || ob1->title != ob2->title
234 (ob1->msg != ob2->msg) || 231 || ob1->msg != ob2->msg
235 (ob1->weight != ob2->weight) || 232 || ob1->weight != ob2->weight
236 (memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist)) != 0) || 233 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
237 (memcmp (&ob1->stats, &ob2->stats, sizeof (ob1->stats)) != 0) || 234 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
238 (ob1->attacktype != ob2->attacktype) || 235 || ob1->attacktype != ob2->attacktype
239 (ob1->magic != ob2->magic) || 236 || ob1->magic != ob2->magic
240 (ob1->slaying != ob2->slaying) || 237 || ob1->slaying != ob2->slaying
241 (ob1->skill != ob2->skill) || 238 || ob1->skill != ob2->skill
242 (ob1->value != ob2->value) || 239 || ob1->value != ob2->value
243 (ob1->animation_id != ob2->animation_id) || 240 || ob1->animation_id != ob2->animation_id
244 (ob1->client_type != ob2->client_type) || 241 || ob1->client_type != ob2->client_type
245 (ob1->materialname != ob2->materialname) || 242 || ob1->materialname != ob2->materialname
246 (ob1->lore != ob2->lore) || 243 || ob1->lore != ob2->lore
247 (ob1->subtype != ob2->subtype) || 244 || ob1->subtype != ob2->subtype
248 (ob1->move_type != ob2->move_type) || 245 || ob1->move_type != ob2->move_type
249 (ob1->move_block != ob2->move_block) || 246 || ob1->move_block != ob2->move_block
250 (ob1->move_allow != ob2->move_allow) || 247 || ob1->move_allow != ob2->move_allow
251 (ob1->move_on != ob2->move_on) || 248 || ob1->move_on != ob2->move_on
252 (ob1->move_off != ob2->move_off) || (ob1->move_slow != ob2->move_slow) || (ob1->move_slow_penalty != ob2->move_slow_penalty)) 249 || ob1->move_off != ob2->move_off
250 || ob1->move_slow != ob2->move_slow
251 || ob1->move_slow_penalty != ob2->move_slow_penalty)
253 return 0; 252 return 0;
254 253
255 /* This is really a spellbook check - really, we should 254 /* This is really a spellbook check - really, we should
256 * check all objects in the inventory. 255 * check all objects in the inventory.
257 */ 256 */
… …
260 /* if one object has inventory but the other doesn't, not equiv */ 259 /* if one object has inventory but the other doesn't, not equiv */
261 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv)) 260 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv))
262 return 0; 261 return 0;
263 262
264 /* Now check to see if the two inventory objects could merge */ 263 /* Now check to see if the two inventory objects could merge */
265 if (!CAN_MERGE (ob1->inv, ob2->inv)) 264 if (!object::can_merge (ob1->inv, ob2->inv))
266 return 0; 265 return 0;
267 266
268 /* inventory ok - still need to check rest of this object to see 267 /* inventory ok - still need to check rest of this object to see
269 * if it is valid. 268 * if it is valid.
270 */ 269 */
… …
279 278
280 /* Note sure why the following is the case - either the object has to 279 /* Note sure why the following is the case - either the object has to
281 * be animated or have a very low speed. Is this an attempted monster 280 * be animated or have a very low speed. Is this an attempted monster
282 * check? 281 * check?
283 */ 282 */
284 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && FABS ((ob1)->speed) > MIN_ACTIVE_SPEED) 283 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && ob1->has_active_speed ())
285 return 0; 284 return 0;
286 285
287 switch (ob1->type) 286 switch (ob1->type)
288 { 287 {
289 case SCROLL: 288 case SCROLL:
… …
354 op = op->env; 353 op = op->env;
355 return op; 354 return op;
356} 355}
357 356
358/* 357/*
359 * Eneq(@csd.uu.se): Since we can have items buried in a character we need
360 * a better check. We basically keeping traversing up until we can't
361 * or find a player.
362 */
363
364object *
365is_player_inv (object *op)
366{
367 for (; op != NULL && op->type != PLAYER; op = op->env)
368 if (op->env == op)
369 op->env = NULL;
370 return op;
371}
372
373/*
374 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump. 358 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
375 * Some error messages. 359 * Some error messages.
376 * The result of the dump is stored in the static global errmsg array. 360 * The result of the dump is stored in the static global errmsg array.
377 */ 361 */
378
379char * 362char *
380dump_object (object *op) 363dump_object (object *op)
381{ 364{
382 if (!op) 365 if (!op)
383 return strdup ("[NULLOBJ]"); 366 return strdup ("[NULLOBJ]");
384 367
385 object_freezer freezer; 368 object_freezer freezer;
386 save_object (freezer, op, 3); 369 op->write (freezer);
387 return freezer.as_string (); 370 return freezer.as_string ();
388} 371}
389 372
390/* 373/*
391 * get_nearest_part(multi-object, object 2) returns the part of the 374 * get_nearest_part(multi-object, object 2) returns the part of the
… …
408} 391}
409 392
410/* 393/*
411 * Returns the object which has the count-variable equal to the argument. 394 * Returns the object which has the count-variable equal to the argument.
412 */ 395 */
413
414object * 396object *
415find_object (tag_t i) 397find_object (tag_t i)
416{ 398{
417 for (object *op = object::first; op; op = op->next) 399 for_all_objects (op)
418 if (op->count == i) 400 if (op->count == i)
419 return op; 401 return op;
420 402
421 return 0; 403 return 0;
422} 404}
423 405
424/* 406/*
425 * Returns the first object which has a name equal to the argument. 407 * Returns the first object which has a name equal to the argument.
426 * Used only by the patch command, but not all that useful. 408 * Used only by the patch command, but not all that useful.
427 * Enables features like "patch <name-of-other-player> food 999" 409 * Enables features like "patch <name-of-other-player> food 999"
428 */ 410 */
429
430object * 411object *
431find_object_name (const char *str) 412find_object_name (const char *str)
432{ 413{
433 shstr_cmp str_ (str); 414 shstr_cmp str_ (str);
434 object *op; 415 object *op;
435 416
436 for (op = object::first; op != NULL; op = op->next) 417 for_all_objects (op)
437 if (op->name == str_) 418 if (op->name == str_)
438 break; 419 break;
439 420
440 return op; 421 return op;
441} 422}
… …
484 } 465 }
485 466
486 op->key_values = 0; 467 op->key_values = 0;
487} 468}
488 469
489void object::clear ()
490{
491 attachable_base::clear ();
492
493 free_key_values (this);
494
495 owner = 0;
496 name = 0;
497 name_pl = 0;
498 title = 0;
499 race = 0;
500 slaying = 0;
501 skill = 0;
502 msg = 0;
503 lore = 0;
504 custom_name = 0;
505 materialname = 0;
506 contr = 0;
507 below = 0;
508 above = 0;
509 inv = 0;
510 container = 0;
511 env = 0;
512 more = 0;
513 head = 0;
514 map = 0;
515 active_next = 0;
516 active_prev = 0;
517
518 memset (static_cast<object_pod *>(this), 0, sizeof (object_pod));
519
520 SET_FLAG (this, FLAG_REMOVED);
521
522 /* What is not cleared is next, prev, and count */
523
524 expmul = 1.0;
525 face = blank_face;
526
527 if (settings.casting_time)
528 casting_time = -1;
529}
530
531void object::clone (object *destination)
532{
533 *(object_copy *)destination = *this;
534 *(object_pod *)destination = *this;
535
536 if (self || cb)
537 INVOKE_OBJECT (CLONE, this, ARG_OBJECT (destination));
538}
539
540/* 470/*
541 * copy object first frees everything allocated by the second object, 471 * copy_to first frees everything allocated by the dst object,
542 * and then copies the contends of the first object into the second 472 * and then copies the contents of itself into the second
543 * object, allocating what needs to be allocated. Basically, any 473 * object, allocating what needs to be allocated. Basically, any
544 * data that is malloc'd needs to be re-malloc/copied. Otherwise, 474 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
545 * if the first object is freed, the pointers in the new object 475 * if the first object is freed, the pointers in the new object
546 * will point at garbage. 476 * will point at garbage.
547 */ 477 */
548void 478void
549copy_object (object *op2, object *op) 479object::copy_to (object *dst)
550{ 480{
551 bool is_freed = QUERY_FLAG (op, FLAG_FREED); 481 bool is_freed = QUERY_FLAG (dst, FLAG_FREED);
552 bool is_removed = QUERY_FLAG (op, FLAG_REMOVED); 482 bool is_removed = QUERY_FLAG (dst, FLAG_REMOVED);
553 483
554 op2->clone (op); 484 *(object_copy *)dst = *this;
555 485
556 if (is_freed) 486 if (is_freed)
557 SET_FLAG (op, FLAG_FREED); 487 SET_FLAG (dst, FLAG_FREED);
488
558 if (is_removed) 489 if (is_removed)
559 SET_FLAG (op, FLAG_REMOVED); 490 SET_FLAG (dst, FLAG_REMOVED);
560 491
561 if (op2->speed < 0) 492 if (speed < 0)
562 op->speed_left = op2->speed_left - RANDOM () % 200 / 100.0; 493 dst->speed_left = speed_left - rndm ();
563 494
564 /* Copy over key_values, if any. */ 495 /* Copy over key_values, if any. */
565 if (op2->key_values) 496 if (key_values)
566 { 497 {
567 key_value *tail = 0; 498 key_value *tail = 0;
568 key_value *i; 499 key_value *i;
569 500
570 op->key_values = 0; 501 dst->key_values = 0;
571 502
572 for (i = op2->key_values; i; i = i->next) 503 for (i = key_values; i; i = i->next)
573 { 504 {
574 key_value *new_link = new key_value; 505 key_value *new_link = new key_value;
575 506
576 new_link->next = 0; 507 new_link->next = 0;
577 new_link->key = i->key; 508 new_link->key = i->key;
578 new_link->value = i->value; 509 new_link->value = i->value;
579 510
580 /* Try and be clever here, too. */ 511 /* Try and be clever here, too. */
581 if (!op->key_values) 512 if (!dst->key_values)
582 { 513 {
583 op->key_values = new_link; 514 dst->key_values = new_link;
584 tail = new_link; 515 tail = new_link;
585 } 516 }
586 else 517 else
587 { 518 {
588 tail->next = new_link; 519 tail->next = new_link;
589 tail = new_link; 520 tail = new_link;
590 } 521 }
591 } 522 }
592 } 523 }
593 524
594 update_ob_speed (op); 525 dst->set_speed (dst->speed);
526}
527
528void
529object::instantiate ()
530{
531 if (!uuid.seq) // HACK
532 uuid = gen_uuid ();
533
534 speed_left = -0.1f;
535 /* copy the body_info to the body_used - this is only really
536 * need for monsters, but doesn't hurt to do it for everything.
537 * by doing so, when a monster is created, it has good starting
538 * values for the body_used info, so when items are created
539 * for it, they can be properly equipped.
540 */
541 memcpy (body_used, body_info, sizeof (body_used));
542
543 attachable::instantiate ();
544}
545
546object *
547object::clone ()
548{
549 object *neu = create ();
550 copy_to (neu);
551 return neu;
595} 552}
596 553
597/* 554/*
598 * If an object with the IS_TURNABLE() flag needs to be turned due 555 * If an object with the IS_TURNABLE() flag needs to be turned due
599 * to the closest player being on the other side, this function can 556 * to the closest player being on the other side, this function can
600 * be called to update the face variable, _and_ how it looks on the map. 557 * be called to update the face variable, _and_ how it looks on the map.
601 */ 558 */
602
603void 559void
604update_turn_face (object *op) 560update_turn_face (object *op)
605{ 561{
606 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || op->arch == NULL) 562 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || !op->arch)
607 return; 563 return;
564
608 SET_ANIMATION (op, op->direction); 565 SET_ANIMATION (op, op->direction);
609 update_object (op, UP_OBJ_FACE); 566 update_object (op, UP_OBJ_FACE);
610} 567}
611 568
612/* 569/*
613 * Updates the speed of an object. If the speed changes from 0 to another 570 * Updates the speed of an object. If the speed changes from 0 to another
614 * value, or vice versa, then add/remove the object from the active list. 571 * value, or vice versa, then add/remove the object from the active list.
615 * This function needs to be called whenever the speed of an object changes. 572 * This function needs to be called whenever the speed of an object changes.
616 */ 573 */
617void 574void
618update_ob_speed (object *op) 575object::set_speed (float speed)
619{ 576{
620 extern int arch_init; 577 if (flag [FLAG_FREED] && speed)
621
622 /* No reason putting the archetypes objects on the speed list,
623 * since they never really need to be updated.
624 */
625
626 if (QUERY_FLAG (op, FLAG_FREED) && op->speed)
627 { 578 {
628 LOG (llevError, "Object %s is freed but has speed.\n", &op->name); 579 LOG (llevError, "Object %s is freed but has speed.\n", &name);
629#ifdef MANY_CORES
630 abort ();
631#else
632 op->speed = 0; 580 speed = 0;
633#endif
634 }
635
636 if (arch_init)
637 return;
638
639 if (FABS (op->speed) > MIN_ACTIVE_SPEED)
640 { 581 }
641 /* If already on active list, don't do anything */
642 if (op->active_next || op->active_prev || op == active_objects)
643 return;
644 582
645 /* process_events() expects us to insert the object at the beginning 583 this->speed = speed;
646 * of the list. */
647 op->active_next = active_objects;
648 584
649 if (op->active_next != NULL) 585 if (has_active_speed ())
650 op->active_next->active_prev = op; 586 activate ();
651
652 active_objects = op;
653 }
654 else 587 else
655 { 588 deactivate ();
656 /* If not on the active list, nothing needs to be done */
657 if (!op->active_next && !op->active_prev && op != active_objects)
658 return;
659
660 if (op->active_prev == NULL)
661 {
662 active_objects = op->active_next;
663
664 if (op->active_next != NULL)
665 op->active_next->active_prev = NULL;
666 }
667 else
668 {
669 op->active_prev->active_next = op->active_next;
670
671 if (op->active_next)
672 op->active_next->active_prev = op->active_prev;
673 }
674
675 op->active_next = NULL;
676 op->active_prev = NULL;
677 }
678} 589}
679 590
680/* This function removes object 'op' from the list of active
681 * objects.
682 * This should only be used for style maps or other such
683 * reference maps where you don't want an object that isn't
684 * in play chewing up cpu time getting processed.
685 * The reverse of this is to call update_ob_speed, which
686 * will do the right thing based on the speed of the object.
687 */
688void
689remove_from_active_list (object *op)
690{
691 /* If not on the active list, nothing needs to be done */
692 if (!op->active_next && !op->active_prev && op != active_objects)
693 return;
694
695 if (op->active_prev == NULL)
696 {
697 active_objects = op->active_next;
698 if (op->active_next != NULL)
699 op->active_next->active_prev = NULL;
700 }
701 else
702 {
703 op->active_prev->active_next = op->active_next;
704 if (op->active_next)
705 op->active_next->active_prev = op->active_prev;
706 }
707 op->active_next = NULL;
708 op->active_prev = NULL;
709}
710
711/* 591/*
712 * update_object() updates the array which represents the map. 592 * update_object() updates the the map.
713 * It takes into account invisible objects (and represent squares covered 593 * It takes into account invisible objects (and represent squares covered
714 * by invisible objects by whatever is below them (unless it's another 594 * by invisible objects by whatever is below them (unless it's another
715 * invisible object, etc...) 595 * invisible object, etc...)
716 * If the object being updated is beneath a player, the look-window 596 * If the object being updated is beneath a player, the look-window
717 * of that player is updated (this might be a suboptimal way of 597 * of that player is updated (this might be a suboptimal way of
718 * updating that window, though, since update_object() is called _often_) 598 * updating that window, though, since update_object() is called _often_)
719 * 599 *
720 * action is a hint of what the caller believes need to be done. 600 * action is a hint of what the caller believes need to be done.
721 * For example, if the only thing that has changed is the face (due to
722 * an animation), we don't need to call update_position until that actually
723 * comes into view of a player. OTOH, many other things, like addition/removal
724 * of walls or living creatures may need us to update the flags now.
725 * current action are: 601 * current action are:
726 * UP_OBJ_INSERT: op was inserted 602 * UP_OBJ_INSERT: op was inserted
727 * UP_OBJ_REMOVE: op was removed 603 * UP_OBJ_REMOVE: op was removed
728 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update 604 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update
729 * as that is easier than trying to look at what may have changed. 605 * as that is easier than trying to look at what may have changed.
730 * UP_OBJ_FACE: only the objects face has changed. 606 * UP_OBJ_FACE: only the objects face has changed.
731 */ 607 */
732
733void 608void
734update_object (object *op, int action) 609update_object (object *op, int action)
735{ 610{
736 int update_now = 0, flags;
737 MoveType move_on, move_off, move_block, move_slow; 611 MoveType move_on, move_off, move_block, move_slow;
738 612
739 if (op == NULL) 613 if (op == NULL)
740 { 614 {
741 /* this should never happen */ 615 /* this should never happen */
742 LOG (llevDebug, "update_object() called for NULL object.\n"); 616 LOG (llevDebug, "update_object() called for NULL object.\n");
743 return; 617 return;
744 } 618 }
745 619
746 if (op->env != NULL) 620 if (op->env)
747 { 621 {
748 /* Animation is currently handled by client, so nothing 622 /* Animation is currently handled by client, so nothing
749 * to do in this case. 623 * to do in this case.
750 */ 624 */
751 return; 625 return;
… …
756 */ 630 */
757 if (!op->map || op->map->in_memory == MAP_SAVING) 631 if (!op->map || op->map->in_memory == MAP_SAVING)
758 return; 632 return;
759 633
760 /* make sure the object is within map boundaries */ 634 /* make sure the object is within map boundaries */
761 if (op->x < 0 || op->x >= MAP_WIDTH (op->map) || op->y < 0 || op->y >= MAP_HEIGHT (op->map)) 635 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
762 { 636 {
763 LOG (llevError, "update_object() called for object out of map!\n"); 637 LOG (llevError, "update_object() called for object out of map!\n");
764#ifdef MANY_CORES 638#ifdef MANY_CORES
765 abort (); 639 abort ();
766#endif 640#endif
767 return; 641 return;
768 } 642 }
769 643
770 flags = GET_MAP_FLAGS (op->map, op->x, op->y); 644 mapspace &m = op->ms ();
771 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NEED_UPDATE);
772 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
773 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
774 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
775 move_off = GET_MAP_MOVE_OFF (op->map, op->x, op->y);
776 645
646 if (!(m.flags_ & P_UPTODATE))
647 /* nop */;
777 if (action == UP_OBJ_INSERT) 648 else if (action == UP_OBJ_INSERT)
778 { 649 {
650 // this is likely overkill, TODO: revisit (schmorp)
779 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(flags & P_BLOCKSVIEW)) 651 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
780 update_now = 1;
781
782 if (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(flags & P_NO_MAGIC)) 652 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
783 update_now = 1; 653 || (op->type == PLAYER && !(m.flags_ & P_PLAYER))
784 654 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
655 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
785 if (QUERY_FLAG (op, FLAG_DAMNED) && !(flags & P_NO_CLERIC)) 656 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
786 update_now = 1;
787
788 if (QUERY_FLAG (op, FLAG_ALIVE) && !(flags & P_IS_ALIVE))
789 update_now = 1;
790
791 if (op->type == SAFE_GROUND && !(flags & P_SAFE))
792 update_now = 1;
793
794 if ((move_on | op->move_on) != move_on) 657 || (m.move_on | op->move_on ) != m.move_on
795 update_now = 1;
796
797 if ((move_off | op->move_off) != move_off) 658 || (m.move_off | op->move_off ) != m.move_off
798 update_now = 1; 659 || (m.move_slow | op->move_slow) != m.move_slow
799
800 /* This isn't perfect, but I don't expect a lot of objects to 660 /* This isn't perfect, but I don't expect a lot of objects to
801 * to have move_allow right now. 661 * to have move_allow right now.
802 */ 662 */
803 if (((move_block | op->move_block) & ~op->move_allow) != move_block) 663 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
804 update_now = 1; 664 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
805 665 m.flags_ = 0;
806 if ((move_slow | op->move_slow) != move_slow)
807 update_now = 1;
808 } 666 }
809 /* if the object is being removed, we can't make intelligent 667 /* if the object is being removed, we can't make intelligent
810 * decisions, because remove_ob can't really pass the object 668 * decisions, because remove_ob can't really pass the object
811 * that is being removed. 669 * that is being removed.
812 */ 670 */
813 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 671 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
814 update_now = 1; 672 m.flags_ = 0;
815 else if (action == UP_OBJ_FACE) 673 else if (action == UP_OBJ_FACE)
816 /* Nothing to do for that case */ ; 674 /* Nothing to do for that case */ ;
817 else 675 else
818 LOG (llevError, "update_object called with invalid action: %d\n", action); 676 LOG (llevError, "update_object called with invalid action: %d\n", action);
819 677
820 if (update_now)
821 {
822 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NO_ERROR | P_NEED_UPDATE);
823 update_position (op->map, op->x, op->y);
824 }
825
826 if (op->more != NULL) 678 if (op->more)
827 update_object (op->more, action); 679 update_object (op->more, action);
828}
829
830object::vector object::mortals;
831object::vector object::objects; // not yet used
832object *object::first;
833
834void object::free_mortals ()
835{
836 for (AUTODECL (i, mortals.begin ()); i != mortals.end ();)
837 if ((*i)->refcnt)
838 ++i; // further delay freeing
839 else
840 {
841 delete *i;
842 mortals.erase (i);
843 }
844
845 static int lastmortals = 0;//D
846
847 if (mortals.size() != lastmortals && lastmortals > 100)//D
848 {
849 lastmortals = mortals.size ();//D
850 LOG (llevDebug, "%d objects in mortal queue\n", lastmortals);//D
851 }
852} 680}
853 681
854object::object () 682object::object ()
855{ 683{
856 SET_FLAG (this, FLAG_REMOVED); 684 SET_FLAG (this, FLAG_REMOVED);
… …
859 face = blank_face; 687 face = blank_face;
860} 688}
861 689
862object::~object () 690object::~object ()
863{ 691{
692 unlink ();
693
864 free_key_values (this); 694 free_key_values (this);
865} 695}
866 696
697static int object_count;
698
867void object::link () 699void object::link ()
868{ 700{
869 count = ++ob_count; 701 assert (!index);//D
870 uuid = gen_uuid (); 702 uuid = gen_uuid ();
703 count = ++object_count;
871 704
872 prev = 0; 705 refcnt_inc ();
873 next = object::first; 706 objects.insert (this);
874
875 if (object::first)
876 object::first->prev = this;
877
878 object::first = this;
879} 707}
880 708
881void object::unlink () 709void object::unlink ()
882{ 710{
883 if (this == object::first) 711 if (!index)
884 object::first = next; 712 return;
885 713
886 /* Remove this object from the list of used objects */ 714 objects.erase (this);
887 if (prev) prev->next = next; 715 refcnt_dec ();
888 if (next) next->prev = prev; 716}
889 717
890 prev = 0; 718void
891 next = 0; 719object::activate ()
720{
721 /* If already on active list, don't do anything */
722 if (active)
723 return;
724
725 if (has_active_speed ())
726 actives.insert (this);
727}
728
729void
730object::activate_recursive ()
731{
732 activate ();
733
734 for (object *op = inv; op; op = op->below)
735 op->activate_recursive ();
736}
737
738/* This function removes object 'op' from the list of active
739 * objects.
740 * This should only be used for style maps or other such
741 * reference maps where you don't want an object that isn't
742 * in play chewing up cpu time getting processed.
743 * The reverse of this is to call update_ob_speed, which
744 * will do the right thing based on the speed of the object.
745 */
746void
747object::deactivate ()
748{
749 /* If not on the active list, nothing needs to be done */
750 if (!active)
751 return;
752
753 actives.erase (this);
754}
755
756void
757object::deactivate_recursive ()
758{
759 for (object *op = inv; op; op = op->below)
760 op->deactivate_recursive ();
761
762 deactivate ();
763}
764
765void
766object::set_flag_inv (int flag, int value)
767{
768 for (object *op = inv; op; op = op->below)
769 {
770 op->flag [flag] = value;
771 op->set_flag_inv (flag, value);
772 }
773}
774
775/*
776 * Remove and free all objects in the inventory of the given object.
777 * object.c ?
778 */
779void
780object::destroy_inv (bool drop_to_ground)
781{
782 // need to check first, because the checks below might segfault
783 // as we might be on an invalid mapspace and crossfire code
784 // is too buggy to ensure that the inventory is empty.
785 // corollary: if you create arrows etc. with stuff in tis inventory,
786 // cf will crash below with off-map x and y
787 if (!inv)
788 return;
789
790 /* Only if the space blocks everything do we not process -
791 * if some form of movement is allowed, let objects
792 * drop on that space.
793 */
794 if (!drop_to_ground
795 || !map
796 || map->in_memory != MAP_IN_MEMORY
797 || map->nodrop
798 || ms ().move_block == MOVE_ALL)
799 {
800 while (inv)
801 {
802 inv->destroy_inv (drop_to_ground);
803 inv->destroy ();
804 }
805 }
806 else
807 { /* Put objects in inventory onto this space */
808 while (inv)
809 {
810 object *op = inv;
811
812 if (op->flag [FLAG_STARTEQUIP]
813 || op->flag [FLAG_NO_DROP]
814 || op->type == RUNE
815 || op->type == TRAP
816 || op->flag [FLAG_IS_A_TEMPLATE]
817 || op->flag [FLAG_DESTROY_ON_DEATH])
818 op->destroy ();
819 else
820 map->insert (op, x, y);
821 }
822 }
892} 823}
893 824
894object *object::create () 825object *object::create ()
895{ 826{
896 object *op = new object; 827 object *op = new object;
897 op->link (); 828 op->link ();
898 return op; 829 return op;
899} 830}
900 831
901/* 832void
902 * free_object() frees everything allocated by an object, removes 833object::do_destroy ()
903 * it from the list of used objects, and puts it on the list of
904 * free objects. The IS_FREED() flag is set in the object.
905 * The object must have been removed by remove_ob() first for
906 * this function to succeed.
907 *
908 * If destroy_inventory is set, free inventory as well. Else drop items in
909 * inventory to the ground.
910 */
911void object::destroy (bool destroy_inventory)
912{ 834{
913 if (QUERY_FLAG (this, FLAG_FREED)) 835 attachable::do_destroy ();
914 return;
915 836
916 if (QUERY_FLAG (this, FLAG_FRIENDLY)) 837 if (flag [FLAG_IS_LINKED])
838 remove_button_link (this);
839
840 if (flag [FLAG_FRIENDLY])
841 {
917 remove_friendly_object (this); 842 remove_friendly_object (this);
918 843
919 if (!QUERY_FLAG (this, FLAG_REMOVED)) 844 if (type == GOLEM
845 && owner
846 && owner->type == PLAYER
847 && owner->contr->ranges[range_golem] == this)
848 owner->contr->ranges[range_golem] = 0;
849 }
850
851 if (!flag [FLAG_REMOVED])
920 remove_ob (this); 852 remove ();
921 853
922 SET_FLAG (this, FLAG_FREED); 854 destroy_inv (true);
855
856 deactivate ();
857 unlink ();
858
859 flag [FLAG_FREED] = 1;
860
861 // hack to ensure that freed objects still have a valid map
862 {
863 static maptile *freed_map; // freed objects are moved here to avoid crashes
864
865 if (!freed_map)
866 {
867 freed_map = new maptile;
868
869 freed_map->name = "/internal/freed_objects_map";
870 freed_map->width = 3;
871 freed_map->height = 3;
872
873 freed_map->alloc ();
874 freed_map->in_memory = MAP_IN_MEMORY;
875 }
876
877 map = freed_map;
878 x = 1;
879 y = 1;
880 }
881
882 head = 0;
923 883
924 if (more) 884 if (more)
925 { 885 {
926 more->destroy (destroy_inventory); 886 more->destroy ();
927 more = 0; 887 more = 0;
928 }
929
930 if (inv)
931 {
932 /* Only if the space blocks everything do we not process -
933 * if some form of movement is allowed, let objects
934 * drop on that space.
935 */
936 if (destroy_inventory || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL)
937 {
938 object *op = inv;
939
940 while (op)
941 {
942 object *tmp = op->below;
943 op->destroy (destroy_inventory);
944 op = tmp;
945 }
946 }
947 else
948 { /* Put objects in inventory onto this space */
949 object *op = inv;
950
951 while (op)
952 {
953 object *tmp = op->below;
954
955 remove_ob (op);
956
957 if (QUERY_FLAG (op, FLAG_STARTEQUIP)
958 || QUERY_FLAG (op, FLAG_NO_DROP) || op->type == RUNE || op->type == TRAP || QUERY_FLAG (op, FLAG_IS_A_TEMPLATE))
959 free_object (op);
960 else
961 {
962 op->x = x;
963 op->y = y;
964 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
965 }
966
967 op = tmp;
968 }
969 }
970 } 888 }
971 889
972 // clear those pointers that likely might have circular references to us 890 // clear those pointers that likely might have circular references to us
973 owner = 0; 891 owner = 0;
974 enemy = 0; 892 enemy = 0;
975 attacked_by = 0; 893 attacked_by = 0;
894}
976 895
977 // only relevant for players(?), but make sure of it anyways 896void
978 contr = 0; 897object::destroy (bool destroy_inventory)
898{
899 if (destroyed ())
900 return;
979 901
980 /* Remove object from the active list */ 902 if (destroy_inventory)
981 speed = 0; 903 destroy_inv (false);
982 update_ob_speed (this);
983 904
984 unlink (); 905 attachable::destroy ();
985
986 mortals.push_back (this);
987} 906}
988 907
989/* 908/*
990 * sub_weight() recursively (outwards) subtracts a number from the 909 * sub_weight() recursively (outwards) subtracts a number from the
991 * weight of an object (and what is carried by it's environment(s)). 910 * weight of an object (and what is carried by it's environment(s)).
992 */ 911 */
993
994void 912void
995sub_weight (object *op, signed long weight) 913sub_weight (object *op, signed long weight)
996{ 914{
997 while (op != NULL) 915 while (op != NULL)
998 { 916 {
… …
1002 op->carrying -= weight; 920 op->carrying -= weight;
1003 op = op->env; 921 op = op->env;
1004 } 922 }
1005} 923}
1006 924
1007/* remove_ob(op): 925/* op->remove ():
1008 * This function removes the object op from the linked list of objects 926 * This function removes the object op from the linked list of objects
1009 * which it is currently tied to. When this function is done, the 927 * which it is currently tied to. When this function is done, the
1010 * object will have no environment. If the object previously had an 928 * object will have no environment. If the object previously had an
1011 * environment, the x and y coordinates will be updated to 929 * environment, the x and y coordinates will be updated to
1012 * the previous environment. 930 * the previous environment.
1013 * Beware: This function is called from the editor as well!
1014 */ 931 */
1015
1016void 932void
1017remove_ob (object *op) 933object::do_remove ()
1018{ 934{
1019 object *tmp, *last = 0; 935 object *tmp, *last = 0;
1020 object *otmp; 936 object *otmp;
1021 937
1022 int check_walk_off;
1023 maptile *m;
1024
1025 sint16 x, y;
1026
1027 if (QUERY_FLAG (op, FLAG_REMOVED)) 938 if (QUERY_FLAG (this, FLAG_REMOVED))
1028 return; 939 return;
1029 940
1030 SET_FLAG (op, FLAG_REMOVED); 941 SET_FLAG (this, FLAG_REMOVED);
942 INVOKE_OBJECT (REMOVE, this);
1031 943
1032 if (op->more != NULL) 944 if (more)
1033 remove_ob (op->more); 945 more->remove ();
1034 946
1035 /* 947 /*
1036 * In this case, the object to be removed is in someones 948 * In this case, the object to be removed is in someones
1037 * inventory. 949 * inventory.
1038 */ 950 */
1039 if (op->env != NULL) 951 if (env)
1040 { 952 {
1041 if (op->nrof) 953 if (nrof)
1042 sub_weight (op->env, op->weight * op->nrof); 954 sub_weight (env, weight * nrof);
1043 else 955 else
1044 sub_weight (op->env, op->weight + op->carrying); 956 sub_weight (env, weight + carrying);
1045 957
1046 /* NO_FIX_PLAYER is set when a great many changes are being 958 /* NO_FIX_PLAYER is set when a great many changes are being
1047 * made to players inventory. If set, avoiding the call 959 * made to players inventory. If set, avoiding the call
1048 * to save cpu time. 960 * to save cpu time.
1049 */ 961 */
1050 if ((otmp = is_player_inv (op->env)) != NULL && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 962 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1051 fix_player (otmp); 963 otmp->update_stats ();
1052 964
1053 if (op->above != NULL) 965 if (above)
1054 op->above->below = op->below; 966 above->below = below;
1055 else 967 else
1056 op->env->inv = op->below; 968 env->inv = below;
1057 969
1058 if (op->below != NULL) 970 if (below)
1059 op->below->above = op->above; 971 below->above = above;
1060 972
1061 /* we set up values so that it could be inserted into 973 /* we set up values so that it could be inserted into
1062 * the map, but we don't actually do that - it is up 974 * the map, but we don't actually do that - it is up
1063 * to the caller to decide what we want to do. 975 * to the caller to decide what we want to do.
1064 */ 976 */
1065 op->x = op->env->x, op->y = op->env->y; 977 x = env->x, y = env->y;
1066 op->map = op->env->map; 978 map = env->map;
1067 op->above = NULL, op->below = NULL; 979 above = 0, below = 0;
1068 op->env = NULL; 980 env = 0;
1069 } 981 }
1070 else if (op->map) 982 else if (map)
1071 { 983 {
1072 x = op->x; 984 if (type == PLAYER)
1073 y = op->y;
1074 m = get_map_from_coord (op->map, &x, &y);
1075
1076 if (!m)
1077 {
1078 LOG (llevError, "remove_ob called when object was on map but appears to not be within valid coordinates? %s (%d,%d)\n",
1079 op->map->path, op->x, op->y);
1080 /* in old days, we used to set x and y to 0 and continue.
1081 * it seems if we get into this case, something is probablye
1082 * screwed up and should be fixed.
1083 */
1084 abort ();
1085 } 985 {
986 // leaving a spot always closes any open container on the ground
987 if (container && !container->env)
988 // this causes spurious floorbox updates, but it ensures
989 // that the CLOSE event is being sent.
990 close_container ();
1086 991
1087 if (op->map != m) 992 --map->players;
1088 LOG (llevDebug, "remove_ob: Object not really on map it claimed to be on? %s != %s, %d,%d != %d,%d\n", 993 map->touch ();
1089 op->map->path, m->path, op->x, op->y, x, y);
1090
1091 /* Re did the following section of code - it looks like it had
1092 * lots of logic for things we no longer care about
1093 */ 994 }
995
996 map->dirty = true;
997 mapspace &ms = this->ms ();
1094 998
1095 /* link the object above us */ 999 /* link the object above us */
1096 if (op->above) 1000 if (above)
1097 op->above->below = op->below; 1001 above->below = below;
1098 else 1002 else
1099 SET_MAP_TOP (m, x, y, op->below); /* we were top, set new top */ 1003 ms.top = below; /* we were top, set new top */
1100 1004
1101 /* Relink the object below us, if there is one */ 1005 /* Relink the object below us, if there is one */
1102 if (op->below) 1006 if (below)
1103 op->below->above = op->above; 1007 below->above = above;
1104 else 1008 else
1105 { 1009 {
1106 /* Nothing below, which means we need to relink map object for this space 1010 /* Nothing below, which means we need to relink map object for this space
1107 * use translated coordinates in case some oddness with map tiling is 1011 * use translated coordinates in case some oddness with map tiling is
1108 * evident 1012 * evident
1109 */ 1013 */
1110 if (GET_MAP_OB (m, x, y) != op) 1014 if (GET_MAP_OB (map, x, y) != this)
1111 {
1112 char *dump = dump_object (op);
1113 LOG (llevError,
1114 "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", dump); 1015 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1115 free (dump); 1016
1116 dump = dump_object (GET_MAP_OB (m, x, y)); 1017 ms.bot = above; /* goes on above it. */
1117 LOG (llevError, "%s\n", dump);
1118 free (dump);
1119 } 1018 }
1120 1019
1121 SET_MAP_OB (m, x, y, op->above); /* goes on above it. */
1122 }
1123
1124 op->above = 0; 1020 above = 0;
1125 op->below = 0; 1021 below = 0;
1126 1022
1127 if (op->map->in_memory == MAP_SAVING) 1023 if (map->in_memory == MAP_SAVING)
1128 return; 1024 return;
1129 1025
1130 check_walk_off = !QUERY_FLAG (op, FLAG_NO_APPLY); 1026 int check_walk_off = !flag [FLAG_NO_APPLY];
1131 1027
1132 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1028 for (tmp = ms.bot; tmp; tmp = tmp->above)
1133 { 1029 {
1134 /* No point updating the players look faces if he is the object 1030 /* No point updating the players look faces if he is the object
1135 * being removed. 1031 * being removed.
1136 */ 1032 */
1137 1033
1138 if (tmp->type == PLAYER && tmp != op) 1034 if (tmp->type == PLAYER && tmp != this)
1139 { 1035 {
1140 /* If a container that the player is currently using somehow gets 1036 /* If a container that the player is currently using somehow gets
1141 * removed (most likely destroyed), update the player view 1037 * removed (most likely destroyed), update the player view
1142 * appropriately. 1038 * appropriately.
1143 */ 1039 */
1144 if (tmp->container == op) 1040 if (tmp->container == this)
1145 { 1041 {
1146 CLEAR_FLAG (op, FLAG_APPLIED); 1042 flag [FLAG_APPLIED] = 0;
1147 tmp->container = NULL; 1043 tmp->container = 0;
1148 } 1044 }
1149 1045
1150 tmp->contr->socket.update_look = 1; 1046 if (tmp->contr->ns)
1047 tmp->contr->ns->floorbox_update ();
1151 } 1048 }
1152 1049
1153 /* See if player moving off should effect something */ 1050 /* See if object moving off should effect something */
1154 if (check_walk_off 1051 if (check_walk_off
1155 && ((op->move_type & tmp->move_off) 1052 && ((move_type & tmp->move_off)
1156 && (op->move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1053 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0))
1157 { 1054 {
1158 move_apply (tmp, op, NULL); 1055 move_apply (tmp, this, 0);
1159 1056
1160 if (op->destroyed ()) 1057 if (destroyed ())
1161 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ()); 1058 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1162 } 1059 }
1163 1060
1164 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */ 1061 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */
1165 1062 //TODO: why is this horrible hacka fix? get rid of this code=bug! (schmorp)
1166 if (tmp->above == tmp) 1063 if (tmp->above == tmp)
1167 tmp->above = NULL; 1064 tmp->above = 0;
1168 1065
1169 last = tmp; 1066 last = tmp;
1170 } 1067 }
1171 1068
1172 /* last == NULL of there are no objects on this space */ 1069 /* last == NULL if there are no objects on this space */
1070 //TODO: this makes little sense, why only update the topmost object?
1173 if (last == NULL) 1071 if (!last)
1174 { 1072 map->at (x, y).flags_ = 0;
1175 /* set P_NEED_UPDATE, otherwise update_position will complain. In theory,
1176 * we could preserve the flags (GET_MAP_FLAGS), but update_position figures
1177 * those out anyways, and if there are any flags set right now, they won't
1178 * be correct anyways.
1179 */
1180 SET_MAP_FLAGS (op->map, op->x, op->y, P_NEED_UPDATE);
1181 update_position (op->map, op->x, op->y);
1182 }
1183 else 1073 else
1184 update_object (last, UP_OBJ_REMOVE); 1074 update_object (last, UP_OBJ_REMOVE);
1185 1075
1186 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) || (op->glow_radius != 0)) 1076 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1187 update_all_los (op->map, op->x, op->y); 1077 update_all_los (map, x, y);
1188 } 1078 }
1189} 1079}
1190 1080
1191/* 1081/*
1192 * merge_ob(op,top): 1082 * merge_ob(op,top):
… …
1200merge_ob (object *op, object *top) 1090merge_ob (object *op, object *top)
1201{ 1091{
1202 if (!op->nrof) 1092 if (!op->nrof)
1203 return 0; 1093 return 0;
1204 1094
1205 if (top == NULL) 1095 if (top)
1206 for (top = op; top != NULL && top->above != NULL; top = top->above); 1096 for (top = op; top && top->above; top = top->above)
1097 ;
1207 1098
1208 for (; top != NULL; top = top->below) 1099 for (; top; top = top->below)
1209 { 1100 {
1210 if (top == op) 1101 if (top == op)
1211 continue; 1102 continue;
1212 if (CAN_MERGE (op, top)) 1103
1104 if (object::can_merge (op, top))
1213 { 1105 {
1214 top->nrof += op->nrof; 1106 top->nrof += op->nrof;
1215 1107
1216/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/ 1108/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/
1217 op->weight = 0; /* Don't want any adjustements now */ 1109 op->weight = 0; /* Don't want any adjustements now */
1218 remove_ob (op); 1110 op->destroy ();
1219 free_object (op);
1220 return top; 1111 return top;
1221 } 1112 }
1222 } 1113 }
1223 1114
1224 return 0; 1115 return 0;
1225} 1116}
1226 1117
1227/* 1118/*
1228 * same as insert_ob_in_map except it handle separate coordinates and do a clean 1119 * same as insert_ob_in_map except it handles separate coordinates and does a clean
1229 * job preparing multi-part monsters 1120 * job preparing multi-part monsters.
1230 */ 1121 */
1231object * 1122object *
1232insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1123insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1233{ 1124{
1234 object *tmp;
1235
1236 if (op->head)
1237 op = op->head;
1238
1239 for (tmp = op; tmp; tmp = tmp->more) 1125 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1240 { 1126 {
1241 tmp->x = x + tmp->arch->clone.x; 1127 tmp->x = x + tmp->arch->clone.x;
1242 tmp->y = y + tmp->arch->clone.y; 1128 tmp->y = y + tmp->arch->clone.y;
1243 } 1129 }
1244 1130
… …
1263 * Return value: 1149 * Return value:
1264 * new object if 'op' was merged with other object 1150 * new object if 'op' was merged with other object
1265 * NULL if 'op' was destroyed 1151 * NULL if 'op' was destroyed
1266 * just 'op' otherwise 1152 * just 'op' otherwise
1267 */ 1153 */
1268
1269object * 1154object *
1270insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1155insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1271{ 1156{
1272 object *tmp, *top, *floor = NULL; 1157 object *tmp, *top, *floor = NULL;
1273 sint16 x, y;
1274 1158
1275 if (QUERY_FLAG (op, FLAG_FREED)) 1159 if (QUERY_FLAG (op, FLAG_FREED))
1276 { 1160 {
1277 LOG (llevError, "Trying to insert freed object!\n"); 1161 LOG (llevError, "Trying to insert freed object!\n");
1278 return NULL; 1162 return NULL;
1279 } 1163 }
1280 1164
1281 if (m == NULL) 1165 if (!QUERY_FLAG (op, FLAG_REMOVED))
1166 LOG (llevError, "Trying to insert already inserted object %s\n", op->debug_desc ());
1167
1168 op->remove ();
1169
1170 if (!m)
1282 { 1171 {
1283 char *dump = dump_object (op); 1172 char *dump = dump_object (op);
1284 LOG (llevError, "Trying to insert in null-map!\n%s\n", dump); 1173 LOG (llevError, "Trying to insert in null-map!\n%s\n", dump);
1285 free (dump); 1174 free (dump);
1286 return op; 1175 return op;
… …
1299#endif 1188#endif
1300 free (dump); 1189 free (dump);
1301 return op; 1190 return op;
1302 } 1191 }
1303 1192
1304 if (!QUERY_FLAG (op, FLAG_REMOVED))
1305 {
1306 char *dump = dump_object (op);
1307 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", dump);
1308 free (dump);
1309 return op;
1310 }
1311
1312 if (op->more != NULL)
1313 {
1314 /* The part may be on a different map. */
1315
1316 object *more = op->more; 1193 if (object *more = op->more)
1317 1194 {
1318 /* We really need the caller to normalize coordinates - if
1319 * we set the map, that doesn't work if the location is within
1320 * a map and this is straddling an edge. So only if coordinate
1321 * is clear wrong do we normalize it.
1322 */
1323 if (OUT_OF_REAL_MAP (more->map, more->x, more->y))
1324 more->map = get_map_from_coord (m, &more->x, &more->y);
1325 else if (!more->map)
1326 {
1327 /* For backwards compatibility - when not dealing with tiled maps,
1328 * more->map should always point to the parent.
1329 */
1330 more->map = m;
1331 }
1332
1333 if (insert_ob_in_map (more, more->map, originator, flag) == NULL) 1195 if (!insert_ob_in_map (more, m, originator, flag))
1334 { 1196 {
1335 if (!op->head) 1197 if (!op->head)
1336 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n"); 1198 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n");
1337 1199
1338 return NULL; 1200 return 0;
1339 } 1201 }
1340 } 1202 }
1341 1203
1342 CLEAR_FLAG (op, FLAG_REMOVED); 1204 CLEAR_FLAG (op, FLAG_REMOVED);
1343 1205
1344 /* Ideally, the caller figures this out. However, it complicates a lot 1206 /* Ideally, the caller figures this out. However, it complicates a lot
1345 * of areas of callers (eg, anything that uses find_free_spot would now 1207 * of areas of callers (eg, anything that uses find_free_spot would now
1346 * need extra work 1208 * need extra work
1347 */ 1209 */
1348 op->map = get_map_from_coord (m, &op->x, &op->y); 1210 if (!xy_normalise (m, op->x, op->y))
1349 x = op->x; 1211 return 0;
1350 y = op->y; 1212
1213 op->map = m;
1214 mapspace &ms = op->ms ();
1351 1215
1352 /* this has to be done after we translate the coordinates. 1216 /* this has to be done after we translate the coordinates.
1353 */ 1217 */
1354 if (op->nrof && !(flag & INS_NO_MERGE)) 1218 if (op->nrof && !(flag & INS_NO_MERGE))
1355 for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above) 1219 for (tmp = ms.bot; tmp; tmp = tmp->above)
1356 if (CAN_MERGE (op, tmp)) 1220 if (object::can_merge (op, tmp))
1357 { 1221 {
1358 op->nrof += tmp->nrof; 1222 op->nrof += tmp->nrof;
1359 remove_ob (tmp); 1223 tmp->destroy ();
1360 free_object (tmp);
1361 } 1224 }
1362 1225
1363 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1226 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1364 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1227 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1365 1228
… …
1378 op->below = originator->below; 1241 op->below = originator->below;
1379 1242
1380 if (op->below) 1243 if (op->below)
1381 op->below->above = op; 1244 op->below->above = op;
1382 else 1245 else
1383 SET_MAP_OB (op->map, op->x, op->y, op); 1246 ms.bot = op;
1384 1247
1385 /* since *below* originator, no need to update top */ 1248 /* since *below* originator, no need to update top */
1386 originator->below = op; 1249 originator->below = op;
1387 } 1250 }
1388 else 1251 else
1389 { 1252 {
1253 top = ms.bot;
1254
1390 /* If there are other objects, then */ 1255 /* If there are other objects, then */
1391 if ((!(flag & INS_MAP_LOAD)) && ((top = GET_MAP_OB (op->map, op->x, op->y)) != NULL)) 1256 if ((!(flag & INS_MAP_LOAD)) && top)
1392 { 1257 {
1393 object *last = NULL; 1258 object *last = 0;
1394 1259
1395 /* 1260 /*
1396 * If there are multiple objects on this space, we do some trickier handling. 1261 * If there are multiple objects on this space, we do some trickier handling.
1397 * We've already dealt with merging if appropriate. 1262 * We've already dealt with merging if appropriate.
1398 * Generally, we want to put the new object on top. But if 1263 * Generally, we want to put the new object on top. But if
… …
1402 * once we get to them. This reduces the need to traverse over all of 1267 * once we get to them. This reduces the need to traverse over all of
1403 * them when adding another one - this saves quite a bit of cpu time 1268 * them when adding another one - this saves quite a bit of cpu time
1404 * when lots of spells are cast in one area. Currently, it is presumed 1269 * when lots of spells are cast in one area. Currently, it is presumed
1405 * that flying non pickable objects are spell objects. 1270 * that flying non pickable objects are spell objects.
1406 */ 1271 */
1407 1272 for (top = ms.bot; top; top = top->above)
1408 while (top != NULL)
1409 { 1273 {
1410 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1274 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))
1411 floor = top; 1275 floor = top;
1412 1276
1413 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1277 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))
… …
1416 top = top->below; 1280 top = top->below;
1417 break; 1281 break;
1418 } 1282 }
1419 1283
1420 last = top; 1284 last = top;
1421 top = top->above;
1422 } 1285 }
1423 1286
1424 /* Don't want top to be NULL, so set it to the last valid object */ 1287 /* Don't want top to be NULL, so set it to the last valid object */
1425 top = last; 1288 top = last;
1426 1289
… …
1433 * Unless those objects are exits, type 66 1296 * Unless those objects are exits, type 66
1434 * If INS_ON_TOP is used, don't do this processing 1297 * If INS_ON_TOP is used, don't do this processing
1435 * Need to find the object that in fact blocks view, otherwise 1298 * Need to find the object that in fact blocks view, otherwise
1436 * stacking is a bit odd. 1299 * stacking is a bit odd.
1437 */ 1300 */
1438 if (!(flag & INS_ON_TOP) && 1301 if (!(flag & INS_ON_TOP)
1439 (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_BLOCKSVIEW) && (op->face && !op->face->visibility)) 1302 && ms.flags () & P_BLOCKSVIEW
1303 && (op->face && !op->face->visibility))
1440 { 1304 {
1441 for (last = top; last != floor; last = last->below) 1305 for (last = top; last != floor; last = last->below)
1442 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1306 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1443 break; 1307 break;
1308
1444 /* Check to see if we found the object that blocks view, 1309 /* Check to see if we found the object that blocks view,
1445 * and make sure we have a below pointer for it so that 1310 * and make sure we have a below pointer for it so that
1446 * we can get inserted below this one, which requires we 1311 * we can get inserted below this one, which requires we
1447 * set top to the object below us. 1312 * set top to the object below us.
1448 */ 1313 */
… …
1450 top = last->below; 1315 top = last->below;
1451 } 1316 }
1452 } /* If objects on this space */ 1317 } /* If objects on this space */
1453 1318
1454 if (flag & INS_MAP_LOAD) 1319 if (flag & INS_MAP_LOAD)
1455 top = GET_MAP_TOP (op->map, op->x, op->y); 1320 top = ms.top;
1456 1321
1457 if (flag & INS_ABOVE_FLOOR_ONLY) 1322 if (flag & INS_ABOVE_FLOOR_ONLY)
1458 top = floor; 1323 top = floor;
1459 1324
1460 /* Top is the object that our object (op) is going to get inserted above. 1325 /* Top is the object that our object (op) is going to get inserted above.
1461 */ 1326 */
1462 1327
1463 /* First object on this space */ 1328 /* First object on this space */
1464 if (!top) 1329 if (!top)
1465 { 1330 {
1466 op->above = GET_MAP_OB (op->map, op->x, op->y); 1331 op->above = ms.bot;
1467 1332
1468 if (op->above) 1333 if (op->above)
1469 op->above->below = op; 1334 op->above->below = op;
1470 1335
1471 op->below = NULL; 1336 op->below = 0;
1472 SET_MAP_OB (op->map, op->x, op->y, op); 1337 ms.bot = op;
1473 } 1338 }
1474 else 1339 else
1475 { /* get inserted into the stack above top */ 1340 { /* get inserted into the stack above top */
1476 op->above = top->above; 1341 op->above = top->above;
1477 1342
… …
1480 1345
1481 op->below = top; 1346 op->below = top;
1482 top->above = op; 1347 top->above = op;
1483 } 1348 }
1484 1349
1485 if (op->above == NULL) 1350 if (!op->above)
1486 SET_MAP_TOP (op->map, op->x, op->y, op); 1351 ms.top = op;
1487 } /* else not INS_BELOW_ORIGINATOR */ 1352 } /* else not INS_BELOW_ORIGINATOR */
1488 1353
1489 if (op->type == PLAYER) 1354 if (op->type == PLAYER)
1355 {
1490 op->contr->do_los = 1; 1356 op->contr->do_los = 1;
1357 ++op->map->players;
1358 op->map->touch ();
1359 }
1360
1361 op->map->dirty = true;
1491 1362
1492 /* If we have a floor, we know the player, if any, will be above 1363 /* If we have a floor, we know the player, if any, will be above
1493 * it, so save a few ticks and start from there. 1364 * it, so save a few ticks and start from there.
1494 */ 1365 */
1495 if (!(flag & INS_MAP_LOAD)) 1366 if (!(flag & INS_MAP_LOAD))
1496 for (tmp = floor ? floor : GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1367 if (object *pl = ms.player ())
1497 if (tmp->type == PLAYER) 1368 if (pl->contr->ns)
1498 tmp->contr->socket.update_look = 1; 1369 pl->contr->ns->floorbox_update ();
1499 1370
1500 /* If this object glows, it may affect lighting conditions that are 1371 /* If this object glows, it may affect lighting conditions that are
1501 * visible to others on this map. But update_all_los is really 1372 * visible to others on this map. But update_all_los is really
1502 * an inefficient way to do this, as it means los for all players 1373 * an inefficient way to do this, as it means los for all players
1503 * on the map will get recalculated. The players could very well 1374 * on the map will get recalculated. The players could very well
1504 * be far away from this change and not affected in any way - 1375 * be far away from this change and not affected in any way -
1505 * this should get redone to only look for players within range, 1376 * this should get redone to only look for players within range,
1506 * or just updating the P_NEED_UPDATE for spaces within this area 1377 * or just updating the P_UPTODATE for spaces within this area
1507 * of effect may be sufficient. 1378 * of effect may be sufficient.
1508 */ 1379 */
1509 if (MAP_DARKNESS (op->map) && (op->glow_radius != 0)) 1380 if (op->map->darkness && (op->glow_radius != 0))
1510 update_all_los (op->map, op->x, op->y); 1381 update_all_los (op->map, op->x, op->y);
1511 1382
1512 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1383 /* updates flags (blocked, alive, no magic, etc) for this map space */
1513 update_object (op, UP_OBJ_INSERT); 1384 update_object (op, UP_OBJ_INSERT);
1514 1385
1386 INVOKE_OBJECT (INSERT, op);
1387
1515 /* Don't know if moving this to the end will break anything. However, 1388 /* Don't know if moving this to the end will break anything. However,
1516 * we want to have update_look set above before calling this. 1389 * we want to have floorbox_update called before calling this.
1517 * 1390 *
1518 * check_move_on() must be after this because code called from 1391 * check_move_on() must be after this because code called from
1519 * check_move_on() depends on correct map flags (so functions like 1392 * check_move_on() depends on correct map flags (so functions like
1520 * blocked() and wall() work properly), and these flags are updated by 1393 * blocked() and wall() work properly), and these flags are updated by
1521 * update_object(). 1394 * update_object().
… …
1523 1396
1524 /* if this is not the head or flag has been passed, don't check walk on status */ 1397 /* if this is not the head or flag has been passed, don't check walk on status */
1525 if (!(flag & INS_NO_WALK_ON) && !op->head) 1398 if (!(flag & INS_NO_WALK_ON) && !op->head)
1526 { 1399 {
1527 if (check_move_on (op, originator)) 1400 if (check_move_on (op, originator))
1528 return NULL; 1401 return 0;
1529 1402
1530 /* If we are a multi part object, lets work our way through the check 1403 /* If we are a multi part object, lets work our way through the check
1531 * walk on's. 1404 * walk on's.
1532 */ 1405 */
1533 for (tmp = op->more; tmp != NULL; tmp = tmp->more) 1406 for (tmp = op->more; tmp != NULL; tmp = tmp->more)
1534 if (check_move_on (tmp, originator)) 1407 if (check_move_on (tmp, originator))
1535 return NULL; 1408 return 0;
1536 } 1409 }
1537 1410
1538 return op; 1411 return op;
1539} 1412}
1540 1413
1541/* this function inserts an object in the map, but if it 1414/* this function inserts an object in the map, but if it
1542 * finds an object of its own type, it'll remove that one first. 1415 * finds an object of its own type, it'll remove that one first.
1543 * op is the object to insert it under: supplies x and the map. 1416 * op is the object to insert it under: supplies x and the map.
1544 */ 1417 */
1545void 1418void
1546replace_insert_ob_in_map (const char *arch_string, object *op) 1419replace_insert_ob_in_map (const char *arch_string, object *op)
1547{ 1420{
1548 object * 1421 object *tmp, *tmp1;
1549 tmp;
1550 object *
1551 tmp1;
1552 1422
1553 /* first search for itself and remove any old instances */ 1423 /* first search for itself and remove any old instances */
1554 1424
1555 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1425 for (tmp = op->ms ().bot; tmp; tmp = tmp->above)
1556 {
1557 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */ 1426 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */
1558 { 1427 tmp->destroy ();
1559 remove_ob (tmp);
1560 free_object (tmp);
1561 }
1562 }
1563 1428
1564 tmp1 = arch_to_object (archetype::find (arch_string)); 1429 tmp1 = arch_to_object (archetype::find (arch_string));
1565 1430
1566 tmp1->x = op->x; 1431 tmp1->x = op->x;
1567 tmp1->y = op->y; 1432 tmp1->y = op->y;
1568 insert_ob_in_map (tmp1, op->map, op, 0); 1433 insert_ob_in_map (tmp1, op->map, op, 0);
1434}
1435
1436object *
1437object::insert_at (object *where, object *originator, int flags)
1438{
1439 where->map->insert (this, where->x, where->y, originator, flags);
1569} 1440}
1570 1441
1571/* 1442/*
1572 * get_split_ob(ob,nr) splits up ob into two parts. The part which 1443 * get_split_ob(ob,nr) splits up ob into two parts. The part which
1573 * is returned contains nr objects, and the remaining parts contains 1444 * is returned contains nr objects, and the remaining parts contains
1574 * the rest (or is removed and freed if that number is 0). 1445 * the rest (or is removed and freed if that number is 0).
1575 * On failure, NULL is returned, and the reason put into the 1446 * On failure, NULL is returned, and the reason put into the
1576 * global static errmsg array. 1447 * global static errmsg array.
1577 */ 1448 */
1578
1579object * 1449object *
1580get_split_ob (object *orig_ob, uint32 nr) 1450get_split_ob (object *orig_ob, uint32 nr)
1581{ 1451{
1582 object * 1452 object *newob;
1583 newob;
1584 int
1585 is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0); 1453 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1586 1454
1587 if (orig_ob->nrof < nr) 1455 if (orig_ob->nrof < nr)
1588 { 1456 {
1589 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name); 1457 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1590 return NULL; 1458 return NULL;
1591 } 1459 }
1592 1460
1593 newob = object_create_clone (orig_ob); 1461 newob = object_create_clone (orig_ob);
1594 1462
1595 if ((orig_ob->nrof -= nr) < 1) 1463 if ((orig_ob->nrof -= nr) < 1)
1596 { 1464 orig_ob->destroy (1);
1597 if (!is_removed)
1598 remove_ob (orig_ob);
1599 free_object2 (orig_ob, 1);
1600 }
1601 else if (!is_removed) 1465 else if (!is_removed)
1602 { 1466 {
1603 if (orig_ob->env != NULL) 1467 if (orig_ob->env != NULL)
1604 sub_weight (orig_ob->env, orig_ob->weight * nr); 1468 sub_weight (orig_ob->env, orig_ob->weight * nr);
1605 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY) 1469 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY)
… …
1625 1489
1626object * 1490object *
1627decrease_ob_nr (object *op, uint32 i) 1491decrease_ob_nr (object *op, uint32 i)
1628{ 1492{
1629 object *tmp; 1493 object *tmp;
1630 player *pl;
1631 1494
1632 if (i == 0) /* objects with op->nrof require this check */ 1495 if (i == 0) /* objects with op->nrof require this check */
1633 return op; 1496 return op;
1634 1497
1635 if (i > op->nrof) 1498 if (i > op->nrof)
1636 i = op->nrof; 1499 i = op->nrof;
1637 1500
1638 if (QUERY_FLAG (op, FLAG_REMOVED)) 1501 if (QUERY_FLAG (op, FLAG_REMOVED))
1639 op->nrof -= i; 1502 op->nrof -= i;
1640 else if (op->env != NULL) 1503 else if (op->env)
1641 { 1504 {
1642 /* is this object in the players inventory, or sub container 1505 /* is this object in the players inventory, or sub container
1643 * therein? 1506 * therein?
1644 */ 1507 */
1645 tmp = is_player_inv (op->env); 1508 tmp = op->in_player ();
1646 /* nope. Is this a container the player has opened? 1509 /* nope. Is this a container the player has opened?
1647 * If so, set tmp to that player. 1510 * If so, set tmp to that player.
1648 * IMO, searching through all the players will mostly 1511 * IMO, searching through all the players will mostly
1649 * likely be quicker than following op->env to the map, 1512 * likely be quicker than following op->env to the map,
1650 * and then searching the map for a player. 1513 * and then searching the map for a player.
1651 */ 1514 */
1652 if (!tmp) 1515 if (!tmp)
1653 { 1516 for_all_players (pl)
1654 for (pl = first_player; pl; pl = pl->next)
1655 if (pl->ob->container == op->env) 1517 if (pl->ob->container == op->env)
1518 {
1519 tmp = pl->ob;
1656 break; 1520 break;
1657 if (pl)
1658 tmp = pl->ob;
1659 else
1660 tmp = NULL;
1661 } 1521 }
1662 1522
1663 if (i < op->nrof) 1523 if (i < op->nrof)
1664 { 1524 {
1665 sub_weight (op->env, op->weight * i); 1525 sub_weight (op->env, op->weight * i);
1666 op->nrof -= i; 1526 op->nrof -= i;
1667 if (tmp) 1527 if (tmp)
1668 {
1669 esrv_send_item (tmp, op); 1528 esrv_send_item (tmp, op);
1670 }
1671 } 1529 }
1672 else 1530 else
1673 { 1531 {
1674 remove_ob (op); 1532 op->remove ();
1675 op->nrof = 0; 1533 op->nrof = 0;
1676 if (tmp) 1534 if (tmp)
1677 {
1678 esrv_del_item (tmp->contr, op->count); 1535 esrv_del_item (tmp->contr, op->count);
1679 }
1680 } 1536 }
1681 } 1537 }
1682 else 1538 else
1683 { 1539 {
1684 object *above = op->above; 1540 object *above = op->above;
1685 1541
1686 if (i < op->nrof) 1542 if (i < op->nrof)
1687 op->nrof -= i; 1543 op->nrof -= i;
1688 else 1544 else
1689 { 1545 {
1690 remove_ob (op); 1546 op->remove ();
1691 op->nrof = 0; 1547 op->nrof = 0;
1692 } 1548 }
1693 1549
1694 /* Since we just removed op, op->above is null */ 1550 /* Since we just removed op, op->above is null */
1695 for (tmp = above; tmp != NULL; tmp = tmp->above) 1551 for (tmp = above; tmp; tmp = tmp->above)
1696 if (tmp->type == PLAYER) 1552 if (tmp->type == PLAYER)
1697 { 1553 {
1698 if (op->nrof) 1554 if (op->nrof)
1699 esrv_send_item (tmp, op); 1555 esrv_send_item (tmp, op);
1700 else 1556 else
… …
1704 1560
1705 if (op->nrof) 1561 if (op->nrof)
1706 return op; 1562 return op;
1707 else 1563 else
1708 { 1564 {
1709 free_object (op); 1565 op->destroy ();
1710 return NULL; 1566 return 0;
1711 } 1567 }
1712} 1568}
1713 1569
1714/* 1570/*
1715 * add_weight(object, weight) adds the specified weight to an object, 1571 * add_weight(object, weight) adds the specified weight to an object,
… …
1727 op->carrying += weight; 1583 op->carrying += weight;
1728 op = op->env; 1584 op = op->env;
1729 } 1585 }
1730} 1586}
1731 1587
1732/*
1733 * insert_ob_in_ob(op,environment):
1734 * This function inserts the object op in the linked list
1735 * inside the object environment.
1736 *
1737 * Eneq(@csd.uu.se): Altered insert_ob_in_ob to make things picked up enter
1738 * the inventory at the last position or next to other objects of the same
1739 * type.
1740 * Frank: Now sorted by type, archetype and magic!
1741 *
1742 * The function returns now pointer to inserted item, and return value can
1743 * be != op, if items are merged. -Tero
1744 */
1745
1746object * 1588object *
1747insert_ob_in_ob (object *op, object *where) 1589insert_ob_in_ob (object *op, object *where)
1748{ 1590{
1749 object * 1591 if (!where)
1750 tmp, *
1751 otmp;
1752
1753 if (!QUERY_FLAG (op, FLAG_REMOVED))
1754 {
1755 char *dump = dump_object (op);
1756 LOG (llevError, "Trying to insert (ob) inserted object.\n%s\n", dump);
1757 free (dump);
1758 return op;
1759 }
1760
1761 if (where == NULL)
1762 { 1592 {
1763 char *dump = dump_object (op); 1593 char *dump = dump_object (op);
1764 LOG (llevError, "Trying to put object in NULL.\n%s\n", dump); 1594 LOG (llevError, "Trying to put object in NULL.\n%s\n", dump);
1765 free (dump); 1595 free (dump);
1766 return op; 1596 return op;
1767 } 1597 }
1768 1598
1769 if (where->head) 1599 if (where->head)
1770 { 1600 {
1771 LOG (llevDebug, "Warning: Tried to insert object wrong part of multipart object.\n"); 1601 LOG (llevDebug, "Warning: Tried to insert object into wrong part of multipart object.\n");
1772 where = where->head; 1602 where = where->head;
1773 } 1603 }
1604
1605 return where->insert (op);
1606}
1607
1608/*
1609 * env->insert (op)
1610 * This function inserts the object op in the linked list
1611 * inside the object environment.
1612 *
1613 * The function returns now pointer to inserted item, and return value can
1614 * be != op, if items are merged. -Tero
1615 */
1616
1617object *
1618object::insert (object *op)
1619{
1620 object *tmp, *otmp;
1621
1622 if (!QUERY_FLAG (op, FLAG_REMOVED))
1623 op->remove ();
1774 1624
1775 if (op->more) 1625 if (op->more)
1776 { 1626 {
1777 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count); 1627 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);
1778 return op; 1628 return op;
… …
1780 1630
1781 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL); 1631 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL);
1782 CLEAR_FLAG (op, FLAG_REMOVED); 1632 CLEAR_FLAG (op, FLAG_REMOVED);
1783 if (op->nrof) 1633 if (op->nrof)
1784 { 1634 {
1785 for (tmp = where->inv; tmp != NULL; tmp = tmp->below) 1635 for (tmp = inv; tmp != NULL; tmp = tmp->below)
1786 if (CAN_MERGE (tmp, op)) 1636 if (object::can_merge (tmp, op))
1787 { 1637 {
1788 /* return the original object and remove inserted object 1638 /* return the original object and remove inserted object
1789 (client needs the original object) */ 1639 (client needs the original object) */
1790 tmp->nrof += op->nrof; 1640 tmp->nrof += op->nrof;
1791 /* Weight handling gets pretty funky. Since we are adding to 1641 /* Weight handling gets pretty funky. Since we are adding to
1792 * tmp->nrof, we need to increase the weight. 1642 * tmp->nrof, we need to increase the weight.
1793 */ 1643 */
1794 add_weight (where, op->weight * op->nrof); 1644 add_weight (this, op->weight * op->nrof);
1795 SET_FLAG (op, FLAG_REMOVED); 1645 SET_FLAG (op, FLAG_REMOVED);
1796 free_object (op); /* free the inserted object */ 1646 op->destroy (); /* free the inserted object */
1797 op = tmp; 1647 op = tmp;
1798 remove_ob (op); /* and fix old object's links */ 1648 op->remove (); /* and fix old object's links */
1799 CLEAR_FLAG (op, FLAG_REMOVED); 1649 CLEAR_FLAG (op, FLAG_REMOVED);
1800 break; 1650 break;
1801 } 1651 }
1802 1652
1803 /* I assume combined objects have no inventory 1653 /* I assume combined objects have no inventory
1804 * We add the weight - this object could have just been removed 1654 * We add the weight - this object could have just been removed
1805 * (if it was possible to merge). calling remove_ob will subtract 1655 * (if it was possible to merge). calling remove_ob will subtract
1806 * the weight, so we need to add it in again, since we actually do 1656 * the weight, so we need to add it in again, since we actually do
1807 * the linking below 1657 * the linking below
1808 */ 1658 */
1809 add_weight (where, op->weight * op->nrof); 1659 add_weight (this, op->weight * op->nrof);
1810 } 1660 }
1811 else 1661 else
1812 add_weight (where, (op->weight + op->carrying)); 1662 add_weight (this, (op->weight + op->carrying));
1813 1663
1814 otmp = is_player_inv (where); 1664 otmp = this->in_player ();
1815 if (otmp && otmp->contr != NULL) 1665 if (otmp && otmp->contr)
1816 {
1817 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1666 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1818 fix_player (otmp); 1667 otmp->update_stats ();
1819 }
1820 1668
1821 op->map = NULL; 1669 op->map = 0;
1822 op->env = where; 1670 op->env = this;
1823 op->above = NULL; 1671 op->above = 0;
1824 op->below = NULL; 1672 op->below = 0;
1825 op->x = 0, op->y = 0; 1673 op->x = 0, op->y = 0;
1826 1674
1827 /* reset the light list and los of the players on the map */ 1675 /* reset the light list and los of the players on the map */
1828 if ((op->glow_radius != 0) && where->map) 1676 if ((op->glow_radius != 0) && map)
1829 { 1677 {
1830#ifdef DEBUG_LIGHTS 1678#ifdef DEBUG_LIGHTS
1831 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name); 1679 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1832#endif /* DEBUG_LIGHTS */ 1680#endif /* DEBUG_LIGHTS */
1833 if (MAP_DARKNESS (where->map)) 1681 if (map->darkness)
1834 update_all_los (where->map, where->x, where->y); 1682 update_all_los (map, x, y);
1835 } 1683 }
1836 1684
1837 /* Client has no idea of ordering so lets not bother ordering it here. 1685 /* Client has no idea of ordering so lets not bother ordering it here.
1838 * It sure simplifies this function... 1686 * It sure simplifies this function...
1839 */ 1687 */
1840 if (where->inv == NULL) 1688 if (!inv)
1841 where->inv = op; 1689 inv = op;
1842 else 1690 else
1843 { 1691 {
1844 op->below = where->inv; 1692 op->below = inv;
1845 op->below->above = op; 1693 op->below->above = op;
1846 where->inv = op; 1694 inv = op;
1847 } 1695 }
1696
1697 INVOKE_OBJECT (INSERT, this);
1698
1848 return op; 1699 return op;
1849} 1700}
1850 1701
1851/* 1702/*
1852 * Checks if any objects has a move_type that matches objects 1703 * Checks if any objects has a move_type that matches objects
… …
1866 * 1717 *
1867 * MSW 2001-07-08: Check all objects on space, not just those below 1718 * MSW 2001-07-08: Check all objects on space, not just those below
1868 * object being inserted. insert_ob_in_map may not put new objects 1719 * object being inserted. insert_ob_in_map may not put new objects
1869 * on top. 1720 * on top.
1870 */ 1721 */
1871
1872int 1722int
1873check_move_on (object *op, object *originator) 1723check_move_on (object *op, object *originator)
1874{ 1724{
1875 object *tmp; 1725 object *tmp;
1876 maptile *m = op->map; 1726 maptile *m = op->map;
… …
1903 1753
1904 /* The objects have to be checked from top to bottom. 1754 /* The objects have to be checked from top to bottom.
1905 * Hence, we first go to the top: 1755 * Hence, we first go to the top:
1906 */ 1756 */
1907 1757
1908 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL && tmp->above != NULL; tmp = tmp->above) 1758 for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1909 { 1759 {
1910 /* Trim the search when we find the first other spell effect 1760 /* Trim the search when we find the first other spell effect
1911 * this helps performance so that if a space has 50 spell objects, 1761 * this helps performance so that if a space has 50 spell objects,
1912 * we don't need to check all of them. 1762 * we don't need to check all of them.
1913 */ 1763 */
… …
1931 if ((!op->move_type && tmp->move_slow & MOVE_WALK) || 1781 if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
1932 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0)) 1782 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
1933 { 1783 {
1934 1784
1935 float 1785 float
1936 diff = tmp->move_slow_penalty * FABS (op->speed); 1786 diff = tmp->move_slow_penalty * fabs (op->speed);
1937 1787
1938 if (op->type == PLAYER) 1788 if (op->type == PLAYER)
1939 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) || 1789 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) ||
1940 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN))) 1790 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN)))
1941 diff /= 4.0; 1791 diff /= 4.0;
… …
1968/* 1818/*
1969 * present_arch(arch, map, x, y) searches for any objects with 1819 * present_arch(arch, map, x, y) searches for any objects with
1970 * a matching archetype at the given map and coordinates. 1820 * a matching archetype at the given map and coordinates.
1971 * The first matching object is returned, or NULL if none. 1821 * The first matching object is returned, or NULL if none.
1972 */ 1822 */
1973
1974object * 1823object *
1975present_arch (const archetype *at, maptile *m, int x, int y) 1824present_arch (const archetype *at, maptile *m, int x, int y)
1976{ 1825{
1977 object *
1978 tmp;
1979
1980 if (m == NULL || out_of_map (m, x, y)) 1826 if (!m || out_of_map (m, x, y))
1981 { 1827 {
1982 LOG (llevError, "Present_arch called outside map.\n"); 1828 LOG (llevError, "Present_arch called outside map.\n");
1983 return NULL; 1829 return NULL;
1984 } 1830 }
1985 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1831
1832 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1986 if (tmp->arch == at) 1833 if (tmp->arch == at)
1987 return tmp; 1834 return tmp;
1835
1988 return NULL; 1836 return NULL;
1989} 1837}
1990 1838
1991/* 1839/*
1992 * present(type, map, x, y) searches for any objects with 1840 * present(type, map, x, y) searches for any objects with
1993 * a matching type variable at the given map and coordinates. 1841 * a matching type variable at the given map and coordinates.
1994 * The first matching object is returned, or NULL if none. 1842 * The first matching object is returned, or NULL if none.
1995 */ 1843 */
1996
1997object * 1844object *
1998present (unsigned char type, maptile *m, int x, int y) 1845present (unsigned char type, maptile *m, int x, int y)
1999{ 1846{
2000 object *
2001 tmp;
2002
2003 if (out_of_map (m, x, y)) 1847 if (out_of_map (m, x, y))
2004 { 1848 {
2005 LOG (llevError, "Present called outside map.\n"); 1849 LOG (llevError, "Present called outside map.\n");
2006 return NULL; 1850 return NULL;
2007 } 1851 }
2008 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1852
1853 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
2009 if (tmp->type == type) 1854 if (tmp->type == type)
2010 return tmp; 1855 return tmp;
1856
2011 return NULL; 1857 return NULL;
2012} 1858}
2013 1859
2014/* 1860/*
2015 * present_in_ob(type, object) searches for any objects with 1861 * present_in_ob(type, object) searches for any objects with
2016 * a matching type variable in the inventory of the given object. 1862 * a matching type variable in the inventory of the given object.
2017 * The first matching object is returned, or NULL if none. 1863 * The first matching object is returned, or NULL if none.
2018 */ 1864 */
2019
2020object * 1865object *
2021present_in_ob (unsigned char type, const object *op) 1866present_in_ob (unsigned char type, const object *op)
2022{ 1867{
2023 object *
2024 tmp;
2025
2026 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1868 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2027 if (tmp->type == type) 1869 if (tmp->type == type)
2028 return tmp; 1870 return tmp;
1871
2029 return NULL; 1872 return NULL;
2030} 1873}
2031 1874
2032/* 1875/*
2033 * present_in_ob (type, str, object) searches for any objects with 1876 * present_in_ob (type, str, object) searches for any objects with
… …
2041 * str is the string to match against. Note that we match against 1884 * str is the string to match against. Note that we match against
2042 * the object name, not the archetype name. this is so that the 1885 * the object name, not the archetype name. this is so that the
2043 * spell code can use one object type (force), but change it's name 1886 * spell code can use one object type (force), but change it's name
2044 * to be unique. 1887 * to be unique.
2045 */ 1888 */
2046
2047object * 1889object *
2048present_in_ob_by_name (int type, const char *str, const object *op) 1890present_in_ob_by_name (int type, const char *str, const object *op)
2049{ 1891{
2050 object *
2051 tmp;
2052
2053 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1892 for (object *tmp = op->inv; tmp; tmp = tmp->below)
2054 {
2055 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name))) 1893 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name)))
2056 return tmp; 1894 return tmp;
2057 } 1895
2058 return NULL; 1896 return 0;
2059} 1897}
2060 1898
2061/* 1899/*
2062 * present_arch_in_ob(archetype, object) searches for any objects with 1900 * present_arch_in_ob(archetype, object) searches for any objects with
2063 * a matching archetype in the inventory of the given object. 1901 * a matching archetype in the inventory of the given object.
2064 * The first matching object is returned, or NULL if none. 1902 * The first matching object is returned, or NULL if none.
2065 */ 1903 */
2066
2067object * 1904object *
2068present_arch_in_ob (const archetype *at, const object *op) 1905present_arch_in_ob (const archetype *at, const object *op)
2069{ 1906{
2070 object *
2071 tmp;
2072
2073 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1907 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2074 if (tmp->arch == at) 1908 if (tmp->arch == at)
2075 return tmp; 1909 return tmp;
1910
2076 return NULL; 1911 return NULL;
2077} 1912}
2078 1913
2079/* 1914/*
2080 * activate recursively a flag on an object inventory 1915 * activate recursively a flag on an object inventory
2081 */ 1916 */
2082void 1917void
2083flag_inv (object *op, int flag) 1918flag_inv (object *op, int flag)
2084{ 1919{
2085 object *
2086 tmp;
2087
2088 if (op->inv) 1920 if (op->inv)
2089 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1921 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2090 { 1922 {
2091 SET_FLAG (tmp, flag); 1923 SET_FLAG (tmp, flag);
2092 flag_inv (tmp, flag); 1924 flag_inv (tmp, flag);
2093 } 1925 }
2094} /* 1926}
1927
1928/*
2095 * desactivate recursively a flag on an object inventory 1929 * deactivate recursively a flag on an object inventory
2096 */ 1930 */
2097void 1931void
2098unflag_inv (object *op, int flag) 1932unflag_inv (object *op, int flag)
2099{ 1933{
2100 object *
2101 tmp;
2102
2103 if (op->inv) 1934 if (op->inv)
2104 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1935 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2105 { 1936 {
2106 CLEAR_FLAG (tmp, flag); 1937 CLEAR_FLAG (tmp, flag);
2107 unflag_inv (tmp, flag); 1938 unflag_inv (tmp, flag);
2108 } 1939 }
2109} 1940}
… …
2112 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in 1943 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in
2113 * all it's inventory (recursively). 1944 * all it's inventory (recursively).
2114 * If checksums are used, a player will get set_cheat called for 1945 * If checksums are used, a player will get set_cheat called for
2115 * him/her-self and all object carried by a call to this function. 1946 * him/her-self and all object carried by a call to this function.
2116 */ 1947 */
2117
2118void 1948void
2119set_cheat (object *op) 1949set_cheat (object *op)
2120{ 1950{
2121 SET_FLAG (op, FLAG_WAS_WIZ); 1951 SET_FLAG (op, FLAG_WAS_WIZ);
2122 flag_inv (op, FLAG_WAS_WIZ); 1952 flag_inv (op, FLAG_WAS_WIZ);
… …
2141 * because arch_blocked (now ob_blocked) needs to know the movement type 1971 * because arch_blocked (now ob_blocked) needs to know the movement type
2142 * to know if the space in question will block the object. We can't use 1972 * to know if the space in question will block the object. We can't use
2143 * the archetype because that isn't correct if the monster has been 1973 * the archetype because that isn't correct if the monster has been
2144 * customized, changed states, etc. 1974 * customized, changed states, etc.
2145 */ 1975 */
2146
2147int 1976int
2148find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop) 1977find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)
2149{ 1978{
2150 int
2151 i,
2152 index = 0, flag; 1979 int index = 0, flag;
2153 static int
2154 altern[SIZEOFFREE]; 1980 int altern[SIZEOFFREE];
2155 1981
2156 for (i = start; i < stop; i++) 1982 for (int i = start; i < stop; i++)
2157 { 1983 {
2158 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]); 1984 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]);
2159 if (!flag) 1985 if (!flag)
2160 altern[index++] = i; 1986 altern [index++] = i;
2161 1987
2162 /* Basically, if we find a wall on a space, we cut down the search size. 1988 /* Basically, if we find a wall on a space, we cut down the search size.
2163 * In this way, we won't return spaces that are on another side of a wall. 1989 * In this way, we won't return spaces that are on another side of a wall.
2164 * This mostly work, but it cuts down the search size in all directions - 1990 * This mostly work, but it cuts down the search size in all directions -
2165 * if the space being examined only has a wall to the north and empty 1991 * if the space being examined only has a wall to the north and empty
2166 * spaces in all the other directions, this will reduce the search space 1992 * spaces in all the other directions, this will reduce the search space
2167 * to only the spaces immediately surrounding the target area, and 1993 * to only the spaces immediately surrounding the target area, and
2168 * won't look 2 spaces south of the target space. 1994 * won't look 2 spaces south of the target space.
2169 */ 1995 */
2170 else if ((flag & AB_NO_PASS) && maxfree[i] < stop) 1996 else if ((flag & P_NO_PASS) && maxfree[i] < stop)
2171 stop = maxfree[i]; 1997 stop = maxfree[i];
2172 } 1998 }
1999
2173 if (!index) 2000 if (!index)
2174 return -1; 2001 return -1;
2002
2175 return altern[RANDOM () % index]; 2003 return altern [rndm (index)];
2176} 2004}
2177 2005
2178/* 2006/*
2179 * find_first_free_spot(archetype, maptile, x, y) works like 2007 * find_first_free_spot(archetype, maptile, x, y) works like
2180 * find_free_spot(), but it will search max number of squares. 2008 * find_free_spot(), but it will search max number of squares.
2181 * But it will return the first available spot, not a random choice. 2009 * But it will return the first available spot, not a random choice.
2182 * Changed 0.93.2: Have it return -1 if there is no free spot available. 2010 * Changed 0.93.2: Have it return -1 if there is no free spot available.
2183 */ 2011 */
2184
2185int 2012int
2186find_first_free_spot (const object *ob, maptile *m, int x, int y) 2013find_first_free_spot (const object *ob, maptile *m, int x, int y)
2187{ 2014{
2188 int
2189 i;
2190
2191 for (i = 0; i < SIZEOFFREE; i++) 2015 for (int i = 0; i < SIZEOFFREE; i++)
2192 {
2193 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i])) 2016 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]))
2194 return i; 2017 return i;
2195 } 2018
2196 return -1; 2019 return -1;
2197} 2020}
2198 2021
2199/* 2022/*
2200 * The function permute(arr, begin, end) randomly reorders the array 2023 * The function permute(arr, begin, end) randomly reorders the array
2201 * arr[begin..end-1]. 2024 * arr[begin..end-1].
2025 * now uses a fisher-yates shuffle, old permute was broken
2202 */ 2026 */
2203static void 2027static void
2204permute (int *arr, int begin, int end) 2028permute (int *arr, int begin, int end)
2205{ 2029{
2206 int 2030 arr += begin;
2207 i,
2208 j,
2209 tmp,
2210 len;
2211
2212 len = end - begin; 2031 end -= begin;
2213 for (i = begin; i < end; i++)
2214 {
2215 j = begin + RANDOM () % len;
2216 2032
2217 tmp = arr[i]; 2033 while (--end)
2218 arr[i] = arr[j]; 2034 swap (arr [end], arr [rndm (end + 1)]);
2219 arr[j] = tmp;
2220 }
2221} 2035}
2222 2036
2223/* new function to make monster searching more efficient, and effective! 2037/* new function to make monster searching more efficient, and effective!
2224 * This basically returns a randomized array (in the passed pointer) of 2038 * This basically returns a randomized array (in the passed pointer) of
2225 * the spaces to find monsters. In this way, it won't always look for 2039 * the spaces to find monsters. In this way, it won't always look for
… …
2228 * the 3x3 area will be searched, just not in a predictable order. 2042 * the 3x3 area will be searched, just not in a predictable order.
2229 */ 2043 */
2230void 2044void
2231get_search_arr (int *search_arr) 2045get_search_arr (int *search_arr)
2232{ 2046{
2233 int 2047 int i;
2234 i;
2235 2048
2236 for (i = 0; i < SIZEOFFREE; i++) 2049 for (i = 0; i < SIZEOFFREE; i++)
2237 {
2238 search_arr[i] = i; 2050 search_arr[i] = i;
2239 }
2240 2051
2241 permute (search_arr, 1, SIZEOFFREE1 + 1); 2052 permute (search_arr, 1, SIZEOFFREE1 + 1);
2242 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1); 2053 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1);
2243 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE); 2054 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE);
2244} 2055}
… …
2253 * Perhaps incorrectly, but I'm making the assumption that exclude 2064 * Perhaps incorrectly, but I'm making the assumption that exclude
2254 * is actually want is going to try and move there. We need this info 2065 * is actually want is going to try and move there. We need this info
2255 * because we have to know what movement the thing looking to move 2066 * because we have to know what movement the thing looking to move
2256 * there is capable of. 2067 * there is capable of.
2257 */ 2068 */
2258
2259int 2069int
2260find_dir (maptile *m, int x, int y, object *exclude) 2070find_dir (maptile *m, int x, int y, object *exclude)
2261{ 2071{
2262 int
2263 i,
2264 max = SIZEOFFREE, mflags; 2072 int i, max = SIZEOFFREE, mflags;
2265 2073
2266 sint16 nx, ny; 2074 sint16 nx, ny;
2267 object * 2075 object *tmp;
2268 tmp;
2269 maptile * 2076 maptile *mp;
2270 mp;
2271 2077
2272 MoveType blocked, move_type; 2078 MoveType blocked, move_type;
2273 2079
2274 if (exclude && exclude->head) 2080 if (exclude && exclude->head)
2275 { 2081 {
… …
2287 mp = m; 2093 mp = m;
2288 nx = x + freearr_x[i]; 2094 nx = x + freearr_x[i];
2289 ny = y + freearr_y[i]; 2095 ny = y + freearr_y[i];
2290 2096
2291 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2097 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);
2098
2292 if (mflags & P_OUT_OF_MAP) 2099 if (mflags & P_OUT_OF_MAP)
2293 {
2294 max = maxfree[i]; 2100 max = maxfree[i];
2295 }
2296 else 2101 else
2297 { 2102 {
2298 blocked = GET_MAP_MOVE_BLOCK (mp, nx, ny); 2103 mapspace &ms = mp->at (nx, ny);
2104
2105 blocked = ms.move_block;
2299 2106
2300 if ((move_type & blocked) == move_type) 2107 if ((move_type & blocked) == move_type)
2301 {
2302 max = maxfree[i]; 2108 max = maxfree[i];
2303 }
2304 else if (mflags & P_IS_ALIVE) 2109 else if (mflags & P_IS_ALIVE)
2305 { 2110 {
2306 for (tmp = GET_MAP_OB (mp, nx, ny); tmp != NULL; tmp = tmp->above) 2111 for (tmp = ms.bot; tmp; tmp = tmp->above)
2307 { 2112 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)
2308 if ((QUERY_FLAG (tmp, FLAG_MONSTER) || tmp->type == PLAYER) && (tmp != exclude || (tmp->head && tmp->head != exclude))) 2113 && (tmp != exclude || (tmp->head && tmp->head != exclude)))
2309 {
2310 break; 2114 break;
2311 } 2115
2312 }
2313 if (tmp) 2116 if (tmp)
2314 {
2315 return freedir[i]; 2117 return freedir[i];
2316 }
2317 } 2118 }
2318 } 2119 }
2319 } 2120 }
2121
2320 return 0; 2122 return 0;
2321} 2123}
2322 2124
2323/* 2125/*
2324 * distance(object 1, object 2) will return the square of the 2126 * distance(object 1, object 2) will return the square of the
2325 * distance between the two given objects. 2127 * distance between the two given objects.
2326 */ 2128 */
2327
2328int 2129int
2329distance (const object *ob1, const object *ob2) 2130distance (const object *ob1, const object *ob2)
2330{ 2131{
2331 int
2332 i;
2333
2334 i = (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y); 2132 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2335 return i;
2336} 2133}
2337 2134
2338/* 2135/*
2339 * find_dir_2(delta-x,delta-y) will return a direction in which 2136 * find_dir_2(delta-x,delta-y) will return a direction in which
2340 * an object which has subtracted the x and y coordinates of another 2137 * an object which has subtracted the x and y coordinates of another
2341 * object, needs to travel toward it. 2138 * object, needs to travel toward it.
2342 */ 2139 */
2343
2344int 2140int
2345find_dir_2 (int x, int y) 2141find_dir_2 (int x, int y)
2346{ 2142{
2347 int 2143 int q;
2348 q;
2349 2144
2350 if (y) 2145 if (y)
2351 q = x * 100 / y; 2146 q = x * 100 / y;
2352 else if (x) 2147 else if (x)
2353 q = -300 * x; 2148 q = -300 * x;
… …
2378 2173
2379 return 3; 2174 return 3;
2380} 2175}
2381 2176
2382/* 2177/*
2383 * absdir(int): Returns a number between 1 and 8, which represent
2384 * the "absolute" direction of a number (it actually takes care of
2385 * "overflow" in previous calculations of a direction).
2386 */
2387
2388int
2389absdir (int d)
2390{
2391 while (d < 1)
2392 d += 8;
2393 while (d > 8)
2394 d -= 8;
2395 return d;
2396}
2397
2398/*
2399 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is 2178 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is
2400 * between two directions (which are expected to be absolute (see absdir()) 2179 * between two directions (which are expected to be absolute (see absdir())
2401 */ 2180 */
2402
2403int 2181int
2404dirdiff (int dir1, int dir2) 2182dirdiff (int dir1, int dir2)
2405{ 2183{
2406 int 2184 int d;
2407 d;
2408 2185
2409 d = abs (dir1 - dir2); 2186 d = abs (dir1 - dir2);
2410 if (d > 4) 2187 if (d > 4)
2411 d = 8 - d; 2188 d = 8 - d;
2189
2412 return d; 2190 return d;
2413} 2191}
2414 2192
2415/* peterm: 2193/* peterm:
2416 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster. 2194 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster.
… …
2419 * This basically means that if direction is 15, then it could either go 2197 * This basically means that if direction is 15, then it could either go
2420 * direction 4, 14, or 16 to get back to where we are. 2198 * direction 4, 14, or 16 to get back to where we are.
2421 * Moved from spell_util.c to object.c with the other related direction 2199 * Moved from spell_util.c to object.c with the other related direction
2422 * functions. 2200 * functions.
2423 */ 2201 */
2424
2425int
2426 reduction_dir[SIZEOFFREE][3] = { 2202int reduction_dir[SIZEOFFREE][3] = {
2427 {0, 0, 0}, /* 0 */ 2203 {0, 0, 0}, /* 0 */
2428 {0, 0, 0}, /* 1 */ 2204 {0, 0, 0}, /* 1 */
2429 {0, 0, 0}, /* 2 */ 2205 {0, 0, 0}, /* 2 */
2430 {0, 0, 0}, /* 3 */ 2206 {0, 0, 0}, /* 3 */
2431 {0, 0, 0}, /* 4 */ 2207 {0, 0, 0}, /* 4 */
… …
2479 * find a path to that monster that we found. If not, 2255 * find a path to that monster that we found. If not,
2480 * we don't bother going toward it. Returns 1 if we 2256 * we don't bother going toward it. Returns 1 if we
2481 * can see a direct way to get it 2257 * can see a direct way to get it
2482 * Modified to be map tile aware -.MSW 2258 * Modified to be map tile aware -.MSW
2483 */ 2259 */
2484
2485
2486int 2260int
2487can_see_monsterP (maptile *m, int x, int y, int dir) 2261can_see_monsterP (maptile *m, int x, int y, int dir)
2488{ 2262{
2489 sint16 dx, dy; 2263 sint16 dx, dy;
2490 int
2491 mflags; 2264 int mflags;
2492 2265
2493 if (dir < 0) 2266 if (dir < 0)
2494 return 0; /* exit condition: invalid direction */ 2267 return 0; /* exit condition: invalid direction */
2495 2268
2496 dx = x + freearr_x[dir]; 2269 dx = x + freearr_x[dir];
… …
2509 return 0; 2282 return 0;
2510 2283
2511 /* yes, can see. */ 2284 /* yes, can see. */
2512 if (dir < 9) 2285 if (dir < 9)
2513 return 1; 2286 return 1;
2287
2514 return can_see_monsterP (m, x, y, reduction_dir[dir][0]) | 2288 return can_see_monsterP (m, x, y, reduction_dir[dir][0])
2515 can_see_monsterP (m, x, y, reduction_dir[dir][1]) | can_see_monsterP (m, x, y, reduction_dir[dir][2]); 2289 | can_see_monsterP (m, x, y, reduction_dir[dir][1])
2290 | can_see_monsterP (m, x, y, reduction_dir[dir][2]);
2516} 2291}
2517
2518
2519 2292
2520/* 2293/*
2521 * can_pick(picker, item): finds out if an object is possible to be 2294 * can_pick(picker, item): finds out if an object is possible to be
2522 * picked up by the picker. Returnes 1 if it can be 2295 * picked up by the picker. Returnes 1 if it can be
2523 * picked up, otherwise 0. 2296 * picked up, otherwise 0.
… …
2534 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2307 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2535 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2308 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2536 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2309 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));
2537} 2310}
2538 2311
2539
2540/* 2312/*
2541 * create clone from object to another 2313 * create clone from object to another
2542 */ 2314 */
2543object * 2315object *
2544object_create_clone (object *asrc) 2316object_create_clone (object *asrc)
2545{ 2317{
2546 object *
2547 dst = NULL, *tmp, *src, *part, *prev, *item; 2318 object *dst = 0, *tmp, *src, *part, *prev, *item;
2548 2319
2549 if (!asrc) 2320 if (!asrc)
2550 return NULL; 2321 return 0;
2322
2551 src = asrc; 2323 src = asrc;
2552 if (src->head) 2324 if (src->head)
2553 src = src->head; 2325 src = src->head;
2554 2326
2555 prev = NULL; 2327 prev = 0;
2556 for (part = src; part; part = part->more) 2328 for (part = src; part; part = part->more)
2557 { 2329 {
2558 tmp = get_object (); 2330 tmp = part->clone ();
2559 copy_object (part, tmp);
2560 tmp->x -= src->x; 2331 tmp->x -= src->x;
2561 tmp->y -= src->y; 2332 tmp->y -= src->y;
2333
2562 if (!part->head) 2334 if (!part->head)
2563 { 2335 {
2564 dst = tmp; 2336 dst = tmp;
2565 tmp->head = NULL; 2337 tmp->head = 0;
2566 } 2338 }
2567 else 2339 else
2568 {
2569 tmp->head = dst; 2340 tmp->head = dst;
2570 } 2341
2571 tmp->more = NULL; 2342 tmp->more = 0;
2343
2572 if (prev) 2344 if (prev)
2573 prev->more = tmp; 2345 prev->more = tmp;
2346
2574 prev = tmp; 2347 prev = tmp;
2575 } 2348 }
2576 2349
2577 for (item = src->inv; item; item = item->below) 2350 for (item = src->inv; item; item = item->below)
2578 insert_ob_in_ob (object_create_clone (item), dst); 2351 insert_ob_in_ob (object_create_clone (item), dst);
2579 2352
2580 return dst; 2353 return dst;
2581}
2582
2583/* GROS - Creates an object using a string representing its content. */
2584/* Basically, we save the content of the string to a temp file, then call */
2585/* load_object on it. I admit it is a highly inefficient way to make things, */
2586/* but it was simple to make and allows reusing the load_object function. */
2587/* Remember not to use load_object_str in a time-critical situation. */
2588/* Also remember that multiparts objects are not supported for now. */
2589
2590object *
2591load_object_str (const char *obstr)
2592{
2593 object *op;
2594 char filename[MAX_BUF];
2595
2596 sprintf (filename, "%s/cfloadobstr2044", settings.tmpdir);
2597
2598 FILE *tempfile = fopen (filename, "w");
2599
2600 if (tempfile == NULL)
2601 {
2602 LOG (llevError, "Error - Unable to access load object temp file\n");
2603 return NULL;
2604 }
2605
2606 fprintf (tempfile, obstr);
2607 fclose (tempfile);
2608
2609 op = get_object ();
2610
2611 object_thawer thawer (filename);
2612
2613 if (thawer)
2614 load_object (thawer, op, 0);
2615
2616 LOG (llevDebug, " load str completed, object=%s\n", &op->name);
2617 CLEAR_FLAG (op, FLAG_REMOVED);
2618
2619 return op;
2620} 2354}
2621 2355
2622/* This returns the first object in who's inventory that 2356/* This returns the first object in who's inventory that
2623 * has the same type and subtype match. 2357 * has the same type and subtype match.
2624 * returns NULL if no match. 2358 * returns NULL if no match.
2625 */ 2359 */
2626object * 2360object *
2627find_obj_by_type_subtype (const object *who, int type, int subtype) 2361find_obj_by_type_subtype (const object *who, int type, int subtype)
2628{ 2362{
2629 object *tmp;
2630
2631 for (tmp = who->inv; tmp; tmp = tmp->below) 2363 for (object *tmp = who->inv; tmp; tmp = tmp->below)
2632 if (tmp->type == type && tmp->subtype == subtype) 2364 if (tmp->type == type && tmp->subtype == subtype)
2633 return tmp; 2365 return tmp;
2634 2366
2635 return NULL; 2367 return 0;
2636} 2368}
2637 2369
2638/* If ob has a field named key, return the link from the list, 2370/* If ob has a field named key, return the link from the list,
2639 * otherwise return NULL. 2371 * otherwise return NULL.
2640 * 2372 *
… …
2642 * do the desired thing. 2374 * do the desired thing.
2643 */ 2375 */
2644key_value * 2376key_value *
2645get_ob_key_link (const object *ob, const char *key) 2377get_ob_key_link (const object *ob, const char *key)
2646{ 2378{
2647 key_value *link;
2648
2649 for (link = ob->key_values; link != NULL; link = link->next) 2379 for (key_value *link = ob->key_values; link; link = link->next)
2650 if (link->key == key) 2380 if (link->key == key)
2651 return link; 2381 return link;
2652 2382
2653 return NULL; 2383 return 0;
2654} 2384}
2655 2385
2656/* 2386/*
2657 * Returns the value of op has an extra_field for key, or NULL. 2387 * Returns the value of op has an extra_field for key, or NULL.
2658 * 2388 *
… …
2698 * Returns TRUE on success. 2428 * Returns TRUE on success.
2699 */ 2429 */
2700int 2430int
2701set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key) 2431set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2702{ 2432{
2703 key_value *
2704 field = NULL, *last = NULL; 2433 key_value *field = NULL, *last = NULL;
2705 2434
2706 for (field = op->key_values; field != NULL; field = field->next) 2435 for (field = op->key_values; field != NULL; field = field->next)
2707 { 2436 {
2708 if (field->key != canonical_key) 2437 if (field->key != canonical_key)
2709 { 2438 {
… …
2737 /* IF we get here, key doesn't exist */ 2466 /* IF we get here, key doesn't exist */
2738 2467
2739 /* No field, we'll have to add it. */ 2468 /* No field, we'll have to add it. */
2740 2469
2741 if (!add_key) 2470 if (!add_key)
2742 {
2743 return FALSE; 2471 return FALSE;
2744 } 2472
2745 /* There isn't any good reason to store a null 2473 /* There isn't any good reason to store a null
2746 * value in the key/value list. If the archetype has 2474 * value in the key/value list. If the archetype has
2747 * this key, then we should also have it, so shouldn't 2475 * this key, then we should also have it, so shouldn't
2748 * be here. If user wants to store empty strings, 2476 * be here. If user wants to store empty strings,
2749 * should pass in "" 2477 * should pass in ""
… …
2798 } 2526 }
2799 else 2527 else
2800 item = item->env; 2528 item = item->env;
2801} 2529}
2802 2530
2531
2532const char *
2533object::flag_desc (char *desc, int len) const
2534{
2535 char *p = desc;
2536 bool first = true;
2537
2538 *p = 0;
2539
2540 for (int i = 0; i < NUM_FLAGS; i++)
2541 {
2542 if (len <= 10) // magic constant!
2543 {
2544 snprintf (p, len, ",...");
2545 break;
2546 }
2547
2548 if (flag [i])
2549 {
2550 int cnt = snprintf (p, len, "%s%d", first ? "" : ",", i);
2551 len -= cnt;
2552 p += cnt;
2553 first = false;
2554 }
2555 }
2556
2557 return desc;
2558}
2559
2803// return a suitable string describing an objetc in enough detail to find it 2560// return a suitable string describing an object in enough detail to find it
2804const char * 2561const char *
2805object::debug_desc (char *info) const 2562object::debug_desc (char *info) const
2806{ 2563{
2564 char flagdesc[512];
2807 char info2[256 * 3]; 2565 char info2[256 * 4];
2808 char *p = info; 2566 char *p = info;
2809 2567
2810 p += snprintf (p, 256, "%d=\"%s%s%s\"", 2568 p += snprintf (p, 512, "{cnt:%d,uuid:<1.%" PRIx64 ">,name:\"%s\"%s%s,flags:[%s],type:%d}",
2811 count, 2569 count, uuid.seq,
2812 &name, 2570 &name,
2813 title ? " " : "", 2571 title ? "\",title:\"" : "",
2814 title ? (const char *)title : ""); 2572 title ? (const char *)title : "",
2573 flag_desc (flagdesc, 512), type);
2815 2574
2816 if (env) 2575 if (env)
2817 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2576 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2818 2577
2819 if (map) 2578 if (map)
2820 p += snprintf (p, 256, "(on %s@%d+%d)", map->path, x, y); 2579 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2821 2580
2822 return info; 2581 return info;
2823} 2582}
2824 2583
2825const char * 2584const char *
2826object::debug_desc () const 2585object::debug_desc () const
2827{ 2586{
2828 static char info[256 * 3]; 2587 static char info[256 * 4];
2829 return debug_desc (info); 2588 return debug_desc (info);
2830} 2589}
2831 2590
2591const char *
2592object::debug_desc2 () const
2593{
2594 static char info[256 * 4];
2595 return debug_desc (info);
2596}
2597
2598struct region *
2599object::region () const
2600{
2601 return map ? map->region (x, y)
2602 : region::default_region ();
2603}
2604
2605const materialtype_t *
2606object::dominant_material () const
2607{
2608 if (materialtype_t *mat = name_to_material (materialname))
2609 return mat;
2610
2611 // omfg this is slow, this has to be temporary :)
2612 shstr unknown ("unknown");
2613
2614 return name_to_material (unknown);
2615}
2616
2617void
2618object::open_container (object *new_container)
2619{
2620 if (container == new_container)
2621 return;
2622
2623 if (object *old_container = container)
2624 {
2625 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))
2626 return;
2627
2628#if 0
2629 // remove the "Close old_container" object.
2630 if (object *closer = old_container->inv)
2631 if (closer->type == CLOSE_CON)
2632 closer->destroy ();
2633#endif
2634
2635 old_container->flag [FLAG_APPLIED] = 0;
2636 container = 0;
2637
2638 esrv_update_item (UPD_FLAGS, this, old_container);
2639 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container));
2640 }
2641
2642 if (new_container)
2643 {
2644 if (INVOKE_OBJECT (OPEN, new_container, ARG_OBJECT (this)))
2645 return;
2646
2647 // TODO: this does not seem to serve any purpose anymore?
2648#if 0
2649 // insert the "Close Container" object.
2650 if (archetype *closer = new_container->other_arch)
2651 {
2652 object *closer = arch_to_object (new_container->other_arch);
2653 closer->flag [FLAG_NO_MAP_SAVE] = 1;
2654 new_container->insert (closer);
2655 }
2656#endif
2657
2658 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container));
2659
2660 new_container->flag [FLAG_APPLIED] = 1;
2661 container = new_container;
2662
2663 esrv_update_item (UPD_FLAGS, this, new_container);
2664 esrv_send_inventory (this, new_container);
2665 }
2666}
2667
2668

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines