ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.219 by root, Wed Apr 23 21:09:10 2008 UTC vs.
Revision 1.249 by root, Tue Jul 15 20:41:58 2008 UTC

139 139
140/* Returns TRUE if every key_values in wants has a partner with the same value in has. */ 140/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
141static bool 141static bool
142compare_ob_value_lists_one (const object *wants, const object *has) 142compare_ob_value_lists_one (const object *wants, const object *has)
143{ 143{
144 key_value *wants_field;
145
146 /* n-squared behaviour (see get_ob_key_link()), but I'm hoping both 144 /* n-squared behaviour (see kv_get), but I'm hoping both
147 * objects with lists are rare, and lists stay short. If not, use a 145 * objects with lists are rare, and lists stay short. If not, use a
148 * different structure or at least keep the lists sorted... 146 * different structure or at least keep the lists sorted...
149 */ 147 */
150 148
151 /* For each field in wants, */ 149 /* For each field in wants, */
152 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next) 150 for (key_value *kv = wants->key_values; kv; kv = kv->next)
153 { 151 if (has->kv_get (kv->key) != kv->value)
154 key_value *has_field; 152 return false;
155
156 /* Look for a field in has with the same key. */
157 has_field = get_ob_key_link (has, wants_field->key);
158
159 if (!has_field)
160 return 0; /* No field with that name. */
161
162 /* Found the matching field. */
163 if (has_field->value != wants_field->value)
164 return 0; /* Values don't match, so this half of the comparison is false. */
165
166 /* If we get here, we found a match. Now for the next field in wants. */
167 }
168 153
169 /* If we get here, every field in wants has a matching field in has. */ 154 /* If we get here, every field in wants has a matching field in has. */
170 return 1; 155 return true;
171} 156}
172 157
173/* Returns TRUE if ob1 has the same key_values as ob2. */ 158/* Returns TRUE if ob1 has the same key_values as ob2. */
174static bool 159static bool
175compare_ob_value_lists (const object *ob1, const object *ob2) 160compare_ob_value_lists (const object *ob1, const object *ob2)
176{ 161{
177 /* However, there may be fields in has which aren't partnered in wants, 162 /* However, there may be fields in has which aren't partnered in wants,
178 * so we need to run the comparison *twice*. :( 163 * so we need to run the comparison *twice*. :(
179 */ 164 */
180 return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1); 165 return compare_ob_value_lists_one (ob1, ob2)
166 && compare_ob_value_lists_one (ob2, ob1);
181} 167}
182 168
183/* Function examines the 2 objects given to it, and returns true if 169/* Function examines the 2 objects given to it, and returns true if
184 * they can be merged together. 170 * they can be merged together.
185 * 171 *
220 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 206 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
221 207
222 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 208 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
223 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 209 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
224 210
225 if (ob1->arch->name != ob2->arch->name 211 if (ob1->arch->archname != ob2->arch->archname
226 || ob1->name != ob2->name 212 || ob1->name != ob2->name
227 || ob1->title != ob2->title 213 || ob1->title != ob2->title
228 || ob1->msg != ob2->msg 214 || ob1->msg != ob2->msg
229 || ob1->weight != ob2->weight 215 || ob1->weight != ob2->weight
230 || ob1->attacktype != ob2->attacktype 216 || ob1->attacktype != ob2->attacktype
231 || ob1->magic != ob2->magic 217 || ob1->magic != ob2->magic
232 || ob1->slaying != ob2->slaying 218 || ob1->slaying != ob2->slaying
233 || ob1->skill != ob2->skill 219 || ob1->skill != ob2->skill
234 || ob1->value != ob2->value 220 || ob1->value != ob2->value
235 || ob1->animation_id != ob2->animation_id 221 || ob1->animation_id != ob2->animation_id
222 || (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependent on each other
236 || ob1->client_type != ob2->client_type 223 || ob1->client_type != ob2->client_type
237 || ob1->materialname != ob2->materialname 224 || ob1->materialname != ob2->materialname
238 || ob1->lore != ob2->lore 225 || ob1->lore != ob2->lore
239 || ob1->subtype != ob2->subtype 226 || ob1->subtype != ob2->subtype
240 || ob1->move_type != ob2->move_type 227 || ob1->move_type != ob2->move_type
334 321
335// find player who can see this object 322// find player who can see this object
336object * 323object *
337object::visible_to () const 324object::visible_to () const
338{ 325{
339 if (!flag [FLAG_REMOVED]) 326 if (client_visible () && !flag [FLAG_REMOVED])
340 { 327 {
341 // see if we are in a container of sorts 328 // see if we are in a container of sorts
342 if (env) 329 if (env)
343 { 330 {
344 // the player inventory itself is always visible 331 // the player inventory itself is always visible
358 else 345 else
359 { 346 {
360 // maybe there is a player standing on the same mapspace 347 // maybe there is a player standing on the same mapspace
361 // this will catch the case where "this" is a player 348 // this will catch the case where "this" is a player
362 if (object *pl = ms ().player ()) 349 if (object *pl = ms ().player ())
350 if ((!pl->container && pl->contr->ns && !pl->contr->ns->update_look)
351 || this == pl->container)
363 return pl; 352 return pl;
364 } 353 }
365 } 354 }
366 355
367 return 0; 356 return 0;
368} 357}
369 358
370// adjust weight per container type ("of holding") 359// adjust weight per container type ("of holding")
371static sint32 360static sint32
372weight_adjust (object *op, sint32 weight) 361weight_adjust_for (object *op, sint32 weight)
373{ 362{
374 return op->type == CONTAINER 363 return op->type == CONTAINER
375 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str) 364 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str)
376 : weight; 365 : weight;
377} 366}
383static void 372static void
384adjust_weight (object *op, sint32 weight) 373adjust_weight (object *op, sint32 weight)
385{ 374{
386 while (op) 375 while (op)
387 { 376 {
377 // adjust by actual difference to account for rounding errors
378 // i.e. (w2 - w1) / f != w2 / f - w1 / f and the latter is correct
388 weight = weight_adjust (op, weight); 379 weight = weight_adjust_for (op, op->carrying)
380 - weight_adjust_for (op, op->carrying - weight);
389 381
390 if (!weight) 382 if (!weight)
391 return; 383 return;
392 384
393 op->carrying += weight; 385 op->carrying += weight;
416 op->update_weight (); 408 op->update_weight ();
417 409
418 sum += op->total_weight (); 410 sum += op->total_weight ();
419 } 411 }
420 412
421 sum = weight_adjust (this, sum); 413 sum = weight_adjust_for (this, sum);
422 414
423 if (sum != carrying) 415 if (sum != carrying)
424 { 416 {
425 carrying = sum; 417 carrying = sum;
426 418
488 */ 480 */
489object * 481object *
490find_object_name (const char *str) 482find_object_name (const char *str)
491{ 483{
492 shstr_cmp str_ (str); 484 shstr_cmp str_ (str);
493 object *op;
494 485
486 if (str_)
495 for_all_objects (op) 487 for_all_objects (op)
496 if (op->name == str_) 488 if (op->name == str_)
497 break; 489 return op;
498 490
499 return op; 491 return 0;
500} 492}
501 493
502/* 494/*
503 * Sets the owner and sets the skill and exp pointers to owner's current 495 * Sets the owner and sets the skill and exp pointers to owner's current
504 * skill and experience objects. 496 * skill and experience objects.
602 } 594 }
603 595
604 op->key_values = 0; 596 op->key_values = 0;
605} 597}
606 598
607object & 599/*
608object::operator =(const object &src) 600 * copy_to first frees everything allocated by the dst object,
601 * and then copies the contents of itself into the second
602 * object, allocating what needs to be allocated. Basically, any
603 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
604 * if the first object is freed, the pointers in the new object
605 * will point at garbage.
606 */
607void
608object::copy_to (object *dst)
609{ 609{
610 bool is_freed = flag [FLAG_FREED]; 610 dst->remove ();
611 bool is_removed = flag [FLAG_REMOVED];
612
613 *(object_copy *)this = src; 611 *(object_copy *)dst = *this;
614
615 flag [FLAG_FREED] = is_freed;
616 flag [FLAG_REMOVED] = is_removed; 612 dst->flag [FLAG_REMOVED] = true;
617 613
618 /* Copy over key_values, if any. */ 614 /* Copy over key_values, if any. */
619 if (src.key_values) 615 if (key_values)
620 { 616 {
621 key_value *tail = 0; 617 key_value *tail = 0;
622 key_values = 0; 618 dst->key_values = 0;
623 619
624 for (key_value *i = src.key_values; i; i = i->next) 620 for (key_value *i = key_values; i; i = i->next)
625 { 621 {
626 key_value *new_link = new key_value; 622 key_value *new_link = new key_value;
627 623
628 new_link->next = 0; 624 new_link->next = 0;
629 new_link->key = i->key; 625 new_link->key = i->key;
630 new_link->value = i->value; 626 new_link->value = i->value;
631 627
632 /* Try and be clever here, too. */ 628 /* Try and be clever here, too. */
633 if (!key_values) 629 if (!dst->key_values)
634 { 630 {
635 key_values = new_link; 631 dst->key_values = new_link;
636 tail = new_link; 632 tail = new_link;
637 } 633 }
638 else 634 else
639 { 635 {
640 tail->next = new_link; 636 tail->next = new_link;
641 tail = new_link; 637 tail = new_link;
642 } 638 }
643 } 639 }
644 } 640 }
645}
646
647/*
648 * copy_to first frees everything allocated by the dst object,
649 * and then copies the contents of itself into the second
650 * object, allocating what needs to be allocated. Basically, any
651 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
652 * if the first object is freed, the pointers in the new object
653 * will point at garbage.
654 */
655void
656object::copy_to (object *dst)
657{
658 *dst = *this;
659 641
660 if (speed < 0) 642 if (speed < 0)
661 dst->speed_left -= rndm (); 643 dst->speed_left -= rndm ();
662 644
663 dst->set_speed (dst->speed); 645 dst->set_speed (dst->speed);
685object * 667object *
686object::clone () 668object::clone ()
687{ 669{
688 object *neu = create (); 670 object *neu = create ();
689 copy_to (neu); 671 copy_to (neu);
672 neu->map = map; // not copied by copy_to
690 return neu; 673 return neu;
691} 674}
692 675
693/* 676/*
694 * If an object with the IS_TURNABLE() flag needs to be turned due 677 * If an object with the IS_TURNABLE() flag needs to be turned due
745 * UP_OBJ_FACE: only the objects face has changed. 728 * UP_OBJ_FACE: only the objects face has changed.
746 */ 729 */
747void 730void
748update_object (object *op, int action) 731update_object (object *op, int action)
749{ 732{
750 if (op == NULL) 733 if (!op)
751 { 734 {
752 /* this should never happen */ 735 /* this should never happen */
753 LOG (llevDebug, "update_object() called for NULL object.\n"); 736 LOG (llevError | logBacktrace, "update_object() called for NULL object.\n");
754 return; 737 return;
755 } 738 }
756 739
757 if (op->env) 740 if (!op->is_on_map ())
758 { 741 {
759 /* Animation is currently handled by client, so nothing 742 /* Animation is currently handled by client, so nothing
760 * to do in this case. 743 * to do in this case.
761 */ 744 */
762 return; 745 return;
763 } 746 }
764
765 /* If the map is saving, don't do anything as everything is
766 * going to get freed anyways.
767 */
768 if (!op->map || op->map->in_memory == MAP_SAVING)
769 return;
770 747
771 /* make sure the object is within map boundaries */ 748 /* make sure the object is within map boundaries */
772 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height) 749 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
773 { 750 {
774 LOG (llevError, "update_object() called for object out of map!\n"); 751 LOG (llevError, "update_object() called for object out of map!\n");
929 * drop on that space. 906 * drop on that space.
930 */ 907 */
931 if (!drop_to_ground 908 if (!drop_to_ground
932 || !map 909 || !map
933 || map->in_memory != MAP_ACTIVE 910 || map->in_memory != MAP_ACTIVE
934 || map->nodrop 911 || map->no_drop
935 || ms ().move_block == MOVE_ALL) 912 || ms ().move_block == MOVE_ALL)
936 { 913 {
937 while (inv) 914 while (inv)
938 { 915 {
939 inv->destroy_inv (false); 916 inv->destroy_inv (false);
964 object *op = new object; 941 object *op = new object;
965 op->link (); 942 op->link ();
966 return op; 943 return op;
967} 944}
968 945
946static struct freed_map : maptile
947{
948 freed_map ()
949 {
950 path = "<freed objects map>";
951 name = "/internal/freed_objects_map";
952 width = 3;
953 height = 3;
954 no_drop = 1;
955 no_reset = 1;
956
957 alloc ();
958 in_memory = MAP_ACTIVE;
959 }
960
961 ~freed_map ()
962 {
963 destroy ();
964 }
965} freed_map; // freed objects are moved here to avoid crashes
966
969void 967void
970object::do_destroy () 968object::do_destroy ()
971{ 969{
972 if (flag [FLAG_IS_LINKED]) 970 if (flag [FLAG_IS_LINKED])
973 remove_button_link (this); 971 remove_button_link (this);
983 unlink (); 981 unlink ();
984 982
985 flag [FLAG_FREED] = 1; 983 flag [FLAG_FREED] = 1;
986 984
987 // hack to ensure that freed objects still have a valid map 985 // hack to ensure that freed objects still have a valid map
988 {
989 static maptile *freed_map; // freed objects are moved here to avoid crashes
990
991 if (!freed_map)
992 {
993 freed_map = new maptile;
994
995 freed_map->path = "<freed objects map>";
996 freed_map->name = "/internal/freed_objects_map";
997 freed_map->width = 3;
998 freed_map->height = 3;
999 freed_map->nodrop = 1;
1000
1001 freed_map->alloc ();
1002 freed_map->in_memory = MAP_ACTIVE;
1003 }
1004
1005 map = freed_map; 986 map = &freed_map;
1006 x = 1; 987 x = 1;
1007 y = 1; 988 y = 1;
1008 }
1009 989
1010 if (more) 990 if (more)
1011 { 991 {
1012 more->destroy (); 992 more->destroy ();
1013 more = 0; 993 more = 0;
1030 1010
1031 if (!is_head () && !head->destroyed ()) 1011 if (!is_head () && !head->destroyed ())
1032 { 1012 {
1033 LOG (llevError | logBacktrace, "tried to destroy the tail of an object"); 1013 LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
1034 head->destroy (destroy_inventory); 1014 head->destroy (destroy_inventory);
1015 return;
1035 } 1016 }
1036 1017
1037 destroy_inv (!destroy_inventory); 1018 destroy_inv (!destroy_inventory);
1038 1019
1039 if (is_head ()) 1020 if (is_head ())
1061 if (flag [FLAG_REMOVED]) 1042 if (flag [FLAG_REMOVED])
1062 return; 1043 return;
1063 1044
1064 INVOKE_OBJECT (REMOVE, this); 1045 INVOKE_OBJECT (REMOVE, this);
1065 1046
1066 if (object *pl = visible_to ())
1067 esrv_del_item (pl->contr, count);
1068
1069 flag [FLAG_REMOVED] = true; 1047 flag [FLAG_REMOVED] = true;
1070 1048
1071 if (more) 1049 if (more)
1072 more->remove (); 1050 more->remove ();
1073 1051
1075 * In this case, the object to be removed is in someones 1053 * In this case, the object to be removed is in someones
1076 * inventory. 1054 * inventory.
1077 */ 1055 */
1078 if (env) 1056 if (env)
1079 { 1057 {
1058 flag [FLAG_REMOVED] = false; // hack around the issue of visible_to checking flag_removed
1059 if (object *pl = visible_to ())
1060 esrv_del_item (pl->contr, count);
1061 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
1062
1080 adjust_weight (env, -total_weight ()); 1063 adjust_weight (env, -total_weight ());
1081
1082 *(above ? &above->below : &env->inv) = below;
1083
1084 if (below)
1085 below->above = above;
1086 1064
1087 /* we set up values so that it could be inserted into 1065 /* we set up values so that it could be inserted into
1088 * the map, but we don't actually do that - it is up 1066 * the map, but we don't actually do that - it is up
1089 * to the caller to decide what we want to do. 1067 * to the caller to decide what we want to do.
1090 */ 1068 */
1091 map = env->map; 1069 map = env->map;
1092 x = env->x; 1070 x = env->x;
1093 y = env->y; 1071 y = env->y;
1072
1073 // make sure cmov optimisation is applicable
1074 *(above ? &above->below : &env->inv) = below;
1075 *(below ? &below->above : &above ) = above; // &above is just a dummy
1076
1094 above = 0; 1077 above = 0;
1095 below = 0; 1078 below = 0;
1096 env = 0; 1079 env = 0;
1097 1080
1098 /* NO_FIX_PLAYER is set when a great many changes are being 1081 /* NO_FIX_PLAYER is set when a great many changes are being
1102 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1085 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1103 otmp->update_stats (); 1086 otmp->update_stats ();
1104 } 1087 }
1105 else if (map) 1088 else if (map)
1106 { 1089 {
1107 if (type == PLAYER)
1108 {
1109 // leaving a spot always closes any open container on the ground
1110 if (container && !container->env)
1111 // this causes spurious floorbox updates, but it ensures
1112 // that the CLOSE event is being sent.
1113 close_container ();
1114
1115 --map->players;
1116 map->touch ();
1117 }
1118
1119 map->dirty = true; 1090 map->dirty = true;
1120 mapspace &ms = this->ms (); 1091 mapspace &ms = this->ms ();
1121 1092
1093 if (object *pl = ms.player ())
1094 {
1095 if (type == PLAYER) // this == pl(!)
1096 {
1097 // leaving a spot always closes any open container on the ground
1098 if (container && !container->env)
1099 // this causes spurious floorbox updates, but it ensures
1100 // that the CLOSE event is being sent.
1101 close_container ();
1102
1103 --map->players;
1104 map->touch ();
1105 }
1106 else if (pl->container == this)
1107 {
1108 // removing a container should close it
1109 close_container ();
1110 }
1111
1112 esrv_del_item (pl->contr, count);
1113 }
1114
1122 /* link the object above us */ 1115 /* link the object above us */
1123 if (above) 1116 // re-link, make sure compiler can easily use cmove
1124 above->below = below; 1117 *(above ? &above->below : &ms.top) = below;
1125 else 1118 *(below ? &below->above : &ms.bot) = above;
1126 ms.top = below; /* we were top, set new top */
1127
1128 /* Relink the object below us, if there is one */
1129 if (below)
1130 below->above = above;
1131 else
1132 {
1133 /* Nothing below, which means we need to relink map object for this space
1134 * use translated coordinates in case some oddness with map tiling is
1135 * evident
1136 */
1137 if (GET_MAP_OB (map, x, y) != this)
1138 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1139
1140 ms.bot = above; /* goes on above it. */
1141 }
1142 1119
1143 above = 0; 1120 above = 0;
1144 below = 0; 1121 below = 0;
1145 1122
1146 if (map->in_memory == MAP_SAVING) 1123 if (map->in_memory == MAP_SAVING)
1156 * appropriately. 1133 * appropriately.
1157 */ 1134 */
1158 pl->close_container (); 1135 pl->close_container ();
1159 1136
1160 //TODO: the floorbox prev/next might need updating 1137 //TODO: the floorbox prev/next might need updating
1161 esrv_del_item (pl->contr, count); 1138 //esrv_del_item (pl->contr, count);
1139 //TODO: update floorbox to preserve ordering
1140 if (pl->contr->ns)
1141 pl->contr->ns->floorbox_update ();
1162 } 1142 }
1163 1143
1164 for (tmp = ms.bot; tmp; tmp = tmp->above) 1144 for (tmp = ms.bot; tmp; tmp = tmp->above)
1165 { 1145 {
1166 /* No point updating the players look faces if he is the object 1146 /* No point updating the players look faces if he is the object
1258 * job preparing multi-part monsters. 1238 * job preparing multi-part monsters.
1259 */ 1239 */
1260object * 1240object *
1261insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1241insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1262{ 1242{
1243 op->remove ();
1244
1263 for (object *tmp = op->head_ (); tmp; tmp = tmp->more) 1245 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1264 { 1246 {
1265 tmp->x = x + tmp->arch->x; 1247 tmp->x = x + tmp->arch->x;
1266 tmp->y = y + tmp->arch->y; 1248 tmp->y = y + tmp->arch->y;
1267 } 1249 }
1290 * just 'op' otherwise 1272 * just 'op' otherwise
1291 */ 1273 */
1292object * 1274object *
1293insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1275insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1294{ 1276{
1295 assert (!op->flag [FLAG_FREED]); 1277 if (op->is_on_map ())
1278 {
1279 LOG (llevError, "insert_ob_in_map called for object already on map");
1280 abort ();
1281 }
1296 1282
1283 if (op->env)
1284 {
1285 LOG (llevError, "insert_ob_in_map called for object in an inventory (proceeding)");
1297 op->remove (); 1286 op->remove ();
1287 }
1288
1289 if (op->face && !face_info (op->face))//D TODO: remove soon
1290 {//D
1291 LOG (llevError | logBacktrace, "op->face out of bounds: %s", op->debug_desc ());//D
1292 op->face = 1;//D
1293 }//D
1298 1294
1299 /* Ideally, the caller figures this out. However, it complicates a lot 1295 /* Ideally, the caller figures this out. However, it complicates a lot
1300 * of areas of callers (eg, anything that uses find_free_spot would now 1296 * of areas of callers (eg, anything that uses find_free_spot would now
1301 * need extra work 1297 * need extra work
1302 */ 1298 */
1303 if (!xy_normalise (m, op->x, op->y)) 1299 if (!xy_normalise (m, op->x, op->y))
1304 { 1300 {
1305 op->destroy (1); 1301 op->head_ ()->destroy (1);// remove head_ once all tail object destroyers found
1306 return 0; 1302 return 0;
1307 } 1303 }
1308 1304
1309 if (object *more = op->more) 1305 if (object *more = op->more)
1310 if (!insert_ob_in_map (more, m, originator, flag)) 1306 if (!insert_ob_in_map (more, m, originator, flag))
1319 */ 1315 */
1320 if (op->nrof && !(flag & INS_NO_MERGE)) 1316 if (op->nrof && !(flag & INS_NO_MERGE))
1321 for (object *tmp = ms.bot; tmp; tmp = tmp->above) 1317 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1322 if (object::can_merge (op, tmp)) 1318 if (object::can_merge (op, tmp))
1323 { 1319 {
1324 // TODO: we atcually want to update tmp, not op, 1320 // TODO: we actually want to update tmp, not op,
1325 // but some caller surely breaks when we return tmp 1321 // but some caller surely breaks when we return tmp
1326 // from here :/ 1322 // from here :/
1327 op->nrof += tmp->nrof; 1323 op->nrof += tmp->nrof;
1328 tmp->destroy (1); 1324 tmp->destroy (1);
1329 } 1325 }
1340 { 1336 {
1341 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n"); 1337 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1342 abort (); 1338 abort ();
1343 } 1339 }
1344 1340
1341 if (!originator->is_on_map ())
1342 LOG (llevDebug | logBacktrace, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
1343 op->debug_desc (), originator->debug_desc ());
1344
1345 op->above = originator; 1345 op->above = originator;
1346 op->below = originator->below; 1346 op->below = originator->below;
1347
1348 if (op->below)
1349 op->below->above = op;
1350 else
1351 ms.bot = op;
1352
1353 /* since *below* originator, no need to update top */
1354 originator->below = op; 1347 originator->below = op;
1348
1349 *(op->below ? &op->below->above : &ms.bot) = op;
1355 } 1350 }
1356 else 1351 else
1357 { 1352 {
1358 object *top, *floor = NULL; 1353 object *floor = 0;
1359 1354 object *top = ms.top;
1360 top = ms.bot;
1361 1355
1362 /* If there are other objects, then */ 1356 /* If there are other objects, then */
1363 if (top) 1357 if (top)
1364 { 1358 {
1365 object *last = 0;
1366
1367 /* 1359 /*
1368 * If there are multiple objects on this space, we do some trickier handling. 1360 * If there are multiple objects on this space, we do some trickier handling.
1369 * We've already dealt with merging if appropriate. 1361 * We've already dealt with merging if appropriate.
1370 * Generally, we want to put the new object on top. But if 1362 * Generally, we want to put the new object on top. But if
1371 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last 1363 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
1374 * once we get to them. This reduces the need to traverse over all of 1366 * once we get to them. This reduces the need to traverse over all of
1375 * them when adding another one - this saves quite a bit of cpu time 1367 * them when adding another one - this saves quite a bit of cpu time
1376 * when lots of spells are cast in one area. Currently, it is presumed 1368 * when lots of spells are cast in one area. Currently, it is presumed
1377 * that flying non pickable objects are spell objects. 1369 * that flying non pickable objects are spell objects.
1378 */ 1370 */
1379 for (top = ms.bot; top; top = top->above) 1371 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1380 { 1372 {
1381 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1373 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) || QUERY_FLAG (tmp, FLAG_OVERLAY_FLOOR))
1382 floor = top; 1374 floor = tmp;
1383 1375
1384 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1376 if (QUERY_FLAG (tmp, FLAG_NO_PICK) && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (tmp, FLAG_IS_FLOOR))
1385 { 1377 {
1386 /* We insert above top, so we want this object below this */ 1378 /* We insert above top, so we want this object below this */
1387 top = top->below; 1379 top = tmp->below;
1388 break; 1380 break;
1389 } 1381 }
1390 1382
1391 last = top; 1383 top = tmp;
1392 } 1384 }
1393
1394 /* Don't want top to be NULL, so set it to the last valid object */
1395 top = last;
1396 1385
1397 /* We let update_position deal with figuring out what the space 1386 /* We let update_position deal with figuring out what the space
1398 * looks like instead of lots of conditions here. 1387 * looks like instead of lots of conditions here.
1399 * makes things faster, and effectively the same result. 1388 * makes things faster, and effectively the same result.
1400 */ 1389 */
1407 */ 1396 */
1408 if (!(flag & INS_ON_TOP) 1397 if (!(flag & INS_ON_TOP)
1409 && ms.flags () & P_BLOCKSVIEW 1398 && ms.flags () & P_BLOCKSVIEW
1410 && (op->face && !faces [op->face].visibility)) 1399 && (op->face && !faces [op->face].visibility))
1411 { 1400 {
1401 object *last;
1402
1412 for (last = top; last != floor; last = last->below) 1403 for (last = top; last != floor; last = last->below)
1413 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1404 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1414 break; 1405 break;
1415 1406
1416 /* Check to see if we found the object that blocks view, 1407 /* Check to see if we found the object that blocks view,
1424 } /* If objects on this space */ 1415 } /* If objects on this space */
1425 1416
1426 if (flag & INS_ABOVE_FLOOR_ONLY) 1417 if (flag & INS_ABOVE_FLOOR_ONLY)
1427 top = floor; 1418 top = floor;
1428 1419
1429 /* Top is the object that our object (op) is going to get inserted above. 1420 // insert object above top, or bottom-most if top = 0
1430 */
1431
1432 /* First object on this space */
1433 if (!top) 1421 if (!top)
1434 { 1422 {
1423 op->below = 0;
1435 op->above = ms.bot; 1424 op->above = ms.bot;
1436
1437 if (op->above)
1438 op->above->below = op;
1439
1440 op->below = 0;
1441 ms.bot = op; 1425 ms.bot = op;
1426
1427 *(op->above ? &op->above->below : &ms.top) = op;
1442 } 1428 }
1443 else 1429 else
1444 { /* get inserted into the stack above top */ 1430 {
1445 op->above = top->above; 1431 op->above = top->above;
1446
1447 if (op->above)
1448 op->above->below = op; 1432 top->above = op;
1449 1433
1450 op->below = top; 1434 op->below = top;
1451 top->above = op; 1435 *(op->above ? &op->above->below : &ms.top) = op;
1452 } 1436 }
1453 1437 }
1454 if (!op->above)
1455 ms.top = op;
1456 } /* else not INS_BELOW_ORIGINATOR */
1457 1438
1458 if (op->type == PLAYER) 1439 if (op->type == PLAYER)
1459 { 1440 {
1460 op->contr->do_los = 1; 1441 op->contr->do_los = 1;
1461 ++op->map->players; 1442 ++op->map->players;
1464 1445
1465 op->map->dirty = true; 1446 op->map->dirty = true;
1466 1447
1467 if (object *pl = ms.player ()) 1448 if (object *pl = ms.player ())
1468 //TODO: the floorbox prev/next might need updating 1449 //TODO: the floorbox prev/next might need updating
1469 esrv_send_item (pl, op); 1450 //esrv_send_item (pl, op);
1451 //TODO: update floorbox to preserve ordering
1452 if (pl->contr->ns)
1453 pl->contr->ns->floorbox_update ();
1470 1454
1471 /* If this object glows, it may affect lighting conditions that are 1455 /* If this object glows, it may affect lighting conditions that are
1472 * visible to others on this map. But update_all_los is really 1456 * visible to others on this map. But update_all_los is really
1473 * an inefficient way to do this, as it means los for all players 1457 * an inefficient way to do this, as it means los for all players
1474 * on the map will get recalculated. The players could very well 1458 * on the map will get recalculated. The players could very well
1558 1542
1559 nrof -= nr; 1543 nrof -= nr;
1560 1544
1561 if (nrof) 1545 if (nrof)
1562 { 1546 {
1563 adjust_weight (env, -weight * nr); // carrying == 0 1547 adjust_weight (env, -weight * max (1, nr)); // carrying == 0
1564 1548
1565 if (object *pl = visible_to ()) 1549 if (object *pl = visible_to ())
1566 esrv_update_item (UPD_NROF, pl, this); 1550 esrv_update_item (UPD_NROF, pl, this);
1567 1551
1568 return true; 1552 return true;
1569 } 1553 }
1570 else 1554 else
1571 { 1555 {
1572 destroy (1); 1556 destroy ();
1573 return false; 1557 return false;
1574 } 1558 }
1575} 1559}
1576 1560
1577/* 1561/*
1594 } 1578 }
1595 else 1579 else
1596 { 1580 {
1597 decrease (nr); 1581 decrease (nr);
1598 1582
1599 object *op = object_create_clone (this); 1583 object *op = deep_clone ();
1600 op->nrof = nr; 1584 op->nrof = nr;
1601 return op; 1585 return op;
1602 } 1586 }
1603} 1587}
1604 1588
1825 LOG (llevError, "Present_arch called outside map.\n"); 1809 LOG (llevError, "Present_arch called outside map.\n");
1826 return NULL; 1810 return NULL;
1827 } 1811 }
1828 1812
1829 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above) 1813 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1830 if (tmp->arch == at) 1814 if (tmp->arch->archname == at->archname)
1831 return tmp; 1815 return tmp;
1832 1816
1833 return NULL; 1817 return NULL;
1834} 1818}
1835 1819
1899 * The first matching object is returned, or NULL if none. 1883 * The first matching object is returned, or NULL if none.
1900 */ 1884 */
1901object * 1885object *
1902present_arch_in_ob (const archetype *at, const object *op) 1886present_arch_in_ob (const archetype *at, const object *op)
1903{ 1887{
1904 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below) 1888 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1905 if (tmp->arch == at) 1889 if (tmp->arch->archname == at->archname)
1906 return tmp; 1890 return tmp;
1907 1891
1908 return NULL; 1892 return NULL;
1909} 1893}
1910 1894
2319 2303
2320/* 2304/*
2321 * create clone from object to another 2305 * create clone from object to another
2322 */ 2306 */
2323object * 2307object *
2324object_create_clone (object *asrc) 2308object::deep_clone ()
2325{ 2309{
2326 object *dst = 0, *tmp, *src, *prev, *item; 2310 assert (("deep_clone called on non-head object", is_head ()));
2327 2311
2328 if (!asrc) 2312 object *dst = clone ();
2329 return 0;
2330 2313
2331 src = asrc->head_ (); 2314 object *prev = dst;
2332
2333 prev = 0;
2334 for (object *part = src; part; part = part->more) 2315 for (object *part = this->more; part; part = part->more)
2335 { 2316 {
2336 tmp = part->clone (); 2317 object *tmp = part->clone ();
2337 tmp->x -= src->x;
2338 tmp->y -= src->y;
2339
2340 if (!part->head)
2341 {
2342 dst = tmp;
2343 tmp->head = 0;
2344 }
2345 else
2346 tmp->head = dst; 2318 tmp->head = dst;
2347
2348 tmp->more = 0;
2349
2350 if (prev)
2351 prev->more = tmp; 2319 prev->more = tmp;
2352
2353 prev = tmp; 2320 prev = tmp;
2354 } 2321 }
2355 2322
2356 for (item = src->inv; item; item = item->below) 2323 for (object *item = inv; item; item = item->below)
2357 insert_ob_in_ob (object_create_clone (item), dst); 2324 insert_ob_in_ob (item->deep_clone (), dst);
2358 2325
2359 return dst; 2326 return dst;
2360} 2327}
2361 2328
2362/* This returns the first object in who's inventory that 2329/* This returns the first object in who's inventory that
2371 return tmp; 2338 return tmp;
2372 2339
2373 return 0; 2340 return 0;
2374} 2341}
2375 2342
2376/* If ob has a field named key, return the link from the list, 2343const shstr &
2377 * otherwise return NULL. 2344object::kv_get (const shstr &key) const
2378 *
2379 * key must be a passed in shared string - otherwise, this won't
2380 * do the desired thing.
2381 */
2382key_value *
2383get_ob_key_link (const object *ob, const char *key)
2384{ 2345{
2385 for (key_value *link = ob->key_values; link; link = link->next) 2346 for (key_value *kv = key_values; kv; kv = kv->next)
2386 if (link->key == key) 2347 if (kv->key == key)
2387 return link;
2388
2389 return 0;
2390}
2391
2392/*
2393 * Returns the value of op has an extra_field for key, or NULL.
2394 *
2395 * The argument doesn't need to be a shared string.
2396 *
2397 * The returned string is shared.
2398 */
2399const char *
2400get_ob_key_value (const object *op, const char *const key)
2401{
2402 key_value *link;
2403 shstr_cmp canonical_key (key);
2404
2405 if (!canonical_key)
2406 {
2407 /* 1. There being a field named key on any object
2408 * implies there'd be a shared string to find.
2409 * 2. Since there isn't, no object has this field.
2410 * 3. Therefore, *this* object doesn't have this field.
2411 */
2412 return 0;
2413 }
2414
2415 /* This is copied from get_ob_key_link() above -
2416 * only 4 lines, and saves the function call overhead.
2417 */
2418 for (link = op->key_values; link; link = link->next)
2419 if (link->key == canonical_key)
2420 return link->value; 2348 return kv->value;
2421 2349
2422 return 0; 2350 return shstr_null;
2423} 2351}
2424 2352
2425/* 2353void
2426 * Updates the canonical_key in op to value. 2354object::kv_set (const shstr &key, const shstr &value)
2427 *
2428 * canonical_key is a shared string (value doesn't have to be).
2429 *
2430 * Unless add_key is TRUE, it won't add fields, only change the value of existing
2431 * keys.
2432 *
2433 * Returns TRUE on success.
2434 */
2435int
2436set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2437{ 2355{
2438 key_value *field = NULL, *last = NULL; 2356 for (key_value *kv = key_values; kv; kv = kv->next)
2439 2357 if (kv->key == key)
2440 for (field = op->key_values; field != NULL; field = field->next)
2441 {
2442 if (field->key != canonical_key)
2443 { 2358 {
2444 last = field; 2359 kv->value = value;
2445 continue; 2360 return;
2446 } 2361 }
2447 2362
2448 if (value) 2363 key_value *kv = new key_value;
2449 field->value = value; 2364
2450 else 2365 kv->next = key_values;
2366 kv->key = key;
2367 kv->value = value;
2368
2369 key_values = kv;
2370}
2371
2372void
2373object::kv_del (const shstr &key)
2374{
2375 for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
2376 if ((*kvp)->key == key)
2451 { 2377 {
2452 /* Basically, if the archetype has this key set, 2378 key_value *kv = *kvp;
2453 * we need to store the null value so when we save 2379 *kvp = (*kvp)->next;
2454 * it, we save the empty value so that when we load, 2380 delete kv;
2455 * we get this value back again. 2381 return;
2456 */
2457 if (get_ob_key_link (op->arch, canonical_key))
2458 field->value = 0;
2459 else
2460 {
2461 if (last)
2462 last->next = field->next;
2463 else
2464 op->key_values = field->next;
2465
2466 delete field;
2467 }
2468 } 2382 }
2469 return TRUE;
2470 }
2471 /* IF we get here, key doesn't exist */
2472
2473 /* No field, we'll have to add it. */
2474
2475 if (!add_key)
2476 return FALSE;
2477
2478 /* There isn't any good reason to store a null
2479 * value in the key/value list. If the archetype has
2480 * this key, then we should also have it, so shouldn't
2481 * be here. If user wants to store empty strings,
2482 * should pass in ""
2483 */
2484 if (value == NULL)
2485 return TRUE;
2486
2487 field = new key_value;
2488
2489 field->key = canonical_key;
2490 field->value = value;
2491 /* Usual prepend-addition. */
2492 field->next = op->key_values;
2493 op->key_values = field;
2494
2495 return TRUE;
2496}
2497
2498/*
2499 * Updates the key in op to value.
2500 *
2501 * If add_key is FALSE, this will only update existing keys,
2502 * and not add new ones.
2503 * In general, should be little reason FALSE is ever passed in for add_key
2504 *
2505 * Returns TRUE on success.
2506 */
2507int
2508set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2509{
2510 shstr key_ (key);
2511
2512 return set_ob_key_value_s (op, key_, value, add_key);
2513} 2383}
2514 2384
2515object::depth_iterator::depth_iterator (object *container) 2385object::depth_iterator::depth_iterator (object *container)
2516: iterator_base (container) 2386: iterator_base (container)
2517{ 2387{
2567{ 2437{
2568 char flagdesc[512]; 2438 char flagdesc[512];
2569 char info2[256 * 4]; 2439 char info2[256 * 4];
2570 char *p = info; 2440 char *p = info;
2571 2441
2572 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s,flags:[%s],type:%d}", 2442 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2573 count, 2443 count,
2574 uuid.c_str (), 2444 uuid.c_str (),
2575 &name, 2445 &name,
2576 title ? "\",title:\"" : "", 2446 title ? ",title:\"" : "",
2577 title ? (const char *)title : "", 2447 title ? (const char *)title : "",
2448 title ? "\"" : "",
2578 flag_desc (flagdesc, 512), type); 2449 flag_desc (flagdesc, 512), type);
2579 2450
2580 if (!flag[FLAG_REMOVED] && env) 2451 if (!flag[FLAG_REMOVED] && env)
2581 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2452 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2582 2453
2615object::open_container (object *new_container) 2486object::open_container (object *new_container)
2616{ 2487{
2617 if (container == new_container) 2488 if (container == new_container)
2618 return; 2489 return;
2619 2490
2620 if (object *old_container = container) 2491 object *old_container = container;
2492
2493 if (old_container)
2621 { 2494 {
2622 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this))) 2495 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))
2623 return; 2496 return;
2624 2497
2625#if 0 2498#if 0
2627 if (object *closer = old_container->inv) 2500 if (object *closer = old_container->inv)
2628 if (closer->type == CLOSE_CON) 2501 if (closer->type == CLOSE_CON)
2629 closer->destroy (); 2502 closer->destroy ();
2630#endif 2503#endif
2631 2504
2505 // make sure the container is available
2506 esrv_send_item (this, old_container);
2507
2632 old_container->flag [FLAG_APPLIED] = false; 2508 old_container->flag [FLAG_APPLIED] = false;
2633 container = 0; 2509 container = 0;
2634 2510
2511 // client needs item update to make it work, client bug requires this to be separate
2635 esrv_update_item (UPD_FLAGS, this, old_container); 2512 esrv_update_item (UPD_FLAGS, this, old_container);
2513
2636 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container)); 2514 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container));
2637 play_sound (sound_find ("chest_close")); 2515 play_sound (sound_find ("chest_close"));
2638 } 2516 }
2639 2517
2640 if (new_container) 2518 if (new_container)
2653 } 2531 }
2654#endif 2532#endif
2655 2533
2656 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container)); 2534 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container));
2657 2535
2536 // make sure the container is available, client bug requires this to be separate
2537 esrv_send_item (this, new_container);
2538
2658 new_container->flag [FLAG_APPLIED] = true; 2539 new_container->flag [FLAG_APPLIED] = true;
2659 container = new_container; 2540 container = new_container;
2660 2541
2542 // client needs flag change
2661 esrv_update_item (UPD_FLAGS, this, new_container); 2543 esrv_update_item (UPD_FLAGS, this, new_container);
2662 esrv_send_inventory (this, new_container); 2544 esrv_send_inventory (this, new_container);
2663 play_sound (sound_find ("chest_open")); 2545 play_sound (sound_find ("chest_open"));
2664 } 2546 }
2547// else if (!old_container->env && contr && contr->ns)
2548// contr->ns->floorbox_reset ();
2665} 2549}
2666 2550
2667object * 2551object *
2668object::force_find (const shstr name) 2552object::force_find (const shstr name)
2669{ 2553{

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines