ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.46 by root, Thu Sep 14 21:16:11 2006 UTC vs.
Revision 1.78 by root, Fri Dec 22 16:34:00 2006 UTC

1
2/* 1/*
3 CrossFire, A Multiplayer game for X-windows 2 CrossFire, A Multiplayer game for X-windows
4 3
5 Copyright (C) 2001 Mark Wedel & Crossfire Development Team 4 Copyright (C) 2001 Mark Wedel & Crossfire Development Team
6 Copyright (C) 1992 Frank Tore Johansen 5 Copyright (C) 1992 Frank Tore Johansen
17 16
18 You should have received a copy of the GNU General Public License 17 You should have received a copy of the GNU General Public License
19 along with this program; if not, write to the Free Software 18 along with this program; if not, write to the Free Software
20 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 19 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
21 20
22 The authors can be reached via e-mail at crossfire-devel@real-time.com 21 The authors can be reached via e-mail at <crossfire@schmorp.de>
23*/ 22*/
24 23
25/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects. 24/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
26 sub/add_weight will transcend the environment updating the carrying 25 sub/add_weight will transcend the environment updating the carrying
27 variable. */ 26 variable. */
30#include <sys/types.h> 29#include <sys/types.h>
31#include <sys/uio.h> 30#include <sys/uio.h>
32#include <object.h> 31#include <object.h>
33#include <funcpoint.h> 32#include <funcpoint.h>
34#include <loader.h> 33#include <loader.h>
34
35#include <bitset>
35 36
36int nrofallocobjects = 0; 37int nrofallocobjects = 0;
37static UUID uuid; 38static UUID uuid;
38const uint64 UUID_SKIP = 1<<19; 39const uint64 UUID_SKIP = 1<<19;
39 40
105 _exit (1); 106 _exit (1);
106 } 107 }
107 108
108 uuid.seq = uid; 109 uuid.seq = uid;
109 write_uuid (); 110 write_uuid ();
110 LOG (llevDebug, "read UID: %lld\n", uid); 111 LOG (llevDebug, "read UID: %" PRId64 "\n", uid);
111 fclose (fp); 112 fclose (fp);
112} 113}
113 114
114UUID 115UUID
115gen_uuid () 116gen_uuid ()
184 * 185 *
185 * Note that this function appears a lot longer than the macro it 186 * Note that this function appears a lot longer than the macro it
186 * replaces - this is mostly for clarity - a decent compiler should hopefully 187 * replaces - this is mostly for clarity - a decent compiler should hopefully
187 * reduce this to the same efficiency. 188 * reduce this to the same efficiency.
188 * 189 *
189 * Check nrof variable *before* calling CAN_MERGE() 190 * Check nrof variable *before* calling can_merge()
190 * 191 *
191 * Improvements made with merge: Better checking on potion, and also 192 * Improvements made with merge: Better checking on potion, and also
192 * check weight 193 * check weight
193 */ 194 */
194 195
195bool object::can_merge (object *ob1, object *ob2) 196bool object::can_merge_slow (object *ob1, object *ob2)
196{ 197{
197 /* A couple quicksanity checks */ 198 /* A couple quicksanity checks */
198 if ((ob1 == ob2) || (ob1->type != ob2->type)) 199 if (ob1 == ob2
200 || ob1->type != ob2->type
201 || ob1->speed != ob2->speed
202 || ob1->value != ob2->value
203 || ob1->name != ob2->name)
199 return 0; 204 return 0;
200 205
201 if (ob1->speed != ob2->speed) 206 //TODO: this ain't working well, use nicer and correct overflow check
202 return 0;
203
204 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that 207 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that
205 * value could not be stored in a sint32 (which unfortunately sometimes is 208 * value could not be stored in a sint32 (which unfortunately sometimes is
206 * used to store nrof). 209 * used to store nrof).
207 */ 210 */
208 if (ob1->nrof + ob2->nrof >= 1UL << 31) 211 if (ob1->nrof + ob2->nrof >= 1UL << 31)
218 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 221 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
219 222
220 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 223 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
221 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 224 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
222 225
223 226 if ((ob1->flags ^ ob2->flags).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any ()
224 /* the 0x400000 on flags2 is FLAG_INV_LOCK. I don't think something 227 || ob1->arch != ob2->arch
225 * being locked in inventory should prevent merging.
226 * 0x4 in flags3 is CLIENT_SENT
227 */
228 if ((ob1->arch != ob2->arch) ||
229 (ob1->flags[0] != ob2->flags[0]) ||
230 (ob1->flags[1] != ob2->flags[1]) ||
231 ((ob1->flags[2] & ~0x400000) != (ob2->flags[2] & ~0x400000)) ||
232 ((ob1->flags[3] & ~0x4) != (ob2->flags[3] & ~0x4)) ||
233 (ob1->name != ob2->name) || 228 || ob1->name != ob2->name
234 (ob1->title != ob2->title) || 229 || ob1->title != ob2->title
235 (ob1->msg != ob2->msg) || 230 || ob1->msg != ob2->msg
236 (ob1->weight != ob2->weight) || 231 || ob1->weight != ob2->weight
237 (memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist)) != 0) || 232 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
238 (memcmp (&ob1->stats, &ob2->stats, sizeof (ob1->stats)) != 0) || 233 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
239 (ob1->attacktype != ob2->attacktype) || 234 || ob1->attacktype != ob2->attacktype
240 (ob1->magic != ob2->magic) || 235 || ob1->magic != ob2->magic
241 (ob1->slaying != ob2->slaying) || 236 || ob1->slaying != ob2->slaying
242 (ob1->skill != ob2->skill) || 237 || ob1->skill != ob2->skill
243 (ob1->value != ob2->value) || 238 || ob1->value != ob2->value
244 (ob1->animation_id != ob2->animation_id) || 239 || ob1->animation_id != ob2->animation_id
245 (ob1->client_type != ob2->client_type) || 240 || ob1->client_type != ob2->client_type
246 (ob1->materialname != ob2->materialname) || 241 || ob1->materialname != ob2->materialname
247 (ob1->lore != ob2->lore) || 242 || ob1->lore != ob2->lore
248 (ob1->subtype != ob2->subtype) || 243 || ob1->subtype != ob2->subtype
249 (ob1->move_type != ob2->move_type) || 244 || ob1->move_type != ob2->move_type
250 (ob1->move_block != ob2->move_block) || 245 || ob1->move_block != ob2->move_block
251 (ob1->move_allow != ob2->move_allow) || 246 || ob1->move_allow != ob2->move_allow
252 (ob1->move_on != ob2->move_on) || 247 || ob1->move_on != ob2->move_on
253 (ob1->move_off != ob2->move_off) || (ob1->move_slow != ob2->move_slow) || (ob1->move_slow_penalty != ob2->move_slow_penalty)) 248 || ob1->move_off != ob2->move_off
249 || ob1->move_slow != ob2->move_slow
250 || ob1->move_slow_penalty != ob2->move_slow_penalty)
254 return 0; 251 return 0;
255 252
256 /* This is really a spellbook check - really, we should 253 /* This is really a spellbook check - really, we should
257 * check all objects in the inventory. 254 * check all objects in the inventory.
258 */ 255 */
261 /* if one object has inventory but the other doesn't, not equiv */ 258 /* if one object has inventory but the other doesn't, not equiv */
262 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv)) 259 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv))
263 return 0; 260 return 0;
264 261
265 /* Now check to see if the two inventory objects could merge */ 262 /* Now check to see if the two inventory objects could merge */
266 if (!CAN_MERGE (ob1->inv, ob2->inv)) 263 if (!object::can_merge (ob1->inv, ob2->inv))
267 return 0; 264 return 0;
268 265
269 /* inventory ok - still need to check rest of this object to see 266 /* inventory ok - still need to check rest of this object to see
270 * if it is valid. 267 * if it is valid.
271 */ 268 */
355 op = op->env; 352 op = op->env;
356 return op; 353 return op;
357} 354}
358 355
359/* 356/*
360 * Eneq(@csd.uu.se): Since we can have items buried in a character we need
361 * a better check. We basically keeping traversing up until we can't
362 * or find a player.
363 */
364
365object *
366is_player_inv (object *op)
367{
368 for (; op != NULL && op->type != PLAYER; op = op->env)
369 if (op->env == op)
370 op->env = NULL;
371 return op;
372}
373
374/*
375 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump. 357 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
376 * Some error messages. 358 * Some error messages.
377 * The result of the dump is stored in the static global errmsg array. 359 * The result of the dump is stored in the static global errmsg array.
378 */ 360 */
379 361
380void 362char *
381dump_object2 (object *op)
382{
383 errmsg[0] = 0;
384 return;
385 //TODO//D#d#
386#if 0
387 char *cp;
388
389/* object *tmp;*/
390
391 if (op->arch != NULL)
392 {
393 strcat (errmsg, "arch ");
394 strcat (errmsg, op->arch->name ? op->arch->name : "(null)");
395 strcat (errmsg, "\n");
396 if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
397 strcat (errmsg, cp);
398# if 0
399 /* Don't dump player diffs - they are too long, mostly meaningless, and
400 * will overflow the buffer.
401 * Changed so that we don't dump inventory either. This may
402 * also overflow the buffer.
403 */
404 if (op->type != PLAYER && (cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
405 strcat (errmsg, cp);
406 for (tmp = op->inv; tmp; tmp = tmp->below)
407 dump_object2 (tmp);
408# endif
409 strcat (errmsg, "end\n");
410 }
411 else
412 {
413 strcat (errmsg, "Object ");
414 if (op->name == NULL)
415 strcat (errmsg, "(null)");
416 else
417 strcat (errmsg, op->name);
418 strcat (errmsg, "\n");
419# if 0
420 if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
421 strcat (errmsg, cp);
422 for (tmp = op->inv; tmp; tmp = tmp->below)
423 dump_object2 (tmp);
424# endif
425 strcat (errmsg, "end\n");
426 }
427#endif
428}
429
430/*
431 * Dumps an object. Returns output in the static global errmsg array.
432 */
433
434void
435dump_object (object *op) 363dump_object (object *op)
436{ 364{
437 if (op == NULL) 365 if (!op)
438 { 366 return strdup ("[NULLOBJ]");
439 strcpy (errmsg, "[NULL pointer]");
440 return;
441 }
442 errmsg[0] = '\0';
443 dump_object2 (op);
444}
445 367
446void 368 object_freezer freezer;
447dump_all_objects (void) 369 save_object (freezer, op, 3);
448{ 370 return freezer.as_string ();
449 object *op;
450
451 for (op = object::first; op != NULL; op = op->next)
452 {
453 dump_object (op);
454 fprintf (logfile, "Object %d\n:%s\n", op->count, errmsg);
455 }
456} 371}
457 372
458/* 373/*
459 * get_nearest_part(multi-object, object 2) returns the part of the 374 * get_nearest_part(multi-object, object 2) returns the part of the
460 * multi-object 1 which is closest to the second object. 375 * multi-object 1 which is closest to the second object.
480 */ 395 */
481 396
482object * 397object *
483find_object (tag_t i) 398find_object (tag_t i)
484{ 399{
485 object *op;
486
487 for (op = object::first; op != NULL; op = op->next) 400 for (object *op = object::first; op; op = op->next)
488 if (op->count == i) 401 if (op->count == i)
489 break; 402 return op;
403
490 return op; 404 return 0;
491} 405}
492 406
493/* 407/*
494 * Returns the first object which has a name equal to the argument. 408 * Returns the first object which has a name equal to the argument.
495 * Used only by the patch command, but not all that useful. 409 * Used only by the patch command, but not all that useful.
553 } 467 }
554 468
555 op->key_values = 0; 469 op->key_values = 0;
556} 470}
557 471
558void object::clear ()
559{
560 attachable_base::clear ();
561
562 free_key_values (this);
563
564 owner = 0;
565 name = 0;
566 name_pl = 0;
567 title = 0;
568 race = 0;
569 slaying = 0;
570 skill = 0;
571 msg = 0;
572 lore = 0;
573 custom_name = 0;
574 materialname = 0;
575 contr = 0;
576 below = 0;
577 above = 0;
578 inv = 0;
579 container = 0;
580 env = 0;
581 more = 0;
582 head = 0;
583 map = 0;
584 active_next = 0;
585 active_prev = 0;
586
587 memset (static_cast<object_pod *>(this), 0, sizeof (object_pod));
588
589 SET_FLAG (this, FLAG_REMOVED);
590
591 /* What is not cleared is next, prev, and count */
592
593 expmul = 1.0;
594 face = blank_face;
595
596 if (settings.casting_time)
597 casting_time = -1;
598}
599
600void object::clone (object *destination)
601{
602 *(object_copy *)destination = *this;
603 *(object_pod *)destination = *this;
604
605 if (self || cb)
606 INVOKE_OBJECT (CLONE, this, ARG_OBJECT (destination));
607}
608
609/* 472/*
610 * copy object first frees everything allocated by the second object, 473 * copy_to first frees everything allocated by the dst object,
611 * and then copies the contends of the first object into the second 474 * and then copies the contents of itself into the second
612 * object, allocating what needs to be allocated. Basically, any 475 * object, allocating what needs to be allocated. Basically, any
613 * data that is malloc'd needs to be re-malloc/copied. Otherwise, 476 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
614 * if the first object is freed, the pointers in the new object 477 * if the first object is freed, the pointers in the new object
615 * will point at garbage. 478 * will point at garbage.
616 */ 479 */
617void 480void
618copy_object (object *op2, object *op) 481object::copy_to (object *dst)
619{ 482{
620 bool is_freed = QUERY_FLAG (op, FLAG_FREED); 483 bool is_freed = QUERY_FLAG (dst, FLAG_FREED);
621 bool is_removed = QUERY_FLAG (op, FLAG_REMOVED); 484 bool is_removed = QUERY_FLAG (dst, FLAG_REMOVED);
622 485
623 op2->clone (op); 486 *(object_copy *)dst = *this;
487 *(object_pod *)dst = *this;
488
489 if (self || cb)
490 INVOKE_OBJECT (CLONE, this, ARG_OBJECT (dst));
624 491
625 if (is_freed) 492 if (is_freed)
626 SET_FLAG (op, FLAG_FREED); 493 SET_FLAG (dst, FLAG_FREED);
494
627 if (is_removed) 495 if (is_removed)
628 SET_FLAG (op, FLAG_REMOVED); 496 SET_FLAG (dst, FLAG_REMOVED);
629 497
630 if (op2->speed < 0) 498 if (speed < 0)
631 op->speed_left = op2->speed_left - RANDOM () % 200 / 100.0; 499 dst->speed_left = speed_left - RANDOM () % 200 / 100.0;
632 500
633 /* Copy over key_values, if any. */ 501 /* Copy over key_values, if any. */
634 if (op2->key_values) 502 if (key_values)
635 { 503 {
636 key_value *tail = 0; 504 key_value *tail = 0;
637 key_value *i; 505 key_value *i;
638 506
639 op->key_values = 0; 507 dst->key_values = 0;
640 508
641 for (i = op2->key_values; i; i = i->next) 509 for (i = key_values; i; i = i->next)
642 { 510 {
643 key_value *new_link = new key_value; 511 key_value *new_link = new key_value;
644 512
645 new_link->next = 0; 513 new_link->next = 0;
646 new_link->key = i->key; 514 new_link->key = i->key;
647 new_link->value = i->value; 515 new_link->value = i->value;
648 516
649 /* Try and be clever here, too. */ 517 /* Try and be clever here, too. */
650 if (!op->key_values) 518 if (!dst->key_values)
651 { 519 {
652 op->key_values = new_link; 520 dst->key_values = new_link;
653 tail = new_link; 521 tail = new_link;
654 } 522 }
655 else 523 else
656 { 524 {
657 tail->next = new_link; 525 tail->next = new_link;
658 tail = new_link; 526 tail = new_link;
659 } 527 }
660 } 528 }
661 } 529 }
662 530
663 update_ob_speed (op); 531 update_ob_speed (dst);
532}
533
534object *
535object::clone ()
536{
537 object *neu = create ();
538 copy_to (neu);
539 return neu;
664} 540}
665 541
666/* 542/*
667 * If an object with the IS_TURNABLE() flag needs to be turned due 543 * If an object with the IS_TURNABLE() flag needs to be turned due
668 * to the closest player being on the other side, this function can 544 * to the closest player being on the other side, this function can
776 op->active_next = NULL; 652 op->active_next = NULL;
777 op->active_prev = NULL; 653 op->active_prev = NULL;
778} 654}
779 655
780/* 656/*
781 * update_object() updates the array which represents the map. 657 * update_object() updates the the map.
782 * It takes into account invisible objects (and represent squares covered 658 * It takes into account invisible objects (and represent squares covered
783 * by invisible objects by whatever is below them (unless it's another 659 * by invisible objects by whatever is below them (unless it's another
784 * invisible object, etc...) 660 * invisible object, etc...)
785 * If the object being updated is beneath a player, the look-window 661 * If the object being updated is beneath a player, the look-window
786 * of that player is updated (this might be a suboptimal way of 662 * of that player is updated (this might be a suboptimal way of
787 * updating that window, though, since update_object() is called _often_) 663 * updating that window, though, since update_object() is called _often_)
788 * 664 *
789 * action is a hint of what the caller believes need to be done. 665 * action is a hint of what the caller believes need to be done.
790 * For example, if the only thing that has changed is the face (due to
791 * an animation), we don't need to call update_position until that actually
792 * comes into view of a player. OTOH, many other things, like addition/removal
793 * of walls or living creatures may need us to update the flags now.
794 * current action are: 666 * current action are:
795 * UP_OBJ_INSERT: op was inserted 667 * UP_OBJ_INSERT: op was inserted
796 * UP_OBJ_REMOVE: op was removed 668 * UP_OBJ_REMOVE: op was removed
797 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update 669 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update
798 * as that is easier than trying to look at what may have changed. 670 * as that is easier than trying to look at what may have changed.
799 * UP_OBJ_FACE: only the objects face has changed. 671 * UP_OBJ_FACE: only the objects face has changed.
800 */ 672 */
801
802void 673void
803update_object (object *op, int action) 674update_object (object *op, int action)
804{ 675{
805 int update_now = 0, flags;
806 MoveType move_on, move_off, move_block, move_slow; 676 MoveType move_on, move_off, move_block, move_slow;
807 677
808 if (op == NULL) 678 if (op == NULL)
809 { 679 {
810 /* this should never happen */ 680 /* this should never happen */
811 LOG (llevDebug, "update_object() called for NULL object.\n"); 681 LOG (llevDebug, "update_object() called for NULL object.\n");
812 return; 682 return;
813 } 683 }
814 684
815 if (op->env != NULL) 685 if (op->env)
816 { 686 {
817 /* Animation is currently handled by client, so nothing 687 /* Animation is currently handled by client, so nothing
818 * to do in this case. 688 * to do in this case.
819 */ 689 */
820 return; 690 return;
834 abort (); 704 abort ();
835#endif 705#endif
836 return; 706 return;
837 } 707 }
838 708
839 flags = GET_MAP_FLAGS (op->map, op->x, op->y); 709 mapspace &m = op->ms ();
840 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NEED_UPDATE);
841 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
842 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
843 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
844 move_off = GET_MAP_MOVE_OFF (op->map, op->x, op->y);
845 710
711 if (m.flags_ & P_NEED_UPDATE)
712 /* nop */;
846 if (action == UP_OBJ_INSERT) 713 else if (action == UP_OBJ_INSERT)
847 { 714 {
715 // this is likely overkill, TODO: revisit (schmorp)
848 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(flags & P_BLOCKSVIEW)) 716 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
849 update_now = 1;
850
851 if (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(flags & P_NO_MAGIC)) 717 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
852 update_now = 1; 718 || (op->type == PLAYER && !(m.flags_ & P_PLAYER))
853 719 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
720 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
854 if (QUERY_FLAG (op, FLAG_DAMNED) && !(flags & P_NO_CLERIC)) 721 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
855 update_now = 1;
856
857 if (QUERY_FLAG (op, FLAG_ALIVE) && !(flags & P_IS_ALIVE))
858 update_now = 1;
859
860 if (op->type == SAFE_GROUND && !(flags & P_SAFE))
861 update_now = 1;
862
863 if ((move_on | op->move_on) != move_on) 722 || (m.move_on | op->move_on ) != m.move_on
864 update_now = 1;
865
866 if ((move_off | op->move_off) != move_off) 723 || (m.move_off | op->move_off ) != m.move_off
867 update_now = 1; 724 || (m.move_slow | op->move_slow) != m.move_slow
868
869 /* This isn't perfect, but I don't expect a lot of objects to 725 /* This isn't perfect, but I don't expect a lot of objects to
870 * to have move_allow right now. 726 * to have move_allow right now.
871 */ 727 */
872 if (((move_block | op->move_block) & ~op->move_allow) != move_block) 728 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
873 update_now = 1; 729 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
874 730 m.flags_ = P_NEED_UPDATE;
875 if ((move_slow | op->move_slow) != move_slow)
876 update_now = 1;
877 } 731 }
878 /* if the object is being removed, we can't make intelligent 732 /* if the object is being removed, we can't make intelligent
879 * decisions, because remove_ob can't really pass the object 733 * decisions, because remove_ob can't really pass the object
880 * that is being removed. 734 * that is being removed.
881 */ 735 */
882 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 736 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
883 update_now = 1; 737 m.flags_ = P_NEED_UPDATE;
884 else if (action == UP_OBJ_FACE) 738 else if (action == UP_OBJ_FACE)
885 /* Nothing to do for that case */ ; 739 /* Nothing to do for that case */ ;
886 else 740 else
887 LOG (llevError, "update_object called with invalid action: %d\n", action); 741 LOG (llevError, "update_object called with invalid action: %d\n", action);
888 742
889 if (update_now)
890 {
891 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NO_ERROR | P_NEED_UPDATE);
892 update_position (op->map, op->x, op->y);
893 }
894
895 if (op->more != NULL) 743 if (op->more)
896 update_object (op->more, action); 744 update_object (op->more, action);
897} 745}
898 746
899object::vector object::mortals; 747object::vector object::mortals;
900object::vector object::objects; // not yet used 748object::vector object::objects; // not yet used
908 else 756 else
909 { 757 {
910 delete *i; 758 delete *i;
911 mortals.erase (i); 759 mortals.erase (i);
912 } 760 }
913
914 static int lastmortals = 0;//D
915
916 if (mortals.size() != lastmortals)//D
917 {
918 lastmortals = mortals.size ();//D
919 LOG (llevDebug, "%d objects in mortal queue\n", lastmortals);//D
920 }
921} 761}
922 762
923object::object () 763object::object ()
924{ 764{
925 SET_FLAG (this, FLAG_REMOVED); 765 SET_FLAG (this, FLAG_REMOVED);
947 object::first = this; 787 object::first = this;
948} 788}
949 789
950void object::unlink () 790void object::unlink ()
951{ 791{
952 //count = 0;//D
953 if (!prev && !next) return;//D
954
955 if (this == object::first) 792 if (this == object::first)
956 object::first = next; 793 object::first = next;
957 794
958 /* Remove this object from the list of used objects */ 795 /* Remove this object from the list of used objects */
959 if (prev) prev->next = next; 796 if (prev) prev->next = next;
975 * it from the list of used objects, and puts it on the list of 812 * it from the list of used objects, and puts it on the list of
976 * free objects. The IS_FREED() flag is set in the object. 813 * free objects. The IS_FREED() flag is set in the object.
977 * The object must have been removed by remove_ob() first for 814 * The object must have been removed by remove_ob() first for
978 * this function to succeed. 815 * this function to succeed.
979 * 816 *
980 * If free_inventory is set, free inventory as well. Else drop items in 817 * If destroy_inventory is set, free inventory as well. Else drop items in
981 * inventory to the ground. 818 * inventory to the ground.
982 */ 819 */
983void object::free (bool free_inventory) 820void object::destroy (bool destroy_inventory)
984{ 821{
985 if (QUERY_FLAG (this, FLAG_FREED)) 822 if (QUERY_FLAG (this, FLAG_FREED))
986 return; 823 return;
987 824
988 if (QUERY_FLAG (this, FLAG_FRIENDLY)) 825 if (QUERY_FLAG (this, FLAG_FRIENDLY))
989 remove_friendly_object (this); 826 remove_friendly_object (this);
990 827
991 if (!QUERY_FLAG (this, FLAG_REMOVED)) 828 if (!QUERY_FLAG (this, FLAG_REMOVED))
992 remove_ob (this); 829 remove ();
993 830
994 SET_FLAG (this, FLAG_FREED); 831 SET_FLAG (this, FLAG_FREED);
995 832
996 if (more) 833 if (more)
997 { 834 {
998 more->free (free_inventory); 835 more->destroy (destroy_inventory);
999 more = 0; 836 more = 0;
1000 } 837 }
1001 838
1002 if (inv) 839 if (inv)
1003 { 840 {
1004 /* Only if the space blocks everything do we not process - 841 /* Only if the space blocks everything do we not process -
1005 * if some form of movement is allowed, let objects 842 * if some form of movement is allowed, let objects
1006 * drop on that space. 843 * drop on that space.
1007 */ 844 */
1008 if (free_inventory || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL) 845 if (destroy_inventory || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL)
1009 { 846 {
1010 object *op = inv; 847 object *op = inv;
1011 848
1012 while (op) 849 while (op)
1013 { 850 {
1014 object *tmp = op->below; 851 object *tmp = op->below;
1015 op->free (free_inventory); 852 op->destroy (destroy_inventory);
1016 op = tmp; 853 op = tmp;
1017 } 854 }
1018 } 855 }
1019 else 856 else
1020 { /* Put objects in inventory onto this space */ 857 { /* Put objects in inventory onto this space */
1022 859
1023 while (op) 860 while (op)
1024 { 861 {
1025 object *tmp = op->below; 862 object *tmp = op->below;
1026 863
1027 remove_ob (op); 864 op->remove ();
1028 865
1029 if (QUERY_FLAG (op, FLAG_STARTEQUIP) 866 if (QUERY_FLAG (op, FLAG_STARTEQUIP)
1030 || QUERY_FLAG (op, FLAG_NO_DROP) || op->type == RUNE || op->type == TRAP || QUERY_FLAG (op, FLAG_IS_A_TEMPLATE)) 867 || QUERY_FLAG (op, FLAG_NO_DROP) || op->type == RUNE || op->type == TRAP || QUERY_FLAG (op, FLAG_IS_A_TEMPLATE))
1031 free_object (op); 868 op->destroy ();
1032 else 869 else
1033 { 870 {
1034 op->x = x; 871 op->x = x;
1035 op->y = y; 872 op->y = y;
1036 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */ 873 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
1039 op = tmp; 876 op = tmp;
1040 } 877 }
1041 } 878 }
1042 } 879 }
1043 880
881 // hack to ensure that freed objects still have a valid map
882 {
883 static maptile *freed_map; // freed objects are moved here to avoid crashes
884
885 if (!freed_map)
886 {
887 freed_map = new maptile;
888
889 freed_map->name = "/internal/freed_objects_map";
890 freed_map->width = 3;
891 freed_map->height = 3;
892
893 freed_map->allocate ();
894 }
895
896 map = freed_map;
897 x = 1;
898 y = 1;
899 }
900
1044 // clear those pointers that likely might have circular references to us 901 // clear those pointers that likely might have circular references to us
1045 owner = 0; 902 owner = 0;
1046 enemy = 0; 903 enemy = 0;
1047 attacked_by = 0; 904 attacked_by = 0;
1048 905
906 // only relevant for players(?), but make sure of it anyways
907 contr = 0;
908
1049 /* Remove object from the active list */ 909 /* Remove object from the active list */
1050 speed = 0; 910 speed = 0;
1051 update_ob_speed (this); 911 update_ob_speed (this);
1052 912
1053 unlink (); 913 unlink ();
1057 917
1058/* 918/*
1059 * sub_weight() recursively (outwards) subtracts a number from the 919 * sub_weight() recursively (outwards) subtracts a number from the
1060 * weight of an object (and what is carried by it's environment(s)). 920 * weight of an object (and what is carried by it's environment(s)).
1061 */ 921 */
1062
1063void 922void
1064sub_weight (object *op, signed long weight) 923sub_weight (object *op, signed long weight)
1065{ 924{
1066 while (op != NULL) 925 while (op != NULL)
1067 { 926 {
1071 op->carrying -= weight; 930 op->carrying -= weight;
1072 op = op->env; 931 op = op->env;
1073 } 932 }
1074} 933}
1075 934
1076/* remove_ob(op): 935/* op->remove ():
1077 * This function removes the object op from the linked list of objects 936 * This function removes the object op from the linked list of objects
1078 * which it is currently tied to. When this function is done, the 937 * which it is currently tied to. When this function is done, the
1079 * object will have no environment. If the object previously had an 938 * object will have no environment. If the object previously had an
1080 * environment, the x and y coordinates will be updated to 939 * environment, the x and y coordinates will be updated to
1081 * the previous environment. 940 * the previous environment.
1082 * Beware: This function is called from the editor as well! 941 * Beware: This function is called from the editor as well!
1083 */ 942 */
1084
1085void 943void
1086remove_ob (object *op) 944object::remove ()
1087{ 945{
1088 object *tmp, *last = 0; 946 object *tmp, *last = 0;
1089 object *otmp; 947 object *otmp;
1090 948
1091 tag_t tag;
1092 int check_walk_off; 949 int check_walk_off;
1093 mapstruct *m;
1094 950
1095 sint16 x, y;
1096
1097 if (QUERY_FLAG (op, FLAG_REMOVED)) 951 if (QUERY_FLAG (this, FLAG_REMOVED))
1098 return; 952 return;
1099 953
1100 SET_FLAG (op, FLAG_REMOVED); 954 SET_FLAG (this, FLAG_REMOVED);
1101 955
1102 if (op->more != NULL) 956 if (more)
1103 remove_ob (op->more); 957 more->remove ();
1104 958
1105 /* 959 /*
1106 * In this case, the object to be removed is in someones 960 * In this case, the object to be removed is in someones
1107 * inventory. 961 * inventory.
1108 */ 962 */
1109 if (op->env != NULL) 963 if (env)
1110 { 964 {
1111 if (op->nrof) 965 if (nrof)
1112 sub_weight (op->env, op->weight * op->nrof); 966 sub_weight (env, weight * nrof);
1113 else 967 else
1114 sub_weight (op->env, op->weight + op->carrying); 968 sub_weight (env, weight + carrying);
1115 969
1116 /* NO_FIX_PLAYER is set when a great many changes are being 970 /* NO_FIX_PLAYER is set when a great many changes are being
1117 * made to players inventory. If set, avoiding the call 971 * made to players inventory. If set, avoiding the call
1118 * to save cpu time. 972 * to save cpu time.
1119 */ 973 */
1120 if ((otmp = is_player_inv (op->env)) != NULL && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 974 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1121 fix_player (otmp); 975 otmp->update_stats ();
1122 976
1123 if (op->above != NULL) 977 if (above != NULL)
1124 op->above->below = op->below; 978 above->below = below;
1125 else 979 else
1126 op->env->inv = op->below; 980 env->inv = below;
1127 981
1128 if (op->below != NULL) 982 if (below != NULL)
1129 op->below->above = op->above; 983 below->above = above;
1130 984
1131 /* we set up values so that it could be inserted into 985 /* we set up values so that it could be inserted into
1132 * the map, but we don't actually do that - it is up 986 * the map, but we don't actually do that - it is up
1133 * to the caller to decide what we want to do. 987 * to the caller to decide what we want to do.
1134 */ 988 */
1135 op->x = op->env->x, op->y = op->env->y; 989 x = env->x, y = env->y;
1136 op->map = op->env->map; 990 map = env->map;
1137 op->above = NULL, op->below = NULL; 991 above = 0, below = 0;
1138 op->env = NULL; 992 env = 0;
1139 } 993 }
1140 else if (op->map) 994 else if (map)
1141 { 995 {
1142 x = op->x;
1143 y = op->y;
1144 m = get_map_from_coord (op->map, &x, &y);
1145
1146 if (!m)
1147 {
1148 LOG (llevError, "remove_ob called when object was on map but appears to not be within valid coordinates? %s (%d,%d)\n",
1149 op->map->path, op->x, op->y);
1150 /* in old days, we used to set x and y to 0 and continue.
1151 * it seems if we get into this case, something is probablye
1152 * screwed up and should be fixed.
1153 */
1154 abort ();
1155 }
1156
1157 if (op->map != m)
1158 LOG (llevDebug, "remove_ob: Object not really on map it claimed to be on? %s != %s, %d,%d != %d,%d\n",
1159 op->map->path, m->path, op->x, op->y, x, y);
1160
1161 /* Re did the following section of code - it looks like it had 996 /* Re did the following section of code - it looks like it had
1162 * lots of logic for things we no longer care about 997 * lots of logic for things we no longer care about
1163 */ 998 */
1164 999
1165 /* link the object above us */ 1000 /* link the object above us */
1166 if (op->above) 1001 if (above)
1167 op->above->below = op->below; 1002 above->below = below;
1168 else 1003 else
1169 SET_MAP_TOP (m, x, y, op->below); /* we were top, set new top */ 1004 map->at (x, y).top = below; /* we were top, set new top */
1170 1005
1171 /* Relink the object below us, if there is one */ 1006 /* Relink the object below us, if there is one */
1172 if (op->below) 1007 if (below)
1173 op->below->above = op->above; 1008 below->above = above;
1174 else 1009 else
1175 { 1010 {
1176 /* Nothing below, which means we need to relink map object for this space 1011 /* Nothing below, which means we need to relink map object for this space
1177 * use translated coordinates in case some oddness with map tiling is 1012 * use translated coordinates in case some oddness with map tiling is
1178 * evident 1013 * evident
1179 */ 1014 */
1180 if (GET_MAP_OB (m, x, y) != op) 1015 if (GET_MAP_OB (map, x, y) != this)
1181 { 1016 {
1182 dump_object (op); 1017 char *dump = dump_object (this);
1183 LOG (llevError, 1018 LOG (llevError,
1184 "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", errmsg); 1019 "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", dump);
1020 free (dump);
1185 dump_object (GET_MAP_OB (m, x, y)); 1021 dump = dump_object (GET_MAP_OB (map, x, y));
1186 LOG (llevError, "%s\n", errmsg); 1022 LOG (llevError, "%s\n", dump);
1023 free (dump);
1187 } 1024 }
1188 1025
1189 SET_MAP_OB (m, x, y, op->above); /* goes on above it. */ 1026 map->at (x, y).bottom = above; /* goes on above it. */
1190 } 1027 }
1191 1028
1192 op->above = 0; 1029 above = 0;
1193 op->below = 0; 1030 below = 0;
1194 1031
1195 if (op->map->in_memory == MAP_SAVING) 1032 if (map->in_memory == MAP_SAVING)
1196 return; 1033 return;
1197 1034
1198 tag = op->count;
1199 check_walk_off = !QUERY_FLAG (op, FLAG_NO_APPLY); 1035 check_walk_off = !QUERY_FLAG (this, FLAG_NO_APPLY);
1200 1036
1201 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1037 for (tmp = GET_MAP_OB (map, x, y); tmp; tmp = tmp->above)
1202 { 1038 {
1203 /* No point updating the players look faces if he is the object 1039 /* No point updating the players look faces if he is the object
1204 * being removed. 1040 * being removed.
1205 */ 1041 */
1206 1042
1207 if (tmp->type == PLAYER && tmp != op) 1043 if (tmp->type == PLAYER && tmp != this)
1208 { 1044 {
1209 /* If a container that the player is currently using somehow gets 1045 /* If a container that the player is currently using somehow gets
1210 * removed (most likely destroyed), update the player view 1046 * removed (most likely destroyed), update the player view
1211 * appropriately. 1047 * appropriately.
1212 */ 1048 */
1213 if (tmp->container == op) 1049 if (tmp->container == this)
1214 { 1050 {
1215 CLEAR_FLAG (op, FLAG_APPLIED); 1051 CLEAR_FLAG (this, FLAG_APPLIED);
1216 tmp->container = NULL; 1052 tmp->container = 0;
1217 } 1053 }
1218 1054
1219 tmp->contr->socket.update_look = 1; 1055 tmp->contr->ns->floorbox_update ();
1220 } 1056 }
1221 1057
1222 /* See if player moving off should effect something */ 1058 /* See if player moving off should effect something */
1223 if (check_walk_off && ((op->move_type & tmp->move_off) && (op->move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1059 if (check_walk_off
1060 && ((move_type & tmp->move_off)
1061 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0))
1224 { 1062 {
1225 move_apply (tmp, op, NULL); 1063 move_apply (tmp, this, 0);
1226 1064
1227 if (was_destroyed (op, tag)) 1065 if (destroyed ())
1228 {
1229 LOG (llevError, "BUG: remove_ob(): name %s, archname %s destroyed " "leaving object\n", &tmp->name, &tmp->arch->name); 1066 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1230 }
1231 } 1067 }
1232 1068
1233 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */ 1069 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */
1234 1070
1235 if (tmp->above == tmp) 1071 if (tmp->above == tmp)
1236 tmp->above = NULL; 1072 tmp->above = 0;
1237 1073
1238 last = tmp; 1074 last = tmp;
1239 } 1075 }
1240 1076
1241 /* last == NULL of there are no objects on this space */ 1077 /* last == NULL of there are no objects on this space */
1242 if (last == NULL) 1078 if (!last)
1243 { 1079 map->at (x, y).flags_ = P_NEED_UPDATE;
1244 /* set P_NEED_UPDATE, otherwise update_position will complain. In theory,
1245 * we could preserve the flags (GET_MAP_FLAGS), but update_position figures
1246 * those out anyways, and if there are any flags set right now, they won't
1247 * be correct anyways.
1248 */
1249 SET_MAP_FLAGS (op->map, op->x, op->y, P_NEED_UPDATE);
1250 update_position (op->map, op->x, op->y);
1251 }
1252 else 1080 else
1253 update_object (last, UP_OBJ_REMOVE); 1081 update_object (last, UP_OBJ_REMOVE);
1254 1082
1255 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) || (op->glow_radius != 0)) 1083 if (QUERY_FLAG (this, FLAG_BLOCKSVIEW) || glow_radius)
1256 update_all_los (op->map, op->x, op->y); 1084 update_all_los (map, x, y);
1257 } 1085 }
1258} 1086}
1259 1087
1260/* 1088/*
1261 * merge_ob(op,top): 1089 * merge_ob(op,top):
1276 1104
1277 for (; top != NULL; top = top->below) 1105 for (; top != NULL; top = top->below)
1278 { 1106 {
1279 if (top == op) 1107 if (top == op)
1280 continue; 1108 continue;
1281 if (CAN_MERGE (op, top)) 1109
1110 if (object::can_merge (op, top))
1282 { 1111 {
1283 top->nrof += op->nrof; 1112 top->nrof += op->nrof;
1284 1113
1285/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/ 1114/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/
1286 op->weight = 0; /* Don't want any adjustements now */ 1115 op->weight = 0; /* Don't want any adjustements now */
1287 remove_ob (op); 1116 op->destroy ();
1288 free_object (op);
1289 return top; 1117 return top;
1290 } 1118 }
1291 } 1119 }
1292 1120
1293 return 0; 1121 return 0;
1296/* 1124/*
1297 * same as insert_ob_in_map except it handle separate coordinates and do a clean 1125 * same as insert_ob_in_map except it handle separate coordinates and do a clean
1298 * job preparing multi-part monsters 1126 * job preparing multi-part monsters
1299 */ 1127 */
1300object * 1128object *
1301insert_ob_in_map_at (object *op, mapstruct *m, object *originator, int flag, int x, int y) 1129insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1302{ 1130{
1303 object *tmp; 1131 object *tmp;
1304 1132
1305 if (op->head) 1133 if (op->head)
1306 op = op->head; 1134 op = op->head;
1334 * NULL if 'op' was destroyed 1162 * NULL if 'op' was destroyed
1335 * just 'op' otherwise 1163 * just 'op' otherwise
1336 */ 1164 */
1337 1165
1338object * 1166object *
1339insert_ob_in_map (object *op, mapstruct *m, object *originator, int flag) 1167insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1340{ 1168{
1341 object *tmp, *top, *floor = NULL; 1169 object *tmp, *top, *floor = NULL;
1342 sint16 x, y; 1170 sint16 x, y;
1343 1171
1344 if (QUERY_FLAG (op, FLAG_FREED)) 1172 if (QUERY_FLAG (op, FLAG_FREED))
1347 return NULL; 1175 return NULL;
1348 } 1176 }
1349 1177
1350 if (m == NULL) 1178 if (m == NULL)
1351 { 1179 {
1352 dump_object (op); 1180 char *dump = dump_object (op);
1353 LOG (llevError, "Trying to insert in null-map!\n%s\n", errmsg); 1181 LOG (llevError, "Trying to insert in null-map!\n%s\n", dump);
1182 free (dump);
1354 return op; 1183 return op;
1355 } 1184 }
1356 1185
1357 if (out_of_map (m, op->x, op->y)) 1186 if (out_of_map (m, op->x, op->y))
1358 { 1187 {
1359 dump_object (op); 1188 char *dump = dump_object (op);
1360 LOG (llevError, "Trying to insert object outside the map.\n%s\n", errmsg); 1189 LOG (llevError, "Trying to insert object outside the map.\n%s\n", dump);
1361#ifdef MANY_CORES 1190#ifdef MANY_CORES
1362 /* Better to catch this here, as otherwise the next use of this object 1191 /* Better to catch this here, as otherwise the next use of this object
1363 * is likely to cause a crash. Better to find out where it is getting 1192 * is likely to cause a crash. Better to find out where it is getting
1364 * improperly inserted. 1193 * improperly inserted.
1365 */ 1194 */
1366 abort (); 1195 abort ();
1367#endif 1196#endif
1197 free (dump);
1368 return op; 1198 return op;
1369 } 1199 }
1370 1200
1371 if (!QUERY_FLAG (op, FLAG_REMOVED)) 1201 if (!QUERY_FLAG (op, FLAG_REMOVED))
1372 { 1202 {
1373 dump_object (op); 1203 char *dump = dump_object (op);
1374 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", errmsg); 1204 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", dump);
1205 free (dump);
1375 return op; 1206 return op;
1376 } 1207 }
1377 1208
1378 if (op->more != NULL) 1209 if (op->more != NULL)
1379 { 1210 {
1417 1248
1418 /* this has to be done after we translate the coordinates. 1249 /* this has to be done after we translate the coordinates.
1419 */ 1250 */
1420 if (op->nrof && !(flag & INS_NO_MERGE)) 1251 if (op->nrof && !(flag & INS_NO_MERGE))
1421 for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above) 1252 for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above)
1422 if (CAN_MERGE (op, tmp)) 1253 if (object::can_merge (op, tmp))
1423 { 1254 {
1424 op->nrof += tmp->nrof; 1255 op->nrof += tmp->nrof;
1425 remove_ob (tmp); 1256 tmp->destroy ();
1426 free_object (tmp);
1427 } 1257 }
1428 1258
1429 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1259 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1430 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1260 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1431 1261
1444 op->below = originator->below; 1274 op->below = originator->below;
1445 1275
1446 if (op->below) 1276 if (op->below)
1447 op->below->above = op; 1277 op->below->above = op;
1448 else 1278 else
1449 SET_MAP_OB (op->map, op->x, op->y, op); 1279 op->ms ().bottom = op;
1450 1280
1451 /* since *below* originator, no need to update top */ 1281 /* since *below* originator, no need to update top */
1452 originator->below = op; 1282 originator->below = op;
1453 } 1283 }
1454 else 1284 else
1500 * If INS_ON_TOP is used, don't do this processing 1330 * If INS_ON_TOP is used, don't do this processing
1501 * Need to find the object that in fact blocks view, otherwise 1331 * Need to find the object that in fact blocks view, otherwise
1502 * stacking is a bit odd. 1332 * stacking is a bit odd.
1503 */ 1333 */
1504 if (!(flag & INS_ON_TOP) && 1334 if (!(flag & INS_ON_TOP) &&
1505 (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_BLOCKSVIEW) && (op->face && !op->face->visibility)) 1335 (get_map_flags (op->map, 0, op->x, op->y, 0, 0) & P_BLOCKSVIEW) && (op->face && !op->face->visibility))
1506 { 1336 {
1507 for (last = top; last != floor; last = last->below) 1337 for (last = top; last != floor; last = last->below)
1508 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1338 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1509 break; 1339 break;
1510 /* Check to see if we found the object that blocks view, 1340 /* Check to see if we found the object that blocks view,
1533 1363
1534 if (op->above) 1364 if (op->above)
1535 op->above->below = op; 1365 op->above->below = op;
1536 1366
1537 op->below = NULL; 1367 op->below = NULL;
1538 SET_MAP_OB (op->map, op->x, op->y, op); 1368 op->ms ().bottom = op;
1539 } 1369 }
1540 else 1370 else
1541 { /* get inserted into the stack above top */ 1371 { /* get inserted into the stack above top */
1542 op->above = top->above; 1372 op->above = top->above;
1543 1373
1547 op->below = top; 1377 op->below = top;
1548 top->above = op; 1378 top->above = op;
1549 } 1379 }
1550 1380
1551 if (op->above == NULL) 1381 if (op->above == NULL)
1552 SET_MAP_TOP (op->map, op->x, op->y, op); 1382 op->ms ().top = op;
1553 } /* else not INS_BELOW_ORIGINATOR */ 1383 } /* else not INS_BELOW_ORIGINATOR */
1554 1384
1555 if (op->type == PLAYER) 1385 if (op->type == PLAYER)
1556 op->contr->do_los = 1; 1386 op->contr->do_los = 1;
1557 1387
1558 /* If we have a floor, we know the player, if any, will be above 1388 /* If we have a floor, we know the player, if any, will be above
1559 * it, so save a few ticks and start from there. 1389 * it, so save a few ticks and start from there.
1560 */ 1390 */
1561 if (!(flag & INS_MAP_LOAD)) 1391 if (!(flag & INS_MAP_LOAD))
1562 for (tmp = floor ? floor : GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1392 if (object *pl = op->ms ().player ())
1563 if (tmp->type == PLAYER) 1393 pl->contr->ns->floorbox_update ();
1564 tmp->contr->socket.update_look = 1;
1565 1394
1566 /* If this object glows, it may affect lighting conditions that are 1395 /* If this object glows, it may affect lighting conditions that are
1567 * visible to others on this map. But update_all_los is really 1396 * visible to others on this map. But update_all_los is really
1568 * an inefficient way to do this, as it means los for all players 1397 * an inefficient way to do this, as it means los for all players
1569 * on the map will get recalculated. The players could very well 1398 * on the map will get recalculated. The players could very well
1577 1406
1578 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1407 /* updates flags (blocked, alive, no magic, etc) for this map space */
1579 update_object (op, UP_OBJ_INSERT); 1408 update_object (op, UP_OBJ_INSERT);
1580 1409
1581 /* Don't know if moving this to the end will break anything. However, 1410 /* Don't know if moving this to the end will break anything. However,
1582 * we want to have update_look set above before calling this. 1411 * we want to have floorbox_update called before calling this.
1583 * 1412 *
1584 * check_move_on() must be after this because code called from 1413 * check_move_on() must be after this because code called from
1585 * check_move_on() depends on correct map flags (so functions like 1414 * check_move_on() depends on correct map flags (so functions like
1586 * blocked() and wall() work properly), and these flags are updated by 1415 * blocked() and wall() work properly), and these flags are updated by
1587 * update_object(). 1416 * update_object().
1603 1432
1604 return op; 1433 return op;
1605} 1434}
1606 1435
1607/* this function inserts an object in the map, but if it 1436/* this function inserts an object in the map, but if it
1608 * finds an object of its own type, it'll remove that one first. 1437 * finds an object of its own type, it'll remove that one first.
1609 * op is the object to insert it under: supplies x and the map. 1438 * op is the object to insert it under: supplies x and the map.
1610 */ 1439 */
1611void 1440void
1612replace_insert_ob_in_map (const char *arch_string, object *op) 1441replace_insert_ob_in_map (const char *arch_string, object *op)
1613{ 1442{
1614 object * 1443 object *tmp, *tmp1;
1615 tmp;
1616 object *
1617 tmp1;
1618 1444
1619 /* first search for itself and remove any old instances */ 1445 /* first search for itself and remove any old instances */
1620 1446
1621 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1447 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above)
1622 {
1623 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */ 1448 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */
1624 { 1449 tmp->destroy ();
1625 remove_ob (tmp);
1626 free_object (tmp);
1627 }
1628 }
1629 1450
1630 tmp1 = arch_to_object (archetype::find (arch_string)); 1451 tmp1 = arch_to_object (archetype::find (arch_string));
1631 1452
1632 tmp1->x = op->x; 1453 tmp1->x = op->x;
1633 tmp1->y = op->y; 1454 tmp1->y = op->y;
1643 */ 1464 */
1644 1465
1645object * 1466object *
1646get_split_ob (object *orig_ob, uint32 nr) 1467get_split_ob (object *orig_ob, uint32 nr)
1647{ 1468{
1648 object * 1469 object *newob;
1649 newob;
1650 int
1651 is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0); 1470 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1652 1471
1653 if (orig_ob->nrof < nr) 1472 if (orig_ob->nrof < nr)
1654 { 1473 {
1655 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name); 1474 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1656 return NULL; 1475 return NULL;
1657 } 1476 }
1658 1477
1659 newob = object_create_clone (orig_ob); 1478 newob = object_create_clone (orig_ob);
1660 1479
1661 if ((orig_ob->nrof -= nr) < 1) 1480 if ((orig_ob->nrof -= nr) < 1)
1662 { 1481 orig_ob->destroy (1);
1663 if (!is_removed)
1664 remove_ob (orig_ob);
1665 free_object2 (orig_ob, 1);
1666 }
1667 else if (!is_removed) 1482 else if (!is_removed)
1668 { 1483 {
1669 if (orig_ob->env != NULL) 1484 if (orig_ob->env != NULL)
1670 sub_weight (orig_ob->env, orig_ob->weight * nr); 1485 sub_weight (orig_ob->env, orig_ob->weight * nr);
1671 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY) 1486 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY)
1701 if (i > op->nrof) 1516 if (i > op->nrof)
1702 i = op->nrof; 1517 i = op->nrof;
1703 1518
1704 if (QUERY_FLAG (op, FLAG_REMOVED)) 1519 if (QUERY_FLAG (op, FLAG_REMOVED))
1705 op->nrof -= i; 1520 op->nrof -= i;
1706 else if (op->env != NULL) 1521 else if (op->env)
1707 { 1522 {
1708 /* is this object in the players inventory, or sub container 1523 /* is this object in the players inventory, or sub container
1709 * therein? 1524 * therein?
1710 */ 1525 */
1711 tmp = is_player_inv (op->env); 1526 tmp = op->in_player ();
1712 /* nope. Is this a container the player has opened? 1527 /* nope. Is this a container the player has opened?
1713 * If so, set tmp to that player. 1528 * If so, set tmp to that player.
1714 * IMO, searching through all the players will mostly 1529 * IMO, searching through all the players will mostly
1715 * likely be quicker than following op->env to the map, 1530 * likely be quicker than following op->env to the map,
1716 * and then searching the map for a player. 1531 * and then searching the map for a player.
1717 */ 1532 */
1718 if (!tmp) 1533 if (!tmp)
1719 { 1534 {
1720 for (pl = first_player; pl; pl = pl->next) 1535 for (pl = first_player; pl; pl = pl->next)
1721 if (pl->ob->container == op->env) 1536 if (pl->ob->container == op->env)
1537 {
1538 tmp = pl->ob;
1722 break; 1539 break;
1723 if (pl) 1540 }
1724 tmp = pl->ob;
1725 else
1726 tmp = NULL;
1727 } 1541 }
1728 1542
1729 if (i < op->nrof) 1543 if (i < op->nrof)
1730 { 1544 {
1731 sub_weight (op->env, op->weight * i); 1545 sub_weight (op->env, op->weight * i);
1732 op->nrof -= i; 1546 op->nrof -= i;
1733 if (tmp) 1547 if (tmp)
1734 {
1735 esrv_send_item (tmp, op); 1548 esrv_send_item (tmp, op);
1736 }
1737 } 1549 }
1738 else 1550 else
1739 { 1551 {
1740 remove_ob (op); 1552 op->remove ();
1741 op->nrof = 0; 1553 op->nrof = 0;
1742 if (tmp) 1554 if (tmp)
1743 {
1744 esrv_del_item (tmp->contr, op->count); 1555 esrv_del_item (tmp->contr, op->count);
1745 }
1746 } 1556 }
1747 } 1557 }
1748 else 1558 else
1749 { 1559 {
1750 object *above = op->above; 1560 object *above = op->above;
1751 1561
1752 if (i < op->nrof) 1562 if (i < op->nrof)
1753 op->nrof -= i; 1563 op->nrof -= i;
1754 else 1564 else
1755 { 1565 {
1756 remove_ob (op); 1566 op->remove ();
1757 op->nrof = 0; 1567 op->nrof = 0;
1758 } 1568 }
1759 1569
1760 /* Since we just removed op, op->above is null */ 1570 /* Since we just removed op, op->above is null */
1761 for (tmp = above; tmp != NULL; tmp = tmp->above) 1571 for (tmp = above; tmp; tmp = tmp->above)
1762 if (tmp->type == PLAYER) 1572 if (tmp->type == PLAYER)
1763 { 1573 {
1764 if (op->nrof) 1574 if (op->nrof)
1765 esrv_send_item (tmp, op); 1575 esrv_send_item (tmp, op);
1766 else 1576 else
1770 1580
1771 if (op->nrof) 1581 if (op->nrof)
1772 return op; 1582 return op;
1773 else 1583 else
1774 { 1584 {
1775 free_object (op); 1585 op->destroy ();
1776 return NULL; 1586 return 0;
1777 } 1587 }
1778} 1588}
1779 1589
1780/* 1590/*
1781 * add_weight(object, weight) adds the specified weight to an object, 1591 * add_weight(object, weight) adds the specified weight to an object,
1793 op->carrying += weight; 1603 op->carrying += weight;
1794 op = op->env; 1604 op = op->env;
1795 } 1605 }
1796} 1606}
1797 1607
1608object *
1609insert_ob_in_ob (object *op, object *where)
1610{
1611 if (!where)
1612 {
1613 char *dump = dump_object (op);
1614 LOG (llevError, "Trying to put object in NULL.\n%s\n", dump);
1615 free (dump);
1616 return op;
1617 }
1618
1619 if (where->head)
1620 {
1621 LOG (llevDebug, "Warning: Tried to insert object into wrong part of multipart object.\n");
1622 where = where->head;
1623 }
1624
1625 return where->insert (op);
1626}
1627
1798/* 1628/*
1799 * insert_ob_in_ob(op,environment): 1629 * env->insert (op)
1800 * This function inserts the object op in the linked list 1630 * This function inserts the object op in the linked list
1801 * inside the object environment. 1631 * inside the object environment.
1802 * 1632 *
1803 * Eneq(@csd.uu.se): Altered insert_ob_in_ob to make things picked up enter
1804 * the inventory at the last position or next to other objects of the same
1805 * type.
1806 * Frank: Now sorted by type, archetype and magic!
1807 *
1808 * The function returns now pointer to inserted item, and return value can 1633 * The function returns now pointer to inserted item, and return value can
1809 * be != op, if items are merged. -Tero 1634 * be != op, if items are merged. -Tero
1810 */ 1635 */
1811 1636
1812object * 1637object *
1813insert_ob_in_ob (object *op, object *where) 1638object::insert (object *op)
1814{ 1639{
1815 object * 1640 object *tmp, *otmp;
1816 tmp, *
1817 otmp;
1818 1641
1819 if (!QUERY_FLAG (op, FLAG_REMOVED)) 1642 if (!QUERY_FLAG (op, FLAG_REMOVED))
1820 { 1643 op->remove ();
1821 dump_object (op);
1822 LOG (llevError, "Trying to insert (ob) inserted object.\n%s\n", errmsg);
1823 return op;
1824 }
1825
1826 if (where == NULL)
1827 {
1828 dump_object (op);
1829 LOG (llevError, "Trying to put object in NULL.\n%s\n", errmsg);
1830 return op;
1831 }
1832
1833 if (where->head)
1834 {
1835 LOG (llevDebug, "Warning: Tried to insert object wrong part of multipart object.\n");
1836 where = where->head;
1837 }
1838 1644
1839 if (op->more) 1645 if (op->more)
1840 { 1646 {
1841 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count); 1647 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);
1842 return op; 1648 return op;
1844 1650
1845 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL); 1651 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL);
1846 CLEAR_FLAG (op, FLAG_REMOVED); 1652 CLEAR_FLAG (op, FLAG_REMOVED);
1847 if (op->nrof) 1653 if (op->nrof)
1848 { 1654 {
1849 for (tmp = where->inv; tmp != NULL; tmp = tmp->below) 1655 for (tmp = inv; tmp != NULL; tmp = tmp->below)
1850 if (CAN_MERGE (tmp, op)) 1656 if (object::can_merge (tmp, op))
1851 { 1657 {
1852 /* return the original object and remove inserted object 1658 /* return the original object and remove inserted object
1853 (client needs the original object) */ 1659 (client needs the original object) */
1854 tmp->nrof += op->nrof; 1660 tmp->nrof += op->nrof;
1855 /* Weight handling gets pretty funky. Since we are adding to 1661 /* Weight handling gets pretty funky. Since we are adding to
1856 * tmp->nrof, we need to increase the weight. 1662 * tmp->nrof, we need to increase the weight.
1857 */ 1663 */
1858 add_weight (where, op->weight * op->nrof); 1664 add_weight (this, op->weight * op->nrof);
1859 SET_FLAG (op, FLAG_REMOVED); 1665 SET_FLAG (op, FLAG_REMOVED);
1860 free_object (op); /* free the inserted object */ 1666 op->destroy (); /* free the inserted object */
1861 op = tmp; 1667 op = tmp;
1862 remove_ob (op); /* and fix old object's links */ 1668 op->remove (); /* and fix old object's links */
1863 CLEAR_FLAG (op, FLAG_REMOVED); 1669 CLEAR_FLAG (op, FLAG_REMOVED);
1864 break; 1670 break;
1865 } 1671 }
1866 1672
1867 /* I assume combined objects have no inventory 1673 /* I assume combined objects have no inventory
1868 * We add the weight - this object could have just been removed 1674 * We add the weight - this object could have just been removed
1869 * (if it was possible to merge). calling remove_ob will subtract 1675 * (if it was possible to merge). calling remove_ob will subtract
1870 * the weight, so we need to add it in again, since we actually do 1676 * the weight, so we need to add it in again, since we actually do
1871 * the linking below 1677 * the linking below
1872 */ 1678 */
1873 add_weight (where, op->weight * op->nrof); 1679 add_weight (this, op->weight * op->nrof);
1874 } 1680 }
1875 else 1681 else
1876 add_weight (where, (op->weight + op->carrying)); 1682 add_weight (this, (op->weight + op->carrying));
1877 1683
1878 otmp = is_player_inv (where); 1684 otmp = this->in_player ();
1879 if (otmp && otmp->contr != NULL) 1685 if (otmp && otmp->contr)
1880 {
1881 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1686 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1882 fix_player (otmp); 1687 otmp->update_stats ();
1883 }
1884 1688
1885 op->map = NULL; 1689 op->map = 0;
1886 op->env = where; 1690 op->env = this;
1887 op->above = NULL; 1691 op->above = 0;
1888 op->below = NULL; 1692 op->below = 0;
1889 op->x = 0, op->y = 0; 1693 op->x = 0, op->y = 0;
1890 1694
1891 /* reset the light list and los of the players on the map */ 1695 /* reset the light list and los of the players on the map */
1892 if ((op->glow_radius != 0) && where->map) 1696 if ((op->glow_radius != 0) && map)
1893 { 1697 {
1894#ifdef DEBUG_LIGHTS 1698#ifdef DEBUG_LIGHTS
1895 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name); 1699 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1896#endif /* DEBUG_LIGHTS */ 1700#endif /* DEBUG_LIGHTS */
1897 if (MAP_DARKNESS (where->map)) 1701 if (MAP_DARKNESS (map))
1898 update_all_los (where->map, where->x, where->y); 1702 update_all_los (map, x, y);
1899 } 1703 }
1900 1704
1901 /* Client has no idea of ordering so lets not bother ordering it here. 1705 /* Client has no idea of ordering so lets not bother ordering it here.
1902 * It sure simplifies this function... 1706 * It sure simplifies this function...
1903 */ 1707 */
1904 if (where->inv == NULL) 1708 if (!inv)
1905 where->inv = op; 1709 inv = op;
1906 else 1710 else
1907 { 1711 {
1908 op->below = where->inv; 1712 op->below = inv;
1909 op->below->above = op; 1713 op->below->above = op;
1910 where->inv = op; 1714 inv = op;
1911 } 1715 }
1716
1912 return op; 1717 return op;
1913} 1718}
1914 1719
1915/* 1720/*
1916 * Checks if any objects has a move_type that matches objects 1721 * Checks if any objects has a move_type that matches objects
1934 */ 1739 */
1935 1740
1936int 1741int
1937check_move_on (object *op, object *originator) 1742check_move_on (object *op, object *originator)
1938{ 1743{
1939 object * 1744 object *tmp;
1940 tmp; 1745 maptile *m = op->map;
1941 tag_t
1942 tag;
1943 mapstruct *
1944 m = op->map;
1945 int
1946 x = op->x, y = op->y; 1746 int x = op->x, y = op->y;
1947 1747
1948 MoveType 1748 MoveType move_on, move_slow, move_block;
1949 move_on,
1950 move_slow,
1951 move_block;
1952 1749
1953 if (QUERY_FLAG (op, FLAG_NO_APPLY)) 1750 if (QUERY_FLAG (op, FLAG_NO_APPLY))
1954 return 0; 1751 return 0;
1955
1956 tag = op->count;
1957 1752
1958 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y); 1753 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
1959 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y); 1754 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
1960 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y); 1755 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
1961 1756
2022 if ((!op->move_type && tmp->move_on & MOVE_WALK) || 1817 if ((!op->move_type && tmp->move_on & MOVE_WALK) ||
2023 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0)) 1818 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0))
2024 { 1819 {
2025 move_apply (tmp, op, originator); 1820 move_apply (tmp, op, originator);
2026 1821
2027 if (was_destroyed (op, tag)) 1822 if (op->destroyed ())
2028 return 1; 1823 return 1;
2029 1824
2030 /* what the person/creature stepped onto has moved the object 1825 /* what the person/creature stepped onto has moved the object
2031 * someplace new. Don't process any further - if we did, 1826 * someplace new. Don't process any further - if we did,
2032 * have a feeling strange problems would result. 1827 * have a feeling strange problems would result.
2044 * a matching archetype at the given map and coordinates. 1839 * a matching archetype at the given map and coordinates.
2045 * The first matching object is returned, or NULL if none. 1840 * The first matching object is returned, or NULL if none.
2046 */ 1841 */
2047 1842
2048object * 1843object *
2049present_arch (const archetype *at, mapstruct *m, int x, int y) 1844present_arch (const archetype *at, maptile *m, int x, int y)
2050{ 1845{
2051 object * 1846 object *
2052 tmp; 1847 tmp;
2053 1848
2054 if (m == NULL || out_of_map (m, x, y)) 1849 if (m == NULL || out_of_map (m, x, y))
2067 * a matching type variable at the given map and coordinates. 1862 * a matching type variable at the given map and coordinates.
2068 * The first matching object is returned, or NULL if none. 1863 * The first matching object is returned, or NULL if none.
2069 */ 1864 */
2070 1865
2071object * 1866object *
2072present (unsigned char type, mapstruct *m, int x, int y) 1867present (unsigned char type, maptile *m, int x, int y)
2073{ 1868{
2074 object * 1869 object *
2075 tmp; 1870 tmp;
2076 1871
2077 if (out_of_map (m, x, y)) 1872 if (out_of_map (m, x, y))
2217 * the archetype because that isn't correct if the monster has been 2012 * the archetype because that isn't correct if the monster has been
2218 * customized, changed states, etc. 2013 * customized, changed states, etc.
2219 */ 2014 */
2220 2015
2221int 2016int
2222find_free_spot (const object *ob, mapstruct *m, int x, int y, int start, int stop) 2017find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)
2223{ 2018{
2224 int 2019 int
2225 i, 2020 i,
2226 index = 0, flag; 2021 index = 0, flag;
2227 static int 2022 static int
2239 * if the space being examined only has a wall to the north and empty 2034 * if the space being examined only has a wall to the north and empty
2240 * spaces in all the other directions, this will reduce the search space 2035 * spaces in all the other directions, this will reduce the search space
2241 * to only the spaces immediately surrounding the target area, and 2036 * to only the spaces immediately surrounding the target area, and
2242 * won't look 2 spaces south of the target space. 2037 * won't look 2 spaces south of the target space.
2243 */ 2038 */
2244 else if ((flag & AB_NO_PASS) && maxfree[i] < stop) 2039 else if ((flag & P_NO_PASS) && maxfree[i] < stop)
2245 stop = maxfree[i]; 2040 stop = maxfree[i];
2246 } 2041 }
2042
2247 if (!index) 2043 if (!index)
2248 return -1; 2044 return -1;
2045
2249 return altern[RANDOM () % index]; 2046 return altern[RANDOM () % index];
2250} 2047}
2251 2048
2252/* 2049/*
2253 * find_first_free_spot(archetype, mapstruct, x, y) works like 2050 * find_first_free_spot(archetype, maptile, x, y) works like
2254 * find_free_spot(), but it will search max number of squares. 2051 * find_free_spot(), but it will search max number of squares.
2255 * But it will return the first available spot, not a random choice. 2052 * But it will return the first available spot, not a random choice.
2256 * Changed 0.93.2: Have it return -1 if there is no free spot available. 2053 * Changed 0.93.2: Have it return -1 if there is no free spot available.
2257 */ 2054 */
2258 2055
2259int 2056int
2260find_first_free_spot (const object *ob, mapstruct *m, int x, int y) 2057find_first_free_spot (const object *ob, maptile *m, int x, int y)
2261{ 2058{
2262 int 2059 int
2263 i; 2060 i;
2264 2061
2265 for (i = 0; i < SIZEOFFREE; i++) 2062 for (i = 0; i < SIZEOFFREE; i++)
2329 * because we have to know what movement the thing looking to move 2126 * because we have to know what movement the thing looking to move
2330 * there is capable of. 2127 * there is capable of.
2331 */ 2128 */
2332 2129
2333int 2130int
2334find_dir (mapstruct *m, int x, int y, object *exclude) 2131find_dir (maptile *m, int x, int y, object *exclude)
2335{ 2132{
2336 int 2133 int
2337 i, 2134 i,
2338 max = SIZEOFFREE, mflags; 2135 max = SIZEOFFREE, mflags;
2339 2136
2340 sint16 nx, ny; 2137 sint16 nx, ny;
2341 object * 2138 object *
2342 tmp; 2139 tmp;
2343 mapstruct * 2140 maptile *
2344 mp; 2141 mp;
2345 2142
2346 MoveType blocked, move_type; 2143 MoveType blocked, move_type;
2347 2144
2348 if (exclude && exclude->head) 2145 if (exclude && exclude->head)
2361 mp = m; 2158 mp = m;
2362 nx = x + freearr_x[i]; 2159 nx = x + freearr_x[i];
2363 ny = y + freearr_y[i]; 2160 ny = y + freearr_y[i];
2364 2161
2365 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2162 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);
2163
2366 if (mflags & P_OUT_OF_MAP) 2164 if (mflags & P_OUT_OF_MAP)
2367 {
2368 max = maxfree[i]; 2165 max = maxfree[i];
2369 }
2370 else 2166 else
2371 { 2167 {
2372 blocked = GET_MAP_MOVE_BLOCK (mp, nx, ny); 2168 blocked = GET_MAP_MOVE_BLOCK (mp, nx, ny);
2373 2169
2374 if ((move_type & blocked) == move_type) 2170 if ((move_type & blocked) == move_type)
2375 {
2376 max = maxfree[i]; 2171 max = maxfree[i];
2377 }
2378 else if (mflags & P_IS_ALIVE) 2172 else if (mflags & P_IS_ALIVE)
2379 { 2173 {
2380 for (tmp = GET_MAP_OB (mp, nx, ny); tmp != NULL; tmp = tmp->above) 2174 for (tmp = GET_MAP_OB (mp, nx, ny); tmp; tmp = tmp->above)
2381 {
2382 if ((QUERY_FLAG (tmp, FLAG_MONSTER) || tmp->type == PLAYER) && (tmp != exclude || (tmp->head && tmp->head != exclude))) 2175 if ((QUERY_FLAG (tmp, FLAG_MONSTER) || tmp->type == PLAYER) && (tmp != exclude || (tmp->head && tmp->head != exclude)))
2383 {
2384 break; 2176 break;
2385 } 2177
2386 }
2387 if (tmp) 2178 if (tmp)
2388 {
2389 return freedir[i]; 2179 return freedir[i];
2390 }
2391 } 2180 }
2392 } 2181 }
2393 } 2182 }
2183
2394 return 0; 2184 return 0;
2395} 2185}
2396 2186
2397/* 2187/*
2398 * distance(object 1, object 2) will return the square of the 2188 * distance(object 1, object 2) will return the square of the
2400 */ 2190 */
2401 2191
2402int 2192int
2403distance (const object *ob1, const object *ob2) 2193distance (const object *ob1, const object *ob2)
2404{ 2194{
2405 int 2195 int i;
2406 i;
2407 2196
2408 i = (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y); 2197 i = (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2409 return i; 2198 return i;
2410} 2199}
2411 2200
2416 */ 2205 */
2417 2206
2418int 2207int
2419find_dir_2 (int x, int y) 2208find_dir_2 (int x, int y)
2420{ 2209{
2421 int 2210 int q;
2422 q;
2423 2211
2424 if (y) 2212 if (y)
2425 q = x * 100 / y; 2213 q = x * 100 / y;
2426 else if (x) 2214 else if (x)
2427 q = -300 * x; 2215 q = -300 * x;
2553 * find a path to that monster that we found. If not, 2341 * find a path to that monster that we found. If not,
2554 * we don't bother going toward it. Returns 1 if we 2342 * we don't bother going toward it. Returns 1 if we
2555 * can see a direct way to get it 2343 * can see a direct way to get it
2556 * Modified to be map tile aware -.MSW 2344 * Modified to be map tile aware -.MSW
2557 */ 2345 */
2558
2559
2560int 2346int
2561can_see_monsterP (mapstruct *m, int x, int y, int dir) 2347can_see_monsterP (maptile *m, int x, int y, int dir)
2562{ 2348{
2563 sint16 dx, dy; 2349 sint16 dx, dy;
2564 int
2565 mflags; 2350 int mflags;
2566 2351
2567 if (dir < 0) 2352 if (dir < 0)
2568 return 0; /* exit condition: invalid direction */ 2353 return 0; /* exit condition: invalid direction */
2569 2354
2570 dx = x + freearr_x[dir]; 2355 dx = x + freearr_x[dir];
2583 return 0; 2368 return 0;
2584 2369
2585 /* yes, can see. */ 2370 /* yes, can see. */
2586 if (dir < 9) 2371 if (dir < 9)
2587 return 1; 2372 return 1;
2373
2588 return can_see_monsterP (m, x, y, reduction_dir[dir][0]) | 2374 return can_see_monsterP (m, x, y, reduction_dir[dir][0])
2589 can_see_monsterP (m, x, y, reduction_dir[dir][1]) | can_see_monsterP (m, x, y, reduction_dir[dir][2]); 2375 | can_see_monsterP (m, x, y, reduction_dir[dir][1])
2376 | can_see_monsterP (m, x, y, reduction_dir[dir][2]);
2590} 2377}
2591
2592
2593 2378
2594/* 2379/*
2595 * can_pick(picker, item): finds out if an object is possible to be 2380 * can_pick(picker, item): finds out if an object is possible to be
2596 * picked up by the picker. Returnes 1 if it can be 2381 * picked up by the picker. Returnes 1 if it can be
2597 * picked up, otherwise 0. 2382 * picked up, otherwise 0.
2608 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2393 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2609 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2394 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2610 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2395 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));
2611} 2396}
2612 2397
2613
2614/* 2398/*
2615 * create clone from object to another 2399 * create clone from object to another
2616 */ 2400 */
2617object * 2401object *
2618object_create_clone (object *asrc) 2402object_create_clone (object *asrc)
2619{ 2403{
2620 object *
2621 dst = NULL, *tmp, *src, *part, *prev, *item; 2404 object *dst = 0, *tmp, *src, *part, *prev, *item;
2622 2405
2623 if (!asrc) 2406 if (!asrc)
2624 return NULL; 2407 return 0;
2408
2625 src = asrc; 2409 src = asrc;
2626 if (src->head) 2410 if (src->head)
2627 src = src->head; 2411 src = src->head;
2628 2412
2629 prev = NULL; 2413 prev = 0;
2630 for (part = src; part; part = part->more) 2414 for (part = src; part; part = part->more)
2631 { 2415 {
2632 tmp = get_object (); 2416 tmp = part->clone ();
2633 copy_object (part, tmp);
2634 tmp->x -= src->x; 2417 tmp->x -= src->x;
2635 tmp->y -= src->y; 2418 tmp->y -= src->y;
2419
2636 if (!part->head) 2420 if (!part->head)
2637 { 2421 {
2638 dst = tmp; 2422 dst = tmp;
2639 tmp->head = NULL; 2423 tmp->head = 0;
2640 } 2424 }
2641 else 2425 else
2642 {
2643 tmp->head = dst; 2426 tmp->head = dst;
2644 } 2427
2645 tmp->more = NULL; 2428 tmp->more = 0;
2429
2646 if (prev) 2430 if (prev)
2647 prev->more = tmp; 2431 prev->more = tmp;
2432
2648 prev = tmp; 2433 prev = tmp;
2649 } 2434 }
2650 2435
2651 /*** copy inventory ***/
2652 for (item = src->inv; item; item = item->below) 2436 for (item = src->inv; item; item = item->below)
2653 {
2654 (void) insert_ob_in_ob (object_create_clone (item), dst); 2437 insert_ob_in_ob (object_create_clone (item), dst);
2655 }
2656 2438
2657 return dst; 2439 return dst;
2658} 2440}
2659 2441
2660/* return true if the object was destroyed, 0 otherwise */
2661int
2662was_destroyed (const object *op, tag_t old_tag)
2663{
2664 /* checking for FLAG_FREED isn't necessary, but makes this function more
2665 * robust */
2666 return op->count != old_tag || QUERY_FLAG (op, FLAG_FREED);
2667}
2668
2669/* GROS - Creates an object using a string representing its content. */ 2442/* GROS - Creates an object using a string representing its content. */
2670
2671/* Basically, we save the content of the string to a temp file, then call */ 2443/* Basically, we save the content of the string to a temp file, then call */
2672
2673/* load_object on it. I admit it is a highly inefficient way to make things, */ 2444/* load_object on it. I admit it is a highly inefficient way to make things, */
2674
2675/* but it was simple to make and allows reusing the load_object function. */ 2445/* but it was simple to make and allows reusing the load_object function. */
2676
2677/* Remember not to use load_object_str in a time-critical situation. */ 2446/* Remember not to use load_object_str in a time-critical situation. */
2678
2679/* Also remember that multiparts objects are not supported for now. */ 2447/* Also remember that multiparts objects are not supported for now. */
2680 2448
2681object * 2449object *
2682load_object_str (const char *obstr) 2450load_object_str (const char *obstr)
2683{ 2451{
2684 object * 2452 object *op;
2685 op;
2686 char
2687 filename[MAX_BUF]; 2453 char filename[MAX_BUF];
2688 2454
2689 sprintf (filename, "%s/cfloadobstr2044", settings.tmpdir); 2455 sprintf (filename, "%s/cfloadobstr2044", settings.tmpdir);
2690 2456
2691 FILE *
2692 tempfile = fopen (filename, "w"); 2457 FILE *tempfile = fopen (filename, "w");
2693 2458
2694 if (tempfile == NULL) 2459 if (tempfile == NULL)
2695 { 2460 {
2696 LOG (llevError, "Error - Unable to access load object temp file\n"); 2461 LOG (llevError, "Error - Unable to access load object temp file\n");
2697 return NULL; 2462 return NULL;
2698 } 2463 }
2699 2464
2700 fprintf (tempfile, obstr); 2465 fprintf (tempfile, obstr);
2701 fclose (tempfile); 2466 fclose (tempfile);
2702 2467
2703 op = get_object (); 2468 op = object::create ();
2704 2469
2705 object_thawer thawer (filename); 2470 object_thawer thawer (filename);
2706 2471
2707 if (thawer) 2472 if (thawer)
2708 load_object (thawer, op, 0); 2473 load_object (thawer, op, 0);
2718 * returns NULL if no match. 2483 * returns NULL if no match.
2719 */ 2484 */
2720object * 2485object *
2721find_obj_by_type_subtype (const object *who, int type, int subtype) 2486find_obj_by_type_subtype (const object *who, int type, int subtype)
2722{ 2487{
2723 object * 2488 object *tmp;
2724 tmp;
2725 2489
2726 for (tmp = who->inv; tmp; tmp = tmp->below) 2490 for (tmp = who->inv; tmp; tmp = tmp->below)
2727 if (tmp->type == type && tmp->subtype == subtype) 2491 if (tmp->type == type && tmp->subtype == subtype)
2728 return tmp; 2492 return tmp;
2729 2493
2737 * do the desired thing. 2501 * do the desired thing.
2738 */ 2502 */
2739key_value * 2503key_value *
2740get_ob_key_link (const object *ob, const char *key) 2504get_ob_key_link (const object *ob, const char *key)
2741{ 2505{
2742 key_value * 2506 key_value *link;
2743 link;
2744 2507
2745 for (link = ob->key_values; link != NULL; link = link->next) 2508 for (link = ob->key_values; link != NULL; link = link->next)
2746 {
2747 if (link->key == key) 2509 if (link->key == key)
2748 {
2749 return link; 2510 return link;
2750 }
2751 }
2752 2511
2753 return NULL; 2512 return NULL;
2754} 2513}
2755 2514
2756/* 2515/*

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines