--- deliantra/server/common/object.C 2006/09/11 12:10:21 1.28 +++ deliantra/server/common/object.C 2006/12/03 02:46:33 1.57 @@ -18,7 +18,7 @@ along with this program; if not, write to the Free Software Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. - The authors can be reached via e-mail at crossfire-devel@real-time.com + The authors can be reached via e-mail at */ /* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects. @@ -30,12 +30,12 @@ #include #include #include -#include #include int nrofallocobjects = 0; +static UUID uuid; +const uint64 UUID_SKIP = 1<<19; -object *objects; /* Pointer to the list of used objects */ object *active_objects; /* List of active objects that need to be processed */ short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, @@ -52,6 +52,83 @@ 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8 }; +static void +write_uuid (void) +{ + char filename1[MAX_BUF], filename2[MAX_BUF]; + + sprintf (filename1, "%s/uuid", settings.localdir); + sprintf (filename2, "%s/uuid~", settings.localdir); + + FILE *fp; + + if (!(fp = fopen (filename2, "w"))) + { + LOG (llevError, "ERROR: cannot open %s for writing, unable to write UUID!\n", filename2); + return; + } + + fprintf (fp, "<1,%llx>\n", (unsigned long long)uuid.seq + UUID_SKIP * 2); + fclose (fp); + rename (filename2, filename1); +} + +static void +read_uuid (void) +{ + char filename[MAX_BUF]; + + sprintf (filename, "%s/uuid", settings.localdir); + + FILE *fp; + + if (!(fp = fopen (filename, "r"))) + { + if (errno == ENOENT) + { + LOG (llevInfo, "RESET uid to 1\n"); + uuid.seq = 0; + write_uuid (); + return; + } + + LOG (llevError, "FATAL: cannot open %s for reading!\n", filename); + _exit (1); + } + + int version; + unsigned long long uid; + if (2 != fscanf (fp, "<%d,%llx>\n", &version, &uid) || version != 1) + { + LOG (llevError, "FATAL: error reading uid from %s!\n", filename); + _exit (1); + } + + uuid.seq = uid; + write_uuid (); + LOG (llevDebug, "read UID: %lld\n", uid); + fclose (fp); +} + +UUID +gen_uuid () +{ + UUID uid; + + uid.seq = ++uuid.seq; + + if (!(uuid.seq & (UUID_SKIP - 1))) + write_uuid (); + + return uid; +} + +void +init_uuid () +{ + read_uuid (); +} + /* Returns TRUE if every key_values in wants has a partner with the same value in has. */ static int compare_ob_value_lists_one (const object *wants, const object *has) @@ -209,10 +286,10 @@ switch (ob1->type) { - case SCROLL: - if (ob1->level != ob2->level) - return 0; - break; + case SCROLL: + if (ob1->level != ob2->level) + return 0; + break; } if (ob1->key_values != NULL || ob2->key_values != NULL) @@ -256,10 +333,13 @@ sum_weight (inv); sum += inv->carrying + inv->weight * (inv->nrof ? inv->nrof : 1); } + if (op->type == CONTAINER && op->stats.Str) sum = (sum * (100 - op->stats.Str)) / 100; + if (op->carrying != sum) op->carrying = sum; + return sum; } @@ -296,82 +376,15 @@ * The result of the dump is stored in the static global errmsg array. */ -void -dump_object2 (object *op) -{ - errmsg[0] = 0; - return; - //TODO//D#d# -#if 0 - char *cp; - -/* object *tmp;*/ - - if (op->arch != NULL) - { - strcat (errmsg, "arch "); - strcat (errmsg, op->arch->name ? op->arch->name : "(null)"); - strcat (errmsg, "\n"); - if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL) - strcat (errmsg, cp); -# if 0 - /* Don't dump player diffs - they are too long, mostly meaningless, and - * will overflow the buffer. - * Changed so that we don't dump inventory either. This may - * also overflow the buffer. - */ - if (op->type != PLAYER && (cp = get_ob_diff (op, &empty_archetype->clone)) != NULL) - strcat (errmsg, cp); - for (tmp = op->inv; tmp; tmp = tmp->below) - dump_object2 (tmp); -# endif - strcat (errmsg, "end\n"); - } - else - { - strcat (errmsg, "Object "); - if (op->name == NULL) - strcat (errmsg, "(null)"); - else - strcat (errmsg, op->name); - strcat (errmsg, "\n"); -# if 0 - if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL) - strcat (errmsg, cp); - for (tmp = op->inv; tmp; tmp = tmp->below) - dump_object2 (tmp); -# endif - strcat (errmsg, "end\n"); - } -#endif -} - -/* - * Dumps an object. Returns output in the static global errmsg array. - */ - -void +char * dump_object (object *op) { - if (op == NULL) - { - strcpy (errmsg, "[NULL pointer]"); - return; - } - errmsg[0] = '\0'; - dump_object2 (op); -} - -void -dump_all_objects (void) -{ - object *op; + if (!op) + return strdup ("[NULLOBJ]"); - for (op = objects; op != NULL; op = op->next) - { - dump_object (op); - fprintf (logfile, "Object %d\n:%s\n", op->count, errmsg); - } + object_freezer freezer; + save_object (freezer, op, 3); + return freezer.as_string (); } /* @@ -401,12 +414,11 @@ object * find_object (tag_t i) { - object *op; - - for (op = objects; op != NULL; op = op->next) + for (object *op = object::first; op; op = op->next) if (op->count == i) - break; - return op; + return op; + + return 0; } /* @@ -418,11 +430,11 @@ object * find_object_name (const char *str) { - const char *name = shstr::find (str); + shstr_cmp str_ (str); object *op; - for (op = objects; op != NULL; op = op->next) - if (&op->name == name) + for (op = object::first; op != NULL; op = op->next) + if (op->name == str_) break; return op; @@ -435,51 +447,13 @@ } /* - * Returns the object which this object marks as being the owner. - * A id-scheme is used to avoid pointing to objects which have been - * freed and are now reused. If this is detected, the owner is - * set to NULL, and NULL is returned. - * Changed 2004-02-12 - if the player is setting at the play again - * prompt, he is removed, and we don't want to treat him as an owner of - * anything, so check removed flag. I don't expect that this should break - * anything - once an object is removed, it is basically dead anyways. - */ - -object * -get_owner (object *op) -{ - if (op->owner == NULL) - return NULL; - - if (!QUERY_FLAG (op->owner, FLAG_FREED) && !QUERY_FLAG (op->owner, FLAG_REMOVED) && op->owner->count == op->ownercount) - return op->owner; - - op->owner = NULL; - op->ownercount = 0; - return NULL; -} - -void -clear_owner (object *op) -{ - if (!op) - return; - - if (op->owner && op->ownercount == op->owner->count) - op->owner->refcount--; - - op->owner = NULL; - op->ownercount = 0; -} - -/* * Sets the owner and sets the skill and exp pointers to owner's current * skill and experience objects. */ void -set_owner (object *op, object *owner) +object::set_owner (object *owner) { - if (owner == NULL || op == NULL) + if (!owner) return; /* next line added to allow objects which own objects */ @@ -489,48 +463,10 @@ * freed and then another object replacing it. Since the ownercounts * didn't match, this check is valid and I believe that cause is valid. */ - while (owner->owner && owner != owner->owner && owner->ownercount == owner->owner->count) + while (owner->owner) owner = owner->owner; - /* IF the owner still has an owner, we did not resolve to a final owner. - * so lets not add to that. - */ - if (owner->owner) - return; - - op->owner = owner; - - op->ownercount = owner->count; - owner->refcount++; -} - -/* Set the owner to clone's current owner and set the skill and experience - * objects to clone's objects (typically those objects that where the owner's - * current skill and experience objects at the time when clone's owner was - * set - not the owner's current skill and experience objects). - * - * Use this function if player created an object (e.g. fire bullet, swarm - * spell), and this object creates further objects whose kills should be - * accounted for the player's original skill, even if player has changed - * skills meanwhile. - */ -void -copy_owner (object *op, object *clone) -{ - object *owner = get_owner (clone); - - if (owner == NULL) - { - /* players don't have owners - they own themselves. Update - * as appropriate. - */ - if (clone->type == PLAYER) - owner = clone; - else - return; - } - - set_owner (op, owner); + this->owner = owner; } /* Zero the key_values on op, decrementing the shared-string @@ -556,8 +492,7 @@ free_key_values (this); - clear_owner (this); - + owner = 0; name = 0; name_pl = 0; title = 0; @@ -568,54 +503,41 @@ lore = 0; custom_name = 0; materialname = 0; + contr = 0; + below = 0; + above = 0; + inv = 0; + container = 0; + env = 0; + more = 0; + head = 0; + map = 0; + active_next = 0; + active_prev = 0; - memset (static_cast < object_pod * >(this), 0, sizeof (object_pod)); + memset (static_cast(this), 0, sizeof (object_pod)); SET_FLAG (this, FLAG_REMOVED); + + /* What is not cleared is next, prev, and count */ + + expmul = 1.0; + face = blank_face; + + if (settings.casting_time) + casting_time = -1; } void object::clone (object *destination) { - *(object_copy *) destination = *this; - *(object_pod *) destination = *this; + *(object_copy *)destination = *this; + *(object_pod *)destination = *this; if (self || cb) INVOKE_OBJECT (CLONE, this, ARG_OBJECT (destination)); } /* - * clear_object() frees everything allocated by an object, and also - * clears all variables and flags to default settings. - */ - -void -clear_object (object *op) -{ - op->clear (); - - op->contr = NULL; - op->below = NULL; - op->above = NULL; - op->inv = NULL; - op->container = NULL; - op->env = NULL; - op->more = NULL; - op->head = NULL; - op->map = NULL; - op->refcount = 0; - op->active_next = NULL; - op->active_prev = NULL; - /* What is not cleared is next, prev, and count */ - - op->expmul = 1.0; - op->face = blank_face; - op->attacked_by_count = -1; - - if (settings.casting_time) - op->casting_time = -1; -} - -/* * copy object first frees everything allocated by the second object, * and then copies the contends of the first object into the second * object, allocating what needs to be allocated. Basically, any @@ -623,7 +545,6 @@ * if the first object is freed, the pointers in the new object * will point at garbage. */ - void copy_object (object *op2, object *op) { @@ -693,7 +614,6 @@ * value, or vice versa, then add/remove the object from the active list. * This function needs to be called whenever the speed of an object changes. */ - void update_ob_speed (object *op) { @@ -712,10 +632,10 @@ op->speed = 0; #endif } + if (arch_init) - { - return; - } + return; + if (FABS (op->speed) > MIN_ACTIVE_SPEED) { /* If already on active list, don't do anything */ @@ -725,8 +645,10 @@ /* process_events() expects us to insert the object at the beginning * of the list. */ op->active_next = active_objects; + if (op->active_next != NULL) op->active_next->active_prev = op; + active_objects = op; } else @@ -738,15 +660,18 @@ if (op->active_prev == NULL) { active_objects = op->active_next; + if (op->active_next != NULL) op->active_next->active_prev = NULL; } else { op->active_prev->active_next = op->active_next; + if (op->active_next) op->active_next->active_prev = op->active_prev; } + op->active_next = NULL; op->active_prev = NULL; } @@ -888,7 +813,7 @@ else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) update_now = 1; else if (action == UP_OBJ_FACE) - /* Nothing to do for that case */; + /* Nothing to do for that case */ ; else LOG (llevError, "update_object called with invalid action: %d\n", action); @@ -902,19 +827,28 @@ update_object (op->more, action); } -static unordered_vector mortals; -static std::vector freed; +object::vector object::mortals; +object::vector object::objects; // not yet used +object *object::first; void object::free_mortals () { - for (unordered_vector::iterator i = mortals.begin (); i != mortals.end (); ) - if (!(*i)->refcount) + for (AUTODECL (i, mortals.begin ()); i != mortals.end ();) + if ((*i)->refcnt) + ++i; // further delay freeing + else { - freed.push_back (*i); + delete *i; mortals.erase (i); } - else - ++i; + + static int lastmortals = 0;//D + + if (mortals.size() != lastmortals && lastmortals > 100)//D + { + lastmortals = mortals.size ();//D + LOG (llevDebug, "%d objects in mortal queue\n", lastmortals);//D + } } object::object () @@ -923,7 +857,6 @@ expmul = 1.0; face = blank_face; - attacked_by_count = -1; } object::~object () @@ -934,51 +867,33 @@ void object::link () { count = ++ob_count; + uuid = gen_uuid (); prev = 0; - next = objects; + next = object::first; - if (objects) - objects->prev = this; + if (object::first) + object::first->prev = this; - objects = this; + object::first = this; } void object::unlink () { - count = 0; + if (this == object::first) + object::first = next; /* Remove this object from the list of used objects */ - if (prev) - { - prev->next = next; - prev = 0; - } - - if (next) - { - next->prev = prev; - next = 0; - } + if (prev) prev->next = next; + if (next) next->prev = prev; - if (this == objects) - objects = next; + prev = 0; + next = 0; } object *object::create () { - object *op; - - if (freed.empty ()) - op = new object; - else - { - // highly annoying, but the only way to get it stable right now - op = freed.back (); freed.pop_back (); - op->~object (); - new ((void *)op) object; - } - + object *op = new object; op->link (); return op; } @@ -990,36 +905,25 @@ * The object must have been removed by remove_ob() first for * this function to succeed. * - * If free_inventory is set, free inventory as well. Else drop items in + * If destroy_inventory is set, free inventory as well. Else drop items in * inventory to the ground. */ -void object::free (bool free_inventory) +void object::destroy (bool destroy_inventory) { - if (!QUERY_FLAG (this, FLAG_REMOVED)) - { - LOG (llevDebug, "Free object called with non removed object\n"); - dump_object (this); -#ifdef MANY_CORES - abort (); -#endif - } + if (QUERY_FLAG (this, FLAG_FREED)) + return; if (QUERY_FLAG (this, FLAG_FRIENDLY)) - { - LOG (llevMonster, "Warning: tried to free friendly object.\n"); - remove_friendly_object (this); - } + remove_friendly_object (this); - if (QUERY_FLAG (this, FLAG_FREED)) - { - dump_object (this); - LOG (llevError, "Trying to free freed object.\n%s\n", errmsg); - return; - } + if (!QUERY_FLAG (this, FLAG_REMOVED)) + remove_ob (this); + + SET_FLAG (this, FLAG_FREED); if (more) { - more->free (free_inventory); + more->destroy (destroy_inventory); more = 0; } @@ -1029,30 +933,24 @@ * if some form of movement is allowed, let objects * drop on that space. */ - if (free_inventory || !map || map->in_memory != MAP_IN_MEMORY || (GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL)) + if (destroy_inventory || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL) { - object * - op = inv; + object *op = inv; while (op) { - object * - tmp = op->below; - - remove_ob (op); - op->free (free_inventory); + object *tmp = op->below; + op->destroy (destroy_inventory); op = tmp; } } else { /* Put objects in inventory onto this space */ - object * - op = inv; + object *op = inv; while (op) { - object * - tmp = op->below; + object *tmp = op->below; remove_ob (op); @@ -1071,7 +969,33 @@ } } - clear_owner (this); + // hack to ensure that freed objects still have a valid map + { + static maptile *freed_map; // freed objects are moved here to avoid crashes + + if (!freed_map) + { + freed_map = new maptile; + + freed_map->name = "/internal/freed_objects_map"; + freed_map->width = 3; + freed_map->height = 3; + + freed_map->allocate (); + } + + map = freed_map; + x = 1; + y = 1; + } + + // clear those pointers that likely might have circular references to us + owner = 0; + enemy = 0; + attacked_by = 0; + + // only relevant for players(?), but make sure of it anyways + contr = 0; /* Remove object from the active list */ speed = 0; @@ -1079,8 +1003,6 @@ unlink (); - SET_FLAG (this, FLAG_FREED); - mortals.push_back (this); } @@ -1095,9 +1017,8 @@ while (op != NULL) { if (op->type == CONTAINER) - { - weight = (signed long) (weight * (100 - op->stats.Str) / 100); - } + weight = (signed long) (weight * (100 - op->stats.Str) / 100); + op->carrying -= weight; op = op->env; } @@ -1115,38 +1036,22 @@ void remove_ob (object *op) { - object *tmp, *last = NULL; + object *tmp, *last = 0; object *otmp; - tag_t tag; int check_walk_off; - mapstruct *m; + maptile *m; sint16 x, y; if (QUERY_FLAG (op, FLAG_REMOVED)) - { - dump_object (op); - LOG (llevError, "Trying to remove removed object.\n%s\n", errmsg); + return; - /* Changed it to always dump core in this case. As has been learned - * in the past, trying to recover from errors almost always - * make things worse, and this is a real error here - something - * that should not happen. - * Yes, if this was a mission critical app, trying to do something - * to recover may make sense, but that is because failure of the app - * may have other disastrous problems. Cf runs out of a script - * so is easily enough restarted without any real problems. - * MSW 2001-07-01 - */ - abort (); - } + SET_FLAG (op, FLAG_REMOVED); if (op->more != NULL) remove_ob (op->more); - SET_FLAG (op, FLAG_REMOVED); - /* * In this case, the object to be removed is in someones * inventory. @@ -1181,128 +1086,126 @@ op->map = op->env->map; op->above = NULL, op->below = NULL; op->env = NULL; - return; } + else if (op->map) + { + x = op->x; + y = op->y; + m = get_map_from_coord (op->map, &x, &y); + + if (!m) + { + LOG (llevError, "remove_ob called when object was on map but appears to not be within valid coordinates? %s (%d,%d)\n", + op->map->path, op->x, op->y); + /* in old days, we used to set x and y to 0 and continue. + * it seems if we get into this case, something is probablye + * screwed up and should be fixed. + */ + abort (); + } - /* If we get here, we are removing it from a map */ - if (op->map == NULL) - return; - - x = op->x; - y = op->y; - m = get_map_from_coord (op->map, &x, &y); + if (op->map != m) + LOG (llevDebug, "remove_ob: Object not really on map it claimed to be on? %s != %s, %d,%d != %d,%d\n", + op->map->path, m->path, op->x, op->y, x, y); - if (!m) - { - LOG (llevError, "remove_ob called when object was on map but appears to not be within valid coordinates? %s (%d,%d)\n", - op->map->path, op->x, op->y); - /* in old days, we used to set x and y to 0 and continue. - * it seems if we get into this case, something is probablye - * screwed up and should be fixed. + /* Re did the following section of code - it looks like it had + * lots of logic for things we no longer care about */ - abort (); - } - if (op->map != m) - { - LOG (llevDebug, "remove_ob: Object not really on map it claimed to be on? %s != %s, %d,%d != %d,%d\n", - op->map->path, m->path, op->x, op->y, x, y); - } - - /* Re did the following section of code - it looks like it had - * lots of logic for things we no longer care about - */ - /* link the object above us */ - if (op->above) - op->above->below = op->below; - else - SET_MAP_TOP (m, x, y, op->below); /* we were top, set new top */ + /* link the object above us */ + if (op->above) + op->above->below = op->below; + else + SET_MAP_TOP (m, x, y, op->below); /* we were top, set new top */ - /* Relink the object below us, if there is one */ - if (op->below) - op->below->above = op->above; - else - { - /* Nothing below, which means we need to relink map object for this space - * use translated coordinates in case some oddness with map tiling is - * evident - */ - if (GET_MAP_OB (m, x, y) != op) + /* Relink the object below us, if there is one */ + if (op->below) + op->below->above = op->above; + else { - dump_object (op); - LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", - errmsg); - dump_object (GET_MAP_OB (m, x, y)); - LOG (llevError, "%s\n", errmsg); - } - - SET_MAP_OB (m, x, y, op->above); /* goes on above it. */ - } + /* Nothing below, which means we need to relink map object for this space + * use translated coordinates in case some oddness with map tiling is + * evident + */ + if (GET_MAP_OB (m, x, y) != op) + { + char *dump = dump_object (op); + LOG (llevError, + "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", dump); + free (dump); + dump = dump_object (GET_MAP_OB (m, x, y)); + LOG (llevError, "%s\n", dump); + free (dump); + } - op->above = NULL; - op->below = NULL; + SET_MAP_OB (m, x, y, op->above); /* goes on above it. */ + } - if (op->map->in_memory == MAP_SAVING) - return; + op->above = 0; + op->below = 0; - tag = op->count; - check_walk_off = !QUERY_FLAG (op, FLAG_NO_APPLY); + if (op->map->in_memory == MAP_SAVING) + return; - for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) - { - /* No point updating the players look faces if he is the object - * being removed. - */ + check_walk_off = !QUERY_FLAG (op, FLAG_NO_APPLY); - if (tmp->type == PLAYER && tmp != op) + for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) { - /* If a container that the player is currently using somehow gets - * removed (most likely destroyed), update the player view - * appropriately. + /* No point updating the players look faces if he is the object + * being removed. */ - if (tmp->container == op) + + if (tmp->type == PLAYER && tmp != op) { - CLEAR_FLAG (op, FLAG_APPLIED); - tmp->container = NULL; - } + /* If a container that the player is currently using somehow gets + * removed (most likely destroyed), update the player view + * appropriately. + */ + if (tmp->container == op) + { + CLEAR_FLAG (op, FLAG_APPLIED); + tmp->container = NULL; + } - tmp->contr->socket.update_look = 1; - } - /* See if player moving off should effect something */ - if (check_walk_off && ((op->move_type & tmp->move_off) && (op->move_type & ~tmp->move_off & ~tmp->move_block) == 0)) - { - move_apply (tmp, op, NULL); + tmp->contr->socket.update_look = 1; + } - if (was_destroyed (op, tag)) + /* See if player moving off should effect something */ + if (check_walk_off + && ((op->move_type & tmp->move_off) + && (op->move_type & ~tmp->move_off & ~tmp->move_block) == 0)) { - LOG (llevError, "BUG: remove_ob(): name %s, archname %s destroyed " "leaving object\n", &tmp->name, &tmp->arch->name); + move_apply (tmp, op, NULL); + + if (op->destroyed ()) + LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ()); } - } - /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */ + /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */ - if (tmp->above == tmp) - tmp->above = NULL; + if (tmp->above == tmp) + tmp->above = NULL; - last = tmp; - } + last = tmp; + } - /* last == NULL of there are no objects on this space */ - if (last == NULL) - { - /* set P_NEED_UPDATE, otherwise update_position will complain. In theory, - * we could preserve the flags (GET_MAP_FLAGS), but update_position figures - * those out anyways, and if there are any flags set right now, they won't - * be correct anyways. - */ - SET_MAP_FLAGS (op->map, op->x, op->y, P_NEED_UPDATE); - update_position (op->map, op->x, op->y); - } - else - update_object (last, UP_OBJ_REMOVE); + /* last == NULL of there are no objects on this space */ + if (last == NULL) + { + /* set P_NEED_UPDATE, otherwise update_position will complain. In theory, + * we could preserve the flags (GET_MAP_FLAGS), but update_position figures + * those out anyways, and if there are any flags set right now, they won't + * be correct anyways. + */ + SET_MAP_FLAGS (op->map, op->x, op->y, P_NEED_UPDATE); + update_position (op->map, op->x, op->y); + } + else + update_object (last, UP_OBJ_REMOVE); - if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) || (op->glow_radius != 0)) - update_all_los (op->map, op->x, op->y); + if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) || (op->glow_radius != 0)) + update_all_los (op->map, op->x, op->y); + } } /* @@ -1313,14 +1216,15 @@ * If top is NULL, it is calculated. * Returns pointer to object if it succeded in the merge, otherwise NULL */ - object * merge_ob (object *op, object *top) { if (!op->nrof) return 0; + if (top == NULL) for (top = op; top != NULL && top->above != NULL; top = top->above); + for (; top != NULL; top = top->below) { if (top == op) @@ -1336,7 +1240,8 @@ return top; } } - return NULL; + + return 0; } /* @@ -1344,18 +1249,19 @@ * job preparing multi-part monsters */ object * -insert_ob_in_map_at (object *op, mapstruct *m, object *originator, int flag, int x, int y) +insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) { - object * - tmp; + object *tmp; if (op->head) op = op->head; + for (tmp = op; tmp; tmp = tmp->more) { tmp->x = x + tmp->arch->clone.x; tmp->y = y + tmp->arch->clone.y; } + return insert_ob_in_map (op, m, originator, flag); } @@ -1381,7 +1287,7 @@ */ object * -insert_ob_in_map (object *op, mapstruct *m, object *originator, int flag) +insert_ob_in_map (object *op, maptile *m, object *originator, int flag) { object *tmp, *top, *floor = NULL; sint16 x, y; @@ -1394,15 +1300,16 @@ if (m == NULL) { - dump_object (op); - LOG (llevError, "Trying to insert in null-map!\n%s\n", errmsg); + char *dump = dump_object (op); + LOG (llevError, "Trying to insert in null-map!\n%s\n", dump); + free (dump); return op; } if (out_of_map (m, op->x, op->y)) { - dump_object (op); - LOG (llevError, "Trying to insert object outside the map.\n%s\n", errmsg); + char *dump = dump_object (op); + LOG (llevError, "Trying to insert object outside the map.\n%s\n", dump); #ifdef MANY_CORES /* Better to catch this here, as otherwise the next use of this object * is likely to cause a crash. Better to find out where it is getting @@ -1410,13 +1317,15 @@ */ abort (); #endif + free (dump); return op; } if (!QUERY_FLAG (op, FLAG_REMOVED)) { - dump_object (op); - LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", errmsg); + char *dump = dump_object (op); + LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", dump); + free (dump); return op; } @@ -1656,8 +1565,10 @@ void replace_insert_ob_in_map (const char *arch_string, object *op) { - object *tmp; - object *tmp1; + object * + tmp; + object * + tmp1; /* first search for itself and remove any old instances */ @@ -1670,7 +1581,7 @@ } } - tmp1 = arch_to_object (find_archetype (arch_string)); + tmp1 = arch_to_object (archetype::find (arch_string)); tmp1->x = op->x; tmp1->y = op->y; @@ -1698,7 +1609,9 @@ sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name); return NULL; } + newob = object_create_clone (orig_ob); + if ((orig_ob->nrof -= nr) < 1) { if (!is_removed) @@ -1716,6 +1629,7 @@ return NULL; } } + newob->nrof = nr; return newob; @@ -1732,10 +1646,8 @@ object * decrease_ob_nr (object *op, uint32 i) { - object * - tmp; - player * - pl; + object *tmp; + player *pl; if (i == 0) /* objects with op->nrof require this check */ return op; @@ -1744,9 +1656,7 @@ i = op->nrof; if (QUERY_FLAG (op, FLAG_REMOVED)) - { - op->nrof -= i; - } + op->nrof -= i; else if (op->env != NULL) { /* is this object in the players inventory, or sub container @@ -1791,18 +1701,16 @@ } else { - object * - above = op->above; + object *above = op->above; if (i < op->nrof) - { - op->nrof -= i; - } + op->nrof -= i; else { remove_ob (op); op->nrof = 0; } + /* Since we just removed op, op->above is null */ for (tmp = above; tmp != NULL; tmp = tmp->above) if (tmp->type == PLAYER) @@ -1815,9 +1723,7 @@ } if (op->nrof) - { - return op; - } + return op; else { free_object (op); @@ -1836,9 +1742,8 @@ while (op != NULL) { if (op->type == CONTAINER) - { - weight = (signed long) (weight * (100 - op->stats.Str) / 100); - } + weight = (signed long) (weight * (100 - op->stats.Str) / 100); + op->carrying += weight; op = op->env; } @@ -1867,26 +1772,32 @@ if (!QUERY_FLAG (op, FLAG_REMOVED)) { - dump_object (op); - LOG (llevError, "Trying to insert (ob) inserted object.\n%s\n", errmsg); + char *dump = dump_object (op); + LOG (llevError, "Trying to insert (ob) inserted object.\n%s\n", dump); + free (dump); return op; } + if (where == NULL) { - dump_object (op); - LOG (llevError, "Trying to put object in NULL.\n%s\n", errmsg); + char *dump = dump_object (op); + LOG (llevError, "Trying to put object in NULL.\n%s\n", dump); + free (dump); return op; } + if (where->head) { LOG (llevDebug, "Warning: Tried to insert object wrong part of multipart object.\n"); where = where->head; } + if (op->more) { LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count); return op; } + CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL); CLEAR_FLAG (op, FLAG_REMOVED); if (op->nrof) @@ -1982,8 +1893,7 @@ check_move_on (object *op, object *originator) { object *tmp; - tag_t tag; - mapstruct *m = op->map; + maptile *m = op->map; int x = op->x, y = op->y; MoveType move_on, move_slow, move_block; @@ -1991,8 +1901,6 @@ if (QUERY_FLAG (op, FLAG_NO_APPLY)) return 0; - tag = op->count; - move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y); move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y); move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y); @@ -2044,7 +1952,8 @@ ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0)) { - float diff = tmp->move_slow_penalty * FABS (op->speed); + float + diff = tmp->move_slow_penalty * FABS (op->speed); if (op->type == PLAYER) if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) || @@ -2061,7 +1970,7 @@ { move_apply (tmp, op, originator); - if (was_destroyed (op, tag)) + if (op->destroyed ()) return 1; /* what the person/creature stepped onto has moved the object @@ -2083,7 +1992,7 @@ */ object * -present_arch (const archetype *at, mapstruct *m, int x, int y) +present_arch (const archetype *at, maptile *m, int x, int y) { object * tmp; @@ -2106,7 +2015,7 @@ */ object * -present (unsigned char type, mapstruct *m, int x, int y) +present (unsigned char type, maptile *m, int x, int y) { object * tmp; @@ -2256,7 +2165,7 @@ */ int -find_free_spot (const object *ob, mapstruct *m, int x, int y, int start, int stop) +find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop) { int i, @@ -2287,14 +2196,14 @@ } /* - * find_first_free_spot(archetype, mapstruct, x, y) works like + * find_first_free_spot(archetype, maptile, x, y) works like * find_free_spot(), but it will search max number of squares. * But it will return the first available spot, not a random choice. * Changed 0.93.2: Have it return -1 if there is no free spot available. */ int -find_first_free_spot (const object *ob, mapstruct *m, int x, int y) +find_first_free_spot (const object *ob, maptile *m, int x, int y) { int i; @@ -2368,21 +2277,19 @@ */ int -find_dir (mapstruct *m, int x, int y, object *exclude) +find_dir (maptile *m, int x, int y, object *exclude) { int i, max = SIZEOFFREE, mflags; - sint16 - nx, - ny; + + sint16 nx, ny; object * tmp; - mapstruct * + maptile * mp; - MoveType - blocked, - move_type; + + MoveType blocked, move_type; if (exclude && exclude->head) { @@ -2597,11 +2504,9 @@ int -can_see_monsterP (mapstruct *m, int x, int y, int dir) +can_see_monsterP (maptile *m, int x, int y, int dir) { - sint16 - dx, - dy; + sint16 dx, dy; int mflags; @@ -2689,61 +2594,41 @@ prev = tmp; } - /*** copy inventory ***/ for (item = src->inv; item; item = item->below) - { - (void) insert_ob_in_ob (object_create_clone (item), dst); - } + insert_ob_in_ob (object_create_clone (item), dst); return dst; } -/* return true if the object was destroyed, 0 otherwise */ -int -was_destroyed (const object *op, tag_t old_tag) -{ - /* checking for FLAG_FREED isn't necessary, but makes this function more - * robust */ - return op->count != old_tag || QUERY_FLAG (op, FLAG_FREED); -} - /* GROS - Creates an object using a string representing its content. */ - /* Basically, we save the content of the string to a temp file, then call */ - /* load_object on it. I admit it is a highly inefficient way to make things, */ - /* but it was simple to make and allows reusing the load_object function. */ - /* Remember not to use load_object_str in a time-critical situation. */ - /* Also remember that multiparts objects are not supported for now. */ object * load_object_str (const char *obstr) { - object * - op; - char - filename[MAX_BUF]; + object *op; + char filename[MAX_BUF]; sprintf (filename, "%s/cfloadobstr2044", settings.tmpdir); - FILE * - tempfile = fopen (filename, "w"); + FILE *tempfile = fopen (filename, "w"); if (tempfile == NULL) { LOG (llevError, "Error - Unable to access load object temp file\n"); return NULL; - }; + } + fprintf (tempfile, obstr); fclose (tempfile); op = get_object (); - object_thawer - thawer (filename); + object_thawer thawer (filename); if (thawer) load_object (thawer, op, 0); @@ -2761,8 +2646,7 @@ object * find_obj_by_type_subtype (const object *who, int type, int subtype) { - object * - tmp; + object *tmp; for (tmp = who->inv; tmp; tmp = tmp->below) if (tmp->type == type && tmp->subtype == subtype) @@ -2780,16 +2664,11 @@ key_value * get_ob_key_link (const object *ob, const char *key) { - key_value * - link; + key_value *link; for (link = ob->key_values; link != NULL; link = link->next) - { - if (link->key == key) - { - return link; - } - } + if (link->key == key) + return link; return NULL; } @@ -2804,34 +2683,27 @@ const char * get_ob_key_value (const object *op, const char *const key) { - key_value * - link; - const char * - canonical_key; + key_value *link; + shstr_cmp canonical_key (key); - canonical_key = shstr::find (key); - - if (canonical_key == NULL) + if (!canonical_key) { /* 1. There being a field named key on any object * implies there'd be a shared string to find. * 2. Since there isn't, no object has this field. * 3. Therefore, *this* object doesn't have this field. */ - return NULL; + return 0; } /* This is copied from get_ob_key_link() above - * only 4 lines, and saves the function call overhead. */ - for (link = op->key_values; link != NULL; link = link->next) - { - if (link->key == canonical_key) - { - return link->value; - } - } - return NULL; + for (link = op->key_values; link; link = link->next) + if (link->key == canonical_key) + return link->value; + + return 0; } @@ -2877,8 +2749,7 @@ else op->key_values = field->next; - delete - field; + delete field; } } return TRUE; @@ -2923,8 +2794,58 @@ int set_ob_key_value (object *op, const char *key, const char *value, int add_key) { - shstr - key_ (key); + shstr key_ (key); return set_ob_key_value_s (op, key_, value, add_key); } + +object::depth_iterator::depth_iterator (object *container) +: iterator_base (container) +{ + while (item->inv) + item = item->inv; +} + +void +object::depth_iterator::next () +{ + if (item->below) + { + item = item->below; + + while (item->inv) + item = item->inv; + } + else + item = item->env; +} + +// return a suitable string describing an objetc in enough detail to find it +const char * +object::debug_desc (char *info) const +{ + char info2[256 * 3]; + char *p = info; + + p += snprintf (p, 256, "%d=\"%s%s%s\"", + count, + &name, + title ? " " : "", + title ? (const char *)title : ""); + + if (env) + p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); + + if (map) + p += snprintf (p, 256, "(on %s@%d+%d)", map->path, x, y); + + return info; +} + +const char * +object::debug_desc () const +{ + static char info[256 * 3]; + return debug_desc (info); +} +