ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.25 by root, Mon Sep 11 01:16:20 2006 UTC vs.
Revision 1.68 by root, Mon Dec 18 02:35:00 2006 UTC

1
2/*
3 * static char *rcsid_object_c =
4 * "$Id: object.C,v 1.25 2006/09/11 01:16:20 root Exp $";
5 */
6
7/* 1/*
8 CrossFire, A Multiplayer game for X-windows 2 CrossFire, A Multiplayer game for X-windows
9 3
10 Copyright (C) 2001 Mark Wedel & Crossfire Development Team 4 Copyright (C) 2001 Mark Wedel & Crossfire Development Team
11 Copyright (C) 1992 Frank Tore Johansen 5 Copyright (C) 1992 Frank Tore Johansen
22 16
23 You should have received a copy of the GNU General Public License 17 You should have received a copy of the GNU General Public License
24 along with this program; if not, write to the Free Software 18 along with this program; if not, write to the Free Software
25 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 19 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
26 20
27 The authors can be reached via e-mail at crossfire-devel@real-time.com 21 The authors can be reached via e-mail at <crossfire@schmorp.de>
28*/ 22*/
29 23
30/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects. 24/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
31 sub/add_weight will transcend the environment updating the carrying 25 sub/add_weight will transcend the environment updating the carrying
32 variable. */ 26 variable. */
33#include <global.h> 27#include <global.h>
34#ifndef WIN32 /* ---win32 exclude headers */
35# include <stdio.h> 28#include <stdio.h>
36# include <sys/types.h> 29#include <sys/types.h>
37# include <sys/uio.h> 30#include <sys/uio.h>
38#endif /* win32 */
39#include <object.h> 31#include <object.h>
40#include <funcpoint.h> 32#include <funcpoint.h>
41#include <skills.h>
42#include <loader.h> 33#include <loader.h>
34
35#include <bitset>
36
43int nrofallocobjects = 0; 37int nrofallocobjects = 0;
38static UUID uuid;
39const uint64 UUID_SKIP = 1<<19;
44 40
45object *objects; /* Pointer to the list of used objects */
46object *active_objects; /* List of active objects that need to be processed */ 41object *active_objects; /* List of active objects that need to be processed */
47 42
48short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 43short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
49 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1 44 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1
50}; 45};
57int freedir[SIZEOFFREE] = { 52int freedir[SIZEOFFREE] = {
58 0, 1, 2, 3, 4, 5, 6, 7, 8, 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8, 53 0, 1, 2, 3, 4, 5, 6, 7, 8, 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,
59 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8 54 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8
60}; 55};
61 56
57static void
58write_uuid (void)
59{
60 char filename1[MAX_BUF], filename2[MAX_BUF];
61
62 sprintf (filename1, "%s/uuid", settings.localdir);
63 sprintf (filename2, "%s/uuid~", settings.localdir);
64
65 FILE *fp;
66
67 if (!(fp = fopen (filename2, "w")))
68 {
69 LOG (llevError, "ERROR: cannot open %s for writing, unable to write UUID!\n", filename2);
70 return;
71 }
72
73 fprintf (fp, "<1,%llx>\n", (unsigned long long)uuid.seq + UUID_SKIP * 2);
74 fclose (fp);
75 rename (filename2, filename1);
76}
77
78static void
79read_uuid (void)
80{
81 char filename[MAX_BUF];
82
83 sprintf (filename, "%s/uuid", settings.localdir);
84
85 FILE *fp;
86
87 if (!(fp = fopen (filename, "r")))
88 {
89 if (errno == ENOENT)
90 {
91 LOG (llevInfo, "RESET uid to 1\n");
92 uuid.seq = 0;
93 write_uuid ();
94 return;
95 }
96
97 LOG (llevError, "FATAL: cannot open %s for reading!\n", filename);
98 _exit (1);
99 }
100
101 int version;
102 unsigned long long uid;
103 if (2 != fscanf (fp, "<%d,%llx>\n", &version, &uid) || version != 1)
104 {
105 LOG (llevError, "FATAL: error reading uid from %s!\n", filename);
106 _exit (1);
107 }
108
109 uuid.seq = uid;
110 write_uuid ();
111 LOG (llevDebug, "read UID: %" PRId64 "\n", uid);
112 fclose (fp);
113}
114
115UUID
116gen_uuid ()
117{
118 UUID uid;
119
120 uid.seq = ++uuid.seq;
121
122 if (!(uuid.seq & (UUID_SKIP - 1)))
123 write_uuid ();
124
125 return uid;
126}
127
128void
129init_uuid ()
130{
131 read_uuid ();
132}
133
62/* Returns TRUE if every key_values in wants has a partner with the same value in has. */ 134/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
63static int 135static int
64compare_ob_value_lists_one (const object *wants, const object *has) 136compare_ob_value_lists_one (const object *wants, const object *has)
65{ 137{
66 key_value *wants_field; 138 key_value *wants_field;
113 * 185 *
114 * Note that this function appears a lot longer than the macro it 186 * Note that this function appears a lot longer than the macro it
115 * replaces - this is mostly for clarity - a decent compiler should hopefully 187 * replaces - this is mostly for clarity - a decent compiler should hopefully
116 * reduce this to the same efficiency. 188 * reduce this to the same efficiency.
117 * 189 *
118 * Check nrof variable *before* calling CAN_MERGE() 190 * Check nrof variable *before* calling can_merge()
119 * 191 *
120 * Improvements made with merge: Better checking on potion, and also 192 * Improvements made with merge: Better checking on potion, and also
121 * check weight 193 * check weight
122 */ 194 */
123 195
124bool object::can_merge (object *ob1, object *ob2) 196bool object::can_merge_slow (object *ob1, object *ob2)
125{ 197{
126 /* A couple quicksanity checks */ 198 /* A couple quicksanity checks */
127 if ((ob1 == ob2) || (ob1->type != ob2->type)) 199 if (ob1 == ob2
200 || ob1->type != ob2->type
201 || ob1->speed != ob2->speed
202 || ob1->value != ob2->value
203 || ob1->name != ob2->name)
128 return 0; 204 return 0;
129 205
130 if (ob1->speed != ob2->speed) 206 //TODO: this ain't working well, use nicer and correct overflow check
131 return 0;
132
133 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that 207 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that
134 * value could not be stored in a sint32 (which unfortunately sometimes is 208 * value could not be stored in a sint32 (which unfortunately sometimes is
135 * used to store nrof). 209 * used to store nrof).
136 */ 210 */
137 if (ob1->nrof + ob2->nrof >= 1UL << 31) 211 if (ob1->nrof + ob2->nrof >= 1UL << 31)
148 222
149 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 223 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
150 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 224 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
151 225
152 226
153 /* the 0x400000 on flags2 is FLAG_INV_LOCK. I don't think something 227 if ((ob1->flags ^ ob2->flags).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any ()
154 * being locked in inventory should prevent merging. 228 || ob1->arch != ob2->arch
155 * 0x4 in flags3 is CLIENT_SENT
156 */
157 if ((ob1->arch != ob2->arch) ||
158 (ob1->flags[0] != ob2->flags[0]) ||
159 (ob1->flags[1] != ob2->flags[1]) ||
160 ((ob1->flags[2] & ~0x400000) != (ob2->flags[2] & ~0x400000)) ||
161 ((ob1->flags[3] & ~0x4) != (ob2->flags[3] & ~0x4)) ||
162 (ob1->name != ob2->name) || 229 || ob1->name != ob2->name
163 (ob1->title != ob2->title) || 230 || ob1->title != ob2->title
164 (ob1->msg != ob2->msg) || 231 || ob1->msg != ob2->msg
165 (ob1->weight != ob2->weight) || 232 || ob1->weight != ob2->weight
166 (memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist)) != 0) || 233 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
167 (memcmp (&ob1->stats, &ob2->stats, sizeof (ob1->stats)) != 0) || 234 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
168 (ob1->attacktype != ob2->attacktype) || 235 || ob1->attacktype != ob2->attacktype
169 (ob1->magic != ob2->magic) || 236 || ob1->magic != ob2->magic
170 (ob1->slaying != ob2->slaying) || 237 || ob1->slaying != ob2->slaying
171 (ob1->skill != ob2->skill) || 238 || ob1->skill != ob2->skill
172 (ob1->value != ob2->value) || 239 || ob1->value != ob2->value
173 (ob1->animation_id != ob2->animation_id) || 240 || ob1->animation_id != ob2->animation_id
174 (ob1->client_type != ob2->client_type) || 241 || ob1->client_type != ob2->client_type
175 (ob1->materialname != ob2->materialname) || 242 || ob1->materialname != ob2->materialname
176 (ob1->lore != ob2->lore) || 243 || ob1->lore != ob2->lore
177 (ob1->subtype != ob2->subtype) || 244 || ob1->subtype != ob2->subtype
178 (ob1->move_type != ob2->move_type) || 245 || ob1->move_type != ob2->move_type
179 (ob1->move_block != ob2->move_block) || 246 || ob1->move_block != ob2->move_block
180 (ob1->move_allow != ob2->move_allow) || 247 || ob1->move_allow != ob2->move_allow
181 (ob1->move_on != ob2->move_on) || 248 || ob1->move_on != ob2->move_on
182 (ob1->move_off != ob2->move_off) || (ob1->move_slow != ob2->move_slow) || (ob1->move_slow_penalty != ob2->move_slow_penalty)) 249 || ob1->move_off != ob2->move_off
250 || ob1->move_slow != ob2->move_slow
251 || ob1->move_slow_penalty != ob2->move_slow_penalty)
183 return 0; 252 return 0;
184 253
185 /* This is really a spellbook check - really, we should 254 /* This is really a spellbook check - really, we should
186 * check all objects in the inventory. 255 * check all objects in the inventory.
187 */ 256 */
190 /* if one object has inventory but the other doesn't, not equiv */ 259 /* if one object has inventory but the other doesn't, not equiv */
191 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv)) 260 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv))
192 return 0; 261 return 0;
193 262
194 /* Now check to see if the two inventory objects could merge */ 263 /* Now check to see if the two inventory objects could merge */
195 if (!CAN_MERGE (ob1->inv, ob2->inv)) 264 if (!object::can_merge (ob1->inv, ob2->inv))
196 return 0; 265 return 0;
197 266
198 /* inventory ok - still need to check rest of this object to see 267 /* inventory ok - still need to check rest of this object to see
199 * if it is valid. 268 * if it is valid.
200 */ 269 */
214 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && FABS ((ob1)->speed) > MIN_ACTIVE_SPEED) 283 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && FABS ((ob1)->speed) > MIN_ACTIVE_SPEED)
215 return 0; 284 return 0;
216 285
217 switch (ob1->type) 286 switch (ob1->type)
218 { 287 {
219 case SCROLL: 288 case SCROLL:
220 if (ob1->level != ob2->level) 289 if (ob1->level != ob2->level)
221 return 0; 290 return 0;
222 break; 291 break;
223 } 292 }
224 293
225 if (ob1->key_values != NULL || ob2->key_values != NULL) 294 if (ob1->key_values != NULL || ob2->key_values != NULL)
226 { 295 {
227 /* At least one of these has key_values. */ 296 /* At least one of these has key_values. */
249/* 318/*
250 * sum_weight() is a recursive function which calculates the weight 319 * sum_weight() is a recursive function which calculates the weight
251 * an object is carrying. It goes through in figures out how much 320 * an object is carrying. It goes through in figures out how much
252 * containers are carrying, and sums it up. 321 * containers are carrying, and sums it up.
253 */ 322 */
254signed long 323long
255sum_weight (object *op) 324sum_weight (object *op)
256{ 325{
257 signed long sum; 326 long sum;
258 object *inv; 327 object *inv;
259 328
260 for (sum = 0, inv = op->inv; inv != NULL; inv = inv->below) 329 for (sum = 0, inv = op->inv; inv != NULL; inv = inv->below)
261 { 330 {
262 if (inv->inv) 331 if (inv->inv)
263 sum_weight (inv); 332 sum_weight (inv);
264 sum += inv->carrying + inv->weight * (inv->nrof ? inv->nrof : 1); 333 sum += inv->carrying + inv->weight * (inv->nrof ? inv->nrof : 1);
265 } 334 }
335
266 if (op->type == CONTAINER && op->stats.Str) 336 if (op->type == CONTAINER && op->stats.Str)
267 sum = (sum * (100 - op->stats.Str)) / 100; 337 sum = (sum * (100 - op->stats.Str)) / 100;
338
268 if (op->carrying != sum) 339 if (op->carrying != sum)
269 op->carrying = sum; 340 op->carrying = sum;
341
270 return sum; 342 return sum;
271} 343}
272 344
273/** 345/**
274 * Return the outermost environment object for a given object. 346 * Return the outermost environment object for a given object.
301 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump. 373 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
302 * Some error messages. 374 * Some error messages.
303 * The result of the dump is stored in the static global errmsg array. 375 * The result of the dump is stored in the static global errmsg array.
304 */ 376 */
305 377
306void 378char *
307dump_object2 (object *op)
308{
309 errmsg[0] = 0;
310 return;
311 //TODO//D#d#
312#if 0
313 char *cp;
314
315/* object *tmp;*/
316
317 if (op->arch != NULL)
318 {
319 strcat (errmsg, "arch ");
320 strcat (errmsg, op->arch->name ? op->arch->name : "(null)");
321 strcat (errmsg, "\n");
322 if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
323 strcat (errmsg, cp);
324# if 0
325 /* Don't dump player diffs - they are too long, mostly meaningless, and
326 * will overflow the buffer.
327 * Changed so that we don't dump inventory either. This may
328 * also overflow the buffer.
329 */
330 if (op->type != PLAYER && (cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
331 strcat (errmsg, cp);
332 for (tmp = op->inv; tmp; tmp = tmp->below)
333 dump_object2 (tmp);
334# endif
335 strcat (errmsg, "end\n");
336 }
337 else
338 {
339 strcat (errmsg, "Object ");
340 if (op->name == NULL)
341 strcat (errmsg, "(null)");
342 else
343 strcat (errmsg, op->name);
344 strcat (errmsg, "\n");
345# if 0
346 if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
347 strcat (errmsg, cp);
348 for (tmp = op->inv; tmp; tmp = tmp->below)
349 dump_object2 (tmp);
350# endif
351 strcat (errmsg, "end\n");
352 }
353#endif
354}
355
356/*
357 * Dumps an object. Returns output in the static global errmsg array.
358 */
359
360void
361dump_object (object *op) 379dump_object (object *op)
362{ 380{
363 if (op == NULL) 381 if (!op)
364 { 382 return strdup ("[NULLOBJ]");
365 strcpy (errmsg, "[NULL pointer]");
366 return;
367 }
368 errmsg[0] = '\0';
369 dump_object2 (op);
370}
371 383
372void 384 object_freezer freezer;
373dump_all_objects (void) 385 save_object (freezer, op, 3);
374{ 386 return freezer.as_string ();
375 object *op;
376
377 for (op = objects; op != NULL; op = op->next)
378 {
379 dump_object (op);
380 fprintf (logfile, "Object %d\n:%s\n", op->count, errmsg);
381 }
382} 387}
383 388
384/* 389/*
385 * get_nearest_part(multi-object, object 2) returns the part of the 390 * get_nearest_part(multi-object, object 2) returns the part of the
386 * multi-object 1 which is closest to the second object. 391 * multi-object 1 which is closest to the second object.
406 */ 411 */
407 412
408object * 413object *
409find_object (tag_t i) 414find_object (tag_t i)
410{ 415{
411 object *op; 416 for (object *op = object::first; op; op = op->next)
412
413 for (op = objects; op != NULL; op = op->next)
414 if (op->count == i) 417 if (op->count == i)
415 break; 418 return op;
419
416 return op; 420 return 0;
417} 421}
418 422
419/* 423/*
420 * Returns the first object which has a name equal to the argument. 424 * Returns the first object which has a name equal to the argument.
421 * Used only by the patch command, but not all that useful. 425 * Used only by the patch command, but not all that useful.
423 */ 427 */
424 428
425object * 429object *
426find_object_name (const char *str) 430find_object_name (const char *str)
427{ 431{
428 const char *name = shstr::find (str); 432 shstr_cmp str_ (str);
429 object *op; 433 object *op;
430 434
431 for (op = objects; op != NULL; op = op->next) 435 for (op = object::first; op != NULL; op = op->next)
432 if (&op->name == name) 436 if (op->name == str_)
433 break; 437 break;
434 438
435 return op; 439 return op;
436} 440}
437 441
440{ 444{
441 LOG (llevDebug, "%d allocated objects\n", nrofallocobjects); 445 LOG (llevDebug, "%d allocated objects\n", nrofallocobjects);
442} 446}
443 447
444/* 448/*
445 * Returns the object which this object marks as being the owner.
446 * A id-scheme is used to avoid pointing to objects which have been
447 * freed and are now reused. If this is detected, the owner is
448 * set to NULL, and NULL is returned.
449 * Changed 2004-02-12 - if the player is setting at the play again
450 * prompt, he is removed, and we don't want to treat him as an owner of
451 * anything, so check removed flag. I don't expect that this should break
452 * anything - once an object is removed, it is basically dead anyways.
453 */
454
455object *
456get_owner (object *op)
457{
458 if (op->owner == NULL)
459 return NULL;
460
461 if (!QUERY_FLAG (op->owner, FLAG_FREED) && !QUERY_FLAG (op->owner, FLAG_REMOVED) && op->owner->count == op->ownercount)
462 return op->owner;
463
464 op->owner = NULL;
465 op->ownercount = 0;
466 return NULL;
467}
468
469void
470clear_owner (object *op)
471{
472 if (!op)
473 return;
474
475 if (op->owner && op->ownercount == op->owner->count)
476 op->owner->refcount--;
477
478 op->owner = NULL;
479 op->ownercount = 0;
480}
481
482/*
483 * Sets the owner and sets the skill and exp pointers to owner's current 449 * Sets the owner and sets the skill and exp pointers to owner's current
484 * skill and experience objects. 450 * skill and experience objects.
485 */ 451 */
486void 452void
487set_owner (object *op, object *owner) 453object::set_owner (object *owner)
488{ 454{
489 if (owner == NULL || op == NULL) 455 if (!owner)
490 return; 456 return;
491 457
492 /* next line added to allow objects which own objects */ 458 /* next line added to allow objects which own objects */
493 /* Add a check for ownercounts in here, as I got into an endless loop 459 /* Add a check for ownercounts in here, as I got into an endless loop
494 * with the fireball owning a poison cloud which then owned the 460 * with the fireball owning a poison cloud which then owned the
495 * fireball. I believe that was caused by one of the objects getting 461 * fireball. I believe that was caused by one of the objects getting
496 * freed and then another object replacing it. Since the ownercounts 462 * freed and then another object replacing it. Since the ownercounts
497 * didn't match, this check is valid and I believe that cause is valid. 463 * didn't match, this check is valid and I believe that cause is valid.
498 */ 464 */
499 while (owner->owner && owner != owner->owner && owner->ownercount == owner->owner->count) 465 while (owner->owner)
500 owner = owner->owner; 466 owner = owner->owner;
501 467
502 /* IF the owner still has an owner, we did not resolve to a final owner.
503 * so lets not add to that.
504 */
505 if (owner->owner)
506 return;
507
508 op->owner = owner; 468 this->owner = owner;
509
510 op->ownercount = owner->count;
511 owner->refcount++;
512}
513
514/* Set the owner to clone's current owner and set the skill and experience
515 * objects to clone's objects (typically those objects that where the owner's
516 * current skill and experience objects at the time when clone's owner was
517 * set - not the owner's current skill and experience objects).
518 *
519 * Use this function if player created an object (e.g. fire bullet, swarm
520 * spell), and this object creates further objects whose kills should be
521 * accounted for the player's original skill, even if player has changed
522 * skills meanwhile.
523 */
524void
525copy_owner (object *op, object *clone)
526{
527 object *owner = get_owner (clone);
528
529 if (owner == NULL)
530 {
531 /* players don't have owners - they own themselves. Update
532 * as appropriate.
533 */
534 if (clone->type == PLAYER)
535 owner = clone;
536 else
537 return;
538 }
539
540 set_owner (op, owner);
541} 469}
542 470
543/* Zero the key_values on op, decrementing the shared-string 471/* Zero the key_values on op, decrementing the shared-string
544 * refcounts and freeing the links. 472 * refcounts and freeing the links.
545 */ 473 */
561{ 489{
562 attachable_base::clear (); 490 attachable_base::clear ();
563 491
564 free_key_values (this); 492 free_key_values (this);
565 493
566 clear_owner (this); 494 owner = 0;
567
568 name = 0; 495 name = 0;
569 name_pl = 0; 496 name_pl = 0;
570 title = 0; 497 title = 0;
571 race = 0; 498 race = 0;
572 slaying = 0; 499 slaying = 0;
573 skill = 0; 500 skill = 0;
574 msg = 0; 501 msg = 0;
575 lore = 0; 502 lore = 0;
576 custom_name = 0; 503 custom_name = 0;
577 materialname = 0; 504 materialname = 0;
505 contr = 0;
506 below = 0;
507 above = 0;
508 inv = 0;
509 container = 0;
510 env = 0;
511 more = 0;
512 head = 0;
513 map = 0;
514 active_next = 0;
515 active_prev = 0;
578 516
579 memset (static_cast < object_pod * >(this), 0, sizeof (object_pod)); 517 memset (static_cast<object_pod *>(this), 0, sizeof (object_pod));
580 518
581 SET_FLAG (this, FLAG_REMOVED); 519 SET_FLAG (this, FLAG_REMOVED);
582}
583 520
584void object::clone (object *destination)
585{
586 *(object_copy *) destination = *this;
587 *(object_pod *) destination = *this;
588
589 if (self || cb)
590 INVOKE_OBJECT (CLONE, this, ARG_OBJECT (destination));
591}
592
593/*
594 * clear_object() frees everything allocated by an object, and also
595 * clears all variables and flags to default settings.
596 */
597
598void
599clear_object (object *op)
600{
601 op->clear ();
602
603 op->contr = NULL;
604 op->below = NULL;
605 op->above = NULL;
606 op->inv = NULL;
607 op->container = NULL;
608 op->env = NULL;
609 op->more = NULL;
610 op->head = NULL;
611 op->map = NULL;
612 op->refcount = 0;
613 op->active_next = NULL;
614 op->active_prev = NULL;
615 /* What is not cleared is next, prev, and count */ 521 /* What is not cleared is next, prev, and count */
616 522
617 op->expmul = 1.0; 523 expmul = 1.0;
618 op->face = blank_face; 524 face = blank_face;
619 op->attacked_by_count = -1;
620 525
621 if (settings.casting_time) 526 if (settings.casting_time)
622 op->casting_time = -1; 527 casting_time = -1;
623} 528}
624 529
625/* 530/*
626 * copy object first frees everything allocated by the second object, 531 * copy_to first frees everything allocated by the dst object,
627 * and then copies the contends of the first object into the second 532 * and then copies the contents of itself into the second
628 * object, allocating what needs to be allocated. Basically, any 533 * object, allocating what needs to be allocated. Basically, any
629 * data that is malloc'd needs to be re-malloc/copied. Otherwise, 534 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
630 * if the first object is freed, the pointers in the new object 535 * if the first object is freed, the pointers in the new object
631 * will point at garbage. 536 * will point at garbage.
632 */ 537 */
633
634void 538void
635copy_object (object *op2, object *op) 539object::copy_to (object *dst)
636{ 540{
637 bool is_freed = QUERY_FLAG (op, FLAG_FREED); 541 bool is_freed = QUERY_FLAG (dst, FLAG_FREED);
638 bool is_removed = QUERY_FLAG (op, FLAG_REMOVED); 542 bool is_removed = QUERY_FLAG (dst, FLAG_REMOVED);
639 543
640 op2->clone (op); 544 *(object_copy *)dst = *this;
545 *(object_pod *)dst = *this;
546
547 if (self || cb)
548 INVOKE_OBJECT (CLONE, this, ARG_OBJECT (dst));
641 549
642 if (is_freed) 550 if (is_freed)
643 SET_FLAG (op, FLAG_FREED); 551 SET_FLAG (dst, FLAG_FREED);
552
644 if (is_removed) 553 if (is_removed)
645 SET_FLAG (op, FLAG_REMOVED); 554 SET_FLAG (dst, FLAG_REMOVED);
646 555
647 if (op2->speed < 0) 556 if (speed < 0)
648 op->speed_left = op2->speed_left - RANDOM () % 200 / 100.0; 557 dst->speed_left = speed_left - RANDOM () % 200 / 100.0;
649 558
650 /* Copy over key_values, if any. */ 559 /* Copy over key_values, if any. */
651 if (op2->key_values) 560 if (key_values)
652 { 561 {
653 key_value *tail = 0; 562 key_value *tail = 0;
654 key_value *i; 563 key_value *i;
655 564
656 op->key_values = 0; 565 dst->key_values = 0;
657 566
658 for (i = op2->key_values; i; i = i->next) 567 for (i = key_values; i; i = i->next)
659 { 568 {
660 key_value *new_link = new key_value; 569 key_value *new_link = new key_value;
661 570
662 new_link->next = 0; 571 new_link->next = 0;
663 new_link->key = i->key; 572 new_link->key = i->key;
664 new_link->value = i->value; 573 new_link->value = i->value;
665 574
666 /* Try and be clever here, too. */ 575 /* Try and be clever here, too. */
667 if (!op->key_values) 576 if (!dst->key_values)
668 { 577 {
669 op->key_values = new_link; 578 dst->key_values = new_link;
670 tail = new_link; 579 tail = new_link;
671 } 580 }
672 else 581 else
673 { 582 {
674 tail->next = new_link; 583 tail->next = new_link;
675 tail = new_link; 584 tail = new_link;
676 } 585 }
677 } 586 }
678 } 587 }
679 588
680 update_ob_speed (op); 589 update_ob_speed (dst);
590}
591
592object *
593object::clone ()
594{
595 object *neu = create ();
596 copy_to (neu);
597 return neu;
681} 598}
682 599
683/* 600/*
684 * If an object with the IS_TURNABLE() flag needs to be turned due 601 * If an object with the IS_TURNABLE() flag needs to be turned due
685 * to the closest player being on the other side, this function can 602 * to the closest player being on the other side, this function can
698/* 615/*
699 * Updates the speed of an object. If the speed changes from 0 to another 616 * Updates the speed of an object. If the speed changes from 0 to another
700 * value, or vice versa, then add/remove the object from the active list. 617 * value, or vice versa, then add/remove the object from the active list.
701 * This function needs to be called whenever the speed of an object changes. 618 * This function needs to be called whenever the speed of an object changes.
702 */ 619 */
703
704void 620void
705update_ob_speed (object *op) 621update_ob_speed (object *op)
706{ 622{
707 extern int arch_init; 623 extern int arch_init;
708 624
717 abort (); 633 abort ();
718#else 634#else
719 op->speed = 0; 635 op->speed = 0;
720#endif 636#endif
721 } 637 }
638
722 if (arch_init) 639 if (arch_init)
723 {
724 return; 640 return;
725 } 641
726 if (FABS (op->speed) > MIN_ACTIVE_SPEED) 642 if (FABS (op->speed) > MIN_ACTIVE_SPEED)
727 { 643 {
728 /* If already on active list, don't do anything */ 644 /* If already on active list, don't do anything */
729 if (op->active_next || op->active_prev || op == active_objects) 645 if (op->active_next || op->active_prev || op == active_objects)
730 return; 646 return;
731 647
732 /* process_events() expects us to insert the object at the beginning 648 /* process_events() expects us to insert the object at the beginning
733 * of the list. */ 649 * of the list. */
734 op->active_next = active_objects; 650 op->active_next = active_objects;
651
735 if (op->active_next != NULL) 652 if (op->active_next != NULL)
736 op->active_next->active_prev = op; 653 op->active_next->active_prev = op;
654
737 active_objects = op; 655 active_objects = op;
738 } 656 }
739 else 657 else
740 { 658 {
741 /* If not on the active list, nothing needs to be done */ 659 /* If not on the active list, nothing needs to be done */
743 return; 661 return;
744 662
745 if (op->active_prev == NULL) 663 if (op->active_prev == NULL)
746 { 664 {
747 active_objects = op->active_next; 665 active_objects = op->active_next;
666
748 if (op->active_next != NULL) 667 if (op->active_next != NULL)
749 op->active_next->active_prev = NULL; 668 op->active_next->active_prev = NULL;
750 } 669 }
751 else 670 else
752 { 671 {
753 op->active_prev->active_next = op->active_next; 672 op->active_prev->active_next = op->active_next;
673
754 if (op->active_next) 674 if (op->active_next)
755 op->active_next->active_prev = op->active_prev; 675 op->active_next->active_prev = op->active_prev;
756 } 676 }
677
757 op->active_next = NULL; 678 op->active_next = NULL;
758 op->active_prev = NULL; 679 op->active_prev = NULL;
759 } 680 }
760} 681}
761 682
886 update_now = 1; 807 update_now = 1;
887 808
888 if ((move_slow | op->move_slow) != move_slow) 809 if ((move_slow | op->move_slow) != move_slow)
889 update_now = 1; 810 update_now = 1;
890 } 811 }
812
891 /* if the object is being removed, we can't make intelligent 813 /* if the object is being removed, we can't make intelligent
892 * decisions, because remove_ob can't really pass the object 814 * decisions, because remove_ob can't really pass the object
893 * that is being removed. 815 * that is being removed.
894 */ 816 */
895 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 817 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
896 {
897 update_now = 1; 818 update_now = 1;
898 }
899 else if (action == UP_OBJ_FACE) 819 else if (action == UP_OBJ_FACE)
900 {
901 /* Nothing to do for that case */ 820 /* Nothing to do for that case */ ;
902 }
903 else 821 else
904 {
905 LOG (llevError, "update_object called with invalid action: %d\n", action); 822 LOG (llevError, "update_object called with invalid action: %d\n", action);
906 }
907 823
908 if (update_now) 824 if (update_now)
909 { 825 {
910 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NO_ERROR | P_NEED_UPDATE); 826 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NO_ERROR | P_NEED_UPDATE);
911 update_position (op->map, op->x, op->y); 827 update_position (op->map, op->x, op->y);
913 829
914 if (op->more != NULL) 830 if (op->more != NULL)
915 update_object (op->more, action); 831 update_object (op->more, action);
916} 832}
917 833
918static unordered_vector<object *> mortals; 834object::vector object::mortals;
919static std::vector<object *> freed; 835object::vector object::objects; // not yet used
836object *object::first;
920 837
921void object::free_mortals () 838void object::free_mortals ()
922{ 839{
923 for (unordered_vector<object *>::iterator i = mortals.begin (); i != mortals.end (); ) 840 for (AUTODECL (i, mortals.begin ()); i != mortals.end ();)
924 if (!(*i)->refcount) 841 if ((*i)->refcnt)
842 ++i; // further delay freeing
843 else
925 { 844 {
926 freed.push_back (*i); 845 delete *i;
927 mortals.erase (i); 846 mortals.erase (i);
928 } 847 }
929 else
930 ++i;
931} 848}
932 849
933object::object () 850object::object ()
934{ 851{
935 SET_FLAG (this, FLAG_REMOVED); 852 SET_FLAG (this, FLAG_REMOVED);
936 853
937 expmul = 1.0; 854 expmul = 1.0;
938 face = blank_face; 855 face = blank_face;
939 attacked_by_count = -1;
940} 856}
941 857
942object::~object () 858object::~object ()
943{ 859{
944 free_key_values (this); 860 free_key_values (this);
945} 861}
946 862
947void object::link () 863void object::link ()
948{ 864{
949 count = ++ob_count; 865 count = ++ob_count;
866 uuid = gen_uuid ();
950 867
951 prev = 0; 868 prev = 0;
952 next = objects; 869 next = object::first;
953 870
954 if (objects) 871 if (object::first)
955 objects->prev = this; 872 object::first->prev = this;
956 873
957 objects = this; 874 object::first = this;
958} 875}
959 876
960void object::unlink () 877void object::unlink ()
961{ 878{
962 count = 0; 879 if (this == object::first)
880 object::first = next;
963 881
964 /* Remove this object from the list of used objects */ 882 /* Remove this object from the list of used objects */
965 if (prev)
966 {
967 prev->next = next; 883 if (prev) prev->next = next;
884 if (next) next->prev = prev;
885
968 prev = 0; 886 prev = 0;
969 }
970
971 if (next)
972 {
973 next->prev = prev;
974 next = 0; 887 next = 0;
975 }
976
977 if (this == objects)
978 objects = next;
979} 888}
980 889
981object *object::create () 890object *object::create ()
982{ 891{
983 object *op;
984
985 if (freed.empty ())
986 op = new object; 892 object *op = new object;
987 else
988 {
989 // highly annoying, but the only way to get it stable right now
990 op = freed.back (); freed.pop_back ();
991 op->~object ();
992 new ((void *)op) object;
993 }
994
995 op->link (); 893 op->link ();
996 return op; 894 return op;
997} 895}
998 896
999/* 897/*
1001 * it from the list of used objects, and puts it on the list of 899 * it from the list of used objects, and puts it on the list of
1002 * free objects. The IS_FREED() flag is set in the object. 900 * free objects. The IS_FREED() flag is set in the object.
1003 * The object must have been removed by remove_ob() first for 901 * The object must have been removed by remove_ob() first for
1004 * this function to succeed. 902 * this function to succeed.
1005 * 903 *
1006 * If free_inventory is set, free inventory as well. Else drop items in 904 * If destroy_inventory is set, free inventory as well. Else drop items in
1007 * inventory to the ground. 905 * inventory to the ground.
1008 */ 906 */
1009void object::free (bool free_inventory) 907void object::destroy (bool destroy_inventory)
1010{ 908{
909 if (QUERY_FLAG (this, FLAG_FREED))
910 return;
911
912 if (QUERY_FLAG (this, FLAG_FRIENDLY))
913 remove_friendly_object (this);
914
1011 if (!QUERY_FLAG (this, FLAG_REMOVED)) 915 if (!QUERY_FLAG (this, FLAG_REMOVED))
1012 { 916 remove ();
1013 LOG (llevDebug, "Free object called with non removed object\n");
1014 dump_object (this);
1015#ifdef MANY_CORES
1016 abort ();
1017#endif
1018 }
1019 917
1020 if (QUERY_FLAG (this, FLAG_FRIENDLY))
1021 {
1022 LOG (llevMonster, "Warning: tried to free friendly object.\n");
1023 remove_friendly_object (this);
1024 }
1025
1026 if (QUERY_FLAG (this, FLAG_FREED)) 918 SET_FLAG (this, FLAG_FREED);
1027 {
1028 dump_object (this);
1029 LOG (llevError, "Trying to free freed object.\n%s\n", errmsg);
1030 return;
1031 }
1032 919
1033 if (more) 920 if (more)
1034 { 921 {
1035 more->free (free_inventory); 922 more->destroy (destroy_inventory);
1036 more = 0; 923 more = 0;
1037 } 924 }
1038 925
1039 if (inv) 926 if (inv)
1040 { 927 {
1041 /* Only if the space blocks everything do we not process - 928 /* Only if the space blocks everything do we not process -
1042 * if some form of movement is allowed, let objects 929 * if some form of movement is allowed, let objects
1043 * drop on that space. 930 * drop on that space.
1044 */ 931 */
1045 if (free_inventory || !map || map->in_memory != MAP_IN_MEMORY || (GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL)) 932 if (destroy_inventory || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL)
1046 { 933 {
1047 object * 934 object *op = inv;
1048 op = inv;
1049 935
1050 while (op) 936 while (op)
1051 { 937 {
1052 object *
1053 tmp = op->below; 938 object *tmp = op->below;
1054
1055 remove_ob (op);
1056 op->free (free_inventory); 939 op->destroy (destroy_inventory);
1057 op = tmp; 940 op = tmp;
1058 } 941 }
1059 } 942 }
1060 else 943 else
1061 { /* Put objects in inventory onto this space */ 944 { /* Put objects in inventory onto this space */
1062 object * 945 object *op = inv;
1063 op = inv;
1064 946
1065 while (op) 947 while (op)
1066 { 948 {
1067 object *
1068 tmp = op->below; 949 object *tmp = op->below;
1069 950
1070 remove_ob (op); 951 op->remove ();
1071 952
1072 if (QUERY_FLAG (op, FLAG_STARTEQUIP) 953 if (QUERY_FLAG (op, FLAG_STARTEQUIP)
1073 || QUERY_FLAG (op, FLAG_NO_DROP) || op->type == RUNE || op->type == TRAP || QUERY_FLAG (op, FLAG_IS_A_TEMPLATE)) 954 || QUERY_FLAG (op, FLAG_NO_DROP) || op->type == RUNE || op->type == TRAP || QUERY_FLAG (op, FLAG_IS_A_TEMPLATE))
1074 free_object (op); 955 op->destroy ();
1075 else 956 else
1076 { 957 {
1077 op->x = x; 958 op->x = x;
1078 op->y = y; 959 op->y = y;
1079 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */ 960 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
1082 op = tmp; 963 op = tmp;
1083 } 964 }
1084 } 965 }
1085 } 966 }
1086 967
1087 clear_owner (this); 968 // hack to ensure that freed objects still have a valid map
969 {
970 static maptile *freed_map; // freed objects are moved here to avoid crashes
971
972 if (!freed_map)
973 {
974 freed_map = new maptile;
975
976 freed_map->name = "/internal/freed_objects_map";
977 freed_map->width = 3;
978 freed_map->height = 3;
979
980 freed_map->allocate ();
981 }
982
983 map = freed_map;
984 x = 1;
985 y = 1;
986 }
987
988 // clear those pointers that likely might have circular references to us
989 owner = 0;
990 enemy = 0;
991 attacked_by = 0;
992
993 // only relevant for players(?), but make sure of it anyways
994 contr = 0;
1088 995
1089 /* Remove object from the active list */ 996 /* Remove object from the active list */
1090 speed = 0; 997 speed = 0;
1091 update_ob_speed (this); 998 update_ob_speed (this);
1092 999
1093 unlink (); 1000 unlink ();
1094 1001
1095 SET_FLAG (this, FLAG_FREED);
1096
1097 mortals.push_back (this); 1002 mortals.push_back (this);
1098} 1003}
1099 1004
1100/* 1005/*
1101 * sub_weight() recursively (outwards) subtracts a number from the 1006 * sub_weight() recursively (outwards) subtracts a number from the
1102 * weight of an object (and what is carried by it's environment(s)). 1007 * weight of an object (and what is carried by it's environment(s)).
1103 */ 1008 */
1104
1105void 1009void
1106sub_weight (object *op, signed long weight) 1010sub_weight (object *op, signed long weight)
1107{ 1011{
1108 while (op != NULL) 1012 while (op != NULL)
1109 { 1013 {
1110 if (op->type == CONTAINER) 1014 if (op->type == CONTAINER)
1111 {
1112 weight = (signed long) (weight * (100 - op->stats.Str) / 100); 1015 weight = (signed long) (weight * (100 - op->stats.Str) / 100);
1113 } 1016
1114 op->carrying -= weight; 1017 op->carrying -= weight;
1115 op = op->env; 1018 op = op->env;
1116 } 1019 }
1117} 1020}
1118 1021
1119/* remove_ob(op): 1022/* op->remove ():
1120 * This function removes the object op from the linked list of objects 1023 * This function removes the object op from the linked list of objects
1121 * which it is currently tied to. When this function is done, the 1024 * which it is currently tied to. When this function is done, the
1122 * object will have no environment. If the object previously had an 1025 * object will have no environment. If the object previously had an
1123 * environment, the x and y coordinates will be updated to 1026 * environment, the x and y coordinates will be updated to
1124 * the previous environment. 1027 * the previous environment.
1125 * Beware: This function is called from the editor as well! 1028 * Beware: This function is called from the editor as well!
1126 */ 1029 */
1127
1128void 1030void
1129remove_ob (object *op) 1031object::remove ()
1130{ 1032{
1033 object *tmp, *last = 0;
1131 object * 1034 object *otmp;
1132 tmp, * 1035
1133 last = NULL;
1134 object *
1135 otmp;
1136 tag_t
1137 tag;
1138 int
1139 check_walk_off; 1036 int check_walk_off;
1140 mapstruct *
1141 m;
1142 sint16
1143 x,
1144 y;
1145 1037
1146
1147 if (QUERY_FLAG (op, FLAG_REMOVED)) 1038 if (QUERY_FLAG (this, FLAG_REMOVED))
1148 { 1039 return;
1149 dump_object (op);
1150 LOG (llevError, "Trying to remove removed object.\n%s\n", errmsg);
1151 1040
1152 /* Changed it to always dump core in this case. As has been learned
1153 * in the past, trying to recover from errors almost always
1154 * make things worse, and this is a real error here - something
1155 * that should not happen.
1156 * Yes, if this was a mission critical app, trying to do something
1157 * to recover may make sense, but that is because failure of the app
1158 * may have other disastrous problems. Cf runs out of a script
1159 * so is easily enough restarted without any real problems.
1160 * MSW 2001-07-01
1161 */
1162 abort ();
1163 }
1164 if (op->more != NULL)
1165 remove_ob (op->more);
1166
1167 SET_FLAG (op, FLAG_REMOVED); 1041 SET_FLAG (this, FLAG_REMOVED);
1042
1043 if (more)
1044 more->remove ();
1168 1045
1169 /* 1046 /*
1170 * In this case, the object to be removed is in someones 1047 * In this case, the object to be removed is in someones
1171 * inventory. 1048 * inventory.
1172 */ 1049 */
1173 if (op->env != NULL) 1050 if (env)
1174 { 1051 {
1175 if (op->nrof) 1052 if (nrof)
1176 sub_weight (op->env, op->weight * op->nrof); 1053 sub_weight (env, weight * nrof);
1177 else 1054 else
1178 sub_weight (op->env, op->weight + op->carrying); 1055 sub_weight (env, weight + carrying);
1179 1056
1180 /* NO_FIX_PLAYER is set when a great many changes are being 1057 /* NO_FIX_PLAYER is set when a great many changes are being
1181 * made to players inventory. If set, avoiding the call 1058 * made to players inventory. If set, avoiding the call
1182 * to save cpu time. 1059 * to save cpu time.
1183 */ 1060 */
1184 if ((otmp = is_player_inv (op->env)) != NULL && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1061 if ((otmp = is_player_inv (env)) != NULL && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1185 fix_player (otmp); 1062 fix_player (otmp);
1186 1063
1187 if (op->above != NULL) 1064 if (above != NULL)
1188 op->above->below = op->below; 1065 above->below = below;
1189 else 1066 else
1190 op->env->inv = op->below; 1067 env->inv = below;
1191 1068
1192 if (op->below != NULL) 1069 if (below != NULL)
1193 op->below->above = op->above; 1070 below->above = above;
1194 1071
1195 /* we set up values so that it could be inserted into 1072 /* we set up values so that it could be inserted into
1196 * the map, but we don't actually do that - it is up 1073 * the map, but we don't actually do that - it is up
1197 * to the caller to decide what we want to do. 1074 * to the caller to decide what we want to do.
1198 */ 1075 */
1199 op->x = op->env->x, op->y = op->env->y; 1076 x = env->x, y = env->y;
1200 op->map = op->env->map; 1077 map = env->map;
1201 op->above = NULL, op->below = NULL; 1078 above = 0, below = 0;
1202 op->env = NULL; 1079 env = 0;
1203 return;
1204 }
1205
1206 /* If we get here, we are removing it from a map */
1207 if (op->map == NULL)
1208 return;
1209
1210 x = op->x;
1211 y = op->y;
1212 m = get_map_from_coord (op->map, &x, &y);
1213
1214 if (!m)
1215 { 1080 }
1216 LOG (llevError, "remove_ob called when object was on map but appears to not be within valid coordinates? %s (%d,%d)\n", 1081 else if (map)
1217 op->map->path, op->x, op->y); 1082 {
1218 /* in old days, we used to set x and y to 0 and continue. 1083 /* Re did the following section of code - it looks like it had
1219 * it seems if we get into this case, something is probablye 1084 * lots of logic for things we no longer care about
1220 * screwed up and should be fixed.
1221 */ 1085 */
1222 abort ();
1223 }
1224 if (op->map != m)
1225 {
1226 LOG (llevDebug, "remove_ob: Object not really on map it claimed to be on? %s != %s, %d,%d != %d,%d\n",
1227 op->map->path, m->path, op->x, op->y, x, y);
1228 }
1229 1086
1230 /* Re did the following section of code - it looks like it had
1231 * lots of logic for things we no longer care about
1232 */
1233
1234 /* link the object above us */ 1087 /* link the object above us */
1235 if (op->above) 1088 if (above)
1236 op->above->below = op->below; 1089 above->below = below;
1237 else 1090 else
1238 SET_MAP_TOP (m, x, y, op->below); /* we were top, set new top */ 1091 SET_MAP_TOP (map, x, y, below); /* we were top, set new top */
1239 1092
1240 /* Relink the object below us, if there is one */ 1093 /* Relink the object below us, if there is one */
1241 if (op->below) 1094 if (below)
1242 {
1243 op->below->above = op->above; 1095 below->above = above;
1244 }
1245 else 1096 else
1246 { 1097 {
1247 /* Nothing below, which means we need to relink map object for this space 1098 /* Nothing below, which means we need to relink map object for this space
1248 * use translated coordinates in case some oddness with map tiling is 1099 * use translated coordinates in case some oddness with map tiling is
1249 * evident 1100 * evident
1250 */
1251 if (GET_MAP_OB (m, x, y) != op)
1252 {
1253 dump_object (op);
1254 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n",
1255 errmsg);
1256 dump_object (GET_MAP_OB (m, x, y));
1257 LOG (llevError, "%s\n", errmsg);
1258 }
1259 SET_MAP_OB (m, x, y, op->above); /* goes on above it. */
1260 }
1261 op->above = NULL;
1262 op->below = NULL;
1263
1264 if (op->map->in_memory == MAP_SAVING)
1265 return;
1266
1267 tag = op->count;
1268 check_walk_off = !QUERY_FLAG (op, FLAG_NO_APPLY);
1269 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above)
1270 {
1271 /* No point updating the players look faces if he is the object
1272 * being removed.
1273 */
1274
1275 if (tmp->type == PLAYER && tmp != op)
1276 {
1277 /* If a container that the player is currently using somehow gets
1278 * removed (most likely destroyed), update the player view
1279 * appropriately.
1280 */ 1101 */
1281 if (tmp->container == op) 1102 if (GET_MAP_OB (map, x, y) != this)
1282 { 1103 {
1283 CLEAR_FLAG (op, FLAG_APPLIED); 1104 char *dump = dump_object (this);
1284 tmp->container = NULL; 1105 LOG (llevError,
1106 "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", dump);
1107 free (dump);
1108 dump = dump_object (GET_MAP_OB (map, x, y));
1109 LOG (llevError, "%s\n", dump);
1110 free (dump);
1285 } 1111 }
1286 tmp->contr->socket.update_look = 1; 1112
1287 } 1113 SET_MAP_OB (map, x, y, above); /* goes on above it. */
1288 /* See if player moving off should effect something */
1289 if (check_walk_off && ((op->move_type & tmp->move_off) && (op->move_type & ~tmp->move_off & ~tmp->move_block) == 0))
1290 { 1114 }
1291 1115
1292 move_apply (tmp, op, NULL); 1116 above = 0;
1293 if (was_destroyed (op, tag)) 1117 below = 0;
1118
1119 if (map->in_memory == MAP_SAVING)
1120 return;
1121
1122 check_walk_off = !QUERY_FLAG (this, FLAG_NO_APPLY);
1123
1124 for (tmp = GET_MAP_OB (map, x, y); tmp; tmp = tmp->above)
1125 {
1126 /* No point updating the players look faces if he is the object
1127 * being removed.
1128 */
1129
1130 if (tmp->type == PLAYER && tmp != this)
1294 { 1131 {
1295 LOG (llevError, "BUG: remove_ob(): name %s, archname %s destroyed " "leaving object\n", &tmp->name, &tmp->arch->name); 1132 /* If a container that the player is currently using somehow gets
1133 * removed (most likely destroyed), update the player view
1134 * appropriately.
1135 */
1136 if (tmp->container == this)
1137 {
1138 CLEAR_FLAG (this, FLAG_APPLIED);
1139 tmp->container = 0;
1140 }
1141
1142 tmp->contr->socket->update_look = 1;
1296 } 1143 }
1144
1145 /* See if player moving off should effect something */
1146 if (check_walk_off
1147 && ((move_type & tmp->move_off)
1148 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0))
1149 {
1150 move_apply (tmp, this, 0);
1151
1152 if (destroyed ())
1153 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1297 } 1154 }
1298 1155
1299 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */ 1156 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */
1300 1157
1301 if (tmp->above == tmp) 1158 if (tmp->above == tmp)
1302 tmp->above = NULL; 1159 tmp->above = 0;
1160
1303 last = tmp; 1161 last = tmp;
1304 } 1162 }
1163
1305 /* last == NULL of there are no objects on this space */ 1164 /* last == NULL of there are no objects on this space */
1306 if (last == NULL) 1165 if (!last)
1307 { 1166 {
1308 /* set P_NEED_UPDATE, otherwise update_position will complain. In theory, 1167 /* set P_NEED_UPDATE, otherwise update_position will complain. In theory,
1309 * we could preserve the flags (GET_MAP_FLAGS), but update_position figures 1168 * we could preserve the flags (GET_MAP_FLAGS), but update_position figures
1310 * those out anyways, and if there are any flags set right now, they won't 1169 * those out anyways, and if there are any flags set right now, they won't
1311 * be correct anyways. 1170 * be correct anyways.
1312 */ 1171 */
1313 SET_MAP_FLAGS (op->map, op->x, op->y, P_NEED_UPDATE); 1172 SET_MAP_FLAGS (map, x, y, P_NEED_UPDATE);
1314 update_position (op->map, op->x, op->y); 1173 update_position (map, x, y);
1315 } 1174 }
1316 else 1175 else
1317 update_object (last, UP_OBJ_REMOVE); 1176 update_object (last, UP_OBJ_REMOVE);
1318 1177
1319 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) || (op->glow_radius != 0)) 1178 if (QUERY_FLAG (this, FLAG_BLOCKSVIEW) || glow_radius)
1320 update_all_los (op->map, op->x, op->y); 1179 update_all_los (map, x, y);
1321 1180 }
1322} 1181}
1323 1182
1324/* 1183/*
1325 * merge_ob(op,top): 1184 * merge_ob(op,top):
1326 * 1185 *
1327 * This function goes through all objects below and including top, and 1186 * This function goes through all objects below and including top, and
1328 * merges op to the first matching object. 1187 * merges op to the first matching object.
1329 * If top is NULL, it is calculated. 1188 * If top is NULL, it is calculated.
1330 * Returns pointer to object if it succeded in the merge, otherwise NULL 1189 * Returns pointer to object if it succeded in the merge, otherwise NULL
1331 */ 1190 */
1332
1333object * 1191object *
1334merge_ob (object *op, object *top) 1192merge_ob (object *op, object *top)
1335{ 1193{
1336 if (!op->nrof) 1194 if (!op->nrof)
1337 return 0; 1195 return 0;
1196
1338 if (top == NULL) 1197 if (top == NULL)
1339 for (top = op; top != NULL && top->above != NULL; top = top->above); 1198 for (top = op; top != NULL && top->above != NULL; top = top->above);
1199
1340 for (; top != NULL; top = top->below) 1200 for (; top != NULL; top = top->below)
1341 { 1201 {
1342 if (top == op) 1202 if (top == op)
1343 continue; 1203 continue;
1344 if (CAN_MERGE (op, top)) 1204
1205 if (object::can_merge (op, top))
1345 { 1206 {
1346 top->nrof += op->nrof; 1207 top->nrof += op->nrof;
1347 1208
1348/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/ 1209/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/
1349 op->weight = 0; /* Don't want any adjustements now */ 1210 op->weight = 0; /* Don't want any adjustements now */
1350 remove_ob (op); 1211 op->destroy ();
1351 free_object (op);
1352 return top; 1212 return top;
1353 } 1213 }
1354 } 1214 }
1215
1355 return NULL; 1216 return 0;
1356} 1217}
1357 1218
1358/* 1219/*
1359 * same as insert_ob_in_map except it handle separate coordinates and do a clean 1220 * same as insert_ob_in_map except it handle separate coordinates and do a clean
1360 * job preparing multi-part monsters 1221 * job preparing multi-part monsters
1361 */ 1222 */
1362object * 1223object *
1363insert_ob_in_map_at (object *op, mapstruct *m, object *originator, int flag, int x, int y) 1224insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1364{ 1225{
1365 object * 1226 object *tmp;
1366 tmp;
1367 1227
1368 if (op->head) 1228 if (op->head)
1369 op = op->head; 1229 op = op->head;
1230
1370 for (tmp = op; tmp; tmp = tmp->more) 1231 for (tmp = op; tmp; tmp = tmp->more)
1371 { 1232 {
1372 tmp->x = x + tmp->arch->clone.x; 1233 tmp->x = x + tmp->arch->clone.x;
1373 tmp->y = y + tmp->arch->clone.y; 1234 tmp->y = y + tmp->arch->clone.y;
1374 } 1235 }
1236
1375 return insert_ob_in_map (op, m, originator, flag); 1237 return insert_ob_in_map (op, m, originator, flag);
1376} 1238}
1377 1239
1378/* 1240/*
1379 * insert_ob_in_map (op, map, originator, flag): 1241 * insert_ob_in_map (op, map, originator, flag):
1395 * NULL if 'op' was destroyed 1257 * NULL if 'op' was destroyed
1396 * just 'op' otherwise 1258 * just 'op' otherwise
1397 */ 1259 */
1398 1260
1399object * 1261object *
1400insert_ob_in_map (object *op, mapstruct *m, object *originator, int flag) 1262insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1401{ 1263{
1402 object *tmp, *top, *floor = NULL; 1264 object *tmp, *top, *floor = NULL;
1403 sint16 x, y; 1265 sint16 x, y;
1404 1266
1405 if (QUERY_FLAG (op, FLAG_FREED)) 1267 if (QUERY_FLAG (op, FLAG_FREED))
1408 return NULL; 1270 return NULL;
1409 } 1271 }
1410 1272
1411 if (m == NULL) 1273 if (m == NULL)
1412 { 1274 {
1413 dump_object (op); 1275 char *dump = dump_object (op);
1414 LOG (llevError, "Trying to insert in null-map!\n%s\n", errmsg); 1276 LOG (llevError, "Trying to insert in null-map!\n%s\n", dump);
1277 free (dump);
1415 return op; 1278 return op;
1416 } 1279 }
1417 1280
1418 if (out_of_map (m, op->x, op->y)) 1281 if (out_of_map (m, op->x, op->y))
1419 { 1282 {
1420 dump_object (op); 1283 char *dump = dump_object (op);
1421 LOG (llevError, "Trying to insert object outside the map.\n%s\n", errmsg); 1284 LOG (llevError, "Trying to insert object outside the map.\n%s\n", dump);
1422#ifdef MANY_CORES 1285#ifdef MANY_CORES
1423 /* Better to catch this here, as otherwise the next use of this object 1286 /* Better to catch this here, as otherwise the next use of this object
1424 * is likely to cause a crash. Better to find out where it is getting 1287 * is likely to cause a crash. Better to find out where it is getting
1425 * improperly inserted. 1288 * improperly inserted.
1426 */ 1289 */
1427 abort (); 1290 abort ();
1428#endif 1291#endif
1292 free (dump);
1429 return op; 1293 return op;
1430 } 1294 }
1431 1295
1432 if (!QUERY_FLAG (op, FLAG_REMOVED)) 1296 if (!QUERY_FLAG (op, FLAG_REMOVED))
1433 { 1297 {
1434 dump_object (op); 1298 char *dump = dump_object (op);
1435 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", errmsg); 1299 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", dump);
1300 free (dump);
1436 return op; 1301 return op;
1437 } 1302 }
1438 1303
1439 if (op->more != NULL) 1304 if (op->more != NULL)
1440 { 1305 {
1441 /* The part may be on a different map. */ 1306 /* The part may be on a different map. */
1442 1307
1443 object *
1444 more = op->more; 1308 object *more = op->more;
1445 1309
1446 /* We really need the caller to normalize coordinates - if 1310 /* We really need the caller to normalize coordinates - if
1447 * we set the map, that doesn't work if the location is within 1311 * we set the map, that doesn't work if the location is within
1448 * a map and this is straddling an edge. So only if coordinate 1312 * a map and this is straddling an edge. So only if coordinate
1449 * is clear wrong do we normalize it. 1313 * is clear wrong do we normalize it.
1450 */ 1314 */
1451 if (OUT_OF_REAL_MAP (more->map, more->x, more->y)) 1315 if (OUT_OF_REAL_MAP (more->map, more->x, more->y))
1452 {
1453 more->map = get_map_from_coord (m, &more->x, &more->y); 1316 more->map = get_map_from_coord (m, &more->x, &more->y);
1454 }
1455 else if (!more->map) 1317 else if (!more->map)
1456 { 1318 {
1457 /* For backwards compatibility - when not dealing with tiled maps, 1319 /* For backwards compatibility - when not dealing with tiled maps,
1458 * more->map should always point to the parent. 1320 * more->map should always point to the parent.
1459 */ 1321 */
1462 1324
1463 if (insert_ob_in_map (more, more->map, originator, flag) == NULL) 1325 if (insert_ob_in_map (more, more->map, originator, flag) == NULL)
1464 { 1326 {
1465 if (!op->head) 1327 if (!op->head)
1466 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n"); 1328 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n");
1329
1467 return NULL; 1330 return NULL;
1468 } 1331 }
1469 } 1332 }
1470 1333
1471 CLEAR_FLAG (op, FLAG_REMOVED); 1334 CLEAR_FLAG (op, FLAG_REMOVED);
1480 1343
1481 /* this has to be done after we translate the coordinates. 1344 /* this has to be done after we translate the coordinates.
1482 */ 1345 */
1483 if (op->nrof && !(flag & INS_NO_MERGE)) 1346 if (op->nrof && !(flag & INS_NO_MERGE))
1484 for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above) 1347 for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above)
1485 if (CAN_MERGE (op, tmp)) 1348 if (object::can_merge (op, tmp))
1486 { 1349 {
1487 op->nrof += tmp->nrof; 1350 op->nrof += tmp->nrof;
1488 remove_ob (tmp); 1351 tmp->destroy ();
1489 free_object (tmp);
1490 } 1352 }
1491 1353
1492 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1354 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1493 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1355 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1494 1356
1536 1398
1537 while (top != NULL) 1399 while (top != NULL)
1538 { 1400 {
1539 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1401 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))
1540 floor = top; 1402 floor = top;
1403
1541 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1404 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))
1542 { 1405 {
1543 /* We insert above top, so we want this object below this */ 1406 /* We insert above top, so we want this object below this */
1544 top = top->below; 1407 top = top->below;
1545 break; 1408 break;
1546 } 1409 }
1410
1547 last = top; 1411 last = top;
1548 top = top->above; 1412 top = top->above;
1549 } 1413 }
1414
1550 /* Don't want top to be NULL, so set it to the last valid object */ 1415 /* Don't want top to be NULL, so set it to the last valid object */
1551 top = last; 1416 top = last;
1552 1417
1553 /* We let update_position deal with figuring out what the space 1418 /* We let update_position deal with figuring out what the space
1554 * looks like instead of lots of conditions here. 1419 * looks like instead of lots of conditions here.
1619 * it, so save a few ticks and start from there. 1484 * it, so save a few ticks and start from there.
1620 */ 1485 */
1621 if (!(flag & INS_MAP_LOAD)) 1486 if (!(flag & INS_MAP_LOAD))
1622 for (tmp = floor ? floor : GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1487 for (tmp = floor ? floor : GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above)
1623 if (tmp->type == PLAYER) 1488 if (tmp->type == PLAYER)
1624 tmp->contr->socket.update_look = 1; 1489 tmp->contr->socket->update_look = 1;
1625 1490
1626 /* If this object glows, it may affect lighting conditions that are 1491 /* If this object glows, it may affect lighting conditions that are
1627 * visible to others on this map. But update_all_los is really 1492 * visible to others on this map. But update_all_los is really
1628 * an inefficient way to do this, as it means los for all players 1493 * an inefficient way to do this, as it means los for all players
1629 * on the map will get recalculated. The players could very well 1494 * on the map will get recalculated. The players could very well
1633 * of effect may be sufficient. 1498 * of effect may be sufficient.
1634 */ 1499 */
1635 if (MAP_DARKNESS (op->map) && (op->glow_radius != 0)) 1500 if (MAP_DARKNESS (op->map) && (op->glow_radius != 0))
1636 update_all_los (op->map, op->x, op->y); 1501 update_all_los (op->map, op->x, op->y);
1637 1502
1638
1639 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1503 /* updates flags (blocked, alive, no magic, etc) for this map space */
1640 update_object (op, UP_OBJ_INSERT); 1504 update_object (op, UP_OBJ_INSERT);
1641
1642 1505
1643 /* Don't know if moving this to the end will break anything. However, 1506 /* Don't know if moving this to the end will break anything. However,
1644 * we want to have update_look set above before calling this. 1507 * we want to have update_look set above before calling this.
1645 * 1508 *
1646 * check_move_on() must be after this because code called from 1509 * check_move_on() must be after this because code called from
1671 * op is the object to insert it under: supplies x and the map. 1534 * op is the object to insert it under: supplies x and the map.
1672 */ 1535 */
1673void 1536void
1674replace_insert_ob_in_map (const char *arch_string, object *op) 1537replace_insert_ob_in_map (const char *arch_string, object *op)
1675{ 1538{
1676 object *tmp; 1539 object *
1540 tmp;
1677 object *tmp1; 1541 object *
1542 tmp1;
1678 1543
1679 /* first search for itself and remove any old instances */ 1544 /* first search for itself and remove any old instances */
1680 1545
1681 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1546 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above)
1682 {
1683 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */ 1547 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */
1684 { 1548 tmp->destroy ();
1685 remove_ob (tmp);
1686 free_object (tmp);
1687 }
1688 }
1689 1549
1690 tmp1 = arch_to_object (find_archetype (arch_string)); 1550 tmp1 = arch_to_object (archetype::find (arch_string));
1691 1551
1692 tmp1->x = op->x; 1552 tmp1->x = op->x;
1693 tmp1->y = op->y; 1553 tmp1->y = op->y;
1694 insert_ob_in_map (tmp1, op->map, op, 0); 1554 insert_ob_in_map (tmp1, op->map, op, 0);
1695} 1555}
1703 */ 1563 */
1704 1564
1705object * 1565object *
1706get_split_ob (object *orig_ob, uint32 nr) 1566get_split_ob (object *orig_ob, uint32 nr)
1707{ 1567{
1708 object * 1568 object *newob;
1709 newob;
1710 int
1711 is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0); 1569 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1712 1570
1713 if (orig_ob->nrof < nr) 1571 if (orig_ob->nrof < nr)
1714 { 1572 {
1715 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name); 1573 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1716 return NULL; 1574 return NULL;
1717 } 1575 }
1576
1718 newob = object_create_clone (orig_ob); 1577 newob = object_create_clone (orig_ob);
1578
1719 if ((orig_ob->nrof -= nr) < 1) 1579 if ((orig_ob->nrof -= nr) < 1)
1720 { 1580 orig_ob->destroy (1);
1721 if (!is_removed)
1722 remove_ob (orig_ob);
1723 free_object2 (orig_ob, 1);
1724 }
1725 else if (!is_removed) 1581 else if (!is_removed)
1726 { 1582 {
1727 if (orig_ob->env != NULL) 1583 if (orig_ob->env != NULL)
1728 sub_weight (orig_ob->env, orig_ob->weight * nr); 1584 sub_weight (orig_ob->env, orig_ob->weight * nr);
1729 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY) 1585 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY)
1731 strcpy (errmsg, "Tried to split object whose map is not in memory."); 1587 strcpy (errmsg, "Tried to split object whose map is not in memory.");
1732 LOG (llevDebug, "Error, Tried to split object whose map is not in memory.\n"); 1588 LOG (llevDebug, "Error, Tried to split object whose map is not in memory.\n");
1733 return NULL; 1589 return NULL;
1734 } 1590 }
1735 } 1591 }
1592
1736 newob->nrof = nr; 1593 newob->nrof = nr;
1737 1594
1738 return newob; 1595 return newob;
1739} 1596}
1740 1597
1747 */ 1604 */
1748 1605
1749object * 1606object *
1750decrease_ob_nr (object *op, uint32 i) 1607decrease_ob_nr (object *op, uint32 i)
1751{ 1608{
1752 object * 1609 object *tmp;
1753 tmp;
1754 player * 1610 player *pl;
1755 pl;
1756 1611
1757 if (i == 0) /* objects with op->nrof require this check */ 1612 if (i == 0) /* objects with op->nrof require this check */
1758 return op; 1613 return op;
1759 1614
1760 if (i > op->nrof) 1615 if (i > op->nrof)
1761 i = op->nrof; 1616 i = op->nrof;
1762 1617
1763 if (QUERY_FLAG (op, FLAG_REMOVED)) 1618 if (QUERY_FLAG (op, FLAG_REMOVED))
1764 {
1765 op->nrof -= i; 1619 op->nrof -= i;
1766 }
1767 else if (op->env != NULL) 1620 else if (op->env != NULL)
1768 { 1621 {
1769 /* is this object in the players inventory, or sub container 1622 /* is this object in the players inventory, or sub container
1770 * therein? 1623 * therein?
1771 */ 1624 */
1796 esrv_send_item (tmp, op); 1649 esrv_send_item (tmp, op);
1797 } 1650 }
1798 } 1651 }
1799 else 1652 else
1800 { 1653 {
1801 remove_ob (op); 1654 op->remove ();
1802 op->nrof = 0; 1655 op->nrof = 0;
1803 if (tmp) 1656 if (tmp)
1804 { 1657 {
1805 esrv_del_item (tmp->contr, op->count); 1658 esrv_del_item (tmp->contr, op->count);
1806 } 1659 }
1807 } 1660 }
1808 } 1661 }
1809 else 1662 else
1810 { 1663 {
1811 object *
1812 above = op->above; 1664 object *above = op->above;
1813 1665
1814 if (i < op->nrof) 1666 if (i < op->nrof)
1815 {
1816 op->nrof -= i; 1667 op->nrof -= i;
1817 }
1818 else 1668 else
1819 { 1669 {
1820 remove_ob (op); 1670 op->remove ();
1821 op->nrof = 0; 1671 op->nrof = 0;
1822 } 1672 }
1673
1823 /* Since we just removed op, op->above is null */ 1674 /* Since we just removed op, op->above is null */
1824 for (tmp = above; tmp != NULL; tmp = tmp->above) 1675 for (tmp = above; tmp != NULL; tmp = tmp->above)
1825 if (tmp->type == PLAYER) 1676 if (tmp->type == PLAYER)
1826 { 1677 {
1827 if (op->nrof) 1678 if (op->nrof)
1830 esrv_del_item (tmp->contr, op->count); 1681 esrv_del_item (tmp->contr, op->count);
1831 } 1682 }
1832 } 1683 }
1833 1684
1834 if (op->nrof) 1685 if (op->nrof)
1835 {
1836 return op; 1686 return op;
1837 }
1838 else 1687 else
1839 { 1688 {
1840 free_object (op); 1689 op->destroy ();
1841 return NULL; 1690 return NULL;
1842 } 1691 }
1843} 1692}
1844 1693
1845/* 1694/*
1851add_weight (object *op, signed long weight) 1700add_weight (object *op, signed long weight)
1852{ 1701{
1853 while (op != NULL) 1702 while (op != NULL)
1854 { 1703 {
1855 if (op->type == CONTAINER) 1704 if (op->type == CONTAINER)
1856 {
1857 weight = (signed long) (weight * (100 - op->stats.Str) / 100); 1705 weight = (signed long) (weight * (100 - op->stats.Str) / 100);
1858 } 1706
1859 op->carrying += weight; 1707 op->carrying += weight;
1860 op = op->env; 1708 op = op->env;
1861 } 1709 }
1862} 1710}
1863 1711
1712object *
1713insert_ob_in_ob (object *op, object *where)
1714{
1715 if (!where)
1716 {
1717 char *dump = dump_object (op);
1718 LOG (llevError, "Trying to put object in NULL.\n%s\n", dump);
1719 free (dump);
1720 return op;
1721 }
1722
1723 if (where->head)
1724 {
1725 LOG (llevDebug, "Warning: Tried to insert object into wrong part of multipart object.\n");
1726 where = where->head;
1727 }
1728
1729 return where->insert (op);
1730}
1731
1864/* 1732/*
1865 * insert_ob_in_ob(op,environment): 1733 * env->insert (op)
1866 * This function inserts the object op in the linked list 1734 * This function inserts the object op in the linked list
1867 * inside the object environment. 1735 * inside the object environment.
1868 * 1736 *
1869 * Eneq(@csd.uu.se): Altered insert_ob_in_ob to make things picked up enter
1870 * the inventory at the last position or next to other objects of the same
1871 * type.
1872 * Frank: Now sorted by type, archetype and magic!
1873 *
1874 * The function returns now pointer to inserted item, and return value can 1737 * The function returns now pointer to inserted item, and return value can
1875 * be != op, if items are merged. -Tero 1738 * be != op, if items are merged. -Tero
1876 */ 1739 */
1877 1740
1878object * 1741object *
1879insert_ob_in_ob (object *op, object *where) 1742object::insert (object *op)
1880{ 1743{
1881 object * 1744 object *tmp, *otmp;
1882 tmp, *
1883 otmp;
1884 1745
1885 if (!QUERY_FLAG (op, FLAG_REMOVED)) 1746 if (!QUERY_FLAG (op, FLAG_REMOVED))
1886 { 1747 op->remove ();
1887 dump_object (op); 1748
1888 LOG (llevError, "Trying to insert (ob) inserted object.\n%s\n", errmsg);
1889 return op;
1890 }
1891 if (where == NULL)
1892 {
1893 dump_object (op);
1894 LOG (llevError, "Trying to put object in NULL.\n%s\n", errmsg);
1895 return op;
1896 }
1897 if (where->head)
1898 {
1899 LOG (llevDebug, "Warning: Tried to insert object wrong part of multipart object.\n");
1900 where = where->head;
1901 }
1902 if (op->more) 1749 if (op->more)
1903 { 1750 {
1904 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count); 1751 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);
1905 return op; 1752 return op;
1906 } 1753 }
1754
1907 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL); 1755 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL);
1908 CLEAR_FLAG (op, FLAG_REMOVED); 1756 CLEAR_FLAG (op, FLAG_REMOVED);
1909 if (op->nrof) 1757 if (op->nrof)
1910 { 1758 {
1911 for (tmp = where->inv; tmp != NULL; tmp = tmp->below) 1759 for (tmp = inv; tmp != NULL; tmp = tmp->below)
1912 if (CAN_MERGE (tmp, op)) 1760 if (object::can_merge (tmp, op))
1913 { 1761 {
1914 /* return the original object and remove inserted object 1762 /* return the original object and remove inserted object
1915 (client needs the original object) */ 1763 (client needs the original object) */
1916 tmp->nrof += op->nrof; 1764 tmp->nrof += op->nrof;
1917 /* Weight handling gets pretty funky. Since we are adding to 1765 /* Weight handling gets pretty funky. Since we are adding to
1918 * tmp->nrof, we need to increase the weight. 1766 * tmp->nrof, we need to increase the weight.
1919 */ 1767 */
1920 add_weight (where, op->weight * op->nrof); 1768 add_weight (this, op->weight * op->nrof);
1921 SET_FLAG (op, FLAG_REMOVED); 1769 SET_FLAG (op, FLAG_REMOVED);
1922 free_object (op); /* free the inserted object */ 1770 op->destroy (); /* free the inserted object */
1923 op = tmp; 1771 op = tmp;
1924 remove_ob (op); /* and fix old object's links */ 1772 op->remove (); /* and fix old object's links */
1925 CLEAR_FLAG (op, FLAG_REMOVED); 1773 CLEAR_FLAG (op, FLAG_REMOVED);
1926 break; 1774 break;
1927 } 1775 }
1928 1776
1929 /* I assume combined objects have no inventory 1777 /* I assume combined objects have no inventory
1930 * We add the weight - this object could have just been removed 1778 * We add the weight - this object could have just been removed
1931 * (if it was possible to merge). calling remove_ob will subtract 1779 * (if it was possible to merge). calling remove_ob will subtract
1932 * the weight, so we need to add it in again, since we actually do 1780 * the weight, so we need to add it in again, since we actually do
1933 * the linking below 1781 * the linking below
1934 */ 1782 */
1935 add_weight (where, op->weight * op->nrof); 1783 add_weight (this, op->weight * op->nrof);
1936 } 1784 }
1937 else 1785 else
1938 add_weight (where, (op->weight + op->carrying)); 1786 add_weight (this, (op->weight + op->carrying));
1939 1787
1940 otmp = is_player_inv (where); 1788 otmp = is_player_inv (this);
1941 if (otmp && otmp->contr != NULL) 1789 if (otmp && otmp->contr)
1942 {
1943 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1790 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1944 fix_player (otmp); 1791 fix_player (otmp);
1945 }
1946 1792
1947 op->map = NULL; 1793 op->map = NULL;
1948 op->env = where; 1794 op->env = this;
1949 op->above = NULL; 1795 op->above = NULL;
1950 op->below = NULL; 1796 op->below = NULL;
1951 op->x = 0, op->y = 0; 1797 op->x = 0, op->y = 0;
1952 1798
1953 /* reset the light list and los of the players on the map */ 1799 /* reset the light list and los of the players on the map */
1954 if ((op->glow_radius != 0) && where->map) 1800 if ((op->glow_radius != 0) && map)
1955 { 1801 {
1956#ifdef DEBUG_LIGHTS 1802#ifdef DEBUG_LIGHTS
1957 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name); 1803 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1958#endif /* DEBUG_LIGHTS */ 1804#endif /* DEBUG_LIGHTS */
1959 if (MAP_DARKNESS (where->map)) 1805 if (MAP_DARKNESS (map))
1960 update_all_los (where->map, where->x, where->y); 1806 update_all_los (map, x, y);
1961 } 1807 }
1962 1808
1963 /* Client has no idea of ordering so lets not bother ordering it here. 1809 /* Client has no idea of ordering so lets not bother ordering it here.
1964 * It sure simplifies this function... 1810 * It sure simplifies this function...
1965 */ 1811 */
1966 if (where->inv == NULL) 1812 if (!inv)
1967 where->inv = op; 1813 inv = op;
1968 else 1814 else
1969 { 1815 {
1970 op->below = where->inv; 1816 op->below = inv;
1971 op->below->above = op; 1817 op->below->above = op;
1972 where->inv = op; 1818 inv = op;
1973 } 1819 }
1820
1974 return op; 1821 return op;
1975} 1822}
1976 1823
1977/* 1824/*
1978 * Checks if any objects has a move_type that matches objects 1825 * Checks if any objects has a move_type that matches objects
1996 */ 1843 */
1997 1844
1998int 1845int
1999check_move_on (object *op, object *originator) 1846check_move_on (object *op, object *originator)
2000{ 1847{
2001 object * 1848 object *tmp;
2002 tmp; 1849 maptile *m = op->map;
2003 tag_t
2004 tag;
2005 mapstruct *
2006 m = op->map;
2007 int
2008 x = op->x, y = op->y; 1850 int x = op->x, y = op->y;
2009 MoveType 1851
2010 move_on, 1852 MoveType move_on, move_slow, move_block;
2011 move_slow,
2012 move_block;
2013 1853
2014 if (QUERY_FLAG (op, FLAG_NO_APPLY)) 1854 if (QUERY_FLAG (op, FLAG_NO_APPLY))
2015 return 0; 1855 return 0;
2016
2017 tag = op->count;
2018 1856
2019 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y); 1857 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
2020 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y); 1858 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
2021 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y); 1859 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
2022 1860
2047 * we don't need to check all of them. 1885 * we don't need to check all of them.
2048 */ 1886 */
2049 if ((tmp->move_type & MOVE_FLY_LOW) && QUERY_FLAG (tmp, FLAG_NO_PICK)) 1887 if ((tmp->move_type & MOVE_FLY_LOW) && QUERY_FLAG (tmp, FLAG_NO_PICK))
2050 break; 1888 break;
2051 } 1889 }
1890
2052 for (; tmp != NULL; tmp = tmp->below) 1891 for (; tmp; tmp = tmp->below)
2053 { 1892 {
2054 if (tmp == op) 1893 if (tmp == op)
2055 continue; /* Can't apply yourself */ 1894 continue; /* Can't apply yourself */
2056 1895
2057 /* Check to see if one of the movement types should be slowed down. 1896 /* Check to see if one of the movement types should be slowed down.
2065 if ((!op->move_type && tmp->move_slow & MOVE_WALK) || 1904 if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
2066 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0)) 1905 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
2067 { 1906 {
2068 1907
2069 float 1908 float
2070 diff;
2071
2072 diff = tmp->move_slow_penalty * FABS (op->speed); 1909 diff = tmp->move_slow_penalty * FABS (op->speed);
1910
2073 if (op->type == PLAYER) 1911 if (op->type == PLAYER)
2074 {
2075 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) || 1912 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) ||
2076 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN))) 1913 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN)))
2077 {
2078 diff /= 4.0; 1914 diff /= 4.0;
2079 } 1915
2080 }
2081 op->speed_left -= diff; 1916 op->speed_left -= diff;
2082 } 1917 }
2083 } 1918 }
2084 1919
2085 /* Basically same logic as above, except now for actual apply. */ 1920 /* Basically same logic as above, except now for actual apply. */
2086 if ((!op->move_type && tmp->move_on & MOVE_WALK) || 1921 if ((!op->move_type && tmp->move_on & MOVE_WALK) ||
2087 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0)) 1922 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0))
2088 { 1923 {
2089
2090 move_apply (tmp, op, originator); 1924 move_apply (tmp, op, originator);
1925
2091 if (was_destroyed (op, tag)) 1926 if (op->destroyed ())
2092 return 1; 1927 return 1;
2093 1928
2094 /* what the person/creature stepped onto has moved the object 1929 /* what the person/creature stepped onto has moved the object
2095 * someplace new. Don't process any further - if we did, 1930 * someplace new. Don't process any further - if we did,
2096 * have a feeling strange problems would result. 1931 * have a feeling strange problems would result.
2097 */ 1932 */
2098 if (op->map != m || op->x != x || op->y != y) 1933 if (op->map != m || op->x != x || op->y != y)
2099 return 0; 1934 return 0;
2100 } 1935 }
2101 } 1936 }
1937
2102 return 0; 1938 return 0;
2103} 1939}
2104 1940
2105/* 1941/*
2106 * present_arch(arch, map, x, y) searches for any objects with 1942 * present_arch(arch, map, x, y) searches for any objects with
2107 * a matching archetype at the given map and coordinates. 1943 * a matching archetype at the given map and coordinates.
2108 * The first matching object is returned, or NULL if none. 1944 * The first matching object is returned, or NULL if none.
2109 */ 1945 */
2110 1946
2111object * 1947object *
2112present_arch (const archetype *at, mapstruct *m, int x, int y) 1948present_arch (const archetype *at, maptile *m, int x, int y)
2113{ 1949{
2114 object * 1950 object *
2115 tmp; 1951 tmp;
2116 1952
2117 if (m == NULL || out_of_map (m, x, y)) 1953 if (m == NULL || out_of_map (m, x, y))
2130 * a matching type variable at the given map and coordinates. 1966 * a matching type variable at the given map and coordinates.
2131 * The first matching object is returned, or NULL if none. 1967 * The first matching object is returned, or NULL if none.
2132 */ 1968 */
2133 1969
2134object * 1970object *
2135present (unsigned char type, mapstruct *m, int x, int y) 1971present (unsigned char type, maptile *m, int x, int y)
2136{ 1972{
2137 object * 1973 object *
2138 tmp; 1974 tmp;
2139 1975
2140 if (out_of_map (m, x, y)) 1976 if (out_of_map (m, x, y))
2280 * the archetype because that isn't correct if the monster has been 2116 * the archetype because that isn't correct if the monster has been
2281 * customized, changed states, etc. 2117 * customized, changed states, etc.
2282 */ 2118 */
2283 2119
2284int 2120int
2285find_free_spot (const object *ob, mapstruct *m, int x, int y, int start, int stop) 2121find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)
2286{ 2122{
2287 int 2123 int
2288 i, 2124 i,
2289 index = 0, flag; 2125 index = 0, flag;
2290 static int 2126 static int
2311 return -1; 2147 return -1;
2312 return altern[RANDOM () % index]; 2148 return altern[RANDOM () % index];
2313} 2149}
2314 2150
2315/* 2151/*
2316 * find_first_free_spot(archetype, mapstruct, x, y) works like 2152 * find_first_free_spot(archetype, maptile, x, y) works like
2317 * find_free_spot(), but it will search max number of squares. 2153 * find_free_spot(), but it will search max number of squares.
2318 * But it will return the first available spot, not a random choice. 2154 * But it will return the first available spot, not a random choice.
2319 * Changed 0.93.2: Have it return -1 if there is no free spot available. 2155 * Changed 0.93.2: Have it return -1 if there is no free spot available.
2320 */ 2156 */
2321 2157
2322int 2158int
2323find_first_free_spot (const object *ob, mapstruct *m, int x, int y) 2159find_first_free_spot (const object *ob, maptile *m, int x, int y)
2324{ 2160{
2325 int 2161 int
2326 i; 2162 i;
2327 2163
2328 for (i = 0; i < SIZEOFFREE; i++) 2164 for (i = 0; i < SIZEOFFREE; i++)
2392 * because we have to know what movement the thing looking to move 2228 * because we have to know what movement the thing looking to move
2393 * there is capable of. 2229 * there is capable of.
2394 */ 2230 */
2395 2231
2396int 2232int
2397find_dir (mapstruct *m, int x, int y, object *exclude) 2233find_dir (maptile *m, int x, int y, object *exclude)
2398{ 2234{
2399 int 2235 int
2400 i, 2236 i,
2401 max = SIZEOFFREE, mflags; 2237 max = SIZEOFFREE, mflags;
2402 sint16 2238
2403 nx, 2239 sint16 nx, ny;
2404 ny;
2405 object * 2240 object *
2406 tmp; 2241 tmp;
2407 mapstruct * 2242 maptile *
2408 mp; 2243 mp;
2409 MoveType 2244
2410 blocked, 2245 MoveType blocked, move_type;
2411 move_type;
2412 2246
2413 if (exclude && exclude->head) 2247 if (exclude && exclude->head)
2414 { 2248 {
2415 exclude = exclude->head; 2249 exclude = exclude->head;
2416 move_type = exclude->move_type; 2250 move_type = exclude->move_type;
2621 * Modified to be map tile aware -.MSW 2455 * Modified to be map tile aware -.MSW
2622 */ 2456 */
2623 2457
2624 2458
2625int 2459int
2626can_see_monsterP (mapstruct *m, int x, int y, int dir) 2460can_see_monsterP (maptile *m, int x, int y, int dir)
2627{ 2461{
2628 sint16 2462 sint16 dx, dy;
2629 dx,
2630 dy;
2631 int 2463 int
2632 mflags; 2464 mflags;
2633 2465
2634 if (dir < 0) 2466 if (dir < 0)
2635 return 0; /* exit condition: invalid direction */ 2467 return 0; /* exit condition: invalid direction */
2682 * create clone from object to another 2514 * create clone from object to another
2683 */ 2515 */
2684object * 2516object *
2685object_create_clone (object *asrc) 2517object_create_clone (object *asrc)
2686{ 2518{
2687 object *
2688 dst = NULL, *tmp, *src, *part, *prev, *item; 2519 object *dst = 0, *tmp, *src, *part, *prev, *item;
2689 2520
2690 if (!asrc) 2521 if (!asrc)
2691 return NULL; 2522 return 0;
2523
2692 src = asrc; 2524 src = asrc;
2693 if (src->head) 2525 if (src->head)
2694 src = src->head; 2526 src = src->head;
2695 2527
2696 prev = NULL; 2528 prev = 0;
2697 for (part = src; part; part = part->more) 2529 for (part = src; part; part = part->more)
2698 { 2530 {
2699 tmp = get_object (); 2531 tmp = part->clone ();
2700 copy_object (part, tmp);
2701 tmp->x -= src->x; 2532 tmp->x -= src->x;
2702 tmp->y -= src->y; 2533 tmp->y -= src->y;
2534
2703 if (!part->head) 2535 if (!part->head)
2704 { 2536 {
2705 dst = tmp; 2537 dst = tmp;
2706 tmp->head = NULL; 2538 tmp->head = 0;
2707 } 2539 }
2708 else 2540 else
2709 { 2541 {
2710 tmp->head = dst; 2542 tmp->head = dst;
2711 } 2543 }
2544
2712 tmp->more = NULL; 2545 tmp->more = 0;
2546
2713 if (prev) 2547 if (prev)
2714 prev->more = tmp; 2548 prev->more = tmp;
2549
2715 prev = tmp; 2550 prev = tmp;
2716 } 2551 }
2717 2552
2718 /*** copy inventory ***/
2719 for (item = src->inv; item; item = item->below) 2553 for (item = src->inv; item; item = item->below)
2720 {
2721 (void) insert_ob_in_ob (object_create_clone (item), dst); 2554 insert_ob_in_ob (object_create_clone (item), dst);
2722 }
2723 2555
2724 return dst; 2556 return dst;
2725} 2557}
2726 2558
2727/* return true if the object was destroyed, 0 otherwise */
2728int
2729was_destroyed (const object *op, tag_t old_tag)
2730{
2731 /* checking for FLAG_FREED isn't necessary, but makes this function more
2732 * robust */
2733 return op->count != old_tag || QUERY_FLAG (op, FLAG_FREED);
2734}
2735
2736/* GROS - Creates an object using a string representing its content. */ 2559/* GROS - Creates an object using a string representing its content. */
2737
2738/* Basically, we save the content of the string to a temp file, then call */ 2560/* Basically, we save the content of the string to a temp file, then call */
2739
2740/* load_object on it. I admit it is a highly inefficient way to make things, */ 2561/* load_object on it. I admit it is a highly inefficient way to make things, */
2741
2742/* but it was simple to make and allows reusing the load_object function. */ 2562/* but it was simple to make and allows reusing the load_object function. */
2743
2744/* Remember not to use load_object_str in a time-critical situation. */ 2563/* Remember not to use load_object_str in a time-critical situation. */
2745
2746/* Also remember that multiparts objects are not supported for now. */ 2564/* Also remember that multiparts objects are not supported for now. */
2747 2565
2748object * 2566object *
2749load_object_str (const char *obstr) 2567load_object_str (const char *obstr)
2750{ 2568{
2751 object * 2569 object *op;
2752 op;
2753 char
2754 filename[MAX_BUF]; 2570 char filename[MAX_BUF];
2755 2571
2756 sprintf (filename, "%s/cfloadobstr2044", settings.tmpdir); 2572 sprintf (filename, "%s/cfloadobstr2044", settings.tmpdir);
2757 2573
2758 FILE *
2759 tempfile = fopen (filename, "w"); 2574 FILE *tempfile = fopen (filename, "w");
2760 2575
2761 if (tempfile == NULL) 2576 if (tempfile == NULL)
2762 { 2577 {
2763 LOG (llevError, "Error - Unable to access load object temp file\n"); 2578 LOG (llevError, "Error - Unable to access load object temp file\n");
2764 return NULL; 2579 return NULL;
2765 }; 2580 }
2581
2766 fprintf (tempfile, obstr); 2582 fprintf (tempfile, obstr);
2767 fclose (tempfile); 2583 fclose (tempfile);
2768 2584
2769 op = get_object (); 2585 op = object::create ();
2770 2586
2771 object_thawer 2587 object_thawer thawer (filename);
2772 thawer (filename);
2773 2588
2774 if (thawer) 2589 if (thawer)
2775 load_object (thawer, op, 0); 2590 load_object (thawer, op, 0);
2776 2591
2777 LOG (llevDebug, " load str completed, object=%s\n", &op->name); 2592 LOG (llevDebug, " load str completed, object=%s\n", &op->name);
2785 * returns NULL if no match. 2600 * returns NULL if no match.
2786 */ 2601 */
2787object * 2602object *
2788find_obj_by_type_subtype (const object *who, int type, int subtype) 2603find_obj_by_type_subtype (const object *who, int type, int subtype)
2789{ 2604{
2790 object * 2605 object *tmp;
2791 tmp;
2792 2606
2793 for (tmp = who->inv; tmp; tmp = tmp->below) 2607 for (tmp = who->inv; tmp; tmp = tmp->below)
2794 if (tmp->type == type && tmp->subtype == subtype) 2608 if (tmp->type == type && tmp->subtype == subtype)
2795 return tmp; 2609 return tmp;
2796 2610
2804 * do the desired thing. 2618 * do the desired thing.
2805 */ 2619 */
2806key_value * 2620key_value *
2807get_ob_key_link (const object *ob, const char *key) 2621get_ob_key_link (const object *ob, const char *key)
2808{ 2622{
2809 key_value * 2623 key_value *link;
2810 link;
2811 2624
2812 for (link = ob->key_values; link != NULL; link = link->next) 2625 for (link = ob->key_values; link != NULL; link = link->next)
2813 {
2814 if (link->key == key) 2626 if (link->key == key)
2815 {
2816 return link; 2627 return link;
2817 }
2818 }
2819 2628
2820 return NULL; 2629 return NULL;
2821} 2630}
2822 2631
2823/* 2632/*
2828 * The returned string is shared. 2637 * The returned string is shared.
2829 */ 2638 */
2830const char * 2639const char *
2831get_ob_key_value (const object *op, const char *const key) 2640get_ob_key_value (const object *op, const char *const key)
2832{ 2641{
2833 key_value * 2642 key_value *link;
2834 link; 2643 shstr_cmp canonical_key (key);
2835 const char *
2836 canonical_key;
2837 2644
2838 canonical_key = shstr::find (key);
2839
2840 if (canonical_key == NULL) 2645 if (!canonical_key)
2841 { 2646 {
2842 /* 1. There being a field named key on any object 2647 /* 1. There being a field named key on any object
2843 * implies there'd be a shared string to find. 2648 * implies there'd be a shared string to find.
2844 * 2. Since there isn't, no object has this field. 2649 * 2. Since there isn't, no object has this field.
2845 * 3. Therefore, *this* object doesn't have this field. 2650 * 3. Therefore, *this* object doesn't have this field.
2846 */ 2651 */
2847 return NULL; 2652 return 0;
2848 } 2653 }
2849 2654
2850 /* This is copied from get_ob_key_link() above - 2655 /* This is copied from get_ob_key_link() above -
2851 * only 4 lines, and saves the function call overhead. 2656 * only 4 lines, and saves the function call overhead.
2852 */ 2657 */
2853 for (link = op->key_values; link != NULL; link = link->next) 2658 for (link = op->key_values; link; link = link->next)
2854 {
2855 if (link->key == canonical_key) 2659 if (link->key == canonical_key)
2856 {
2857 return link->value; 2660 return link->value;
2858 } 2661
2859 }
2860 return NULL; 2662 return 0;
2861} 2663}
2862 2664
2863 2665
2864/* 2666/*
2865 * Updates the canonical_key in op to value. 2667 * Updates the canonical_key in op to value.
2901 if (last) 2703 if (last)
2902 last->next = field->next; 2704 last->next = field->next;
2903 else 2705 else
2904 op->key_values = field->next; 2706 op->key_values = field->next;
2905 2707
2906 delete
2907 field; 2708 delete field;
2908 } 2709 }
2909 } 2710 }
2910 return TRUE; 2711 return TRUE;
2911 } 2712 }
2912 /* IF we get here, key doesn't exist */ 2713 /* IF we get here, key doesn't exist */
2947 * Returns TRUE on success. 2748 * Returns TRUE on success.
2948 */ 2749 */
2949int 2750int
2950set_ob_key_value (object *op, const char *key, const char *value, int add_key) 2751set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2951{ 2752{
2952 shstr
2953 key_ (key); 2753 shstr key_ (key);
2954 2754
2955 return set_ob_key_value_s (op, key_, value, add_key); 2755 return set_ob_key_value_s (op, key_, value, add_key);
2956} 2756}
2757
2758object::depth_iterator::depth_iterator (object *container)
2759: iterator_base (container)
2760{
2761 while (item->inv)
2762 item = item->inv;
2763}
2764
2765void
2766object::depth_iterator::next ()
2767{
2768 if (item->below)
2769 {
2770 item = item->below;
2771
2772 while (item->inv)
2773 item = item->inv;
2774 }
2775 else
2776 item = item->env;
2777}
2778
2779// return a suitable string describing an objetc in enough detail to find it
2780const char *
2781object::debug_desc (char *info) const
2782{
2783 char info2[256 * 3];
2784 char *p = info;
2785
2786 p += snprintf (p, 256, "%d=\"%s%s%s\"",
2787 count,
2788 &name,
2789 title ? " " : "",
2790 title ? (const char *)title : "");
2791
2792 if (env)
2793 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2794
2795 if (map)
2796 p += snprintf (p, 256, "(on %s@%d+%d)", map->path, x, y);
2797
2798 return info;
2799}
2800
2801const char *
2802object::debug_desc () const
2803{
2804 static char info[256 * 3];
2805 return debug_desc (info);
2806}
2807

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines