ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.201 by root, Tue Jan 22 16:22:45 2008 UTC vs.
Revision 1.261 by root, Wed Oct 1 16:04:16 2008 UTC

1/* 1/*
2 * This file is part of Deliantra, the Roguelike Realtime MMORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007 Marc Alexander Lehmann / Robin Redeker / the Deliantra team 4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 * 7 *
8 * Deliantra is free software: you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify
9 * it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
19 * along with this program. If not, see <http://www.gnu.org/licenses/>. 19 * along with this program. If not, see <http://www.gnu.org/licenses/>.
20 * 20 *
21 * The authors can be reached via e-mail to <support@deliantra.net> 21 * The authors can be reached via e-mail to <support@deliantra.net>
22 */ 22 */
23 23
24/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
25 sub/add_weight will transcend the environment updating the carrying
26 variable. */
27#include <global.h> 24#include <global.h>
28#include <stdio.h> 25#include <stdio.h>
29#include <sys/types.h> 26#include <sys/types.h>
30#include <sys/uio.h> 27#include <sys/uio.h>
31#include <object.h> 28#include <object.h>
32#include <funcpoint.h>
33#include <sproto.h> 29#include <sproto.h>
34#include <loader.h> 30#include <loader.h>
35 31
36#include <bitset> 32#include <bitset>
37 33
38int nrofallocobjects = 0; 34UUID UUID::cur;
39static UUID uuid; 35static uint64_t seq_next_save;
40const uint64 UUID_SKIP = 1<<19; 36static const uint64 UUID_GAP = 1<<19;
41 37
42objectvec objects; 38objectvec objects;
43activevec actives; 39activevec actives;
44 40
45short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 41short freearr_x[SIZEOFFREE] = {
42 0,
43 0, 1, 1, 1, 0, -1, -1, -1,
44 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
46 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1 45 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1
47}; 46};
48short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, 47short freearr_y[SIZEOFFREE] = {
48 0,
49 -1, -1, 0, 1, 1, 1, 0, -1,
50 -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
49 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3 51 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3
50}; 52};
51int maxfree[SIZEOFFREE] = { 0, 9, 10, 13, 14, 17, 18, 21, 22, 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 53int maxfree[SIZEOFFREE] = {
54 0,
55 9, 10, 13, 14, 17, 18, 21, 22,
56 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
52 48, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49 57 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
53}; 58};
54int freedir[SIZEOFFREE] = { 59int freedir[SIZEOFFREE] = {
55 0, 1, 2, 3, 4, 5, 6, 7, 8, 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8, 60 0,
61 1, 2, 3, 4, 5, 6, 7, 8,
62 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,
56 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8 63 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8
57}; 64};
58 65
59static void 66static void
60write_uuid (void) 67write_uuid (uval64 skip, bool sync)
61{ 68{
62 char filename1[MAX_BUF], filename2[MAX_BUF]; 69 CALL_BEGIN (2);
63 70 CALL_ARG_SV (newSVval64 (skip));
64 sprintf (filename1, "%s/uuid", settings.localdir); 71 CALL_ARG_SV (boolSV (sync));
65 sprintf (filename2, "%s/uuid~", settings.localdir); 72 CALL_CALL ("cf::write_uuid", G_DISCARD);
66 73 CALL_END;
67 FILE *fp;
68
69 if (!(fp = fopen (filename2, "w")))
70 {
71 LOG (llevError, "ERROR: cannot open %s for writing, unable to write UUID!\n", filename2);
72 return;
73 }
74
75 fprintf (fp, "<1,%llx>\n", (unsigned long long)uuid.seq + UUID_SKIP * 2);
76 fclose (fp);
77 rename (filename2, filename1);
78} 74}
79 75
80static void 76static void
81read_uuid (void) 77read_uuid (void)
82{ 78{
83 char filename[MAX_BUF]; 79 char filename[MAX_BUF];
84 80
85 sprintf (filename, "%s/uuid", settings.localdir); 81 sprintf (filename, "%s/uuid", settings.localdir);
82
83 seq_next_save = 0;
86 84
87 FILE *fp; 85 FILE *fp;
88 86
89 if (!(fp = fopen (filename, "r"))) 87 if (!(fp = fopen (filename, "r")))
90 { 88 {
91 if (errno == ENOENT) 89 if (errno == ENOENT)
92 { 90 {
93 LOG (llevInfo, "RESET uid to 1\n"); 91 LOG (llevInfo, "RESET uid to 1\n");
94 uuid.seq = 0; 92 UUID::cur.seq = 0;
95 write_uuid (); 93 write_uuid (UUID_GAP, true);
96 return; 94 return;
97 } 95 }
98 96
99 LOG (llevError, "FATAL: cannot open %s for reading!\n", filename); 97 LOG (llevError, "FATAL: cannot open %s for reading!\n", filename);
100 _exit (1); 98 _exit (1);
101 } 99 }
102 100
103 int version; 101 UUID::BUF buf;
104 unsigned long long uid; 102 buf[0] = 0;
105 if (2 != fscanf (fp, "<%d,%llx>\n", &version, &uid) || version != 1) 103 fgets (buf, sizeof (buf), fp);
104
105 if (!UUID::cur.parse (buf))
106 { 106 {
107 LOG (llevError, "FATAL: error reading uid from %s!\n", filename); 107 LOG (llevError, "FATAL: error reading uid from %s (%s)!\n", filename, buf);
108 _exit (1); 108 _exit (1);
109 } 109 }
110 110
111 uuid.seq = uid; 111 LOG (llevDebug, "read UUID: %s\n", UUID::cur.c_str ());
112 write_uuid (); 112
113 LOG (llevDebug, "read UID: %" PRId64 "\n", uid); 113 write_uuid (UUID_GAP, true);
114 fclose (fp); 114 fclose (fp);
115} 115}
116 116
117UUID 117UUID
118gen_uuid () 118UUID::gen ()
119{ 119{
120 UUID uid; 120 UUID uid;
121 121
122 uid.seq = ++uuid.seq; 122 uid.seq = ++cur.seq;
123 123
124 if (!(uuid.seq & (UUID_SKIP - 1))) 124 if (expect_false (cur.seq >= seq_next_save))
125 write_uuid (); 125 {
126 seq_next_save = UUID::cur.seq + (UUID_GAP >> 1);
127 write_uuid (UUID_GAP, false);
128 }
129
126 130
127 return uid; 131 return uid;
128} 132}
129 133
130void 134void
131init_uuid () 135UUID::init ()
132{ 136{
133 read_uuid (); 137 read_uuid ();
134} 138}
135 139
136/* Returns TRUE if every key_values in wants has a partner with the same value in has. */ 140/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
137static int 141static bool
138compare_ob_value_lists_one (const object *wants, const object *has) 142compare_ob_value_lists_one (const object *wants, const object *has)
139{ 143{
140 key_value *wants_field;
141
142 /* n-squared behaviour (see get_ob_key_link()), but I'm hoping both 144 /* n-squared behaviour (see kv_get), but I'm hoping both
143 * objects with lists are rare, and lists stay short. If not, use a 145 * objects with lists are rare, and lists stay short. If not, use a
144 * different structure or at least keep the lists sorted... 146 * different structure or at least keep the lists sorted...
145 */ 147 */
146 148
147 /* For each field in wants, */ 149 /* For each field in wants, */
148 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next) 150 for (key_value *kv = wants->key_values; kv; kv = kv->next)
149 { 151 if (has->kv_get (kv->key) != kv->value)
150 key_value *has_field; 152 return false;
151
152 /* Look for a field in has with the same key. */
153 has_field = get_ob_key_link (has, wants_field->key);
154
155 if (has_field == NULL)
156 {
157 /* No field with that name. */
158 return FALSE;
159 }
160
161 /* Found the matching field. */
162 if (has_field->value != wants_field->value)
163 {
164 /* Values don't match, so this half of the comparison is false. */
165 return FALSE;
166 }
167
168 /* If we get here, we found a match. Now for the next field in wants. */
169 }
170 153
171 /* If we get here, every field in wants has a matching field in has. */ 154 /* If we get here, every field in wants has a matching field in has. */
172 return TRUE; 155 return true;
173} 156}
174 157
175/* Returns TRUE if ob1 has the same key_values as ob2. */ 158/* Returns TRUE if ob1 has the same key_values as ob2. */
176static int 159static bool
177compare_ob_value_lists (const object *ob1, const object *ob2) 160compare_ob_value_lists (const object *ob1, const object *ob2)
178{ 161{
179 /* However, there may be fields in has which aren't partnered in wants, 162 /* However, there may be fields in has which aren't partnered in wants,
180 * so we need to run the comparison *twice*. :( 163 * so we need to run the comparison *twice*. :(
181 */ 164 */
182 return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1); 165 return compare_ob_value_lists_one (ob1, ob2)
166 && compare_ob_value_lists_one (ob2, ob1);
183} 167}
184 168
185/* Function examines the 2 objects given to it, and returns true if 169/* Function examines the 2 objects given to it, and returns true if
186 * they can be merged together. 170 * they can be merged together.
187 * 171 *
202 || ob1->speed != ob2->speed 186 || ob1->speed != ob2->speed
203 || ob1->value != ob2->value 187 || ob1->value != ob2->value
204 || ob1->name != ob2->name) 188 || ob1->name != ob2->name)
205 return 0; 189 return 0;
206 190
207 //TODO: this ain't working well, use nicer and correct overflow check
208 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that 191 /* Do not merge objects if nrof would overflow, assume nrof
209 * value could not be stored in a sint32 (which unfortunately sometimes is 192 * is always 0 .. 2**31-1 */
210 * used to store nrof). 193 if (ob1->nrof > 0x7fffffff - ob2->nrof)
211 */
212 if (ob1->nrof + ob2->nrof >= 1UL << 31)
213 return 0; 194 return 0;
214 195
215 /* If the objects have been identified, set the BEEN_APPLIED flag. 196 /* If the objects have been identified, set the BEEN_APPLIED flag.
216 * This is to the comparison of the flags below will be OK. We 197 * This is to the comparison of the flags below will be OK. We
217 * just can't ignore the been applied or identified flags, as they 198 * just can't ignore the been applied or identified flags, as they
218 * are not equal - just if it has been identified, the been_applied 199 * are not equal - just if it has been identified, the been_applied
219 * flags lose any meaning. 200 * flags lose any meaning.
220 */ 201 */
221 if (QUERY_FLAG (ob1, FLAG_IDENTIFIED)) 202 if (QUERY_FLAG (ob1, FLAG_IDENTIFIED))
222 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 203 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
223 204
224 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 205 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
225 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 206 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
226 207
227 if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any () 208 if (ob1->arch->archname != ob2->arch->archname
228 || ob1->arch != ob2->arch
229 || ob1->name != ob2->name 209 || ob1->name != ob2->name
230 || ob1->title != ob2->title 210 || ob1->title != ob2->title
231 || ob1->msg != ob2->msg 211 || ob1->msg != ob2->msg
232 || ob1->weight != ob2->weight 212 || ob1->weight != ob2->weight
233 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
234 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
235 || ob1->attacktype != ob2->attacktype 213 || ob1->attacktype != ob2->attacktype
236 || ob1->magic != ob2->magic 214 || ob1->magic != ob2->magic
237 || ob1->slaying != ob2->slaying 215 || ob1->slaying != ob2->slaying
238 || ob1->skill != ob2->skill 216 || ob1->skill != ob2->skill
239 || ob1->value != ob2->value 217 || ob1->value != ob2->value
240 || ob1->animation_id != ob2->animation_id 218 || ob1->animation_id != ob2->animation_id
219 || (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependent on each other
241 || ob1->client_type != ob2->client_type 220 || ob1->client_type != ob2->client_type
242 || ob1->materialname != ob2->materialname 221 || ob1->materialname != ob2->materialname
243 || ob1->lore != ob2->lore 222 || ob1->lore != ob2->lore
244 || ob1->subtype != ob2->subtype 223 || ob1->subtype != ob2->subtype
245 || ob1->move_type != ob2->move_type 224 || ob1->move_type != ob2->move_type
246 || ob1->move_block != ob2->move_block 225 || ob1->move_block != ob2->move_block
247 || ob1->move_allow != ob2->move_allow 226 || ob1->move_allow != ob2->move_allow
248 || ob1->move_on != ob2->move_on 227 || ob1->move_on != ob2->move_on
249 || ob1->move_off != ob2->move_off 228 || ob1->move_off != ob2->move_off
250 || ob1->move_slow != ob2->move_slow 229 || ob1->move_slow != ob2->move_slow
251 || ob1->move_slow_penalty != ob2->move_slow_penalty) 230 || ob1->move_slow_penalty != ob2->move_slow_penalty
231 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
232 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
252 return 0; 233 return 0;
253 234
235 if ((ob1->flag ^ ob2->flag)
236 .reset (FLAG_INV_LOCKED)
237 .reset (FLAG_REMOVED)
238 .any ())
239 return 0;
240
254 /* This is really a spellbook check - really, we should 241 /* This is really a spellbook check - we should in general
255 * check all objects in the inventory. 242 * not merge objects with real inventories, as splitting them
243 * is hard.
256 */ 244 */
257 if (ob1->inv || ob2->inv) 245 if (ob1->inv || ob2->inv)
258 { 246 {
259 if (!(ob1->inv && ob2->inv)) 247 if (!(ob1->inv && ob2->inv))
260 return 0; /* inventories differ in length */ 248 return 0; /* inventories differ in length */
261 249
262 if (ob1->inv->below || ob2->inv->below) 250 if (ob1->inv->below || ob2->inv->below)
263 return 0; /* more than one object in inv */ 251 return 0; /* more than one object in inv */
264 252
265 if (!object::can_merge (ob1->inv, ob2->inv)) 253 if (!object::can_merge (ob1->inv, ob2->inv))
266 return 0; /* inventory objexts differ */ 254 return 0; /* inventory objects differ */
267 255
268 /* inventory ok - still need to check rest of this object to see 256 /* inventory ok - still need to check rest of this object to see
269 * if it is valid. 257 * if it is valid.
270 */ 258 */
271 } 259 }
290 if (ob1->level != ob2->level) 278 if (ob1->level != ob2->level)
291 return 0; 279 return 0;
292 break; 280 break;
293 } 281 }
294 282
295 if (ob1->key_values != NULL || ob2->key_values != NULL) 283 if (ob1->key_values || ob2->key_values)
296 { 284 {
297 /* At least one of these has key_values. */ 285 /* At least one of these has key_values. */
298 if ((ob1->key_values == NULL) != (ob2->key_values == NULL)) 286 if ((!ob1->key_values) != (!ob2->key_values))
299 /* One has fields, but the other one doesn't. */ 287 return 0; /* One has fields, but the other one doesn't. */
300 return 0; 288
301 else if (!compare_ob_value_lists (ob1, ob2)) 289 if (!compare_ob_value_lists (ob1, ob2))
302 return 0; 290 return 0;
303 } 291 }
304 292
305 if (ob1->self || ob2->self) 293 if (ob1->self || ob2->self)
306 { 294 {
312 int k1 = ob1->self ? HvTOTALKEYS (ob1->self) : 0; 300 int k1 = ob1->self ? HvTOTALKEYS (ob1->self) : 0;
313 int k2 = ob2->self ? HvTOTALKEYS (ob2->self) : 0; 301 int k2 = ob2->self ? HvTOTALKEYS (ob2->self) : 0;
314 302
315 if (k1 != k2) 303 if (k1 != k2)
316 return 0; 304 return 0;
305
317 else if (k1 == 0) 306 if (k1 == 0)
318 return 1; 307 return 1;
308
319 else if (!cfperl_can_merge (ob1, ob2)) 309 if (!cfperl_can_merge (ob1, ob2))
320 return 0; 310 return 0;
321 } 311 }
322 } 312 }
323 313
324 /* Everything passes, must be OK. */ 314 /* Everything passes, must be OK. */
325 return 1; 315 return 1;
326} 316}
327 317
318// find player who can see this object
319object *
320object::visible_to () const
321{
322 if (client_visible () && !flag [FLAG_REMOVED])
323 {
324 // see if we are in a container of sorts
325 if (env)
326 {
327 // the player inventory itself is always visible
328 if (env->type == PLAYER)
329 return env;
330
331 // else a player could have our env open
332 object *envest = env->outer_env ();
333
334 // the player itself is always on a map, so we will find him here
335 // even if our inv is in a player.
336 if (envest->is_on_map ())
337 if (object *pl = envest->ms ().player ())
338 if (pl->container == env)
339 return pl;
340 }
341 else
342 {
343 // maybe there is a player standing on the same mapspace
344 // this will catch the case where "this" is a player
345 if (object *pl = ms ().player ())
346 if ((!pl->container && pl->contr->ns && !pl->contr->ns->update_look)
347 || this == pl->container)
348 return pl;
349 }
350 }
351
352 return 0;
353}
354
355// adjust weight per container type ("of holding")
356static sint32
357weight_adjust_for (object *op, sint32 weight)
358{
359 return op->type == CONTAINER
360 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str)
361 : weight;
362}
363
328/* 364/*
365 * adjust_weight(object, weight) adds the specified weight to an object,
366 * and also updates how much the environment(s) is/are carrying.
367 */
368static void
369adjust_weight (object *op, sint32 weight)
370{
371 while (op)
372 {
373 // adjust by actual difference to account for rounding errors
374 // i.e. (w2 - w1) / f != w2 / f - w1 / f and the latter is correct
375 weight = weight_adjust_for (op, op->carrying)
376 - weight_adjust_for (op, op->carrying - weight);
377
378 if (!weight)
379 return;
380
381 op->carrying += weight;
382
383 if (object *pl = op->visible_to ())
384 if (pl != op) // player is handled lazily
385 esrv_update_item (UPD_WEIGHT, pl, op);
386
387 op = op->env;
388 }
389}
390
391/*
329 * sum_weight() is a recursive function which calculates the weight 392 * this is a recursive function which calculates the weight
330 * an object is carrying. It goes through in figures out how much 393 * an object is carrying. It goes through op and figures out how much
331 * containers are carrying, and sums it up. 394 * containers are carrying, and sums it up.
332 */ 395 */
333long 396void
334sum_weight (object *op) 397object::update_weight ()
335{ 398{
336 long sum; 399 sint32 sum = 0;
337 object *inv;
338 400
339 for (sum = 0, inv = op->inv; inv; inv = inv->below) 401 for (object *op = inv; op; op = op->below)
340 { 402 {
341 if (inv->inv) 403 if (op->inv)
342 sum_weight (inv); 404 op->update_weight ();
343 405
344 sum += inv->carrying + inv->weight * (inv->nrof ? inv->nrof : 1); 406 sum += op->total_weight ();
407 }
408
409 sum = weight_adjust_for (this, sum);
410
411 if (sum != carrying)
345 } 412 {
346
347 if (op->type == CONTAINER && op->stats.Str)
348 sum = (sum * (100 - op->stats.Str)) / 100;
349
350 if (op->carrying != sum)
351 op->carrying = sum; 413 carrying = sum;
352 414
353 return sum; 415 if (object *pl = visible_to ())
416 if (pl != this) // player is handled lazily
417 esrv_update_item (UPD_WEIGHT, pl, this);
418 }
354} 419}
355 420
356/** 421/*
357 * Return the outermost environment object for a given object. 422 * Used by: Server DM commands: dumpbelow, dump. Some error messages.
358 */
359
360object *
361object_get_env_recursive (object *op)
362{
363 while (op->env != NULL)
364 op = op->env;
365 return op;
366}
367
368/*
369 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
370 * Some error messages.
371 * The result of the dump is stored in the static global errmsg array.
372 */ 423 */
373char * 424char *
374dump_object (object *op) 425dump_object (object *op)
375{ 426{
376 if (!op) 427 if (!op)
390get_nearest_part (object *op, const object *pl) 441get_nearest_part (object *op, const object *pl)
391{ 442{
392 object *tmp, *closest; 443 object *tmp, *closest;
393 int last_dist, i; 444 int last_dist, i;
394 445
395 if (op->more == NULL) 446 if (!op->more)
396 return op; 447 return op;
448
397 for (last_dist = distance (op, pl), closest = op, tmp = op->more; tmp != NULL; tmp = tmp->more) 449 for (last_dist = distance (op, pl), closest = op, tmp = op->more;
450 tmp;
451 tmp = tmp->more)
398 if ((i = distance (tmp, pl)) < last_dist) 452 if ((i = distance (tmp, pl)) < last_dist)
399 closest = tmp, last_dist = i; 453 closest = tmp, last_dist = i;
454
400 return closest; 455 return closest;
401} 456}
402 457
403/* 458/*
404 * Returns the object which has the count-variable equal to the argument. 459 * Returns the object which has the count-variable equal to the argument.
460 * VERRRY slow.
405 */ 461 */
406object * 462object *
407find_object (tag_t i) 463find_object (tag_t i)
408{ 464{
409 for_all_objects (op) 465 for_all_objects (op)
420 */ 476 */
421object * 477object *
422find_object_name (const char *str) 478find_object_name (const char *str)
423{ 479{
424 shstr_cmp str_ (str); 480 shstr_cmp str_ (str);
425 object *op;
426 481
482 if (str_)
427 for_all_objects (op) 483 for_all_objects (op)
428 if (op->name == str_) 484 if (op->name == str_)
429 break; 485 return op;
430 486
431 return op; 487 return 0;
432}
433
434void
435free_all_object_data ()
436{
437 LOG (llevDebug, "%d allocated objects\n", nrofallocobjects);
438} 488}
439 489
440/* 490/*
441 * Sets the owner and sets the skill and exp pointers to owner's current 491 * Sets the owner and sets the skill and exp pointers to owner's current
442 * skill and experience objects. 492 * skill and experience objects.
540 } 590 }
541 591
542 op->key_values = 0; 592 op->key_values = 0;
543} 593}
544 594
545object & 595/*
546object::operator =(const object &src) 596 * copy_to first frees everything allocated by the dst object,
597 * and then copies the contents of itself into the second
598 * object, allocating what needs to be allocated. Basically, any
599 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
600 * if the first object is freed, the pointers in the new object
601 * will point at garbage.
602 */
603void
604object::copy_to (object *dst)
547{ 605{
548 bool is_freed = flag [FLAG_FREED]; 606 dst->remove ();
549 bool is_removed = flag [FLAG_REMOVED];
550
551 *(object_copy *)this = src; 607 *(object_copy *)dst = *this;
552
553 flag [FLAG_FREED] = is_freed;
554 flag [FLAG_REMOVED] = is_removed; 608 dst->flag [FLAG_REMOVED] = true;
555 609
556 /* Copy over key_values, if any. */ 610 /* Copy over key_values, if any. */
557 if (src.key_values) 611 if (key_values)
558 { 612 {
559 key_value *tail = 0; 613 key_value *tail = 0;
560 key_values = 0; 614 dst->key_values = 0;
561 615
562 for (key_value *i = src.key_values; i; i = i->next) 616 for (key_value *i = key_values; i; i = i->next)
563 { 617 {
564 key_value *new_link = new key_value; 618 key_value *new_link = new key_value;
565 619
566 new_link->next = 0; 620 new_link->next = 0;
567 new_link->key = i->key; 621 new_link->key = i->key;
568 new_link->value = i->value; 622 new_link->value = i->value;
569 623
570 /* Try and be clever here, too. */ 624 /* Try and be clever here, too. */
571 if (!key_values) 625 if (!dst->key_values)
572 { 626 {
573 key_values = new_link; 627 dst->key_values = new_link;
574 tail = new_link; 628 tail = new_link;
575 } 629 }
576 else 630 else
577 { 631 {
578 tail->next = new_link; 632 tail->next = new_link;
579 tail = new_link; 633 tail = new_link;
580 } 634 }
581 } 635 }
582 } 636 }
583}
584
585/*
586 * copy_to first frees everything allocated by the dst object,
587 * and then copies the contents of itself into the second
588 * object, allocating what needs to be allocated. Basically, any
589 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
590 * if the first object is freed, the pointers in the new object
591 * will point at garbage.
592 */
593void
594object::copy_to (object *dst)
595{
596 *dst = *this;
597 637
598 if (speed < 0) 638 if (speed < 0)
599 dst->speed_left -= rndm (); 639 dst->speed_left -= rndm ();
600 640
601 dst->set_speed (dst->speed); 641 dst->activate ();
602} 642}
603 643
604void 644void
605object::instantiate () 645object::instantiate ()
606{ 646{
607 if (!uuid.seq) // HACK 647 if (!uuid.seq) // HACK
608 uuid = gen_uuid (); 648 uuid = UUID::gen ();
609 649
610 speed_left = -0.1f; 650 speed_left = -0.1f;
611 /* copy the body_info to the body_used - this is only really 651 /* copy the body_info to the body_used - this is only really
612 * need for monsters, but doesn't hurt to do it for everything. 652 * need for monsters, but doesn't hurt to do it for everything.
613 * by doing so, when a monster is created, it has good starting 653 * by doing so, when a monster is created, it has good starting
623object * 663object *
624object::clone () 664object::clone ()
625{ 665{
626 object *neu = create (); 666 object *neu = create ();
627 copy_to (neu); 667 copy_to (neu);
668 neu->map = map; // not copied by copy_to
628 return neu; 669 return neu;
629} 670}
630 671
631/* 672/*
632 * If an object with the IS_TURNABLE() flag needs to be turned due 673 * If an object with the IS_TURNABLE() flag needs to be turned due
683 * UP_OBJ_FACE: only the objects face has changed. 724 * UP_OBJ_FACE: only the objects face has changed.
684 */ 725 */
685void 726void
686update_object (object *op, int action) 727update_object (object *op, int action)
687{ 728{
688 if (op == NULL) 729 if (!op)
689 { 730 {
690 /* this should never happen */ 731 /* this should never happen */
691 LOG (llevDebug, "update_object() called for NULL object.\n"); 732 LOG (llevError | logBacktrace, "update_object() called for NULL object.\n");
692 return; 733 return;
693 } 734 }
694 735
695 if (op->env) 736 if (!op->is_on_map ())
696 { 737 {
697 /* Animation is currently handled by client, so nothing 738 /* Animation is currently handled by client, so nothing
698 * to do in this case. 739 * to do in this case.
699 */ 740 */
700 return; 741 return;
701 } 742 }
702
703 /* If the map is saving, don't do anything as everything is
704 * going to get freed anyways.
705 */
706 if (!op->map || op->map->in_memory == MAP_SAVING)
707 return;
708 743
709 /* make sure the object is within map boundaries */ 744 /* make sure the object is within map boundaries */
710 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height) 745 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
711 { 746 {
712 LOG (llevError, "update_object() called for object out of map!\n"); 747 LOG (llevError, "update_object() called for object out of map!\n");
731 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC)) 766 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
732 || (m.move_on | op->move_on ) != m.move_on 767 || (m.move_on | op->move_on ) != m.move_on
733 || (m.move_off | op->move_off ) != m.move_off 768 || (m.move_off | op->move_off ) != m.move_off
734 || (m.move_slow | op->move_slow) != m.move_slow 769 || (m.move_slow | op->move_slow) != m.move_slow
735 /* This isn't perfect, but I don't expect a lot of objects to 770 /* This isn't perfect, but I don't expect a lot of objects to
736 * to have move_allow right now. 771 * have move_allow right now.
737 */ 772 */
738 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block 773 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
739 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp) 774 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
740 m.flags_ = 0; 775 m.flags_ = 0;
741 } 776 }
772static int object_count; 807static int object_count;
773 808
774void object::link () 809void object::link ()
775{ 810{
776 assert (!index);//D 811 assert (!index);//D
777 uuid = gen_uuid (); 812 uuid = UUID::gen ();
778 count = ++object_count; 813 count = ++object_count;
779 814
780 refcnt_inc (); 815 refcnt_inc ();
781 objects.insert (this); 816 objects.insert (this);
782} 817}
794object::activate () 829object::activate ()
795{ 830{
796 /* If already on active list, don't do anything */ 831 /* If already on active list, don't do anything */
797 if (active) 832 if (active)
798 return; 833 return;
834
835 if (has_active_speed () && flag [FLAG_FREED]) LOG (llevError | logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
836 if (has_active_speed () && flag [FLAG_DEBUG]) LOG (llevError | logBacktrace, "BUG: tried to activate DEBUG object %s\n", debug_desc ());//D temp
799 837
800 if (has_active_speed ()) 838 if (has_active_speed ())
801 actives.insert (this); 839 actives.insert (this);
802} 840}
803 841
855object::destroy_inv (bool drop_to_ground) 893object::destroy_inv (bool drop_to_ground)
856{ 894{
857 // need to check first, because the checks below might segfault 895 // need to check first, because the checks below might segfault
858 // as we might be on an invalid mapspace and crossfire code 896 // as we might be on an invalid mapspace and crossfire code
859 // is too buggy to ensure that the inventory is empty. 897 // is too buggy to ensure that the inventory is empty.
860 // corollary: if you create arrows etc. with stuff in tis inventory, 898 // corollary: if you create arrows etc. with stuff in its inventory,
861 // cf will crash below with off-map x and y 899 // cf will crash below with off-map x and y
862 if (!inv) 900 if (!inv)
863 return; 901 return;
864 902
865 /* Only if the space blocks everything do we not process - 903 /* Only if the space blocks everything do we not process -
866 * if some form of movement is allowed, let objects 904 * if some form of movement is allowed, let objects
867 * drop on that space. 905 * drop on that space.
868 */ 906 */
869 if (!drop_to_ground 907 if (!drop_to_ground
870 || !map 908 || !map
871 || map->in_memory != MAP_IN_MEMORY 909 || map->in_memory != MAP_ACTIVE
872 || map->nodrop 910 || map->no_drop
873 || ms ().move_block == MOVE_ALL) 911 || ms ().move_block == MOVE_ALL)
874 { 912 {
875 while (inv) 913 while (inv)
876 {
877 inv->destroy_inv (drop_to_ground);
878 inv->destroy (); 914 inv->destroy ();
879 }
880 } 915 }
881 else 916 else
882 { /* Put objects in inventory onto this space */ 917 { /* Put objects in inventory onto this space */
883 while (inv) 918 while (inv)
884 { 919 {
902 object *op = new object; 937 object *op = new object;
903 op->link (); 938 op->link ();
904 return op; 939 return op;
905} 940}
906 941
942static struct freed_map : maptile
943{
944 freed_map ()
945 {
946 path = "<freed objects map>";
947 name = "/internal/freed_objects_map";
948 width = 3;
949 height = 3;
950 no_drop = 1;
951 no_reset = 1;
952
953 alloc ();
954 in_memory = MAP_ACTIVE;
955 }
956
957 ~freed_map ()
958 {
959 destroy ();
960 }
961} freed_map; // freed objects are moved here to avoid crashes
962
907void 963void
908object::do_destroy () 964object::do_destroy ()
909{ 965{
910 attachable::do_destroy ();
911
912 if (flag [FLAG_IS_LINKED]) 966 if (flag [FLAG_IS_LINKED])
913 remove_button_link (this); 967 remove_button_link (this);
914 968
915 if (flag [FLAG_FRIENDLY]) 969 if (flag [FLAG_FRIENDLY])
916 remove_friendly_object (this); 970 remove_friendly_object (this);
917 971
918 if (!flag [FLAG_REMOVED])
919 remove (); 972 remove ();
920 973
921 destroy_inv (true); 974 attachable::do_destroy ();
922 975
923 deactivate (); 976 deactivate ();
924 unlink (); 977 unlink ();
925 978
926 flag [FLAG_FREED] = 1; 979 flag [FLAG_FREED] = 1;
927 980
928 // hack to ensure that freed objects still have a valid map 981 // hack to ensure that freed objects still have a valid map
929 {
930 static maptile *freed_map; // freed objects are moved here to avoid crashes
931
932 if (!freed_map)
933 {
934 freed_map = new maptile;
935
936 freed_map->path = "<freed objects map>";
937 freed_map->name = "/internal/freed_objects_map";
938 freed_map->width = 3;
939 freed_map->height = 3;
940 freed_map->nodrop = 1;
941
942 freed_map->alloc ();
943 freed_map->in_memory = MAP_IN_MEMORY;
944 }
945
946 map = freed_map; 982 map = &freed_map;
947 x = 1; 983 x = 1;
948 y = 1; 984 y = 1;
949 }
950 985
951 if (more) 986 if (more)
952 { 987 {
953 more->destroy (); 988 more->destroy ();
954 more = 0; 989 more = 0;
962 attacked_by = 0; 997 attacked_by = 0;
963 current_weapon = 0; 998 current_weapon = 0;
964} 999}
965 1000
966void 1001void
967object::destroy (bool destroy_inventory) 1002object::destroy ()
968{ 1003{
969 if (destroyed ()) 1004 if (destroyed ())
970 return; 1005 return;
971 1006
972 if (destroy_inventory) 1007 if (!is_head () && !head->destroyed ())
1008 {
1009 LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
1010 head->destroy ();
1011 return;
1012 }
1013
973 destroy_inv (false); 1014 destroy_inv (false);
974 1015
975 if (is_head ()) 1016 if (is_head ())
976 if (sound_destroy) 1017 if (sound_destroy)
977 play_sound (sound_destroy); 1018 play_sound (sound_destroy);
978 else if (flag [FLAG_MONSTER]) 1019 else if (flag [FLAG_MONSTER])
979 play_sound (sound_find ("monster_destroy")); // quick hack, too lazy to create a generic mechanism 1020 play_sound (sound_find ("monster_destroy")); // quick hack, too lazy to create a generic mechanism
980 1021
981 attachable::destroy (); 1022 attachable::destroy ();
982}
983
984/*
985 * sub_weight() recursively (outwards) subtracts a number from the
986 * weight of an object (and what is carried by it's environment(s)).
987 */
988void
989sub_weight (object *op, signed long weight)
990{
991 while (op != NULL)
992 {
993 if (op->type == CONTAINER)
994 weight = (signed long) (weight * (100 - op->stats.Str) / 100);
995
996 op->carrying -= weight;
997 op = op->env;
998 }
999} 1023}
1000 1024
1001/* op->remove (): 1025/* op->remove ():
1002 * This function removes the object op from the linked list of objects 1026 * This function removes the object op from the linked list of objects
1003 * which it is currently tied to. When this function is done, the 1027 * which it is currently tied to. When this function is done, the
1009object::do_remove () 1033object::do_remove ()
1010{ 1034{
1011 object *tmp, *last = 0; 1035 object *tmp, *last = 0;
1012 object *otmp; 1036 object *otmp;
1013 1037
1014 if (QUERY_FLAG (this, FLAG_REMOVED)) 1038 if (flag [FLAG_REMOVED])
1015 return; 1039 return;
1016 1040
1017 SET_FLAG (this, FLAG_REMOVED);
1018 INVOKE_OBJECT (REMOVE, this); 1041 INVOKE_OBJECT (REMOVE, this);
1042
1043 flag [FLAG_REMOVED] = true;
1019 1044
1020 if (more) 1045 if (more)
1021 more->remove (); 1046 more->remove ();
1022 1047
1023 /* 1048 /*
1024 * In this case, the object to be removed is in someones 1049 * In this case, the object to be removed is in someones
1025 * inventory. 1050 * inventory.
1026 */ 1051 */
1027 if (env) 1052 if (env)
1028 { 1053 {
1029 if (nrof) 1054 flag [FLAG_REMOVED] = false; // hack around the issue of visible_to checking flag_removed
1030 sub_weight (env, weight * nrof); 1055 if (object *pl = visible_to ())
1031 else 1056 esrv_del_item (pl->contr, count);
1032 sub_weight (env, weight + carrying); 1057 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
1058
1059 adjust_weight (env, -total_weight ());
1060
1061 /* we set up values so that it could be inserted into
1062 * the map, but we don't actually do that - it is up
1063 * to the caller to decide what we want to do.
1064 */
1065 map = env->map;
1066 x = env->x;
1067 y = env->y;
1068
1069 // make sure cmov optimisation is applicable
1070 *(above ? &above->below : &env->inv) = below;
1071 *(below ? &below->above : &above ) = above; // &above is just a dummy
1072
1073 above = 0;
1074 below = 0;
1075 env = 0;
1033 1076
1034 /* NO_FIX_PLAYER is set when a great many changes are being 1077 /* NO_FIX_PLAYER is set when a great many changes are being
1035 * made to players inventory. If set, avoiding the call 1078 * made to players inventory. If set, avoiding the call
1036 * to save cpu time. 1079 * to save cpu time.
1037 */ 1080 */
1038 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1081 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1039 otmp->update_stats (); 1082 otmp->update_stats ();
1040
1041 if (above)
1042 above->below = below;
1043 else
1044 env->inv = below;
1045
1046 if (below)
1047 below->above = above;
1048
1049 /* we set up values so that it could be inserted into
1050 * the map, but we don't actually do that - it is up
1051 * to the caller to decide what we want to do.
1052 */
1053 x = env->x, y = env->y;
1054 map = env->map;
1055 above = 0, below = 0;
1056 env = 0;
1057 } 1083 }
1058 else if (map) 1084 else if (map)
1059 { 1085 {
1060 if (type == PLAYER)
1061 {
1062 // leaving a spot always closes any open container on the ground
1063 if (container && !container->env)
1064 // this causes spurious floorbox updates, but it ensures
1065 // that the CLOSE event is being sent.
1066 close_container ();
1067
1068 --map->players;
1069 map->touch ();
1070 }
1071
1072 map->dirty = true; 1086 map->dirty = true;
1073 mapspace &ms = this->ms (); 1087 mapspace &ms = this->ms ();
1074 1088
1089 if (object *pl = ms.player ())
1090 {
1091 if (type == PLAYER) // this == pl(!)
1092 {
1093 // leaving a spot always closes any open container on the ground
1094 if (container && !container->env)
1095 // this causes spurious floorbox updates, but it ensures
1096 // that the CLOSE event is being sent.
1097 close_container ();
1098
1099 --map->players;
1100 map->touch ();
1101 }
1102 else if (pl->container == this)
1103 {
1104 // removing a container should close it
1105 close_container ();
1106 }
1107
1108 esrv_del_item (pl->contr, count);
1109 }
1110
1075 /* link the object above us */ 1111 /* link the object above us */
1076 if (above) 1112 // re-link, make sure compiler can easily use cmove
1077 above->below = below; 1113 *(above ? &above->below : &ms.top) = below;
1078 else 1114 *(below ? &below->above : &ms.bot) = above;
1079 ms.top = below; /* we were top, set new top */
1080
1081 /* Relink the object below us, if there is one */
1082 if (below)
1083 below->above = above;
1084 else
1085 {
1086 /* Nothing below, which means we need to relink map object for this space
1087 * use translated coordinates in case some oddness with map tiling is
1088 * evident
1089 */
1090 if (GET_MAP_OB (map, x, y) != this)
1091 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1092
1093 ms.bot = above; /* goes on above it. */
1094 }
1095 1115
1096 above = 0; 1116 above = 0;
1097 below = 0; 1117 below = 0;
1118
1119 ms.flags_ = 0;
1098 1120
1099 if (map->in_memory == MAP_SAVING) 1121 if (map->in_memory == MAP_SAVING)
1100 return; 1122 return;
1101 1123
1102 int check_walk_off = !flag [FLAG_NO_APPLY]; 1124 int check_walk_off = !flag [FLAG_NO_APPLY];
1108 * removed (most likely destroyed), update the player view 1130 * removed (most likely destroyed), update the player view
1109 * appropriately. 1131 * appropriately.
1110 */ 1132 */
1111 pl->close_container (); 1133 pl->close_container ();
1112 1134
1135 //TODO: the floorbox prev/next might need updating
1136 //esrv_del_item (pl->contr, count);
1137 //TODO: update floorbox to preserve ordering
1138 if (pl->contr->ns)
1113 pl->contr->ns->floorbox_update (); 1139 pl->contr->ns->floorbox_update ();
1114 } 1140 }
1115 1141
1116 for (tmp = ms.bot; tmp; tmp = tmp->above) 1142 for (tmp = ms.bot; tmp; tmp = tmp->above)
1117 { 1143 {
1118 /* No point updating the players look faces if he is the object 1144 /* No point updating the players look faces if he is the object
1131 } 1157 }
1132 1158
1133 last = tmp; 1159 last = tmp;
1134 } 1160 }
1135 1161
1136 /* last == NULL if there are no objects on this space */
1137 //TODO: this makes little sense, why only update the topmost object?
1138 if (!last)
1139 map->at (x, y).flags_ = 0;
1140 else
1141 update_object (last, UP_OBJ_REMOVE);
1142
1143 if (flag [FLAG_BLOCKSVIEW] || glow_radius) 1162 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1144 update_all_los (map, x, y); 1163 update_all_los (map, x, y);
1145 } 1164 }
1146} 1165}
1147 1166
1162 if (!top) 1181 if (!top)
1163 for (top = op; top && top->above; top = top->above) 1182 for (top = op; top && top->above; top = top->above)
1164 ; 1183 ;
1165 1184
1166 for (; top; top = top->below) 1185 for (; top; top = top->below)
1167 {
1168 if (top == op)
1169 continue;
1170
1171 if (object::can_merge (op, top)) 1186 if (object::can_merge (op, top))
1172 { 1187 {
1173 top->nrof += op->nrof; 1188 top->nrof += op->nrof;
1174 1189
1175/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/ 1190 if (object *pl = top->visible_to ())
1176 op->weight = 0; /* Don't want any adjustements now */ 1191 esrv_update_item (UPD_NROF, pl, top);
1192
1193 op->weight = 0; // cancel the addition above
1194 op->carrying = 0; // must be 0 already
1195
1177 op->destroy (); 1196 op->destroy ();
1197
1178 return top; 1198 return top;
1179 } 1199 }
1180 }
1181 1200
1182 return 0; 1201 return 0;
1183} 1202}
1184 1203
1185void 1204void
1210 * job preparing multi-part monsters. 1229 * job preparing multi-part monsters.
1211 */ 1230 */
1212object * 1231object *
1213insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1232insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1214{ 1233{
1234 op->remove ();
1235
1215 for (object *tmp = op->head_ (); tmp; tmp = tmp->more) 1236 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1216 { 1237 {
1217 tmp->x = x + tmp->arch->x; 1238 tmp->x = x + tmp->arch->x;
1218 tmp->y = y + tmp->arch->y; 1239 tmp->y = y + tmp->arch->y;
1219 } 1240 }
1242 * just 'op' otherwise 1263 * just 'op' otherwise
1243 */ 1264 */
1244object * 1265object *
1245insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1266insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1246{ 1267{
1247 assert (!op->flag [FLAG_FREED]);
1248
1249 object *top, *floor = NULL;
1250
1251 op->remove (); 1268 op->remove ();
1269
1270 if (m == &freed_map)//D TODO: remove soon
1271 {//D
1272 LOG (llevError | logBacktrace, "tries to insret object on freed objects map: %s", op->debug_desc ());//D
1273 }//D
1252 1274
1253 /* Ideally, the caller figures this out. However, it complicates a lot 1275 /* Ideally, the caller figures this out. However, it complicates a lot
1254 * of areas of callers (eg, anything that uses find_free_spot would now 1276 * of areas of callers (eg, anything that uses find_free_spot would now
1255 * need extra work 1277 * need extra work
1256 */ 1278 */
1257 if (!xy_normalise (m, op->x, op->y)) 1279 if (!xy_normalise (m, op->x, op->y))
1258 { 1280 {
1259 op->destroy (); 1281 op->head_ ()->destroy ();// remove head_ once all tail object destroyers found
1260 return 0; 1282 return 0;
1261 } 1283 }
1262 1284
1263 if (object *more = op->more) 1285 if (object *more = op->more)
1264 if (!insert_ob_in_map (more, m, originator, flag)) 1286 if (!insert_ob_in_map (more, m, originator, flag))
1273 */ 1295 */
1274 if (op->nrof && !(flag & INS_NO_MERGE)) 1296 if (op->nrof && !(flag & INS_NO_MERGE))
1275 for (object *tmp = ms.bot; tmp; tmp = tmp->above) 1297 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1276 if (object::can_merge (op, tmp)) 1298 if (object::can_merge (op, tmp))
1277 { 1299 {
1300 // TODO: we actually want to update tmp, not op,
1301 // but some caller surely breaks when we return tmp
1302 // from here :/
1278 op->nrof += tmp->nrof; 1303 op->nrof += tmp->nrof;
1279 tmp->destroy (); 1304 tmp->destroy ();
1280 } 1305 }
1281 1306
1282 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1307 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1291 { 1316 {
1292 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n"); 1317 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1293 abort (); 1318 abort ();
1294 } 1319 }
1295 1320
1321 if (!originator->is_on_map ())
1322 LOG (llevDebug | logBacktrace, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
1323 op->debug_desc (), originator->debug_desc ());
1324
1296 op->above = originator; 1325 op->above = originator;
1297 op->below = originator->below; 1326 op->below = originator->below;
1298
1299 if (op->below)
1300 op->below->above = op;
1301 else
1302 ms.bot = op;
1303
1304 /* since *below* originator, no need to update top */
1305 originator->below = op; 1327 originator->below = op;
1328
1329 *(op->below ? &op->below->above : &ms.bot) = op;
1306 } 1330 }
1307 else 1331 else
1308 { 1332 {
1309 top = ms.bot; 1333 object *floor = 0;
1334 object *top = ms.top;
1310 1335
1311 /* If there are other objects, then */ 1336 /* If there are other objects, then */
1312 if (top) 1337 if (top)
1313 { 1338 {
1314 object *last = 0;
1315
1316 /* 1339 /*
1317 * If there are multiple objects on this space, we do some trickier handling. 1340 * If there are multiple objects on this space, we do some trickier handling.
1318 * We've already dealt with merging if appropriate. 1341 * We've already dealt with merging if appropriate.
1319 * Generally, we want to put the new object on top. But if 1342 * Generally, we want to put the new object on top. But if
1320 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last 1343 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
1323 * once we get to them. This reduces the need to traverse over all of 1346 * once we get to them. This reduces the need to traverse over all of
1324 * them when adding another one - this saves quite a bit of cpu time 1347 * them when adding another one - this saves quite a bit of cpu time
1325 * when lots of spells are cast in one area. Currently, it is presumed 1348 * when lots of spells are cast in one area. Currently, it is presumed
1326 * that flying non pickable objects are spell objects. 1349 * that flying non pickable objects are spell objects.
1327 */ 1350 */
1328 for (top = ms.bot; top; top = top->above) 1351 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1329 { 1352 {
1330 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1353 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) || QUERY_FLAG (tmp, FLAG_OVERLAY_FLOOR))
1331 floor = top; 1354 floor = tmp;
1332 1355
1333 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1356 if (QUERY_FLAG (tmp, FLAG_NO_PICK) && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (tmp, FLAG_IS_FLOOR))
1334 { 1357 {
1335 /* We insert above top, so we want this object below this */ 1358 /* We insert above top, so we want this object below this */
1336 top = top->below; 1359 top = tmp->below;
1337 break; 1360 break;
1338 } 1361 }
1339 1362
1340 last = top; 1363 top = tmp;
1341 } 1364 }
1342
1343 /* Don't want top to be NULL, so set it to the last valid object */
1344 top = last;
1345 1365
1346 /* We let update_position deal with figuring out what the space 1366 /* We let update_position deal with figuring out what the space
1347 * looks like instead of lots of conditions here. 1367 * looks like instead of lots of conditions here.
1348 * makes things faster, and effectively the same result. 1368 * makes things faster, and effectively the same result.
1349 */ 1369 */
1356 */ 1376 */
1357 if (!(flag & INS_ON_TOP) 1377 if (!(flag & INS_ON_TOP)
1358 && ms.flags () & P_BLOCKSVIEW 1378 && ms.flags () & P_BLOCKSVIEW
1359 && (op->face && !faces [op->face].visibility)) 1379 && (op->face && !faces [op->face].visibility))
1360 { 1380 {
1381 object *last;
1382
1361 for (last = top; last != floor; last = last->below) 1383 for (last = top; last != floor; last = last->below)
1362 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1384 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1363 break; 1385 break;
1364 1386
1365 /* Check to see if we found the object that blocks view, 1387 /* Check to see if we found the object that blocks view,
1373 } /* If objects on this space */ 1395 } /* If objects on this space */
1374 1396
1375 if (flag & INS_ABOVE_FLOOR_ONLY) 1397 if (flag & INS_ABOVE_FLOOR_ONLY)
1376 top = floor; 1398 top = floor;
1377 1399
1378 /* Top is the object that our object (op) is going to get inserted above. 1400 // insert object above top, or bottom-most if top = 0
1379 */
1380
1381 /* First object on this space */
1382 if (!top) 1401 if (!top)
1383 { 1402 {
1403 op->below = 0;
1384 op->above = ms.bot; 1404 op->above = ms.bot;
1385
1386 if (op->above)
1387 op->above->below = op;
1388
1389 op->below = 0;
1390 ms.bot = op; 1405 ms.bot = op;
1406
1407 *(op->above ? &op->above->below : &ms.top) = op;
1391 } 1408 }
1392 else 1409 else
1393 { /* get inserted into the stack above top */ 1410 {
1394 op->above = top->above; 1411 op->above = top->above;
1395
1396 if (op->above)
1397 op->above->below = op; 1412 top->above = op;
1398 1413
1399 op->below = top; 1414 op->below = top;
1400 top->above = op; 1415 *(op->above ? &op->above->below : &ms.top) = op;
1401 } 1416 }
1402 1417 }
1403 if (!op->above)
1404 ms.top = op;
1405 } /* else not INS_BELOW_ORIGINATOR */
1406 1418
1407 if (op->type == PLAYER) 1419 if (op->type == PLAYER)
1408 { 1420 {
1409 op->contr->do_los = 1; 1421 op->contr->do_los = 1;
1410 ++op->map->players; 1422 ++op->map->players;
1412 } 1424 }
1413 1425
1414 op->map->dirty = true; 1426 op->map->dirty = true;
1415 1427
1416 if (object *pl = ms.player ()) 1428 if (object *pl = ms.player ())
1429 //TODO: the floorbox prev/next might need updating
1430 //esrv_send_item (pl, op);
1431 //TODO: update floorbox to preserve ordering
1432 if (pl->contr->ns)
1417 pl->contr->ns->floorbox_update (); 1433 pl->contr->ns->floorbox_update ();
1418 1434
1419 /* If this object glows, it may affect lighting conditions that are 1435 /* If this object glows, it may affect lighting conditions that are
1420 * visible to others on this map. But update_all_los is really 1436 * visible to others on this map. But update_all_los is really
1421 * an inefficient way to do this, as it means los for all players 1437 * an inefficient way to do this, as it means los for all players
1422 * on the map will get recalculated. The players could very well 1438 * on the map will get recalculated. The players could very well
1464 * op is the object to insert it under: supplies x and the map. 1480 * op is the object to insert it under: supplies x and the map.
1465 */ 1481 */
1466void 1482void
1467replace_insert_ob_in_map (const char *arch_string, object *op) 1483replace_insert_ob_in_map (const char *arch_string, object *op)
1468{ 1484{
1469 object *tmp, *tmp1;
1470
1471 /* first search for itself and remove any old instances */ 1485 /* first search for itself and remove any old instances */
1472 1486
1473 for (tmp = op->ms ().bot; tmp; tmp = tmp->above) 1487 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1474 if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */ 1488 if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */
1475 tmp->destroy (); 1489 tmp->destroy ();
1476 1490
1477 tmp1 = arch_to_object (archetype::find (arch_string)); 1491 object *tmp = arch_to_object (archetype::find (arch_string));
1478 1492
1479 tmp1->x = op->x; 1493 tmp->x = op->x;
1480 tmp1->y = op->y; 1494 tmp->y = op->y;
1495
1481 insert_ob_in_map (tmp1, op->map, op, 0); 1496 insert_ob_in_map (tmp, op->map, op, 0);
1482} 1497}
1483 1498
1484object * 1499object *
1485object::insert_at (object *where, object *originator, int flags) 1500object::insert_at (object *where, object *originator, int flags)
1486{ 1501{
1502 if (where->env)
1503 return where->env->insert (this);
1504 else
1487 return where->map->insert (this, where->x, where->y, originator, flags); 1505 return where->map->insert (this, where->x, where->y, originator, flags);
1488} 1506}
1489 1507
1490/* 1508/*
1491 * get_split_ob(ob,nr) splits up ob into two parts. The part which
1492 * is returned contains nr objects, and the remaining parts contains
1493 * the rest (or is removed and freed if that number is 0).
1494 * On failure, NULL is returned, and the reason put into the
1495 * global static errmsg array.
1496 */
1497object *
1498get_split_ob (object *orig_ob, uint32 nr)
1499{
1500 object *newob;
1501 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1502
1503 if (orig_ob->nrof < nr)
1504 {
1505 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1506 return NULL;
1507 }
1508
1509 newob = object_create_clone (orig_ob);
1510
1511 if ((orig_ob->nrof -= nr) < 1)
1512 orig_ob->destroy (1);
1513 else if (!is_removed)
1514 {
1515 if (orig_ob->env != NULL)
1516 sub_weight (orig_ob->env, orig_ob->weight * nr);
1517 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY)
1518 {
1519 strcpy (errmsg, "Tried to split object whose map is not in memory.");
1520 LOG (llevDebug, "Error, Tried to split object whose map is not in memory.\n");
1521 return NULL;
1522 }
1523 }
1524
1525 newob->nrof = nr;
1526
1527 return newob;
1528}
1529
1530/*
1531 * decrease_ob_nr(object, number) decreases a specified number from 1509 * decrease(object, number) decreases a specified number from
1532 * the amount of an object. If the amount reaches 0, the object 1510 * the amount of an object. If the amount reaches 0, the object
1533 * is subsequently removed and freed. 1511 * is subsequently removed and freed.
1534 * 1512 *
1535 * Return value: 'op' if something is left, NULL if the amount reached 0 1513 * Return value: 'op' if something is left, NULL if the amount reached 0
1536 */ 1514 */
1515bool
1516object::decrease (sint32 nr)
1517{
1518 if (!nr)
1519 return true;
1520
1521 nr = min (nr, nrof);
1522
1523 if (nrof > nr)
1524 {
1525 nrof -= nr;
1526 adjust_weight (env, -weight * max (1, nr)); // carrying == 0
1527
1528 if (object *pl = visible_to ())
1529 esrv_update_item (UPD_NROF, pl, this);
1530
1531 return true;
1532 }
1533 else
1534 {
1535 destroy ();
1536 return false;
1537 }
1538}
1539
1540/*
1541 * split(ob,nr) splits up ob into two parts. The part which
1542 * is returned contains nr objects, and the remaining parts contains
1543 * the rest (or is removed and returned if that number is 0).
1544 * On failure, NULL is returned.
1545 */
1537object * 1546object *
1538decrease_ob_nr (object *op, uint32 i) 1547object::split (sint32 nr)
1539{ 1548{
1540 object *tmp; 1549 int have = number_of ();
1541 1550
1542 if (i == 0) /* objects with op->nrof require this check */ 1551 if (have < nr)
1543 return op; 1552 return 0;
1544 1553 else if (have == nr)
1545 if (i > op->nrof)
1546 i = op->nrof;
1547
1548 if (QUERY_FLAG (op, FLAG_REMOVED))
1549 op->nrof -= i;
1550 else if (op->env)
1551 { 1554 {
1552 /* is this object in the players inventory, or sub container
1553 * therein?
1554 */
1555 tmp = op->in_player ();
1556 /* nope. Is this a container the player has opened?
1557 * If so, set tmp to that player.
1558 * IMO, searching through all the players will mostly
1559 * likely be quicker than following op->env to the map,
1560 * and then searching the map for a player.
1561 */
1562 if (!tmp)
1563 for_all_players (pl)
1564 if (pl->ob->container == op->env)
1565 {
1566 tmp = pl->ob;
1567 break;
1568 }
1569
1570 if (i < op->nrof)
1571 {
1572 sub_weight (op->env, op->weight * i);
1573 op->nrof -= i;
1574 if (tmp)
1575 esrv_send_item (tmp, op);
1576 }
1577 else
1578 {
1579 op->remove (); 1555 remove ();
1580 op->nrof = 0; 1556 return this;
1581 if (tmp)
1582 esrv_del_item (tmp->contr, op->count);
1583 }
1584 } 1557 }
1585 else 1558 else
1586 { 1559 {
1587 object *above = op->above; 1560 decrease (nr);
1588 1561
1589 if (i < op->nrof) 1562 object *op = deep_clone ();
1590 op->nrof -= i; 1563 op->nrof = nr;
1591 else
1592 {
1593 op->remove ();
1594 op->nrof = 0;
1595 }
1596
1597 /* Since we just removed op, op->above is null */
1598 for (tmp = above; tmp; tmp = tmp->above)
1599 if (tmp->type == PLAYER)
1600 {
1601 if (op->nrof)
1602 esrv_send_item (tmp, op);
1603 else
1604 esrv_del_item (tmp->contr, op->count);
1605 }
1606 }
1607
1608 if (op->nrof)
1609 return op; 1564 return op;
1610 else
1611 {
1612 op->destroy ();
1613 return 0;
1614 }
1615}
1616
1617/*
1618 * add_weight(object, weight) adds the specified weight to an object,
1619 * and also updates how much the environment(s) is/are carrying.
1620 */
1621void
1622add_weight (object *op, signed long weight)
1623{
1624 while (op != NULL)
1625 {
1626 if (op->type == CONTAINER)
1627 weight = (signed long) (weight * (100 - op->stats.Str) / 100);
1628
1629 op->carrying += weight;
1630 op = op->env;
1631 } 1565 }
1632} 1566}
1633 1567
1634object * 1568object *
1635insert_ob_in_ob (object *op, object *where) 1569insert_ob_in_ob (object *op, object *where)
1660 * be != op, if items are merged. -Tero 1594 * be != op, if items are merged. -Tero
1661 */ 1595 */
1662object * 1596object *
1663object::insert (object *op) 1597object::insert (object *op)
1664{ 1598{
1665 if (!QUERY_FLAG (op, FLAG_REMOVED))
1666 op->remove ();
1667
1668 if (op->more) 1599 if (op->more)
1669 { 1600 {
1670 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count); 1601 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);
1671 return op; 1602 return op;
1672 } 1603 }
1673 1604
1674 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL); 1605 op->remove ();
1675 CLEAR_FLAG (op, FLAG_REMOVED); 1606
1607 op->flag [FLAG_OBJ_ORIGINAL] = 0;
1676 1608
1677 if (op->nrof) 1609 if (op->nrof)
1678 {
1679 for (object *tmp = inv; tmp; tmp = tmp->below) 1610 for (object *tmp = inv; tmp; tmp = tmp->below)
1680 if (object::can_merge (tmp, op)) 1611 if (object::can_merge (tmp, op))
1681 { 1612 {
1682 /* return the original object and remove inserted object 1613 /* return the original object and remove inserted object
1683 (client needs the original object) */ 1614 (client needs the original object) */
1684 tmp->nrof += op->nrof; 1615 tmp->nrof += op->nrof;
1685 /* Weight handling gets pretty funky. Since we are adding to 1616
1686 * tmp->nrof, we need to increase the weight. 1617 if (object *pl = tmp->visible_to ())
1687 */ 1618 esrv_update_item (UPD_NROF, pl, tmp);
1619
1688 add_weight (this, op->weight * op->nrof); 1620 adjust_weight (this, op->total_weight ());
1689 SET_FLAG (op, FLAG_REMOVED); 1621
1690 op->destroy (); /* free the inserted object */ 1622 op->destroy ();
1691 op = tmp; 1623 op = tmp;
1692 op->remove (); /* and fix old object's links */ 1624 goto inserted;
1693 CLEAR_FLAG (op, FLAG_REMOVED);
1694 break;
1695 } 1625 }
1696 1626
1697 /* I assume combined objects have no inventory
1698 * We add the weight - this object could have just been removed
1699 * (if it was possible to merge). calling remove_ob will subtract
1700 * the weight, so we need to add it in again, since we actually do
1701 * the linking below
1702 */
1703 add_weight (this, op->weight * op->nrof);
1704 }
1705 else
1706 add_weight (this, (op->weight + op->carrying));
1707
1708 if (object *otmp = this->in_player ())
1709 if (otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1710 otmp->update_stats ();
1711
1712 op->owner = 0; // its his/hers now. period. 1627 op->owner = 0; // it's his/hers now. period.
1713 op->map = 0; 1628 op->map = 0;
1629 op->x = 0;
1630 op->y = 0;
1631
1632 op->above = 0;
1633 op->below = inv;
1714 op->env = this; 1634 op->env = this;
1715 op->above = 0;
1716 op->below = 0;
1717 op->x = op->y = 0;
1718 1635
1636 if (inv)
1637 inv->above = op;
1638
1639 inv = op;
1640
1641 op->flag [FLAG_REMOVED] = 0;
1642
1643 if (object *pl = op->visible_to ())
1644 esrv_send_item (pl, op);
1645
1646 adjust_weight (this, op->total_weight ());
1647
1648inserted:
1719 /* reset the light list and los of the players on the map */ 1649 /* reset the light list and los of the players on the map */
1720 if (op->glow_radius && map) 1650 if (op->glow_radius && map && map->darkness)
1721 {
1722#ifdef DEBUG_LIGHTS
1723 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1724#endif /* DEBUG_LIGHTS */
1725 if (map->darkness)
1726 update_all_los (map, x, y); 1651 update_all_los (map, x, y);
1727 }
1728 1652
1729 /* Client has no idea of ordering so lets not bother ordering it here. 1653 // if this is a player's inventory, update stats
1730 * It sure simplifies this function... 1654 if (type == PLAYER && !flag [FLAG_NO_FIX_PLAYER])
1731 */ 1655 update_stats ();
1732 if (!inv)
1733 inv = op;
1734 else
1735 {
1736 op->below = inv;
1737 op->below->above = op;
1738 inv = op;
1739 }
1740 1656
1741 INVOKE_OBJECT (INSERT, this); 1657 INVOKE_OBJECT (INSERT, this);
1742 1658
1743 return op; 1659 return op;
1744} 1660}
1872 LOG (llevError, "Present_arch called outside map.\n"); 1788 LOG (llevError, "Present_arch called outside map.\n");
1873 return NULL; 1789 return NULL;
1874 } 1790 }
1875 1791
1876 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above) 1792 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1877 if (tmp->arch == at) 1793 if (tmp->arch->archname == at->archname)
1878 return tmp; 1794 return tmp;
1879 1795
1880 return NULL; 1796 return NULL;
1881} 1797}
1882 1798
1946 * The first matching object is returned, or NULL if none. 1862 * The first matching object is returned, or NULL if none.
1947 */ 1863 */
1948object * 1864object *
1949present_arch_in_ob (const archetype *at, const object *op) 1865present_arch_in_ob (const archetype *at, const object *op)
1950{ 1866{
1951 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below) 1867 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1952 if (tmp->arch == at) 1868 if (tmp->arch->archname == at->archname)
1953 return tmp; 1869 return tmp;
1954 1870
1955 return NULL; 1871 return NULL;
1956} 1872}
1957 1873
2366 2282
2367/* 2283/*
2368 * create clone from object to another 2284 * create clone from object to another
2369 */ 2285 */
2370object * 2286object *
2371object_create_clone (object *asrc) 2287object::deep_clone ()
2372{ 2288{
2373 object *dst = 0, *tmp, *src, *prev, *item; 2289 assert (("deep_clone called on non-head object", is_head ()));
2374 2290
2375 if (!asrc) 2291 object *dst = clone ();
2376 return 0;
2377 2292
2378 src = asrc->head_ (); 2293 object *prev = dst;
2379
2380 prev = 0;
2381 for (object *part = src; part; part = part->more) 2294 for (object *part = this->more; part; part = part->more)
2382 { 2295 {
2383 tmp = part->clone (); 2296 object *tmp = part->clone ();
2384 tmp->x -= src->x;
2385 tmp->y -= src->y;
2386
2387 if (!part->head)
2388 {
2389 dst = tmp;
2390 tmp->head = 0;
2391 }
2392 else
2393 tmp->head = dst; 2297 tmp->head = dst;
2394
2395 tmp->more = 0;
2396
2397 if (prev)
2398 prev->more = tmp; 2298 prev->more = tmp;
2399
2400 prev = tmp; 2299 prev = tmp;
2401 } 2300 }
2402 2301
2403 for (item = src->inv; item; item = item->below) 2302 for (object *item = inv; item; item = item->below)
2404 insert_ob_in_ob (object_create_clone (item), dst); 2303 insert_ob_in_ob (item->deep_clone (), dst);
2405 2304
2406 return dst; 2305 return dst;
2407} 2306}
2408 2307
2409/* This returns the first object in who's inventory that 2308/* This returns the first object in who's inventory that
2418 return tmp; 2317 return tmp;
2419 2318
2420 return 0; 2319 return 0;
2421} 2320}
2422 2321
2423/* If ob has a field named key, return the link from the list, 2322const shstr &
2424 * otherwise return NULL. 2323object::kv_get (const shstr &key) const
2425 *
2426 * key must be a passed in shared string - otherwise, this won't
2427 * do the desired thing.
2428 */
2429key_value *
2430get_ob_key_link (const object *ob, const char *key)
2431{ 2324{
2432 for (key_value *link = ob->key_values; link; link = link->next) 2325 for (key_value *kv = key_values; kv; kv = kv->next)
2433 if (link->key == key) 2326 if (kv->key == key)
2434 return link;
2435
2436 return 0;
2437}
2438
2439/*
2440 * Returns the value of op has an extra_field for key, or NULL.
2441 *
2442 * The argument doesn't need to be a shared string.
2443 *
2444 * The returned string is shared.
2445 */
2446const char *
2447get_ob_key_value (const object *op, const char *const key)
2448{
2449 key_value *link;
2450 shstr_cmp canonical_key (key);
2451
2452 if (!canonical_key)
2453 {
2454 /* 1. There being a field named key on any object
2455 * implies there'd be a shared string to find.
2456 * 2. Since there isn't, no object has this field.
2457 * 3. Therefore, *this* object doesn't have this field.
2458 */
2459 return 0;
2460 }
2461
2462 /* This is copied from get_ob_key_link() above -
2463 * only 4 lines, and saves the function call overhead.
2464 */
2465 for (link = op->key_values; link; link = link->next)
2466 if (link->key == canonical_key)
2467 return link->value; 2327 return kv->value;
2468 2328
2469 return 0; 2329 return shstr_null;
2470} 2330}
2471 2331
2472/* 2332void
2473 * Updates the canonical_key in op to value. 2333object::kv_set (const shstr &key, const shstr &value)
2474 *
2475 * canonical_key is a shared string (value doesn't have to be).
2476 *
2477 * Unless add_key is TRUE, it won't add fields, only change the value of existing
2478 * keys.
2479 *
2480 * Returns TRUE on success.
2481 */
2482int
2483set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2484{ 2334{
2485 key_value *field = NULL, *last = NULL; 2335 for (key_value *kv = key_values; kv; kv = kv->next)
2486 2336 if (kv->key == key)
2487 for (field = op->key_values; field != NULL; field = field->next)
2488 {
2489 if (field->key != canonical_key)
2490 { 2337 {
2491 last = field; 2338 kv->value = value;
2492 continue; 2339 return;
2493 } 2340 }
2494 2341
2495 if (value) 2342 key_value *kv = new key_value;
2496 field->value = value; 2343
2497 else 2344 kv->next = key_values;
2345 kv->key = key;
2346 kv->value = value;
2347
2348 key_values = kv;
2349}
2350
2351void
2352object::kv_del (const shstr &key)
2353{
2354 for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
2355 if ((*kvp)->key == key)
2498 { 2356 {
2499 /* Basically, if the archetype has this key set, 2357 key_value *kv = *kvp;
2500 * we need to store the null value so when we save 2358 *kvp = (*kvp)->next;
2501 * it, we save the empty value so that when we load, 2359 delete kv;
2502 * we get this value back again. 2360 return;
2503 */
2504 if (get_ob_key_link (op->arch, canonical_key))
2505 field->value = 0;
2506 else
2507 {
2508 if (last)
2509 last->next = field->next;
2510 else
2511 op->key_values = field->next;
2512
2513 delete field;
2514 }
2515 } 2361 }
2516 return TRUE;
2517 }
2518 /* IF we get here, key doesn't exist */
2519
2520 /* No field, we'll have to add it. */
2521
2522 if (!add_key)
2523 return FALSE;
2524
2525 /* There isn't any good reason to store a null
2526 * value in the key/value list. If the archetype has
2527 * this key, then we should also have it, so shouldn't
2528 * be here. If user wants to store empty strings,
2529 * should pass in ""
2530 */
2531 if (value == NULL)
2532 return TRUE;
2533
2534 field = new key_value;
2535
2536 field->key = canonical_key;
2537 field->value = value;
2538 /* Usual prepend-addition. */
2539 field->next = op->key_values;
2540 op->key_values = field;
2541
2542 return TRUE;
2543}
2544
2545/*
2546 * Updates the key in op to value.
2547 *
2548 * If add_key is FALSE, this will only update existing keys,
2549 * and not add new ones.
2550 * In general, should be little reason FALSE is ever passed in for add_key
2551 *
2552 * Returns TRUE on success.
2553 */
2554int
2555set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2556{
2557 shstr key_ (key);
2558
2559 return set_ob_key_value_s (op, key_, value, add_key);
2560} 2362}
2561 2363
2562object::depth_iterator::depth_iterator (object *container) 2364object::depth_iterator::depth_iterator (object *container)
2563: iterator_base (container) 2365: iterator_base (container)
2564{ 2366{
2614{ 2416{
2615 char flagdesc[512]; 2417 char flagdesc[512];
2616 char info2[256 * 4]; 2418 char info2[256 * 4];
2617 char *p = info; 2419 char *p = info;
2618 2420
2619 p += snprintf (p, 512, "{cnt:%d,uuid:<1.%" PRIx64 ">,name:\"%s\"%s%s,flags:[%s],type:%d}", 2421 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2620 count, uuid.seq, 2422 count,
2423 uuid.c_str (),
2621 &name, 2424 &name,
2622 title ? "\",title:\"" : "", 2425 title ? ",title:\"" : "",
2623 title ? (const char *)title : "", 2426 title ? (const char *)title : "",
2427 title ? "\"" : "",
2624 flag_desc (flagdesc, 512), type); 2428 flag_desc (flagdesc, 512), type);
2625 2429
2626 if (!this->flag[FLAG_REMOVED] && env) 2430 if (!flag[FLAG_REMOVED] && env)
2627 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2431 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2628 2432
2629 if (map) 2433 if (map)
2630 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y); 2434 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2631 2435
2661object::open_container (object *new_container) 2465object::open_container (object *new_container)
2662{ 2466{
2663 if (container == new_container) 2467 if (container == new_container)
2664 return; 2468 return;
2665 2469
2666 if (object *old_container = container) 2470 object *old_container = container;
2471
2472 if (old_container)
2667 { 2473 {
2668 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this))) 2474 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))
2669 return; 2475 return;
2670 2476
2671#if 0 2477#if 0
2673 if (object *closer = old_container->inv) 2479 if (object *closer = old_container->inv)
2674 if (closer->type == CLOSE_CON) 2480 if (closer->type == CLOSE_CON)
2675 closer->destroy (); 2481 closer->destroy ();
2676#endif 2482#endif
2677 2483
2484 // make sure the container is available
2485 esrv_send_item (this, old_container);
2486
2678 old_container->flag [FLAG_APPLIED] = 0; 2487 old_container->flag [FLAG_APPLIED] = false;
2679 container = 0; 2488 container = 0;
2680 2489
2490 // client needs item update to make it work, client bug requires this to be separate
2681 esrv_update_item (UPD_FLAGS, this, old_container); 2491 esrv_update_item (UPD_FLAGS, this, old_container);
2492
2682 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container)); 2493 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container));
2683 play_sound (sound_find ("chest_close")); 2494 play_sound (sound_find ("chest_close"));
2684 } 2495 }
2685 2496
2686 if (new_container) 2497 if (new_container)
2699 } 2510 }
2700#endif 2511#endif
2701 2512
2702 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container)); 2513 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container));
2703 2514
2515 // make sure the container is available, client bug requires this to be separate
2516 esrv_send_item (this, new_container);
2517
2704 new_container->flag [FLAG_APPLIED] = 1; 2518 new_container->flag [FLAG_APPLIED] = true;
2705 container = new_container; 2519 container = new_container;
2706 2520
2521 // client needs flag change
2707 esrv_update_item (UPD_FLAGS, this, new_container); 2522 esrv_update_item (UPD_FLAGS, this, new_container);
2708 esrv_send_inventory (this, new_container); 2523 esrv_send_inventory (this, new_container);
2709 play_sound (sound_find ("chest_open")); 2524 play_sound (sound_find ("chest_open"));
2710 } 2525 }
2526// else if (!old_container->env && contr && contr->ns)
2527// contr->ns->floorbox_reset ();
2711} 2528}
2712 2529
2713object * 2530object *
2714object::force_find (const shstr name) 2531object::force_find (const shstr name)
2715{ 2532{
2741 2558
2742 insert (force); 2559 insert (force);
2743} 2560}
2744 2561
2745void 2562void
2746object::play_sound (faceidx sound) const 2563object::play_sound (faceidx sound)
2747{ 2564{
2748 if (!sound) 2565 if (!sound)
2749 return; 2566 return;
2750 2567
2751 if (flag [FLAG_REMOVED]) 2568 if (flag [FLAG_REMOVED])

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines