ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.220 by root, Thu Apr 24 00:30:52 2008 UTC vs.
Revision 1.286 by root, Wed Sep 2 16:54:20 2009 UTC

1/* 1/*
2 * This file is part of Deliantra, the Roguelike Realtime MMORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team 4 * Copyright (©) 2005,2006,2007,2008,2009 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 * 7 *
8 * Deliantra is free software: you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify
9 * it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
32#include <bitset> 32#include <bitset>
33 33
34UUID UUID::cur; 34UUID UUID::cur;
35static uint64_t seq_next_save; 35static uint64_t seq_next_save;
36static const uint64 UUID_GAP = 1<<19; 36static const uint64 UUID_GAP = 1<<19;
37uint32_t mapspace::smellcount = 10000;
37 38
38objectvec objects; 39objectvec objects;
39activevec actives; 40activevec actives;
40 41
41short freearr_x[SIZEOFFREE] = { 42short freearr_x[SIZEOFFREE] = {
139 140
140/* Returns TRUE if every key_values in wants has a partner with the same value in has. */ 141/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
141static bool 142static bool
142compare_ob_value_lists_one (const object *wants, const object *has) 143compare_ob_value_lists_one (const object *wants, const object *has)
143{ 144{
144 key_value *wants_field;
145
146 /* n-squared behaviour (see get_ob_key_link()), but I'm hoping both 145 /* n-squared behaviour (see kv_get), but I'm hoping both
147 * objects with lists are rare, and lists stay short. If not, use a 146 * objects with lists are rare, and lists stay short. If not, use a
148 * different structure or at least keep the lists sorted... 147 * different structure or at least keep the lists sorted...
149 */ 148 */
150 149
151 /* For each field in wants, */ 150 /* For each field in wants, */
152 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next) 151 for (key_value *kv = wants->key_values; kv; kv = kv->next)
153 { 152 if (has->kv_get (kv->key) != kv->value)
154 key_value *has_field; 153 return false;
155
156 /* Look for a field in has with the same key. */
157 has_field = get_ob_key_link (has, wants_field->key);
158
159 if (!has_field)
160 return 0; /* No field with that name. */
161
162 /* Found the matching field. */
163 if (has_field->value != wants_field->value)
164 return 0; /* Values don't match, so this half of the comparison is false. */
165
166 /* If we get here, we found a match. Now for the next field in wants. */
167 }
168 154
169 /* If we get here, every field in wants has a matching field in has. */ 155 /* If we get here, every field in wants has a matching field in has. */
170 return 1; 156 return true;
171} 157}
172 158
173/* Returns TRUE if ob1 has the same key_values as ob2. */ 159/* Returns TRUE if ob1 has the same key_values as ob2. */
174static bool 160static bool
175compare_ob_value_lists (const object *ob1, const object *ob2) 161compare_ob_value_lists (const object *ob1, const object *ob2)
176{ 162{
177 /* However, there may be fields in has which aren't partnered in wants, 163 /* However, there may be fields in has which aren't partnered in wants,
178 * so we need to run the comparison *twice*. :( 164 * so we need to run the comparison *twice*. :(
179 */ 165 */
180 return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1); 166 return compare_ob_value_lists_one (ob1, ob2)
167 && compare_ob_value_lists_one (ob2, ob1);
181} 168}
182 169
183/* Function examines the 2 objects given to it, and returns true if 170/* Function examines the 2 objects given to it, and returns true if
184 * they can be merged together. 171 * they can be merged together.
185 * 172 *
200 || ob1->speed != ob2->speed 187 || ob1->speed != ob2->speed
201 || ob1->value != ob2->value 188 || ob1->value != ob2->value
202 || ob1->name != ob2->name) 189 || ob1->name != ob2->name)
203 return 0; 190 return 0;
204 191
205 /* Do not merge objects if nrof would overflow. First part checks 192 /* Do not merge objects if nrof would overflow, assume nrof
206 * for unsigned overflow (2c), second part checks whether the result 193 * is always 0 .. 2**31-1 */
207 * would fit into a 32 bit signed int, which is often used to hold 194 if (ob1->nrof > 0x7fffffff - ob2->nrof)
208 * nrof values.
209 */
210 if (~ob1->nrof < ob2->nrof || ob1->nrof + ob2->nrof > (1UL << 31))
211 return 0; 195 return 0;
212 196
213 /* If the objects have been identified, set the BEEN_APPLIED flag. 197 /* If the objects have been identified, set the BEEN_APPLIED flag.
214 * This is to the comparison of the flags below will be OK. We 198 * This is to the comparison of the flags below will be OK. We
215 * just can't ignore the been applied or identified flags, as they 199 * just can't ignore the been applied or identified flags, as they
220 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 204 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
221 205
222 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 206 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
223 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 207 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
224 208
225 if (ob1->arch->name != ob2->arch->name 209 if (ob1->arch->archname != ob2->arch->archname
226 || ob1->name != ob2->name 210 || ob1->name != ob2->name
227 || ob1->title != ob2->title 211 || ob1->title != ob2->title
228 || ob1->msg != ob2->msg 212 || ob1->msg != ob2->msg
229 || ob1->weight != ob2->weight 213 || ob1->weight != ob2->weight
230 || ob1->attacktype != ob2->attacktype 214 || ob1->attacktype != ob2->attacktype
231 || ob1->magic != ob2->magic 215 || ob1->magic != ob2->magic
232 || ob1->slaying != ob2->slaying 216 || ob1->slaying != ob2->slaying
233 || ob1->skill != ob2->skill 217 || ob1->skill != ob2->skill
234 || ob1->value != ob2->value 218 || ob1->value != ob2->value
235 || ob1->animation_id != ob2->animation_id 219 || ob1->animation_id != ob2->animation_id
220 || (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependent on each other
236 || ob1->client_type != ob2->client_type 221 || ob1->client_type != ob2->client_type
237 || ob1->materialname != ob2->materialname 222 || ob1->materialname != ob2->materialname
238 || ob1->lore != ob2->lore 223 || ob1->lore != ob2->lore
239 || ob1->subtype != ob2->subtype 224 || ob1->subtype != ob2->subtype
240 || ob1->move_type != ob2->move_type 225 || ob1->move_type != ob2->move_type
248 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats))) 233 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
249 return 0; 234 return 0;
250 235
251 if ((ob1->flag ^ ob2->flag) 236 if ((ob1->flag ^ ob2->flag)
252 .reset (FLAG_INV_LOCKED) 237 .reset (FLAG_INV_LOCKED)
253 .reset (FLAG_CLIENT_SENT)
254 .reset (FLAG_REMOVED) 238 .reset (FLAG_REMOVED)
255 .any ()) 239 .any ())
256 return 0; 240 return 0;
257 241
258 /* This is really a spellbook check - we should in general 242 /* This is really a spellbook check - we should in general
340 { 324 {
341 // see if we are in a container of sorts 325 // see if we are in a container of sorts
342 if (env) 326 if (env)
343 { 327 {
344 // the player inventory itself is always visible 328 // the player inventory itself is always visible
345 if (env->type == PLAYER) 329 if (env->is_player ())
346 return env; 330 return env;
347 331
348 // else a player could have our env open 332 // else a player could have our env open
349 object *envest = env->outer_env (); 333 object *envest = env->outer_env_or_self ();
350 334
351 // the player itself is always on a map, so we will find him here 335 // the player itself is always on a map, so we will find him here
352 // even if our inv is in a player. 336 // even if our inv is in a player.
353 if (envest->is_on_map ()) 337 if (envest->is_on_map ())
354 if (object *pl = envest->ms ().player ()) 338 if (object *pl = envest->ms ().player ())
358 else 342 else
359 { 343 {
360 // maybe there is a player standing on the same mapspace 344 // maybe there is a player standing on the same mapspace
361 // this will catch the case where "this" is a player 345 // this will catch the case where "this" is a player
362 if (object *pl = ms ().player ()) 346 if (object *pl = ms ().player ())
347 if ((!pl->container && pl->contr->ns && !pl->contr->ns->update_look)
363 if (!pl->container || this == pl->container) 348 || this == pl->container)
364 return pl; 349 return pl;
365 } 350 }
366 } 351 }
367 352
368 return 0; 353 return 0;
369} 354}
370 355
371// adjust weight per container type ("of holding") 356// adjust weight per container type ("of holding")
372static sint32 357static sint32
373weight_adjust (object *op, sint32 weight) 358weight_adjust_for (object *op, sint32 weight)
374{ 359{
375 return op->type == CONTAINER 360 return op->type == CONTAINER
376 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str) 361 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str)
377 : weight; 362 : weight;
378} 363}
384static void 369static void
385adjust_weight (object *op, sint32 weight) 370adjust_weight (object *op, sint32 weight)
386{ 371{
387 while (op) 372 while (op)
388 { 373 {
374 // adjust by actual difference to account for rounding errors
375 // i.e. (w2 - w1) / f != w2 / f - w1 / f and the latter is correct
389 weight = weight_adjust (op, weight); 376 weight = weight_adjust_for (op, op->carrying)
377 - weight_adjust_for (op, op->carrying - weight);
390 378
391 if (!weight) 379 if (!weight)
392 return; 380 return;
393 381
394 op->carrying += weight; 382 op->carrying += weight;
417 op->update_weight (); 405 op->update_weight ();
418 406
419 sum += op->total_weight (); 407 sum += op->total_weight ();
420 } 408 }
421 409
422 sum = weight_adjust (this, sum); 410 sum = weight_adjust_for (this, sum);
423 411
424 if (sum != carrying) 412 if (sum != carrying)
425 { 413 {
426 carrying = sum; 414 carrying = sum;
427 415
489 */ 477 */
490object * 478object *
491find_object_name (const char *str) 479find_object_name (const char *str)
492{ 480{
493 shstr_cmp str_ (str); 481 shstr_cmp str_ (str);
494 object *op;
495 482
483 if (str_)
496 for_all_objects (op) 484 for_all_objects (op)
497 if (op->name == str_) 485 if (op->name == str_)
498 break; 486 return op;
499 487
500 return op; 488 return 0;
501} 489}
502 490
503/* 491/*
504 * Sets the owner and sets the skill and exp pointers to owner's current 492 * Sets the owner and sets the skill and exp pointers to owner's current
505 * skill and experience objects. 493 * skill and experience objects.
603 } 591 }
604 592
605 op->key_values = 0; 593 op->key_values = 0;
606} 594}
607 595
608object & 596/*
609object::operator =(const object &src) 597 * copy_to first frees everything allocated by the dst object,
598 * and then copies the contents of itself into the second
599 * object, allocating what needs to be allocated. Basically, any
600 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
601 * if the first object is freed, the pointers in the new object
602 * will point at garbage.
603 */
604void
605object::copy_to (object *dst)
610{ 606{
611 bool is_freed = flag [FLAG_FREED]; 607 dst->remove ();
612 bool is_removed = flag [FLAG_REMOVED];
613
614 *(object_copy *)this = src; 608 *(object_copy *)dst = *this;
615
616 flag [FLAG_FREED] = is_freed;
617 flag [FLAG_REMOVED] = is_removed; 609 dst->flag [FLAG_REMOVED] = true;
618 610
619 /* Copy over key_values, if any. */ 611 /* Copy over key_values, if any. */
620 if (src.key_values) 612 if (key_values)
621 { 613 {
622 key_value *tail = 0; 614 key_value *tail = 0;
623 key_values = 0; 615 dst->key_values = 0;
624 616
625 for (key_value *i = src.key_values; i; i = i->next) 617 for (key_value *i = key_values; i; i = i->next)
626 { 618 {
627 key_value *new_link = new key_value; 619 key_value *new_link = new key_value;
628 620
629 new_link->next = 0; 621 new_link->next = 0;
630 new_link->key = i->key; 622 new_link->key = i->key;
631 new_link->value = i->value; 623 new_link->value = i->value;
632 624
633 /* Try and be clever here, too. */ 625 /* Try and be clever here, too. */
634 if (!key_values) 626 if (!dst->key_values)
635 { 627 {
636 key_values = new_link; 628 dst->key_values = new_link;
637 tail = new_link; 629 tail = new_link;
638 } 630 }
639 else 631 else
640 { 632 {
641 tail->next = new_link; 633 tail->next = new_link;
642 tail = new_link; 634 tail = new_link;
643 } 635 }
644 } 636 }
645 } 637 }
646}
647
648/*
649 * copy_to first frees everything allocated by the dst object,
650 * and then copies the contents of itself into the second
651 * object, allocating what needs to be allocated. Basically, any
652 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
653 * if the first object is freed, the pointers in the new object
654 * will point at garbage.
655 */
656void
657object::copy_to (object *dst)
658{
659 *dst = *this;
660 638
661 if (speed < 0) 639 if (speed < 0)
662 dst->speed_left -= rndm (); 640 dst->speed_left -= rndm ();
663 641
664 dst->set_speed (dst->speed); 642 dst->activate ();
665} 643}
666 644
667void 645void
668object::instantiate () 646object::instantiate ()
669{ 647{
686object * 664object *
687object::clone () 665object::clone ()
688{ 666{
689 object *neu = create (); 667 object *neu = create ();
690 copy_to (neu); 668 copy_to (neu);
669 neu->map = map; // not copied by copy_to
691 return neu; 670 return neu;
692} 671}
693 672
694/* 673/*
695 * If an object with the IS_TURNABLE() flag needs to be turned due 674 * If an object with the IS_TURNABLE() flag needs to be turned due
746 * UP_OBJ_FACE: only the objects face has changed. 725 * UP_OBJ_FACE: only the objects face has changed.
747 */ 726 */
748void 727void
749update_object (object *op, int action) 728update_object (object *op, int action)
750{ 729{
751 if (op == NULL) 730 if (!op)
752 { 731 {
753 /* this should never happen */ 732 /* this should never happen */
754 LOG (llevDebug, "update_object() called for NULL object.\n"); 733 LOG (llevError | logBacktrace, "update_object() called for NULL object.\n");
755 return; 734 return;
756 } 735 }
757 736
758 if (op->env) 737 if (!op->is_on_map ())
759 { 738 {
760 /* Animation is currently handled by client, so nothing 739 /* Animation is currently handled by client, so nothing
761 * to do in this case. 740 * to do in this case.
762 */ 741 */
763 return; 742 return;
764 } 743 }
765
766 /* If the map is saving, don't do anything as everything is
767 * going to get freed anyways.
768 */
769 if (!op->map || op->map->in_memory == MAP_SAVING)
770 return;
771 744
772 /* make sure the object is within map boundaries */ 745 /* make sure the object is within map boundaries */
773 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height) 746 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
774 { 747 {
775 LOG (llevError, "update_object() called for object out of map!\n"); 748 LOG (llevError, "update_object() called for object out of map!\n");
786 else if (action == UP_OBJ_INSERT) 759 else if (action == UP_OBJ_INSERT)
787 { 760 {
788 // this is likely overkill, TODO: revisit (schmorp) 761 // this is likely overkill, TODO: revisit (schmorp)
789 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW)) 762 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
790 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC)) 763 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
791 || (op->type == PLAYER && !(m.flags_ & P_PLAYER)) 764 || (op->is_player () && !(m.flags_ & P_PLAYER))
792 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE)) 765 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
793 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE)) 766 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
794 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC)) 767 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
795 || (m.move_on | op->move_on ) != m.move_on 768 || (m.move_on | op->move_on ) != m.move_on
796 || (m.move_off | op->move_off ) != m.move_off 769 || (m.move_off | op->move_off ) != m.move_off
797 || (m.move_slow | op->move_slow) != m.move_slow 770 || (m.move_slow | op->move_slow) != m.move_slow
798 /* This isn't perfect, but I don't expect a lot of objects to 771 /* This isn't perfect, but I don't expect a lot of objects to
799 * to have move_allow right now. 772 * have move_allow right now.
800 */ 773 */
801 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block 774 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
802 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp) 775 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
803 m.flags_ = 0; 776 m.invalidate ();
804 } 777 }
805 /* if the object is being removed, we can't make intelligent 778 /* if the object is being removed, we can't make intelligent
806 * decisions, because remove_ob can't really pass the object 779 * decisions, because remove_ob can't really pass the object
807 * that is being removed. 780 * that is being removed.
808 */ 781 */
809 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 782 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
810 m.flags_ = 0; 783 m.invalidate ();
811 else if (action == UP_OBJ_FACE) 784 else if (action == UP_OBJ_FACE)
812 /* Nothing to do for that case */ ; 785 /* Nothing to do for that case */ ;
813 else 786 else
814 LOG (llevError, "update_object called with invalid action: %d\n", action); 787 LOG (llevError, "update_object called with invalid action: %d\n", action);
815 788
819 792
820object::object () 793object::object ()
821{ 794{
822 SET_FLAG (this, FLAG_REMOVED); 795 SET_FLAG (this, FLAG_REMOVED);
823 796
824 expmul = 1.0; 797 //expmul = 1.0; declared const for the time being
825 face = blank_face; 798 face = blank_face;
826} 799}
827 800
828object::~object () 801object::~object ()
829{ 802{
859 /* If already on active list, don't do anything */ 832 /* If already on active list, don't do anything */
860 if (active) 833 if (active)
861 return; 834 return;
862 835
863 if (has_active_speed ()) 836 if (has_active_speed ())
837 {
838 if (flag [FLAG_FREED])
839 LOG (llevError | logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
840
864 actives.insert (this); 841 actives.insert (this);
842 }
865} 843}
866 844
867void 845void
868object::activate_recursive () 846object::activate_recursive ()
869{ 847{
930 * drop on that space. 908 * drop on that space.
931 */ 909 */
932 if (!drop_to_ground 910 if (!drop_to_ground
933 || !map 911 || !map
934 || map->in_memory != MAP_ACTIVE 912 || map->in_memory != MAP_ACTIVE
935 || map->nodrop 913 || map->no_drop
936 || ms ().move_block == MOVE_ALL) 914 || ms ().move_block == MOVE_ALL)
937 { 915 {
938 while (inv) 916 while (inv)
939 {
940 inv->destroy_inv (false);
941 inv->destroy (); 917 inv->destroy ();
942 }
943 } 918 }
944 else 919 else
945 { /* Put objects in inventory onto this space */ 920 { /* Put objects in inventory onto this space */
946 while (inv) 921 while (inv)
947 { 922 {
951 || op->flag [FLAG_NO_DROP] 926 || op->flag [FLAG_NO_DROP]
952 || op->type == RUNE 927 || op->type == RUNE
953 || op->type == TRAP 928 || op->type == TRAP
954 || op->flag [FLAG_IS_A_TEMPLATE] 929 || op->flag [FLAG_IS_A_TEMPLATE]
955 || op->flag [FLAG_DESTROY_ON_DEATH]) 930 || op->flag [FLAG_DESTROY_ON_DEATH])
956 op->destroy (true); 931 op->destroy ();
957 else 932 else
958 map->insert (op, x, y); 933 map->insert (op, x, y);
959 } 934 }
960 } 935 }
961} 936}
965 object *op = new object; 940 object *op = new object;
966 op->link (); 941 op->link ();
967 return op; 942 return op;
968} 943}
969 944
945static struct freed_map : maptile
946{
947 freed_map ()
948 {
949 path = "<freed objects map>";
950 name = "/internal/freed_objects_map";
951 width = 3;
952 height = 3;
953 no_drop = 1;
954 no_reset = 1;
955
956 alloc ();
957 in_memory = MAP_ACTIVE;
958 }
959
960 ~freed_map ()
961 {
962 destroy ();
963 }
964} freed_map; // freed objects are moved here to avoid crashes
965
970void 966void
971object::do_destroy () 967object::do_destroy ()
972{ 968{
973 if (flag [FLAG_IS_LINKED]) 969 if (flag [FLAG_IS_LINKED])
974 remove_button_link (this); 970 remove_link ();
975 971
976 if (flag [FLAG_FRIENDLY]) 972 if (flag [FLAG_FRIENDLY])
977 remove_friendly_object (this); 973 remove_friendly_object (this);
978 974
979 remove (); 975 remove ();
984 unlink (); 980 unlink ();
985 981
986 flag [FLAG_FREED] = 1; 982 flag [FLAG_FREED] = 1;
987 983
988 // hack to ensure that freed objects still have a valid map 984 // hack to ensure that freed objects still have a valid map
989 {
990 static maptile *freed_map; // freed objects are moved here to avoid crashes
991
992 if (!freed_map)
993 {
994 freed_map = new maptile;
995
996 freed_map->path = "<freed objects map>";
997 freed_map->name = "/internal/freed_objects_map";
998 freed_map->width = 3;
999 freed_map->height = 3;
1000 freed_map->nodrop = 1;
1001
1002 freed_map->alloc ();
1003 freed_map->in_memory = MAP_ACTIVE;
1004 }
1005
1006 map = freed_map; 985 map = &freed_map;
1007 x = 1; 986 x = 1;
1008 y = 1; 987 y = 1;
1009 }
1010 988
1011 if (more) 989 if (more)
1012 { 990 {
1013 more->destroy (); 991 more->destroy ();
1014 more = 0; 992 more = 0;
1022 attacked_by = 0; 1000 attacked_by = 0;
1023 current_weapon = 0; 1001 current_weapon = 0;
1024} 1002}
1025 1003
1026void 1004void
1027object::destroy (bool destroy_inventory) 1005object::destroy ()
1028{ 1006{
1029 if (destroyed ()) 1007 if (destroyed ())
1030 return; 1008 return;
1031 1009
1032 if (!is_head () && !head->destroyed ()) 1010 if (!is_head () && !head->destroyed ())
1033 { 1011 {
1034 LOG (llevError | logBacktrace, "tried to destroy the tail of an object"); 1012 LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
1035 head->destroy (destroy_inventory); 1013 head->destroy ();
1014 return;
1036 } 1015 }
1037 1016
1038 destroy_inv (!destroy_inventory); 1017 destroy_inv (false);
1039 1018
1040 if (is_head ()) 1019 if (is_head ())
1041 if (sound_destroy) 1020 if (sound_destroy)
1042 play_sound (sound_destroy); 1021 play_sound (sound_destroy);
1043 else if (flag [FLAG_MONSTER]) 1022 else if (flag [FLAG_MONSTER])
1073 * In this case, the object to be removed is in someones 1052 * In this case, the object to be removed is in someones
1074 * inventory. 1053 * inventory.
1075 */ 1054 */
1076 if (env) 1055 if (env)
1077 { 1056 {
1057 flag [FLAG_REMOVED] = false; // hack around the issue of visible_to checking flag_removed
1078 if (object *pl = visible_to ()) 1058 if (object *pl = visible_to ())
1079 esrv_del_item (pl->contr, count); 1059 esrv_del_item (pl->contr, count);
1060 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
1080 1061
1081 adjust_weight (env, -total_weight ()); 1062 adjust_weight (env, -total_weight ());
1082 1063
1083 *(above ? &above->below : &env->inv) = below; 1064 object *pl = in_player ();
1084
1085 if (below)
1086 below->above = above;
1087 1065
1088 /* we set up values so that it could be inserted into 1066 /* we set up values so that it could be inserted into
1089 * the map, but we don't actually do that - it is up 1067 * the map, but we don't actually do that - it is up
1090 * to the caller to decide what we want to do. 1068 * to the caller to decide what we want to do.
1091 */ 1069 */
1092 map = env->map; 1070 map = env->map;
1093 x = env->x; 1071 x = env->x;
1094 y = env->y; 1072 y = env->y;
1073
1074 // make sure cmov optimisation is applicable
1075 *(above ? &above->below : &env->inv) = below;
1076 *(below ? &below->above : &above ) = above; // &above is just a dummy
1077
1095 above = 0; 1078 above = 0;
1096 below = 0; 1079 below = 0;
1097 env = 0; 1080 env = 0;
1098 1081
1099 /* NO_FIX_PLAYER is set when a great many changes are being 1082 /* NO_FIX_PLAYER is set when a great many changes are being
1100 * made to players inventory. If set, avoiding the call 1083 * made to players inventory. If set, avoiding the call
1101 * to save cpu time. 1084 * to save cpu time.
1102 */ 1085 */
1103 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1086 if (pl)
1087 if (pl->is_player () && (glow_radius || !QUERY_FLAG (pl, FLAG_NO_FIX_PLAYER)))
1088 {
1104 otmp->update_stats (); 1089 pl->update_stats ();
1090
1091 if (glow_radius && pl->is_on_map ())
1092 update_all_los (pl->map, pl->x, pl->y);
1093 }
1105 } 1094 }
1106 else if (map) 1095 else if (map)
1107 { 1096 {
1108 map->dirty = true; 1097 map->dirty = true;
1109 mapspace &ms = this->ms (); 1098 mapspace &ms = this->ms ();
1110 1099
1111 if (object *pl = ms.player ()) 1100 if (object *pl = ms.player ())
1112 { 1101 {
1113 if (type == PLAYER) // this == pl(!) 1102 if (is_player ())
1114 { 1103 {
1104 if (!flag [FLAG_WIZPASS])
1105 ms.smell = ++mapspace::smellcount; // remember the smell of the player
1106
1115 // leaving a spot always closes any open container on the ground 1107 // leaving a spot always closes any open container on the ground
1116 if (container && !container->env) 1108 if (container && !container->env)
1117 // this causes spurious floorbox updates, but it ensures 1109 // this causes spurious floorbox updates, but it ensures
1118 // that the CLOSE event is being sent. 1110 // that the CLOSE event is being sent.
1119 close_container (); 1111 close_container ();
1129 1121
1130 esrv_del_item (pl->contr, count); 1122 esrv_del_item (pl->contr, count);
1131 } 1123 }
1132 1124
1133 /* link the object above us */ 1125 /* link the object above us */
1134 if (above) 1126 // re-link, make sure compiler can easily use cmove
1135 above->below = below; 1127 *(above ? &above->below : &ms.top) = below;
1136 else 1128 *(below ? &below->above : &ms.bot) = above;
1137 ms.top = below; /* we were top, set new top */
1138
1139 /* Relink the object below us, if there is one */
1140 if (below)
1141 below->above = above;
1142 else
1143 {
1144 /* Nothing below, which means we need to relink map object for this space
1145 * use translated coordinates in case some oddness with map tiling is
1146 * evident
1147 */
1148 if (GET_MAP_OB (map, x, y) != this)
1149 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1150
1151 ms.bot = above; /* goes on above it. */
1152 }
1153 1129
1154 above = 0; 1130 above = 0;
1155 below = 0; 1131 below = 0;
1132
1133 ms.invalidate ();
1156 1134
1157 if (map->in_memory == MAP_SAVING) 1135 if (map->in_memory == MAP_SAVING)
1158 return; 1136 return;
1159 1137
1160 int check_walk_off = !flag [FLAG_NO_APPLY]; 1138 int check_walk_off = !flag [FLAG_NO_APPLY];
1167 * appropriately. 1145 * appropriately.
1168 */ 1146 */
1169 pl->close_container (); 1147 pl->close_container ();
1170 1148
1171 //TODO: the floorbox prev/next might need updating 1149 //TODO: the floorbox prev/next might need updating
1172 esrv_del_item (pl->contr, count); 1150 //esrv_del_item (pl->contr, count);
1151 //TODO: update floorbox to preserve ordering
1152 if (pl->contr->ns)
1153 pl->contr->ns->floorbox_update ();
1173 } 1154 }
1174 1155
1175 for (tmp = ms.bot; tmp; tmp = tmp->above) 1156 for (tmp = ms.bot; tmp; tmp = tmp->above)
1176 { 1157 {
1177 /* No point updating the players look faces if he is the object 1158 /* No point updating the players look faces if he is the object
1190 } 1171 }
1191 1172
1192 last = tmp; 1173 last = tmp;
1193 } 1174 }
1194 1175
1195 /* last == NULL if there are no objects on this space */ 1176 if (affects_los ())
1196 //TODO: this makes little sense, why only update the topmost object?
1197 if (!last)
1198 map->at (x, y).flags_ = 0;
1199 else
1200 update_object (last, UP_OBJ_REMOVE);
1201
1202 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1203 update_all_los (map, x, y); 1177 update_all_los (map, x, y);
1204 } 1178 }
1205} 1179}
1206 1180
1207/* 1181/*
1231 esrv_update_item (UPD_NROF, pl, top); 1205 esrv_update_item (UPD_NROF, pl, top);
1232 1206
1233 op->weight = 0; // cancel the addition above 1207 op->weight = 0; // cancel the addition above
1234 op->carrying = 0; // must be 0 already 1208 op->carrying = 0; // must be 0 already
1235 1209
1236 op->destroy (1); 1210 op->destroy ();
1237 1211
1238 return top; 1212 return top;
1239 } 1213 }
1240 1214
1241 return 0; 1215 return 0;
1269 * job preparing multi-part monsters. 1243 * job preparing multi-part monsters.
1270 */ 1244 */
1271object * 1245object *
1272insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1246insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1273{ 1247{
1248 op->remove ();
1249
1274 for (object *tmp = op->head_ (); tmp; tmp = tmp->more) 1250 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1275 { 1251 {
1276 tmp->x = x + tmp->arch->x; 1252 tmp->x = x + tmp->arch->x;
1277 tmp->y = y + tmp->arch->y; 1253 tmp->y = y + tmp->arch->y;
1278 } 1254 }
1301 * just 'op' otherwise 1277 * just 'op' otherwise
1302 */ 1278 */
1303object * 1279object *
1304insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1280insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1305{ 1281{
1306 assert (!op->flag [FLAG_FREED]);
1307
1308 op->remove (); 1282 op->remove ();
1283
1284 if (m == &freed_map)//D TODO: remove soon
1285 {//D
1286 LOG (llevError | logBacktrace, "tries to insret object on freed objects map: %s", op->debug_desc ());//D
1287 }//D
1309 1288
1310 /* Ideally, the caller figures this out. However, it complicates a lot 1289 /* Ideally, the caller figures this out. However, it complicates a lot
1311 * of areas of callers (eg, anything that uses find_free_spot would now 1290 * of areas of callers (eg, anything that uses find_free_spot would now
1312 * need extra work 1291 * need extra work
1313 */ 1292 */
1293 maptile *newmap = m;
1314 if (!xy_normalise (m, op->x, op->y)) 1294 if (!xy_normalise (newmap, op->x, op->y))
1315 { 1295 {
1316 op->destroy (1); 1296 op->head_ ()->destroy ();// remove head_ once all tail object destroyers found
1317 return 0; 1297 return 0;
1318 } 1298 }
1319 1299
1320 if (object *more = op->more) 1300 if (object *more = op->more)
1321 if (!insert_ob_in_map (more, m, originator, flag)) 1301 if (!insert_ob_in_map (more, m, originator, flag))
1322 return 0; 1302 return 0;
1323 1303
1324 CLEAR_FLAG (op, FLAG_REMOVED); 1304 op->flag [FLAG_REMOVED] = false;
1325 1305 op->env = 0;
1326 op->map = m; 1306 op->map = newmap;
1307
1327 mapspace &ms = op->ms (); 1308 mapspace &ms = op->ms ();
1328 1309
1329 /* this has to be done after we translate the coordinates. 1310 /* this has to be done after we translate the coordinates.
1330 */ 1311 */
1331 if (op->nrof && !(flag & INS_NO_MERGE)) 1312 if (op->nrof && !(flag & INS_NO_MERGE))
1332 for (object *tmp = ms.bot; tmp; tmp = tmp->above) 1313 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1333 if (object::can_merge (op, tmp)) 1314 if (object::can_merge (op, tmp))
1334 { 1315 {
1335 // TODO: we atcually want to update tmp, not op, 1316 // TODO: we actually want to update tmp, not op,
1336 // but some caller surely breaks when we return tmp 1317 // but some caller surely breaks when we return tmp
1337 // from here :/ 1318 // from here :/
1338 op->nrof += tmp->nrof; 1319 op->nrof += tmp->nrof;
1339 tmp->destroy (1); 1320 tmp->destroy ();
1340 } 1321 }
1341 1322
1342 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1323 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1343 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1324 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1344 1325
1351 { 1332 {
1352 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n"); 1333 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1353 abort (); 1334 abort ();
1354 } 1335 }
1355 1336
1337 if (!originator->is_on_map ())
1338 {
1339 LOG (llevError, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
1340 op->debug_desc (), originator->debug_desc ());
1341 abort ();
1342 }
1343
1356 op->above = originator; 1344 op->above = originator;
1357 op->below = originator->below; 1345 op->below = originator->below;
1358
1359 if (op->below)
1360 op->below->above = op;
1361 else
1362 ms.bot = op;
1363
1364 /* since *below* originator, no need to update top */
1365 originator->below = op; 1346 originator->below = op;
1347
1348 *(op->below ? &op->below->above : &ms.bot) = op;
1366 } 1349 }
1367 else 1350 else
1368 { 1351 {
1369 object *top, *floor = NULL; 1352 object *floor = 0;
1370 1353 object *top = ms.top;
1371 top = ms.bot;
1372 1354
1373 /* If there are other objects, then */ 1355 /* If there are other objects, then */
1374 if (top) 1356 if (top)
1375 { 1357 {
1376 object *last = 0;
1377
1378 /* 1358 /*
1379 * If there are multiple objects on this space, we do some trickier handling. 1359 * If there are multiple objects on this space, we do some trickier handling.
1380 * We've already dealt with merging if appropriate. 1360 * We've already dealt with merging if appropriate.
1381 * Generally, we want to put the new object on top. But if 1361 * Generally, we want to put the new object on top. But if
1382 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last 1362 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
1385 * once we get to them. This reduces the need to traverse over all of 1365 * once we get to them. This reduces the need to traverse over all of
1386 * them when adding another one - this saves quite a bit of cpu time 1366 * them when adding another one - this saves quite a bit of cpu time
1387 * when lots of spells are cast in one area. Currently, it is presumed 1367 * when lots of spells are cast in one area. Currently, it is presumed
1388 * that flying non pickable objects are spell objects. 1368 * that flying non pickable objects are spell objects.
1389 */ 1369 */
1390 for (top = ms.bot; top; top = top->above) 1370 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1391 { 1371 {
1392 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1372 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) || QUERY_FLAG (tmp, FLAG_OVERLAY_FLOOR))
1393 floor = top; 1373 floor = tmp;
1394 1374
1395 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1375 if (QUERY_FLAG (tmp, FLAG_NO_PICK) && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (tmp, FLAG_IS_FLOOR))
1396 { 1376 {
1397 /* We insert above top, so we want this object below this */ 1377 /* We insert above top, so we want this object below this */
1398 top = top->below; 1378 top = tmp->below;
1399 break; 1379 break;
1400 } 1380 }
1401 1381
1402 last = top; 1382 top = tmp;
1403 } 1383 }
1404
1405 /* Don't want top to be NULL, so set it to the last valid object */
1406 top = last;
1407 1384
1408 /* We let update_position deal with figuring out what the space 1385 /* We let update_position deal with figuring out what the space
1409 * looks like instead of lots of conditions here. 1386 * looks like instead of lots of conditions here.
1410 * makes things faster, and effectively the same result. 1387 * makes things faster, and effectively the same result.
1411 */ 1388 */
1418 */ 1395 */
1419 if (!(flag & INS_ON_TOP) 1396 if (!(flag & INS_ON_TOP)
1420 && ms.flags () & P_BLOCKSVIEW 1397 && ms.flags () & P_BLOCKSVIEW
1421 && (op->face && !faces [op->face].visibility)) 1398 && (op->face && !faces [op->face].visibility))
1422 { 1399 {
1400 object *last;
1401
1423 for (last = top; last != floor; last = last->below) 1402 for (last = top; last != floor; last = last->below)
1424 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1403 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1425 break; 1404 break;
1426 1405
1427 /* Check to see if we found the object that blocks view, 1406 /* Check to see if we found the object that blocks view,
1435 } /* If objects on this space */ 1414 } /* If objects on this space */
1436 1415
1437 if (flag & INS_ABOVE_FLOOR_ONLY) 1416 if (flag & INS_ABOVE_FLOOR_ONLY)
1438 top = floor; 1417 top = floor;
1439 1418
1440 /* Top is the object that our object (op) is going to get inserted above. 1419 // insert object above top, or bottom-most if top = 0
1441 */
1442
1443 /* First object on this space */
1444 if (!top) 1420 if (!top)
1445 { 1421 {
1422 op->below = 0;
1446 op->above = ms.bot; 1423 op->above = ms.bot;
1447
1448 if (op->above)
1449 op->above->below = op;
1450
1451 op->below = 0;
1452 ms.bot = op; 1424 ms.bot = op;
1425
1426 *(op->above ? &op->above->below : &ms.top) = op;
1453 } 1427 }
1454 else 1428 else
1455 { /* get inserted into the stack above top */ 1429 {
1456 op->above = top->above; 1430 op->above = top->above;
1457
1458 if (op->above)
1459 op->above->below = op; 1431 top->above = op;
1460 1432
1461 op->below = top; 1433 op->below = top;
1462 top->above = op; 1434 *(op->above ? &op->above->below : &ms.top) = op;
1463 } 1435 }
1436 }
1464 1437
1465 if (!op->above) 1438 if (op->is_player ())
1466 ms.top = op;
1467 } /* else not INS_BELOW_ORIGINATOR */
1468
1469 if (op->type == PLAYER)
1470 { 1439 {
1471 op->contr->do_los = 1; 1440 op->contr->do_los = 1;
1472 ++op->map->players; 1441 ++op->map->players;
1473 op->map->touch (); 1442 op->map->touch ();
1474 } 1443 }
1475 1444
1476 op->map->dirty = true; 1445 op->map->dirty = true;
1477 1446
1478 if (object *pl = ms.player ()) 1447 if (object *pl = ms.player ())
1479 //TODO: the floorbox prev/next might need updating 1448 //TODO: the floorbox prev/next might need updating
1480 esrv_send_item (pl, op); 1449 //esrv_send_item (pl, op);
1450 //TODO: update floorbox to preserve ordering
1451 if (pl->contr->ns)
1452 pl->contr->ns->floorbox_update ();
1481 1453
1482 /* If this object glows, it may affect lighting conditions that are 1454 /* If this object glows, it may affect lighting conditions that are
1483 * visible to others on this map. But update_all_los is really 1455 * visible to others on this map. But update_all_los is really
1484 * an inefficient way to do this, as it means los for all players 1456 * an inefficient way to do this, as it means los for all players
1485 * on the map will get recalculated. The players could very well 1457 * on the map will get recalculated. The players could very well
1486 * be far away from this change and not affected in any way - 1458 * be far away from this change and not affected in any way -
1487 * this should get redone to only look for players within range, 1459 * this should get redone to only look for players within range,
1488 * or just updating the P_UPTODATE for spaces within this area 1460 * or just updating the P_UPTODATE for spaces within this area
1489 * of effect may be sufficient. 1461 * of effect may be sufficient.
1490 */ 1462 */
1491 if (op->map->darkness && (op->glow_radius != 0)) 1463 if (op->affects_los ())
1464 {
1465 op->ms ().invalidate ();
1492 update_all_los (op->map, op->x, op->y); 1466 update_all_los (op->map, op->x, op->y);
1467 }
1493 1468
1494 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1469 /* updates flags (blocked, alive, no magic, etc) for this map space */
1495 update_object (op, UP_OBJ_INSERT); 1470 update_object (op, UP_OBJ_INSERT);
1496 1471
1497 INVOKE_OBJECT (INSERT, op); 1472 INVOKE_OBJECT (INSERT, op);
1525/* this function inserts an object in the map, but if it 1500/* this function inserts an object in the map, but if it
1526 * finds an object of its own type, it'll remove that one first. 1501 * finds an object of its own type, it'll remove that one first.
1527 * op is the object to insert it under: supplies x and the map. 1502 * op is the object to insert it under: supplies x and the map.
1528 */ 1503 */
1529void 1504void
1530replace_insert_ob_in_map (const char *arch_string, object *op) 1505replace_insert_ob_in_map (shstr_tmp archname, object *op)
1531{ 1506{
1532 /* first search for itself and remove any old instances */ 1507 /* first search for itself and remove any old instances */
1533 1508
1534 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above) 1509 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1535 if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */ 1510 if (tmp->arch->archname == archname) /* same archetype */
1536 tmp->destroy (1); 1511 tmp->destroy ();
1537 1512
1538 object *tmp = arch_to_object (archetype::find (arch_string)); 1513 object *tmp = arch_to_object (archetype::find (archname));
1539 1514
1540 tmp->x = op->x; 1515 tmp->x = op->x;
1541 tmp->y = op->y; 1516 tmp->y = op->y;
1542 1517
1543 insert_ob_in_map (tmp, op->map, op, 0); 1518 insert_ob_in_map (tmp, op->map, op, 0);
1565 if (!nr) 1540 if (!nr)
1566 return true; 1541 return true;
1567 1542
1568 nr = min (nr, nrof); 1543 nr = min (nr, nrof);
1569 1544
1545 if (nrof > nr)
1546 {
1570 nrof -= nr; 1547 nrof -= nr;
1571
1572 if (nrof)
1573 {
1574 adjust_weight (env, -weight * nr); // carrying == 0 1548 adjust_weight (env, -weight * max (1, nr)); // carrying == 0
1575 1549
1576 if (object *pl = visible_to ()) 1550 if (object *pl = visible_to ())
1577 esrv_update_item (UPD_NROF, pl, this); 1551 esrv_update_item (UPD_NROF, pl, this);
1578 1552
1579 return true; 1553 return true;
1580 } 1554 }
1581 else 1555 else
1582 { 1556 {
1583 destroy (1); 1557 destroy ();
1584 return false; 1558 return false;
1585 } 1559 }
1586} 1560}
1587 1561
1588/* 1562/*
1605 } 1579 }
1606 else 1580 else
1607 { 1581 {
1608 decrease (nr); 1582 decrease (nr);
1609 1583
1610 object *op = object_create_clone (this); 1584 object *op = deep_clone ();
1611 op->nrof = nr; 1585 op->nrof = nr;
1612 return op; 1586 return op;
1613 } 1587 }
1614} 1588}
1615 1589
1665 if (object *pl = tmp->visible_to ()) 1639 if (object *pl = tmp->visible_to ())
1666 esrv_update_item (UPD_NROF, pl, tmp); 1640 esrv_update_item (UPD_NROF, pl, tmp);
1667 1641
1668 adjust_weight (this, op->total_weight ()); 1642 adjust_weight (this, op->total_weight ());
1669 1643
1670 op->destroy (1); 1644 op->destroy ();
1671 op = tmp; 1645 op = tmp;
1672 goto inserted; 1646 goto inserted;
1673 } 1647 }
1674 1648
1675 op->owner = 0; // it's his/hers now. period. 1649 op->owner = 0; // it's his/hers now. period.
1693 1667
1694 adjust_weight (this, op->total_weight ()); 1668 adjust_weight (this, op->total_weight ());
1695 1669
1696inserted: 1670inserted:
1697 /* reset the light list and los of the players on the map */ 1671 /* reset the light list and los of the players on the map */
1698 if (op->glow_radius && map && map->darkness) 1672 if (op->glow_radius && is_on_map ())
1673 {
1674 update_stats ();
1699 update_all_los (map, x, y); 1675 update_all_los (map, x, y);
1700 1676 }
1677 else if (is_player () && !flag [FLAG_NO_FIX_PLAYER])
1701 // if this is a player's inventory, update stats 1678 // if this is a player's inventory, update stats
1702 if (type == PLAYER && !flag [FLAG_NO_FIX_PLAYER])
1703 update_stats (); 1679 update_stats ();
1704 1680
1705 INVOKE_OBJECT (INSERT, this); 1681 INVOKE_OBJECT (INSERT, this);
1706 1682
1707 return op; 1683 return op;
1791 { 1767 {
1792 1768
1793 float 1769 float
1794 diff = tmp->move_slow_penalty * fabs (op->speed); 1770 diff = tmp->move_slow_penalty * fabs (op->speed);
1795 1771
1796 if (op->type == PLAYER) 1772 if (op->is_player ())
1797 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) || 1773 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) ||
1798 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN))) 1774 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN)))
1799 diff /= 4.0; 1775 diff /= 4.0;
1800 1776
1801 op->speed_left -= diff; 1777 op->speed_left -= diff;
1836 LOG (llevError, "Present_arch called outside map.\n"); 1812 LOG (llevError, "Present_arch called outside map.\n");
1837 return NULL; 1813 return NULL;
1838 } 1814 }
1839 1815
1840 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above) 1816 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1841 if (tmp->arch == at) 1817 if (tmp->arch->archname == at->archname)
1842 return tmp; 1818 return tmp;
1843 1819
1844 return NULL; 1820 return NULL;
1845} 1821}
1846 1822
1910 * The first matching object is returned, or NULL if none. 1886 * The first matching object is returned, or NULL if none.
1911 */ 1887 */
1912object * 1888object *
1913present_arch_in_ob (const archetype *at, const object *op) 1889present_arch_in_ob (const archetype *at, const object *op)
1914{ 1890{
1915 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below) 1891 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1916 if (tmp->arch == at) 1892 if (tmp->arch->archname == at->archname)
1917 return tmp; 1893 return tmp;
1918 1894
1919 return NULL; 1895 return NULL;
1920} 1896}
1921 1897
2009 * head of the object should correspond for the entire object. 1985 * head of the object should correspond for the entire object.
2010 */ 1986 */
2011 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block)) 1987 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))
2012 continue; 1988 continue;
2013 1989
2014 if (ob->blocked (m, pos.x, pos.y)) 1990 if (ob->blocked (pos.m, pos.x, pos.y))
2015 continue; 1991 continue;
2016 1992
2017 altern [index++] = i; 1993 altern [index++] = i;
2018 } 1994 }
2019 1995
2087 * there is capable of. 2063 * there is capable of.
2088 */ 2064 */
2089int 2065int
2090find_dir (maptile *m, int x, int y, object *exclude) 2066find_dir (maptile *m, int x, int y, object *exclude)
2091{ 2067{
2092 int i, max = SIZEOFFREE, mflags; 2068 int max = SIZEOFFREE, mflags;
2093
2094 sint16 nx, ny;
2095 object *tmp;
2096 maptile *mp;
2097
2098 MoveType blocked, move_type; 2069 MoveType move_type;
2099 2070
2100 if (exclude && exclude->head_ () != exclude) 2071 if (exclude && exclude->head_ () != exclude)
2101 { 2072 {
2102 exclude = exclude->head; 2073 exclude = exclude->head;
2103 move_type = exclude->move_type; 2074 move_type = exclude->move_type;
2106 { 2077 {
2107 /* If we don't have anything, presume it can use all movement types. */ 2078 /* If we don't have anything, presume it can use all movement types. */
2108 move_type = MOVE_ALL; 2079 move_type = MOVE_ALL;
2109 } 2080 }
2110 2081
2111 for (i = 1; i < max; i++) 2082 for (int i = 1; i < max; i++)
2112 { 2083 {
2113 mp = m; 2084 mapxy pos (m, x, y);
2114 nx = x + freearr_x[i]; 2085 pos.move (i);
2115 ny = y + freearr_y[i];
2116 2086
2117 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2087 if (!pos.normalise ())
2118
2119 if (mflags & P_OUT_OF_MAP)
2120 max = maxfree[i]; 2088 max = maxfree[i];
2121 else 2089 else
2122 { 2090 {
2123 mapspace &ms = mp->at (nx, ny); 2091 mapspace &ms = *pos;
2124 2092
2125 blocked = ms.move_block;
2126
2127 if ((move_type & blocked) == move_type) 2093 if ((move_type & ms.move_block) == move_type)
2128 max = maxfree[i]; 2094 max = maxfree [i];
2129 else if (mflags & P_IS_ALIVE) 2095 else if (ms.flags () & P_IS_ALIVE)
2130 { 2096 {
2131 for (tmp = ms.bot; tmp; tmp = tmp->above) 2097 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
2132 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER) 2098 if ((tmp->flag [FLAG_MONSTER] || tmp->is_player ())
2133 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude))) 2099 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))
2134 break;
2135
2136 if (tmp)
2137 return freedir[i]; 2100 return freedir [i];
2138 } 2101 }
2139 } 2102 }
2140 } 2103 }
2141 2104
2142 return 0; 2105 return 0;
2217 * This basically means that if direction is 15, then it could either go 2180 * This basically means that if direction is 15, then it could either go
2218 * direction 4, 14, or 16 to get back to where we are. 2181 * direction 4, 14, or 16 to get back to where we are.
2219 * Moved from spell_util.c to object.c with the other related direction 2182 * Moved from spell_util.c to object.c with the other related direction
2220 * functions. 2183 * functions.
2221 */ 2184 */
2222int reduction_dir[SIZEOFFREE][3] = { 2185const int reduction_dir[SIZEOFFREE][3] = {
2223 {0, 0, 0}, /* 0 */ 2186 {0, 0, 0}, /* 0 */
2224 {0, 0, 0}, /* 1 */ 2187 {0, 0, 0}, /* 1 */
2225 {0, 0, 0}, /* 2 */ 2188 {0, 0, 0}, /* 2 */
2226 {0, 0, 0}, /* 3 */ 2189 {0, 0, 0}, /* 3 */
2227 {0, 0, 0}, /* 4 */ 2190 {0, 0, 0}, /* 4 */
2323int 2286int
2324can_pick (const object *who, const object *item) 2287can_pick (const object *who, const object *item)
2325{ 2288{
2326 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2289 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2327 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2290 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2328 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2291 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->is_player () || item->weight < who->weight / 3));
2329} 2292}
2330 2293
2331/* 2294/*
2332 * create clone from object to another 2295 * create clone from object to another
2333 */ 2296 */
2334object * 2297object *
2335object_create_clone (object *asrc) 2298object::deep_clone ()
2336{ 2299{
2337 object *dst = 0, *tmp, *src, *prev, *item; 2300 assert (("deep_clone called on non-head object", is_head ()));
2338 2301
2339 if (!asrc) 2302 object *dst = clone ();
2340 return 0;
2341 2303
2342 src = asrc->head_ (); 2304 object *prev = dst;
2343
2344 prev = 0;
2345 for (object *part = src; part; part = part->more) 2305 for (object *part = this->more; part; part = part->more)
2346 { 2306 {
2347 tmp = part->clone (); 2307 object *tmp = part->clone ();
2348 tmp->x -= src->x;
2349 tmp->y -= src->y;
2350
2351 if (!part->head)
2352 {
2353 dst = tmp;
2354 tmp->head = 0;
2355 }
2356 else
2357 tmp->head = dst; 2308 tmp->head = dst;
2358
2359 tmp->more = 0;
2360
2361 if (prev)
2362 prev->more = tmp; 2309 prev->more = tmp;
2363
2364 prev = tmp; 2310 prev = tmp;
2365 } 2311 }
2366 2312
2367 for (item = src->inv; item; item = item->below) 2313 for (object *item = inv; item; item = item->below)
2368 insert_ob_in_ob (object_create_clone (item), dst); 2314 insert_ob_in_ob (item->deep_clone (), dst);
2369 2315
2370 return dst; 2316 return dst;
2371} 2317}
2372 2318
2373/* This returns the first object in who's inventory that 2319/* This returns the first object in who's inventory that
2382 return tmp; 2328 return tmp;
2383 2329
2384 return 0; 2330 return 0;
2385} 2331}
2386 2332
2387/* If ob has a field named key, return the link from the list, 2333shstr_tmp
2388 * otherwise return NULL. 2334object::kv_get (shstr_tmp key) const
2389 *
2390 * key must be a passed in shared string - otherwise, this won't
2391 * do the desired thing.
2392 */
2393key_value *
2394get_ob_key_link (const object *ob, const char *key)
2395{ 2335{
2396 for (key_value *link = ob->key_values; link; link = link->next) 2336 for (key_value *kv = key_values; kv; kv = kv->next)
2397 if (link->key == key) 2337 if (kv->key == key)
2398 return link;
2399
2400 return 0;
2401}
2402
2403/*
2404 * Returns the value of op has an extra_field for key, or NULL.
2405 *
2406 * The argument doesn't need to be a shared string.
2407 *
2408 * The returned string is shared.
2409 */
2410const char *
2411get_ob_key_value (const object *op, const char *const key)
2412{
2413 key_value *link;
2414 shstr_cmp canonical_key (key);
2415
2416 if (!canonical_key)
2417 {
2418 /* 1. There being a field named key on any object
2419 * implies there'd be a shared string to find.
2420 * 2. Since there isn't, no object has this field.
2421 * 3. Therefore, *this* object doesn't have this field.
2422 */
2423 return 0;
2424 }
2425
2426 /* This is copied from get_ob_key_link() above -
2427 * only 4 lines, and saves the function call overhead.
2428 */
2429 for (link = op->key_values; link; link = link->next)
2430 if (link->key == canonical_key)
2431 return link->value; 2338 return kv->value;
2432 2339
2433 return 0; 2340 return shstr ();
2434} 2341}
2435 2342
2436/* 2343void
2437 * Updates the canonical_key in op to value. 2344object::kv_set (shstr_tmp key, shstr_tmp value)
2438 *
2439 * canonical_key is a shared string (value doesn't have to be).
2440 *
2441 * Unless add_key is TRUE, it won't add fields, only change the value of existing
2442 * keys.
2443 *
2444 * Returns TRUE on success.
2445 */
2446int
2447set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2448{ 2345{
2449 key_value *field = NULL, *last = NULL; 2346 for (key_value *kv = key_values; kv; kv = kv->next)
2450 2347 if (kv->key == key)
2451 for (field = op->key_values; field != NULL; field = field->next)
2452 {
2453 if (field->key != canonical_key)
2454 { 2348 {
2455 last = field; 2349 kv->value = value;
2456 continue; 2350 return;
2457 } 2351 }
2458 2352
2459 if (value) 2353 key_value *kv = new key_value;
2460 field->value = value; 2354
2461 else 2355 kv->next = key_values;
2356 kv->key = key;
2357 kv->value = value;
2358
2359 key_values = kv;
2360}
2361
2362void
2363object::kv_del (shstr_tmp key)
2364{
2365 for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
2366 if ((*kvp)->key == key)
2462 { 2367 {
2463 /* Basically, if the archetype has this key set, 2368 key_value *kv = *kvp;
2464 * we need to store the null value so when we save 2369 *kvp = (*kvp)->next;
2465 * it, we save the empty value so that when we load, 2370 delete kv;
2466 * we get this value back again. 2371 return;
2467 */
2468 if (get_ob_key_link (op->arch, canonical_key))
2469 field->value = 0;
2470 else
2471 {
2472 if (last)
2473 last->next = field->next;
2474 else
2475 op->key_values = field->next;
2476
2477 delete field;
2478 }
2479 } 2372 }
2480 return TRUE;
2481 }
2482 /* IF we get here, key doesn't exist */
2483
2484 /* No field, we'll have to add it. */
2485
2486 if (!add_key)
2487 return FALSE;
2488
2489 /* There isn't any good reason to store a null
2490 * value in the key/value list. If the archetype has
2491 * this key, then we should also have it, so shouldn't
2492 * be here. If user wants to store empty strings,
2493 * should pass in ""
2494 */
2495 if (value == NULL)
2496 return TRUE;
2497
2498 field = new key_value;
2499
2500 field->key = canonical_key;
2501 field->value = value;
2502 /* Usual prepend-addition. */
2503 field->next = op->key_values;
2504 op->key_values = field;
2505
2506 return TRUE;
2507}
2508
2509/*
2510 * Updates the key in op to value.
2511 *
2512 * If add_key is FALSE, this will only update existing keys,
2513 * and not add new ones.
2514 * In general, should be little reason FALSE is ever passed in for add_key
2515 *
2516 * Returns TRUE on success.
2517 */
2518int
2519set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2520{
2521 shstr key_ (key);
2522
2523 return set_ob_key_value_s (op, key_, value, add_key);
2524} 2373}
2525 2374
2526object::depth_iterator::depth_iterator (object *container) 2375object::depth_iterator::depth_iterator (object *container)
2527: iterator_base (container) 2376: iterator_base (container)
2528{ 2377{
2578{ 2427{
2579 char flagdesc[512]; 2428 char flagdesc[512];
2580 char info2[256 * 4]; 2429 char info2[256 * 4];
2581 char *p = info; 2430 char *p = info;
2582 2431
2583 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s,flags:[%s],type:%d}", 2432 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2584 count, 2433 count,
2585 uuid.c_str (), 2434 uuid.c_str (),
2586 &name, 2435 &name,
2587 title ? "\",title:\"" : "", 2436 title ? ",title:\"" : "",
2588 title ? (const char *)title : "", 2437 title ? (const char *)title : "",
2438 title ? "\"" : "",
2589 flag_desc (flagdesc, 512), type); 2439 flag_desc (flagdesc, 512), type);
2590 2440
2591 if (!flag[FLAG_REMOVED] && env) 2441 if (!flag[FLAG_REMOVED] && env)
2592 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2442 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2593 2443
2649 container = 0; 2499 container = 0;
2650 2500
2651 // client needs item update to make it work, client bug requires this to be separate 2501 // client needs item update to make it work, client bug requires this to be separate
2652 esrv_update_item (UPD_FLAGS, this, old_container); 2502 esrv_update_item (UPD_FLAGS, this, old_container);
2653 2503
2654 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container)); 2504 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", old_container->query_name ());
2655 play_sound (sound_find ("chest_close")); 2505 play_sound (sound_find ("chest_close"));
2656 } 2506 }
2657 2507
2658 if (new_container) 2508 if (new_container)
2659 { 2509 {
2669 closer->flag [FLAG_NO_MAP_SAVE] = 1; 2519 closer->flag [FLAG_NO_MAP_SAVE] = 1;
2670 new_container->insert (closer); 2520 new_container->insert (closer);
2671 } 2521 }
2672#endif 2522#endif
2673 2523
2674 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container)); 2524 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", new_container->query_name ());
2675 2525
2676 // make sure the container is available, client bug requires this to be separate 2526 // make sure the container is available, client bug requires this to be separate
2677 esrv_send_item (this, new_container); 2527 esrv_send_item (this, new_container);
2678 2528
2679 new_container->flag [FLAG_APPLIED] = true; 2529 new_container->flag [FLAG_APPLIED] = true;
2687// else if (!old_container->env && contr && contr->ns) 2537// else if (!old_container->env && contr && contr->ns)
2688// contr->ns->floorbox_reset (); 2538// contr->ns->floorbox_reset ();
2689} 2539}
2690 2540
2691object * 2541object *
2692object::force_find (const shstr name) 2542object::force_find (shstr_tmp name)
2693{ 2543{
2694 /* cycle through his inventory to look for the MARK we want to 2544 /* cycle through his inventory to look for the MARK we want to
2695 * place 2545 * place
2696 */ 2546 */
2697 for (object *tmp = inv; tmp; tmp = tmp->below) 2547 for (object *tmp = inv; tmp; tmp = tmp->below)
2699 return splay (tmp); 2549 return splay (tmp);
2700 2550
2701 return 0; 2551 return 0;
2702} 2552}
2703 2553
2704void 2554object *
2705object::force_add (const shstr name, int duration) 2555object::force_add (shstr_tmp name, int duration)
2706{ 2556{
2707 if (object *force = force_find (name)) 2557 if (object *force = force_find (name))
2708 force->destroy (); 2558 force->destroy ();
2709 2559
2710 object *force = get_archetype (FORCE_NAME); 2560 object *force = get_archetype (FORCE_NAME);
2715 2565
2716 force->set_speed (duration ? 1.f / duration : 0.f); 2566 force->set_speed (duration ? 1.f / duration : 0.f);
2717 force->flag [FLAG_IS_USED_UP] = true; 2567 force->flag [FLAG_IS_USED_UP] = true;
2718 force->flag [FLAG_APPLIED] = true; 2568 force->flag [FLAG_APPLIED] = true;
2719 2569
2720 insert (force); 2570 return insert (force);
2721} 2571}
2722 2572
2723void 2573void
2724object::play_sound (faceidx sound) 2574object::play_sound (faceidx sound) const
2725{ 2575{
2726 if (!sound) 2576 if (!sound)
2727 return; 2577 return;
2728 2578
2729 if (flag [FLAG_REMOVED]) 2579 if (is_on_map ())
2580 map->play_sound (sound, x, y);
2581 else if (object *pl = in_player ())
2582 pl->contr->play_sound (sound);
2583}
2584
2585void
2586object::say_msg (const char *msg) const
2587{
2588 if (is_on_map ())
2589 map->say_msg (msg, x, y);
2590 else if (object *pl = in_player ())
2591 pl->contr->play_sound (sound);
2592}
2593
2594void
2595object::make_noise ()
2596{
2597 // we do not model noise in the map, so instead put
2598 // a temporary light into the noise source
2599 // could use the map instead, but that's less reliable for our
2600 // goal, which is to make invisibility a bit harder to exploit
2601
2602 // currently only works sensibly for players
2603 if (!is_player ())
2730 return; 2604 return;
2731 2605
2732 if (env) 2606 // find old force, or create new one
2733 { 2607 object *force = force_find (shstr_noise_force);
2734 if (object *pl = in_player ()) 2608
2735 pl->contr->play_sound (sound); 2609 if (force)
2736 } 2610 force->speed_left = -1.f; // patch old speed up
2737 else 2611 else
2738 map->play_sound (sound, x, y); 2612 {
2739} 2613 force = archetype::get (shstr_noise_force);
2740 2614
2615 force->slaying = shstr_noise_force;
2616 force->stats.food = 1;
2617 force->speed_left = -1.f;
2618
2619 force->set_speed (1.f / 4.f);
2620 force->flag [FLAG_IS_USED_UP] = true;
2621 force->flag [FLAG_APPLIED] = true;
2622
2623 insert (force);
2624 }
2625}
2626

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines