[ViewVC] Diff of: cvs/deliantra/server/common/object.C

Comparing deliantra/server/common/object.C (file contents):
Revision 1.273 by root, Sat Dec 27 04:15:56 2008 UTC vs.
Revision 1.280 by root, Thu Jan 8 19:23:44 2009 UTC

 void
 object::do_destroy ()
 {
   if (flag [FLAG_IS_LINKED])
-    remove_button_link (this);
+    remove_link ();
   if (flag [FLAG_FRIENDLY])
     remove_friendly_object (this);
   remove ();
   /* Ideally, the caller figures this out.  However, it complicates a lot
    * of areas of callers (eg, anything that uses find_free_spot would now
    * need extra work
    */
+  maptile *newmap = m;
-  if (!xy_normalise (m, op->x, op->y))
+  if (!xy_normalise (newmap, op->x, op->y))
     {
       op->head_ ()->destroy ();// remove head_ once all tail object destroyers found
       return 0;
     }
     if (!insert_ob_in_map (more, m, originator, flag))
       return 0;
   CLEAR_FLAG (op, FLAG_REMOVED);
-  op->map = m;
+  op->map = newmap;
   mapspace &ms = op->ms ();
   /* this has to be done after we translate the coordinates.
    */
   if (op->nrof && !(flag & INS_NO_MERGE))
 /* this function inserts an object in the map, but if it
  * finds an object of its own type, it'll remove that one first.
  * op is the object to insert it under: supplies x and the map.
  */
 void
-replace_insert_ob_in_map (const char *arch_string, object *op)
+replace_insert_ob_in_map (shstr_tmp archname, object *op)
 {
   /* first search for itself and remove any old instances */
   for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
-    if (!strcmp (tmp->arch->archname, arch_string))       /* same archetype */
+    if (tmp->arch->archname == archname)       /* same archetype */
       tmp->destroy ();
-  object *tmp = arch_to_object (archetype::find (arch_string));
+  object *tmp = arch_to_object (archetype::find (archname));
   tmp->x = op->x;
   tmp->y = op->y;
   insert_ob_in_map (tmp, op->map, op, 0);
  * there is capable of.
  */
 int
 find_dir (maptile *m, int x, int y, object *exclude)
 {
-  int i, max = SIZEOFFREE, mflags;
+  int max = SIZEOFFREE, mflags;
-  sint16 nx, ny;
-  object *tmp;
-  maptile *mp;
-  MoveType blocked, move_type;
+  MoveType move_type;
   if (exclude && exclude->head_ () != exclude)
     {
       exclude = exclude->head;
       move_type = exclude->move_type;
     {
       /* If we don't have anything, presume it can use all movement types. */
       move_type = MOVE_ALL;
     }
-  for (i = 1; i < max; i++)
+  for (int i = 1; i < max; i++)
     {
-      mp = m;
+      mapxy pos (m, x, y);
-      nx = x + freearr_x[i];
+      pos.move (i);
-      ny = y + freearr_y[i];
-      mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);
+      if (!pos.normalise ())
-      if (mflags & P_OUT_OF_MAP)
         max = maxfree[i];
       else
         {
-          mapspace &ms = mp->at (nx, ny);
+          mapspace &ms = *pos;
-          blocked = ms.move_block;
-          if ((move_type & blocked) == move_type)
+          if ((move_type & ms.move_block) == move_type)
-            max = maxfree[i];
+            max = maxfree [i];
-          else if (mflags & P_IS_ALIVE)
+          else if (ms.flags () & P_IS_ALIVE)
             {
-              for (tmp = ms.bot; tmp; tmp = tmp->above)
+              for (object *tmp = ms.bot; tmp; tmp = tmp->above)
                 if ((tmp->flag [FLAG_MONSTER] || tmp->is_player ())
                     && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))
-                  break;
-              if (tmp)
-                return freedir[i];
+                  return freedir [i];
             }
         }
     }
   return 0;
  * This basically means that if direction is 15, then it could either go
  * direction 4, 14, or 16 to get back to where we are.
  * Moved from spell_util.c to object.c with the other related direction
  * functions.
  */
-int reduction_dir[SIZEOFFREE][3] = {
+const int reduction_dir[SIZEOFFREE][3] = {
   {0, 0, 0},                    /* 0 */
   {0, 0, 0},                    /* 1 */
   {0, 0, 0},                    /* 2 */
   {0, 0, 0},                    /* 3 */
   {0, 0, 0},                    /* 4 */
       return tmp;
   return 0;
 }
-const shstr &
+shstr_tmp
-object::kv_get (const shstr &key) const
+object::kv_get (shstr_tmp key) const
 {
   for (key_value *kv = key_values; kv; kv = kv->next)
     if (kv->key == key)
       return kv->value;
-  return shstr_null;
+  return shstr ();
 }
 void
-object::kv_set (const shstr &key, const shstr &value)
+object::kv_set (shstr_tmp key, shstr_tmp value)
 {
   for (key_value *kv = key_values; kv; kv = kv->next)
     if (kv->key == key)
       {
         kv->value = value;
   key_values = kv;
 }
 void
-object::kv_del (const shstr &key)
+object::kv_del (shstr_tmp key)
 {
   for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
     if ((*kvp)->key == key)
       {
         key_value *kv = *kvp;
 //  else if (!old_container->env && contr && contr->ns)
 //    contr->ns->floorbox_reset ();
 }
 object *
-object::force_find (const shstr name)
+object::force_find (shstr_tmp name)
 {
   /* cycle through his inventory to look for the MARK we want to
    * place
    */
   for (object *tmp = inv; tmp; tmp = tmp->below)
   return 0;
 }
 object *
-object::force_add (const shstr name, int duration)
+object::force_add (shstr_tmp name, int duration)
 {
   if (object *force = force_find (name))
     force->destroy ();
   object *force = get_archetype (FORCE_NAME);
   return insert (force);
 }
 void
-object::play_sound (faceidx sound)
+object::play_sound (faceidx sound) const
 {
   if (!sound)
     return;
-  if (flag [FLAG_REMOVED])
+  if (is_on_map ())
-    return;
-  if (env)
-    {
-      if (object *pl = in_player ())
-        pl->contr->play_sound (sound);
-    }
-  else
     map->play_sound (sound, x, y);
+  else if (object *pl = in_player ())
+    pl->contr->play_sound (sound);
+}
+void
+object::say_msg (const char *msg) const
+{
+  if (is_on_map ())
+    map->say_msg (msg, x, y);
+  else if (object *pl = in_player ())
+    pl->contr->play_sound (sound);
 }
 void
 object::make_noise ()
 {

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing deliantra/server/common/object.C (file contents): Revision 1.273 by root, Sat Dec 27 04:15:56 2008 UTC vs. Revision 1.280 by root, Thu Jan 8 19:23:44 2009 UTC

Diff Legend

Comparing deliantra/server/common/object.C (file contents):
Revision 1.273 by root, Sat Dec 27 04:15:56 2008 UTC vs.
Revision 1.280 by root, Thu Jan 8 19:23:44 2009 UTC