ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.233 by root, Tue May 6 18:47:32 2008 UTC vs.
Revision 1.288 by root, Sat Oct 3 22:36:08 2009 UTC

1/* 1/*
2 * This file is part of Deliantra, the Roguelike Realtime MMORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team 4 * Copyright (©) 2005,2006,2007,2008,2009 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 * 7 *
8 * Deliantra is free software: you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify
9 * it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
32#include <bitset> 32#include <bitset>
33 33
34UUID UUID::cur; 34UUID UUID::cur;
35static uint64_t seq_next_save; 35static uint64_t seq_next_save;
36static const uint64 UUID_GAP = 1<<19; 36static const uint64 UUID_GAP = 1<<19;
37uint32_t mapspace::smellcount = 10000;
37 38
38objectvec objects; 39objectvec objects;
39activevec actives; 40activevec actives;
40 41
41short freearr_x[SIZEOFFREE] = { 42short freearr_x[SIZEOFFREE] = {
186 || ob1->speed != ob2->speed 187 || ob1->speed != ob2->speed
187 || ob1->value != ob2->value 188 || ob1->value != ob2->value
188 || ob1->name != ob2->name) 189 || ob1->name != ob2->name)
189 return 0; 190 return 0;
190 191
191 /* Do not merge objects if nrof would overflow. First part checks 192 /* Do not merge objects if nrof would overflow, assume nrof
192 * for unsigned overflow (2c), second part checks whether the result 193 * is always 0 .. 2**31-1 */
193 * would fit into a 32 bit signed int, which is often used to hold 194 if (ob1->nrof > 0x7fffffff - ob2->nrof)
194 * nrof values.
195 */
196 if (~ob1->nrof < ob2->nrof || ob1->nrof + ob2->nrof > (1UL << 31))
197 return 0; 195 return 0;
198 196
199 /* If the objects have been identified, set the BEEN_APPLIED flag. 197 /* If the objects have been identified, set the BEEN_APPLIED flag.
200 * This is to the comparison of the flags below will be OK. We 198 * This is to the comparison of the flags below will be OK. We
201 * just can't ignore the been applied or identified flags, as they 199 * just can't ignore the been applied or identified flags, as they
206 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 204 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
207 205
208 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 206 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
209 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 207 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
210 208
211 if (ob1->arch->name != ob2->arch->name 209 if (ob1->arch->archname != ob2->arch->archname
212 || ob1->name != ob2->name 210 || ob1->name != ob2->name
213 || ob1->title != ob2->title 211 || ob1->title != ob2->title
214 || ob1->msg != ob2->msg 212 || ob1->msg != ob2->msg
215 || ob1->weight != ob2->weight 213 || ob1->weight != ob2->weight
216 || ob1->attacktype != ob2->attacktype 214 || ob1->attacktype != ob2->attacktype
217 || ob1->magic != ob2->magic 215 || ob1->magic != ob2->magic
218 || ob1->slaying != ob2->slaying 216 || ob1->slaying != ob2->slaying
219 || ob1->skill != ob2->skill 217 || ob1->skill != ob2->skill
220 || ob1->value != ob2->value 218 || ob1->value != ob2->value
221 || ob1->animation_id != ob2->animation_id 219 || ob1->animation_id != ob2->animation_id
220 || (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependent on each other
222 || ob1->client_type != ob2->client_type 221 || ob1->client_type != ob2->client_type
223 || ob1->materialname != ob2->materialname 222 || ob1->materialname != ob2->materialname
224 || ob1->lore != ob2->lore 223 || ob1->lore != ob2->lore
225 || ob1->subtype != ob2->subtype 224 || ob1->subtype != ob2->subtype
226 || ob1->move_type != ob2->move_type 225 || ob1->move_type != ob2->move_type
234 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats))) 233 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
235 return 0; 234 return 0;
236 235
237 if ((ob1->flag ^ ob2->flag) 236 if ((ob1->flag ^ ob2->flag)
238 .reset (FLAG_INV_LOCKED) 237 .reset (FLAG_INV_LOCKED)
239 .reset (FLAG_CLIENT_SENT)
240 .reset (FLAG_REMOVED) 238 .reset (FLAG_REMOVED)
241 .any ()) 239 .any ())
242 return 0; 240 return 0;
243 241
244 /* This is really a spellbook check - we should in general 242 /* This is really a spellbook check - we should in general
326 { 324 {
327 // see if we are in a container of sorts 325 // see if we are in a container of sorts
328 if (env) 326 if (env)
329 { 327 {
330 // the player inventory itself is always visible 328 // the player inventory itself is always visible
331 if (env->type == PLAYER) 329 if (env->is_player ())
332 return env; 330 return env;
333 331
334 // else a player could have our env open 332 // else a player could have our env open
335 object *envest = env->outer_env (); 333 object *envest = env->outer_env_or_self ();
336 334
337 // the player itself is always on a map, so we will find him here 335 // the player itself is always on a map, so we will find him here
338 // even if our inv is in a player. 336 // even if our inv is in a player.
339 if (envest->is_on_map ()) 337 if (envest->is_on_map ())
340 if (object *pl = envest->ms ().player ()) 338 if (object *pl = envest->ms ().player ())
344 else 342 else
345 { 343 {
346 // maybe there is a player standing on the same mapspace 344 // maybe there is a player standing on the same mapspace
347 // this will catch the case where "this" is a player 345 // this will catch the case where "this" is a player
348 if (object *pl = ms ().player ()) 346 if (object *pl = ms ().player ())
347 if ((!pl->container && pl->contr->ns && !pl->contr->ns->update_look)
349 if (!pl->container || this == pl->container) 348 || this == pl->container)
350 return pl; 349 return pl;
351 } 350 }
352 } 351 }
353 352
354 return 0; 353 return 0;
406 op->update_weight (); 405 op->update_weight ();
407 406
408 sum += op->total_weight (); 407 sum += op->total_weight ();
409 } 408 }
410 409
411 sum = weight_adjust (this, sum); 410 sum = weight_adjust_for (this, sum);
412 411
413 if (sum != carrying) 412 if (sum != carrying)
414 { 413 {
415 carrying = sum; 414 carrying = sum;
416 415
478 */ 477 */
479object * 478object *
480find_object_name (const char *str) 479find_object_name (const char *str)
481{ 480{
482 shstr_cmp str_ (str); 481 shstr_cmp str_ (str);
483 object *op;
484 482
483 if (str_)
485 for_all_objects (op) 484 for_all_objects (op)
486 if (op->name == str_) 485 if (op->name == str_)
487 break; 486 return op;
488 487
489 return op; 488 return 0;
490} 489}
491 490
492/* 491/*
493 * Sets the owner and sets the skill and exp pointers to owner's current 492 * Sets the owner and sets the skill and exp pointers to owner's current
494 * skill and experience objects. 493 * skill and experience objects.
556 update_stats (); 555 update_stats ();
557 556
558 new_draw_info_format (NDI_UNIQUE, 0, this, 557 new_draw_info_format (NDI_UNIQUE, 0, this,
559 "You try to balance all your items at once, " 558 "You try to balance all your items at once, "
560 "but the %s is just too much for your body. " 559 "but the %s is just too much for your body. "
561 "[You need to unapply some items first.]", &ob->name); 560 "[You need to unapply some items first - use the 'body' command to see "
561 "how many items you cna wera on a specific body part.]", &ob->name);
562 return false; 562 return false;
563 } 563 }
564 564
565 //new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name); 565 //new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name);
566 } 566 }
638 } 638 }
639 639
640 if (speed < 0) 640 if (speed < 0)
641 dst->speed_left -= rndm (); 641 dst->speed_left -= rndm ();
642 642
643 dst->set_speed (dst->speed); 643 dst->activate ();
644} 644}
645 645
646void 646void
647object::instantiate () 647object::instantiate ()
648{ 648{
760 else if (action == UP_OBJ_INSERT) 760 else if (action == UP_OBJ_INSERT)
761 { 761 {
762 // this is likely overkill, TODO: revisit (schmorp) 762 // this is likely overkill, TODO: revisit (schmorp)
763 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW)) 763 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
764 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC)) 764 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
765 || (op->type == PLAYER && !(m.flags_ & P_PLAYER)) 765 || (op->is_player () && !(m.flags_ & P_PLAYER))
766 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE)) 766 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
767 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE)) 767 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
768 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC)) 768 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
769 || (m.move_on | op->move_on ) != m.move_on 769 || (m.move_on | op->move_on ) != m.move_on
770 || (m.move_off | op->move_off ) != m.move_off 770 || (m.move_off | op->move_off ) != m.move_off
771 || (m.move_slow | op->move_slow) != m.move_slow 771 || (m.move_slow | op->move_slow) != m.move_slow
772 /* This isn't perfect, but I don't expect a lot of objects to 772 /* This isn't perfect, but I don't expect a lot of objects to
773 * to have move_allow right now. 773 * have move_allow right now.
774 */ 774 */
775 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block 775 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
776 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp) 776 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
777 m.flags_ = 0; 777 m.invalidate ();
778 } 778 }
779 /* if the object is being removed, we can't make intelligent 779 /* if the object is being removed, we can't make intelligent
780 * decisions, because remove_ob can't really pass the object 780 * decisions, because remove_ob can't really pass the object
781 * that is being removed. 781 * that is being removed.
782 */ 782 */
783 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 783 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
784 m.flags_ = 0; 784 m.invalidate ();
785 else if (action == UP_OBJ_FACE) 785 else if (action == UP_OBJ_FACE)
786 /* Nothing to do for that case */ ; 786 /* Nothing to do for that case */ ;
787 else 787 else
788 LOG (llevError, "update_object called with invalid action: %d\n", action); 788 LOG (llevError, "update_object called with invalid action: %d\n", action);
789 789
793 793
794object::object () 794object::object ()
795{ 795{
796 SET_FLAG (this, FLAG_REMOVED); 796 SET_FLAG (this, FLAG_REMOVED);
797 797
798 expmul = 1.0; 798 //expmul = 1.0; declared const for the time being
799 face = blank_face; 799 face = blank_face;
800} 800}
801 801
802object::~object () 802object::~object ()
803{ 803{
833 /* If already on active list, don't do anything */ 833 /* If already on active list, don't do anything */
834 if (active) 834 if (active)
835 return; 835 return;
836 836
837 if (has_active_speed ()) 837 if (has_active_speed ())
838 {
839 if (flag [FLAG_FREED])
840 LOG (llevError | logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
841
838 actives.insert (this); 842 actives.insert (this);
843 }
839} 844}
840 845
841void 846void
842object::activate_recursive () 847object::activate_recursive ()
843{ 848{
904 * drop on that space. 909 * drop on that space.
905 */ 910 */
906 if (!drop_to_ground 911 if (!drop_to_ground
907 || !map 912 || !map
908 || map->in_memory != MAP_ACTIVE 913 || map->in_memory != MAP_ACTIVE
909 || map->nodrop 914 || map->no_drop
910 || ms ().move_block == MOVE_ALL) 915 || ms ().move_block == MOVE_ALL)
911 { 916 {
912 while (inv) 917 while (inv)
913 {
914 inv->destroy_inv (false);
915 inv->destroy (); 918 inv->destroy ();
916 }
917 } 919 }
918 else 920 else
919 { /* Put objects in inventory onto this space */ 921 { /* Put objects in inventory onto this space */
920 while (inv) 922 while (inv)
921 { 923 {
925 || op->flag [FLAG_NO_DROP] 927 || op->flag [FLAG_NO_DROP]
926 || op->type == RUNE 928 || op->type == RUNE
927 || op->type == TRAP 929 || op->type == TRAP
928 || op->flag [FLAG_IS_A_TEMPLATE] 930 || op->flag [FLAG_IS_A_TEMPLATE]
929 || op->flag [FLAG_DESTROY_ON_DEATH]) 931 || op->flag [FLAG_DESTROY_ON_DEATH])
930 op->destroy (true); 932 op->destroy ();
931 else 933 else
932 map->insert (op, x, y); 934 map->insert (op, x, y);
933 } 935 }
934 } 936 }
935} 937}
943 945
944static struct freed_map : maptile 946static struct freed_map : maptile
945{ 947{
946 freed_map () 948 freed_map ()
947 { 949 {
948 path = "<freed objects map>"; 950 path = "<freed objects map>";
949 name = "/internal/freed_objects_map"; 951 name = "/internal/freed_objects_map";
950 width = 3; 952 width = 3;
951 height = 3; 953 height = 3;
952 nodrop = 1; 954 no_drop = 1;
955 no_reset = 1;
953 956
954 alloc (); 957 alloc ();
955 in_memory = MAP_ACTIVE; 958 in_memory = MAP_ACTIVE;
956 } 959 }
957 960
963 966
964void 967void
965object::do_destroy () 968object::do_destroy ()
966{ 969{
967 if (flag [FLAG_IS_LINKED]) 970 if (flag [FLAG_IS_LINKED])
968 remove_button_link (this); 971 remove_link ();
969 972
970 if (flag [FLAG_FRIENDLY]) 973 if (flag [FLAG_FRIENDLY])
971 remove_friendly_object (this); 974 remove_friendly_object (this);
972 975
973 remove (); 976 remove ();
998 attacked_by = 0; 1001 attacked_by = 0;
999 current_weapon = 0; 1002 current_weapon = 0;
1000} 1003}
1001 1004
1002void 1005void
1003object::destroy (bool destroy_inventory) 1006object::destroy ()
1004{ 1007{
1005 if (destroyed ()) 1008 if (destroyed ())
1006 return; 1009 return;
1007 1010
1008 if (!is_head () && !head->destroyed ()) 1011 if (!is_head () && !head->destroyed ())
1009 { 1012 {
1010 LOG (llevError | logBacktrace, "tried to destroy the tail of an object"); 1013 LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
1011 head->destroy (destroy_inventory); 1014 head->destroy ();
1012 return; 1015 return;
1013 } 1016 }
1014 1017
1015 destroy_inv (!destroy_inventory); 1018 destroy_inv (false);
1016 1019
1017 if (is_head ()) 1020 if (is_head ())
1018 if (sound_destroy) 1021 if (sound_destroy)
1019 play_sound (sound_destroy); 1022 play_sound (sound_destroy);
1020 else if (flag [FLAG_MONSTER]) 1023 else if (flag [FLAG_MONSTER])
1057 esrv_del_item (pl->contr, count); 1060 esrv_del_item (pl->contr, count);
1058 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed 1061 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
1059 1062
1060 adjust_weight (env, -total_weight ()); 1063 adjust_weight (env, -total_weight ());
1061 1064
1062 *(above ? &above->below : &env->inv) = below; 1065 object *pl = in_player ();
1063
1064 if (below)
1065 below->above = above;
1066 1066
1067 /* we set up values so that it could be inserted into 1067 /* we set up values so that it could be inserted into
1068 * the map, but we don't actually do that - it is up 1068 * the map, but we don't actually do that - it is up
1069 * to the caller to decide what we want to do. 1069 * to the caller to decide what we want to do.
1070 */ 1070 */
1071 map = env->map; 1071 map = env->map;
1072 x = env->x; 1072 x = env->x;
1073 y = env->y; 1073 y = env->y;
1074
1075 // make sure cmov optimisation is applicable
1076 *(above ? &above->below : &env->inv) = below;
1077 *(below ? &below->above : &above ) = above; // &above is just a dummy
1078
1074 above = 0; 1079 above = 0;
1075 below = 0; 1080 below = 0;
1076 env = 0; 1081 env = 0;
1077 1082
1078 /* NO_FIX_PLAYER is set when a great many changes are being 1083 /* NO_FIX_PLAYER is set when a great many changes are being
1079 * made to players inventory. If set, avoiding the call 1084 * made to players inventory. If set, avoiding the call
1080 * to save cpu time. 1085 * to save cpu time.
1081 */ 1086 */
1082 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1087 if (pl)
1088 if (pl->is_player () && (glow_radius || !QUERY_FLAG (pl, FLAG_NO_FIX_PLAYER)))
1089 {
1083 otmp->update_stats (); 1090 pl->update_stats ();
1091
1092 if (glow_radius && pl->is_on_map ())
1093 update_all_los (pl->map, pl->x, pl->y);
1094 }
1084 } 1095 }
1085 else if (map) 1096 else if (map)
1086 { 1097 {
1087 map->dirty = true; 1098 map->dirty = true;
1088 mapspace &ms = this->ms (); 1099 mapspace &ms = this->ms ();
1089 1100
1090 if (object *pl = ms.player ()) 1101 if (object *pl = ms.player ())
1091 { 1102 {
1092 if (type == PLAYER) // this == pl(!) 1103 if (is_player ())
1093 { 1104 {
1105 if (!flag [FLAG_WIZPASS])
1106 ms.smell = ++mapspace::smellcount; // remember the smell of the player
1107
1094 // leaving a spot always closes any open container on the ground 1108 // leaving a spot always closes any open container on the ground
1095 if (container && !container->env) 1109 if (container && !container->env)
1096 // this causes spurious floorbox updates, but it ensures 1110 // this causes spurious floorbox updates, but it ensures
1097 // that the CLOSE event is being sent. 1111 // that the CLOSE event is being sent.
1098 close_container (); 1112 close_container ();
1108 1122
1109 esrv_del_item (pl->contr, count); 1123 esrv_del_item (pl->contr, count);
1110 } 1124 }
1111 1125
1112 /* link the object above us */ 1126 /* link the object above us */
1113 if (above) 1127 // re-link, make sure compiler can easily use cmove
1114 above->below = below; 1128 *(above ? &above->below : &ms.top) = below;
1115 else 1129 *(below ? &below->above : &ms.bot) = above;
1116 ms.top = below; /* we were top, set new top */
1117
1118 /* Relink the object below us, if there is one */
1119 if (below)
1120 below->above = above;
1121 else
1122 {
1123 /* Nothing below, which means we need to relink map object for this space
1124 * use translated coordinates in case some oddness with map tiling is
1125 * evident
1126 */
1127 if (GET_MAP_OB (map, x, y) != this)
1128 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1129
1130 ms.bot = above; /* goes on above it. */
1131 }
1132 1130
1133 above = 0; 1131 above = 0;
1134 below = 0; 1132 below = 0;
1133
1134 ms.invalidate ();
1135 1135
1136 if (map->in_memory == MAP_SAVING) 1136 if (map->in_memory == MAP_SAVING)
1137 return; 1137 return;
1138 1138
1139 int check_walk_off = !flag [FLAG_NO_APPLY]; 1139 int check_walk_off = !flag [FLAG_NO_APPLY];
1172 } 1172 }
1173 1173
1174 last = tmp; 1174 last = tmp;
1175 } 1175 }
1176 1176
1177 /* last == NULL if there are no objects on this space */ 1177 if (affects_los ())
1178 //TODO: this makes little sense, why only update the topmost object?
1179 if (!last)
1180 map->at (x, y).flags_ = 0;
1181 else
1182 update_object (last, UP_OBJ_REMOVE);
1183
1184 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1185 update_all_los (map, x, y); 1178 update_all_los (map, x, y);
1186 } 1179 }
1187} 1180}
1188 1181
1189/* 1182/*
1213 esrv_update_item (UPD_NROF, pl, top); 1206 esrv_update_item (UPD_NROF, pl, top);
1214 1207
1215 op->weight = 0; // cancel the addition above 1208 op->weight = 0; // cancel the addition above
1216 op->carrying = 0; // must be 0 already 1209 op->carrying = 0; // must be 0 already
1217 1210
1218 op->destroy (1); 1211 op->destroy ();
1219 1212
1220 return top; 1213 return top;
1221 } 1214 }
1222 1215
1223 return 0; 1216 return 0;
1251 * job preparing multi-part monsters. 1244 * job preparing multi-part monsters.
1252 */ 1245 */
1253object * 1246object *
1254insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1247insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1255{ 1248{
1249 op->remove ();
1250
1256 for (object *tmp = op->head_ (); tmp; tmp = tmp->more) 1251 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1257 { 1252 {
1258 tmp->x = x + tmp->arch->x; 1253 tmp->x = x + tmp->arch->x;
1259 tmp->y = y + tmp->arch->y; 1254 tmp->y = y + tmp->arch->y;
1260 } 1255 }
1283 * just 'op' otherwise 1278 * just 'op' otherwise
1284 */ 1279 */
1285object * 1280object *
1286insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1281insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1287{ 1282{
1288 assert (!op->flag [FLAG_FREED]);
1289
1290 op->remove (); 1283 op->remove ();
1284
1285 if (m == &freed_map)//D TODO: remove soon
1286 {//D
1287 LOG (llevError | logBacktrace, "tries to insret object on freed objects map: %s", op->debug_desc ());//D
1288 }//D
1291 1289
1292 /* Ideally, the caller figures this out. However, it complicates a lot 1290 /* Ideally, the caller figures this out. However, it complicates a lot
1293 * of areas of callers (eg, anything that uses find_free_spot would now 1291 * of areas of callers (eg, anything that uses find_free_spot would now
1294 * need extra work 1292 * need extra work
1295 */ 1293 */
1294 maptile *newmap = m;
1296 if (!xy_normalise (m, op->x, op->y)) 1295 if (!xy_normalise (newmap, op->x, op->y))
1297 { 1296 {
1298 op->head_ ()->destroy (1);// remove head_ once all tail object destroyers found 1297 op->head_ ()->destroy ();// remove head_ once all tail object destroyers found
1299 return 0; 1298 return 0;
1300 } 1299 }
1301 1300
1302 if (object *more = op->more) 1301 if (object *more = op->more)
1303 if (!insert_ob_in_map (more, m, originator, flag)) 1302 if (!insert_ob_in_map (more, m, originator, flag))
1304 return 0; 1303 return 0;
1305 1304
1306 CLEAR_FLAG (op, FLAG_REMOVED); 1305 op->flag [FLAG_REMOVED] = false;
1307 1306 op->env = 0;
1308 op->map = m; 1307 op->map = newmap;
1308
1309 mapspace &ms = op->ms (); 1309 mapspace &ms = op->ms ();
1310 1310
1311 /* this has to be done after we translate the coordinates. 1311 /* this has to be done after we translate the coordinates.
1312 */ 1312 */
1313 if (op->nrof && !(flag & INS_NO_MERGE)) 1313 if (op->nrof && !(flag & INS_NO_MERGE))
1314 for (object *tmp = ms.bot; tmp; tmp = tmp->above) 1314 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1315 if (object::can_merge (op, tmp)) 1315 if (object::can_merge (op, tmp))
1316 { 1316 {
1317 // TODO: we atcually want to update tmp, not op, 1317 // TODO: we actually want to update tmp, not op,
1318 // but some caller surely breaks when we return tmp 1318 // but some caller surely breaks when we return tmp
1319 // from here :/ 1319 // from here :/
1320 op->nrof += tmp->nrof; 1320 op->nrof += tmp->nrof;
1321 tmp->destroy (1); 1321 tmp->destroy ();
1322 } 1322 }
1323 1323
1324 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1324 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1325 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1325 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1326 1326
1333 { 1333 {
1334 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n"); 1334 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1335 abort (); 1335 abort ();
1336 } 1336 }
1337 1337
1338 if (!originator->is_on_map ())
1339 {
1340 LOG (llevError, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
1341 op->debug_desc (), originator->debug_desc ());
1342 abort ();
1343 }
1344
1338 op->above = originator; 1345 op->above = originator;
1339 op->below = originator->below; 1346 op->below = originator->below;
1340
1341 if (op->below)
1342 op->below->above = op;
1343 else
1344 ms.bot = op;
1345
1346 /* since *below* originator, no need to update top */
1347 originator->below = op; 1347 originator->below = op;
1348
1349 *(op->below ? &op->below->above : &ms.bot) = op;
1348 } 1350 }
1349 else 1351 else
1350 { 1352 {
1351 object *top, *floor = NULL; 1353 object *floor = 0;
1352 1354 object *top = ms.top;
1353 top = ms.bot;
1354 1355
1355 /* If there are other objects, then */ 1356 /* If there are other objects, then */
1356 if (top) 1357 if (top)
1357 { 1358 {
1358 object *last = 0;
1359
1360 /* 1359 /*
1361 * If there are multiple objects on this space, we do some trickier handling. 1360 * If there are multiple objects on this space, we do some trickier handling.
1362 * We've already dealt with merging if appropriate. 1361 * We've already dealt with merging if appropriate.
1363 * Generally, we want to put the new object on top. But if 1362 * Generally, we want to put the new object on top. But if
1364 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last 1363 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
1367 * once we get to them. This reduces the need to traverse over all of 1366 * once we get to them. This reduces the need to traverse over all of
1368 * them when adding another one - this saves quite a bit of cpu time 1367 * them when adding another one - this saves quite a bit of cpu time
1369 * when lots of spells are cast in one area. Currently, it is presumed 1368 * when lots of spells are cast in one area. Currently, it is presumed
1370 * that flying non pickable objects are spell objects. 1369 * that flying non pickable objects are spell objects.
1371 */ 1370 */
1372 for (top = ms.bot; top; top = top->above) 1371 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1373 { 1372 {
1374 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1373 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) || QUERY_FLAG (tmp, FLAG_OVERLAY_FLOOR))
1375 floor = top; 1374 floor = tmp;
1376 1375
1377 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1376 if (QUERY_FLAG (tmp, FLAG_NO_PICK) && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (tmp, FLAG_IS_FLOOR))
1378 { 1377 {
1379 /* We insert above top, so we want this object below this */ 1378 /* We insert above top, so we want this object below this */
1380 top = top->below; 1379 top = tmp->below;
1381 break; 1380 break;
1382 } 1381 }
1383 1382
1384 last = top; 1383 top = tmp;
1385 } 1384 }
1386
1387 /* Don't want top to be NULL, so set it to the last valid object */
1388 top = last;
1389 1385
1390 /* We let update_position deal with figuring out what the space 1386 /* We let update_position deal with figuring out what the space
1391 * looks like instead of lots of conditions here. 1387 * looks like instead of lots of conditions here.
1392 * makes things faster, and effectively the same result. 1388 * makes things faster, and effectively the same result.
1393 */ 1389 */
1400 */ 1396 */
1401 if (!(flag & INS_ON_TOP) 1397 if (!(flag & INS_ON_TOP)
1402 && ms.flags () & P_BLOCKSVIEW 1398 && ms.flags () & P_BLOCKSVIEW
1403 && (op->face && !faces [op->face].visibility)) 1399 && (op->face && !faces [op->face].visibility))
1404 { 1400 {
1401 object *last;
1402
1405 for (last = top; last != floor; last = last->below) 1403 for (last = top; last != floor; last = last->below)
1406 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1404 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1407 break; 1405 break;
1408 1406
1409 /* Check to see if we found the object that blocks view, 1407 /* Check to see if we found the object that blocks view,
1417 } /* If objects on this space */ 1415 } /* If objects on this space */
1418 1416
1419 if (flag & INS_ABOVE_FLOOR_ONLY) 1417 if (flag & INS_ABOVE_FLOOR_ONLY)
1420 top = floor; 1418 top = floor;
1421 1419
1422 /* Top is the object that our object (op) is going to get inserted above. 1420 // insert object above top, or bottom-most if top = 0
1423 */
1424
1425 /* First object on this space */
1426 if (!top) 1421 if (!top)
1427 { 1422 {
1423 op->below = 0;
1428 op->above = ms.bot; 1424 op->above = ms.bot;
1429
1430 if (op->above)
1431 op->above->below = op;
1432
1433 op->below = 0;
1434 ms.bot = op; 1425 ms.bot = op;
1426
1427 *(op->above ? &op->above->below : &ms.top) = op;
1435 } 1428 }
1436 else 1429 else
1437 { /* get inserted into the stack above top */ 1430 {
1438 op->above = top->above; 1431 op->above = top->above;
1439
1440 if (op->above)
1441 op->above->below = op; 1432 top->above = op;
1442 1433
1443 op->below = top; 1434 op->below = top;
1444 top->above = op; 1435 *(op->above ? &op->above->below : &ms.top) = op;
1445 } 1436 }
1437 }
1446 1438
1447 if (!op->above) 1439 if (op->is_player ())
1448 ms.top = op;
1449 } /* else not INS_BELOW_ORIGINATOR */
1450
1451 if (op->type == PLAYER)
1452 { 1440 {
1453 op->contr->do_los = 1; 1441 op->contr->do_los = 1;
1454 ++op->map->players; 1442 ++op->map->players;
1455 op->map->touch (); 1443 op->map->touch ();
1456 } 1444 }
1471 * be far away from this change and not affected in any way - 1459 * be far away from this change and not affected in any way -
1472 * this should get redone to only look for players within range, 1460 * this should get redone to only look for players within range,
1473 * or just updating the P_UPTODATE for spaces within this area 1461 * or just updating the P_UPTODATE for spaces within this area
1474 * of effect may be sufficient. 1462 * of effect may be sufficient.
1475 */ 1463 */
1476 if (op->map->darkness && (op->glow_radius != 0)) 1464 if (op->affects_los ())
1465 {
1466 op->ms ().invalidate ();
1477 update_all_los (op->map, op->x, op->y); 1467 update_all_los (op->map, op->x, op->y);
1468 }
1478 1469
1479 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1470 /* updates flags (blocked, alive, no magic, etc) for this map space */
1480 update_object (op, UP_OBJ_INSERT); 1471 update_object (op, UP_OBJ_INSERT);
1481 1472
1482 INVOKE_OBJECT (INSERT, op); 1473 INVOKE_OBJECT (INSERT, op);
1489 * blocked() and wall() work properly), and these flags are updated by 1480 * blocked() and wall() work properly), and these flags are updated by
1490 * update_object(). 1481 * update_object().
1491 */ 1482 */
1492 1483
1493 /* if this is not the head or flag has been passed, don't check walk on status */ 1484 /* if this is not the head or flag has been passed, don't check walk on status */
1494 if (!(flag & INS_NO_WALK_ON) && op->head_ () == op) 1485 if (!(flag & INS_NO_WALK_ON) && op->is_head ())
1495 { 1486 {
1496 if (check_move_on (op, originator)) 1487 if (check_move_on (op, originator))
1497 return 0; 1488 return 0;
1498 1489
1499 /* If we are a multi part object, lets work our way through the check 1490 /* If we are a multi part object, lets work our way through the check
1510/* this function inserts an object in the map, but if it 1501/* this function inserts an object in the map, but if it
1511 * finds an object of its own type, it'll remove that one first. 1502 * finds an object of its own type, it'll remove that one first.
1512 * op is the object to insert it under: supplies x and the map. 1503 * op is the object to insert it under: supplies x and the map.
1513 */ 1504 */
1514void 1505void
1515replace_insert_ob_in_map (const char *arch_string, object *op) 1506replace_insert_ob_in_map (shstr_tmp archname, object *op)
1516{ 1507{
1517 /* first search for itself and remove any old instances */ 1508 /* first search for itself and remove any old instances */
1518 1509
1519 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above) 1510 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1520 if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */ 1511 if (tmp->arch->archname == archname) /* same archetype */
1521 tmp->destroy (1); 1512 tmp->destroy ();
1522 1513
1523 object *tmp = arch_to_object (archetype::find (arch_string)); 1514 object *tmp = arch_to_object (archetype::find (archname));
1524 1515
1525 tmp->x = op->x; 1516 tmp->x = op->x;
1526 tmp->y = op->y; 1517 tmp->y = op->y;
1527 1518
1528 insert_ob_in_map (tmp, op->map, op, 0); 1519 insert_ob_in_map (tmp, op->map, op, 0);
1550 if (!nr) 1541 if (!nr)
1551 return true; 1542 return true;
1552 1543
1553 nr = min (nr, nrof); 1544 nr = min (nr, nrof);
1554 1545
1546 if (nrof > nr)
1547 {
1555 nrof -= nr; 1548 nrof -= nr;
1556
1557 if (nrof)
1558 {
1559 adjust_weight (env, -weight * nr); // carrying == 0 1549 adjust_weight (env, -weight * max (1, nr)); // carrying == 0
1560 1550
1561 if (object *pl = visible_to ()) 1551 if (object *pl = visible_to ())
1562 esrv_update_item (UPD_NROF, pl, this); 1552 esrv_update_item (UPD_NROF, pl, this);
1563 1553
1564 return true; 1554 return true;
1565 } 1555 }
1566 else 1556 else
1567 { 1557 {
1568 destroy (1); 1558 destroy ();
1569 return false; 1559 return false;
1570 } 1560 }
1571} 1561}
1572 1562
1573/* 1563/*
1650 if (object *pl = tmp->visible_to ()) 1640 if (object *pl = tmp->visible_to ())
1651 esrv_update_item (UPD_NROF, pl, tmp); 1641 esrv_update_item (UPD_NROF, pl, tmp);
1652 1642
1653 adjust_weight (this, op->total_weight ()); 1643 adjust_weight (this, op->total_weight ());
1654 1644
1655 op->destroy (1); 1645 op->destroy ();
1656 op = tmp; 1646 op = tmp;
1657 goto inserted; 1647 goto inserted;
1658 } 1648 }
1659 1649
1660 op->owner = 0; // it's his/hers now. period. 1650 op->owner = 0; // it's his/hers now. period.
1678 1668
1679 adjust_weight (this, op->total_weight ()); 1669 adjust_weight (this, op->total_weight ());
1680 1670
1681inserted: 1671inserted:
1682 /* reset the light list and los of the players on the map */ 1672 /* reset the light list and los of the players on the map */
1683 if (op->glow_radius && map && map->darkness) 1673 if (op->glow_radius && is_on_map ())
1674 {
1675 update_stats ();
1684 update_all_los (map, x, y); 1676 update_all_los (map, x, y);
1685 1677 }
1678 else if (is_player () && !flag [FLAG_NO_FIX_PLAYER])
1686 // if this is a player's inventory, update stats 1679 // if this is a player's inventory, update stats
1687 if (type == PLAYER && !flag [FLAG_NO_FIX_PLAYER])
1688 update_stats (); 1680 update_stats ();
1689 1681
1690 INVOKE_OBJECT (INSERT, this); 1682 INVOKE_OBJECT (INSERT, this);
1691 1683
1692 return op; 1684 return op;
1713 * on top. 1705 * on top.
1714 */ 1706 */
1715int 1707int
1716check_move_on (object *op, object *originator) 1708check_move_on (object *op, object *originator)
1717{ 1709{
1710 if (QUERY_FLAG (op, FLAG_NO_APPLY))
1711 return 0;
1712
1718 object *tmp; 1713 object *tmp;
1719 maptile *m = op->map; 1714 maptile *m = op->map;
1720 int x = op->x, y = op->y; 1715 int x = op->x, y = op->y;
1721 1716
1722 MoveType move_on, move_slow, move_block; 1717 mapspace &ms = m->at (x, y);
1723 1718
1724 if (QUERY_FLAG (op, FLAG_NO_APPLY)) 1719 ms.update ();
1725 return 0;
1726 1720
1727 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y); 1721 MoveType move_on = ms.move_on;
1728 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y); 1722 MoveType move_slow = ms.move_slow;
1729 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y); 1723 MoveType move_block = ms.move_block;
1730 1724
1731 /* if nothing on this space will slow op down or be applied, 1725 /* if nothing on this space will slow op down or be applied,
1732 * no need to do checking below. have to make sure move_type 1726 * no need to do checking below. have to make sure move_type
1733 * is set, as lots of objects don't have it set - we treat that 1727 * is set, as lots of objects don't have it set - we treat that
1734 * as walking. 1728 * as walking.
1745 return 0; 1739 return 0;
1746 1740
1747 /* The objects have to be checked from top to bottom. 1741 /* The objects have to be checked from top to bottom.
1748 * Hence, we first go to the top: 1742 * Hence, we first go to the top:
1749 */ 1743 */
1750 1744 for (object *next, *tmp = ms.top; tmp; tmp = next)
1751 for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1752 {
1753 /* Trim the search when we find the first other spell effect
1754 * this helps performance so that if a space has 50 spell objects,
1755 * we don't need to check all of them.
1756 */
1757 if ((tmp->move_type & MOVE_FLY_LOW) && QUERY_FLAG (tmp, FLAG_NO_PICK))
1758 break;
1759 } 1745 {
1746 next = tmp->below;
1760 1747
1761 for (; tmp; tmp = tmp->below)
1762 {
1763 if (tmp == op) 1748 if (tmp == op)
1764 continue; /* Can't apply yourself */ 1749 continue; /* Can't apply yourself */
1765 1750
1766 /* Check to see if one of the movement types should be slowed down. 1751 /* Check to see if one of the movement types should be slowed down.
1767 * Second check makes sure that the movement types not being slowed 1752 * Second check makes sure that the movement types not being slowed
1772 if (!QUERY_FLAG (op, FLAG_WIZPASS)) 1757 if (!QUERY_FLAG (op, FLAG_WIZPASS))
1773 { 1758 {
1774 if ((!op->move_type && tmp->move_slow & MOVE_WALK) || 1759 if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
1775 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0)) 1760 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
1776 { 1761 {
1777
1778 float
1779 diff = tmp->move_slow_penalty * fabs (op->speed); 1762 float diff = tmp->move_slow_penalty * fabs (op->speed);
1780 1763
1781 if (op->type == PLAYER) 1764 if (op->is_player ())
1782 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) || 1765 if ((tmp->flag [FLAG_IS_HILLY ] && find_skill_by_number (op, SK_CLIMBING)) ||
1783 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN))) 1766 (tmp->flag [FLAG_IS_WOODED] && find_skill_by_number (op, SK_WOODSMAN)))
1784 diff /= 4.0; 1767 diff /= 4.0;
1785 1768
1786 op->speed_left -= diff; 1769 op->speed_left -= diff;
1787 } 1770 }
1788 } 1771 }
1994 * head of the object should correspond for the entire object. 1977 * head of the object should correspond for the entire object.
1995 */ 1978 */
1996 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block)) 1979 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))
1997 continue; 1980 continue;
1998 1981
1999 if (ob->blocked (m, pos.x, pos.y)) 1982 if (ob->blocked (pos.m, pos.x, pos.y))
2000 continue; 1983 continue;
2001 1984
2002 altern [index++] = i; 1985 altern [index++] = i;
2003 } 1986 }
2004 1987
2072 * there is capable of. 2055 * there is capable of.
2073 */ 2056 */
2074int 2057int
2075find_dir (maptile *m, int x, int y, object *exclude) 2058find_dir (maptile *m, int x, int y, object *exclude)
2076{ 2059{
2077 int i, max = SIZEOFFREE, mflags; 2060 int max = SIZEOFFREE, mflags;
2078
2079 sint16 nx, ny;
2080 object *tmp;
2081 maptile *mp;
2082
2083 MoveType blocked, move_type; 2061 MoveType move_type;
2084 2062
2085 if (exclude && exclude->head_ () != exclude) 2063 if (exclude && exclude->head_ () != exclude)
2086 { 2064 {
2087 exclude = exclude->head; 2065 exclude = exclude->head;
2088 move_type = exclude->move_type; 2066 move_type = exclude->move_type;
2091 { 2069 {
2092 /* If we don't have anything, presume it can use all movement types. */ 2070 /* If we don't have anything, presume it can use all movement types. */
2093 move_type = MOVE_ALL; 2071 move_type = MOVE_ALL;
2094 } 2072 }
2095 2073
2096 for (i = 1; i < max; i++) 2074 for (int i = 1; i < max; i++)
2097 { 2075 {
2098 mp = m; 2076 mapxy pos (m, x, y);
2099 nx = x + freearr_x[i]; 2077 pos.move (i);
2100 ny = y + freearr_y[i];
2101 2078
2102 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2079 if (!pos.normalise ())
2103
2104 if (mflags & P_OUT_OF_MAP)
2105 max = maxfree[i]; 2080 max = maxfree[i];
2106 else 2081 else
2107 { 2082 {
2108 mapspace &ms = mp->at (nx, ny); 2083 mapspace &ms = *pos;
2109 2084
2110 blocked = ms.move_block;
2111
2112 if ((move_type & blocked) == move_type) 2085 if ((move_type & ms.move_block) == move_type)
2113 max = maxfree[i]; 2086 max = maxfree [i];
2114 else if (mflags & P_IS_ALIVE) 2087 else if (ms.flags () & P_IS_ALIVE)
2115 { 2088 {
2116 for (tmp = ms.bot; tmp; tmp = tmp->above) 2089 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
2117 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER) 2090 if ((tmp->flag [FLAG_MONSTER] || tmp->is_player ())
2118 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude))) 2091 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))
2119 break;
2120
2121 if (tmp)
2122 return freedir[i]; 2092 return freedir [i];
2123 } 2093 }
2124 } 2094 }
2125 } 2095 }
2126 2096
2127 return 0; 2097 return 0;
2202 * This basically means that if direction is 15, then it could either go 2172 * This basically means that if direction is 15, then it could either go
2203 * direction 4, 14, or 16 to get back to where we are. 2173 * direction 4, 14, or 16 to get back to where we are.
2204 * Moved from spell_util.c to object.c with the other related direction 2174 * Moved from spell_util.c to object.c with the other related direction
2205 * functions. 2175 * functions.
2206 */ 2176 */
2207int reduction_dir[SIZEOFFREE][3] = { 2177const int reduction_dir[SIZEOFFREE][3] = {
2208 {0, 0, 0}, /* 0 */ 2178 {0, 0, 0}, /* 0 */
2209 {0, 0, 0}, /* 1 */ 2179 {0, 0, 0}, /* 1 */
2210 {0, 0, 0}, /* 2 */ 2180 {0, 0, 0}, /* 2 */
2211 {0, 0, 0}, /* 3 */ 2181 {0, 0, 0}, /* 3 */
2212 {0, 0, 0}, /* 4 */ 2182 {0, 0, 0}, /* 4 */
2308int 2278int
2309can_pick (const object *who, const object *item) 2279can_pick (const object *who, const object *item)
2310{ 2280{
2311 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2281 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2312 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2282 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2313 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2283 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->is_player () || item->weight < who->weight / 3));
2314} 2284}
2315 2285
2316/* 2286/*
2317 * create clone from object to another 2287 * create clone from object to another
2318 */ 2288 */
2350 return tmp; 2320 return tmp;
2351 2321
2352 return 0; 2322 return 0;
2353} 2323}
2354 2324
2355const shstr & 2325shstr_tmp
2356object::kv_get (const shstr &key) const 2326object::kv_get (shstr_tmp key) const
2357{ 2327{
2358 for (key_value *kv = key_values; kv; kv = kv->next) 2328 for (key_value *kv = key_values; kv; kv = kv->next)
2359 if (kv->key == key) 2329 if (kv->key == key)
2360 return kv->value; 2330 return kv->value;
2361 2331
2362 return shstr_null; 2332 return shstr ();
2363} 2333}
2364 2334
2365void 2335void
2366object::kv_set (const shstr &key, const shstr &value) 2336object::kv_set (shstr_tmp key, shstr_tmp value)
2367{ 2337{
2368 for (key_value *kv = key_values; kv; kv = kv->next) 2338 for (key_value *kv = key_values; kv; kv = kv->next)
2369 if (kv->key == key) 2339 if (kv->key == key)
2370 { 2340 {
2371 kv->value = value; 2341 kv->value = value;
2380 2350
2381 key_values = kv; 2351 key_values = kv;
2382} 2352}
2383 2353
2384void 2354void
2385object::kv_del (const shstr &key) 2355object::kv_del (shstr_tmp key)
2386{ 2356{
2387 for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next) 2357 for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
2388 if ((*kvp)->key == key) 2358 if ((*kvp)->key == key)
2389 { 2359 {
2390 key_value *kv = *kvp; 2360 key_value *kv = *kvp;
2449{ 2419{
2450 char flagdesc[512]; 2420 char flagdesc[512];
2451 char info2[256 * 4]; 2421 char info2[256 * 4];
2452 char *p = info; 2422 char *p = info;
2453 2423
2454 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s,flags:[%s],type:%d}", 2424 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2455 count, 2425 count,
2456 uuid.c_str (), 2426 uuid.c_str (),
2457 &name, 2427 &name,
2458 title ? "\",title:\"" : "", 2428 title ? ",title:\"" : "",
2459 title ? (const char *)title : "", 2429 title ? (const char *)title : "",
2430 title ? "\"" : "",
2460 flag_desc (flagdesc, 512), type); 2431 flag_desc (flagdesc, 512), type);
2461 2432
2462 if (!flag[FLAG_REMOVED] && env) 2433 if (!flag[FLAG_REMOVED] && env)
2463 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2434 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2464 2435
2520 container = 0; 2491 container = 0;
2521 2492
2522 // client needs item update to make it work, client bug requires this to be separate 2493 // client needs item update to make it work, client bug requires this to be separate
2523 esrv_update_item (UPD_FLAGS, this, old_container); 2494 esrv_update_item (UPD_FLAGS, this, old_container);
2524 2495
2525 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container)); 2496 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", old_container->query_name ());
2526 play_sound (sound_find ("chest_close")); 2497 play_sound (sound_find ("chest_close"));
2527 } 2498 }
2528 2499
2529 if (new_container) 2500 if (new_container)
2530 { 2501 {
2540 closer->flag [FLAG_NO_MAP_SAVE] = 1; 2511 closer->flag [FLAG_NO_MAP_SAVE] = 1;
2541 new_container->insert (closer); 2512 new_container->insert (closer);
2542 } 2513 }
2543#endif 2514#endif
2544 2515
2545 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container)); 2516 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", new_container->query_name ());
2546 2517
2547 // make sure the container is available, client bug requires this to be separate 2518 // make sure the container is available, client bug requires this to be separate
2548 esrv_send_item (this, new_container); 2519 esrv_send_item (this, new_container);
2549 2520
2550 new_container->flag [FLAG_APPLIED] = true; 2521 new_container->flag [FLAG_APPLIED] = true;
2558// else if (!old_container->env && contr && contr->ns) 2529// else if (!old_container->env && contr && contr->ns)
2559// contr->ns->floorbox_reset (); 2530// contr->ns->floorbox_reset ();
2560} 2531}
2561 2532
2562object * 2533object *
2563object::force_find (const shstr name) 2534object::force_find (shstr_tmp name)
2564{ 2535{
2565 /* cycle through his inventory to look for the MARK we want to 2536 /* cycle through his inventory to look for the MARK we want to
2566 * place 2537 * place
2567 */ 2538 */
2568 for (object *tmp = inv; tmp; tmp = tmp->below) 2539 for (object *tmp = inv; tmp; tmp = tmp->below)
2570 return splay (tmp); 2541 return splay (tmp);
2571 2542
2572 return 0; 2543 return 0;
2573} 2544}
2574 2545
2575void 2546object *
2576object::force_add (const shstr name, int duration) 2547object::force_add (shstr_tmp name, int duration)
2577{ 2548{
2578 if (object *force = force_find (name)) 2549 if (object *force = force_find (name))
2579 force->destroy (); 2550 force->destroy ();
2580 2551
2581 object *force = get_archetype (FORCE_NAME); 2552 object *force = get_archetype (FORCE_NAME);
2586 2557
2587 force->set_speed (duration ? 1.f / duration : 0.f); 2558 force->set_speed (duration ? 1.f / duration : 0.f);
2588 force->flag [FLAG_IS_USED_UP] = true; 2559 force->flag [FLAG_IS_USED_UP] = true;
2589 force->flag [FLAG_APPLIED] = true; 2560 force->flag [FLAG_APPLIED] = true;
2590 2561
2591 insert (force); 2562 return insert (force);
2592} 2563}
2593 2564
2594void 2565void
2595object::play_sound (faceidx sound) 2566object::play_sound (faceidx sound) const
2596{ 2567{
2597 if (!sound) 2568 if (!sound)
2598 return; 2569 return;
2599 2570
2600 if (flag [FLAG_REMOVED]) 2571 if (is_on_map ())
2572 map->play_sound (sound, x, y);
2573 else if (object *pl = in_player ())
2574 pl->contr->play_sound (sound);
2575}
2576
2577void
2578object::say_msg (const char *msg) const
2579{
2580 if (is_on_map ())
2581 map->say_msg (msg, x, y);
2582 else if (object *pl = in_player ())
2583 pl->contr->play_sound (sound);
2584}
2585
2586void
2587object::make_noise ()
2588{
2589 // we do not model noise in the map, so instead put
2590 // a temporary light into the noise source
2591 // could use the map instead, but that's less reliable for our
2592 // goal, which is to make invisibility a bit harder to exploit
2593
2594 // currently only works sensibly for players
2595 if (!is_player ())
2601 return; 2596 return;
2602 2597
2603 if (env) 2598 // find old force, or create new one
2604 { 2599 object *force = force_find (shstr_noise_force);
2605 if (object *pl = in_player ()) 2600
2606 pl->contr->play_sound (sound); 2601 if (force)
2607 } 2602 force->speed_left = -1.f; // patch old speed up
2608 else 2603 else
2609 map->play_sound (sound, x, y); 2604 {
2610} 2605 force = archetype::get (shstr_noise_force);
2611 2606
2607 force->slaying = shstr_noise_force;
2608 force->stats.food = 1;
2609 force->speed_left = -1.f;
2610
2611 force->set_speed (1.f / 4.f);
2612 force->flag [FLAG_IS_USED_UP] = true;
2613 force->flag [FLAG_APPLIED] = true;
2614
2615 insert (force);
2616 }
2617}
2618

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines