ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.221 by root, Thu Apr 24 12:06:01 2008 UTC vs.
Revision 1.257 by root, Tue Sep 16 16:03:02 2008 UTC

139 139
140/* Returns TRUE if every key_values in wants has a partner with the same value in has. */ 140/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
141static bool 141static bool
142compare_ob_value_lists_one (const object *wants, const object *has) 142compare_ob_value_lists_one (const object *wants, const object *has)
143{ 143{
144 key_value *wants_field;
145
146 /* n-squared behaviour (see get_ob_key_link()), but I'm hoping both 144 /* n-squared behaviour (see kv_get), but I'm hoping both
147 * objects with lists are rare, and lists stay short. If not, use a 145 * objects with lists are rare, and lists stay short. If not, use a
148 * different structure or at least keep the lists sorted... 146 * different structure or at least keep the lists sorted...
149 */ 147 */
150 148
151 /* For each field in wants, */ 149 /* For each field in wants, */
152 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next) 150 for (key_value *kv = wants->key_values; kv; kv = kv->next)
153 { 151 if (has->kv_get (kv->key) != kv->value)
154 key_value *has_field; 152 return false;
155
156 /* Look for a field in has with the same key. */
157 has_field = get_ob_key_link (has, wants_field->key);
158
159 if (!has_field)
160 return 0; /* No field with that name. */
161
162 /* Found the matching field. */
163 if (has_field->value != wants_field->value)
164 return 0; /* Values don't match, so this half of the comparison is false. */
165
166 /* If we get here, we found a match. Now for the next field in wants. */
167 }
168 153
169 /* If we get here, every field in wants has a matching field in has. */ 154 /* If we get here, every field in wants has a matching field in has. */
170 return 1; 155 return true;
171} 156}
172 157
173/* Returns TRUE if ob1 has the same key_values as ob2. */ 158/* Returns TRUE if ob1 has the same key_values as ob2. */
174static bool 159static bool
175compare_ob_value_lists (const object *ob1, const object *ob2) 160compare_ob_value_lists (const object *ob1, const object *ob2)
176{ 161{
177 /* However, there may be fields in has which aren't partnered in wants, 162 /* However, there may be fields in has which aren't partnered in wants,
178 * so we need to run the comparison *twice*. :( 163 * so we need to run the comparison *twice*. :(
179 */ 164 */
180 return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1); 165 return compare_ob_value_lists_one (ob1, ob2)
166 && compare_ob_value_lists_one (ob2, ob1);
181} 167}
182 168
183/* Function examines the 2 objects given to it, and returns true if 169/* Function examines the 2 objects given to it, and returns true if
184 * they can be merged together. 170 * they can be merged together.
185 * 171 *
200 || ob1->speed != ob2->speed 186 || ob1->speed != ob2->speed
201 || ob1->value != ob2->value 187 || ob1->value != ob2->value
202 || ob1->name != ob2->name) 188 || ob1->name != ob2->name)
203 return 0; 189 return 0;
204 190
205 /* Do not merge objects if nrof would overflow. First part checks 191 /* Do not merge objects if nrof would overflow, assume nrof
206 * for unsigned overflow (2c), second part checks whether the result 192 * is always 0 .. 2**31-1 */
207 * would fit into a 32 bit signed int, which is often used to hold 193 if (ob1->nrof > 0x7fffffff - ob2->nrof)
208 * nrof values.
209 */
210 if (~ob1->nrof < ob2->nrof || ob1->nrof + ob2->nrof > (1UL << 31))
211 return 0; 194 return 0;
212 195
213 /* If the objects have been identified, set the BEEN_APPLIED flag. 196 /* If the objects have been identified, set the BEEN_APPLIED flag.
214 * This is to the comparison of the flags below will be OK. We 197 * This is to the comparison of the flags below will be OK. We
215 * just can't ignore the been applied or identified flags, as they 198 * just can't ignore the been applied or identified flags, as they
220 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 203 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
221 204
222 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 205 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
223 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 206 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
224 207
225 if (ob1->arch->name != ob2->arch->name 208 if (ob1->arch->archname != ob2->arch->archname
226 || ob1->name != ob2->name 209 || ob1->name != ob2->name
227 || ob1->title != ob2->title 210 || ob1->title != ob2->title
228 || ob1->msg != ob2->msg 211 || ob1->msg != ob2->msg
229 || ob1->weight != ob2->weight 212 || ob1->weight != ob2->weight
230 || ob1->attacktype != ob2->attacktype 213 || ob1->attacktype != ob2->attacktype
231 || ob1->magic != ob2->magic 214 || ob1->magic != ob2->magic
232 || ob1->slaying != ob2->slaying 215 || ob1->slaying != ob2->slaying
233 || ob1->skill != ob2->skill 216 || ob1->skill != ob2->skill
234 || ob1->value != ob2->value 217 || ob1->value != ob2->value
235 || ob1->animation_id != ob2->animation_id 218 || ob1->animation_id != ob2->animation_id
219 || (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependent on each other
236 || ob1->client_type != ob2->client_type 220 || ob1->client_type != ob2->client_type
237 || ob1->materialname != ob2->materialname 221 || ob1->materialname != ob2->materialname
238 || ob1->lore != ob2->lore 222 || ob1->lore != ob2->lore
239 || ob1->subtype != ob2->subtype 223 || ob1->subtype != ob2->subtype
240 || ob1->move_type != ob2->move_type 224 || ob1->move_type != ob2->move_type
248 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats))) 232 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
249 return 0; 233 return 0;
250 234
251 if ((ob1->flag ^ ob2->flag) 235 if ((ob1->flag ^ ob2->flag)
252 .reset (FLAG_INV_LOCKED) 236 .reset (FLAG_INV_LOCKED)
253 .reset (FLAG_CLIENT_SENT)
254 .reset (FLAG_REMOVED) 237 .reset (FLAG_REMOVED)
255 .any ()) 238 .any ())
256 return 0; 239 return 0;
257 240
258 /* This is really a spellbook check - we should in general 241 /* This is really a spellbook check - we should in general
358 else 341 else
359 { 342 {
360 // maybe there is a player standing on the same mapspace 343 // maybe there is a player standing on the same mapspace
361 // this will catch the case where "this" is a player 344 // this will catch the case where "this" is a player
362 if (object *pl = ms ().player ()) 345 if (object *pl = ms ().player ())
346 if ((!pl->container && pl->contr->ns && !pl->contr->ns->update_look)
363 if (!pl->container || this == pl->container) 347 || this == pl->container)
364 return pl; 348 return pl;
365 } 349 }
366 } 350 }
367 351
368 return 0; 352 return 0;
369} 353}
370 354
371// adjust weight per container type ("of holding") 355// adjust weight per container type ("of holding")
372static sint32 356static sint32
373weight_adjust (object *op, sint32 weight) 357weight_adjust_for (object *op, sint32 weight)
374{ 358{
375 return op->type == CONTAINER 359 return op->type == CONTAINER
376 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str) 360 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str)
377 : weight; 361 : weight;
378} 362}
384static void 368static void
385adjust_weight (object *op, sint32 weight) 369adjust_weight (object *op, sint32 weight)
386{ 370{
387 while (op) 371 while (op)
388 { 372 {
373 // adjust by actual difference to account for rounding errors
374 // i.e. (w2 - w1) / f != w2 / f - w1 / f and the latter is correct
389 weight = weight_adjust (op, weight); 375 weight = weight_adjust_for (op, op->carrying)
376 - weight_adjust_for (op, op->carrying - weight);
390 377
391 if (!weight) 378 if (!weight)
392 return; 379 return;
393 380
394 op->carrying += weight; 381 op->carrying += weight;
417 op->update_weight (); 404 op->update_weight ();
418 405
419 sum += op->total_weight (); 406 sum += op->total_weight ();
420 } 407 }
421 408
422 sum = weight_adjust (this, sum); 409 sum = weight_adjust_for (this, sum);
423 410
424 if (sum != carrying) 411 if (sum != carrying)
425 { 412 {
426 carrying = sum; 413 carrying = sum;
427 414
489 */ 476 */
490object * 477object *
491find_object_name (const char *str) 478find_object_name (const char *str)
492{ 479{
493 shstr_cmp str_ (str); 480 shstr_cmp str_ (str);
494 object *op;
495 481
482 if (str_)
496 for_all_objects (op) 483 for_all_objects (op)
497 if (op->name == str_) 484 if (op->name == str_)
498 break; 485 return op;
499 486
500 return op; 487 return 0;
501} 488}
502 489
503/* 490/*
504 * Sets the owner and sets the skill and exp pointers to owner's current 491 * Sets the owner and sets the skill and exp pointers to owner's current
505 * skill and experience objects. 492 * skill and experience objects.
603 } 590 }
604 591
605 op->key_values = 0; 592 op->key_values = 0;
606} 593}
607 594
608object & 595/*
609object::operator =(const object &src) 596 * copy_to first frees everything allocated by the dst object,
597 * and then copies the contents of itself into the second
598 * object, allocating what needs to be allocated. Basically, any
599 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
600 * if the first object is freed, the pointers in the new object
601 * will point at garbage.
602 */
603void
604object::copy_to (object *dst)
610{ 605{
611 bool is_freed = flag [FLAG_FREED]; 606 dst->remove ();
612 bool is_removed = flag [FLAG_REMOVED];
613
614 *(object_copy *)this = src; 607 *(object_copy *)dst = *this;
615
616 flag [FLAG_FREED] = is_freed;
617 flag [FLAG_REMOVED] = is_removed; 608 dst->flag [FLAG_REMOVED] = true;
618 609
619 /* Copy over key_values, if any. */ 610 /* Copy over key_values, if any. */
620 if (src.key_values) 611 if (key_values)
621 { 612 {
622 key_value *tail = 0; 613 key_value *tail = 0;
623 key_values = 0; 614 dst->key_values = 0;
624 615
625 for (key_value *i = src.key_values; i; i = i->next) 616 for (key_value *i = key_values; i; i = i->next)
626 { 617 {
627 key_value *new_link = new key_value; 618 key_value *new_link = new key_value;
628 619
629 new_link->next = 0; 620 new_link->next = 0;
630 new_link->key = i->key; 621 new_link->key = i->key;
631 new_link->value = i->value; 622 new_link->value = i->value;
632 623
633 /* Try and be clever here, too. */ 624 /* Try and be clever here, too. */
634 if (!key_values) 625 if (!dst->key_values)
635 { 626 {
636 key_values = new_link; 627 dst->key_values = new_link;
637 tail = new_link; 628 tail = new_link;
638 } 629 }
639 else 630 else
640 { 631 {
641 tail->next = new_link; 632 tail->next = new_link;
642 tail = new_link; 633 tail = new_link;
643 } 634 }
644 } 635 }
645 } 636 }
646}
647
648/*
649 * copy_to first frees everything allocated by the dst object,
650 * and then copies the contents of itself into the second
651 * object, allocating what needs to be allocated. Basically, any
652 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
653 * if the first object is freed, the pointers in the new object
654 * will point at garbage.
655 */
656void
657object::copy_to (object *dst)
658{
659 *dst = *this;
660 637
661 if (speed < 0) 638 if (speed < 0)
662 dst->speed_left -= rndm (); 639 dst->speed_left -= rndm ();
663 640
664 dst->set_speed (dst->speed); 641 dst->activate ();
665} 642}
666 643
667void 644void
668object::instantiate () 645object::instantiate ()
669{ 646{
686object * 663object *
687object::clone () 664object::clone ()
688{ 665{
689 object *neu = create (); 666 object *neu = create ();
690 copy_to (neu); 667 copy_to (neu);
668 neu->map = map; // not copied by copy_to
691 return neu; 669 return neu;
692} 670}
693 671
694/* 672/*
695 * If an object with the IS_TURNABLE() flag needs to be turned due 673 * If an object with the IS_TURNABLE() flag needs to be turned due
746 * UP_OBJ_FACE: only the objects face has changed. 724 * UP_OBJ_FACE: only the objects face has changed.
747 */ 725 */
748void 726void
749update_object (object *op, int action) 727update_object (object *op, int action)
750{ 728{
751 if (op == NULL) 729 if (!op)
752 { 730 {
753 /* this should never happen */ 731 /* this should never happen */
754 LOG (llevDebug, "update_object() called for NULL object.\n"); 732 LOG (llevError | logBacktrace, "update_object() called for NULL object.\n");
755 return; 733 return;
756 } 734 }
757 735
758 if (op->env) 736 if (!op->is_on_map ())
759 { 737 {
760 /* Animation is currently handled by client, so nothing 738 /* Animation is currently handled by client, so nothing
761 * to do in this case. 739 * to do in this case.
762 */ 740 */
763 return; 741 return;
764 } 742 }
765
766 /* If the map is saving, don't do anything as everything is
767 * going to get freed anyways.
768 */
769 if (!op->map || op->map->in_memory == MAP_SAVING)
770 return;
771 743
772 /* make sure the object is within map boundaries */ 744 /* make sure the object is within map boundaries */
773 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height) 745 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
774 { 746 {
775 LOG (llevError, "update_object() called for object out of map!\n"); 747 LOG (llevError, "update_object() called for object out of map!\n");
794 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC)) 766 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
795 || (m.move_on | op->move_on ) != m.move_on 767 || (m.move_on | op->move_on ) != m.move_on
796 || (m.move_off | op->move_off ) != m.move_off 768 || (m.move_off | op->move_off ) != m.move_off
797 || (m.move_slow | op->move_slow) != m.move_slow 769 || (m.move_slow | op->move_slow) != m.move_slow
798 /* This isn't perfect, but I don't expect a lot of objects to 770 /* This isn't perfect, but I don't expect a lot of objects to
799 * to have move_allow right now. 771 * have move_allow right now.
800 */ 772 */
801 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block 773 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
802 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp) 774 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
803 m.flags_ = 0; 775 m.flags_ = 0;
804 } 776 }
858{ 830{
859 /* If already on active list, don't do anything */ 831 /* If already on active list, don't do anything */
860 if (active) 832 if (active)
861 return; 833 return;
862 834
835 if (has_active_speed () && flag [FLAG_FREED]) LOG (llevError | logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
836 if (has_active_speed () && flag [FLAG_DEBUG]) LOG (llevError | logBacktrace, "BUG: tried to activate DEBUG object %s\n", debug_desc ());//D temp
837
863 if (has_active_speed ()) 838 if (has_active_speed ())
864 actives.insert (this); 839 actives.insert (this);
865} 840}
866 841
867void 842void
930 * drop on that space. 905 * drop on that space.
931 */ 906 */
932 if (!drop_to_ground 907 if (!drop_to_ground
933 || !map 908 || !map
934 || map->in_memory != MAP_ACTIVE 909 || map->in_memory != MAP_ACTIVE
935 || map->nodrop 910 || map->no_drop
936 || ms ().move_block == MOVE_ALL) 911 || ms ().move_block == MOVE_ALL)
937 { 912 {
938 while (inv) 913 while (inv)
939 {
940 inv->destroy_inv (false);
941 inv->destroy (); 914 inv->destroy (true);
942 }
943 } 915 }
944 else 916 else
945 { /* Put objects in inventory onto this space */ 917 { /* Put objects in inventory onto this space */
946 while (inv) 918 while (inv)
947 { 919 {
965 object *op = new object; 937 object *op = new object;
966 op->link (); 938 op->link ();
967 return op; 939 return op;
968} 940}
969 941
942static struct freed_map : maptile
943{
944 freed_map ()
945 {
946 path = "<freed objects map>";
947 name = "/internal/freed_objects_map";
948 width = 3;
949 height = 3;
950 no_drop = 1;
951 no_reset = 1;
952
953 alloc ();
954 in_memory = MAP_ACTIVE;
955 }
956
957 ~freed_map ()
958 {
959 destroy ();
960 }
961} freed_map; // freed objects are moved here to avoid crashes
962
970void 963void
971object::do_destroy () 964object::do_destroy ()
972{ 965{
973 if (flag [FLAG_IS_LINKED]) 966 if (flag [FLAG_IS_LINKED])
974 remove_button_link (this); 967 remove_button_link (this);
984 unlink (); 977 unlink ();
985 978
986 flag [FLAG_FREED] = 1; 979 flag [FLAG_FREED] = 1;
987 980
988 // hack to ensure that freed objects still have a valid map 981 // hack to ensure that freed objects still have a valid map
989 {
990 static maptile *freed_map; // freed objects are moved here to avoid crashes
991
992 if (!freed_map)
993 {
994 freed_map = new maptile;
995
996 freed_map->path = "<freed objects map>";
997 freed_map->name = "/internal/freed_objects_map";
998 freed_map->width = 3;
999 freed_map->height = 3;
1000 freed_map->nodrop = 1;
1001
1002 freed_map->alloc ();
1003 freed_map->in_memory = MAP_ACTIVE;
1004 }
1005
1006 map = freed_map; 982 map = &freed_map;
1007 x = 1; 983 x = 1;
1008 y = 1; 984 y = 1;
1009 }
1010 985
1011 if (more) 986 if (more)
1012 { 987 {
1013 more->destroy (); 988 more->destroy ();
1014 more = 0; 989 more = 0;
1031 1006
1032 if (!is_head () && !head->destroyed ()) 1007 if (!is_head () && !head->destroyed ())
1033 { 1008 {
1034 LOG (llevError | logBacktrace, "tried to destroy the tail of an object"); 1009 LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
1035 head->destroy (destroy_inventory); 1010 head->destroy (destroy_inventory);
1011 return;
1036 } 1012 }
1037 1013
1038 destroy_inv (!destroy_inventory); 1014 destroy_inv (!destroy_inventory);
1039 1015
1040 if (is_head ()) 1016 if (is_head ())
1079 if (object *pl = visible_to ()) 1055 if (object *pl = visible_to ())
1080 esrv_del_item (pl->contr, count); 1056 esrv_del_item (pl->contr, count);
1081 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed 1057 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
1082 1058
1083 adjust_weight (env, -total_weight ()); 1059 adjust_weight (env, -total_weight ());
1084
1085 *(above ? &above->below : &env->inv) = below;
1086
1087 if (below)
1088 below->above = above;
1089 1060
1090 /* we set up values so that it could be inserted into 1061 /* we set up values so that it could be inserted into
1091 * the map, but we don't actually do that - it is up 1062 * the map, but we don't actually do that - it is up
1092 * to the caller to decide what we want to do. 1063 * to the caller to decide what we want to do.
1093 */ 1064 */
1094 map = env->map; 1065 map = env->map;
1095 x = env->x; 1066 x = env->x;
1096 y = env->y; 1067 y = env->y;
1068
1069 // make sure cmov optimisation is applicable
1070 *(above ? &above->below : &env->inv) = below;
1071 *(below ? &below->above : &above ) = above; // &above is just a dummy
1072
1097 above = 0; 1073 above = 0;
1098 below = 0; 1074 below = 0;
1099 env = 0; 1075 env = 0;
1100 1076
1101 /* NO_FIX_PLAYER is set when a great many changes are being 1077 /* NO_FIX_PLAYER is set when a great many changes are being
1131 1107
1132 esrv_del_item (pl->contr, count); 1108 esrv_del_item (pl->contr, count);
1133 } 1109 }
1134 1110
1135 /* link the object above us */ 1111 /* link the object above us */
1136 if (above) 1112 // re-link, make sure compiler can easily use cmove
1137 above->below = below; 1113 *(above ? &above->below : &ms.top) = below;
1138 else 1114 *(below ? &below->above : &ms.bot) = above;
1139 ms.top = below; /* we were top, set new top */
1140
1141 /* Relink the object below us, if there is one */
1142 if (below)
1143 below->above = above;
1144 else
1145 {
1146 /* Nothing below, which means we need to relink map object for this space
1147 * use translated coordinates in case some oddness with map tiling is
1148 * evident
1149 */
1150 if (GET_MAP_OB (map, x, y) != this)
1151 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1152
1153 ms.bot = above; /* goes on above it. */
1154 }
1155 1115
1156 above = 0; 1116 above = 0;
1157 below = 0; 1117 below = 0;
1118
1119 ms.flags_ = 0;
1158 1120
1159 if (map->in_memory == MAP_SAVING) 1121 if (map->in_memory == MAP_SAVING)
1160 return; 1122 return;
1161 1123
1162 int check_walk_off = !flag [FLAG_NO_APPLY]; 1124 int check_walk_off = !flag [FLAG_NO_APPLY];
1169 * appropriately. 1131 * appropriately.
1170 */ 1132 */
1171 pl->close_container (); 1133 pl->close_container ();
1172 1134
1173 //TODO: the floorbox prev/next might need updating 1135 //TODO: the floorbox prev/next might need updating
1174 esrv_del_item (pl->contr, count); 1136 //esrv_del_item (pl->contr, count);
1137 //TODO: update floorbox to preserve ordering
1138 if (pl->contr->ns)
1139 pl->contr->ns->floorbox_update ();
1175 } 1140 }
1176 1141
1177 for (tmp = ms.bot; tmp; tmp = tmp->above) 1142 for (tmp = ms.bot; tmp; tmp = tmp->above)
1178 { 1143 {
1179 /* No point updating the players look faces if he is the object 1144 /* No point updating the players look faces if he is the object
1192 } 1157 }
1193 1158
1194 last = tmp; 1159 last = tmp;
1195 } 1160 }
1196 1161
1197 /* last == NULL if there are no objects on this space */
1198 //TODO: this makes little sense, why only update the topmost object?
1199 if (!last)
1200 map->at (x, y).flags_ = 0;
1201 else
1202 update_object (last, UP_OBJ_REMOVE);
1203
1204 if (flag [FLAG_BLOCKSVIEW] || glow_radius) 1162 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1205 update_all_los (map, x, y); 1163 update_all_los (map, x, y);
1206 } 1164 }
1207} 1165}
1208 1166
1271 * job preparing multi-part monsters. 1229 * job preparing multi-part monsters.
1272 */ 1230 */
1273object * 1231object *
1274insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1232insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1275{ 1233{
1234 op->remove ();
1235
1276 for (object *tmp = op->head_ (); tmp; tmp = tmp->more) 1236 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1277 { 1237 {
1278 tmp->x = x + tmp->arch->x; 1238 tmp->x = x + tmp->arch->x;
1279 tmp->y = y + tmp->arch->y; 1239 tmp->y = y + tmp->arch->y;
1280 } 1240 }
1303 * just 'op' otherwise 1263 * just 'op' otherwise
1304 */ 1264 */
1305object * 1265object *
1306insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1266insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1307{ 1267{
1308 assert (!op->flag [FLAG_FREED]); 1268 if (op->is_on_map ())
1269 {
1270 LOG (llevError, "insert_ob_in_map called for object already on map");
1271 abort ();
1272 }
1309 1273
1274 if (op->env)
1275 {
1276 LOG (llevError, "insert_ob_in_map called for object in an inventory (proceeding)");
1310 op->remove (); 1277 op->remove ();
1278 }
1279
1280 if (op->face && !face_info (op->face))//D TODO: remove soon
1281 {//D
1282 LOG (llevError | logBacktrace, "op->face out of bounds: %s", op->debug_desc ());//D
1283 op->face = 1;//D
1284 }//D
1311 1285
1312 /* Ideally, the caller figures this out. However, it complicates a lot 1286 /* Ideally, the caller figures this out. However, it complicates a lot
1313 * of areas of callers (eg, anything that uses find_free_spot would now 1287 * of areas of callers (eg, anything that uses find_free_spot would now
1314 * need extra work 1288 * need extra work
1315 */ 1289 */
1316 if (!xy_normalise (m, op->x, op->y)) 1290 if (!xy_normalise (m, op->x, op->y))
1317 { 1291 {
1318 op->destroy (1); 1292 op->head_ ()->destroy (1);// remove head_ once all tail object destroyers found
1319 return 0; 1293 return 0;
1320 } 1294 }
1321 1295
1322 if (object *more = op->more) 1296 if (object *more = op->more)
1323 if (!insert_ob_in_map (more, m, originator, flag)) 1297 if (!insert_ob_in_map (more, m, originator, flag))
1332 */ 1306 */
1333 if (op->nrof && !(flag & INS_NO_MERGE)) 1307 if (op->nrof && !(flag & INS_NO_MERGE))
1334 for (object *tmp = ms.bot; tmp; tmp = tmp->above) 1308 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1335 if (object::can_merge (op, tmp)) 1309 if (object::can_merge (op, tmp))
1336 { 1310 {
1337 // TODO: we atcually want to update tmp, not op, 1311 // TODO: we actually want to update tmp, not op,
1338 // but some caller surely breaks when we return tmp 1312 // but some caller surely breaks when we return tmp
1339 // from here :/ 1313 // from here :/
1340 op->nrof += tmp->nrof; 1314 op->nrof += tmp->nrof;
1341 tmp->destroy (1); 1315 tmp->destroy (1);
1342 } 1316 }
1353 { 1327 {
1354 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n"); 1328 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1355 abort (); 1329 abort ();
1356 } 1330 }
1357 1331
1332 if (!originator->is_on_map ())
1333 LOG (llevDebug | logBacktrace, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
1334 op->debug_desc (), originator->debug_desc ());
1335
1358 op->above = originator; 1336 op->above = originator;
1359 op->below = originator->below; 1337 op->below = originator->below;
1360
1361 if (op->below)
1362 op->below->above = op;
1363 else
1364 ms.bot = op;
1365
1366 /* since *below* originator, no need to update top */
1367 originator->below = op; 1338 originator->below = op;
1339
1340 *(op->below ? &op->below->above : &ms.bot) = op;
1368 } 1341 }
1369 else 1342 else
1370 { 1343 {
1371 object *top, *floor = NULL; 1344 object *floor = 0;
1372 1345 object *top = ms.top;
1373 top = ms.bot;
1374 1346
1375 /* If there are other objects, then */ 1347 /* If there are other objects, then */
1376 if (top) 1348 if (top)
1377 { 1349 {
1378 object *last = 0;
1379
1380 /* 1350 /*
1381 * If there are multiple objects on this space, we do some trickier handling. 1351 * If there are multiple objects on this space, we do some trickier handling.
1382 * We've already dealt with merging if appropriate. 1352 * We've already dealt with merging if appropriate.
1383 * Generally, we want to put the new object on top. But if 1353 * Generally, we want to put the new object on top. But if
1384 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last 1354 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
1387 * once we get to them. This reduces the need to traverse over all of 1357 * once we get to them. This reduces the need to traverse over all of
1388 * them when adding another one - this saves quite a bit of cpu time 1358 * them when adding another one - this saves quite a bit of cpu time
1389 * when lots of spells are cast in one area. Currently, it is presumed 1359 * when lots of spells are cast in one area. Currently, it is presumed
1390 * that flying non pickable objects are spell objects. 1360 * that flying non pickable objects are spell objects.
1391 */ 1361 */
1392 for (top = ms.bot; top; top = top->above) 1362 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1393 { 1363 {
1394 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1364 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) || QUERY_FLAG (tmp, FLAG_OVERLAY_FLOOR))
1395 floor = top; 1365 floor = tmp;
1396 1366
1397 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1367 if (QUERY_FLAG (tmp, FLAG_NO_PICK) && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (tmp, FLAG_IS_FLOOR))
1398 { 1368 {
1399 /* We insert above top, so we want this object below this */ 1369 /* We insert above top, so we want this object below this */
1400 top = top->below; 1370 top = tmp->below;
1401 break; 1371 break;
1402 } 1372 }
1403 1373
1404 last = top; 1374 top = tmp;
1405 } 1375 }
1406
1407 /* Don't want top to be NULL, so set it to the last valid object */
1408 top = last;
1409 1376
1410 /* We let update_position deal with figuring out what the space 1377 /* We let update_position deal with figuring out what the space
1411 * looks like instead of lots of conditions here. 1378 * looks like instead of lots of conditions here.
1412 * makes things faster, and effectively the same result. 1379 * makes things faster, and effectively the same result.
1413 */ 1380 */
1420 */ 1387 */
1421 if (!(flag & INS_ON_TOP) 1388 if (!(flag & INS_ON_TOP)
1422 && ms.flags () & P_BLOCKSVIEW 1389 && ms.flags () & P_BLOCKSVIEW
1423 && (op->face && !faces [op->face].visibility)) 1390 && (op->face && !faces [op->face].visibility))
1424 { 1391 {
1392 object *last;
1393
1425 for (last = top; last != floor; last = last->below) 1394 for (last = top; last != floor; last = last->below)
1426 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1395 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1427 break; 1396 break;
1428 1397
1429 /* Check to see if we found the object that blocks view, 1398 /* Check to see if we found the object that blocks view,
1437 } /* If objects on this space */ 1406 } /* If objects on this space */
1438 1407
1439 if (flag & INS_ABOVE_FLOOR_ONLY) 1408 if (flag & INS_ABOVE_FLOOR_ONLY)
1440 top = floor; 1409 top = floor;
1441 1410
1442 /* Top is the object that our object (op) is going to get inserted above. 1411 // insert object above top, or bottom-most if top = 0
1443 */
1444
1445 /* First object on this space */
1446 if (!top) 1412 if (!top)
1447 { 1413 {
1414 op->below = 0;
1448 op->above = ms.bot; 1415 op->above = ms.bot;
1449
1450 if (op->above)
1451 op->above->below = op;
1452
1453 op->below = 0;
1454 ms.bot = op; 1416 ms.bot = op;
1417
1418 *(op->above ? &op->above->below : &ms.top) = op;
1455 } 1419 }
1456 else 1420 else
1457 { /* get inserted into the stack above top */ 1421 {
1458 op->above = top->above; 1422 op->above = top->above;
1459
1460 if (op->above)
1461 op->above->below = op; 1423 top->above = op;
1462 1424
1463 op->below = top; 1425 op->below = top;
1464 top->above = op; 1426 *(op->above ? &op->above->below : &ms.top) = op;
1465 } 1427 }
1466 1428 }
1467 if (!op->above)
1468 ms.top = op;
1469 } /* else not INS_BELOW_ORIGINATOR */
1470 1429
1471 if (op->type == PLAYER) 1430 if (op->type == PLAYER)
1472 { 1431 {
1473 op->contr->do_los = 1; 1432 op->contr->do_los = 1;
1474 ++op->map->players; 1433 ++op->map->players;
1477 1436
1478 op->map->dirty = true; 1437 op->map->dirty = true;
1479 1438
1480 if (object *pl = ms.player ()) 1439 if (object *pl = ms.player ())
1481 //TODO: the floorbox prev/next might need updating 1440 //TODO: the floorbox prev/next might need updating
1482 esrv_send_item (pl, op); 1441 //esrv_send_item (pl, op);
1442 //TODO: update floorbox to preserve ordering
1443 if (pl->contr->ns)
1444 pl->contr->ns->floorbox_update ();
1483 1445
1484 /* If this object glows, it may affect lighting conditions that are 1446 /* If this object glows, it may affect lighting conditions that are
1485 * visible to others on this map. But update_all_los is really 1447 * visible to others on this map. But update_all_los is really
1486 * an inefficient way to do this, as it means los for all players 1448 * an inefficient way to do this, as it means los for all players
1487 * on the map will get recalculated. The players could very well 1449 * on the map will get recalculated. The players could very well
1567 if (!nr) 1529 if (!nr)
1568 return true; 1530 return true;
1569 1531
1570 nr = min (nr, nrof); 1532 nr = min (nr, nrof);
1571 1533
1534 if (nrof > nr)
1535 {
1572 nrof -= nr; 1536 nrof -= nr;
1573
1574 if (nrof)
1575 {
1576 adjust_weight (env, -weight * nr); // carrying == 0 1537 adjust_weight (env, -weight * max (1, nr)); // carrying == 0
1577 1538
1578 if (object *pl = visible_to ()) 1539 if (object *pl = visible_to ())
1579 esrv_update_item (UPD_NROF, pl, this); 1540 esrv_update_item (UPD_NROF, pl, this);
1580 1541
1581 return true; 1542 return true;
1582 } 1543 }
1583 else 1544 else
1584 { 1545 {
1585 destroy (1); 1546 destroy ();
1586 return false; 1547 return false;
1587 } 1548 }
1588} 1549}
1589 1550
1590/* 1551/*
1607 } 1568 }
1608 else 1569 else
1609 { 1570 {
1610 decrease (nr); 1571 decrease (nr);
1611 1572
1612 object *op = object_create_clone (this); 1573 object *op = deep_clone ();
1613 op->nrof = nr; 1574 op->nrof = nr;
1614 return op; 1575 return op;
1615 } 1576 }
1616} 1577}
1617 1578
1838 LOG (llevError, "Present_arch called outside map.\n"); 1799 LOG (llevError, "Present_arch called outside map.\n");
1839 return NULL; 1800 return NULL;
1840 } 1801 }
1841 1802
1842 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above) 1803 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1843 if (tmp->arch == at) 1804 if (tmp->arch->archname == at->archname)
1844 return tmp; 1805 return tmp;
1845 1806
1846 return NULL; 1807 return NULL;
1847} 1808}
1848 1809
1912 * The first matching object is returned, or NULL if none. 1873 * The first matching object is returned, or NULL if none.
1913 */ 1874 */
1914object * 1875object *
1915present_arch_in_ob (const archetype *at, const object *op) 1876present_arch_in_ob (const archetype *at, const object *op)
1916{ 1877{
1917 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below) 1878 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1918 if (tmp->arch == at) 1879 if (tmp->arch->archname == at->archname)
1919 return tmp; 1880 return tmp;
1920 1881
1921 return NULL; 1882 return NULL;
1922} 1883}
1923 1884
2332 2293
2333/* 2294/*
2334 * create clone from object to another 2295 * create clone from object to another
2335 */ 2296 */
2336object * 2297object *
2337object_create_clone (object *asrc) 2298object::deep_clone ()
2338{ 2299{
2339 object *dst = 0, *tmp, *src, *prev, *item; 2300 assert (("deep_clone called on non-head object", is_head ()));
2340 2301
2341 if (!asrc) 2302 object *dst = clone ();
2342 return 0;
2343 2303
2344 src = asrc->head_ (); 2304 object *prev = dst;
2345
2346 prev = 0;
2347 for (object *part = src; part; part = part->more) 2305 for (object *part = this->more; part; part = part->more)
2348 { 2306 {
2349 tmp = part->clone (); 2307 object *tmp = part->clone ();
2350 tmp->x -= src->x;
2351 tmp->y -= src->y;
2352
2353 if (!part->head)
2354 {
2355 dst = tmp;
2356 tmp->head = 0;
2357 }
2358 else
2359 tmp->head = dst; 2308 tmp->head = dst;
2360
2361 tmp->more = 0;
2362
2363 if (prev)
2364 prev->more = tmp; 2309 prev->more = tmp;
2365
2366 prev = tmp; 2310 prev = tmp;
2367 } 2311 }
2368 2312
2369 for (item = src->inv; item; item = item->below) 2313 for (object *item = inv; item; item = item->below)
2370 insert_ob_in_ob (object_create_clone (item), dst); 2314 insert_ob_in_ob (item->deep_clone (), dst);
2371 2315
2372 return dst; 2316 return dst;
2373} 2317}
2374 2318
2375/* This returns the first object in who's inventory that 2319/* This returns the first object in who's inventory that
2384 return tmp; 2328 return tmp;
2385 2329
2386 return 0; 2330 return 0;
2387} 2331}
2388 2332
2389/* If ob has a field named key, return the link from the list, 2333const shstr &
2390 * otherwise return NULL. 2334object::kv_get (const shstr &key) const
2391 *
2392 * key must be a passed in shared string - otherwise, this won't
2393 * do the desired thing.
2394 */
2395key_value *
2396get_ob_key_link (const object *ob, const char *key)
2397{ 2335{
2398 for (key_value *link = ob->key_values; link; link = link->next) 2336 for (key_value *kv = key_values; kv; kv = kv->next)
2399 if (link->key == key) 2337 if (kv->key == key)
2400 return link;
2401
2402 return 0;
2403}
2404
2405/*
2406 * Returns the value of op has an extra_field for key, or NULL.
2407 *
2408 * The argument doesn't need to be a shared string.
2409 *
2410 * The returned string is shared.
2411 */
2412const char *
2413get_ob_key_value (const object *op, const char *const key)
2414{
2415 key_value *link;
2416 shstr_cmp canonical_key (key);
2417
2418 if (!canonical_key)
2419 {
2420 /* 1. There being a field named key on any object
2421 * implies there'd be a shared string to find.
2422 * 2. Since there isn't, no object has this field.
2423 * 3. Therefore, *this* object doesn't have this field.
2424 */
2425 return 0;
2426 }
2427
2428 /* This is copied from get_ob_key_link() above -
2429 * only 4 lines, and saves the function call overhead.
2430 */
2431 for (link = op->key_values; link; link = link->next)
2432 if (link->key == canonical_key)
2433 return link->value; 2338 return kv->value;
2434 2339
2435 return 0; 2340 return shstr_null;
2436} 2341}
2437 2342
2438/* 2343void
2439 * Updates the canonical_key in op to value. 2344object::kv_set (const shstr &key, const shstr &value)
2440 *
2441 * canonical_key is a shared string (value doesn't have to be).
2442 *
2443 * Unless add_key is TRUE, it won't add fields, only change the value of existing
2444 * keys.
2445 *
2446 * Returns TRUE on success.
2447 */
2448int
2449set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2450{ 2345{
2451 key_value *field = NULL, *last = NULL; 2346 for (key_value *kv = key_values; kv; kv = kv->next)
2452 2347 if (kv->key == key)
2453 for (field = op->key_values; field != NULL; field = field->next)
2454 {
2455 if (field->key != canonical_key)
2456 { 2348 {
2457 last = field; 2349 kv->value = value;
2458 continue; 2350 return;
2459 } 2351 }
2460 2352
2461 if (value) 2353 key_value *kv = new key_value;
2462 field->value = value; 2354
2463 else 2355 kv->next = key_values;
2356 kv->key = key;
2357 kv->value = value;
2358
2359 key_values = kv;
2360}
2361
2362void
2363object::kv_del (const shstr &key)
2364{
2365 for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
2366 if ((*kvp)->key == key)
2464 { 2367 {
2465 /* Basically, if the archetype has this key set, 2368 key_value *kv = *kvp;
2466 * we need to store the null value so when we save 2369 *kvp = (*kvp)->next;
2467 * it, we save the empty value so that when we load, 2370 delete kv;
2468 * we get this value back again. 2371 return;
2469 */
2470 if (get_ob_key_link (op->arch, canonical_key))
2471 field->value = 0;
2472 else
2473 {
2474 if (last)
2475 last->next = field->next;
2476 else
2477 op->key_values = field->next;
2478
2479 delete field;
2480 }
2481 } 2372 }
2482 return TRUE;
2483 }
2484 /* IF we get here, key doesn't exist */
2485
2486 /* No field, we'll have to add it. */
2487
2488 if (!add_key)
2489 return FALSE;
2490
2491 /* There isn't any good reason to store a null
2492 * value in the key/value list. If the archetype has
2493 * this key, then we should also have it, so shouldn't
2494 * be here. If user wants to store empty strings,
2495 * should pass in ""
2496 */
2497 if (value == NULL)
2498 return TRUE;
2499
2500 field = new key_value;
2501
2502 field->key = canonical_key;
2503 field->value = value;
2504 /* Usual prepend-addition. */
2505 field->next = op->key_values;
2506 op->key_values = field;
2507
2508 return TRUE;
2509}
2510
2511/*
2512 * Updates the key in op to value.
2513 *
2514 * If add_key is FALSE, this will only update existing keys,
2515 * and not add new ones.
2516 * In general, should be little reason FALSE is ever passed in for add_key
2517 *
2518 * Returns TRUE on success.
2519 */
2520int
2521set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2522{
2523 shstr key_ (key);
2524
2525 return set_ob_key_value_s (op, key_, value, add_key);
2526} 2373}
2527 2374
2528object::depth_iterator::depth_iterator (object *container) 2375object::depth_iterator::depth_iterator (object *container)
2529: iterator_base (container) 2376: iterator_base (container)
2530{ 2377{
2580{ 2427{
2581 char flagdesc[512]; 2428 char flagdesc[512];
2582 char info2[256 * 4]; 2429 char info2[256 * 4];
2583 char *p = info; 2430 char *p = info;
2584 2431
2585 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s,flags:[%s],type:%d}", 2432 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2586 count, 2433 count,
2587 uuid.c_str (), 2434 uuid.c_str (),
2588 &name, 2435 &name,
2589 title ? "\",title:\"" : "", 2436 title ? ",title:\"" : "",
2590 title ? (const char *)title : "", 2437 title ? (const char *)title : "",
2438 title ? "\"" : "",
2591 flag_desc (flagdesc, 512), type); 2439 flag_desc (flagdesc, 512), type);
2592 2440
2593 if (!flag[FLAG_REMOVED] && env) 2441 if (!flag[FLAG_REMOVED] && env)
2594 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2442 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2595 2443

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines