ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.213 by root, Tue Apr 22 01:18:10 2008 UTC vs.
Revision 1.294 by root, Thu Nov 5 15:43:21 2009 UTC

1/* 1/*
2 * This file is part of Deliantra, the Roguelike Realtime MMORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team 4 * Copyright (©) 2005,2006,2007,2008,2009 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 * 7 *
8 * Deliantra is free software: you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify it under
9 * it under the terms of the GNU General Public License as published by 9 * the terms of the Affero GNU General Public License as published by the
10 * the Free Software Foundation, either version 3 of the License, or 10 * Free Software Foundation, either version 3 of the License, or (at your
11 * (at your option) any later version. 11 * option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the Affero GNU General Public License
19 * along with this program. If not, see <http://www.gnu.org/licenses/>. 19 * and the GNU General Public License along with this program. If not, see
20 * <http://www.gnu.org/licenses/>.
20 * 21 *
21 * The authors can be reached via e-mail to <support@deliantra.net> 22 * The authors can be reached via e-mail to <support@deliantra.net>
22 */ 23 */
23 24
24#include <global.h> 25#include <global.h>
32#include <bitset> 33#include <bitset>
33 34
34UUID UUID::cur; 35UUID UUID::cur;
35static uint64_t seq_next_save; 36static uint64_t seq_next_save;
36static const uint64 UUID_GAP = 1<<19; 37static const uint64 UUID_GAP = 1<<19;
38uint32_t mapspace::smellcount = 10000;
37 39
38objectvec objects; 40objectvec objects;
39activevec actives; 41activevec actives;
42
43//+GPL
40 44
41short freearr_x[SIZEOFFREE] = { 45short freearr_x[SIZEOFFREE] = {
42 0, 46 0,
43 0, 1, 1, 1, 0, -1, -1, -1, 47 0, 1, 1, 1, 0, -1, -1, -1,
44 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 48 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
139 143
140/* Returns TRUE if every key_values in wants has a partner with the same value in has. */ 144/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
141static bool 145static bool
142compare_ob_value_lists_one (const object *wants, const object *has) 146compare_ob_value_lists_one (const object *wants, const object *has)
143{ 147{
144 key_value *wants_field;
145
146 /* n-squared behaviour (see get_ob_key_link()), but I'm hoping both 148 /* n-squared behaviour (see kv_get), but I'm hoping both
147 * objects with lists are rare, and lists stay short. If not, use a 149 * objects with lists are rare, and lists stay short. If not, use a
148 * different structure or at least keep the lists sorted... 150 * different structure or at least keep the lists sorted...
149 */ 151 */
150 152
151 /* For each field in wants, */ 153 /* For each field in wants, */
152 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next) 154 for (key_value *kv = wants->key_values; kv; kv = kv->next)
153 { 155 if (has->kv_get (kv->key) != kv->value)
154 key_value *has_field; 156 return false;
155
156 /* Look for a field in has with the same key. */
157 has_field = get_ob_key_link (has, wants_field->key);
158
159 if (!has_field)
160 return 0; /* No field with that name. */
161
162 /* Found the matching field. */
163 if (has_field->value != wants_field->value)
164 return 0; /* Values don't match, so this half of the comparison is false. */
165
166 /* If we get here, we found a match. Now for the next field in wants. */
167 }
168 157
169 /* If we get here, every field in wants has a matching field in has. */ 158 /* If we get here, every field in wants has a matching field in has. */
170 return 1; 159 return true;
171} 160}
172 161
173/* Returns TRUE if ob1 has the same key_values as ob2. */ 162/* Returns TRUE if ob1 has the same key_values as ob2. */
174static bool 163static bool
175compare_ob_value_lists (const object *ob1, const object *ob2) 164compare_ob_value_lists (const object *ob1, const object *ob2)
176{ 165{
177 /* However, there may be fields in has which aren't partnered in wants, 166 /* However, there may be fields in has which aren't partnered in wants,
178 * so we need to run the comparison *twice*. :( 167 * so we need to run the comparison *twice*. :(
179 */ 168 */
180 return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1); 169 return compare_ob_value_lists_one (ob1, ob2)
170 && compare_ob_value_lists_one (ob2, ob1);
181} 171}
182 172
183/* Function examines the 2 objects given to it, and returns true if 173/* Function examines the 2 objects given to it, and returns true if
184 * they can be merged together. 174 * they can be merged together.
185 * 175 *
200 || ob1->speed != ob2->speed 190 || ob1->speed != ob2->speed
201 || ob1->value != ob2->value 191 || ob1->value != ob2->value
202 || ob1->name != ob2->name) 192 || ob1->name != ob2->name)
203 return 0; 193 return 0;
204 194
205 /* Do not merge objects if nrof would overflow. First part checks 195 /* Do not merge objects if nrof would overflow, assume nrof
206 * for unsigned overflow (2c), second part checks whether the result 196 * is always 0 .. 2**31-1 */
207 * would fit into a 32 bit signed int, which is often used to hold 197 if (ob1->nrof > 0x7fffffff - ob2->nrof)
208 * nrof values.
209 */
210 if (~ob1->nrof < ob2->nrof || ob1->nrof + ob2->nrof > (1UL << 31))
211 return 0; 198 return 0;
212 199
213 /* If the objects have been identified, set the BEEN_APPLIED flag. 200 /* If the objects have been identified, set the BEEN_APPLIED flag.
214 * This is to the comparison of the flags below will be OK. We 201 * This is to the comparison of the flags below will be OK. We
215 * just can't ignore the been applied or identified flags, as they 202 * just can't ignore the been applied or identified flags, as they
220 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 207 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
221 208
222 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 209 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
223 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 210 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
224 211
225 if (ob1->arch->name != ob2->arch->name 212 if (ob1->arch->archname != ob2->arch->archname
226 || ob1->name != ob2->name 213 || ob1->name != ob2->name
227 || ob1->title != ob2->title 214 || ob1->title != ob2->title
228 || ob1->msg != ob2->msg 215 || ob1->msg != ob2->msg
229 || ob1->weight != ob2->weight 216 || ob1->weight != ob2->weight
230 || ob1->attacktype != ob2->attacktype 217 || ob1->attacktype != ob2->attacktype
231 || ob1->magic != ob2->magic 218 || ob1->magic != ob2->magic
232 || ob1->slaying != ob2->slaying 219 || ob1->slaying != ob2->slaying
233 || ob1->skill != ob2->skill 220 || ob1->skill != ob2->skill
234 || ob1->value != ob2->value 221 || ob1->value != ob2->value
235 || ob1->animation_id != ob2->animation_id 222 || ob1->animation_id != ob2->animation_id
223 || (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependent on each other
236 || ob1->client_type != ob2->client_type 224 || ob1->client_type != ob2->client_type
237 || ob1->materialname != ob2->materialname 225 || ob1->materialname != ob2->materialname
238 || ob1->lore != ob2->lore 226 || ob1->lore != ob2->lore
239 || ob1->subtype != ob2->subtype 227 || ob1->subtype != ob2->subtype
240 || ob1->move_type != ob2->move_type 228 || ob1->move_type != ob2->move_type
248 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats))) 236 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
249 return 0; 237 return 0;
250 238
251 if ((ob1->flag ^ ob2->flag) 239 if ((ob1->flag ^ ob2->flag)
252 .reset (FLAG_INV_LOCKED) 240 .reset (FLAG_INV_LOCKED)
253 .reset (FLAG_CLIENT_SENT)
254 .reset (FLAG_REMOVED) 241 .reset (FLAG_REMOVED)
255 .any ()) 242 .any ())
256 return 0; 243 return 0;
257 244
258 /* This is really a spellbook check - we should in general 245 /* This is really a spellbook check - we should in general
330 317
331 /* Everything passes, must be OK. */ 318 /* Everything passes, must be OK. */
332 return 1; 319 return 1;
333} 320}
334 321
322// find player who can see this object
323object *
324object::visible_to () const
325{
326 if (client_visible () && !flag [FLAG_REMOVED])
327 {
328 // see if we are in a container of sorts
329 if (env)
330 {
331 // the player inventory itself is always visible
332 if (env->is_player ())
333 return env;
334
335 // else a player could have our env open
336 object *envest = env->outer_env_or_self ();
337
338 // the player itself is always on a map, so we will find him here
339 // even if our inv is in a player.
340 if (envest->is_on_map ())
341 if (object *pl = envest->ms ().player ())
342 if (pl->container_ () == env)
343 return pl;
344 }
345 else
346 {
347 // maybe there is a player standing on the same mapspace
348 // this will catch the case where "this" is a player
349 if (object *pl = ms ().player ())
350 if ((pl->contr->ns && !pl->container_ () && !pl->contr->ns->update_look)
351 || pl->container_ () == this)
352 return pl;
353 }
354 }
355
356 return 0;
357}
358
335// adjust weight per container type ("of holding") 359// adjust weight per container type ("of holding")
336static sint32 360static sint32
337weight_adjust (object *op, sint32 weight) 361weight_adjust_for (object *op, sint32 weight)
338{ 362{
339 return op->type == CONTAINER 363 return op->type == CONTAINER
340 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str) 364 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str)
341 : weight; 365 : weight;
342} 366}
348static void 372static void
349adjust_weight (object *op, sint32 weight) 373adjust_weight (object *op, sint32 weight)
350{ 374{
351 while (op) 375 while (op)
352 { 376 {
377 // adjust by actual difference to account for rounding errors
378 // i.e. (w2 - w1) / f != w2 / f - w1 / f and the latter is correct
353 weight = weight_adjust (op, weight); 379 weight = weight_adjust_for (op, op->carrying)
380 - weight_adjust_for (op, op->carrying - weight);
354 381
355 if (!weight) 382 if (!weight)
356 return; 383 return;
357 384
358 op->carrying += weight; 385 op->carrying += weight;
359 386
360 if (object *pl = op->visible_to ()) 387 if (object *pl = op->visible_to ())
388 if (pl != op) // player is handled lazily
361 esrv_update_item (UPD_WEIGHT, pl, op); 389 esrv_update_item (UPD_WEIGHT, pl, op);
362 390
363 op = op->env; 391 op = op->env;
364 } 392 }
365} 393}
366 394
380 op->update_weight (); 408 op->update_weight ();
381 409
382 sum += op->total_weight (); 410 sum += op->total_weight ();
383 } 411 }
384 412
385 sum = weight_adjust (this, sum); 413 sum = weight_adjust_for (this, sum);
386 414
387 if (sum != carrying) 415 if (sum != carrying)
388 { 416 {
389 carrying = sum; 417 carrying = sum;
390 418
391 if (object *pl = visible_to ()) 419 if (object *pl = visible_to ())
420 if (pl != this) // player is handled lazily
392 esrv_update_item (UPD_WEIGHT, pl, this); 421 esrv_update_item (UPD_WEIGHT, pl, this);
393 } 422 }
394} 423}
395 424
396/* 425/*
397 * Used by: Server DM commands: dumpbelow, dump. Some error messages. 426 * Used by: Server DM commands: dumpbelow, dump. Some error messages.
403 return strdup ("[NULLOBJ]"); 432 return strdup ("[NULLOBJ]");
404 433
405 object_freezer freezer; 434 object_freezer freezer;
406 op->write (freezer); 435 op->write (freezer);
407 return freezer.as_string (); 436 return freezer.as_string ();
437}
438
439char *
440object::as_string ()
441{
442 return dump_object (this);
408} 443}
409 444
410/* 445/*
411 * get_nearest_part(multi-object, object 2) returns the part of the 446 * get_nearest_part(multi-object, object 2) returns the part of the
412 * multi-object 1 which is closest to the second object. 447 * multi-object 1 which is closest to the second object.
451 */ 486 */
452object * 487object *
453find_object_name (const char *str) 488find_object_name (const char *str)
454{ 489{
455 shstr_cmp str_ (str); 490 shstr_cmp str_ (str);
456 object *op;
457 491
492 if (str_)
458 for_all_objects (op) 493 for_all_objects (op)
459 if (op->name == str_) 494 if (op->name == str_)
460 break; 495 return op;
461 496
462 return op; 497 return 0;
463} 498}
464 499
465/* 500/*
466 * Sets the owner and sets the skill and exp pointers to owner's current 501 * Sets the owner and sets the skill and exp pointers to owner's current
467 * skill and experience objects. 502 * skill and experience objects.
529 update_stats (); 564 update_stats ();
530 565
531 new_draw_info_format (NDI_UNIQUE, 0, this, 566 new_draw_info_format (NDI_UNIQUE, 0, this,
532 "You try to balance all your items at once, " 567 "You try to balance all your items at once, "
533 "but the %s is just too much for your body. " 568 "but the %s is just too much for your body. "
534 "[You need to unapply some items first.]", &ob->name); 569 "[You need to unapply some items first - use the 'body' command to see "
570 "how many items you cna wera on a specific body part.]", &ob->name);
535 return false; 571 return false;
536 } 572 }
537 573
538 //new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name); 574 //new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name);
539 } 575 }
565 } 601 }
566 602
567 op->key_values = 0; 603 op->key_values = 0;
568} 604}
569 605
570object & 606/*
571object::operator =(const object &src) 607 * copy_to first frees everything allocated by the dst object,
608 * and then copies the contents of itself into the second
609 * object, allocating what needs to be allocated. Basically, any
610 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
611 * if the first object is freed, the pointers in the new object
612 * will point at garbage.
613 */
614void
615object::copy_to (object *dst)
572{ 616{
573 bool is_freed = flag [FLAG_FREED]; 617 dst->remove ();
574 bool is_removed = flag [FLAG_REMOVED];
575
576 *(object_copy *)this = src; 618 *(object_copy *)dst = *this;
577
578 flag [FLAG_FREED] = is_freed;
579 flag [FLAG_REMOVED] = is_removed; 619 dst->flag [FLAG_REMOVED] = true;
580 620
581 /* Copy over key_values, if any. */ 621 /* Copy over key_values, if any. */
582 if (src.key_values) 622 if (key_values)
583 { 623 {
584 key_value *tail = 0; 624 key_value *tail = 0;
585 key_values = 0; 625 dst->key_values = 0;
586 626
587 for (key_value *i = src.key_values; i; i = i->next) 627 for (key_value *i = key_values; i; i = i->next)
588 { 628 {
589 key_value *new_link = new key_value; 629 key_value *new_link = new key_value;
590 630
591 new_link->next = 0; 631 new_link->next = 0;
592 new_link->key = i->key; 632 new_link->key = i->key;
593 new_link->value = i->value; 633 new_link->value = i->value;
594 634
595 /* Try and be clever here, too. */ 635 /* Try and be clever here, too. */
596 if (!key_values) 636 if (!dst->key_values)
597 { 637 {
598 key_values = new_link; 638 dst->key_values = new_link;
599 tail = new_link; 639 tail = new_link;
600 } 640 }
601 else 641 else
602 { 642 {
603 tail->next = new_link; 643 tail->next = new_link;
604 tail = new_link; 644 tail = new_link;
605 } 645 }
606 } 646 }
607 } 647 }
608}
609
610/*
611 * copy_to first frees everything allocated by the dst object,
612 * and then copies the contents of itself into the second
613 * object, allocating what needs to be allocated. Basically, any
614 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
615 * if the first object is freed, the pointers in the new object
616 * will point at garbage.
617 */
618void
619object::copy_to (object *dst)
620{
621 *dst = *this;
622 648
623 if (speed < 0) 649 if (speed < 0)
624 dst->speed_left -= rndm (); 650 dst->speed_left -= rndm ();
625 651
626 dst->set_speed (dst->speed); 652 dst->activate ();
627} 653}
628 654
629void 655void
630object::instantiate () 656object::instantiate ()
631{ 657{
648object * 674object *
649object::clone () 675object::clone ()
650{ 676{
651 object *neu = create (); 677 object *neu = create ();
652 copy_to (neu); 678 copy_to (neu);
679 neu->map = map; // not copied by copy_to
653 return neu; 680 return neu;
654} 681}
655 682
656/* 683/*
657 * If an object with the IS_TURNABLE() flag needs to be turned due 684 * If an object with the IS_TURNABLE() flag needs to be turned due
708 * UP_OBJ_FACE: only the objects face has changed. 735 * UP_OBJ_FACE: only the objects face has changed.
709 */ 736 */
710void 737void
711update_object (object *op, int action) 738update_object (object *op, int action)
712{ 739{
713 if (op == NULL) 740 if (!op)
714 { 741 {
715 /* this should never happen */ 742 /* this should never happen */
716 LOG (llevDebug, "update_object() called for NULL object.\n"); 743 LOG (llevError | logBacktrace, "update_object() called for NULL object.\n");
717 return; 744 return;
718 } 745 }
719 746
720 if (op->env) 747 if (!op->is_on_map ())
721 { 748 {
722 /* Animation is currently handled by client, so nothing 749 /* Animation is currently handled by client, so nothing
723 * to do in this case. 750 * to do in this case.
724 */ 751 */
725 return; 752 return;
726 } 753 }
727
728 /* If the map is saving, don't do anything as everything is
729 * going to get freed anyways.
730 */
731 if (!op->map || op->map->in_memory == MAP_SAVING)
732 return;
733 754
734 /* make sure the object is within map boundaries */ 755 /* make sure the object is within map boundaries */
735 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height) 756 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
736 { 757 {
737 LOG (llevError, "update_object() called for object out of map!\n"); 758 LOG (llevError, "update_object() called for object out of map!\n");
748 else if (action == UP_OBJ_INSERT) 769 else if (action == UP_OBJ_INSERT)
749 { 770 {
750 // this is likely overkill, TODO: revisit (schmorp) 771 // this is likely overkill, TODO: revisit (schmorp)
751 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW)) 772 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
752 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC)) 773 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
753 || (op->type == PLAYER && !(m.flags_ & P_PLAYER)) 774 || (op->is_player () && !(m.flags_ & P_PLAYER))
754 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE)) 775 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
755 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE)) 776 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
756 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC)) 777 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
757 || (m.move_on | op->move_on ) != m.move_on 778 || (m.move_on | op->move_on ) != m.move_on
758 || (m.move_off | op->move_off ) != m.move_off 779 || (m.move_off | op->move_off ) != m.move_off
759 || (m.move_slow | op->move_slow) != m.move_slow 780 || (m.move_slow | op->move_slow) != m.move_slow
760 /* This isn't perfect, but I don't expect a lot of objects to 781 /* This isn't perfect, but I don't expect a lot of objects to
761 * to have move_allow right now. 782 * have move_allow right now.
762 */ 783 */
763 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block 784 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
764 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp) 785 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
765 m.flags_ = 0; 786 m.invalidate ();
766 } 787 }
767 /* if the object is being removed, we can't make intelligent 788 /* if the object is being removed, we can't make intelligent
768 * decisions, because remove_ob can't really pass the object 789 * decisions, because remove_ob can't really pass the object
769 * that is being removed. 790 * that is being removed.
770 */ 791 */
771 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 792 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
772 m.flags_ = 0; 793 m.invalidate ();
773 else if (action == UP_OBJ_FACE) 794 else if (action == UP_OBJ_FACE)
774 /* Nothing to do for that case */ ; 795 /* Nothing to do for that case */ ;
775 else 796 else
776 LOG (llevError, "update_object called with invalid action: %d\n", action); 797 LOG (llevError, "update_object called with invalid action: %d\n", action);
777 798
781 802
782object::object () 803object::object ()
783{ 804{
784 SET_FLAG (this, FLAG_REMOVED); 805 SET_FLAG (this, FLAG_REMOVED);
785 806
786 expmul = 1.0; 807 //expmul = 1.0; declared const for the time being
787 face = blank_face; 808 face = blank_face;
788} 809}
789 810
790object::~object () 811object::~object ()
791{ 812{
821 /* If already on active list, don't do anything */ 842 /* If already on active list, don't do anything */
822 if (active) 843 if (active)
823 return; 844 return;
824 845
825 if (has_active_speed ()) 846 if (has_active_speed ())
847 {
848 if (flag [FLAG_FREED])
849 LOG (llevError | logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
850
826 actives.insert (this); 851 actives.insert (this);
852 }
827} 853}
828 854
829void 855void
830object::activate_recursive () 856object::activate_recursive ()
831{ 857{
880object::destroy_inv (bool drop_to_ground) 906object::destroy_inv (bool drop_to_ground)
881{ 907{
882 // need to check first, because the checks below might segfault 908 // need to check first, because the checks below might segfault
883 // as we might be on an invalid mapspace and crossfire code 909 // as we might be on an invalid mapspace and crossfire code
884 // is too buggy to ensure that the inventory is empty. 910 // is too buggy to ensure that the inventory is empty.
885 // corollary: if you create arrows etc. with stuff in tis inventory, 911 // corollary: if you create arrows etc. with stuff in its inventory,
886 // cf will crash below with off-map x and y 912 // cf will crash below with off-map x and y
887 if (!inv) 913 if (!inv)
888 return; 914 return;
889 915
890 /* Only if the space blocks everything do we not process - 916 /* Only if the space blocks everything do we not process -
892 * drop on that space. 918 * drop on that space.
893 */ 919 */
894 if (!drop_to_ground 920 if (!drop_to_ground
895 || !map 921 || !map
896 || map->in_memory != MAP_ACTIVE 922 || map->in_memory != MAP_ACTIVE
897 || map->nodrop 923 || map->no_drop
898 || ms ().move_block == MOVE_ALL) 924 || ms ().move_block == MOVE_ALL)
899 { 925 {
900 while (inv) 926 while (inv)
901 {
902 inv->destroy_inv (drop_to_ground);
903 inv->destroy (); 927 inv->destroy ();
904 }
905 } 928 }
906 else 929 else
907 { /* Put objects in inventory onto this space */ 930 { /* Put objects in inventory onto this space */
908 while (inv) 931 while (inv)
909 { 932 {
927 object *op = new object; 950 object *op = new object;
928 op->link (); 951 op->link ();
929 return op; 952 return op;
930} 953}
931 954
955static struct freed_map : maptile
956{
957 freed_map ()
958 {
959 path = "<freed objects map>";
960 name = "/internal/freed_objects_map";
961 width = 3;
962 height = 3;
963 no_drop = 1;
964 no_reset = 1;
965
966 alloc ();
967 in_memory = MAP_ACTIVE;
968 }
969
970 ~freed_map ()
971 {
972 destroy ();
973 }
974} freed_map; // freed objects are moved here to avoid crashes
975
932void 976void
933object::do_destroy () 977object::do_destroy ()
934{ 978{
935 if (flag [FLAG_IS_LINKED]) 979 if (flag [FLAG_IS_LINKED])
936 remove_button_link (this); 980 remove_link ();
937 981
938 if (flag [FLAG_FRIENDLY]) 982 if (flag [FLAG_FRIENDLY])
939 remove_friendly_object (this); 983 remove_friendly_object (this);
940 984
941 remove (); 985 remove ();
942 986
943 attachable::do_destroy (); 987 attachable::do_destroy ();
944 988
945 destroy_inv (true);
946
947 deactivate (); 989 deactivate ();
948 unlink (); 990 unlink ();
949 991
950 flag [FLAG_FREED] = 1; 992 flag [FLAG_FREED] = 1;
951 993
952 // hack to ensure that freed objects still have a valid map 994 // hack to ensure that freed objects still have a valid map
953 {
954 static maptile *freed_map; // freed objects are moved here to avoid crashes
955
956 if (!freed_map)
957 {
958 freed_map = new maptile;
959
960 freed_map->path = "<freed objects map>";
961 freed_map->name = "/internal/freed_objects_map";
962 freed_map->width = 3;
963 freed_map->height = 3;
964 freed_map->nodrop = 1;
965
966 freed_map->alloc ();
967 freed_map->in_memory = MAP_ACTIVE;
968 }
969
970 map = freed_map; 995 map = &freed_map;
971 x = 1; 996 x = 1;
972 y = 1; 997 y = 1;
973 }
974 998
975 if (more) 999 if (more)
976 { 1000 {
977 more->destroy (); 1001 more->destroy ();
978 more = 0; 1002 more = 0;
986 attacked_by = 0; 1010 attacked_by = 0;
987 current_weapon = 0; 1011 current_weapon = 0;
988} 1012}
989 1013
990void 1014void
991object::destroy (bool destroy_inventory) 1015object::destroy ()
992{ 1016{
993 if (destroyed ()) 1017 if (destroyed ())
994 return; 1018 return;
995 1019
996 if (destroy_inventory) 1020 if (!is_head () && !head->destroyed ())
1021 {
1022 LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
1023 head->destroy ();
1024 return;
1025 }
1026
997 destroy_inv (false); 1027 destroy_inv (false);
998 1028
999 if (is_head ()) 1029 if (is_head ())
1000 if (sound_destroy) 1030 if (sound_destroy)
1001 play_sound (sound_destroy); 1031 play_sound (sound_destroy);
1002 else if (flag [FLAG_MONSTER]) 1032 else if (flag [FLAG_MONSTER])
1013 * the previous environment. 1043 * the previous environment.
1014 */ 1044 */
1015void 1045void
1016object::do_remove () 1046object::do_remove ()
1017{ 1047{
1018 object *tmp, *last = 0;
1019 object *otmp;
1020
1021 if (flag [FLAG_REMOVED]) 1048 if (flag [FLAG_REMOVED])
1022 return; 1049 return;
1023 1050
1024 INVOKE_OBJECT (REMOVE, this); 1051 INVOKE_OBJECT (REMOVE, this);
1025
1026 if (object *pl = visible_to ())
1027 esrv_del_item (pl->contr, count);
1028 1052
1029 flag [FLAG_REMOVED] = true; 1053 flag [FLAG_REMOVED] = true;
1030 1054
1031 if (more) 1055 if (more)
1032 more->remove (); 1056 more->remove ();
1035 * In this case, the object to be removed is in someones 1059 * In this case, the object to be removed is in someones
1036 * inventory. 1060 * inventory.
1037 */ 1061 */
1038 if (env) 1062 if (env)
1039 { 1063 {
1064 flag [FLAG_REMOVED] = false; // hack around the issue of visible_to checking flag_removed
1065 if (object *pl = visible_to ())
1066 esrv_del_item (pl->contr, count);
1067 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
1068
1040 adjust_weight (env, -total_weight ()); 1069 adjust_weight (env, -total_weight ());
1041 1070
1042 *(above ? &above->below : &env->inv) = below; 1071 object *pl = in_player ();
1043
1044 if (below)
1045 below->above = above;
1046 1072
1047 /* we set up values so that it could be inserted into 1073 /* we set up values so that it could be inserted into
1048 * the map, but we don't actually do that - it is up 1074 * the map, but we don't actually do that - it is up
1049 * to the caller to decide what we want to do. 1075 * to the caller to decide what we want to do.
1050 */ 1076 */
1051 map = env->map; 1077 map = env->map;
1052 x = env->x; 1078 x = env->x;
1053 y = env->y; 1079 y = env->y;
1080
1081 // make sure cmov optimisation is applicable
1082 *(above ? &above->below : &env->inv) = below;
1083 *(below ? &below->above : &above ) = above; // &above is just a dummy
1084
1054 above = 0; 1085 above = 0;
1055 below = 0; 1086 below = 0;
1056 env = 0; 1087 env = 0;
1057 1088
1058 /* NO_FIX_PLAYER is set when a great many changes are being 1089 /* NO_FIX_PLAYER is set when a great many changes are being
1059 * made to players inventory. If set, avoiding the call 1090 * made to players inventory. If set, avoiding the call
1060 * to save cpu time. 1091 * to save cpu time.
1061 */ 1092 */
1062 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1093 if (pl)
1094 if (pl->is_player () && (glow_radius || !QUERY_FLAG (pl, FLAG_NO_FIX_PLAYER)))
1095 {
1063 otmp->update_stats (); 1096 pl->update_stats ();
1097
1098 if (glow_radius && pl->is_on_map ())
1099 update_all_los (pl->map, pl->x, pl->y);
1100 }
1064 } 1101 }
1065 else if (map) 1102 else if (map)
1066 { 1103 {
1067 if (type == PLAYER)
1068 {
1069 // leaving a spot always closes any open container on the ground
1070 if (container && !container->env)
1071 // this causes spurious floorbox updates, but it ensures
1072 // that the CLOSE event is being sent.
1073 close_container ();
1074
1075 --map->players;
1076 map->touch ();
1077 }
1078
1079 map->dirty = true; 1104 map->dirty = true;
1080 mapspace &ms = this->ms (); 1105 mapspace &ms = this->ms ();
1081 1106
1107 if (object *pl = ms.player ())
1108 {
1109 if (is_player ())
1110 {
1111 if (!flag [FLAG_WIZPASS])
1112 ms.smell = ++mapspace::smellcount; // remember the smell of the player
1113
1114 // leaving a spot always closes any open container on the ground
1115 if (container && !container->env)
1116 // this causes spurious floorbox updates, but it ensures
1117 // that the CLOSE event is being sent.
1118 close_container ();
1119
1120 --map->players;
1121 map->touch ();
1122 }
1123 else if (pl->container_ () == this)
1124 {
1125 // removing a container should close it
1126 close_container ();
1127 }
1128
1129 esrv_del_item (pl->contr, count);
1130 }
1131
1082 /* link the object above us */ 1132 /* link the object above us */
1083 if (above) 1133 // re-link, make sure compiler can easily use cmove
1084 above->below = below; 1134 *(above ? &above->below : &ms.top) = below;
1085 else 1135 *(below ? &below->above : &ms.bot) = above;
1086 ms.top = below; /* we were top, set new top */
1087
1088 /* Relink the object below us, if there is one */
1089 if (below)
1090 below->above = above;
1091 else
1092 {
1093 /* Nothing below, which means we need to relink map object for this space
1094 * use translated coordinates in case some oddness with map tiling is
1095 * evident
1096 */
1097 if (GET_MAP_OB (map, x, y) != this)
1098 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1099
1100 ms.bot = above; /* goes on above it. */
1101 }
1102 1136
1103 above = 0; 1137 above = 0;
1104 below = 0; 1138 below = 0;
1105 1139
1140 ms.invalidate ();
1141
1106 if (map->in_memory == MAP_SAVING) 1142 if (map->in_memory == MAP_SAVING)
1107 return; 1143 return;
1108 1144
1109 int check_walk_off = !flag [FLAG_NO_APPLY]; 1145 int check_walk_off = !flag [FLAG_NO_APPLY];
1110 1146
1111 if (object *pl = ms.player ()) 1147 if (object *pl = ms.player ())
1112 { 1148 {
1113 if (pl->container == this) 1149 if (pl->container_ () == this)
1114 /* If a container that the player is currently using somehow gets 1150 /* If a container that the player is currently using somehow gets
1115 * removed (most likely destroyed), update the player view 1151 * removed (most likely destroyed), update the player view
1116 * appropriately. 1152 * appropriately.
1117 */ 1153 */
1118 pl->close_container (); 1154 pl->close_container ();
1119 1155
1156 //TODO: the floorbox prev/next might need updating
1157 //esrv_del_item (pl->contr, count);
1158 //TODO: update floorbox to preserve ordering
1159 if (pl->contr->ns)
1120 pl->contr->ns->floorbox_update (); 1160 pl->contr->ns->floorbox_update ();
1121 } 1161 }
1122 1162
1163 if (check_walk_off)
1123 for (tmp = ms.bot; tmp; tmp = tmp->above) 1164 for (object *above, *tmp = ms.bot; tmp; tmp = above)
1124 { 1165 {
1166 above = tmp->above;
1167
1125 /* No point updating the players look faces if he is the object 1168 /* No point updating the players look faces if he is the object
1126 * being removed. 1169 * being removed.
1127 */ 1170 */
1128 1171
1129 /* See if object moving off should effect something */ 1172 /* See if object moving off should effect something */
1130 if (check_walk_off
1131 && ((move_type & tmp->move_off) 1173 if ((move_type & tmp->move_off)
1132 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1174 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)
1133 {
1134 move_apply (tmp, this, 0); 1175 move_apply (tmp, this, 0);
1135
1136 if (destroyed ())
1137 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1138 } 1176 }
1139 1177
1140 last = tmp; 1178 if (affects_los ())
1141 }
1142
1143 /* last == NULL if there are no objects on this space */
1144 //TODO: this makes little sense, why only update the topmost object?
1145 if (!last)
1146 map->at (x, y).flags_ = 0;
1147 else
1148 update_object (last, UP_OBJ_REMOVE);
1149
1150 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1151 update_all_los (map, x, y); 1179 update_all_los (map, x, y);
1152 } 1180 }
1153} 1181}
1154 1182
1155/* 1183/*
1169 if (!top) 1197 if (!top)
1170 for (top = op; top && top->above; top = top->above) 1198 for (top = op; top && top->above; top = top->above)
1171 ; 1199 ;
1172 1200
1173 for (; top; top = top->below) 1201 for (; top; top = top->below)
1174 {
1175 if (top == op)
1176 continue;
1177
1178 if (object::can_merge (op, top)) 1202 if (object::can_merge (op, top))
1179 { 1203 {
1180 top->nrof += op->nrof; 1204 top->nrof += op->nrof;
1181 1205
1182/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/ 1206 if (object *pl = top->visible_to ())
1183 op->weight = 0; /* Don't want any adjustements now */ 1207 esrv_update_item (UPD_NROF, pl, top);
1208
1209 op->weight = 0; // cancel the addition above
1210 op->carrying = 0; // must be 0 already
1211
1184 op->destroy (); 1212 op->destroy ();
1213
1185 return top; 1214 return top;
1186 } 1215 }
1187 }
1188 1216
1189 return 0; 1217 return 0;
1190} 1218}
1191 1219
1192void 1220void
1217 * job preparing multi-part monsters. 1245 * job preparing multi-part monsters.
1218 */ 1246 */
1219object * 1247object *
1220insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1248insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1221{ 1249{
1250 op->remove ();
1251
1222 for (object *tmp = op->head_ (); tmp; tmp = tmp->more) 1252 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1223 { 1253 {
1224 tmp->x = x + tmp->arch->x; 1254 tmp->x = x + tmp->arch->x;
1225 tmp->y = y + tmp->arch->y; 1255 tmp->y = y + tmp->arch->y;
1226 } 1256 }
1249 * just 'op' otherwise 1279 * just 'op' otherwise
1250 */ 1280 */
1251object * 1281object *
1252insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1282insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1253{ 1283{
1254 assert (!op->flag [FLAG_FREED]);
1255
1256 object *top, *floor = NULL;
1257
1258 op->remove (); 1284 op->remove ();
1285
1286 if (m == &freed_map)//D TODO: remove soon
1287 {//D
1288 LOG (llevError | logBacktrace, "tries to insret object on freed objects map: %s", op->debug_desc ());//D
1289 }//D
1259 1290
1260 /* Ideally, the caller figures this out. However, it complicates a lot 1291 /* Ideally, the caller figures this out. However, it complicates a lot
1261 * of areas of callers (eg, anything that uses find_free_spot would now 1292 * of areas of callers (eg, anything that uses find_free_spot would now
1262 * need extra work 1293 * need extra work
1263 */ 1294 */
1295 maptile *newmap = m;
1264 if (!xy_normalise (m, op->x, op->y)) 1296 if (!xy_normalise (newmap, op->x, op->y))
1265 { 1297 {
1266 op->destroy (); 1298 op->head_ ()->destroy ();// remove head_ once all tail object destroyers found
1267 return 0; 1299 return 0;
1268 } 1300 }
1269 1301
1270 if (object *more = op->more) 1302 if (object *more = op->more)
1271 if (!insert_ob_in_map (more, m, originator, flag)) 1303 if (!insert_ob_in_map (more, m, originator, flag))
1272 return 0; 1304 return 0;
1273 1305
1274 CLEAR_FLAG (op, FLAG_REMOVED); 1306 op->flag [FLAG_REMOVED] = false;
1275 1307 op->env = 0;
1276 op->map = m; 1308 op->map = newmap;
1309
1277 mapspace &ms = op->ms (); 1310 mapspace &ms = op->ms ();
1278 1311
1279 /* this has to be done after we translate the coordinates. 1312 /* this has to be done after we translate the coordinates.
1280 */ 1313 */
1281 if (op->nrof && !(flag & INS_NO_MERGE)) 1314 if (op->nrof && !(flag & INS_NO_MERGE))
1282 for (object *tmp = ms.bot; tmp; tmp = tmp->above) 1315 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1283 if (object::can_merge (op, tmp)) 1316 if (object::can_merge (op, tmp))
1284 { 1317 {
1318 // TODO: we actually want to update tmp, not op,
1319 // but some caller surely breaks when we return tmp
1320 // from here :/
1285 op->nrof += tmp->nrof; 1321 op->nrof += tmp->nrof;
1286 tmp->destroy (1); 1322 tmp->destroy ();
1287 } 1323 }
1288 1324
1289 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1325 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1290 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1326 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1291 1327
1298 { 1334 {
1299 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n"); 1335 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1300 abort (); 1336 abort ();
1301 } 1337 }
1302 1338
1339 if (!originator->is_on_map ())
1340 {
1341 LOG (llevError, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
1342 op->debug_desc (), originator->debug_desc ());
1343 abort ();
1344 }
1345
1303 op->above = originator; 1346 op->above = originator;
1304 op->below = originator->below; 1347 op->below = originator->below;
1305
1306 if (op->below)
1307 op->below->above = op;
1308 else
1309 ms.bot = op;
1310
1311 /* since *below* originator, no need to update top */
1312 originator->below = op; 1348 originator->below = op;
1349
1350 *(op->below ? &op->below->above : &ms.bot) = op;
1313 } 1351 }
1314 else 1352 else
1315 { 1353 {
1316 top = ms.bot; 1354 object *floor = 0;
1355 object *top = ms.top;
1317 1356
1318 /* If there are other objects, then */ 1357 /* If there are other objects, then */
1319 if (top) 1358 if (top)
1320 { 1359 {
1321 object *last = 0;
1322
1323 /* 1360 /*
1324 * If there are multiple objects on this space, we do some trickier handling. 1361 * If there are multiple objects on this space, we do some trickier handling.
1325 * We've already dealt with merging if appropriate. 1362 * We've already dealt with merging if appropriate.
1326 * Generally, we want to put the new object on top. But if 1363 * Generally, we want to put the new object on top. But if
1327 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last 1364 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
1330 * once we get to them. This reduces the need to traverse over all of 1367 * once we get to them. This reduces the need to traverse over all of
1331 * them when adding another one - this saves quite a bit of cpu time 1368 * them when adding another one - this saves quite a bit of cpu time
1332 * when lots of spells are cast in one area. Currently, it is presumed 1369 * when lots of spells are cast in one area. Currently, it is presumed
1333 * that flying non pickable objects are spell objects. 1370 * that flying non pickable objects are spell objects.
1334 */ 1371 */
1335 for (top = ms.bot; top; top = top->above) 1372 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1336 { 1373 {
1337 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1374 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) || QUERY_FLAG (tmp, FLAG_OVERLAY_FLOOR))
1338 floor = top; 1375 floor = tmp;
1339 1376
1340 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1377 if (QUERY_FLAG (tmp, FLAG_NO_PICK) && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (tmp, FLAG_IS_FLOOR))
1341 { 1378 {
1342 /* We insert above top, so we want this object below this */ 1379 /* We insert above top, so we want this object below this */
1343 top = top->below; 1380 top = tmp->below;
1344 break; 1381 break;
1345 } 1382 }
1346 1383
1347 last = top; 1384 top = tmp;
1348 } 1385 }
1349
1350 /* Don't want top to be NULL, so set it to the last valid object */
1351 top = last;
1352 1386
1353 /* We let update_position deal with figuring out what the space 1387 /* We let update_position deal with figuring out what the space
1354 * looks like instead of lots of conditions here. 1388 * looks like instead of lots of conditions here.
1355 * makes things faster, and effectively the same result. 1389 * makes things faster, and effectively the same result.
1356 */ 1390 */
1363 */ 1397 */
1364 if (!(flag & INS_ON_TOP) 1398 if (!(flag & INS_ON_TOP)
1365 && ms.flags () & P_BLOCKSVIEW 1399 && ms.flags () & P_BLOCKSVIEW
1366 && (op->face && !faces [op->face].visibility)) 1400 && (op->face && !faces [op->face].visibility))
1367 { 1401 {
1402 object *last;
1403
1368 for (last = top; last != floor; last = last->below) 1404 for (last = top; last != floor; last = last->below)
1369 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1405 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1370 break; 1406 break;
1371 1407
1372 /* Check to see if we found the object that blocks view, 1408 /* Check to see if we found the object that blocks view,
1380 } /* If objects on this space */ 1416 } /* If objects on this space */
1381 1417
1382 if (flag & INS_ABOVE_FLOOR_ONLY) 1418 if (flag & INS_ABOVE_FLOOR_ONLY)
1383 top = floor; 1419 top = floor;
1384 1420
1385 /* Top is the object that our object (op) is going to get inserted above. 1421 // insert object above top, or bottom-most if top = 0
1386 */
1387
1388 /* First object on this space */
1389 if (!top) 1422 if (!top)
1390 { 1423 {
1424 op->below = 0;
1391 op->above = ms.bot; 1425 op->above = ms.bot;
1392
1393 if (op->above)
1394 op->above->below = op;
1395
1396 op->below = 0;
1397 ms.bot = op; 1426 ms.bot = op;
1427
1428 *(op->above ? &op->above->below : &ms.top) = op;
1398 } 1429 }
1399 else 1430 else
1400 { /* get inserted into the stack above top */ 1431 {
1401 op->above = top->above; 1432 op->above = top->above;
1402
1403 if (op->above)
1404 op->above->below = op; 1433 top->above = op;
1405 1434
1406 op->below = top; 1435 op->below = top;
1407 top->above = op; 1436 *(op->above ? &op->above->below : &ms.top) = op;
1408 } 1437 }
1438 }
1409 1439
1410 if (!op->above) 1440 if (op->is_player ())
1411 ms.top = op;
1412 } /* else not INS_BELOW_ORIGINATOR */
1413
1414 if (op->type == PLAYER)
1415 { 1441 {
1416 op->contr->do_los = 1; 1442 op->contr->do_los = 1;
1417 ++op->map->players; 1443 ++op->map->players;
1418 op->map->touch (); 1444 op->map->touch ();
1419 } 1445 }
1420 1446
1421 op->map->dirty = true; 1447 op->map->dirty = true;
1422 1448
1423 if (object *pl = ms.player ()) 1449 if (object *pl = ms.player ())
1450 //TODO: the floorbox prev/next might need updating
1451 //esrv_send_item (pl, op);
1452 //TODO: update floorbox to preserve ordering
1453 if (pl->contr->ns)
1424 pl->contr->ns->floorbox_update (); 1454 pl->contr->ns->floorbox_update ();
1425 1455
1426 /* If this object glows, it may affect lighting conditions that are 1456 /* If this object glows, it may affect lighting conditions that are
1427 * visible to others on this map. But update_all_los is really 1457 * visible to others on this map. But update_all_los is really
1428 * an inefficient way to do this, as it means los for all players 1458 * an inefficient way to do this, as it means los for all players
1429 * on the map will get recalculated. The players could very well 1459 * on the map will get recalculated. The players could very well
1430 * be far away from this change and not affected in any way - 1460 * be far away from this change and not affected in any way -
1431 * this should get redone to only look for players within range, 1461 * this should get redone to only look for players within range,
1432 * or just updating the P_UPTODATE for spaces within this area 1462 * or just updating the P_UPTODATE for spaces within this area
1433 * of effect may be sufficient. 1463 * of effect may be sufficient.
1434 */ 1464 */
1435 if (op->map->darkness && (op->glow_radius != 0)) 1465 if (op->affects_los ())
1466 {
1467 op->ms ().invalidate ();
1436 update_all_los (op->map, op->x, op->y); 1468 update_all_los (op->map, op->x, op->y);
1469 }
1437 1470
1438 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1471 /* updates flags (blocked, alive, no magic, etc) for this map space */
1439 update_object (op, UP_OBJ_INSERT); 1472 update_object (op, UP_OBJ_INSERT);
1440 1473
1441 INVOKE_OBJECT (INSERT, op); 1474 INVOKE_OBJECT (INSERT, op);
1448 * blocked() and wall() work properly), and these flags are updated by 1481 * blocked() and wall() work properly), and these flags are updated by
1449 * update_object(). 1482 * update_object().
1450 */ 1483 */
1451 1484
1452 /* if this is not the head or flag has been passed, don't check walk on status */ 1485 /* if this is not the head or flag has been passed, don't check walk on status */
1453 if (!(flag & INS_NO_WALK_ON) && op->head_ () == op) 1486 if (!(flag & INS_NO_WALK_ON) && op->is_head ())
1454 { 1487 {
1455 if (check_move_on (op, originator)) 1488 if (check_move_on (op, originator))
1456 return 0; 1489 return 0;
1457 1490
1458 /* If we are a multi part object, lets work our way through the check 1491 /* If we are a multi part object, lets work our way through the check
1469/* this function inserts an object in the map, but if it 1502/* this function inserts an object in the map, but if it
1470 * finds an object of its own type, it'll remove that one first. 1503 * finds an object of its own type, it'll remove that one first.
1471 * op is the object to insert it under: supplies x and the map. 1504 * op is the object to insert it under: supplies x and the map.
1472 */ 1505 */
1473void 1506void
1474replace_insert_ob_in_map (const char *arch_string, object *op) 1507replace_insert_ob_in_map (shstr_tmp archname, object *op)
1475{ 1508{
1476 /* first search for itself and remove any old instances */ 1509 /* first search for itself and remove any old instances */
1477 1510
1478 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above) 1511 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1479 if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */ 1512 if (tmp->arch->archname == archname) /* same archetype */
1480 tmp->destroy (1); 1513 tmp->destroy ();
1481 1514
1482 object *tmp = arch_to_object (archetype::find (arch_string)); 1515 object *tmp = arch_to_object (archetype::find (archname));
1483 1516
1484 tmp->x = op->x; 1517 tmp->x = op->x;
1485 tmp->y = op->y; 1518 tmp->y = op->y;
1486 1519
1487 insert_ob_in_map (tmp, op->map, op, 0); 1520 insert_ob_in_map (tmp, op->map, op, 0);
1492{ 1525{
1493 if (where->env) 1526 if (where->env)
1494 return where->env->insert (this); 1527 return where->env->insert (this);
1495 else 1528 else
1496 return where->map->insert (this, where->x, where->y, originator, flags); 1529 return where->map->insert (this, where->x, where->y, originator, flags);
1497}
1498
1499// find player who can see this object
1500object *
1501object::visible_to () const
1502{
1503 if (!flag [FLAG_REMOVED])
1504 {
1505 // see if we are in a container of sorts
1506 if (env)
1507 {
1508 // the player inventory itself is always visible
1509 if (env->type == PLAYER)
1510 return env;
1511
1512 // else a player could have our env open
1513 object *envest = env->outer_env ();
1514
1515 // the player itself is always on a map, so we will find him here
1516 // even if our inv is in a player.
1517 if (envest->is_on_map ())
1518 if (object *pl = envest->ms ().player ())
1519 if (pl->container == env)
1520 return pl;
1521 }
1522 else
1523 {
1524 // maybe there is a player standing on the same mapspace
1525 // this will catch the case where "this" is a player
1526 if (object *pl = ms ().player ())
1527 return pl;
1528 }
1529 }
1530
1531 return 0;
1532} 1530}
1533 1531
1534/* 1532/*
1535 * decrease(object, number) decreases a specified number from 1533 * decrease(object, number) decreases a specified number from
1536 * the amount of an object. If the amount reaches 0, the object 1534 * the amount of an object. If the amount reaches 0, the object
1544 if (!nr) 1542 if (!nr)
1545 return true; 1543 return true;
1546 1544
1547 nr = min (nr, nrof); 1545 nr = min (nr, nrof);
1548 1546
1547 if (nrof > nr)
1548 {
1549 nrof -= nr; 1549 nrof -= nr;
1550
1551 if (nrof)
1552 {
1553 adjust_weight (env, -weight * nr); // carrying == 0 1550 adjust_weight (env, -weight * max (1, nr)); // carrying == 0
1554 1551
1555 if (object *pl = visible_to ()) 1552 if (object *pl = visible_to ())
1556 esrv_update_item (UPD_NROF, pl, this); 1553 esrv_update_item (UPD_NROF, pl, this);
1557 1554
1558 return true; 1555 return true;
1559 } 1556 }
1560 else 1557 else
1561 { 1558 {
1562 destroy (1); 1559 destroy ();
1563 return false; 1560 return false;
1564 } 1561 }
1565} 1562}
1566 1563
1567/* 1564/*
1584 } 1581 }
1585 else 1582 else
1586 { 1583 {
1587 decrease (nr); 1584 decrease (nr);
1588 1585
1589 object *op = object_create_clone (this); 1586 object *op = deep_clone ();
1590 op->nrof = nr; 1587 op->nrof = nr;
1591 return op; 1588 return op;
1592 } 1589 }
1593} 1590}
1594 1591
1638 if (object::can_merge (tmp, op)) 1635 if (object::can_merge (tmp, op))
1639 { 1636 {
1640 /* return the original object and remove inserted object 1637 /* return the original object and remove inserted object
1641 (client needs the original object) */ 1638 (client needs the original object) */
1642 tmp->nrof += op->nrof; 1639 tmp->nrof += op->nrof;
1640
1641 if (object *pl = tmp->visible_to ())
1642 esrv_update_item (UPD_NROF, pl, tmp);
1643
1643 adjust_weight (this, op->total_weight ()); 1644 adjust_weight (this, op->total_weight ());
1644 1645
1645 op->destroy (1); 1646 op->destroy ();
1646 op = tmp; 1647 op = tmp;
1647 goto inserted; 1648 goto inserted;
1648 } 1649 }
1649 1650
1650 op->owner = 0; // it's his/hers now. period. 1651 op->owner = 0; // it's his/hers now. period.
1661 1662
1662 inv = op; 1663 inv = op;
1663 1664
1664 op->flag [FLAG_REMOVED] = 0; 1665 op->flag [FLAG_REMOVED] = 0;
1665 1666
1667 if (object *pl = op->visible_to ())
1668 esrv_send_item (pl, op);
1669
1666 adjust_weight (this, op->total_weight ()); 1670 adjust_weight (this, op->total_weight ());
1667 1671
1668inserted: 1672inserted:
1669 /* reset the light list and los of the players on the map */ 1673 /* reset the light list and los of the players on the map */
1670 if (op->glow_radius && map && map->darkness) 1674 if (op->glow_radius && is_on_map ())
1675 {
1676 update_stats ();
1671 update_all_los (map, x, y); 1677 update_all_los (map, x, y);
1672 1678 }
1673 if (object *otmp = in_player ()) 1679 else if (is_player () && !flag [FLAG_NO_FIX_PLAYER])
1674 if (otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1680 // if this is a player's inventory, update stats
1675 otmp->update_stats (); 1681 update_stats ();
1676 1682
1677 INVOKE_OBJECT (INSERT, this); 1683 INVOKE_OBJECT (INSERT, this);
1678 1684
1679 return op; 1685 return op;
1680} 1686}
1700 * on top. 1706 * on top.
1701 */ 1707 */
1702int 1708int
1703check_move_on (object *op, object *originator) 1709check_move_on (object *op, object *originator)
1704{ 1710{
1711 if (QUERY_FLAG (op, FLAG_NO_APPLY))
1712 return 0;
1713
1705 object *tmp; 1714 object *tmp;
1706 maptile *m = op->map; 1715 maptile *m = op->map;
1707 int x = op->x, y = op->y; 1716 int x = op->x, y = op->y;
1708 1717
1709 MoveType move_on, move_slow, move_block; 1718 mapspace &ms = m->at (x, y);
1710 1719
1711 if (QUERY_FLAG (op, FLAG_NO_APPLY)) 1720 ms.update ();
1712 return 0;
1713 1721
1714 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y); 1722 MoveType move_on = ms.move_on;
1715 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y); 1723 MoveType move_slow = ms.move_slow;
1716 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y); 1724 MoveType move_block = ms.move_block;
1717 1725
1718 /* if nothing on this space will slow op down or be applied, 1726 /* if nothing on this space will slow op down or be applied,
1719 * no need to do checking below. have to make sure move_type 1727 * no need to do checking below. have to make sure move_type
1720 * is set, as lots of objects don't have it set - we treat that 1728 * is set, as lots of objects don't have it set - we treat that
1721 * as walking. 1729 * as walking.
1732 return 0; 1740 return 0;
1733 1741
1734 /* The objects have to be checked from top to bottom. 1742 /* The objects have to be checked from top to bottom.
1735 * Hence, we first go to the top: 1743 * Hence, we first go to the top:
1736 */ 1744 */
1737 1745 for (object *next, *tmp = ms.top; tmp; tmp = next)
1738 for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1739 {
1740 /* Trim the search when we find the first other spell effect
1741 * this helps performance so that if a space has 50 spell objects,
1742 * we don't need to check all of them.
1743 */
1744 if ((tmp->move_type & MOVE_FLY_LOW) && QUERY_FLAG (tmp, FLAG_NO_PICK))
1745 break;
1746 } 1746 {
1747 next = tmp->below;
1747 1748
1748 for (; tmp; tmp = tmp->below)
1749 {
1750 if (tmp == op) 1749 if (tmp == op)
1751 continue; /* Can't apply yourself */ 1750 continue; /* Can't apply yourself */
1752 1751
1753 /* Check to see if one of the movement types should be slowed down. 1752 /* Check to see if one of the movement types should be slowed down.
1754 * Second check makes sure that the movement types not being slowed 1753 * Second check makes sure that the movement types not being slowed
1759 if (!QUERY_FLAG (op, FLAG_WIZPASS)) 1758 if (!QUERY_FLAG (op, FLAG_WIZPASS))
1760 { 1759 {
1761 if ((!op->move_type && tmp->move_slow & MOVE_WALK) || 1760 if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
1762 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0)) 1761 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
1763 { 1762 {
1764
1765 float
1766 diff = tmp->move_slow_penalty * fabs (op->speed); 1763 float diff = tmp->move_slow_penalty * fabs (op->speed);
1767 1764
1768 if (op->type == PLAYER) 1765 if (op->is_player ())
1769 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) || 1766 if ((tmp->flag [FLAG_IS_HILLY ] && find_skill_by_number (op, SK_CLIMBING)) ||
1770 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN))) 1767 (tmp->flag [FLAG_IS_WOODED] && find_skill_by_number (op, SK_WOODSMAN)))
1771 diff /= 4.0; 1768 diff /= 4.0;
1772 1769
1773 op->speed_left -= diff; 1770 op->speed_left -= diff;
1774 } 1771 }
1775 } 1772 }
1808 LOG (llevError, "Present_arch called outside map.\n"); 1805 LOG (llevError, "Present_arch called outside map.\n");
1809 return NULL; 1806 return NULL;
1810 } 1807 }
1811 1808
1812 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above) 1809 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1813 if (tmp->arch == at) 1810 if (tmp->arch->archname == at->archname)
1814 return tmp; 1811 return tmp;
1815 1812
1816 return NULL; 1813 return NULL;
1817} 1814}
1818 1815
1882 * The first matching object is returned, or NULL if none. 1879 * The first matching object is returned, or NULL if none.
1883 */ 1880 */
1884object * 1881object *
1885present_arch_in_ob (const archetype *at, const object *op) 1882present_arch_in_ob (const archetype *at, const object *op)
1886{ 1883{
1887 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below) 1884 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1888 if (tmp->arch == at) 1885 if (tmp->arch->archname == at->archname)
1889 return tmp; 1886 return tmp;
1890 1887
1891 return NULL; 1888 return NULL;
1892} 1889}
1893 1890
1981 * head of the object should correspond for the entire object. 1978 * head of the object should correspond for the entire object.
1982 */ 1979 */
1983 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block)) 1980 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))
1984 continue; 1981 continue;
1985 1982
1986 if (ob->blocked (m, pos.x, pos.y)) 1983 if (ob->blocked (pos.m, pos.x, pos.y))
1987 continue; 1984 continue;
1988 1985
1989 altern [index++] = i; 1986 altern [index++] = i;
1990 } 1987 }
1991 1988
2059 * there is capable of. 2056 * there is capable of.
2060 */ 2057 */
2061int 2058int
2062find_dir (maptile *m, int x, int y, object *exclude) 2059find_dir (maptile *m, int x, int y, object *exclude)
2063{ 2060{
2064 int i, max = SIZEOFFREE, mflags; 2061 int max = SIZEOFFREE, mflags;
2065
2066 sint16 nx, ny;
2067 object *tmp;
2068 maptile *mp;
2069
2070 MoveType blocked, move_type; 2062 MoveType move_type;
2071 2063
2072 if (exclude && exclude->head_ () != exclude) 2064 if (exclude && exclude->head_ () != exclude)
2073 { 2065 {
2074 exclude = exclude->head; 2066 exclude = exclude->head;
2075 move_type = exclude->move_type; 2067 move_type = exclude->move_type;
2078 { 2070 {
2079 /* If we don't have anything, presume it can use all movement types. */ 2071 /* If we don't have anything, presume it can use all movement types. */
2080 move_type = MOVE_ALL; 2072 move_type = MOVE_ALL;
2081 } 2073 }
2082 2074
2083 for (i = 1; i < max; i++) 2075 for (int i = 1; i < max; i++)
2084 { 2076 {
2085 mp = m; 2077 mapxy pos (m, x, y);
2086 nx = x + freearr_x[i]; 2078 pos.move (i);
2087 ny = y + freearr_y[i];
2088 2079
2089 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2080 if (!pos.normalise ())
2090
2091 if (mflags & P_OUT_OF_MAP)
2092 max = maxfree[i]; 2081 max = maxfree[i];
2093 else 2082 else
2094 { 2083 {
2095 mapspace &ms = mp->at (nx, ny); 2084 mapspace &ms = *pos;
2096 2085
2097 blocked = ms.move_block;
2098
2099 if ((move_type & blocked) == move_type) 2086 if ((move_type & ms.move_block) == move_type)
2100 max = maxfree[i]; 2087 max = maxfree [i];
2101 else if (mflags & P_IS_ALIVE) 2088 else if (ms.flags () & P_IS_ALIVE)
2102 { 2089 {
2103 for (tmp = ms.bot; tmp; tmp = tmp->above) 2090 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
2104 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER) 2091 if ((tmp->flag [FLAG_MONSTER] || tmp->is_player ())
2105 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude))) 2092 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))
2106 break;
2107
2108 if (tmp)
2109 return freedir[i]; 2093 return freedir [i];
2110 } 2094 }
2111 } 2095 }
2112 } 2096 }
2113 2097
2114 return 0; 2098 return 0;
2189 * This basically means that if direction is 15, then it could either go 2173 * This basically means that if direction is 15, then it could either go
2190 * direction 4, 14, or 16 to get back to where we are. 2174 * direction 4, 14, or 16 to get back to where we are.
2191 * Moved from spell_util.c to object.c with the other related direction 2175 * Moved from spell_util.c to object.c with the other related direction
2192 * functions. 2176 * functions.
2193 */ 2177 */
2194int reduction_dir[SIZEOFFREE][3] = { 2178const int reduction_dir[SIZEOFFREE][3] = {
2195 {0, 0, 0}, /* 0 */ 2179 {0, 0, 0}, /* 0 */
2196 {0, 0, 0}, /* 1 */ 2180 {0, 0, 0}, /* 1 */
2197 {0, 0, 0}, /* 2 */ 2181 {0, 0, 0}, /* 2 */
2198 {0, 0, 0}, /* 3 */ 2182 {0, 0, 0}, /* 3 */
2199 {0, 0, 0}, /* 4 */ 2183 {0, 0, 0}, /* 4 */
2295int 2279int
2296can_pick (const object *who, const object *item) 2280can_pick (const object *who, const object *item)
2297{ 2281{
2298 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2282 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2299 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2283 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2300 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2284 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->is_player () || item->weight < who->weight / 3));
2301} 2285}
2302 2286
2303/* 2287/*
2304 * create clone from object to another 2288 * create clone from object to another
2305 */ 2289 */
2306object * 2290object *
2307object_create_clone (object *asrc) 2291object::deep_clone ()
2308{ 2292{
2309 object *dst = 0, *tmp, *src, *prev, *item; 2293 assert (("deep_clone called on non-head object", is_head ()));
2310 2294
2311 if (!asrc) 2295 object *dst = clone ();
2312 return 0;
2313 2296
2314 src = asrc->head_ (); 2297 object *prev = dst;
2315
2316 prev = 0;
2317 for (object *part = src; part; part = part->more) 2298 for (object *part = this->more; part; part = part->more)
2318 { 2299 {
2319 tmp = part->clone (); 2300 object *tmp = part->clone ();
2320 tmp->x -= src->x;
2321 tmp->y -= src->y;
2322
2323 if (!part->head)
2324 {
2325 dst = tmp;
2326 tmp->head = 0;
2327 }
2328 else
2329 tmp->head = dst; 2301 tmp->head = dst;
2330
2331 tmp->more = 0;
2332
2333 if (prev)
2334 prev->more = tmp; 2302 prev->more = tmp;
2335
2336 prev = tmp; 2303 prev = tmp;
2337 } 2304 }
2338 2305
2339 for (item = src->inv; item; item = item->below) 2306 for (object *item = inv; item; item = item->below)
2340 insert_ob_in_ob (object_create_clone (item), dst); 2307 insert_ob_in_ob (item->deep_clone (), dst);
2341 2308
2342 return dst; 2309 return dst;
2343} 2310}
2344 2311
2345/* This returns the first object in who's inventory that 2312/* This returns the first object in who's inventory that
2354 return tmp; 2321 return tmp;
2355 2322
2356 return 0; 2323 return 0;
2357} 2324}
2358 2325
2359/* If ob has a field named key, return the link from the list, 2326shstr_tmp
2360 * otherwise return NULL. 2327object::kv_get (shstr_tmp key) const
2361 *
2362 * key must be a passed in shared string - otherwise, this won't
2363 * do the desired thing.
2364 */
2365key_value *
2366get_ob_key_link (const object *ob, const char *key)
2367{ 2328{
2368 for (key_value *link = ob->key_values; link; link = link->next) 2329 for (key_value *kv = key_values; kv; kv = kv->next)
2369 if (link->key == key) 2330 if (kv->key == key)
2370 return link;
2371
2372 return 0;
2373}
2374
2375/*
2376 * Returns the value of op has an extra_field for key, or NULL.
2377 *
2378 * The argument doesn't need to be a shared string.
2379 *
2380 * The returned string is shared.
2381 */
2382const char *
2383get_ob_key_value (const object *op, const char *const key)
2384{
2385 key_value *link;
2386 shstr_cmp canonical_key (key);
2387
2388 if (!canonical_key)
2389 {
2390 /* 1. There being a field named key on any object
2391 * implies there'd be a shared string to find.
2392 * 2. Since there isn't, no object has this field.
2393 * 3. Therefore, *this* object doesn't have this field.
2394 */
2395 return 0;
2396 }
2397
2398 /* This is copied from get_ob_key_link() above -
2399 * only 4 lines, and saves the function call overhead.
2400 */
2401 for (link = op->key_values; link; link = link->next)
2402 if (link->key == canonical_key)
2403 return link->value; 2331 return kv->value;
2404 2332
2405 return 0; 2333 return shstr ();
2406} 2334}
2407 2335
2408/* 2336void
2409 * Updates the canonical_key in op to value. 2337object::kv_set (shstr_tmp key, shstr_tmp value)
2410 *
2411 * canonical_key is a shared string (value doesn't have to be).
2412 *
2413 * Unless add_key is TRUE, it won't add fields, only change the value of existing
2414 * keys.
2415 *
2416 * Returns TRUE on success.
2417 */
2418int
2419set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2420{ 2338{
2421 key_value *field = NULL, *last = NULL; 2339 for (key_value *kv = key_values; kv; kv = kv->next)
2422 2340 if (kv->key == key)
2423 for (field = op->key_values; field != NULL; field = field->next)
2424 {
2425 if (field->key != canonical_key)
2426 { 2341 {
2427 last = field; 2342 kv->value = value;
2428 continue; 2343 return;
2429 } 2344 }
2430 2345
2431 if (value) 2346 key_value *kv = new key_value;
2432 field->value = value; 2347
2433 else 2348 kv->next = key_values;
2349 kv->key = key;
2350 kv->value = value;
2351
2352 key_values = kv;
2353}
2354
2355void
2356object::kv_del (shstr_tmp key)
2357{
2358 for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
2359 if ((*kvp)->key == key)
2434 { 2360 {
2435 /* Basically, if the archetype has this key set, 2361 key_value *kv = *kvp;
2436 * we need to store the null value so when we save 2362 *kvp = (*kvp)->next;
2437 * it, we save the empty value so that when we load, 2363 delete kv;
2438 * we get this value back again. 2364 return;
2439 */
2440 if (get_ob_key_link (op->arch, canonical_key))
2441 field->value = 0;
2442 else
2443 {
2444 if (last)
2445 last->next = field->next;
2446 else
2447 op->key_values = field->next;
2448
2449 delete field;
2450 }
2451 } 2365 }
2452 return TRUE;
2453 }
2454 /* IF we get here, key doesn't exist */
2455
2456 /* No field, we'll have to add it. */
2457
2458 if (!add_key)
2459 return FALSE;
2460
2461 /* There isn't any good reason to store a null
2462 * value in the key/value list. If the archetype has
2463 * this key, then we should also have it, so shouldn't
2464 * be here. If user wants to store empty strings,
2465 * should pass in ""
2466 */
2467 if (value == NULL)
2468 return TRUE;
2469
2470 field = new key_value;
2471
2472 field->key = canonical_key;
2473 field->value = value;
2474 /* Usual prepend-addition. */
2475 field->next = op->key_values;
2476 op->key_values = field;
2477
2478 return TRUE;
2479}
2480
2481/*
2482 * Updates the key in op to value.
2483 *
2484 * If add_key is FALSE, this will only update existing keys,
2485 * and not add new ones.
2486 * In general, should be little reason FALSE is ever passed in for add_key
2487 *
2488 * Returns TRUE on success.
2489 */
2490int
2491set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2492{
2493 shstr key_ (key);
2494
2495 return set_ob_key_value_s (op, key_, value, add_key);
2496} 2366}
2497 2367
2498object::depth_iterator::depth_iterator (object *container) 2368object::depth_iterator::depth_iterator (object *container)
2499: iterator_base (container) 2369: iterator_base (container)
2500{ 2370{
2550{ 2420{
2551 char flagdesc[512]; 2421 char flagdesc[512];
2552 char info2[256 * 4]; 2422 char info2[256 * 4];
2553 char *p = info; 2423 char *p = info;
2554 2424
2555 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s,flags:[%s],type:%d}", 2425 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2556 count, 2426 count,
2557 uuid.c_str (), 2427 uuid.c_str (),
2558 &name, 2428 &name,
2559 title ? "\",title:\"" : "", 2429 title ? ",title:\"" : "",
2560 title ? (const char *)title : "", 2430 title ? (const char *)title : "",
2431 title ? "\"" : "",
2561 flag_desc (flagdesc, 512), type); 2432 flag_desc (flagdesc, 512), type);
2562 2433
2563 if (!this->flag[FLAG_REMOVED] && env) 2434 if (!flag[FLAG_REMOVED] && env)
2564 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2435 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2565 2436
2566 if (map) 2437 if (map)
2567 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y); 2438 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2568 2439
2598object::open_container (object *new_container) 2469object::open_container (object *new_container)
2599{ 2470{
2600 if (container == new_container) 2471 if (container == new_container)
2601 return; 2472 return;
2602 2473
2603 if (object *old_container = container) 2474 object *old_container = container;
2475
2476 if (old_container)
2604 { 2477 {
2605 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this))) 2478 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))
2606 return; 2479 return;
2607 2480
2608#if 0 2481#if 0
2610 if (object *closer = old_container->inv) 2483 if (object *closer = old_container->inv)
2611 if (closer->type == CLOSE_CON) 2484 if (closer->type == CLOSE_CON)
2612 closer->destroy (); 2485 closer->destroy ();
2613#endif 2486#endif
2614 2487
2488 // make sure the container is available
2489 esrv_send_item (this, old_container);
2490
2615 old_container->flag [FLAG_APPLIED] = 0; 2491 old_container->flag [FLAG_APPLIED] = false;
2616 container = 0; 2492 container = 0;
2617 2493
2494 // client needs item update to make it work, client bug requires this to be separate
2618 esrv_update_item (UPD_FLAGS, this, old_container); 2495 esrv_update_item (UPD_FLAGS, this, old_container);
2496
2619 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container)); 2497 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", old_container->query_name ());
2620 play_sound (sound_find ("chest_close")); 2498 play_sound (sound_find ("chest_close"));
2621 } 2499 }
2622 2500
2623 if (new_container) 2501 if (new_container)
2624 { 2502 {
2634 closer->flag [FLAG_NO_MAP_SAVE] = 1; 2512 closer->flag [FLAG_NO_MAP_SAVE] = 1;
2635 new_container->insert (closer); 2513 new_container->insert (closer);
2636 } 2514 }
2637#endif 2515#endif
2638 2516
2639 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container)); 2517 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", new_container->query_name ());
2640 2518
2519 // make sure the container is available, client bug requires this to be separate
2520 esrv_send_item (this, new_container);
2521
2641 new_container->flag [FLAG_APPLIED] = 1; 2522 new_container->flag [FLAG_APPLIED] = true;
2642 container = new_container; 2523 container = new_container;
2643 2524
2525 // client needs flag change
2644 esrv_update_item (UPD_FLAGS, this, new_container); 2526 esrv_update_item (UPD_FLAGS, this, new_container);
2645 esrv_send_inventory (this, new_container); 2527 esrv_send_inventory (this, new_container);
2646 play_sound (sound_find ("chest_open")); 2528 play_sound (sound_find ("chest_open"));
2647 } 2529 }
2530// else if (!old_container->env && contr && contr->ns)
2531// contr->ns->floorbox_reset ();
2648} 2532}
2649 2533
2650object * 2534object *
2651object::force_find (const shstr name) 2535object::force_find (shstr_tmp name)
2652{ 2536{
2653 /* cycle through his inventory to look for the MARK we want to 2537 /* cycle through his inventory to look for the MARK we want to
2654 * place 2538 * place
2655 */ 2539 */
2656 for (object *tmp = inv; tmp; tmp = tmp->below) 2540 for (object *tmp = inv; tmp; tmp = tmp->below)
2658 return splay (tmp); 2542 return splay (tmp);
2659 2543
2660 return 0; 2544 return 0;
2661} 2545}
2662 2546
2547//-GPL
2548
2663void 2549void
2550object::force_set_timer (int duration)
2551{
2552 this->duration = 1;
2553 this->speed_left = -1.f;
2554
2555 this->set_speed (duration ? 1.f / duration : 0.f);
2556}
2557
2558object *
2664object::force_add (const shstr name, int duration) 2559object::force_add (shstr_tmp name, int duration)
2665{ 2560{
2666 if (object *force = force_find (name)) 2561 if (object *force = force_find (name))
2667 force->destroy (); 2562 force->destroy ();
2668 2563
2669 object *force = get_archetype (FORCE_NAME); 2564 object *force = get_archetype (FORCE_NAME);
2670 2565
2671 force->slaying = name; 2566 force->slaying = name;
2672 force->stats.food = 1; 2567 force->force_set_timer (duration);
2673 force->speed_left = -1.f;
2674
2675 force->set_speed (duration ? 1.f / duration : 0.f);
2676 force->flag [FLAG_IS_USED_UP] = true;
2677 force->flag [FLAG_APPLIED] = true; 2568 force->flag [FLAG_APPLIED] = true;
2678 2569
2679 insert (force); 2570 return insert (force);
2680} 2571}
2681 2572
2682void 2573void
2683object::play_sound (faceidx sound) 2574object::play_sound (faceidx sound) const
2684{ 2575{
2685 if (!sound) 2576 if (!sound)
2686 return; 2577 return;
2687 2578
2688 if (flag [FLAG_REMOVED]) 2579 if (is_on_map ())
2580 map->play_sound (sound, x, y);
2581 else if (object *pl = in_player ())
2582 pl->contr->play_sound (sound);
2583}
2584
2585void
2586object::say_msg (const char *msg) const
2587{
2588 if (is_on_map ())
2589 map->say_msg (msg, x, y);
2590 else if (object *pl = in_player ())
2591 pl->contr->play_sound (sound);
2592}
2593
2594void
2595object::make_noise ()
2596{
2597 // we do not model noise in the map, so instead put
2598 // a temporary light into the noise source
2599 // could use the map instead, but that's less reliable for our
2600 // goal, which is to make invisibility a bit harder to exploit
2601
2602 // currently only works sensibly for players
2603 if (!is_player ())
2689 return; 2604 return;
2690 2605
2691 if (env) 2606 // find old force, or create new one
2692 { 2607 object *force = force_find (shstr_noise_force);
2693 if (object *pl = in_player ()) 2608
2694 pl->contr->play_sound (sound); 2609 if (force)
2695 } 2610 force->speed_left = -1.f; // patch old speed up
2696 else 2611 else
2697 map->play_sound (sound, x, y); 2612 {
2698} 2613 force = archetype::get (shstr_noise_force);
2699 2614
2615 force->slaying = shstr_noise_force;
2616 force->stats.food = 1;
2617 force->speed_left = -1.f;
2618
2619 force->set_speed (1.f / 4.f);
2620 force->flag [FLAG_IS_USED_UP] = true;
2621 force->flag [FLAG_APPLIED] = true;
2622
2623 insert (force);
2624 }
2625}
2626

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines