ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.55 by root, Sun Dec 3 00:41:33 2006 UTC vs.
Revision 1.80 by root, Sat Dec 23 06:41:39 2006 UTC

… …
29#include <sys/types.h> 29#include <sys/types.h>
30#include <sys/uio.h> 30#include <sys/uio.h>
31#include <object.h> 31#include <object.h>
32#include <funcpoint.h> 32#include <funcpoint.h>
33#include <loader.h> 33#include <loader.h>
34
35#include <bitset>
34 36
35int nrofallocobjects = 0; 37int nrofallocobjects = 0;
36static UUID uuid; 38static UUID uuid;
37const uint64 UUID_SKIP = 1<<19; 39const uint64 UUID_SKIP = 1<<19;
38 40
… …
104 _exit (1); 106 _exit (1);
105 } 107 }
106 108
107 uuid.seq = uid; 109 uuid.seq = uid;
108 write_uuid (); 110 write_uuid ();
109 LOG (llevDebug, "read UID: %lld\n", uid); 111 LOG (llevDebug, "read UID: %" PRId64 "\n", uid);
110 fclose (fp); 112 fclose (fp);
111} 113}
112 114
113UUID 115UUID
114gen_uuid () 116gen_uuid ()
… …
183 * 185 *
184 * Note that this function appears a lot longer than the macro it 186 * Note that this function appears a lot longer than the macro it
185 * replaces - this is mostly for clarity - a decent compiler should hopefully 187 * replaces - this is mostly for clarity - a decent compiler should hopefully
186 * reduce this to the same efficiency. 188 * reduce this to the same efficiency.
187 * 189 *
188 * Check nrof variable *before* calling CAN_MERGE() 190 * Check nrof variable *before* calling can_merge()
189 * 191 *
190 * Improvements made with merge: Better checking on potion, and also 192 * Improvements made with merge: Better checking on potion, and also
191 * check weight 193 * check weight
192 */ 194 */
193 195
194bool object::can_merge (object *ob1, object *ob2) 196bool object::can_merge_slow (object *ob1, object *ob2)
195{ 197{
196 /* A couple quicksanity checks */ 198 /* A couple quicksanity checks */
197 if ((ob1 == ob2) || (ob1->type != ob2->type)) 199 if (ob1 == ob2
200 || ob1->type != ob2->type
201 || ob1->speed != ob2->speed
202 || ob1->value != ob2->value
203 || ob1->name != ob2->name)
198 return 0; 204 return 0;
199 205
200 if (ob1->speed != ob2->speed) 206 //TODO: this ain't working well, use nicer and correct overflow check
201 return 0;
202
203 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that 207 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that
204 * value could not be stored in a sint32 (which unfortunately sometimes is 208 * value could not be stored in a sint32 (which unfortunately sometimes is
205 * used to store nrof). 209 * used to store nrof).
206 */ 210 */
207 if (ob1->nrof + ob2->nrof >= 1UL << 31) 211 if (ob1->nrof + ob2->nrof >= 1UL << 31)
… …
217 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 221 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
218 222
219 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 223 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
220 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 224 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
221 225
222 226 if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any ()
223 /* the 0x400000 on flags2 is FLAG_INV_LOCK. I don't think something 227 || ob1->arch != ob2->arch
224 * being locked in inventory should prevent merging.
225 * 0x4 in flags3 is CLIENT_SENT
226 */
227 if ((ob1->arch != ob2->arch) ||
228 (ob1->flags[0] != ob2->flags[0]) ||
229 (ob1->flags[1] != ob2->flags[1]) ||
230 ((ob1->flags[2] & ~0x400000) != (ob2->flags[2] & ~0x400000)) ||
231 ((ob1->flags[3] & ~0x4) != (ob2->flags[3] & ~0x4)) ||
232 (ob1->name != ob2->name) || 228 || ob1->name != ob2->name
233 (ob1->title != ob2->title) || 229 || ob1->title != ob2->title
234 (ob1->msg != ob2->msg) || 230 || ob1->msg != ob2->msg
235 (ob1->weight != ob2->weight) || 231 || ob1->weight != ob2->weight
236 (memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist)) != 0) || 232 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
237 (memcmp (&ob1->stats, &ob2->stats, sizeof (ob1->stats)) != 0) || 233 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
238 (ob1->attacktype != ob2->attacktype) || 234 || ob1->attacktype != ob2->attacktype
239 (ob1->magic != ob2->magic) || 235 || ob1->magic != ob2->magic
240 (ob1->slaying != ob2->slaying) || 236 || ob1->slaying != ob2->slaying
241 (ob1->skill != ob2->skill) || 237 || ob1->skill != ob2->skill
242 (ob1->value != ob2->value) || 238 || ob1->value != ob2->value
243 (ob1->animation_id != ob2->animation_id) || 239 || ob1->animation_id != ob2->animation_id
244 (ob1->client_type != ob2->client_type) || 240 || ob1->client_type != ob2->client_type
245 (ob1->materialname != ob2->materialname) || 241 || ob1->materialname != ob2->materialname
246 (ob1->lore != ob2->lore) || 242 || ob1->lore != ob2->lore
247 (ob1->subtype != ob2->subtype) || 243 || ob1->subtype != ob2->subtype
248 (ob1->move_type != ob2->move_type) || 244 || ob1->move_type != ob2->move_type
249 (ob1->move_block != ob2->move_block) || 245 || ob1->move_block != ob2->move_block
250 (ob1->move_allow != ob2->move_allow) || 246 || ob1->move_allow != ob2->move_allow
251 (ob1->move_on != ob2->move_on) || 247 || ob1->move_on != ob2->move_on
252 (ob1->move_off != ob2->move_off) || (ob1->move_slow != ob2->move_slow) || (ob1->move_slow_penalty != ob2->move_slow_penalty)) 248 || ob1->move_off != ob2->move_off
249 || ob1->move_slow != ob2->move_slow
250 || ob1->move_slow_penalty != ob2->move_slow_penalty)
253 return 0; 251 return 0;
254 252
255 /* This is really a spellbook check - really, we should 253 /* This is really a spellbook check - really, we should
256 * check all objects in the inventory. 254 * check all objects in the inventory.
257 */ 255 */
… …
260 /* if one object has inventory but the other doesn't, not equiv */ 258 /* if one object has inventory but the other doesn't, not equiv */
261 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv)) 259 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv))
262 return 0; 260 return 0;
263 261
264 /* Now check to see if the two inventory objects could merge */ 262 /* Now check to see if the two inventory objects could merge */
265 if (!CAN_MERGE (ob1->inv, ob2->inv)) 263 if (!object::can_merge (ob1->inv, ob2->inv))
266 return 0; 264 return 0;
267 265
268 /* inventory ok - still need to check rest of this object to see 266 /* inventory ok - still need to check rest of this object to see
269 * if it is valid. 267 * if it is valid.
270 */ 268 */
… …
350object * 348object *
351object_get_env_recursive (object *op) 349object_get_env_recursive (object *op)
352{ 350{
353 while (op->env != NULL) 351 while (op->env != NULL)
354 op = op->env; 352 op = op->env;
355 return op;
356}
357
358/*
359 * Eneq(@csd.uu.se): Since we can have items buried in a character we need
360 * a better check. We basically keeping traversing up until we can't
361 * or find a player.
362 */
363
364object *
365is_player_inv (object *op)
366{
367 for (; op != NULL && op->type != PLAYER; op = op->env)
368 if (op->env == op)
369 op->env = NULL;
370 return op; 353 return op;
371} 354}
372 355
373/* 356/*
374 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump. 357 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
… …
484 } 467 }
485 468
486 op->key_values = 0; 469 op->key_values = 0;
487} 470}
488 471
489void object::clear ()
490{
491 attachable_base::clear ();
492
493 free_key_values (this);
494
495 owner = 0;
496 name = 0;
497 name_pl = 0;
498 title = 0;
499 race = 0;
500 slaying = 0;
501 skill = 0;
502 msg = 0;
503 lore = 0;
504 custom_name = 0;
505 materialname = 0;
506 contr = 0;
507 below = 0;
508 above = 0;
509 inv = 0;
510 container = 0;
511 env = 0;
512 more = 0;
513 head = 0;
514 map = 0;
515 active_next = 0;
516 active_prev = 0;
517
518 memset (static_cast<object_pod *>(this), 0, sizeof (object_pod));
519
520 SET_FLAG (this, FLAG_REMOVED);
521
522 /* What is not cleared is next, prev, and count */
523
524 expmul = 1.0;
525 face = blank_face;
526
527 if (settings.casting_time)
528 casting_time = -1;
529}
530
531void object::clone (object *destination)
532{
533 *(object_copy *)destination = *this;
534 *(object_pod *)destination = *this;
535
536 if (self || cb)
537 INVOKE_OBJECT (CLONE, this, ARG_OBJECT (destination));
538}
539
540/* 472/*
541 * copy object first frees everything allocated by the second object, 473 * copy_to first frees everything allocated by the dst object,
542 * and then copies the contends of the first object into the second 474 * and then copies the contents of itself into the second
543 * object, allocating what needs to be allocated. Basically, any 475 * object, allocating what needs to be allocated. Basically, any
544 * data that is malloc'd needs to be re-malloc/copied. Otherwise, 476 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
545 * if the first object is freed, the pointers in the new object 477 * if the first object is freed, the pointers in the new object
546 * will point at garbage. 478 * will point at garbage.
547 */ 479 */
548void 480void
549copy_object (object *op2, object *op) 481object::copy_to (object *dst)
550{ 482{
551 bool is_freed = QUERY_FLAG (op, FLAG_FREED); 483 bool is_freed = QUERY_FLAG (dst, FLAG_FREED);
552 bool is_removed = QUERY_FLAG (op, FLAG_REMOVED); 484 bool is_removed = QUERY_FLAG (dst, FLAG_REMOVED);
553 485
554 op2->clone (op); 486 *(object_copy *)dst = *this;
487
488 if (self || cb)
489 INVOKE_OBJECT (CLONE, this, ARG_OBJECT (dst));
555 490
556 if (is_freed) 491 if (is_freed)
557 SET_FLAG (op, FLAG_FREED); 492 SET_FLAG (dst, FLAG_FREED);
493
558 if (is_removed) 494 if (is_removed)
559 SET_FLAG (op, FLAG_REMOVED); 495 SET_FLAG (dst, FLAG_REMOVED);
560 496
561 if (op2->speed < 0) 497 if (speed < 0)
562 op->speed_left = op2->speed_left - RANDOM () % 200 / 100.0; 498 dst->speed_left = speed_left - RANDOM () % 200 / 100.0;
563 499
564 /* Copy over key_values, if any. */ 500 /* Copy over key_values, if any. */
565 if (op2->key_values) 501 if (key_values)
566 { 502 {
567 key_value *tail = 0; 503 key_value *tail = 0;
568 key_value *i; 504 key_value *i;
569 505
570 op->key_values = 0; 506 dst->key_values = 0;
571 507
572 for (i = op2->key_values; i; i = i->next) 508 for (i = key_values; i; i = i->next)
573 { 509 {
574 key_value *new_link = new key_value; 510 key_value *new_link = new key_value;
575 511
576 new_link->next = 0; 512 new_link->next = 0;
577 new_link->key = i->key; 513 new_link->key = i->key;
578 new_link->value = i->value; 514 new_link->value = i->value;
579 515
580 /* Try and be clever here, too. */ 516 /* Try and be clever here, too. */
581 if (!op->key_values) 517 if (!dst->key_values)
582 { 518 {
583 op->key_values = new_link; 519 dst->key_values = new_link;
584 tail = new_link; 520 tail = new_link;
585 } 521 }
586 else 522 else
587 { 523 {
588 tail->next = new_link; 524 tail->next = new_link;
589 tail = new_link; 525 tail = new_link;
590 } 526 }
591 } 527 }
592 } 528 }
593 529
594 update_ob_speed (op); 530 update_ob_speed (dst);
531}
532
533object *
534object::clone ()
535{
536 object *neu = create ();
537 copy_to (neu);
538 return neu;
595} 539}
596 540
597/* 541/*
598 * If an object with the IS_TURNABLE() flag needs to be turned due 542 * If an object with the IS_TURNABLE() flag needs to be turned due
599 * to the closest player being on the other side, this function can 543 * to the closest player being on the other side, this function can
… …
707 op->active_next = NULL; 651 op->active_next = NULL;
708 op->active_prev = NULL; 652 op->active_prev = NULL;
709} 653}
710 654
711/* 655/*
712 * update_object() updates the array which represents the map. 656 * update_object() updates the the map.
713 * It takes into account invisible objects (and represent squares covered 657 * It takes into account invisible objects (and represent squares covered
714 * by invisible objects by whatever is below them (unless it's another 658 * by invisible objects by whatever is below them (unless it's another
715 * invisible object, etc...) 659 * invisible object, etc...)
716 * If the object being updated is beneath a player, the look-window 660 * If the object being updated is beneath a player, the look-window
717 * of that player is updated (this might be a suboptimal way of 661 * of that player is updated (this might be a suboptimal way of
718 * updating that window, though, since update_object() is called _often_) 662 * updating that window, though, since update_object() is called _often_)
719 * 663 *
720 * action is a hint of what the caller believes need to be done. 664 * action is a hint of what the caller believes need to be done.
721 * For example, if the only thing that has changed is the face (due to
722 * an animation), we don't need to call update_position until that actually
723 * comes into view of a player. OTOH, many other things, like addition/removal
724 * of walls or living creatures may need us to update the flags now.
725 * current action are: 665 * current action are:
726 * UP_OBJ_INSERT: op was inserted 666 * UP_OBJ_INSERT: op was inserted
727 * UP_OBJ_REMOVE: op was removed 667 * UP_OBJ_REMOVE: op was removed
728 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update 668 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update
729 * as that is easier than trying to look at what may have changed. 669 * as that is easier than trying to look at what may have changed.
730 * UP_OBJ_FACE: only the objects face has changed. 670 * UP_OBJ_FACE: only the objects face has changed.
731 */ 671 */
732
733void 672void
734update_object (object *op, int action) 673update_object (object *op, int action)
735{ 674{
736 int update_now = 0, flags;
737 MoveType move_on, move_off, move_block, move_slow; 675 MoveType move_on, move_off, move_block, move_slow;
738 676
739 if (op == NULL) 677 if (op == NULL)
740 { 678 {
741 /* this should never happen */ 679 /* this should never happen */
742 LOG (llevDebug, "update_object() called for NULL object.\n"); 680 LOG (llevDebug, "update_object() called for NULL object.\n");
743 return; 681 return;
744 } 682 }
745 683
746 if (op->env != NULL) 684 if (op->env)
747 { 685 {
748 /* Animation is currently handled by client, so nothing 686 /* Animation is currently handled by client, so nothing
749 * to do in this case. 687 * to do in this case.
750 */ 688 */
751 return; 689 return;
… …
765 abort (); 703 abort ();
766#endif 704#endif
767 return; 705 return;
768 } 706 }
769 707
770 flags = GET_MAP_FLAGS (op->map, op->x, op->y); 708 mapspace &m = op->ms ();
771 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NEED_UPDATE);
772 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
773 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
774 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
775 move_off = GET_MAP_MOVE_OFF (op->map, op->x, op->y);
776 709
710 if (m.flags_ & P_NEED_UPDATE)
711 /* nop */;
777 if (action == UP_OBJ_INSERT) 712 else if (action == UP_OBJ_INSERT)
778 { 713 {
714 // this is likely overkill, TODO: revisit (schmorp)
779 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(flags & P_BLOCKSVIEW)) 715 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
780 update_now = 1;
781
782 if (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(flags & P_NO_MAGIC)) 716 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
783 update_now = 1; 717 || (op->type == PLAYER && !(m.flags_ & P_PLAYER))
784 718 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
719 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
785 if (QUERY_FLAG (op, FLAG_DAMNED) && !(flags & P_NO_CLERIC)) 720 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
786 update_now = 1;
787
788 if (QUERY_FLAG (op, FLAG_ALIVE) && !(flags & P_IS_ALIVE))
789 update_now = 1;
790
791 if (op->type == SAFE_GROUND && !(flags & P_SAFE))
792 update_now = 1;
793
794 if ((move_on | op->move_on) != move_on) 721 || (m.move_on | op->move_on ) != m.move_on
795 update_now = 1;
796
797 if ((move_off | op->move_off) != move_off) 722 || (m.move_off | op->move_off ) != m.move_off
798 update_now = 1; 723 || (m.move_slow | op->move_slow) != m.move_slow
799
800 /* This isn't perfect, but I don't expect a lot of objects to 724 /* This isn't perfect, but I don't expect a lot of objects to
801 * to have move_allow right now. 725 * to have move_allow right now.
802 */ 726 */
803 if (((move_block | op->move_block) & ~op->move_allow) != move_block) 727 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
804 update_now = 1; 728 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
805 729 m.flags_ = P_NEED_UPDATE;
806 if ((move_slow | op->move_slow) != move_slow)
807 update_now = 1;
808 } 730 }
809 /* if the object is being removed, we can't make intelligent 731 /* if the object is being removed, we can't make intelligent
810 * decisions, because remove_ob can't really pass the object 732 * decisions, because remove_ob can't really pass the object
811 * that is being removed. 733 * that is being removed.
812 */ 734 */
813 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 735 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
814 update_now = 1; 736 m.flags_ = P_NEED_UPDATE;
815 else if (action == UP_OBJ_FACE) 737 else if (action == UP_OBJ_FACE)
816 /* Nothing to do for that case */ ; 738 /* Nothing to do for that case */ ;
817 else 739 else
818 LOG (llevError, "update_object called with invalid action: %d\n", action); 740 LOG (llevError, "update_object called with invalid action: %d\n", action);
819 741
820 if (update_now)
821 {
822 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NO_ERROR | P_NEED_UPDATE);
823 update_position (op->map, op->x, op->y);
824 }
825
826 if (op->more != NULL) 742 if (op->more)
827 update_object (op->more, action); 743 update_object (op->more, action);
828} 744}
829 745
830object::vector object::mortals; 746object::vector object::mortals;
831object::vector object::objects; // not yet used 747object::vector object::objects; // not yet used
… …
839 else 755 else
840 { 756 {
841 delete *i; 757 delete *i;
842 mortals.erase (i); 758 mortals.erase (i);
843 } 759 }
844
845 static int lastmortals = 0;//D
846
847 if (mortals.size() != lastmortals && lastmortals > 100)//D
848 {
849 lastmortals = mortals.size ();//D
850 LOG (llevDebug, "%d objects in mortal queue\n", lastmortals);//D
851 }
852} 760}
853 761
854object::object () 762object::object ()
855{ 763{
856 SET_FLAG (this, FLAG_REMOVED); 764 SET_FLAG (this, FLAG_REMOVED);
… …
915 823
916 if (QUERY_FLAG (this, FLAG_FRIENDLY)) 824 if (QUERY_FLAG (this, FLAG_FRIENDLY))
917 remove_friendly_object (this); 825 remove_friendly_object (this);
918 826
919 if (!QUERY_FLAG (this, FLAG_REMOVED)) 827 if (!QUERY_FLAG (this, FLAG_REMOVED))
920 remove_ob (this); 828 remove ();
921 829
922 SET_FLAG (this, FLAG_FREED); 830 SET_FLAG (this, FLAG_FREED);
923
924 // hack to ensure that freed objects still have a valid map
925 {
926 static maptile *freed_map; // freed objects are moved here to avoid crashes
927
928 if (!freed_map)
929 {
930 freed_map = get_empty_map (3, 3);
931 freed_map->name = "freed objects map";
932 allocate_map (freed_map);
933 }
934
935 map = freed_map;
936 x = 1;
937 y = 1;
938 }
939 831
940 if (more) 832 if (more)
941 { 833 {
942 more->destroy (destroy_inventory); 834 more->destroy (destroy_inventory);
943 more = 0; 835 more = 0;
… …
966 858
967 while (op) 859 while (op)
968 { 860 {
969 object *tmp = op->below; 861 object *tmp = op->below;
970 862
971 remove_ob (op); 863 op->remove ();
972 864
973 if (QUERY_FLAG (op, FLAG_STARTEQUIP) 865 if (QUERY_FLAG (op, FLAG_STARTEQUIP)
974 || QUERY_FLAG (op, FLAG_NO_DROP) || op->type == RUNE || op->type == TRAP || QUERY_FLAG (op, FLAG_IS_A_TEMPLATE)) 866 || QUERY_FLAG (op, FLAG_NO_DROP) || op->type == RUNE || op->type == TRAP || QUERY_FLAG (op, FLAG_IS_A_TEMPLATE))
975 free_object (op); 867 op->destroy ();
976 else 868 else
977 { 869 {
978 op->x = x; 870 op->x = x;
979 op->y = y; 871 op->y = y;
980 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */ 872 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
… …
983 op = tmp; 875 op = tmp;
984 } 876 }
985 } 877 }
986 } 878 }
987 879
880 // hack to ensure that freed objects still have a valid map
881 {
882 static maptile *freed_map; // freed objects are moved here to avoid crashes
883
884 if (!freed_map)
885 {
886 freed_map = new maptile;
887
888 freed_map->name = "/internal/freed_objects_map";
889 freed_map->width = 3;
890 freed_map->height = 3;
891
892 freed_map->allocate ();
893 }
894
895 map = freed_map;
896 x = 1;
897 y = 1;
898 }
899
988 // clear those pointers that likely might have circular references to us 900 // clear those pointers that likely might have circular references to us
989 owner = 0; 901 owner = 0;
990 enemy = 0; 902 enemy = 0;
991 attacked_by = 0; 903 attacked_by = 0;
992 904
… …
1004 916
1005/* 917/*
1006 * sub_weight() recursively (outwards) subtracts a number from the 918 * sub_weight() recursively (outwards) subtracts a number from the
1007 * weight of an object (and what is carried by it's environment(s)). 919 * weight of an object (and what is carried by it's environment(s)).
1008 */ 920 */
1009
1010void 921void
1011sub_weight (object *op, signed long weight) 922sub_weight (object *op, signed long weight)
1012{ 923{
1013 while (op != NULL) 924 while (op != NULL)
1014 { 925 {
… …
1018 op->carrying -= weight; 929 op->carrying -= weight;
1019 op = op->env; 930 op = op->env;
1020 } 931 }
1021} 932}
1022 933
1023/* remove_ob(op): 934/* op->remove ():
1024 * This function removes the object op from the linked list of objects 935 * This function removes the object op from the linked list of objects
1025 * which it is currently tied to. When this function is done, the 936 * which it is currently tied to. When this function is done, the
1026 * object will have no environment. If the object previously had an 937 * object will have no environment. If the object previously had an
1027 * environment, the x and y coordinates will be updated to 938 * environment, the x and y coordinates will be updated to
1028 * the previous environment. 939 * the previous environment.
1029 * Beware: This function is called from the editor as well! 940 * Beware: This function is called from the editor as well!
1030 */ 941 */
1031
1032void 942void
1033remove_ob (object *op) 943object::remove ()
1034{ 944{
1035 object *tmp, *last = 0; 945 object *tmp, *last = 0;
1036 object *otmp; 946 object *otmp;
1037 947
1038 int check_walk_off; 948 int check_walk_off;
1039 maptile *m;
1040 949
1041 sint16 x, y;
1042
1043 if (QUERY_FLAG (op, FLAG_REMOVED)) 950 if (QUERY_FLAG (this, FLAG_REMOVED))
1044 return; 951 return;
1045 952
1046 SET_FLAG (op, FLAG_REMOVED); 953 SET_FLAG (this, FLAG_REMOVED);
1047 954
1048 if (op->more != NULL) 955 if (more)
1049 remove_ob (op->more); 956 more->remove ();
1050 957
1051 /* 958 /*
1052 * In this case, the object to be removed is in someones 959 * In this case, the object to be removed is in someones
1053 * inventory. 960 * inventory.
1054 */ 961 */
1055 if (op->env != NULL) 962 if (env)
1056 { 963 {
1057 if (op->nrof) 964 if (nrof)
1058 sub_weight (op->env, op->weight * op->nrof); 965 sub_weight (env, weight * nrof);
1059 else 966 else
1060 sub_weight (op->env, op->weight + op->carrying); 967 sub_weight (env, weight + carrying);
1061 968
1062 /* NO_FIX_PLAYER is set when a great many changes are being 969 /* NO_FIX_PLAYER is set when a great many changes are being
1063 * made to players inventory. If set, avoiding the call 970 * made to players inventory. If set, avoiding the call
1064 * to save cpu time. 971 * to save cpu time.
1065 */ 972 */
1066 if ((otmp = is_player_inv (op->env)) != NULL && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 973 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1067 fix_player (otmp); 974 otmp->update_stats ();
1068 975
1069 if (op->above != NULL) 976 if (above != NULL)
1070 op->above->below = op->below; 977 above->below = below;
1071 else 978 else
1072 op->env->inv = op->below; 979 env->inv = below;
1073 980
1074 if (op->below != NULL) 981 if (below != NULL)
1075 op->below->above = op->above; 982 below->above = above;
1076 983
1077 /* we set up values so that it could be inserted into 984 /* we set up values so that it could be inserted into
1078 * the map, but we don't actually do that - it is up 985 * the map, but we don't actually do that - it is up
1079 * to the caller to decide what we want to do. 986 * to the caller to decide what we want to do.
1080 */ 987 */
1081 op->x = op->env->x, op->y = op->env->y; 988 x = env->x, y = env->y;
1082 op->map = op->env->map; 989 map = env->map;
1083 op->above = NULL, op->below = NULL; 990 above = 0, below = 0;
1084 op->env = NULL; 991 env = 0;
1085 } 992 }
1086 else if (op->map) 993 else if (map)
1087 { 994 {
1088 x = op->x;
1089 y = op->y;
1090 m = get_map_from_coord (op->map, &x, &y);
1091
1092 if (!m)
1093 {
1094 LOG (llevError, "remove_ob called when object was on map but appears to not be within valid coordinates? %s (%d,%d)\n",
1095 op->map->path, op->x, op->y);
1096 /* in old days, we used to set x and y to 0 and continue.
1097 * it seems if we get into this case, something is probablye
1098 * screwed up and should be fixed.
1099 */
1100 abort ();
1101 }
1102
1103 if (op->map != m)
1104 LOG (llevDebug, "remove_ob: Object not really on map it claimed to be on? %s != %s, %d,%d != %d,%d\n",
1105 op->map->path, m->path, op->x, op->y, x, y);
1106
1107 /* Re did the following section of code - it looks like it had 995 /* Re did the following section of code - it looks like it had
1108 * lots of logic for things we no longer care about 996 * lots of logic for things we no longer care about
1109 */ 997 */
1110 998
1111 /* link the object above us */ 999 /* link the object above us */
1112 if (op->above) 1000 if (above)
1113 op->above->below = op->below; 1001 above->below = below;
1114 else 1002 else
1115 SET_MAP_TOP (m, x, y, op->below); /* we were top, set new top */ 1003 map->at (x, y).top = below; /* we were top, set new top */
1116 1004
1117 /* Relink the object below us, if there is one */ 1005 /* Relink the object below us, if there is one */
1118 if (op->below) 1006 if (below)
1119 op->below->above = op->above; 1007 below->above = above;
1120 else 1008 else
1121 { 1009 {
1122 /* Nothing below, which means we need to relink map object for this space 1010 /* Nothing below, which means we need to relink map object for this space
1123 * use translated coordinates in case some oddness with map tiling is 1011 * use translated coordinates in case some oddness with map tiling is
1124 * evident 1012 * evident
1125 */ 1013 */
1126 if (GET_MAP_OB (m, x, y) != op) 1014 if (GET_MAP_OB (map, x, y) != this)
1127 { 1015 {
1128 char *dump = dump_object (op); 1016 char *dump = dump_object (this);
1129 LOG (llevError, 1017 LOG (llevError,
1130 "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", dump); 1018 "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", dump);
1131 free (dump); 1019 free (dump);
1132 dump = dump_object (GET_MAP_OB (m, x, y)); 1020 dump = dump_object (GET_MAP_OB (map, x, y));
1133 LOG (llevError, "%s\n", dump); 1021 LOG (llevError, "%s\n", dump);
1134 free (dump); 1022 free (dump);
1135 } 1023 }
1136 1024
1137 SET_MAP_OB (m, x, y, op->above); /* goes on above it. */ 1025 map->at (x, y).bottom = above; /* goes on above it. */
1138 } 1026 }
1139 1027
1140 op->above = 0; 1028 above = 0;
1141 op->below = 0; 1029 below = 0;
1142 1030
1143 if (op->map->in_memory == MAP_SAVING) 1031 if (map->in_memory == MAP_SAVING)
1144 return; 1032 return;
1145 1033
1146 check_walk_off = !QUERY_FLAG (op, FLAG_NO_APPLY); 1034 check_walk_off = !QUERY_FLAG (this, FLAG_NO_APPLY);
1147 1035
1148 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1036 for (tmp = GET_MAP_OB (map, x, y); tmp; tmp = tmp->above)
1149 { 1037 {
1150 /* No point updating the players look faces if he is the object 1038 /* No point updating the players look faces if he is the object
1151 * being removed. 1039 * being removed.
1152 */ 1040 */
1153 1041
1154 if (tmp->type == PLAYER && tmp != op) 1042 if (tmp->type == PLAYER && tmp != this)
1155 { 1043 {
1156 /* If a container that the player is currently using somehow gets 1044 /* If a container that the player is currently using somehow gets
1157 * removed (most likely destroyed), update the player view 1045 * removed (most likely destroyed), update the player view
1158 * appropriately. 1046 * appropriately.
1159 */ 1047 */
1160 if (tmp->container == op) 1048 if (tmp->container == this)
1161 { 1049 {
1162 CLEAR_FLAG (op, FLAG_APPLIED); 1050 CLEAR_FLAG (this, FLAG_APPLIED);
1163 tmp->container = NULL; 1051 tmp->container = 0;
1164 } 1052 }
1165 1053
1166 tmp->contr->socket.update_look = 1; 1054 tmp->contr->ns->floorbox_update ();
1167 } 1055 }
1168 1056
1169 /* See if player moving off should effect something */ 1057 /* See if player moving off should effect something */
1170 if (check_walk_off 1058 if (check_walk_off
1171 && ((op->move_type & tmp->move_off) 1059 && ((move_type & tmp->move_off)
1172 && (op->move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1060 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0))
1173 { 1061 {
1174 move_apply (tmp, op, NULL); 1062 move_apply (tmp, this, 0);
1175 1063
1176 if (op->destroyed ()) 1064 if (destroyed ())
1177 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ()); 1065 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1178 } 1066 }
1179 1067
1180 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */ 1068 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */
1181 1069
1182 if (tmp->above == tmp) 1070 if (tmp->above == tmp)
1183 tmp->above = NULL; 1071 tmp->above = 0;
1184 1072
1185 last = tmp; 1073 last = tmp;
1186 } 1074 }
1187 1075
1188 /* last == NULL of there are no objects on this space */ 1076 /* last == NULL of there are no objects on this space */
1189 if (last == NULL) 1077 if (!last)
1190 { 1078 map->at (x, y).flags_ = P_NEED_UPDATE;
1191 /* set P_NEED_UPDATE, otherwise update_position will complain. In theory,
1192 * we could preserve the flags (GET_MAP_FLAGS), but update_position figures
1193 * those out anyways, and if there are any flags set right now, they won't
1194 * be correct anyways.
1195 */
1196 SET_MAP_FLAGS (op->map, op->x, op->y, P_NEED_UPDATE);
1197 update_position (op->map, op->x, op->y);
1198 }
1199 else 1079 else
1200 update_object (last, UP_OBJ_REMOVE); 1080 update_object (last, UP_OBJ_REMOVE);
1201 1081
1202 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) || (op->glow_radius != 0)) 1082 if (QUERY_FLAG (this, FLAG_BLOCKSVIEW) || glow_radius)
1203 update_all_los (op->map, op->x, op->y); 1083 update_all_los (map, x, y);
1204 } 1084 }
1205} 1085}
1206 1086
1207/* 1087/*
1208 * merge_ob(op,top): 1088 * merge_ob(op,top):
… …
1223 1103
1224 for (; top != NULL; top = top->below) 1104 for (; top != NULL; top = top->below)
1225 { 1105 {
1226 if (top == op) 1106 if (top == op)
1227 continue; 1107 continue;
1228 if (CAN_MERGE (op, top)) 1108
1109 if (object::can_merge (op, top))
1229 { 1110 {
1230 top->nrof += op->nrof; 1111 top->nrof += op->nrof;
1231 1112
1232/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/ 1113/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/
1233 op->weight = 0; /* Don't want any adjustements now */ 1114 op->weight = 0; /* Don't want any adjustements now */
1234 remove_ob (op); 1115 op->destroy ();
1235 free_object (op);
1236 return top; 1116 return top;
1237 } 1117 }
1238 } 1118 }
1239 1119
1240 return 0; 1120 return 0;
… …
1367 1247
1368 /* this has to be done after we translate the coordinates. 1248 /* this has to be done after we translate the coordinates.
1369 */ 1249 */
1370 if (op->nrof && !(flag & INS_NO_MERGE)) 1250 if (op->nrof && !(flag & INS_NO_MERGE))
1371 for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above) 1251 for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above)
1372 if (CAN_MERGE (op, tmp)) 1252 if (object::can_merge (op, tmp))
1373 { 1253 {
1374 op->nrof += tmp->nrof; 1254 op->nrof += tmp->nrof;
1375 remove_ob (tmp); 1255 tmp->destroy ();
1376 free_object (tmp);
1377 } 1256 }
1378 1257
1379 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1258 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1380 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1259 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1381 1260
… …
1394 op->below = originator->below; 1273 op->below = originator->below;
1395 1274
1396 if (op->below) 1275 if (op->below)
1397 op->below->above = op; 1276 op->below->above = op;
1398 else 1277 else
1399 SET_MAP_OB (op->map, op->x, op->y, op); 1278 op->ms ().bottom = op;
1400 1279
1401 /* since *below* originator, no need to update top */ 1280 /* since *below* originator, no need to update top */
1402 originator->below = op; 1281 originator->below = op;
1403 } 1282 }
1404 else 1283 else
… …
1450 * If INS_ON_TOP is used, don't do this processing 1329 * If INS_ON_TOP is used, don't do this processing
1451 * Need to find the object that in fact blocks view, otherwise 1330 * Need to find the object that in fact blocks view, otherwise
1452 * stacking is a bit odd. 1331 * stacking is a bit odd.
1453 */ 1332 */
1454 if (!(flag & INS_ON_TOP) && 1333 if (!(flag & INS_ON_TOP) &&
1455 (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_BLOCKSVIEW) && (op->face && !op->face->visibility)) 1334 (get_map_flags (op->map, 0, op->x, op->y, 0, 0) & P_BLOCKSVIEW) && (op->face && !op->face->visibility))
1456 { 1335 {
1457 for (last = top; last != floor; last = last->below) 1336 for (last = top; last != floor; last = last->below)
1458 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1337 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1459 break; 1338 break;
1460 /* Check to see if we found the object that blocks view, 1339 /* Check to see if we found the object that blocks view,
… …
1483 1362
1484 if (op->above) 1363 if (op->above)
1485 op->above->below = op; 1364 op->above->below = op;
1486 1365
1487 op->below = NULL; 1366 op->below = NULL;
1488 SET_MAP_OB (op->map, op->x, op->y, op); 1367 op->ms ().bottom = op;
1489 } 1368 }
1490 else 1369 else
1491 { /* get inserted into the stack above top */ 1370 { /* get inserted into the stack above top */
1492 op->above = top->above; 1371 op->above = top->above;
1493 1372
… …
1497 op->below = top; 1376 op->below = top;
1498 top->above = op; 1377 top->above = op;
1499 } 1378 }
1500 1379
1501 if (op->above == NULL) 1380 if (op->above == NULL)
1502 SET_MAP_TOP (op->map, op->x, op->y, op); 1381 op->ms ().top = op;
1503 } /* else not INS_BELOW_ORIGINATOR */ 1382 } /* else not INS_BELOW_ORIGINATOR */
1504 1383
1505 if (op->type == PLAYER) 1384 if (op->type == PLAYER)
1506 op->contr->do_los = 1; 1385 op->contr->do_los = 1;
1507 1386
1508 /* If we have a floor, we know the player, if any, will be above 1387 /* If we have a floor, we know the player, if any, will be above
1509 * it, so save a few ticks and start from there. 1388 * it, so save a few ticks and start from there.
1510 */ 1389 */
1511 if (!(flag & INS_MAP_LOAD)) 1390 if (!(flag & INS_MAP_LOAD))
1512 for (tmp = floor ? floor : GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1391 if (object *pl = op->ms ().player ())
1513 if (tmp->type == PLAYER) 1392 pl->contr->ns->floorbox_update ();
1514 tmp->contr->socket.update_look = 1;
1515 1393
1516 /* If this object glows, it may affect lighting conditions that are 1394 /* If this object glows, it may affect lighting conditions that are
1517 * visible to others on this map. But update_all_los is really 1395 * visible to others on this map. But update_all_los is really
1518 * an inefficient way to do this, as it means los for all players 1396 * an inefficient way to do this, as it means los for all players
1519 * on the map will get recalculated. The players could very well 1397 * on the map will get recalculated. The players could very well
… …
1527 1405
1528 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1406 /* updates flags (blocked, alive, no magic, etc) for this map space */
1529 update_object (op, UP_OBJ_INSERT); 1407 update_object (op, UP_OBJ_INSERT);
1530 1408
1531 /* Don't know if moving this to the end will break anything. However, 1409 /* Don't know if moving this to the end will break anything. However,
1532 * we want to have update_look set above before calling this. 1410 * we want to have floorbox_update called before calling this.
1533 * 1411 *
1534 * check_move_on() must be after this because code called from 1412 * check_move_on() must be after this because code called from
1535 * check_move_on() depends on correct map flags (so functions like 1413 * check_move_on() depends on correct map flags (so functions like
1536 * blocked() and wall() work properly), and these flags are updated by 1414 * blocked() and wall() work properly), and these flags are updated by
1537 * update_object(). 1415 * update_object().
… …
1553 1431
1554 return op; 1432 return op;
1555} 1433}
1556 1434
1557/* this function inserts an object in the map, but if it 1435/* this function inserts an object in the map, but if it
1558 * finds an object of its own type, it'll remove that one first. 1436 * finds an object of its own type, it'll remove that one first.
1559 * op is the object to insert it under: supplies x and the map. 1437 * op is the object to insert it under: supplies x and the map.
1560 */ 1438 */
1561void 1439void
1562replace_insert_ob_in_map (const char *arch_string, object *op) 1440replace_insert_ob_in_map (const char *arch_string, object *op)
1563{ 1441{
1564 object * 1442 object *tmp, *tmp1;
1565 tmp;
1566 object *
1567 tmp1;
1568 1443
1569 /* first search for itself and remove any old instances */ 1444 /* first search for itself and remove any old instances */
1570 1445
1571 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1446 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above)
1572 {
1573 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */ 1447 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */
1574 { 1448 tmp->destroy ();
1575 remove_ob (tmp);
1576 free_object (tmp);
1577 }
1578 }
1579 1449
1580 tmp1 = arch_to_object (archetype::find (arch_string)); 1450 tmp1 = arch_to_object (archetype::find (arch_string));
1581 1451
1582 tmp1->x = op->x; 1452 tmp1->x = op->x;
1583 tmp1->y = op->y; 1453 tmp1->y = op->y;
… …
1593 */ 1463 */
1594 1464
1595object * 1465object *
1596get_split_ob (object *orig_ob, uint32 nr) 1466get_split_ob (object *orig_ob, uint32 nr)
1597{ 1467{
1598 object * 1468 object *newob;
1599 newob;
1600 int
1601 is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0); 1469 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1602 1470
1603 if (orig_ob->nrof < nr) 1471 if (orig_ob->nrof < nr)
1604 { 1472 {
1605 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name); 1473 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1606 return NULL; 1474 return NULL;
1607 } 1475 }
1608 1476
1609 newob = object_create_clone (orig_ob); 1477 newob = object_create_clone (orig_ob);
1610 1478
1611 if ((orig_ob->nrof -= nr) < 1) 1479 if ((orig_ob->nrof -= nr) < 1)
1612 { 1480 orig_ob->destroy (1);
1613 if (!is_removed)
1614 remove_ob (orig_ob);
1615 free_object2 (orig_ob, 1);
1616 }
1617 else if (!is_removed) 1481 else if (!is_removed)
1618 { 1482 {
1619 if (orig_ob->env != NULL) 1483 if (orig_ob->env != NULL)
1620 sub_weight (orig_ob->env, orig_ob->weight * nr); 1484 sub_weight (orig_ob->env, orig_ob->weight * nr);
1621 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY) 1485 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY)
… …
1651 if (i > op->nrof) 1515 if (i > op->nrof)
1652 i = op->nrof; 1516 i = op->nrof;
1653 1517
1654 if (QUERY_FLAG (op, FLAG_REMOVED)) 1518 if (QUERY_FLAG (op, FLAG_REMOVED))
1655 op->nrof -= i; 1519 op->nrof -= i;
1656 else if (op->env != NULL) 1520 else if (op->env)
1657 { 1521 {
1658 /* is this object in the players inventory, or sub container 1522 /* is this object in the players inventory, or sub container
1659 * therein? 1523 * therein?
1660 */ 1524 */
1661 tmp = is_player_inv (op->env); 1525 tmp = op->in_player ();
1662 /* nope. Is this a container the player has opened? 1526 /* nope. Is this a container the player has opened?
1663 * If so, set tmp to that player. 1527 * If so, set tmp to that player.
1664 * IMO, searching through all the players will mostly 1528 * IMO, searching through all the players will mostly
1665 * likely be quicker than following op->env to the map, 1529 * likely be quicker than following op->env to the map,
1666 * and then searching the map for a player. 1530 * and then searching the map for a player.
1667 */ 1531 */
1668 if (!tmp) 1532 if (!tmp)
1669 { 1533 {
1670 for (pl = first_player; pl; pl = pl->next) 1534 for (pl = first_player; pl; pl = pl->next)
1671 if (pl->ob->container == op->env) 1535 if (pl->ob->container == op->env)
1536 {
1537 tmp = pl->ob;
1672 break; 1538 break;
1673 if (pl) 1539 }
1674 tmp = pl->ob;
1675 else
1676 tmp = NULL;
1677 } 1540 }
1678 1541
1679 if (i < op->nrof) 1542 if (i < op->nrof)
1680 { 1543 {
1681 sub_weight (op->env, op->weight * i); 1544 sub_weight (op->env, op->weight * i);
1682 op->nrof -= i; 1545 op->nrof -= i;
1683 if (tmp) 1546 if (tmp)
1684 {
1685 esrv_send_item (tmp, op); 1547 esrv_send_item (tmp, op);
1686 }
1687 } 1548 }
1688 else 1549 else
1689 { 1550 {
1690 remove_ob (op); 1551 op->remove ();
1691 op->nrof = 0; 1552 op->nrof = 0;
1692 if (tmp) 1553 if (tmp)
1693 {
1694 esrv_del_item (tmp->contr, op->count); 1554 esrv_del_item (tmp->contr, op->count);
1695 }
1696 } 1555 }
1697 } 1556 }
1698 else 1557 else
1699 { 1558 {
1700 object *above = op->above; 1559 object *above = op->above;
1701 1560
1702 if (i < op->nrof) 1561 if (i < op->nrof)
1703 op->nrof -= i; 1562 op->nrof -= i;
1704 else 1563 else
1705 { 1564 {
1706 remove_ob (op); 1565 op->remove ();
1707 op->nrof = 0; 1566 op->nrof = 0;
1708 } 1567 }
1709 1568
1710 /* Since we just removed op, op->above is null */ 1569 /* Since we just removed op, op->above is null */
1711 for (tmp = above; tmp != NULL; tmp = tmp->above) 1570 for (tmp = above; tmp; tmp = tmp->above)
1712 if (tmp->type == PLAYER) 1571 if (tmp->type == PLAYER)
1713 { 1572 {
1714 if (op->nrof) 1573 if (op->nrof)
1715 esrv_send_item (tmp, op); 1574 esrv_send_item (tmp, op);
1716 else 1575 else
… …
1720 1579
1721 if (op->nrof) 1580 if (op->nrof)
1722 return op; 1581 return op;
1723 else 1582 else
1724 { 1583 {
1725 free_object (op); 1584 op->destroy ();
1726 return NULL; 1585 return 0;
1727 } 1586 }
1728} 1587}
1729 1588
1730/* 1589/*
1731 * add_weight(object, weight) adds the specified weight to an object, 1590 * add_weight(object, weight) adds the specified weight to an object,
… …
1743 op->carrying += weight; 1602 op->carrying += weight;
1744 op = op->env; 1603 op = op->env;
1745 } 1604 }
1746} 1605}
1747 1606
1748/*
1749 * insert_ob_in_ob(op,environment):
1750 * This function inserts the object op in the linked list
1751 * inside the object environment.
1752 *
1753 * Eneq(@csd.uu.se): Altered insert_ob_in_ob to make things picked up enter
1754 * the inventory at the last position or next to other objects of the same
1755 * type.
1756 * Frank: Now sorted by type, archetype and magic!
1757 *
1758 * The function returns now pointer to inserted item, and return value can
1759 * be != op, if items are merged. -Tero
1760 */
1761
1762object * 1607object *
1763insert_ob_in_ob (object *op, object *where) 1608insert_ob_in_ob (object *op, object *where)
1764{ 1609{
1765 object * 1610 if (!where)
1766 tmp, *
1767 otmp;
1768
1769 if (!QUERY_FLAG (op, FLAG_REMOVED))
1770 {
1771 char *dump = dump_object (op);
1772 LOG (llevError, "Trying to insert (ob) inserted object.\n%s\n", dump);
1773 free (dump);
1774 return op;
1775 }
1776
1777 if (where == NULL)
1778 { 1611 {
1779 char *dump = dump_object (op); 1612 char *dump = dump_object (op);
1780 LOG (llevError, "Trying to put object in NULL.\n%s\n", dump); 1613 LOG (llevError, "Trying to put object in NULL.\n%s\n", dump);
1781 free (dump); 1614 free (dump);
1782 return op; 1615 return op;
1783 } 1616 }
1784 1617
1785 if (where->head) 1618 if (where->head)
1786 { 1619 {
1787 LOG (llevDebug, "Warning: Tried to insert object wrong part of multipart object.\n"); 1620 LOG (llevDebug, "Warning: Tried to insert object into wrong part of multipart object.\n");
1788 where = where->head; 1621 where = where->head;
1789 } 1622 }
1623
1624 return where->insert (op);
1625}
1626
1627/*
1628 * env->insert (op)
1629 * This function inserts the object op in the linked list
1630 * inside the object environment.
1631 *
1632 * The function returns now pointer to inserted item, and return value can
1633 * be != op, if items are merged. -Tero
1634 */
1635
1636object *
1637object::insert (object *op)
1638{
1639 object *tmp, *otmp;
1640
1641 if (!QUERY_FLAG (op, FLAG_REMOVED))
1642 op->remove ();
1790 1643
1791 if (op->more) 1644 if (op->more)
1792 { 1645 {
1793 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count); 1646 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);
1794 return op; 1647 return op;
… …
1796 1649
1797 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL); 1650 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL);
1798 CLEAR_FLAG (op, FLAG_REMOVED); 1651 CLEAR_FLAG (op, FLAG_REMOVED);
1799 if (op->nrof) 1652 if (op->nrof)
1800 { 1653 {
1801 for (tmp = where->inv; tmp != NULL; tmp = tmp->below) 1654 for (tmp = inv; tmp != NULL; tmp = tmp->below)
1802 if (CAN_MERGE (tmp, op)) 1655 if (object::can_merge (tmp, op))
1803 { 1656 {
1804 /* return the original object and remove inserted object 1657 /* return the original object and remove inserted object
1805 (client needs the original object) */ 1658 (client needs the original object) */
1806 tmp->nrof += op->nrof; 1659 tmp->nrof += op->nrof;
1807 /* Weight handling gets pretty funky. Since we are adding to 1660 /* Weight handling gets pretty funky. Since we are adding to
1808 * tmp->nrof, we need to increase the weight. 1661 * tmp->nrof, we need to increase the weight.
1809 */ 1662 */
1810 add_weight (where, op->weight * op->nrof); 1663 add_weight (this, op->weight * op->nrof);
1811 SET_FLAG (op, FLAG_REMOVED); 1664 SET_FLAG (op, FLAG_REMOVED);
1812 free_object (op); /* free the inserted object */ 1665 op->destroy (); /* free the inserted object */
1813 op = tmp; 1666 op = tmp;
1814 remove_ob (op); /* and fix old object's links */ 1667 op->remove (); /* and fix old object's links */
1815 CLEAR_FLAG (op, FLAG_REMOVED); 1668 CLEAR_FLAG (op, FLAG_REMOVED);
1816 break; 1669 break;
1817 } 1670 }
1818 1671
1819 /* I assume combined objects have no inventory 1672 /* I assume combined objects have no inventory
1820 * We add the weight - this object could have just been removed 1673 * We add the weight - this object could have just been removed
1821 * (if it was possible to merge). calling remove_ob will subtract 1674 * (if it was possible to merge). calling remove_ob will subtract
1822 * the weight, so we need to add it in again, since we actually do 1675 * the weight, so we need to add it in again, since we actually do
1823 * the linking below 1676 * the linking below
1824 */ 1677 */
1825 add_weight (where, op->weight * op->nrof); 1678 add_weight (this, op->weight * op->nrof);
1826 } 1679 }
1827 else 1680 else
1828 add_weight (where, (op->weight + op->carrying)); 1681 add_weight (this, (op->weight + op->carrying));
1829 1682
1830 otmp = is_player_inv (where); 1683 otmp = this->in_player ();
1831 if (otmp && otmp->contr != NULL) 1684 if (otmp && otmp->contr)
1832 {
1833 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1685 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1834 fix_player (otmp); 1686 otmp->update_stats ();
1835 }
1836 1687
1837 op->map = NULL; 1688 op->map = 0;
1838 op->env = where; 1689 op->env = this;
1839 op->above = NULL; 1690 op->above = 0;
1840 op->below = NULL; 1691 op->below = 0;
1841 op->x = 0, op->y = 0; 1692 op->x = 0, op->y = 0;
1842 1693
1843 /* reset the light list and los of the players on the map */ 1694 /* reset the light list and los of the players on the map */
1844 if ((op->glow_radius != 0) && where->map) 1695 if ((op->glow_radius != 0) && map)
1845 { 1696 {
1846#ifdef DEBUG_LIGHTS 1697#ifdef DEBUG_LIGHTS
1847 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name); 1698 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1848#endif /* DEBUG_LIGHTS */ 1699#endif /* DEBUG_LIGHTS */
1849 if (MAP_DARKNESS (where->map)) 1700 if (MAP_DARKNESS (map))
1850 update_all_los (where->map, where->x, where->y); 1701 update_all_los (map, x, y);
1851 } 1702 }
1852 1703
1853 /* Client has no idea of ordering so lets not bother ordering it here. 1704 /* Client has no idea of ordering so lets not bother ordering it here.
1854 * It sure simplifies this function... 1705 * It sure simplifies this function...
1855 */ 1706 */
1856 if (where->inv == NULL) 1707 if (!inv)
1857 where->inv = op; 1708 inv = op;
1858 else 1709 else
1859 { 1710 {
1860 op->below = where->inv; 1711 op->below = inv;
1861 op->below->above = op; 1712 op->below->above = op;
1862 where->inv = op; 1713 inv = op;
1863 } 1714 }
1715
1864 return op; 1716 return op;
1865} 1717}
1866 1718
1867/* 1719/*
1868 * Checks if any objects has a move_type that matches objects 1720 * Checks if any objects has a move_type that matches objects
… …
2181 * if the space being examined only has a wall to the north and empty 2033 * if the space being examined only has a wall to the north and empty
2182 * spaces in all the other directions, this will reduce the search space 2034 * spaces in all the other directions, this will reduce the search space
2183 * to only the spaces immediately surrounding the target area, and 2035 * to only the spaces immediately surrounding the target area, and
2184 * won't look 2 spaces south of the target space. 2036 * won't look 2 spaces south of the target space.
2185 */ 2037 */
2186 else if ((flag & AB_NO_PASS) && maxfree[i] < stop) 2038 else if ((flag & P_NO_PASS) && maxfree[i] < stop)
2187 stop = maxfree[i]; 2039 stop = maxfree[i];
2188 } 2040 }
2041
2189 if (!index) 2042 if (!index)
2190 return -1; 2043 return -1;
2044
2191 return altern[RANDOM () % index]; 2045 return altern[RANDOM () % index];
2192} 2046}
2193 2047
2194/* 2048/*
2195 * find_first_free_spot(archetype, maptile, x, y) works like 2049 * find_first_free_spot(archetype, maptile, x, y) works like
… …
2303 mp = m; 2157 mp = m;
2304 nx = x + freearr_x[i]; 2158 nx = x + freearr_x[i];
2305 ny = y + freearr_y[i]; 2159 ny = y + freearr_y[i];
2306 2160
2307 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2161 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);
2162
2308 if (mflags & P_OUT_OF_MAP) 2163 if (mflags & P_OUT_OF_MAP)
2309 {
2310 max = maxfree[i]; 2164 max = maxfree[i];
2311 }
2312 else 2165 else
2313 { 2166 {
2314 blocked = GET_MAP_MOVE_BLOCK (mp, nx, ny); 2167 blocked = GET_MAP_MOVE_BLOCK (mp, nx, ny);
2315 2168
2316 if ((move_type & blocked) == move_type) 2169 if ((move_type & blocked) == move_type)
2317 {
2318 max = maxfree[i]; 2170 max = maxfree[i];
2319 }
2320 else if (mflags & P_IS_ALIVE) 2171 else if (mflags & P_IS_ALIVE)
2321 { 2172 {
2322 for (tmp = GET_MAP_OB (mp, nx, ny); tmp != NULL; tmp = tmp->above) 2173 for (tmp = GET_MAP_OB (mp, nx, ny); tmp; tmp = tmp->above)
2323 {
2324 if ((QUERY_FLAG (tmp, FLAG_MONSTER) || tmp->type == PLAYER) && (tmp != exclude || (tmp->head && tmp->head != exclude))) 2174 if ((QUERY_FLAG (tmp, FLAG_MONSTER) || tmp->type == PLAYER) && (tmp != exclude || (tmp->head && tmp->head != exclude)))
2325 {
2326 break; 2175 break;
2327 } 2176
2328 }
2329 if (tmp) 2177 if (tmp)
2330 {
2331 return freedir[i]; 2178 return freedir[i];
2332 }
2333 } 2179 }
2334 } 2180 }
2335 } 2181 }
2182
2336 return 0; 2183 return 0;
2337} 2184}
2338 2185
2339/* 2186/*
2340 * distance(object 1, object 2) will return the square of the 2187 * distance(object 1, object 2) will return the square of the
… …
2342 */ 2189 */
2343 2190
2344int 2191int
2345distance (const object *ob1, const object *ob2) 2192distance (const object *ob1, const object *ob2)
2346{ 2193{
2347 int 2194 int i;
2348 i;
2349 2195
2350 i = (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y); 2196 i = (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2351 return i; 2197 return i;
2352} 2198}
2353 2199
… …
2358 */ 2204 */
2359 2205
2360int 2206int
2361find_dir_2 (int x, int y) 2207find_dir_2 (int x, int y)
2362{ 2208{
2363 int 2209 int q;
2364 q;
2365 2210
2366 if (y) 2211 if (y)
2367 q = x * 100 / y; 2212 q = x * 100 / y;
2368 else if (x) 2213 else if (x)
2369 q = -300 * x; 2214 q = -300 * x;
… …
2495 * find a path to that monster that we found. If not, 2340 * find a path to that monster that we found. If not,
2496 * we don't bother going toward it. Returns 1 if we 2341 * we don't bother going toward it. Returns 1 if we
2497 * can see a direct way to get it 2342 * can see a direct way to get it
2498 * Modified to be map tile aware -.MSW 2343 * Modified to be map tile aware -.MSW
2499 */ 2344 */
2500
2501
2502int 2345int
2503can_see_monsterP (maptile *m, int x, int y, int dir) 2346can_see_monsterP (maptile *m, int x, int y, int dir)
2504{ 2347{
2505 sint16 dx, dy; 2348 sint16 dx, dy;
2506 int
2507 mflags; 2349 int mflags;
2508 2350
2509 if (dir < 0) 2351 if (dir < 0)
2510 return 0; /* exit condition: invalid direction */ 2352 return 0; /* exit condition: invalid direction */
2511 2353
2512 dx = x + freearr_x[dir]; 2354 dx = x + freearr_x[dir];
… …
2525 return 0; 2367 return 0;
2526 2368
2527 /* yes, can see. */ 2369 /* yes, can see. */
2528 if (dir < 9) 2370 if (dir < 9)
2529 return 1; 2371 return 1;
2372
2530 return can_see_monsterP (m, x, y, reduction_dir[dir][0]) | 2373 return can_see_monsterP (m, x, y, reduction_dir[dir][0])
2531 can_see_monsterP (m, x, y, reduction_dir[dir][1]) | can_see_monsterP (m, x, y, reduction_dir[dir][2]); 2374 | can_see_monsterP (m, x, y, reduction_dir[dir][1])
2375 | can_see_monsterP (m, x, y, reduction_dir[dir][2]);
2532} 2376}
2533
2534
2535 2377
2536/* 2378/*
2537 * can_pick(picker, item): finds out if an object is possible to be 2379 * can_pick(picker, item): finds out if an object is possible to be
2538 * picked up by the picker. Returnes 1 if it can be 2380 * picked up by the picker. Returnes 1 if it can be
2539 * picked up, otherwise 0. 2381 * picked up, otherwise 0.
… …
2550 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2392 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2551 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2393 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2552 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2394 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));
2553} 2395}
2554 2396
2555
2556/* 2397/*
2557 * create clone from object to another 2398 * create clone from object to another
2558 */ 2399 */
2559object * 2400object *
2560object_create_clone (object *asrc) 2401object_create_clone (object *asrc)
2561{ 2402{
2562 object *
2563 dst = NULL, *tmp, *src, *part, *prev, *item; 2403 object *dst = 0, *tmp, *src, *part, *prev, *item;
2564 2404
2565 if (!asrc) 2405 if (!asrc)
2566 return NULL; 2406 return 0;
2407
2567 src = asrc; 2408 src = asrc;
2568 if (src->head) 2409 if (src->head)
2569 src = src->head; 2410 src = src->head;
2570 2411
2571 prev = NULL; 2412 prev = 0;
2572 for (part = src; part; part = part->more) 2413 for (part = src; part; part = part->more)
2573 { 2414 {
2574 tmp = get_object (); 2415 tmp = part->clone ();
2575 copy_object (part, tmp);
2576 tmp->x -= src->x; 2416 tmp->x -= src->x;
2577 tmp->y -= src->y; 2417 tmp->y -= src->y;
2418
2578 if (!part->head) 2419 if (!part->head)
2579 { 2420 {
2580 dst = tmp; 2421 dst = tmp;
2581 tmp->head = NULL; 2422 tmp->head = 0;
2582 } 2423 }
2583 else 2424 else
2584 {
2585 tmp->head = dst; 2425 tmp->head = dst;
2586 } 2426
2587 tmp->more = NULL; 2427 tmp->more = 0;
2428
2588 if (prev) 2429 if (prev)
2589 prev->more = tmp; 2430 prev->more = tmp;
2431
2590 prev = tmp; 2432 prev = tmp;
2591 } 2433 }
2592 2434
2593 for (item = src->inv; item; item = item->below) 2435 for (item = src->inv; item; item = item->below)
2594 insert_ob_in_ob (object_create_clone (item), dst); 2436 insert_ob_in_ob (object_create_clone (item), dst);
… …
2620 } 2462 }
2621 2463
2622 fprintf (tempfile, obstr); 2464 fprintf (tempfile, obstr);
2623 fclose (tempfile); 2465 fclose (tempfile);
2624 2466
2625 op = get_object (); 2467 op = object::create ();
2626 2468
2627 object_thawer thawer (filename); 2469 object_thawer thawer (filename);
2628 2470
2629 if (thawer) 2471 if (thawer)
2630 load_object (thawer, op, 0); 2472 load_object (thawer, op, 0);

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines