ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.49 by root, Sat Sep 16 22:24:12 2006 UTC vs.
Revision 1.107 by pippijn, Sat Jan 6 14:42:29 2007 UTC

1/* 1/*
2 CrossFire, A Multiplayer game for X-windows 2 CrossFire, A Multiplayer game for X-windows
3 3
4 Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team
4 Copyright (C) 2001 Mark Wedel & Crossfire Development Team 5 Copyright (C) 2001 Mark Wedel & Crossfire Development Team
5 Copyright (C) 1992 Frank Tore Johansen 6 Copyright (C) 1992 Frank Tore Johansen
6 7
7 This program is free software; you can redistribute it and/or modify 8 This program is free software; you can redistribute it and/or modify
8 it under the terms of the GNU General Public License as published by 9 it under the terms of the GNU General Public License as published by
29#include <sys/types.h> 30#include <sys/types.h>
30#include <sys/uio.h> 31#include <sys/uio.h>
31#include <object.h> 32#include <object.h>
32#include <funcpoint.h> 33#include <funcpoint.h>
33#include <loader.h> 34#include <loader.h>
35
36#include <bitset>
34 37
35int nrofallocobjects = 0; 38int nrofallocobjects = 0;
36static UUID uuid; 39static UUID uuid;
37const uint64 UUID_SKIP = 1<<19; 40const uint64 UUID_SKIP = 1<<19;
38 41
104 _exit (1); 107 _exit (1);
105 } 108 }
106 109
107 uuid.seq = uid; 110 uuid.seq = uid;
108 write_uuid (); 111 write_uuid ();
109 LOG (llevDebug, "read UID: %lld\n", uid); 112 LOG (llevDebug, "read UID: %" PRId64 "\n", uid);
110 fclose (fp); 113 fclose (fp);
111} 114}
112 115
113UUID 116UUID
114gen_uuid () 117gen_uuid ()
139 * objects with lists are rare, and lists stay short. If not, use a 142 * objects with lists are rare, and lists stay short. If not, use a
140 * different structure or at least keep the lists sorted... 143 * different structure or at least keep the lists sorted...
141 */ 144 */
142 145
143 /* For each field in wants, */ 146 /* For each field in wants, */
144 for (wants_field = wants->key_values; wants_field != NULL; wants_field = wants_field->next) 147 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)
145 { 148 {
146 key_value *has_field; 149 key_value *has_field;
147 150
148 /* Look for a field in has with the same key. */ 151 /* Look for a field in has with the same key. */
149 has_field = get_ob_key_link (has, wants_field->key); 152 has_field = get_ob_key_link (has, wants_field->key);
183 * 186 *
184 * Note that this function appears a lot longer than the macro it 187 * Note that this function appears a lot longer than the macro it
185 * replaces - this is mostly for clarity - a decent compiler should hopefully 188 * replaces - this is mostly for clarity - a decent compiler should hopefully
186 * reduce this to the same efficiency. 189 * reduce this to the same efficiency.
187 * 190 *
188 * Check nrof variable *before* calling CAN_MERGE() 191 * Check nrof variable *before* calling can_merge()
189 * 192 *
190 * Improvements made with merge: Better checking on potion, and also 193 * Improvements made with merge: Better checking on potion, and also
191 * check weight 194 * check weight
192 */ 195 */
193
194bool object::can_merge (object *ob1, object *ob2) 196bool object::can_merge_slow (object *ob1, object *ob2)
195{ 197{
196 /* A couple quicksanity checks */ 198 /* A couple quicksanity checks */
197 if ((ob1 == ob2) || (ob1->type != ob2->type)) 199 if (ob1 == ob2
200 || ob1->type != ob2->type
201 || ob1->speed != ob2->speed
202 || ob1->value != ob2->value
203 || ob1->name != ob2->name)
198 return 0; 204 return 0;
199 205
200 if (ob1->speed != ob2->speed) 206 //TODO: this ain't working well, use nicer and correct overflow check
201 return 0;
202
203 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that 207 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that
204 * value could not be stored in a sint32 (which unfortunately sometimes is 208 * value could not be stored in a sint32 (which unfortunately sometimes is
205 * used to store nrof). 209 * used to store nrof).
206 */ 210 */
207 if (ob1->nrof + ob2->nrof >= 1UL << 31) 211 if (ob1->nrof + ob2->nrof >= 1UL << 31)
217 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 221 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
218 222
219 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 223 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
220 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 224 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
221 225
222 226 if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any ()
223 /* the 0x400000 on flags2 is FLAG_INV_LOCK. I don't think something 227 || ob1->arch != ob2->arch
224 * being locked in inventory should prevent merging.
225 * 0x4 in flags3 is CLIENT_SENT
226 */
227 if ((ob1->arch != ob2->arch) ||
228 (ob1->flags[0] != ob2->flags[0]) ||
229 (ob1->flags[1] != ob2->flags[1]) ||
230 ((ob1->flags[2] & ~0x400000) != (ob2->flags[2] & ~0x400000)) ||
231 ((ob1->flags[3] & ~0x4) != (ob2->flags[3] & ~0x4)) ||
232 (ob1->name != ob2->name) || 228 || ob1->name != ob2->name
233 (ob1->title != ob2->title) || 229 || ob1->title != ob2->title
234 (ob1->msg != ob2->msg) || 230 || ob1->msg != ob2->msg
235 (ob1->weight != ob2->weight) || 231 || ob1->weight != ob2->weight
236 (memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist)) != 0) || 232 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
237 (memcmp (&ob1->stats, &ob2->stats, sizeof (ob1->stats)) != 0) || 233 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
238 (ob1->attacktype != ob2->attacktype) || 234 || ob1->attacktype != ob2->attacktype
239 (ob1->magic != ob2->magic) || 235 || ob1->magic != ob2->magic
240 (ob1->slaying != ob2->slaying) || 236 || ob1->slaying != ob2->slaying
241 (ob1->skill != ob2->skill) || 237 || ob1->skill != ob2->skill
242 (ob1->value != ob2->value) || 238 || ob1->value != ob2->value
243 (ob1->animation_id != ob2->animation_id) || 239 || ob1->animation_id != ob2->animation_id
244 (ob1->client_type != ob2->client_type) || 240 || ob1->client_type != ob2->client_type
245 (ob1->materialname != ob2->materialname) || 241 || ob1->materialname != ob2->materialname
246 (ob1->lore != ob2->lore) || 242 || ob1->lore != ob2->lore
247 (ob1->subtype != ob2->subtype) || 243 || ob1->subtype != ob2->subtype
248 (ob1->move_type != ob2->move_type) || 244 || ob1->move_type != ob2->move_type
249 (ob1->move_block != ob2->move_block) || 245 || ob1->move_block != ob2->move_block
250 (ob1->move_allow != ob2->move_allow) || 246 || ob1->move_allow != ob2->move_allow
251 (ob1->move_on != ob2->move_on) || 247 || ob1->move_on != ob2->move_on
252 (ob1->move_off != ob2->move_off) || (ob1->move_slow != ob2->move_slow) || (ob1->move_slow_penalty != ob2->move_slow_penalty)) 248 || ob1->move_off != ob2->move_off
249 || ob1->move_slow != ob2->move_slow
250 || ob1->move_slow_penalty != ob2->move_slow_penalty)
253 return 0; 251 return 0;
254 252
255 /* This is really a spellbook check - really, we should 253 /* This is really a spellbook check - really, we should
256 * check all objects in the inventory. 254 * check all objects in the inventory.
257 */ 255 */
260 /* if one object has inventory but the other doesn't, not equiv */ 258 /* if one object has inventory but the other doesn't, not equiv */
261 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv)) 259 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv))
262 return 0; 260 return 0;
263 261
264 /* Now check to see if the two inventory objects could merge */ 262 /* Now check to see if the two inventory objects could merge */
265 if (!CAN_MERGE (ob1->inv, ob2->inv)) 263 if (!object::can_merge (ob1->inv, ob2->inv))
266 return 0; 264 return 0;
267 265
268 /* inventory ok - still need to check rest of this object to see 266 /* inventory ok - still need to check rest of this object to see
269 * if it is valid. 267 * if it is valid.
270 */ 268 */
279 277
280 /* Note sure why the following is the case - either the object has to 278 /* Note sure why the following is the case - either the object has to
281 * be animated or have a very low speed. Is this an attempted monster 279 * be animated or have a very low speed. Is this an attempted monster
282 * check? 280 * check?
283 */ 281 */
284 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && FABS ((ob1)->speed) > MIN_ACTIVE_SPEED) 282 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && ob1->has_active_speed ())
285 return 0; 283 return 0;
286 284
287 switch (ob1->type) 285 switch (ob1->type)
288 { 286 {
289 case SCROLL: 287 case SCROLL:
354 op = op->env; 352 op = op->env;
355 return op; 353 return op;
356} 354}
357 355
358/* 356/*
359 * Eneq(@csd.uu.se): Since we can have items buried in a character we need
360 * a better check. We basically keeping traversing up until we can't
361 * or find a player.
362 */
363
364object *
365is_player_inv (object *op)
366{
367 for (; op != NULL && op->type != PLAYER; op = op->env)
368 if (op->env == op)
369 op->env = NULL;
370 return op;
371}
372
373/*
374 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump. 357 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
375 * Some error messages. 358 * Some error messages.
376 * The result of the dump is stored in the static global errmsg array. 359 * The result of the dump is stored in the static global errmsg array.
377 */ 360 */
378 361
379void 362char *
380dump_object2 (object *op)
381{
382 errmsg[0] = 0;
383 return;
384 //TODO//D#d#
385#if 0
386 char *cp;
387
388/* object *tmp;*/
389
390 if (op->arch != NULL)
391 {
392 strcat (errmsg, "arch ");
393 strcat (errmsg, op->arch->name ? op->arch->name : "(null)");
394 strcat (errmsg, "\n");
395 if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
396 strcat (errmsg, cp);
397# if 0
398 /* Don't dump player diffs - they are too long, mostly meaningless, and
399 * will overflow the buffer.
400 * Changed so that we don't dump inventory either. This may
401 * also overflow the buffer.
402 */
403 if (op->type != PLAYER && (cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
404 strcat (errmsg, cp);
405 for (tmp = op->inv; tmp; tmp = tmp->below)
406 dump_object2 (tmp);
407# endif
408 strcat (errmsg, "end\n");
409 }
410 else
411 {
412 strcat (errmsg, "Object ");
413 if (op->name == NULL)
414 strcat (errmsg, "(null)");
415 else
416 strcat (errmsg, op->name);
417 strcat (errmsg, "\n");
418# if 0
419 if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
420 strcat (errmsg, cp);
421 for (tmp = op->inv; tmp; tmp = tmp->below)
422 dump_object2 (tmp);
423# endif
424 strcat (errmsg, "end\n");
425 }
426#endif
427}
428
429/*
430 * Dumps an object. Returns output in the static global errmsg array.
431 */
432
433void
434dump_object (object *op) 363dump_object (object *op)
435{ 364{
436 if (op == NULL) 365 if (!op)
437 { 366 return strdup ("[NULLOBJ]");
438 strcpy (errmsg, "[NULL pointer]");
439 return;
440 }
441 errmsg[0] = '\0';
442 dump_object2 (op);
443}
444 367
445void 368 object_freezer freezer;
446dump_all_objects (void) 369 save_object (freezer, op, 1);
447{ 370 return freezer.as_string ();
448 object *op;
449
450 for (op = object::first; op != NULL; op = op->next)
451 {
452 dump_object (op);
453 fprintf (logfile, "Object %s\n", errmsg);
454 }
455} 371}
456 372
457/* 373/*
458 * get_nearest_part(multi-object, object 2) returns the part of the 374 * get_nearest_part(multi-object, object 2) returns the part of the
459 * multi-object 1 which is closest to the second object. 375 * multi-object 1 which is closest to the second object.
479 */ 395 */
480 396
481object * 397object *
482find_object (tag_t i) 398find_object (tag_t i)
483{ 399{
484 object *op;
485
486 for (op = object::first; op != NULL; op = op->next) 400 for (object *op = object::first; op; op = op->next)
487 if (op->count == i) 401 if (op->count == i)
488 break; 402 return op;
489 403
490 return op; 404 return 0;
491} 405}
492 406
493/* 407/*
494 * Returns the first object which has a name equal to the argument. 408 * Returns the first object which has a name equal to the argument.
495 * Used only by the patch command, but not all that useful. 409 * Used only by the patch command, but not all that useful.
553 } 467 }
554 468
555 op->key_values = 0; 469 op->key_values = 0;
556} 470}
557 471
558void object::clear ()
559{
560 attachable_base::clear ();
561
562 free_key_values (this);
563
564 owner = 0;
565 name = 0;
566 name_pl = 0;
567 title = 0;
568 race = 0;
569 slaying = 0;
570 skill = 0;
571 msg = 0;
572 lore = 0;
573 custom_name = 0;
574 materialname = 0;
575 contr = 0;
576 below = 0;
577 above = 0;
578 inv = 0;
579 container = 0;
580 env = 0;
581 more = 0;
582 head = 0;
583 map = 0;
584 active_next = 0;
585 active_prev = 0;
586
587 memset (static_cast<object_pod *>(this), 0, sizeof (object_pod));
588
589 SET_FLAG (this, FLAG_REMOVED);
590
591 /* What is not cleared is next, prev, and count */
592
593 expmul = 1.0;
594 face = blank_face;
595
596 if (settings.casting_time)
597 casting_time = -1;
598}
599
600void object::clone (object *destination)
601{
602 *(object_copy *)destination = *this;
603 *(object_pod *)destination = *this;
604
605 if (self || cb)
606 INVOKE_OBJECT (CLONE, this, ARG_OBJECT (destination));
607}
608
609/* 472/*
610 * copy object first frees everything allocated by the second object, 473 * copy_to first frees everything allocated by the dst object,
611 * and then copies the contends of the first object into the second 474 * and then copies the contents of itself into the second
612 * object, allocating what needs to be allocated. Basically, any 475 * object, allocating what needs to be allocated. Basically, any
613 * data that is malloc'd needs to be re-malloc/copied. Otherwise, 476 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
614 * if the first object is freed, the pointers in the new object 477 * if the first object is freed, the pointers in the new object
615 * will point at garbage. 478 * will point at garbage.
616 */ 479 */
617void 480void
618copy_object (object *op2, object *op) 481object::copy_to (object *dst)
619{ 482{
620 bool is_freed = QUERY_FLAG (op, FLAG_FREED); 483 bool is_freed = QUERY_FLAG (dst, FLAG_FREED);
621 bool is_removed = QUERY_FLAG (op, FLAG_REMOVED); 484 bool is_removed = QUERY_FLAG (dst, FLAG_REMOVED);
622 485
623 op2->clone (op); 486 *(object_copy *)dst = *this;
624 487
625 if (is_freed) 488 if (is_freed)
626 SET_FLAG (op, FLAG_FREED); 489 SET_FLAG (dst, FLAG_FREED);
490
627 if (is_removed) 491 if (is_removed)
628 SET_FLAG (op, FLAG_REMOVED); 492 SET_FLAG (dst, FLAG_REMOVED);
629 493
630 if (op2->speed < 0) 494 if (speed < 0)
631 op->speed_left = op2->speed_left - RANDOM () % 200 / 100.0; 495 dst->speed_left = speed_left - RANDOM () % 200 / 100.0;
632 496
633 /* Copy over key_values, if any. */ 497 /* Copy over key_values, if any. */
634 if (op2->key_values) 498 if (key_values)
635 { 499 {
636 key_value *tail = 0; 500 key_value *tail = 0;
637 key_value *i; 501 key_value *i;
638 502
639 op->key_values = 0; 503 dst->key_values = 0;
640 504
641 for (i = op2->key_values; i; i = i->next) 505 for (i = key_values; i; i = i->next)
642 { 506 {
643 key_value *new_link = new key_value; 507 key_value *new_link = new key_value;
644 508
645 new_link->next = 0; 509 new_link->next = 0;
646 new_link->key = i->key; 510 new_link->key = i->key;
647 new_link->value = i->value; 511 new_link->value = i->value;
648 512
649 /* Try and be clever here, too. */ 513 /* Try and be clever here, too. */
650 if (!op->key_values) 514 if (!dst->key_values)
651 { 515 {
652 op->key_values = new_link; 516 dst->key_values = new_link;
653 tail = new_link; 517 tail = new_link;
654 } 518 }
655 else 519 else
656 { 520 {
657 tail->next = new_link; 521 tail->next = new_link;
658 tail = new_link; 522 tail = new_link;
659 } 523 }
660 } 524 }
661 } 525 }
662 526
663 update_ob_speed (op); 527 dst->set_speed (dst->speed);
528}
529
530object *
531object::clone ()
532{
533 object *neu = create ();
534 copy_to (neu);
535 return neu;
664} 536}
665 537
666/* 538/*
667 * If an object with the IS_TURNABLE() flag needs to be turned due 539 * If an object with the IS_TURNABLE() flag needs to be turned due
668 * to the closest player being on the other side, this function can 540 * to the closest player being on the other side, this function can
669 * be called to update the face variable, _and_ how it looks on the map. 541 * be called to update the face variable, _and_ how it looks on the map.
670 */ 542 */
671
672void 543void
673update_turn_face (object *op) 544update_turn_face (object *op)
674{ 545{
675 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || op->arch == NULL) 546 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || !op->arch)
676 return; 547 return;
548
677 SET_ANIMATION (op, op->direction); 549 SET_ANIMATION (op, op->direction);
678 update_object (op, UP_OBJ_FACE); 550 update_object (op, UP_OBJ_FACE);
679} 551}
680 552
681/* 553/*
682 * Updates the speed of an object. If the speed changes from 0 to another 554 * Updates the speed of an object. If the speed changes from 0 to another
683 * value, or vice versa, then add/remove the object from the active list. 555 * value, or vice versa, then add/remove the object from the active list.
684 * This function needs to be called whenever the speed of an object changes. 556 * This function needs to be called whenever the speed of an object changes.
685 */ 557 */
686void 558void
687update_ob_speed (object *op) 559object::set_speed (float speed)
688{ 560{
689 extern int arch_init; 561 if (flag [FLAG_FREED] && speed)
690
691 /* No reason putting the archetypes objects on the speed list,
692 * since they never really need to be updated.
693 */
694
695 if (QUERY_FLAG (op, FLAG_FREED) && op->speed)
696 { 562 {
697 LOG (llevError, "Object %s is freed but has speed.\n", &op->name); 563 LOG (llevError, "Object %s is freed but has speed.\n", &name);
698#ifdef MANY_CORES
699 abort ();
700#else
701 op->speed = 0; 564 speed = 0;
702#endif
703 }
704
705 if (arch_init)
706 return;
707
708 if (FABS (op->speed) > MIN_ACTIVE_SPEED)
709 { 565 }
710 /* If already on active list, don't do anything */
711 if (op->active_next || op->active_prev || op == active_objects)
712 return;
713 566
714 /* process_events() expects us to insert the object at the beginning 567 this->speed = speed;
715 * of the list. */
716 op->active_next = active_objects;
717 568
718 if (op->active_next != NULL) 569 if (has_active_speed ())
719 op->active_next->active_prev = op; 570 activate ();
720
721 active_objects = op;
722 }
723 else 571 else
724 { 572 deactivate ();
725 /* If not on the active list, nothing needs to be done */
726 if (!op->active_next && !op->active_prev && op != active_objects)
727 return;
728
729 if (op->active_prev == NULL)
730 {
731 active_objects = op->active_next;
732
733 if (op->active_next != NULL)
734 op->active_next->active_prev = NULL;
735 }
736 else
737 {
738 op->active_prev->active_next = op->active_next;
739
740 if (op->active_next)
741 op->active_next->active_prev = op->active_prev;
742 }
743
744 op->active_next = NULL;
745 op->active_prev = NULL;
746 }
747} 573}
748 574
749/* This function removes object 'op' from the list of active
750 * objects.
751 * This should only be used for style maps or other such
752 * reference maps where you don't want an object that isn't
753 * in play chewing up cpu time getting processed.
754 * The reverse of this is to call update_ob_speed, which
755 * will do the right thing based on the speed of the object.
756 */
757void
758remove_from_active_list (object *op)
759{
760 /* If not on the active list, nothing needs to be done */
761 if (!op->active_next && !op->active_prev && op != active_objects)
762 return;
763
764 if (op->active_prev == NULL)
765 {
766 active_objects = op->active_next;
767 if (op->active_next != NULL)
768 op->active_next->active_prev = NULL;
769 }
770 else
771 {
772 op->active_prev->active_next = op->active_next;
773 if (op->active_next)
774 op->active_next->active_prev = op->active_prev;
775 }
776 op->active_next = NULL;
777 op->active_prev = NULL;
778}
779
780/* 575/*
781 * update_object() updates the array which represents the map. 576 * update_object() updates the the map.
782 * It takes into account invisible objects (and represent squares covered 577 * It takes into account invisible objects (and represent squares covered
783 * by invisible objects by whatever is below them (unless it's another 578 * by invisible objects by whatever is below them (unless it's another
784 * invisible object, etc...) 579 * invisible object, etc...)
785 * If the object being updated is beneath a player, the look-window 580 * If the object being updated is beneath a player, the look-window
786 * of that player is updated (this might be a suboptimal way of 581 * of that player is updated (this might be a suboptimal way of
787 * updating that window, though, since update_object() is called _often_) 582 * updating that window, though, since update_object() is called _often_)
788 * 583 *
789 * action is a hint of what the caller believes need to be done. 584 * action is a hint of what the caller believes need to be done.
790 * For example, if the only thing that has changed is the face (due to
791 * an animation), we don't need to call update_position until that actually
792 * comes into view of a player. OTOH, many other things, like addition/removal
793 * of walls or living creatures may need us to update the flags now.
794 * current action are: 585 * current action are:
795 * UP_OBJ_INSERT: op was inserted 586 * UP_OBJ_INSERT: op was inserted
796 * UP_OBJ_REMOVE: op was removed 587 * UP_OBJ_REMOVE: op was removed
797 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update 588 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update
798 * as that is easier than trying to look at what may have changed. 589 * as that is easier than trying to look at what may have changed.
799 * UP_OBJ_FACE: only the objects face has changed. 590 * UP_OBJ_FACE: only the objects face has changed.
800 */ 591 */
801
802void 592void
803update_object (object *op, int action) 593update_object (object *op, int action)
804{ 594{
805 int update_now = 0, flags;
806 MoveType move_on, move_off, move_block, move_slow; 595 MoveType move_on, move_off, move_block, move_slow;
807 596
808 if (op == NULL) 597 if (op == NULL)
809 { 598 {
810 /* this should never happen */ 599 /* this should never happen */
811 LOG (llevDebug, "update_object() called for NULL object.\n"); 600 LOG (llevDebug, "update_object() called for NULL object.\n");
812 return; 601 return;
813 } 602 }
814 603
815 if (op->env != NULL) 604 if (op->env)
816 { 605 {
817 /* Animation is currently handled by client, so nothing 606 /* Animation is currently handled by client, so nothing
818 * to do in this case. 607 * to do in this case.
819 */ 608 */
820 return; 609 return;
825 */ 614 */
826 if (!op->map || op->map->in_memory == MAP_SAVING) 615 if (!op->map || op->map->in_memory == MAP_SAVING)
827 return; 616 return;
828 617
829 /* make sure the object is within map boundaries */ 618 /* make sure the object is within map boundaries */
830 if (op->x < 0 || op->x >= MAP_WIDTH (op->map) || op->y < 0 || op->y >= MAP_HEIGHT (op->map)) 619 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
831 { 620 {
832 LOG (llevError, "update_object() called for object out of map!\n"); 621 LOG (llevError, "update_object() called for object out of map!\n");
833#ifdef MANY_CORES 622#ifdef MANY_CORES
834 abort (); 623 abort ();
835#endif 624#endif
836 return; 625 return;
837 } 626 }
838 627
839 flags = GET_MAP_FLAGS (op->map, op->x, op->y); 628 mapspace &m = op->ms ();
840 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NEED_UPDATE);
841 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
842 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
843 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
844 move_off = GET_MAP_MOVE_OFF (op->map, op->x, op->y);
845 629
630 if (!(m.flags_ & P_UPTODATE))
631 /* nop */;
846 if (action == UP_OBJ_INSERT) 632 else if (action == UP_OBJ_INSERT)
847 { 633 {
634 // this is likely overkill, TODO: revisit (schmorp)
848 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(flags & P_BLOCKSVIEW)) 635 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
849 update_now = 1;
850
851 if (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(flags & P_NO_MAGIC)) 636 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
852 update_now = 1; 637 || (op->type == PLAYER && !(m.flags_ & P_PLAYER))
853 638 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
639 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
854 if (QUERY_FLAG (op, FLAG_DAMNED) && !(flags & P_NO_CLERIC)) 640 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
855 update_now = 1;
856
857 if (QUERY_FLAG (op, FLAG_ALIVE) && !(flags & P_IS_ALIVE))
858 update_now = 1;
859
860 if (op->type == SAFE_GROUND && !(flags & P_SAFE))
861 update_now = 1;
862
863 if ((move_on | op->move_on) != move_on) 641 || (m.move_on | op->move_on ) != m.move_on
864 update_now = 1;
865
866 if ((move_off | op->move_off) != move_off) 642 || (m.move_off | op->move_off ) != m.move_off
867 update_now = 1; 643 || (m.move_slow | op->move_slow) != m.move_slow
868
869 /* This isn't perfect, but I don't expect a lot of objects to 644 /* This isn't perfect, but I don't expect a lot of objects to
870 * to have move_allow right now. 645 * to have move_allow right now.
871 */ 646 */
872 if (((move_block | op->move_block) & ~op->move_allow) != move_block) 647 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
873 update_now = 1; 648 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
874 649 m.flags_ = 0;
875 if ((move_slow | op->move_slow) != move_slow)
876 update_now = 1;
877 } 650 }
878 /* if the object is being removed, we can't make intelligent 651 /* if the object is being removed, we can't make intelligent
879 * decisions, because remove_ob can't really pass the object 652 * decisions, because remove_ob can't really pass the object
880 * that is being removed. 653 * that is being removed.
881 */ 654 */
882 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 655 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
883 update_now = 1; 656 m.flags_ = 0;
884 else if (action == UP_OBJ_FACE) 657 else if (action == UP_OBJ_FACE)
885 /* Nothing to do for that case */ ; 658 /* Nothing to do for that case */ ;
886 else 659 else
887 LOG (llevError, "update_object called with invalid action: %d\n", action); 660 LOG (llevError, "update_object called with invalid action: %d\n", action);
888 661
889 if (update_now)
890 {
891 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NO_ERROR | P_NEED_UPDATE);
892 update_position (op->map, op->x, op->y);
893 }
894
895 if (op->more != NULL) 662 if (op->more)
896 update_object (op->more, action); 663 update_object (op->more, action);
897} 664}
898 665
899object::vector object::mortals;
900object::vector object::objects; // not yet used
901object *object::first; 666object *object::first;
902
903void object::free_mortals ()
904{
905 for (AUTODECL (i, mortals.begin ()); i != mortals.end ();)
906 if ((*i)->refcnt)
907 ++i; // further delay freeing
908 else
909 {
910 delete *i;
911 mortals.erase (i);
912 }
913
914 static int lastmortals = 0;//D
915
916 if (mortals.size() != lastmortals)//D
917 {
918 lastmortals = mortals.size ();//D
919 LOG (llevDebug, "%d objects in mortal queue\n", lastmortals);//D
920 }
921}
922 667
923object::object () 668object::object ()
924{ 669{
925 SET_FLAG (this, FLAG_REMOVED); 670 SET_FLAG (this, FLAG_REMOVED);
926 671
958 703
959 prev = 0; 704 prev = 0;
960 next = 0; 705 next = 0;
961} 706}
962 707
708bool
709object::active () const
710{
711 return active_next || active_prev || this == active_objects;
712}
713
714void
715object::activate ()
716{
717 /* If already on active list, don't do anything */
718 if (active ())
719 return;
720
721 if (has_active_speed ())
722 {
723 /* process_events() expects us to insert the object at the beginning
724 * of the list. */
725 active_next = active_objects;
726
727 if (active_next)
728 active_next->active_prev = this;
729
730 active_objects = this;
731 }
732}
733
734void
735object::activate_recursive ()
736{
737 activate ();
738
739 for (object *op = inv; op; op = op->below)
740 op->activate_recursive ();
741}
742
743/* This function removes object 'op' from the list of active
744 * objects.
745 * This should only be used for style maps or other such
746 * reference maps where you don't want an object that isn't
747 * in play chewing up cpu time getting processed.
748 * The reverse of this is to call update_ob_speed, which
749 * will do the right thing based on the speed of the object.
750 */
751void
752object::deactivate ()
753{
754 /* If not on the active list, nothing needs to be done */
755 if (!active ())
756 return;
757
758 if (active_prev == 0)
759 {
760 active_objects = active_next;
761 if (active_next)
762 active_next->active_prev = 0;
763 }
764 else
765 {
766 active_prev->active_next = active_next;
767 if (active_next)
768 active_next->active_prev = active_prev;
769 }
770
771 active_next = 0;
772 active_prev = 0;
773}
774
775void
776object::deactivate_recursive ()
777{
778 for (object *op = inv; op; op = op->below)
779 op->deactivate_recursive ();
780
781 deactivate ();
782}
783
784void
785object::set_flag_inv (int flag, int value)
786{
787 for (object *op = inv; op; op = op->below)
788 {
789 op->flag [flag] = value;
790 op->set_flag_inv (flag, value);
791 }
792}
793
794/*
795 * Remove and free all objects in the inventory of the given object.
796 * object.c ?
797 */
798void
799object::destroy_inv (bool drop_to_ground)
800{
801 // need to check first, because the checks below might segfault
802 // as we might be on an invalid mapspace and crossfire code
803 // is too buggy to ensure that the inventory is empty.
804 // corollary: if you create arrows etc. with stuff in tis inventory,
805 // cf will crash below with off-map x and y
806 if (!inv)
807 return;
808
809 /* Only if the space blocks everything do we not process -
810 * if some form of movement is allowed, let objects
811 * drop on that space.
812 */
813 if (!drop_to_ground
814 || !map
815 || map->in_memory != MAP_IN_MEMORY
816 || ms ().move_block == MOVE_ALL)
817 {
818 while (inv)
819 {
820 inv->destroy_inv (drop_to_ground);
821 inv->destroy ();
822 }
823 }
824 else
825 { /* Put objects in inventory onto this space */
826 while (inv)
827 {
828 object *op = inv;
829
830 if (op->flag [FLAG_STARTEQUIP]
831 || op->flag [FLAG_NO_DROP]
832 || op->type == RUNE
833 || op->type == TRAP
834 || op->flag [FLAG_IS_A_TEMPLATE])
835 op->destroy ();
836 else
837 map->insert (op, x, y);
838 }
839 }
840}
841
963object *object::create () 842object *object::create ()
964{ 843{
965 object *op = new object; 844 object *op = new object;
966 op->link (); 845 op->link ();
967 return op; 846 return op;
968} 847}
969 848
970/* 849void
971 * free_object() frees everything allocated by an object, removes 850object::do_destroy ()
972 * it from the list of used objects, and puts it on the list of
973 * free objects. The IS_FREED() flag is set in the object.
974 * The object must have been removed by remove_ob() first for
975 * this function to succeed.
976 *
977 * If free_inventory is set, free inventory as well. Else drop items in
978 * inventory to the ground.
979 */
980void object::free (bool free_inventory)
981{ 851{
982 if (QUERY_FLAG (this, FLAG_FREED)) 852 if (flag [FLAG_IS_LINKED])
853 remove_button_link (this);
854
855 if (flag [FLAG_FRIENDLY])
856 remove_friendly_object (this);
857
858 if (!flag [FLAG_REMOVED])
859 remove ();
860
861 if (flag [FLAG_FREED])
983 return; 862 return;
984 863
985 if (QUERY_FLAG (this, FLAG_FRIENDLY)) 864 set_speed (0);
986 remove_friendly_object (this);
987 865
988 if (!QUERY_FLAG (this, FLAG_REMOVED)) 866 flag [FLAG_FREED] = 1;
989 remove_ob (this);
990 867
991 SET_FLAG (this, FLAG_FREED); 868 attachable::do_destroy ();
869
870 destroy_inv (true);
871 unlink ();
872
873 // hack to ensure that freed objects still have a valid map
874 {
875 static maptile *freed_map; // freed objects are moved here to avoid crashes
876
877 if (!freed_map)
878 {
879 freed_map = new maptile;
880
881 freed_map->name = "/internal/freed_objects_map";
882 freed_map->width = 3;
883 freed_map->height = 3;
884
885 freed_map->alloc ();
886 freed_map->in_memory = MAP_IN_MEMORY;
887 }
888
889 map = freed_map;
890 x = 1;
891 y = 1;
892 }
893
894 head = 0;
992 895
993 if (more) 896 if (more)
994 { 897 {
995 more->free (free_inventory); 898 more->destroy ();
996 more = 0; 899 more = 0;
997 }
998
999 if (inv)
1000 {
1001 /* Only if the space blocks everything do we not process -
1002 * if some form of movement is allowed, let objects
1003 * drop on that space.
1004 */
1005 if (free_inventory || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL)
1006 {
1007 object *op = inv;
1008
1009 while (op)
1010 {
1011 object *tmp = op->below;
1012 op->free (free_inventory);
1013 op = tmp;
1014 }
1015 }
1016 else
1017 { /* Put objects in inventory onto this space */
1018 object *op = inv;
1019
1020 while (op)
1021 {
1022 object *tmp = op->below;
1023
1024 remove_ob (op);
1025
1026 if (QUERY_FLAG (op, FLAG_STARTEQUIP)
1027 || QUERY_FLAG (op, FLAG_NO_DROP) || op->type == RUNE || op->type == TRAP || QUERY_FLAG (op, FLAG_IS_A_TEMPLATE))
1028 free_object (op);
1029 else
1030 {
1031 op->x = x;
1032 op->y = y;
1033 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
1034 }
1035
1036 op = tmp;
1037 }
1038 }
1039 } 900 }
1040 901
1041 // clear those pointers that likely might have circular references to us 902 // clear those pointers that likely might have circular references to us
1042 owner = 0; 903 owner = 0;
1043 enemy = 0; 904 enemy = 0;
1044 attacked_by = 0; 905 attacked_by = 0;
1045 906
1046 /* Remove object from the active list */ 907 // only relevant for players(?), but make sure of it anyways
1047 speed = 0; 908 contr = 0;
1048 update_ob_speed (this); 909}
1049 910
1050 unlink (); 911void
912object::destroy (bool destroy_inventory)
913{
914 if (destroyed ())
915 return;
1051 916
1052 mortals.push_back (this); 917 if (destroy_inventory)
918 destroy_inv (false);
919
920 attachable::destroy ();
1053} 921}
1054 922
1055/* 923/*
1056 * sub_weight() recursively (outwards) subtracts a number from the 924 * sub_weight() recursively (outwards) subtracts a number from the
1057 * weight of an object (and what is carried by it's environment(s)). 925 * weight of an object (and what is carried by it's environment(s)).
1058 */ 926 */
1059
1060void 927void
1061sub_weight (object *op, signed long weight) 928sub_weight (object *op, signed long weight)
1062{ 929{
1063 while (op != NULL) 930 while (op != NULL)
1064 { 931 {
1068 op->carrying -= weight; 935 op->carrying -= weight;
1069 op = op->env; 936 op = op->env;
1070 } 937 }
1071} 938}
1072 939
1073/* remove_ob(op): 940/* op->remove ():
1074 * This function removes the object op from the linked list of objects 941 * This function removes the object op from the linked list of objects
1075 * which it is currently tied to. When this function is done, the 942 * which it is currently tied to. When this function is done, the
1076 * object will have no environment. If the object previously had an 943 * object will have no environment. If the object previously had an
1077 * environment, the x and y coordinates will be updated to 944 * environment, the x and y coordinates will be updated to
1078 * the previous environment. 945 * the previous environment.
1079 * Beware: This function is called from the editor as well! 946 * Beware: This function is called from the editor as well!
1080 */ 947 */
1081
1082void 948void
1083remove_ob (object *op) 949object::remove ()
1084{ 950{
1085 object *tmp, *last = 0; 951 object *tmp, *last = 0;
1086 object *otmp; 952 object *otmp;
1087 953
1088 int check_walk_off;
1089 maptile *m;
1090
1091 sint16 x, y;
1092
1093 if (QUERY_FLAG (op, FLAG_REMOVED)) 954 if (QUERY_FLAG (this, FLAG_REMOVED))
1094 return; 955 return;
1095 956
1096 SET_FLAG (op, FLAG_REMOVED); 957 SET_FLAG (this, FLAG_REMOVED);
958 INVOKE_OBJECT (REMOVE, this);
1097 959
1098 if (op->more != NULL) 960 if (more)
1099 remove_ob (op->more); 961 more->remove ();
1100 962
1101 /* 963 /*
1102 * In this case, the object to be removed is in someones 964 * In this case, the object to be removed is in someones
1103 * inventory. 965 * inventory.
1104 */ 966 */
1105 if (op->env != NULL) 967 if (env)
1106 { 968 {
1107 if (op->nrof) 969 if (nrof)
1108 sub_weight (op->env, op->weight * op->nrof); 970 sub_weight (env, weight * nrof);
1109 else 971 else
1110 sub_weight (op->env, op->weight + op->carrying); 972 sub_weight (env, weight + carrying);
1111 973
1112 /* NO_FIX_PLAYER is set when a great many changes are being 974 /* NO_FIX_PLAYER is set when a great many changes are being
1113 * made to players inventory. If set, avoiding the call 975 * made to players inventory. If set, avoiding the call
1114 * to save cpu time. 976 * to save cpu time.
1115 */ 977 */
1116 if ((otmp = is_player_inv (op->env)) != NULL && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 978 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1117 fix_player (otmp); 979 otmp->update_stats ();
1118 980
1119 if (op->above != NULL) 981 if (above)
1120 op->above->below = op->below; 982 above->below = below;
1121 else 983 else
1122 op->env->inv = op->below; 984 env->inv = below;
1123 985
1124 if (op->below != NULL) 986 if (below)
1125 op->below->above = op->above; 987 below->above = above;
1126 988
1127 /* we set up values so that it could be inserted into 989 /* we set up values so that it could be inserted into
1128 * the map, but we don't actually do that - it is up 990 * the map, but we don't actually do that - it is up
1129 * to the caller to decide what we want to do. 991 * to the caller to decide what we want to do.
1130 */ 992 */
1131 op->x = op->env->x, op->y = op->env->y; 993 x = env->x, y = env->y;
1132 op->map = op->env->map; 994 map = env->map;
1133 op->above = NULL, op->below = NULL; 995 above = 0, below = 0;
1134 op->env = NULL; 996 env = 0;
1135 } 997 }
1136 else if (op->map) 998 else if (map)
1137 { 999 {
1138 x = op->x; 1000 if (type == PLAYER)
1139 y = op->y;
1140 m = get_map_from_coord (op->map, &x, &y);
1141
1142 if (!m)
1143 {
1144 LOG (llevError, "remove_ob called when object was on map but appears to not be within valid coordinates? %s (%d,%d)\n",
1145 op->map->path, op->x, op->y);
1146 /* in old days, we used to set x and y to 0 and continue.
1147 * it seems if we get into this case, something is probablye
1148 * screwed up and should be fixed.
1149 */
1150 abort ();
1151 } 1001 {
1152 1002 --map->players;
1153 if (op->map != m) 1003 map->touch ();
1154 LOG (llevDebug, "remove_ob: Object not really on map it claimed to be on? %s != %s, %d,%d != %d,%d\n",
1155 op->map->path, m->path, op->x, op->y, x, y);
1156
1157 /* Re did the following section of code - it looks like it had
1158 * lots of logic for things we no longer care about
1159 */ 1004 }
1005
1006 map->dirty = true;
1160 1007
1161 /* link the object above us */ 1008 /* link the object above us */
1162 if (op->above) 1009 if (above)
1163 op->above->below = op->below; 1010 above->below = below;
1164 else 1011 else
1165 SET_MAP_TOP (m, x, y, op->below); /* we were top, set new top */ 1012 map->at (x, y).top = below; /* we were top, set new top */
1166 1013
1167 /* Relink the object below us, if there is one */ 1014 /* Relink the object below us, if there is one */
1168 if (op->below) 1015 if (below)
1169 op->below->above = op->above; 1016 below->above = above;
1170 else 1017 else
1171 { 1018 {
1172 /* Nothing below, which means we need to relink map object for this space 1019 /* Nothing below, which means we need to relink map object for this space
1173 * use translated coordinates in case some oddness with map tiling is 1020 * use translated coordinates in case some oddness with map tiling is
1174 * evident 1021 * evident
1175 */ 1022 */
1176 if (GET_MAP_OB (m, x, y) != op) 1023 if (GET_MAP_OB (map, x, y) != this)
1177 { 1024 {
1178 dump_object (op); 1025 char *dump = dump_object (this);
1179 LOG (llevError, 1026 LOG (llevError,
1180 "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", errmsg); 1027 "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", dump);
1028 free (dump);
1181 dump_object (GET_MAP_OB (m, x, y)); 1029 dump = dump_object (GET_MAP_OB (map, x, y));
1182 LOG (llevError, "%s\n", errmsg); 1030 LOG (llevError, "%s\n", dump);
1031 free (dump);
1183 } 1032 }
1184 1033
1185 SET_MAP_OB (m, x, y, op->above); /* goes on above it. */ 1034 map->at (x, y).bot = above; /* goes on above it. */
1186 } 1035 }
1187 1036
1188 op->above = 0; 1037 above = 0;
1189 op->below = 0; 1038 below = 0;
1190 1039
1191 if (op->map->in_memory == MAP_SAVING) 1040 if (map->in_memory == MAP_SAVING)
1192 return; 1041 return;
1193 1042
1194 check_walk_off = !QUERY_FLAG (op, FLAG_NO_APPLY); 1043 int check_walk_off = !flag [FLAG_NO_APPLY];
1195 1044
1196 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1045 for (tmp = map->at (x, y).bot; tmp; tmp = tmp->above)
1197 { 1046 {
1198 /* No point updating the players look faces if he is the object 1047 /* No point updating the players look faces if he is the object
1199 * being removed. 1048 * being removed.
1200 */ 1049 */
1201 1050
1202 if (tmp->type == PLAYER && tmp != op) 1051 if (tmp->type == PLAYER && tmp != this)
1203 { 1052 {
1204 /* If a container that the player is currently using somehow gets 1053 /* If a container that the player is currently using somehow gets
1205 * removed (most likely destroyed), update the player view 1054 * removed (most likely destroyed), update the player view
1206 * appropriately. 1055 * appropriately.
1207 */ 1056 */
1208 if (tmp->container == op) 1057 if (tmp->container == this)
1209 { 1058 {
1210 CLEAR_FLAG (op, FLAG_APPLIED); 1059 flag [FLAG_APPLIED] = 0;
1211 tmp->container = NULL; 1060 tmp->container = 0;
1212 } 1061 }
1213 1062
1214 tmp->contr->socket.update_look = 1; 1063 if (tmp->contr->ns)
1064 tmp->contr->ns->floorbox_update ();
1215 } 1065 }
1216 1066
1217 /* See if player moving off should effect something */ 1067 /* See if object moving off should effect something */
1218 if (check_walk_off && ((op->move_type & tmp->move_off) && (op->move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1068 if (check_walk_off
1069 && ((move_type & tmp->move_off)
1070 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0))
1219 { 1071 {
1220 move_apply (tmp, op, NULL); 1072 move_apply (tmp, this, 0);
1221 1073
1222 if (op->destroyed ()); 1074 if (destroyed ())
1223 LOG (llevError, "BUG: remove_ob(): name %s, archname %s destroyed " "leaving object\n", &tmp->name, &tmp->arch->name); 1075 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1224 } 1076 }
1225 1077
1226 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */ 1078 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */
1227 1079 //TODO: why is this horrible hacka fix? get rid of this code=bug! (schmorp)
1228 if (tmp->above == tmp) 1080 if (tmp->above == tmp)
1229 tmp->above = NULL; 1081 tmp->above = 0;
1230 1082
1231 last = tmp; 1083 last = tmp;
1232 } 1084 }
1233 1085
1234 /* last == NULL of there are no objects on this space */ 1086 /* last == NULL if there are no objects on this space */
1087 //TODO: this makes little sense, why only update the topmost object?
1235 if (last == NULL) 1088 if (!last)
1236 { 1089 map->at (x, y).flags_ = 0;
1237 /* set P_NEED_UPDATE, otherwise update_position will complain. In theory,
1238 * we could preserve the flags (GET_MAP_FLAGS), but update_position figures
1239 * those out anyways, and if there are any flags set right now, they won't
1240 * be correct anyways.
1241 */
1242 SET_MAP_FLAGS (op->map, op->x, op->y, P_NEED_UPDATE);
1243 update_position (op->map, op->x, op->y);
1244 }
1245 else 1090 else
1246 update_object (last, UP_OBJ_REMOVE); 1091 update_object (last, UP_OBJ_REMOVE);
1247 1092
1248 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) || (op->glow_radius != 0)) 1093 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1249 update_all_los (op->map, op->x, op->y); 1094 update_all_los (map, x, y);
1250 } 1095 }
1251} 1096}
1252 1097
1253/* 1098/*
1254 * merge_ob(op,top): 1099 * merge_ob(op,top):
1262merge_ob (object *op, object *top) 1107merge_ob (object *op, object *top)
1263{ 1108{
1264 if (!op->nrof) 1109 if (!op->nrof)
1265 return 0; 1110 return 0;
1266 1111
1267 if (top == NULL) 1112 if (top)
1268 for (top = op; top != NULL && top->above != NULL; top = top->above); 1113 for (top = op; top && top->above; top = top->above)
1114 ;
1269 1115
1270 for (; top != NULL; top = top->below) 1116 for (; top; top = top->below)
1271 { 1117 {
1272 if (top == op) 1118 if (top == op)
1273 continue; 1119 continue;
1274 if (CAN_MERGE (op, top)) 1120
1121 if (object::can_merge (op, top))
1275 { 1122 {
1276 top->nrof += op->nrof; 1123 top->nrof += op->nrof;
1277 1124
1278/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/ 1125/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/
1279 op->weight = 0; /* Don't want any adjustements now */ 1126 op->weight = 0; /* Don't want any adjustements now */
1280 remove_ob (op); 1127 op->destroy ();
1281 free_object (op);
1282 return top; 1128 return top;
1283 } 1129 }
1284 } 1130 }
1285 1131
1286 return 0; 1132 return 0;
1291 * job preparing multi-part monsters 1137 * job preparing multi-part monsters
1292 */ 1138 */
1293object * 1139object *
1294insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1140insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1295{ 1141{
1296 object *tmp;
1297
1298 if (op->head)
1299 op = op->head;
1300
1301 for (tmp = op; tmp; tmp = tmp->more) 1142 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1302 { 1143 {
1303 tmp->x = x + tmp->arch->clone.x; 1144 tmp->x = x + tmp->arch->clone.x;
1304 tmp->y = y + tmp->arch->clone.y; 1145 tmp->y = y + tmp->arch->clone.y;
1305 } 1146 }
1306 1147
1325 * Return value: 1166 * Return value:
1326 * new object if 'op' was merged with other object 1167 * new object if 'op' was merged with other object
1327 * NULL if 'op' was destroyed 1168 * NULL if 'op' was destroyed
1328 * just 'op' otherwise 1169 * just 'op' otherwise
1329 */ 1170 */
1330
1331object * 1171object *
1332insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1172insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1333{ 1173{
1334 object *tmp, *top, *floor = NULL; 1174 object *tmp, *top, *floor = NULL;
1335 sint16 x, y; 1175 sint16 x, y;
1338 { 1178 {
1339 LOG (llevError, "Trying to insert freed object!\n"); 1179 LOG (llevError, "Trying to insert freed object!\n");
1340 return NULL; 1180 return NULL;
1341 } 1181 }
1342 1182
1343 if (m == NULL) 1183 if (!m)
1344 { 1184 {
1345 dump_object (op); 1185 char *dump = dump_object (op);
1346 LOG (llevError, "Trying to insert in null-map!\n%s\n", errmsg); 1186 LOG (llevError, "Trying to insert in null-map!\n%s\n", dump);
1187 free (dump);
1347 return op; 1188 return op;
1348 } 1189 }
1349 1190
1350 if (out_of_map (m, op->x, op->y)) 1191 if (out_of_map (m, op->x, op->y))
1351 { 1192 {
1352 dump_object (op); 1193 char *dump = dump_object (op);
1353 LOG (llevError, "Trying to insert object outside the map.\n%s\n", errmsg); 1194 LOG (llevError, "Trying to insert object outside the map.\n%s\n", dump);
1354#ifdef MANY_CORES 1195#ifdef MANY_CORES
1355 /* Better to catch this here, as otherwise the next use of this object 1196 /* Better to catch this here, as otherwise the next use of this object
1356 * is likely to cause a crash. Better to find out where it is getting 1197 * is likely to cause a crash. Better to find out where it is getting
1357 * improperly inserted. 1198 * improperly inserted.
1358 */ 1199 */
1359 abort (); 1200 abort ();
1360#endif 1201#endif
1202 free (dump);
1361 return op; 1203 return op;
1362 } 1204 }
1363 1205
1364 if (!QUERY_FLAG (op, FLAG_REMOVED)) 1206 if (!QUERY_FLAG (op, FLAG_REMOVED))
1365 { 1207 {
1366 dump_object (op); 1208 char *dump = dump_object (op);
1367 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", errmsg); 1209 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", dump);
1210 free (dump);
1368 return op; 1211 return op;
1369 } 1212 }
1370 1213
1371 if (op->more != NULL) 1214 if (op->more)
1372 { 1215 {
1373 /* The part may be on a different map. */ 1216 /* The part may be on a different map. */
1374 1217
1375 object *more = op->more; 1218 object *more = op->more;
1376 1219
1377 /* We really need the caller to normalize coordinates - if 1220 /* We really need the caller to normalise coordinates - if
1378 * we set the map, that doesn't work if the location is within 1221 * we set the map, that doesn't work if the location is within
1379 * a map and this is straddling an edge. So only if coordinate 1222 * a map and this is straddling an edge. So only if coordinate
1380 * is clear wrong do we normalize it. 1223 * is clear wrong do we normalise it.
1381 */ 1224 */
1382 if (OUT_OF_REAL_MAP (more->map, more->x, more->y)) 1225 if (OUT_OF_REAL_MAP (more->map, more->x, more->y))
1383 more->map = get_map_from_coord (m, &more->x, &more->y); 1226 more->map = get_map_from_coord (m, &more->x, &more->y);
1384 else if (!more->map) 1227 else if (!more->map)
1385 { 1228 {
1392 if (insert_ob_in_map (more, more->map, originator, flag) == NULL) 1235 if (insert_ob_in_map (more, more->map, originator, flag) == NULL)
1393 { 1236 {
1394 if (!op->head) 1237 if (!op->head)
1395 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n"); 1238 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n");
1396 1239
1397 return NULL; 1240 return 0;
1398 } 1241 }
1399 } 1242 }
1400 1243
1401 CLEAR_FLAG (op, FLAG_REMOVED); 1244 CLEAR_FLAG (op, FLAG_REMOVED);
1402 1245
1409 y = op->y; 1252 y = op->y;
1410 1253
1411 /* this has to be done after we translate the coordinates. 1254 /* this has to be done after we translate the coordinates.
1412 */ 1255 */
1413 if (op->nrof && !(flag & INS_NO_MERGE)) 1256 if (op->nrof && !(flag & INS_NO_MERGE))
1414 for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above) 1257 for (tmp = GET_MAP_OB (op->map, x, y); tmp; tmp = tmp->above)
1415 if (CAN_MERGE (op, tmp)) 1258 if (object::can_merge (op, tmp))
1416 { 1259 {
1417 op->nrof += tmp->nrof; 1260 op->nrof += tmp->nrof;
1418 remove_ob (tmp); 1261 tmp->destroy ();
1419 free_object (tmp);
1420 } 1262 }
1421 1263
1422 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1264 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1423 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1265 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1424 1266
1437 op->below = originator->below; 1279 op->below = originator->below;
1438 1280
1439 if (op->below) 1281 if (op->below)
1440 op->below->above = op; 1282 op->below->above = op;
1441 else 1283 else
1442 SET_MAP_OB (op->map, op->x, op->y, op); 1284 op->ms ().bot = op;
1443 1285
1444 /* since *below* originator, no need to update top */ 1286 /* since *below* originator, no need to update top */
1445 originator->below = op; 1287 originator->below = op;
1446 } 1288 }
1447 else 1289 else
1448 { 1290 {
1449 /* If there are other objects, then */ 1291 /* If there are other objects, then */
1450 if ((!(flag & INS_MAP_LOAD)) && ((top = GET_MAP_OB (op->map, op->x, op->y)) != NULL)) 1292 if ((!(flag & INS_MAP_LOAD)) && ((top = GET_MAP_OB (op->map, op->x, op->y)) != NULL))
1451 { 1293 {
1452 object *last = NULL; 1294 object *last = 0;
1453 1295
1454 /* 1296 /*
1455 * If there are multiple objects on this space, we do some trickier handling. 1297 * If there are multiple objects on this space, we do some trickier handling.
1456 * We've already dealt with merging if appropriate. 1298 * We've already dealt with merging if appropriate.
1457 * Generally, we want to put the new object on top. But if 1299 * Generally, we want to put the new object on top. But if
1461 * once we get to them. This reduces the need to traverse over all of 1303 * once we get to them. This reduces the need to traverse over all of
1462 * them when adding another one - this saves quite a bit of cpu time 1304 * them when adding another one - this saves quite a bit of cpu time
1463 * when lots of spells are cast in one area. Currently, it is presumed 1305 * when lots of spells are cast in one area. Currently, it is presumed
1464 * that flying non pickable objects are spell objects. 1306 * that flying non pickable objects are spell objects.
1465 */ 1307 */
1466
1467 while (top != NULL) 1308 while (top)
1468 { 1309 {
1469 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1310 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))
1470 floor = top; 1311 floor = top;
1471 1312
1472 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1313 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))
1493 * If INS_ON_TOP is used, don't do this processing 1334 * If INS_ON_TOP is used, don't do this processing
1494 * Need to find the object that in fact blocks view, otherwise 1335 * Need to find the object that in fact blocks view, otherwise
1495 * stacking is a bit odd. 1336 * stacking is a bit odd.
1496 */ 1337 */
1497 if (!(flag & INS_ON_TOP) && 1338 if (!(flag & INS_ON_TOP) &&
1498 (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_BLOCKSVIEW) && (op->face && !op->face->visibility)) 1339 (get_map_flags (op->map, 0, op->x, op->y, 0, 0) & P_BLOCKSVIEW) && (op->face && !op->face->visibility))
1499 { 1340 {
1500 for (last = top; last != floor; last = last->below) 1341 for (last = top; last != floor; last = last->below)
1501 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1342 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1502 break; 1343 break;
1503 /* Check to see if we found the object that blocks view, 1344 /* Check to see if we found the object that blocks view,
1525 op->above = GET_MAP_OB (op->map, op->x, op->y); 1366 op->above = GET_MAP_OB (op->map, op->x, op->y);
1526 1367
1527 if (op->above) 1368 if (op->above)
1528 op->above->below = op; 1369 op->above->below = op;
1529 1370
1530 op->below = NULL; 1371 op->below = 0;
1531 SET_MAP_OB (op->map, op->x, op->y, op); 1372 op->ms ().bot = op;
1532 } 1373 }
1533 else 1374 else
1534 { /* get inserted into the stack above top */ 1375 { /* get inserted into the stack above top */
1535 op->above = top->above; 1376 op->above = top->above;
1536 1377
1539 1380
1540 op->below = top; 1381 op->below = top;
1541 top->above = op; 1382 top->above = op;
1542 } 1383 }
1543 1384
1544 if (op->above == NULL) 1385 if (!op->above)
1545 SET_MAP_TOP (op->map, op->x, op->y, op); 1386 op->ms ().top = op;
1546 } /* else not INS_BELOW_ORIGINATOR */ 1387 } /* else not INS_BELOW_ORIGINATOR */
1547 1388
1548 if (op->type == PLAYER) 1389 if (op->type == PLAYER)
1390 {
1549 op->contr->do_los = 1; 1391 op->contr->do_los = 1;
1392 ++op->map->players;
1393 op->map->touch ();
1394 }
1395
1396 op->map->dirty = true;
1550 1397
1551 /* If we have a floor, we know the player, if any, will be above 1398 /* If we have a floor, we know the player, if any, will be above
1552 * it, so save a few ticks and start from there. 1399 * it, so save a few ticks and start from there.
1553 */ 1400 */
1554 if (!(flag & INS_MAP_LOAD)) 1401 if (!(flag & INS_MAP_LOAD))
1555 for (tmp = floor ? floor : GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1402 if (object *pl = op->ms ().player ())
1556 if (tmp->type == PLAYER) 1403 if (pl->contr->ns)
1557 tmp->contr->socket.update_look = 1; 1404 pl->contr->ns->floorbox_update ();
1558 1405
1559 /* If this object glows, it may affect lighting conditions that are 1406 /* If this object glows, it may affect lighting conditions that are
1560 * visible to others on this map. But update_all_los is really 1407 * visible to others on this map. But update_all_los is really
1561 * an inefficient way to do this, as it means los for all players 1408 * an inefficient way to do this, as it means los for all players
1562 * on the map will get recalculated. The players could very well 1409 * on the map will get recalculated. The players could very well
1563 * be far away from this change and not affected in any way - 1410 * be far away from this change and not affected in any way -
1564 * this should get redone to only look for players within range, 1411 * this should get redone to only look for players within range,
1565 * or just updating the P_NEED_UPDATE for spaces within this area 1412 * or just updating the P_UPTODATE for spaces within this area
1566 * of effect may be sufficient. 1413 * of effect may be sufficient.
1567 */ 1414 */
1568 if (MAP_DARKNESS (op->map) && (op->glow_radius != 0)) 1415 if (op->map->darkness && (op->glow_radius != 0))
1569 update_all_los (op->map, op->x, op->y); 1416 update_all_los (op->map, op->x, op->y);
1570 1417
1571 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1418 /* updates flags (blocked, alive, no magic, etc) for this map space */
1572 update_object (op, UP_OBJ_INSERT); 1419 update_object (op, UP_OBJ_INSERT);
1573 1420
1421 INVOKE_OBJECT (INSERT, op);
1422
1574 /* Don't know if moving this to the end will break anything. However, 1423 /* Don't know if moving this to the end will break anything. However,
1575 * we want to have update_look set above before calling this. 1424 * we want to have floorbox_update called before calling this.
1576 * 1425 *
1577 * check_move_on() must be after this because code called from 1426 * check_move_on() must be after this because code called from
1578 * check_move_on() depends on correct map flags (so functions like 1427 * check_move_on() depends on correct map flags (so functions like
1579 * blocked() and wall() work properly), and these flags are updated by 1428 * blocked() and wall() work properly), and these flags are updated by
1580 * update_object(). 1429 * update_object().
1582 1431
1583 /* if this is not the head or flag has been passed, don't check walk on status */ 1432 /* if this is not the head or flag has been passed, don't check walk on status */
1584 if (!(flag & INS_NO_WALK_ON) && !op->head) 1433 if (!(flag & INS_NO_WALK_ON) && !op->head)
1585 { 1434 {
1586 if (check_move_on (op, originator)) 1435 if (check_move_on (op, originator))
1587 return NULL; 1436 return 0;
1588 1437
1589 /* If we are a multi part object, lets work our way through the check 1438 /* If we are a multi part object, lets work our way through the check
1590 * walk on's. 1439 * walk on's.
1591 */ 1440 */
1592 for (tmp = op->more; tmp != NULL; tmp = tmp->more) 1441 for (tmp = op->more; tmp != NULL; tmp = tmp->more)
1593 if (check_move_on (tmp, originator)) 1442 if (check_move_on (tmp, originator))
1594 return NULL; 1443 return 0;
1595 } 1444 }
1596 1445
1597 return op; 1446 return op;
1598} 1447}
1599 1448
1600/* this function inserts an object in the map, but if it 1449/* this function inserts an object in the map, but if it
1601 * finds an object of its own type, it'll remove that one first. 1450 * finds an object of its own type, it'll remove that one first.
1602 * op is the object to insert it under: supplies x and the map. 1451 * op is the object to insert it under: supplies x and the map.
1603 */ 1452 */
1604void 1453void
1605replace_insert_ob_in_map (const char *arch_string, object *op) 1454replace_insert_ob_in_map (const char *arch_string, object *op)
1606{ 1455{
1607 object * 1456 object *tmp, *tmp1;
1608 tmp;
1609 object *
1610 tmp1;
1611 1457
1612 /* first search for itself and remove any old instances */ 1458 /* first search for itself and remove any old instances */
1613 1459
1614 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1460 for (tmp = op->ms ().bot; tmp; tmp = tmp->above)
1615 {
1616 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */ 1461 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */
1617 { 1462 tmp->destroy ();
1618 remove_ob (tmp);
1619 free_object (tmp);
1620 }
1621 }
1622 1463
1623 tmp1 = arch_to_object (archetype::find (arch_string)); 1464 tmp1 = arch_to_object (archetype::find (arch_string));
1624 1465
1625 tmp1->x = op->x; 1466 tmp1->x = op->x;
1626 tmp1->y = op->y; 1467 tmp1->y = op->y;
1627 insert_ob_in_map (tmp1, op->map, op, 0); 1468 insert_ob_in_map (tmp1, op->map, op, 0);
1469}
1470
1471object *
1472object::insert_at (object *where, object *originator, int flags)
1473{
1474 where->map->insert (this, where->x, where->y, originator, flags);
1628} 1475}
1629 1476
1630/* 1477/*
1631 * get_split_ob(ob,nr) splits up ob into two parts. The part which 1478 * get_split_ob(ob,nr) splits up ob into two parts. The part which
1632 * is returned contains nr objects, and the remaining parts contains 1479 * is returned contains nr objects, and the remaining parts contains
1633 * the rest (or is removed and freed if that number is 0). 1480 * the rest (or is removed and freed if that number is 0).
1634 * On failure, NULL is returned, and the reason put into the 1481 * On failure, NULL is returned, and the reason put into the
1635 * global static errmsg array. 1482 * global static errmsg array.
1636 */ 1483 */
1637
1638object * 1484object *
1639get_split_ob (object *orig_ob, uint32 nr) 1485get_split_ob (object *orig_ob, uint32 nr)
1640{ 1486{
1641 object * 1487 object *newob;
1642 newob;
1643 int
1644 is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0); 1488 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1645 1489
1646 if (orig_ob->nrof < nr) 1490 if (orig_ob->nrof < nr)
1647 { 1491 {
1648 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name); 1492 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1649 return NULL; 1493 return NULL;
1650 } 1494 }
1651 1495
1652 newob = object_create_clone (orig_ob); 1496 newob = object_create_clone (orig_ob);
1653 1497
1654 if ((orig_ob->nrof -= nr) < 1) 1498 if ((orig_ob->nrof -= nr) < 1)
1655 { 1499 orig_ob->destroy (1);
1656 if (!is_removed)
1657 remove_ob (orig_ob);
1658 free_object2 (orig_ob, 1);
1659 }
1660 else if (!is_removed) 1500 else if (!is_removed)
1661 { 1501 {
1662 if (orig_ob->env != NULL) 1502 if (orig_ob->env != NULL)
1663 sub_weight (orig_ob->env, orig_ob->weight * nr); 1503 sub_weight (orig_ob->env, orig_ob->weight * nr);
1664 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY) 1504 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY)
1684 1524
1685object * 1525object *
1686decrease_ob_nr (object *op, uint32 i) 1526decrease_ob_nr (object *op, uint32 i)
1687{ 1527{
1688 object *tmp; 1528 object *tmp;
1689 player *pl;
1690 1529
1691 if (i == 0) /* objects with op->nrof require this check */ 1530 if (i == 0) /* objects with op->nrof require this check */
1692 return op; 1531 return op;
1693 1532
1694 if (i > op->nrof) 1533 if (i > op->nrof)
1695 i = op->nrof; 1534 i = op->nrof;
1696 1535
1697 if (QUERY_FLAG (op, FLAG_REMOVED)) 1536 if (QUERY_FLAG (op, FLAG_REMOVED))
1698 op->nrof -= i; 1537 op->nrof -= i;
1699 else if (op->env != NULL) 1538 else if (op->env)
1700 { 1539 {
1701 /* is this object in the players inventory, or sub container 1540 /* is this object in the players inventory, or sub container
1702 * therein? 1541 * therein?
1703 */ 1542 */
1704 tmp = is_player_inv (op->env); 1543 tmp = op->in_player ();
1705 /* nope. Is this a container the player has opened? 1544 /* nope. Is this a container the player has opened?
1706 * If so, set tmp to that player. 1545 * If so, set tmp to that player.
1707 * IMO, searching through all the players will mostly 1546 * IMO, searching through all the players will mostly
1708 * likely be quicker than following op->env to the map, 1547 * likely be quicker than following op->env to the map,
1709 * and then searching the map for a player. 1548 * and then searching the map for a player.
1710 */ 1549 */
1711 if (!tmp) 1550 if (!tmp)
1712 { 1551 for_all_players (pl)
1713 for (pl = first_player; pl; pl = pl->next)
1714 if (pl->ob->container == op->env) 1552 if (pl->ob->container == op->env)
1553 {
1554 tmp = pl->ob;
1715 break; 1555 break;
1716 if (pl)
1717 tmp = pl->ob;
1718 else
1719 tmp = NULL;
1720 } 1556 }
1721 1557
1722 if (i < op->nrof) 1558 if (i < op->nrof)
1723 { 1559 {
1724 sub_weight (op->env, op->weight * i); 1560 sub_weight (op->env, op->weight * i);
1725 op->nrof -= i; 1561 op->nrof -= i;
1726 if (tmp) 1562 if (tmp)
1727 {
1728 esrv_send_item (tmp, op); 1563 esrv_send_item (tmp, op);
1729 }
1730 } 1564 }
1731 else 1565 else
1732 { 1566 {
1733 remove_ob (op); 1567 op->remove ();
1734 op->nrof = 0; 1568 op->nrof = 0;
1735 if (tmp) 1569 if (tmp)
1736 {
1737 esrv_del_item (tmp->contr, op->count); 1570 esrv_del_item (tmp->contr, op->count);
1738 }
1739 } 1571 }
1740 } 1572 }
1741 else 1573 else
1742 { 1574 {
1743 object *above = op->above; 1575 object *above = op->above;
1744 1576
1745 if (i < op->nrof) 1577 if (i < op->nrof)
1746 op->nrof -= i; 1578 op->nrof -= i;
1747 else 1579 else
1748 { 1580 {
1749 remove_ob (op); 1581 op->remove ();
1750 op->nrof = 0; 1582 op->nrof = 0;
1751 } 1583 }
1752 1584
1753 /* Since we just removed op, op->above is null */ 1585 /* Since we just removed op, op->above is null */
1754 for (tmp = above; tmp != NULL; tmp = tmp->above) 1586 for (tmp = above; tmp; tmp = tmp->above)
1755 if (tmp->type == PLAYER) 1587 if (tmp->type == PLAYER)
1756 { 1588 {
1757 if (op->nrof) 1589 if (op->nrof)
1758 esrv_send_item (tmp, op); 1590 esrv_send_item (tmp, op);
1759 else 1591 else
1763 1595
1764 if (op->nrof) 1596 if (op->nrof)
1765 return op; 1597 return op;
1766 else 1598 else
1767 { 1599 {
1768 free_object (op); 1600 op->destroy ();
1769 return NULL; 1601 return 0;
1770 } 1602 }
1771} 1603}
1772 1604
1773/* 1605/*
1774 * add_weight(object, weight) adds the specified weight to an object, 1606 * add_weight(object, weight) adds the specified weight to an object,
1786 op->carrying += weight; 1618 op->carrying += weight;
1787 op = op->env; 1619 op = op->env;
1788 } 1620 }
1789} 1621}
1790 1622
1623object *
1624insert_ob_in_ob (object *op, object *where)
1625{
1626 if (!where)
1627 {
1628 char *dump = dump_object (op);
1629 LOG (llevError, "Trying to put object in NULL.\n%s\n", dump);
1630 free (dump);
1631 return op;
1632 }
1633
1634 if (where->head)
1635 {
1636 LOG (llevDebug, "Warning: Tried to insert object into wrong part of multipart object.\n");
1637 where = where->head;
1638 }
1639
1640 return where->insert (op);
1641}
1642
1791/* 1643/*
1792 * insert_ob_in_ob(op,environment): 1644 * env->insert (op)
1793 * This function inserts the object op in the linked list 1645 * This function inserts the object op in the linked list
1794 * inside the object environment. 1646 * inside the object environment.
1795 * 1647 *
1796 * Eneq(@csd.uu.se): Altered insert_ob_in_ob to make things picked up enter
1797 * the inventory at the last position or next to other objects of the same
1798 * type.
1799 * Frank: Now sorted by type, archetype and magic!
1800 *
1801 * The function returns now pointer to inserted item, and return value can 1648 * The function returns now pointer to inserted item, and return value can
1802 * be != op, if items are merged. -Tero 1649 * be != op, if items are merged. -Tero
1803 */ 1650 */
1804 1651
1805object * 1652object *
1806insert_ob_in_ob (object *op, object *where) 1653object::insert (object *op)
1807{ 1654{
1808 object * 1655 object *tmp, *otmp;
1809 tmp, *
1810 otmp;
1811 1656
1812 if (!QUERY_FLAG (op, FLAG_REMOVED)) 1657 if (!QUERY_FLAG (op, FLAG_REMOVED))
1813 { 1658 op->remove ();
1814 dump_object (op);
1815 LOG (llevError, "Trying to insert (ob) inserted object.\n%s\n", errmsg);
1816 return op;
1817 }
1818
1819 if (where == NULL)
1820 {
1821 dump_object (op);
1822 LOG (llevError, "Trying to put object in NULL.\n%s\n", errmsg);
1823 return op;
1824 }
1825
1826 if (where->head)
1827 {
1828 LOG (llevDebug, "Warning: Tried to insert object wrong part of multipart object.\n");
1829 where = where->head;
1830 }
1831 1659
1832 if (op->more) 1660 if (op->more)
1833 { 1661 {
1834 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count); 1662 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);
1835 return op; 1663 return op;
1837 1665
1838 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL); 1666 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL);
1839 CLEAR_FLAG (op, FLAG_REMOVED); 1667 CLEAR_FLAG (op, FLAG_REMOVED);
1840 if (op->nrof) 1668 if (op->nrof)
1841 { 1669 {
1842 for (tmp = where->inv; tmp != NULL; tmp = tmp->below) 1670 for (tmp = inv; tmp != NULL; tmp = tmp->below)
1843 if (CAN_MERGE (tmp, op)) 1671 if (object::can_merge (tmp, op))
1844 { 1672 {
1845 /* return the original object and remove inserted object 1673 /* return the original object and remove inserted object
1846 (client needs the original object) */ 1674 (client needs the original object) */
1847 tmp->nrof += op->nrof; 1675 tmp->nrof += op->nrof;
1848 /* Weight handling gets pretty funky. Since we are adding to 1676 /* Weight handling gets pretty funky. Since we are adding to
1849 * tmp->nrof, we need to increase the weight. 1677 * tmp->nrof, we need to increase the weight.
1850 */ 1678 */
1851 add_weight (where, op->weight * op->nrof); 1679 add_weight (this, op->weight * op->nrof);
1852 SET_FLAG (op, FLAG_REMOVED); 1680 SET_FLAG (op, FLAG_REMOVED);
1853 free_object (op); /* free the inserted object */ 1681 op->destroy (); /* free the inserted object */
1854 op = tmp; 1682 op = tmp;
1855 remove_ob (op); /* and fix old object's links */ 1683 op->remove (); /* and fix old object's links */
1856 CLEAR_FLAG (op, FLAG_REMOVED); 1684 CLEAR_FLAG (op, FLAG_REMOVED);
1857 break; 1685 break;
1858 } 1686 }
1859 1687
1860 /* I assume combined objects have no inventory 1688 /* I assume combined objects have no inventory
1861 * We add the weight - this object could have just been removed 1689 * We add the weight - this object could have just been removed
1862 * (if it was possible to merge). calling remove_ob will subtract 1690 * (if it was possible to merge). calling remove_ob will subtract
1863 * the weight, so we need to add it in again, since we actually do 1691 * the weight, so we need to add it in again, since we actually do
1864 * the linking below 1692 * the linking below
1865 */ 1693 */
1866 add_weight (where, op->weight * op->nrof); 1694 add_weight (this, op->weight * op->nrof);
1867 } 1695 }
1868 else 1696 else
1869 add_weight (where, (op->weight + op->carrying)); 1697 add_weight (this, (op->weight + op->carrying));
1870 1698
1871 otmp = is_player_inv (where); 1699 otmp = this->in_player ();
1872 if (otmp && otmp->contr != NULL) 1700 if (otmp && otmp->contr)
1873 {
1874 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1701 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1875 fix_player (otmp); 1702 otmp->update_stats ();
1876 }
1877 1703
1878 op->map = NULL; 1704 op->map = 0;
1879 op->env = where; 1705 op->env = this;
1880 op->above = NULL; 1706 op->above = 0;
1881 op->below = NULL; 1707 op->below = 0;
1882 op->x = 0, op->y = 0; 1708 op->x = 0, op->y = 0;
1883 1709
1884 /* reset the light list and los of the players on the map */ 1710 /* reset the light list and los of the players on the map */
1885 if ((op->glow_radius != 0) && where->map) 1711 if ((op->glow_radius != 0) && map)
1886 { 1712 {
1887#ifdef DEBUG_LIGHTS 1713#ifdef DEBUG_LIGHTS
1888 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name); 1714 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1889#endif /* DEBUG_LIGHTS */ 1715#endif /* DEBUG_LIGHTS */
1890 if (MAP_DARKNESS (where->map)) 1716 if (map->darkness)
1891 update_all_los (where->map, where->x, where->y); 1717 update_all_los (map, x, y);
1892 } 1718 }
1893 1719
1894 /* Client has no idea of ordering so lets not bother ordering it here. 1720 /* Client has no idea of ordering so lets not bother ordering it here.
1895 * It sure simplifies this function... 1721 * It sure simplifies this function...
1896 */ 1722 */
1897 if (where->inv == NULL) 1723 if (!inv)
1898 where->inv = op; 1724 inv = op;
1899 else 1725 else
1900 { 1726 {
1901 op->below = where->inv; 1727 op->below = inv;
1902 op->below->above = op; 1728 op->below->above = op;
1903 where->inv = op; 1729 inv = op;
1904 } 1730 }
1731
1732 INVOKE_OBJECT (INSERT, this);
1733
1905 return op; 1734 return op;
1906} 1735}
1907 1736
1908/* 1737/*
1909 * Checks if any objects has a move_type that matches objects 1738 * Checks if any objects has a move_type that matches objects
1923 * 1752 *
1924 * MSW 2001-07-08: Check all objects on space, not just those below 1753 * MSW 2001-07-08: Check all objects on space, not just those below
1925 * object being inserted. insert_ob_in_map may not put new objects 1754 * object being inserted. insert_ob_in_map may not put new objects
1926 * on top. 1755 * on top.
1927 */ 1756 */
1928
1929int 1757int
1930check_move_on (object *op, object *originator) 1758check_move_on (object *op, object *originator)
1931{ 1759{
1932 object *tmp; 1760 object *tmp;
1933 maptile *m = op->map; 1761 maptile *m = op->map;
1960 1788
1961 /* The objects have to be checked from top to bottom. 1789 /* The objects have to be checked from top to bottom.
1962 * Hence, we first go to the top: 1790 * Hence, we first go to the top:
1963 */ 1791 */
1964 1792
1965 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL && tmp->above != NULL; tmp = tmp->above) 1793 for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1966 { 1794 {
1967 /* Trim the search when we find the first other spell effect 1795 /* Trim the search when we find the first other spell effect
1968 * this helps performance so that if a space has 50 spell objects, 1796 * this helps performance so that if a space has 50 spell objects,
1969 * we don't need to check all of them. 1797 * we don't need to check all of them.
1970 */ 1798 */
2025/* 1853/*
2026 * present_arch(arch, map, x, y) searches for any objects with 1854 * present_arch(arch, map, x, y) searches for any objects with
2027 * a matching archetype at the given map and coordinates. 1855 * a matching archetype at the given map and coordinates.
2028 * The first matching object is returned, or NULL if none. 1856 * The first matching object is returned, or NULL if none.
2029 */ 1857 */
2030
2031object * 1858object *
2032present_arch (const archetype *at, maptile *m, int x, int y) 1859present_arch (const archetype *at, maptile *m, int x, int y)
2033{ 1860{
2034 object *
2035 tmp;
2036
2037 if (m == NULL || out_of_map (m, x, y)) 1861 if (!m || out_of_map (m, x, y))
2038 { 1862 {
2039 LOG (llevError, "Present_arch called outside map.\n"); 1863 LOG (llevError, "Present_arch called outside map.\n");
2040 return NULL; 1864 return NULL;
2041 } 1865 }
2042 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1866
1867 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
2043 if (tmp->arch == at) 1868 if (tmp->arch == at)
2044 return tmp; 1869 return tmp;
1870
2045 return NULL; 1871 return NULL;
2046} 1872}
2047 1873
2048/* 1874/*
2049 * present(type, map, x, y) searches for any objects with 1875 * present(type, map, x, y) searches for any objects with
2050 * a matching type variable at the given map and coordinates. 1876 * a matching type variable at the given map and coordinates.
2051 * The first matching object is returned, or NULL if none. 1877 * The first matching object is returned, or NULL if none.
2052 */ 1878 */
2053
2054object * 1879object *
2055present (unsigned char type, maptile *m, int x, int y) 1880present (unsigned char type, maptile *m, int x, int y)
2056{ 1881{
2057 object *
2058 tmp;
2059
2060 if (out_of_map (m, x, y)) 1882 if (out_of_map (m, x, y))
2061 { 1883 {
2062 LOG (llevError, "Present called outside map.\n"); 1884 LOG (llevError, "Present called outside map.\n");
2063 return NULL; 1885 return NULL;
2064 } 1886 }
2065 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1887
1888 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
2066 if (tmp->type == type) 1889 if (tmp->type == type)
2067 return tmp; 1890 return tmp;
1891
2068 return NULL; 1892 return NULL;
2069} 1893}
2070 1894
2071/* 1895/*
2072 * present_in_ob(type, object) searches for any objects with 1896 * present_in_ob(type, object) searches for any objects with
2073 * a matching type variable in the inventory of the given object. 1897 * a matching type variable in the inventory of the given object.
2074 * The first matching object is returned, or NULL if none. 1898 * The first matching object is returned, or NULL if none.
2075 */ 1899 */
2076
2077object * 1900object *
2078present_in_ob (unsigned char type, const object *op) 1901present_in_ob (unsigned char type, const object *op)
2079{ 1902{
2080 object *
2081 tmp;
2082
2083 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1903 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2084 if (tmp->type == type) 1904 if (tmp->type == type)
2085 return tmp; 1905 return tmp;
1906
2086 return NULL; 1907 return NULL;
2087} 1908}
2088 1909
2089/* 1910/*
2090 * present_in_ob (type, str, object) searches for any objects with 1911 * present_in_ob (type, str, object) searches for any objects with
2098 * str is the string to match against. Note that we match against 1919 * str is the string to match against. Note that we match against
2099 * the object name, not the archetype name. this is so that the 1920 * the object name, not the archetype name. this is so that the
2100 * spell code can use one object type (force), but change it's name 1921 * spell code can use one object type (force), but change it's name
2101 * to be unique. 1922 * to be unique.
2102 */ 1923 */
2103
2104object * 1924object *
2105present_in_ob_by_name (int type, const char *str, const object *op) 1925present_in_ob_by_name (int type, const char *str, const object *op)
2106{ 1926{
2107 object *
2108 tmp;
2109
2110 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1927 for (object *tmp = op->inv; tmp; tmp = tmp->below)
2111 {
2112 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name))) 1928 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name)))
2113 return tmp; 1929 return tmp;
2114 } 1930
2115 return NULL; 1931 return 0;
2116} 1932}
2117 1933
2118/* 1934/*
2119 * present_arch_in_ob(archetype, object) searches for any objects with 1935 * present_arch_in_ob(archetype, object) searches for any objects with
2120 * a matching archetype in the inventory of the given object. 1936 * a matching archetype in the inventory of the given object.
2121 * The first matching object is returned, or NULL if none. 1937 * The first matching object is returned, or NULL if none.
2122 */ 1938 */
2123
2124object * 1939object *
2125present_arch_in_ob (const archetype *at, const object *op) 1940present_arch_in_ob (const archetype *at, const object *op)
2126{ 1941{
2127 object *
2128 tmp;
2129
2130 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1942 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2131 if (tmp->arch == at) 1943 if (tmp->arch == at)
2132 return tmp; 1944 return tmp;
1945
2133 return NULL; 1946 return NULL;
2134} 1947}
2135 1948
2136/* 1949/*
2137 * activate recursively a flag on an object inventory 1950 * activate recursively a flag on an object inventory
2138 */ 1951 */
2139void 1952void
2140flag_inv (object *op, int flag) 1953flag_inv (object *op, int flag)
2141{ 1954{
2142 object *
2143 tmp;
2144
2145 if (op->inv) 1955 if (op->inv)
2146 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1956 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2147 { 1957 {
2148 SET_FLAG (tmp, flag); 1958 SET_FLAG (tmp, flag);
2149 flag_inv (tmp, flag); 1959 flag_inv (tmp, flag);
2150 } 1960 }
2151} /* 1961}
1962
1963/*
2152 * desactivate recursively a flag on an object inventory 1964 * deactivate recursively a flag on an object inventory
2153 */ 1965 */
2154void 1966void
2155unflag_inv (object *op, int flag) 1967unflag_inv (object *op, int flag)
2156{ 1968{
2157 object *
2158 tmp;
2159
2160 if (op->inv) 1969 if (op->inv)
2161 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1970 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2162 { 1971 {
2163 CLEAR_FLAG (tmp, flag); 1972 CLEAR_FLAG (tmp, flag);
2164 unflag_inv (tmp, flag); 1973 unflag_inv (tmp, flag);
2165 } 1974 }
2166} 1975}
2169 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in 1978 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in
2170 * all it's inventory (recursively). 1979 * all it's inventory (recursively).
2171 * If checksums are used, a player will get set_cheat called for 1980 * If checksums are used, a player will get set_cheat called for
2172 * him/her-self and all object carried by a call to this function. 1981 * him/her-self and all object carried by a call to this function.
2173 */ 1982 */
2174
2175void 1983void
2176set_cheat (object *op) 1984set_cheat (object *op)
2177{ 1985{
2178 SET_FLAG (op, FLAG_WAS_WIZ); 1986 SET_FLAG (op, FLAG_WAS_WIZ);
2179 flag_inv (op, FLAG_WAS_WIZ); 1987 flag_inv (op, FLAG_WAS_WIZ);
2198 * because arch_blocked (now ob_blocked) needs to know the movement type 2006 * because arch_blocked (now ob_blocked) needs to know the movement type
2199 * to know if the space in question will block the object. We can't use 2007 * to know if the space in question will block the object. We can't use
2200 * the archetype because that isn't correct if the monster has been 2008 * the archetype because that isn't correct if the monster has been
2201 * customized, changed states, etc. 2009 * customized, changed states, etc.
2202 */ 2010 */
2203
2204int 2011int
2205find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop) 2012find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)
2206{ 2013{
2207 int
2208 i,
2209 index = 0, flag; 2014 int index = 0, flag;
2210 static int
2211 altern[SIZEOFFREE]; 2015 int altern[SIZEOFFREE];
2212 2016
2213 for (i = start; i < stop; i++) 2017 for (int i = start; i < stop; i++)
2214 { 2018 {
2215 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]); 2019 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]);
2216 if (!flag) 2020 if (!flag)
2217 altern[index++] = i; 2021 altern [index++] = i;
2218 2022
2219 /* Basically, if we find a wall on a space, we cut down the search size. 2023 /* Basically, if we find a wall on a space, we cut down the search size.
2220 * In this way, we won't return spaces that are on another side of a wall. 2024 * In this way, we won't return spaces that are on another side of a wall.
2221 * This mostly work, but it cuts down the search size in all directions - 2025 * This mostly work, but it cuts down the search size in all directions -
2222 * if the space being examined only has a wall to the north and empty 2026 * if the space being examined only has a wall to the north and empty
2223 * spaces in all the other directions, this will reduce the search space 2027 * spaces in all the other directions, this will reduce the search space
2224 * to only the spaces immediately surrounding the target area, and 2028 * to only the spaces immediately surrounding the target area, and
2225 * won't look 2 spaces south of the target space. 2029 * won't look 2 spaces south of the target space.
2226 */ 2030 */
2227 else if ((flag & AB_NO_PASS) && maxfree[i] < stop) 2031 else if ((flag & P_NO_PASS) && maxfree[i] < stop)
2228 stop = maxfree[i]; 2032 stop = maxfree[i];
2229 } 2033 }
2034
2230 if (!index) 2035 if (!index)
2231 return -1; 2036 return -1;
2037
2232 return altern[RANDOM () % index]; 2038 return altern[RANDOM () % index];
2233} 2039}
2234 2040
2235/* 2041/*
2236 * find_first_free_spot(archetype, maptile, x, y) works like 2042 * find_first_free_spot(archetype, maptile, x, y) works like
2237 * find_free_spot(), but it will search max number of squares. 2043 * find_free_spot(), but it will search max number of squares.
2238 * But it will return the first available spot, not a random choice. 2044 * But it will return the first available spot, not a random choice.
2239 * Changed 0.93.2: Have it return -1 if there is no free spot available. 2045 * Changed 0.93.2: Have it return -1 if there is no free spot available.
2240 */ 2046 */
2241
2242int 2047int
2243find_first_free_spot (const object *ob, maptile *m, int x, int y) 2048find_first_free_spot (const object *ob, maptile *m, int x, int y)
2244{ 2049{
2245 int
2246 i;
2247
2248 for (i = 0; i < SIZEOFFREE; i++) 2050 for (int i = 0; i < SIZEOFFREE; i++)
2249 {
2250 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i])) 2051 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]))
2251 return i; 2052 return i;
2252 } 2053
2253 return -1; 2054 return -1;
2254} 2055}
2255 2056
2256/* 2057/*
2257 * The function permute(arr, begin, end) randomly reorders the array 2058 * The function permute(arr, begin, end) randomly reorders the array
2258 * arr[begin..end-1]. 2059 * arr[begin..end-1].
2060 * now uses a fisher-yates shuffle, old permute was broken
2259 */ 2061 */
2260static void 2062static void
2261permute (int *arr, int begin, int end) 2063permute (int *arr, int begin, int end)
2262{ 2064{
2263 int 2065 arr += begin;
2264 i,
2265 j,
2266 tmp,
2267 len;
2268
2269 len = end - begin; 2066 end -= begin;
2270 for (i = begin; i < end; i++)
2271 {
2272 j = begin + RANDOM () % len;
2273 2067
2274 tmp = arr[i]; 2068 while (--end)
2275 arr[i] = arr[j]; 2069 swap (arr [end], arr [RANDOM () % (end + 1)]);
2276 arr[j] = tmp;
2277 }
2278} 2070}
2279 2071
2280/* new function to make monster searching more efficient, and effective! 2072/* new function to make monster searching more efficient, and effective!
2281 * This basically returns a randomized array (in the passed pointer) of 2073 * This basically returns a randomized array (in the passed pointer) of
2282 * the spaces to find monsters. In this way, it won't always look for 2074 * the spaces to find monsters. In this way, it won't always look for
2285 * the 3x3 area will be searched, just not in a predictable order. 2077 * the 3x3 area will be searched, just not in a predictable order.
2286 */ 2078 */
2287void 2079void
2288get_search_arr (int *search_arr) 2080get_search_arr (int *search_arr)
2289{ 2081{
2290 int 2082 int i;
2291 i;
2292 2083
2293 for (i = 0; i < SIZEOFFREE; i++) 2084 for (i = 0; i < SIZEOFFREE; i++)
2294 {
2295 search_arr[i] = i; 2085 search_arr[i] = i;
2296 }
2297 2086
2298 permute (search_arr, 1, SIZEOFFREE1 + 1); 2087 permute (search_arr, 1, SIZEOFFREE1 + 1);
2299 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1); 2088 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1);
2300 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE); 2089 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE);
2301} 2090}
2310 * Perhaps incorrectly, but I'm making the assumption that exclude 2099 * Perhaps incorrectly, but I'm making the assumption that exclude
2311 * is actually want is going to try and move there. We need this info 2100 * is actually want is going to try and move there. We need this info
2312 * because we have to know what movement the thing looking to move 2101 * because we have to know what movement the thing looking to move
2313 * there is capable of. 2102 * there is capable of.
2314 */ 2103 */
2315
2316int 2104int
2317find_dir (maptile *m, int x, int y, object *exclude) 2105find_dir (maptile *m, int x, int y, object *exclude)
2318{ 2106{
2319 int
2320 i,
2321 max = SIZEOFFREE, mflags; 2107 int i, max = SIZEOFFREE, mflags;
2322 2108
2323 sint16 nx, ny; 2109 sint16 nx, ny;
2324 object * 2110 object *tmp;
2325 tmp;
2326 maptile * 2111 maptile *mp;
2327 mp;
2328 2112
2329 MoveType blocked, move_type; 2113 MoveType blocked, move_type;
2330 2114
2331 if (exclude && exclude->head) 2115 if (exclude && exclude->head)
2332 { 2116 {
2344 mp = m; 2128 mp = m;
2345 nx = x + freearr_x[i]; 2129 nx = x + freearr_x[i];
2346 ny = y + freearr_y[i]; 2130 ny = y + freearr_y[i];
2347 2131
2348 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2132 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);
2133
2349 if (mflags & P_OUT_OF_MAP) 2134 if (mflags & P_OUT_OF_MAP)
2350 {
2351 max = maxfree[i]; 2135 max = maxfree[i];
2352 }
2353 else 2136 else
2354 { 2137 {
2355 blocked = GET_MAP_MOVE_BLOCK (mp, nx, ny); 2138 mapspace &ms = mp->at (nx, ny);
2139
2140 blocked = ms.move_block;
2356 2141
2357 if ((move_type & blocked) == move_type) 2142 if ((move_type & blocked) == move_type)
2358 {
2359 max = maxfree[i]; 2143 max = maxfree[i];
2360 }
2361 else if (mflags & P_IS_ALIVE) 2144 else if (mflags & P_IS_ALIVE)
2362 { 2145 {
2363 for (tmp = GET_MAP_OB (mp, nx, ny); tmp != NULL; tmp = tmp->above) 2146 for (tmp = ms.bot; tmp; tmp = tmp->above)
2364 { 2147 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)
2365 if ((QUERY_FLAG (tmp, FLAG_MONSTER) || tmp->type == PLAYER) && (tmp != exclude || (tmp->head && tmp->head != exclude))) 2148 && (tmp != exclude || (tmp->head && tmp->head != exclude)))
2366 {
2367 break; 2149 break;
2368 } 2150
2369 }
2370 if (tmp) 2151 if (tmp)
2371 {
2372 return freedir[i]; 2152 return freedir[i];
2373 }
2374 } 2153 }
2375 } 2154 }
2376 } 2155 }
2156
2377 return 0; 2157 return 0;
2378} 2158}
2379 2159
2380/* 2160/*
2381 * distance(object 1, object 2) will return the square of the 2161 * distance(object 1, object 2) will return the square of the
2382 * distance between the two given objects. 2162 * distance between the two given objects.
2383 */ 2163 */
2384
2385int 2164int
2386distance (const object *ob1, const object *ob2) 2165distance (const object *ob1, const object *ob2)
2387{ 2166{
2388 int
2389 i;
2390
2391 i = (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y); 2167 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2392 return i;
2393} 2168}
2394 2169
2395/* 2170/*
2396 * find_dir_2(delta-x,delta-y) will return a direction in which 2171 * find_dir_2(delta-x,delta-y) will return a direction in which
2397 * an object which has subtracted the x and y coordinates of another 2172 * an object which has subtracted the x and y coordinates of another
2398 * object, needs to travel toward it. 2173 * object, needs to travel toward it.
2399 */ 2174 */
2400
2401int 2175int
2402find_dir_2 (int x, int y) 2176find_dir_2 (int x, int y)
2403{ 2177{
2404 int 2178 int q;
2405 q;
2406 2179
2407 if (y) 2180 if (y)
2408 q = x * 100 / y; 2181 q = x * 100 / y;
2409 else if (x) 2182 else if (x)
2410 q = -300 * x; 2183 q = -300 * x;
2445int 2218int
2446absdir (int d) 2219absdir (int d)
2447{ 2220{
2448 while (d < 1) 2221 while (d < 1)
2449 d += 8; 2222 d += 8;
2223
2450 while (d > 8) 2224 while (d > 8)
2451 d -= 8; 2225 d -= 8;
2226
2452 return d; 2227 return d;
2453} 2228}
2454 2229
2455/* 2230/*
2456 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is 2231 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is
2458 */ 2233 */
2459 2234
2460int 2235int
2461dirdiff (int dir1, int dir2) 2236dirdiff (int dir1, int dir2)
2462{ 2237{
2463 int 2238 int d;
2464 d;
2465 2239
2466 d = abs (dir1 - dir2); 2240 d = abs (dir1 - dir2);
2467 if (d > 4) 2241 if (d > 4)
2468 d = 8 - d; 2242 d = 8 - d;
2243
2469 return d; 2244 return d;
2470} 2245}
2471 2246
2472/* peterm: 2247/* peterm:
2473 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster. 2248 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster.
2476 * This basically means that if direction is 15, then it could either go 2251 * This basically means that if direction is 15, then it could either go
2477 * direction 4, 14, or 16 to get back to where we are. 2252 * direction 4, 14, or 16 to get back to where we are.
2478 * Moved from spell_util.c to object.c with the other related direction 2253 * Moved from spell_util.c to object.c with the other related direction
2479 * functions. 2254 * functions.
2480 */ 2255 */
2481
2482int
2483 reduction_dir[SIZEOFFREE][3] = { 2256int reduction_dir[SIZEOFFREE][3] = {
2484 {0, 0, 0}, /* 0 */ 2257 {0, 0, 0}, /* 0 */
2485 {0, 0, 0}, /* 1 */ 2258 {0, 0, 0}, /* 1 */
2486 {0, 0, 0}, /* 2 */ 2259 {0, 0, 0}, /* 2 */
2487 {0, 0, 0}, /* 3 */ 2260 {0, 0, 0}, /* 3 */
2488 {0, 0, 0}, /* 4 */ 2261 {0, 0, 0}, /* 4 */
2536 * find a path to that monster that we found. If not, 2309 * find a path to that monster that we found. If not,
2537 * we don't bother going toward it. Returns 1 if we 2310 * we don't bother going toward it. Returns 1 if we
2538 * can see a direct way to get it 2311 * can see a direct way to get it
2539 * Modified to be map tile aware -.MSW 2312 * Modified to be map tile aware -.MSW
2540 */ 2313 */
2541
2542
2543int 2314int
2544can_see_monsterP (maptile *m, int x, int y, int dir) 2315can_see_monsterP (maptile *m, int x, int y, int dir)
2545{ 2316{
2546 sint16 dx, dy; 2317 sint16 dx, dy;
2547 int
2548 mflags; 2318 int mflags;
2549 2319
2550 if (dir < 0) 2320 if (dir < 0)
2551 return 0; /* exit condition: invalid direction */ 2321 return 0; /* exit condition: invalid direction */
2552 2322
2553 dx = x + freearr_x[dir]; 2323 dx = x + freearr_x[dir];
2566 return 0; 2336 return 0;
2567 2337
2568 /* yes, can see. */ 2338 /* yes, can see. */
2569 if (dir < 9) 2339 if (dir < 9)
2570 return 1; 2340 return 1;
2341
2571 return can_see_monsterP (m, x, y, reduction_dir[dir][0]) | 2342 return can_see_monsterP (m, x, y, reduction_dir[dir][0])
2572 can_see_monsterP (m, x, y, reduction_dir[dir][1]) | can_see_monsterP (m, x, y, reduction_dir[dir][2]); 2343 | can_see_monsterP (m, x, y, reduction_dir[dir][1])
2344 | can_see_monsterP (m, x, y, reduction_dir[dir][2]);
2573} 2345}
2574
2575
2576 2346
2577/* 2347/*
2578 * can_pick(picker, item): finds out if an object is possible to be 2348 * can_pick(picker, item): finds out if an object is possible to be
2579 * picked up by the picker. Returnes 1 if it can be 2349 * picked up by the picker. Returnes 1 if it can be
2580 * picked up, otherwise 0. 2350 * picked up, otherwise 0.
2591 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2361 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2592 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2362 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2593 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2363 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));
2594} 2364}
2595 2365
2596
2597/* 2366/*
2598 * create clone from object to another 2367 * create clone from object to another
2599 */ 2368 */
2600object * 2369object *
2601object_create_clone (object *asrc) 2370object_create_clone (object *asrc)
2602{ 2371{
2603 object *
2604 dst = NULL, *tmp, *src, *part, *prev, *item; 2372 object *dst = 0, *tmp, *src, *part, *prev, *item;
2605 2373
2606 if (!asrc) 2374 if (!asrc)
2607 return NULL; 2375 return 0;
2376
2608 src = asrc; 2377 src = asrc;
2609 if (src->head) 2378 if (src->head)
2610 src = src->head; 2379 src = src->head;
2611 2380
2612 prev = NULL; 2381 prev = 0;
2613 for (part = src; part; part = part->more) 2382 for (part = src; part; part = part->more)
2614 { 2383 {
2615 tmp = get_object (); 2384 tmp = part->clone ();
2616 copy_object (part, tmp);
2617 tmp->x -= src->x; 2385 tmp->x -= src->x;
2618 tmp->y -= src->y; 2386 tmp->y -= src->y;
2387
2619 if (!part->head) 2388 if (!part->head)
2620 { 2389 {
2621 dst = tmp; 2390 dst = tmp;
2622 tmp->head = NULL; 2391 tmp->head = 0;
2623 } 2392 }
2624 else 2393 else
2625 {
2626 tmp->head = dst; 2394 tmp->head = dst;
2627 } 2395
2628 tmp->more = NULL; 2396 tmp->more = 0;
2397
2629 if (prev) 2398 if (prev)
2630 prev->more = tmp; 2399 prev->more = tmp;
2400
2631 prev = tmp; 2401 prev = tmp;
2632 } 2402 }
2633 2403
2634 for (item = src->inv; item; item = item->below) 2404 for (item = src->inv; item; item = item->below)
2635 insert_ob_in_ob (object_create_clone (item), dst); 2405 insert_ob_in_ob (object_create_clone (item), dst);
2641/* Basically, we save the content of the string to a temp file, then call */ 2411/* Basically, we save the content of the string to a temp file, then call */
2642/* load_object on it. I admit it is a highly inefficient way to make things, */ 2412/* load_object on it. I admit it is a highly inefficient way to make things, */
2643/* but it was simple to make and allows reusing the load_object function. */ 2413/* but it was simple to make and allows reusing the load_object function. */
2644/* Remember not to use load_object_str in a time-critical situation. */ 2414/* Remember not to use load_object_str in a time-critical situation. */
2645/* Also remember that multiparts objects are not supported for now. */ 2415/* Also remember that multiparts objects are not supported for now. */
2646
2647object * 2416object *
2648load_object_str (const char *obstr) 2417load_object_str (const char *obstr)
2649{ 2418{
2650 object *op; 2419 object *op;
2651 char filename[MAX_BUF]; 2420 char filename[MAX_BUF];
2661 } 2430 }
2662 2431
2663 fprintf (tempfile, obstr); 2432 fprintf (tempfile, obstr);
2664 fclose (tempfile); 2433 fclose (tempfile);
2665 2434
2666 op = get_object (); 2435 op = object::create ();
2667 2436
2668 object_thawer thawer (filename); 2437 object_thawer thawer (filename);
2669 2438
2670 if (thawer) 2439 if (thawer)
2671 load_object (thawer, op, 0); 2440 load_object (thawer, op, 0);
2681 * returns NULL if no match. 2450 * returns NULL if no match.
2682 */ 2451 */
2683object * 2452object *
2684find_obj_by_type_subtype (const object *who, int type, int subtype) 2453find_obj_by_type_subtype (const object *who, int type, int subtype)
2685{ 2454{
2686 object *tmp;
2687
2688 for (tmp = who->inv; tmp; tmp = tmp->below) 2455 for (object *tmp = who->inv; tmp; tmp = tmp->below)
2689 if (tmp->type == type && tmp->subtype == subtype) 2456 if (tmp->type == type && tmp->subtype == subtype)
2690 return tmp; 2457 return tmp;
2691 2458
2692 return NULL; 2459 return 0;
2693} 2460}
2694 2461
2695/* If ob has a field named key, return the link from the list, 2462/* If ob has a field named key, return the link from the list,
2696 * otherwise return NULL. 2463 * otherwise return NULL.
2697 * 2464 *
2699 * do the desired thing. 2466 * do the desired thing.
2700 */ 2467 */
2701key_value * 2468key_value *
2702get_ob_key_link (const object *ob, const char *key) 2469get_ob_key_link (const object *ob, const char *key)
2703{ 2470{
2704 key_value *link;
2705
2706 for (link = ob->key_values; link != NULL; link = link->next) 2471 for (key_value *link = ob->key_values; link; link = link->next)
2707 if (link->key == key) 2472 if (link->key == key)
2708 return link; 2473 return link;
2709 2474
2710 return NULL; 2475 return 0;
2711} 2476}
2712 2477
2713/* 2478/*
2714 * Returns the value of op has an extra_field for key, or NULL. 2479 * Returns the value of op has an extra_field for key, or NULL.
2715 * 2480 *
2755 * Returns TRUE on success. 2520 * Returns TRUE on success.
2756 */ 2521 */
2757int 2522int
2758set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key) 2523set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2759{ 2524{
2760 key_value *
2761 field = NULL, *last = NULL; 2525 key_value *field = NULL, *last = NULL;
2762 2526
2763 for (field = op->key_values; field != NULL; field = field->next) 2527 for (field = op->key_values; field != NULL; field = field->next)
2764 { 2528 {
2765 if (field->key != canonical_key) 2529 if (field->key != canonical_key)
2766 { 2530 {
2794 /* IF we get here, key doesn't exist */ 2558 /* IF we get here, key doesn't exist */
2795 2559
2796 /* No field, we'll have to add it. */ 2560 /* No field, we'll have to add it. */
2797 2561
2798 if (!add_key) 2562 if (!add_key)
2799 {
2800 return FALSE; 2563 return FALSE;
2801 } 2564
2802 /* There isn't any good reason to store a null 2565 /* There isn't any good reason to store a null
2803 * value in the key/value list. If the archetype has 2566 * value in the key/value list. If the archetype has
2804 * this key, then we should also have it, so shouldn't 2567 * this key, then we should also have it, so shouldn't
2805 * be here. If user wants to store empty strings, 2568 * be here. If user wants to store empty strings,
2806 * should pass in "" 2569 * should pass in ""
2855 } 2618 }
2856 else 2619 else
2857 item = item->env; 2620 item = item->env;
2858} 2621}
2859 2622
2623
2624const char *
2625object::flag_desc (char *desc, int len) const
2626{
2627 char *p = desc;
2628 bool first = true;
2629
2630 *p = 0;
2631
2632 for (int i = 0; i < NUM_FLAGS; i++)
2633 {
2634 if (len <= 10) // magic constant!
2635 {
2636 snprintf (p, len, ",...");
2637 break;
2638 }
2639
2640 if (flag [i])
2641 {
2642 int cnt = snprintf (p, len, "%s%d", first ? "" : ",", i);
2643 len -= cnt;
2644 p += cnt;
2645 first = false;
2646 }
2647 }
2648
2649 return desc;
2650}
2651
2860// return a suitable string describing an objetc in enough detail to find it 2652// return a suitable string describing an object in enough detail to find it
2861const char * 2653const char *
2862object::debug_desc (char *info) const 2654object::debug_desc (char *info) const
2863{ 2655{
2656 char flagdesc[512];
2864 char info2[256 * 3]; 2657 char info2[256 * 4];
2865 char *p = info; 2658 char *p = info;
2866 2659
2867 p += snprintf (p, 256, "%d=\"%s%s%s\"", 2660 p += snprintf (p, 512, "{cnt:%d,uuid:<1,%" PRIx64 ">,name:\"%s%s%s\",flags:[%s],type:%d}",
2868 count, 2661 count, uuid.seq,
2869 &name, 2662 &name,
2870 title ? " " : "", 2663 title ? "\",title:" : "",
2871 title ? (const char *)title : ""); 2664 title ? (const char *)title : "",
2665 flag_desc (flagdesc, 512), type);
2872 2666
2873 if (env) 2667 if (env)
2874 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2668 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2875 2669
2876 if (map) 2670 if (map)
2877 p += snprintf (p, 256, "(on %s@%d+%d)", map->path, x, y); 2671 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2878 2672
2879 return info; 2673 return info;
2880} 2674}
2881 2675
2882const char * 2676const char *
2883object::debug_desc () const 2677object::debug_desc () const
2884{ 2678{
2885 static char info[256 * 3]; 2679 static char info[256 * 4];
2886 return debug_desc (info); 2680 return debug_desc (info);
2887} 2681}
2888 2682

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines