ViewVC Help

View File | Revision Log | Show Annotations | Download File

/cvs/deliantra/server/common/object.C

Comparing deliantra/server/common/object.C (file contents):
Revision 1.81 by root, Sat Dec 23 13:56:25 2006 UTC vs.
Revision 1.111 by root, Mon Jan 8 01:19:02 2007 UTC

1	/*	1	/*
2	CrossFire, A Multiplayer game for X-windows	2	CrossFire, A Multiplayer game for X-windows
3		3
		4	Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team
4	Copyright (C) 2001 Mark Wedel & Crossfire Development Team	5	Copyright (C) 2001 Mark Wedel & Crossfire Development Team
5	Copyright (C) 1992 Frank Tore Johansen	6	Copyright (C) 1992 Frank Tore Johansen
6		7
7	This program is free software; you can redistribute it and/or modify	8	This program is free software; you can redistribute it and/or modify
8	it under the terms of the GNU General Public License as published by	9	it under the terms of the GNU General Public License as published by
…		…
36		37
37	int nrofallocobjects = 0;	38	int nrofallocobjects = 0;
38	static UUID uuid;	39	static UUID uuid;
39	const uint64 UUID_SKIP = 1<<19;	40	const uint64 UUID_SKIP = 1<<19;
40		41
41	object *active_objects; /* List of active objects that need to be processed */	42	objectvec objects;
		43	activevec actives;
42		44
43	short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,	45	short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
44	0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1	46	0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1
45	};	47	};
46	short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,	48	short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
…		…
141	* objects with lists are rare, and lists stay short. If not, use a	143	* objects with lists are rare, and lists stay short. If not, use a
142	* different structure or at least keep the lists sorted...	144	* different structure or at least keep the lists sorted...
143	*/	145	*/
144		146
145	/* For each field in wants, */	147	/* For each field in wants, */
146	for (wants_field = wants->key_values; wants_field != NULL; wants_field = wants_field->next)	148	for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)
147	{	149	{
148	key_value *has_field;	150	key_value *has_field;
149		151
150	/* Look for a field in has with the same key. */	152	/* Look for a field in has with the same key. */
151	has_field = get_ob_key_link (has, wants_field->key);	153	has_field = get_ob_key_link (has, wants_field->key);
…		…
190	* Check nrof variable *before* calling can_merge()	192	* Check nrof variable *before* calling can_merge()
191	*	193	*
192	* Improvements made with merge: Better checking on potion, and also	194	* Improvements made with merge: Better checking on potion, and also
193	* check weight	195	* check weight
194	*/	196	*/
195
196	bool object::can_merge_slow (object *ob1, object *ob2)	197	bool object::can_merge_slow (object *ob1, object *ob2)
197	{	198	{
198	/* A couple quicksanity checks */	199	/* A couple quicksanity checks */
199	if (ob1 == ob2	200	if (ob1 == ob2
200	|| ob1->type != ob2->type	201	|| ob1->type != ob2->type
…		…
277		278
278	/* Note sure why the following is the case - either the object has to	279	/* Note sure why the following is the case - either the object has to
279	* be animated or have a very low speed. Is this an attempted monster	280	* be animated or have a very low speed. Is this an attempted monster
280	* check?	281	* check?
281	*/	282	*/
282	if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && FABS ((ob1)->speed) > MIN_ACTIVE_SPEED)	283	if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && ob1->has_active_speed ())
283	return 0;	284	return 0;
284		285
285	switch (ob1->type)	286	switch (ob1->type)
286	{	287	{
287	case SCROLL:	288	case SCROLL:
…		…
364	{	365	{
365	if (!op)	366	if (!op)
366	return strdup ("[NULLOBJ]");	367	return strdup ("[NULLOBJ]");
367		368
368	object_freezer freezer;	369	object_freezer freezer;
369	save_object (freezer, op, 3);	370	save_object (freezer, op, 1);
370	return freezer.as_string ();	371	return freezer.as_string ();
371	}	372	}
372		373
373	/*	374	/*
374	* get_nearest_part(multi-object, object 2) returns the part of the	375	* get_nearest_part(multi-object, object 2) returns the part of the
…		…
391	}	392	}
392		393
393	/*	394	/*
394	* Returns the object which has the count-variable equal to the argument.	395	* Returns the object which has the count-variable equal to the argument.
395	*/	396	*/
396
397	object *	397	object *
398	find_object (tag_t i)	398	find_object (tag_t i)
399	{	399	{
400	for (object *op = object::first; op; op = op->next)	400	return ((unsigned int)i) < objects.size ()
401	if (op->count == i)	401	? objects [i]
402	return op;	402	: 0;
403
404	return 0;
405	}	403	}
406		404
407	/*	405	/*
408	* Returns the first object which has a name equal to the argument.	406	* Returns the first object which has a name equal to the argument.
409	* Used only by the patch command, but not all that useful.	407	* Used only by the patch command, but not all that useful.
410	* Enables features like "patch <name-of-other-player> food 999"	408	* Enables features like "patch <name-of-other-player> food 999"
411	*/	409	*/
412
413	object *	410	object *
414	find_object_name (const char *str)	411	find_object_name (const char *str)
415	{	412	{
416	shstr_cmp str_ (str);	413	shstr_cmp str_ (str);
417	object *op;	414	object *op;
418		415
419	for (op = object::first; op != NULL; op = op->next)	416	for_all_objects (op)
420	if (op->name == str_)	417	if (op->name == str_)
421	break;	418	break;
422		419
423	return op;	420	return op;
424	}	421	}
…		…
482	{	479	{
483	bool is_freed = QUERY_FLAG (dst, FLAG_FREED);	480	bool is_freed = QUERY_FLAG (dst, FLAG_FREED);
484	bool is_removed = QUERY_FLAG (dst, FLAG_REMOVED);	481	bool is_removed = QUERY_FLAG (dst, FLAG_REMOVED);
485		482
486	*(object_copy *)dst = *this;	483	*(object_copy *)dst = *this;
487
488	if (self || cb)
489	INVOKE_OBJECT (CLONE, this, ARG_OBJECT (dst));
490		484
491	if (is_freed)	485	if (is_freed)
492	SET_FLAG (dst, FLAG_FREED);	486	SET_FLAG (dst, FLAG_FREED);
493		487
494	if (is_removed)	488	if (is_removed)
…		…
525	tail = new_link;	519	tail = new_link;
526	}	520	}
527	}	521	}
528	}	522	}
529		523
530	update_ob_speed (dst);	524	dst->set_speed (dst->speed);
531	}	525	}
532		526
533	object *	527	object *
534	object::clone ()	528	object::clone ()
535	{	529	{
…		…
541	/*	535	/*
542	* If an object with the IS_TURNABLE() flag needs to be turned due	536	* If an object with the IS_TURNABLE() flag needs to be turned due
543	* to the closest player being on the other side, this function can	537	* to the closest player being on the other side, this function can
544	* be called to update the face variable, _and_ how it looks on the map.	538	* be called to update the face variable, _and_ how it looks on the map.
545	*/	539	*/
546
547	void	540	void
548	update_turn_face (object *op)	541	update_turn_face (object *op)
549	{	542	{
550	if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || op->arch == NULL)	543	if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || !op->arch)
551	return;	544	return;
		545
552	SET_ANIMATION (op, op->direction);	546	SET_ANIMATION (op, op->direction);
553	update_object (op, UP_OBJ_FACE);	547	update_object (op, UP_OBJ_FACE);
554	}	548	}
555		549
556	/*	550	/*
557	* Updates the speed of an object. If the speed changes from 0 to another	551	* Updates the speed of an object. If the speed changes from 0 to another
558	* value, or vice versa, then add/remove the object from the active list.	552	* value, or vice versa, then add/remove the object from the active list.
559	* This function needs to be called whenever the speed of an object changes.	553	* This function needs to be called whenever the speed of an object changes.
560	*/	554	*/
561	void	555	void
562	update_ob_speed (object *op)	556	object::set_speed (float speed)
563	{	557	{
564	extern int arch_init;	558	if (flag [FLAG_FREED] && speed)
565
566	/* No reason putting the archetypes objects on the speed list,
567	* since they never really need to be updated.
568	*/
569
570	if (QUERY_FLAG (op, FLAG_FREED) && op->speed)
571	{	559	{
572	LOG (llevError, "Object %s is freed but has speed.\n", &op->name);	560	LOG (llevError, "Object %s is freed but has speed.\n", &name);
573	#ifdef MANY_CORES
574	abort ();
575	#else
576	op->speed = 0;	561	speed = 0;
577	#endif
578	}
579
580	if (arch_init)
581	return;
582
583	if (FABS (op->speed) > MIN_ACTIVE_SPEED)
584	{	562	}
585	/* If already on active list, don't do anything */
586	if (op->active_next || op->active_prev || op == active_objects)
587	return;
588		563
589	/* process_events() expects us to insert the object at the beginning	564	this->speed = speed;
590	* of the list. */
591	op->active_next = active_objects;
592		565
593	if (op->active_next != NULL)	566	if (has_active_speed ())
594	op->active_next->active_prev = op;	567	activate ();
595
596	active_objects = op;
597	}
598	else	568	else
599	{	569	deactivate ();
600	/* If not on the active list, nothing needs to be done */
601	if (!op->active_next && !op->active_prev && op != active_objects)
602	return;
603
604	if (op->active_prev == NULL)
605	{
606	active_objects = op->active_next;
607
608	if (op->active_next != NULL)
609	op->active_next->active_prev = NULL;
610	}
611	else
612	{
613	op->active_prev->active_next = op->active_next;
614
615	if (op->active_next)
616	op->active_next->active_prev = op->active_prev;
617	}
618
619	op->active_next = NULL;
620	op->active_prev = NULL;
621	}
622	}
623
624	/* This function removes object 'op' from the list of active
625	* objects.
626	* This should only be used for style maps or other such
627	* reference maps where you don't want an object that isn't
628	* in play chewing up cpu time getting processed.
629	* The reverse of this is to call update_ob_speed, which
630	* will do the right thing based on the speed of the object.
631	*/
632	void
633	remove_from_active_list (object *op)
634	{
635	/* If not on the active list, nothing needs to be done */
636	if (!op->active_next && !op->active_prev && op != active_objects)
637	return;
638
639	if (op->active_prev == NULL)
640	{
641	active_objects = op->active_next;
642	if (op->active_next != NULL)
643	op->active_next->active_prev = NULL;
644	}
645	else
646	{
647	op->active_prev->active_next = op->active_next;
648	if (op->active_next)
649	op->active_next->active_prev = op->active_prev;
650	}
651	op->active_next = NULL;
652	op->active_prev = NULL;
653	}	570	}
654		571
655	/*	572	/*
656	* update_object() updates the the map.	573	* update_object() updates the the map.
657	* It takes into account invisible objects (and represent squares covered	574	* It takes into account invisible objects (and represent squares covered
…		…
694	*/	611	*/
695	if (!op->map || op->map->in_memory == MAP_SAVING)	612	if (!op->map || op->map->in_memory == MAP_SAVING)
696	return;	613	return;
697		614
698	/* make sure the object is within map boundaries */	615	/* make sure the object is within map boundaries */
699	if (op->x < 0 || op->x >= MAP_WIDTH (op->map) || op->y < 0 || op->y >= MAP_HEIGHT (op->map))	616	if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
700	{	617	{
701	LOG (llevError, "update_object() called for object out of map!\n");	618	LOG (llevError, "update_object() called for object out of map!\n");
702	#ifdef MANY_CORES	619	#ifdef MANY_CORES
703	abort ();	620	abort ();
704	#endif	621	#endif
705	return;	622	return;
706	}	623	}
707		624
708	mapspace &m = op->ms ();	625	mapspace &m = op->ms ();
709		626
710	if (m.flags_ & P_NEED_UPDATE)	627	if (!(m.flags_ & P_UPTODATE))
711	/* nop */;	628	/* nop */;
712	else if (action == UP_OBJ_INSERT)	629	else if (action == UP_OBJ_INSERT)
713	{	630	{
714	// this is likely overkill, TODO: revisit (schmorp)	631	// this is likely overkill, TODO: revisit (schmorp)
715	if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))	632	if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
…		…
724	/* This isn't perfect, but I don't expect a lot of objects to	641	/* This isn't perfect, but I don't expect a lot of objects to
725	* to have move_allow right now.	642	* to have move_allow right now.
726	*/	643	*/
727	|| ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block	644	|| ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
728	|| 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)	645	|| 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
729	m.flags_ = P_NEED_UPDATE;	646	m.flags_ = 0;
730	}	647	}
731	/* if the object is being removed, we can't make intelligent	648	/* if the object is being removed, we can't make intelligent
732	* decisions, because remove_ob can't really pass the object	649	* decisions, because remove_ob can't really pass the object
733	* that is being removed.	650	* that is being removed.
734	*/	651	*/
735	else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)	652	else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
736	m.flags_ = P_NEED_UPDATE;	653	m.flags_ = 0;
737	else if (action == UP_OBJ_FACE)	654	else if (action == UP_OBJ_FACE)
738	/* Nothing to do for that case */ ;	655	/* Nothing to do for that case */ ;
739	else	656	else
740	LOG (llevError, "update_object called with invalid action: %d\n", action);	657	LOG (llevError, "update_object called with invalid action: %d\n", action);
741		658
742	if (op->more)	659	if (op->more)
743	update_object (op->more, action);	660	update_object (op->more, action);
744	}	661	}
745		662
746	object::vector object::mortals;
747	object::vector object::objects; // not yet used
748	object *object::first;	663	object *object::first;
749
750	void object::free_mortals ()
751	{
752	for (AUTODECL (i, mortals.begin ()); i != mortals.end ();)
753	if ((*i)->refcnt)
754	++i; // further delay freeing
755	else
756	{
757	delete *i;
758	mortals.erase (i);
759	}
760	}
761		664
762	object::object ()	665	object::object ()
763	{	666	{
764	SET_FLAG (this, FLAG_REMOVED);	667	SET_FLAG (this, FLAG_REMOVED);
765		668
…		…
772	free_key_values (this);	675	free_key_values (this);
773	}	676	}
774		677
775	void object::link ()	678	void object::link ()
776	{	679	{
777	count = ++ob_count;	680	assert (!count);//D
778	uuid = gen_uuid ();	681	uuid = gen_uuid ();
779		682
780	prev = 0;	683	refcnt_inc ();
781	next = object::first;	684	objects.insert (this);
782
783	if (object::first)
784	object::first->prev = this;
785
786	object::first = this;
787	}	685	}
788		686
789	void object::unlink ()	687	void object::unlink ()
790	{	688	{
791	if (this == object::first)	689	assert (count);//D
792	object::first = next;	690	objects.erase (this);
		691	refcnt_dec ();
		692	}
793		693
794	/* Remove this object from the list of used objects */	694	void
795	if (prev) prev->next = next;	695	object::activate ()
796	if (next) next->prev = prev;	696	{
		697	/* If already on active list, don't do anything */
		698	if (active)
		699	return;
797		700
798	prev = 0;	701	if (has_active_speed ())
799	next = 0;	702	actives.insert (this);
		703	}
		704
		705	void
		706	object::activate_recursive ()
		707	{
		708	activate ();
		709
		710	for (object *op = inv; op; op = op->below)
		711	op->activate_recursive ();
		712	}
		713
		714	/* This function removes object 'op' from the list of active
		715	* objects.
		716	* This should only be used for style maps or other such
		717	* reference maps where you don't want an object that isn't
		718	* in play chewing up cpu time getting processed.
		719	* The reverse of this is to call update_ob_speed, which
		720	* will do the right thing based on the speed of the object.
		721	*/
		722	void
		723	object::deactivate ()
		724	{
		725	/* If not on the active list, nothing needs to be done */
		726	if (!active)
		727	return;
		728
		729	actives.erase (this);
		730	}
		731
		732	void
		733	object::deactivate_recursive ()
		734	{
		735	for (object *op = inv; op; op = op->below)
		736	op->deactivate_recursive ();
		737
		738	deactivate ();
		739	}
		740
		741	void
		742	object::set_flag_inv (int flag, int value)
		743	{
		744	for (object *op = inv; op; op = op->below)
		745	{
		746	op->flag [flag] = value;
		747	op->set_flag_inv (flag, value);
		748	}
		749	}
		750
		751	/*
		752	* Remove and free all objects in the inventory of the given object.
		753	* object.c ?
		754	*/
		755	void
		756	object::destroy_inv (bool drop_to_ground)
		757	{
		758	// need to check first, because the checks below might segfault
		759	// as we might be on an invalid mapspace and crossfire code
		760	// is too buggy to ensure that the inventory is empty.
		761	// corollary: if you create arrows etc. with stuff in tis inventory,
		762	// cf will crash below with off-map x and y
		763	if (!inv)
		764	return;
		765
		766	/* Only if the space blocks everything do we not process -
		767	* if some form of movement is allowed, let objects
		768	* drop on that space.
		769	*/
		770	if (!drop_to_ground
		771	|| !map
		772	|| map->in_memory != MAP_IN_MEMORY
		773	|| ms ().move_block == MOVE_ALL)
		774	{
		775	while (inv)
		776	{
		777	inv->destroy_inv (drop_to_ground);
		778	inv->destroy ();
		779	}
		780	}
		781	else
		782	{ /* Put objects in inventory onto this space */
		783	while (inv)
		784	{
		785	object *op = inv;
		786
		787	if (op->flag [FLAG_STARTEQUIP]
		788	|| op->flag [FLAG_NO_DROP]
		789	|| op->type == RUNE
		790	|| op->type == TRAP
		791	|| op->flag [FLAG_IS_A_TEMPLATE]
		792	|| op->flag [FLAG_DESTROY_ON_DEATH])
		793	op->destroy ();
		794	else
		795	map->insert (op, x, y);
		796	}
		797	}
800	}	798	}
801		799
802	object *object::create ()	800	object *object::create ()
803	{	801	{
804	object *op = new object;	802	object *op = new object;
805	op->link ();	803	op->link ();
806	return op;	804	return op;
807	}	805	}
808		806
809	/*	807	void
810	* free_object() frees everything allocated by an object, removes	808	object::do_destroy ()
811	* it from the list of used objects, and puts it on the list of
812	* free objects. The IS_FREED() flag is set in the object.
813	* The object must have been removed by remove_ob() first for
814	* this function to succeed.
815	*
816	* If destroy_inventory is set, free inventory as well. Else drop items in
817	* inventory to the ground.
818	*/
819	void object::destroy (bool destroy_inventory)
820	{	809	{
821	if (QUERY_FLAG (this, FLAG_FREED))	810	if (flag [FLAG_IS_LINKED])
		811	remove_button_link (this);
		812
		813	if (flag [FLAG_FRIENDLY])
		814	remove_friendly_object (this);
		815
		816	if (!flag [FLAG_REMOVED])
		817	remove ();
		818
		819	if (flag [FLAG_FREED])
822	return;	820	return;
823		821
824	if (QUERY_FLAG (this, FLAG_FRIENDLY))	822	set_speed (0);
825	remove_friendly_object (this);
826		823
827	if (!QUERY_FLAG (this, FLAG_REMOVED))	824	flag [FLAG_FREED] = 1;
828	remove ();
829		825
830	SET_FLAG (this, FLAG_FREED);	826	attachable::do_destroy ();
831		827
832	if (more)	828	destroy_inv (true);
833	{	829	unlink ();
834	more->destroy (destroy_inventory);
835	more = 0;
836	}
837
838	if (inv)
839	{
840	/* Only if the space blocks everything do we not process -
841	* if some form of movement is allowed, let objects
842	* drop on that space.
843	*/
844	if (destroy_inventory || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL)
845	{
846	object *op = inv;
847
848	while (op)
849	{
850	object *tmp = op->below;
851	op->destroy (destroy_inventory);
852	op = tmp;
853	}
854	}
855	else
856	{ /* Put objects in inventory onto this space */
857	object *op = inv;
858
859	while (op)
860	{
861	object *tmp = op->below;
862
863	op->remove ();
864
865	if (QUERY_FLAG (op, FLAG_STARTEQUIP)
866	|| QUERY_FLAG (op, FLAG_NO_DROP) || op->type == RUNE || op->type == TRAP || QUERY_FLAG (op, FLAG_IS_A_TEMPLATE))
867	op->destroy ();
868	else
869	{
870	op->x = x;
871	op->y = y;
872	insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
873	}
874
875	op = tmp;
876	}
877	}
878	}
879		830
880	// hack to ensure that freed objects still have a valid map	831	// hack to ensure that freed objects still have a valid map
881	{	832	{
882	static maptile *freed_map; // freed objects are moved here to avoid crashes	833	static maptile *freed_map; // freed objects are moved here to avoid crashes
883		834
…		…
887		838
888	freed_map->name = "/internal/freed_objects_map";	839	freed_map->name = "/internal/freed_objects_map";
889	freed_map->width = 3;	840	freed_map->width = 3;
890	freed_map->height = 3;	841	freed_map->height = 3;
891		842
892	freed_map->allocate ();	843	freed_map->alloc ();
		844	freed_map->in_memory = MAP_IN_MEMORY;
893	}	845	}
894		846
895	map = freed_map;	847	map = freed_map;
896	x = 1;	848	x = 1;
897	y = 1;	849	y = 1;
898	}	850	}
899		851
		852	head = 0;
		853
		854	if (more)
		855	{
		856	more->destroy ();
		857	more = 0;
		858	}
		859
900	// clear those pointers that likely might have circular references to us	860	// clear those pointers that likely might have circular references to us
901	owner = 0;	861	owner = 0;
902	enemy = 0;	862	enemy = 0;
903	attacked_by = 0;	863	attacked_by = 0;
		864	}
904		865
905	// only relevant for players(?), but make sure of it anyways	866	void
906	contr = 0;	867	object::destroy (bool destroy_inventory)
		868	{
		869	if (destroyed ())
		870	return;
907		871
908	/* Remove object from the active list */	872	if (destroy_inventory)
909	speed = 0;	873	destroy_inv (false);
910	update_ob_speed (this);
911		874
912	unlink ();	875	attachable::destroy ();
913
914	mortals.push_back (this);
915	}	876	}
916		877
917	/*	878	/*
918	* sub_weight() recursively (outwards) subtracts a number from the	879	* sub_weight() recursively (outwards) subtracts a number from the
919	* weight of an object (and what is carried by it's environment(s)).	880	* weight of an object (and what is carried by it's environment(s)).
…		…
943	object::remove ()	904	object::remove ()
944	{	905	{
945	object *tmp, *last = 0;	906	object *tmp, *last = 0;
946	object *otmp;	907	object *otmp;
947		908
948	int check_walk_off;
949
950	if (QUERY_FLAG (this, FLAG_REMOVED))	909	if (QUERY_FLAG (this, FLAG_REMOVED))
951	return;	910	return;
952		911
953	SET_FLAG (this, FLAG_REMOVED);	912	SET_FLAG (this, FLAG_REMOVED);
		913	INVOKE_OBJECT (REMOVE, this);
954		914
955	if (more)	915	if (more)
956	more->remove ();	916	more->remove ();
957		917
958	/*	918	/*
…		…
971	* to save cpu time.	931	* to save cpu time.
972	*/	932	*/
973	if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))	933	if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
974	otmp->update_stats ();	934	otmp->update_stats ();
975		935
976	if (above != NULL)	936	if (above)
977	above->below = below;	937	above->below = below;
978	else	938	else
979	env->inv = below;	939	env->inv = below;
980		940
981	if (below != NULL)	941	if (below)
982	below->above = above;	942	below->above = above;
983		943
984	/* we set up values so that it could be inserted into	944	/* we set up values so that it could be inserted into
985	* the map, but we don't actually do that - it is up	945	* the map, but we don't actually do that - it is up
986	* to the caller to decide what we want to do.	946	* to the caller to decide what we want to do.
…		…
990	above = 0, below = 0;	950	above = 0, below = 0;
991	env = 0;	951	env = 0;
992	}	952	}
993	else if (map)	953	else if (map)
994	{	954	{
995	/* Re did the following section of code - it looks like it had	955	if (type == PLAYER)
996	* lots of logic for things we no longer care about
997	*/	956	{
		957	--map->players;
		958	map->touch ();
		959	}
		960
		961	map->dirty = true;
998		962
999	/* link the object above us */	963	/* link the object above us */
1000	if (above)	964	if (above)
1001	above->below = below;	965	above->below = below;
1002	else	966	else
…		…
1020	dump = dump_object (GET_MAP_OB (map, x, y));	984	dump = dump_object (GET_MAP_OB (map, x, y));
1021	LOG (llevError, "%s\n", dump);	985	LOG (llevError, "%s\n", dump);
1022	free (dump);	986	free (dump);
1023	}	987	}
1024		988
1025	map->at (x, y).bottom = above; /* goes on above it. */	989	map->at (x, y).bot = above; /* goes on above it. */
1026	}	990	}
1027		991
1028	above = 0;	992	above = 0;
1029	below = 0;	993	below = 0;
1030		994
1031	if (map->in_memory == MAP_SAVING)	995	if (map->in_memory == MAP_SAVING)
1032	return;	996	return;
1033		997
1034	check_walk_off = !QUERY_FLAG (this, FLAG_NO_APPLY);	998	int check_walk_off = !flag [FLAG_NO_APPLY];
1035		999
1036	for (tmp = GET_MAP_OB (map, x, y); tmp; tmp = tmp->above)	1000	for (tmp = map->at (x, y).bot; tmp; tmp = tmp->above)
1037	{	1001	{
1038	/* No point updating the players look faces if he is the object	1002	/* No point updating the players look faces if he is the object
1039	* being removed.	1003	* being removed.
1040	*/	1004	*/
1041		1005
…		…
1045	* removed (most likely destroyed), update the player view	1009	* removed (most likely destroyed), update the player view
1046	* appropriately.	1010	* appropriately.
1047	*/	1011	*/
1048	if (tmp->container == this)	1012	if (tmp->container == this)
1049	{	1013	{
1050	CLEAR_FLAG (this, FLAG_APPLIED);	1014	flag [FLAG_APPLIED] = 0;
1051	tmp->container = 0;	1015	tmp->container = 0;
1052	}	1016	}
1053		1017
		1018	if (tmp->contr->ns)
1054	tmp->contr->ns->floorbox_update ();	1019	tmp->contr->ns->floorbox_update ();
1055	}	1020	}
1056		1021
1057	/* See if player moving off should effect something */	1022	/* See if object moving off should effect something */
1058	if (check_walk_off	1023	if (check_walk_off
1059	&& ((move_type & tmp->move_off)	1024	&& ((move_type & tmp->move_off)
1060	&& (move_type & ~tmp->move_off & ~tmp->move_block) == 0))	1025	&& (move_type & ~tmp->move_off & ~tmp->move_block) == 0))
1061	{	1026	{
1062	move_apply (tmp, this, 0);	1027	move_apply (tmp, this, 0);
…		…
1064	if (destroyed ())	1029	if (destroyed ())
1065	LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());	1030	LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1066	}	1031	}
1067		1032
1068	/* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */	1033	/* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */
1069		1034	//TODO: why is this horrible hacka fix? get rid of this code=bug! (schmorp)
1070	if (tmp->above == tmp)	1035	if (tmp->above == tmp)
1071	tmp->above = 0;	1036	tmp->above = 0;
1072		1037
1073	last = tmp;	1038	last = tmp;
1074	}	1039	}
1075		1040
1076	/* last == NULL of there are no objects on this space */	1041	/* last == NULL if there are no objects on this space */
		1042	//TODO: this makes little sense, why only update the topmost object?
1077	if (!last)	1043	if (!last)
1078	map->at (x, y).flags_ = P_NEED_UPDATE;	1044	map->at (x, y).flags_ = 0;
1079	else	1045	else
1080	update_object (last, UP_OBJ_REMOVE);	1046	update_object (last, UP_OBJ_REMOVE);
1081		1047
1082	if (QUERY_FLAG (this, FLAG_BLOCKSVIEW) || glow_radius)	1048	if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1083	update_all_los (map, x, y);	1049	update_all_los (map, x, y);
1084	}	1050	}
1085	}	1051	}
1086		1052
1087	/*	1053	/*
…		…
1096	merge_ob (object *op, object *top)	1062	merge_ob (object *op, object *top)
1097	{	1063	{
1098	if (!op->nrof)	1064	if (!op->nrof)
1099	return 0;	1065	return 0;
1100		1066
1101	if (top == NULL)	1067	if (top)
1102	for (top = op; top != NULL && top->above != NULL; top = top->above);	1068	for (top = op; top && top->above; top = top->above)
		1069	;
1103		1070
1104	for (; top != NULL; top = top->below)	1071	for (; top; top = top->below)
1105	{	1072	{
1106	if (top == op)	1073	if (top == op)
1107	continue;	1074	continue;
1108		1075
1109	if (object::can_merge (op, top))	1076	if (object::can_merge (op, top))
…		…
1125	* job preparing multi-part monsters	1092	* job preparing multi-part monsters
1126	*/	1093	*/
1127	object *	1094	object *
1128	insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)	1095	insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1129	{	1096	{
1130	object *tmp;
1131
1132	if (op->head)
1133	op = op->head;
1134
1135	for (tmp = op; tmp; tmp = tmp->more)	1097	for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1136	{	1098	{
1137	tmp->x = x + tmp->arch->clone.x;	1099	tmp->x = x + tmp->arch->clone.x;
1138	tmp->y = y + tmp->arch->clone.y;	1100	tmp->y = y + tmp->arch->clone.y;
1139	}	1101	}
1140		1102
…		…
1159	* Return value:	1121	* Return value:
1160	* new object if 'op' was merged with other object	1122	* new object if 'op' was merged with other object
1161	* NULL if 'op' was destroyed	1123	* NULL if 'op' was destroyed
1162	* just 'op' otherwise	1124	* just 'op' otherwise
1163	*/	1125	*/
1164
1165	object *	1126	object *
1166	insert_ob_in_map (object *op, maptile *m, object *originator, int flag)	1127	insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1167	{	1128	{
1168	object *tmp, *top, *floor = NULL;	1129	object *tmp, *top, *floor = NULL;
1169	sint16 x, y;	1130	sint16 x, y;
…		…
1172	{	1133	{
1173	LOG (llevError, "Trying to insert freed object!\n");	1134	LOG (llevError, "Trying to insert freed object!\n");
1174	return NULL;	1135	return NULL;
1175	}	1136	}
1176		1137
1177	if (m == NULL)	1138	if (!m)
1178	{	1139	{
1179	char *dump = dump_object (op);	1140	char *dump = dump_object (op);
1180	LOG (llevError, "Trying to insert in null-map!\n%s\n", dump);	1141	LOG (llevError, "Trying to insert in null-map!\n%s\n", dump);
1181	free (dump);	1142	free (dump);
1182	return op;	1143	return op;
…		…
1203	LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", dump);	1164	LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", dump);
1204	free (dump);	1165	free (dump);
1205	return op;	1166	return op;
1206	}	1167	}
1207		1168
1208	if (op->more != NULL)	1169	if (op->more)
1209	{	1170	{
1210	/* The part may be on a different map. */	1171	/* The part may be on a different map. */
1211		1172
1212	object *more = op->more;	1173	object *more = op->more;
1213		1174
1214	/* We really need the caller to normalize coordinates - if	1175	/* We really need the caller to normalise coordinates - if
1215	* we set the map, that doesn't work if the location is within	1176	* we set the map, that doesn't work if the location is within
1216	* a map and this is straddling an edge. So only if coordinate	1177	* a map and this is straddling an edge. So only if coordinate
1217	* is clear wrong do we normalize it.	1178	* is clear wrong do we normalise it.
1218	*/	1179	*/
1219	if (OUT_OF_REAL_MAP (more->map, more->x, more->y))	1180	if (OUT_OF_REAL_MAP (more->map, more->x, more->y))
1220	more->map = get_map_from_coord (m, &more->x, &more->y);	1181	more->map = get_map_from_coord (m, &more->x, &more->y);
1221	else if (!more->map)	1182	else if (!more->map)
1222	{	1183	{
…		…
1229	if (insert_ob_in_map (more, more->map, originator, flag) == NULL)	1190	if (insert_ob_in_map (more, more->map, originator, flag) == NULL)
1230	{	1191	{
1231	if (!op->head)	1192	if (!op->head)
1232	LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n");	1193	LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n");
1233		1194
1234	return NULL;	1195	return 0;
1235	}	1196	}
1236	}	1197	}
1237		1198
1238	CLEAR_FLAG (op, FLAG_REMOVED);	1199	CLEAR_FLAG (op, FLAG_REMOVED);
1239		1200
…		…
1246	y = op->y;	1207	y = op->y;
1247		1208
1248	/* this has to be done after we translate the coordinates.	1209	/* this has to be done after we translate the coordinates.
1249	*/	1210	*/
1250	if (op->nrof && !(flag & INS_NO_MERGE))	1211	if (op->nrof && !(flag & INS_NO_MERGE))
1251	for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above)	1212	for (tmp = GET_MAP_OB (op->map, x, y); tmp; tmp = tmp->above)
1252	if (object::can_merge (op, tmp))	1213	if (object::can_merge (op, tmp))
1253	{	1214	{
1254	op->nrof += tmp->nrof;	1215	op->nrof += tmp->nrof;
1255	tmp->destroy ();	1216	tmp->destroy ();
1256	}	1217	}
…		…
1273	op->below = originator->below;	1234	op->below = originator->below;
1274		1235
1275	if (op->below)	1236	if (op->below)
1276	op->below->above = op;	1237	op->below->above = op;
1277	else	1238	else
1278	op->ms ().bottom = op;	1239	op->ms ().bot = op;
1279		1240
1280	/* since *below* originator, no need to update top */	1241	/* since *below* originator, no need to update top */
1281	originator->below = op;	1242	originator->below = op;
1282	}	1243	}
1283	else	1244	else
1284	{	1245	{
1285	/* If there are other objects, then */	1246	/* If there are other objects, then */
1286	if ((!(flag & INS_MAP_LOAD)) && ((top = GET_MAP_OB (op->map, op->x, op->y)) != NULL))	1247	if ((!(flag & INS_MAP_LOAD)) && ((top = GET_MAP_OB (op->map, op->x, op->y)) != NULL))
1287	{	1248	{
1288	object *last = NULL;	1249	object *last = 0;
1289		1250
1290	/*	1251	/*
1291	* If there are multiple objects on this space, we do some trickier handling.	1252	* If there are multiple objects on this space, we do some trickier handling.
1292	* We've already dealt with merging if appropriate.	1253	* We've already dealt with merging if appropriate.
1293	* Generally, we want to put the new object on top. But if	1254	* Generally, we want to put the new object on top. But if
…		…
1297	* once we get to them. This reduces the need to traverse over all of	1258	* once we get to them. This reduces the need to traverse over all of
1298	* them when adding another one - this saves quite a bit of cpu time	1259	* them when adding another one - this saves quite a bit of cpu time
1299	* when lots of spells are cast in one area. Currently, it is presumed	1260	* when lots of spells are cast in one area. Currently, it is presumed
1300	* that flying non pickable objects are spell objects.	1261	* that flying non pickable objects are spell objects.
1301	*/	1262	*/
1302
1303	while (top != NULL)	1263	while (top)
1304	{	1264	{
1305	if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))	1265	if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))
1306	floor = top;	1266	floor = top;
1307		1267
1308	if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))	1268	if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))
…		…
1361	op->above = GET_MAP_OB (op->map, op->x, op->y);	1321	op->above = GET_MAP_OB (op->map, op->x, op->y);
1362		1322
1363	if (op->above)	1323	if (op->above)
1364	op->above->below = op;	1324	op->above->below = op;
1365		1325
1366	op->below = NULL;	1326	op->below = 0;
1367	op->ms ().bottom = op;	1327	op->ms ().bot = op;
1368	}	1328	}
1369	else	1329	else
1370	{ /* get inserted into the stack above top */	1330	{ /* get inserted into the stack above top */
1371	op->above = top->above;	1331	op->above = top->above;
1372		1332
…		…
1375		1335
1376	op->below = top;	1336	op->below = top;
1377	top->above = op;	1337	top->above = op;
1378	}	1338	}
1379		1339
1380	if (op->above == NULL)	1340	if (!op->above)
1381	op->ms ().top = op;	1341	op->ms ().top = op;
1382	} /* else not INS_BELOW_ORIGINATOR */	1342	} /* else not INS_BELOW_ORIGINATOR */
1383		1343
1384	if (op->type == PLAYER)	1344	if (op->type == PLAYER)
		1345	{
1385	op->contr->do_los = 1;	1346	op->contr->do_los = 1;
		1347	++op->map->players;
		1348	op->map->touch ();
		1349	}
		1350
		1351	op->map->dirty = true;
1386		1352
1387	/* If we have a floor, we know the player, if any, will be above	1353	/* If we have a floor, we know the player, if any, will be above
1388	* it, so save a few ticks and start from there.	1354	* it, so save a few ticks and start from there.
1389	*/	1355	*/
1390	if (!(flag & INS_MAP_LOAD))	1356	if (!(flag & INS_MAP_LOAD))
1391	if (object *pl = op->ms ().player ())	1357	if (object *pl = op->ms ().player ())
		1358	if (pl->contr->ns)
1392	pl->contr->ns->floorbox_update ();	1359	pl->contr->ns->floorbox_update ();
1393		1360
1394	/* If this object glows, it may affect lighting conditions that are	1361	/* If this object glows, it may affect lighting conditions that are
1395	* visible to others on this map. But update_all_los is really	1362	* visible to others on this map. But update_all_los is really
1396	* an inefficient way to do this, as it means los for all players	1363	* an inefficient way to do this, as it means los for all players
1397	* on the map will get recalculated. The players could very well	1364	* on the map will get recalculated. The players could very well
1398	* be far away from this change and not affected in any way -	1365	* be far away from this change and not affected in any way -
1399	* this should get redone to only look for players within range,	1366	* this should get redone to only look for players within range,
1400	* or just updating the P_NEED_UPDATE for spaces within this area	1367	* or just updating the P_UPTODATE for spaces within this area
1401	* of effect may be sufficient.	1368	* of effect may be sufficient.
1402	*/	1369	*/
1403	if (MAP_DARKNESS (op->map) && (op->glow_radius != 0))	1370	if (op->map->darkness && (op->glow_radius != 0))
1404	update_all_los (op->map, op->x, op->y);	1371	update_all_los (op->map, op->x, op->y);
1405		1372
1406	/* updates flags (blocked, alive, no magic, etc) for this map space */	1373	/* updates flags (blocked, alive, no magic, etc) for this map space */
1407	update_object (op, UP_OBJ_INSERT);	1374	update_object (op, UP_OBJ_INSERT);
		1375
		1376	INVOKE_OBJECT (INSERT, op);
1408		1377
1409	/* Don't know if moving this to the end will break anything. However,	1378	/* Don't know if moving this to the end will break anything. However,
1410	* we want to have floorbox_update called before calling this.	1379	* we want to have floorbox_update called before calling this.
1411	*	1380	*
1412	* check_move_on() must be after this because code called from	1381	* check_move_on() must be after this because code called from
…		…
1417		1386
1418	/* if this is not the head or flag has been passed, don't check walk on status */	1387	/* if this is not the head or flag has been passed, don't check walk on status */
1419	if (!(flag & INS_NO_WALK_ON) && !op->head)	1388	if (!(flag & INS_NO_WALK_ON) && !op->head)
1420	{	1389	{
1421	if (check_move_on (op, originator))	1390	if (check_move_on (op, originator))
1422	return NULL;	1391	return 0;
1423		1392
1424	/* If we are a multi part object, lets work our way through the check	1393	/* If we are a multi part object, lets work our way through the check
1425	* walk on's.	1394	* walk on's.
1426	*/	1395	*/
1427	for (tmp = op->more; tmp != NULL; tmp = tmp->more)	1396	for (tmp = op->more; tmp != NULL; tmp = tmp->more)
1428	if (check_move_on (tmp, originator))	1397	if (check_move_on (tmp, originator))
1429	return NULL;	1398	return 0;
1430	}	1399	}
1431		1400
1432	return op;	1401	return op;
1433	}	1402	}
1434		1403
…		…
1441	{	1410	{
1442	object *tmp, *tmp1;	1411	object *tmp, *tmp1;
1443		1412
1444	/* first search for itself and remove any old instances */	1413	/* first search for itself and remove any old instances */
1445		1414
1446	for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above)	1415	for (tmp = op->ms ().bot; tmp; tmp = tmp->above)
1447	if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */	1416	if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */
1448	tmp->destroy ();	1417	tmp->destroy ();
1449		1418
1450	tmp1 = arch_to_object (archetype::find (arch_string));	1419	tmp1 = arch_to_object (archetype::find (arch_string));
1451		1420
1452	tmp1->x = op->x;	1421	tmp1->x = op->x;
1453	tmp1->y = op->y;	1422	tmp1->y = op->y;
1454	insert_ob_in_map (tmp1, op->map, op, 0);	1423	insert_ob_in_map (tmp1, op->map, op, 0);
		1424	}
		1425
		1426	object *
		1427	object::insert_at (object *where, object *originator, int flags)
		1428	{
		1429	where->map->insert (this, where->x, where->y, originator, flags);
1455	}	1430	}
1456		1431
1457	/*	1432	/*
1458	* get_split_ob(ob,nr) splits up ob into two parts. The part which	1433	* get_split_ob(ob,nr) splits up ob into two parts. The part which
1459	* is returned contains nr objects, and the remaining parts contains	1434	* is returned contains nr objects, and the remaining parts contains
1460	* the rest (or is removed and freed if that number is 0).	1435	* the rest (or is removed and freed if that number is 0).
1461	* On failure, NULL is returned, and the reason put into the	1436	* On failure, NULL is returned, and the reason put into the
1462	* global static errmsg array.	1437	* global static errmsg array.
1463	*/	1438	*/
1464
1465	object *	1439	object *
1466	get_split_ob (object *orig_ob, uint32 nr)	1440	get_split_ob (object *orig_ob, uint32 nr)
1467	{	1441	{
1468	object *newob;	1442	object *newob;
1469	int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);	1443	int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
…		…
1692	if ((op->glow_radius != 0) && map)	1666	if ((op->glow_radius != 0) && map)
1693	{	1667	{
1694	#ifdef DEBUG_LIGHTS	1668	#ifdef DEBUG_LIGHTS
1695	LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);	1669	LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1696	#endif /* DEBUG_LIGHTS */	1670	#endif /* DEBUG_LIGHTS */
1697	if (MAP_DARKNESS (map))	1671	if (map->darkness)
1698	update_all_los (map, x, y);	1672	update_all_los (map, x, y);
1699	}	1673	}
1700		1674
1701	/* Client has no idea of ordering so lets not bother ordering it here.	1675	/* Client has no idea of ordering so lets not bother ordering it here.
1702	* It sure simplifies this function...	1676	* It sure simplifies this function...
…		…
1707	{	1681	{
1708	op->below = inv;	1682	op->below = inv;
1709	op->below->above = op;	1683	op->below->above = op;
1710	inv = op;	1684	inv = op;
1711	}	1685	}
		1686
		1687	INVOKE_OBJECT (INSERT, this);
1712		1688
1713	return op;	1689	return op;
1714	}	1690	}
1715		1691
1716	/*	1692	/*
…		…
1731	*	1707	*
1732	* MSW 2001-07-08: Check all objects on space, not just those below	1708	* MSW 2001-07-08: Check all objects on space, not just those below
1733	* object being inserted. insert_ob_in_map may not put new objects	1709	* object being inserted. insert_ob_in_map may not put new objects
1734	* on top.	1710	* on top.
1735	*/	1711	*/
1736
1737	int	1712	int
1738	check_move_on (object *op, object *originator)	1713	check_move_on (object *op, object *originator)
1739	{	1714	{
1740	object *tmp;	1715	object *tmp;
1741	maptile *m = op->map;	1716	maptile *m = op->map;
…		…
1768		1743
1769	/* The objects have to be checked from top to bottom.	1744	/* The objects have to be checked from top to bottom.
1770	* Hence, we first go to the top:	1745	* Hence, we first go to the top:
1771	*/	1746	*/
1772		1747
1773	for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL && tmp->above != NULL; tmp = tmp->above)	1748	for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1774	{	1749	{
1775	/* Trim the search when we find the first other spell effect	1750	/* Trim the search when we find the first other spell effect
1776	* this helps performance so that if a space has 50 spell objects,	1751	* this helps performance so that if a space has 50 spell objects,
1777	* we don't need to check all of them.	1752	* we don't need to check all of them.
1778	*/	1753	*/
…		…
1833	/*	1808	/*
1834	* present_arch(arch, map, x, y) searches for any objects with	1809	* present_arch(arch, map, x, y) searches for any objects with
1835	* a matching archetype at the given map and coordinates.	1810	* a matching archetype at the given map and coordinates.
1836	* The first matching object is returned, or NULL if none.	1811	* The first matching object is returned, or NULL if none.
1837	*/	1812	*/
1838
1839	object *	1813	object *
1840	present_arch (const archetype *at, maptile *m, int x, int y)	1814	present_arch (const archetype *at, maptile *m, int x, int y)
1841	{	1815	{
1842	object *
1843	tmp;
1844
1845	if (m == NULL || out_of_map (m, x, y))	1816	if (!m || out_of_map (m, x, y))
1846	{	1817	{
1847	LOG (llevError, "Present_arch called outside map.\n");	1818	LOG (llevError, "Present_arch called outside map.\n");
1848	return NULL;	1819	return NULL;
1849	}	1820	}
1850	for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above)	1821
		1822	for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1851	if (tmp->arch == at)	1823	if (tmp->arch == at)
1852	return tmp;	1824	return tmp;
		1825
1853	return NULL;	1826	return NULL;
1854	}	1827	}
1855		1828
1856	/*	1829	/*
1857	* present(type, map, x, y) searches for any objects with	1830	* present(type, map, x, y) searches for any objects with
1858	* a matching type variable at the given map and coordinates.	1831	* a matching type variable at the given map and coordinates.
1859	* The first matching object is returned, or NULL if none.	1832	* The first matching object is returned, or NULL if none.
1860	*/	1833	*/
1861
1862	object *	1834	object *
1863	present (unsigned char type, maptile *m, int x, int y)	1835	present (unsigned char type, maptile *m, int x, int y)
1864	{	1836	{
1865	object *
1866	tmp;
1867
1868	if (out_of_map (m, x, y))	1837	if (out_of_map (m, x, y))
1869	{	1838	{
1870	LOG (llevError, "Present called outside map.\n");	1839	LOG (llevError, "Present called outside map.\n");
1871	return NULL;	1840	return NULL;
1872	}	1841	}
1873	for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above)	1842
		1843	for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1874	if (tmp->type == type)	1844	if (tmp->type == type)
1875	return tmp;	1845	return tmp;
		1846
1876	return NULL;	1847	return NULL;
1877	}	1848	}
1878		1849
1879	/*	1850	/*
1880	* present_in_ob(type, object) searches for any objects with	1851	* present_in_ob(type, object) searches for any objects with
1881	* a matching type variable in the inventory of the given object.	1852	* a matching type variable in the inventory of the given object.
1882	* The first matching object is returned, or NULL if none.	1853	* The first matching object is returned, or NULL if none.
1883	*/	1854	*/
1884
1885	object *	1855	object *
1886	present_in_ob (unsigned char type, const object *op)	1856	present_in_ob (unsigned char type, const object *op)
1887	{	1857	{
1888	object *
1889	tmp;
1890
1891	for (tmp = op->inv; tmp != NULL; tmp = tmp->below)	1858	for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
1892	if (tmp->type == type)	1859	if (tmp->type == type)
1893	return tmp;	1860	return tmp;
		1861
1894	return NULL;	1862	return NULL;
1895	}	1863	}
1896		1864
1897	/*	1865	/*
1898	* present_in_ob (type, str, object) searches for any objects with	1866	* present_in_ob (type, str, object) searches for any objects with
…		…
1906	* str is the string to match against. Note that we match against	1874	* str is the string to match against. Note that we match against
1907	* the object name, not the archetype name. this is so that the	1875	* the object name, not the archetype name. this is so that the
1908	* spell code can use one object type (force), but change it's name	1876	* spell code can use one object type (force), but change it's name
1909	* to be unique.	1877	* to be unique.
1910	*/	1878	*/
1911
1912	object *	1879	object *
1913	present_in_ob_by_name (int type, const char *str, const object *op)	1880	present_in_ob_by_name (int type, const char *str, const object *op)
1914	{	1881	{
1915	object *
1916	tmp;
1917
1918	for (tmp = op->inv; tmp != NULL; tmp = tmp->below)	1882	for (object *tmp = op->inv; tmp; tmp = tmp->below)
1919	{
1920	if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name)))	1883	if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name)))
1921	return tmp;	1884	return tmp;
1922	}	1885
1923	return NULL;	1886	return 0;
1924	}	1887	}
1925		1888
1926	/*	1889	/*
1927	* present_arch_in_ob(archetype, object) searches for any objects with	1890	* present_arch_in_ob(archetype, object) searches for any objects with
1928	* a matching archetype in the inventory of the given object.	1891	* a matching archetype in the inventory of the given object.
1929	* The first matching object is returned, or NULL if none.	1892	* The first matching object is returned, or NULL if none.
1930	*/	1893	*/
1931
1932	object *	1894	object *
1933	present_arch_in_ob (const archetype *at, const object *op)	1895	present_arch_in_ob (const archetype *at, const object *op)
1934	{	1896	{
1935	object *
1936	tmp;
1937
1938	for (tmp = op->inv; tmp != NULL; tmp = tmp->below)	1897	for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
1939	if (tmp->arch == at)	1898	if (tmp->arch == at)
1940	return tmp;	1899	return tmp;
		1900
1941	return NULL;	1901	return NULL;
1942	}	1902	}
1943		1903
1944	/*	1904	/*
1945	* activate recursively a flag on an object inventory	1905	* activate recursively a flag on an object inventory
1946	*/	1906	*/
1947	void	1907	void
1948	flag_inv (object *op, int flag)	1908	flag_inv (object *op, int flag)
1949	{	1909	{
1950	object *
1951	tmp;
1952
1953	if (op->inv)	1910	if (op->inv)
1954	for (tmp = op->inv; tmp != NULL; tmp = tmp->below)	1911	for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
1955	{	1912	{
1956	SET_FLAG (tmp, flag);	1913	SET_FLAG (tmp, flag);
1957	flag_inv (tmp, flag);	1914	flag_inv (tmp, flag);
1958	}	1915	}
1959	} /*	1916	}
		1917
		1918	/*
1960	* desactivate recursively a flag on an object inventory	1919	* deactivate recursively a flag on an object inventory
1961	*/	1920	*/
1962	void	1921	void
1963	unflag_inv (object *op, int flag)	1922	unflag_inv (object *op, int flag)
1964	{	1923	{
1965	object *
1966	tmp;
1967
1968	if (op->inv)	1924	if (op->inv)
1969	for (tmp = op->inv; tmp != NULL; tmp = tmp->below)	1925	for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
1970	{	1926	{
1971	CLEAR_FLAG (tmp, flag);	1927	CLEAR_FLAG (tmp, flag);
1972	unflag_inv (tmp, flag);	1928	unflag_inv (tmp, flag);
1973	}	1929	}
1974	}	1930	}
…		…
1977	* set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in	1933	* set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in
1978	* all it's inventory (recursively).	1934	* all it's inventory (recursively).
1979	* If checksums are used, a player will get set_cheat called for	1935	* If checksums are used, a player will get set_cheat called for
1980	* him/her-self and all object carried by a call to this function.	1936	* him/her-self and all object carried by a call to this function.
1981	*/	1937	*/
1982
1983	void	1938	void
1984	set_cheat (object *op)	1939	set_cheat (object *op)
1985	{	1940	{
1986	SET_FLAG (op, FLAG_WAS_WIZ);	1941	SET_FLAG (op, FLAG_WAS_WIZ);
1987	flag_inv (op, FLAG_WAS_WIZ);	1942	flag_inv (op, FLAG_WAS_WIZ);
…		…
2006	* because arch_blocked (now ob_blocked) needs to know the movement type	1961	* because arch_blocked (now ob_blocked) needs to know the movement type
2007	* to know if the space in question will block the object. We can't use	1962	* to know if the space in question will block the object. We can't use
2008	* the archetype because that isn't correct if the monster has been	1963	* the archetype because that isn't correct if the monster has been
2009	* customized, changed states, etc.	1964	* customized, changed states, etc.
2010	*/	1965	*/
2011
2012	int	1966	int
2013	find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)	1967	find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)
2014	{	1968	{
2015	int
2016	i,
2017	index = 0, flag;	1969	int index = 0, flag;
2018	static int
2019	altern[SIZEOFFREE];	1970	int altern[SIZEOFFREE];
2020		1971
2021	for (i = start; i < stop; i++)	1972	for (int i = start; i < stop; i++)
2022	{	1973	{
2023	flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]);	1974	flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]);
2024	if (!flag)	1975	if (!flag)
2025	altern[index++] = i;	1976	altern [index++] = i;
2026		1977
2027	/* Basically, if we find a wall on a space, we cut down the search size.	1978	/* Basically, if we find a wall on a space, we cut down the search size.
2028	* In this way, we won't return spaces that are on another side of a wall.	1979	* In this way, we won't return spaces that are on another side of a wall.
2029	* This mostly work, but it cuts down the search size in all directions -	1980	* This mostly work, but it cuts down the search size in all directions -
2030	* if the space being examined only has a wall to the north and empty	1981	* if the space being examined only has a wall to the north and empty
…		…
2046	* find_first_free_spot(archetype, maptile, x, y) works like	1997	* find_first_free_spot(archetype, maptile, x, y) works like
2047	* find_free_spot(), but it will search max number of squares.	1998	* find_free_spot(), but it will search max number of squares.
2048	* But it will return the first available spot, not a random choice.	1999	* But it will return the first available spot, not a random choice.
2049	* Changed 0.93.2: Have it return -1 if there is no free spot available.	2000	* Changed 0.93.2: Have it return -1 if there is no free spot available.
2050	*/	2001	*/
2051
2052	int	2002	int
2053	find_first_free_spot (const object *ob, maptile *m, int x, int y)	2003	find_first_free_spot (const object *ob, maptile *m, int x, int y)
2054	{	2004	{
2055	int
2056	i;
2057
2058	for (i = 0; i < SIZEOFFREE; i++)	2005	for (int i = 0; i < SIZEOFFREE; i++)
2059	{
2060	if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]))	2006	if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]))
2061	return i;	2007	return i;
2062	}	2008
2063	return -1;	2009	return -1;
2064	}	2010	}
2065		2011
2066	/*	2012	/*
2067	* The function permute(arr, begin, end) randomly reorders the array	2013	* The function permute(arr, begin, end) randomly reorders the array
2068	* arr[begin..end-1].	2014	* arr[begin..end-1].
		2015	* now uses a fisher-yates shuffle, old permute was broken
2069	*/	2016	*/
2070	static void	2017	static void
2071	permute (int *arr, int begin, int end)	2018	permute (int *arr, int begin, int end)
2072	{	2019	{
2073	int	2020	arr += begin;
2074	i,
2075	j,
2076	tmp,
2077	len;
2078
2079	len = end - begin;	2021	end -= begin;
2080	for (i = begin; i < end; i++)
2081	{
2082	j = begin + RANDOM () % len;
2083		2022
2084	tmp = arr[i];	2023	while (--end)
2085	arr[i] = arr[j];	2024	swap (arr [end], arr [RANDOM () % (end + 1)]);
2086	arr[j] = tmp;
2087	}
2088	}	2025	}
2089		2026
2090	/* new function to make monster searching more efficient, and effective!	2027	/* new function to make monster searching more efficient, and effective!
2091	* This basically returns a randomized array (in the passed pointer) of	2028	* This basically returns a randomized array (in the passed pointer) of
2092	* the spaces to find monsters. In this way, it won't always look for	2029	* the spaces to find monsters. In this way, it won't always look for
…		…
2095	* the 3x3 area will be searched, just not in a predictable order.	2032	* the 3x3 area will be searched, just not in a predictable order.
2096	*/	2033	*/
2097	void	2034	void
2098	get_search_arr (int *search_arr)	2035	get_search_arr (int *search_arr)
2099	{	2036	{
2100	int	2037	int i;
2101	i;
2102		2038
2103	for (i = 0; i < SIZEOFFREE; i++)	2039	for (i = 0; i < SIZEOFFREE; i++)
2104	{
2105	search_arr[i] = i;	2040	search_arr[i] = i;
2106	}
2107		2041
2108	permute (search_arr, 1, SIZEOFFREE1 + 1);	2042	permute (search_arr, 1, SIZEOFFREE1 + 1);
2109	permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1);	2043	permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1);
2110	permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE);	2044	permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE);
2111	}	2045	}
…		…
2120	* Perhaps incorrectly, but I'm making the assumption that exclude	2054	* Perhaps incorrectly, but I'm making the assumption that exclude
2121	* is actually want is going to try and move there. We need this info	2055	* is actually want is going to try and move there. We need this info
2122	* because we have to know what movement the thing looking to move	2056	* because we have to know what movement the thing looking to move
2123	* there is capable of.	2057	* there is capable of.
2124	*/	2058	*/
2125
2126	int	2059	int
2127	find_dir (maptile *m, int x, int y, object *exclude)	2060	find_dir (maptile *m, int x, int y, object *exclude)
2128	{	2061	{
2129	int
2130	i,
2131	max = SIZEOFFREE, mflags;	2062	int i, max = SIZEOFFREE, mflags;
2132		2063
2133	sint16 nx, ny;	2064	sint16 nx, ny;
2134	object *	2065	object *tmp;
2135	tmp;
2136	maptile *	2066	maptile *mp;
2137	mp;
2138		2067
2139	MoveType blocked, move_type;	2068	MoveType blocked, move_type;
2140		2069
2141	if (exclude && exclude->head)	2070	if (exclude && exclude->head)
2142	{	2071	{
…		…
2159		2088
2160	if (mflags & P_OUT_OF_MAP)	2089	if (mflags & P_OUT_OF_MAP)
2161	max = maxfree[i];	2090	max = maxfree[i];
2162	else	2091	else
2163	{	2092	{
2164	blocked = GET_MAP_MOVE_BLOCK (mp, nx, ny);	2093	mapspace &ms = mp->at (nx, ny);
		2094
		2095	blocked = ms.move_block;
2165		2096
2166	if ((move_type & blocked) == move_type)	2097	if ((move_type & blocked) == move_type)
2167	max = maxfree[i];	2098	max = maxfree[i];
2168	else if (mflags & P_IS_ALIVE)	2099	else if (mflags & P_IS_ALIVE)
2169	{	2100	{
2170	for (tmp = GET_MAP_OB (mp, nx, ny); tmp; tmp = tmp->above)	2101	for (tmp = ms.bot; tmp; tmp = tmp->above)
2171	if ((QUERY_FLAG (tmp, FLAG_MONSTER) || tmp->type == PLAYER) && (tmp != exclude || (tmp->head && tmp->head != exclude)))	2102	if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)
		2103	&& (tmp != exclude || (tmp->head && tmp->head != exclude)))
2172	break;	2104	break;
2173		2105
2174	if (tmp)	2106	if (tmp)
2175	return freedir[i];	2107	return freedir[i];
2176	}	2108	}
…		…
2182		2114
2183	/*	2115	/*
2184	* distance(object 1, object 2) will return the square of the	2116	* distance(object 1, object 2) will return the square of the
2185	* distance between the two given objects.	2117	* distance between the two given objects.
2186	*/	2118	*/
2187
2188	int	2119	int
2189	distance (const object *ob1, const object *ob2)	2120	distance (const object *ob1, const object *ob2)
2190	{	2121	{
2191	int i;
2192
2193	i = (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);	2122	return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2194	return i;
2195	}	2123	}
2196		2124
2197	/*	2125	/*
2198	* find_dir_2(delta-x,delta-y) will return a direction in which	2126	* find_dir_2(delta-x,delta-y) will return a direction in which
2199	* an object which has subtracted the x and y coordinates of another	2127	* an object which has subtracted the x and y coordinates of another
2200	* object, needs to travel toward it.	2128	* object, needs to travel toward it.
2201	*/	2129	*/
2202
2203	int	2130	int
2204	find_dir_2 (int x, int y)	2131	find_dir_2 (int x, int y)
2205	{	2132	{
2206	int q;	2133	int q;
2207		2134
…		…
2246	int	2173	int
2247	absdir (int d)	2174	absdir (int d)
2248	{	2175	{
2249	while (d < 1)	2176	while (d < 1)
2250	d += 8;	2177	d += 8;
		2178
2251	while (d > 8)	2179	while (d > 8)
2252	d -= 8;	2180	d -= 8;
		2181
2253	return d;	2182	return d;
2254	}	2183	}
2255		2184
2256	/*	2185	/*
2257	* dirdiff(dir1, dir2) returns how many 45-degrees differences there is	2186	* dirdiff(dir1, dir2) returns how many 45-degrees differences there is
…		…
2259	*/	2188	*/
2260		2189
2261	int	2190	int
2262	dirdiff (int dir1, int dir2)	2191	dirdiff (int dir1, int dir2)
2263	{	2192	{
2264	int	2193	int d;
2265	d;
2266		2194
2267	d = abs (dir1 - dir2);	2195	d = abs (dir1 - dir2);
2268	if (d > 4)	2196	if (d > 4)
2269	d = 8 - d;	2197	d = 8 - d;
		2198
2270	return d;	2199	return d;
2271	}	2200	}
2272		2201
2273	/* peterm:	2202	/* peterm:
2274	* do LOS stuff for ball lightning. Go after the closest VISIBLE monster.	2203	* do LOS stuff for ball lightning. Go after the closest VISIBLE monster.
…		…
2277	* This basically means that if direction is 15, then it could either go	2206	* This basically means that if direction is 15, then it could either go
2278	* direction 4, 14, or 16 to get back to where we are.	2207	* direction 4, 14, or 16 to get back to where we are.
2279	* Moved from spell_util.c to object.c with the other related direction	2208	* Moved from spell_util.c to object.c with the other related direction
2280	* functions.	2209	* functions.
2281	*/	2210	*/
2282
2283	int
2284	reduction_dir[SIZEOFFREE][3] = {	2211	int reduction_dir[SIZEOFFREE][3] = {
2285	{0, 0, 0}, /* 0 */	2212	{0, 0, 0}, /* 0 */
2286	{0, 0, 0}, /* 1 */	2213	{0, 0, 0}, /* 1 */
2287	{0, 0, 0}, /* 2 */	2214	{0, 0, 0}, /* 2 */
2288	{0, 0, 0}, /* 3 */	2215	{0, 0, 0}, /* 3 */
2289	{0, 0, 0}, /* 4 */	2216	{0, 0, 0}, /* 4 */
…		…
2439	/* Basically, we save the content of the string to a temp file, then call */	2366	/* Basically, we save the content of the string to a temp file, then call */
2440	/* load_object on it. I admit it is a highly inefficient way to make things, */	2367	/* load_object on it. I admit it is a highly inefficient way to make things, */
2441	/* but it was simple to make and allows reusing the load_object function. */	2368	/* but it was simple to make and allows reusing the load_object function. */
2442	/* Remember not to use load_object_str in a time-critical situation. */	2369	/* Remember not to use load_object_str in a time-critical situation. */
2443	/* Also remember that multiparts objects are not supported for now. */	2370	/* Also remember that multiparts objects are not supported for now. */
2444
2445	object *	2371	object *
2446	load_object_str (const char *obstr)	2372	load_object_str (const char *obstr)
2447	{	2373	{
2448	object *op;	2374	object *op;
2449	char filename[MAX_BUF];	2375	char filename[MAX_BUF];
…		…
2479	* returns NULL if no match.	2405	* returns NULL if no match.
2480	*/	2406	*/
2481	object *	2407	object *
2482	find_obj_by_type_subtype (const object *who, int type, int subtype)	2408	find_obj_by_type_subtype (const object *who, int type, int subtype)
2483	{	2409	{
2484	object *tmp;
2485
2486	for (tmp = who->inv; tmp; tmp = tmp->below)	2410	for (object *tmp = who->inv; tmp; tmp = tmp->below)
2487	if (tmp->type == type && tmp->subtype == subtype)	2411	if (tmp->type == type && tmp->subtype == subtype)
2488	return tmp;	2412	return tmp;
2489		2413
2490	return NULL;	2414	return 0;
2491	}	2415	}
2492		2416
2493	/* If ob has a field named key, return the link from the list,	2417	/* If ob has a field named key, return the link from the list,
2494	* otherwise return NULL.	2418	* otherwise return NULL.
2495	*	2419	*
…		…
2497	* do the desired thing.	2421	* do the desired thing.
2498	*/	2422	*/
2499	key_value *	2423	key_value *
2500	get_ob_key_link (const object *ob, const char *key)	2424	get_ob_key_link (const object *ob, const char *key)
2501	{	2425	{
2502	key_value *link;
2503
2504	for (link = ob->key_values; link != NULL; link = link->next)	2426	for (key_value *link = ob->key_values; link; link = link->next)
2505	if (link->key == key)	2427	if (link->key == key)
2506	return link;	2428	return link;
2507		2429
2508	return NULL;	2430	return 0;
2509	}	2431	}
2510		2432
2511	/*	2433	/*
2512	* Returns the value of op has an extra_field for key, or NULL.	2434	* Returns the value of op has an extra_field for key, or NULL.
2513	*	2435	*
…		…
2553	* Returns TRUE on success.	2475	* Returns TRUE on success.
2554	*/	2476	*/
2555	int	2477	int
2556	set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)	2478	set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2557	{	2479	{
2558	key_value *
2559	field = NULL, *last = NULL;	2480	key_value *field = NULL, *last = NULL;
2560		2481
2561	for (field = op->key_values; field != NULL; field = field->next)	2482	for (field = op->key_values; field != NULL; field = field->next)
2562	{	2483	{
2563	if (field->key != canonical_key)	2484	if (field->key != canonical_key)
2564	{	2485	{
…		…
2592	/* IF we get here, key doesn't exist */	2513	/* IF we get here, key doesn't exist */
2593		2514
2594	/* No field, we'll have to add it. */	2515	/* No field, we'll have to add it. */
2595		2516
2596	if (!add_key)	2517	if (!add_key)
2597	{
2598	return FALSE;	2518	return FALSE;
2599	}	2519
2600	/* There isn't any good reason to store a null	2520	/* There isn't any good reason to store a null
2601	* value in the key/value list. If the archetype has	2521	* value in the key/value list. If the archetype has
2602	* this key, then we should also have it, so shouldn't	2522	* this key, then we should also have it, so shouldn't
2603	* be here. If user wants to store empty strings,	2523	* be here. If user wants to store empty strings,
2604	* should pass in ""	2524	* should pass in ""
…		…
2653	}	2573	}
2654	else	2574	else
2655	item = item->env;	2575	item = item->env;
2656	}	2576	}
2657		2577
		2578
		2579	const char *
		2580	object::flag_desc (char *desc, int len) const
		2581	{
		2582	char *p = desc;
		2583	bool first = true;
		2584
		2585	*p = 0;
		2586
		2587	for (int i = 0; i < NUM_FLAGS; i++)
		2588	{
		2589	if (len <= 10) // magic constant!
		2590	{
		2591	snprintf (p, len, ",...");
		2592	break;
		2593	}
		2594
		2595	if (flag [i])
		2596	{
		2597	int cnt = snprintf (p, len, "%s%d", first ? "" : ",", i);
		2598	len -= cnt;
		2599	p += cnt;
		2600	first = false;
		2601	}
		2602	}
		2603
		2604	return desc;
		2605	}
		2606
2658	// return a suitable string describing an objetc in enough detail to find it	2607	// return a suitable string describing an object in enough detail to find it
2659	const char *	2608	const char *
2660	object::debug_desc (char *info) const	2609	object::debug_desc (char *info) const
2661	{	2610	{
		2611	char flagdesc[512];
2662	char info2[256 * 3];	2612	char info2[256 * 4];
2663	char *p = info;	2613	char *p = info;
2664		2614
2665	p += snprintf (p, 256, "%d=\"%s%s%s\"",	2615	p += snprintf (p, 512, "{cnt:%d,uuid:<1,%" PRIx64 ">,name:\"%s%s%s\",flags:[%s],type:%d}",
2666	count,	2616	count, uuid.seq,
2667	&name,	2617	&name,
2668	title ? " " : "",	2618	title ? "\",title:" : "",
2669	title ? (const char *)title : "");	2619	title ? (const char *)title : "",
		2620	flag_desc (flagdesc, 512), type);
2670		2621
2671	if (env)	2622	if (env)
2672	p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));	2623	p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2673		2624
2674	if (map)	2625	if (map)
2675	p += snprintf (p, 256, "(on %s@%d+%d)", map->path, x, y);	2626	p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2676		2627
2677	return info;	2628	return info;
2678	}	2629	}
2679		2630
2680	const char *	2631	const char *
2681	object::debug_desc () const	2632	object::debug_desc () const
2682	{	2633	{
2683	static char info[256 * 3];	2634	static char info[256 * 4];
2684	return debug_desc (info);	2635	return debug_desc (info);
2685	}	2636	}
2686		2637

Diff Legend

–	Removed lines
+	Added lines
<	Changed lines
>	Changed lines