ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.116 by pippijn, Mon Jan 15 21:06:18 2007 UTC vs.
Revision 1.117 by root, Thu Jan 18 16:19:34 2007 UTC

… …
899 * environment, the x and y coordinates will be updated to 899 * environment, the x and y coordinates will be updated to
900 * the previous environment. 900 * the previous environment.
901 * Beware: This function is called from the editor as well! 901 * Beware: This function is called from the editor as well!
902 */ 902 */
903void 903void
904object::remove () 904object::remove_slow ()
905{ 905{
906 object *tmp, *last = 0; 906 object *tmp, *last = 0;
907 object *otmp; 907 object *otmp;
908 908
909 if (QUERY_FLAG (this, FLAG_REMOVED)) 909 if (QUERY_FLAG (this, FLAG_REMOVED))
… …
957 --map->players; 957 --map->players;
958 map->touch (); 958 map->touch ();
959 } 959 }
960 960
961 map->dirty = true; 961 map->dirty = true;
962 mapspace &ms = this->ms ();
962 963
963 /* link the object above us */ 964 /* link the object above us */
964 if (above) 965 if (above)
965 above->below = below; 966 above->below = below;
966 else 967 else
967 map->at (x, y).top = below; /* we were top, set new top */ 968 ms.top = below; /* we were top, set new top */
968 969
969 /* Relink the object below us, if there is one */ 970 /* Relink the object below us, if there is one */
970 if (below) 971 if (below)
971 below->above = above; 972 below->above = above;
972 else 973 else
… …
974 /* Nothing below, which means we need to relink map object for this space 975 /* Nothing below, which means we need to relink map object for this space
975 * use translated coordinates in case some oddness with map tiling is 976 * use translated coordinates in case some oddness with map tiling is
976 * evident 977 * evident
977 */ 978 */
978 if (GET_MAP_OB (map, x, y) != this) 979 if (GET_MAP_OB (map, x, y) != this)
979 {
980 char *dump = dump_object (this);
981 LOG (llevError,
982 "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", dump); 980 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
983 free (dump);
984 dump = dump_object (GET_MAP_OB (map, x, y));
985 LOG (llevError, "%s\n", dump);
986 free (dump);
987 }
988 981
989 map->at (x, y).bot = above; /* goes on above it. */ 982 ms.bot = above; /* goes on above it. */
990 } 983 }
991 984
992 above = 0; 985 above = 0;
993 below = 0; 986 below = 0;
994 987
995 if (map->in_memory == MAP_SAVING) 988 if (map->in_memory == MAP_SAVING)
996 return; 989 return;
997 990
998 int check_walk_off = !flag [FLAG_NO_APPLY]; 991 int check_walk_off = !flag [FLAG_NO_APPLY];
999 992
1000 for (tmp = map->at (x, y).bot; tmp; tmp = tmp->above) 993 for (tmp = ms.bot; tmp; tmp = tmp->above)
1001 { 994 {
1002 /* No point updating the players look faces if he is the object 995 /* No point updating the players look faces if he is the object
1003 * being removed. 996 * being removed.
1004 */ 997 */
1005 998
… …
1086 1079
1087 return 0; 1080 return 0;
1088} 1081}
1089 1082
1090/* 1083/*
1091 * same as insert_ob_in_map except it handle separate coordinates and do a clean 1084 * same as insert_ob_in_map except it handles separate coordinates and does a clean
1092 * job preparing multi-part monsters 1085 * job preparing multi-part monsters.
1093 */ 1086 */
1094object * 1087object *
1095insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1088insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1096{ 1089{
1097 for (object *tmp = op->head_ (); tmp; tmp = tmp->more) 1090 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
… …
1125 */ 1118 */
1126object * 1119object *
1127insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1120insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1128{ 1121{
1129 object *tmp, *top, *floor = NULL; 1122 object *tmp, *top, *floor = NULL;
1130 sint16 x, y;
1131 1123
1132 if (QUERY_FLAG (op, FLAG_FREED)) 1124 if (QUERY_FLAG (op, FLAG_FREED))
1133 { 1125 {
1134 LOG (llevError, "Trying to insert freed object!\n"); 1126 LOG (llevError, "Trying to insert freed object!\n");
1135 return NULL; 1127 return NULL;
1136 } 1128 }
1129
1130 if (!QUERY_FLAG (op, FLAG_REMOVED))
1131 LOG (llevError, "Trying to insert already inserted object %s\n", op->debug_desc ());
1132
1133 op->remove ();
1137 1134
1138 if (!m) 1135 if (!m)
1139 { 1136 {
1140 char *dump = dump_object (op); 1137 char *dump = dump_object (op);
1141 LOG (llevError, "Trying to insert in null-map!\n%s\n", dump); 1138 LOG (llevError, "Trying to insert in null-map!\n%s\n", dump);
… …
1156#endif 1153#endif
1157 free (dump); 1154 free (dump);
1158 return op; 1155 return op;
1159 } 1156 }
1160 1157
1161 if (!QUERY_FLAG (op, FLAG_REMOVED))
1162 {
1163 char *dump = dump_object (op);
1164 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", dump);
1165 free (dump);
1166 return op;
1167 }
1168
1169 if (op->more)
1170 {
1171 /* The part may be on a different map. */
1172
1173 object *more = op->more; 1158 if (object *more = op->more)
1174 1159 {
1175 /* We really need the caller to normalise coordinates - if
1176 * we set the map, that doesn't work if the location is within
1177 * a map and this is straddling an edge. So only if coordinate
1178 * is clear wrong do we normalise it.
1179 */
1180 if (OUT_OF_REAL_MAP (more->map, more->x, more->y))
1181 more->map = get_map_from_coord (m, &more->x, &more->y);
1182 else if (!more->map)
1183 {
1184 /* For backwards compatibility - when not dealing with tiled maps,
1185 * more->map should always point to the parent.
1186 */
1187 more->map = m;
1188 }
1189
1190 if (insert_ob_in_map (more, more->map, originator, flag) == NULL) 1160 if (!insert_ob_in_map (more, m, originator, flag))
1191 { 1161 {
1192 if (!op->head) 1162 if (!op->head)
1193 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n"); 1163 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n");
1194 1164
1195 return 0; 1165 return 0;
… …
1200 1170
1201 /* Ideally, the caller figures this out. However, it complicates a lot 1171 /* Ideally, the caller figures this out. However, it complicates a lot
1202 * of areas of callers (eg, anything that uses find_free_spot would now 1172 * of areas of callers (eg, anything that uses find_free_spot would now
1203 * need extra work 1173 * need extra work
1204 */ 1174 */
1205 op->map = get_map_from_coord (m, &op->x, &op->y); 1175 if (!xy_normalise (m, op->x, op->y))
1206 x = op->x; 1176 return 0;
1207 y = op->y; 1177
1178 op->map = m;
1179 mapspace &ms = op->ms ();
1208 1180
1209 /* this has to be done after we translate the coordinates. 1181 /* this has to be done after we translate the coordinates.
1210 */ 1182 */
1211 if (op->nrof && !(flag & INS_NO_MERGE)) 1183 if (op->nrof && !(flag & INS_NO_MERGE))
1212 for (tmp = GET_MAP_OB (op->map, x, y); tmp; tmp = tmp->above) 1184 for (tmp = ms.bot; tmp; tmp = tmp->above)
1213 if (object::can_merge (op, tmp)) 1185 if (object::can_merge (op, tmp))
1214 { 1186 {
1215 op->nrof += tmp->nrof; 1187 op->nrof += tmp->nrof;
1216 tmp->destroy (); 1188 tmp->destroy ();
1217 } 1189 }
… …
1234 op->below = originator->below; 1206 op->below = originator->below;
1235 1207
1236 if (op->below) 1208 if (op->below)
1237 op->below->above = op; 1209 op->below->above = op;
1238 else 1210 else
1239 op->ms ().bot = op; 1211 ms.bot = op;
1240 1212
1241 /* since *below* originator, no need to update top */ 1213 /* since *below* originator, no need to update top */
1242 originator->below = op; 1214 originator->below = op;
1243 } 1215 }
1244 else 1216 else
1245 { 1217 {
1218 top = ms.bot;
1219
1246 /* If there are other objects, then */ 1220 /* If there are other objects, then */
1247 if ((!(flag & INS_MAP_LOAD)) && ((top = GET_MAP_OB (op->map, op->x, op->y)) != NULL)) 1221 if ((!(flag & INS_MAP_LOAD)) && top)
1248 { 1222 {
1249 object *last = 0; 1223 object *last = 0;
1250 1224
1251 /* 1225 /*
1252 * If there are multiple objects on this space, we do some trickier handling. 1226 * If there are multiple objects on this space, we do some trickier handling.
… …
1258 * once we get to them. This reduces the need to traverse over all of 1232 * once we get to them. This reduces the need to traverse over all of
1259 * them when adding another one - this saves quite a bit of cpu time 1233 * them when adding another one - this saves quite a bit of cpu time
1260 * when lots of spells are cast in one area. Currently, it is presumed 1234 * when lots of spells are cast in one area. Currently, it is presumed
1261 * that flying non pickable objects are spell objects. 1235 * that flying non pickable objects are spell objects.
1262 */ 1236 */
1263 while (top) 1237 for (top = ms.bot; top; top = top->above)
1264 { 1238 {
1265 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1239 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))
1266 floor = top; 1240 floor = top;
1267 1241
1268 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1242 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))
… …
1271 top = top->below; 1245 top = top->below;
1272 break; 1246 break;
1273 } 1247 }
1274 1248
1275 last = top; 1249 last = top;
1276 top = top->above;
1277 } 1250 }
1278 1251
1279 /* Don't want top to be NULL, so set it to the last valid object */ 1252 /* Don't want top to be NULL, so set it to the last valid object */
1280 top = last; 1253 top = last;
1281 1254
… …
1288 * Unless those objects are exits, type 66 1261 * Unless those objects are exits, type 66
1289 * If INS_ON_TOP is used, don't do this processing 1262 * If INS_ON_TOP is used, don't do this processing
1290 * Need to find the object that in fact blocks view, otherwise 1263 * Need to find the object that in fact blocks view, otherwise
1291 * stacking is a bit odd. 1264 * stacking is a bit odd.
1292 */ 1265 */
1293 if (!(flag & INS_ON_TOP) && 1266 if (!(flag & INS_ON_TOP)
1294 (get_map_flags (op->map, 0, op->x, op->y, 0, 0) & P_BLOCKSVIEW) && (op->face && !op->face->visibility)) 1267 && ms.flags () & P_BLOCKSVIEW
1268 && (op->face && !op->face->visibility))
1295 { 1269 {
1296 for (last = top; last != floor; last = last->below) 1270 for (last = top; last != floor; last = last->below)
1297 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1271 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1298 break; 1272 break;
1273
1299 /* Check to see if we found the object that blocks view, 1274 /* Check to see if we found the object that blocks view,
1300 * and make sure we have a below pointer for it so that 1275 * and make sure we have a below pointer for it so that
1301 * we can get inserted below this one, which requires we 1276 * we can get inserted below this one, which requires we
1302 * set top to the object below us. 1277 * set top to the object below us.
1303 */ 1278 */
… …
1305 top = last->below; 1280 top = last->below;
1306 } 1281 }
1307 } /* If objects on this space */ 1282 } /* If objects on this space */
1308 1283
1309 if (flag & INS_MAP_LOAD) 1284 if (flag & INS_MAP_LOAD)
1310 top = GET_MAP_TOP (op->map, op->x, op->y); 1285 top = ms.top;
1311 1286
1312 if (flag & INS_ABOVE_FLOOR_ONLY) 1287 if (flag & INS_ABOVE_FLOOR_ONLY)
1313 top = floor; 1288 top = floor;
1314 1289
1315 /* Top is the object that our object (op) is going to get inserted above. 1290 /* Top is the object that our object (op) is going to get inserted above.
1316 */ 1291 */
1317 1292
1318 /* First object on this space */ 1293 /* First object on this space */
1319 if (!top) 1294 if (!top)
1320 { 1295 {
1321 op->above = GET_MAP_OB (op->map, op->x, op->y); 1296 op->above = ms.bot;
1322 1297
1323 if (op->above) 1298 if (op->above)
1324 op->above->below = op; 1299 op->above->below = op;
1325 1300
1326 op->below = 0; 1301 op->below = 0;
1327 op->ms ().bot = op; 1302 ms.bot = op;
1328 } 1303 }
1329 else 1304 else
1330 { /* get inserted into the stack above top */ 1305 { /* get inserted into the stack above top */
1331 op->above = top->above; 1306 op->above = top->above;
1332 1307
… …
1336 op->below = top; 1311 op->below = top;
1337 top->above = op; 1312 top->above = op;
1338 } 1313 }
1339 1314
1340 if (!op->above) 1315 if (!op->above)
1341 op->ms ().top = op; 1316 ms.top = op;
1342 } /* else not INS_BELOW_ORIGINATOR */ 1317 } /* else not INS_BELOW_ORIGINATOR */
1343 1318
1344 if (op->type == PLAYER) 1319 if (op->type == PLAYER)
1345 { 1320 {
1346 op->contr->do_los = 1; 1321 op->contr->do_los = 1;
… …
1352 1327
1353 /* If we have a floor, we know the player, if any, will be above 1328 /* If we have a floor, we know the player, if any, will be above
1354 * it, so save a few ticks and start from there. 1329 * it, so save a few ticks and start from there.
1355 */ 1330 */
1356 if (!(flag & INS_MAP_LOAD)) 1331 if (!(flag & INS_MAP_LOAD))
1357 if (object *pl = op->ms ().player ()) 1332 if (object *pl = ms.player ())
1358 if (pl->contr->ns) 1333 if (pl->contr->ns)
1359 pl->contr->ns->floorbox_update (); 1334 pl->contr->ns->floorbox_update ();
1360 1335
1361 /* If this object glows, it may affect lighting conditions that are 1336 /* If this object glows, it may affect lighting conditions that are
1362 * visible to others on this map. But update_all_los is really 1337 * visible to others on this map. But update_all_los is really
… …
2591{ 2566{
2592 char flagdesc[512]; 2567 char flagdesc[512];
2593 char info2[256 * 4]; 2568 char info2[256 * 4];
2594 char *p = info; 2569 char *p = info;
2595 2570
2596 p += snprintf (p, 512, "{cnt:%d,uuid:<1,%" PRIx64 ">,name:\"%s%s%s\",flags:[%s],type:%d}", 2571 p += snprintf (p, 512, "{cnt:%d,uuid:<1,%" PRIx64 ">,name:\"%s\"%s%s,flags:[%s],type:%d}",
2597 count, uuid.seq, 2572 count, uuid.seq,
2598 &name, 2573 &name,
2599 title ? "\",title:" : "", 2574 title ? "\",title:\"" : "",
2600 title ? (const char *)title : "", 2575 title ? (const char *)title : "",
2601 flag_desc (flagdesc, 512), type); 2576 flag_desc (flagdesc, 512), type);
2602 2577
2603 if (env) 2578 if (env)
2604 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2579 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines