ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.47 by root, Thu Sep 14 22:33:59 2006 UTC vs.
Revision 1.126 by root, Mon Jan 29 15:36:25 2007 UTC

1/* 1/*
2 CrossFire, A Multiplayer game for X-windows 2 * CrossFire, A Multiplayer game for X-windows
3 3 *
4 * Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team
4 Copyright (C) 2001 Mark Wedel & Crossfire Development Team 5 * Copyright (C) 2001 Mark Wedel & Crossfire Development Team
5 Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (C) 1992 Frank Tore Johansen
6 7 *
7 This program is free software; you can redistribute it and/or modify 8 * This program is free software; you can redistribute it and/or modify
8 it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
9 the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation; either version 2 of the License, or
10 (at your option) any later version. 11 * (at your option) any later version.
11 12 *
12 This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
13 but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 GNU General Public License for more details. 16 * GNU General Public License for more details.
16 17 *
17 You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
18 along with this program; if not, write to the Free Software 19 * along with this program; if not, write to the Free Software
19 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
20 21 *
21 The authors can be reached via e-mail at <crossfire@schmorp.de> 22 * The authors can be reached via e-mail at <crossfire@schmorp.de>
22*/ 23 */
23 24
24/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects. 25/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
25 sub/add_weight will transcend the environment updating the carrying 26 sub/add_weight will transcend the environment updating the carrying
26 variable. */ 27 variable. */
27#include <global.h> 28#include <global.h>
… …
30#include <sys/uio.h> 31#include <sys/uio.h>
31#include <object.h> 32#include <object.h>
32#include <funcpoint.h> 33#include <funcpoint.h>
33#include <loader.h> 34#include <loader.h>
34 35
36#include <bitset>
37
35int nrofallocobjects = 0; 38int nrofallocobjects = 0;
36static UUID uuid; 39static UUID uuid;
37const uint64 UUID_SKIP = 1<<19; 40const uint64 UUID_SKIP = 1<<19;
38 41
39object *active_objects; /* List of active objects that need to be processed */ 42objectvec objects;
43activevec actives;
40 44
41short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 45short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
42 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1 46 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1
43}; 47};
44short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, 48short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
… …
104 _exit (1); 108 _exit (1);
105 } 109 }
106 110
107 uuid.seq = uid; 111 uuid.seq = uid;
108 write_uuid (); 112 write_uuid ();
109 LOG (llevDebug, "read UID: %lld\n", uid); 113 LOG (llevDebug, "read UID: %" PRId64 "\n", uid);
110 fclose (fp); 114 fclose (fp);
111} 115}
112 116
113UUID 117UUID
114gen_uuid () 118gen_uuid ()
… …
139 * objects with lists are rare, and lists stay short. If not, use a 143 * objects with lists are rare, and lists stay short. If not, use a
140 * different structure or at least keep the lists sorted... 144 * different structure or at least keep the lists sorted...
141 */ 145 */
142 146
143 /* For each field in wants, */ 147 /* For each field in wants, */
144 for (wants_field = wants->key_values; wants_field != NULL; wants_field = wants_field->next) 148 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)
145 { 149 {
146 key_value *has_field; 150 key_value *has_field;
147 151
148 /* Look for a field in has with the same key. */ 152 /* Look for a field in has with the same key. */
149 has_field = get_ob_key_link (has, wants_field->key); 153 has_field = get_ob_key_link (has, wants_field->key);
… …
183 * 187 *
184 * Note that this function appears a lot longer than the macro it 188 * Note that this function appears a lot longer than the macro it
185 * replaces - this is mostly for clarity - a decent compiler should hopefully 189 * replaces - this is mostly for clarity - a decent compiler should hopefully
186 * reduce this to the same efficiency. 190 * reduce this to the same efficiency.
187 * 191 *
188 * Check nrof variable *before* calling CAN_MERGE() 192 * Check nrof variable *before* calling can_merge()
189 * 193 *
190 * Improvements made with merge: Better checking on potion, and also 194 * Improvements made with merge: Better checking on potion, and also
191 * check weight 195 * check weight
192 */ 196 */
193
194bool object::can_merge (object *ob1, object *ob2) 197bool object::can_merge_slow (object *ob1, object *ob2)
195{ 198{
196 /* A couple quicksanity checks */ 199 /* A couple quicksanity checks */
197 if ((ob1 == ob2) || (ob1->type != ob2->type)) 200 if (ob1 == ob2
201 || ob1->type != ob2->type
202 || ob1->speed != ob2->speed
203 || ob1->value != ob2->value
204 || ob1->name != ob2->name)
198 return 0; 205 return 0;
199 206
200 if (ob1->speed != ob2->speed) 207 //TODO: this ain't working well, use nicer and correct overflow check
201 return 0;
202
203 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that 208 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that
204 * value could not be stored in a sint32 (which unfortunately sometimes is 209 * value could not be stored in a sint32 (which unfortunately sometimes is
205 * used to store nrof). 210 * used to store nrof).
206 */ 211 */
207 if (ob1->nrof + ob2->nrof >= 1UL << 31) 212 if (ob1->nrof + ob2->nrof >= 1UL << 31)
… …
217 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 222 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
218 223
219 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 224 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
220 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 225 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
221 226
222 227 if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any ()
223 /* the 0x400000 on flags2 is FLAG_INV_LOCK. I don't think something 228 || ob1->arch != ob2->arch
224 * being locked in inventory should prevent merging.
225 * 0x4 in flags3 is CLIENT_SENT
226 */
227 if ((ob1->arch != ob2->arch) ||
228 (ob1->flags[0] != ob2->flags[0]) ||
229 (ob1->flags[1] != ob2->flags[1]) ||
230 ((ob1->flags[2] & ~0x400000) != (ob2->flags[2] & ~0x400000)) ||
231 ((ob1->flags[3] & ~0x4) != (ob2->flags[3] & ~0x4)) ||
232 (ob1->name != ob2->name) || 229 || ob1->name != ob2->name
233 (ob1->title != ob2->title) || 230 || ob1->title != ob2->title
234 (ob1->msg != ob2->msg) || 231 || ob1->msg != ob2->msg
235 (ob1->weight != ob2->weight) || 232 || ob1->weight != ob2->weight
236 (memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist)) != 0) || 233 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
237 (memcmp (&ob1->stats, &ob2->stats, sizeof (ob1->stats)) != 0) || 234 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
238 (ob1->attacktype != ob2->attacktype) || 235 || ob1->attacktype != ob2->attacktype
239 (ob1->magic != ob2->magic) || 236 || ob1->magic != ob2->magic
240 (ob1->slaying != ob2->slaying) || 237 || ob1->slaying != ob2->slaying
241 (ob1->skill != ob2->skill) || 238 || ob1->skill != ob2->skill
242 (ob1->value != ob2->value) || 239 || ob1->value != ob2->value
243 (ob1->animation_id != ob2->animation_id) || 240 || ob1->animation_id != ob2->animation_id
244 (ob1->client_type != ob2->client_type) || 241 || ob1->client_type != ob2->client_type
245 (ob1->materialname != ob2->materialname) || 242 || ob1->materialname != ob2->materialname
246 (ob1->lore != ob2->lore) || 243 || ob1->lore != ob2->lore
247 (ob1->subtype != ob2->subtype) || 244 || ob1->subtype != ob2->subtype
248 (ob1->move_type != ob2->move_type) || 245 || ob1->move_type != ob2->move_type
249 (ob1->move_block != ob2->move_block) || 246 || ob1->move_block != ob2->move_block
250 (ob1->move_allow != ob2->move_allow) || 247 || ob1->move_allow != ob2->move_allow
251 (ob1->move_on != ob2->move_on) || 248 || ob1->move_on != ob2->move_on
252 (ob1->move_off != ob2->move_off) || (ob1->move_slow != ob2->move_slow) || (ob1->move_slow_penalty != ob2->move_slow_penalty)) 249 || ob1->move_off != ob2->move_off
250 || ob1->move_slow != ob2->move_slow
251 || ob1->move_slow_penalty != ob2->move_slow_penalty)
253 return 0; 252 return 0;
254 253
255 /* This is really a spellbook check - really, we should 254 /* This is really a spellbook check - really, we should
256 * check all objects in the inventory. 255 * check all objects in the inventory.
257 */ 256 */
… …
260 /* if one object has inventory but the other doesn't, not equiv */ 259 /* if one object has inventory but the other doesn't, not equiv */
261 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv)) 260 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv))
262 return 0; 261 return 0;
263 262
264 /* Now check to see if the two inventory objects could merge */ 263 /* Now check to see if the two inventory objects could merge */
265 if (!CAN_MERGE (ob1->inv, ob2->inv)) 264 if (!object::can_merge (ob1->inv, ob2->inv))
266 return 0; 265 return 0;
267 266
268 /* inventory ok - still need to check rest of this object to see 267 /* inventory ok - still need to check rest of this object to see
269 * if it is valid. 268 * if it is valid.
270 */ 269 */
… …
279 278
280 /* Note sure why the following is the case - either the object has to 279 /* Note sure why the following is the case - either the object has to
281 * be animated or have a very low speed. Is this an attempted monster 280 * be animated or have a very low speed. Is this an attempted monster
282 * check? 281 * check?
283 */ 282 */
284 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && FABS ((ob1)->speed) > MIN_ACTIVE_SPEED) 283 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && ob1->has_active_speed ())
285 return 0; 284 return 0;
286 285
287 switch (ob1->type) 286 switch (ob1->type)
288 { 287 {
289 case SCROLL: 288 case SCROLL:
… …
354 op = op->env; 353 op = op->env;
355 return op; 354 return op;
356} 355}
357 356
358/* 357/*
359 * Eneq(@csd.uu.se): Since we can have items buried in a character we need
360 * a better check. We basically keeping traversing up until we can't
361 * or find a player.
362 */
363
364object *
365is_player_inv (object *op)
366{
367 for (; op != NULL && op->type != PLAYER; op = op->env)
368 if (op->env == op)
369 op->env = NULL;
370 return op;
371}
372
373/*
374 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump. 358 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
375 * Some error messages. 359 * Some error messages.
376 * The result of the dump is stored in the static global errmsg array. 360 * The result of the dump is stored in the static global errmsg array.
377 */ 361 */
378 362
379void 363char *
380dump_object2 (object *op)
381{
382 errmsg[0] = 0;
383 return;
384 //TODO//D#d#
385#if 0
386 char *cp;
387
388/* object *tmp;*/
389
390 if (op->arch != NULL)
391 {
392 strcat (errmsg, "arch ");
393 strcat (errmsg, op->arch->name ? op->arch->name : "(null)");
394 strcat (errmsg, "\n");
395 if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
396 strcat (errmsg, cp);
397# if 0
398 /* Don't dump player diffs - they are too long, mostly meaningless, and
399 * will overflow the buffer.
400 * Changed so that we don't dump inventory either. This may
401 * also overflow the buffer.
402 */
403 if (op->type != PLAYER && (cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
404 strcat (errmsg, cp);
405 for (tmp = op->inv; tmp; tmp = tmp->below)
406 dump_object2 (tmp);
407# endif
408 strcat (errmsg, "end\n");
409 }
410 else
411 {
412 strcat (errmsg, "Object ");
413 if (op->name == NULL)
414 strcat (errmsg, "(null)");
415 else
416 strcat (errmsg, op->name);
417 strcat (errmsg, "\n");
418# if 0
419 if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
420 strcat (errmsg, cp);
421 for (tmp = op->inv; tmp; tmp = tmp->below)
422 dump_object2 (tmp);
423# endif
424 strcat (errmsg, "end\n");
425 }
426#endif
427}
428
429/*
430 * Dumps an object. Returns output in the static global errmsg array.
431 */
432
433void
434dump_object (object *op) 364dump_object (object *op)
435{ 365{
436 if (op == NULL) 366 if (!op)
437 { 367 return strdup ("[NULLOBJ]");
438 strcpy (errmsg, "[NULL pointer]");
439 return;
440 }
441 errmsg[0] = '\0';
442 dump_object2 (op);
443}
444 368
445void 369 object_freezer freezer;
446dump_all_objects (void) 370 save_object (freezer, op, 1);
447{ 371 return freezer.as_string ();
448 object *op;
449
450 for (op = object::first; op != NULL; op = op->next)
451 {
452 dump_object (op);
453 fprintf (logfile, "Object %d\n:%s\n", op->count, errmsg);
454 }
455} 372}
456 373
457/* 374/*
458 * get_nearest_part(multi-object, object 2) returns the part of the 375 * get_nearest_part(multi-object, object 2) returns the part of the
459 * multi-object 1 which is closest to the second object. 376 * multi-object 1 which is closest to the second object.
… …
475} 392}
476 393
477/* 394/*
478 * Returns the object which has the count-variable equal to the argument. 395 * Returns the object which has the count-variable equal to the argument.
479 */ 396 */
480
481object * 397object *
482find_object (tag_t i) 398find_object (tag_t i)
483{ 399{
484 object *op; 400 for_all_objects (op)
485
486 for (op = object::first; op != NULL; op = op->next)
487 if (op->count == i) 401 if (op->count == i)
488 break;
489 return op; 402 return op;
403
404 return 0;
490} 405}
491 406
492/* 407/*
493 * Returns the first object which has a name equal to the argument. 408 * Returns the first object which has a name equal to the argument.
494 * Used only by the patch command, but not all that useful. 409 * Used only by the patch command, but not all that useful.
495 * Enables features like "patch <name-of-other-player> food 999" 410 * Enables features like "patch <name-of-other-player> food 999"
496 */ 411 */
497
498object * 412object *
499find_object_name (const char *str) 413find_object_name (const char *str)
500{ 414{
501 shstr_cmp str_ (str); 415 shstr_cmp str_ (str);
502 object *op; 416 object *op;
503 417
504 for (op = object::first; op != NULL; op = op->next) 418 for_all_objects (op)
505 if (op->name == str_) 419 if (op->name == str_)
506 break; 420 break;
507 421
508 return op; 422 return op;
509} 423}
… …
552 } 466 }
553 467
554 op->key_values = 0; 468 op->key_values = 0;
555} 469}
556 470
557void object::clear ()
558{
559 attachable_base::clear ();
560
561 free_key_values (this);
562
563 owner = 0;
564 name = 0;
565 name_pl = 0;
566 title = 0;
567 race = 0;
568 slaying = 0;
569 skill = 0;
570 msg = 0;
571 lore = 0;
572 custom_name = 0;
573 materialname = 0;
574 contr = 0;
575 below = 0;
576 above = 0;
577 inv = 0;
578 container = 0;
579 env = 0;
580 more = 0;
581 head = 0;
582 map = 0;
583 active_next = 0;
584 active_prev = 0;
585
586 memset (static_cast<object_pod *>(this), 0, sizeof (object_pod));
587
588 SET_FLAG (this, FLAG_REMOVED);
589
590 /* What is not cleared is next, prev, and count */
591
592 expmul = 1.0;
593 face = blank_face;
594
595 if (settings.casting_time)
596 casting_time = -1;
597}
598
599void object::clone (object *destination)
600{
601 *(object_copy *)destination = *this;
602 *(object_pod *)destination = *this;
603
604 if (self || cb)
605 INVOKE_OBJECT (CLONE, this, ARG_OBJECT (destination));
606}
607
608/* 471/*
609 * copy object first frees everything allocated by the second object, 472 * copy_to first frees everything allocated by the dst object,
610 * and then copies the contends of the first object into the second 473 * and then copies the contents of itself into the second
611 * object, allocating what needs to be allocated. Basically, any 474 * object, allocating what needs to be allocated. Basically, any
612 * data that is malloc'd needs to be re-malloc/copied. Otherwise, 475 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
613 * if the first object is freed, the pointers in the new object 476 * if the first object is freed, the pointers in the new object
614 * will point at garbage. 477 * will point at garbage.
615 */ 478 */
616void 479void
617copy_object (object *op2, object *op) 480object::copy_to (object *dst)
618{ 481{
619 bool is_freed = QUERY_FLAG (op, FLAG_FREED); 482 bool is_freed = QUERY_FLAG (dst, FLAG_FREED);
620 bool is_removed = QUERY_FLAG (op, FLAG_REMOVED); 483 bool is_removed = QUERY_FLAG (dst, FLAG_REMOVED);
621 484
622 op2->clone (op); 485 *(object_copy *)dst = *this;
623 486
624 if (is_freed) 487 if (is_freed)
625 SET_FLAG (op, FLAG_FREED); 488 SET_FLAG (dst, FLAG_FREED);
489
626 if (is_removed) 490 if (is_removed)
627 SET_FLAG (op, FLAG_REMOVED); 491 SET_FLAG (dst, FLAG_REMOVED);
628 492
629 if (op2->speed < 0) 493 if (speed < 0)
630 op->speed_left = op2->speed_left - RANDOM () % 200 / 100.0; 494 dst->speed_left = speed_left - rndm ();
631 495
632 /* Copy over key_values, if any. */ 496 /* Copy over key_values, if any. */
633 if (op2->key_values) 497 if (key_values)
634 { 498 {
635 key_value *tail = 0; 499 key_value *tail = 0;
636 key_value *i; 500 key_value *i;
637 501
638 op->key_values = 0; 502 dst->key_values = 0;
639 503
640 for (i = op2->key_values; i; i = i->next) 504 for (i = key_values; i; i = i->next)
641 { 505 {
642 key_value *new_link = new key_value; 506 key_value *new_link = new key_value;
643 507
644 new_link->next = 0; 508 new_link->next = 0;
645 new_link->key = i->key; 509 new_link->key = i->key;
646 new_link->value = i->value; 510 new_link->value = i->value;
647 511
648 /* Try and be clever here, too. */ 512 /* Try and be clever here, too. */
649 if (!op->key_values) 513 if (!dst->key_values)
650 { 514 {
651 op->key_values = new_link; 515 dst->key_values = new_link;
652 tail = new_link; 516 tail = new_link;
653 } 517 }
654 else 518 else
655 { 519 {
656 tail->next = new_link; 520 tail->next = new_link;
657 tail = new_link; 521 tail = new_link;
658 } 522 }
659 } 523 }
660 } 524 }
661 525
662 update_ob_speed (op); 526 dst->set_speed (dst->speed);
527}
528
529object *
530object::clone ()
531{
532 object *neu = create ();
533 copy_to (neu);
534 return neu;
663} 535}
664 536
665/* 537/*
666 * If an object with the IS_TURNABLE() flag needs to be turned due 538 * If an object with the IS_TURNABLE() flag needs to be turned due
667 * to the closest player being on the other side, this function can 539 * to the closest player being on the other side, this function can
668 * be called to update the face variable, _and_ how it looks on the map. 540 * be called to update the face variable, _and_ how it looks on the map.
669 */ 541 */
670
671void 542void
672update_turn_face (object *op) 543update_turn_face (object *op)
673{ 544{
674 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || op->arch == NULL) 545 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || !op->arch)
675 return; 546 return;
547
676 SET_ANIMATION (op, op->direction); 548 SET_ANIMATION (op, op->direction);
677 update_object (op, UP_OBJ_FACE); 549 update_object (op, UP_OBJ_FACE);
678} 550}
679 551
680/* 552/*
681 * Updates the speed of an object. If the speed changes from 0 to another 553 * Updates the speed of an object. If the speed changes from 0 to another
682 * value, or vice versa, then add/remove the object from the active list. 554 * value, or vice versa, then add/remove the object from the active list.
683 * This function needs to be called whenever the speed of an object changes. 555 * This function needs to be called whenever the speed of an object changes.
684 */ 556 */
685void 557void
686update_ob_speed (object *op) 558object::set_speed (float speed)
687{ 559{
688 extern int arch_init; 560 if (flag [FLAG_FREED] && speed)
689
690 /* No reason putting the archetypes objects on the speed list,
691 * since they never really need to be updated.
692 */
693
694 if (QUERY_FLAG (op, FLAG_FREED) && op->speed)
695 { 561 {
696 LOG (llevError, "Object %s is freed but has speed.\n", &op->name); 562 LOG (llevError, "Object %s is freed but has speed.\n", &name);
697#ifdef MANY_CORES
698 abort ();
699#else
700 op->speed = 0; 563 speed = 0;
701#endif
702 }
703
704 if (arch_init)
705 return;
706
707 if (FABS (op->speed) > MIN_ACTIVE_SPEED)
708 { 564 }
709 /* If already on active list, don't do anything */
710 if (op->active_next || op->active_prev || op == active_objects)
711 return;
712 565
713 /* process_events() expects us to insert the object at the beginning 566 this->speed = speed;
714 * of the list. */
715 op->active_next = active_objects;
716 567
717 if (op->active_next != NULL) 568 if (has_active_speed ())
718 op->active_next->active_prev = op; 569 activate ();
719
720 active_objects = op;
721 }
722 else 570 else
723 { 571 deactivate ();
724 /* If not on the active list, nothing needs to be done */
725 if (!op->active_next && !op->active_prev && op != active_objects)
726 return;
727
728 if (op->active_prev == NULL)
729 {
730 active_objects = op->active_next;
731
732 if (op->active_next != NULL)
733 op->active_next->active_prev = NULL;
734 }
735 else
736 {
737 op->active_prev->active_next = op->active_next;
738
739 if (op->active_next)
740 op->active_next->active_prev = op->active_prev;
741 }
742
743 op->active_next = NULL;
744 op->active_prev = NULL;
745 }
746} 572}
747 573
748/* This function removes object 'op' from the list of active
749 * objects.
750 * This should only be used for style maps or other such
751 * reference maps where you don't want an object that isn't
752 * in play chewing up cpu time getting processed.
753 * The reverse of this is to call update_ob_speed, which
754 * will do the right thing based on the speed of the object.
755 */
756void
757remove_from_active_list (object *op)
758{
759 /* If not on the active list, nothing needs to be done */
760 if (!op->active_next && !op->active_prev && op != active_objects)
761 return;
762
763 if (op->active_prev == NULL)
764 {
765 active_objects = op->active_next;
766 if (op->active_next != NULL)
767 op->active_next->active_prev = NULL;
768 }
769 else
770 {
771 op->active_prev->active_next = op->active_next;
772 if (op->active_next)
773 op->active_next->active_prev = op->active_prev;
774 }
775 op->active_next = NULL;
776 op->active_prev = NULL;
777}
778
779/* 574/*
780 * update_object() updates the array which represents the map. 575 * update_object() updates the the map.
781 * It takes into account invisible objects (and represent squares covered 576 * It takes into account invisible objects (and represent squares covered
782 * by invisible objects by whatever is below them (unless it's another 577 * by invisible objects by whatever is below them (unless it's another
783 * invisible object, etc...) 578 * invisible object, etc...)
784 * If the object being updated is beneath a player, the look-window 579 * If the object being updated is beneath a player, the look-window
785 * of that player is updated (this might be a suboptimal way of 580 * of that player is updated (this might be a suboptimal way of
786 * updating that window, though, since update_object() is called _often_) 581 * updating that window, though, since update_object() is called _often_)
787 * 582 *
788 * action is a hint of what the caller believes need to be done. 583 * action is a hint of what the caller believes need to be done.
789 * For example, if the only thing that has changed is the face (due to
790 * an animation), we don't need to call update_position until that actually
791 * comes into view of a player. OTOH, many other things, like addition/removal
792 * of walls or living creatures may need us to update the flags now.
793 * current action are: 584 * current action are:
794 * UP_OBJ_INSERT: op was inserted 585 * UP_OBJ_INSERT: op was inserted
795 * UP_OBJ_REMOVE: op was removed 586 * UP_OBJ_REMOVE: op was removed
796 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update 587 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update
797 * as that is easier than trying to look at what may have changed. 588 * as that is easier than trying to look at what may have changed.
798 * UP_OBJ_FACE: only the objects face has changed. 589 * UP_OBJ_FACE: only the objects face has changed.
799 */ 590 */
800
801void 591void
802update_object (object *op, int action) 592update_object (object *op, int action)
803{ 593{
804 int update_now = 0, flags;
805 MoveType move_on, move_off, move_block, move_slow; 594 MoveType move_on, move_off, move_block, move_slow;
806 595
807 if (op == NULL) 596 if (op == NULL)
808 { 597 {
809 /* this should never happen */ 598 /* this should never happen */
810 LOG (llevDebug, "update_object() called for NULL object.\n"); 599 LOG (llevDebug, "update_object() called for NULL object.\n");
811 return; 600 return;
812 } 601 }
813 602
814 if (op->env != NULL) 603 if (op->env)
815 { 604 {
816 /* Animation is currently handled by client, so nothing 605 /* Animation is currently handled by client, so nothing
817 * to do in this case. 606 * to do in this case.
818 */ 607 */
819 return; 608 return;
… …
824 */ 613 */
825 if (!op->map || op->map->in_memory == MAP_SAVING) 614 if (!op->map || op->map->in_memory == MAP_SAVING)
826 return; 615 return;
827 616
828 /* make sure the object is within map boundaries */ 617 /* make sure the object is within map boundaries */
829 if (op->x < 0 || op->x >= MAP_WIDTH (op->map) || op->y < 0 || op->y >= MAP_HEIGHT (op->map)) 618 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
830 { 619 {
831 LOG (llevError, "update_object() called for object out of map!\n"); 620 LOG (llevError, "update_object() called for object out of map!\n");
832#ifdef MANY_CORES 621#ifdef MANY_CORES
833 abort (); 622 abort ();
834#endif 623#endif
835 return; 624 return;
836 } 625 }
837 626
838 flags = GET_MAP_FLAGS (op->map, op->x, op->y); 627 mapspace &m = op->ms ();
839 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NEED_UPDATE);
840 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
841 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
842 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
843 move_off = GET_MAP_MOVE_OFF (op->map, op->x, op->y);
844 628
629 if (!(m.flags_ & P_UPTODATE))
630 /* nop */;
845 if (action == UP_OBJ_INSERT) 631 else if (action == UP_OBJ_INSERT)
846 { 632 {
633 // this is likely overkill, TODO: revisit (schmorp)
847 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(flags & P_BLOCKSVIEW)) 634 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
848 update_now = 1;
849
850 if (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(flags & P_NO_MAGIC)) 635 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
851 update_now = 1; 636 || (op->type == PLAYER && !(m.flags_ & P_PLAYER))
852 637 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
638 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
853 if (QUERY_FLAG (op, FLAG_DAMNED) && !(flags & P_NO_CLERIC)) 639 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
854 update_now = 1;
855
856 if (QUERY_FLAG (op, FLAG_ALIVE) && !(flags & P_IS_ALIVE))
857 update_now = 1;
858
859 if (op->type == SAFE_GROUND && !(flags & P_SAFE))
860 update_now = 1;
861
862 if ((move_on | op->move_on) != move_on) 640 || (m.move_on | op->move_on ) != m.move_on
863 update_now = 1;
864
865 if ((move_off | op->move_off) != move_off) 641 || (m.move_off | op->move_off ) != m.move_off
866 update_now = 1; 642 || (m.move_slow | op->move_slow) != m.move_slow
867
868 /* This isn't perfect, but I don't expect a lot of objects to 643 /* This isn't perfect, but I don't expect a lot of objects to
869 * to have move_allow right now. 644 * to have move_allow right now.
870 */ 645 */
871 if (((move_block | op->move_block) & ~op->move_allow) != move_block) 646 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
872 update_now = 1; 647 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
873 648 m.flags_ = 0;
874 if ((move_slow | op->move_slow) != move_slow)
875 update_now = 1;
876 } 649 }
877 /* if the object is being removed, we can't make intelligent 650 /* if the object is being removed, we can't make intelligent
878 * decisions, because remove_ob can't really pass the object 651 * decisions, because remove_ob can't really pass the object
879 * that is being removed. 652 * that is being removed.
880 */ 653 */
881 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 654 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
882 update_now = 1; 655 m.flags_ = 0;
883 else if (action == UP_OBJ_FACE) 656 else if (action == UP_OBJ_FACE)
884 /* Nothing to do for that case */ ; 657 /* Nothing to do for that case */ ;
885 else 658 else
886 LOG (llevError, "update_object called with invalid action: %d\n", action); 659 LOG (llevError, "update_object called with invalid action: %d\n", action);
887 660
888 if (update_now)
889 {
890 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NO_ERROR | P_NEED_UPDATE);
891 update_position (op->map, op->x, op->y);
892 }
893
894 if (op->more != NULL) 661 if (op->more)
895 update_object (op->more, action); 662 update_object (op->more, action);
896}
897
898object::vector object::mortals;
899object::vector object::objects; // not yet used
900object *object::first;
901
902void object::free_mortals ()
903{
904 for (AUTODECL (i, mortals.begin ()); i != mortals.end ();)
905 if ((*i)->refcnt)
906 ++i; // further delay freeing
907 else
908 {
909 delete *i;
910 mortals.erase (i);
911 }
912
913 static int lastmortals = 0;//D
914
915 if (mortals.size() != lastmortals)//D
916 {
917 lastmortals = mortals.size ();//D
918 LOG (llevDebug, "%d objects in mortal queue\n", lastmortals);//D
919 }
920} 663}
921 664
922object::object () 665object::object ()
923{ 666{
924 SET_FLAG (this, FLAG_REMOVED); 667 SET_FLAG (this, FLAG_REMOVED);
… …
927 face = blank_face; 670 face = blank_face;
928} 671}
929 672
930object::~object () 673object::~object ()
931{ 674{
675 unlink ();
676
932 free_key_values (this); 677 free_key_values (this);
933} 678}
934 679
680static int object_count;
681
935void object::link () 682void object::link ()
936{ 683{
937 count = ++ob_count; 684 assert (!index);//D
938 uuid = gen_uuid (); 685 uuid = gen_uuid ();
686 count = ++object_count;
939 687
940 prev = 0; 688 refcnt_inc ();
941 next = object::first; 689 objects.insert (this);
942
943 if (object::first)
944 object::first->prev = this;
945
946 object::first = this;
947} 690}
948 691
949void object::unlink () 692void object::unlink ()
950{ 693{
951 //count = 0;//D 694 if (!index)
952 if (!prev && !next) return;//D 695 return;
953 696
954 if (this == object::first) 697 objects.erase (this);
955 object::first = next; 698 refcnt_dec ();
699}
956 700
957 /* Remove this object from the list of used objects */ 701void
958 if (prev) prev->next = next; 702object::activate ()
959 if (next) next->prev = prev; 703{
704 /* If already on active list, don't do anything */
705 if (active)
706 return;
960 707
961 prev = 0; 708 if (has_active_speed ())
962 next = 0; 709 actives.insert (this);
710}
711
712void
713object::activate_recursive ()
714{
715 activate ();
716
717 for (object *op = inv; op; op = op->below)
718 op->activate_recursive ();
719}
720
721/* This function removes object 'op' from the list of active
722 * objects.
723 * This should only be used for style maps or other such
724 * reference maps where you don't want an object that isn't
725 * in play chewing up cpu time getting processed.
726 * The reverse of this is to call update_ob_speed, which
727 * will do the right thing based on the speed of the object.
728 */
729void
730object::deactivate ()
731{
732 /* If not on the active list, nothing needs to be done */
733 if (!active)
734 return;
735
736 actives.erase (this);
737}
738
739void
740object::deactivate_recursive ()
741{
742 for (object *op = inv; op; op = op->below)
743 op->deactivate_recursive ();
744
745 deactivate ();
746}
747
748void
749object::set_flag_inv (int flag, int value)
750{
751 for (object *op = inv; op; op = op->below)
752 {
753 op->flag [flag] = value;
754 op->set_flag_inv (flag, value);
755 }
756}
757
758/*
759 * Remove and free all objects in the inventory of the given object.
760 * object.c ?
761 */
762void
763object::destroy_inv (bool drop_to_ground)
764{
765 // need to check first, because the checks below might segfault
766 // as we might be on an invalid mapspace and crossfire code
767 // is too buggy to ensure that the inventory is empty.
768 // corollary: if you create arrows etc. with stuff in tis inventory,
769 // cf will crash below with off-map x and y
770 if (!inv)
771 return;
772
773 /* Only if the space blocks everything do we not process -
774 * if some form of movement is allowed, let objects
775 * drop on that space.
776 */
777 if (!drop_to_ground
778 || !map
779 || map->in_memory != MAP_IN_MEMORY
780 || map->nodrop
781 || ms ().move_block == MOVE_ALL)
782 {
783 while (inv)
784 {
785 inv->destroy_inv (drop_to_ground);
786 inv->destroy ();
787 }
788 }
789 else
790 { /* Put objects in inventory onto this space */
791 while (inv)
792 {
793 object *op = inv;
794
795 if (op->flag [FLAG_STARTEQUIP]
796 || op->flag [FLAG_NO_DROP]
797 || op->type == RUNE
798 || op->type == TRAP
799 || op->flag [FLAG_IS_A_TEMPLATE]
800 || op->flag [FLAG_DESTROY_ON_DEATH])
801 op->destroy ();
802 else
803 map->insert (op, x, y);
804 }
805 }
963} 806}
964 807
965object *object::create () 808object *object::create ()
966{ 809{
967 object *op = new object; 810 object *op = new object;
968 op->link (); 811 op->link ();
969 return op; 812 return op;
970} 813}
971 814
972/* 815void
973 * free_object() frees everything allocated by an object, removes 816object::do_destroy ()
974 * it from the list of used objects, and puts it on the list of
975 * free objects. The IS_FREED() flag is set in the object.
976 * The object must have been removed by remove_ob() first for
977 * this function to succeed.
978 *
979 * If free_inventory is set, free inventory as well. Else drop items in
980 * inventory to the ground.
981 */
982void object::free (bool free_inventory)
983{ 817{
984 if (QUERY_FLAG (this, FLAG_FREED)) 818 attachable::do_destroy ();
985 return;
986 819
987 if (QUERY_FLAG (this, FLAG_FRIENDLY)) 820 if (flag [FLAG_IS_LINKED])
821 remove_button_link (this);
822
823 if (flag [FLAG_FRIENDLY])
824 {
988 remove_friendly_object (this); 825 remove_friendly_object (this);
989 826
990 if (!QUERY_FLAG (this, FLAG_REMOVED)) 827 if (type == GOLEM
828 && owner
829 && owner->type == PLAYER
830 && owner->contr->ranges[range_golem] == this)
831 owner->contr->ranges[range_golem] = 0;
832 }
833
834 if (!flag [FLAG_REMOVED])
991 remove_ob (this); 835 remove ();
992 836
993 SET_FLAG (this, FLAG_FREED); 837 destroy_inv (true);
838
839 deactivate ();
840 unlink ();
841
842 flag [FLAG_FREED] = 1;
843
844 // hack to ensure that freed objects still have a valid map
845 {
846 static maptile *freed_map; // freed objects are moved here to avoid crashes
847
848 if (!freed_map)
849 {
850 freed_map = new maptile;
851
852 freed_map->name = "/internal/freed_objects_map";
853 freed_map->width = 3;
854 freed_map->height = 3;
855
856 freed_map->alloc ();
857 freed_map->in_memory = MAP_IN_MEMORY;
858 }
859
860 map = freed_map;
861 x = 1;
862 y = 1;
863 }
864
865 head = 0;
994 866
995 if (more) 867 if (more)
996 { 868 {
997 more->free (free_inventory); 869 more->destroy ();
998 more = 0; 870 more = 0;
999 }
1000
1001 if (inv)
1002 {
1003 /* Only if the space blocks everything do we not process -
1004 * if some form of movement is allowed, let objects
1005 * drop on that space.
1006 */
1007 if (free_inventory || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL)
1008 {
1009 object *op = inv;
1010
1011 while (op)
1012 {
1013 object *tmp = op->below;
1014 op->free (free_inventory);
1015 op = tmp;
1016 }
1017 }
1018 else
1019 { /* Put objects in inventory onto this space */
1020 object *op = inv;
1021
1022 while (op)
1023 {
1024 object *tmp = op->below;
1025
1026 remove_ob (op);
1027
1028 if (QUERY_FLAG (op, FLAG_STARTEQUIP)
1029 || QUERY_FLAG (op, FLAG_NO_DROP) || op->type == RUNE || op->type == TRAP || QUERY_FLAG (op, FLAG_IS_A_TEMPLATE))
1030 free_object (op);
1031 else
1032 {
1033 op->x = x;
1034 op->y = y;
1035 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
1036 }
1037
1038 op = tmp;
1039 }
1040 }
1041 } 871 }
1042 872
1043 // clear those pointers that likely might have circular references to us 873 // clear those pointers that likely might have circular references to us
1044 owner = 0; 874 owner = 0;
1045 enemy = 0; 875 enemy = 0;
1046 attacked_by = 0; 876 attacked_by = 0;
877}
1047 878
1048 /* Remove object from the active list */ 879void
1049 speed = 0; 880object::destroy (bool destroy_inventory)
1050 update_ob_speed (this); 881{
882 if (destroyed ())
883 return;
1051 884
1052 unlink (); 885 if (destroy_inventory)
886 destroy_inv (false);
1053 887
1054 mortals.push_back (this); 888 attachable::destroy ();
1055} 889}
1056 890
1057/* 891/*
1058 * sub_weight() recursively (outwards) subtracts a number from the 892 * sub_weight() recursively (outwards) subtracts a number from the
1059 * weight of an object (and what is carried by it's environment(s)). 893 * weight of an object (and what is carried by it's environment(s)).
1060 */ 894 */
1061
1062void 895void
1063sub_weight (object *op, signed long weight) 896sub_weight (object *op, signed long weight)
1064{ 897{
1065 while (op != NULL) 898 while (op != NULL)
1066 { 899 {
… …
1070 op->carrying -= weight; 903 op->carrying -= weight;
1071 op = op->env; 904 op = op->env;
1072 } 905 }
1073} 906}
1074 907
1075/* remove_ob(op): 908/* op->remove ():
1076 * This function removes the object op from the linked list of objects 909 * This function removes the object op from the linked list of objects
1077 * which it is currently tied to. When this function is done, the 910 * which it is currently tied to. When this function is done, the
1078 * object will have no environment. If the object previously had an 911 * object will have no environment. If the object previously had an
1079 * environment, the x and y coordinates will be updated to 912 * environment, the x and y coordinates will be updated to
1080 * the previous environment. 913 * the previous environment.
1081 * Beware: This function is called from the editor as well!
1082 */ 914 */
1083
1084void 915void
1085remove_ob (object *op) 916object::remove_slow ()
1086{ 917{
1087 object *tmp, *last = 0; 918 object *tmp, *last = 0;
1088 object *otmp; 919 object *otmp;
1089 920
1090 tag_t tag;
1091 int check_walk_off;
1092 mapstruct *m;
1093
1094 sint16 x, y;
1095
1096 if (QUERY_FLAG (op, FLAG_REMOVED)) 921 if (QUERY_FLAG (this, FLAG_REMOVED))
1097 return; 922 return;
1098 923
1099 SET_FLAG (op, FLAG_REMOVED); 924 SET_FLAG (this, FLAG_REMOVED);
925 INVOKE_OBJECT (REMOVE, this);
1100 926
1101 if (op->more != NULL) 927 if (more)
1102 remove_ob (op->more); 928 more->remove ();
1103 929
1104 /* 930 /*
1105 * In this case, the object to be removed is in someones 931 * In this case, the object to be removed is in someones
1106 * inventory. 932 * inventory.
1107 */ 933 */
1108 if (op->env != NULL) 934 if (env)
1109 { 935 {
1110 if (op->nrof) 936 if (nrof)
1111 sub_weight (op->env, op->weight * op->nrof); 937 sub_weight (env, weight * nrof);
1112 else 938 else
1113 sub_weight (op->env, op->weight + op->carrying); 939 sub_weight (env, weight + carrying);
1114 940
1115 /* NO_FIX_PLAYER is set when a great many changes are being 941 /* NO_FIX_PLAYER is set when a great many changes are being
1116 * made to players inventory. If set, avoiding the call 942 * made to players inventory. If set, avoiding the call
1117 * to save cpu time. 943 * to save cpu time.
1118 */ 944 */
1119 if ((otmp = is_player_inv (op->env)) != NULL && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 945 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1120 fix_player (otmp); 946 otmp->update_stats ();
1121 947
1122 if (op->above != NULL) 948 if (above)
1123 op->above->below = op->below; 949 above->below = below;
1124 else 950 else
1125 op->env->inv = op->below; 951 env->inv = below;
1126 952
1127 if (op->below != NULL) 953 if (below)
1128 op->below->above = op->above; 954 below->above = above;
1129 955
1130 /* we set up values so that it could be inserted into 956 /* we set up values so that it could be inserted into
1131 * the map, but we don't actually do that - it is up 957 * the map, but we don't actually do that - it is up
1132 * to the caller to decide what we want to do. 958 * to the caller to decide what we want to do.
1133 */ 959 */
1134 op->x = op->env->x, op->y = op->env->y; 960 x = env->x, y = env->y;
1135 op->map = op->env->map; 961 map = env->map;
1136 op->above = NULL, op->below = NULL; 962 above = 0, below = 0;
1137 op->env = NULL; 963 env = 0;
1138 } 964 }
1139 else if (op->map) 965 else if (map)
1140 { 966 {
1141 x = op->x; 967 if (type == PLAYER)
1142 y = op->y;
1143 m = get_map_from_coord (op->map, &x, &y);
1144
1145 if (!m)
1146 { 968 {
1147 LOG (llevError, "remove_ob called when object was on map but appears to not be within valid coordinates? %s (%d,%d)\n", 969 --map->players;
1148 op->map->path, op->x, op->y); 970 map->touch ();
1149 /* in old days, we used to set x and y to 0 and continue.
1150 * it seems if we get into this case, something is probablye
1151 * screwed up and should be fixed.
1152 */
1153 abort ();
1154 } 971 }
1155 972
1156 if (op->map != m) 973 map->dirty = true;
1157 LOG (llevDebug, "remove_ob: Object not really on map it claimed to be on? %s != %s, %d,%d != %d,%d\n", 974 mapspace &ms = this->ms ();
1158 op->map->path, m->path, op->x, op->y, x, y);
1159
1160 /* Re did the following section of code - it looks like it had
1161 * lots of logic for things we no longer care about
1162 */
1163 975
1164 /* link the object above us */ 976 /* link the object above us */
1165 if (op->above) 977 if (above)
1166 op->above->below = op->below; 978 above->below = below;
1167 else 979 else
1168 SET_MAP_TOP (m, x, y, op->below); /* we were top, set new top */ 980 ms.top = below; /* we were top, set new top */
1169 981
1170 /* Relink the object below us, if there is one */ 982 /* Relink the object below us, if there is one */
1171 if (op->below) 983 if (below)
1172 op->below->above = op->above; 984 below->above = above;
1173 else 985 else
1174 { 986 {
1175 /* Nothing below, which means we need to relink map object for this space 987 /* Nothing below, which means we need to relink map object for this space
1176 * use translated coordinates in case some oddness with map tiling is 988 * use translated coordinates in case some oddness with map tiling is
1177 * evident 989 * evident
1178 */ 990 */
1179 if (GET_MAP_OB (m, x, y) != op) 991 if (GET_MAP_OB (map, x, y) != this)
1180 {
1181 dump_object (op);
1182 LOG (llevError,
1183 "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", errmsg); 992 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1184 dump_object (GET_MAP_OB (m, x, y));
1185 LOG (llevError, "%s\n", errmsg);
1186 }
1187 993
1188 SET_MAP_OB (m, x, y, op->above); /* goes on above it. */ 994 ms.bot = above; /* goes on above it. */
1189 } 995 }
1190 996
1191 op->above = 0; 997 above = 0;
1192 op->below = 0; 998 below = 0;
1193 999
1194 if (op->map->in_memory == MAP_SAVING) 1000 if (map->in_memory == MAP_SAVING)
1195 return; 1001 return;
1196 1002
1197 tag = op->count; 1003 int check_walk_off = !flag [FLAG_NO_APPLY];
1198 check_walk_off = !QUERY_FLAG (op, FLAG_NO_APPLY);
1199 1004
1200 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1005 for (tmp = ms.bot; tmp; tmp = tmp->above)
1201 { 1006 {
1202 /* No point updating the players look faces if he is the object 1007 /* No point updating the players look faces if he is the object
1203 * being removed. 1008 * being removed.
1204 */ 1009 */
1205 1010
1206 if (tmp->type == PLAYER && tmp != op) 1011 if (tmp->type == PLAYER && tmp != this)
1207 { 1012 {
1208 /* If a container that the player is currently using somehow gets 1013 /* If a container that the player is currently using somehow gets
1209 * removed (most likely destroyed), update the player view 1014 * removed (most likely destroyed), update the player view
1210 * appropriately. 1015 * appropriately.
1211 */ 1016 */
1212 if (tmp->container == op) 1017 if (tmp->container == this)
1213 { 1018 {
1214 CLEAR_FLAG (op, FLAG_APPLIED); 1019 flag [FLAG_APPLIED] = 0;
1215 tmp->container = NULL; 1020 tmp->container = 0;
1216 } 1021 }
1217 1022
1218 tmp->contr->socket.update_look = 1; 1023 if (tmp->contr->ns)
1024 tmp->contr->ns->floorbox_update ();
1219 } 1025 }
1220 1026
1221 /* See if player moving off should effect something */ 1027 /* See if object moving off should effect something */
1222 if (check_walk_off && ((op->move_type & tmp->move_off) && (op->move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1028 if (check_walk_off
1029 && ((move_type & tmp->move_off)
1030 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0))
1223 { 1031 {
1224 move_apply (tmp, op, NULL); 1032 move_apply (tmp, this, 0);
1225 1033
1226 if (was_destroyed (op, tag)) 1034 if (destroyed ())
1227 {
1228 LOG (llevError, "BUG: remove_ob(): name %s, archname %s destroyed " "leaving object\n", &tmp->name, &tmp->arch->name); 1035 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1229 }
1230 } 1036 }
1231 1037
1232 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */ 1038 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */
1233 1039 //TODO: why is this horrible hacka fix? get rid of this code=bug! (schmorp)
1234 if (tmp->above == tmp) 1040 if (tmp->above == tmp)
1235 tmp->above = NULL; 1041 tmp->above = 0;
1236 1042
1237 last = tmp; 1043 last = tmp;
1238 } 1044 }
1239 1045
1240 /* last == NULL of there are no objects on this space */ 1046 /* last == NULL if there are no objects on this space */
1047 //TODO: this makes little sense, why only update the topmost object?
1241 if (last == NULL) 1048 if (!last)
1242 { 1049 map->at (x, y).flags_ = 0;
1243 /* set P_NEED_UPDATE, otherwise update_position will complain. In theory,
1244 * we could preserve the flags (GET_MAP_FLAGS), but update_position figures
1245 * those out anyways, and if there are any flags set right now, they won't
1246 * be correct anyways.
1247 */
1248 SET_MAP_FLAGS (op->map, op->x, op->y, P_NEED_UPDATE);
1249 update_position (op->map, op->x, op->y);
1250 }
1251 else 1050 else
1252 update_object (last, UP_OBJ_REMOVE); 1051 update_object (last, UP_OBJ_REMOVE);
1253 1052
1254 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) || (op->glow_radius != 0)) 1053 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1255 update_all_los (op->map, op->x, op->y); 1054 update_all_los (map, x, y);
1256 } 1055 }
1257} 1056}
1258 1057
1259/* 1058/*
1260 * merge_ob(op,top): 1059 * merge_ob(op,top):
… …
1268merge_ob (object *op, object *top) 1067merge_ob (object *op, object *top)
1269{ 1068{
1270 if (!op->nrof) 1069 if (!op->nrof)
1271 return 0; 1070 return 0;
1272 1071
1273 if (top == NULL) 1072 if (top)
1274 for (top = op; top != NULL && top->above != NULL; top = top->above); 1073 for (top = op; top && top->above; top = top->above)
1074 ;
1275 1075
1276 for (; top != NULL; top = top->below) 1076 for (; top; top = top->below)
1277 { 1077 {
1278 if (top == op) 1078 if (top == op)
1279 continue; 1079 continue;
1280 if (CAN_MERGE (op, top)) 1080
1081 if (object::can_merge (op, top))
1281 { 1082 {
1282 top->nrof += op->nrof; 1083 top->nrof += op->nrof;
1283 1084
1284/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/ 1085/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/
1285 op->weight = 0; /* Don't want any adjustements now */ 1086 op->weight = 0; /* Don't want any adjustements now */
1286 remove_ob (op); 1087 op->destroy ();
1287 free_object (op);
1288 return top; 1088 return top;
1289 } 1089 }
1290 } 1090 }
1291 1091
1292 return 0; 1092 return 0;
1293} 1093}
1294 1094
1295/* 1095/*
1296 * same as insert_ob_in_map except it handle separate coordinates and do a clean 1096 * same as insert_ob_in_map except it handles separate coordinates and does a clean
1297 * job preparing multi-part monsters 1097 * job preparing multi-part monsters.
1298 */ 1098 */
1299object * 1099object *
1300insert_ob_in_map_at (object *op, mapstruct *m, object *originator, int flag, int x, int y) 1100insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1301{ 1101{
1302 object *tmp;
1303
1304 if (op->head)
1305 op = op->head;
1306
1307 for (tmp = op; tmp; tmp = tmp->more) 1102 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1308 { 1103 {
1309 tmp->x = x + tmp->arch->clone.x; 1104 tmp->x = x + tmp->arch->clone.x;
1310 tmp->y = y + tmp->arch->clone.y; 1105 tmp->y = y + tmp->arch->clone.y;
1311 } 1106 }
1312 1107
… …
1331 * Return value: 1126 * Return value:
1332 * new object if 'op' was merged with other object 1127 * new object if 'op' was merged with other object
1333 * NULL if 'op' was destroyed 1128 * NULL if 'op' was destroyed
1334 * just 'op' otherwise 1129 * just 'op' otherwise
1335 */ 1130 */
1336
1337object * 1131object *
1338insert_ob_in_map (object *op, mapstruct *m, object *originator, int flag) 1132insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1339{ 1133{
1340 object *tmp, *top, *floor = NULL; 1134 object *tmp, *top, *floor = NULL;
1341 sint16 x, y;
1342 1135
1343 if (QUERY_FLAG (op, FLAG_FREED)) 1136 if (QUERY_FLAG (op, FLAG_FREED))
1344 { 1137 {
1345 LOG (llevError, "Trying to insert freed object!\n"); 1138 LOG (llevError, "Trying to insert freed object!\n");
1346 return NULL; 1139 return NULL;
1347 } 1140 }
1348 1141
1349 if (m == NULL) 1142 if (!QUERY_FLAG (op, FLAG_REMOVED))
1143 LOG (llevError, "Trying to insert already inserted object %s\n", op->debug_desc ());
1144
1145 op->remove ();
1146
1147 if (!m)
1350 { 1148 {
1351 dump_object (op); 1149 char *dump = dump_object (op);
1352 LOG (llevError, "Trying to insert in null-map!\n%s\n", errmsg); 1150 LOG (llevError, "Trying to insert in null-map!\n%s\n", dump);
1151 free (dump);
1353 return op; 1152 return op;
1354 } 1153 }
1355 1154
1356 if (out_of_map (m, op->x, op->y)) 1155 if (out_of_map (m, op->x, op->y))
1357 { 1156 {
1358 dump_object (op); 1157 char *dump = dump_object (op);
1359 LOG (llevError, "Trying to insert object outside the map.\n%s\n", errmsg); 1158 LOG (llevError, "Trying to insert object outside the map.\n%s\n", dump);
1360#ifdef MANY_CORES 1159#ifdef MANY_CORES
1361 /* Better to catch this here, as otherwise the next use of this object 1160 /* Better to catch this here, as otherwise the next use of this object
1362 * is likely to cause a crash. Better to find out where it is getting 1161 * is likely to cause a crash. Better to find out where it is getting
1363 * improperly inserted. 1162 * improperly inserted.
1364 */ 1163 */
1365 abort (); 1164 abort ();
1366#endif 1165#endif
1166 free (dump);
1367 return op; 1167 return op;
1368 } 1168 }
1369 1169
1370 if (!QUERY_FLAG (op, FLAG_REMOVED))
1371 {
1372 dump_object (op);
1373 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", errmsg);
1374 return op;
1375 }
1376
1377 if (op->more != NULL)
1378 {
1379 /* The part may be on a different map. */
1380
1381 object *more = op->more; 1170 if (object *more = op->more)
1382 1171 {
1383 /* We really need the caller to normalize coordinates - if
1384 * we set the map, that doesn't work if the location is within
1385 * a map and this is straddling an edge. So only if coordinate
1386 * is clear wrong do we normalize it.
1387 */
1388 if (OUT_OF_REAL_MAP (more->map, more->x, more->y))
1389 more->map = get_map_from_coord (m, &more->x, &more->y);
1390 else if (!more->map)
1391 {
1392 /* For backwards compatibility - when not dealing with tiled maps,
1393 * more->map should always point to the parent.
1394 */
1395 more->map = m;
1396 }
1397
1398 if (insert_ob_in_map (more, more->map, originator, flag) == NULL) 1172 if (!insert_ob_in_map (more, m, originator, flag))
1399 { 1173 {
1400 if (!op->head) 1174 if (!op->head)
1401 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n"); 1175 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n");
1402 1176
1403 return NULL; 1177 return 0;
1404 } 1178 }
1405 } 1179 }
1406 1180
1407 CLEAR_FLAG (op, FLAG_REMOVED); 1181 CLEAR_FLAG (op, FLAG_REMOVED);
1408 1182
1409 /* Ideally, the caller figures this out. However, it complicates a lot 1183 /* Ideally, the caller figures this out. However, it complicates a lot
1410 * of areas of callers (eg, anything that uses find_free_spot would now 1184 * of areas of callers (eg, anything that uses find_free_spot would now
1411 * need extra work 1185 * need extra work
1412 */ 1186 */
1413 op->map = get_map_from_coord (m, &op->x, &op->y); 1187 if (!xy_normalise (m, op->x, op->y))
1414 x = op->x; 1188 return 0;
1415 y = op->y; 1189
1190 op->map = m;
1191 mapspace &ms = op->ms ();
1416 1192
1417 /* this has to be done after we translate the coordinates. 1193 /* this has to be done after we translate the coordinates.
1418 */ 1194 */
1419 if (op->nrof && !(flag & INS_NO_MERGE)) 1195 if (op->nrof && !(flag & INS_NO_MERGE))
1420 for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above) 1196 for (tmp = ms.bot; tmp; tmp = tmp->above)
1421 if (CAN_MERGE (op, tmp)) 1197 if (object::can_merge (op, tmp))
1422 { 1198 {
1423 op->nrof += tmp->nrof; 1199 op->nrof += tmp->nrof;
1424 remove_ob (tmp); 1200 tmp->destroy ();
1425 free_object (tmp);
1426 } 1201 }
1427 1202
1428 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1203 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1429 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1204 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1430 1205
… …
1443 op->below = originator->below; 1218 op->below = originator->below;
1444 1219
1445 if (op->below) 1220 if (op->below)
1446 op->below->above = op; 1221 op->below->above = op;
1447 else 1222 else
1448 SET_MAP_OB (op->map, op->x, op->y, op); 1223 ms.bot = op;
1449 1224
1450 /* since *below* originator, no need to update top */ 1225 /* since *below* originator, no need to update top */
1451 originator->below = op; 1226 originator->below = op;
1452 } 1227 }
1453 else 1228 else
1454 { 1229 {
1230 top = ms.bot;
1231
1455 /* If there are other objects, then */ 1232 /* If there are other objects, then */
1456 if ((!(flag & INS_MAP_LOAD)) && ((top = GET_MAP_OB (op->map, op->x, op->y)) != NULL)) 1233 if ((!(flag & INS_MAP_LOAD)) && top)
1457 { 1234 {
1458 object *last = NULL; 1235 object *last = 0;
1459 1236
1460 /* 1237 /*
1461 * If there are multiple objects on this space, we do some trickier handling. 1238 * If there are multiple objects on this space, we do some trickier handling.
1462 * We've already dealt with merging if appropriate. 1239 * We've already dealt with merging if appropriate.
1463 * Generally, we want to put the new object on top. But if 1240 * Generally, we want to put the new object on top. But if
… …
1467 * once we get to them. This reduces the need to traverse over all of 1244 * once we get to them. This reduces the need to traverse over all of
1468 * them when adding another one - this saves quite a bit of cpu time 1245 * them when adding another one - this saves quite a bit of cpu time
1469 * when lots of spells are cast in one area. Currently, it is presumed 1246 * when lots of spells are cast in one area. Currently, it is presumed
1470 * that flying non pickable objects are spell objects. 1247 * that flying non pickable objects are spell objects.
1471 */ 1248 */
1472 1249 for (top = ms.bot; top; top = top->above)
1473 while (top != NULL)
1474 { 1250 {
1475 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1251 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))
1476 floor = top; 1252 floor = top;
1477 1253
1478 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1254 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))
… …
1481 top = top->below; 1257 top = top->below;
1482 break; 1258 break;
1483 } 1259 }
1484 1260
1485 last = top; 1261 last = top;
1486 top = top->above;
1487 } 1262 }
1488 1263
1489 /* Don't want top to be NULL, so set it to the last valid object */ 1264 /* Don't want top to be NULL, so set it to the last valid object */
1490 top = last; 1265 top = last;
1491 1266
… …
1498 * Unless those objects are exits, type 66 1273 * Unless those objects are exits, type 66
1499 * If INS_ON_TOP is used, don't do this processing 1274 * If INS_ON_TOP is used, don't do this processing
1500 * Need to find the object that in fact blocks view, otherwise 1275 * Need to find the object that in fact blocks view, otherwise
1501 * stacking is a bit odd. 1276 * stacking is a bit odd.
1502 */ 1277 */
1503 if (!(flag & INS_ON_TOP) && 1278 if (!(flag & INS_ON_TOP)
1504 (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_BLOCKSVIEW) && (op->face && !op->face->visibility)) 1279 && ms.flags () & P_BLOCKSVIEW
1280 && (op->face && !op->face->visibility))
1505 { 1281 {
1506 for (last = top; last != floor; last = last->below) 1282 for (last = top; last != floor; last = last->below)
1507 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1283 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1508 break; 1284 break;
1285
1509 /* Check to see if we found the object that blocks view, 1286 /* Check to see if we found the object that blocks view,
1510 * and make sure we have a below pointer for it so that 1287 * and make sure we have a below pointer for it so that
1511 * we can get inserted below this one, which requires we 1288 * we can get inserted below this one, which requires we
1512 * set top to the object below us. 1289 * set top to the object below us.
1513 */ 1290 */
… …
1515 top = last->below; 1292 top = last->below;
1516 } 1293 }
1517 } /* If objects on this space */ 1294 } /* If objects on this space */
1518 1295
1519 if (flag & INS_MAP_LOAD) 1296 if (flag & INS_MAP_LOAD)
1520 top = GET_MAP_TOP (op->map, op->x, op->y); 1297 top = ms.top;
1521 1298
1522 if (flag & INS_ABOVE_FLOOR_ONLY) 1299 if (flag & INS_ABOVE_FLOOR_ONLY)
1523 top = floor; 1300 top = floor;
1524 1301
1525 /* Top is the object that our object (op) is going to get inserted above. 1302 /* Top is the object that our object (op) is going to get inserted above.
1526 */ 1303 */
1527 1304
1528 /* First object on this space */ 1305 /* First object on this space */
1529 if (!top) 1306 if (!top)
1530 { 1307 {
1531 op->above = GET_MAP_OB (op->map, op->x, op->y); 1308 op->above = ms.bot;
1532 1309
1533 if (op->above) 1310 if (op->above)
1534 op->above->below = op; 1311 op->above->below = op;
1535 1312
1536 op->below = NULL; 1313 op->below = 0;
1537 SET_MAP_OB (op->map, op->x, op->y, op); 1314 ms.bot = op;
1538 } 1315 }
1539 else 1316 else
1540 { /* get inserted into the stack above top */ 1317 { /* get inserted into the stack above top */
1541 op->above = top->above; 1318 op->above = top->above;
1542 1319
… …
1545 1322
1546 op->below = top; 1323 op->below = top;
1547 top->above = op; 1324 top->above = op;
1548 } 1325 }
1549 1326
1550 if (op->above == NULL) 1327 if (!op->above)
1551 SET_MAP_TOP (op->map, op->x, op->y, op); 1328 ms.top = op;
1552 } /* else not INS_BELOW_ORIGINATOR */ 1329 } /* else not INS_BELOW_ORIGINATOR */
1553 1330
1554 if (op->type == PLAYER) 1331 if (op->type == PLAYER)
1332 {
1555 op->contr->do_los = 1; 1333 op->contr->do_los = 1;
1334 ++op->map->players;
1335 op->map->touch ();
1336 }
1337
1338 op->map->dirty = true;
1556 1339
1557 /* If we have a floor, we know the player, if any, will be above 1340 /* If we have a floor, we know the player, if any, will be above
1558 * it, so save a few ticks and start from there. 1341 * it, so save a few ticks and start from there.
1559 */ 1342 */
1560 if (!(flag & INS_MAP_LOAD)) 1343 if (!(flag & INS_MAP_LOAD))
1561 for (tmp = floor ? floor : GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1344 if (object *pl = ms.player ())
1562 if (tmp->type == PLAYER) 1345 if (pl->contr->ns)
1563 tmp->contr->socket.update_look = 1; 1346 pl->contr->ns->floorbox_update ();
1564 1347
1565 /* If this object glows, it may affect lighting conditions that are 1348 /* If this object glows, it may affect lighting conditions that are
1566 * visible to others on this map. But update_all_los is really 1349 * visible to others on this map. But update_all_los is really
1567 * an inefficient way to do this, as it means los for all players 1350 * an inefficient way to do this, as it means los for all players
1568 * on the map will get recalculated. The players could very well 1351 * on the map will get recalculated. The players could very well
1569 * be far away from this change and not affected in any way - 1352 * be far away from this change and not affected in any way -
1570 * this should get redone to only look for players within range, 1353 * this should get redone to only look for players within range,
1571 * or just updating the P_NEED_UPDATE for spaces within this area 1354 * or just updating the P_UPTODATE for spaces within this area
1572 * of effect may be sufficient. 1355 * of effect may be sufficient.
1573 */ 1356 */
1574 if (MAP_DARKNESS (op->map) && (op->glow_radius != 0)) 1357 if (op->map->darkness && (op->glow_radius != 0))
1575 update_all_los (op->map, op->x, op->y); 1358 update_all_los (op->map, op->x, op->y);
1576 1359
1577 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1360 /* updates flags (blocked, alive, no magic, etc) for this map space */
1578 update_object (op, UP_OBJ_INSERT); 1361 update_object (op, UP_OBJ_INSERT);
1579 1362
1363 INVOKE_OBJECT (INSERT, op);
1364
1580 /* Don't know if moving this to the end will break anything. However, 1365 /* Don't know if moving this to the end will break anything. However,
1581 * we want to have update_look set above before calling this. 1366 * we want to have floorbox_update called before calling this.
1582 * 1367 *
1583 * check_move_on() must be after this because code called from 1368 * check_move_on() must be after this because code called from
1584 * check_move_on() depends on correct map flags (so functions like 1369 * check_move_on() depends on correct map flags (so functions like
1585 * blocked() and wall() work properly), and these flags are updated by 1370 * blocked() and wall() work properly), and these flags are updated by
1586 * update_object(). 1371 * update_object().
… …
1588 1373
1589 /* if this is not the head or flag has been passed, don't check walk on status */ 1374 /* if this is not the head or flag has been passed, don't check walk on status */
1590 if (!(flag & INS_NO_WALK_ON) && !op->head) 1375 if (!(flag & INS_NO_WALK_ON) && !op->head)
1591 { 1376 {
1592 if (check_move_on (op, originator)) 1377 if (check_move_on (op, originator))
1593 return NULL; 1378 return 0;
1594 1379
1595 /* If we are a multi part object, lets work our way through the check 1380 /* If we are a multi part object, lets work our way through the check
1596 * walk on's. 1381 * walk on's.
1597 */ 1382 */
1598 for (tmp = op->more; tmp != NULL; tmp = tmp->more) 1383 for (tmp = op->more; tmp != NULL; tmp = tmp->more)
1599 if (check_move_on (tmp, originator)) 1384 if (check_move_on (tmp, originator))
1600 return NULL; 1385 return 0;
1601 } 1386 }
1602 1387
1603 return op; 1388 return op;
1604} 1389}
1605 1390
1606/* this function inserts an object in the map, but if it 1391/* this function inserts an object in the map, but if it
1607 * finds an object of its own type, it'll remove that one first. 1392 * finds an object of its own type, it'll remove that one first.
1608 * op is the object to insert it under: supplies x and the map. 1393 * op is the object to insert it under: supplies x and the map.
1609 */ 1394 */
1610void 1395void
1611replace_insert_ob_in_map (const char *arch_string, object *op) 1396replace_insert_ob_in_map (const char *arch_string, object *op)
1612{ 1397{
1613 object * 1398 object *tmp, *tmp1;
1614 tmp;
1615 object *
1616 tmp1;
1617 1399
1618 /* first search for itself and remove any old instances */ 1400 /* first search for itself and remove any old instances */
1619 1401
1620 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1402 for (tmp = op->ms ().bot; tmp; tmp = tmp->above)
1621 {
1622 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */ 1403 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */
1623 { 1404 tmp->destroy ();
1624 remove_ob (tmp);
1625 free_object (tmp);
1626 }
1627 }
1628 1405
1629 tmp1 = arch_to_object (archetype::find (arch_string)); 1406 tmp1 = arch_to_object (archetype::find (arch_string));
1630 1407
1631 tmp1->x = op->x; 1408 tmp1->x = op->x;
1632 tmp1->y = op->y; 1409 tmp1->y = op->y;
1633 insert_ob_in_map (tmp1, op->map, op, 0); 1410 insert_ob_in_map (tmp1, op->map, op, 0);
1411}
1412
1413object *
1414object::insert_at (object *where, object *originator, int flags)
1415{
1416 where->map->insert (this, where->x, where->y, originator, flags);
1634} 1417}
1635 1418
1636/* 1419/*
1637 * get_split_ob(ob,nr) splits up ob into two parts. The part which 1420 * get_split_ob(ob,nr) splits up ob into two parts. The part which
1638 * is returned contains nr objects, and the remaining parts contains 1421 * is returned contains nr objects, and the remaining parts contains
1639 * the rest (or is removed and freed if that number is 0). 1422 * the rest (or is removed and freed if that number is 0).
1640 * On failure, NULL is returned, and the reason put into the 1423 * On failure, NULL is returned, and the reason put into the
1641 * global static errmsg array. 1424 * global static errmsg array.
1642 */ 1425 */
1643
1644object * 1426object *
1645get_split_ob (object *orig_ob, uint32 nr) 1427get_split_ob (object *orig_ob, uint32 nr)
1646{ 1428{
1647 object * 1429 object *newob;
1648 newob;
1649 int
1650 is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0); 1430 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1651 1431
1652 if (orig_ob->nrof < nr) 1432 if (orig_ob->nrof < nr)
1653 { 1433 {
1654 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name); 1434 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1655 return NULL; 1435 return NULL;
1656 } 1436 }
1657 1437
1658 newob = object_create_clone (orig_ob); 1438 newob = object_create_clone (orig_ob);
1659 1439
1660 if ((orig_ob->nrof -= nr) < 1) 1440 if ((orig_ob->nrof -= nr) < 1)
1661 { 1441 orig_ob->destroy (1);
1662 if (!is_removed)
1663 remove_ob (orig_ob);
1664 free_object2 (orig_ob, 1);
1665 }
1666 else if (!is_removed) 1442 else if (!is_removed)
1667 { 1443 {
1668 if (orig_ob->env != NULL) 1444 if (orig_ob->env != NULL)
1669 sub_weight (orig_ob->env, orig_ob->weight * nr); 1445 sub_weight (orig_ob->env, orig_ob->weight * nr);
1670 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY) 1446 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY)
… …
1690 1466
1691object * 1467object *
1692decrease_ob_nr (object *op, uint32 i) 1468decrease_ob_nr (object *op, uint32 i)
1693{ 1469{
1694 object *tmp; 1470 object *tmp;
1695 player *pl;
1696 1471
1697 if (i == 0) /* objects with op->nrof require this check */ 1472 if (i == 0) /* objects with op->nrof require this check */
1698 return op; 1473 return op;
1699 1474
1700 if (i > op->nrof) 1475 if (i > op->nrof)
1701 i = op->nrof; 1476 i = op->nrof;
1702 1477
1703 if (QUERY_FLAG (op, FLAG_REMOVED)) 1478 if (QUERY_FLAG (op, FLAG_REMOVED))
1704 op->nrof -= i; 1479 op->nrof -= i;
1705 else if (op->env != NULL) 1480 else if (op->env)
1706 { 1481 {
1707 /* is this object in the players inventory, or sub container 1482 /* is this object in the players inventory, or sub container
1708 * therein? 1483 * therein?
1709 */ 1484 */
1710 tmp = is_player_inv (op->env); 1485 tmp = op->in_player ();
1711 /* nope. Is this a container the player has opened? 1486 /* nope. Is this a container the player has opened?
1712 * If so, set tmp to that player. 1487 * If so, set tmp to that player.
1713 * IMO, searching through all the players will mostly 1488 * IMO, searching through all the players will mostly
1714 * likely be quicker than following op->env to the map, 1489 * likely be quicker than following op->env to the map,
1715 * and then searching the map for a player. 1490 * and then searching the map for a player.
1716 */ 1491 */
1717 if (!tmp) 1492 if (!tmp)
1718 { 1493 for_all_players (pl)
1719 for (pl = first_player; pl; pl = pl->next)
1720 if (pl->ob->container == op->env) 1494 if (pl->ob->container == op->env)
1495 {
1496 tmp = pl->ob;
1721 break; 1497 break;
1722 if (pl)
1723 tmp = pl->ob;
1724 else
1725 tmp = NULL;
1726 } 1498 }
1727 1499
1728 if (i < op->nrof) 1500 if (i < op->nrof)
1729 { 1501 {
1730 sub_weight (op->env, op->weight * i); 1502 sub_weight (op->env, op->weight * i);
1731 op->nrof -= i; 1503 op->nrof -= i;
1732 if (tmp) 1504 if (tmp)
1733 {
1734 esrv_send_item (tmp, op); 1505 esrv_send_item (tmp, op);
1735 }
1736 } 1506 }
1737 else 1507 else
1738 { 1508 {
1739 remove_ob (op); 1509 op->remove ();
1740 op->nrof = 0; 1510 op->nrof = 0;
1741 if (tmp) 1511 if (tmp)
1742 {
1743 esrv_del_item (tmp->contr, op->count); 1512 esrv_del_item (tmp->contr, op->count);
1744 }
1745 } 1513 }
1746 } 1514 }
1747 else 1515 else
1748 { 1516 {
1749 object *above = op->above; 1517 object *above = op->above;
1750 1518
1751 if (i < op->nrof) 1519 if (i < op->nrof)
1752 op->nrof -= i; 1520 op->nrof -= i;
1753 else 1521 else
1754 { 1522 {
1755 remove_ob (op); 1523 op->remove ();
1756 op->nrof = 0; 1524 op->nrof = 0;
1757 } 1525 }
1758 1526
1759 /* Since we just removed op, op->above is null */ 1527 /* Since we just removed op, op->above is null */
1760 for (tmp = above; tmp != NULL; tmp = tmp->above) 1528 for (tmp = above; tmp; tmp = tmp->above)
1761 if (tmp->type == PLAYER) 1529 if (tmp->type == PLAYER)
1762 { 1530 {
1763 if (op->nrof) 1531 if (op->nrof)
1764 esrv_send_item (tmp, op); 1532 esrv_send_item (tmp, op);
1765 else 1533 else
… …
1769 1537
1770 if (op->nrof) 1538 if (op->nrof)
1771 return op; 1539 return op;
1772 else 1540 else
1773 { 1541 {
1774 free_object (op); 1542 op->destroy ();
1775 return NULL; 1543 return 0;
1776 } 1544 }
1777} 1545}
1778 1546
1779/* 1547/*
1780 * add_weight(object, weight) adds the specified weight to an object, 1548 * add_weight(object, weight) adds the specified weight to an object,
… …
1792 op->carrying += weight; 1560 op->carrying += weight;
1793 op = op->env; 1561 op = op->env;
1794 } 1562 }
1795} 1563}
1796 1564
1565object *
1566insert_ob_in_ob (object *op, object *where)
1567{
1568 if (!where)
1569 {
1570 char *dump = dump_object (op);
1571 LOG (llevError, "Trying to put object in NULL.\n%s\n", dump);
1572 free (dump);
1573 return op;
1574 }
1575
1576 if (where->head)
1577 {
1578 LOG (llevDebug, "Warning: Tried to insert object into wrong part of multipart object.\n");
1579 where = where->head;
1580 }
1581
1582 return where->insert (op);
1583}
1584
1797/* 1585/*
1798 * insert_ob_in_ob(op,environment): 1586 * env->insert (op)
1799 * This function inserts the object op in the linked list 1587 * This function inserts the object op in the linked list
1800 * inside the object environment. 1588 * inside the object environment.
1801 * 1589 *
1802 * Eneq(@csd.uu.se): Altered insert_ob_in_ob to make things picked up enter
1803 * the inventory at the last position or next to other objects of the same
1804 * type.
1805 * Frank: Now sorted by type, archetype and magic!
1806 *
1807 * The function returns now pointer to inserted item, and return value can 1590 * The function returns now pointer to inserted item, and return value can
1808 * be != op, if items are merged. -Tero 1591 * be != op, if items are merged. -Tero
1809 */ 1592 */
1810 1593
1811object * 1594object *
1812insert_ob_in_ob (object *op, object *where) 1595object::insert (object *op)
1813{ 1596{
1814 object * 1597 object *tmp, *otmp;
1815 tmp, *
1816 otmp;
1817 1598
1818 if (!QUERY_FLAG (op, FLAG_REMOVED)) 1599 if (!QUERY_FLAG (op, FLAG_REMOVED))
1819 { 1600 op->remove ();
1820 dump_object (op);
1821 LOG (llevError, "Trying to insert (ob) inserted object.\n%s\n", errmsg);
1822 return op;
1823 }
1824
1825 if (where == NULL)
1826 {
1827 dump_object (op);
1828 LOG (llevError, "Trying to put object in NULL.\n%s\n", errmsg);
1829 return op;
1830 }
1831
1832 if (where->head)
1833 {
1834 LOG (llevDebug, "Warning: Tried to insert object wrong part of multipart object.\n");
1835 where = where->head;
1836 }
1837 1601
1838 if (op->more) 1602 if (op->more)
1839 { 1603 {
1840 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count); 1604 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);
1841 return op; 1605 return op;
… …
1843 1607
1844 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL); 1608 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL);
1845 CLEAR_FLAG (op, FLAG_REMOVED); 1609 CLEAR_FLAG (op, FLAG_REMOVED);
1846 if (op->nrof) 1610 if (op->nrof)
1847 { 1611 {
1848 for (tmp = where->inv; tmp != NULL; tmp = tmp->below) 1612 for (tmp = inv; tmp != NULL; tmp = tmp->below)
1849 if (CAN_MERGE (tmp, op)) 1613 if (object::can_merge (tmp, op))
1850 { 1614 {
1851 /* return the original object and remove inserted object 1615 /* return the original object and remove inserted object
1852 (client needs the original object) */ 1616 (client needs the original object) */
1853 tmp->nrof += op->nrof; 1617 tmp->nrof += op->nrof;
1854 /* Weight handling gets pretty funky. Since we are adding to 1618 /* Weight handling gets pretty funky. Since we are adding to
1855 * tmp->nrof, we need to increase the weight. 1619 * tmp->nrof, we need to increase the weight.
1856 */ 1620 */
1857 add_weight (where, op->weight * op->nrof); 1621 add_weight (this, op->weight * op->nrof);
1858 SET_FLAG (op, FLAG_REMOVED); 1622 SET_FLAG (op, FLAG_REMOVED);
1859 free_object (op); /* free the inserted object */ 1623 op->destroy (); /* free the inserted object */
1860 op = tmp; 1624 op = tmp;
1861 remove_ob (op); /* and fix old object's links */ 1625 op->remove (); /* and fix old object's links */
1862 CLEAR_FLAG (op, FLAG_REMOVED); 1626 CLEAR_FLAG (op, FLAG_REMOVED);
1863 break; 1627 break;
1864 } 1628 }
1865 1629
1866 /* I assume combined objects have no inventory 1630 /* I assume combined objects have no inventory
1867 * We add the weight - this object could have just been removed 1631 * We add the weight - this object could have just been removed
1868 * (if it was possible to merge). calling remove_ob will subtract 1632 * (if it was possible to merge). calling remove_ob will subtract
1869 * the weight, so we need to add it in again, since we actually do 1633 * the weight, so we need to add it in again, since we actually do
1870 * the linking below 1634 * the linking below
1871 */ 1635 */
1872 add_weight (where, op->weight * op->nrof); 1636 add_weight (this, op->weight * op->nrof);
1873 } 1637 }
1874 else 1638 else
1875 add_weight (where, (op->weight + op->carrying)); 1639 add_weight (this, (op->weight + op->carrying));
1876 1640
1877 otmp = is_player_inv (where); 1641 otmp = this->in_player ();
1878 if (otmp && otmp->contr != NULL) 1642 if (otmp && otmp->contr)
1879 {
1880 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1643 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1881 fix_player (otmp); 1644 otmp->update_stats ();
1882 }
1883 1645
1884 op->map = NULL; 1646 op->map = 0;
1885 op->env = where; 1647 op->env = this;
1886 op->above = NULL; 1648 op->above = 0;
1887 op->below = NULL; 1649 op->below = 0;
1888 op->x = 0, op->y = 0; 1650 op->x = 0, op->y = 0;
1889 1651
1890 /* reset the light list and los of the players on the map */ 1652 /* reset the light list and los of the players on the map */
1891 if ((op->glow_radius != 0) && where->map) 1653 if ((op->glow_radius != 0) && map)
1892 { 1654 {
1893#ifdef DEBUG_LIGHTS 1655#ifdef DEBUG_LIGHTS
1894 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name); 1656 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1895#endif /* DEBUG_LIGHTS */ 1657#endif /* DEBUG_LIGHTS */
1896 if (MAP_DARKNESS (where->map)) 1658 if (map->darkness)
1897 update_all_los (where->map, where->x, where->y); 1659 update_all_los (map, x, y);
1898 } 1660 }
1899 1661
1900 /* Client has no idea of ordering so lets not bother ordering it here. 1662 /* Client has no idea of ordering so lets not bother ordering it here.
1901 * It sure simplifies this function... 1663 * It sure simplifies this function...
1902 */ 1664 */
1903 if (where->inv == NULL) 1665 if (!inv)
1904 where->inv = op; 1666 inv = op;
1905 else 1667 else
1906 { 1668 {
1907 op->below = where->inv; 1669 op->below = inv;
1908 op->below->above = op; 1670 op->below->above = op;
1909 where->inv = op; 1671 inv = op;
1910 } 1672 }
1673
1674 INVOKE_OBJECT (INSERT, this);
1675
1911 return op; 1676 return op;
1912} 1677}
1913 1678
1914/* 1679/*
1915 * Checks if any objects has a move_type that matches objects 1680 * Checks if any objects has a move_type that matches objects
… …
1929 * 1694 *
1930 * MSW 2001-07-08: Check all objects on space, not just those below 1695 * MSW 2001-07-08: Check all objects on space, not just those below
1931 * object being inserted. insert_ob_in_map may not put new objects 1696 * object being inserted. insert_ob_in_map may not put new objects
1932 * on top. 1697 * on top.
1933 */ 1698 */
1934
1935int 1699int
1936check_move_on (object *op, object *originator) 1700check_move_on (object *op, object *originator)
1937{ 1701{
1938 object * 1702 object *tmp;
1939 tmp; 1703 maptile *m = op->map;
1940 tag_t
1941 tag;
1942 mapstruct *
1943 m = op->map;
1944 int
1945 x = op->x, y = op->y; 1704 int x = op->x, y = op->y;
1946 1705
1947 MoveType 1706 MoveType move_on, move_slow, move_block;
1948 move_on,
1949 move_slow,
1950 move_block;
1951 1707
1952 if (QUERY_FLAG (op, FLAG_NO_APPLY)) 1708 if (QUERY_FLAG (op, FLAG_NO_APPLY))
1953 return 0; 1709 return 0;
1954
1955 tag = op->count;
1956 1710
1957 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y); 1711 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
1958 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y); 1712 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
1959 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y); 1713 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
1960 1714
… …
1976 1730
1977 /* The objects have to be checked from top to bottom. 1731 /* The objects have to be checked from top to bottom.
1978 * Hence, we first go to the top: 1732 * Hence, we first go to the top:
1979 */ 1733 */
1980 1734
1981 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL && tmp->above != NULL; tmp = tmp->above) 1735 for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1982 { 1736 {
1983 /* Trim the search when we find the first other spell effect 1737 /* Trim the search when we find the first other spell effect
1984 * this helps performance so that if a space has 50 spell objects, 1738 * this helps performance so that if a space has 50 spell objects,
1985 * we don't need to check all of them. 1739 * we don't need to check all of them.
1986 */ 1740 */
… …
2004 if ((!op->move_type && tmp->move_slow & MOVE_WALK) || 1758 if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
2005 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0)) 1759 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
2006 { 1760 {
2007 1761
2008 float 1762 float
2009 diff = tmp->move_slow_penalty * FABS (op->speed); 1763 diff = tmp->move_slow_penalty * fabs (op->speed);
2010 1764
2011 if (op->type == PLAYER) 1765 if (op->type == PLAYER)
2012 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) || 1766 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) ||
2013 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN))) 1767 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN)))
2014 diff /= 4.0; 1768 diff /= 4.0;
… …
2021 if ((!op->move_type && tmp->move_on & MOVE_WALK) || 1775 if ((!op->move_type && tmp->move_on & MOVE_WALK) ||
2022 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0)) 1776 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0))
2023 { 1777 {
2024 move_apply (tmp, op, originator); 1778 move_apply (tmp, op, originator);
2025 1779
2026 if (was_destroyed (op, tag)) 1780 if (op->destroyed ())
2027 return 1; 1781 return 1;
2028 1782
2029 /* what the person/creature stepped onto has moved the object 1783 /* what the person/creature stepped onto has moved the object
2030 * someplace new. Don't process any further - if we did, 1784 * someplace new. Don't process any further - if we did,
2031 * have a feeling strange problems would result. 1785 * have a feeling strange problems would result.
… …
2041/* 1795/*
2042 * present_arch(arch, map, x, y) searches for any objects with 1796 * present_arch(arch, map, x, y) searches for any objects with
2043 * a matching archetype at the given map and coordinates. 1797 * a matching archetype at the given map and coordinates.
2044 * The first matching object is returned, or NULL if none. 1798 * The first matching object is returned, or NULL if none.
2045 */ 1799 */
2046
2047object * 1800object *
2048present_arch (const archetype *at, mapstruct *m, int x, int y) 1801present_arch (const archetype *at, maptile *m, int x, int y)
2049{ 1802{
2050 object *
2051 tmp;
2052
2053 if (m == NULL || out_of_map (m, x, y)) 1803 if (!m || out_of_map (m, x, y))
2054 { 1804 {
2055 LOG (llevError, "Present_arch called outside map.\n"); 1805 LOG (llevError, "Present_arch called outside map.\n");
2056 return NULL; 1806 return NULL;
2057 } 1807 }
2058 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1808
1809 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
2059 if (tmp->arch == at) 1810 if (tmp->arch == at)
2060 return tmp; 1811 return tmp;
1812
2061 return NULL; 1813 return NULL;
2062} 1814}
2063 1815
2064/* 1816/*
2065 * present(type, map, x, y) searches for any objects with 1817 * present(type, map, x, y) searches for any objects with
2066 * a matching type variable at the given map and coordinates. 1818 * a matching type variable at the given map and coordinates.
2067 * The first matching object is returned, or NULL if none. 1819 * The first matching object is returned, or NULL if none.
2068 */ 1820 */
2069
2070object * 1821object *
2071present (unsigned char type, mapstruct *m, int x, int y) 1822present (unsigned char type, maptile *m, int x, int y)
2072{ 1823{
2073 object *
2074 tmp;
2075
2076 if (out_of_map (m, x, y)) 1824 if (out_of_map (m, x, y))
2077 { 1825 {
2078 LOG (llevError, "Present called outside map.\n"); 1826 LOG (llevError, "Present called outside map.\n");
2079 return NULL; 1827 return NULL;
2080 } 1828 }
2081 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1829
1830 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
2082 if (tmp->type == type) 1831 if (tmp->type == type)
2083 return tmp; 1832 return tmp;
1833
2084 return NULL; 1834 return NULL;
2085} 1835}
2086 1836
2087/* 1837/*
2088 * present_in_ob(type, object) searches for any objects with 1838 * present_in_ob(type, object) searches for any objects with
2089 * a matching type variable in the inventory of the given object. 1839 * a matching type variable in the inventory of the given object.
2090 * The first matching object is returned, or NULL if none. 1840 * The first matching object is returned, or NULL if none.
2091 */ 1841 */
2092
2093object * 1842object *
2094present_in_ob (unsigned char type, const object *op) 1843present_in_ob (unsigned char type, const object *op)
2095{ 1844{
2096 object *
2097 tmp;
2098
2099 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1845 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2100 if (tmp->type == type) 1846 if (tmp->type == type)
2101 return tmp; 1847 return tmp;
1848
2102 return NULL; 1849 return NULL;
2103} 1850}
2104 1851
2105/* 1852/*
2106 * present_in_ob (type, str, object) searches for any objects with 1853 * present_in_ob (type, str, object) searches for any objects with
… …
2114 * str is the string to match against. Note that we match against 1861 * str is the string to match against. Note that we match against
2115 * the object name, not the archetype name. this is so that the 1862 * the object name, not the archetype name. this is so that the
2116 * spell code can use one object type (force), but change it's name 1863 * spell code can use one object type (force), but change it's name
2117 * to be unique. 1864 * to be unique.
2118 */ 1865 */
2119
2120object * 1866object *
2121present_in_ob_by_name (int type, const char *str, const object *op) 1867present_in_ob_by_name (int type, const char *str, const object *op)
2122{ 1868{
2123 object *
2124 tmp;
2125
2126 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1869 for (object *tmp = op->inv; tmp; tmp = tmp->below)
2127 {
2128 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name))) 1870 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name)))
2129 return tmp; 1871 return tmp;
2130 } 1872
2131 return NULL; 1873 return 0;
2132} 1874}
2133 1875
2134/* 1876/*
2135 * present_arch_in_ob(archetype, object) searches for any objects with 1877 * present_arch_in_ob(archetype, object) searches for any objects with
2136 * a matching archetype in the inventory of the given object. 1878 * a matching archetype in the inventory of the given object.
2137 * The first matching object is returned, or NULL if none. 1879 * The first matching object is returned, or NULL if none.
2138 */ 1880 */
2139
2140object * 1881object *
2141present_arch_in_ob (const archetype *at, const object *op) 1882present_arch_in_ob (const archetype *at, const object *op)
2142{ 1883{
2143 object *
2144 tmp;
2145
2146 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1884 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2147 if (tmp->arch == at) 1885 if (tmp->arch == at)
2148 return tmp; 1886 return tmp;
1887
2149 return NULL; 1888 return NULL;
2150} 1889}
2151 1890
2152/* 1891/*
2153 * activate recursively a flag on an object inventory 1892 * activate recursively a flag on an object inventory
2154 */ 1893 */
2155void 1894void
2156flag_inv (object *op, int flag) 1895flag_inv (object *op, int flag)
2157{ 1896{
2158 object *
2159 tmp;
2160
2161 if (op->inv) 1897 if (op->inv)
2162 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1898 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2163 { 1899 {
2164 SET_FLAG (tmp, flag); 1900 SET_FLAG (tmp, flag);
2165 flag_inv (tmp, flag); 1901 flag_inv (tmp, flag);
2166 } 1902 }
2167} /* 1903}
1904
1905/*
2168 * desactivate recursively a flag on an object inventory 1906 * deactivate recursively a flag on an object inventory
2169 */ 1907 */
2170void 1908void
2171unflag_inv (object *op, int flag) 1909unflag_inv (object *op, int flag)
2172{ 1910{
2173 object *
2174 tmp;
2175
2176 if (op->inv) 1911 if (op->inv)
2177 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1912 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2178 { 1913 {
2179 CLEAR_FLAG (tmp, flag); 1914 CLEAR_FLAG (tmp, flag);
2180 unflag_inv (tmp, flag); 1915 unflag_inv (tmp, flag);
2181 } 1916 }
2182} 1917}
… …
2185 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in 1920 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in
2186 * all it's inventory (recursively). 1921 * all it's inventory (recursively).
2187 * If checksums are used, a player will get set_cheat called for 1922 * If checksums are used, a player will get set_cheat called for
2188 * him/her-self and all object carried by a call to this function. 1923 * him/her-self and all object carried by a call to this function.
2189 */ 1924 */
2190
2191void 1925void
2192set_cheat (object *op) 1926set_cheat (object *op)
2193{ 1927{
2194 SET_FLAG (op, FLAG_WAS_WIZ); 1928 SET_FLAG (op, FLAG_WAS_WIZ);
2195 flag_inv (op, FLAG_WAS_WIZ); 1929 flag_inv (op, FLAG_WAS_WIZ);
… …
2214 * because arch_blocked (now ob_blocked) needs to know the movement type 1948 * because arch_blocked (now ob_blocked) needs to know the movement type
2215 * to know if the space in question will block the object. We can't use 1949 * to know if the space in question will block the object. We can't use
2216 * the archetype because that isn't correct if the monster has been 1950 * the archetype because that isn't correct if the monster has been
2217 * customized, changed states, etc. 1951 * customized, changed states, etc.
2218 */ 1952 */
2219
2220int 1953int
2221find_free_spot (const object *ob, mapstruct *m, int x, int y, int start, int stop) 1954find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)
2222{ 1955{
2223 int
2224 i,
2225 index = 0, flag; 1956 int index = 0, flag;
2226 static int
2227 altern[SIZEOFFREE]; 1957 int altern[SIZEOFFREE];
2228 1958
2229 for (i = start; i < stop; i++) 1959 for (int i = start; i < stop; i++)
2230 { 1960 {
2231 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]); 1961 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]);
2232 if (!flag) 1962 if (!flag)
2233 altern[index++] = i; 1963 altern [index++] = i;
2234 1964
2235 /* Basically, if we find a wall on a space, we cut down the search size. 1965 /* Basically, if we find a wall on a space, we cut down the search size.
2236 * In this way, we won't return spaces that are on another side of a wall. 1966 * In this way, we won't return spaces that are on another side of a wall.
2237 * This mostly work, but it cuts down the search size in all directions - 1967 * This mostly work, but it cuts down the search size in all directions -
2238 * if the space being examined only has a wall to the north and empty 1968 * if the space being examined only has a wall to the north and empty
2239 * spaces in all the other directions, this will reduce the search space 1969 * spaces in all the other directions, this will reduce the search space
2240 * to only the spaces immediately surrounding the target area, and 1970 * to only the spaces immediately surrounding the target area, and
2241 * won't look 2 spaces south of the target space. 1971 * won't look 2 spaces south of the target space.
2242 */ 1972 */
2243 else if ((flag & AB_NO_PASS) && maxfree[i] < stop) 1973 else if ((flag & P_NO_PASS) && maxfree[i] < stop)
2244 stop = maxfree[i]; 1974 stop = maxfree[i];
2245 } 1975 }
1976
2246 if (!index) 1977 if (!index)
2247 return -1; 1978 return -1;
1979
2248 return altern[RANDOM () % index]; 1980 return altern [rndm (index)];
2249} 1981}
2250 1982
2251/* 1983/*
2252 * find_first_free_spot(archetype, mapstruct, x, y) works like 1984 * find_first_free_spot(archetype, maptile, x, y) works like
2253 * find_free_spot(), but it will search max number of squares. 1985 * find_free_spot(), but it will search max number of squares.
2254 * But it will return the first available spot, not a random choice. 1986 * But it will return the first available spot, not a random choice.
2255 * Changed 0.93.2: Have it return -1 if there is no free spot available. 1987 * Changed 0.93.2: Have it return -1 if there is no free spot available.
2256 */ 1988 */
2257
2258int 1989int
2259find_first_free_spot (const object *ob, mapstruct *m, int x, int y) 1990find_first_free_spot (const object *ob, maptile *m, int x, int y)
2260{ 1991{
2261 int
2262 i;
2263
2264 for (i = 0; i < SIZEOFFREE; i++) 1992 for (int i = 0; i < SIZEOFFREE; i++)
2265 {
2266 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i])) 1993 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]))
2267 return i; 1994 return i;
2268 } 1995
2269 return -1; 1996 return -1;
2270} 1997}
2271 1998
2272/* 1999/*
2273 * The function permute(arr, begin, end) randomly reorders the array 2000 * The function permute(arr, begin, end) randomly reorders the array
2274 * arr[begin..end-1]. 2001 * arr[begin..end-1].
2002 * now uses a fisher-yates shuffle, old permute was broken
2275 */ 2003 */
2276static void 2004static void
2277permute (int *arr, int begin, int end) 2005permute (int *arr, int begin, int end)
2278{ 2006{
2279 int 2007 arr += begin;
2280 i,
2281 j,
2282 tmp,
2283 len;
2284
2285 len = end - begin; 2008 end -= begin;
2286 for (i = begin; i < end; i++)
2287 {
2288 j = begin + RANDOM () % len;
2289 2009
2290 tmp = arr[i]; 2010 while (--end)
2291 arr[i] = arr[j]; 2011 swap (arr [end], arr [rndm (end + 1)]);
2292 arr[j] = tmp;
2293 }
2294} 2012}
2295 2013
2296/* new function to make monster searching more efficient, and effective! 2014/* new function to make monster searching more efficient, and effective!
2297 * This basically returns a randomized array (in the passed pointer) of 2015 * This basically returns a randomized array (in the passed pointer) of
2298 * the spaces to find monsters. In this way, it won't always look for 2016 * the spaces to find monsters. In this way, it won't always look for
… …
2301 * the 3x3 area will be searched, just not in a predictable order. 2019 * the 3x3 area will be searched, just not in a predictable order.
2302 */ 2020 */
2303void 2021void
2304get_search_arr (int *search_arr) 2022get_search_arr (int *search_arr)
2305{ 2023{
2306 int 2024 int i;
2307 i;
2308 2025
2309 for (i = 0; i < SIZEOFFREE; i++) 2026 for (i = 0; i < SIZEOFFREE; i++)
2310 {
2311 search_arr[i] = i; 2027 search_arr[i] = i;
2312 }
2313 2028
2314 permute (search_arr, 1, SIZEOFFREE1 + 1); 2029 permute (search_arr, 1, SIZEOFFREE1 + 1);
2315 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1); 2030 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1);
2316 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE); 2031 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE);
2317} 2032}
… …
2326 * Perhaps incorrectly, but I'm making the assumption that exclude 2041 * Perhaps incorrectly, but I'm making the assumption that exclude
2327 * is actually want is going to try and move there. We need this info 2042 * is actually want is going to try and move there. We need this info
2328 * because we have to know what movement the thing looking to move 2043 * because we have to know what movement the thing looking to move
2329 * there is capable of. 2044 * there is capable of.
2330 */ 2045 */
2331
2332int 2046int
2333find_dir (mapstruct *m, int x, int y, object *exclude) 2047find_dir (maptile *m, int x, int y, object *exclude)
2334{ 2048{
2335 int
2336 i,
2337 max = SIZEOFFREE, mflags; 2049 int i, max = SIZEOFFREE, mflags;
2338 2050
2339 sint16 nx, ny; 2051 sint16 nx, ny;
2340 object * 2052 object *tmp;
2341 tmp; 2053 maptile *mp;
2342 mapstruct *
2343 mp;
2344 2054
2345 MoveType blocked, move_type; 2055 MoveType blocked, move_type;
2346 2056
2347 if (exclude && exclude->head) 2057 if (exclude && exclude->head)
2348 { 2058 {
… …
2360 mp = m; 2070 mp = m;
2361 nx = x + freearr_x[i]; 2071 nx = x + freearr_x[i];
2362 ny = y + freearr_y[i]; 2072 ny = y + freearr_y[i];
2363 2073
2364 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2074 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);
2075
2365 if (mflags & P_OUT_OF_MAP) 2076 if (mflags & P_OUT_OF_MAP)
2366 {
2367 max = maxfree[i]; 2077 max = maxfree[i];
2368 }
2369 else 2078 else
2370 { 2079 {
2371 blocked = GET_MAP_MOVE_BLOCK (mp, nx, ny); 2080 mapspace &ms = mp->at (nx, ny);
2081
2082 blocked = ms.move_block;
2372 2083
2373 if ((move_type & blocked) == move_type) 2084 if ((move_type & blocked) == move_type)
2374 {
2375 max = maxfree[i]; 2085 max = maxfree[i];
2376 }
2377 else if (mflags & P_IS_ALIVE) 2086 else if (mflags & P_IS_ALIVE)
2378 { 2087 {
2379 for (tmp = GET_MAP_OB (mp, nx, ny); tmp != NULL; tmp = tmp->above) 2088 for (tmp = ms.bot; tmp; tmp = tmp->above)
2380 { 2089 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)
2381 if ((QUERY_FLAG (tmp, FLAG_MONSTER) || tmp->type == PLAYER) && (tmp != exclude || (tmp->head && tmp->head != exclude))) 2090 && (tmp != exclude || (tmp->head && tmp->head != exclude)))
2382 {
2383 break; 2091 break;
2384 } 2092
2385 }
2386 if (tmp) 2093 if (tmp)
2387 {
2388 return freedir[i]; 2094 return freedir[i];
2389 }
2390 } 2095 }
2391 } 2096 }
2392 } 2097 }
2098
2393 return 0; 2099 return 0;
2394} 2100}
2395 2101
2396/* 2102/*
2397 * distance(object 1, object 2) will return the square of the 2103 * distance(object 1, object 2) will return the square of the
2398 * distance between the two given objects. 2104 * distance between the two given objects.
2399 */ 2105 */
2400
2401int 2106int
2402distance (const object *ob1, const object *ob2) 2107distance (const object *ob1, const object *ob2)
2403{ 2108{
2404 int
2405 i;
2406
2407 i = (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y); 2109 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2408 return i;
2409} 2110}
2410 2111
2411/* 2112/*
2412 * find_dir_2(delta-x,delta-y) will return a direction in which 2113 * find_dir_2(delta-x,delta-y) will return a direction in which
2413 * an object which has subtracted the x and y coordinates of another 2114 * an object which has subtracted the x and y coordinates of another
2414 * object, needs to travel toward it. 2115 * object, needs to travel toward it.
2415 */ 2116 */
2416
2417int 2117int
2418find_dir_2 (int x, int y) 2118find_dir_2 (int x, int y)
2419{ 2119{
2420 int 2120 int q;
2421 q;
2422 2121
2423 if (y) 2122 if (y)
2424 q = x * 100 / y; 2123 q = x * 100 / y;
2425 else if (x) 2124 else if (x)
2426 q = -300 * x; 2125 q = -300 * x;
… …
2451 2150
2452 return 3; 2151 return 3;
2453} 2152}
2454 2153
2455/* 2154/*
2456 * absdir(int): Returns a number between 1 and 8, which represent
2457 * the "absolute" direction of a number (it actually takes care of
2458 * "overflow" in previous calculations of a direction).
2459 */
2460
2461int
2462absdir (int d)
2463{
2464 while (d < 1)
2465 d += 8;
2466 while (d > 8)
2467 d -= 8;
2468 return d;
2469}
2470
2471/*
2472 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is 2155 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is
2473 * between two directions (which are expected to be absolute (see absdir()) 2156 * between two directions (which are expected to be absolute (see absdir())
2474 */ 2157 */
2475
2476int 2158int
2477dirdiff (int dir1, int dir2) 2159dirdiff (int dir1, int dir2)
2478{ 2160{
2479 int 2161 int d;
2480 d;
2481 2162
2482 d = abs (dir1 - dir2); 2163 d = abs (dir1 - dir2);
2483 if (d > 4) 2164 if (d > 4)
2484 d = 8 - d; 2165 d = 8 - d;
2166
2485 return d; 2167 return d;
2486} 2168}
2487 2169
2488/* peterm: 2170/* peterm:
2489 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster. 2171 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster.
… …
2492 * This basically means that if direction is 15, then it could either go 2174 * This basically means that if direction is 15, then it could either go
2493 * direction 4, 14, or 16 to get back to where we are. 2175 * direction 4, 14, or 16 to get back to where we are.
2494 * Moved from spell_util.c to object.c with the other related direction 2176 * Moved from spell_util.c to object.c with the other related direction
2495 * functions. 2177 * functions.
2496 */ 2178 */
2497
2498int
2499 reduction_dir[SIZEOFFREE][3] = { 2179int reduction_dir[SIZEOFFREE][3] = {
2500 {0, 0, 0}, /* 0 */ 2180 {0, 0, 0}, /* 0 */
2501 {0, 0, 0}, /* 1 */ 2181 {0, 0, 0}, /* 1 */
2502 {0, 0, 0}, /* 2 */ 2182 {0, 0, 0}, /* 2 */
2503 {0, 0, 0}, /* 3 */ 2183 {0, 0, 0}, /* 3 */
2504 {0, 0, 0}, /* 4 */ 2184 {0, 0, 0}, /* 4 */
… …
2552 * find a path to that monster that we found. If not, 2232 * find a path to that monster that we found. If not,
2553 * we don't bother going toward it. Returns 1 if we 2233 * we don't bother going toward it. Returns 1 if we
2554 * can see a direct way to get it 2234 * can see a direct way to get it
2555 * Modified to be map tile aware -.MSW 2235 * Modified to be map tile aware -.MSW
2556 */ 2236 */
2557
2558
2559int 2237int
2560can_see_monsterP (mapstruct *m, int x, int y, int dir) 2238can_see_monsterP (maptile *m, int x, int y, int dir)
2561{ 2239{
2562 sint16 dx, dy; 2240 sint16 dx, dy;
2563 int
2564 mflags; 2241 int mflags;
2565 2242
2566 if (dir < 0) 2243 if (dir < 0)
2567 return 0; /* exit condition: invalid direction */ 2244 return 0; /* exit condition: invalid direction */
2568 2245
2569 dx = x + freearr_x[dir]; 2246 dx = x + freearr_x[dir];
… …
2582 return 0; 2259 return 0;
2583 2260
2584 /* yes, can see. */ 2261 /* yes, can see. */
2585 if (dir < 9) 2262 if (dir < 9)
2586 return 1; 2263 return 1;
2264
2587 return can_see_monsterP (m, x, y, reduction_dir[dir][0]) | 2265 return can_see_monsterP (m, x, y, reduction_dir[dir][0])
2588 can_see_monsterP (m, x, y, reduction_dir[dir][1]) | can_see_monsterP (m, x, y, reduction_dir[dir][2]); 2266 | can_see_monsterP (m, x, y, reduction_dir[dir][1])
2267 | can_see_monsterP (m, x, y, reduction_dir[dir][2]);
2589} 2268}
2590
2591
2592 2269
2593/* 2270/*
2594 * can_pick(picker, item): finds out if an object is possible to be 2271 * can_pick(picker, item): finds out if an object is possible to be
2595 * picked up by the picker. Returnes 1 if it can be 2272 * picked up by the picker. Returnes 1 if it can be
2596 * picked up, otherwise 0. 2273 * picked up, otherwise 0.
… …
2607 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2284 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2608 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2285 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2609 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2286 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));
2610} 2287}
2611 2288
2612
2613/* 2289/*
2614 * create clone from object to another 2290 * create clone from object to another
2615 */ 2291 */
2616object * 2292object *
2617object_create_clone (object *asrc) 2293object_create_clone (object *asrc)
2618{ 2294{
2619 object *
2620 dst = NULL, *tmp, *src, *part, *prev, *item; 2295 object *dst = 0, *tmp, *src, *part, *prev, *item;
2621 2296
2622 if (!asrc) 2297 if (!asrc)
2623 return NULL; 2298 return 0;
2299
2624 src = asrc; 2300 src = asrc;
2625 if (src->head) 2301 if (src->head)
2626 src = src->head; 2302 src = src->head;
2627 2303
2628 prev = NULL; 2304 prev = 0;
2629 for (part = src; part; part = part->more) 2305 for (part = src; part; part = part->more)
2630 { 2306 {
2631 tmp = get_object (); 2307 tmp = part->clone ();
2632 copy_object (part, tmp);
2633 tmp->x -= src->x; 2308 tmp->x -= src->x;
2634 tmp->y -= src->y; 2309 tmp->y -= src->y;
2310
2635 if (!part->head) 2311 if (!part->head)
2636 { 2312 {
2637 dst = tmp; 2313 dst = tmp;
2638 tmp->head = NULL; 2314 tmp->head = 0;
2639 } 2315 }
2640 else 2316 else
2641 {
2642 tmp->head = dst; 2317 tmp->head = dst;
2643 } 2318
2644 tmp->more = NULL; 2319 tmp->more = 0;
2320
2645 if (prev) 2321 if (prev)
2646 prev->more = tmp; 2322 prev->more = tmp;
2323
2647 prev = tmp; 2324 prev = tmp;
2648 } 2325 }
2649 2326
2650 /*** copy inventory ***/
2651 for (item = src->inv; item; item = item->below) 2327 for (item = src->inv; item; item = item->below)
2652 {
2653 (void) insert_ob_in_ob (object_create_clone (item), dst); 2328 insert_ob_in_ob (object_create_clone (item), dst);
2654 }
2655 2329
2656 return dst; 2330 return dst;
2657} 2331}
2658 2332
2659/* return true if the object was destroyed, 0 otherwise */
2660int
2661was_destroyed (const object *op, tag_t old_tag)
2662{
2663 /* checking for FLAG_FREED isn't necessary, but makes this function more
2664 * robust */
2665 return op->count != old_tag || QUERY_FLAG (op, FLAG_FREED);
2666}
2667
2668/* GROS - Creates an object using a string representing its content. */ 2333/* GROS - Creates an object using a string representing its content. */
2669
2670/* Basically, we save the content of the string to a temp file, then call */ 2334/* Basically, we save the content of the string to a temp file, then call */
2671
2672/* load_object on it. I admit it is a highly inefficient way to make things, */ 2335/* load_object on it. I admit it is a highly inefficient way to make things, */
2673
2674/* but it was simple to make and allows reusing the load_object function. */ 2336/* but it was simple to make and allows reusing the load_object function. */
2675
2676/* Remember not to use load_object_str in a time-critical situation. */ 2337/* Remember not to use load_object_str in a time-critical situation. */
2677
2678/* Also remember that multiparts objects are not supported for now. */ 2338/* Also remember that multiparts objects are not supported for now. */
2679
2680object * 2339object *
2681load_object_str (const char *obstr) 2340load_object_str (const char *obstr)
2682{ 2341{
2683 object * 2342 object *op;
2684 op;
2685 char
2686 filename[MAX_BUF]; 2343 char filename[MAX_BUF];
2687 2344
2688 sprintf (filename, "%s/cfloadobstr2044", settings.tmpdir); 2345 sprintf (filename, "%s/cfloadobstr2044", settings.tmpdir);
2689 2346
2690 FILE *
2691 tempfile = fopen (filename, "w"); 2347 FILE *tempfile = fopen (filename, "w");
2692 2348
2693 if (tempfile == NULL) 2349 if (tempfile == NULL)
2694 { 2350 {
2695 LOG (llevError, "Error - Unable to access load object temp file\n"); 2351 LOG (llevError, "Error - Unable to access load object temp file\n");
2696 return NULL; 2352 return NULL;
2697 } 2353 }
2698 2354
2699 fprintf (tempfile, obstr); 2355 fprintf (tempfile, obstr);
2700 fclose (tempfile); 2356 fclose (tempfile);
2701 2357
2702 op = get_object (); 2358 op = object::create ();
2703 2359
2704 object_thawer thawer (filename); 2360 object_thawer thawer (filename);
2705 2361
2706 if (thawer) 2362 if (thawer)
2707 load_object (thawer, op, 0); 2363 load_object (thawer, op, 0);
… …
2717 * returns NULL if no match. 2373 * returns NULL if no match.
2718 */ 2374 */
2719object * 2375object *
2720find_obj_by_type_subtype (const object *who, int type, int subtype) 2376find_obj_by_type_subtype (const object *who, int type, int subtype)
2721{ 2377{
2722 object *
2723 tmp;
2724
2725 for (tmp = who->inv; tmp; tmp = tmp->below) 2378 for (object *tmp = who->inv; tmp; tmp = tmp->below)
2726 if (tmp->type == type && tmp->subtype == subtype) 2379 if (tmp->type == type && tmp->subtype == subtype)
2727 return tmp; 2380 return tmp;
2728 2381
2729 return NULL; 2382 return 0;
2730} 2383}
2731 2384
2732/* If ob has a field named key, return the link from the list, 2385/* If ob has a field named key, return the link from the list,
2733 * otherwise return NULL. 2386 * otherwise return NULL.
2734 * 2387 *
… …
2736 * do the desired thing. 2389 * do the desired thing.
2737 */ 2390 */
2738key_value * 2391key_value *
2739get_ob_key_link (const object *ob, const char *key) 2392get_ob_key_link (const object *ob, const char *key)
2740{ 2393{
2741 key_value *
2742 link;
2743
2744 for (link = ob->key_values; link != NULL; link = link->next) 2394 for (key_value *link = ob->key_values; link; link = link->next)
2745 {
2746 if (link->key == key) 2395 if (link->key == key)
2747 {
2748 return link; 2396 return link;
2749 }
2750 }
2751 2397
2752 return NULL; 2398 return 0;
2753} 2399}
2754 2400
2755/* 2401/*
2756 * Returns the value of op has an extra_field for key, or NULL. 2402 * Returns the value of op has an extra_field for key, or NULL.
2757 * 2403 *
… …
2797 * Returns TRUE on success. 2443 * Returns TRUE on success.
2798 */ 2444 */
2799int 2445int
2800set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key) 2446set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2801{ 2447{
2802 key_value *
2803 field = NULL, *last = NULL; 2448 key_value *field = NULL, *last = NULL;
2804 2449
2805 for (field = op->key_values; field != NULL; field = field->next) 2450 for (field = op->key_values; field != NULL; field = field->next)
2806 { 2451 {
2807 if (field->key != canonical_key) 2452 if (field->key != canonical_key)
2808 { 2453 {
… …
2836 /* IF we get here, key doesn't exist */ 2481 /* IF we get here, key doesn't exist */
2837 2482
2838 /* No field, we'll have to add it. */ 2483 /* No field, we'll have to add it. */
2839 2484
2840 if (!add_key) 2485 if (!add_key)
2841 {
2842 return FALSE; 2486 return FALSE;
2843 } 2487
2844 /* There isn't any good reason to store a null 2488 /* There isn't any good reason to store a null
2845 * value in the key/value list. If the archetype has 2489 * value in the key/value list. If the archetype has
2846 * this key, then we should also have it, so shouldn't 2490 * this key, then we should also have it, so shouldn't
2847 * be here. If user wants to store empty strings, 2491 * be here. If user wants to store empty strings,
2848 * should pass in "" 2492 * should pass in ""
… …
2897 } 2541 }
2898 else 2542 else
2899 item = item->env; 2543 item = item->env;
2900} 2544}
2901 2545
2546
2547const char *
2548object::flag_desc (char *desc, int len) const
2549{
2550 char *p = desc;
2551 bool first = true;
2552
2553 *p = 0;
2554
2555 for (int i = 0; i < NUM_FLAGS; i++)
2556 {
2557 if (len <= 10) // magic constant!
2558 {
2559 snprintf (p, len, ",...");
2560 break;
2561 }
2562
2563 if (flag [i])
2564 {
2565 int cnt = snprintf (p, len, "%s%d", first ? "" : ",", i);
2566 len -= cnt;
2567 p += cnt;
2568 first = false;
2569 }
2570 }
2571
2572 return desc;
2573}
2574
2902// return a suitable string describing an objetc in enough detail to find it 2575// return a suitable string describing an object in enough detail to find it
2903const char * 2576const char *
2904object::debug_desc (char *info) const 2577object::debug_desc (char *info) const
2905{ 2578{
2579 char flagdesc[512];
2906 char info2[256 * 3]; 2580 char info2[256 * 4];
2907 char *p = info; 2581 char *p = info;
2908 2582
2909 p += snprintf (p, 256, "%d=\"%s%s%s\"", 2583 p += snprintf (p, 512, "{cnt:%d,uuid:<1,%" PRIx64 ">,name:\"%s\"%s%s,flags:[%s],type:%d}",
2910 count, 2584 count, uuid.seq,
2911 &name, 2585 &name,
2912 title ? " " : "", 2586 title ? "\",title:\"" : "",
2913 title ? (const char *)title : ""); 2587 title ? (const char *)title : "",
2588 flag_desc (flagdesc, 512), type);
2914 2589
2915 if (env) 2590 if (env)
2916 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2591 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2917 2592
2918 if (map) 2593 if (map)
2919 p += snprintf (p, 256, "(on %s@%d+%d)", map->path, x, y); 2594 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2920 2595
2921 return info; 2596 return info;
2922} 2597}
2923 2598
2924const char * 2599const char *
2925object::debug_desc () const 2600object::debug_desc () const
2926{ 2601{
2927 static char info[256 * 3]; 2602 static char info[256 * 4];
2928 return debug_desc (info); 2603 return debug_desc (info);
2929} 2604}
2930 2605
2606const char *
2607object::debug_desc2 () const
2608{
2609 static char info[256 * 4];
2610 return debug_desc (info);
2611}
2612
2613struct region *
2614object::region () const
2615{
2616 return map ? map->region (x, y)
2617 : region::default_region ();
2618}
2619

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines