ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.63 by root, Tue Dec 12 20:53:02 2006 UTC vs.
Revision 1.128 by root, Mon Feb 5 01:24:45 2007 UTC

1/* 1/*
2 CrossFire, A Multiplayer game for X-windows 2 * CrossFire, A Multiplayer game for X-windows
3 3 *
4 * Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team
4 Copyright (C) 2001 Mark Wedel & Crossfire Development Team 5 * Copyright (C) 2001 Mark Wedel & Crossfire Development Team
5 Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (C) 1992 Frank Tore Johansen
6 7 *
7 This program is free software; you can redistribute it and/or modify 8 * This program is free software; you can redistribute it and/or modify
8 it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
9 the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation; either version 2 of the License, or
10 (at your option) any later version. 11 * (at your option) any later version.
11 12 *
12 This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
13 but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 GNU General Public License for more details. 16 * GNU General Public License for more details.
16 17 *
17 You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
18 along with this program; if not, write to the Free Software 19 * along with this program; if not, write to the Free Software
19 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
20 21 *
21 The authors can be reached via e-mail at <crossfire@schmorp.de> 22 * The authors can be reached via e-mail at <crossfire@schmorp.de>
22*/ 23 */
23 24
24/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects. 25/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
25 sub/add_weight will transcend the environment updating the carrying 26 sub/add_weight will transcend the environment updating the carrying
26 variable. */ 27 variable. */
27#include <global.h> 28#include <global.h>
… …
30#include <sys/uio.h> 31#include <sys/uio.h>
31#include <object.h> 32#include <object.h>
32#include <funcpoint.h> 33#include <funcpoint.h>
33#include <loader.h> 34#include <loader.h>
34 35
36#include <bitset>
37
35int nrofallocobjects = 0; 38int nrofallocobjects = 0;
36static UUID uuid; 39static UUID uuid;
37const uint64 UUID_SKIP = 1<<19; 40const uint64 UUID_SKIP = 1<<19;
38 41
39object *active_objects; /* List of active objects that need to be processed */ 42objectvec objects;
43activevec actives;
40 44
41short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 45short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
42 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1 46 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1
43}; 47};
44short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, 48short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
… …
139 * objects with lists are rare, and lists stay short. If not, use a 143 * objects with lists are rare, and lists stay short. If not, use a
140 * different structure or at least keep the lists sorted... 144 * different structure or at least keep the lists sorted...
141 */ 145 */
142 146
143 /* For each field in wants, */ 147 /* For each field in wants, */
144 for (wants_field = wants->key_values; wants_field != NULL; wants_field = wants_field->next) 148 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)
145 { 149 {
146 key_value *has_field; 150 key_value *has_field;
147 151
148 /* Look for a field in has with the same key. */ 152 /* Look for a field in has with the same key. */
149 has_field = get_ob_key_link (has, wants_field->key); 153 has_field = get_ob_key_link (has, wants_field->key);
… …
183 * 187 *
184 * Note that this function appears a lot longer than the macro it 188 * Note that this function appears a lot longer than the macro it
185 * replaces - this is mostly for clarity - a decent compiler should hopefully 189 * replaces - this is mostly for clarity - a decent compiler should hopefully
186 * reduce this to the same efficiency. 190 * reduce this to the same efficiency.
187 * 191 *
188 * Check nrof variable *before* calling CAN_MERGE() 192 * Check nrof variable *before* calling can_merge()
189 * 193 *
190 * Improvements made with merge: Better checking on potion, and also 194 * Improvements made with merge: Better checking on potion, and also
191 * check weight 195 * check weight
192 */ 196 */
193
194bool object::can_merge (object *ob1, object *ob2) 197bool object::can_merge_slow (object *ob1, object *ob2)
195{ 198{
196 /* A couple quicksanity checks */ 199 /* A couple quicksanity checks */
197 if ((ob1 == ob2) || (ob1->type != ob2->type)) 200 if (ob1 == ob2
201 || ob1->type != ob2->type
202 || ob1->speed != ob2->speed
203 || ob1->value != ob2->value
204 || ob1->name != ob2->name)
198 return 0; 205 return 0;
199 206
200 if (ob1->speed != ob2->speed) 207 //TODO: this ain't working well, use nicer and correct overflow check
201 return 0;
202
203 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that 208 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that
204 * value could not be stored in a sint32 (which unfortunately sometimes is 209 * value could not be stored in a sint32 (which unfortunately sometimes is
205 * used to store nrof). 210 * used to store nrof).
206 */ 211 */
207 if (ob1->nrof + ob2->nrof >= 1UL << 31) 212 if (ob1->nrof + ob2->nrof >= 1UL << 31)
… …
217 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 222 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
218 223
219 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 224 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
220 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 225 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
221 226
222 227 if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any ()
223 /* the 0x400000 on flags2 is FLAG_INV_LOCK. I don't think something 228 || ob1->arch != ob2->arch
224 * being locked in inventory should prevent merging.
225 * 0x4 in flags3 is CLIENT_SENT
226 */
227 if ((ob1->arch != ob2->arch) ||
228 (ob1->flags[0] != ob2->flags[0]) ||
229 (ob1->flags[1] != ob2->flags[1]) ||
230 ((ob1->flags[2] & ~0x400000) != (ob2->flags[2] & ~0x400000)) ||
231 ((ob1->flags[3] & ~0x4) != (ob2->flags[3] & ~0x4)) ||
232 (ob1->name != ob2->name) || 229 || ob1->name != ob2->name
233 (ob1->title != ob2->title) || 230 || ob1->title != ob2->title
234 (ob1->msg != ob2->msg) || 231 || ob1->msg != ob2->msg
235 (ob1->weight != ob2->weight) || 232 || ob1->weight != ob2->weight
236 (memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist)) != 0) || 233 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
237 (memcmp (&ob1->stats, &ob2->stats, sizeof (ob1->stats)) != 0) || 234 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
238 (ob1->attacktype != ob2->attacktype) || 235 || ob1->attacktype != ob2->attacktype
239 (ob1->magic != ob2->magic) || 236 || ob1->magic != ob2->magic
240 (ob1->slaying != ob2->slaying) || 237 || ob1->slaying != ob2->slaying
241 (ob1->skill != ob2->skill) || 238 || ob1->skill != ob2->skill
242 (ob1->value != ob2->value) || 239 || ob1->value != ob2->value
243 (ob1->animation_id != ob2->animation_id) || 240 || ob1->animation_id != ob2->animation_id
244 (ob1->client_type != ob2->client_type) || 241 || ob1->client_type != ob2->client_type
245 (ob1->materialname != ob2->materialname) || 242 || ob1->materialname != ob2->materialname
246 (ob1->lore != ob2->lore) || 243 || ob1->lore != ob2->lore
247 (ob1->subtype != ob2->subtype) || 244 || ob1->subtype != ob2->subtype
248 (ob1->move_type != ob2->move_type) || 245 || ob1->move_type != ob2->move_type
249 (ob1->move_block != ob2->move_block) || 246 || ob1->move_block != ob2->move_block
250 (ob1->move_allow != ob2->move_allow) || 247 || ob1->move_allow != ob2->move_allow
251 (ob1->move_on != ob2->move_on) || 248 || ob1->move_on != ob2->move_on
252 (ob1->move_off != ob2->move_off) || (ob1->move_slow != ob2->move_slow) || (ob1->move_slow_penalty != ob2->move_slow_penalty)) 249 || ob1->move_off != ob2->move_off
250 || ob1->move_slow != ob2->move_slow
251 || ob1->move_slow_penalty != ob2->move_slow_penalty)
253 return 0; 252 return 0;
254 253
255 /* This is really a spellbook check - really, we should 254 /* This is really a spellbook check - really, we should
256 * check all objects in the inventory. 255 * check all objects in the inventory.
257 */ 256 */
… …
260 /* if one object has inventory but the other doesn't, not equiv */ 259 /* if one object has inventory but the other doesn't, not equiv */
261 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv)) 260 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv))
262 return 0; 261 return 0;
263 262
264 /* Now check to see if the two inventory objects could merge */ 263 /* Now check to see if the two inventory objects could merge */
265 if (!CAN_MERGE (ob1->inv, ob2->inv)) 264 if (!object::can_merge (ob1->inv, ob2->inv))
266 return 0; 265 return 0;
267 266
268 /* inventory ok - still need to check rest of this object to see 267 /* inventory ok - still need to check rest of this object to see
269 * if it is valid. 268 * if it is valid.
270 */ 269 */
… …
279 278
280 /* Note sure why the following is the case - either the object has to 279 /* Note sure why the following is the case - either the object has to
281 * be animated or have a very low speed. Is this an attempted monster 280 * be animated or have a very low speed. Is this an attempted monster
282 * check? 281 * check?
283 */ 282 */
284 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && FABS ((ob1)->speed) > MIN_ACTIVE_SPEED) 283 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && ob1->has_active_speed ())
285 return 0; 284 return 0;
286 285
287 switch (ob1->type) 286 switch (ob1->type)
288 { 287 {
289 case SCROLL: 288 case SCROLL:
… …
354 op = op->env; 353 op = op->env;
355 return op; 354 return op;
356} 355}
357 356
358/* 357/*
359 * Eneq(@csd.uu.se): Since we can have items buried in a character we need
360 * a better check. We basically keeping traversing up until we can't
361 * or find a player.
362 */
363
364object *
365is_player_inv (object *op)
366{
367 for (; op != NULL && op->type != PLAYER; op = op->env)
368 if (op->env == op)
369 op->env = NULL;
370 return op;
371}
372
373/*
374 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump. 358 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
375 * Some error messages. 359 * Some error messages.
376 * The result of the dump is stored in the static global errmsg array. 360 * The result of the dump is stored in the static global errmsg array.
377 */ 361 */
378 362
… …
381{ 365{
382 if (!op) 366 if (!op)
383 return strdup ("[NULLOBJ]"); 367 return strdup ("[NULLOBJ]");
384 368
385 object_freezer freezer; 369 object_freezer freezer;
386 save_object (freezer, op, 3); 370 save_object (freezer, op, 1);
387 return freezer.as_string (); 371 return freezer.as_string ();
388} 372}
389 373
390/* 374/*
391 * get_nearest_part(multi-object, object 2) returns the part of the 375 * get_nearest_part(multi-object, object 2) returns the part of the
… …
408} 392}
409 393
410/* 394/*
411 * Returns the object which has the count-variable equal to the argument. 395 * Returns the object which has the count-variable equal to the argument.
412 */ 396 */
413
414object * 397object *
415find_object (tag_t i) 398find_object (tag_t i)
416{ 399{
417 for (object *op = object::first; op; op = op->next) 400 for_all_objects (op)
418 if (op->count == i) 401 if (op->count == i)
419 return op; 402 return op;
420 403
421 return 0; 404 return 0;
422} 405}
423 406
424/* 407/*
425 * Returns the first object which has a name equal to the argument. 408 * Returns the first object which has a name equal to the argument.
426 * Used only by the patch command, but not all that useful. 409 * Used only by the patch command, but not all that useful.
427 * Enables features like "patch <name-of-other-player> food 999" 410 * Enables features like "patch <name-of-other-player> food 999"
428 */ 411 */
429
430object * 412object *
431find_object_name (const char *str) 413find_object_name (const char *str)
432{ 414{
433 shstr_cmp str_ (str); 415 shstr_cmp str_ (str);
434 object *op; 416 object *op;
435 417
436 for (op = object::first; op != NULL; op = op->next) 418 for_all_objects (op)
437 if (op->name == str_) 419 if (op->name == str_)
438 break; 420 break;
439 421
440 return op; 422 return op;
441} 423}
… …
484 } 466 }
485 467
486 op->key_values = 0; 468 op->key_values = 0;
487} 469}
488 470
489void object::clear ()
490{
491 attachable_base::clear ();
492
493 free_key_values (this);
494
495 owner = 0;
496 name = 0;
497 name_pl = 0;
498 title = 0;
499 race = 0;
500 slaying = 0;
501 skill = 0;
502 msg = 0;
503 lore = 0;
504 custom_name = 0;
505 materialname = 0;
506 contr = 0;
507 below = 0;
508 above = 0;
509 inv = 0;
510 container = 0;
511 env = 0;
512 more = 0;
513 head = 0;
514 map = 0;
515 active_next = 0;
516 active_prev = 0;
517
518 memset (static_cast<object_pod *>(this), 0, sizeof (object_pod));
519
520 SET_FLAG (this, FLAG_REMOVED);
521
522 /* What is not cleared is next, prev, and count */
523
524 expmul = 1.0;
525 face = blank_face;
526
527 if (settings.casting_time)
528 casting_time = -1;
529}
530
531void object::clone (object *destination)
532{
533 *(object_copy *)destination = *this;
534 *(object_pod *)destination = *this;
535
536 if (self || cb)
537 INVOKE_OBJECT (CLONE, this, ARG_OBJECT (destination));
538}
539
540/* 471/*
541 * copy object first frees everything allocated by the second object, 472 * copy_to first frees everything allocated by the dst object,
542 * and then copies the contends of the first object into the second 473 * and then copies the contents of itself into the second
543 * object, allocating what needs to be allocated. Basically, any 474 * object, allocating what needs to be allocated. Basically, any
544 * data that is malloc'd needs to be re-malloc/copied. Otherwise, 475 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
545 * if the first object is freed, the pointers in the new object 476 * if the first object is freed, the pointers in the new object
546 * will point at garbage. 477 * will point at garbage.
547 */ 478 */
548void 479void
549copy_object (object *op2, object *op) 480object::copy_to (object *dst)
550{ 481{
551 bool is_freed = QUERY_FLAG (op, FLAG_FREED); 482 bool is_freed = QUERY_FLAG (dst, FLAG_FREED);
552 bool is_removed = QUERY_FLAG (op, FLAG_REMOVED); 483 bool is_removed = QUERY_FLAG (dst, FLAG_REMOVED);
553 484
554 op2->clone (op); 485 *(object_copy *)dst = *this;
555 486
556 if (is_freed) 487 if (is_freed)
557 SET_FLAG (op, FLAG_FREED); 488 SET_FLAG (dst, FLAG_FREED);
558 489
559 if (is_removed) 490 if (is_removed)
560 SET_FLAG (op, FLAG_REMOVED); 491 SET_FLAG (dst, FLAG_REMOVED);
561 492
562 if (op2->speed < 0) 493 if (speed < 0)
563 op->speed_left = op2->speed_left - RANDOM () % 200 / 100.0; 494 dst->speed_left = speed_left - rndm ();
564 495
565 /* Copy over key_values, if any. */ 496 /* Copy over key_values, if any. */
566 if (op2->key_values) 497 if (key_values)
567 { 498 {
568 key_value *tail = 0; 499 key_value *tail = 0;
569 key_value *i; 500 key_value *i;
570 501
571 op->key_values = 0; 502 dst->key_values = 0;
572 503
573 for (i = op2->key_values; i; i = i->next) 504 for (i = key_values; i; i = i->next)
574 { 505 {
575 key_value *new_link = new key_value; 506 key_value *new_link = new key_value;
576 507
577 new_link->next = 0; 508 new_link->next = 0;
578 new_link->key = i->key; 509 new_link->key = i->key;
579 new_link->value = i->value; 510 new_link->value = i->value;
580 511
581 /* Try and be clever here, too. */ 512 /* Try and be clever here, too. */
582 if (!op->key_values) 513 if (!dst->key_values)
583 { 514 {
584 op->key_values = new_link; 515 dst->key_values = new_link;
585 tail = new_link; 516 tail = new_link;
586 } 517 }
587 else 518 else
588 { 519 {
589 tail->next = new_link; 520 tail->next = new_link;
590 tail = new_link; 521 tail = new_link;
591 } 522 }
592 } 523 }
593 } 524 }
594 525
595 update_ob_speed (op); 526 dst->set_speed (dst->speed);
527}
528
529object *
530object::clone ()
531{
532 object *neu = create ();
533 copy_to (neu);
534 return neu;
596} 535}
597 536
598/* 537/*
599 * If an object with the IS_TURNABLE() flag needs to be turned due 538 * If an object with the IS_TURNABLE() flag needs to be turned due
600 * to the closest player being on the other side, this function can 539 * to the closest player being on the other side, this function can
601 * be called to update the face variable, _and_ how it looks on the map. 540 * be called to update the face variable, _and_ how it looks on the map.
602 */ 541 */
603
604void 542void
605update_turn_face (object *op) 543update_turn_face (object *op)
606{ 544{
607 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || op->arch == NULL) 545 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || !op->arch)
608 return; 546 return;
547
609 SET_ANIMATION (op, op->direction); 548 SET_ANIMATION (op, op->direction);
610 update_object (op, UP_OBJ_FACE); 549 update_object (op, UP_OBJ_FACE);
611} 550}
612 551
613/* 552/*
614 * Updates the speed of an object. If the speed changes from 0 to another 553 * Updates the speed of an object. If the speed changes from 0 to another
615 * value, or vice versa, then add/remove the object from the active list. 554 * value, or vice versa, then add/remove the object from the active list.
616 * This function needs to be called whenever the speed of an object changes. 555 * This function needs to be called whenever the speed of an object changes.
617 */ 556 */
618void 557void
619update_ob_speed (object *op) 558object::set_speed (float speed)
620{ 559{
621 extern int arch_init; 560 if (flag [FLAG_FREED] && speed)
622
623 /* No reason putting the archetypes objects on the speed list,
624 * since they never really need to be updated.
625 */
626
627 if (QUERY_FLAG (op, FLAG_FREED) && op->speed)
628 { 561 {
629 LOG (llevError, "Object %s is freed but has speed.\n", &op->name); 562 LOG (llevError, "Object %s is freed but has speed.\n", &name);
630#ifdef MANY_CORES
631 abort ();
632#else
633 op->speed = 0; 563 speed = 0;
634#endif
635 }
636
637 if (arch_init)
638 return;
639
640 if (FABS (op->speed) > MIN_ACTIVE_SPEED)
641 { 564 }
642 /* If already on active list, don't do anything */
643 if (op->active_next || op->active_prev || op == active_objects)
644 return;
645 565
646 /* process_events() expects us to insert the object at the beginning 566 this->speed = speed;
647 * of the list. */
648 op->active_next = active_objects;
649 567
650 if (op->active_next != NULL) 568 if (has_active_speed ())
651 op->active_next->active_prev = op; 569 activate ();
652
653 active_objects = op;
654 }
655 else 570 else
656 { 571 deactivate ();
657 /* If not on the active list, nothing needs to be done */
658 if (!op->active_next && !op->active_prev && op != active_objects)
659 return;
660
661 if (op->active_prev == NULL)
662 {
663 active_objects = op->active_next;
664
665 if (op->active_next != NULL)
666 op->active_next->active_prev = NULL;
667 }
668 else
669 {
670 op->active_prev->active_next = op->active_next;
671
672 if (op->active_next)
673 op->active_next->active_prev = op->active_prev;
674 }
675
676 op->active_next = NULL;
677 op->active_prev = NULL;
678 }
679} 572}
680 573
681/* This function removes object 'op' from the list of active
682 * objects.
683 * This should only be used for style maps or other such
684 * reference maps where you don't want an object that isn't
685 * in play chewing up cpu time getting processed.
686 * The reverse of this is to call update_ob_speed, which
687 * will do the right thing based on the speed of the object.
688 */
689void
690remove_from_active_list (object *op)
691{
692 /* If not on the active list, nothing needs to be done */
693 if (!op->active_next && !op->active_prev && op != active_objects)
694 return;
695
696 if (op->active_prev == NULL)
697 {
698 active_objects = op->active_next;
699 if (op->active_next != NULL)
700 op->active_next->active_prev = NULL;
701 }
702 else
703 {
704 op->active_prev->active_next = op->active_next;
705 if (op->active_next)
706 op->active_next->active_prev = op->active_prev;
707 }
708 op->active_next = NULL;
709 op->active_prev = NULL;
710}
711
712/* 574/*
713 * update_object() updates the array which represents the map. 575 * update_object() updates the the map.
714 * It takes into account invisible objects (and represent squares covered 576 * It takes into account invisible objects (and represent squares covered
715 * by invisible objects by whatever is below them (unless it's another 577 * by invisible objects by whatever is below them (unless it's another
716 * invisible object, etc...) 578 * invisible object, etc...)
717 * If the object being updated is beneath a player, the look-window 579 * If the object being updated is beneath a player, the look-window
718 * of that player is updated (this might be a suboptimal way of 580 * of that player is updated (this might be a suboptimal way of
719 * updating that window, though, since update_object() is called _often_) 581 * updating that window, though, since update_object() is called _often_)
720 * 582 *
721 * action is a hint of what the caller believes need to be done. 583 * action is a hint of what the caller believes need to be done.
722 * For example, if the only thing that has changed is the face (due to
723 * an animation), we don't need to call update_position until that actually
724 * comes into view of a player. OTOH, many other things, like addition/removal
725 * of walls or living creatures may need us to update the flags now.
726 * current action are: 584 * current action are:
727 * UP_OBJ_INSERT: op was inserted 585 * UP_OBJ_INSERT: op was inserted
728 * UP_OBJ_REMOVE: op was removed 586 * UP_OBJ_REMOVE: op was removed
729 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update 587 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update
730 * as that is easier than trying to look at what may have changed. 588 * as that is easier than trying to look at what may have changed.
731 * UP_OBJ_FACE: only the objects face has changed. 589 * UP_OBJ_FACE: only the objects face has changed.
732 */ 590 */
733
734void 591void
735update_object (object *op, int action) 592update_object (object *op, int action)
736{ 593{
737 int update_now = 0, flags;
738 MoveType move_on, move_off, move_block, move_slow; 594 MoveType move_on, move_off, move_block, move_slow;
739 595
740 if (op == NULL) 596 if (op == NULL)
741 { 597 {
742 /* this should never happen */ 598 /* this should never happen */
743 LOG (llevDebug, "update_object() called for NULL object.\n"); 599 LOG (llevDebug, "update_object() called for NULL object.\n");
744 return; 600 return;
745 } 601 }
746 602
747 if (op->env != NULL) 603 if (op->env)
748 { 604 {
749 /* Animation is currently handled by client, so nothing 605 /* Animation is currently handled by client, so nothing
750 * to do in this case. 606 * to do in this case.
751 */ 607 */
752 return; 608 return;
… …
757 */ 613 */
758 if (!op->map || op->map->in_memory == MAP_SAVING) 614 if (!op->map || op->map->in_memory == MAP_SAVING)
759 return; 615 return;
760 616
761 /* make sure the object is within map boundaries */ 617 /* make sure the object is within map boundaries */
762 if (op->x < 0 || op->x >= MAP_WIDTH (op->map) || op->y < 0 || op->y >= MAP_HEIGHT (op->map)) 618 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
763 { 619 {
764 LOG (llevError, "update_object() called for object out of map!\n"); 620 LOG (llevError, "update_object() called for object out of map!\n");
765#ifdef MANY_CORES 621#ifdef MANY_CORES
766 abort (); 622 abort ();
767#endif 623#endif
768 return; 624 return;
769 } 625 }
770 626
771 flags = GET_MAP_FLAGS (op->map, op->x, op->y); 627 mapspace &m = op->ms ();
772 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NEED_UPDATE);
773 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
774 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
775 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
776 move_off = GET_MAP_MOVE_OFF (op->map, op->x, op->y);
777 628
629 if (!(m.flags_ & P_UPTODATE))
630 /* nop */;
778 if (action == UP_OBJ_INSERT) 631 else if (action == UP_OBJ_INSERT)
779 { 632 {
633 // this is likely overkill, TODO: revisit (schmorp)
780 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(flags & P_BLOCKSVIEW)) 634 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
781 update_now = 1;
782
783 if (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(flags & P_NO_MAGIC)) 635 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
784 update_now = 1; 636 || (op->type == PLAYER && !(m.flags_ & P_PLAYER))
785 637 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
638 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
786 if (QUERY_FLAG (op, FLAG_DAMNED) && !(flags & P_NO_CLERIC)) 639 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
787 update_now = 1;
788
789 if (QUERY_FLAG (op, FLAG_ALIVE) && !(flags & P_IS_ALIVE))
790 update_now = 1;
791
792 if (op->type == SAFE_GROUND && !(flags & P_SAFE))
793 update_now = 1;
794
795 if ((move_on | op->move_on) != move_on) 640 || (m.move_on | op->move_on ) != m.move_on
796 update_now = 1;
797
798 if ((move_off | op->move_off) != move_off) 641 || (m.move_off | op->move_off ) != m.move_off
799 update_now = 1; 642 || (m.move_slow | op->move_slow) != m.move_slow
800
801 /* This isn't perfect, but I don't expect a lot of objects to 643 /* This isn't perfect, but I don't expect a lot of objects to
802 * to have move_allow right now. 644 * to have move_allow right now.
803 */ 645 */
804 if (((move_block | op->move_block) & ~op->move_allow) != move_block) 646 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
805 update_now = 1; 647 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
806 648 m.flags_ = 0;
807 if ((move_slow | op->move_slow) != move_slow)
808 update_now = 1;
809 } 649 }
810
811 /* if the object is being removed, we can't make intelligent 650 /* if the object is being removed, we can't make intelligent
812 * decisions, because remove_ob can't really pass the object 651 * decisions, because remove_ob can't really pass the object
813 * that is being removed. 652 * that is being removed.
814 */ 653 */
815 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 654 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
816 update_now = 1; 655 m.flags_ = 0;
817 else if (action == UP_OBJ_FACE) 656 else if (action == UP_OBJ_FACE)
818 /* Nothing to do for that case */ ; 657 /* Nothing to do for that case */ ;
819 else 658 else
820 LOG (llevError, "update_object called with invalid action: %d\n", action); 659 LOG (llevError, "update_object called with invalid action: %d\n", action);
821 660
822 if (update_now)
823 {
824 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NO_ERROR | P_NEED_UPDATE);
825 update_position (op->map, op->x, op->y);
826 }
827
828 if (op->more != NULL) 661 if (op->more)
829 update_object (op->more, action); 662 update_object (op->more, action);
830}
831
832object::vector object::mortals;
833object::vector object::objects; // not yet used
834object *object::first;
835
836void object::free_mortals ()
837{
838 for (AUTODECL (i, mortals.begin ()); i != mortals.end ();)
839 if ((*i)->refcnt)
840 ++i; // further delay freeing
841 else
842 {
843 delete *i;
844 mortals.erase (i);
845 }
846} 663}
847 664
848object::object () 665object::object ()
849{ 666{
850 SET_FLAG (this, FLAG_REMOVED); 667 SET_FLAG (this, FLAG_REMOVED);
… …
853 face = blank_face; 670 face = blank_face;
854} 671}
855 672
856object::~object () 673object::~object ()
857{ 674{
675 unlink ();
676
858 free_key_values (this); 677 free_key_values (this);
859} 678}
860 679
680static int object_count;
681
861void object::link () 682void object::link ()
862{ 683{
863 count = ++ob_count; 684 assert (!index);//D
864 uuid = gen_uuid (); 685 uuid = gen_uuid ();
686 count = ++object_count;
865 687
866 prev = 0; 688 refcnt_inc ();
867 next = object::first; 689 objects.insert (this);
868
869 if (object::first)
870 object::first->prev = this;
871
872 object::first = this;
873} 690}
874 691
875void object::unlink () 692void object::unlink ()
876{ 693{
877 if (this == object::first) 694 if (!index)
878 object::first = next; 695 return;
879 696
880 /* Remove this object from the list of used objects */ 697 objects.erase (this);
881 if (prev) prev->next = next; 698 refcnt_dec ();
882 if (next) next->prev = prev; 699}
883 700
884 prev = 0; 701void
885 next = 0; 702object::activate ()
703{
704 /* If already on active list, don't do anything */
705 if (active)
706 return;
707
708 if (has_active_speed ())
709 actives.insert (this);
710}
711
712void
713object::activate_recursive ()
714{
715 activate ();
716
717 for (object *op = inv; op; op = op->below)
718 op->activate_recursive ();
719}
720
721/* This function removes object 'op' from the list of active
722 * objects.
723 * This should only be used for style maps or other such
724 * reference maps where you don't want an object that isn't
725 * in play chewing up cpu time getting processed.
726 * The reverse of this is to call update_ob_speed, which
727 * will do the right thing based on the speed of the object.
728 */
729void
730object::deactivate ()
731{
732 /* If not on the active list, nothing needs to be done */
733 if (!active)
734 return;
735
736 actives.erase (this);
737}
738
739void
740object::deactivate_recursive ()
741{
742 for (object *op = inv; op; op = op->below)
743 op->deactivate_recursive ();
744
745 deactivate ();
746}
747
748void
749object::set_flag_inv (int flag, int value)
750{
751 for (object *op = inv; op; op = op->below)
752 {
753 op->flag [flag] = value;
754 op->set_flag_inv (flag, value);
755 }
756}
757
758/*
759 * Remove and free all objects in the inventory of the given object.
760 * object.c ?
761 */
762void
763object::destroy_inv (bool drop_to_ground)
764{
765 // need to check first, because the checks below might segfault
766 // as we might be on an invalid mapspace and crossfire code
767 // is too buggy to ensure that the inventory is empty.
768 // corollary: if you create arrows etc. with stuff in tis inventory,
769 // cf will crash below with off-map x and y
770 if (!inv)
771 return;
772
773 /* Only if the space blocks everything do we not process -
774 * if some form of movement is allowed, let objects
775 * drop on that space.
776 */
777 if (!drop_to_ground
778 || !map
779 || map->in_memory != MAP_IN_MEMORY
780 || map->nodrop
781 || ms ().move_block == MOVE_ALL)
782 {
783 while (inv)
784 {
785 inv->destroy_inv (drop_to_ground);
786 inv->destroy ();
787 }
788 }
789 else
790 { /* Put objects in inventory onto this space */
791 while (inv)
792 {
793 object *op = inv;
794
795 if (op->flag [FLAG_STARTEQUIP]
796 || op->flag [FLAG_NO_DROP]
797 || op->type == RUNE
798 || op->type == TRAP
799 || op->flag [FLAG_IS_A_TEMPLATE]
800 || op->flag [FLAG_DESTROY_ON_DEATH])
801 op->destroy ();
802 else
803 map->insert (op, x, y);
804 }
805 }
886} 806}
887 807
888object *object::create () 808object *object::create ()
889{ 809{
890 object *op = new object; 810 object *op = new object;
891 op->link (); 811 op->link ();
892 return op; 812 return op;
893} 813}
894 814
895/* 815void
896 * free_object() frees everything allocated by an object, removes 816object::do_destroy ()
897 * it from the list of used objects, and puts it on the list of
898 * free objects. The IS_FREED() flag is set in the object.
899 * The object must have been removed by remove_ob() first for
900 * this function to succeed.
901 *
902 * If destroy_inventory is set, free inventory as well. Else drop items in
903 * inventory to the ground.
904 */
905void object::destroy (bool destroy_inventory)
906{ 817{
907 if (QUERY_FLAG (this, FLAG_FREED)) 818 attachable::do_destroy ();
908 return;
909 819
910 if (QUERY_FLAG (this, FLAG_FRIENDLY)) 820 if (flag [FLAG_IS_LINKED])
821 remove_button_link (this);
822
823 if (flag [FLAG_FRIENDLY])
824 {
911 remove_friendly_object (this); 825 remove_friendly_object (this);
912 826
913 if (!QUERY_FLAG (this, FLAG_REMOVED)) 827 if (type == GOLEM
828 && owner
829 && owner->type == PLAYER
830 && owner->contr->ranges[range_golem] == this)
831 owner->contr->ranges[range_golem] = 0;
832 }
833
834 if (!flag [FLAG_REMOVED])
914 remove (); 835 remove ();
915 836
916 SET_FLAG (this, FLAG_FREED); 837 destroy_inv (true);
917 838
918 if (more) 839 deactivate ();
919 { 840 unlink ();
920 more->destroy (destroy_inventory);
921 more = 0;
922 }
923 841
924 if (inv) 842 flag [FLAG_FREED] = 1;
925 {
926 /* Only if the space blocks everything do we not process -
927 * if some form of movement is allowed, let objects
928 * drop on that space.
929 */
930 if (destroy_inventory || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL)
931 {
932 object *op = inv;
933
934 while (op)
935 {
936 object *tmp = op->below;
937 op->destroy (destroy_inventory);
938 op = tmp;
939 }
940 }
941 else
942 { /* Put objects in inventory onto this space */
943 object *op = inv;
944
945 while (op)
946 {
947 object *tmp = op->below;
948
949 op->remove ();
950
951 if (QUERY_FLAG (op, FLAG_STARTEQUIP)
952 || QUERY_FLAG (op, FLAG_NO_DROP) || op->type == RUNE || op->type == TRAP || QUERY_FLAG (op, FLAG_IS_A_TEMPLATE))
953 op->destroy (0);
954 else
955 {
956 op->x = x;
957 op->y = y;
958 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
959 }
960
961 op = tmp;
962 }
963 }
964 }
965 843
966 // hack to ensure that freed objects still have a valid map 844 // hack to ensure that freed objects still have a valid map
967 { 845 {
968 static maptile *freed_map; // freed objects are moved here to avoid crashes 846 static maptile *freed_map; // freed objects are moved here to avoid crashes
969 847
… …
973 851
974 freed_map->name = "/internal/freed_objects_map"; 852 freed_map->name = "/internal/freed_objects_map";
975 freed_map->width = 3; 853 freed_map->width = 3;
976 freed_map->height = 3; 854 freed_map->height = 3;
977 855
978 freed_map->allocate (); 856 freed_map->alloc ();
857 freed_map->in_memory = MAP_IN_MEMORY;
979 } 858 }
980 859
981 map = freed_map; 860 map = freed_map;
982 x = 1; 861 x = 1;
983 y = 1; 862 y = 1;
984 } 863 }
985 864
865 head = 0;
866
867 if (more)
868 {
869 more->destroy ();
870 more = 0;
871 }
872
986 // clear those pointers that likely might have circular references to us 873 // clear those pointers that likely might have circular references to us
987 owner = 0; 874 owner = 0;
988 enemy = 0; 875 enemy = 0;
989 attacked_by = 0; 876 attacked_by = 0;
877}
990 878
991 // only relevant for players(?), but make sure of it anyways 879void
992 contr = 0; 880object::destroy (bool destroy_inventory)
881{
882 if (destroyed ())
883 return;
993 884
994 /* Remove object from the active list */ 885 if (destroy_inventory)
995 speed = 0; 886 destroy_inv (false);
996 update_ob_speed (this);
997 887
998 unlink (); 888 attachable::destroy ();
999
1000 mortals.push_back (this);
1001} 889}
1002 890
1003/* 891/*
1004 * sub_weight() recursively (outwards) subtracts a number from the 892 * sub_weight() recursively (outwards) subtracts a number from the
1005 * weight of an object (and what is carried by it's environment(s)). 893 * weight of an object (and what is carried by it's environment(s)).
… …
1021 * This function removes the object op from the linked list of objects 909 * This function removes the object op from the linked list of objects
1022 * which it is currently tied to. When this function is done, the 910 * which it is currently tied to. When this function is done, the
1023 * object will have no environment. If the object previously had an 911 * object will have no environment. If the object previously had an
1024 * environment, the x and y coordinates will be updated to 912 * environment, the x and y coordinates will be updated to
1025 * the previous environment. 913 * the previous environment.
1026 * Beware: This function is called from the editor as well!
1027 */ 914 */
1028void 915void
1029object::remove () 916object::do_remove ()
1030{ 917{
1031 object *tmp, *last = 0; 918 object *tmp, *last = 0;
1032 object *otmp; 919 object *otmp;
1033 920
1034 int check_walk_off;
1035
1036 if (QUERY_FLAG (this, FLAG_REMOVED)) 921 if (QUERY_FLAG (this, FLAG_REMOVED))
1037 return; 922 return;
1038 923
1039 SET_FLAG (this, FLAG_REMOVED); 924 SET_FLAG (this, FLAG_REMOVED);
925 INVOKE_OBJECT (REMOVE, this);
1040 926
1041 if (more) 927 if (more)
1042 more->remove (); 928 more->remove ();
1043 929
1044 /* 930 /*
… …
1054 940
1055 /* NO_FIX_PLAYER is set when a great many changes are being 941 /* NO_FIX_PLAYER is set when a great many changes are being
1056 * made to players inventory. If set, avoiding the call 942 * made to players inventory. If set, avoiding the call
1057 * to save cpu time. 943 * to save cpu time.
1058 */ 944 */
1059 if ((otmp = is_player_inv (env)) != NULL && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 945 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1060 fix_player (otmp); 946 otmp->update_stats ();
1061 947
1062 if (above != NULL) 948 if (above)
1063 above->below = below; 949 above->below = below;
1064 else 950 else
1065 env->inv = below; 951 env->inv = below;
1066 952
1067 if (below != NULL) 953 if (below)
1068 below->above = above; 954 below->above = above;
1069 955
1070 /* we set up values so that it could be inserted into 956 /* we set up values so that it could be inserted into
1071 * the map, but we don't actually do that - it is up 957 * the map, but we don't actually do that - it is up
1072 * to the caller to decide what we want to do. 958 * to the caller to decide what we want to do.
… …
1076 above = 0, below = 0; 962 above = 0, below = 0;
1077 env = 0; 963 env = 0;
1078 } 964 }
1079 else if (map) 965 else if (map)
1080 { 966 {
1081 /* Re did the following section of code - it looks like it had 967 if (type == PLAYER)
1082 * lots of logic for things we no longer care about
1083 */ 968 {
969 --map->players;
970 map->touch ();
971 }
972
973 map->dirty = true;
974 mapspace &ms = this->ms ();
1084 975
1085 /* link the object above us */ 976 /* link the object above us */
1086 if (above) 977 if (above)
1087 above->below = below; 978 above->below = below;
1088 else 979 else
1089 SET_MAP_TOP (map, x, y, below); /* we were top, set new top */ 980 ms.top = below; /* we were top, set new top */
1090 981
1091 /* Relink the object below us, if there is one */ 982 /* Relink the object below us, if there is one */
1092 if (below) 983 if (below)
1093 below->above = above; 984 below->above = above;
1094 else 985 else
… …
1096 /* Nothing below, which means we need to relink map object for this space 987 /* Nothing below, which means we need to relink map object for this space
1097 * use translated coordinates in case some oddness with map tiling is 988 * use translated coordinates in case some oddness with map tiling is
1098 * evident 989 * evident
1099 */ 990 */
1100 if (GET_MAP_OB (map, x, y) != this) 991 if (GET_MAP_OB (map, x, y) != this)
1101 {
1102 char *dump = dump_object (this);
1103 LOG (llevError,
1104 "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", dump); 992 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1105 free (dump);
1106 dump = dump_object (GET_MAP_OB (map, x, y));
1107 LOG (llevError, "%s\n", dump);
1108 free (dump);
1109 }
1110 993
1111 SET_MAP_OB (map, x, y, above); /* goes on above it. */ 994 ms.bot = above; /* goes on above it. */
1112 } 995 }
1113 996
1114 above = 0; 997 above = 0;
1115 below = 0; 998 below = 0;
1116 999
1117 if (map->in_memory == MAP_SAVING) 1000 if (map->in_memory == MAP_SAVING)
1118 return; 1001 return;
1119 1002
1120 check_walk_off = !QUERY_FLAG (this, FLAG_NO_APPLY); 1003 int check_walk_off = !flag [FLAG_NO_APPLY];
1121 1004
1122 for (tmp = GET_MAP_OB (map, x, y); tmp; tmp = tmp->above) 1005 for (tmp = ms.bot; tmp; tmp = tmp->above)
1123 { 1006 {
1124 /* No point updating the players look faces if he is the object 1007 /* No point updating the players look faces if he is the object
1125 * being removed. 1008 * being removed.
1126 */ 1009 */
1127 1010
… …
1131 * removed (most likely destroyed), update the player view 1014 * removed (most likely destroyed), update the player view
1132 * appropriately. 1015 * appropriately.
1133 */ 1016 */
1134 if (tmp->container == this) 1017 if (tmp->container == this)
1135 { 1018 {
1136 CLEAR_FLAG (this, FLAG_APPLIED); 1019 flag [FLAG_APPLIED] = 0;
1137 tmp->container = 0; 1020 tmp->container = 0;
1138 } 1021 }
1139 1022
1140 tmp->contr->socket.update_look = 1; 1023 if (tmp->contr->ns)
1024 tmp->contr->ns->floorbox_update ();
1141 } 1025 }
1142 1026
1143 /* See if player moving off should effect something */ 1027 /* See if object moving off should effect something */
1144 if (check_walk_off 1028 if (check_walk_off
1145 && ((move_type & tmp->move_off) 1029 && ((move_type & tmp->move_off)
1146 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1030 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0))
1147 { 1031 {
1148 move_apply (tmp, this, 0); 1032 move_apply (tmp, this, 0);
… …
1150 if (destroyed ()) 1034 if (destroyed ())
1151 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ()); 1035 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1152 } 1036 }
1153 1037
1154 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */ 1038 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */
1155 1039 //TODO: why is this horrible hacka fix? get rid of this code=bug! (schmorp)
1156 if (tmp->above == tmp) 1040 if (tmp->above == tmp)
1157 tmp->above = 0; 1041 tmp->above = 0;
1158 1042
1159 last = tmp; 1043 last = tmp;
1160 } 1044 }
1161 1045
1162 /* last == NULL of there are no objects on this space */ 1046 /* last == NULL if there are no objects on this space */
1047 //TODO: this makes little sense, why only update the topmost object?
1163 if (!last) 1048 if (!last)
1164 { 1049 map->at (x, y).flags_ = 0;
1165 /* set P_NEED_UPDATE, otherwise update_position will complain. In theory,
1166 * we could preserve the flags (GET_MAP_FLAGS), but update_position figures
1167 * those out anyways, and if there are any flags set right now, they won't
1168 * be correct anyways.
1169 */
1170 SET_MAP_FLAGS (map, x, y, P_NEED_UPDATE);
1171 update_position (map, x, y);
1172 }
1173 else 1050 else
1174 update_object (last, UP_OBJ_REMOVE); 1051 update_object (last, UP_OBJ_REMOVE);
1175 1052
1176 if (QUERY_FLAG (this, FLAG_BLOCKSVIEW) || glow_radius) 1053 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1177 update_all_los (map, x, y); 1054 update_all_los (map, x, y);
1178 } 1055 }
1179} 1056}
1180 1057
1181/* 1058/*
… …
1190merge_ob (object *op, object *top) 1067merge_ob (object *op, object *top)
1191{ 1068{
1192 if (!op->nrof) 1069 if (!op->nrof)
1193 return 0; 1070 return 0;
1194 1071
1195 if (top == NULL) 1072 if (top)
1196 for (top = op; top != NULL && top->above != NULL; top = top->above); 1073 for (top = op; top && top->above; top = top->above)
1074 ;
1197 1075
1198 for (; top != NULL; top = top->below) 1076 for (; top; top = top->below)
1199 { 1077 {
1200 if (top == op) 1078 if (top == op)
1201 continue; 1079 continue;
1202 if (CAN_MERGE (op, top)) 1080
1081 if (object::can_merge (op, top))
1203 { 1082 {
1204 top->nrof += op->nrof; 1083 top->nrof += op->nrof;
1205 1084
1206/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/ 1085/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/
1207 op->weight = 0; /* Don't want any adjustements now */ 1086 op->weight = 0; /* Don't want any adjustements now */
1208 op->remove ();
1209 op->destroy (0); 1087 op->destroy ();
1210 return top; 1088 return top;
1211 } 1089 }
1212 } 1090 }
1213 1091
1214 return 0; 1092 return 0;
1215} 1093}
1216 1094
1217/* 1095/*
1218 * same as insert_ob_in_map except it handle separate coordinates and do a clean 1096 * same as insert_ob_in_map except it handles separate coordinates and does a clean
1219 * job preparing multi-part monsters 1097 * job preparing multi-part monsters.
1220 */ 1098 */
1221object * 1099object *
1222insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1100insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1223{ 1101{
1224 object *tmp;
1225
1226 if (op->head)
1227 op = op->head;
1228
1229 for (tmp = op; tmp; tmp = tmp->more) 1102 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1230 { 1103 {
1231 tmp->x = x + tmp->arch->clone.x; 1104 tmp->x = x + tmp->arch->clone.x;
1232 tmp->y = y + tmp->arch->clone.y; 1105 tmp->y = y + tmp->arch->clone.y;
1233 } 1106 }
1234 1107
… …
1253 * Return value: 1126 * Return value:
1254 * new object if 'op' was merged with other object 1127 * new object if 'op' was merged with other object
1255 * NULL if 'op' was destroyed 1128 * NULL if 'op' was destroyed
1256 * just 'op' otherwise 1129 * just 'op' otherwise
1257 */ 1130 */
1258
1259object * 1131object *
1260insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1132insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1261{ 1133{
1262 object *tmp, *top, *floor = NULL; 1134 object *tmp, *top, *floor = NULL;
1263 sint16 x, y;
1264 1135
1265 if (QUERY_FLAG (op, FLAG_FREED)) 1136 if (QUERY_FLAG (op, FLAG_FREED))
1266 { 1137 {
1267 LOG (llevError, "Trying to insert freed object!\n"); 1138 LOG (llevError, "Trying to insert freed object!\n");
1268 return NULL; 1139 return NULL;
1269 } 1140 }
1270 1141
1271 if (m == NULL) 1142 if (!QUERY_FLAG (op, FLAG_REMOVED))
1143 LOG (llevError, "Trying to insert already inserted object %s\n", op->debug_desc ());
1144
1145 op->remove ();
1146
1147 if (!m)
1272 { 1148 {
1273 char *dump = dump_object (op); 1149 char *dump = dump_object (op);
1274 LOG (llevError, "Trying to insert in null-map!\n%s\n", dump); 1150 LOG (llevError, "Trying to insert in null-map!\n%s\n", dump);
1275 free (dump); 1151 free (dump);
1276 return op; 1152 return op;
… …
1289#endif 1165#endif
1290 free (dump); 1166 free (dump);
1291 return op; 1167 return op;
1292 } 1168 }
1293 1169
1294 if (!QUERY_FLAG (op, FLAG_REMOVED))
1295 {
1296 char *dump = dump_object (op);
1297 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", dump);
1298 free (dump);
1299 return op;
1300 }
1301
1302 if (op->more != NULL)
1303 {
1304 /* The part may be on a different map. */
1305
1306 object *more = op->more; 1170 if (object *more = op->more)
1307 1171 {
1308 /* We really need the caller to normalize coordinates - if
1309 * we set the map, that doesn't work if the location is within
1310 * a map and this is straddling an edge. So only if coordinate
1311 * is clear wrong do we normalize it.
1312 */
1313 if (OUT_OF_REAL_MAP (more->map, more->x, more->y))
1314 more->map = get_map_from_coord (m, &more->x, &more->y);
1315 else if (!more->map)
1316 {
1317 /* For backwards compatibility - when not dealing with tiled maps,
1318 * more->map should always point to the parent.
1319 */
1320 more->map = m;
1321 }
1322
1323 if (insert_ob_in_map (more, more->map, originator, flag) == NULL) 1172 if (!insert_ob_in_map (more, m, originator, flag))
1324 { 1173 {
1325 if (!op->head) 1174 if (!op->head)
1326 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n"); 1175 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n");
1327 1176
1328 return NULL; 1177 return 0;
1329 } 1178 }
1330 } 1179 }
1331 1180
1332 CLEAR_FLAG (op, FLAG_REMOVED); 1181 CLEAR_FLAG (op, FLAG_REMOVED);
1333 1182
1334 /* Ideally, the caller figures this out. However, it complicates a lot 1183 /* Ideally, the caller figures this out. However, it complicates a lot
1335 * of areas of callers (eg, anything that uses find_free_spot would now 1184 * of areas of callers (eg, anything that uses find_free_spot would now
1336 * need extra work 1185 * need extra work
1337 */ 1186 */
1338 op->map = get_map_from_coord (m, &op->x, &op->y); 1187 if (!xy_normalise (m, op->x, op->y))
1339 x = op->x; 1188 return 0;
1340 y = op->y; 1189
1190 op->map = m;
1191 mapspace &ms = op->ms ();
1341 1192
1342 /* this has to be done after we translate the coordinates. 1193 /* this has to be done after we translate the coordinates.
1343 */ 1194 */
1344 if (op->nrof && !(flag & INS_NO_MERGE)) 1195 if (op->nrof && !(flag & INS_NO_MERGE))
1345 for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above) 1196 for (tmp = ms.bot; tmp; tmp = tmp->above)
1346 if (CAN_MERGE (op, tmp)) 1197 if (object::can_merge (op, tmp))
1347 { 1198 {
1348 op->nrof += tmp->nrof; 1199 op->nrof += tmp->nrof;
1349 tmp->remove ();
1350 tmp->destroy (0); 1200 tmp->destroy ();
1351 } 1201 }
1352 1202
1353 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1203 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1354 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1204 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1355 1205
… …
1368 op->below = originator->below; 1218 op->below = originator->below;
1369 1219
1370 if (op->below) 1220 if (op->below)
1371 op->below->above = op; 1221 op->below->above = op;
1372 else 1222 else
1373 SET_MAP_OB (op->map, op->x, op->y, op); 1223 ms.bot = op;
1374 1224
1375 /* since *below* originator, no need to update top */ 1225 /* since *below* originator, no need to update top */
1376 originator->below = op; 1226 originator->below = op;
1377 } 1227 }
1378 else 1228 else
1379 { 1229 {
1230 top = ms.bot;
1231
1380 /* If there are other objects, then */ 1232 /* If there are other objects, then */
1381 if ((!(flag & INS_MAP_LOAD)) && ((top = GET_MAP_OB (op->map, op->x, op->y)) != NULL)) 1233 if ((!(flag & INS_MAP_LOAD)) && top)
1382 { 1234 {
1383 object *last = NULL; 1235 object *last = 0;
1384 1236
1385 /* 1237 /*
1386 * If there are multiple objects on this space, we do some trickier handling. 1238 * If there are multiple objects on this space, we do some trickier handling.
1387 * We've already dealt with merging if appropriate. 1239 * We've already dealt with merging if appropriate.
1388 * Generally, we want to put the new object on top. But if 1240 * Generally, we want to put the new object on top. But if
… …
1392 * once we get to them. This reduces the need to traverse over all of 1244 * once we get to them. This reduces the need to traverse over all of
1393 * them when adding another one - this saves quite a bit of cpu time 1245 * them when adding another one - this saves quite a bit of cpu time
1394 * when lots of spells are cast in one area. Currently, it is presumed 1246 * when lots of spells are cast in one area. Currently, it is presumed
1395 * that flying non pickable objects are spell objects. 1247 * that flying non pickable objects are spell objects.
1396 */ 1248 */
1397 1249 for (top = ms.bot; top; top = top->above)
1398 while (top != NULL)
1399 { 1250 {
1400 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1251 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))
1401 floor = top; 1252 floor = top;
1402 1253
1403 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1254 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))
… …
1406 top = top->below; 1257 top = top->below;
1407 break; 1258 break;
1408 } 1259 }
1409 1260
1410 last = top; 1261 last = top;
1411 top = top->above;
1412 } 1262 }
1413 1263
1414 /* Don't want top to be NULL, so set it to the last valid object */ 1264 /* Don't want top to be NULL, so set it to the last valid object */
1415 top = last; 1265 top = last;
1416 1266
… …
1423 * Unless those objects are exits, type 66 1273 * Unless those objects are exits, type 66
1424 * If INS_ON_TOP is used, don't do this processing 1274 * If INS_ON_TOP is used, don't do this processing
1425 * Need to find the object that in fact blocks view, otherwise 1275 * Need to find the object that in fact blocks view, otherwise
1426 * stacking is a bit odd. 1276 * stacking is a bit odd.
1427 */ 1277 */
1428 if (!(flag & INS_ON_TOP) && 1278 if (!(flag & INS_ON_TOP)
1429 (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_BLOCKSVIEW) && (op->face && !op->face->visibility)) 1279 && ms.flags () & P_BLOCKSVIEW
1280 && (op->face && !op->face->visibility))
1430 { 1281 {
1431 for (last = top; last != floor; last = last->below) 1282 for (last = top; last != floor; last = last->below)
1432 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1283 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1433 break; 1284 break;
1285
1434 /* Check to see if we found the object that blocks view, 1286 /* Check to see if we found the object that blocks view,
1435 * and make sure we have a below pointer for it so that 1287 * and make sure we have a below pointer for it so that
1436 * we can get inserted below this one, which requires we 1288 * we can get inserted below this one, which requires we
1437 * set top to the object below us. 1289 * set top to the object below us.
1438 */ 1290 */
… …
1440 top = last->below; 1292 top = last->below;
1441 } 1293 }
1442 } /* If objects on this space */ 1294 } /* If objects on this space */
1443 1295
1444 if (flag & INS_MAP_LOAD) 1296 if (flag & INS_MAP_LOAD)
1445 top = GET_MAP_TOP (op->map, op->x, op->y); 1297 top = ms.top;
1446 1298
1447 if (flag & INS_ABOVE_FLOOR_ONLY) 1299 if (flag & INS_ABOVE_FLOOR_ONLY)
1448 top = floor; 1300 top = floor;
1449 1301
1450 /* Top is the object that our object (op) is going to get inserted above. 1302 /* Top is the object that our object (op) is going to get inserted above.
1451 */ 1303 */
1452 1304
1453 /* First object on this space */ 1305 /* First object on this space */
1454 if (!top) 1306 if (!top)
1455 { 1307 {
1456 op->above = GET_MAP_OB (op->map, op->x, op->y); 1308 op->above = ms.bot;
1457 1309
1458 if (op->above) 1310 if (op->above)
1459 op->above->below = op; 1311 op->above->below = op;
1460 1312
1461 op->below = NULL; 1313 op->below = 0;
1462 SET_MAP_OB (op->map, op->x, op->y, op); 1314 ms.bot = op;
1463 } 1315 }
1464 else 1316 else
1465 { /* get inserted into the stack above top */ 1317 { /* get inserted into the stack above top */
1466 op->above = top->above; 1318 op->above = top->above;
1467 1319
… …
1470 1322
1471 op->below = top; 1323 op->below = top;
1472 top->above = op; 1324 top->above = op;
1473 } 1325 }
1474 1326
1475 if (op->above == NULL) 1327 if (!op->above)
1476 SET_MAP_TOP (op->map, op->x, op->y, op); 1328 ms.top = op;
1477 } /* else not INS_BELOW_ORIGINATOR */ 1329 } /* else not INS_BELOW_ORIGINATOR */
1478 1330
1479 if (op->type == PLAYER) 1331 if (op->type == PLAYER)
1332 {
1480 op->contr->do_los = 1; 1333 op->contr->do_los = 1;
1334 ++op->map->players;
1335 op->map->touch ();
1336 }
1337
1338 op->map->dirty = true;
1481 1339
1482 /* If we have a floor, we know the player, if any, will be above 1340 /* If we have a floor, we know the player, if any, will be above
1483 * it, so save a few ticks and start from there. 1341 * it, so save a few ticks and start from there.
1484 */ 1342 */
1485 if (!(flag & INS_MAP_LOAD)) 1343 if (!(flag & INS_MAP_LOAD))
1486 for (tmp = floor ? floor : GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1344 if (object *pl = ms.player ())
1487 if (tmp->type == PLAYER) 1345 if (pl->contr->ns)
1488 tmp->contr->socket.update_look = 1; 1346 pl->contr->ns->floorbox_update ();
1489 1347
1490 /* If this object glows, it may affect lighting conditions that are 1348 /* If this object glows, it may affect lighting conditions that are
1491 * visible to others on this map. But update_all_los is really 1349 * visible to others on this map. But update_all_los is really
1492 * an inefficient way to do this, as it means los for all players 1350 * an inefficient way to do this, as it means los for all players
1493 * on the map will get recalculated. The players could very well 1351 * on the map will get recalculated. The players could very well
1494 * be far away from this change and not affected in any way - 1352 * be far away from this change and not affected in any way -
1495 * this should get redone to only look for players within range, 1353 * this should get redone to only look for players within range,
1496 * or just updating the P_NEED_UPDATE for spaces within this area 1354 * or just updating the P_UPTODATE for spaces within this area
1497 * of effect may be sufficient. 1355 * of effect may be sufficient.
1498 */ 1356 */
1499 if (MAP_DARKNESS (op->map) && (op->glow_radius != 0)) 1357 if (op->map->darkness && (op->glow_radius != 0))
1500 update_all_los (op->map, op->x, op->y); 1358 update_all_los (op->map, op->x, op->y);
1501 1359
1502 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1360 /* updates flags (blocked, alive, no magic, etc) for this map space */
1503 update_object (op, UP_OBJ_INSERT); 1361 update_object (op, UP_OBJ_INSERT);
1504 1362
1363 INVOKE_OBJECT (INSERT, op);
1364
1505 /* Don't know if moving this to the end will break anything. However, 1365 /* Don't know if moving this to the end will break anything. However,
1506 * we want to have update_look set above before calling this. 1366 * we want to have floorbox_update called before calling this.
1507 * 1367 *
1508 * check_move_on() must be after this because code called from 1368 * check_move_on() must be after this because code called from
1509 * check_move_on() depends on correct map flags (so functions like 1369 * check_move_on() depends on correct map flags (so functions like
1510 * blocked() and wall() work properly), and these flags are updated by 1370 * blocked() and wall() work properly), and these flags are updated by
1511 * update_object(). 1371 * update_object().
… …
1513 1373
1514 /* if this is not the head or flag has been passed, don't check walk on status */ 1374 /* if this is not the head or flag has been passed, don't check walk on status */
1515 if (!(flag & INS_NO_WALK_ON) && !op->head) 1375 if (!(flag & INS_NO_WALK_ON) && !op->head)
1516 { 1376 {
1517 if (check_move_on (op, originator)) 1377 if (check_move_on (op, originator))
1518 return NULL; 1378 return 0;
1519 1379
1520 /* If we are a multi part object, lets work our way through the check 1380 /* If we are a multi part object, lets work our way through the check
1521 * walk on's. 1381 * walk on's.
1522 */ 1382 */
1523 for (tmp = op->more; tmp != NULL; tmp = tmp->more) 1383 for (tmp = op->more; tmp != NULL; tmp = tmp->more)
1524 if (check_move_on (tmp, originator)) 1384 if (check_move_on (tmp, originator))
1525 return NULL; 1385 return 0;
1526 } 1386 }
1527 1387
1528 return op; 1388 return op;
1529} 1389}
1530 1390
1531/* this function inserts an object in the map, but if it 1391/* this function inserts an object in the map, but if it
1532 * finds an object of its own type, it'll remove that one first. 1392 * finds an object of its own type, it'll remove that one first.
1533 * op is the object to insert it under: supplies x and the map. 1393 * op is the object to insert it under: supplies x and the map.
1534 */ 1394 */
1535void 1395void
1536replace_insert_ob_in_map (const char *arch_string, object *op) 1396replace_insert_ob_in_map (const char *arch_string, object *op)
1537{ 1397{
1538 object * 1398 object *tmp, *tmp1;
1539 tmp;
1540 object *
1541 tmp1;
1542 1399
1543 /* first search for itself and remove any old instances */ 1400 /* first search for itself and remove any old instances */
1544 1401
1545 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1402 for (tmp = op->ms ().bot; tmp; tmp = tmp->above)
1546 {
1547 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */ 1403 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */
1548 {
1549 tmp->remove ();
1550 tmp->destroy (0); 1404 tmp->destroy ();
1551 }
1552 }
1553 1405
1554 tmp1 = arch_to_object (archetype::find (arch_string)); 1406 tmp1 = arch_to_object (archetype::find (arch_string));
1555 1407
1556 tmp1->x = op->x; 1408 tmp1->x = op->x;
1557 tmp1->y = op->y; 1409 tmp1->y = op->y;
1558 insert_ob_in_map (tmp1, op->map, op, 0); 1410 insert_ob_in_map (tmp1, op->map, op, 0);
1411}
1412
1413object *
1414object::insert_at (object *where, object *originator, int flags)
1415{
1416 where->map->insert (this, where->x, where->y, originator, flags);
1559} 1417}
1560 1418
1561/* 1419/*
1562 * get_split_ob(ob,nr) splits up ob into two parts. The part which 1420 * get_split_ob(ob,nr) splits up ob into two parts. The part which
1563 * is returned contains nr objects, and the remaining parts contains 1421 * is returned contains nr objects, and the remaining parts contains
1564 * the rest (or is removed and freed if that number is 0). 1422 * the rest (or is removed and freed if that number is 0).
1565 * On failure, NULL is returned, and the reason put into the 1423 * On failure, NULL is returned, and the reason put into the
1566 * global static errmsg array. 1424 * global static errmsg array.
1567 */ 1425 */
1568
1569object * 1426object *
1570get_split_ob (object *orig_ob, uint32 nr) 1427get_split_ob (object *orig_ob, uint32 nr)
1571{ 1428{
1572 object * 1429 object *newob;
1573 newob;
1574 int
1575 is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0); 1430 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1576 1431
1577 if (orig_ob->nrof < nr) 1432 if (orig_ob->nrof < nr)
1578 { 1433 {
1579 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name); 1434 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1580 return NULL; 1435 return NULL;
… …
1611 1466
1612object * 1467object *
1613decrease_ob_nr (object *op, uint32 i) 1468decrease_ob_nr (object *op, uint32 i)
1614{ 1469{
1615 object *tmp; 1470 object *tmp;
1616 player *pl;
1617 1471
1618 if (i == 0) /* objects with op->nrof require this check */ 1472 if (i == 0) /* objects with op->nrof require this check */
1619 return op; 1473 return op;
1620 1474
1621 if (i > op->nrof) 1475 if (i > op->nrof)
1622 i = op->nrof; 1476 i = op->nrof;
1623 1477
1624 if (QUERY_FLAG (op, FLAG_REMOVED)) 1478 if (QUERY_FLAG (op, FLAG_REMOVED))
1625 op->nrof -= i; 1479 op->nrof -= i;
1626 else if (op->env != NULL) 1480 else if (op->env)
1627 { 1481 {
1628 /* is this object in the players inventory, or sub container 1482 /* is this object in the players inventory, or sub container
1629 * therein? 1483 * therein?
1630 */ 1484 */
1631 tmp = is_player_inv (op->env); 1485 tmp = op->in_player ();
1632 /* nope. Is this a container the player has opened? 1486 /* nope. Is this a container the player has opened?
1633 * If so, set tmp to that player. 1487 * If so, set tmp to that player.
1634 * IMO, searching through all the players will mostly 1488 * IMO, searching through all the players will mostly
1635 * likely be quicker than following op->env to the map, 1489 * likely be quicker than following op->env to the map,
1636 * and then searching the map for a player. 1490 * and then searching the map for a player.
1637 */ 1491 */
1638 if (!tmp) 1492 if (!tmp)
1639 { 1493 for_all_players (pl)
1640 for (pl = first_player; pl; pl = pl->next)
1641 if (pl->ob->container == op->env) 1494 if (pl->ob->container == op->env)
1495 {
1496 tmp = pl->ob;
1642 break; 1497 break;
1643 if (pl)
1644 tmp = pl->ob;
1645 else
1646 tmp = NULL;
1647 } 1498 }
1648 1499
1649 if (i < op->nrof) 1500 if (i < op->nrof)
1650 { 1501 {
1651 sub_weight (op->env, op->weight * i); 1502 sub_weight (op->env, op->weight * i);
1652 op->nrof -= i; 1503 op->nrof -= i;
1653 if (tmp) 1504 if (tmp)
1654 {
1655 esrv_send_item (tmp, op); 1505 esrv_send_item (tmp, op);
1656 }
1657 } 1506 }
1658 else 1507 else
1659 { 1508 {
1660 op->remove (); 1509 op->remove ();
1661 op->nrof = 0; 1510 op->nrof = 0;
1662 if (tmp) 1511 if (tmp)
1663 {
1664 esrv_del_item (tmp->contr, op->count); 1512 esrv_del_item (tmp->contr, op->count);
1665 }
1666 } 1513 }
1667 } 1514 }
1668 else 1515 else
1669 { 1516 {
1670 object *above = op->above; 1517 object *above = op->above;
… …
1676 op->remove (); 1523 op->remove ();
1677 op->nrof = 0; 1524 op->nrof = 0;
1678 } 1525 }
1679 1526
1680 /* Since we just removed op, op->above is null */ 1527 /* Since we just removed op, op->above is null */
1681 for (tmp = above; tmp != NULL; tmp = tmp->above) 1528 for (tmp = above; tmp; tmp = tmp->above)
1682 if (tmp->type == PLAYER) 1529 if (tmp->type == PLAYER)
1683 { 1530 {
1684 if (op->nrof) 1531 if (op->nrof)
1685 esrv_send_item (tmp, op); 1532 esrv_send_item (tmp, op);
1686 else 1533 else
… …
1690 1537
1691 if (op->nrof) 1538 if (op->nrof)
1692 return op; 1539 return op;
1693 else 1540 else
1694 { 1541 {
1695 op->destroy (0); 1542 op->destroy ();
1696 return NULL; 1543 return 0;
1697 } 1544 }
1698} 1545}
1699 1546
1700/* 1547/*
1701 * add_weight(object, weight) adds the specified weight to an object, 1548 * add_weight(object, weight) adds the specified weight to an object,
… …
1761 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL); 1608 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL);
1762 CLEAR_FLAG (op, FLAG_REMOVED); 1609 CLEAR_FLAG (op, FLAG_REMOVED);
1763 if (op->nrof) 1610 if (op->nrof)
1764 { 1611 {
1765 for (tmp = inv; tmp != NULL; tmp = tmp->below) 1612 for (tmp = inv; tmp != NULL; tmp = tmp->below)
1766 if (CAN_MERGE (tmp, op)) 1613 if (object::can_merge (tmp, op))
1767 { 1614 {
1768 /* return the original object and remove inserted object 1615 /* return the original object and remove inserted object
1769 (client needs the original object) */ 1616 (client needs the original object) */
1770 tmp->nrof += op->nrof; 1617 tmp->nrof += op->nrof;
1771 /* Weight handling gets pretty funky. Since we are adding to 1618 /* Weight handling gets pretty funky. Since we are adding to
… …
1789 add_weight (this, op->weight * op->nrof); 1636 add_weight (this, op->weight * op->nrof);
1790 } 1637 }
1791 else 1638 else
1792 add_weight (this, (op->weight + op->carrying)); 1639 add_weight (this, (op->weight + op->carrying));
1793 1640
1794 otmp = is_player_inv (this); 1641 otmp = this->in_player ();
1795 if (otmp && otmp->contr) 1642 if (otmp && otmp->contr)
1796 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1643 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1797 fix_player (otmp); 1644 otmp->update_stats ();
1798 1645
1799 op->map = NULL; 1646 op->map = 0;
1800 op->env = this; 1647 op->env = this;
1801 op->above = NULL; 1648 op->above = 0;
1802 op->below = NULL; 1649 op->below = 0;
1803 op->x = 0, op->y = 0; 1650 op->x = 0, op->y = 0;
1804 1651
1805 /* reset the light list and los of the players on the map */ 1652 /* reset the light list and los of the players on the map */
1806 if ((op->glow_radius != 0) && map) 1653 if ((op->glow_radius != 0) && map)
1807 { 1654 {
1808#ifdef DEBUG_LIGHTS 1655#ifdef DEBUG_LIGHTS
1809 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name); 1656 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1810#endif /* DEBUG_LIGHTS */ 1657#endif /* DEBUG_LIGHTS */
1811 if (MAP_DARKNESS (map)) 1658 if (map->darkness)
1812 update_all_los (map, x, y); 1659 update_all_los (map, x, y);
1813 } 1660 }
1814 1661
1815 /* Client has no idea of ordering so lets not bother ordering it here. 1662 /* Client has no idea of ordering so lets not bother ordering it here.
1816 * It sure simplifies this function... 1663 * It sure simplifies this function...
… …
1821 { 1668 {
1822 op->below = inv; 1669 op->below = inv;
1823 op->below->above = op; 1670 op->below->above = op;
1824 inv = op; 1671 inv = op;
1825 } 1672 }
1673
1674 INVOKE_OBJECT (INSERT, this);
1826 1675
1827 return op; 1676 return op;
1828} 1677}
1829 1678
1830/* 1679/*
… …
1845 * 1694 *
1846 * MSW 2001-07-08: Check all objects on space, not just those below 1695 * MSW 2001-07-08: Check all objects on space, not just those below
1847 * object being inserted. insert_ob_in_map may not put new objects 1696 * object being inserted. insert_ob_in_map may not put new objects
1848 * on top. 1697 * on top.
1849 */ 1698 */
1850
1851int 1699int
1852check_move_on (object *op, object *originator) 1700check_move_on (object *op, object *originator)
1853{ 1701{
1854 object *tmp; 1702 object *tmp;
1855 maptile *m = op->map; 1703 maptile *m = op->map;
… …
1882 1730
1883 /* The objects have to be checked from top to bottom. 1731 /* The objects have to be checked from top to bottom.
1884 * Hence, we first go to the top: 1732 * Hence, we first go to the top:
1885 */ 1733 */
1886 1734
1887 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL && tmp->above != NULL; tmp = tmp->above) 1735 for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1888 { 1736 {
1889 /* Trim the search when we find the first other spell effect 1737 /* Trim the search when we find the first other spell effect
1890 * this helps performance so that if a space has 50 spell objects, 1738 * this helps performance so that if a space has 50 spell objects,
1891 * we don't need to check all of them. 1739 * we don't need to check all of them.
1892 */ 1740 */
… …
1910 if ((!op->move_type && tmp->move_slow & MOVE_WALK) || 1758 if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
1911 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0)) 1759 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
1912 { 1760 {
1913 1761
1914 float 1762 float
1915 diff = tmp->move_slow_penalty * FABS (op->speed); 1763 diff = tmp->move_slow_penalty * fabs (op->speed);
1916 1764
1917 if (op->type == PLAYER) 1765 if (op->type == PLAYER)
1918 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) || 1766 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) ||
1919 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN))) 1767 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN)))
1920 diff /= 4.0; 1768 diff /= 4.0;
… …
1947/* 1795/*
1948 * present_arch(arch, map, x, y) searches for any objects with 1796 * present_arch(arch, map, x, y) searches for any objects with
1949 * a matching archetype at the given map and coordinates. 1797 * a matching archetype at the given map and coordinates.
1950 * The first matching object is returned, or NULL if none. 1798 * The first matching object is returned, or NULL if none.
1951 */ 1799 */
1952
1953object * 1800object *
1954present_arch (const archetype *at, maptile *m, int x, int y) 1801present_arch (const archetype *at, maptile *m, int x, int y)
1955{ 1802{
1956 object *
1957 tmp;
1958
1959 if (m == NULL || out_of_map (m, x, y)) 1803 if (!m || out_of_map (m, x, y))
1960 { 1804 {
1961 LOG (llevError, "Present_arch called outside map.\n"); 1805 LOG (llevError, "Present_arch called outside map.\n");
1962 return NULL; 1806 return NULL;
1963 } 1807 }
1964 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1808
1809 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1965 if (tmp->arch == at) 1810 if (tmp->arch == at)
1966 return tmp; 1811 return tmp;
1812
1967 return NULL; 1813 return NULL;
1968} 1814}
1969 1815
1970/* 1816/*
1971 * present(type, map, x, y) searches for any objects with 1817 * present(type, map, x, y) searches for any objects with
1972 * a matching type variable at the given map and coordinates. 1818 * a matching type variable at the given map and coordinates.
1973 * The first matching object is returned, or NULL if none. 1819 * The first matching object is returned, or NULL if none.
1974 */ 1820 */
1975
1976object * 1821object *
1977present (unsigned char type, maptile *m, int x, int y) 1822present (unsigned char type, maptile *m, int x, int y)
1978{ 1823{
1979 object *
1980 tmp;
1981
1982 if (out_of_map (m, x, y)) 1824 if (out_of_map (m, x, y))
1983 { 1825 {
1984 LOG (llevError, "Present called outside map.\n"); 1826 LOG (llevError, "Present called outside map.\n");
1985 return NULL; 1827 return NULL;
1986 } 1828 }
1987 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1829
1830 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1988 if (tmp->type == type) 1831 if (tmp->type == type)
1989 return tmp; 1832 return tmp;
1833
1990 return NULL; 1834 return NULL;
1991} 1835}
1992 1836
1993/* 1837/*
1994 * present_in_ob(type, object) searches for any objects with 1838 * present_in_ob(type, object) searches for any objects with
1995 * a matching type variable in the inventory of the given object. 1839 * a matching type variable in the inventory of the given object.
1996 * The first matching object is returned, or NULL if none. 1840 * The first matching object is returned, or NULL if none.
1997 */ 1841 */
1998
1999object * 1842object *
2000present_in_ob (unsigned char type, const object *op) 1843present_in_ob (unsigned char type, const object *op)
2001{ 1844{
2002 object *
2003 tmp;
2004
2005 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1845 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2006 if (tmp->type == type) 1846 if (tmp->type == type)
2007 return tmp; 1847 return tmp;
1848
2008 return NULL; 1849 return NULL;
2009} 1850}
2010 1851
2011/* 1852/*
2012 * present_in_ob (type, str, object) searches for any objects with 1853 * present_in_ob (type, str, object) searches for any objects with
… …
2020 * str is the string to match against. Note that we match against 1861 * str is the string to match against. Note that we match against
2021 * the object name, not the archetype name. this is so that the 1862 * the object name, not the archetype name. this is so that the
2022 * spell code can use one object type (force), but change it's name 1863 * spell code can use one object type (force), but change it's name
2023 * to be unique. 1864 * to be unique.
2024 */ 1865 */
2025
2026object * 1866object *
2027present_in_ob_by_name (int type, const char *str, const object *op) 1867present_in_ob_by_name (int type, const char *str, const object *op)
2028{ 1868{
2029 object *
2030 tmp;
2031
2032 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1869 for (object *tmp = op->inv; tmp; tmp = tmp->below)
2033 {
2034 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name))) 1870 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name)))
2035 return tmp; 1871 return tmp;
2036 } 1872
2037 return NULL; 1873 return 0;
2038} 1874}
2039 1875
2040/* 1876/*
2041 * present_arch_in_ob(archetype, object) searches for any objects with 1877 * present_arch_in_ob(archetype, object) searches for any objects with
2042 * a matching archetype in the inventory of the given object. 1878 * a matching archetype in the inventory of the given object.
2043 * The first matching object is returned, or NULL if none. 1879 * The first matching object is returned, or NULL if none.
2044 */ 1880 */
2045
2046object * 1881object *
2047present_arch_in_ob (const archetype *at, const object *op) 1882present_arch_in_ob (const archetype *at, const object *op)
2048{ 1883{
2049 object *
2050 tmp;
2051
2052 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1884 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2053 if (tmp->arch == at) 1885 if (tmp->arch == at)
2054 return tmp; 1886 return tmp;
1887
2055 return NULL; 1888 return NULL;
2056} 1889}
2057 1890
2058/* 1891/*
2059 * activate recursively a flag on an object inventory 1892 * activate recursively a flag on an object inventory
2060 */ 1893 */
2061void 1894void
2062flag_inv (object *op, int flag) 1895flag_inv (object *op, int flag)
2063{ 1896{
2064 object *
2065 tmp;
2066
2067 if (op->inv) 1897 if (op->inv)
2068 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1898 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2069 { 1899 {
2070 SET_FLAG (tmp, flag); 1900 SET_FLAG (tmp, flag);
2071 flag_inv (tmp, flag); 1901 flag_inv (tmp, flag);
2072 } 1902 }
2073} /* 1903}
1904
1905/*
2074 * desactivate recursively a flag on an object inventory 1906 * deactivate recursively a flag on an object inventory
2075 */ 1907 */
2076void 1908void
2077unflag_inv (object *op, int flag) 1909unflag_inv (object *op, int flag)
2078{ 1910{
2079 object *
2080 tmp;
2081
2082 if (op->inv) 1911 if (op->inv)
2083 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1912 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2084 { 1913 {
2085 CLEAR_FLAG (tmp, flag); 1914 CLEAR_FLAG (tmp, flag);
2086 unflag_inv (tmp, flag); 1915 unflag_inv (tmp, flag);
2087 } 1916 }
2088} 1917}
… …
2091 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in 1920 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in
2092 * all it's inventory (recursively). 1921 * all it's inventory (recursively).
2093 * If checksums are used, a player will get set_cheat called for 1922 * If checksums are used, a player will get set_cheat called for
2094 * him/her-self and all object carried by a call to this function. 1923 * him/her-self and all object carried by a call to this function.
2095 */ 1924 */
2096
2097void 1925void
2098set_cheat (object *op) 1926set_cheat (object *op)
2099{ 1927{
2100 SET_FLAG (op, FLAG_WAS_WIZ); 1928 SET_FLAG (op, FLAG_WAS_WIZ);
2101 flag_inv (op, FLAG_WAS_WIZ); 1929 flag_inv (op, FLAG_WAS_WIZ);
… …
2120 * because arch_blocked (now ob_blocked) needs to know the movement type 1948 * because arch_blocked (now ob_blocked) needs to know the movement type
2121 * to know if the space in question will block the object. We can't use 1949 * to know if the space in question will block the object. We can't use
2122 * the archetype because that isn't correct if the monster has been 1950 * the archetype because that isn't correct if the monster has been
2123 * customized, changed states, etc. 1951 * customized, changed states, etc.
2124 */ 1952 */
2125
2126int 1953int
2127find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop) 1954find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)
2128{ 1955{
2129 int
2130 i,
2131 index = 0, flag; 1956 int index = 0, flag;
2132 static int
2133 altern[SIZEOFFREE]; 1957 int altern[SIZEOFFREE];
2134 1958
2135 for (i = start; i < stop; i++) 1959 for (int i = start; i < stop; i++)
2136 { 1960 {
2137 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]); 1961 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]);
2138 if (!flag) 1962 if (!flag)
2139 altern[index++] = i; 1963 altern [index++] = i;
2140 1964
2141 /* Basically, if we find a wall on a space, we cut down the search size. 1965 /* Basically, if we find a wall on a space, we cut down the search size.
2142 * In this way, we won't return spaces that are on another side of a wall. 1966 * In this way, we won't return spaces that are on another side of a wall.
2143 * This mostly work, but it cuts down the search size in all directions - 1967 * This mostly work, but it cuts down the search size in all directions -
2144 * if the space being examined only has a wall to the north and empty 1968 * if the space being examined only has a wall to the north and empty
2145 * spaces in all the other directions, this will reduce the search space 1969 * spaces in all the other directions, this will reduce the search space
2146 * to only the spaces immediately surrounding the target area, and 1970 * to only the spaces immediately surrounding the target area, and
2147 * won't look 2 spaces south of the target space. 1971 * won't look 2 spaces south of the target space.
2148 */ 1972 */
2149 else if ((flag & AB_NO_PASS) && maxfree[i] < stop) 1973 else if ((flag & P_NO_PASS) && maxfree[i] < stop)
2150 stop = maxfree[i]; 1974 stop = maxfree[i];
2151 } 1975 }
1976
2152 if (!index) 1977 if (!index)
2153 return -1; 1978 return -1;
1979
2154 return altern[RANDOM () % index]; 1980 return altern [rndm (index)];
2155} 1981}
2156 1982
2157/* 1983/*
2158 * find_first_free_spot(archetype, maptile, x, y) works like 1984 * find_first_free_spot(archetype, maptile, x, y) works like
2159 * find_free_spot(), but it will search max number of squares. 1985 * find_free_spot(), but it will search max number of squares.
2160 * But it will return the first available spot, not a random choice. 1986 * But it will return the first available spot, not a random choice.
2161 * Changed 0.93.2: Have it return -1 if there is no free spot available. 1987 * Changed 0.93.2: Have it return -1 if there is no free spot available.
2162 */ 1988 */
2163
2164int 1989int
2165find_first_free_spot (const object *ob, maptile *m, int x, int y) 1990find_first_free_spot (const object *ob, maptile *m, int x, int y)
2166{ 1991{
2167 int
2168 i;
2169
2170 for (i = 0; i < SIZEOFFREE; i++) 1992 for (int i = 0; i < SIZEOFFREE; i++)
2171 {
2172 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i])) 1993 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]))
2173 return i; 1994 return i;
2174 } 1995
2175 return -1; 1996 return -1;
2176} 1997}
2177 1998
2178/* 1999/*
2179 * The function permute(arr, begin, end) randomly reorders the array 2000 * The function permute(arr, begin, end) randomly reorders the array
2180 * arr[begin..end-1]. 2001 * arr[begin..end-1].
2002 * now uses a fisher-yates shuffle, old permute was broken
2181 */ 2003 */
2182static void 2004static void
2183permute (int *arr, int begin, int end) 2005permute (int *arr, int begin, int end)
2184{ 2006{
2185 int 2007 arr += begin;
2186 i,
2187 j,
2188 tmp,
2189 len;
2190
2191 len = end - begin; 2008 end -= begin;
2192 for (i = begin; i < end; i++)
2193 {
2194 j = begin + RANDOM () % len;
2195 2009
2196 tmp = arr[i]; 2010 while (--end)
2197 arr[i] = arr[j]; 2011 swap (arr [end], arr [rndm (end + 1)]);
2198 arr[j] = tmp;
2199 }
2200} 2012}
2201 2013
2202/* new function to make monster searching more efficient, and effective! 2014/* new function to make monster searching more efficient, and effective!
2203 * This basically returns a randomized array (in the passed pointer) of 2015 * This basically returns a randomized array (in the passed pointer) of
2204 * the spaces to find monsters. In this way, it won't always look for 2016 * the spaces to find monsters. In this way, it won't always look for
… …
2207 * the 3x3 area will be searched, just not in a predictable order. 2019 * the 3x3 area will be searched, just not in a predictable order.
2208 */ 2020 */
2209void 2021void
2210get_search_arr (int *search_arr) 2022get_search_arr (int *search_arr)
2211{ 2023{
2212 int 2024 int i;
2213 i;
2214 2025
2215 for (i = 0; i < SIZEOFFREE; i++) 2026 for (i = 0; i < SIZEOFFREE; i++)
2216 {
2217 search_arr[i] = i; 2027 search_arr[i] = i;
2218 }
2219 2028
2220 permute (search_arr, 1, SIZEOFFREE1 + 1); 2029 permute (search_arr, 1, SIZEOFFREE1 + 1);
2221 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1); 2030 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1);
2222 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE); 2031 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE);
2223} 2032}
… …
2232 * Perhaps incorrectly, but I'm making the assumption that exclude 2041 * Perhaps incorrectly, but I'm making the assumption that exclude
2233 * is actually want is going to try and move there. We need this info 2042 * is actually want is going to try and move there. We need this info
2234 * because we have to know what movement the thing looking to move 2043 * because we have to know what movement the thing looking to move
2235 * there is capable of. 2044 * there is capable of.
2236 */ 2045 */
2237
2238int 2046int
2239find_dir (maptile *m, int x, int y, object *exclude) 2047find_dir (maptile *m, int x, int y, object *exclude)
2240{ 2048{
2241 int
2242 i,
2243 max = SIZEOFFREE, mflags; 2049 int i, max = SIZEOFFREE, mflags;
2244 2050
2245 sint16 nx, ny; 2051 sint16 nx, ny;
2246 object * 2052 object *tmp;
2247 tmp;
2248 maptile * 2053 maptile *mp;
2249 mp;
2250 2054
2251 MoveType blocked, move_type; 2055 MoveType blocked, move_type;
2252 2056
2253 if (exclude && exclude->head) 2057 if (exclude && exclude->head)
2254 { 2058 {
… …
2266 mp = m; 2070 mp = m;
2267 nx = x + freearr_x[i]; 2071 nx = x + freearr_x[i];
2268 ny = y + freearr_y[i]; 2072 ny = y + freearr_y[i];
2269 2073
2270 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2074 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);
2075
2271 if (mflags & P_OUT_OF_MAP) 2076 if (mflags & P_OUT_OF_MAP)
2272 {
2273 max = maxfree[i]; 2077 max = maxfree[i];
2274 }
2275 else 2078 else
2276 { 2079 {
2277 blocked = GET_MAP_MOVE_BLOCK (mp, nx, ny); 2080 mapspace &ms = mp->at (nx, ny);
2081
2082 blocked = ms.move_block;
2278 2083
2279 if ((move_type & blocked) == move_type) 2084 if ((move_type & blocked) == move_type)
2280 {
2281 max = maxfree[i]; 2085 max = maxfree[i];
2282 }
2283 else if (mflags & P_IS_ALIVE) 2086 else if (mflags & P_IS_ALIVE)
2284 { 2087 {
2285 for (tmp = GET_MAP_OB (mp, nx, ny); tmp != NULL; tmp = tmp->above) 2088 for (tmp = ms.bot; tmp; tmp = tmp->above)
2286 { 2089 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)
2287 if ((QUERY_FLAG (tmp, FLAG_MONSTER) || tmp->type == PLAYER) && (tmp != exclude || (tmp->head && tmp->head != exclude))) 2090 && (tmp != exclude || (tmp->head && tmp->head != exclude)))
2288 {
2289 break; 2091 break;
2290 } 2092
2291 }
2292 if (tmp) 2093 if (tmp)
2293 {
2294 return freedir[i]; 2094 return freedir[i];
2295 }
2296 } 2095 }
2297 } 2096 }
2298 } 2097 }
2098
2299 return 0; 2099 return 0;
2300} 2100}
2301 2101
2302/* 2102/*
2303 * distance(object 1, object 2) will return the square of the 2103 * distance(object 1, object 2) will return the square of the
2304 * distance between the two given objects. 2104 * distance between the two given objects.
2305 */ 2105 */
2306
2307int 2106int
2308distance (const object *ob1, const object *ob2) 2107distance (const object *ob1, const object *ob2)
2309{ 2108{
2310 int
2311 i;
2312
2313 i = (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y); 2109 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2314 return i;
2315} 2110}
2316 2111
2317/* 2112/*
2318 * find_dir_2(delta-x,delta-y) will return a direction in which 2113 * find_dir_2(delta-x,delta-y) will return a direction in which
2319 * an object which has subtracted the x and y coordinates of another 2114 * an object which has subtracted the x and y coordinates of another
2320 * object, needs to travel toward it. 2115 * object, needs to travel toward it.
2321 */ 2116 */
2322
2323int 2117int
2324find_dir_2 (int x, int y) 2118find_dir_2 (int x, int y)
2325{ 2119{
2326 int 2120 int q;
2327 q;
2328 2121
2329 if (y) 2122 if (y)
2330 q = x * 100 / y; 2123 q = x * 100 / y;
2331 else if (x) 2124 else if (x)
2332 q = -300 * x; 2125 q = -300 * x;
… …
2357 2150
2358 return 3; 2151 return 3;
2359} 2152}
2360 2153
2361/* 2154/*
2362 * absdir(int): Returns a number between 1 and 8, which represent
2363 * the "absolute" direction of a number (it actually takes care of
2364 * "overflow" in previous calculations of a direction).
2365 */
2366
2367int
2368absdir (int d)
2369{
2370 while (d < 1)
2371 d += 8;
2372 while (d > 8)
2373 d -= 8;
2374 return d;
2375}
2376
2377/*
2378 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is 2155 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is
2379 * between two directions (which are expected to be absolute (see absdir()) 2156 * between two directions (which are expected to be absolute (see absdir())
2380 */ 2157 */
2381
2382int 2158int
2383dirdiff (int dir1, int dir2) 2159dirdiff (int dir1, int dir2)
2384{ 2160{
2385 int 2161 int d;
2386 d;
2387 2162
2388 d = abs (dir1 - dir2); 2163 d = abs (dir1 - dir2);
2389 if (d > 4) 2164 if (d > 4)
2390 d = 8 - d; 2165 d = 8 - d;
2166
2391 return d; 2167 return d;
2392} 2168}
2393 2169
2394/* peterm: 2170/* peterm:
2395 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster. 2171 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster.
… …
2398 * This basically means that if direction is 15, then it could either go 2174 * This basically means that if direction is 15, then it could either go
2399 * direction 4, 14, or 16 to get back to where we are. 2175 * direction 4, 14, or 16 to get back to where we are.
2400 * Moved from spell_util.c to object.c with the other related direction 2176 * Moved from spell_util.c to object.c with the other related direction
2401 * functions. 2177 * functions.
2402 */ 2178 */
2403
2404int
2405 reduction_dir[SIZEOFFREE][3] = { 2179int reduction_dir[SIZEOFFREE][3] = {
2406 {0, 0, 0}, /* 0 */ 2180 {0, 0, 0}, /* 0 */
2407 {0, 0, 0}, /* 1 */ 2181 {0, 0, 0}, /* 1 */
2408 {0, 0, 0}, /* 2 */ 2182 {0, 0, 0}, /* 2 */
2409 {0, 0, 0}, /* 3 */ 2183 {0, 0, 0}, /* 3 */
2410 {0, 0, 0}, /* 4 */ 2184 {0, 0, 0}, /* 4 */
… …
2458 * find a path to that monster that we found. If not, 2232 * find a path to that monster that we found. If not,
2459 * we don't bother going toward it. Returns 1 if we 2233 * we don't bother going toward it. Returns 1 if we
2460 * can see a direct way to get it 2234 * can see a direct way to get it
2461 * Modified to be map tile aware -.MSW 2235 * Modified to be map tile aware -.MSW
2462 */ 2236 */
2463
2464
2465int 2237int
2466can_see_monsterP (maptile *m, int x, int y, int dir) 2238can_see_monsterP (maptile *m, int x, int y, int dir)
2467{ 2239{
2468 sint16 dx, dy; 2240 sint16 dx, dy;
2469 int
2470 mflags; 2241 int mflags;
2471 2242
2472 if (dir < 0) 2243 if (dir < 0)
2473 return 0; /* exit condition: invalid direction */ 2244 return 0; /* exit condition: invalid direction */
2474 2245
2475 dx = x + freearr_x[dir]; 2246 dx = x + freearr_x[dir];
… …
2488 return 0; 2259 return 0;
2489 2260
2490 /* yes, can see. */ 2261 /* yes, can see. */
2491 if (dir < 9) 2262 if (dir < 9)
2492 return 1; 2263 return 1;
2264
2493 return can_see_monsterP (m, x, y, reduction_dir[dir][0]) | 2265 return can_see_monsterP (m, x, y, reduction_dir[dir][0])
2494 can_see_monsterP (m, x, y, reduction_dir[dir][1]) | can_see_monsterP (m, x, y, reduction_dir[dir][2]); 2266 | can_see_monsterP (m, x, y, reduction_dir[dir][1])
2267 | can_see_monsterP (m, x, y, reduction_dir[dir][2]);
2495} 2268}
2496
2497
2498 2269
2499/* 2270/*
2500 * can_pick(picker, item): finds out if an object is possible to be 2271 * can_pick(picker, item): finds out if an object is possible to be
2501 * picked up by the picker. Returnes 1 if it can be 2272 * picked up by the picker. Returnes 1 if it can be
2502 * picked up, otherwise 0. 2273 * picked up, otherwise 0.
… …
2513 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2284 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2514 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2285 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2515 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2286 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));
2516} 2287}
2517 2288
2518
2519/* 2289/*
2520 * create clone from object to another 2290 * create clone from object to another
2521 */ 2291 */
2522object * 2292object *
2523object_create_clone (object *asrc) 2293object_create_clone (object *asrc)
… …
2532 src = src->head; 2302 src = src->head;
2533 2303
2534 prev = 0; 2304 prev = 0;
2535 for (part = src; part; part = part->more) 2305 for (part = src; part; part = part->more)
2536 { 2306 {
2537 tmp = get_object (); 2307 tmp = part->clone ();
2538 copy_object (part, tmp);
2539 tmp->x -= src->x; 2308 tmp->x -= src->x;
2540 tmp->y -= src->y; 2309 tmp->y -= src->y;
2541 2310
2542 if (!part->head) 2311 if (!part->head)
2543 { 2312 {
2544 dst = tmp; 2313 dst = tmp;
2545 tmp->head = 0; 2314 tmp->head = 0;
2546 } 2315 }
2547 else 2316 else
2548 {
2549 tmp->head = dst; 2317 tmp->head = dst;
2550 }
2551 2318
2552 tmp->more = 0; 2319 tmp->more = 0;
2553 2320
2554 if (prev) 2321 if (prev)
2555 prev->more = tmp; 2322 prev->more = tmp;
… …
2567/* Basically, we save the content of the string to a temp file, then call */ 2334/* Basically, we save the content of the string to a temp file, then call */
2568/* load_object on it. I admit it is a highly inefficient way to make things, */ 2335/* load_object on it. I admit it is a highly inefficient way to make things, */
2569/* but it was simple to make and allows reusing the load_object function. */ 2336/* but it was simple to make and allows reusing the load_object function. */
2570/* Remember not to use load_object_str in a time-critical situation. */ 2337/* Remember not to use load_object_str in a time-critical situation. */
2571/* Also remember that multiparts objects are not supported for now. */ 2338/* Also remember that multiparts objects are not supported for now. */
2572
2573object * 2339object *
2574load_object_str (const char *obstr) 2340load_object_str (const char *obstr)
2575{ 2341{
2576 object *op; 2342 object *op;
2577 char filename[MAX_BUF]; 2343 char filename[MAX_BUF];
… …
2587 } 2353 }
2588 2354
2589 fprintf (tempfile, obstr); 2355 fprintf (tempfile, obstr);
2590 fclose (tempfile); 2356 fclose (tempfile);
2591 2357
2592 op = get_object (); 2358 op = object::create ();
2593 2359
2594 object_thawer thawer (filename); 2360 object_thawer thawer (filename);
2595 2361
2596 if (thawer) 2362 if (thawer)
2597 load_object (thawer, op, 0); 2363 load_object (thawer, op, 0);
… …
2607 * returns NULL if no match. 2373 * returns NULL if no match.
2608 */ 2374 */
2609object * 2375object *
2610find_obj_by_type_subtype (const object *who, int type, int subtype) 2376find_obj_by_type_subtype (const object *who, int type, int subtype)
2611{ 2377{
2612 object *tmp;
2613
2614 for (tmp = who->inv; tmp; tmp = tmp->below) 2378 for (object *tmp = who->inv; tmp; tmp = tmp->below)
2615 if (tmp->type == type && tmp->subtype == subtype) 2379 if (tmp->type == type && tmp->subtype == subtype)
2616 return tmp; 2380 return tmp;
2617 2381
2618 return NULL; 2382 return 0;
2619} 2383}
2620 2384
2621/* If ob has a field named key, return the link from the list, 2385/* If ob has a field named key, return the link from the list,
2622 * otherwise return NULL. 2386 * otherwise return NULL.
2623 * 2387 *
… …
2625 * do the desired thing. 2389 * do the desired thing.
2626 */ 2390 */
2627key_value * 2391key_value *
2628get_ob_key_link (const object *ob, const char *key) 2392get_ob_key_link (const object *ob, const char *key)
2629{ 2393{
2630 key_value *link;
2631
2632 for (link = ob->key_values; link != NULL; link = link->next) 2394 for (key_value *link = ob->key_values; link; link = link->next)
2633 if (link->key == key) 2395 if (link->key == key)
2634 return link; 2396 return link;
2635 2397
2636 return NULL; 2398 return 0;
2637} 2399}
2638 2400
2639/* 2401/*
2640 * Returns the value of op has an extra_field for key, or NULL. 2402 * Returns the value of op has an extra_field for key, or NULL.
2641 * 2403 *
… …
2681 * Returns TRUE on success. 2443 * Returns TRUE on success.
2682 */ 2444 */
2683int 2445int
2684set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key) 2446set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2685{ 2447{
2686 key_value *
2687 field = NULL, *last = NULL; 2448 key_value *field = NULL, *last = NULL;
2688 2449
2689 for (field = op->key_values; field != NULL; field = field->next) 2450 for (field = op->key_values; field != NULL; field = field->next)
2690 { 2451 {
2691 if (field->key != canonical_key) 2452 if (field->key != canonical_key)
2692 { 2453 {
… …
2720 /* IF we get here, key doesn't exist */ 2481 /* IF we get here, key doesn't exist */
2721 2482
2722 /* No field, we'll have to add it. */ 2483 /* No field, we'll have to add it. */
2723 2484
2724 if (!add_key) 2485 if (!add_key)
2725 {
2726 return FALSE; 2486 return FALSE;
2727 } 2487
2728 /* There isn't any good reason to store a null 2488 /* There isn't any good reason to store a null
2729 * value in the key/value list. If the archetype has 2489 * value in the key/value list. If the archetype has
2730 * this key, then we should also have it, so shouldn't 2490 * this key, then we should also have it, so shouldn't
2731 * be here. If user wants to store empty strings, 2491 * be here. If user wants to store empty strings,
2732 * should pass in "" 2492 * should pass in ""
… …
2781 } 2541 }
2782 else 2542 else
2783 item = item->env; 2543 item = item->env;
2784} 2544}
2785 2545
2546
2547const char *
2548object::flag_desc (char *desc, int len) const
2549{
2550 char *p = desc;
2551 bool first = true;
2552
2553 *p = 0;
2554
2555 for (int i = 0; i < NUM_FLAGS; i++)
2556 {
2557 if (len <= 10) // magic constant!
2558 {
2559 snprintf (p, len, ",...");
2560 break;
2561 }
2562
2563 if (flag [i])
2564 {
2565 int cnt = snprintf (p, len, "%s%d", first ? "" : ",", i);
2566 len -= cnt;
2567 p += cnt;
2568 first = false;
2569 }
2570 }
2571
2572 return desc;
2573}
2574
2786// return a suitable string describing an objetc in enough detail to find it 2575// return a suitable string describing an object in enough detail to find it
2787const char * 2576const char *
2788object::debug_desc (char *info) const 2577object::debug_desc (char *info) const
2789{ 2578{
2579 char flagdesc[512];
2790 char info2[256 * 3]; 2580 char info2[256 * 4];
2791 char *p = info; 2581 char *p = info;
2792 2582
2793 p += snprintf (p, 256, "%d=\"%s%s%s\"", 2583 p += snprintf (p, 512, "{cnt:%d,uuid:<1.%" PRIx64 ">,name:\"%s\"%s%s,flags:[%s],type:%d}",
2794 count, 2584 count, uuid.seq,
2795 &name, 2585 &name,
2796 title ? " " : "", 2586 title ? "\",title:\"" : "",
2797 title ? (const char *)title : ""); 2587 title ? (const char *)title : "",
2588 flag_desc (flagdesc, 512), type);
2798 2589
2799 if (env) 2590 if (env)
2800 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2591 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2801 2592
2802 if (map) 2593 if (map)
2803 p += snprintf (p, 256, "(on %s@%d+%d)", map->path, x, y); 2594 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2804 2595
2805 return info; 2596 return info;
2806} 2597}
2807 2598
2808const char * 2599const char *
2809object::debug_desc () const 2600object::debug_desc () const
2810{ 2601{
2811 static char info[256 * 3]; 2602 static char info[256 * 4];
2812 return debug_desc (info); 2603 return debug_desc (info);
2813} 2604}
2814 2605
2606const char *
2607object::debug_desc2 () const
2608{
2609 static char info[256 * 4];
2610 return debug_desc (info);
2611}
2612
2613struct region *
2614object::region () const
2615{
2616 return map ? map->region (x, y)
2617 : region::default_region ();
2618}
2619

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines