ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.145 by root, Mon May 7 03:05:58 2007 UTC vs.
Revision 1.237 by root, Tue May 6 21:04:37 2008 UTC

1/* 1/*
2 * CrossFire, A Multiplayer game 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team 4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (C) 2001 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team
6 * Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 * 7 *
8 * This program is free software; you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify
9 * it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
10 * the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation, either version 3 of the License, or
11 * (at your option) any later version. 11 * (at your option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
19 * along with this program; if not, write to the Free Software 19 * along with this program. If not, see <http://www.gnu.org/licenses/>.
20 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
21 * 20 *
22 * The authors can be reached via e-mail at <crossfire@schmorp.de> 21 * The authors can be reached via e-mail to <support@deliantra.net>
23 */ 22 */
24 23
25/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
26 sub/add_weight will transcend the environment updating the carrying
27 variable. */
28#include <global.h> 24#include <global.h>
29#include <stdio.h> 25#include <stdio.h>
30#include <sys/types.h> 26#include <sys/types.h>
31#include <sys/uio.h> 27#include <sys/uio.h>
32#include <object.h> 28#include <object.h>
33#include <funcpoint.h> 29#include <sproto.h>
34#include <loader.h> 30#include <loader.h>
35 31
36#include <bitset> 32#include <bitset>
37 33
38int nrofallocobjects = 0; 34UUID UUID::cur;
39static UUID uuid; 35static uint64_t seq_next_save;
40const uint64 UUID_SKIP = 1<<19; 36static const uint64 UUID_GAP = 1<<19;
41 37
42objectvec objects; 38objectvec objects;
43activevec actives; 39activevec actives;
44 40
45short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 41short freearr_x[SIZEOFFREE] = {
42 0,
43 0, 1, 1, 1, 0, -1, -1, -1,
44 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
46 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1 45 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1
47}; 46};
48short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, 47short freearr_y[SIZEOFFREE] = {
48 0,
49 -1, -1, 0, 1, 1, 1, 0, -1,
50 -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
49 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3 51 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3
50}; 52};
51int maxfree[SIZEOFFREE] = { 0, 9, 10, 13, 14, 17, 18, 21, 22, 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 53int maxfree[SIZEOFFREE] = {
54 0,
55 9, 10, 13, 14, 17, 18, 21, 22,
56 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
52 48, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49 57 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
53}; 58};
54int freedir[SIZEOFFREE] = { 59int freedir[SIZEOFFREE] = {
55 0, 1, 2, 3, 4, 5, 6, 7, 8, 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8, 60 0,
61 1, 2, 3, 4, 5, 6, 7, 8,
62 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,
56 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8 63 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8
57}; 64};
58 65
59static void 66static void
60write_uuid (void) 67write_uuid (uval64 skip, bool sync)
61{ 68{
62 char filename1[MAX_BUF], filename2[MAX_BUF]; 69 CALL_BEGIN (2);
63 70 CALL_ARG_SV (newSVval64 (skip));
64 sprintf (filename1, "%s/uuid", settings.localdir); 71 CALL_ARG_SV (boolSV (sync));
65 sprintf (filename2, "%s/uuid~", settings.localdir); 72 CALL_CALL ("cf::write_uuid", G_DISCARD);
66 73 CALL_END;
67 FILE *fp;
68
69 if (!(fp = fopen (filename2, "w")))
70 {
71 LOG (llevError, "ERROR: cannot open %s for writing, unable to write UUID!\n", filename2);
72 return;
73 }
74
75 fprintf (fp, "<1,%llx>\n", (unsigned long long)uuid.seq + UUID_SKIP * 2);
76 fclose (fp);
77 rename (filename2, filename1);
78} 74}
79 75
80static void 76static void
81read_uuid (void) 77read_uuid (void)
82{ 78{
83 char filename[MAX_BUF]; 79 char filename[MAX_BUF];
84 80
85 sprintf (filename, "%s/uuid", settings.localdir); 81 sprintf (filename, "%s/uuid", settings.localdir);
82
83 seq_next_save = 0;
86 84
87 FILE *fp; 85 FILE *fp;
88 86
89 if (!(fp = fopen (filename, "r"))) 87 if (!(fp = fopen (filename, "r")))
90 { 88 {
91 if (errno == ENOENT) 89 if (errno == ENOENT)
92 { 90 {
93 LOG (llevInfo, "RESET uid to 1\n"); 91 LOG (llevInfo, "RESET uid to 1\n");
94 uuid.seq = 0; 92 UUID::cur.seq = 0;
95 write_uuid (); 93 write_uuid (UUID_GAP, true);
96 return; 94 return;
97 } 95 }
98 96
99 LOG (llevError, "FATAL: cannot open %s for reading!\n", filename); 97 LOG (llevError, "FATAL: cannot open %s for reading!\n", filename);
100 _exit (1); 98 _exit (1);
101 } 99 }
102 100
103 int version; 101 UUID::BUF buf;
104 unsigned long long uid; 102 buf[0] = 0;
105 if (2 != fscanf (fp, "<%d,%llx>\n", &version, &uid) || version != 1) 103 fgets (buf, sizeof (buf), fp);
104
105 if (!UUID::cur.parse (buf))
106 { 106 {
107 LOG (llevError, "FATAL: error reading uid from %s!\n", filename); 107 LOG (llevError, "FATAL: error reading uid from %s (%s)!\n", filename, buf);
108 _exit (1); 108 _exit (1);
109 } 109 }
110 110
111 uuid.seq = uid; 111 LOG (llevDebug, "read UUID: %s\n", UUID::cur.c_str ());
112 write_uuid (); 112
113 LOG (llevDebug, "read UID: %" PRId64 "\n", uid); 113 write_uuid (UUID_GAP, true);
114 fclose (fp); 114 fclose (fp);
115} 115}
116 116
117UUID 117UUID
118gen_uuid () 118UUID::gen ()
119{ 119{
120 UUID uid; 120 UUID uid;
121 121
122 uid.seq = ++uuid.seq; 122 uid.seq = ++cur.seq;
123 123
124 if (!(uuid.seq & (UUID_SKIP - 1))) 124 if (expect_false (cur.seq >= seq_next_save))
125 write_uuid (); 125 {
126 seq_next_save = UUID::cur.seq + (UUID_GAP >> 1);
127 write_uuid (UUID_GAP, false);
128 }
129
126 130
127 return uid; 131 return uid;
128} 132}
129 133
130void 134void
131init_uuid () 135UUID::init ()
132{ 136{
133 read_uuid (); 137 read_uuid ();
134} 138}
135 139
136/* Returns TRUE if every key_values in wants has a partner with the same value in has. */ 140/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
137static int 141static bool
138compare_ob_value_lists_one (const object *wants, const object *has) 142compare_ob_value_lists_one (const object *wants, const object *has)
139{ 143{
140 key_value *wants_field;
141
142 /* n-squared behaviour (see get_ob_key_link()), but I'm hoping both 144 /* n-squared behaviour (see kv_get), but I'm hoping both
143 * objects with lists are rare, and lists stay short. If not, use a 145 * objects with lists are rare, and lists stay short. If not, use a
144 * different structure or at least keep the lists sorted... 146 * different structure or at least keep the lists sorted...
145 */ 147 */
146 148
147 /* For each field in wants, */ 149 /* For each field in wants, */
148 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next) 150 for (key_value *kv = wants->key_values; kv; kv = kv->next)
149 { 151 if (has->kv_get (kv->key) != kv->value)
150 key_value *has_field; 152 return false;
151
152 /* Look for a field in has with the same key. */
153 has_field = get_ob_key_link (has, wants_field->key);
154
155 if (has_field == NULL)
156 {
157 /* No field with that name. */
158 return FALSE;
159 }
160
161 /* Found the matching field. */
162 if (has_field->value != wants_field->value)
163 {
164 /* Values don't match, so this half of the comparison is false. */
165 return FALSE;
166 }
167
168 /* If we get here, we found a match. Now for the next field in wants. */
169 }
170 153
171 /* If we get here, every field in wants has a matching field in has. */ 154 /* If we get here, every field in wants has a matching field in has. */
172 return TRUE; 155 return true;
173} 156}
174 157
175/* Returns TRUE if ob1 has the same key_values as ob2. */ 158/* Returns TRUE if ob1 has the same key_values as ob2. */
176static int 159static bool
177compare_ob_value_lists (const object *ob1, const object *ob2) 160compare_ob_value_lists (const object *ob1, const object *ob2)
178{ 161{
179 /* However, there may be fields in has which aren't partnered in wants, 162 /* However, there may be fields in has which aren't partnered in wants,
180 * so we need to run the comparison *twice*. :( 163 * so we need to run the comparison *twice*. :(
181 */ 164 */
182 return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1); 165 return compare_ob_value_lists_one (ob1, ob2)
166 && compare_ob_value_lists_one (ob2, ob1);
183} 167}
184 168
185/* Function examines the 2 objects given to it, and returns true if 169/* Function examines the 2 objects given to it, and returns true if
186 * they can be merged together. 170 * they can be merged together.
187 * 171 *
202 || ob1->speed != ob2->speed 186 || ob1->speed != ob2->speed
203 || ob1->value != ob2->value 187 || ob1->value != ob2->value
204 || ob1->name != ob2->name) 188 || ob1->name != ob2->name)
205 return 0; 189 return 0;
206 190
207 //TODO: this ain't working well, use nicer and correct overflow check 191 /* Do not merge objects if nrof would overflow. First part checks
208 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that 192 * for unsigned overflow (2c), second part checks whether the result
209 * value could not be stored in a sint32 (which unfortunately sometimes is 193 * would fit into a 32 bit signed int, which is often used to hold
210 * used to store nrof). 194 * nrof values.
211 */ 195 */
212 if (ob1->nrof + ob2->nrof >= 1UL << 31) 196 if (~ob1->nrof < ob2->nrof || ob1->nrof + ob2->nrof > (1UL << 31))
213 return 0; 197 return 0;
214 198
215 /* If the objects have been identified, set the BEEN_APPLIED flag. 199 /* If the objects have been identified, set the BEEN_APPLIED flag.
216 * This is to the comparison of the flags below will be OK. We 200 * This is to the comparison of the flags below will be OK. We
217 * just can't ignore the been applied or identified flags, as they 201 * just can't ignore the been applied or identified flags, as they
218 * are not equal - just if it has been identified, the been_applied 202 * are not equal - just if it has been identified, the been_applied
219 * flags lose any meaning. 203 * flags lose any meaning.
220 */ 204 */
221 if (QUERY_FLAG (ob1, FLAG_IDENTIFIED)) 205 if (QUERY_FLAG (ob1, FLAG_IDENTIFIED))
222 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 206 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
223 207
224 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 208 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
225 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 209 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
226 210
227 if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any () 211 if (ob1->arch->name != ob2->arch->name
228 || ob1->arch != ob2->arch
229 || ob1->name != ob2->name 212 || ob1->name != ob2->name
230 || ob1->title != ob2->title 213 || ob1->title != ob2->title
231 || ob1->msg != ob2->msg 214 || ob1->msg != ob2->msg
232 || ob1->weight != ob2->weight 215 || ob1->weight != ob2->weight
233 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
234 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
235 || ob1->attacktype != ob2->attacktype 216 || ob1->attacktype != ob2->attacktype
236 || ob1->magic != ob2->magic 217 || ob1->magic != ob2->magic
237 || ob1->slaying != ob2->slaying 218 || ob1->slaying != ob2->slaying
238 || ob1->skill != ob2->skill 219 || ob1->skill != ob2->skill
239 || ob1->value != ob2->value 220 || ob1->value != ob2->value
246 || ob1->move_block != ob2->move_block 227 || ob1->move_block != ob2->move_block
247 || ob1->move_allow != ob2->move_allow 228 || ob1->move_allow != ob2->move_allow
248 || ob1->move_on != ob2->move_on 229 || ob1->move_on != ob2->move_on
249 || ob1->move_off != ob2->move_off 230 || ob1->move_off != ob2->move_off
250 || ob1->move_slow != ob2->move_slow 231 || ob1->move_slow != ob2->move_slow
251 || ob1->move_slow_penalty != ob2->move_slow_penalty) 232 || ob1->move_slow_penalty != ob2->move_slow_penalty
233 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
234 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
252 return 0; 235 return 0;
253 236
237 if ((ob1->flag ^ ob2->flag)
238 .reset (FLAG_INV_LOCKED)
239 .reset (FLAG_CLIENT_SENT)
240 .reset (FLAG_REMOVED)
241 .any ())
242 return 0;
243
254 /* This is really a spellbook check - really, we should 244 /* This is really a spellbook check - we should in general
255 * check all objects in the inventory. 245 * not merge objects with real inventories, as splitting them
246 * is hard.
256 */ 247 */
257 if (ob1->inv || ob2->inv) 248 if (ob1->inv || ob2->inv)
258 { 249 {
259 /* if one object has inventory but the other doesn't, not equiv */ 250 if (!(ob1->inv && ob2->inv))
260 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv)) 251 return 0; /* inventories differ in length */
261 return 0;
262 252
263 /* Now check to see if the two inventory objects could merge */ 253 if (ob1->inv->below || ob2->inv->below)
254 return 0; /* more than one object in inv */
255
264 if (!object::can_merge (ob1->inv, ob2->inv)) 256 if (!object::can_merge (ob1->inv, ob2->inv))
265 return 0; 257 return 0; /* inventory objects differ */
266 258
267 /* inventory ok - still need to check rest of this object to see 259 /* inventory ok - still need to check rest of this object to see
268 * if it is valid. 260 * if it is valid.
269 */ 261 */
270 } 262 }
289 if (ob1->level != ob2->level) 281 if (ob1->level != ob2->level)
290 return 0; 282 return 0;
291 break; 283 break;
292 } 284 }
293 285
294 if (ob1->key_values != NULL || ob2->key_values != NULL) 286 if (ob1->key_values || ob2->key_values)
295 { 287 {
296 /* At least one of these has key_values. */ 288 /* At least one of these has key_values. */
297 if ((ob1->key_values == NULL) != (ob2->key_values == NULL)) 289 if ((!ob1->key_values) != (!ob2->key_values))
298 /* One has fields, but the other one doesn't. */ 290 return 0; /* One has fields, but the other one doesn't. */
291
292 if (!compare_ob_value_lists (ob1, ob2))
299 return 0; 293 return 0;
300 else if (!compare_ob_value_lists (ob1, ob2))
301 return 0;
302 } 294 }
303 295
304 //TODO: generate an event or call into perl for additional checks
305 if (ob1->self || ob2->self) 296 if (ob1->self || ob2->self)
306 { 297 {
307 ob1->optimise (); 298 ob1->optimise ();
308 ob2->optimise (); 299 ob2->optimise ();
309 300
310 if (ob1->self || ob2->self) 301 if (ob1->self || ob2->self)
302 {
303 int k1 = ob1->self ? HvTOTALKEYS (ob1->self) : 0;
304 int k2 = ob2->self ? HvTOTALKEYS (ob2->self) : 0;
305
306 if (k1 != k2)
311 return 0; 307 return 0;
308
309 if (k1 == 0)
310 return 1;
311
312 if (!cfperl_can_merge (ob1, ob2))
313 return 0;
314 }
312 } 315 }
313 316
314 /* Everything passes, must be OK. */ 317 /* Everything passes, must be OK. */
315 return 1; 318 return 1;
316} 319}
317 320
321// find player who can see this object
322object *
323object::visible_to () const
324{
325 if (client_visible () && !flag [FLAG_REMOVED])
326 {
327 // see if we are in a container of sorts
328 if (env)
329 {
330 // the player inventory itself is always visible
331 if (env->type == PLAYER)
332 return env;
333
334 // else a player could have our env open
335 object *envest = env->outer_env ();
336
337 // the player itself is always on a map, so we will find him here
338 // even if our inv is in a player.
339 if (envest->is_on_map ())
340 if (object *pl = envest->ms ().player ())
341 if (pl->container == env)
342 return pl;
343 }
344 else
345 {
346 // maybe there is a player standing on the same mapspace
347 // this will catch the case where "this" is a player
348 if (object *pl = ms ().player ())
349 if (!pl->container || this == pl->container)
350 return pl;
351 }
352 }
353
354 return 0;
355}
356
357// adjust weight per container type ("of holding")
358static sint32
359weight_adjust_for (object *op, sint32 weight)
360{
361 return op->type == CONTAINER
362 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str)
363 : weight;
364}
365
318/* 366/*
367 * adjust_weight(object, weight) adds the specified weight to an object,
368 * and also updates how much the environment(s) is/are carrying.
369 */
370static void
371adjust_weight (object *op, sint32 weight)
372{
373 while (op)
374 {
375 // adjust by actual difference to account for rounding errors
376 // i.e. (w2 - w1) / f != w2 / f - w1 / f and the latter is correct
377 weight = weight_adjust_for (op, op->carrying)
378 - weight_adjust_for (op, op->carrying - weight);
379
380 if (!weight)
381 return;
382
383 op->carrying += weight;
384
385 if (object *pl = op->visible_to ())
386 if (pl != op) // player is handled lazily
387 esrv_update_item (UPD_WEIGHT, pl, op);
388
389 op = op->env;
390 }
391}
392
393/*
319 * sum_weight() is a recursive function which calculates the weight 394 * this is a recursive function which calculates the weight
320 * an object is carrying. It goes through in figures out how much 395 * an object is carrying. It goes through op and figures out how much
321 * containers are carrying, and sums it up. 396 * containers are carrying, and sums it up.
322 */ 397 */
323long 398void
324sum_weight (object *op) 399object::update_weight ()
325{ 400{
326 long sum; 401 sint32 sum = 0;
327 object *inv;
328 402
329 for (sum = 0, inv = op->inv; inv; inv = inv->below) 403 for (object *op = inv; op; op = op->below)
330 { 404 {
331 if (inv->inv) 405 if (op->inv)
332 sum_weight (inv); 406 op->update_weight ();
333 407
334 sum += inv->carrying + inv->weight * (inv->nrof ? inv->nrof : 1); 408 sum += op->total_weight ();
409 }
410
411 sum = weight_adjust_for (this, sum);
412
413 if (sum != carrying)
335 } 414 {
336
337 if (op->type == CONTAINER && op->stats.Str)
338 sum = (sum * (100 - op->stats.Str)) / 100;
339
340 if (op->carrying != sum)
341 op->carrying = sum; 415 carrying = sum;
342 416
343 return sum; 417 if (object *pl = visible_to ())
418 if (pl != this) // player is handled lazily
419 esrv_update_item (UPD_WEIGHT, pl, this);
420 }
344} 421}
345 422
346/** 423/*
347 * Return the outermost environment object for a given object. 424 * Used by: Server DM commands: dumpbelow, dump. Some error messages.
348 */
349
350object *
351object_get_env_recursive (object *op)
352{
353 while (op->env != NULL)
354 op = op->env;
355 return op;
356}
357
358/*
359 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
360 * Some error messages.
361 * The result of the dump is stored in the static global errmsg array.
362 */ 425 */
363char * 426char *
364dump_object (object *op) 427dump_object (object *op)
365{ 428{
366 if (!op) 429 if (!op)
374/* 437/*
375 * get_nearest_part(multi-object, object 2) returns the part of the 438 * get_nearest_part(multi-object, object 2) returns the part of the
376 * multi-object 1 which is closest to the second object. 439 * multi-object 1 which is closest to the second object.
377 * If it's not a multi-object, it is returned. 440 * If it's not a multi-object, it is returned.
378 */ 441 */
379
380object * 442object *
381get_nearest_part (object *op, const object *pl) 443get_nearest_part (object *op, const object *pl)
382{ 444{
383 object *tmp, *closest; 445 object *tmp, *closest;
384 int last_dist, i; 446 int last_dist, i;
385 447
386 if (op->more == NULL) 448 if (!op->more)
387 return op; 449 return op;
450
388 for (last_dist = distance (op, pl), closest = op, tmp = op->more; tmp != NULL; tmp = tmp->more) 451 for (last_dist = distance (op, pl), closest = op, tmp = op->more;
452 tmp;
453 tmp = tmp->more)
389 if ((i = distance (tmp, pl)) < last_dist) 454 if ((i = distance (tmp, pl)) < last_dist)
390 closest = tmp, last_dist = i; 455 closest = tmp, last_dist = i;
456
391 return closest; 457 return closest;
392} 458}
393 459
394/* 460/*
395 * Returns the object which has the count-variable equal to the argument. 461 * Returns the object which has the count-variable equal to the argument.
462 * VERRRY slow.
396 */ 463 */
397object * 464object *
398find_object (tag_t i) 465find_object (tag_t i)
399{ 466{
400 for_all_objects (op) 467 for_all_objects (op)
420 break; 487 break;
421 488
422 return op; 489 return op;
423} 490}
424 491
425void
426free_all_object_data ()
427{
428 LOG (llevDebug, "%d allocated objects\n", nrofallocobjects);
429}
430
431/* 492/*
432 * Sets the owner and sets the skill and exp pointers to owner's current 493 * Sets the owner and sets the skill and exp pointers to owner's current
433 * skill and experience objects. 494 * skill and experience objects.
495 * ACTUALLY NO! investigate! TODO
434 */ 496 */
435void 497void
436object::set_owner (object *owner) 498object::set_owner (object *owner)
437{ 499{
500 // allow objects which own objects
438 if (!owner) 501 if (owner)
439 return;
440
441 /* next line added to allow objects which own objects */
442 /* Add a check for ownercounts in here, as I got into an endless loop
443 * with the fireball owning a poison cloud which then owned the
444 * fireball. I believe that was caused by one of the objects getting
445 * freed and then another object replacing it. Since the ownercounts
446 * didn't match, this check is valid and I believe that cause is valid.
447 */
448 while (owner->owner) 502 while (owner->owner)
449 owner = owner->owner; 503 owner = owner->owner;
504
505 if (flag [FLAG_FREED])
506 {
507 LOG (llevError | logBacktrace, "tried to set owner of %s to %s\n", debug_desc (), owner->debug_desc ());
508 return;
509 }
450 510
451 this->owner = owner; 511 this->owner = owner;
452} 512}
453 513
454void 514int
515object::slottype () const
516{
517 if (type == SKILL)
518 {
519 if (IS_COMBAT_SKILL (subtype)) return slot_combat;
520 if (IS_RANGED_SKILL (subtype)) return slot_ranged;
521 }
522 else
523 {
524 if (slot [body_combat].info) return slot_combat;
525 if (slot [body_range ].info) return slot_ranged;
526 }
527
528 return slot_none;
529}
530
531bool
455object::set_weapon (object *ob) 532object::change_weapon (object *ob)
456{ 533{
457 if (current_weapon == ob) 534 if (current_weapon == ob)
458 return; 535 return true;
536
537 if (chosen_skill)
538 chosen_skill->flag [FLAG_APPLIED] = false;
459 539
460 current_weapon = ob; 540 current_weapon = ob;
461 new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name); 541 chosen_skill = !ob || ob->type == SKILL ? ob : find_skill_by_name (this, ob->skill);
542
543 if (chosen_skill)
544 chosen_skill->flag [FLAG_APPLIED] = true;
545
462 update_stats (); 546 update_stats ();
547
548 if (ob)
549 {
550 // now check wether any body locations became invalid, in which case
551 // we cannot apply the weapon at the moment.
552 for (int i = 0; i < NUM_BODY_LOCATIONS; ++i)
553 if (slot[i].used < 0)
554 {
555 current_weapon = chosen_skill = 0;
556 update_stats ();
557
558 new_draw_info_format (NDI_UNIQUE, 0, this,
559 "You try to balance all your items at once, "
560 "but the %s is just too much for your body. "
561 "[You need to unapply some items first.]", &ob->name);
562 return false;
563 }
564
565 //new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name);
566 }
567 else
568 ;//new_draw_info_format (NDI_UNIQUE, 0, this, "You unwield your weapons.");
569
570 if (ob && !ob->flag [FLAG_APPLIED] && ob->type != SPELL)
571 {
572 LOG (llevError | logBacktrace, "%s changed to unapplied weapon %s",
573 &name, ob->debug_desc ());
574 return false;
575 }
576
577 return true;
463} 578}
464 579
465/* Zero the key_values on op, decrementing the shared-string 580/* Zero the key_values on op, decrementing the shared-string
466 * refcounts and freeing the links. 581 * refcounts and freeing the links.
467 */ 582 */
477 } 592 }
478 593
479 op->key_values = 0; 594 op->key_values = 0;
480} 595}
481 596
482object & 597/*
483object::operator =(const object &src) 598 * copy_to first frees everything allocated by the dst object,
599 * and then copies the contents of itself into the second
600 * object, allocating what needs to be allocated. Basically, any
601 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
602 * if the first object is freed, the pointers in the new object
603 * will point at garbage.
604 */
605void
606object::copy_to (object *dst)
484{ 607{
485 bool is_freed = flag [FLAG_FREED]; 608 dst->remove ();
486 bool is_removed = flag [FLAG_REMOVED];
487
488 *(object_copy *)this = src; 609 *(object_copy *)dst = *this;
489
490 flag [FLAG_FREED] = is_freed;
491 flag [FLAG_REMOVED] = is_removed; 610 dst->flag [FLAG_REMOVED] = true;
492 611
493 /* Copy over key_values, if any. */ 612 /* Copy over key_values, if any. */
494 if (src.key_values) 613 if (key_values)
495 { 614 {
496 key_value *tail = 0; 615 key_value *tail = 0;
497 key_values = 0; 616 dst->key_values = 0;
498 617
499 for (key_value *i = src.key_values; i; i = i->next) 618 for (key_value *i = key_values; i; i = i->next)
500 { 619 {
501 key_value *new_link = new key_value; 620 key_value *new_link = new key_value;
502 621
503 new_link->next = 0; 622 new_link->next = 0;
504 new_link->key = i->key; 623 new_link->key = i->key;
505 new_link->value = i->value; 624 new_link->value = i->value;
506 625
507 /* Try and be clever here, too. */ 626 /* Try and be clever here, too. */
508 if (!key_values) 627 if (!dst->key_values)
509 { 628 {
510 key_values = new_link; 629 dst->key_values = new_link;
511 tail = new_link; 630 tail = new_link;
512 } 631 }
513 else 632 else
514 { 633 {
515 tail->next = new_link; 634 tail->next = new_link;
516 tail = new_link; 635 tail = new_link;
517 } 636 }
518 } 637 }
519 } 638 }
520}
521
522/*
523 * copy_to first frees everything allocated by the dst object,
524 * and then copies the contents of itself into the second
525 * object, allocating what needs to be allocated. Basically, any
526 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
527 * if the first object is freed, the pointers in the new object
528 * will point at garbage.
529 */
530void
531object::copy_to (object *dst)
532{
533 *dst = *this;
534 639
535 if (speed < 0) 640 if (speed < 0)
536 dst->speed_left = speed_left - rndm (); 641 dst->speed_left -= rndm ();
537 642
538 dst->set_speed (dst->speed); 643 dst->set_speed (dst->speed);
539} 644}
540 645
541void 646void
542object::instantiate () 647object::instantiate ()
543{ 648{
544 if (!uuid.seq) // HACK 649 if (!uuid.seq) // HACK
545 uuid = gen_uuid (); 650 uuid = UUID::gen ();
546 651
547 speed_left = -0.1f; 652 speed_left = -0.1f;
548 /* copy the body_info to the body_used - this is only really 653 /* copy the body_info to the body_used - this is only really
549 * need for monsters, but doesn't hurt to do it for everything. 654 * need for monsters, but doesn't hurt to do it for everything.
550 * by doing so, when a monster is created, it has good starting 655 * by doing so, when a monster is created, it has good starting
560object * 665object *
561object::clone () 666object::clone ()
562{ 667{
563 object *neu = create (); 668 object *neu = create ();
564 copy_to (neu); 669 copy_to (neu);
670 neu->map = map; // not copied by copy_to
565 return neu; 671 return neu;
566} 672}
567 673
568/* 674/*
569 * If an object with the IS_TURNABLE() flag needs to be turned due 675 * If an object with the IS_TURNABLE() flag needs to be turned due
620 * UP_OBJ_FACE: only the objects face has changed. 726 * UP_OBJ_FACE: only the objects face has changed.
621 */ 727 */
622void 728void
623update_object (object *op, int action) 729update_object (object *op, int action)
624{ 730{
625 if (op == NULL) 731 if (!op)
626 { 732 {
627 /* this should never happen */ 733 /* this should never happen */
628 LOG (llevDebug, "update_object() called for NULL object.\n"); 734 LOG (llevError | logBacktrace, "update_object() called for NULL object.\n");
629 return; 735 return;
630 } 736 }
631 737
632 if (op->env) 738 if (!op->is_on_map ())
633 { 739 {
634 /* Animation is currently handled by client, so nothing 740 /* Animation is currently handled by client, so nothing
635 * to do in this case. 741 * to do in this case.
636 */ 742 */
637 return; 743 return;
638 } 744 }
639
640 /* If the map is saving, don't do anything as everything is
641 * going to get freed anyways.
642 */
643 if (!op->map || op->map->in_memory == MAP_SAVING)
644 return;
645 745
646 /* make sure the object is within map boundaries */ 746 /* make sure the object is within map boundaries */
647 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height) 747 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
648 { 748 {
649 LOG (llevError, "update_object() called for object out of map!\n"); 749 LOG (llevError, "update_object() called for object out of map!\n");
709static int object_count; 809static int object_count;
710 810
711void object::link () 811void object::link ()
712{ 812{
713 assert (!index);//D 813 assert (!index);//D
714 uuid = gen_uuid (); 814 uuid = UUID::gen ();
715 count = ++object_count; 815 count = ++object_count;
716 816
717 refcnt_inc (); 817 refcnt_inc ();
718 objects.insert (this); 818 objects.insert (this);
719} 819}
792object::destroy_inv (bool drop_to_ground) 892object::destroy_inv (bool drop_to_ground)
793{ 893{
794 // need to check first, because the checks below might segfault 894 // need to check first, because the checks below might segfault
795 // as we might be on an invalid mapspace and crossfire code 895 // as we might be on an invalid mapspace and crossfire code
796 // is too buggy to ensure that the inventory is empty. 896 // is too buggy to ensure that the inventory is empty.
797 // corollary: if you create arrows etc. with stuff in tis inventory, 897 // corollary: if you create arrows etc. with stuff in its inventory,
798 // cf will crash below with off-map x and y 898 // cf will crash below with off-map x and y
799 if (!inv) 899 if (!inv)
800 return; 900 return;
801 901
802 /* Only if the space blocks everything do we not process - 902 /* Only if the space blocks everything do we not process -
803 * if some form of movement is allowed, let objects 903 * if some form of movement is allowed, let objects
804 * drop on that space. 904 * drop on that space.
805 */ 905 */
806 if (!drop_to_ground 906 if (!drop_to_ground
807 || !map 907 || !map
808 || map->in_memory != MAP_IN_MEMORY 908 || map->in_memory != MAP_ACTIVE
809 || map->nodrop 909 || map->nodrop
810 || ms ().move_block == MOVE_ALL) 910 || ms ().move_block == MOVE_ALL)
811 { 911 {
812 while (inv) 912 while (inv)
813 { 913 {
814 inv->destroy_inv (drop_to_ground); 914 inv->destroy_inv (false);
815 inv->destroy (); 915 inv->destroy ();
816 } 916 }
817 } 917 }
818 else 918 else
819 { /* Put objects in inventory onto this space */ 919 { /* Put objects in inventory onto this space */
825 || op->flag [FLAG_NO_DROP] 925 || op->flag [FLAG_NO_DROP]
826 || op->type == RUNE 926 || op->type == RUNE
827 || op->type == TRAP 927 || op->type == TRAP
828 || op->flag [FLAG_IS_A_TEMPLATE] 928 || op->flag [FLAG_IS_A_TEMPLATE]
829 || op->flag [FLAG_DESTROY_ON_DEATH]) 929 || op->flag [FLAG_DESTROY_ON_DEATH])
830 op->destroy (); 930 op->destroy (true);
831 else 931 else
832 map->insert (op, x, y); 932 map->insert (op, x, y);
833 } 933 }
834 } 934 }
835} 935}
839 object *op = new object; 939 object *op = new object;
840 op->link (); 940 op->link ();
841 return op; 941 return op;
842} 942}
843 943
944static struct freed_map : maptile
945{
946 freed_map ()
947 {
948 path = "<freed objects map>";
949 name = "/internal/freed_objects_map";
950 width = 3;
951 height = 3;
952 nodrop = 1;
953
954 alloc ();
955 in_memory = MAP_ACTIVE;
956 }
957
958 ~freed_map ()
959 {
960 destroy ();
961 }
962} freed_map; // freed objects are moved here to avoid crashes
963
844void 964void
845object::do_destroy () 965object::do_destroy ()
846{ 966{
847 attachable::do_destroy ();
848
849 if (flag [FLAG_IS_LINKED]) 967 if (flag [FLAG_IS_LINKED])
850 remove_button_link (this); 968 remove_button_link (this);
851 969
852 if (flag [FLAG_FRIENDLY]) 970 if (flag [FLAG_FRIENDLY])
853 remove_friendly_object (this); 971 remove_friendly_object (this);
854 972
855 if (!flag [FLAG_REMOVED])
856 remove (); 973 remove ();
857 974
858 destroy_inv (true); 975 attachable::do_destroy ();
859 976
860 deactivate (); 977 deactivate ();
861 unlink (); 978 unlink ();
862 979
863 flag [FLAG_FREED] = 1; 980 flag [FLAG_FREED] = 1;
864 981
865 // hack to ensure that freed objects still have a valid map 982 // hack to ensure that freed objects still have a valid map
866 {
867 static maptile *freed_map; // freed objects are moved here to avoid crashes
868
869 if (!freed_map)
870 {
871 freed_map = new maptile;
872
873 freed_map->name = "/internal/freed_objects_map";
874 freed_map->width = 3;
875 freed_map->height = 3;
876
877 freed_map->alloc ();
878 freed_map->in_memory = MAP_IN_MEMORY;
879 }
880
881 map = freed_map; 983 map = &freed_map;
882 x = 1; 984 x = 1;
883 y = 1; 985 y = 1;
884 }
885
886 head = 0;
887 986
888 if (more) 987 if (more)
889 { 988 {
890 more->destroy (); 989 more->destroy ();
891 more = 0; 990 more = 0;
892 } 991 }
893 992
993 head = 0;
994
894 // clear those pointers that likely might have circular references to us 995 // clear those pointers that likely might cause circular references
895 owner = 0; 996 owner = 0;
896 enemy = 0; 997 enemy = 0;
897 attacked_by = 0; 998 attacked_by = 0;
999 current_weapon = 0;
898} 1000}
899 1001
900void 1002void
901object::destroy (bool destroy_inventory) 1003object::destroy (bool destroy_inventory)
902{ 1004{
903 if (destroyed ()) 1005 if (destroyed ())
904 return; 1006 return;
905 1007
1008 if (!is_head () && !head->destroyed ())
1009 {
1010 LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
1011 head->destroy (destroy_inventory);
1012 return;
1013 }
1014
906 if (destroy_inventory) 1015 destroy_inv (!destroy_inventory);
907 destroy_inv (false); 1016
1017 if (is_head ())
1018 if (sound_destroy)
1019 play_sound (sound_destroy);
1020 else if (flag [FLAG_MONSTER])
1021 play_sound (sound_find ("monster_destroy")); // quick hack, too lazy to create a generic mechanism
908 1022
909 attachable::destroy (); 1023 attachable::destroy ();
910}
911
912/*
913 * sub_weight() recursively (outwards) subtracts a number from the
914 * weight of an object (and what is carried by it's environment(s)).
915 */
916void
917sub_weight (object *op, signed long weight)
918{
919 while (op != NULL)
920 {
921 if (op->type == CONTAINER)
922 weight = (signed long) (weight * (100 - op->stats.Str) / 100);
923
924 op->carrying -= weight;
925 op = op->env;
926 }
927} 1024}
928 1025
929/* op->remove (): 1026/* op->remove ():
930 * This function removes the object op from the linked list of objects 1027 * This function removes the object op from the linked list of objects
931 * which it is currently tied to. When this function is done, the 1028 * which it is currently tied to. When this function is done, the
937object::do_remove () 1034object::do_remove ()
938{ 1035{
939 object *tmp, *last = 0; 1036 object *tmp, *last = 0;
940 object *otmp; 1037 object *otmp;
941 1038
942 if (QUERY_FLAG (this, FLAG_REMOVED)) 1039 if (flag [FLAG_REMOVED])
943 return; 1040 return;
944 1041
945 SET_FLAG (this, FLAG_REMOVED);
946 INVOKE_OBJECT (REMOVE, this); 1042 INVOKE_OBJECT (REMOVE, this);
1043
1044 flag [FLAG_REMOVED] = true;
947 1045
948 if (more) 1046 if (more)
949 more->remove (); 1047 more->remove ();
950 1048
951 /* 1049 /*
952 * In this case, the object to be removed is in someones 1050 * In this case, the object to be removed is in someones
953 * inventory. 1051 * inventory.
954 */ 1052 */
955 if (env) 1053 if (env)
956 { 1054 {
957 if (nrof) 1055 flag [FLAG_REMOVED] = false; // hack around the issue of visible_to checking flag_removed
958 sub_weight (env, weight * nrof); 1056 if (object *pl = visible_to ())
959 else 1057 esrv_del_item (pl->contr, count);
960 sub_weight (env, weight + carrying); 1058 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
1059
1060 adjust_weight (env, -total_weight ());
1061
1062 /* we set up values so that it could be inserted into
1063 * the map, but we don't actually do that - it is up
1064 * to the caller to decide what we want to do.
1065 */
1066 map = env->map;
1067 x = env->x;
1068 y = env->y;
1069
1070 // make sure cmov optimisation is applicable
1071 *(above ? &above->below : &env->inv) = below;
1072 *(below ? &below->above : &above ) = above; // &above is just a dummy
1073
1074 above = 0;
1075 below = 0;
1076 env = 0;
961 1077
962 /* NO_FIX_PLAYER is set when a great many changes are being 1078 /* NO_FIX_PLAYER is set when a great many changes are being
963 * made to players inventory. If set, avoiding the call 1079 * made to players inventory. If set, avoiding the call
964 * to save cpu time. 1080 * to save cpu time.
965 */ 1081 */
966 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1082 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
967 otmp->update_stats (); 1083 otmp->update_stats ();
968
969 if (above)
970 above->below = below;
971 else
972 env->inv = below;
973
974 if (below)
975 below->above = above;
976
977 /* we set up values so that it could be inserted into
978 * the map, but we don't actually do that - it is up
979 * to the caller to decide what we want to do.
980 */
981 x = env->x, y = env->y;
982 map = env->map;
983 above = 0, below = 0;
984 env = 0;
985 } 1084 }
986 else if (map) 1085 else if (map)
987 { 1086 {
988 if (type == PLAYER)
989 {
990 // leaving a spot always closes any open container on the ground
991 if (container && !container->env)
992 // this causes spurious floorbox updates, but it ensures
993 // that the CLOSE event is being sent.
994 close_container ();
995
996 --map->players;
997 map->touch ();
998 }
999
1000 map->dirty = true; 1087 map->dirty = true;
1001 mapspace &ms = this->ms (); 1088 mapspace &ms = this->ms ();
1002 1089
1090 if (object *pl = ms.player ())
1091 {
1092 if (type == PLAYER) // this == pl(!)
1093 {
1094 // leaving a spot always closes any open container on the ground
1095 if (container && !container->env)
1096 // this causes spurious floorbox updates, but it ensures
1097 // that the CLOSE event is being sent.
1098 close_container ();
1099
1100 --map->players;
1101 map->touch ();
1102 }
1103 else if (pl->container == this)
1104 {
1105 // removing a container should close it
1106 close_container ();
1107 }
1108
1109 esrv_del_item (pl->contr, count);
1110 }
1111
1003 /* link the object above us */ 1112 /* link the object above us */
1004 if (above) 1113 // re-link, make sure compiler can easily use cmove
1005 above->below = below; 1114 *(above ? &above->below : &ms.top) = below;
1006 else 1115 *(below ? &below->above : &ms.bot) = above;
1007 ms.top = below; /* we were top, set new top */
1008
1009 /* Relink the object below us, if there is one */
1010 if (below)
1011 below->above = above;
1012 else
1013 {
1014 /* Nothing below, which means we need to relink map object for this space
1015 * use translated coordinates in case some oddness with map tiling is
1016 * evident
1017 */
1018 if (GET_MAP_OB (map, x, y) != this)
1019 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1020
1021 ms.bot = above; /* goes on above it. */
1022 }
1023 1116
1024 above = 0; 1117 above = 0;
1025 below = 0; 1118 below = 0;
1026 1119
1027 if (map->in_memory == MAP_SAVING) 1120 if (map->in_memory == MAP_SAVING)
1028 return; 1121 return;
1029 1122
1030 int check_walk_off = !flag [FLAG_NO_APPLY]; 1123 int check_walk_off = !flag [FLAG_NO_APPLY];
1124
1125 if (object *pl = ms.player ())
1126 {
1127 if (pl->container == this)
1128 /* If a container that the player is currently using somehow gets
1129 * removed (most likely destroyed), update the player view
1130 * appropriately.
1131 */
1132 pl->close_container ();
1133
1134 //TODO: the floorbox prev/next might need updating
1135 //esrv_del_item (pl->contr, count);
1136 //TODO: update floorbox to preserve ordering
1137 if (pl->contr->ns)
1138 pl->contr->ns->floorbox_update ();
1139 }
1031 1140
1032 for (tmp = ms.bot; tmp; tmp = tmp->above) 1141 for (tmp = ms.bot; tmp; tmp = tmp->above)
1033 { 1142 {
1034 /* No point updating the players look faces if he is the object 1143 /* No point updating the players look faces if he is the object
1035 * being removed. 1144 * being removed.
1036 */ 1145 */
1037
1038 if (tmp->type == PLAYER && tmp != this)
1039 {
1040 /* If a container that the player is currently using somehow gets
1041 * removed (most likely destroyed), update the player view
1042 * appropriately.
1043 */
1044 if (tmp->container == this)
1045 {
1046 flag [FLAG_APPLIED] = 0;
1047 tmp->container = 0;
1048 }
1049
1050 if (tmp->contr->ns)
1051 tmp->contr->ns->floorbox_update ();
1052 }
1053 1146
1054 /* See if object moving off should effect something */ 1147 /* See if object moving off should effect something */
1055 if (check_walk_off 1148 if (check_walk_off
1056 && ((move_type & tmp->move_off) 1149 && ((move_type & tmp->move_off)
1057 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1150 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0))
1060 1153
1061 if (destroyed ()) 1154 if (destroyed ())
1062 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ()); 1155 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1063 } 1156 }
1064 1157
1065 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */
1066 //TODO: why is this horrible hacka fix? get rid of this code=bug! (schmorp)
1067 if (tmp->above == tmp)
1068 tmp->above = 0;
1069
1070 last = tmp; 1158 last = tmp;
1071 } 1159 }
1072 1160
1073 /* last == NULL if there are no objects on this space */ 1161 /* last == NULL if there are no objects on this space */
1074 //TODO: this makes little sense, why only update the topmost object? 1162 //TODO: this makes little sense, why only update the topmost object?
1094merge_ob (object *op, object *top) 1182merge_ob (object *op, object *top)
1095{ 1183{
1096 if (!op->nrof) 1184 if (!op->nrof)
1097 return 0; 1185 return 0;
1098 1186
1099 if (top) 1187 if (!top)
1100 for (top = op; top && top->above; top = top->above) 1188 for (top = op; top && top->above; top = top->above)
1101 ; 1189 ;
1102 1190
1103 for (; top; top = top->below) 1191 for (; top; top = top->below)
1104 {
1105 if (top == op)
1106 continue;
1107
1108 if (object::can_merge (op, top)) 1192 if (object::can_merge (op, top))
1109 { 1193 {
1110 top->nrof += op->nrof; 1194 top->nrof += op->nrof;
1111 1195
1112/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/ 1196 if (object *pl = top->visible_to ())
1113 op->weight = 0; /* Don't want any adjustements now */ 1197 esrv_update_item (UPD_NROF, pl, top);
1198
1199 op->weight = 0; // cancel the addition above
1200 op->carrying = 0; // must be 0 already
1201
1114 op->destroy (); 1202 op->destroy (1);
1203
1115 return top; 1204 return top;
1116 } 1205 }
1117 }
1118 1206
1119 return 0; 1207 return 0;
1120} 1208}
1121 1209
1122void 1210void
1125 if (more) 1213 if (more)
1126 return; 1214 return;
1127 1215
1128 object *prev = this; 1216 object *prev = this;
1129 1217
1130 for (archetype *at = arch->more; at; at = at->more) 1218 for (archetype *at = (archetype *)arch->more; at; at = (archetype *)at->more)
1131 { 1219 {
1132 object *op = arch_to_object (at); 1220 object *op = arch_to_object (at);
1133 1221
1134 op->name = name; 1222 op->name = name;
1135 op->name_pl = name_pl; 1223 op->name_pl = name_pl;
1149object * 1237object *
1150insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1238insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1151{ 1239{
1152 for (object *tmp = op->head_ (); tmp; tmp = tmp->more) 1240 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1153 { 1241 {
1154 tmp->x = x + tmp->arch->clone.x; 1242 tmp->x = x + tmp->arch->x;
1155 tmp->y = y + tmp->arch->clone.y; 1243 tmp->y = y + tmp->arch->y;
1156 } 1244 }
1157 1245
1158 return insert_ob_in_map (op, m, originator, flag); 1246 return insert_ob_in_map (op, m, originator, flag);
1159} 1247}
1160 1248
1179 * just 'op' otherwise 1267 * just 'op' otherwise
1180 */ 1268 */
1181object * 1269object *
1182insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1270insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1183{ 1271{
1184 assert (!op->flag [FLAG_FREED]);
1185
1186 object *tmp, *top, *floor = NULL;
1187
1188 op->remove (); 1272 op->remove ();
1189
1190#if 0
1191 if (!m->active != !op->active)
1192 if (m->active)
1193 op->activate_recursive ();
1194 else
1195 op->deactivate_recursive ();
1196#endif
1197
1198 if (out_of_map (m, op->x, op->y))
1199 {
1200 LOG (llevError, "Trying to insert object outside the map.\n%s\n", op->debug_desc ());
1201#ifdef MANY_CORES
1202 /* Better to catch this here, as otherwise the next use of this object
1203 * is likely to cause a crash. Better to find out where it is getting
1204 * improperly inserted.
1205 */
1206 abort ();
1207#endif
1208 return op;
1209 }
1210
1211 if (object *more = op->more)
1212 {
1213 if (!insert_ob_in_map (more, m, originator, flag))
1214 {
1215 if (!op->head)
1216 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n");
1217
1218 return 0;
1219 }
1220 }
1221
1222 CLEAR_FLAG (op, FLAG_REMOVED);
1223 1273
1224 /* Ideally, the caller figures this out. However, it complicates a lot 1274 /* Ideally, the caller figures this out. However, it complicates a lot
1225 * of areas of callers (eg, anything that uses find_free_spot would now 1275 * of areas of callers (eg, anything that uses find_free_spot would now
1226 * need extra work 1276 * need extra work
1227 */ 1277 */
1228 if (!xy_normalise (m, op->x, op->y)) 1278 if (!xy_normalise (m, op->x, op->y))
1279 {
1280 op->head_ ()->destroy (1);// remove head_ once all tail object destroyers found
1229 return 0; 1281 return 0;
1282 }
1283
1284 if (object *more = op->more)
1285 if (!insert_ob_in_map (more, m, originator, flag))
1286 return 0;
1287
1288 CLEAR_FLAG (op, FLAG_REMOVED);
1230 1289
1231 op->map = m; 1290 op->map = m;
1232 mapspace &ms = op->ms (); 1291 mapspace &ms = op->ms ();
1233 1292
1234 /* this has to be done after we translate the coordinates. 1293 /* this has to be done after we translate the coordinates.
1235 */ 1294 */
1236 if (op->nrof && !(flag & INS_NO_MERGE)) 1295 if (op->nrof && !(flag & INS_NO_MERGE))
1237 for (tmp = ms.bot; tmp; tmp = tmp->above) 1296 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1238 if (object::can_merge (op, tmp)) 1297 if (object::can_merge (op, tmp))
1239 { 1298 {
1299 // TODO: we actually want to update tmp, not op,
1300 // but some caller surely breaks when we return tmp
1301 // from here :/
1240 op->nrof += tmp->nrof; 1302 op->nrof += tmp->nrof;
1241 tmp->destroy (); 1303 tmp->destroy (1);
1242 } 1304 }
1243 1305
1244 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1306 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1245 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1307 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1246 1308
1247 if (!QUERY_FLAG (op, FLAG_ALIVE)) 1309 if (!QUERY_FLAG (op, FLAG_ALIVE))
1248 CLEAR_FLAG (op, FLAG_NO_STEAL); 1310 CLEAR_FLAG (op, FLAG_NO_STEAL);
1249 1311
1250 if (flag & INS_BELOW_ORIGINATOR) 1312 if (flag & INS_BELOW_ORIGINATOR)
1251 { 1313 {
1252 if (originator->map != op->map || originator->x != op->x || originator->y != op->y) 1314 if (originator->map != op->map || originator->x != op->x || originator->y != op->y || !originator->is_on_map ())
1253 { 1315 {
1254 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n"); 1316 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1255 abort (); 1317 abort ();
1256 } 1318 }
1257 1319
1258 op->above = originator; 1320 op->above = originator;
1259 op->below = originator->below; 1321 op->below = originator->below;
1260
1261 if (op->below)
1262 op->below->above = op;
1263 else
1264 ms.bot = op;
1265
1266 /* since *below* originator, no need to update top */
1267 originator->below = op; 1322 originator->below = op;
1323
1324 *(op->below ? &op->below->above : &ms.bot) = op;
1268 } 1325 }
1269 else 1326 else
1270 { 1327 {
1271 top = ms.bot; 1328 object *floor = 0;
1329 object *top = ms.top;
1272 1330
1273 /* If there are other objects, then */ 1331 /* If there are other objects, then */
1274 if ((!(flag & INS_MAP_LOAD)) && top) 1332 if (top)
1275 { 1333 {
1276 object *last = 0;
1277
1278 /* 1334 /*
1279 * If there are multiple objects on this space, we do some trickier handling. 1335 * If there are multiple objects on this space, we do some trickier handling.
1280 * We've already dealt with merging if appropriate. 1336 * We've already dealt with merging if appropriate.
1281 * Generally, we want to put the new object on top. But if 1337 * Generally, we want to put the new object on top. But if
1282 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last 1338 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
1285 * once we get to them. This reduces the need to traverse over all of 1341 * once we get to them. This reduces the need to traverse over all of
1286 * them when adding another one - this saves quite a bit of cpu time 1342 * them when adding another one - this saves quite a bit of cpu time
1287 * when lots of spells are cast in one area. Currently, it is presumed 1343 * when lots of spells are cast in one area. Currently, it is presumed
1288 * that flying non pickable objects are spell objects. 1344 * that flying non pickable objects are spell objects.
1289 */ 1345 */
1290 for (top = ms.bot; top; top = top->above) 1346 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1291 { 1347 {
1292 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1348 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) || QUERY_FLAG (tmp, FLAG_OVERLAY_FLOOR))
1293 floor = top; 1349 floor = tmp;
1294 1350
1295 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1351 if (QUERY_FLAG (tmp, FLAG_NO_PICK) && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (tmp, FLAG_IS_FLOOR))
1296 { 1352 {
1297 /* We insert above top, so we want this object below this */ 1353 /* We insert above top, so we want this object below this */
1298 top = top->below; 1354 top = tmp->below;
1299 break; 1355 break;
1300 } 1356 }
1301 1357
1302 last = top; 1358 top = tmp;
1303 } 1359 }
1304
1305 /* Don't want top to be NULL, so set it to the last valid object */
1306 top = last;
1307 1360
1308 /* We let update_position deal with figuring out what the space 1361 /* We let update_position deal with figuring out what the space
1309 * looks like instead of lots of conditions here. 1362 * looks like instead of lots of conditions here.
1310 * makes things faster, and effectively the same result. 1363 * makes things faster, and effectively the same result.
1311 */ 1364 */
1318 */ 1371 */
1319 if (!(flag & INS_ON_TOP) 1372 if (!(flag & INS_ON_TOP)
1320 && ms.flags () & P_BLOCKSVIEW 1373 && ms.flags () & P_BLOCKSVIEW
1321 && (op->face && !faces [op->face].visibility)) 1374 && (op->face && !faces [op->face].visibility))
1322 { 1375 {
1376 object *last;
1377
1323 for (last = top; last != floor; last = last->below) 1378 for (last = top; last != floor; last = last->below)
1324 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1379 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1325 break; 1380 break;
1326 1381
1327 /* Check to see if we found the object that blocks view, 1382 /* Check to see if we found the object that blocks view,
1332 if (last && last->below && last != floor) 1387 if (last && last->below && last != floor)
1333 top = last->below; 1388 top = last->below;
1334 } 1389 }
1335 } /* If objects on this space */ 1390 } /* If objects on this space */
1336 1391
1337 if (flag & INS_MAP_LOAD)
1338 top = ms.top;
1339
1340 if (flag & INS_ABOVE_FLOOR_ONLY) 1392 if (flag & INS_ABOVE_FLOOR_ONLY)
1341 top = floor; 1393 top = floor;
1342 1394
1343 /* Top is the object that our object (op) is going to get inserted above. 1395 /* Top is the object that our object (op) is going to get inserted above.
1344 */ 1396 */
1345 1397
1346 /* First object on this space */ 1398 /* no top found, insert on top */
1347 if (!top) 1399 if (!top)
1348 { 1400 {
1349 op->above = ms.bot;
1350
1351 if (op->above)
1352 op->above->below = op;
1353
1354 op->below = 0; 1401 op->above = 0;
1402 op->below = ms.top;
1355 ms.bot = op; 1403 ms.top = op;
1404
1405 *(op->below ? &op->below->above : &ms.bot) = op;
1356 } 1406 }
1357 else 1407 else
1358 { /* get inserted into the stack above top */ 1408 { /* get inserted into the stack above top */
1359 op->above = top->above; 1409 op->above = top->above;
1360
1361 if (op->above)
1362 op->above->below = op; 1410 top->above = op;
1363 1411
1364 op->below = top; 1412 op->below = top;
1365 top->above = op; 1413 *(op->above ? &op->above->below : &ms.top) = op;
1366 } 1414 }
1367
1368 if (!op->above)
1369 ms.top = op;
1370 } /* else not INS_BELOW_ORIGINATOR */ 1415 } /* else not INS_BELOW_ORIGINATOR */
1371 1416
1372 if (op->type == PLAYER) 1417 if (op->type == PLAYER)
1373 { 1418 {
1374 op->contr->do_los = 1; 1419 op->contr->do_los = 1;
1376 op->map->touch (); 1421 op->map->touch ();
1377 } 1422 }
1378 1423
1379 op->map->dirty = true; 1424 op->map->dirty = true;
1380 1425
1381 /* If we have a floor, we know the player, if any, will be above
1382 * it, so save a few ticks and start from there.
1383 */
1384 if (!(flag & INS_MAP_LOAD))
1385 if (object *pl = ms.player ()) 1426 if (object *pl = ms.player ())
1427 //TODO: the floorbox prev/next might need updating
1428 //esrv_send_item (pl, op);
1429 //TODO: update floorbox to preserve ordering
1386 if (pl->contr->ns) 1430 if (pl->contr->ns)
1387 pl->contr->ns->floorbox_update (); 1431 pl->contr->ns->floorbox_update ();
1388 1432
1389 /* If this object glows, it may affect lighting conditions that are 1433 /* If this object glows, it may affect lighting conditions that are
1390 * visible to others on this map. But update_all_los is really 1434 * visible to others on this map. But update_all_los is really
1391 * an inefficient way to do this, as it means los for all players 1435 * an inefficient way to do this, as it means los for all players
1392 * on the map will get recalculated. The players could very well 1436 * on the map will get recalculated. The players could very well
1411 * blocked() and wall() work properly), and these flags are updated by 1455 * blocked() and wall() work properly), and these flags are updated by
1412 * update_object(). 1456 * update_object().
1413 */ 1457 */
1414 1458
1415 /* if this is not the head or flag has been passed, don't check walk on status */ 1459 /* if this is not the head or flag has been passed, don't check walk on status */
1416 if (!(flag & INS_NO_WALK_ON) && !op->head) 1460 if (!(flag & INS_NO_WALK_ON) && op->head_ () == op)
1417 { 1461 {
1418 if (check_move_on (op, originator)) 1462 if (check_move_on (op, originator))
1419 return 0; 1463 return 0;
1420 1464
1421 /* If we are a multi part object, lets work our way through the check 1465 /* If we are a multi part object, lets work our way through the check
1422 * walk on's. 1466 * walk on's.
1423 */ 1467 */
1424 for (tmp = op->more; tmp != NULL; tmp = tmp->more) 1468 for (object *tmp = op->more; tmp; tmp = tmp->more)
1425 if (check_move_on (tmp, originator)) 1469 if (check_move_on (tmp, originator))
1426 return 0; 1470 return 0;
1427 } 1471 }
1428 1472
1429 return op; 1473 return op;
1434 * op is the object to insert it under: supplies x and the map. 1478 * op is the object to insert it under: supplies x and the map.
1435 */ 1479 */
1436void 1480void
1437replace_insert_ob_in_map (const char *arch_string, object *op) 1481replace_insert_ob_in_map (const char *arch_string, object *op)
1438{ 1482{
1439 object *tmp, *tmp1;
1440
1441 /* first search for itself and remove any old instances */ 1483 /* first search for itself and remove any old instances */
1442 1484
1443 for (tmp = op->ms ().bot; tmp; tmp = tmp->above) 1485 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1444 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */ 1486 if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */
1445 tmp->destroy (); 1487 tmp->destroy (1);
1446 1488
1447 tmp1 = arch_to_object (archetype::find (arch_string)); 1489 object *tmp = arch_to_object (archetype::find (arch_string));
1448 1490
1449 tmp1->x = op->x; 1491 tmp->x = op->x;
1450 tmp1->y = op->y; 1492 tmp->y = op->y;
1493
1451 insert_ob_in_map (tmp1, op->map, op, 0); 1494 insert_ob_in_map (tmp, op->map, op, 0);
1452} 1495}
1453 1496
1454object * 1497object *
1455object::insert_at (object *where, object *originator, int flags) 1498object::insert_at (object *where, object *originator, int flags)
1456{ 1499{
1500 if (where->env)
1501 return where->env->insert (this);
1502 else
1457 return where->map->insert (this, where->x, where->y, originator, flags); 1503 return where->map->insert (this, where->x, where->y, originator, flags);
1458} 1504}
1459 1505
1460/* 1506/*
1461 * get_split_ob(ob,nr) splits up ob into two parts. The part which
1462 * is returned contains nr objects, and the remaining parts contains
1463 * the rest (or is removed and freed if that number is 0).
1464 * On failure, NULL is returned, and the reason put into the
1465 * global static errmsg array.
1466 */
1467object *
1468get_split_ob (object *orig_ob, uint32 nr)
1469{
1470 object *newob;
1471 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1472
1473 if (orig_ob->nrof < nr)
1474 {
1475 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1476 return NULL;
1477 }
1478
1479 newob = object_create_clone (orig_ob);
1480
1481 if ((orig_ob->nrof -= nr) < 1)
1482 orig_ob->destroy (1);
1483 else if (!is_removed)
1484 {
1485 if (orig_ob->env != NULL)
1486 sub_weight (orig_ob->env, orig_ob->weight * nr);
1487 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY)
1488 {
1489 strcpy (errmsg, "Tried to split object whose map is not in memory.");
1490 LOG (llevDebug, "Error, Tried to split object whose map is not in memory.\n");
1491 return NULL;
1492 }
1493 }
1494
1495 newob->nrof = nr;
1496
1497 return newob;
1498}
1499
1500/*
1501 * decrease_ob_nr(object, number) decreases a specified number from 1507 * decrease(object, number) decreases a specified number from
1502 * the amount of an object. If the amount reaches 0, the object 1508 * the amount of an object. If the amount reaches 0, the object
1503 * is subsequently removed and freed. 1509 * is subsequently removed and freed.
1504 * 1510 *
1505 * Return value: 'op' if something is left, NULL if the amount reached 0 1511 * Return value: 'op' if something is left, NULL if the amount reached 0
1506 */ 1512 */
1513bool
1514object::decrease (sint32 nr)
1515{
1516 if (!nr)
1517 return true;
1518
1519 nr = min (nr, nrof);
1520
1521 nrof -= nr;
1522
1523 if (nrof)
1524 {
1525 adjust_weight (env, -weight * nr); // carrying == 0
1526
1527 if (object *pl = visible_to ())
1528 esrv_update_item (UPD_NROF, pl, this);
1529
1530 return true;
1531 }
1532 else
1533 {
1534 destroy (1);
1535 return false;
1536 }
1537}
1538
1539/*
1540 * split(ob,nr) splits up ob into two parts. The part which
1541 * is returned contains nr objects, and the remaining parts contains
1542 * the rest (or is removed and returned if that number is 0).
1543 * On failure, NULL is returned.
1544 */
1507object * 1545object *
1508decrease_ob_nr (object *op, uint32 i) 1546object::split (sint32 nr)
1509{ 1547{
1510 object *tmp; 1548 int have = number_of ();
1511 1549
1512 if (i == 0) /* objects with op->nrof require this check */ 1550 if (have < nr)
1513 return op; 1551 return 0;
1514 1552 else if (have == nr)
1515 if (i > op->nrof)
1516 i = op->nrof;
1517
1518 if (QUERY_FLAG (op, FLAG_REMOVED))
1519 op->nrof -= i;
1520 else if (op->env)
1521 { 1553 {
1522 /* is this object in the players inventory, or sub container
1523 * therein?
1524 */
1525 tmp = op->in_player ();
1526 /* nope. Is this a container the player has opened?
1527 * If so, set tmp to that player.
1528 * IMO, searching through all the players will mostly
1529 * likely be quicker than following op->env to the map,
1530 * and then searching the map for a player.
1531 */
1532 if (!tmp)
1533 for_all_players (pl)
1534 if (pl->ob->container == op->env)
1535 {
1536 tmp = pl->ob;
1537 break;
1538 }
1539
1540 if (i < op->nrof)
1541 {
1542 sub_weight (op->env, op->weight * i);
1543 op->nrof -= i;
1544 if (tmp)
1545 esrv_send_item (tmp, op);
1546 }
1547 else
1548 {
1549 op->remove (); 1554 remove ();
1550 op->nrof = 0; 1555 return this;
1551 if (tmp)
1552 esrv_del_item (tmp->contr, op->count);
1553 }
1554 } 1556 }
1555 else 1557 else
1556 { 1558 {
1557 object *above = op->above; 1559 decrease (nr);
1558 1560
1559 if (i < op->nrof) 1561 object *op = deep_clone ();
1560 op->nrof -= i; 1562 op->nrof = nr;
1561 else
1562 {
1563 op->remove ();
1564 op->nrof = 0;
1565 }
1566
1567 /* Since we just removed op, op->above is null */
1568 for (tmp = above; tmp; tmp = tmp->above)
1569 if (tmp->type == PLAYER)
1570 {
1571 if (op->nrof)
1572 esrv_send_item (tmp, op);
1573 else
1574 esrv_del_item (tmp->contr, op->count);
1575 }
1576 }
1577
1578 if (op->nrof)
1579 return op; 1563 return op;
1580 else
1581 {
1582 op->destroy ();
1583 return 0;
1584 }
1585}
1586
1587/*
1588 * add_weight(object, weight) adds the specified weight to an object,
1589 * and also updates how much the environment(s) is/are carrying.
1590 */
1591void
1592add_weight (object *op, signed long weight)
1593{
1594 while (op != NULL)
1595 {
1596 if (op->type == CONTAINER)
1597 weight = (signed long) (weight * (100 - op->stats.Str) / 100);
1598
1599 op->carrying += weight;
1600 op = op->env;
1601 } 1564 }
1602} 1565}
1603 1566
1604object * 1567object *
1605insert_ob_in_ob (object *op, object *where) 1568insert_ob_in_ob (object *op, object *where)
1610 LOG (llevError, "Trying to put object in NULL.\n%s\n", dump); 1573 LOG (llevError, "Trying to put object in NULL.\n%s\n", dump);
1611 free (dump); 1574 free (dump);
1612 return op; 1575 return op;
1613 } 1576 }
1614 1577
1615 if (where->head) 1578 if (where->head_ () != where)
1616 { 1579 {
1617 LOG (llevDebug, "Warning: Tried to insert object into wrong part of multipart object.\n"); 1580 LOG (llevError | logBacktrace, "Warning: Tried to insert object into wrong part of multipart object.\n");
1618 where = where->head; 1581 where = where->head;
1619 } 1582 }
1620 1583
1621 return where->insert (op); 1584 return where->insert (op);
1622} 1585}
1630 * be != op, if items are merged. -Tero 1593 * be != op, if items are merged. -Tero
1631 */ 1594 */
1632object * 1595object *
1633object::insert (object *op) 1596object::insert (object *op)
1634{ 1597{
1635 object *tmp, *otmp;
1636
1637 if (!QUERY_FLAG (op, FLAG_REMOVED))
1638 op->remove ();
1639
1640 if (op->more) 1598 if (op->more)
1641 { 1599 {
1642 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count); 1600 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);
1643 return op; 1601 return op;
1644 } 1602 }
1645 1603
1646 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL); 1604 op->remove ();
1647 CLEAR_FLAG (op, FLAG_REMOVED); 1605
1606 op->flag [FLAG_OBJ_ORIGINAL] = 0;
1607
1648 if (op->nrof) 1608 if (op->nrof)
1649 {
1650 for (tmp = inv; tmp != NULL; tmp = tmp->below) 1609 for (object *tmp = inv; tmp; tmp = tmp->below)
1651 if (object::can_merge (tmp, op)) 1610 if (object::can_merge (tmp, op))
1652 { 1611 {
1653 /* return the original object and remove inserted object 1612 /* return the original object and remove inserted object
1654 (client needs the original object) */ 1613 (client needs the original object) */
1655 tmp->nrof += op->nrof; 1614 tmp->nrof += op->nrof;
1656 /* Weight handling gets pretty funky. Since we are adding to 1615
1657 * tmp->nrof, we need to increase the weight. 1616 if (object *pl = tmp->visible_to ())
1658 */ 1617 esrv_update_item (UPD_NROF, pl, tmp);
1618
1659 add_weight (this, op->weight * op->nrof); 1619 adjust_weight (this, op->total_weight ());
1660 SET_FLAG (op, FLAG_REMOVED); 1620
1661 op->destroy (); /* free the inserted object */ 1621 op->destroy (1);
1662 op = tmp; 1622 op = tmp;
1663 op->remove (); /* and fix old object's links */ 1623 goto inserted;
1664 CLEAR_FLAG (op, FLAG_REMOVED);
1665 break;
1666 } 1624 }
1667 1625
1668 /* I assume combined objects have no inventory 1626 op->owner = 0; // it's his/hers now. period.
1669 * We add the weight - this object could have just been removed
1670 * (if it was possible to merge). calling remove_ob will subtract
1671 * the weight, so we need to add it in again, since we actually do
1672 * the linking below
1673 */
1674 add_weight (this, op->weight * op->nrof);
1675 }
1676 else
1677 add_weight (this, (op->weight + op->carrying));
1678
1679 otmp = this->in_player ();
1680 if (otmp && otmp->contr)
1681 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1682 otmp->update_stats ();
1683
1684 op->map = 0; 1627 op->map = 0;
1685 op->env = this; 1628 op->x = 0;
1629 op->y = 0;
1630
1686 op->above = 0; 1631 op->above = 0;
1687 op->below = 0; 1632 op->below = inv;
1688 op->x = 0, op->y = 0; 1633 op->env = this;
1689 1634
1635 if (inv)
1636 inv->above = op;
1637
1638 inv = op;
1639
1640 op->flag [FLAG_REMOVED] = 0;
1641
1642 if (object *pl = op->visible_to ())
1643 esrv_send_item (pl, op);
1644
1645 adjust_weight (this, op->total_weight ());
1646
1647inserted:
1690 /* reset the light list and los of the players on the map */ 1648 /* reset the light list and los of the players on the map */
1691 if ((op->glow_radius != 0) && map) 1649 if (op->glow_radius && map && map->darkness)
1692 {
1693#ifdef DEBUG_LIGHTS
1694 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1695#endif /* DEBUG_LIGHTS */
1696 if (map->darkness)
1697 update_all_los (map, x, y); 1650 update_all_los (map, x, y);
1698 }
1699 1651
1700 /* Client has no idea of ordering so lets not bother ordering it here. 1652 // if this is a player's inventory, update stats
1701 * It sure simplifies this function... 1653 if (type == PLAYER && !flag [FLAG_NO_FIX_PLAYER])
1702 */ 1654 update_stats ();
1703 if (!inv)
1704 inv = op;
1705 else
1706 {
1707 op->below = inv;
1708 op->below->above = op;
1709 inv = op;
1710 }
1711 1655
1712 INVOKE_OBJECT (INSERT, this); 1656 INVOKE_OBJECT (INSERT, this);
1713 1657
1714 return op; 1658 return op;
1715} 1659}
1843 LOG (llevError, "Present_arch called outside map.\n"); 1787 LOG (llevError, "Present_arch called outside map.\n");
1844 return NULL; 1788 return NULL;
1845 } 1789 }
1846 1790
1847 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above) 1791 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1848 if (tmp->arch == at) 1792 if (tmp->arch->archname == at->archname)
1849 return tmp; 1793 return tmp;
1850 1794
1851 return NULL; 1795 return NULL;
1852} 1796}
1853 1797
1917 * The first matching object is returned, or NULL if none. 1861 * The first matching object is returned, or NULL if none.
1918 */ 1862 */
1919object * 1863object *
1920present_arch_in_ob (const archetype *at, const object *op) 1864present_arch_in_ob (const archetype *at, const object *op)
1921{ 1865{
1922 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below) 1866 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1923 if (tmp->arch == at) 1867 if (tmp->arch->archname == at->archname)
1924 return tmp; 1868 return tmp;
1925 1869
1926 return NULL; 1870 return NULL;
1927} 1871}
1928 1872
1930 * activate recursively a flag on an object inventory 1874 * activate recursively a flag on an object inventory
1931 */ 1875 */
1932void 1876void
1933flag_inv (object *op, int flag) 1877flag_inv (object *op, int flag)
1934{ 1878{
1935 if (op->inv)
1936 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below) 1879 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1937 { 1880 {
1938 SET_FLAG (tmp, flag); 1881 SET_FLAG (tmp, flag);
1939 flag_inv (tmp, flag); 1882 flag_inv (tmp, flag);
1940 } 1883 }
1941} 1884}
1942 1885
1943/* 1886/*
1944 * deactivate recursively a flag on an object inventory 1887 * deactivate recursively a flag on an object inventory
1945 */ 1888 */
1946void 1889void
1947unflag_inv (object *op, int flag) 1890unflag_inv (object *op, int flag)
1948{ 1891{
1949 if (op->inv)
1950 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below) 1892 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1951 { 1893 {
1952 CLEAR_FLAG (tmp, flag); 1894 CLEAR_FLAG (tmp, flag);
1953 unflag_inv (tmp, flag); 1895 unflag_inv (tmp, flag);
1954 } 1896 }
1955}
1956
1957/*
1958 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in
1959 * all it's inventory (recursively).
1960 * If checksums are used, a player will get set_cheat called for
1961 * him/her-self and all object carried by a call to this function.
1962 */
1963void
1964set_cheat (object *op)
1965{
1966 SET_FLAG (op, FLAG_WAS_WIZ);
1967 flag_inv (op, FLAG_WAS_WIZ);
1968} 1897}
1969 1898
1970/* 1899/*
1971 * find_free_spot(object, map, x, y, start, stop) will search for 1900 * find_free_spot(object, map, x, y, start, stop) will search for
1972 * a spot at the given map and coordinates which will be able to contain 1901 * a spot at the given map and coordinates which will be able to contain
1974 * to search (see the freearr_x/y[] definition). 1903 * to search (see the freearr_x/y[] definition).
1975 * It returns a random choice among the alternatives found. 1904 * It returns a random choice among the alternatives found.
1976 * start and stop are where to start relative to the free_arr array (1,9 1905 * start and stop are where to start relative to the free_arr array (1,9
1977 * does all 4 immediate directions). This returns the index into the 1906 * does all 4 immediate directions). This returns the index into the
1978 * array of the free spot, -1 if no spot available (dir 0 = x,y) 1907 * array of the free spot, -1 if no spot available (dir 0 = x,y)
1979 * Note - this only checks to see if there is space for the head of the
1980 * object - if it is a multispace object, this should be called for all
1981 * pieces.
1982 * Note2: This function does correctly handle tiled maps, but does not 1908 * Note: This function does correctly handle tiled maps, but does not
1983 * inform the caller. However, insert_ob_in_map will update as 1909 * inform the caller. However, insert_ob_in_map will update as
1984 * necessary, so the caller shouldn't need to do any special work. 1910 * necessary, so the caller shouldn't need to do any special work.
1985 * Note - updated to take an object instead of archetype - this is necessary 1911 * Note - updated to take an object instead of archetype - this is necessary
1986 * because arch_blocked (now ob_blocked) needs to know the movement type 1912 * because arch_blocked (now ob_blocked) needs to know the movement type
1987 * to know if the space in question will block the object. We can't use 1913 * to know if the space in question will block the object. We can't use
1989 * customized, changed states, etc. 1915 * customized, changed states, etc.
1990 */ 1916 */
1991int 1917int
1992find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop) 1918find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)
1993{ 1919{
1920 int altern[SIZEOFFREE];
1994 int index = 0, flag; 1921 int index = 0, flag;
1995 int altern[SIZEOFFREE];
1996 1922
1997 for (int i = start; i < stop; i++) 1923 for (int i = start; i < stop; i++)
1998 { 1924 {
1999 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]); 1925 mapxy pos (m, x, y); pos.move (i);
2000 if (!flag) 1926
1927 if (!pos.normalise ())
1928 continue;
1929
1930 mapspace &ms = *pos;
1931
1932 if (ms.flags () & P_IS_ALIVE)
1933 continue;
1934
1935 /* However, often
1936 * ob doesn't have any move type (when used to place exits)
1937 * so the AND operation in OB_TYPE_MOVE_BLOCK doesn't work.
1938 */
1939 if (ob && ob->move_type == 0 && ms.move_block != MOVE_ALL)
1940 {
2001 altern [index++] = i; 1941 altern [index++] = i;
1942 continue;
1943 }
2002 1944
2003 /* Basically, if we find a wall on a space, we cut down the search size. 1945 /* Basically, if we find a wall on a space, we cut down the search size.
2004 * In this way, we won't return spaces that are on another side of a wall. 1946 * In this way, we won't return spaces that are on another side of a wall.
2005 * This mostly work, but it cuts down the search size in all directions - 1947 * This mostly work, but it cuts down the search size in all directions -
2006 * if the space being examined only has a wall to the north and empty 1948 * if the space being examined only has a wall to the north and empty
2007 * spaces in all the other directions, this will reduce the search space 1949 * spaces in all the other directions, this will reduce the search space
2008 * to only the spaces immediately surrounding the target area, and 1950 * to only the spaces immediately surrounding the target area, and
2009 * won't look 2 spaces south of the target space. 1951 * won't look 2 spaces south of the target space.
2010 */ 1952 */
2011 else if ((flag & P_NO_PASS) && maxfree[i] < stop) 1953 if (ms.move_block == MOVE_ALL && maxfree[i] < stop)
1954 {
2012 stop = maxfree[i]; 1955 stop = maxfree[i];
1956 continue;
1957 }
1958
1959 /* Note it is intentional that we check ob - the movement type of the
1960 * head of the object should correspond for the entire object.
1961 */
1962 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))
1963 continue;
1964
1965 if (ob->blocked (m, pos.x, pos.y))
1966 continue;
1967
1968 altern [index++] = i;
2013 } 1969 }
2014 1970
2015 if (!index) 1971 if (!index)
2016 return -1; 1972 return -1;
2017 1973
2026 */ 1982 */
2027int 1983int
2028find_first_free_spot (const object *ob, maptile *m, int x, int y) 1984find_first_free_spot (const object *ob, maptile *m, int x, int y)
2029{ 1985{
2030 for (int i = 0; i < SIZEOFFREE; i++) 1986 for (int i = 0; i < SIZEOFFREE; i++)
2031 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i])) 1987 if (!ob->blocked (m, x + freearr_x[i], y + freearr_y[i]))
2032 return i; 1988 return i;
2033 1989
2034 return -1; 1990 return -1;
2035} 1991}
2036 1992
2090 object *tmp; 2046 object *tmp;
2091 maptile *mp; 2047 maptile *mp;
2092 2048
2093 MoveType blocked, move_type; 2049 MoveType blocked, move_type;
2094 2050
2095 if (exclude && exclude->head) 2051 if (exclude && exclude->head_ () != exclude)
2096 { 2052 {
2097 exclude = exclude->head; 2053 exclude = exclude->head;
2098 move_type = exclude->move_type; 2054 move_type = exclude->move_type;
2099 } 2055 }
2100 else 2056 else
2123 max = maxfree[i]; 2079 max = maxfree[i];
2124 else if (mflags & P_IS_ALIVE) 2080 else if (mflags & P_IS_ALIVE)
2125 { 2081 {
2126 for (tmp = ms.bot; tmp; tmp = tmp->above) 2082 for (tmp = ms.bot; tmp; tmp = tmp->above)
2127 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER) 2083 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)
2128 && (tmp != exclude || (tmp->head && tmp->head != exclude))) 2084 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))
2129 break; 2085 break;
2130 2086
2131 if (tmp) 2087 if (tmp)
2132 return freedir[i]; 2088 return freedir[i];
2133 } 2089 }
2313 * Cf 0.91.3 - don't let WIZ's pick up anything - will likely cause 2269 * Cf 0.91.3 - don't let WIZ's pick up anything - will likely cause
2314 * core dumps if they do. 2270 * core dumps if they do.
2315 * 2271 *
2316 * Add a check so we can't pick up invisible objects (0.93.8) 2272 * Add a check so we can't pick up invisible objects (0.93.8)
2317 */ 2273 */
2318
2319int 2274int
2320can_pick (const object *who, const object *item) 2275can_pick (const object *who, const object *item)
2321{ 2276{
2322 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2277 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2323 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2278 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2326 2281
2327/* 2282/*
2328 * create clone from object to another 2283 * create clone from object to another
2329 */ 2284 */
2330object * 2285object *
2331object_create_clone (object *asrc) 2286object::deep_clone ()
2332{ 2287{
2333 object *dst = 0, *tmp, *src, *part, *prev, *item; 2288 assert (("deep_clone called on non-head object", is_head ()));
2334 2289
2335 if (!asrc) 2290 object *dst = clone ();
2336 return 0;
2337 2291
2338 src = asrc; 2292 object *prev = dst;
2339 if (src->head)
2340 src = src->head;
2341
2342 prev = 0;
2343 for (part = src; part; part = part->more) 2293 for (object *part = this->more; part; part = part->more)
2344 { 2294 {
2345 tmp = part->clone (); 2295 object *tmp = part->clone ();
2346 tmp->x -= src->x;
2347 tmp->y -= src->y;
2348
2349 if (!part->head)
2350 {
2351 dst = tmp;
2352 tmp->head = 0;
2353 }
2354 else
2355 tmp->head = dst; 2296 tmp->head = dst;
2356
2357 tmp->more = 0;
2358
2359 if (prev)
2360 prev->more = tmp; 2297 prev->more = tmp;
2361
2362 prev = tmp; 2298 prev = tmp;
2363 } 2299 }
2364 2300
2365 for (item = src->inv; item; item = item->below) 2301 for (object *item = inv; item; item = item->below)
2366 insert_ob_in_ob (object_create_clone (item), dst); 2302 insert_ob_in_ob (item->deep_clone (), dst);
2367 2303
2368 return dst; 2304 return dst;
2369} 2305}
2370 2306
2371/* This returns the first object in who's inventory that 2307/* This returns the first object in who's inventory that
2380 return tmp; 2316 return tmp;
2381 2317
2382 return 0; 2318 return 0;
2383} 2319}
2384 2320
2385/* If ob has a field named key, return the link from the list, 2321const shstr &
2386 * otherwise return NULL. 2322object::kv_get (const shstr &key) const
2387 *
2388 * key must be a passed in shared string - otherwise, this won't
2389 * do the desired thing.
2390 */
2391key_value *
2392get_ob_key_link (const object *ob, const char *key)
2393{ 2323{
2394 for (key_value *link = ob->key_values; link; link = link->next) 2324 for (key_value *kv = key_values; kv; kv = kv->next)
2395 if (link->key == key) 2325 if (kv->key == key)
2396 return link;
2397
2398 return 0;
2399}
2400
2401/*
2402 * Returns the value of op has an extra_field for key, or NULL.
2403 *
2404 * The argument doesn't need to be a shared string.
2405 *
2406 * The returned string is shared.
2407 */
2408const char *
2409get_ob_key_value (const object *op, const char *const key)
2410{
2411 key_value *link;
2412 shstr_cmp canonical_key (key);
2413
2414 if (!canonical_key)
2415 {
2416 /* 1. There being a field named key on any object
2417 * implies there'd be a shared string to find.
2418 * 2. Since there isn't, no object has this field.
2419 * 3. Therefore, *this* object doesn't have this field.
2420 */
2421 return 0;
2422 }
2423
2424 /* This is copied from get_ob_key_link() above -
2425 * only 4 lines, and saves the function call overhead.
2426 */
2427 for (link = op->key_values; link; link = link->next)
2428 if (link->key == canonical_key)
2429 return link->value; 2326 return kv->value;
2430 2327
2431 return 0; 2328 return shstr_null;
2432} 2329}
2433 2330
2434/* 2331void
2435 * Updates the canonical_key in op to value. 2332object::kv_set (const shstr &key, const shstr &value)
2436 *
2437 * canonical_key is a shared string (value doesn't have to be).
2438 *
2439 * Unless add_key is TRUE, it won't add fields, only change the value of existing
2440 * keys.
2441 *
2442 * Returns TRUE on success.
2443 */
2444int
2445set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2446{ 2333{
2447 key_value *field = NULL, *last = NULL; 2334 for (key_value *kv = key_values; kv; kv = kv->next)
2448 2335 if (kv->key == key)
2449 for (field = op->key_values; field != NULL; field = field->next)
2450 {
2451 if (field->key != canonical_key)
2452 { 2336 {
2453 last = field; 2337 kv->value = value;
2454 continue; 2338 return;
2455 } 2339 }
2456 2340
2457 if (value) 2341 key_value *kv = new key_value;
2458 field->value = value; 2342
2459 else 2343 kv->next = key_values;
2344 kv->key = key;
2345 kv->value = value;
2346
2347 key_values = kv;
2348}
2349
2350void
2351object::kv_del (const shstr &key)
2352{
2353 for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
2354 if ((*kvp)->key == key)
2460 { 2355 {
2461 /* Basically, if the archetype has this key set, 2356 key_value *kv = *kvp;
2462 * we need to store the null value so when we save 2357 *kvp = (*kvp)->next;
2463 * it, we save the empty value so that when we load, 2358 delete kv;
2464 * we get this value back again. 2359 return;
2465 */
2466 if (get_ob_key_link (&op->arch->clone, canonical_key))
2467 field->value = 0;
2468 else
2469 {
2470 if (last)
2471 last->next = field->next;
2472 else
2473 op->key_values = field->next;
2474
2475 delete field;
2476 }
2477 } 2360 }
2478 return TRUE;
2479 }
2480 /* IF we get here, key doesn't exist */
2481
2482 /* No field, we'll have to add it. */
2483
2484 if (!add_key)
2485 return FALSE;
2486
2487 /* There isn't any good reason to store a null
2488 * value in the key/value list. If the archetype has
2489 * this key, then we should also have it, so shouldn't
2490 * be here. If user wants to store empty strings,
2491 * should pass in ""
2492 */
2493 if (value == NULL)
2494 return TRUE;
2495
2496 field = new key_value;
2497
2498 field->key = canonical_key;
2499 field->value = value;
2500 /* Usual prepend-addition. */
2501 field->next = op->key_values;
2502 op->key_values = field;
2503
2504 return TRUE;
2505}
2506
2507/*
2508 * Updates the key in op to value.
2509 *
2510 * If add_key is FALSE, this will only update existing keys,
2511 * and not add new ones.
2512 * In general, should be little reason FALSE is ever passed in for add_key
2513 *
2514 * Returns TRUE on success.
2515 */
2516int
2517set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2518{
2519 shstr key_ (key);
2520
2521 return set_ob_key_value_s (op, key_, value, add_key);
2522} 2361}
2523 2362
2524object::depth_iterator::depth_iterator (object *container) 2363object::depth_iterator::depth_iterator (object *container)
2525: iterator_base (container) 2364: iterator_base (container)
2526{ 2365{
2539 item = item->inv; 2378 item = item->inv;
2540 } 2379 }
2541 else 2380 else
2542 item = item->env; 2381 item = item->env;
2543} 2382}
2544
2545 2383
2546const char * 2384const char *
2547object::flag_desc (char *desc, int len) const 2385object::flag_desc (char *desc, int len) const
2548{ 2386{
2549 char *p = desc; 2387 char *p = desc;
2577{ 2415{
2578 char flagdesc[512]; 2416 char flagdesc[512];
2579 char info2[256 * 4]; 2417 char info2[256 * 4];
2580 char *p = info; 2418 char *p = info;
2581 2419
2582 p += snprintf (p, 512, "{cnt:%d,uuid:<1.%" PRIx64 ">,name:\"%s\"%s%s,flags:[%s],type:%d}", 2420 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s,flags:[%s],type:%d}",
2583 count, uuid.seq, 2421 count,
2422 uuid.c_str (),
2584 &name, 2423 &name,
2585 title ? "\",title:\"" : "", 2424 title ? "\",title:\"" : "",
2586 title ? (const char *)title : "", 2425 title ? (const char *)title : "",
2587 flag_desc (flagdesc, 512), type); 2426 flag_desc (flagdesc, 512), type);
2588 2427
2589 if (env) 2428 if (!flag[FLAG_REMOVED] && env)
2590 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2429 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2591 2430
2592 if (map) 2431 if (map)
2593 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y); 2432 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2594 2433
2612} 2451}
2613 2452
2614const materialtype_t * 2453const materialtype_t *
2615object::dominant_material () const 2454object::dominant_material () const
2616{ 2455{
2617 if (materialtype_t *mat = name_to_material (materialname)) 2456 if (materialtype_t *mt = name_to_material (materialname))
2618 return mat; 2457 return mt;
2619 2458
2620 // omfg this is slow, this has to be temporary :)
2621 shstr unknown ("unknown");
2622
2623 return name_to_material (unknown); 2459 return name_to_material (shstr_unknown);
2624} 2460}
2625 2461
2626void 2462void
2627object::open_container (object *new_container) 2463object::open_container (object *new_container)
2628{ 2464{
2629 if (container == new_container) 2465 if (container == new_container)
2630 return; 2466 return;
2631 2467
2632 if (object *old_container = container) 2468 object *old_container = container;
2469
2470 if (old_container)
2633 { 2471 {
2634 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this))) 2472 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))
2635 return; 2473 return;
2636 2474
2637#if 0 2475#if 0
2639 if (object *closer = old_container->inv) 2477 if (object *closer = old_container->inv)
2640 if (closer->type == CLOSE_CON) 2478 if (closer->type == CLOSE_CON)
2641 closer->destroy (); 2479 closer->destroy ();
2642#endif 2480#endif
2643 2481
2482 // make sure the container is available
2483 esrv_send_item (this, old_container);
2484
2644 old_container->flag [FLAG_APPLIED] = 0; 2485 old_container->flag [FLAG_APPLIED] = false;
2645 container = 0; 2486 container = 0;
2646 2487
2488 // client needs item update to make it work, client bug requires this to be separate
2647 esrv_update_item (UPD_FLAGS, this, old_container); 2489 esrv_update_item (UPD_FLAGS, this, old_container);
2490
2648 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container)); 2491 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container));
2492 play_sound (sound_find ("chest_close"));
2649 } 2493 }
2650 2494
2651 if (new_container) 2495 if (new_container)
2652 { 2496 {
2653 if (INVOKE_OBJECT (OPEN, new_container, ARG_OBJECT (this))) 2497 if (INVOKE_OBJECT (OPEN, new_container, ARG_OBJECT (this)))
2664 } 2508 }
2665#endif 2509#endif
2666 2510
2667 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container)); 2511 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container));
2668 2512
2513 // make sure the container is available, client bug requires this to be separate
2514 esrv_send_item (this, new_container);
2515
2669 new_container->flag [FLAG_APPLIED] = 1; 2516 new_container->flag [FLAG_APPLIED] = true;
2670 container = new_container; 2517 container = new_container;
2671 2518
2519 // client needs flag change
2672 esrv_update_item (UPD_FLAGS, this, new_container); 2520 esrv_update_item (UPD_FLAGS, this, new_container);
2673 esrv_send_inventory (this, new_container); 2521 esrv_send_inventory (this, new_container);
2522 play_sound (sound_find ("chest_open"));
2523 }
2524// else if (!old_container->env && contr && contr->ns)
2525// contr->ns->floorbox_reset ();
2526}
2527
2528object *
2529object::force_find (const shstr name)
2530{
2531 /* cycle through his inventory to look for the MARK we want to
2532 * place
2533 */
2534 for (object *tmp = inv; tmp; tmp = tmp->below)
2535 if (tmp->type == FORCE && tmp->slaying == name)
2536 return splay (tmp);
2537
2538 return 0;
2539}
2540
2541void
2542object::force_add (const shstr name, int duration)
2543{
2544 if (object *force = force_find (name))
2545 force->destroy ();
2546
2547 object *force = get_archetype (FORCE_NAME);
2548
2549 force->slaying = name;
2550 force->stats.food = 1;
2551 force->speed_left = -1.f;
2552
2553 force->set_speed (duration ? 1.f / duration : 0.f);
2554 force->flag [FLAG_IS_USED_UP] = true;
2555 force->flag [FLAG_APPLIED] = true;
2556
2557 insert (force);
2558}
2559
2560void
2561object::play_sound (faceidx sound)
2562{
2563 if (!sound)
2564 return;
2565
2566 if (flag [FLAG_REMOVED])
2567 return;
2568
2569 if (env)
2674 } 2570 {
2571 if (object *pl = in_player ())
2572 pl->contr->play_sound (sound);
2573 }
2574 else
2575 map->play_sound (sound, x, y);
2675} 2576}
2676 2577
2677

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines