ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.62 by root, Mon Dec 11 23:35:37 2006 UTC vs.
Revision 1.146 by root, Fri May 11 21:07:13 2007 UTC

1/* 1/*
2 CrossFire, A Multiplayer game for X-windows 2 * CrossFire, A Multiplayer game
3 3 *
4 * Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team
4 Copyright (C) 2001 Mark Wedel & Crossfire Development Team 5 * Copyright (C) 2001 Mark Wedel & Crossfire Development Team
5 Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (C) 1992 Frank Tore Johansen
6 7 *
7 This program is free software; you can redistribute it and/or modify 8 * This program is free software; you can redistribute it and/or modify
8 it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
9 the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation; either version 2 of the License, or
10 (at your option) any later version. 11 * (at your option) any later version.
11 12 *
12 This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
13 but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 GNU General Public License for more details. 16 * GNU General Public License for more details.
16 17 *
17 You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
18 along with this program; if not, write to the Free Software 19 * along with this program; if not, write to the Free Software
19 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
20 21 *
21 The authors can be reached via e-mail at <crossfire@schmorp.de> 22 * The authors can be reached via e-mail at <crossfire@schmorp.de>
22*/ 23 */
23 24
24/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects. 25/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
25 sub/add_weight will transcend the environment updating the carrying 26 sub/add_weight will transcend the environment updating the carrying
26 variable. */ 27 variable. */
27#include <global.h> 28#include <global.h>
28#include <stdio.h> 29#include <stdio.h>
29#include <sys/types.h> 30#include <sys/types.h>
30#include <sys/uio.h> 31#include <sys/uio.h>
31#include <object.h> 32#include <object.h>
32#include <funcpoint.h> 33#include <funcpoint.h>
34#include <sproto.h>
33#include <loader.h> 35#include <loader.h>
36
37#include <bitset>
34 38
35int nrofallocobjects = 0; 39int nrofallocobjects = 0;
36static UUID uuid; 40static UUID uuid;
37const uint64 UUID_SKIP = 1<<19; 41const uint64 UUID_SKIP = 1<<19;
38 42
39object *active_objects; /* List of active objects that need to be processed */ 43objectvec objects;
44activevec actives;
40 45
41short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 46short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
42 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1 47 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1
43}; 48};
44short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, 49short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
139 * objects with lists are rare, and lists stay short. If not, use a 144 * objects with lists are rare, and lists stay short. If not, use a
140 * different structure or at least keep the lists sorted... 145 * different structure or at least keep the lists sorted...
141 */ 146 */
142 147
143 /* For each field in wants, */ 148 /* For each field in wants, */
144 for (wants_field = wants->key_values; wants_field != NULL; wants_field = wants_field->next) 149 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)
145 { 150 {
146 key_value *has_field; 151 key_value *has_field;
147 152
148 /* Look for a field in has with the same key. */ 153 /* Look for a field in has with the same key. */
149 has_field = get_ob_key_link (has, wants_field->key); 154 has_field = get_ob_key_link (has, wants_field->key);
183 * 188 *
184 * Note that this function appears a lot longer than the macro it 189 * Note that this function appears a lot longer than the macro it
185 * replaces - this is mostly for clarity - a decent compiler should hopefully 190 * replaces - this is mostly for clarity - a decent compiler should hopefully
186 * reduce this to the same efficiency. 191 * reduce this to the same efficiency.
187 * 192 *
188 * Check nrof variable *before* calling CAN_MERGE() 193 * Check nrof variable *before* calling can_merge()
189 * 194 *
190 * Improvements made with merge: Better checking on potion, and also 195 * Improvements made with merge: Better checking on potion, and also
191 * check weight 196 * check weight
192 */ 197 */
193
194bool object::can_merge (object *ob1, object *ob2) 198bool object::can_merge_slow (object *ob1, object *ob2)
195{ 199{
196 /* A couple quicksanity checks */ 200 /* A couple quicksanity checks */
197 if ((ob1 == ob2) || (ob1->type != ob2->type)) 201 if (ob1 == ob2
202 || ob1->type != ob2->type
203 || ob1->speed != ob2->speed
204 || ob1->value != ob2->value
205 || ob1->name != ob2->name)
198 return 0; 206 return 0;
199 207
200 if (ob1->speed != ob2->speed) 208 //TODO: this ain't working well, use nicer and correct overflow check
201 return 0;
202
203 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that 209 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that
204 * value could not be stored in a sint32 (which unfortunately sometimes is 210 * value could not be stored in a sint32 (which unfortunately sometimes is
205 * used to store nrof). 211 * used to store nrof).
206 */ 212 */
207 if (ob1->nrof + ob2->nrof >= 1UL << 31) 213 if (ob1->nrof + ob2->nrof >= 1UL << 31)
217 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 223 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
218 224
219 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 225 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
220 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 226 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
221 227
222 228 if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any ()
223 /* the 0x400000 on flags2 is FLAG_INV_LOCK. I don't think something 229 || ob1->arch != ob2->arch
224 * being locked in inventory should prevent merging.
225 * 0x4 in flags3 is CLIENT_SENT
226 */
227 if ((ob1->arch != ob2->arch) ||
228 (ob1->flags[0] != ob2->flags[0]) ||
229 (ob1->flags[1] != ob2->flags[1]) ||
230 ((ob1->flags[2] & ~0x400000) != (ob2->flags[2] & ~0x400000)) ||
231 ((ob1->flags[3] & ~0x4) != (ob2->flags[3] & ~0x4)) ||
232 (ob1->name != ob2->name) || 230 || ob1->name != ob2->name
233 (ob1->title != ob2->title) || 231 || ob1->title != ob2->title
234 (ob1->msg != ob2->msg) || 232 || ob1->msg != ob2->msg
235 (ob1->weight != ob2->weight) || 233 || ob1->weight != ob2->weight
236 (memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist)) != 0) || 234 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
237 (memcmp (&ob1->stats, &ob2->stats, sizeof (ob1->stats)) != 0) || 235 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
238 (ob1->attacktype != ob2->attacktype) || 236 || ob1->attacktype != ob2->attacktype
239 (ob1->magic != ob2->magic) || 237 || ob1->magic != ob2->magic
240 (ob1->slaying != ob2->slaying) || 238 || ob1->slaying != ob2->slaying
241 (ob1->skill != ob2->skill) || 239 || ob1->skill != ob2->skill
242 (ob1->value != ob2->value) || 240 || ob1->value != ob2->value
243 (ob1->animation_id != ob2->animation_id) || 241 || ob1->animation_id != ob2->animation_id
244 (ob1->client_type != ob2->client_type) || 242 || ob1->client_type != ob2->client_type
245 (ob1->materialname != ob2->materialname) || 243 || ob1->materialname != ob2->materialname
246 (ob1->lore != ob2->lore) || 244 || ob1->lore != ob2->lore
247 (ob1->subtype != ob2->subtype) || 245 || ob1->subtype != ob2->subtype
248 (ob1->move_type != ob2->move_type) || 246 || ob1->move_type != ob2->move_type
249 (ob1->move_block != ob2->move_block) || 247 || ob1->move_block != ob2->move_block
250 (ob1->move_allow != ob2->move_allow) || 248 || ob1->move_allow != ob2->move_allow
251 (ob1->move_on != ob2->move_on) || 249 || ob1->move_on != ob2->move_on
252 (ob1->move_off != ob2->move_off) || (ob1->move_slow != ob2->move_slow) || (ob1->move_slow_penalty != ob2->move_slow_penalty)) 250 || ob1->move_off != ob2->move_off
251 || ob1->move_slow != ob2->move_slow
252 || ob1->move_slow_penalty != ob2->move_slow_penalty)
253 return 0; 253 return 0;
254 254
255 /* This is really a spellbook check - really, we should 255 /* This is really a spellbook check - really, we should
256 * check all objects in the inventory. 256 * check all objects in the inventory.
257 */ 257 */
260 /* if one object has inventory but the other doesn't, not equiv */ 260 /* if one object has inventory but the other doesn't, not equiv */
261 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv)) 261 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv))
262 return 0; 262 return 0;
263 263
264 /* Now check to see if the two inventory objects could merge */ 264 /* Now check to see if the two inventory objects could merge */
265 if (!CAN_MERGE (ob1->inv, ob2->inv)) 265 if (!object::can_merge (ob1->inv, ob2->inv))
266 return 0; 266 return 0;
267 267
268 /* inventory ok - still need to check rest of this object to see 268 /* inventory ok - still need to check rest of this object to see
269 * if it is valid. 269 * if it is valid.
270 */ 270 */
279 279
280 /* Note sure why the following is the case - either the object has to 280 /* Note sure why the following is the case - either the object has to
281 * be animated or have a very low speed. Is this an attempted monster 281 * be animated or have a very low speed. Is this an attempted monster
282 * check? 282 * check?
283 */ 283 */
284 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && FABS ((ob1)->speed) > MIN_ACTIVE_SPEED) 284 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && ob1->has_active_speed ())
285 return 0; 285 return 0;
286 286
287 switch (ob1->type) 287 switch (ob1->type)
288 { 288 {
289 case SCROLL: 289 case SCROLL:
325sum_weight (object *op) 325sum_weight (object *op)
326{ 326{
327 long sum; 327 long sum;
328 object *inv; 328 object *inv;
329 329
330 for (sum = 0, inv = op->inv; inv != NULL; inv = inv->below) 330 for (sum = 0, inv = op->inv; inv; inv = inv->below)
331 { 331 {
332 if (inv->inv) 332 if (inv->inv)
333 sum_weight (inv); 333 sum_weight (inv);
334
334 sum += inv->carrying + inv->weight * (inv->nrof ? inv->nrof : 1); 335 sum += inv->carrying + inv->weight * (inv->nrof ? inv->nrof : 1);
335 } 336 }
336 337
337 if (op->type == CONTAINER && op->stats.Str) 338 if (op->type == CONTAINER && op->stats.Str)
338 sum = (sum * (100 - op->stats.Str)) / 100; 339 sum = (sum * (100 - op->stats.Str)) / 100;
354 op = op->env; 355 op = op->env;
355 return op; 356 return op;
356} 357}
357 358
358/* 359/*
359 * Eneq(@csd.uu.se): Since we can have items buried in a character we need
360 * a better check. We basically keeping traversing up until we can't
361 * or find a player.
362 */
363
364object *
365is_player_inv (object *op)
366{
367 for (; op != NULL && op->type != PLAYER; op = op->env)
368 if (op->env == op)
369 op->env = NULL;
370 return op;
371}
372
373/*
374 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump. 360 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
375 * Some error messages. 361 * Some error messages.
376 * The result of the dump is stored in the static global errmsg array. 362 * The result of the dump is stored in the static global errmsg array.
377 */ 363 */
378
379char * 364char *
380dump_object (object *op) 365dump_object (object *op)
381{ 366{
382 if (!op) 367 if (!op)
383 return strdup ("[NULLOBJ]"); 368 return strdup ("[NULLOBJ]");
384 369
385 object_freezer freezer; 370 object_freezer freezer;
386 save_object (freezer, op, 3); 371 op->write (freezer);
387 return freezer.as_string (); 372 return freezer.as_string ();
388} 373}
389 374
390/* 375/*
391 * get_nearest_part(multi-object, object 2) returns the part of the 376 * get_nearest_part(multi-object, object 2) returns the part of the
408} 393}
409 394
410/* 395/*
411 * Returns the object which has the count-variable equal to the argument. 396 * Returns the object which has the count-variable equal to the argument.
412 */ 397 */
413
414object * 398object *
415find_object (tag_t i) 399find_object (tag_t i)
416{ 400{
417 for (object *op = object::first; op; op = op->next) 401 for_all_objects (op)
418 if (op->count == i) 402 if (op->count == i)
419 return op; 403 return op;
420 404
421 return 0; 405 return 0;
422} 406}
423 407
424/* 408/*
425 * Returns the first object which has a name equal to the argument. 409 * Returns the first object which has a name equal to the argument.
426 * Used only by the patch command, but not all that useful. 410 * Used only by the patch command, but not all that useful.
427 * Enables features like "patch <name-of-other-player> food 999" 411 * Enables features like "patch <name-of-other-player> food 999"
428 */ 412 */
429
430object * 413object *
431find_object_name (const char *str) 414find_object_name (const char *str)
432{ 415{
433 shstr_cmp str_ (str); 416 shstr_cmp str_ (str);
434 object *op; 417 object *op;
435 418
436 for (op = object::first; op != NULL; op = op->next) 419 for_all_objects (op)
437 if (op->name == str_) 420 if (op->name == str_)
438 break; 421 break;
439 422
440 return op; 423 return op;
441} 424}
467 owner = owner->owner; 450 owner = owner->owner;
468 451
469 this->owner = owner; 452 this->owner = owner;
470} 453}
471 454
455void
456object::set_weapon (object *ob)
457{
458 if (current_weapon == ob)
459 return;
460
461 new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name);
462
463 if (chosen_skill)
464 chosen_skill->flag [FLAG_APPLIED] = false;
465
466 current_weapon = ob;
467 chosen_skill = ob->type == SKILL ? ob : find_skill_by_name (this, ob->skill);
468
469 if (chosen_skill)
470 chosen_skill->flag [FLAG_APPLIED] = true;
471
472 update_stats ();
473}
474
472/* Zero the key_values on op, decrementing the shared-string 475/* Zero the key_values on op, decrementing the shared-string
473 * refcounts and freeing the links. 476 * refcounts and freeing the links.
474 */ 477 */
475static void 478static void
476free_key_values (object *op) 479free_key_values (object *op)
477{ 480{
478 for (key_value *i = op->key_values; i != 0;) 481 for (key_value *i = op->key_values; i; )
479 { 482 {
480 key_value *next = i->next; 483 key_value *next = i->next;
481 delete i; 484 delete i;
482 485
483 i = next; 486 i = next;
484 } 487 }
485 488
486 op->key_values = 0; 489 op->key_values = 0;
487} 490}
488 491
489void object::clear () 492object &
493object::operator =(const object &src)
490{ 494{
491 attachable_base::clear (); 495 bool is_freed = flag [FLAG_FREED];
496 bool is_removed = flag [FLAG_REMOVED];
492 497
493 free_key_values (this); 498 *(object_copy *)this = src;
494 499
495 owner = 0; 500 flag [FLAG_FREED] = is_freed;
496 name = 0; 501 flag [FLAG_REMOVED] = is_removed;
497 name_pl = 0;
498 title = 0;
499 race = 0;
500 slaying = 0;
501 skill = 0;
502 msg = 0;
503 lore = 0;
504 custom_name = 0;
505 materialname = 0;
506 contr = 0;
507 below = 0;
508 above = 0;
509 inv = 0;
510 container = 0;
511 env = 0;
512 more = 0;
513 head = 0;
514 map = 0;
515 active_next = 0;
516 active_prev = 0;
517
518 memset (static_cast<object_pod *>(this), 0, sizeof (object_pod));
519
520 SET_FLAG (this, FLAG_REMOVED);
521
522 /* What is not cleared is next, prev, and count */
523
524 expmul = 1.0;
525 face = blank_face;
526
527 if (settings.casting_time)
528 casting_time = -1;
529}
530
531void object::clone (object *destination)
532{
533 *(object_copy *)destination = *this;
534 *(object_pod *)destination = *this;
535
536 if (self || cb)
537 INVOKE_OBJECT (CLONE, this, ARG_OBJECT (destination));
538}
539
540/*
541 * copy object first frees everything allocated by the second object,
542 * and then copies the contends of the first object into the second
543 * object, allocating what needs to be allocated. Basically, any
544 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
545 * if the first object is freed, the pointers in the new object
546 * will point at garbage.
547 */
548void
549copy_object (object *op2, object *op)
550{
551 bool is_freed = QUERY_FLAG (op, FLAG_FREED);
552 bool is_removed = QUERY_FLAG (op, FLAG_REMOVED);
553
554 op2->clone (op);
555
556 if (is_freed)
557 SET_FLAG (op, FLAG_FREED);
558
559 if (is_removed)
560 SET_FLAG (op, FLAG_REMOVED);
561
562 if (op2->speed < 0)
563 op->speed_left = op2->speed_left - RANDOM () % 200 / 100.0;
564 502
565 /* Copy over key_values, if any. */ 503 /* Copy over key_values, if any. */
566 if (op2->key_values) 504 if (src.key_values)
567 { 505 {
568 key_value *tail = 0; 506 key_value *tail = 0;
569 key_value *i;
570
571 op->key_values = 0; 507 key_values = 0;
572 508
573 for (i = op2->key_values; i; i = i->next) 509 for (key_value *i = src.key_values; i; i = i->next)
574 { 510 {
575 key_value *new_link = new key_value; 511 key_value *new_link = new key_value;
576 512
577 new_link->next = 0; 513 new_link->next = 0;
578 new_link->key = i->key; 514 new_link->key = i->key;
579 new_link->value = i->value; 515 new_link->value = i->value;
580 516
581 /* Try and be clever here, too. */ 517 /* Try and be clever here, too. */
582 if (!op->key_values) 518 if (!key_values)
583 { 519 {
584 op->key_values = new_link; 520 key_values = new_link;
585 tail = new_link; 521 tail = new_link;
586 } 522 }
587 else 523 else
588 { 524 {
589 tail->next = new_link; 525 tail->next = new_link;
590 tail = new_link; 526 tail = new_link;
591 } 527 }
592 } 528 }
593 } 529 }
530}
594 531
595 update_ob_speed (op); 532/*
533 * copy_to first frees everything allocated by the dst object,
534 * and then copies the contents of itself into the second
535 * object, allocating what needs to be allocated. Basically, any
536 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
537 * if the first object is freed, the pointers in the new object
538 * will point at garbage.
539 */
540void
541object::copy_to (object *dst)
542{
543 *dst = *this;
544
545 if (speed < 0)
546 dst->speed_left = speed_left - rndm ();
547
548 dst->set_speed (dst->speed);
549}
550
551void
552object::instantiate ()
553{
554 if (!uuid.seq) // HACK
555 uuid = gen_uuid ();
556
557 speed_left = -0.1f;
558 /* copy the body_info to the body_used - this is only really
559 * need for monsters, but doesn't hurt to do it for everything.
560 * by doing so, when a monster is created, it has good starting
561 * values for the body_used info, so when items are created
562 * for it, they can be properly equipped.
563 */
564 for (int i = NUM_BODY_LOCATIONS; i--; )
565 slot[i].used = slot[i].info;
566
567 attachable::instantiate ();
568}
569
570object *
571object::clone ()
572{
573 object *neu = create ();
574 copy_to (neu);
575 return neu;
596} 576}
597 577
598/* 578/*
599 * If an object with the IS_TURNABLE() flag needs to be turned due 579 * If an object with the IS_TURNABLE() flag needs to be turned due
600 * to the closest player being on the other side, this function can 580 * to the closest player being on the other side, this function can
601 * be called to update the face variable, _and_ how it looks on the map. 581 * be called to update the face variable, _and_ how it looks on the map.
602 */ 582 */
603
604void 583void
605update_turn_face (object *op) 584update_turn_face (object *op)
606{ 585{
607 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || op->arch == NULL) 586 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || !op->arch)
608 return; 587 return;
588
609 SET_ANIMATION (op, op->direction); 589 SET_ANIMATION (op, op->direction);
610 update_object (op, UP_OBJ_FACE); 590 update_object (op, UP_OBJ_FACE);
611} 591}
612 592
613/* 593/*
614 * Updates the speed of an object. If the speed changes from 0 to another 594 * Updates the speed of an object. If the speed changes from 0 to another
615 * value, or vice versa, then add/remove the object from the active list. 595 * value, or vice versa, then add/remove the object from the active list.
616 * This function needs to be called whenever the speed of an object changes. 596 * This function needs to be called whenever the speed of an object changes.
617 */ 597 */
618void 598void
619update_ob_speed (object *op) 599object::set_speed (float speed)
620{ 600{
621 extern int arch_init; 601 if (flag [FLAG_FREED] && speed)
622
623 /* No reason putting the archetypes objects on the speed list,
624 * since they never really need to be updated.
625 */
626
627 if (QUERY_FLAG (op, FLAG_FREED) && op->speed)
628 { 602 {
629 LOG (llevError, "Object %s is freed but has speed.\n", &op->name); 603 LOG (llevError, "Object %s is freed but has speed.\n", &name);
630#ifdef MANY_CORES
631 abort ();
632#else
633 op->speed = 0; 604 speed = 0;
634#endif
635 }
636
637 if (arch_init)
638 return;
639
640 if (FABS (op->speed) > MIN_ACTIVE_SPEED)
641 { 605 }
642 /* If already on active list, don't do anything */
643 if (op->active_next || op->active_prev || op == active_objects)
644 return;
645 606
646 /* process_events() expects us to insert the object at the beginning 607 this->speed = speed;
647 * of the list. */
648 op->active_next = active_objects;
649 608
650 if (op->active_next != NULL) 609 if (has_active_speed ())
651 op->active_next->active_prev = op; 610 activate ();
652
653 active_objects = op;
654 }
655 else 611 else
656 { 612 deactivate ();
657 /* If not on the active list, nothing needs to be done */
658 if (!op->active_next && !op->active_prev && op != active_objects)
659 return;
660
661 if (op->active_prev == NULL)
662 {
663 active_objects = op->active_next;
664
665 if (op->active_next != NULL)
666 op->active_next->active_prev = NULL;
667 }
668 else
669 {
670 op->active_prev->active_next = op->active_next;
671
672 if (op->active_next)
673 op->active_next->active_prev = op->active_prev;
674 }
675
676 op->active_next = NULL;
677 op->active_prev = NULL;
678 }
679} 613}
680 614
681/* This function removes object 'op' from the list of active
682 * objects.
683 * This should only be used for style maps or other such
684 * reference maps where you don't want an object that isn't
685 * in play chewing up cpu time getting processed.
686 * The reverse of this is to call update_ob_speed, which
687 * will do the right thing based on the speed of the object.
688 */
689void
690remove_from_active_list (object *op)
691{
692 /* If not on the active list, nothing needs to be done */
693 if (!op->active_next && !op->active_prev && op != active_objects)
694 return;
695
696 if (op->active_prev == NULL)
697 {
698 active_objects = op->active_next;
699 if (op->active_next != NULL)
700 op->active_next->active_prev = NULL;
701 }
702 else
703 {
704 op->active_prev->active_next = op->active_next;
705 if (op->active_next)
706 op->active_next->active_prev = op->active_prev;
707 }
708 op->active_next = NULL;
709 op->active_prev = NULL;
710}
711
712/* 615/*
713 * update_object() updates the array which represents the map. 616 * update_object() updates the the map.
714 * It takes into account invisible objects (and represent squares covered 617 * It takes into account invisible objects (and represent squares covered
715 * by invisible objects by whatever is below them (unless it's another 618 * by invisible objects by whatever is below them (unless it's another
716 * invisible object, etc...) 619 * invisible object, etc...)
717 * If the object being updated is beneath a player, the look-window 620 * If the object being updated is beneath a player, the look-window
718 * of that player is updated (this might be a suboptimal way of 621 * of that player is updated (this might be a suboptimal way of
719 * updating that window, though, since update_object() is called _often_) 622 * updating that window, though, since update_object() is called _often_)
720 * 623 *
721 * action is a hint of what the caller believes need to be done. 624 * action is a hint of what the caller believes need to be done.
722 * For example, if the only thing that has changed is the face (due to
723 * an animation), we don't need to call update_position until that actually
724 * comes into view of a player. OTOH, many other things, like addition/removal
725 * of walls or living creatures may need us to update the flags now.
726 * current action are: 625 * current action are:
727 * UP_OBJ_INSERT: op was inserted 626 * UP_OBJ_INSERT: op was inserted
728 * UP_OBJ_REMOVE: op was removed 627 * UP_OBJ_REMOVE: op was removed
729 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update 628 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update
730 * as that is easier than trying to look at what may have changed. 629 * as that is easier than trying to look at what may have changed.
731 * UP_OBJ_FACE: only the objects face has changed. 630 * UP_OBJ_FACE: only the objects face has changed.
732 */ 631 */
733
734void 632void
735update_object (object *op, int action) 633update_object (object *op, int action)
736{ 634{
737 int update_now = 0, flags;
738 MoveType move_on, move_off, move_block, move_slow;
739
740 if (op == NULL) 635 if (op == NULL)
741 { 636 {
742 /* this should never happen */ 637 /* this should never happen */
743 LOG (llevDebug, "update_object() called for NULL object.\n"); 638 LOG (llevDebug, "update_object() called for NULL object.\n");
744 return; 639 return;
745 } 640 }
746 641
747 if (op->env != NULL) 642 if (op->env)
748 { 643 {
749 /* Animation is currently handled by client, so nothing 644 /* Animation is currently handled by client, so nothing
750 * to do in this case. 645 * to do in this case.
751 */ 646 */
752 return; 647 return;
757 */ 652 */
758 if (!op->map || op->map->in_memory == MAP_SAVING) 653 if (!op->map || op->map->in_memory == MAP_SAVING)
759 return; 654 return;
760 655
761 /* make sure the object is within map boundaries */ 656 /* make sure the object is within map boundaries */
762 if (op->x < 0 || op->x >= MAP_WIDTH (op->map) || op->y < 0 || op->y >= MAP_HEIGHT (op->map)) 657 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
763 { 658 {
764 LOG (llevError, "update_object() called for object out of map!\n"); 659 LOG (llevError, "update_object() called for object out of map!\n");
765#ifdef MANY_CORES 660#ifdef MANY_CORES
766 abort (); 661 abort ();
767#endif 662#endif
768 return; 663 return;
769 } 664 }
770 665
771 flags = GET_MAP_FLAGS (op->map, op->x, op->y); 666 mapspace &m = op->ms ();
772 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NEED_UPDATE);
773 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
774 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
775 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
776 move_off = GET_MAP_MOVE_OFF (op->map, op->x, op->y);
777 667
668 if (!(m.flags_ & P_UPTODATE))
669 /* nop */;
778 if (action == UP_OBJ_INSERT) 670 else if (action == UP_OBJ_INSERT)
779 { 671 {
672 // this is likely overkill, TODO: revisit (schmorp)
780 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(flags & P_BLOCKSVIEW)) 673 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
781 update_now = 1;
782
783 if (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(flags & P_NO_MAGIC)) 674 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
784 update_now = 1; 675 || (op->type == PLAYER && !(m.flags_ & P_PLAYER))
785 676 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
677 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
786 if (QUERY_FLAG (op, FLAG_DAMNED) && !(flags & P_NO_CLERIC)) 678 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
787 update_now = 1;
788
789 if (QUERY_FLAG (op, FLAG_ALIVE) && !(flags & P_IS_ALIVE))
790 update_now = 1;
791
792 if (op->type == SAFE_GROUND && !(flags & P_SAFE))
793 update_now = 1;
794
795 if ((move_on | op->move_on) != move_on) 679 || (m.move_on | op->move_on ) != m.move_on
796 update_now = 1;
797
798 if ((move_off | op->move_off) != move_off) 680 || (m.move_off | op->move_off ) != m.move_off
799 update_now = 1; 681 || (m.move_slow | op->move_slow) != m.move_slow
800
801 /* This isn't perfect, but I don't expect a lot of objects to 682 /* This isn't perfect, but I don't expect a lot of objects to
802 * to have move_allow right now. 683 * to have move_allow right now.
803 */ 684 */
804 if (((move_block | op->move_block) & ~op->move_allow) != move_block) 685 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
805 update_now = 1; 686 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
806 687 m.flags_ = 0;
807 if ((move_slow | op->move_slow) != move_slow)
808 update_now = 1;
809 } 688 }
810
811 /* if the object is being removed, we can't make intelligent 689 /* if the object is being removed, we can't make intelligent
812 * decisions, because remove_ob can't really pass the object 690 * decisions, because remove_ob can't really pass the object
813 * that is being removed. 691 * that is being removed.
814 */ 692 */
815 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 693 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
816 update_now = 1; 694 m.flags_ = 0;
817 else if (action == UP_OBJ_FACE) 695 else if (action == UP_OBJ_FACE)
818 /* Nothing to do for that case */ ; 696 /* Nothing to do for that case */ ;
819 else 697 else
820 LOG (llevError, "update_object called with invalid action: %d\n", action); 698 LOG (llevError, "update_object called with invalid action: %d\n", action);
821 699
822 if (update_now)
823 {
824 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NO_ERROR | P_NEED_UPDATE);
825 update_position (op->map, op->x, op->y);
826 }
827
828 if (op->more != NULL) 700 if (op->more)
829 update_object (op->more, action); 701 update_object (op->more, action);
830}
831
832object::vector object::mortals;
833object::vector object::objects; // not yet used
834object *object::first;
835
836void object::free_mortals ()
837{
838 for (AUTODECL (i, mortals.begin ()); i != mortals.end ();)
839 if ((*i)->refcnt)
840 ++i; // further delay freeing
841 else
842 {
843 delete *i;
844 mortals.erase (i);
845 }
846} 702}
847 703
848object::object () 704object::object ()
849{ 705{
850 SET_FLAG (this, FLAG_REMOVED); 706 SET_FLAG (this, FLAG_REMOVED);
853 face = blank_face; 709 face = blank_face;
854} 710}
855 711
856object::~object () 712object::~object ()
857{ 713{
714 unlink ();
715
858 free_key_values (this); 716 free_key_values (this);
859} 717}
860 718
719static int object_count;
720
861void object::link () 721void object::link ()
862{ 722{
863 count = ++ob_count; 723 assert (!index);//D
864 uuid = gen_uuid (); 724 uuid = gen_uuid ();
725 count = ++object_count;
865 726
866 prev = 0; 727 refcnt_inc ();
867 next = object::first; 728 objects.insert (this);
868
869 if (object::first)
870 object::first->prev = this;
871
872 object::first = this;
873} 729}
874 730
875void object::unlink () 731void object::unlink ()
876{ 732{
877 if (this == object::first) 733 if (!index)
878 object::first = next; 734 return;
879 735
880 /* Remove this object from the list of used objects */ 736 objects.erase (this);
881 if (prev) prev->next = next; 737 refcnt_dec ();
882 if (next) next->prev = prev; 738}
883 739
884 prev = 0; 740void
885 next = 0; 741object::activate ()
742{
743 /* If already on active list, don't do anything */
744 if (active)
745 return;
746
747 if (has_active_speed ())
748 actives.insert (this);
749}
750
751void
752object::activate_recursive ()
753{
754 activate ();
755
756 for (object *op = inv; op; op = op->below)
757 op->activate_recursive ();
758}
759
760/* This function removes object 'op' from the list of active
761 * objects.
762 * This should only be used for style maps or other such
763 * reference maps where you don't want an object that isn't
764 * in play chewing up cpu time getting processed.
765 * The reverse of this is to call update_ob_speed, which
766 * will do the right thing based on the speed of the object.
767 */
768void
769object::deactivate ()
770{
771 /* If not on the active list, nothing needs to be done */
772 if (!active)
773 return;
774
775 actives.erase (this);
776}
777
778void
779object::deactivate_recursive ()
780{
781 for (object *op = inv; op; op = op->below)
782 op->deactivate_recursive ();
783
784 deactivate ();
785}
786
787void
788object::set_flag_inv (int flag, int value)
789{
790 for (object *op = inv; op; op = op->below)
791 {
792 op->flag [flag] = value;
793 op->set_flag_inv (flag, value);
794 }
795}
796
797/*
798 * Remove and free all objects in the inventory of the given object.
799 * object.c ?
800 */
801void
802object::destroy_inv (bool drop_to_ground)
803{
804 // need to check first, because the checks below might segfault
805 // as we might be on an invalid mapspace and crossfire code
806 // is too buggy to ensure that the inventory is empty.
807 // corollary: if you create arrows etc. with stuff in tis inventory,
808 // cf will crash below with off-map x and y
809 if (!inv)
810 return;
811
812 /* Only if the space blocks everything do we not process -
813 * if some form of movement is allowed, let objects
814 * drop on that space.
815 */
816 if (!drop_to_ground
817 || !map
818 || map->in_memory != MAP_IN_MEMORY
819 || map->nodrop
820 || ms ().move_block == MOVE_ALL)
821 {
822 while (inv)
823 {
824 inv->destroy_inv (drop_to_ground);
825 inv->destroy ();
826 }
827 }
828 else
829 { /* Put objects in inventory onto this space */
830 while (inv)
831 {
832 object *op = inv;
833
834 if (op->flag [FLAG_STARTEQUIP]
835 || op->flag [FLAG_NO_DROP]
836 || op->type == RUNE
837 || op->type == TRAP
838 || op->flag [FLAG_IS_A_TEMPLATE]
839 || op->flag [FLAG_DESTROY_ON_DEATH])
840 op->destroy ();
841 else
842 map->insert (op, x, y);
843 }
844 }
886} 845}
887 846
888object *object::create () 847object *object::create ()
889{ 848{
890 object *op = new object; 849 object *op = new object;
891 op->link (); 850 op->link ();
892 return op; 851 return op;
893} 852}
894 853
895/* 854void
896 * free_object() frees everything allocated by an object, removes 855object::do_destroy ()
897 * it from the list of used objects, and puts it on the list of
898 * free objects. The IS_FREED() flag is set in the object.
899 * The object must have been removed by remove_ob() first for
900 * this function to succeed.
901 *
902 * If destroy_inventory is set, free inventory as well. Else drop items in
903 * inventory to the ground.
904 */
905void object::destroy (bool destroy_inventory)
906{ 856{
907 if (QUERY_FLAG (this, FLAG_FREED)) 857 attachable::do_destroy ();
908 return;
909 858
910 if (QUERY_FLAG (this, FLAG_FRIENDLY)) 859 if (flag [FLAG_IS_LINKED])
860 remove_button_link (this);
861
862 if (flag [FLAG_FRIENDLY])
911 remove_friendly_object (this); 863 remove_friendly_object (this);
912 864
913 if (!QUERY_FLAG (this, FLAG_REMOVED)) 865 if (!flag [FLAG_REMOVED])
914 remove_ob (this); 866 remove ();
915 867
916 SET_FLAG (this, FLAG_FREED); 868 destroy_inv (true);
917 869
918 if (more) 870 deactivate ();
919 { 871 unlink ();
920 more->destroy (destroy_inventory);
921 more = 0;
922 }
923 872
924 if (inv) 873 flag [FLAG_FREED] = 1;
925 {
926 /* Only if the space blocks everything do we not process -
927 * if some form of movement is allowed, let objects
928 * drop on that space.
929 */
930 if (destroy_inventory || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL)
931 {
932 object *op = inv;
933
934 while (op)
935 {
936 object *tmp = op->below;
937 op->destroy (destroy_inventory);
938 op = tmp;
939 }
940 }
941 else
942 { /* Put objects in inventory onto this space */
943 object *op = inv;
944
945 while (op)
946 {
947 object *tmp = op->below;
948
949 remove_ob (op);
950
951 if (QUERY_FLAG (op, FLAG_STARTEQUIP)
952 || QUERY_FLAG (op, FLAG_NO_DROP) || op->type == RUNE || op->type == TRAP || QUERY_FLAG (op, FLAG_IS_A_TEMPLATE))
953 free_object (op);
954 else
955 {
956 op->x = x;
957 op->y = y;
958 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
959 }
960
961 op = tmp;
962 }
963 }
964 }
965 874
966 // hack to ensure that freed objects still have a valid map 875 // hack to ensure that freed objects still have a valid map
967 { 876 {
968 static maptile *freed_map; // freed objects are moved here to avoid crashes 877 static maptile *freed_map; // freed objects are moved here to avoid crashes
969 878
973 882
974 freed_map->name = "/internal/freed_objects_map"; 883 freed_map->name = "/internal/freed_objects_map";
975 freed_map->width = 3; 884 freed_map->width = 3;
976 freed_map->height = 3; 885 freed_map->height = 3;
977 886
978 freed_map->allocate (); 887 freed_map->alloc ();
888 freed_map->in_memory = MAP_IN_MEMORY;
979 } 889 }
980 890
981 map = freed_map; 891 map = freed_map;
982 x = 1; 892 x = 1;
983 y = 1; 893 y = 1;
984 } 894 }
985 895
896 head = 0;
897
898 if (more)
899 {
900 more->destroy ();
901 more = 0;
902 }
903
986 // clear those pointers that likely might have circular references to us 904 // clear those pointers that likely might have circular references to us
987 owner = 0; 905 owner = 0;
988 enemy = 0; 906 enemy = 0;
989 attacked_by = 0; 907 attacked_by = 0;
908}
990 909
991 // only relevant for players(?), but make sure of it anyways 910void
992 contr = 0; 911object::destroy (bool destroy_inventory)
912{
913 if (destroyed ())
914 return;
993 915
994 /* Remove object from the active list */ 916 if (destroy_inventory)
995 speed = 0; 917 destroy_inv (false);
996 update_ob_speed (this);
997 918
998 unlink (); 919 attachable::destroy ();
999
1000 mortals.push_back (this);
1001} 920}
1002 921
1003/* 922/*
1004 * sub_weight() recursively (outwards) subtracts a number from the 923 * sub_weight() recursively (outwards) subtracts a number from the
1005 * weight of an object (and what is carried by it's environment(s)). 924 * weight of an object (and what is carried by it's environment(s)).
1015 op->carrying -= weight; 934 op->carrying -= weight;
1016 op = op->env; 935 op = op->env;
1017 } 936 }
1018} 937}
1019 938
1020/* remove_ob(op): 939/* op->remove ():
1021 * This function removes the object op from the linked list of objects 940 * This function removes the object op from the linked list of objects
1022 * which it is currently tied to. When this function is done, the 941 * which it is currently tied to. When this function is done, the
1023 * object will have no environment. If the object previously had an 942 * object will have no environment. If the object previously had an
1024 * environment, the x and y coordinates will be updated to 943 * environment, the x and y coordinates will be updated to
1025 * the previous environment. 944 * the previous environment.
1026 * Beware: This function is called from the editor as well!
1027 */ 945 */
1028void 946void
1029object::remove () 947object::do_remove ()
1030{ 948{
1031 object *tmp, *last = 0; 949 object *tmp, *last = 0;
1032 object *otmp; 950 object *otmp;
1033 951
1034 int check_walk_off;
1035
1036 if (QUERY_FLAG (this, FLAG_REMOVED)) 952 if (QUERY_FLAG (this, FLAG_REMOVED))
1037 return; 953 return;
1038 954
1039 SET_FLAG (this, FLAG_REMOVED); 955 SET_FLAG (this, FLAG_REMOVED);
956 INVOKE_OBJECT (REMOVE, this);
1040 957
1041 if (more) 958 if (more)
1042 more->remove (); 959 more->remove ();
1043 960
1044 /* 961 /*
1054 971
1055 /* NO_FIX_PLAYER is set when a great many changes are being 972 /* NO_FIX_PLAYER is set when a great many changes are being
1056 * made to players inventory. If set, avoiding the call 973 * made to players inventory. If set, avoiding the call
1057 * to save cpu time. 974 * to save cpu time.
1058 */ 975 */
1059 if ((otmp = is_player_inv (env)) != NULL && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 976 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1060 fix_player (otmp); 977 otmp->update_stats ();
1061 978
1062 if (above != NULL) 979 if (above)
1063 above->below = below; 980 above->below = below;
1064 else 981 else
1065 env->inv = below; 982 env->inv = below;
1066 983
1067 if (below != NULL) 984 if (below)
1068 below->above = above; 985 below->above = above;
1069 986
1070 /* we set up values so that it could be inserted into 987 /* we set up values so that it could be inserted into
1071 * the map, but we don't actually do that - it is up 988 * the map, but we don't actually do that - it is up
1072 * to the caller to decide what we want to do. 989 * to the caller to decide what we want to do.
1076 above = 0, below = 0; 993 above = 0, below = 0;
1077 env = 0; 994 env = 0;
1078 } 995 }
1079 else if (map) 996 else if (map)
1080 { 997 {
1081 /* Re did the following section of code - it looks like it had 998 if (type == PLAYER)
1082 * lots of logic for things we no longer care about
1083 */ 999 {
1000 // leaving a spot always closes any open container on the ground
1001 if (container && !container->env)
1002 // this causes spurious floorbox updates, but it ensures
1003 // that the CLOSE event is being sent.
1004 close_container ();
1005
1006 --map->players;
1007 map->touch ();
1008 }
1009
1010 map->dirty = true;
1011 mapspace &ms = this->ms ();
1084 1012
1085 /* link the object above us */ 1013 /* link the object above us */
1086 if (above) 1014 if (above)
1087 above->below = below; 1015 above->below = below;
1088 else 1016 else
1089 SET_MAP_TOP (map, x, y, below); /* we were top, set new top */ 1017 ms.top = below; /* we were top, set new top */
1090 1018
1091 /* Relink the object below us, if there is one */ 1019 /* Relink the object below us, if there is one */
1092 if (below) 1020 if (below)
1093 below->above = above; 1021 below->above = above;
1094 else 1022 else
1096 /* Nothing below, which means we need to relink map object for this space 1024 /* Nothing below, which means we need to relink map object for this space
1097 * use translated coordinates in case some oddness with map tiling is 1025 * use translated coordinates in case some oddness with map tiling is
1098 * evident 1026 * evident
1099 */ 1027 */
1100 if (GET_MAP_OB (map, x, y) != this) 1028 if (GET_MAP_OB (map, x, y) != this)
1101 {
1102 char *dump = dump_object (this);
1103 LOG (llevError,
1104 "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", dump); 1029 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1105 free (dump);
1106 dump = dump_object (GET_MAP_OB (map, x, y));
1107 LOG (llevError, "%s\n", dump);
1108 free (dump);
1109 }
1110 1030
1111 SET_MAP_OB (map, x, y, above); /* goes on above it. */ 1031 ms.bot = above; /* goes on above it. */
1112 } 1032 }
1113 1033
1114 above = 0; 1034 above = 0;
1115 below = 0; 1035 below = 0;
1116 1036
1117 if (map->in_memory == MAP_SAVING) 1037 if (map->in_memory == MAP_SAVING)
1118 return; 1038 return;
1119 1039
1120 check_walk_off = !QUERY_FLAG (this, FLAG_NO_APPLY); 1040 int check_walk_off = !flag [FLAG_NO_APPLY];
1121 1041
1122 for (tmp = GET_MAP_OB (map, x, y); tmp; tmp = tmp->above) 1042 for (tmp = ms.bot; tmp; tmp = tmp->above)
1123 { 1043 {
1124 /* No point updating the players look faces if he is the object 1044 /* No point updating the players look faces if he is the object
1125 * being removed. 1045 * being removed.
1126 */ 1046 */
1127 1047
1131 * removed (most likely destroyed), update the player view 1051 * removed (most likely destroyed), update the player view
1132 * appropriately. 1052 * appropriately.
1133 */ 1053 */
1134 if (tmp->container == this) 1054 if (tmp->container == this)
1135 { 1055 {
1136 CLEAR_FLAG (this, FLAG_APPLIED); 1056 flag [FLAG_APPLIED] = 0;
1137 tmp->container = 0; 1057 tmp->container = 0;
1138 } 1058 }
1139 1059
1140 tmp->contr->socket.update_look = 1; 1060 if (tmp->contr->ns)
1061 tmp->contr->ns->floorbox_update ();
1141 } 1062 }
1142 1063
1143 /* See if player moving off should effect something */ 1064 /* See if object moving off should effect something */
1144 if (check_walk_off 1065 if (check_walk_off
1145 && ((move_type & tmp->move_off) 1066 && ((move_type & tmp->move_off)
1146 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1067 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0))
1147 { 1068 {
1148 move_apply (tmp, this, 0); 1069 move_apply (tmp, this, 0);
1150 if (destroyed ()) 1071 if (destroyed ())
1151 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ()); 1072 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1152 } 1073 }
1153 1074
1154 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */ 1075 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */
1155 1076 //TODO: why is this horrible hacka fix? get rid of this code=bug! (schmorp)
1156 if (tmp->above == tmp) 1077 if (tmp->above == tmp)
1157 tmp->above = 0; 1078 tmp->above = 0;
1158 1079
1159 last = tmp; 1080 last = tmp;
1160 } 1081 }
1161 1082
1162 /* last == NULL of there are no objects on this space */ 1083 /* last == NULL if there are no objects on this space */
1084 //TODO: this makes little sense, why only update the topmost object?
1163 if (!last) 1085 if (!last)
1164 { 1086 map->at (x, y).flags_ = 0;
1165 /* set P_NEED_UPDATE, otherwise update_position will complain. In theory,
1166 * we could preserve the flags (GET_MAP_FLAGS), but update_position figures
1167 * those out anyways, and if there are any flags set right now, they won't
1168 * be correct anyways.
1169 */
1170 SET_MAP_FLAGS (map, x, y, P_NEED_UPDATE);
1171 update_position (map, x, y);
1172 }
1173 else 1087 else
1174 update_object (last, UP_OBJ_REMOVE); 1088 update_object (last, UP_OBJ_REMOVE);
1175 1089
1176 if (QUERY_FLAG (this, FLAG_BLOCKSVIEW) || glow_radius) 1090 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1177 update_all_los (map, x, y); 1091 update_all_los (map, x, y);
1178 } 1092 }
1179} 1093}
1180 1094
1181/* 1095/*
1190merge_ob (object *op, object *top) 1104merge_ob (object *op, object *top)
1191{ 1105{
1192 if (!op->nrof) 1106 if (!op->nrof)
1193 return 0; 1107 return 0;
1194 1108
1195 if (top == NULL) 1109 if (top)
1196 for (top = op; top != NULL && top->above != NULL; top = top->above); 1110 for (top = op; top && top->above; top = top->above)
1111 ;
1197 1112
1198 for (; top != NULL; top = top->below) 1113 for (; top; top = top->below)
1199 { 1114 {
1200 if (top == op) 1115 if (top == op)
1201 continue; 1116 continue;
1202 if (CAN_MERGE (op, top)) 1117
1118 if (object::can_merge (op, top))
1203 { 1119 {
1204 top->nrof += op->nrof; 1120 top->nrof += op->nrof;
1205 1121
1206/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/ 1122/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/
1207 op->weight = 0; /* Don't want any adjustements now */ 1123 op->weight = 0; /* Don't want any adjustements now */
1208 remove_ob (op); 1124 op->destroy ();
1209 free_object (op);
1210 return top; 1125 return top;
1211 } 1126 }
1212 } 1127 }
1213 1128
1214 return 0; 1129 return 0;
1215} 1130}
1216 1131
1132void
1133object::expand_tail ()
1134{
1135 if (more)
1136 return;
1137
1138 object *prev = this;
1139
1140 for (archetype *at = arch->more; at; at = at->more)
1141 {
1142 object *op = arch_to_object (at);
1143
1144 op->name = name;
1145 op->name_pl = name_pl;
1146 op->title = title;
1147
1148 op->head = this;
1149 prev->more = op;
1150
1151 prev = op;
1152 }
1153}
1154
1217/* 1155/*
1218 * same as insert_ob_in_map except it handle separate coordinates and do a clean 1156 * same as insert_ob_in_map except it handles separate coordinates and does a clean
1219 * job preparing multi-part monsters 1157 * job preparing multi-part monsters.
1220 */ 1158 */
1221object * 1159object *
1222insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1160insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1223{ 1161{
1224 object *tmp;
1225
1226 if (op->head)
1227 op = op->head;
1228
1229 for (tmp = op; tmp; tmp = tmp->more) 1162 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1230 { 1163 {
1231 tmp->x = x + tmp->arch->clone.x; 1164 tmp->x = x + tmp->arch->clone.x;
1232 tmp->y = y + tmp->arch->clone.y; 1165 tmp->y = y + tmp->arch->clone.y;
1233 } 1166 }
1234 1167
1253 * Return value: 1186 * Return value:
1254 * new object if 'op' was merged with other object 1187 * new object if 'op' was merged with other object
1255 * NULL if 'op' was destroyed 1188 * NULL if 'op' was destroyed
1256 * just 'op' otherwise 1189 * just 'op' otherwise
1257 */ 1190 */
1258
1259object * 1191object *
1260insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1192insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1261{ 1193{
1194 assert (!op->flag [FLAG_FREED]);
1195
1262 object *tmp, *top, *floor = NULL; 1196 object *tmp, *top, *floor = NULL;
1263 sint16 x, y;
1264 1197
1265 if (QUERY_FLAG (op, FLAG_FREED)) 1198 op->remove ();
1266 {
1267 LOG (llevError, "Trying to insert freed object!\n");
1268 return NULL;
1269 }
1270 1199
1271 if (m == NULL) 1200#if 0
1272 { 1201 if (!m->active != !op->active)
1273 char *dump = dump_object (op); 1202 if (m->active)
1274 LOG (llevError, "Trying to insert in null-map!\n%s\n", dump); 1203 op->activate_recursive ();
1275 free (dump); 1204 else
1276 return op; 1205 op->deactivate_recursive ();
1277 } 1206#endif
1278 1207
1279 if (out_of_map (m, op->x, op->y)) 1208 if (out_of_map (m, op->x, op->y))
1280 { 1209 {
1281 char *dump = dump_object (op);
1282 LOG (llevError, "Trying to insert object outside the map.\n%s\n", dump); 1210 LOG (llevError, "Trying to insert object outside the map.\n%s\n", op->debug_desc ());
1283#ifdef MANY_CORES 1211#ifdef MANY_CORES
1284 /* Better to catch this here, as otherwise the next use of this object 1212 /* Better to catch this here, as otherwise the next use of this object
1285 * is likely to cause a crash. Better to find out where it is getting 1213 * is likely to cause a crash. Better to find out where it is getting
1286 * improperly inserted. 1214 * improperly inserted.
1287 */ 1215 */
1288 abort (); 1216 abort ();
1289#endif 1217#endif
1290 free (dump);
1291 return op; 1218 return op;
1292 } 1219 }
1293 1220
1294 if (!QUERY_FLAG (op, FLAG_REMOVED))
1295 {
1296 char *dump = dump_object (op);
1297 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", dump);
1298 free (dump);
1299 return op;
1300 }
1301
1302 if (op->more != NULL)
1303 {
1304 /* The part may be on a different map. */
1305
1306 object *more = op->more; 1221 if (object *more = op->more)
1307 1222 {
1308 /* We really need the caller to normalize coordinates - if
1309 * we set the map, that doesn't work if the location is within
1310 * a map and this is straddling an edge. So only if coordinate
1311 * is clear wrong do we normalize it.
1312 */
1313 if (OUT_OF_REAL_MAP (more->map, more->x, more->y))
1314 more->map = get_map_from_coord (m, &more->x, &more->y);
1315 else if (!more->map)
1316 {
1317 /* For backwards compatibility - when not dealing with tiled maps,
1318 * more->map should always point to the parent.
1319 */
1320 more->map = m;
1321 }
1322
1323 if (insert_ob_in_map (more, more->map, originator, flag) == NULL) 1223 if (!insert_ob_in_map (more, m, originator, flag))
1324 { 1224 {
1325 if (!op->head) 1225 if (!op->head)
1326 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n"); 1226 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n");
1327 1227
1328 return NULL; 1228 return 0;
1329 } 1229 }
1330 } 1230 }
1331 1231
1332 CLEAR_FLAG (op, FLAG_REMOVED); 1232 CLEAR_FLAG (op, FLAG_REMOVED);
1333 1233
1334 /* Ideally, the caller figures this out. However, it complicates a lot 1234 /* Ideally, the caller figures this out. However, it complicates a lot
1335 * of areas of callers (eg, anything that uses find_free_spot would now 1235 * of areas of callers (eg, anything that uses find_free_spot would now
1336 * need extra work 1236 * need extra work
1337 */ 1237 */
1338 op->map = get_map_from_coord (m, &op->x, &op->y); 1238 if (!xy_normalise (m, op->x, op->y))
1339 x = op->x; 1239 return 0;
1340 y = op->y; 1240
1241 op->map = m;
1242 mapspace &ms = op->ms ();
1341 1243
1342 /* this has to be done after we translate the coordinates. 1244 /* this has to be done after we translate the coordinates.
1343 */ 1245 */
1344 if (op->nrof && !(flag & INS_NO_MERGE)) 1246 if (op->nrof && !(flag & INS_NO_MERGE))
1345 for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above) 1247 for (tmp = ms.bot; tmp; tmp = tmp->above)
1346 if (CAN_MERGE (op, tmp)) 1248 if (object::can_merge (op, tmp))
1347 { 1249 {
1348 op->nrof += tmp->nrof; 1250 op->nrof += tmp->nrof;
1349 remove_ob (tmp); 1251 tmp->destroy ();
1350 free_object (tmp);
1351 } 1252 }
1352 1253
1353 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1254 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1354 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1255 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1355 1256
1368 op->below = originator->below; 1269 op->below = originator->below;
1369 1270
1370 if (op->below) 1271 if (op->below)
1371 op->below->above = op; 1272 op->below->above = op;
1372 else 1273 else
1373 SET_MAP_OB (op->map, op->x, op->y, op); 1274 ms.bot = op;
1374 1275
1375 /* since *below* originator, no need to update top */ 1276 /* since *below* originator, no need to update top */
1376 originator->below = op; 1277 originator->below = op;
1377 } 1278 }
1378 else 1279 else
1379 { 1280 {
1281 top = ms.bot;
1282
1380 /* If there are other objects, then */ 1283 /* If there are other objects, then */
1381 if ((!(flag & INS_MAP_LOAD)) && ((top = GET_MAP_OB (op->map, op->x, op->y)) != NULL)) 1284 if ((!(flag & INS_MAP_LOAD)) && top)
1382 { 1285 {
1383 object *last = NULL; 1286 object *last = 0;
1384 1287
1385 /* 1288 /*
1386 * If there are multiple objects on this space, we do some trickier handling. 1289 * If there are multiple objects on this space, we do some trickier handling.
1387 * We've already dealt with merging if appropriate. 1290 * We've already dealt with merging if appropriate.
1388 * Generally, we want to put the new object on top. But if 1291 * Generally, we want to put the new object on top. But if
1392 * once we get to them. This reduces the need to traverse over all of 1295 * once we get to them. This reduces the need to traverse over all of
1393 * them when adding another one - this saves quite a bit of cpu time 1296 * them when adding another one - this saves quite a bit of cpu time
1394 * when lots of spells are cast in one area. Currently, it is presumed 1297 * when lots of spells are cast in one area. Currently, it is presumed
1395 * that flying non pickable objects are spell objects. 1298 * that flying non pickable objects are spell objects.
1396 */ 1299 */
1397 1300 for (top = ms.bot; top; top = top->above)
1398 while (top != NULL)
1399 { 1301 {
1400 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1302 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))
1401 floor = top; 1303 floor = top;
1402 1304
1403 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1305 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))
1406 top = top->below; 1308 top = top->below;
1407 break; 1309 break;
1408 } 1310 }
1409 1311
1410 last = top; 1312 last = top;
1411 top = top->above;
1412 } 1313 }
1413 1314
1414 /* Don't want top to be NULL, so set it to the last valid object */ 1315 /* Don't want top to be NULL, so set it to the last valid object */
1415 top = last; 1316 top = last;
1416 1317
1418 * looks like instead of lots of conditions here. 1319 * looks like instead of lots of conditions here.
1419 * makes things faster, and effectively the same result. 1320 * makes things faster, and effectively the same result.
1420 */ 1321 */
1421 1322
1422 /* Have object 'fall below' other objects that block view. 1323 /* Have object 'fall below' other objects that block view.
1423 * Unless those objects are exits, type 66 1324 * Unless those objects are exits.
1424 * If INS_ON_TOP is used, don't do this processing 1325 * If INS_ON_TOP is used, don't do this processing
1425 * Need to find the object that in fact blocks view, otherwise 1326 * Need to find the object that in fact blocks view, otherwise
1426 * stacking is a bit odd. 1327 * stacking is a bit odd.
1427 */ 1328 */
1428 if (!(flag & INS_ON_TOP) && 1329 if (!(flag & INS_ON_TOP)
1429 (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_BLOCKSVIEW) && (op->face && !op->face->visibility)) 1330 && ms.flags () & P_BLOCKSVIEW
1331 && (op->face && !faces [op->face].visibility))
1430 { 1332 {
1431 for (last = top; last != floor; last = last->below) 1333 for (last = top; last != floor; last = last->below)
1432 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1334 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1433 break; 1335 break;
1336
1434 /* Check to see if we found the object that blocks view, 1337 /* Check to see if we found the object that blocks view,
1435 * and make sure we have a below pointer for it so that 1338 * and make sure we have a below pointer for it so that
1436 * we can get inserted below this one, which requires we 1339 * we can get inserted below this one, which requires we
1437 * set top to the object below us. 1340 * set top to the object below us.
1438 */ 1341 */
1440 top = last->below; 1343 top = last->below;
1441 } 1344 }
1442 } /* If objects on this space */ 1345 } /* If objects on this space */
1443 1346
1444 if (flag & INS_MAP_LOAD) 1347 if (flag & INS_MAP_LOAD)
1445 top = GET_MAP_TOP (op->map, op->x, op->y); 1348 top = ms.top;
1446 1349
1447 if (flag & INS_ABOVE_FLOOR_ONLY) 1350 if (flag & INS_ABOVE_FLOOR_ONLY)
1448 top = floor; 1351 top = floor;
1449 1352
1450 /* Top is the object that our object (op) is going to get inserted above. 1353 /* Top is the object that our object (op) is going to get inserted above.
1451 */ 1354 */
1452 1355
1453 /* First object on this space */ 1356 /* First object on this space */
1454 if (!top) 1357 if (!top)
1455 { 1358 {
1456 op->above = GET_MAP_OB (op->map, op->x, op->y); 1359 op->above = ms.bot;
1457 1360
1458 if (op->above) 1361 if (op->above)
1459 op->above->below = op; 1362 op->above->below = op;
1460 1363
1461 op->below = NULL; 1364 op->below = 0;
1462 SET_MAP_OB (op->map, op->x, op->y, op); 1365 ms.bot = op;
1463 } 1366 }
1464 else 1367 else
1465 { /* get inserted into the stack above top */ 1368 { /* get inserted into the stack above top */
1466 op->above = top->above; 1369 op->above = top->above;
1467 1370
1470 1373
1471 op->below = top; 1374 op->below = top;
1472 top->above = op; 1375 top->above = op;
1473 } 1376 }
1474 1377
1475 if (op->above == NULL) 1378 if (!op->above)
1476 SET_MAP_TOP (op->map, op->x, op->y, op); 1379 ms.top = op;
1477 } /* else not INS_BELOW_ORIGINATOR */ 1380 } /* else not INS_BELOW_ORIGINATOR */
1478 1381
1479 if (op->type == PLAYER) 1382 if (op->type == PLAYER)
1383 {
1480 op->contr->do_los = 1; 1384 op->contr->do_los = 1;
1385 ++op->map->players;
1386 op->map->touch ();
1387 }
1388
1389 op->map->dirty = true;
1481 1390
1482 /* If we have a floor, we know the player, if any, will be above 1391 /* If we have a floor, we know the player, if any, will be above
1483 * it, so save a few ticks and start from there. 1392 * it, so save a few ticks and start from there.
1484 */ 1393 */
1485 if (!(flag & INS_MAP_LOAD)) 1394 if (!(flag & INS_MAP_LOAD))
1486 for (tmp = floor ? floor : GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1395 if (object *pl = ms.player ())
1487 if (tmp->type == PLAYER) 1396 if (pl->contr->ns)
1488 tmp->contr->socket.update_look = 1; 1397 pl->contr->ns->floorbox_update ();
1489 1398
1490 /* If this object glows, it may affect lighting conditions that are 1399 /* If this object glows, it may affect lighting conditions that are
1491 * visible to others on this map. But update_all_los is really 1400 * visible to others on this map. But update_all_los is really
1492 * an inefficient way to do this, as it means los for all players 1401 * an inefficient way to do this, as it means los for all players
1493 * on the map will get recalculated. The players could very well 1402 * on the map will get recalculated. The players could very well
1494 * be far away from this change and not affected in any way - 1403 * be far away from this change and not affected in any way -
1495 * this should get redone to only look for players within range, 1404 * this should get redone to only look for players within range,
1496 * or just updating the P_NEED_UPDATE for spaces within this area 1405 * or just updating the P_UPTODATE for spaces within this area
1497 * of effect may be sufficient. 1406 * of effect may be sufficient.
1498 */ 1407 */
1499 if (MAP_DARKNESS (op->map) && (op->glow_radius != 0)) 1408 if (op->map->darkness && (op->glow_radius != 0))
1500 update_all_los (op->map, op->x, op->y); 1409 update_all_los (op->map, op->x, op->y);
1501 1410
1502 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1411 /* updates flags (blocked, alive, no magic, etc) for this map space */
1503 update_object (op, UP_OBJ_INSERT); 1412 update_object (op, UP_OBJ_INSERT);
1504 1413
1414 INVOKE_OBJECT (INSERT, op);
1415
1505 /* Don't know if moving this to the end will break anything. However, 1416 /* Don't know if moving this to the end will break anything. However,
1506 * we want to have update_look set above before calling this. 1417 * we want to have floorbox_update called before calling this.
1507 * 1418 *
1508 * check_move_on() must be after this because code called from 1419 * check_move_on() must be after this because code called from
1509 * check_move_on() depends on correct map flags (so functions like 1420 * check_move_on() depends on correct map flags (so functions like
1510 * blocked() and wall() work properly), and these flags are updated by 1421 * blocked() and wall() work properly), and these flags are updated by
1511 * update_object(). 1422 * update_object().
1513 1424
1514 /* if this is not the head or flag has been passed, don't check walk on status */ 1425 /* if this is not the head or flag has been passed, don't check walk on status */
1515 if (!(flag & INS_NO_WALK_ON) && !op->head) 1426 if (!(flag & INS_NO_WALK_ON) && !op->head)
1516 { 1427 {
1517 if (check_move_on (op, originator)) 1428 if (check_move_on (op, originator))
1518 return NULL; 1429 return 0;
1519 1430
1520 /* If we are a multi part object, lets work our way through the check 1431 /* If we are a multi part object, lets work our way through the check
1521 * walk on's. 1432 * walk on's.
1522 */ 1433 */
1523 for (tmp = op->more; tmp != NULL; tmp = tmp->more) 1434 for (tmp = op->more; tmp != NULL; tmp = tmp->more)
1524 if (check_move_on (tmp, originator)) 1435 if (check_move_on (tmp, originator))
1525 return NULL; 1436 return 0;
1526 } 1437 }
1527 1438
1528 return op; 1439 return op;
1529} 1440}
1530 1441
1531/* this function inserts an object in the map, but if it 1442/* this function inserts an object in the map, but if it
1532 * finds an object of its own type, it'll remove that one first. 1443 * finds an object of its own type, it'll remove that one first.
1533 * op is the object to insert it under: supplies x and the map. 1444 * op is the object to insert it under: supplies x and the map.
1534 */ 1445 */
1535void 1446void
1536replace_insert_ob_in_map (const char *arch_string, object *op) 1447replace_insert_ob_in_map (const char *arch_string, object *op)
1537{ 1448{
1538 object * 1449 object *tmp, *tmp1;
1539 tmp;
1540 object *
1541 tmp1;
1542 1450
1543 /* first search for itself and remove any old instances */ 1451 /* first search for itself and remove any old instances */
1544 1452
1545 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1453 for (tmp = op->ms ().bot; tmp; tmp = tmp->above)
1546 {
1547 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */ 1454 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */
1548 { 1455 tmp->destroy ();
1549 remove_ob (tmp);
1550 free_object (tmp);
1551 }
1552 }
1553 1456
1554 tmp1 = arch_to_object (archetype::find (arch_string)); 1457 tmp1 = arch_to_object (archetype::find (arch_string));
1555 1458
1556 tmp1->x = op->x; 1459 tmp1->x = op->x;
1557 tmp1->y = op->y; 1460 tmp1->y = op->y;
1558 insert_ob_in_map (tmp1, op->map, op, 0); 1461 insert_ob_in_map (tmp1, op->map, op, 0);
1462}
1463
1464object *
1465object::insert_at (object *where, object *originator, int flags)
1466{
1467 return where->map->insert (this, where->x, where->y, originator, flags);
1559} 1468}
1560 1469
1561/* 1470/*
1562 * get_split_ob(ob,nr) splits up ob into two parts. The part which 1471 * get_split_ob(ob,nr) splits up ob into two parts. The part which
1563 * is returned contains nr objects, and the remaining parts contains 1472 * is returned contains nr objects, and the remaining parts contains
1564 * the rest (or is removed and freed if that number is 0). 1473 * the rest (or is removed and freed if that number is 0).
1565 * On failure, NULL is returned, and the reason put into the 1474 * On failure, NULL is returned, and the reason put into the
1566 * global static errmsg array. 1475 * global static errmsg array.
1567 */ 1476 */
1568
1569object * 1477object *
1570get_split_ob (object *orig_ob, uint32 nr) 1478get_split_ob (object *orig_ob, uint32 nr)
1571{ 1479{
1572 object * 1480 object *newob;
1573 newob;
1574 int
1575 is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0); 1481 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1576 1482
1577 if (orig_ob->nrof < nr) 1483 if (orig_ob->nrof < nr)
1578 { 1484 {
1579 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name); 1485 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1580 return NULL; 1486 return NULL;
1581 } 1487 }
1582 1488
1583 newob = object_create_clone (orig_ob); 1489 newob = object_create_clone (orig_ob);
1584 1490
1585 if ((orig_ob->nrof -= nr) < 1) 1491 if ((orig_ob->nrof -= nr) < 1)
1586 { 1492 orig_ob->destroy (1);
1587 if (!is_removed)
1588 remove_ob (orig_ob);
1589 free_object2 (orig_ob, 1);
1590 }
1591 else if (!is_removed) 1493 else if (!is_removed)
1592 { 1494 {
1593 if (orig_ob->env != NULL) 1495 if (orig_ob->env != NULL)
1594 sub_weight (orig_ob->env, orig_ob->weight * nr); 1496 sub_weight (orig_ob->env, orig_ob->weight * nr);
1595 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY) 1497 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY)
1610 * the amount of an object. If the amount reaches 0, the object 1512 * the amount of an object. If the amount reaches 0, the object
1611 * is subsequently removed and freed. 1513 * is subsequently removed and freed.
1612 * 1514 *
1613 * Return value: 'op' if something is left, NULL if the amount reached 0 1515 * Return value: 'op' if something is left, NULL if the amount reached 0
1614 */ 1516 */
1615
1616object * 1517object *
1617decrease_ob_nr (object *op, uint32 i) 1518decrease_ob_nr (object *op, uint32 i)
1618{ 1519{
1619 object *tmp; 1520 object *tmp;
1620 player *pl;
1621 1521
1622 if (i == 0) /* objects with op->nrof require this check */ 1522 if (i == 0) /* objects with op->nrof require this check */
1623 return op; 1523 return op;
1624 1524
1625 if (i > op->nrof) 1525 if (i > op->nrof)
1626 i = op->nrof; 1526 i = op->nrof;
1627 1527
1628 if (QUERY_FLAG (op, FLAG_REMOVED)) 1528 if (QUERY_FLAG (op, FLAG_REMOVED))
1629 op->nrof -= i; 1529 op->nrof -= i;
1630 else if (op->env != NULL) 1530 else if (op->env)
1631 { 1531 {
1632 /* is this object in the players inventory, or sub container 1532 /* is this object in the players inventory, or sub container
1633 * therein? 1533 * therein?
1634 */ 1534 */
1635 tmp = is_player_inv (op->env); 1535 tmp = op->in_player ();
1636 /* nope. Is this a container the player has opened? 1536 /* nope. Is this a container the player has opened?
1637 * If so, set tmp to that player. 1537 * If so, set tmp to that player.
1638 * IMO, searching through all the players will mostly 1538 * IMO, searching through all the players will mostly
1639 * likely be quicker than following op->env to the map, 1539 * likely be quicker than following op->env to the map,
1640 * and then searching the map for a player. 1540 * and then searching the map for a player.
1641 */ 1541 */
1642 if (!tmp) 1542 if (!tmp)
1643 { 1543 for_all_players (pl)
1644 for (pl = first_player; pl; pl = pl->next)
1645 if (pl->ob->container == op->env) 1544 if (pl->ob->container == op->env)
1545 {
1546 tmp = pl->ob;
1646 break; 1547 break;
1647 if (pl)
1648 tmp = pl->ob;
1649 else
1650 tmp = NULL;
1651 } 1548 }
1652 1549
1653 if (i < op->nrof) 1550 if (i < op->nrof)
1654 { 1551 {
1655 sub_weight (op->env, op->weight * i); 1552 sub_weight (op->env, op->weight * i);
1656 op->nrof -= i; 1553 op->nrof -= i;
1657 if (tmp) 1554 if (tmp)
1658 {
1659 esrv_send_item (tmp, op); 1555 esrv_send_item (tmp, op);
1660 }
1661 } 1556 }
1662 else 1557 else
1663 { 1558 {
1664 remove_ob (op); 1559 op->remove ();
1665 op->nrof = 0; 1560 op->nrof = 0;
1666 if (tmp) 1561 if (tmp)
1667 {
1668 esrv_del_item (tmp->contr, op->count); 1562 esrv_del_item (tmp->contr, op->count);
1669 }
1670 } 1563 }
1671 } 1564 }
1672 else 1565 else
1673 { 1566 {
1674 object *above = op->above; 1567 object *above = op->above;
1675 1568
1676 if (i < op->nrof) 1569 if (i < op->nrof)
1677 op->nrof -= i; 1570 op->nrof -= i;
1678 else 1571 else
1679 { 1572 {
1680 remove_ob (op); 1573 op->remove ();
1681 op->nrof = 0; 1574 op->nrof = 0;
1682 } 1575 }
1683 1576
1684 /* Since we just removed op, op->above is null */ 1577 /* Since we just removed op, op->above is null */
1685 for (tmp = above; tmp != NULL; tmp = tmp->above) 1578 for (tmp = above; tmp; tmp = tmp->above)
1686 if (tmp->type == PLAYER) 1579 if (tmp->type == PLAYER)
1687 { 1580 {
1688 if (op->nrof) 1581 if (op->nrof)
1689 esrv_send_item (tmp, op); 1582 esrv_send_item (tmp, op);
1690 else 1583 else
1694 1587
1695 if (op->nrof) 1588 if (op->nrof)
1696 return op; 1589 return op;
1697 else 1590 else
1698 { 1591 {
1699 free_object (op); 1592 op->destroy ();
1700 return NULL; 1593 return 0;
1701 } 1594 }
1702} 1595}
1703 1596
1704/* 1597/*
1705 * add_weight(object, weight) adds the specified weight to an object, 1598 * add_weight(object, weight) adds the specified weight to an object,
1706 * and also updates how much the environment(s) is/are carrying. 1599 * and also updates how much the environment(s) is/are carrying.
1707 */ 1600 */
1708
1709void 1601void
1710add_weight (object *op, signed long weight) 1602add_weight (object *op, signed long weight)
1711{ 1603{
1712 while (op != NULL) 1604 while (op != NULL)
1713 { 1605 {
1745 * inside the object environment. 1637 * inside the object environment.
1746 * 1638 *
1747 * The function returns now pointer to inserted item, and return value can 1639 * The function returns now pointer to inserted item, and return value can
1748 * be != op, if items are merged. -Tero 1640 * be != op, if items are merged. -Tero
1749 */ 1641 */
1750
1751object * 1642object *
1752object::insert (object *op) 1643object::insert (object *op)
1753{ 1644{
1754 object *tmp, *otmp; 1645 object *tmp, *otmp;
1755 1646
1765 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL); 1656 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL);
1766 CLEAR_FLAG (op, FLAG_REMOVED); 1657 CLEAR_FLAG (op, FLAG_REMOVED);
1767 if (op->nrof) 1658 if (op->nrof)
1768 { 1659 {
1769 for (tmp = inv; tmp != NULL; tmp = tmp->below) 1660 for (tmp = inv; tmp != NULL; tmp = tmp->below)
1770 if (CAN_MERGE (tmp, op)) 1661 if (object::can_merge (tmp, op))
1771 { 1662 {
1772 /* return the original object and remove inserted object 1663 /* return the original object and remove inserted object
1773 (client needs the original object) */ 1664 (client needs the original object) */
1774 tmp->nrof += op->nrof; 1665 tmp->nrof += op->nrof;
1775 /* Weight handling gets pretty funky. Since we are adding to 1666 /* Weight handling gets pretty funky. Since we are adding to
1793 add_weight (this, op->weight * op->nrof); 1684 add_weight (this, op->weight * op->nrof);
1794 } 1685 }
1795 else 1686 else
1796 add_weight (this, (op->weight + op->carrying)); 1687 add_weight (this, (op->weight + op->carrying));
1797 1688
1798 otmp = is_player_inv (this); 1689 otmp = this->in_player ();
1799 if (otmp && otmp->contr) 1690 if (otmp && otmp->contr)
1800 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1691 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1801 fix_player (otmp); 1692 otmp->update_stats ();
1802 1693
1803 op->map = NULL; 1694 op->map = 0;
1804 op->env = this; 1695 op->env = this;
1805 op->above = NULL; 1696 op->above = 0;
1806 op->below = NULL; 1697 op->below = 0;
1807 op->x = 0, op->y = 0; 1698 op->x = 0, op->y = 0;
1808 1699
1809 /* reset the light list and los of the players on the map */ 1700 /* reset the light list and los of the players on the map */
1810 if ((op->glow_radius != 0) && map) 1701 if ((op->glow_radius != 0) && map)
1811 { 1702 {
1812#ifdef DEBUG_LIGHTS 1703#ifdef DEBUG_LIGHTS
1813 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name); 1704 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1814#endif /* DEBUG_LIGHTS */ 1705#endif /* DEBUG_LIGHTS */
1815 if (MAP_DARKNESS (map)) 1706 if (map->darkness)
1816 update_all_los (map, x, y); 1707 update_all_los (map, x, y);
1817 } 1708 }
1818 1709
1819 /* Client has no idea of ordering so lets not bother ordering it here. 1710 /* Client has no idea of ordering so lets not bother ordering it here.
1820 * It sure simplifies this function... 1711 * It sure simplifies this function...
1825 { 1716 {
1826 op->below = inv; 1717 op->below = inv;
1827 op->below->above = op; 1718 op->below->above = op;
1828 inv = op; 1719 inv = op;
1829 } 1720 }
1721
1722 INVOKE_OBJECT (INSERT, this);
1830 1723
1831 return op; 1724 return op;
1832} 1725}
1833 1726
1834/* 1727/*
1849 * 1742 *
1850 * MSW 2001-07-08: Check all objects on space, not just those below 1743 * MSW 2001-07-08: Check all objects on space, not just those below
1851 * object being inserted. insert_ob_in_map may not put new objects 1744 * object being inserted. insert_ob_in_map may not put new objects
1852 * on top. 1745 * on top.
1853 */ 1746 */
1854
1855int 1747int
1856check_move_on (object *op, object *originator) 1748check_move_on (object *op, object *originator)
1857{ 1749{
1858 object *tmp; 1750 object *tmp;
1859 maptile *m = op->map; 1751 maptile *m = op->map;
1886 1778
1887 /* The objects have to be checked from top to bottom. 1779 /* The objects have to be checked from top to bottom.
1888 * Hence, we first go to the top: 1780 * Hence, we first go to the top:
1889 */ 1781 */
1890 1782
1891 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL && tmp->above != NULL; tmp = tmp->above) 1783 for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1892 { 1784 {
1893 /* Trim the search when we find the first other spell effect 1785 /* Trim the search when we find the first other spell effect
1894 * this helps performance so that if a space has 50 spell objects, 1786 * this helps performance so that if a space has 50 spell objects,
1895 * we don't need to check all of them. 1787 * we don't need to check all of them.
1896 */ 1788 */
1914 if ((!op->move_type && tmp->move_slow & MOVE_WALK) || 1806 if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
1915 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0)) 1807 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
1916 { 1808 {
1917 1809
1918 float 1810 float
1919 diff = tmp->move_slow_penalty * FABS (op->speed); 1811 diff = tmp->move_slow_penalty * fabs (op->speed);
1920 1812
1921 if (op->type == PLAYER) 1813 if (op->type == PLAYER)
1922 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) || 1814 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) ||
1923 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN))) 1815 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN)))
1924 diff /= 4.0; 1816 diff /= 4.0;
1951/* 1843/*
1952 * present_arch(arch, map, x, y) searches for any objects with 1844 * present_arch(arch, map, x, y) searches for any objects with
1953 * a matching archetype at the given map and coordinates. 1845 * a matching archetype at the given map and coordinates.
1954 * The first matching object is returned, or NULL if none. 1846 * The first matching object is returned, or NULL if none.
1955 */ 1847 */
1956
1957object * 1848object *
1958present_arch (const archetype *at, maptile *m, int x, int y) 1849present_arch (const archetype *at, maptile *m, int x, int y)
1959{ 1850{
1960 object *
1961 tmp;
1962
1963 if (m == NULL || out_of_map (m, x, y)) 1851 if (!m || out_of_map (m, x, y))
1964 { 1852 {
1965 LOG (llevError, "Present_arch called outside map.\n"); 1853 LOG (llevError, "Present_arch called outside map.\n");
1966 return NULL; 1854 return NULL;
1967 } 1855 }
1968 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1856
1857 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1969 if (tmp->arch == at) 1858 if (tmp->arch == at)
1970 return tmp; 1859 return tmp;
1860
1971 return NULL; 1861 return NULL;
1972} 1862}
1973 1863
1974/* 1864/*
1975 * present(type, map, x, y) searches for any objects with 1865 * present(type, map, x, y) searches for any objects with
1976 * a matching type variable at the given map and coordinates. 1866 * a matching type variable at the given map and coordinates.
1977 * The first matching object is returned, or NULL if none. 1867 * The first matching object is returned, or NULL if none.
1978 */ 1868 */
1979
1980object * 1869object *
1981present (unsigned char type, maptile *m, int x, int y) 1870present (unsigned char type, maptile *m, int x, int y)
1982{ 1871{
1983 object *
1984 tmp;
1985
1986 if (out_of_map (m, x, y)) 1872 if (out_of_map (m, x, y))
1987 { 1873 {
1988 LOG (llevError, "Present called outside map.\n"); 1874 LOG (llevError, "Present called outside map.\n");
1989 return NULL; 1875 return NULL;
1990 } 1876 }
1991 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1877
1878 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1992 if (tmp->type == type) 1879 if (tmp->type == type)
1993 return tmp; 1880 return tmp;
1881
1994 return NULL; 1882 return NULL;
1995} 1883}
1996 1884
1997/* 1885/*
1998 * present_in_ob(type, object) searches for any objects with 1886 * present_in_ob(type, object) searches for any objects with
1999 * a matching type variable in the inventory of the given object. 1887 * a matching type variable in the inventory of the given object.
2000 * The first matching object is returned, or NULL if none. 1888 * The first matching object is returned, or NULL if none.
2001 */ 1889 */
2002
2003object * 1890object *
2004present_in_ob (unsigned char type, const object *op) 1891present_in_ob (unsigned char type, const object *op)
2005{ 1892{
2006 object *
2007 tmp;
2008
2009 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1893 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2010 if (tmp->type == type) 1894 if (tmp->type == type)
2011 return tmp; 1895 return tmp;
1896
2012 return NULL; 1897 return NULL;
2013} 1898}
2014 1899
2015/* 1900/*
2016 * present_in_ob (type, str, object) searches for any objects with 1901 * present_in_ob (type, str, object) searches for any objects with
2024 * str is the string to match against. Note that we match against 1909 * str is the string to match against. Note that we match against
2025 * the object name, not the archetype name. this is so that the 1910 * the object name, not the archetype name. this is so that the
2026 * spell code can use one object type (force), but change it's name 1911 * spell code can use one object type (force), but change it's name
2027 * to be unique. 1912 * to be unique.
2028 */ 1913 */
2029
2030object * 1914object *
2031present_in_ob_by_name (int type, const char *str, const object *op) 1915present_in_ob_by_name (int type, const char *str, const object *op)
2032{ 1916{
2033 object *
2034 tmp;
2035
2036 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1917 for (object *tmp = op->inv; tmp; tmp = tmp->below)
2037 {
2038 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name))) 1918 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name)))
2039 return tmp; 1919 return tmp;
2040 } 1920
2041 return NULL; 1921 return 0;
2042} 1922}
2043 1923
2044/* 1924/*
2045 * present_arch_in_ob(archetype, object) searches for any objects with 1925 * present_arch_in_ob(archetype, object) searches for any objects with
2046 * a matching archetype in the inventory of the given object. 1926 * a matching archetype in the inventory of the given object.
2047 * The first matching object is returned, or NULL if none. 1927 * The first matching object is returned, or NULL if none.
2048 */ 1928 */
2049
2050object * 1929object *
2051present_arch_in_ob (const archetype *at, const object *op) 1930present_arch_in_ob (const archetype *at, const object *op)
2052{ 1931{
2053 object *
2054 tmp;
2055
2056 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1932 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2057 if (tmp->arch == at) 1933 if (tmp->arch == at)
2058 return tmp; 1934 return tmp;
1935
2059 return NULL; 1936 return NULL;
2060} 1937}
2061 1938
2062/* 1939/*
2063 * activate recursively a flag on an object inventory 1940 * activate recursively a flag on an object inventory
2064 */ 1941 */
2065void 1942void
2066flag_inv (object *op, int flag) 1943flag_inv (object *op, int flag)
2067{ 1944{
2068 object *
2069 tmp;
2070
2071 if (op->inv) 1945 if (op->inv)
2072 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1946 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2073 { 1947 {
2074 SET_FLAG (tmp, flag); 1948 SET_FLAG (tmp, flag);
2075 flag_inv (tmp, flag); 1949 flag_inv (tmp, flag);
2076 } 1950 }
2077} /* 1951}
1952
1953/*
2078 * desactivate recursively a flag on an object inventory 1954 * deactivate recursively a flag on an object inventory
2079 */ 1955 */
2080void 1956void
2081unflag_inv (object *op, int flag) 1957unflag_inv (object *op, int flag)
2082{ 1958{
2083 object *
2084 tmp;
2085
2086 if (op->inv) 1959 if (op->inv)
2087 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1960 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2088 { 1961 {
2089 CLEAR_FLAG (tmp, flag); 1962 CLEAR_FLAG (tmp, flag);
2090 unflag_inv (tmp, flag); 1963 unflag_inv (tmp, flag);
2091 } 1964 }
2092} 1965}
2095 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in 1968 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in
2096 * all it's inventory (recursively). 1969 * all it's inventory (recursively).
2097 * If checksums are used, a player will get set_cheat called for 1970 * If checksums are used, a player will get set_cheat called for
2098 * him/her-self and all object carried by a call to this function. 1971 * him/her-self and all object carried by a call to this function.
2099 */ 1972 */
2100
2101void 1973void
2102set_cheat (object *op) 1974set_cheat (object *op)
2103{ 1975{
2104 SET_FLAG (op, FLAG_WAS_WIZ); 1976 SET_FLAG (op, FLAG_WAS_WIZ);
2105 flag_inv (op, FLAG_WAS_WIZ); 1977 flag_inv (op, FLAG_WAS_WIZ);
2124 * because arch_blocked (now ob_blocked) needs to know the movement type 1996 * because arch_blocked (now ob_blocked) needs to know the movement type
2125 * to know if the space in question will block the object. We can't use 1997 * to know if the space in question will block the object. We can't use
2126 * the archetype because that isn't correct if the monster has been 1998 * the archetype because that isn't correct if the monster has been
2127 * customized, changed states, etc. 1999 * customized, changed states, etc.
2128 */ 2000 */
2129
2130int 2001int
2131find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop) 2002find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)
2132{ 2003{
2133 int
2134 i,
2135 index = 0, flag; 2004 int index = 0, flag;
2136 static int
2137 altern[SIZEOFFREE]; 2005 int altern[SIZEOFFREE];
2138 2006
2139 for (i = start; i < stop; i++) 2007 for (int i = start; i < stop; i++)
2140 { 2008 {
2141 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]); 2009 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]);
2142 if (!flag) 2010 if (!flag)
2143 altern[index++] = i; 2011 altern [index++] = i;
2144 2012
2145 /* Basically, if we find a wall on a space, we cut down the search size. 2013 /* Basically, if we find a wall on a space, we cut down the search size.
2146 * In this way, we won't return spaces that are on another side of a wall. 2014 * In this way, we won't return spaces that are on another side of a wall.
2147 * This mostly work, but it cuts down the search size in all directions - 2015 * This mostly work, but it cuts down the search size in all directions -
2148 * if the space being examined only has a wall to the north and empty 2016 * if the space being examined only has a wall to the north and empty
2149 * spaces in all the other directions, this will reduce the search space 2017 * spaces in all the other directions, this will reduce the search space
2150 * to only the spaces immediately surrounding the target area, and 2018 * to only the spaces immediately surrounding the target area, and
2151 * won't look 2 spaces south of the target space. 2019 * won't look 2 spaces south of the target space.
2152 */ 2020 */
2153 else if ((flag & AB_NO_PASS) && maxfree[i] < stop) 2021 else if ((flag & P_NO_PASS) && maxfree[i] < stop)
2154 stop = maxfree[i]; 2022 stop = maxfree[i];
2155 } 2023 }
2024
2156 if (!index) 2025 if (!index)
2157 return -1; 2026 return -1;
2027
2158 return altern[RANDOM () % index]; 2028 return altern [rndm (index)];
2159} 2029}
2160 2030
2161/* 2031/*
2162 * find_first_free_spot(archetype, maptile, x, y) works like 2032 * find_first_free_spot(archetype, maptile, x, y) works like
2163 * find_free_spot(), but it will search max number of squares. 2033 * find_free_spot(), but it will search max number of squares.
2164 * But it will return the first available spot, not a random choice. 2034 * But it will return the first available spot, not a random choice.
2165 * Changed 0.93.2: Have it return -1 if there is no free spot available. 2035 * Changed 0.93.2: Have it return -1 if there is no free spot available.
2166 */ 2036 */
2167
2168int 2037int
2169find_first_free_spot (const object *ob, maptile *m, int x, int y) 2038find_first_free_spot (const object *ob, maptile *m, int x, int y)
2170{ 2039{
2171 int
2172 i;
2173
2174 for (i = 0; i < SIZEOFFREE; i++) 2040 for (int i = 0; i < SIZEOFFREE; i++)
2175 {
2176 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i])) 2041 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]))
2177 return i; 2042 return i;
2178 } 2043
2179 return -1; 2044 return -1;
2180} 2045}
2181 2046
2182/* 2047/*
2183 * The function permute(arr, begin, end) randomly reorders the array 2048 * The function permute(arr, begin, end) randomly reorders the array
2184 * arr[begin..end-1]. 2049 * arr[begin..end-1].
2050 * now uses a fisher-yates shuffle, old permute was broken
2185 */ 2051 */
2186static void 2052static void
2187permute (int *arr, int begin, int end) 2053permute (int *arr, int begin, int end)
2188{ 2054{
2189 int 2055 arr += begin;
2190 i,
2191 j,
2192 tmp,
2193 len;
2194
2195 len = end - begin; 2056 end -= begin;
2196 for (i = begin; i < end; i++)
2197 {
2198 j = begin + RANDOM () % len;
2199 2057
2200 tmp = arr[i]; 2058 while (--end)
2201 arr[i] = arr[j]; 2059 swap (arr [end], arr [rndm (end + 1)]);
2202 arr[j] = tmp;
2203 }
2204} 2060}
2205 2061
2206/* new function to make monster searching more efficient, and effective! 2062/* new function to make monster searching more efficient, and effective!
2207 * This basically returns a randomized array (in the passed pointer) of 2063 * This basically returns a randomized array (in the passed pointer) of
2208 * the spaces to find monsters. In this way, it won't always look for 2064 * the spaces to find monsters. In this way, it won't always look for
2211 * the 3x3 area will be searched, just not in a predictable order. 2067 * the 3x3 area will be searched, just not in a predictable order.
2212 */ 2068 */
2213void 2069void
2214get_search_arr (int *search_arr) 2070get_search_arr (int *search_arr)
2215{ 2071{
2216 int 2072 int i;
2217 i;
2218 2073
2219 for (i = 0; i < SIZEOFFREE; i++) 2074 for (i = 0; i < SIZEOFFREE; i++)
2220 {
2221 search_arr[i] = i; 2075 search_arr[i] = i;
2222 }
2223 2076
2224 permute (search_arr, 1, SIZEOFFREE1 + 1); 2077 permute (search_arr, 1, SIZEOFFREE1 + 1);
2225 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1); 2078 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1);
2226 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE); 2079 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE);
2227} 2080}
2236 * Perhaps incorrectly, but I'm making the assumption that exclude 2089 * Perhaps incorrectly, but I'm making the assumption that exclude
2237 * is actually want is going to try and move there. We need this info 2090 * is actually want is going to try and move there. We need this info
2238 * because we have to know what movement the thing looking to move 2091 * because we have to know what movement the thing looking to move
2239 * there is capable of. 2092 * there is capable of.
2240 */ 2093 */
2241
2242int 2094int
2243find_dir (maptile *m, int x, int y, object *exclude) 2095find_dir (maptile *m, int x, int y, object *exclude)
2244{ 2096{
2245 int
2246 i,
2247 max = SIZEOFFREE, mflags; 2097 int i, max = SIZEOFFREE, mflags;
2248 2098
2249 sint16 nx, ny; 2099 sint16 nx, ny;
2250 object * 2100 object *tmp;
2251 tmp;
2252 maptile * 2101 maptile *mp;
2253 mp;
2254 2102
2255 MoveType blocked, move_type; 2103 MoveType blocked, move_type;
2256 2104
2257 if (exclude && exclude->head) 2105 if (exclude && exclude->head)
2258 { 2106 {
2270 mp = m; 2118 mp = m;
2271 nx = x + freearr_x[i]; 2119 nx = x + freearr_x[i];
2272 ny = y + freearr_y[i]; 2120 ny = y + freearr_y[i];
2273 2121
2274 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2122 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);
2123
2275 if (mflags & P_OUT_OF_MAP) 2124 if (mflags & P_OUT_OF_MAP)
2276 {
2277 max = maxfree[i]; 2125 max = maxfree[i];
2278 }
2279 else 2126 else
2280 { 2127 {
2281 blocked = GET_MAP_MOVE_BLOCK (mp, nx, ny); 2128 mapspace &ms = mp->at (nx, ny);
2129
2130 blocked = ms.move_block;
2282 2131
2283 if ((move_type & blocked) == move_type) 2132 if ((move_type & blocked) == move_type)
2284 {
2285 max = maxfree[i]; 2133 max = maxfree[i];
2286 }
2287 else if (mflags & P_IS_ALIVE) 2134 else if (mflags & P_IS_ALIVE)
2288 { 2135 {
2289 for (tmp = GET_MAP_OB (mp, nx, ny); tmp != NULL; tmp = tmp->above) 2136 for (tmp = ms.bot; tmp; tmp = tmp->above)
2290 { 2137 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)
2291 if ((QUERY_FLAG (tmp, FLAG_MONSTER) || tmp->type == PLAYER) && (tmp != exclude || (tmp->head && tmp->head != exclude))) 2138 && (tmp != exclude || (tmp->head && tmp->head != exclude)))
2292 {
2293 break; 2139 break;
2294 } 2140
2295 }
2296 if (tmp) 2141 if (tmp)
2297 {
2298 return freedir[i]; 2142 return freedir[i];
2299 }
2300 } 2143 }
2301 } 2144 }
2302 } 2145 }
2146
2303 return 0; 2147 return 0;
2304} 2148}
2305 2149
2306/* 2150/*
2307 * distance(object 1, object 2) will return the square of the 2151 * distance(object 1, object 2) will return the square of the
2308 * distance between the two given objects. 2152 * distance between the two given objects.
2309 */ 2153 */
2310
2311int 2154int
2312distance (const object *ob1, const object *ob2) 2155distance (const object *ob1, const object *ob2)
2313{ 2156{
2314 int
2315 i;
2316
2317 i = (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y); 2157 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2318 return i;
2319} 2158}
2320 2159
2321/* 2160/*
2322 * find_dir_2(delta-x,delta-y) will return a direction in which 2161 * find_dir_2(delta-x,delta-y) will return a direction in which
2323 * an object which has subtracted the x and y coordinates of another 2162 * an object which has subtracted the x and y coordinates of another
2324 * object, needs to travel toward it. 2163 * object, needs to travel toward it.
2325 */ 2164 */
2326
2327int 2165int
2328find_dir_2 (int x, int y) 2166find_dir_2 (int x, int y)
2329{ 2167{
2330 int 2168 int q;
2331 q;
2332 2169
2333 if (y) 2170 if (y)
2334 q = x * 100 / y; 2171 q = x * 100 / y;
2335 else if (x) 2172 else if (x)
2336 q = -300 * x; 2173 q = -300 * x;
2361 2198
2362 return 3; 2199 return 3;
2363} 2200}
2364 2201
2365/* 2202/*
2366 * absdir(int): Returns a number between 1 and 8, which represent
2367 * the "absolute" direction of a number (it actually takes care of
2368 * "overflow" in previous calculations of a direction).
2369 */
2370
2371int
2372absdir (int d)
2373{
2374 while (d < 1)
2375 d += 8;
2376 while (d > 8)
2377 d -= 8;
2378 return d;
2379}
2380
2381/*
2382 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is 2203 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is
2383 * between two directions (which are expected to be absolute (see absdir()) 2204 * between two directions (which are expected to be absolute (see absdir())
2384 */ 2205 */
2385
2386int 2206int
2387dirdiff (int dir1, int dir2) 2207dirdiff (int dir1, int dir2)
2388{ 2208{
2389 int 2209 int d;
2390 d;
2391 2210
2392 d = abs (dir1 - dir2); 2211 d = abs (dir1 - dir2);
2393 if (d > 4) 2212 if (d > 4)
2394 d = 8 - d; 2213 d = 8 - d;
2214
2395 return d; 2215 return d;
2396} 2216}
2397 2217
2398/* peterm: 2218/* peterm:
2399 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster. 2219 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster.
2402 * This basically means that if direction is 15, then it could either go 2222 * This basically means that if direction is 15, then it could either go
2403 * direction 4, 14, or 16 to get back to where we are. 2223 * direction 4, 14, or 16 to get back to where we are.
2404 * Moved from spell_util.c to object.c with the other related direction 2224 * Moved from spell_util.c to object.c with the other related direction
2405 * functions. 2225 * functions.
2406 */ 2226 */
2407
2408int
2409 reduction_dir[SIZEOFFREE][3] = { 2227int reduction_dir[SIZEOFFREE][3] = {
2410 {0, 0, 0}, /* 0 */ 2228 {0, 0, 0}, /* 0 */
2411 {0, 0, 0}, /* 1 */ 2229 {0, 0, 0}, /* 1 */
2412 {0, 0, 0}, /* 2 */ 2230 {0, 0, 0}, /* 2 */
2413 {0, 0, 0}, /* 3 */ 2231 {0, 0, 0}, /* 3 */
2414 {0, 0, 0}, /* 4 */ 2232 {0, 0, 0}, /* 4 */
2462 * find a path to that monster that we found. If not, 2280 * find a path to that monster that we found. If not,
2463 * we don't bother going toward it. Returns 1 if we 2281 * we don't bother going toward it. Returns 1 if we
2464 * can see a direct way to get it 2282 * can see a direct way to get it
2465 * Modified to be map tile aware -.MSW 2283 * Modified to be map tile aware -.MSW
2466 */ 2284 */
2467
2468
2469int 2285int
2470can_see_monsterP (maptile *m, int x, int y, int dir) 2286can_see_monsterP (maptile *m, int x, int y, int dir)
2471{ 2287{
2472 sint16 dx, dy; 2288 sint16 dx, dy;
2473 int
2474 mflags; 2289 int mflags;
2475 2290
2476 if (dir < 0) 2291 if (dir < 0)
2477 return 0; /* exit condition: invalid direction */ 2292 return 0; /* exit condition: invalid direction */
2478 2293
2479 dx = x + freearr_x[dir]; 2294 dx = x + freearr_x[dir];
2492 return 0; 2307 return 0;
2493 2308
2494 /* yes, can see. */ 2309 /* yes, can see. */
2495 if (dir < 9) 2310 if (dir < 9)
2496 return 1; 2311 return 1;
2312
2497 return can_see_monsterP (m, x, y, reduction_dir[dir][0]) | 2313 return can_see_monsterP (m, x, y, reduction_dir[dir][0])
2498 can_see_monsterP (m, x, y, reduction_dir[dir][1]) | can_see_monsterP (m, x, y, reduction_dir[dir][2]); 2314 | can_see_monsterP (m, x, y, reduction_dir[dir][1])
2315 | can_see_monsterP (m, x, y, reduction_dir[dir][2]);
2499} 2316}
2500
2501
2502 2317
2503/* 2318/*
2504 * can_pick(picker, item): finds out if an object is possible to be 2319 * can_pick(picker, item): finds out if an object is possible to be
2505 * picked up by the picker. Returnes 1 if it can be 2320 * picked up by the picker. Returnes 1 if it can be
2506 * picked up, otherwise 0. 2321 * picked up, otherwise 0.
2517 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2332 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2518 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2333 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2519 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2334 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));
2520} 2335}
2521 2336
2522
2523/* 2337/*
2524 * create clone from object to another 2338 * create clone from object to another
2525 */ 2339 */
2526object * 2340object *
2527object_create_clone (object *asrc) 2341object_create_clone (object *asrc)
2536 src = src->head; 2350 src = src->head;
2537 2351
2538 prev = 0; 2352 prev = 0;
2539 for (part = src; part; part = part->more) 2353 for (part = src; part; part = part->more)
2540 { 2354 {
2541 tmp = get_object (); 2355 tmp = part->clone ();
2542 copy_object (part, tmp);
2543 tmp->x -= src->x; 2356 tmp->x -= src->x;
2544 tmp->y -= src->y; 2357 tmp->y -= src->y;
2545 2358
2546 if (!part->head) 2359 if (!part->head)
2547 { 2360 {
2548 dst = tmp; 2361 dst = tmp;
2549 tmp->head = 0; 2362 tmp->head = 0;
2550 } 2363 }
2551 else 2364 else
2552 {
2553 tmp->head = dst; 2365 tmp->head = dst;
2554 }
2555 2366
2556 tmp->more = 0; 2367 tmp->more = 0;
2557 2368
2558 if (prev) 2369 if (prev)
2559 prev->more = tmp; 2370 prev->more = tmp;
2563 2374
2564 for (item = src->inv; item; item = item->below) 2375 for (item = src->inv; item; item = item->below)
2565 insert_ob_in_ob (object_create_clone (item), dst); 2376 insert_ob_in_ob (object_create_clone (item), dst);
2566 2377
2567 return dst; 2378 return dst;
2568}
2569
2570/* GROS - Creates an object using a string representing its content. */
2571/* Basically, we save the content of the string to a temp file, then call */
2572/* load_object on it. I admit it is a highly inefficient way to make things, */
2573/* but it was simple to make and allows reusing the load_object function. */
2574/* Remember not to use load_object_str in a time-critical situation. */
2575/* Also remember that multiparts objects are not supported for now. */
2576
2577object *
2578load_object_str (const char *obstr)
2579{
2580 object *op;
2581 char filename[MAX_BUF];
2582
2583 sprintf (filename, "%s/cfloadobstr2044", settings.tmpdir);
2584
2585 FILE *tempfile = fopen (filename, "w");
2586
2587 if (tempfile == NULL)
2588 {
2589 LOG (llevError, "Error - Unable to access load object temp file\n");
2590 return NULL;
2591 }
2592
2593 fprintf (tempfile, obstr);
2594 fclose (tempfile);
2595
2596 op = get_object ();
2597
2598 object_thawer thawer (filename);
2599
2600 if (thawer)
2601 load_object (thawer, op, 0);
2602
2603 LOG (llevDebug, " load str completed, object=%s\n", &op->name);
2604 CLEAR_FLAG (op, FLAG_REMOVED);
2605
2606 return op;
2607} 2379}
2608 2380
2609/* This returns the first object in who's inventory that 2381/* This returns the first object in who's inventory that
2610 * has the same type and subtype match. 2382 * has the same type and subtype match.
2611 * returns NULL if no match. 2383 * returns NULL if no match.
2612 */ 2384 */
2613object * 2385object *
2614find_obj_by_type_subtype (const object *who, int type, int subtype) 2386find_obj_by_type_subtype (const object *who, int type, int subtype)
2615{ 2387{
2616 object *tmp;
2617
2618 for (tmp = who->inv; tmp; tmp = tmp->below) 2388 for (object *tmp = who->inv; tmp; tmp = tmp->below)
2619 if (tmp->type == type && tmp->subtype == subtype) 2389 if (tmp->type == type && tmp->subtype == subtype)
2620 return tmp; 2390 return tmp;
2621 2391
2622 return NULL; 2392 return 0;
2623} 2393}
2624 2394
2625/* If ob has a field named key, return the link from the list, 2395/* If ob has a field named key, return the link from the list,
2626 * otherwise return NULL. 2396 * otherwise return NULL.
2627 * 2397 *
2629 * do the desired thing. 2399 * do the desired thing.
2630 */ 2400 */
2631key_value * 2401key_value *
2632get_ob_key_link (const object *ob, const char *key) 2402get_ob_key_link (const object *ob, const char *key)
2633{ 2403{
2634 key_value *link;
2635
2636 for (link = ob->key_values; link != NULL; link = link->next) 2404 for (key_value *link = ob->key_values; link; link = link->next)
2637 if (link->key == key) 2405 if (link->key == key)
2638 return link; 2406 return link;
2639 2407
2640 return NULL; 2408 return 0;
2641} 2409}
2642 2410
2643/* 2411/*
2644 * Returns the value of op has an extra_field for key, or NULL. 2412 * Returns the value of op has an extra_field for key, or NULL.
2645 * 2413 *
2670 if (link->key == canonical_key) 2438 if (link->key == canonical_key)
2671 return link->value; 2439 return link->value;
2672 2440
2673 return 0; 2441 return 0;
2674} 2442}
2675
2676 2443
2677/* 2444/*
2678 * Updates the canonical_key in op to value. 2445 * Updates the canonical_key in op to value.
2679 * 2446 *
2680 * canonical_key is a shared string (value doesn't have to be). 2447 * canonical_key is a shared string (value doesn't have to be).
2685 * Returns TRUE on success. 2452 * Returns TRUE on success.
2686 */ 2453 */
2687int 2454int
2688set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key) 2455set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2689{ 2456{
2690 key_value *
2691 field = NULL, *last = NULL; 2457 key_value *field = NULL, *last = NULL;
2692 2458
2693 for (field = op->key_values; field != NULL; field = field->next) 2459 for (field = op->key_values; field != NULL; field = field->next)
2694 { 2460 {
2695 if (field->key != canonical_key) 2461 if (field->key != canonical_key)
2696 { 2462 {
2724 /* IF we get here, key doesn't exist */ 2490 /* IF we get here, key doesn't exist */
2725 2491
2726 /* No field, we'll have to add it. */ 2492 /* No field, we'll have to add it. */
2727 2493
2728 if (!add_key) 2494 if (!add_key)
2729 {
2730 return FALSE; 2495 return FALSE;
2731 } 2496
2732 /* There isn't any good reason to store a null 2497 /* There isn't any good reason to store a null
2733 * value in the key/value list. If the archetype has 2498 * value in the key/value list. If the archetype has
2734 * this key, then we should also have it, so shouldn't 2499 * this key, then we should also have it, so shouldn't
2735 * be here. If user wants to store empty strings, 2500 * be here. If user wants to store empty strings,
2736 * should pass in "" 2501 * should pass in ""
2785 } 2550 }
2786 else 2551 else
2787 item = item->env; 2552 item = item->env;
2788} 2553}
2789 2554
2555
2556const char *
2557object::flag_desc (char *desc, int len) const
2558{
2559 char *p = desc;
2560 bool first = true;
2561
2562 *p = 0;
2563
2564 for (int i = 0; i < NUM_FLAGS; i++)
2565 {
2566 if (len <= 10) // magic constant!
2567 {
2568 snprintf (p, len, ",...");
2569 break;
2570 }
2571
2572 if (flag [i])
2573 {
2574 int cnt = snprintf (p, len, "%s%d", first ? "" : ",", i);
2575 len -= cnt;
2576 p += cnt;
2577 first = false;
2578 }
2579 }
2580
2581 return desc;
2582}
2583
2790// return a suitable string describing an objetc in enough detail to find it 2584// return a suitable string describing an object in enough detail to find it
2791const char * 2585const char *
2792object::debug_desc (char *info) const 2586object::debug_desc (char *info) const
2793{ 2587{
2588 char flagdesc[512];
2794 char info2[256 * 3]; 2589 char info2[256 * 4];
2795 char *p = info; 2590 char *p = info;
2796 2591
2797 p += snprintf (p, 256, "%d=\"%s%s%s\"", 2592 p += snprintf (p, 512, "{cnt:%d,uuid:<1.%" PRIx64 ">,name:\"%s\"%s%s,flags:[%s],type:%d}",
2798 count, 2593 count, uuid.seq,
2799 &name, 2594 &name,
2800 title ? " " : "", 2595 title ? "\",title:\"" : "",
2801 title ? (const char *)title : ""); 2596 title ? (const char *)title : "",
2597 flag_desc (flagdesc, 512), type);
2802 2598
2803 if (env) 2599 if (env)
2804 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2600 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2805 2601
2806 if (map) 2602 if (map)
2807 p += snprintf (p, 256, "(on %s@%d+%d)", map->path, x, y); 2603 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2808 2604
2809 return info; 2605 return info;
2810} 2606}
2811 2607
2812const char * 2608const char *
2813object::debug_desc () const 2609object::debug_desc () const
2814{ 2610{
2815 static char info[256 * 3]; 2611 static char info[3][256 * 4];
2612 static int info_idx;
2613
2816 return debug_desc (info); 2614 return debug_desc (info [++info_idx % 3]);
2817} 2615}
2818 2616
2617struct region *
2618object::region () const
2619{
2620 return map ? map->region (x, y)
2621 : region::default_region ();
2622}
2623
2624const materialtype_t *
2625object::dominant_material () const
2626{
2627 if (materialtype_t *mat = name_to_material (materialname))
2628 return mat;
2629
2630 // omfg this is slow, this has to be temporary :)
2631 shstr unknown ("unknown");
2632
2633 return name_to_material (unknown);
2634}
2635
2636void
2637object::open_container (object *new_container)
2638{
2639 if (container == new_container)
2640 return;
2641
2642 if (object *old_container = container)
2643 {
2644 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))
2645 return;
2646
2647#if 0
2648 // remove the "Close old_container" object.
2649 if (object *closer = old_container->inv)
2650 if (closer->type == CLOSE_CON)
2651 closer->destroy ();
2652#endif
2653
2654 old_container->flag [FLAG_APPLIED] = 0;
2655 container = 0;
2656
2657 esrv_update_item (UPD_FLAGS, this, old_container);
2658 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container));
2659 }
2660
2661 if (new_container)
2662 {
2663 if (INVOKE_OBJECT (OPEN, new_container, ARG_OBJECT (this)))
2664 return;
2665
2666 // TODO: this does not seem to serve any purpose anymore?
2667#if 0
2668 // insert the "Close Container" object.
2669 if (archetype *closer = new_container->other_arch)
2670 {
2671 object *closer = arch_to_object (new_container->other_arch);
2672 closer->flag [FLAG_NO_MAP_SAVE] = 1;
2673 new_container->insert (closer);
2674 }
2675#endif
2676
2677 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container));
2678
2679 new_container->flag [FLAG_APPLIED] = 1;
2680 container = new_container;
2681
2682 esrv_update_item (UPD_FLAGS, this, new_container);
2683 esrv_send_inventory (this, new_container);
2684 }
2685}
2686
2687

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines