ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.57 by root, Sun Dec 3 02:46:33 2006 UTC vs.
Revision 1.147 by root, Sat May 12 16:06:42 2007 UTC

1/* 1/*
2 CrossFire, A Multiplayer game for X-windows 2 * CrossFire, A Multiplayer game
3 3 *
4 * Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team
4 Copyright (C) 2001 Mark Wedel & Crossfire Development Team 5 * Copyright (C) 2001 Mark Wedel & Crossfire Development Team
5 Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (C) 1992 Frank Tore Johansen
6 7 *
7 This program is free software; you can redistribute it and/or modify 8 * This program is free software; you can redistribute it and/or modify
8 it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
9 the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation; either version 2 of the License, or
10 (at your option) any later version. 11 * (at your option) any later version.
11 12 *
12 This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
13 but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 GNU General Public License for more details. 16 * GNU General Public License for more details.
16 17 *
17 You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
18 along with this program; if not, write to the Free Software 19 * along with this program; if not, write to the Free Software
19 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
20 21 *
21 The authors can be reached via e-mail at <crossfire@schmorp.de> 22 * The authors can be reached via e-mail at <crossfire@schmorp.de>
22*/ 23 */
23 24
24/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects. 25/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
25 sub/add_weight will transcend the environment updating the carrying 26 sub/add_weight will transcend the environment updating the carrying
26 variable. */ 27 variable. */
27#include <global.h> 28#include <global.h>
28#include <stdio.h> 29#include <stdio.h>
29#include <sys/types.h> 30#include <sys/types.h>
30#include <sys/uio.h> 31#include <sys/uio.h>
31#include <object.h> 32#include <object.h>
32#include <funcpoint.h> 33#include <funcpoint.h>
34#include <sproto.h>
33#include <loader.h> 35#include <loader.h>
36
37#include <bitset>
34 38
35int nrofallocobjects = 0; 39int nrofallocobjects = 0;
36static UUID uuid; 40static UUID uuid;
37const uint64 UUID_SKIP = 1<<19; 41const uint64 UUID_SKIP = 1<<19;
38 42
39object *active_objects; /* List of active objects that need to be processed */ 43objectvec objects;
44activevec actives;
40 45
41short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 46short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
42 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1 47 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1
43}; 48};
44short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, 49short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
… …
104 _exit (1); 109 _exit (1);
105 } 110 }
106 111
107 uuid.seq = uid; 112 uuid.seq = uid;
108 write_uuid (); 113 write_uuid ();
109 LOG (llevDebug, "read UID: %lld\n", uid); 114 LOG (llevDebug, "read UID: %" PRId64 "\n", uid);
110 fclose (fp); 115 fclose (fp);
111} 116}
112 117
113UUID 118UUID
114gen_uuid () 119gen_uuid ()
… …
139 * objects with lists are rare, and lists stay short. If not, use a 144 * objects with lists are rare, and lists stay short. If not, use a
140 * different structure or at least keep the lists sorted... 145 * different structure or at least keep the lists sorted...
141 */ 146 */
142 147
143 /* For each field in wants, */ 148 /* For each field in wants, */
144 for (wants_field = wants->key_values; wants_field != NULL; wants_field = wants_field->next) 149 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)
145 { 150 {
146 key_value *has_field; 151 key_value *has_field;
147 152
148 /* Look for a field in has with the same key. */ 153 /* Look for a field in has with the same key. */
149 has_field = get_ob_key_link (has, wants_field->key); 154 has_field = get_ob_key_link (has, wants_field->key);
… …
183 * 188 *
184 * Note that this function appears a lot longer than the macro it 189 * Note that this function appears a lot longer than the macro it
185 * replaces - this is mostly for clarity - a decent compiler should hopefully 190 * replaces - this is mostly for clarity - a decent compiler should hopefully
186 * reduce this to the same efficiency. 191 * reduce this to the same efficiency.
187 * 192 *
188 * Check nrof variable *before* calling CAN_MERGE() 193 * Check nrof variable *before* calling can_merge()
189 * 194 *
190 * Improvements made with merge: Better checking on potion, and also 195 * Improvements made with merge: Better checking on potion, and also
191 * check weight 196 * check weight
192 */ 197 */
193
194bool object::can_merge (object *ob1, object *ob2) 198bool object::can_merge_slow (object *ob1, object *ob2)
195{ 199{
196 /* A couple quicksanity checks */ 200 /* A couple quicksanity checks */
197 if ((ob1 == ob2) || (ob1->type != ob2->type)) 201 if (ob1 == ob2
202 || ob1->type != ob2->type
203 || ob1->speed != ob2->speed
204 || ob1->value != ob2->value
205 || ob1->name != ob2->name)
198 return 0; 206 return 0;
199 207
200 if (ob1->speed != ob2->speed) 208 //TODO: this ain't working well, use nicer and correct overflow check
201 return 0;
202
203 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that 209 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that
204 * value could not be stored in a sint32 (which unfortunately sometimes is 210 * value could not be stored in a sint32 (which unfortunately sometimes is
205 * used to store nrof). 211 * used to store nrof).
206 */ 212 */
207 if (ob1->nrof + ob2->nrof >= 1UL << 31) 213 if (ob1->nrof + ob2->nrof >= 1UL << 31)
… …
217 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 223 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
218 224
219 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 225 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
220 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 226 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
221 227
222 228 if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any ()
223 /* the 0x400000 on flags2 is FLAG_INV_LOCK. I don't think something 229 || ob1->arch != ob2->arch
224 * being locked in inventory should prevent merging.
225 * 0x4 in flags3 is CLIENT_SENT
226 */
227 if ((ob1->arch != ob2->arch) ||
228 (ob1->flags[0] != ob2->flags[0]) ||
229 (ob1->flags[1] != ob2->flags[1]) ||
230 ((ob1->flags[2] & ~0x400000) != (ob2->flags[2] & ~0x400000)) ||
231 ((ob1->flags[3] & ~0x4) != (ob2->flags[3] & ~0x4)) ||
232 (ob1->name != ob2->name) || 230 || ob1->name != ob2->name
233 (ob1->title != ob2->title) || 231 || ob1->title != ob2->title
234 (ob1->msg != ob2->msg) || 232 || ob1->msg != ob2->msg
235 (ob1->weight != ob2->weight) || 233 || ob1->weight != ob2->weight
236 (memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist)) != 0) || 234 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
237 (memcmp (&ob1->stats, &ob2->stats, sizeof (ob1->stats)) != 0) || 235 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
238 (ob1->attacktype != ob2->attacktype) || 236 || ob1->attacktype != ob2->attacktype
239 (ob1->magic != ob2->magic) || 237 || ob1->magic != ob2->magic
240 (ob1->slaying != ob2->slaying) || 238 || ob1->slaying != ob2->slaying
241 (ob1->skill != ob2->skill) || 239 || ob1->skill != ob2->skill
242 (ob1->value != ob2->value) || 240 || ob1->value != ob2->value
243 (ob1->animation_id != ob2->animation_id) || 241 || ob1->animation_id != ob2->animation_id
244 (ob1->client_type != ob2->client_type) || 242 || ob1->client_type != ob2->client_type
245 (ob1->materialname != ob2->materialname) || 243 || ob1->materialname != ob2->materialname
246 (ob1->lore != ob2->lore) || 244 || ob1->lore != ob2->lore
247 (ob1->subtype != ob2->subtype) || 245 || ob1->subtype != ob2->subtype
248 (ob1->move_type != ob2->move_type) || 246 || ob1->move_type != ob2->move_type
249 (ob1->move_block != ob2->move_block) || 247 || ob1->move_block != ob2->move_block
250 (ob1->move_allow != ob2->move_allow) || 248 || ob1->move_allow != ob2->move_allow
251 (ob1->move_on != ob2->move_on) || 249 || ob1->move_on != ob2->move_on
252 (ob1->move_off != ob2->move_off) || (ob1->move_slow != ob2->move_slow) || (ob1->move_slow_penalty != ob2->move_slow_penalty)) 250 || ob1->move_off != ob2->move_off
251 || ob1->move_slow != ob2->move_slow
252 || ob1->move_slow_penalty != ob2->move_slow_penalty)
253 return 0; 253 return 0;
254 254
255 /* This is really a spellbook check - really, we should 255 /* This is really a spellbook check - really, we should
256 * check all objects in the inventory. 256 * check all objects in the inventory.
257 */ 257 */
… …
260 /* if one object has inventory but the other doesn't, not equiv */ 260 /* if one object has inventory but the other doesn't, not equiv */
261 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv)) 261 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv))
262 return 0; 262 return 0;
263 263
264 /* Now check to see if the two inventory objects could merge */ 264 /* Now check to see if the two inventory objects could merge */
265 if (!CAN_MERGE (ob1->inv, ob2->inv)) 265 if (!object::can_merge (ob1->inv, ob2->inv))
266 return 0; 266 return 0;
267 267
268 /* inventory ok - still need to check rest of this object to see 268 /* inventory ok - still need to check rest of this object to see
269 * if it is valid. 269 * if it is valid.
270 */ 270 */
… …
279 279
280 /* Note sure why the following is the case - either the object has to 280 /* Note sure why the following is the case - either the object has to
281 * be animated or have a very low speed. Is this an attempted monster 281 * be animated or have a very low speed. Is this an attempted monster
282 * check? 282 * check?
283 */ 283 */
284 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && FABS ((ob1)->speed) > MIN_ACTIVE_SPEED) 284 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && ob1->has_active_speed ())
285 return 0; 285 return 0;
286 286
287 switch (ob1->type) 287 switch (ob1->type)
288 { 288 {
289 case SCROLL: 289 case SCROLL:
… …
325sum_weight (object *op) 325sum_weight (object *op)
326{ 326{
327 long sum; 327 long sum;
328 object *inv; 328 object *inv;
329 329
330 for (sum = 0, inv = op->inv; inv != NULL; inv = inv->below) 330 for (sum = 0, inv = op->inv; inv; inv = inv->below)
331 { 331 {
332 if (inv->inv) 332 if (inv->inv)
333 sum_weight (inv); 333 sum_weight (inv);
334
334 sum += inv->carrying + inv->weight * (inv->nrof ? inv->nrof : 1); 335 sum += inv->carrying + inv->weight * (inv->nrof ? inv->nrof : 1);
335 } 336 }
336 337
337 if (op->type == CONTAINER && op->stats.Str) 338 if (op->type == CONTAINER && op->stats.Str)
338 sum = (sum * (100 - op->stats.Str)) / 100; 339 sum = (sum * (100 - op->stats.Str)) / 100;
… …
354 op = op->env; 355 op = op->env;
355 return op; 356 return op;
356} 357}
357 358
358/* 359/*
359 * Eneq(@csd.uu.se): Since we can have items buried in a character we need
360 * a better check. We basically keeping traversing up until we can't
361 * or find a player.
362 */
363
364object *
365is_player_inv (object *op)
366{
367 for (; op != NULL && op->type != PLAYER; op = op->env)
368 if (op->env == op)
369 op->env = NULL;
370 return op;
371}
372
373/*
374 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump. 360 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
375 * Some error messages. 361 * Some error messages.
376 * The result of the dump is stored in the static global errmsg array. 362 * The result of the dump is stored in the static global errmsg array.
377 */ 363 */
378
379char * 364char *
380dump_object (object *op) 365dump_object (object *op)
381{ 366{
382 if (!op) 367 if (!op)
383 return strdup ("[NULLOBJ]"); 368 return strdup ("[NULLOBJ]");
384 369
385 object_freezer freezer; 370 object_freezer freezer;
386 save_object (freezer, op, 3); 371 op->write (freezer);
387 return freezer.as_string (); 372 return freezer.as_string ();
388} 373}
389 374
390/* 375/*
391 * get_nearest_part(multi-object, object 2) returns the part of the 376 * get_nearest_part(multi-object, object 2) returns the part of the
… …
408} 393}
409 394
410/* 395/*
411 * Returns the object which has the count-variable equal to the argument. 396 * Returns the object which has the count-variable equal to the argument.
412 */ 397 */
413
414object * 398object *
415find_object (tag_t i) 399find_object (tag_t i)
416{ 400{
417 for (object *op = object::first; op; op = op->next) 401 for_all_objects (op)
418 if (op->count == i) 402 if (op->count == i)
419 return op; 403 return op;
420 404
421 return 0; 405 return 0;
422} 406}
423 407
424/* 408/*
425 * Returns the first object which has a name equal to the argument. 409 * Returns the first object which has a name equal to the argument.
426 * Used only by the patch command, but not all that useful. 410 * Used only by the patch command, but not all that useful.
427 * Enables features like "patch <name-of-other-player> food 999" 411 * Enables features like "patch <name-of-other-player> food 999"
428 */ 412 */
429
430object * 413object *
431find_object_name (const char *str) 414find_object_name (const char *str)
432{ 415{
433 shstr_cmp str_ (str); 416 shstr_cmp str_ (str);
434 object *op; 417 object *op;
435 418
436 for (op = object::first; op != NULL; op = op->next) 419 for_all_objects (op)
437 if (op->name == str_) 420 if (op->name == str_)
438 break; 421 break;
439 422
440 return op; 423 return op;
441} 424}
… …
467 owner = owner->owner; 450 owner = owner->owner;
468 451
469 this->owner = owner; 452 this->owner = owner;
470} 453}
471 454
455bool
456object::change_weapon (object *ob)
457{
458 if (current_weapon == ob)
459 return true;
460
461 if (chosen_skill)
462 chosen_skill->flag [FLAG_APPLIED] = false;
463
464 current_weapon = ob;
465 chosen_skill = !ob || ob->type == SKILL ? ob : find_skill_by_name (this, ob->skill);
466
467 if (chosen_skill)
468 chosen_skill->flag [FLAG_APPLIED] = true;
469
470 update_stats ();
471
472 if (ob)
473 {
474 // now check wether any body locations became invalid, in which case
475 // we cannot apply the weapon at the moment.
476 for (int i = 0; i < NUM_BODY_LOCATIONS; ++i)
477 if (slot[i].used < 0)
478 {
479 current_weapon = chosen_skill = 0;
480 update_stats ();
481
482 new_draw_info_format (NDI_UNIQUE, 0, this,
483 "You try to balance your applied items all at once, but the %s is too much. "
484 "You need to unapply some items first.", &ob->name);
485 return false;
486 }
487
488 new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name);
489 }
490 else
491 new_draw_info_format (NDI_UNIQUE, 0, this, "You unwield your weapons.");
492
493 return true;
494}
495
472/* Zero the key_values on op, decrementing the shared-string 496/* Zero the key_values on op, decrementing the shared-string
473 * refcounts and freeing the links. 497 * refcounts and freeing the links.
474 */ 498 */
475static void 499static void
476free_key_values (object *op) 500free_key_values (object *op)
477{ 501{
478 for (key_value *i = op->key_values; i != 0;) 502 for (key_value *i = op->key_values; i; )
479 { 503 {
480 key_value *next = i->next; 504 key_value *next = i->next;
481 delete i; 505 delete i;
482 506
483 i = next; 507 i = next;
484 } 508 }
485 509
486 op->key_values = 0; 510 op->key_values = 0;
487} 511}
488 512
489void object::clear () 513object &
514object::operator =(const object &src)
490{ 515{
491 attachable_base::clear (); 516 bool is_freed = flag [FLAG_FREED];
517 bool is_removed = flag [FLAG_REMOVED];
492 518
493 free_key_values (this); 519 *(object_copy *)this = src;
494 520
495 owner = 0; 521 flag [FLAG_FREED] = is_freed;
496 name = 0; 522 flag [FLAG_REMOVED] = is_removed;
497 name_pl = 0;
498 title = 0;
499 race = 0;
500 slaying = 0;
501 skill = 0;
502 msg = 0;
503 lore = 0;
504 custom_name = 0;
505 materialname = 0;
506 contr = 0;
507 below = 0;
508 above = 0;
509 inv = 0;
510 container = 0;
511 env = 0;
512 more = 0;
513 head = 0;
514 map = 0;
515 active_next = 0;
516 active_prev = 0;
517
518 memset (static_cast<object_pod *>(this), 0, sizeof (object_pod));
519
520 SET_FLAG (this, FLAG_REMOVED);
521
522 /* What is not cleared is next, prev, and count */
523
524 expmul = 1.0;
525 face = blank_face;
526
527 if (settings.casting_time)
528 casting_time = -1;
529}
530
531void object::clone (object *destination)
532{
533 *(object_copy *)destination = *this;
534 *(object_pod *)destination = *this;
535
536 if (self || cb)
537 INVOKE_OBJECT (CLONE, this, ARG_OBJECT (destination));
538}
539
540/*
541 * copy object first frees everything allocated by the second object,
542 * and then copies the contends of the first object into the second
543 * object, allocating what needs to be allocated. Basically, any
544 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
545 * if the first object is freed, the pointers in the new object
546 * will point at garbage.
547 */
548void
549copy_object (object *op2, object *op)
550{
551 bool is_freed = QUERY_FLAG (op, FLAG_FREED);
552 bool is_removed = QUERY_FLAG (op, FLAG_REMOVED);
553
554 op2->clone (op);
555
556 if (is_freed)
557 SET_FLAG (op, FLAG_FREED);
558 if (is_removed)
559 SET_FLAG (op, FLAG_REMOVED);
560
561 if (op2->speed < 0)
562 op->speed_left = op2->speed_left - RANDOM () % 200 / 100.0;
563 523
564 /* Copy over key_values, if any. */ 524 /* Copy over key_values, if any. */
565 if (op2->key_values) 525 if (src.key_values)
566 { 526 {
567 key_value *tail = 0; 527 key_value *tail = 0;
568 key_value *i;
569
570 op->key_values = 0; 528 key_values = 0;
571 529
572 for (i = op2->key_values; i; i = i->next) 530 for (key_value *i = src.key_values; i; i = i->next)
573 { 531 {
574 key_value *new_link = new key_value; 532 key_value *new_link = new key_value;
575 533
576 new_link->next = 0; 534 new_link->next = 0;
577 new_link->key = i->key; 535 new_link->key = i->key;
578 new_link->value = i->value; 536 new_link->value = i->value;
579 537
580 /* Try and be clever here, too. */ 538 /* Try and be clever here, too. */
581 if (!op->key_values) 539 if (!key_values)
582 { 540 {
583 op->key_values = new_link; 541 key_values = new_link;
584 tail = new_link; 542 tail = new_link;
585 } 543 }
586 else 544 else
587 { 545 {
588 tail->next = new_link; 546 tail->next = new_link;
589 tail = new_link; 547 tail = new_link;
590 } 548 }
591 } 549 }
592 } 550 }
551}
593 552
594 update_ob_speed (op); 553/*
554 * copy_to first frees everything allocated by the dst object,
555 * and then copies the contents of itself into the second
556 * object, allocating what needs to be allocated. Basically, any
557 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
558 * if the first object is freed, the pointers in the new object
559 * will point at garbage.
560 */
561void
562object::copy_to (object *dst)
563{
564 *dst = *this;
565
566 if (speed < 0)
567 dst->speed_left = speed_left - rndm ();
568
569 dst->set_speed (dst->speed);
570}
571
572void
573object::instantiate ()
574{
575 if (!uuid.seq) // HACK
576 uuid = gen_uuid ();
577
578 speed_left = -0.1f;
579 /* copy the body_info to the body_used - this is only really
580 * need for monsters, but doesn't hurt to do it for everything.
581 * by doing so, when a monster is created, it has good starting
582 * values for the body_used info, so when items are created
583 * for it, they can be properly equipped.
584 */
585 for (int i = NUM_BODY_LOCATIONS; i--; )
586 slot[i].used = slot[i].info;
587
588 attachable::instantiate ();
589}
590
591object *
592object::clone ()
593{
594 object *neu = create ();
595 copy_to (neu);
596 return neu;
595} 597}
596 598
597/* 599/*
598 * If an object with the IS_TURNABLE() flag needs to be turned due 600 * If an object with the IS_TURNABLE() flag needs to be turned due
599 * to the closest player being on the other side, this function can 601 * to the closest player being on the other side, this function can
600 * be called to update the face variable, _and_ how it looks on the map. 602 * be called to update the face variable, _and_ how it looks on the map.
601 */ 603 */
602
603void 604void
604update_turn_face (object *op) 605update_turn_face (object *op)
605{ 606{
606 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || op->arch == NULL) 607 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || !op->arch)
607 return; 608 return;
609
608 SET_ANIMATION (op, op->direction); 610 SET_ANIMATION (op, op->direction);
609 update_object (op, UP_OBJ_FACE); 611 update_object (op, UP_OBJ_FACE);
610} 612}
611 613
612/* 614/*
613 * Updates the speed of an object. If the speed changes from 0 to another 615 * Updates the speed of an object. If the speed changes from 0 to another
614 * value, or vice versa, then add/remove the object from the active list. 616 * value, or vice versa, then add/remove the object from the active list.
615 * This function needs to be called whenever the speed of an object changes. 617 * This function needs to be called whenever the speed of an object changes.
616 */ 618 */
617void 619void
618update_ob_speed (object *op) 620object::set_speed (float speed)
619{ 621{
620 extern int arch_init; 622 if (flag [FLAG_FREED] && speed)
621
622 /* No reason putting the archetypes objects on the speed list,
623 * since they never really need to be updated.
624 */
625
626 if (QUERY_FLAG (op, FLAG_FREED) && op->speed)
627 { 623 {
628 LOG (llevError, "Object %s is freed but has speed.\n", &op->name); 624 LOG (llevError, "Object %s is freed but has speed.\n", &name);
629#ifdef MANY_CORES
630 abort ();
631#else
632 op->speed = 0; 625 speed = 0;
633#endif
634 }
635
636 if (arch_init)
637 return;
638
639 if (FABS (op->speed) > MIN_ACTIVE_SPEED)
640 { 626 }
641 /* If already on active list, don't do anything */
642 if (op->active_next || op->active_prev || op == active_objects)
643 return;
644 627
645 /* process_events() expects us to insert the object at the beginning 628 this->speed = speed;
646 * of the list. */
647 op->active_next = active_objects;
648 629
649 if (op->active_next != NULL) 630 if (has_active_speed ())
650 op->active_next->active_prev = op; 631 activate ();
651
652 active_objects = op;
653 }
654 else 632 else
655 { 633 deactivate ();
656 /* If not on the active list, nothing needs to be done */
657 if (!op->active_next && !op->active_prev && op != active_objects)
658 return;
659
660 if (op->active_prev == NULL)
661 {
662 active_objects = op->active_next;
663
664 if (op->active_next != NULL)
665 op->active_next->active_prev = NULL;
666 }
667 else
668 {
669 op->active_prev->active_next = op->active_next;
670
671 if (op->active_next)
672 op->active_next->active_prev = op->active_prev;
673 }
674
675 op->active_next = NULL;
676 op->active_prev = NULL;
677 }
678} 634}
679 635
680/* This function removes object 'op' from the list of active
681 * objects.
682 * This should only be used for style maps or other such
683 * reference maps where you don't want an object that isn't
684 * in play chewing up cpu time getting processed.
685 * The reverse of this is to call update_ob_speed, which
686 * will do the right thing based on the speed of the object.
687 */
688void
689remove_from_active_list (object *op)
690{
691 /* If not on the active list, nothing needs to be done */
692 if (!op->active_next && !op->active_prev && op != active_objects)
693 return;
694
695 if (op->active_prev == NULL)
696 {
697 active_objects = op->active_next;
698 if (op->active_next != NULL)
699 op->active_next->active_prev = NULL;
700 }
701 else
702 {
703 op->active_prev->active_next = op->active_next;
704 if (op->active_next)
705 op->active_next->active_prev = op->active_prev;
706 }
707 op->active_next = NULL;
708 op->active_prev = NULL;
709}
710
711/* 636/*
712 * update_object() updates the array which represents the map. 637 * update_object() updates the the map.
713 * It takes into account invisible objects (and represent squares covered 638 * It takes into account invisible objects (and represent squares covered
714 * by invisible objects by whatever is below them (unless it's another 639 * by invisible objects by whatever is below them (unless it's another
715 * invisible object, etc...) 640 * invisible object, etc...)
716 * If the object being updated is beneath a player, the look-window 641 * If the object being updated is beneath a player, the look-window
717 * of that player is updated (this might be a suboptimal way of 642 * of that player is updated (this might be a suboptimal way of
718 * updating that window, though, since update_object() is called _often_) 643 * updating that window, though, since update_object() is called _often_)
719 * 644 *
720 * action is a hint of what the caller believes need to be done. 645 * action is a hint of what the caller believes need to be done.
721 * For example, if the only thing that has changed is the face (due to
722 * an animation), we don't need to call update_position until that actually
723 * comes into view of a player. OTOH, many other things, like addition/removal
724 * of walls or living creatures may need us to update the flags now.
725 * current action are: 646 * current action are:
726 * UP_OBJ_INSERT: op was inserted 647 * UP_OBJ_INSERT: op was inserted
727 * UP_OBJ_REMOVE: op was removed 648 * UP_OBJ_REMOVE: op was removed
728 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update 649 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update
729 * as that is easier than trying to look at what may have changed. 650 * as that is easier than trying to look at what may have changed.
730 * UP_OBJ_FACE: only the objects face has changed. 651 * UP_OBJ_FACE: only the objects face has changed.
731 */ 652 */
732
733void 653void
734update_object (object *op, int action) 654update_object (object *op, int action)
735{ 655{
736 int update_now = 0, flags;
737 MoveType move_on, move_off, move_block, move_slow;
738
739 if (op == NULL) 656 if (op == NULL)
740 { 657 {
741 /* this should never happen */ 658 /* this should never happen */
742 LOG (llevDebug, "update_object() called for NULL object.\n"); 659 LOG (llevDebug, "update_object() called for NULL object.\n");
743 return; 660 return;
744 } 661 }
745 662
746 if (op->env != NULL) 663 if (op->env)
747 { 664 {
748 /* Animation is currently handled by client, so nothing 665 /* Animation is currently handled by client, so nothing
749 * to do in this case. 666 * to do in this case.
750 */ 667 */
751 return; 668 return;
… …
756 */ 673 */
757 if (!op->map || op->map->in_memory == MAP_SAVING) 674 if (!op->map || op->map->in_memory == MAP_SAVING)
758 return; 675 return;
759 676
760 /* make sure the object is within map boundaries */ 677 /* make sure the object is within map boundaries */
761 if (op->x < 0 || op->x >= MAP_WIDTH (op->map) || op->y < 0 || op->y >= MAP_HEIGHT (op->map)) 678 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
762 { 679 {
763 LOG (llevError, "update_object() called for object out of map!\n"); 680 LOG (llevError, "update_object() called for object out of map!\n");
764#ifdef MANY_CORES 681#ifdef MANY_CORES
765 abort (); 682 abort ();
766#endif 683#endif
767 return; 684 return;
768 } 685 }
769 686
770 flags = GET_MAP_FLAGS (op->map, op->x, op->y); 687 mapspace &m = op->ms ();
771 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NEED_UPDATE);
772 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
773 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
774 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
775 move_off = GET_MAP_MOVE_OFF (op->map, op->x, op->y);
776 688
689 if (!(m.flags_ & P_UPTODATE))
690 /* nop */;
777 if (action == UP_OBJ_INSERT) 691 else if (action == UP_OBJ_INSERT)
778 { 692 {
693 // this is likely overkill, TODO: revisit (schmorp)
779 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(flags & P_BLOCKSVIEW)) 694 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
780 update_now = 1;
781
782 if (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(flags & P_NO_MAGIC)) 695 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
783 update_now = 1; 696 || (op->type == PLAYER && !(m.flags_ & P_PLAYER))
784 697 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
698 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
785 if (QUERY_FLAG (op, FLAG_DAMNED) && !(flags & P_NO_CLERIC)) 699 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
786 update_now = 1;
787
788 if (QUERY_FLAG (op, FLAG_ALIVE) && !(flags & P_IS_ALIVE))
789 update_now = 1;
790
791 if (op->type == SAFE_GROUND && !(flags & P_SAFE))
792 update_now = 1;
793
794 if ((move_on | op->move_on) != move_on) 700 || (m.move_on | op->move_on ) != m.move_on
795 update_now = 1;
796
797 if ((move_off | op->move_off) != move_off) 701 || (m.move_off | op->move_off ) != m.move_off
798 update_now = 1; 702 || (m.move_slow | op->move_slow) != m.move_slow
799
800 /* This isn't perfect, but I don't expect a lot of objects to 703 /* This isn't perfect, but I don't expect a lot of objects to
801 * to have move_allow right now. 704 * to have move_allow right now.
802 */ 705 */
803 if (((move_block | op->move_block) & ~op->move_allow) != move_block) 706 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
804 update_now = 1; 707 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
805 708 m.flags_ = 0;
806 if ((move_slow | op->move_slow) != move_slow)
807 update_now = 1;
808 } 709 }
809 /* if the object is being removed, we can't make intelligent 710 /* if the object is being removed, we can't make intelligent
810 * decisions, because remove_ob can't really pass the object 711 * decisions, because remove_ob can't really pass the object
811 * that is being removed. 712 * that is being removed.
812 */ 713 */
813 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 714 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
814 update_now = 1; 715 m.flags_ = 0;
815 else if (action == UP_OBJ_FACE) 716 else if (action == UP_OBJ_FACE)
816 /* Nothing to do for that case */ ; 717 /* Nothing to do for that case */ ;
817 else 718 else
818 LOG (llevError, "update_object called with invalid action: %d\n", action); 719 LOG (llevError, "update_object called with invalid action: %d\n", action);
819 720
820 if (update_now)
821 {
822 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NO_ERROR | P_NEED_UPDATE);
823 update_position (op->map, op->x, op->y);
824 }
825
826 if (op->more != NULL) 721 if (op->more)
827 update_object (op->more, action); 722 update_object (op->more, action);
828}
829
830object::vector object::mortals;
831object::vector object::objects; // not yet used
832object *object::first;
833
834void object::free_mortals ()
835{
836 for (AUTODECL (i, mortals.begin ()); i != mortals.end ();)
837 if ((*i)->refcnt)
838 ++i; // further delay freeing
839 else
840 {
841 delete *i;
842 mortals.erase (i);
843 }
844
845 static int lastmortals = 0;//D
846
847 if (mortals.size() != lastmortals && lastmortals > 100)//D
848 {
849 lastmortals = mortals.size ();//D
850 LOG (llevDebug, "%d objects in mortal queue\n", lastmortals);//D
851 }
852} 723}
853 724
854object::object () 725object::object ()
855{ 726{
856 SET_FLAG (this, FLAG_REMOVED); 727 SET_FLAG (this, FLAG_REMOVED);
… …
859 face = blank_face; 730 face = blank_face;
860} 731}
861 732
862object::~object () 733object::~object ()
863{ 734{
735 unlink ();
736
864 free_key_values (this); 737 free_key_values (this);
865} 738}
866 739
740static int object_count;
741
867void object::link () 742void object::link ()
868{ 743{
869 count = ++ob_count; 744 assert (!index);//D
870 uuid = gen_uuid (); 745 uuid = gen_uuid ();
746 count = ++object_count;
871 747
872 prev = 0; 748 refcnt_inc ();
873 next = object::first; 749 objects.insert (this);
874
875 if (object::first)
876 object::first->prev = this;
877
878 object::first = this;
879} 750}
880 751
881void object::unlink () 752void object::unlink ()
882{ 753{
883 if (this == object::first) 754 if (!index)
884 object::first = next; 755 return;
885 756
886 /* Remove this object from the list of used objects */ 757 objects.erase (this);
887 if (prev) prev->next = next; 758 refcnt_dec ();
888 if (next) next->prev = prev; 759}
889 760
890 prev = 0; 761void
891 next = 0; 762object::activate ()
763{
764 /* If already on active list, don't do anything */
765 if (active)
766 return;
767
768 if (has_active_speed ())
769 actives.insert (this);
770}
771
772void
773object::activate_recursive ()
774{
775 activate ();
776
777 for (object *op = inv; op; op = op->below)
778 op->activate_recursive ();
779}
780
781/* This function removes object 'op' from the list of active
782 * objects.
783 * This should only be used for style maps or other such
784 * reference maps where you don't want an object that isn't
785 * in play chewing up cpu time getting processed.
786 * The reverse of this is to call update_ob_speed, which
787 * will do the right thing based on the speed of the object.
788 */
789void
790object::deactivate ()
791{
792 /* If not on the active list, nothing needs to be done */
793 if (!active)
794 return;
795
796 actives.erase (this);
797}
798
799void
800object::deactivate_recursive ()
801{
802 for (object *op = inv; op; op = op->below)
803 op->deactivate_recursive ();
804
805 deactivate ();
806}
807
808void
809object::set_flag_inv (int flag, int value)
810{
811 for (object *op = inv; op; op = op->below)
812 {
813 op->flag [flag] = value;
814 op->set_flag_inv (flag, value);
815 }
816}
817
818/*
819 * Remove and free all objects in the inventory of the given object.
820 * object.c ?
821 */
822void
823object::destroy_inv (bool drop_to_ground)
824{
825 // need to check first, because the checks below might segfault
826 // as we might be on an invalid mapspace and crossfire code
827 // is too buggy to ensure that the inventory is empty.
828 // corollary: if you create arrows etc. with stuff in tis inventory,
829 // cf will crash below with off-map x and y
830 if (!inv)
831 return;
832
833 /* Only if the space blocks everything do we not process -
834 * if some form of movement is allowed, let objects
835 * drop on that space.
836 */
837 if (!drop_to_ground
838 || !map
839 || map->in_memory != MAP_IN_MEMORY
840 || map->nodrop
841 || ms ().move_block == MOVE_ALL)
842 {
843 while (inv)
844 {
845 inv->destroy_inv (drop_to_ground);
846 inv->destroy ();
847 }
848 }
849 else
850 { /* Put objects in inventory onto this space */
851 while (inv)
852 {
853 object *op = inv;
854
855 if (op->flag [FLAG_STARTEQUIP]
856 || op->flag [FLAG_NO_DROP]
857 || op->type == RUNE
858 || op->type == TRAP
859 || op->flag [FLAG_IS_A_TEMPLATE]
860 || op->flag [FLAG_DESTROY_ON_DEATH])
861 op->destroy ();
862 else
863 map->insert (op, x, y);
864 }
865 }
892} 866}
893 867
894object *object::create () 868object *object::create ()
895{ 869{
896 object *op = new object; 870 object *op = new object;
897 op->link (); 871 op->link ();
898 return op; 872 return op;
899} 873}
900 874
901/* 875void
902 * free_object() frees everything allocated by an object, removes 876object::do_destroy ()
903 * it from the list of used objects, and puts it on the list of
904 * free objects. The IS_FREED() flag is set in the object.
905 * The object must have been removed by remove_ob() first for
906 * this function to succeed.
907 *
908 * If destroy_inventory is set, free inventory as well. Else drop items in
909 * inventory to the ground.
910 */
911void object::destroy (bool destroy_inventory)
912{ 877{
913 if (QUERY_FLAG (this, FLAG_FREED)) 878 attachable::do_destroy ();
914 return;
915 879
916 if (QUERY_FLAG (this, FLAG_FRIENDLY)) 880 if (flag [FLAG_IS_LINKED])
881 remove_button_link (this);
882
883 if (flag [FLAG_FRIENDLY])
917 remove_friendly_object (this); 884 remove_friendly_object (this);
918 885
919 if (!QUERY_FLAG (this, FLAG_REMOVED)) 886 if (!flag [FLAG_REMOVED])
920 remove_ob (this); 887 remove ();
921 888
922 SET_FLAG (this, FLAG_FREED); 889 destroy_inv (true);
923 890
924 if (more) 891 deactivate ();
925 { 892 unlink ();
926 more->destroy (destroy_inventory);
927 more = 0;
928 }
929 893
930 if (inv) 894 flag [FLAG_FREED] = 1;
931 {
932 /* Only if the space blocks everything do we not process -
933 * if some form of movement is allowed, let objects
934 * drop on that space.
935 */
936 if (destroy_inventory || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL)
937 {
938 object *op = inv;
939
940 while (op)
941 {
942 object *tmp = op->below;
943 op->destroy (destroy_inventory);
944 op = tmp;
945 }
946 }
947 else
948 { /* Put objects in inventory onto this space */
949 object *op = inv;
950
951 while (op)
952 {
953 object *tmp = op->below;
954
955 remove_ob (op);
956
957 if (QUERY_FLAG (op, FLAG_STARTEQUIP)
958 || QUERY_FLAG (op, FLAG_NO_DROP) || op->type == RUNE || op->type == TRAP || QUERY_FLAG (op, FLAG_IS_A_TEMPLATE))
959 free_object (op);
960 else
961 {
962 op->x = x;
963 op->y = y;
964 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
965 }
966
967 op = tmp;
968 }
969 }
970 }
971 895
972 // hack to ensure that freed objects still have a valid map 896 // hack to ensure that freed objects still have a valid map
973 { 897 {
974 static maptile *freed_map; // freed objects are moved here to avoid crashes 898 static maptile *freed_map; // freed objects are moved here to avoid crashes
975 899
… …
979 903
980 freed_map->name = "/internal/freed_objects_map"; 904 freed_map->name = "/internal/freed_objects_map";
981 freed_map->width = 3; 905 freed_map->width = 3;
982 freed_map->height = 3; 906 freed_map->height = 3;
983 907
984 freed_map->allocate (); 908 freed_map->alloc ();
909 freed_map->in_memory = MAP_IN_MEMORY;
985 } 910 }
986 911
987 map = freed_map; 912 map = freed_map;
988 x = 1; 913 x = 1;
989 y = 1; 914 y = 1;
990 } 915 }
991 916
917 head = 0;
918
919 if (more)
920 {
921 more->destroy ();
922 more = 0;
923 }
924
992 // clear those pointers that likely might have circular references to us 925 // clear those pointers that likely might have circular references to us
993 owner = 0; 926 owner = 0;
994 enemy = 0; 927 enemy = 0;
995 attacked_by = 0; 928 attacked_by = 0;
929}
996 930
997 // only relevant for players(?), but make sure of it anyways 931void
998 contr = 0; 932object::destroy (bool destroy_inventory)
933{
934 if (destroyed ())
935 return;
999 936
1000 /* Remove object from the active list */ 937 if (destroy_inventory)
1001 speed = 0; 938 destroy_inv (false);
1002 update_ob_speed (this);
1003 939
1004 unlink (); 940 attachable::destroy ();
1005
1006 mortals.push_back (this);
1007} 941}
1008 942
1009/* 943/*
1010 * sub_weight() recursively (outwards) subtracts a number from the 944 * sub_weight() recursively (outwards) subtracts a number from the
1011 * weight of an object (and what is carried by it's environment(s)). 945 * weight of an object (and what is carried by it's environment(s)).
1012 */ 946 */
1013
1014void 947void
1015sub_weight (object *op, signed long weight) 948sub_weight (object *op, signed long weight)
1016{ 949{
1017 while (op != NULL) 950 while (op != NULL)
1018 { 951 {
… …
1022 op->carrying -= weight; 955 op->carrying -= weight;
1023 op = op->env; 956 op = op->env;
1024 } 957 }
1025} 958}
1026 959
1027/* remove_ob(op): 960/* op->remove ():
1028 * This function removes the object op from the linked list of objects 961 * This function removes the object op from the linked list of objects
1029 * which it is currently tied to. When this function is done, the 962 * which it is currently tied to. When this function is done, the
1030 * object will have no environment. If the object previously had an 963 * object will have no environment. If the object previously had an
1031 * environment, the x and y coordinates will be updated to 964 * environment, the x and y coordinates will be updated to
1032 * the previous environment. 965 * the previous environment.
1033 * Beware: This function is called from the editor as well!
1034 */ 966 */
1035
1036void 967void
1037remove_ob (object *op) 968object::do_remove ()
1038{ 969{
1039 object *tmp, *last = 0; 970 object *tmp, *last = 0;
1040 object *otmp; 971 object *otmp;
1041 972
1042 int check_walk_off;
1043 maptile *m;
1044
1045 sint16 x, y;
1046
1047 if (QUERY_FLAG (op, FLAG_REMOVED)) 973 if (QUERY_FLAG (this, FLAG_REMOVED))
1048 return; 974 return;
1049 975
1050 SET_FLAG (op, FLAG_REMOVED); 976 SET_FLAG (this, FLAG_REMOVED);
977 INVOKE_OBJECT (REMOVE, this);
1051 978
1052 if (op->more != NULL) 979 if (more)
1053 remove_ob (op->more); 980 more->remove ();
1054 981
1055 /* 982 /*
1056 * In this case, the object to be removed is in someones 983 * In this case, the object to be removed is in someones
1057 * inventory. 984 * inventory.
1058 */ 985 */
1059 if (op->env != NULL) 986 if (env)
1060 { 987 {
1061 if (op->nrof) 988 if (nrof)
1062 sub_weight (op->env, op->weight * op->nrof); 989 sub_weight (env, weight * nrof);
1063 else 990 else
1064 sub_weight (op->env, op->weight + op->carrying); 991 sub_weight (env, weight + carrying);
1065 992
1066 /* NO_FIX_PLAYER is set when a great many changes are being 993 /* NO_FIX_PLAYER is set when a great many changes are being
1067 * made to players inventory. If set, avoiding the call 994 * made to players inventory. If set, avoiding the call
1068 * to save cpu time. 995 * to save cpu time.
1069 */ 996 */
1070 if ((otmp = is_player_inv (op->env)) != NULL && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 997 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1071 fix_player (otmp); 998 otmp->update_stats ();
1072 999
1073 if (op->above != NULL) 1000 if (above)
1074 op->above->below = op->below; 1001 above->below = below;
1075 else 1002 else
1076 op->env->inv = op->below; 1003 env->inv = below;
1077 1004
1078 if (op->below != NULL) 1005 if (below)
1079 op->below->above = op->above; 1006 below->above = above;
1080 1007
1081 /* we set up values so that it could be inserted into 1008 /* we set up values so that it could be inserted into
1082 * the map, but we don't actually do that - it is up 1009 * the map, but we don't actually do that - it is up
1083 * to the caller to decide what we want to do. 1010 * to the caller to decide what we want to do.
1084 */ 1011 */
1085 op->x = op->env->x, op->y = op->env->y; 1012 x = env->x, y = env->y;
1086 op->map = op->env->map; 1013 map = env->map;
1087 op->above = NULL, op->below = NULL; 1014 above = 0, below = 0;
1088 op->env = NULL; 1015 env = 0;
1089 } 1016 }
1090 else if (op->map) 1017 else if (map)
1091 { 1018 {
1092 x = op->x; 1019 if (type == PLAYER)
1093 y = op->y;
1094 m = get_map_from_coord (op->map, &x, &y);
1095
1096 if (!m)
1097 { 1020 {
1098 LOG (llevError, "remove_ob called when object was on map but appears to not be within valid coordinates? %s (%d,%d)\n", 1021 // leaving a spot always closes any open container on the ground
1099 op->map->path, op->x, op->y); 1022 if (container && !container->env)
1100 /* in old days, we used to set x and y to 0 and continue. 1023 // this causes spurious floorbox updates, but it ensures
1101 * it seems if we get into this case, something is probablye 1024 // that the CLOSE event is being sent.
1102 * screwed up and should be fixed. 1025 close_container ();
1103 */ 1026
1104 abort (); 1027 --map->players;
1028 map->touch ();
1105 } 1029 }
1106 1030
1107 if (op->map != m) 1031 map->dirty = true;
1108 LOG (llevDebug, "remove_ob: Object not really on map it claimed to be on? %s != %s, %d,%d != %d,%d\n", 1032 mapspace &ms = this->ms ();
1109 op->map->path, m->path, op->x, op->y, x, y);
1110
1111 /* Re did the following section of code - it looks like it had
1112 * lots of logic for things we no longer care about
1113 */
1114 1033
1115 /* link the object above us */ 1034 /* link the object above us */
1116 if (op->above) 1035 if (above)
1117 op->above->below = op->below; 1036 above->below = below;
1118 else 1037 else
1119 SET_MAP_TOP (m, x, y, op->below); /* we were top, set new top */ 1038 ms.top = below; /* we were top, set new top */
1120 1039
1121 /* Relink the object below us, if there is one */ 1040 /* Relink the object below us, if there is one */
1122 if (op->below) 1041 if (below)
1123 op->below->above = op->above; 1042 below->above = above;
1124 else 1043 else
1125 { 1044 {
1126 /* Nothing below, which means we need to relink map object for this space 1045 /* Nothing below, which means we need to relink map object for this space
1127 * use translated coordinates in case some oddness with map tiling is 1046 * use translated coordinates in case some oddness with map tiling is
1128 * evident 1047 * evident
1129 */ 1048 */
1130 if (GET_MAP_OB (m, x, y) != op) 1049 if (GET_MAP_OB (map, x, y) != this)
1131 {
1132 char *dump = dump_object (op);
1133 LOG (llevError,
1134 "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", dump); 1050 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1135 free (dump);
1136 dump = dump_object (GET_MAP_OB (m, x, y));
1137 LOG (llevError, "%s\n", dump);
1138 free (dump);
1139 }
1140 1051
1141 SET_MAP_OB (m, x, y, op->above); /* goes on above it. */ 1052 ms.bot = above; /* goes on above it. */
1142 } 1053 }
1143 1054
1144 op->above = 0; 1055 above = 0;
1145 op->below = 0; 1056 below = 0;
1146 1057
1147 if (op->map->in_memory == MAP_SAVING) 1058 if (map->in_memory == MAP_SAVING)
1148 return; 1059 return;
1149 1060
1150 check_walk_off = !QUERY_FLAG (op, FLAG_NO_APPLY); 1061 int check_walk_off = !flag [FLAG_NO_APPLY];
1151 1062
1152 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1063 for (tmp = ms.bot; tmp; tmp = tmp->above)
1153 { 1064 {
1154 /* No point updating the players look faces if he is the object 1065 /* No point updating the players look faces if he is the object
1155 * being removed. 1066 * being removed.
1156 */ 1067 */
1157 1068
1158 if (tmp->type == PLAYER && tmp != op) 1069 if (tmp->type == PLAYER && tmp != this)
1159 { 1070 {
1160 /* If a container that the player is currently using somehow gets 1071 /* If a container that the player is currently using somehow gets
1161 * removed (most likely destroyed), update the player view 1072 * removed (most likely destroyed), update the player view
1162 * appropriately. 1073 * appropriately.
1163 */ 1074 */
1164 if (tmp->container == op) 1075 if (tmp->container == this)
1165 { 1076 {
1166 CLEAR_FLAG (op, FLAG_APPLIED); 1077 flag [FLAG_APPLIED] = 0;
1167 tmp->container = NULL; 1078 tmp->container = 0;
1168 } 1079 }
1169 1080
1170 tmp->contr->socket.update_look = 1; 1081 if (tmp->contr->ns)
1082 tmp->contr->ns->floorbox_update ();
1171 } 1083 }
1172 1084
1173 /* See if player moving off should effect something */ 1085 /* See if object moving off should effect something */
1174 if (check_walk_off 1086 if (check_walk_off
1175 && ((op->move_type & tmp->move_off) 1087 && ((move_type & tmp->move_off)
1176 && (op->move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1088 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0))
1177 { 1089 {
1178 move_apply (tmp, op, NULL); 1090 move_apply (tmp, this, 0);
1179 1091
1180 if (op->destroyed ()) 1092 if (destroyed ())
1181 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ()); 1093 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1182 } 1094 }
1183 1095
1184 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */ 1096 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */
1185 1097 //TODO: why is this horrible hacka fix? get rid of this code=bug! (schmorp)
1186 if (tmp->above == tmp) 1098 if (tmp->above == tmp)
1187 tmp->above = NULL; 1099 tmp->above = 0;
1188 1100
1189 last = tmp; 1101 last = tmp;
1190 } 1102 }
1191 1103
1192 /* last == NULL of there are no objects on this space */ 1104 /* last == NULL if there are no objects on this space */
1105 //TODO: this makes little sense, why only update the topmost object?
1193 if (last == NULL) 1106 if (!last)
1194 { 1107 map->at (x, y).flags_ = 0;
1195 /* set P_NEED_UPDATE, otherwise update_position will complain. In theory,
1196 * we could preserve the flags (GET_MAP_FLAGS), but update_position figures
1197 * those out anyways, and if there are any flags set right now, they won't
1198 * be correct anyways.
1199 */
1200 SET_MAP_FLAGS (op->map, op->x, op->y, P_NEED_UPDATE);
1201 update_position (op->map, op->x, op->y);
1202 }
1203 else 1108 else
1204 update_object (last, UP_OBJ_REMOVE); 1109 update_object (last, UP_OBJ_REMOVE);
1205 1110
1206 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) || (op->glow_radius != 0)) 1111 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1207 update_all_los (op->map, op->x, op->y); 1112 update_all_los (map, x, y);
1208 } 1113 }
1209} 1114}
1210 1115
1211/* 1116/*
1212 * merge_ob(op,top): 1117 * merge_ob(op,top):
… …
1220merge_ob (object *op, object *top) 1125merge_ob (object *op, object *top)
1221{ 1126{
1222 if (!op->nrof) 1127 if (!op->nrof)
1223 return 0; 1128 return 0;
1224 1129
1225 if (top == NULL) 1130 if (top)
1226 for (top = op; top != NULL && top->above != NULL; top = top->above); 1131 for (top = op; top && top->above; top = top->above)
1132 ;
1227 1133
1228 for (; top != NULL; top = top->below) 1134 for (; top; top = top->below)
1229 { 1135 {
1230 if (top == op) 1136 if (top == op)
1231 continue; 1137 continue;
1232 if (CAN_MERGE (op, top)) 1138
1139 if (object::can_merge (op, top))
1233 { 1140 {
1234 top->nrof += op->nrof; 1141 top->nrof += op->nrof;
1235 1142
1236/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/ 1143/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/
1237 op->weight = 0; /* Don't want any adjustements now */ 1144 op->weight = 0; /* Don't want any adjustements now */
1238 remove_ob (op); 1145 op->destroy ();
1239 free_object (op);
1240 return top; 1146 return top;
1241 } 1147 }
1242 } 1148 }
1243 1149
1244 return 0; 1150 return 0;
1245} 1151}
1246 1152
1153void
1154object::expand_tail ()
1155{
1156 if (more)
1157 return;
1158
1159 object *prev = this;
1160
1161 for (archetype *at = arch->more; at; at = at->more)
1162 {
1163 object *op = arch_to_object (at);
1164
1165 op->name = name;
1166 op->name_pl = name_pl;
1167 op->title = title;
1168
1169 op->head = this;
1170 prev->more = op;
1171
1172 prev = op;
1173 }
1174}
1175
1247/* 1176/*
1248 * same as insert_ob_in_map except it handle separate coordinates and do a clean 1177 * same as insert_ob_in_map except it handles separate coordinates and does a clean
1249 * job preparing multi-part monsters 1178 * job preparing multi-part monsters.
1250 */ 1179 */
1251object * 1180object *
1252insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1181insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1253{ 1182{
1254 object *tmp;
1255
1256 if (op->head)
1257 op = op->head;
1258
1259 for (tmp = op; tmp; tmp = tmp->more) 1183 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1260 { 1184 {
1261 tmp->x = x + tmp->arch->clone.x; 1185 tmp->x = x + tmp->arch->clone.x;
1262 tmp->y = y + tmp->arch->clone.y; 1186 tmp->y = y + tmp->arch->clone.y;
1263 } 1187 }
1264 1188
… …
1283 * Return value: 1207 * Return value:
1284 * new object if 'op' was merged with other object 1208 * new object if 'op' was merged with other object
1285 * NULL if 'op' was destroyed 1209 * NULL if 'op' was destroyed
1286 * just 'op' otherwise 1210 * just 'op' otherwise
1287 */ 1211 */
1288
1289object * 1212object *
1290insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1213insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1291{ 1214{
1215 assert (!op->flag [FLAG_FREED]);
1216
1292 object *tmp, *top, *floor = NULL; 1217 object *tmp, *top, *floor = NULL;
1293 sint16 x, y;
1294 1218
1295 if (QUERY_FLAG (op, FLAG_FREED)) 1219 op->remove ();
1296 {
1297 LOG (llevError, "Trying to insert freed object!\n");
1298 return NULL;
1299 }
1300 1220
1301 if (m == NULL) 1221#if 0
1302 { 1222 if (!m->active != !op->active)
1303 char *dump = dump_object (op); 1223 if (m->active)
1304 LOG (llevError, "Trying to insert in null-map!\n%s\n", dump); 1224 op->activate_recursive ();
1305 free (dump); 1225 else
1306 return op; 1226 op->deactivate_recursive ();
1307 } 1227#endif
1308 1228
1309 if (out_of_map (m, op->x, op->y)) 1229 if (out_of_map (m, op->x, op->y))
1310 { 1230 {
1311 char *dump = dump_object (op);
1312 LOG (llevError, "Trying to insert object outside the map.\n%s\n", dump); 1231 LOG (llevError, "Trying to insert object outside the map.\n%s\n", op->debug_desc ());
1313#ifdef MANY_CORES 1232#ifdef MANY_CORES
1314 /* Better to catch this here, as otherwise the next use of this object 1233 /* Better to catch this here, as otherwise the next use of this object
1315 * is likely to cause a crash. Better to find out where it is getting 1234 * is likely to cause a crash. Better to find out where it is getting
1316 * improperly inserted. 1235 * improperly inserted.
1317 */ 1236 */
1318 abort (); 1237 abort ();
1319#endif 1238#endif
1320 free (dump);
1321 return op; 1239 return op;
1322 } 1240 }
1323 1241
1324 if (!QUERY_FLAG (op, FLAG_REMOVED))
1325 {
1326 char *dump = dump_object (op);
1327 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", dump);
1328 free (dump);
1329 return op;
1330 }
1331
1332 if (op->more != NULL)
1333 {
1334 /* The part may be on a different map. */
1335
1336 object *more = op->more; 1242 if (object *more = op->more)
1337 1243 {
1338 /* We really need the caller to normalize coordinates - if
1339 * we set the map, that doesn't work if the location is within
1340 * a map and this is straddling an edge. So only if coordinate
1341 * is clear wrong do we normalize it.
1342 */
1343 if (OUT_OF_REAL_MAP (more->map, more->x, more->y))
1344 more->map = get_map_from_coord (m, &more->x, &more->y);
1345 else if (!more->map)
1346 {
1347 /* For backwards compatibility - when not dealing with tiled maps,
1348 * more->map should always point to the parent.
1349 */
1350 more->map = m;
1351 }
1352
1353 if (insert_ob_in_map (more, more->map, originator, flag) == NULL) 1244 if (!insert_ob_in_map (more, m, originator, flag))
1354 { 1245 {
1355 if (!op->head) 1246 if (!op->head)
1356 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n"); 1247 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n");
1357 1248
1358 return NULL; 1249 return 0;
1359 } 1250 }
1360 } 1251 }
1361 1252
1362 CLEAR_FLAG (op, FLAG_REMOVED); 1253 CLEAR_FLAG (op, FLAG_REMOVED);
1363 1254
1364 /* Ideally, the caller figures this out. However, it complicates a lot 1255 /* Ideally, the caller figures this out. However, it complicates a lot
1365 * of areas of callers (eg, anything that uses find_free_spot would now 1256 * of areas of callers (eg, anything that uses find_free_spot would now
1366 * need extra work 1257 * need extra work
1367 */ 1258 */
1368 op->map = get_map_from_coord (m, &op->x, &op->y); 1259 if (!xy_normalise (m, op->x, op->y))
1369 x = op->x; 1260 return 0;
1370 y = op->y; 1261
1262 op->map = m;
1263 mapspace &ms = op->ms ();
1371 1264
1372 /* this has to be done after we translate the coordinates. 1265 /* this has to be done after we translate the coordinates.
1373 */ 1266 */
1374 if (op->nrof && !(flag & INS_NO_MERGE)) 1267 if (op->nrof && !(flag & INS_NO_MERGE))
1375 for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above) 1268 for (tmp = ms.bot; tmp; tmp = tmp->above)
1376 if (CAN_MERGE (op, tmp)) 1269 if (object::can_merge (op, tmp))
1377 { 1270 {
1378 op->nrof += tmp->nrof; 1271 op->nrof += tmp->nrof;
1379 remove_ob (tmp); 1272 tmp->destroy ();
1380 free_object (tmp);
1381 } 1273 }
1382 1274
1383 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1275 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1384 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1276 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1385 1277
… …
1398 op->below = originator->below; 1290 op->below = originator->below;
1399 1291
1400 if (op->below) 1292 if (op->below)
1401 op->below->above = op; 1293 op->below->above = op;
1402 else 1294 else
1403 SET_MAP_OB (op->map, op->x, op->y, op); 1295 ms.bot = op;
1404 1296
1405 /* since *below* originator, no need to update top */ 1297 /* since *below* originator, no need to update top */
1406 originator->below = op; 1298 originator->below = op;
1407 } 1299 }
1408 else 1300 else
1409 { 1301 {
1302 top = ms.bot;
1303
1410 /* If there are other objects, then */ 1304 /* If there are other objects, then */
1411 if ((!(flag & INS_MAP_LOAD)) && ((top = GET_MAP_OB (op->map, op->x, op->y)) != NULL)) 1305 if ((!(flag & INS_MAP_LOAD)) && top)
1412 { 1306 {
1413 object *last = NULL; 1307 object *last = 0;
1414 1308
1415 /* 1309 /*
1416 * If there are multiple objects on this space, we do some trickier handling. 1310 * If there are multiple objects on this space, we do some trickier handling.
1417 * We've already dealt with merging if appropriate. 1311 * We've already dealt with merging if appropriate.
1418 * Generally, we want to put the new object on top. But if 1312 * Generally, we want to put the new object on top. But if
… …
1422 * once we get to them. This reduces the need to traverse over all of 1316 * once we get to them. This reduces the need to traverse over all of
1423 * them when adding another one - this saves quite a bit of cpu time 1317 * them when adding another one - this saves quite a bit of cpu time
1424 * when lots of spells are cast in one area. Currently, it is presumed 1318 * when lots of spells are cast in one area. Currently, it is presumed
1425 * that flying non pickable objects are spell objects. 1319 * that flying non pickable objects are spell objects.
1426 */ 1320 */
1427 1321 for (top = ms.bot; top; top = top->above)
1428 while (top != NULL)
1429 { 1322 {
1430 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1323 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))
1431 floor = top; 1324 floor = top;
1432 1325
1433 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1326 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))
… …
1436 top = top->below; 1329 top = top->below;
1437 break; 1330 break;
1438 } 1331 }
1439 1332
1440 last = top; 1333 last = top;
1441 top = top->above;
1442 } 1334 }
1443 1335
1444 /* Don't want top to be NULL, so set it to the last valid object */ 1336 /* Don't want top to be NULL, so set it to the last valid object */
1445 top = last; 1337 top = last;
1446 1338
… …
1448 * looks like instead of lots of conditions here. 1340 * looks like instead of lots of conditions here.
1449 * makes things faster, and effectively the same result. 1341 * makes things faster, and effectively the same result.
1450 */ 1342 */
1451 1343
1452 /* Have object 'fall below' other objects that block view. 1344 /* Have object 'fall below' other objects that block view.
1453 * Unless those objects are exits, type 66 1345 * Unless those objects are exits.
1454 * If INS_ON_TOP is used, don't do this processing 1346 * If INS_ON_TOP is used, don't do this processing
1455 * Need to find the object that in fact blocks view, otherwise 1347 * Need to find the object that in fact blocks view, otherwise
1456 * stacking is a bit odd. 1348 * stacking is a bit odd.
1457 */ 1349 */
1458 if (!(flag & INS_ON_TOP) && 1350 if (!(flag & INS_ON_TOP)
1459 (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_BLOCKSVIEW) && (op->face && !op->face->visibility)) 1351 && ms.flags () & P_BLOCKSVIEW
1352 && (op->face && !faces [op->face].visibility))
1460 { 1353 {
1461 for (last = top; last != floor; last = last->below) 1354 for (last = top; last != floor; last = last->below)
1462 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1355 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1463 break; 1356 break;
1357
1464 /* Check to see if we found the object that blocks view, 1358 /* Check to see if we found the object that blocks view,
1465 * and make sure we have a below pointer for it so that 1359 * and make sure we have a below pointer for it so that
1466 * we can get inserted below this one, which requires we 1360 * we can get inserted below this one, which requires we
1467 * set top to the object below us. 1361 * set top to the object below us.
1468 */ 1362 */
… …
1470 top = last->below; 1364 top = last->below;
1471 } 1365 }
1472 } /* If objects on this space */ 1366 } /* If objects on this space */
1473 1367
1474 if (flag & INS_MAP_LOAD) 1368 if (flag & INS_MAP_LOAD)
1475 top = GET_MAP_TOP (op->map, op->x, op->y); 1369 top = ms.top;
1476 1370
1477 if (flag & INS_ABOVE_FLOOR_ONLY) 1371 if (flag & INS_ABOVE_FLOOR_ONLY)
1478 top = floor; 1372 top = floor;
1479 1373
1480 /* Top is the object that our object (op) is going to get inserted above. 1374 /* Top is the object that our object (op) is going to get inserted above.
1481 */ 1375 */
1482 1376
1483 /* First object on this space */ 1377 /* First object on this space */
1484 if (!top) 1378 if (!top)
1485 { 1379 {
1486 op->above = GET_MAP_OB (op->map, op->x, op->y); 1380 op->above = ms.bot;
1487 1381
1488 if (op->above) 1382 if (op->above)
1489 op->above->below = op; 1383 op->above->below = op;
1490 1384
1491 op->below = NULL; 1385 op->below = 0;
1492 SET_MAP_OB (op->map, op->x, op->y, op); 1386 ms.bot = op;
1493 } 1387 }
1494 else 1388 else
1495 { /* get inserted into the stack above top */ 1389 { /* get inserted into the stack above top */
1496 op->above = top->above; 1390 op->above = top->above;
1497 1391
… …
1500 1394
1501 op->below = top; 1395 op->below = top;
1502 top->above = op; 1396 top->above = op;
1503 } 1397 }
1504 1398
1505 if (op->above == NULL) 1399 if (!op->above)
1506 SET_MAP_TOP (op->map, op->x, op->y, op); 1400 ms.top = op;
1507 } /* else not INS_BELOW_ORIGINATOR */ 1401 } /* else not INS_BELOW_ORIGINATOR */
1508 1402
1509 if (op->type == PLAYER) 1403 if (op->type == PLAYER)
1404 {
1510 op->contr->do_los = 1; 1405 op->contr->do_los = 1;
1406 ++op->map->players;
1407 op->map->touch ();
1408 }
1409
1410 op->map->dirty = true;
1511 1411
1512 /* If we have a floor, we know the player, if any, will be above 1412 /* If we have a floor, we know the player, if any, will be above
1513 * it, so save a few ticks and start from there. 1413 * it, so save a few ticks and start from there.
1514 */ 1414 */
1515 if (!(flag & INS_MAP_LOAD)) 1415 if (!(flag & INS_MAP_LOAD))
1516 for (tmp = floor ? floor : GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1416 if (object *pl = ms.player ())
1517 if (tmp->type == PLAYER) 1417 if (pl->contr->ns)
1518 tmp->contr->socket.update_look = 1; 1418 pl->contr->ns->floorbox_update ();
1519 1419
1520 /* If this object glows, it may affect lighting conditions that are 1420 /* If this object glows, it may affect lighting conditions that are
1521 * visible to others on this map. But update_all_los is really 1421 * visible to others on this map. But update_all_los is really
1522 * an inefficient way to do this, as it means los for all players 1422 * an inefficient way to do this, as it means los for all players
1523 * on the map will get recalculated. The players could very well 1423 * on the map will get recalculated. The players could very well
1524 * be far away from this change and not affected in any way - 1424 * be far away from this change and not affected in any way -
1525 * this should get redone to only look for players within range, 1425 * this should get redone to only look for players within range,
1526 * or just updating the P_NEED_UPDATE for spaces within this area 1426 * or just updating the P_UPTODATE for spaces within this area
1527 * of effect may be sufficient. 1427 * of effect may be sufficient.
1528 */ 1428 */
1529 if (MAP_DARKNESS (op->map) && (op->glow_radius != 0)) 1429 if (op->map->darkness && (op->glow_radius != 0))
1530 update_all_los (op->map, op->x, op->y); 1430 update_all_los (op->map, op->x, op->y);
1531 1431
1532 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1432 /* updates flags (blocked, alive, no magic, etc) for this map space */
1533 update_object (op, UP_OBJ_INSERT); 1433 update_object (op, UP_OBJ_INSERT);
1534 1434
1435 INVOKE_OBJECT (INSERT, op);
1436
1535 /* Don't know if moving this to the end will break anything. However, 1437 /* Don't know if moving this to the end will break anything. However,
1536 * we want to have update_look set above before calling this. 1438 * we want to have floorbox_update called before calling this.
1537 * 1439 *
1538 * check_move_on() must be after this because code called from 1440 * check_move_on() must be after this because code called from
1539 * check_move_on() depends on correct map flags (so functions like 1441 * check_move_on() depends on correct map flags (so functions like
1540 * blocked() and wall() work properly), and these flags are updated by 1442 * blocked() and wall() work properly), and these flags are updated by
1541 * update_object(). 1443 * update_object().
… …
1543 1445
1544 /* if this is not the head or flag has been passed, don't check walk on status */ 1446 /* if this is not the head or flag has been passed, don't check walk on status */
1545 if (!(flag & INS_NO_WALK_ON) && !op->head) 1447 if (!(flag & INS_NO_WALK_ON) && !op->head)
1546 { 1448 {
1547 if (check_move_on (op, originator)) 1449 if (check_move_on (op, originator))
1548 return NULL; 1450 return 0;
1549 1451
1550 /* If we are a multi part object, lets work our way through the check 1452 /* If we are a multi part object, lets work our way through the check
1551 * walk on's. 1453 * walk on's.
1552 */ 1454 */
1553 for (tmp = op->more; tmp != NULL; tmp = tmp->more) 1455 for (tmp = op->more; tmp != NULL; tmp = tmp->more)
1554 if (check_move_on (tmp, originator)) 1456 if (check_move_on (tmp, originator))
1555 return NULL; 1457 return 0;
1556 } 1458 }
1557 1459
1558 return op; 1460 return op;
1559} 1461}
1560 1462
1561/* this function inserts an object in the map, but if it 1463/* this function inserts an object in the map, but if it
1562 * finds an object of its own type, it'll remove that one first. 1464 * finds an object of its own type, it'll remove that one first.
1563 * op is the object to insert it under: supplies x and the map. 1465 * op is the object to insert it under: supplies x and the map.
1564 */ 1466 */
1565void 1467void
1566replace_insert_ob_in_map (const char *arch_string, object *op) 1468replace_insert_ob_in_map (const char *arch_string, object *op)
1567{ 1469{
1568 object * 1470 object *tmp, *tmp1;
1569 tmp;
1570 object *
1571 tmp1;
1572 1471
1573 /* first search for itself and remove any old instances */ 1472 /* first search for itself and remove any old instances */
1574 1473
1575 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1474 for (tmp = op->ms ().bot; tmp; tmp = tmp->above)
1576 {
1577 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */ 1475 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */
1578 { 1476 tmp->destroy ();
1579 remove_ob (tmp);
1580 free_object (tmp);
1581 }
1582 }
1583 1477
1584 tmp1 = arch_to_object (archetype::find (arch_string)); 1478 tmp1 = arch_to_object (archetype::find (arch_string));
1585 1479
1586 tmp1->x = op->x; 1480 tmp1->x = op->x;
1587 tmp1->y = op->y; 1481 tmp1->y = op->y;
1588 insert_ob_in_map (tmp1, op->map, op, 0); 1482 insert_ob_in_map (tmp1, op->map, op, 0);
1483}
1484
1485object *
1486object::insert_at (object *where, object *originator, int flags)
1487{
1488 return where->map->insert (this, where->x, where->y, originator, flags);
1589} 1489}
1590 1490
1591/* 1491/*
1592 * get_split_ob(ob,nr) splits up ob into two parts. The part which 1492 * get_split_ob(ob,nr) splits up ob into two parts. The part which
1593 * is returned contains nr objects, and the remaining parts contains 1493 * is returned contains nr objects, and the remaining parts contains
1594 * the rest (or is removed and freed if that number is 0). 1494 * the rest (or is removed and freed if that number is 0).
1595 * On failure, NULL is returned, and the reason put into the 1495 * On failure, NULL is returned, and the reason put into the
1596 * global static errmsg array. 1496 * global static errmsg array.
1597 */ 1497 */
1598
1599object * 1498object *
1600get_split_ob (object *orig_ob, uint32 nr) 1499get_split_ob (object *orig_ob, uint32 nr)
1601{ 1500{
1602 object * 1501 object *newob;
1603 newob;
1604 int
1605 is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0); 1502 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1606 1503
1607 if (orig_ob->nrof < nr) 1504 if (orig_ob->nrof < nr)
1608 { 1505 {
1609 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name); 1506 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1610 return NULL; 1507 return NULL;
1611 } 1508 }
1612 1509
1613 newob = object_create_clone (orig_ob); 1510 newob = object_create_clone (orig_ob);
1614 1511
1615 if ((orig_ob->nrof -= nr) < 1) 1512 if ((orig_ob->nrof -= nr) < 1)
1616 { 1513 orig_ob->destroy (1);
1617 if (!is_removed)
1618 remove_ob (orig_ob);
1619 free_object2 (orig_ob, 1);
1620 }
1621 else if (!is_removed) 1514 else if (!is_removed)
1622 { 1515 {
1623 if (orig_ob->env != NULL) 1516 if (orig_ob->env != NULL)
1624 sub_weight (orig_ob->env, orig_ob->weight * nr); 1517 sub_weight (orig_ob->env, orig_ob->weight * nr);
1625 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY) 1518 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY)
… …
1640 * the amount of an object. If the amount reaches 0, the object 1533 * the amount of an object. If the amount reaches 0, the object
1641 * is subsequently removed and freed. 1534 * is subsequently removed and freed.
1642 * 1535 *
1643 * Return value: 'op' if something is left, NULL if the amount reached 0 1536 * Return value: 'op' if something is left, NULL if the amount reached 0
1644 */ 1537 */
1645
1646object * 1538object *
1647decrease_ob_nr (object *op, uint32 i) 1539decrease_ob_nr (object *op, uint32 i)
1648{ 1540{
1649 object *tmp; 1541 object *tmp;
1650 player *pl;
1651 1542
1652 if (i == 0) /* objects with op->nrof require this check */ 1543 if (i == 0) /* objects with op->nrof require this check */
1653 return op; 1544 return op;
1654 1545
1655 if (i > op->nrof) 1546 if (i > op->nrof)
1656 i = op->nrof; 1547 i = op->nrof;
1657 1548
1658 if (QUERY_FLAG (op, FLAG_REMOVED)) 1549 if (QUERY_FLAG (op, FLAG_REMOVED))
1659 op->nrof -= i; 1550 op->nrof -= i;
1660 else if (op->env != NULL) 1551 else if (op->env)
1661 { 1552 {
1662 /* is this object in the players inventory, or sub container 1553 /* is this object in the players inventory, or sub container
1663 * therein? 1554 * therein?
1664 */ 1555 */
1665 tmp = is_player_inv (op->env); 1556 tmp = op->in_player ();
1666 /* nope. Is this a container the player has opened? 1557 /* nope. Is this a container the player has opened?
1667 * If so, set tmp to that player. 1558 * If so, set tmp to that player.
1668 * IMO, searching through all the players will mostly 1559 * IMO, searching through all the players will mostly
1669 * likely be quicker than following op->env to the map, 1560 * likely be quicker than following op->env to the map,
1670 * and then searching the map for a player. 1561 * and then searching the map for a player.
1671 */ 1562 */
1672 if (!tmp) 1563 if (!tmp)
1673 { 1564 for_all_players (pl)
1674 for (pl = first_player; pl; pl = pl->next)
1675 if (pl->ob->container == op->env) 1565 if (pl->ob->container == op->env)
1566 {
1567 tmp = pl->ob;
1676 break; 1568 break;
1677 if (pl)
1678 tmp = pl->ob;
1679 else
1680 tmp = NULL;
1681 } 1569 }
1682 1570
1683 if (i < op->nrof) 1571 if (i < op->nrof)
1684 { 1572 {
1685 sub_weight (op->env, op->weight * i); 1573 sub_weight (op->env, op->weight * i);
1686 op->nrof -= i; 1574 op->nrof -= i;
1687 if (tmp) 1575 if (tmp)
1688 {
1689 esrv_send_item (tmp, op); 1576 esrv_send_item (tmp, op);
1690 }
1691 } 1577 }
1692 else 1578 else
1693 { 1579 {
1694 remove_ob (op); 1580 op->remove ();
1695 op->nrof = 0; 1581 op->nrof = 0;
1696 if (tmp) 1582 if (tmp)
1697 {
1698 esrv_del_item (tmp->contr, op->count); 1583 esrv_del_item (tmp->contr, op->count);
1699 }
1700 } 1584 }
1701 } 1585 }
1702 else 1586 else
1703 { 1587 {
1704 object *above = op->above; 1588 object *above = op->above;
1705 1589
1706 if (i < op->nrof) 1590 if (i < op->nrof)
1707 op->nrof -= i; 1591 op->nrof -= i;
1708 else 1592 else
1709 { 1593 {
1710 remove_ob (op); 1594 op->remove ();
1711 op->nrof = 0; 1595 op->nrof = 0;
1712 } 1596 }
1713 1597
1714 /* Since we just removed op, op->above is null */ 1598 /* Since we just removed op, op->above is null */
1715 for (tmp = above; tmp != NULL; tmp = tmp->above) 1599 for (tmp = above; tmp; tmp = tmp->above)
1716 if (tmp->type == PLAYER) 1600 if (tmp->type == PLAYER)
1717 { 1601 {
1718 if (op->nrof) 1602 if (op->nrof)
1719 esrv_send_item (tmp, op); 1603 esrv_send_item (tmp, op);
1720 else 1604 else
… …
1724 1608
1725 if (op->nrof) 1609 if (op->nrof)
1726 return op; 1610 return op;
1727 else 1611 else
1728 { 1612 {
1729 free_object (op); 1613 op->destroy ();
1730 return NULL; 1614 return 0;
1731 } 1615 }
1732} 1616}
1733 1617
1734/* 1618/*
1735 * add_weight(object, weight) adds the specified weight to an object, 1619 * add_weight(object, weight) adds the specified weight to an object,
1736 * and also updates how much the environment(s) is/are carrying. 1620 * and also updates how much the environment(s) is/are carrying.
1737 */ 1621 */
1738
1739void 1622void
1740add_weight (object *op, signed long weight) 1623add_weight (object *op, signed long weight)
1741{ 1624{
1742 while (op != NULL) 1625 while (op != NULL)
1743 { 1626 {
… …
1747 op->carrying += weight; 1630 op->carrying += weight;
1748 op = op->env; 1631 op = op->env;
1749 } 1632 }
1750} 1633}
1751 1634
1752/*
1753 * insert_ob_in_ob(op,environment):
1754 * This function inserts the object op in the linked list
1755 * inside the object environment.
1756 *
1757 * Eneq(@csd.uu.se): Altered insert_ob_in_ob to make things picked up enter
1758 * the inventory at the last position or next to other objects of the same
1759 * type.
1760 * Frank: Now sorted by type, archetype and magic!
1761 *
1762 * The function returns now pointer to inserted item, and return value can
1763 * be != op, if items are merged. -Tero
1764 */
1765
1766object * 1635object *
1767insert_ob_in_ob (object *op, object *where) 1636insert_ob_in_ob (object *op, object *where)
1768{ 1637{
1769 object * 1638 if (!where)
1770 tmp, *
1771 otmp;
1772
1773 if (!QUERY_FLAG (op, FLAG_REMOVED))
1774 {
1775 char *dump = dump_object (op);
1776 LOG (llevError, "Trying to insert (ob) inserted object.\n%s\n", dump);
1777 free (dump);
1778 return op;
1779 }
1780
1781 if (where == NULL)
1782 { 1639 {
1783 char *dump = dump_object (op); 1640 char *dump = dump_object (op);
1784 LOG (llevError, "Trying to put object in NULL.\n%s\n", dump); 1641 LOG (llevError, "Trying to put object in NULL.\n%s\n", dump);
1785 free (dump); 1642 free (dump);
1786 return op; 1643 return op;
1787 } 1644 }
1788 1645
1789 if (where->head) 1646 if (where->head)
1790 { 1647 {
1791 LOG (llevDebug, "Warning: Tried to insert object wrong part of multipart object.\n"); 1648 LOG (llevDebug, "Warning: Tried to insert object into wrong part of multipart object.\n");
1792 where = where->head; 1649 where = where->head;
1793 } 1650 }
1651
1652 return where->insert (op);
1653}
1654
1655/*
1656 * env->insert (op)
1657 * This function inserts the object op in the linked list
1658 * inside the object environment.
1659 *
1660 * The function returns now pointer to inserted item, and return value can
1661 * be != op, if items are merged. -Tero
1662 */
1663object *
1664object::insert (object *op)
1665{
1666 object *tmp, *otmp;
1667
1668 if (!QUERY_FLAG (op, FLAG_REMOVED))
1669 op->remove ();
1794 1670
1795 if (op->more) 1671 if (op->more)
1796 { 1672 {
1797 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count); 1673 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);
1798 return op; 1674 return op;
… …
1800 1676
1801 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL); 1677 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL);
1802 CLEAR_FLAG (op, FLAG_REMOVED); 1678 CLEAR_FLAG (op, FLAG_REMOVED);
1803 if (op->nrof) 1679 if (op->nrof)
1804 { 1680 {
1805 for (tmp = where->inv; tmp != NULL; tmp = tmp->below) 1681 for (tmp = inv; tmp != NULL; tmp = tmp->below)
1806 if (CAN_MERGE (tmp, op)) 1682 if (object::can_merge (tmp, op))
1807 { 1683 {
1808 /* return the original object and remove inserted object 1684 /* return the original object and remove inserted object
1809 (client needs the original object) */ 1685 (client needs the original object) */
1810 tmp->nrof += op->nrof; 1686 tmp->nrof += op->nrof;
1811 /* Weight handling gets pretty funky. Since we are adding to 1687 /* Weight handling gets pretty funky. Since we are adding to
1812 * tmp->nrof, we need to increase the weight. 1688 * tmp->nrof, we need to increase the weight.
1813 */ 1689 */
1814 add_weight (where, op->weight * op->nrof); 1690 add_weight (this, op->weight * op->nrof);
1815 SET_FLAG (op, FLAG_REMOVED); 1691 SET_FLAG (op, FLAG_REMOVED);
1816 free_object (op); /* free the inserted object */ 1692 op->destroy (); /* free the inserted object */
1817 op = tmp; 1693 op = tmp;
1818 remove_ob (op); /* and fix old object's links */ 1694 op->remove (); /* and fix old object's links */
1819 CLEAR_FLAG (op, FLAG_REMOVED); 1695 CLEAR_FLAG (op, FLAG_REMOVED);
1820 break; 1696 break;
1821 } 1697 }
1822 1698
1823 /* I assume combined objects have no inventory 1699 /* I assume combined objects have no inventory
1824 * We add the weight - this object could have just been removed 1700 * We add the weight - this object could have just been removed
1825 * (if it was possible to merge). calling remove_ob will subtract 1701 * (if it was possible to merge). calling remove_ob will subtract
1826 * the weight, so we need to add it in again, since we actually do 1702 * the weight, so we need to add it in again, since we actually do
1827 * the linking below 1703 * the linking below
1828 */ 1704 */
1829 add_weight (where, op->weight * op->nrof); 1705 add_weight (this, op->weight * op->nrof);
1830 } 1706 }
1831 else 1707 else
1832 add_weight (where, (op->weight + op->carrying)); 1708 add_weight (this, (op->weight + op->carrying));
1833 1709
1834 otmp = is_player_inv (where); 1710 otmp = this->in_player ();
1835 if (otmp && otmp->contr != NULL) 1711 if (otmp && otmp->contr)
1836 {
1837 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1712 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1838 fix_player (otmp); 1713 otmp->update_stats ();
1839 }
1840 1714
1841 op->map = NULL; 1715 op->map = 0;
1842 op->env = where; 1716 op->env = this;
1843 op->above = NULL; 1717 op->above = 0;
1844 op->below = NULL; 1718 op->below = 0;
1845 op->x = 0, op->y = 0; 1719 op->x = 0, op->y = 0;
1846 1720
1847 /* reset the light list and los of the players on the map */ 1721 /* reset the light list and los of the players on the map */
1848 if ((op->glow_radius != 0) && where->map) 1722 if ((op->glow_radius != 0) && map)
1849 { 1723 {
1850#ifdef DEBUG_LIGHTS 1724#ifdef DEBUG_LIGHTS
1851 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name); 1725 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1852#endif /* DEBUG_LIGHTS */ 1726#endif /* DEBUG_LIGHTS */
1853 if (MAP_DARKNESS (where->map)) 1727 if (map->darkness)
1854 update_all_los (where->map, where->x, where->y); 1728 update_all_los (map, x, y);
1855 } 1729 }
1856 1730
1857 /* Client has no idea of ordering so lets not bother ordering it here. 1731 /* Client has no idea of ordering so lets not bother ordering it here.
1858 * It sure simplifies this function... 1732 * It sure simplifies this function...
1859 */ 1733 */
1860 if (where->inv == NULL) 1734 if (!inv)
1861 where->inv = op; 1735 inv = op;
1862 else 1736 else
1863 { 1737 {
1864 op->below = where->inv; 1738 op->below = inv;
1865 op->below->above = op; 1739 op->below->above = op;
1866 where->inv = op; 1740 inv = op;
1867 } 1741 }
1742
1743 INVOKE_OBJECT (INSERT, this);
1744
1868 return op; 1745 return op;
1869} 1746}
1870 1747
1871/* 1748/*
1872 * Checks if any objects has a move_type that matches objects 1749 * Checks if any objects has a move_type that matches objects
… …
1886 * 1763 *
1887 * MSW 2001-07-08: Check all objects on space, not just those below 1764 * MSW 2001-07-08: Check all objects on space, not just those below
1888 * object being inserted. insert_ob_in_map may not put new objects 1765 * object being inserted. insert_ob_in_map may not put new objects
1889 * on top. 1766 * on top.
1890 */ 1767 */
1891
1892int 1768int
1893check_move_on (object *op, object *originator) 1769check_move_on (object *op, object *originator)
1894{ 1770{
1895 object *tmp; 1771 object *tmp;
1896 maptile *m = op->map; 1772 maptile *m = op->map;
… …
1923 1799
1924 /* The objects have to be checked from top to bottom. 1800 /* The objects have to be checked from top to bottom.
1925 * Hence, we first go to the top: 1801 * Hence, we first go to the top:
1926 */ 1802 */
1927 1803
1928 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL && tmp->above != NULL; tmp = tmp->above) 1804 for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1929 { 1805 {
1930 /* Trim the search when we find the first other spell effect 1806 /* Trim the search when we find the first other spell effect
1931 * this helps performance so that if a space has 50 spell objects, 1807 * this helps performance so that if a space has 50 spell objects,
1932 * we don't need to check all of them. 1808 * we don't need to check all of them.
1933 */ 1809 */
… …
1951 if ((!op->move_type && tmp->move_slow & MOVE_WALK) || 1827 if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
1952 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0)) 1828 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
1953 { 1829 {
1954 1830
1955 float 1831 float
1956 diff = tmp->move_slow_penalty * FABS (op->speed); 1832 diff = tmp->move_slow_penalty * fabs (op->speed);
1957 1833
1958 if (op->type == PLAYER) 1834 if (op->type == PLAYER)
1959 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) || 1835 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) ||
1960 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN))) 1836 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN)))
1961 diff /= 4.0; 1837 diff /= 4.0;
… …
1988/* 1864/*
1989 * present_arch(arch, map, x, y) searches for any objects with 1865 * present_arch(arch, map, x, y) searches for any objects with
1990 * a matching archetype at the given map and coordinates. 1866 * a matching archetype at the given map and coordinates.
1991 * The first matching object is returned, or NULL if none. 1867 * The first matching object is returned, or NULL if none.
1992 */ 1868 */
1993
1994object * 1869object *
1995present_arch (const archetype *at, maptile *m, int x, int y) 1870present_arch (const archetype *at, maptile *m, int x, int y)
1996{ 1871{
1997 object *
1998 tmp;
1999
2000 if (m == NULL || out_of_map (m, x, y)) 1872 if (!m || out_of_map (m, x, y))
2001 { 1873 {
2002 LOG (llevError, "Present_arch called outside map.\n"); 1874 LOG (llevError, "Present_arch called outside map.\n");
2003 return NULL; 1875 return NULL;
2004 } 1876 }
2005 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1877
1878 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
2006 if (tmp->arch == at) 1879 if (tmp->arch == at)
2007 return tmp; 1880 return tmp;
1881
2008 return NULL; 1882 return NULL;
2009} 1883}
2010 1884
2011/* 1885/*
2012 * present(type, map, x, y) searches for any objects with 1886 * present(type, map, x, y) searches for any objects with
2013 * a matching type variable at the given map and coordinates. 1887 * a matching type variable at the given map and coordinates.
2014 * The first matching object is returned, or NULL if none. 1888 * The first matching object is returned, or NULL if none.
2015 */ 1889 */
2016
2017object * 1890object *
2018present (unsigned char type, maptile *m, int x, int y) 1891present (unsigned char type, maptile *m, int x, int y)
2019{ 1892{
2020 object *
2021 tmp;
2022
2023 if (out_of_map (m, x, y)) 1893 if (out_of_map (m, x, y))
2024 { 1894 {
2025 LOG (llevError, "Present called outside map.\n"); 1895 LOG (llevError, "Present called outside map.\n");
2026 return NULL; 1896 return NULL;
2027 } 1897 }
2028 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1898
1899 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
2029 if (tmp->type == type) 1900 if (tmp->type == type)
2030 return tmp; 1901 return tmp;
1902
2031 return NULL; 1903 return NULL;
2032} 1904}
2033 1905
2034/* 1906/*
2035 * present_in_ob(type, object) searches for any objects with 1907 * present_in_ob(type, object) searches for any objects with
2036 * a matching type variable in the inventory of the given object. 1908 * a matching type variable in the inventory of the given object.
2037 * The first matching object is returned, or NULL if none. 1909 * The first matching object is returned, or NULL if none.
2038 */ 1910 */
2039
2040object * 1911object *
2041present_in_ob (unsigned char type, const object *op) 1912present_in_ob (unsigned char type, const object *op)
2042{ 1913{
2043 object *
2044 tmp;
2045
2046 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1914 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2047 if (tmp->type == type) 1915 if (tmp->type == type)
2048 return tmp; 1916 return tmp;
1917
2049 return NULL; 1918 return NULL;
2050} 1919}
2051 1920
2052/* 1921/*
2053 * present_in_ob (type, str, object) searches for any objects with 1922 * present_in_ob (type, str, object) searches for any objects with
… …
2061 * str is the string to match against. Note that we match against 1930 * str is the string to match against. Note that we match against
2062 * the object name, not the archetype name. this is so that the 1931 * the object name, not the archetype name. this is so that the
2063 * spell code can use one object type (force), but change it's name 1932 * spell code can use one object type (force), but change it's name
2064 * to be unique. 1933 * to be unique.
2065 */ 1934 */
2066
2067object * 1935object *
2068present_in_ob_by_name (int type, const char *str, const object *op) 1936present_in_ob_by_name (int type, const char *str, const object *op)
2069{ 1937{
2070 object *
2071 tmp;
2072
2073 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1938 for (object *tmp = op->inv; tmp; tmp = tmp->below)
2074 {
2075 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name))) 1939 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name)))
2076 return tmp; 1940 return tmp;
2077 } 1941
2078 return NULL; 1942 return 0;
2079} 1943}
2080 1944
2081/* 1945/*
2082 * present_arch_in_ob(archetype, object) searches for any objects with 1946 * present_arch_in_ob(archetype, object) searches for any objects with
2083 * a matching archetype in the inventory of the given object. 1947 * a matching archetype in the inventory of the given object.
2084 * The first matching object is returned, or NULL if none. 1948 * The first matching object is returned, or NULL if none.
2085 */ 1949 */
2086
2087object * 1950object *
2088present_arch_in_ob (const archetype *at, const object *op) 1951present_arch_in_ob (const archetype *at, const object *op)
2089{ 1952{
2090 object *
2091 tmp;
2092
2093 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1953 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2094 if (tmp->arch == at) 1954 if (tmp->arch == at)
2095 return tmp; 1955 return tmp;
1956
2096 return NULL; 1957 return NULL;
2097} 1958}
2098 1959
2099/* 1960/*
2100 * activate recursively a flag on an object inventory 1961 * activate recursively a flag on an object inventory
2101 */ 1962 */
2102void 1963void
2103flag_inv (object *op, int flag) 1964flag_inv (object *op, int flag)
2104{ 1965{
2105 object *
2106 tmp;
2107
2108 if (op->inv) 1966 if (op->inv)
2109 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1967 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2110 { 1968 {
2111 SET_FLAG (tmp, flag); 1969 SET_FLAG (tmp, flag);
2112 flag_inv (tmp, flag); 1970 flag_inv (tmp, flag);
2113 } 1971 }
2114} /* 1972}
1973
1974/*
2115 * desactivate recursively a flag on an object inventory 1975 * deactivate recursively a flag on an object inventory
2116 */ 1976 */
2117void 1977void
2118unflag_inv (object *op, int flag) 1978unflag_inv (object *op, int flag)
2119{ 1979{
2120 object *
2121 tmp;
2122
2123 if (op->inv) 1980 if (op->inv)
2124 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1981 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2125 { 1982 {
2126 CLEAR_FLAG (tmp, flag); 1983 CLEAR_FLAG (tmp, flag);
2127 unflag_inv (tmp, flag); 1984 unflag_inv (tmp, flag);
2128 } 1985 }
2129} 1986}
… …
2132 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in 1989 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in
2133 * all it's inventory (recursively). 1990 * all it's inventory (recursively).
2134 * If checksums are used, a player will get set_cheat called for 1991 * If checksums are used, a player will get set_cheat called for
2135 * him/her-self and all object carried by a call to this function. 1992 * him/her-self and all object carried by a call to this function.
2136 */ 1993 */
2137
2138void 1994void
2139set_cheat (object *op) 1995set_cheat (object *op)
2140{ 1996{
2141 SET_FLAG (op, FLAG_WAS_WIZ); 1997 SET_FLAG (op, FLAG_WAS_WIZ);
2142 flag_inv (op, FLAG_WAS_WIZ); 1998 flag_inv (op, FLAG_WAS_WIZ);
… …
2161 * because arch_blocked (now ob_blocked) needs to know the movement type 2017 * because arch_blocked (now ob_blocked) needs to know the movement type
2162 * to know if the space in question will block the object. We can't use 2018 * to know if the space in question will block the object. We can't use
2163 * the archetype because that isn't correct if the monster has been 2019 * the archetype because that isn't correct if the monster has been
2164 * customized, changed states, etc. 2020 * customized, changed states, etc.
2165 */ 2021 */
2166
2167int 2022int
2168find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop) 2023find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)
2169{ 2024{
2170 int
2171 i,
2172 index = 0, flag; 2025 int index = 0, flag;
2173 static int
2174 altern[SIZEOFFREE]; 2026 int altern[SIZEOFFREE];
2175 2027
2176 for (i = start; i < stop; i++) 2028 for (int i = start; i < stop; i++)
2177 { 2029 {
2178 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]); 2030 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]);
2179 if (!flag) 2031 if (!flag)
2180 altern[index++] = i; 2032 altern [index++] = i;
2181 2033
2182 /* Basically, if we find a wall on a space, we cut down the search size. 2034 /* Basically, if we find a wall on a space, we cut down the search size.
2183 * In this way, we won't return spaces that are on another side of a wall. 2035 * In this way, we won't return spaces that are on another side of a wall.
2184 * This mostly work, but it cuts down the search size in all directions - 2036 * This mostly work, but it cuts down the search size in all directions -
2185 * if the space being examined only has a wall to the north and empty 2037 * if the space being examined only has a wall to the north and empty
2186 * spaces in all the other directions, this will reduce the search space 2038 * spaces in all the other directions, this will reduce the search space
2187 * to only the spaces immediately surrounding the target area, and 2039 * to only the spaces immediately surrounding the target area, and
2188 * won't look 2 spaces south of the target space. 2040 * won't look 2 spaces south of the target space.
2189 */ 2041 */
2190 else if ((flag & AB_NO_PASS) && maxfree[i] < stop) 2042 else if ((flag & P_NO_PASS) && maxfree[i] < stop)
2191 stop = maxfree[i]; 2043 stop = maxfree[i];
2192 } 2044 }
2045
2193 if (!index) 2046 if (!index)
2194 return -1; 2047 return -1;
2048
2195 return altern[RANDOM () % index]; 2049 return altern [rndm (index)];
2196} 2050}
2197 2051
2198/* 2052/*
2199 * find_first_free_spot(archetype, maptile, x, y) works like 2053 * find_first_free_spot(archetype, maptile, x, y) works like
2200 * find_free_spot(), but it will search max number of squares. 2054 * find_free_spot(), but it will search max number of squares.
2201 * But it will return the first available spot, not a random choice. 2055 * But it will return the first available spot, not a random choice.
2202 * Changed 0.93.2: Have it return -1 if there is no free spot available. 2056 * Changed 0.93.2: Have it return -1 if there is no free spot available.
2203 */ 2057 */
2204
2205int 2058int
2206find_first_free_spot (const object *ob, maptile *m, int x, int y) 2059find_first_free_spot (const object *ob, maptile *m, int x, int y)
2207{ 2060{
2208 int
2209 i;
2210
2211 for (i = 0; i < SIZEOFFREE; i++) 2061 for (int i = 0; i < SIZEOFFREE; i++)
2212 {
2213 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i])) 2062 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]))
2214 return i; 2063 return i;
2215 } 2064
2216 return -1; 2065 return -1;
2217} 2066}
2218 2067
2219/* 2068/*
2220 * The function permute(arr, begin, end) randomly reorders the array 2069 * The function permute(arr, begin, end) randomly reorders the array
2221 * arr[begin..end-1]. 2070 * arr[begin..end-1].
2071 * now uses a fisher-yates shuffle, old permute was broken
2222 */ 2072 */
2223static void 2073static void
2224permute (int *arr, int begin, int end) 2074permute (int *arr, int begin, int end)
2225{ 2075{
2226 int 2076 arr += begin;
2227 i,
2228 j,
2229 tmp,
2230 len;
2231
2232 len = end - begin; 2077 end -= begin;
2233 for (i = begin; i < end; i++)
2234 {
2235 j = begin + RANDOM () % len;
2236 2078
2237 tmp = arr[i]; 2079 while (--end)
2238 arr[i] = arr[j]; 2080 swap (arr [end], arr [rndm (end + 1)]);
2239 arr[j] = tmp;
2240 }
2241} 2081}
2242 2082
2243/* new function to make monster searching more efficient, and effective! 2083/* new function to make monster searching more efficient, and effective!
2244 * This basically returns a randomized array (in the passed pointer) of 2084 * This basically returns a randomized array (in the passed pointer) of
2245 * the spaces to find monsters. In this way, it won't always look for 2085 * the spaces to find monsters. In this way, it won't always look for
… …
2248 * the 3x3 area will be searched, just not in a predictable order. 2088 * the 3x3 area will be searched, just not in a predictable order.
2249 */ 2089 */
2250void 2090void
2251get_search_arr (int *search_arr) 2091get_search_arr (int *search_arr)
2252{ 2092{
2253 int 2093 int i;
2254 i;
2255 2094
2256 for (i = 0; i < SIZEOFFREE; i++) 2095 for (i = 0; i < SIZEOFFREE; i++)
2257 {
2258 search_arr[i] = i; 2096 search_arr[i] = i;
2259 }
2260 2097
2261 permute (search_arr, 1, SIZEOFFREE1 + 1); 2098 permute (search_arr, 1, SIZEOFFREE1 + 1);
2262 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1); 2099 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1);
2263 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE); 2100 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE);
2264} 2101}
… …
2273 * Perhaps incorrectly, but I'm making the assumption that exclude 2110 * Perhaps incorrectly, but I'm making the assumption that exclude
2274 * is actually want is going to try and move there. We need this info 2111 * is actually want is going to try and move there. We need this info
2275 * because we have to know what movement the thing looking to move 2112 * because we have to know what movement the thing looking to move
2276 * there is capable of. 2113 * there is capable of.
2277 */ 2114 */
2278
2279int 2115int
2280find_dir (maptile *m, int x, int y, object *exclude) 2116find_dir (maptile *m, int x, int y, object *exclude)
2281{ 2117{
2282 int
2283 i,
2284 max = SIZEOFFREE, mflags; 2118 int i, max = SIZEOFFREE, mflags;
2285 2119
2286 sint16 nx, ny; 2120 sint16 nx, ny;
2287 object * 2121 object *tmp;
2288 tmp;
2289 maptile * 2122 maptile *mp;
2290 mp;
2291 2123
2292 MoveType blocked, move_type; 2124 MoveType blocked, move_type;
2293 2125
2294 if (exclude && exclude->head) 2126 if (exclude && exclude->head)
2295 { 2127 {
… …
2307 mp = m; 2139 mp = m;
2308 nx = x + freearr_x[i]; 2140 nx = x + freearr_x[i];
2309 ny = y + freearr_y[i]; 2141 ny = y + freearr_y[i];
2310 2142
2311 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2143 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);
2144
2312 if (mflags & P_OUT_OF_MAP) 2145 if (mflags & P_OUT_OF_MAP)
2313 {
2314 max = maxfree[i]; 2146 max = maxfree[i];
2315 }
2316 else 2147 else
2317 { 2148 {
2318 blocked = GET_MAP_MOVE_BLOCK (mp, nx, ny); 2149 mapspace &ms = mp->at (nx, ny);
2150
2151 blocked = ms.move_block;
2319 2152
2320 if ((move_type & blocked) == move_type) 2153 if ((move_type & blocked) == move_type)
2321 {
2322 max = maxfree[i]; 2154 max = maxfree[i];
2323 }
2324 else if (mflags & P_IS_ALIVE) 2155 else if (mflags & P_IS_ALIVE)
2325 { 2156 {
2326 for (tmp = GET_MAP_OB (mp, nx, ny); tmp != NULL; tmp = tmp->above) 2157 for (tmp = ms.bot; tmp; tmp = tmp->above)
2327 { 2158 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)
2328 if ((QUERY_FLAG (tmp, FLAG_MONSTER) || tmp->type == PLAYER) && (tmp != exclude || (tmp->head && tmp->head != exclude))) 2159 && (tmp != exclude || (tmp->head && tmp->head != exclude)))
2329 {
2330 break; 2160 break;
2331 } 2161
2332 }
2333 if (tmp) 2162 if (tmp)
2334 {
2335 return freedir[i]; 2163 return freedir[i];
2336 }
2337 } 2164 }
2338 } 2165 }
2339 } 2166 }
2167
2340 return 0; 2168 return 0;
2341} 2169}
2342 2170
2343/* 2171/*
2344 * distance(object 1, object 2) will return the square of the 2172 * distance(object 1, object 2) will return the square of the
2345 * distance between the two given objects. 2173 * distance between the two given objects.
2346 */ 2174 */
2347
2348int 2175int
2349distance (const object *ob1, const object *ob2) 2176distance (const object *ob1, const object *ob2)
2350{ 2177{
2351 int
2352 i;
2353
2354 i = (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y); 2178 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2355 return i;
2356} 2179}
2357 2180
2358/* 2181/*
2359 * find_dir_2(delta-x,delta-y) will return a direction in which 2182 * find_dir_2(delta-x,delta-y) will return a direction in which
2360 * an object which has subtracted the x and y coordinates of another 2183 * an object which has subtracted the x and y coordinates of another
2361 * object, needs to travel toward it. 2184 * object, needs to travel toward it.
2362 */ 2185 */
2363
2364int 2186int
2365find_dir_2 (int x, int y) 2187find_dir_2 (int x, int y)
2366{ 2188{
2367 int 2189 int q;
2368 q;
2369 2190
2370 if (y) 2191 if (y)
2371 q = x * 100 / y; 2192 q = x * 100 / y;
2372 else if (x) 2193 else if (x)
2373 q = -300 * x; 2194 q = -300 * x;
… …
2398 2219
2399 return 3; 2220 return 3;
2400} 2221}
2401 2222
2402/* 2223/*
2403 * absdir(int): Returns a number between 1 and 8, which represent
2404 * the "absolute" direction of a number (it actually takes care of
2405 * "overflow" in previous calculations of a direction).
2406 */
2407
2408int
2409absdir (int d)
2410{
2411 while (d < 1)
2412 d += 8;
2413 while (d > 8)
2414 d -= 8;
2415 return d;
2416}
2417
2418/*
2419 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is 2224 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is
2420 * between two directions (which are expected to be absolute (see absdir()) 2225 * between two directions (which are expected to be absolute (see absdir())
2421 */ 2226 */
2422
2423int 2227int
2424dirdiff (int dir1, int dir2) 2228dirdiff (int dir1, int dir2)
2425{ 2229{
2426 int 2230 int d;
2427 d;
2428 2231
2429 d = abs (dir1 - dir2); 2232 d = abs (dir1 - dir2);
2430 if (d > 4) 2233 if (d > 4)
2431 d = 8 - d; 2234 d = 8 - d;
2235
2432 return d; 2236 return d;
2433} 2237}
2434 2238
2435/* peterm: 2239/* peterm:
2436 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster. 2240 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster.
… …
2439 * This basically means that if direction is 15, then it could either go 2243 * This basically means that if direction is 15, then it could either go
2440 * direction 4, 14, or 16 to get back to where we are. 2244 * direction 4, 14, or 16 to get back to where we are.
2441 * Moved from spell_util.c to object.c with the other related direction 2245 * Moved from spell_util.c to object.c with the other related direction
2442 * functions. 2246 * functions.
2443 */ 2247 */
2444
2445int
2446 reduction_dir[SIZEOFFREE][3] = { 2248int reduction_dir[SIZEOFFREE][3] = {
2447 {0, 0, 0}, /* 0 */ 2249 {0, 0, 0}, /* 0 */
2448 {0, 0, 0}, /* 1 */ 2250 {0, 0, 0}, /* 1 */
2449 {0, 0, 0}, /* 2 */ 2251 {0, 0, 0}, /* 2 */
2450 {0, 0, 0}, /* 3 */ 2252 {0, 0, 0}, /* 3 */
2451 {0, 0, 0}, /* 4 */ 2253 {0, 0, 0}, /* 4 */
… …
2499 * find a path to that monster that we found. If not, 2301 * find a path to that monster that we found. If not,
2500 * we don't bother going toward it. Returns 1 if we 2302 * we don't bother going toward it. Returns 1 if we
2501 * can see a direct way to get it 2303 * can see a direct way to get it
2502 * Modified to be map tile aware -.MSW 2304 * Modified to be map tile aware -.MSW
2503 */ 2305 */
2504
2505
2506int 2306int
2507can_see_monsterP (maptile *m, int x, int y, int dir) 2307can_see_monsterP (maptile *m, int x, int y, int dir)
2508{ 2308{
2509 sint16 dx, dy; 2309 sint16 dx, dy;
2510 int
2511 mflags; 2310 int mflags;
2512 2311
2513 if (dir < 0) 2312 if (dir < 0)
2514 return 0; /* exit condition: invalid direction */ 2313 return 0; /* exit condition: invalid direction */
2515 2314
2516 dx = x + freearr_x[dir]; 2315 dx = x + freearr_x[dir];
… …
2529 return 0; 2328 return 0;
2530 2329
2531 /* yes, can see. */ 2330 /* yes, can see. */
2532 if (dir < 9) 2331 if (dir < 9)
2533 return 1; 2332 return 1;
2333
2534 return can_see_monsterP (m, x, y, reduction_dir[dir][0]) | 2334 return can_see_monsterP (m, x, y, reduction_dir[dir][0])
2535 can_see_monsterP (m, x, y, reduction_dir[dir][1]) | can_see_monsterP (m, x, y, reduction_dir[dir][2]); 2335 | can_see_monsterP (m, x, y, reduction_dir[dir][1])
2336 | can_see_monsterP (m, x, y, reduction_dir[dir][2]);
2536} 2337}
2537
2538
2539 2338
2540/* 2339/*
2541 * can_pick(picker, item): finds out if an object is possible to be 2340 * can_pick(picker, item): finds out if an object is possible to be
2542 * picked up by the picker. Returnes 1 if it can be 2341 * picked up by the picker. Returnes 1 if it can be
2543 * picked up, otherwise 0. 2342 * picked up, otherwise 0.
… …
2554 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2353 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2555 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2354 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2556 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2355 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));
2557} 2356}
2558 2357
2559
2560/* 2358/*
2561 * create clone from object to another 2359 * create clone from object to another
2562 */ 2360 */
2563object * 2361object *
2564object_create_clone (object *asrc) 2362object_create_clone (object *asrc)
2565{ 2363{
2566 object *
2567 dst = NULL, *tmp, *src, *part, *prev, *item; 2364 object *dst = 0, *tmp, *src, *part, *prev, *item;
2568 2365
2569 if (!asrc) 2366 if (!asrc)
2570 return NULL; 2367 return 0;
2368
2571 src = asrc; 2369 src = asrc;
2572 if (src->head) 2370 if (src->head)
2573 src = src->head; 2371 src = src->head;
2574 2372
2575 prev = NULL; 2373 prev = 0;
2576 for (part = src; part; part = part->more) 2374 for (part = src; part; part = part->more)
2577 { 2375 {
2578 tmp = get_object (); 2376 tmp = part->clone ();
2579 copy_object (part, tmp);
2580 tmp->x -= src->x; 2377 tmp->x -= src->x;
2581 tmp->y -= src->y; 2378 tmp->y -= src->y;
2379
2582 if (!part->head) 2380 if (!part->head)
2583 { 2381 {
2584 dst = tmp; 2382 dst = tmp;
2585 tmp->head = NULL; 2383 tmp->head = 0;
2586 } 2384 }
2587 else 2385 else
2588 {
2589 tmp->head = dst; 2386 tmp->head = dst;
2590 } 2387
2591 tmp->more = NULL; 2388 tmp->more = 0;
2389
2592 if (prev) 2390 if (prev)
2593 prev->more = tmp; 2391 prev->more = tmp;
2392
2594 prev = tmp; 2393 prev = tmp;
2595 } 2394 }
2596 2395
2597 for (item = src->inv; item; item = item->below) 2396 for (item = src->inv; item; item = item->below)
2598 insert_ob_in_ob (object_create_clone (item), dst); 2397 insert_ob_in_ob (object_create_clone (item), dst);
2599 2398
2600 return dst; 2399 return dst;
2601}
2602
2603/* GROS - Creates an object using a string representing its content. */
2604/* Basically, we save the content of the string to a temp file, then call */
2605/* load_object on it. I admit it is a highly inefficient way to make things, */
2606/* but it was simple to make and allows reusing the load_object function. */
2607/* Remember not to use load_object_str in a time-critical situation. */
2608/* Also remember that multiparts objects are not supported for now. */
2609
2610object *
2611load_object_str (const char *obstr)
2612{
2613 object *op;
2614 char filename[MAX_BUF];
2615
2616 sprintf (filename, "%s/cfloadobstr2044", settings.tmpdir);
2617
2618 FILE *tempfile = fopen (filename, "w");
2619
2620 if (tempfile == NULL)
2621 {
2622 LOG (llevError, "Error - Unable to access load object temp file\n");
2623 return NULL;
2624 }
2625
2626 fprintf (tempfile, obstr);
2627 fclose (tempfile);
2628
2629 op = get_object ();
2630
2631 object_thawer thawer (filename);
2632
2633 if (thawer)
2634 load_object (thawer, op, 0);
2635
2636 LOG (llevDebug, " load str completed, object=%s\n", &op->name);
2637 CLEAR_FLAG (op, FLAG_REMOVED);
2638
2639 return op;
2640} 2400}
2641 2401
2642/* This returns the first object in who's inventory that 2402/* This returns the first object in who's inventory that
2643 * has the same type and subtype match. 2403 * has the same type and subtype match.
2644 * returns NULL if no match. 2404 * returns NULL if no match.
2645 */ 2405 */
2646object * 2406object *
2647find_obj_by_type_subtype (const object *who, int type, int subtype) 2407find_obj_by_type_subtype (const object *who, int type, int subtype)
2648{ 2408{
2649 object *tmp;
2650
2651 for (tmp = who->inv; tmp; tmp = tmp->below) 2409 for (object *tmp = who->inv; tmp; tmp = tmp->below)
2652 if (tmp->type == type && tmp->subtype == subtype) 2410 if (tmp->type == type && tmp->subtype == subtype)
2653 return tmp; 2411 return tmp;
2654 2412
2655 return NULL; 2413 return 0;
2656} 2414}
2657 2415
2658/* If ob has a field named key, return the link from the list, 2416/* If ob has a field named key, return the link from the list,
2659 * otherwise return NULL. 2417 * otherwise return NULL.
2660 * 2418 *
… …
2662 * do the desired thing. 2420 * do the desired thing.
2663 */ 2421 */
2664key_value * 2422key_value *
2665get_ob_key_link (const object *ob, const char *key) 2423get_ob_key_link (const object *ob, const char *key)
2666{ 2424{
2667 key_value *link;
2668
2669 for (link = ob->key_values; link != NULL; link = link->next) 2425 for (key_value *link = ob->key_values; link; link = link->next)
2670 if (link->key == key) 2426 if (link->key == key)
2671 return link; 2427 return link;
2672 2428
2673 return NULL; 2429 return 0;
2674} 2430}
2675 2431
2676/* 2432/*
2677 * Returns the value of op has an extra_field for key, or NULL. 2433 * Returns the value of op has an extra_field for key, or NULL.
2678 * 2434 *
… …
2703 if (link->key == canonical_key) 2459 if (link->key == canonical_key)
2704 return link->value; 2460 return link->value;
2705 2461
2706 return 0; 2462 return 0;
2707} 2463}
2708
2709 2464
2710/* 2465/*
2711 * Updates the canonical_key in op to value. 2466 * Updates the canonical_key in op to value.
2712 * 2467 *
2713 * canonical_key is a shared string (value doesn't have to be). 2468 * canonical_key is a shared string (value doesn't have to be).
… …
2718 * Returns TRUE on success. 2473 * Returns TRUE on success.
2719 */ 2474 */
2720int 2475int
2721set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key) 2476set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2722{ 2477{
2723 key_value *
2724 field = NULL, *last = NULL; 2478 key_value *field = NULL, *last = NULL;
2725 2479
2726 for (field = op->key_values; field != NULL; field = field->next) 2480 for (field = op->key_values; field != NULL; field = field->next)
2727 { 2481 {
2728 if (field->key != canonical_key) 2482 if (field->key != canonical_key)
2729 { 2483 {
… …
2757 /* IF we get here, key doesn't exist */ 2511 /* IF we get here, key doesn't exist */
2758 2512
2759 /* No field, we'll have to add it. */ 2513 /* No field, we'll have to add it. */
2760 2514
2761 if (!add_key) 2515 if (!add_key)
2762 {
2763 return FALSE; 2516 return FALSE;
2764 } 2517
2765 /* There isn't any good reason to store a null 2518 /* There isn't any good reason to store a null
2766 * value in the key/value list. If the archetype has 2519 * value in the key/value list. If the archetype has
2767 * this key, then we should also have it, so shouldn't 2520 * this key, then we should also have it, so shouldn't
2768 * be here. If user wants to store empty strings, 2521 * be here. If user wants to store empty strings,
2769 * should pass in "" 2522 * should pass in ""
… …
2818 } 2571 }
2819 else 2572 else
2820 item = item->env; 2573 item = item->env;
2821} 2574}
2822 2575
2576
2577const char *
2578object::flag_desc (char *desc, int len) const
2579{
2580 char *p = desc;
2581 bool first = true;
2582
2583 *p = 0;
2584
2585 for (int i = 0; i < NUM_FLAGS; i++)
2586 {
2587 if (len <= 10) // magic constant!
2588 {
2589 snprintf (p, len, ",...");
2590 break;
2591 }
2592
2593 if (flag [i])
2594 {
2595 int cnt = snprintf (p, len, "%s%d", first ? "" : ",", i);
2596 len -= cnt;
2597 p += cnt;
2598 first = false;
2599 }
2600 }
2601
2602 return desc;
2603}
2604
2823// return a suitable string describing an objetc in enough detail to find it 2605// return a suitable string describing an object in enough detail to find it
2824const char * 2606const char *
2825object::debug_desc (char *info) const 2607object::debug_desc (char *info) const
2826{ 2608{
2609 char flagdesc[512];
2827 char info2[256 * 3]; 2610 char info2[256 * 4];
2828 char *p = info; 2611 char *p = info;
2829 2612
2830 p += snprintf (p, 256, "%d=\"%s%s%s\"", 2613 p += snprintf (p, 512, "{cnt:%d,uuid:<1.%" PRIx64 ">,name:\"%s\"%s%s,flags:[%s],type:%d}",
2831 count, 2614 count, uuid.seq,
2832 &name, 2615 &name,
2833 title ? " " : "", 2616 title ? "\",title:\"" : "",
2834 title ? (const char *)title : ""); 2617 title ? (const char *)title : "",
2618 flag_desc (flagdesc, 512), type);
2835 2619
2836 if (env) 2620 if (env)
2837 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2621 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2838 2622
2839 if (map) 2623 if (map)
2840 p += snprintf (p, 256, "(on %s@%d+%d)", map->path, x, y); 2624 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2841 2625
2842 return info; 2626 return info;
2843} 2627}
2844 2628
2845const char * 2629const char *
2846object::debug_desc () const 2630object::debug_desc () const
2847{ 2631{
2848 static char info[256 * 3]; 2632 static char info[3][256 * 4];
2633 static int info_idx;
2634
2849 return debug_desc (info); 2635 return debug_desc (info [++info_idx % 3]);
2850} 2636}
2851 2637
2638struct region *
2639object::region () const
2640{
2641 return map ? map->region (x, y)
2642 : region::default_region ();
2643}
2644
2645const materialtype_t *
2646object::dominant_material () const
2647{
2648 if (materialtype_t *mat = name_to_material (materialname))
2649 return mat;
2650
2651 // omfg this is slow, this has to be temporary :)
2652 shstr unknown ("unknown");
2653
2654 return name_to_material (unknown);
2655}
2656
2657void
2658object::open_container (object *new_container)
2659{
2660 if (container == new_container)
2661 return;
2662
2663 if (object *old_container = container)
2664 {
2665 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))
2666 return;
2667
2668#if 0
2669 // remove the "Close old_container" object.
2670 if (object *closer = old_container->inv)
2671 if (closer->type == CLOSE_CON)
2672 closer->destroy ();
2673#endif
2674
2675 old_container->flag [FLAG_APPLIED] = 0;
2676 container = 0;
2677
2678 esrv_update_item (UPD_FLAGS, this, old_container);
2679 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container));
2680 }
2681
2682 if (new_container)
2683 {
2684 if (INVOKE_OBJECT (OPEN, new_container, ARG_OBJECT (this)))
2685 return;
2686
2687 // TODO: this does not seem to serve any purpose anymore?
2688#if 0
2689 // insert the "Close Container" object.
2690 if (archetype *closer = new_container->other_arch)
2691 {
2692 object *closer = arch_to_object (new_container->other_arch);
2693 closer->flag [FLAG_NO_MAP_SAVE] = 1;
2694 new_container->insert (closer);
2695 }
2696#endif
2697
2698 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container));
2699
2700 new_container->flag [FLAG_APPLIED] = 1;
2701 container = new_container;
2702
2703 esrv_update_item (UPD_FLAGS, this, new_container);
2704 esrv_send_inventory (this, new_container);
2705 }
2706}
2707
2708

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines