[ViewVC] Diff of: cvs/deliantra/server/common/object.C

Comparing deliantra/server/common/object.C (file contents):
Revision 1.150 by root, Tue May 15 19:07:15 2007 UTC vs.
Revision 1.163 by root, Sun Jul 1 05:00:17 2007 UTC

 /*
- * CrossFire, A Multiplayer game
+ * This file is part of Crossfire TRT, the Roguelike Realtime MORPG.
  *
- * Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team
+ * Copyright (©) 2005,2006,2007 Marc Alexander Lehmann / Robin Redeker / the Crossfire TRT team
- * Copyright (C) 2001 Mark Wedel & Crossfire Development Team
+ * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team
- * Copyright (C) 1992 Frank Tore Johansen
+ * Copyright (©) 1992,2007 Frank Tore Johansen
  *
- * This program is free software; you can redistribute it and/or modify
+ * Crossfire TRT is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
+ * the Free Software Foundation, either version 3 of the License, or
  * (at your option) any later version.
  *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
- * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
  *
- * The authors can be reached via e-mail at <crossfire@schmorp.de>
+ * The authors can be reached via e-mail to <crossfire@schmorp.de>
  */
 /* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
    sub/add_weight will transcend the environment updating the carrying
    variable. */
   chosen_skill = !ob || ob->type == SKILL ? ob : find_skill_by_name (this, ob->skill);
   if (chosen_skill)
     chosen_skill->flag [FLAG_APPLIED] = true;
-  if (ob && !ob->flag [FLAG_APPLIED])
-    {
-      LOG (llevError | logBacktrace, "%s changed to unapplied weapon %s",
-           &name, ob->debug_desc ());
-      return false;
-    }
   update_stats ();
   if (ob)
     {
       // now check wether any body locations became invalid, in which case
           {
             current_weapon = chosen_skill = 0;
             update_stats ();
             new_draw_info_format (NDI_UNIQUE, 0, this,
-                                  "You try to balance your applied items all at once, but the %s is too much. "
+                                  "You try to balance all your items at once, "
+                                  "but the %s is just too much for your body. "
-                                  "You need to unapply some items first.", &ob->name);
+                                  "[You need to unapply some items first.]", &ob->name);
             return false;
           }
       //new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name);
     }
   else
     ;//new_draw_info_format (NDI_UNIQUE, 0, this, "You unwield your weapons.");
+  if (ob && !ob->flag [FLAG_APPLIED] && ob->type != SPELL)
+    {
+      LOG (llevError | logBacktrace, "%s changed to unapplied weapon %s",
+           &name, ob->debug_desc ());
+      return false;
+    }
   return true;
 }
 /* Zero the key_values on op, decrementing the shared-string
     map = freed_map;
     x = 1;
     y = 1;
   }
-  head = 0;
   if (more)
     {
       more->destroy ();
       more = 0;
     }
+  head = 0;
-  // clear those pointers that likely might have circular references to us
+  // clear those pointers that likely might cause circular references
-  owner       = 0;
+  owner          = 0;
-  enemy       = 0;
+  enemy          = 0;
-  attacked_by = 0;
+  attacked_by    = 0;
+  current_weapon = 0;
 }
 void
 object::destroy (bool destroy_inventory)
 {
               if (destroyed ())
                 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
             }
-          /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */
-          //TODO: why is this horrible hacka fix? get rid of this code=bug! (schmorp)
-          if (tmp->above == tmp)
-            tmp->above = 0;
           last = tmp;
         }
       /* last == NULL if there are no objects on this space */
       //TODO: this makes little sense, why only update the topmost object?
   if (more)
     return;
   object *prev = this;
-  for (archetype *at = arch->more; at; at = at->more)
+  for (archetype *at = (archetype *)arch->more; at; at = (archetype *)at->more)
     {
       object *op = arch_to_object (at);
       op->name    = name;
       op->name_pl = name_pl;
 object *
 insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
 {
   for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
     {
-      tmp->x = x + tmp->arch->clone.x;
+      tmp->x = x + tmp->arch->x;
-      tmp->y = y + tmp->arch->clone.y;
+      tmp->y = y + tmp->arch->y;
     }
   return insert_ob_in_map (op, m, originator, flag);
 }
 object *
 insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
 {
   assert (!op->flag [FLAG_FREED]);
-  object *tmp, *top, *floor = NULL;
+  object *top, *floor = NULL;
   op->remove ();
 #if 0
   if (!m->active != !op->active)
 #endif
       return op;
     }
   if (object *more = op->more)
-    {
-      if (!insert_ob_in_map (more, m, originator, flag))
+    if (!insert_ob_in_map (more, m, originator, flag))
-        {
-          if (!op->head)
-            LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n");
-          return 0;
+      return 0;
-        }
-    }
   CLEAR_FLAG (op, FLAG_REMOVED);
   /* Ideally, the caller figures this out.  However, it complicates a lot
    * of areas of callers (eg, anything that uses find_free_spot would now
   mapspace &ms = op->ms ();
   /* this has to be done after we translate the coordinates.
    */
   if (op->nrof && !(flag & INS_NO_MERGE))
-    for (tmp = ms.bot; tmp; tmp = tmp->above)
+    for (object *tmp = ms.bot; tmp; tmp = tmp->above)
       if (object::can_merge (op, tmp))
         {
           op->nrof += tmp->nrof;
           tmp->destroy ();
         }
    * blocked() and wall() work properly), and these flags are updated by
    * update_object().
    */
   /* if this is not the head or flag has been passed, don't check walk on status */
-  if (!(flag & INS_NO_WALK_ON) && !op->head)
+  if (!(flag & INS_NO_WALK_ON) && op->head_ () == op)
     {
       if (check_move_on (op, originator))
         return 0;
       /* If we are a multi part object, lets work our way through the check
        * walk on's.
        */
-      for (tmp = op->more; tmp != NULL; tmp = tmp->more)
+      for (object *tmp = op->more; tmp; tmp = tmp->more)
         if (check_move_on (tmp, originator))
           return 0;
     }
   return op;
   object *tmp, *tmp1;
   /* first search for itself and remove any old instances */
   for (tmp = op->ms ().bot; tmp; tmp = tmp->above)
-    if (!strcmp (tmp->arch->name, arch_string))       /* same archetype */
+    if (!strcmp (tmp->arch->archname, arch_string))       /* same archetype */
       tmp->destroy ();
   tmp1 = arch_to_object (archetype::find (arch_string));
   tmp1->x = op->x;
       LOG (llevError, "Trying to put object in NULL.\n%s\n", dump);
       free (dump);
       return op;
     }
-  if (where->head)
+  if (where->head_ () != where)
     {
-      LOG (llevDebug, "Warning: Tried to insert object into wrong part of multipart object.\n");
+      LOG (llevError | logBacktrace, "Warning: Tried to insert object into wrong part of multipart object.\n");
       where = where->head;
     }
   return where->insert (op);
 }
     for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
       {
         CLEAR_FLAG (tmp, flag);
         unflag_inv (tmp, flag);
       }
-}
-/*
- * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in
- * all it's inventory (recursively).
- * If checksums are used, a player will get set_cheat called for
- * him/her-self and all object carried by a call to this function.
- */
-void
-set_cheat (object *op)
-{
-  SET_FLAG (op, FLAG_WAS_WIZ);
-  flag_inv (op, FLAG_WAS_WIZ);
 }
 /*
  * find_free_spot(object, map, x, y, start, stop) will search for
  * a spot at the given map and coordinates which will be able to contain
   object *tmp;
   maptile *mp;
   MoveType blocked, move_type;
-  if (exclude && exclude->head)
+  if (exclude && exclude->head_ () != exclude)
     {
       exclude = exclude->head;
       move_type = exclude->move_type;
     }
   else
             max = maxfree[i];
           else if (mflags & P_IS_ALIVE)
             {
               for (tmp = ms.bot; tmp; tmp = tmp->above)
                 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)
-                    && (tmp != exclude || (tmp->head && tmp->head != exclude)))
+                    && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))
                   break;
               if (tmp)
                 return freedir[i];
             }
  * create clone from object to another
  */
 object *
 object_create_clone (object *asrc)
 {
-  object *dst = 0, *tmp, *src, *part, *prev, *item;
+  object *dst = 0, *tmp, *src, *prev, *item;
   if (!asrc)
     return 0;
-  src = asrc;
-  if (src->head)
-    src = src->head;
+  src = asrc->head_ ();
   prev = 0;
-  for (part = src; part; part = part->more)
+  for (object *part = src; part; part = part->more)
     {
       tmp = part->clone ();
       tmp->x -= src->x;
       tmp->y -= src->y;
           /* Basically, if the archetype has this key set,
            * we need to store the null value so when we save
            * it, we save the empty value so that when we load,
            * we get this value back again.
            */
-          if (get_ob_key_link (&op->arch->clone, canonical_key))
+          if (get_ob_key_link (op->arch, canonical_key))
             field->value = 0;
           else
             {
               if (last)
                 last->next = field->next;
         item = item->inv;
     }
   else
     item = item->env;
 }
 const char *
 object::flag_desc (char *desc, int len) const
 {
   char *p = desc;

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing deliantra/server/common/object.C (file contents): Revision 1.150 by root, Tue May 15 19:07:15 2007 UTC vs. Revision 1.163 by root, Sun Jul 1 05:00:17 2007 UTC

Diff Legend

Comparing deliantra/server/common/object.C (file contents):
Revision 1.150 by root, Tue May 15 19:07:15 2007 UTC vs.
Revision 1.163 by root, Sun Jul 1 05:00:17 2007 UTC