ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.28 by root, Mon Sep 11 12:10:21 2006 UTC vs.
Revision 1.152 by root, Thu May 17 14:14:54 2007 UTC

1/* 1/*
2 CrossFire, A Multiplayer game for X-windows 2 * CrossFire, A Multiplayer game
3 3 *
4 * Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team
4 Copyright (C) 2001 Mark Wedel & Crossfire Development Team 5 * Copyright (C) 2001 Mark Wedel & Crossfire Development Team
5 Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (C) 1992 Frank Tore Johansen
6 7 *
7 This program is free software; you can redistribute it and/or modify 8 * This program is free software; you can redistribute it and/or modify
8 it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
9 the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation; either version 2 of the License, or
10 (at your option) any later version. 11 * (at your option) any later version.
11 12 *
12 This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
13 but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 GNU General Public License for more details. 16 * GNU General Public License for more details.
16 17 *
17 You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
18 along with this program; if not, write to the Free Software 19 * along with this program; if not, write to the Free Software
19 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
20 21 *
21 The authors can be reached via e-mail at crossfire-devel@real-time.com 22 * The authors can be reached via e-mail at <crossfire@schmorp.de>
22*/ 23 */
23 24
24/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects. 25/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
25 sub/add_weight will transcend the environment updating the carrying 26 sub/add_weight will transcend the environment updating the carrying
26 variable. */ 27 variable. */
27#include <global.h> 28#include <global.h>
28#include <stdio.h> 29#include <stdio.h>
29#include <sys/types.h> 30#include <sys/types.h>
30#include <sys/uio.h> 31#include <sys/uio.h>
31#include <object.h> 32#include <object.h>
32#include <funcpoint.h> 33#include <funcpoint.h>
33#include <skills.h> 34#include <sproto.h>
34#include <loader.h> 35#include <loader.h>
35 36
37#include <bitset>
38
36int nrofallocobjects = 0; 39int nrofallocobjects = 0;
40static UUID uuid;
41const uint64 UUID_SKIP = 1<<19;
37 42
38object *objects; /* Pointer to the list of used objects */ 43objectvec objects;
39object *active_objects; /* List of active objects that need to be processed */ 44activevec actives;
40 45
41short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 46short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
42 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1 47 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1
43}; 48};
44short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, 49short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
… …
50int freedir[SIZEOFFREE] = { 55int freedir[SIZEOFFREE] = {
51 0, 1, 2, 3, 4, 5, 6, 7, 8, 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8, 56 0, 1, 2, 3, 4, 5, 6, 7, 8, 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,
52 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8 57 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8
53}; 58};
54 59
60static void
61write_uuid (void)
62{
63 char filename1[MAX_BUF], filename2[MAX_BUF];
64
65 sprintf (filename1, "%s/uuid", settings.localdir);
66 sprintf (filename2, "%s/uuid~", settings.localdir);
67
68 FILE *fp;
69
70 if (!(fp = fopen (filename2, "w")))
71 {
72 LOG (llevError, "ERROR: cannot open %s for writing, unable to write UUID!\n", filename2);
73 return;
74 }
75
76 fprintf (fp, "<1,%llx>\n", (unsigned long long)uuid.seq + UUID_SKIP * 2);
77 fclose (fp);
78 rename (filename2, filename1);
79}
80
81static void
82read_uuid (void)
83{
84 char filename[MAX_BUF];
85
86 sprintf (filename, "%s/uuid", settings.localdir);
87
88 FILE *fp;
89
90 if (!(fp = fopen (filename, "r")))
91 {
92 if (errno == ENOENT)
93 {
94 LOG (llevInfo, "RESET uid to 1\n");
95 uuid.seq = 0;
96 write_uuid ();
97 return;
98 }
99
100 LOG (llevError, "FATAL: cannot open %s for reading!\n", filename);
101 _exit (1);
102 }
103
104 int version;
105 unsigned long long uid;
106 if (2 != fscanf (fp, "<%d,%llx>\n", &version, &uid) || version != 1)
107 {
108 LOG (llevError, "FATAL: error reading uid from %s!\n", filename);
109 _exit (1);
110 }
111
112 uuid.seq = uid;
113 write_uuid ();
114 LOG (llevDebug, "read UID: %" PRId64 "\n", uid);
115 fclose (fp);
116}
117
118UUID
119gen_uuid ()
120{
121 UUID uid;
122
123 uid.seq = ++uuid.seq;
124
125 if (!(uuid.seq & (UUID_SKIP - 1)))
126 write_uuid ();
127
128 return uid;
129}
130
131void
132init_uuid ()
133{
134 read_uuid ();
135}
136
55/* Returns TRUE if every key_values in wants has a partner with the same value in has. */ 137/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
56static int 138static int
57compare_ob_value_lists_one (const object *wants, const object *has) 139compare_ob_value_lists_one (const object *wants, const object *has)
58{ 140{
59 key_value *wants_field; 141 key_value *wants_field;
… …
62 * objects with lists are rare, and lists stay short. If not, use a 144 * objects with lists are rare, and lists stay short. If not, use a
63 * different structure or at least keep the lists sorted... 145 * different structure or at least keep the lists sorted...
64 */ 146 */
65 147
66 /* For each field in wants, */ 148 /* For each field in wants, */
67 for (wants_field = wants->key_values; wants_field != NULL; wants_field = wants_field->next) 149 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)
68 { 150 {
69 key_value *has_field; 151 key_value *has_field;
70 152
71 /* Look for a field in has with the same key. */ 153 /* Look for a field in has with the same key. */
72 has_field = get_ob_key_link (has, wants_field->key); 154 has_field = get_ob_key_link (has, wants_field->key);
… …
106 * 188 *
107 * Note that this function appears a lot longer than the macro it 189 * Note that this function appears a lot longer than the macro it
108 * replaces - this is mostly for clarity - a decent compiler should hopefully 190 * replaces - this is mostly for clarity - a decent compiler should hopefully
109 * reduce this to the same efficiency. 191 * reduce this to the same efficiency.
110 * 192 *
111 * Check nrof variable *before* calling CAN_MERGE() 193 * Check nrof variable *before* calling can_merge()
112 * 194 *
113 * Improvements made with merge: Better checking on potion, and also 195 * Improvements made with merge: Better checking on potion, and also
114 * check weight 196 * check weight
115 */ 197 */
116
117bool object::can_merge (object *ob1, object *ob2) 198bool object::can_merge_slow (object *ob1, object *ob2)
118{ 199{
119 /* A couple quicksanity checks */ 200 /* A couple quicksanity checks */
120 if ((ob1 == ob2) || (ob1->type != ob2->type)) 201 if (ob1 == ob2
202 || ob1->type != ob2->type
203 || ob1->speed != ob2->speed
204 || ob1->value != ob2->value
205 || ob1->name != ob2->name)
121 return 0; 206 return 0;
122 207
123 if (ob1->speed != ob2->speed) 208 //TODO: this ain't working well, use nicer and correct overflow check
124 return 0;
125
126 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that 209 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that
127 * value could not be stored in a sint32 (which unfortunately sometimes is 210 * value could not be stored in a sint32 (which unfortunately sometimes is
128 * used to store nrof). 211 * used to store nrof).
129 */ 212 */
130 if (ob1->nrof + ob2->nrof >= 1UL << 31) 213 if (ob1->nrof + ob2->nrof >= 1UL << 31)
… …
140 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 223 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
141 224
142 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 225 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
143 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 226 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
144 227
145 228 if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any ()
146 /* the 0x400000 on flags2 is FLAG_INV_LOCK. I don't think something 229 || ob1->arch != ob2->arch
147 * being locked in inventory should prevent merging.
148 * 0x4 in flags3 is CLIENT_SENT
149 */
150 if ((ob1->arch != ob2->arch) ||
151 (ob1->flags[0] != ob2->flags[0]) ||
152 (ob1->flags[1] != ob2->flags[1]) ||
153 ((ob1->flags[2] & ~0x400000) != (ob2->flags[2] & ~0x400000)) ||
154 ((ob1->flags[3] & ~0x4) != (ob2->flags[3] & ~0x4)) ||
155 (ob1->name != ob2->name) || 230 || ob1->name != ob2->name
156 (ob1->title != ob2->title) || 231 || ob1->title != ob2->title
157 (ob1->msg != ob2->msg) || 232 || ob1->msg != ob2->msg
158 (ob1->weight != ob2->weight) || 233 || ob1->weight != ob2->weight
159 (memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist)) != 0) || 234 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
160 (memcmp (&ob1->stats, &ob2->stats, sizeof (ob1->stats)) != 0) || 235 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
161 (ob1->attacktype != ob2->attacktype) || 236 || ob1->attacktype != ob2->attacktype
162 (ob1->magic != ob2->magic) || 237 || ob1->magic != ob2->magic
163 (ob1->slaying != ob2->slaying) || 238 || ob1->slaying != ob2->slaying
164 (ob1->skill != ob2->skill) || 239 || ob1->skill != ob2->skill
165 (ob1->value != ob2->value) || 240 || ob1->value != ob2->value
166 (ob1->animation_id != ob2->animation_id) || 241 || ob1->animation_id != ob2->animation_id
167 (ob1->client_type != ob2->client_type) || 242 || ob1->client_type != ob2->client_type
168 (ob1->materialname != ob2->materialname) || 243 || ob1->materialname != ob2->materialname
169 (ob1->lore != ob2->lore) || 244 || ob1->lore != ob2->lore
170 (ob1->subtype != ob2->subtype) || 245 || ob1->subtype != ob2->subtype
171 (ob1->move_type != ob2->move_type) || 246 || ob1->move_type != ob2->move_type
172 (ob1->move_block != ob2->move_block) || 247 || ob1->move_block != ob2->move_block
173 (ob1->move_allow != ob2->move_allow) || 248 || ob1->move_allow != ob2->move_allow
174 (ob1->move_on != ob2->move_on) || 249 || ob1->move_on != ob2->move_on
175 (ob1->move_off != ob2->move_off) || (ob1->move_slow != ob2->move_slow) || (ob1->move_slow_penalty != ob2->move_slow_penalty)) 250 || ob1->move_off != ob2->move_off
251 || ob1->move_slow != ob2->move_slow
252 || ob1->move_slow_penalty != ob2->move_slow_penalty)
176 return 0; 253 return 0;
177 254
178 /* This is really a spellbook check - really, we should 255 /* This is really a spellbook check - really, we should
179 * check all objects in the inventory. 256 * check all objects in the inventory.
180 */ 257 */
… …
183 /* if one object has inventory but the other doesn't, not equiv */ 260 /* if one object has inventory but the other doesn't, not equiv */
184 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv)) 261 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv))
185 return 0; 262 return 0;
186 263
187 /* Now check to see if the two inventory objects could merge */ 264 /* Now check to see if the two inventory objects could merge */
188 if (!CAN_MERGE (ob1->inv, ob2->inv)) 265 if (!object::can_merge (ob1->inv, ob2->inv))
189 return 0; 266 return 0;
190 267
191 /* inventory ok - still need to check rest of this object to see 268 /* inventory ok - still need to check rest of this object to see
192 * if it is valid. 269 * if it is valid.
193 */ 270 */
… …
202 279
203 /* Note sure why the following is the case - either the object has to 280 /* Note sure why the following is the case - either the object has to
204 * be animated or have a very low speed. Is this an attempted monster 281 * be animated or have a very low speed. Is this an attempted monster
205 * check? 282 * check?
206 */ 283 */
207 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && FABS ((ob1)->speed) > MIN_ACTIVE_SPEED) 284 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && ob1->has_active_speed ())
208 return 0; 285 return 0;
209 286
210 switch (ob1->type) 287 switch (ob1->type)
211 { 288 {
212 case SCROLL: 289 case SCROLL:
213 if (ob1->level != ob2->level) 290 if (ob1->level != ob2->level)
214 return 0; 291 return 0;
215 break; 292 break;
216 } 293 }
217 294
218 if (ob1->key_values != NULL || ob2->key_values != NULL) 295 if (ob1->key_values != NULL || ob2->key_values != NULL)
219 { 296 {
220 /* At least one of these has key_values. */ 297 /* At least one of these has key_values. */
… …
248sum_weight (object *op) 325sum_weight (object *op)
249{ 326{
250 long sum; 327 long sum;
251 object *inv; 328 object *inv;
252 329
253 for (sum = 0, inv = op->inv; inv != NULL; inv = inv->below) 330 for (sum = 0, inv = op->inv; inv; inv = inv->below)
254 { 331 {
255 if (inv->inv) 332 if (inv->inv)
256 sum_weight (inv); 333 sum_weight (inv);
334
257 sum += inv->carrying + inv->weight * (inv->nrof ? inv->nrof : 1); 335 sum += inv->carrying + inv->weight * (inv->nrof ? inv->nrof : 1);
258 } 336 }
337
259 if (op->type == CONTAINER && op->stats.Str) 338 if (op->type == CONTAINER && op->stats.Str)
260 sum = (sum * (100 - op->stats.Str)) / 100; 339 sum = (sum * (100 - op->stats.Str)) / 100;
340
261 if (op->carrying != sum) 341 if (op->carrying != sum)
262 op->carrying = sum; 342 op->carrying = sum;
343
263 return sum; 344 return sum;
264} 345}
265 346
266/** 347/**
267 * Return the outermost environment object for a given object. 348 * Return the outermost environment object for a given object.
… …
274 op = op->env; 355 op = op->env;
275 return op; 356 return op;
276} 357}
277 358
278/* 359/*
279 * Eneq(@csd.uu.se): Since we can have items buried in a character we need
280 * a better check. We basically keeping traversing up until we can't
281 * or find a player.
282 */
283
284object *
285is_player_inv (object *op)
286{
287 for (; op != NULL && op->type != PLAYER; op = op->env)
288 if (op->env == op)
289 op->env = NULL;
290 return op;
291}
292
293/*
294 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump. 360 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
295 * Some error messages. 361 * Some error messages.
296 * The result of the dump is stored in the static global errmsg array. 362 * The result of the dump is stored in the static global errmsg array.
297 */ 363 */
298 364char *
299void
300dump_object2 (object *op)
301{
302 errmsg[0] = 0;
303 return;
304 //TODO//D#d#
305#if 0
306 char *cp;
307
308/* object *tmp;*/
309
310 if (op->arch != NULL)
311 {
312 strcat (errmsg, "arch ");
313 strcat (errmsg, op->arch->name ? op->arch->name : "(null)");
314 strcat (errmsg, "\n");
315 if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
316 strcat (errmsg, cp);
317# if 0
318 /* Don't dump player diffs - they are too long, mostly meaningless, and
319 * will overflow the buffer.
320 * Changed so that we don't dump inventory either. This may
321 * also overflow the buffer.
322 */
323 if (op->type != PLAYER && (cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
324 strcat (errmsg, cp);
325 for (tmp = op->inv; tmp; tmp = tmp->below)
326 dump_object2 (tmp);
327# endif
328 strcat (errmsg, "end\n");
329 }
330 else
331 {
332 strcat (errmsg, "Object ");
333 if (op->name == NULL)
334 strcat (errmsg, "(null)");
335 else
336 strcat (errmsg, op->name);
337 strcat (errmsg, "\n");
338# if 0
339 if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
340 strcat (errmsg, cp);
341 for (tmp = op->inv; tmp; tmp = tmp->below)
342 dump_object2 (tmp);
343# endif
344 strcat (errmsg, "end\n");
345 }
346#endif
347}
348
349/*
350 * Dumps an object. Returns output in the static global errmsg array.
351 */
352
353void
354dump_object (object *op) 365dump_object (object *op)
355{ 366{
356 if (op == NULL) 367 if (!op)
357 { 368 return strdup ("[NULLOBJ]");
358 strcpy (errmsg, "[NULL pointer]");
359 return;
360 }
361 errmsg[0] = '\0';
362 dump_object2 (op);
363}
364 369
365void 370 object_freezer freezer;
366dump_all_objects (void) 371 op->write (freezer);
367{ 372 return freezer.as_string ();
368 object *op;
369
370 for (op = objects; op != NULL; op = op->next)
371 {
372 dump_object (op);
373 fprintf (logfile, "Object %d\n:%s\n", op->count, errmsg);
374 }
375} 373}
376 374
377/* 375/*
378 * get_nearest_part(multi-object, object 2) returns the part of the 376 * get_nearest_part(multi-object, object 2) returns the part of the
379 * multi-object 1 which is closest to the second object. 377 * multi-object 1 which is closest to the second object.
… …
395} 393}
396 394
397/* 395/*
398 * Returns the object which has the count-variable equal to the argument. 396 * Returns the object which has the count-variable equal to the argument.
399 */ 397 */
400
401object * 398object *
402find_object (tag_t i) 399find_object (tag_t i)
403{ 400{
404 object *op; 401 for_all_objects (op)
405
406 for (op = objects; op != NULL; op = op->next)
407 if (op->count == i) 402 if (op->count == i)
408 break;
409 return op; 403 return op;
404
405 return 0;
410} 406}
411 407
412/* 408/*
413 * Returns the first object which has a name equal to the argument. 409 * Returns the first object which has a name equal to the argument.
414 * Used only by the patch command, but not all that useful. 410 * Used only by the patch command, but not all that useful.
415 * Enables features like "patch <name-of-other-player> food 999" 411 * Enables features like "patch <name-of-other-player> food 999"
416 */ 412 */
417
418object * 413object *
419find_object_name (const char *str) 414find_object_name (const char *str)
420{ 415{
421 const char *name = shstr::find (str); 416 shstr_cmp str_ (str);
422 object *op; 417 object *op;
423 418
424 for (op = objects; op != NULL; op = op->next) 419 for_all_objects (op)
425 if (&op->name == name) 420 if (op->name == str_)
426 break; 421 break;
427 422
428 return op; 423 return op;
429} 424}
430 425
… …
433{ 428{
434 LOG (llevDebug, "%d allocated objects\n", nrofallocobjects); 429 LOG (llevDebug, "%d allocated objects\n", nrofallocobjects);
435} 430}
436 431
437/* 432/*
438 * Returns the object which this object marks as being the owner.
439 * A id-scheme is used to avoid pointing to objects which have been
440 * freed and are now reused. If this is detected, the owner is
441 * set to NULL, and NULL is returned.
442 * Changed 2004-02-12 - if the player is setting at the play again
443 * prompt, he is removed, and we don't want to treat him as an owner of
444 * anything, so check removed flag. I don't expect that this should break
445 * anything - once an object is removed, it is basically dead anyways.
446 */
447
448object *
449get_owner (object *op)
450{
451 if (op->owner == NULL)
452 return NULL;
453
454 if (!QUERY_FLAG (op->owner, FLAG_FREED) && !QUERY_FLAG (op->owner, FLAG_REMOVED) && op->owner->count == op->ownercount)
455 return op->owner;
456
457 op->owner = NULL;
458 op->ownercount = 0;
459 return NULL;
460}
461
462void
463clear_owner (object *op)
464{
465 if (!op)
466 return;
467
468 if (op->owner && op->ownercount == op->owner->count)
469 op->owner->refcount--;
470
471 op->owner = NULL;
472 op->ownercount = 0;
473}
474
475/*
476 * Sets the owner and sets the skill and exp pointers to owner's current 433 * Sets the owner and sets the skill and exp pointers to owner's current
477 * skill and experience objects. 434 * skill and experience objects.
478 */ 435 */
479void 436void
480set_owner (object *op, object *owner) 437object::set_owner (object *owner)
481{ 438{
482 if (owner == NULL || op == NULL) 439 if (!owner)
483 return; 440 return;
484 441
485 /* next line added to allow objects which own objects */ 442 /* next line added to allow objects which own objects */
486 /* Add a check for ownercounts in here, as I got into an endless loop 443 /* Add a check for ownercounts in here, as I got into an endless loop
487 * with the fireball owning a poison cloud which then owned the 444 * with the fireball owning a poison cloud which then owned the
488 * fireball. I believe that was caused by one of the objects getting 445 * fireball. I believe that was caused by one of the objects getting
489 * freed and then another object replacing it. Since the ownercounts 446 * freed and then another object replacing it. Since the ownercounts
490 * didn't match, this check is valid and I believe that cause is valid. 447 * didn't match, this check is valid and I believe that cause is valid.
491 */ 448 */
492 while (owner->owner && owner != owner->owner && owner->ownercount == owner->owner->count) 449 while (owner->owner)
493 owner = owner->owner; 450 owner = owner->owner;
494 451
495 /* IF the owner still has an owner, we did not resolve to a final owner.
496 * so lets not add to that.
497 */
498 if (owner->owner)
499 return;
500
501 op->owner = owner; 452 this->owner = owner;
502
503 op->ownercount = owner->count;
504 owner->refcount++;
505} 453}
506 454
507/* Set the owner to clone's current owner and set the skill and experience 455int
508 * objects to clone's objects (typically those objects that where the owner's 456object::slottype () const
509 * current skill and experience objects at the time when clone's owner was
510 * set - not the owner's current skill and experience objects).
511 *
512 * Use this function if player created an object (e.g. fire bullet, swarm
513 * spell), and this object creates further objects whose kills should be
514 * accounted for the player's original skill, even if player has changed
515 * skills meanwhile.
516 */
517void
518copy_owner (object *op, object *clone)
519{ 457{
520 object *owner = get_owner (clone); 458 if (type == SKILL)
521
522 if (owner == NULL)
523 {
524 /* players don't have owners - they own themselves. Update
525 * as appropriate.
526 */
527 if (clone->type == PLAYER)
528 owner = clone;
529 else
530 return;
531 } 459 {
460 if (IS_COMBAT_SKILL (subtype)) return slot_combat;
461 if (IS_RANGED_SKILL (subtype)) return slot_ranged;
462 }
463 else
464 {
465 if (slot [body_combat].info) return slot_combat;
466 if (slot [body_range ].info) return slot_ranged;
467 }
468
469 return slot_none;
470}
532 471
533 set_owner (op, owner); 472bool
473object::change_weapon (object *ob)
474{
475 if (current_weapon == ob)
476 return true;
477
478 if (chosen_skill)
479 chosen_skill->flag [FLAG_APPLIED] = false;
480
481 current_weapon = ob;
482 chosen_skill = !ob || ob->type == SKILL ? ob : find_skill_by_name (this, ob->skill);
483
484 if (chosen_skill)
485 chosen_skill->flag [FLAG_APPLIED] = true;
486
487 update_stats ();
488
489 if (ob)
490 {
491 // now check wether any body locations became invalid, in which case
492 // we cannot apply the weapon at the moment.
493 for (int i = 0; i < NUM_BODY_LOCATIONS; ++i)
494 if (slot[i].used < 0)
495 {
496 current_weapon = chosen_skill = 0;
497 update_stats ();
498
499 new_draw_info_format (NDI_UNIQUE, 0, this,
500 "You try to balance your applied items all at once, but the %s is too much. "
501 "You need to unapply some items first.", &ob->name);
502 return false;
503 }
504
505 //new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name);
506 }
507 else
508 ;//new_draw_info_format (NDI_UNIQUE, 0, this, "You unwield your weapons.");
509
510 if (ob && !ob->flag [FLAG_APPLIED] && ob->type != SPELL)
511 {
512 LOG (llevError | logBacktrace, "%s changed to unapplied weapon %s",
513 &name, ob->debug_desc ());
514 return false;
515 }
516
517 return true;
534} 518}
535 519
536/* Zero the key_values on op, decrementing the shared-string 520/* Zero the key_values on op, decrementing the shared-string
537 * refcounts and freeing the links. 521 * refcounts and freeing the links.
538 */ 522 */
539static void 523static void
540free_key_values (object *op) 524free_key_values (object *op)
541{ 525{
542 for (key_value *i = op->key_values; i != 0;) 526 for (key_value *i = op->key_values; i; )
543 { 527 {
544 key_value *next = i->next; 528 key_value *next = i->next;
545 delete i; 529 delete i;
546 530
547 i = next; 531 i = next;
548 } 532 }
549 533
550 op->key_values = 0; 534 op->key_values = 0;
551} 535}
552 536
553void object::clear () 537object &
538object::operator =(const object &src)
554{ 539{
555 attachable_base::clear (); 540 bool is_freed = flag [FLAG_FREED];
541 bool is_removed = flag [FLAG_REMOVED];
556 542
557 free_key_values (this); 543 *(object_copy *)this = src;
558 544
559 clear_owner (this); 545 flag [FLAG_FREED] = is_freed;
560 546 flag [FLAG_REMOVED] = is_removed;
561 name = 0;
562 name_pl = 0;
563 title = 0;
564 race = 0;
565 slaying = 0;
566 skill = 0;
567 msg = 0;
568 lore = 0;
569 custom_name = 0;
570 materialname = 0;
571
572 memset (static_cast < object_pod * >(this), 0, sizeof (object_pod));
573
574 SET_FLAG (this, FLAG_REMOVED);
575}
576
577void object::clone (object *destination)
578{
579 *(object_copy *) destination = *this;
580 *(object_pod *) destination = *this;
581
582 if (self || cb)
583 INVOKE_OBJECT (CLONE, this, ARG_OBJECT (destination));
584}
585
586/*
587 * clear_object() frees everything allocated by an object, and also
588 * clears all variables and flags to default settings.
589 */
590
591void
592clear_object (object *op)
593{
594 op->clear ();
595
596 op->contr = NULL;
597 op->below = NULL;
598 op->above = NULL;
599 op->inv = NULL;
600 op->container = NULL;
601 op->env = NULL;
602 op->more = NULL;
603 op->head = NULL;
604 op->map = NULL;
605 op->refcount = 0;
606 op->active_next = NULL;
607 op->active_prev = NULL;
608 /* What is not cleared is next, prev, and count */
609
610 op->expmul = 1.0;
611 op->face = blank_face;
612 op->attacked_by_count = -1;
613
614 if (settings.casting_time)
615 op->casting_time = -1;
616}
617
618/*
619 * copy object first frees everything allocated by the second object,
620 * and then copies the contends of the first object into the second
621 * object, allocating what needs to be allocated. Basically, any
622 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
623 * if the first object is freed, the pointers in the new object
624 * will point at garbage.
625 */
626
627void
628copy_object (object *op2, object *op)
629{
630 bool is_freed = QUERY_FLAG (op, FLAG_FREED);
631 bool is_removed = QUERY_FLAG (op, FLAG_REMOVED);
632
633 op2->clone (op);
634
635 if (is_freed)
636 SET_FLAG (op, FLAG_FREED);
637 if (is_removed)
638 SET_FLAG (op, FLAG_REMOVED);
639
640 if (op2->speed < 0)
641 op->speed_left = op2->speed_left - RANDOM () % 200 / 100.0;
642 547
643 /* Copy over key_values, if any. */ 548 /* Copy over key_values, if any. */
644 if (op2->key_values) 549 if (src.key_values)
645 { 550 {
646 key_value *tail = 0; 551 key_value *tail = 0;
647 key_value *i;
648
649 op->key_values = 0; 552 key_values = 0;
650 553
651 for (i = op2->key_values; i; i = i->next) 554 for (key_value *i = src.key_values; i; i = i->next)
652 { 555 {
653 key_value *new_link = new key_value; 556 key_value *new_link = new key_value;
654 557
655 new_link->next = 0; 558 new_link->next = 0;
656 new_link->key = i->key; 559 new_link->key = i->key;
657 new_link->value = i->value; 560 new_link->value = i->value;
658 561
659 /* Try and be clever here, too. */ 562 /* Try and be clever here, too. */
660 if (!op->key_values) 563 if (!key_values)
661 { 564 {
662 op->key_values = new_link; 565 key_values = new_link;
663 tail = new_link; 566 tail = new_link;
664 } 567 }
665 else 568 else
666 { 569 {
667 tail->next = new_link; 570 tail->next = new_link;
668 tail = new_link; 571 tail = new_link;
669 } 572 }
670 } 573 }
671 } 574 }
575}
672 576
673 update_ob_speed (op); 577/*
578 * copy_to first frees everything allocated by the dst object,
579 * and then copies the contents of itself into the second
580 * object, allocating what needs to be allocated. Basically, any
581 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
582 * if the first object is freed, the pointers in the new object
583 * will point at garbage.
584 */
585void
586object::copy_to (object *dst)
587{
588 *dst = *this;
589
590 if (speed < 0)
591 dst->speed_left = speed_left - rndm ();
592
593 dst->set_speed (dst->speed);
594}
595
596void
597object::instantiate ()
598{
599 if (!uuid.seq) // HACK
600 uuid = gen_uuid ();
601
602 speed_left = -0.1f;
603 /* copy the body_info to the body_used - this is only really
604 * need for monsters, but doesn't hurt to do it for everything.
605 * by doing so, when a monster is created, it has good starting
606 * values for the body_used info, so when items are created
607 * for it, they can be properly equipped.
608 */
609 for (int i = NUM_BODY_LOCATIONS; i--; )
610 slot[i].used = slot[i].info;
611
612 attachable::instantiate ();
613}
614
615object *
616object::clone ()
617{
618 object *neu = create ();
619 copy_to (neu);
620 return neu;
674} 621}
675 622
676/* 623/*
677 * If an object with the IS_TURNABLE() flag needs to be turned due 624 * If an object with the IS_TURNABLE() flag needs to be turned due
678 * to the closest player being on the other side, this function can 625 * to the closest player being on the other side, this function can
679 * be called to update the face variable, _and_ how it looks on the map. 626 * be called to update the face variable, _and_ how it looks on the map.
680 */ 627 */
681
682void 628void
683update_turn_face (object *op) 629update_turn_face (object *op)
684{ 630{
685 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || op->arch == NULL) 631 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || !op->arch)
686 return; 632 return;
633
687 SET_ANIMATION (op, op->direction); 634 SET_ANIMATION (op, op->direction);
688 update_object (op, UP_OBJ_FACE); 635 update_object (op, UP_OBJ_FACE);
689} 636}
690 637
691/* 638/*
692 * Updates the speed of an object. If the speed changes from 0 to another 639 * Updates the speed of an object. If the speed changes from 0 to another
693 * value, or vice versa, then add/remove the object from the active list. 640 * value, or vice versa, then add/remove the object from the active list.
694 * This function needs to be called whenever the speed of an object changes. 641 * This function needs to be called whenever the speed of an object changes.
695 */ 642 */
696
697void 643void
698update_ob_speed (object *op) 644object::set_speed (float speed)
699{ 645{
700 extern int arch_init; 646 if (flag [FLAG_FREED] && speed)
701
702 /* No reason putting the archetypes objects on the speed list,
703 * since they never really need to be updated.
704 */
705
706 if (QUERY_FLAG (op, FLAG_FREED) && op->speed)
707 { 647 {
708 LOG (llevError, "Object %s is freed but has speed.\n", &op->name); 648 LOG (llevError, "Object %s is freed but has speed.\n", &name);
709#ifdef MANY_CORES
710 abort ();
711#else
712 op->speed = 0; 649 speed = 0;
713#endif
714 }
715 if (arch_init)
716 { 650 }
717 return;
718 }
719 if (FABS (op->speed) > MIN_ACTIVE_SPEED)
720 {
721 /* If already on active list, don't do anything */
722 if (op->active_next || op->active_prev || op == active_objects)
723 return;
724 651
725 /* process_events() expects us to insert the object at the beginning 652 this->speed = speed;
726 * of the list. */ 653
727 op->active_next = active_objects; 654 if (has_active_speed ())
728 if (op->active_next != NULL) 655 activate ();
729 op->active_next->active_prev = op;
730 active_objects = op;
731 }
732 else 656 else
733 { 657 deactivate ();
734 /* If not on the active list, nothing needs to be done */
735 if (!op->active_next && !op->active_prev && op != active_objects)
736 return;
737
738 if (op->active_prev == NULL)
739 {
740 active_objects = op->active_next;
741 if (op->active_next != NULL)
742 op->active_next->active_prev = NULL;
743 }
744 else
745 {
746 op->active_prev->active_next = op->active_next;
747 if (op->active_next)
748 op->active_next->active_prev = op->active_prev;
749 }
750 op->active_next = NULL;
751 op->active_prev = NULL;
752 }
753} 658}
754 659
755/* This function removes object 'op' from the list of active
756 * objects.
757 * This should only be used for style maps or other such
758 * reference maps where you don't want an object that isn't
759 * in play chewing up cpu time getting processed.
760 * The reverse of this is to call update_ob_speed, which
761 * will do the right thing based on the speed of the object.
762 */
763void
764remove_from_active_list (object *op)
765{
766 /* If not on the active list, nothing needs to be done */
767 if (!op->active_next && !op->active_prev && op != active_objects)
768 return;
769
770 if (op->active_prev == NULL)
771 {
772 active_objects = op->active_next;
773 if (op->active_next != NULL)
774 op->active_next->active_prev = NULL;
775 }
776 else
777 {
778 op->active_prev->active_next = op->active_next;
779 if (op->active_next)
780 op->active_next->active_prev = op->active_prev;
781 }
782 op->active_next = NULL;
783 op->active_prev = NULL;
784}
785
786/* 660/*
787 * update_object() updates the array which represents the map. 661 * update_object() updates the the map.
788 * It takes into account invisible objects (and represent squares covered 662 * It takes into account invisible objects (and represent squares covered
789 * by invisible objects by whatever is below them (unless it's another 663 * by invisible objects by whatever is below them (unless it's another
790 * invisible object, etc...) 664 * invisible object, etc...)
791 * If the object being updated is beneath a player, the look-window 665 * If the object being updated is beneath a player, the look-window
792 * of that player is updated (this might be a suboptimal way of 666 * of that player is updated (this might be a suboptimal way of
793 * updating that window, though, since update_object() is called _often_) 667 * updating that window, though, since update_object() is called _often_)
794 * 668 *
795 * action is a hint of what the caller believes need to be done. 669 * action is a hint of what the caller believes need to be done.
796 * For example, if the only thing that has changed is the face (due to
797 * an animation), we don't need to call update_position until that actually
798 * comes into view of a player. OTOH, many other things, like addition/removal
799 * of walls or living creatures may need us to update the flags now.
800 * current action are: 670 * current action are:
801 * UP_OBJ_INSERT: op was inserted 671 * UP_OBJ_INSERT: op was inserted
802 * UP_OBJ_REMOVE: op was removed 672 * UP_OBJ_REMOVE: op was removed
803 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update 673 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update
804 * as that is easier than trying to look at what may have changed. 674 * as that is easier than trying to look at what may have changed.
805 * UP_OBJ_FACE: only the objects face has changed. 675 * UP_OBJ_FACE: only the objects face has changed.
806 */ 676 */
807
808void 677void
809update_object (object *op, int action) 678update_object (object *op, int action)
810{ 679{
811 int update_now = 0, flags;
812 MoveType move_on, move_off, move_block, move_slow;
813
814 if (op == NULL) 680 if (op == NULL)
815 { 681 {
816 /* this should never happen */ 682 /* this should never happen */
817 LOG (llevDebug, "update_object() called for NULL object.\n"); 683 LOG (llevDebug, "update_object() called for NULL object.\n");
818 return; 684 return;
819 } 685 }
820 686
821 if (op->env != NULL) 687 if (op->env)
822 { 688 {
823 /* Animation is currently handled by client, so nothing 689 /* Animation is currently handled by client, so nothing
824 * to do in this case. 690 * to do in this case.
825 */ 691 */
826 return; 692 return;
… …
831 */ 697 */
832 if (!op->map || op->map->in_memory == MAP_SAVING) 698 if (!op->map || op->map->in_memory == MAP_SAVING)
833 return; 699 return;
834 700
835 /* make sure the object is within map boundaries */ 701 /* make sure the object is within map boundaries */
836 if (op->x < 0 || op->x >= MAP_WIDTH (op->map) || op->y < 0 || op->y >= MAP_HEIGHT (op->map)) 702 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
837 { 703 {
838 LOG (llevError, "update_object() called for object out of map!\n"); 704 LOG (llevError, "update_object() called for object out of map!\n");
839#ifdef MANY_CORES 705#ifdef MANY_CORES
840 abort (); 706 abort ();
841#endif 707#endif
842 return; 708 return;
843 } 709 }
844 710
845 flags = GET_MAP_FLAGS (op->map, op->x, op->y); 711 mapspace &m = op->ms ();
846 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NEED_UPDATE);
847 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
848 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
849 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
850 move_off = GET_MAP_MOVE_OFF (op->map, op->x, op->y);
851 712
713 if (!(m.flags_ & P_UPTODATE))
714 /* nop */;
852 if (action == UP_OBJ_INSERT) 715 else if (action == UP_OBJ_INSERT)
853 { 716 {
717 // this is likely overkill, TODO: revisit (schmorp)
854 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(flags & P_BLOCKSVIEW)) 718 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
855 update_now = 1;
856
857 if (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(flags & P_NO_MAGIC)) 719 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
858 update_now = 1; 720 || (op->type == PLAYER && !(m.flags_ & P_PLAYER))
859 721 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
722 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
860 if (QUERY_FLAG (op, FLAG_DAMNED) && !(flags & P_NO_CLERIC)) 723 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
861 update_now = 1;
862
863 if (QUERY_FLAG (op, FLAG_ALIVE) && !(flags & P_IS_ALIVE))
864 update_now = 1;
865
866 if (op->type == SAFE_GROUND && !(flags & P_SAFE))
867 update_now = 1;
868
869 if ((move_on | op->move_on) != move_on) 724 || (m.move_on | op->move_on ) != m.move_on
870 update_now = 1;
871
872 if ((move_off | op->move_off) != move_off) 725 || (m.move_off | op->move_off ) != m.move_off
873 update_now = 1; 726 || (m.move_slow | op->move_slow) != m.move_slow
874
875 /* This isn't perfect, but I don't expect a lot of objects to 727 /* This isn't perfect, but I don't expect a lot of objects to
876 * to have move_allow right now. 728 * to have move_allow right now.
877 */ 729 */
878 if (((move_block | op->move_block) & ~op->move_allow) != move_block) 730 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
879 update_now = 1; 731 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
880 732 m.flags_ = 0;
881 if ((move_slow | op->move_slow) != move_slow)
882 update_now = 1;
883 } 733 }
884 /* if the object is being removed, we can't make intelligent 734 /* if the object is being removed, we can't make intelligent
885 * decisions, because remove_ob can't really pass the object 735 * decisions, because remove_ob can't really pass the object
886 * that is being removed. 736 * that is being removed.
887 */ 737 */
888 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 738 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
889 update_now = 1; 739 m.flags_ = 0;
890 else if (action == UP_OBJ_FACE) 740 else if (action == UP_OBJ_FACE)
891 /* Nothing to do for that case */; 741 /* Nothing to do for that case */ ;
892 else 742 else
893 LOG (llevError, "update_object called with invalid action: %d\n", action); 743 LOG (llevError, "update_object called with invalid action: %d\n", action);
894 744
895 if (update_now)
896 {
897 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NO_ERROR | P_NEED_UPDATE);
898 update_position (op->map, op->x, op->y);
899 }
900
901 if (op->more != NULL) 745 if (op->more)
902 update_object (op->more, action); 746 update_object (op->more, action);
903}
904
905static unordered_vector<object *> mortals;
906static std::vector<object *> freed;
907
908void object::free_mortals ()
909{
910 for (unordered_vector<object *>::iterator i = mortals.begin (); i != mortals.end (); )
911 if (!(*i)->refcount)
912 {
913 freed.push_back (*i);
914 mortals.erase (i);
915 }
916 else
917 ++i;
918} 747}
919 748
920object::object () 749object::object ()
921{ 750{
922 SET_FLAG (this, FLAG_REMOVED); 751 SET_FLAG (this, FLAG_REMOVED);
923 752
924 expmul = 1.0; 753 expmul = 1.0;
925 face = blank_face; 754 face = blank_face;
926 attacked_by_count = -1;
927} 755}
928 756
929object::~object () 757object::~object ()
930{ 758{
759 unlink ();
760
931 free_key_values (this); 761 free_key_values (this);
932} 762}
933 763
764static int object_count;
765
934void object::link () 766void object::link ()
935{ 767{
768 assert (!index);//D
769 uuid = gen_uuid ();
936 count = ++ob_count; 770 count = ++object_count;
937 771
938 prev = 0; 772 refcnt_inc ();
939 next = objects; 773 objects.insert (this);
940
941 if (objects)
942 objects->prev = this;
943
944 objects = this;
945} 774}
946 775
947void object::unlink () 776void object::unlink ()
948{ 777{
949 count = 0;
950
951 /* Remove this object from the list of used objects */
952 if (prev)
953 {
954 prev->next = next;
955 prev = 0;
956 }
957
958 if (next) 778 if (!index)
959 { 779 return;
960 next->prev = prev; 780
961 next = 0; 781 objects.erase (this);
782 refcnt_dec ();
783}
784
785void
786object::activate ()
787{
788 /* If already on active list, don't do anything */
789 if (active)
790 return;
791
792 if (has_active_speed ())
793 actives.insert (this);
794}
795
796void
797object::activate_recursive ()
798{
799 activate ();
800
801 for (object *op = inv; op; op = op->below)
802 op->activate_recursive ();
803}
804
805/* This function removes object 'op' from the list of active
806 * objects.
807 * This should only be used for style maps or other such
808 * reference maps where you don't want an object that isn't
809 * in play chewing up cpu time getting processed.
810 * The reverse of this is to call update_ob_speed, which
811 * will do the right thing based on the speed of the object.
812 */
813void
814object::deactivate ()
815{
816 /* If not on the active list, nothing needs to be done */
817 if (!active)
818 return;
819
820 actives.erase (this);
821}
822
823void
824object::deactivate_recursive ()
825{
826 for (object *op = inv; op; op = op->below)
827 op->deactivate_recursive ();
828
829 deactivate ();
830}
831
832void
833object::set_flag_inv (int flag, int value)
834{
835 for (object *op = inv; op; op = op->below)
962 } 836 {
837 op->flag [flag] = value;
838 op->set_flag_inv (flag, value);
839 }
840}
963 841
964 if (this == objects) 842/*
965 objects = next; 843 * Remove and free all objects in the inventory of the given object.
844 * object.c ?
845 */
846void
847object::destroy_inv (bool drop_to_ground)
848{
849 // need to check first, because the checks below might segfault
850 // as we might be on an invalid mapspace and crossfire code
851 // is too buggy to ensure that the inventory is empty.
852 // corollary: if you create arrows etc. with stuff in tis inventory,
853 // cf will crash below with off-map x and y
854 if (!inv)
855 return;
856
857 /* Only if the space blocks everything do we not process -
858 * if some form of movement is allowed, let objects
859 * drop on that space.
860 */
861 if (!drop_to_ground
862 || !map
863 || map->in_memory != MAP_IN_MEMORY
864 || map->nodrop
865 || ms ().move_block == MOVE_ALL)
866 {
867 while (inv)
868 {
869 inv->destroy_inv (drop_to_ground);
870 inv->destroy ();
871 }
872 }
873 else
874 { /* Put objects in inventory onto this space */
875 while (inv)
876 {
877 object *op = inv;
878
879 if (op->flag [FLAG_STARTEQUIP]
880 || op->flag [FLAG_NO_DROP]
881 || op->type == RUNE
882 || op->type == TRAP
883 || op->flag [FLAG_IS_A_TEMPLATE]
884 || op->flag [FLAG_DESTROY_ON_DEATH])
885 op->destroy ();
886 else
887 map->insert (op, x, y);
888 }
889 }
966} 890}
967 891
968object *object::create () 892object *object::create ()
969{ 893{
970 object *op;
971
972 if (freed.empty ())
973 op = new object; 894 object *op = new object;
974 else
975 {
976 // highly annoying, but the only way to get it stable right now
977 op = freed.back (); freed.pop_back ();
978 op->~object ();
979 new ((void *)op) object;
980 }
981
982 op->link (); 895 op->link ();
983 return op; 896 return op;
984} 897}
985 898
986/* 899void
987 * free_object() frees everything allocated by an object, removes 900object::do_destroy ()
988 * it from the list of used objects, and puts it on the list of
989 * free objects. The IS_FREED() flag is set in the object.
990 * The object must have been removed by remove_ob() first for
991 * this function to succeed.
992 *
993 * If free_inventory is set, free inventory as well. Else drop items in
994 * inventory to the ground.
995 */
996void object::free (bool free_inventory)
997{ 901{
998 if (!QUERY_FLAG (this, FLAG_REMOVED)) 902 attachable::do_destroy ();
999 {
1000 LOG (llevDebug, "Free object called with non removed object\n");
1001 dump_object (this);
1002#ifdef MANY_CORES
1003 abort ();
1004#endif
1005 }
1006 903
1007 if (QUERY_FLAG (this, FLAG_FRIENDLY)) 904 if (flag [FLAG_IS_LINKED])
1008 { 905 remove_button_link (this);
1009 LOG (llevMonster, "Warning: tried to free friendly object.\n"); 906
907 if (flag [FLAG_FRIENDLY])
1010 remove_friendly_object (this); 908 remove_friendly_object (this);
1011 }
1012 909
1013 if (QUERY_FLAG (this, FLAG_FREED)) 910 if (!flag [FLAG_REMOVED])
911 remove ();
912
913 destroy_inv (true);
914
915 deactivate ();
916 unlink ();
917
918 flag [FLAG_FREED] = 1;
919
920 // hack to ensure that freed objects still have a valid map
921 {
922 static maptile *freed_map; // freed objects are moved here to avoid crashes
923
924 if (!freed_map)
1014 { 925 {
1015 dump_object (this); 926 freed_map = new maptile;
1016 LOG (llevError, "Trying to free freed object.\n%s\n", errmsg); 927
1017 return; 928 freed_map->name = "/internal/freed_objects_map";
929 freed_map->width = 3;
930 freed_map->height = 3;
931
932 freed_map->alloc ();
933 freed_map->in_memory = MAP_IN_MEMORY;
1018 } 934 }
935
936 map = freed_map;
937 x = 1;
938 y = 1;
939 }
940
941 head = 0;
1019 942
1020 if (more) 943 if (more)
1021 { 944 {
1022 more->free (free_inventory); 945 more->destroy ();
1023 more = 0; 946 more = 0;
1024 } 947 }
1025 948
1026 if (inv) 949 // clear those pointers that likely might have circular references to us
1027 { 950 owner = 0;
1028 /* Only if the space blocks everything do we not process - 951 enemy = 0;
1029 * if some form of movement is allowed, let objects 952 attacked_by = 0;
1030 * drop on that space. 953}
1031 */
1032 if (free_inventory || !map || map->in_memory != MAP_IN_MEMORY || (GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL))
1033 {
1034 object *
1035 op = inv;
1036 954
1037 while (op) 955void
1038 { 956object::destroy (bool destroy_inventory)
1039 object * 957{
1040 tmp = op->below; 958 if (destroyed ())
959 return;
1041 960
1042 remove_ob (op); 961 if (destroy_inventory)
1043 op->free (free_inventory); 962 destroy_inv (false);
1044 op = tmp;
1045 }
1046 }
1047 else
1048 { /* Put objects in inventory onto this space */
1049 object *
1050 op = inv;
1051 963
1052 while (op) 964 attachable::destroy ();
1053 {
1054 object *
1055 tmp = op->below;
1056
1057 remove_ob (op);
1058
1059 if (QUERY_FLAG (op, FLAG_STARTEQUIP)
1060 || QUERY_FLAG (op, FLAG_NO_DROP) || op->type == RUNE || op->type == TRAP || QUERY_FLAG (op, FLAG_IS_A_TEMPLATE))
1061 free_object (op);
1062 else
1063 {
1064 op->x = x;
1065 op->y = y;
1066 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
1067 }
1068
1069 op = tmp;
1070 }
1071 }
1072 }
1073
1074 clear_owner (this);
1075
1076 /* Remove object from the active list */
1077 speed = 0;
1078 update_ob_speed (this);
1079
1080 unlink ();
1081
1082 SET_FLAG (this, FLAG_FREED);
1083
1084 mortals.push_back (this);
1085} 965}
1086 966
1087/* 967/*
1088 * sub_weight() recursively (outwards) subtracts a number from the 968 * sub_weight() recursively (outwards) subtracts a number from the
1089 * weight of an object (and what is carried by it's environment(s)). 969 * weight of an object (and what is carried by it's environment(s)).
1090 */ 970 */
1091
1092void 971void
1093sub_weight (object *op, signed long weight) 972sub_weight (object *op, signed long weight)
1094{ 973{
1095 while (op != NULL) 974 while (op != NULL)
1096 { 975 {
1097 if (op->type == CONTAINER) 976 if (op->type == CONTAINER)
1098 {
1099 weight = (signed long) (weight * (100 - op->stats.Str) / 100); 977 weight = (signed long) (weight * (100 - op->stats.Str) / 100);
1100 } 978
1101 op->carrying -= weight; 979 op->carrying -= weight;
1102 op = op->env; 980 op = op->env;
1103 } 981 }
1104} 982}
1105 983
1106/* remove_ob(op): 984/* op->remove ():
1107 * This function removes the object op from the linked list of objects 985 * This function removes the object op from the linked list of objects
1108 * which it is currently tied to. When this function is done, the 986 * which it is currently tied to. When this function is done, the
1109 * object will have no environment. If the object previously had an 987 * object will have no environment. If the object previously had an
1110 * environment, the x and y coordinates will be updated to 988 * environment, the x and y coordinates will be updated to
1111 * the previous environment. 989 * the previous environment.
1112 * Beware: This function is called from the editor as well!
1113 */ 990 */
1114
1115void 991void
1116remove_ob (object *op) 992object::do_remove ()
1117{ 993{
1118 object *tmp, *last = NULL; 994 object *tmp, *last = 0;
1119 object *otmp; 995 object *otmp;
1120 996
1121 tag_t tag;
1122 int check_walk_off;
1123 mapstruct *m;
1124
1125 sint16 x, y;
1126
1127 if (QUERY_FLAG (op, FLAG_REMOVED)) 997 if (QUERY_FLAG (this, FLAG_REMOVED))
1128 { 998 return;
1129 dump_object (op);
1130 LOG (llevError, "Trying to remove removed object.\n%s\n", errmsg);
1131 999
1132 /* Changed it to always dump core in this case. As has been learned
1133 * in the past, trying to recover from errors almost always
1134 * make things worse, and this is a real error here - something
1135 * that should not happen.
1136 * Yes, if this was a mission critical app, trying to do something
1137 * to recover may make sense, but that is because failure of the app
1138 * may have other disastrous problems. Cf runs out of a script
1139 * so is easily enough restarted without any real problems.
1140 * MSW 2001-07-01
1141 */
1142 abort ();
1143 }
1144
1145 if (op->more != NULL)
1146 remove_ob (op->more);
1147
1148 SET_FLAG (op, FLAG_REMOVED); 1000 SET_FLAG (this, FLAG_REMOVED);
1001 INVOKE_OBJECT (REMOVE, this);
1002
1003 if (more)
1004 more->remove ();
1149 1005
1150 /* 1006 /*
1151 * In this case, the object to be removed is in someones 1007 * In this case, the object to be removed is in someones
1152 * inventory. 1008 * inventory.
1153 */ 1009 */
1154 if (op->env != NULL) 1010 if (env)
1155 { 1011 {
1156 if (op->nrof) 1012 if (nrof)
1157 sub_weight (op->env, op->weight * op->nrof); 1013 sub_weight (env, weight * nrof);
1158 else 1014 else
1159 sub_weight (op->env, op->weight + op->carrying); 1015 sub_weight (env, weight + carrying);
1160 1016
1161 /* NO_FIX_PLAYER is set when a great many changes are being 1017 /* NO_FIX_PLAYER is set when a great many changes are being
1162 * made to players inventory. If set, avoiding the call 1018 * made to players inventory. If set, avoiding the call
1163 * to save cpu time. 1019 * to save cpu time.
1164 */ 1020 */
1165 if ((otmp = is_player_inv (op->env)) != NULL && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1021 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1166 fix_player (otmp); 1022 otmp->update_stats ();
1167 1023
1168 if (op->above != NULL) 1024 if (above)
1169 op->above->below = op->below; 1025 above->below = below;
1170 else 1026 else
1171 op->env->inv = op->below; 1027 env->inv = below;
1172 1028
1173 if (op->below != NULL) 1029 if (below)
1174 op->below->above = op->above; 1030 below->above = above;
1175 1031
1176 /* we set up values so that it could be inserted into 1032 /* we set up values so that it could be inserted into
1177 * the map, but we don't actually do that - it is up 1033 * the map, but we don't actually do that - it is up
1178 * to the caller to decide what we want to do. 1034 * to the caller to decide what we want to do.
1179 */ 1035 */
1180 op->x = op->env->x, op->y = op->env->y; 1036 x = env->x, y = env->y;
1181 op->map = op->env->map; 1037 map = env->map;
1182 op->above = NULL, op->below = NULL; 1038 above = 0, below = 0;
1183 op->env = NULL; 1039 env = 0;
1184 return;
1185 }
1186
1187 /* If we get here, we are removing it from a map */
1188 if (op->map == NULL)
1189 return;
1190
1191 x = op->x;
1192 y = op->y;
1193 m = get_map_from_coord (op->map, &x, &y);
1194
1195 if (!m)
1196 { 1040 }
1197 LOG (llevError, "remove_ob called when object was on map but appears to not be within valid coordinates? %s (%d,%d)\n", 1041 else if (map)
1198 op->map->path, op->x, op->y);
1199 /* in old days, we used to set x and y to 0 and continue.
1200 * it seems if we get into this case, something is probablye
1201 * screwed up and should be fixed.
1202 */
1203 abort ();
1204 } 1042 {
1205 if (op->map != m) 1043 if (type == PLAYER)
1206 {
1207 LOG (llevDebug, "remove_ob: Object not really on map it claimed to be on? %s != %s, %d,%d != %d,%d\n",
1208 op->map->path, m->path, op->x, op->y, x, y);
1209 }
1210
1211 /* Re did the following section of code - it looks like it had
1212 * lots of logic for things we no longer care about
1213 */
1214
1215 /* link the object above us */
1216 if (op->above)
1217 op->above->below = op->below;
1218 else
1219 SET_MAP_TOP (m, x, y, op->below); /* we were top, set new top */
1220
1221 /* Relink the object below us, if there is one */
1222 if (op->below)
1223 op->below->above = op->above;
1224 else
1225 {
1226 /* Nothing below, which means we need to relink map object for this space
1227 * use translated coordinates in case some oddness with map tiling is
1228 * evident
1229 */
1230 if (GET_MAP_OB (m, x, y) != op)
1231 { 1044 {
1232 dump_object (op); 1045 // leaving a spot always closes any open container on the ground
1233 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", 1046 if (container && !container->env)
1234 errmsg); 1047 // this causes spurious floorbox updates, but it ensures
1235 dump_object (GET_MAP_OB (m, x, y)); 1048 // that the CLOSE event is being sent.
1236 LOG (llevError, "%s\n", errmsg); 1049 close_container ();
1050
1051 --map->players;
1052 map->touch ();
1237 } 1053 }
1238 1054
1239 SET_MAP_OB (m, x, y, op->above); /* goes on above it. */ 1055 map->dirty = true;
1240 } 1056 mapspace &ms = this->ms ();
1241 1057
1242 op->above = NULL; 1058 /* link the object above us */
1243 op->below = NULL; 1059 if (above)
1060 above->below = below;
1061 else
1062 ms.top = below; /* we were top, set new top */
1244 1063
1245 if (op->map->in_memory == MAP_SAVING) 1064 /* Relink the object below us, if there is one */
1246 return; 1065 if (below)
1247 1066 below->above = above;
1248 tag = op->count; 1067 else
1249 check_walk_off = !QUERY_FLAG (op, FLAG_NO_APPLY);
1250
1251 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above)
1252 {
1253 /* No point updating the players look faces if he is the object
1254 * being removed.
1255 */
1256
1257 if (tmp->type == PLAYER && tmp != op)
1258 { 1068 {
1259 /* If a container that the player is currently using somehow gets 1069 /* Nothing below, which means we need to relink map object for this space
1260 * removed (most likely destroyed), update the player view 1070 * use translated coordinates in case some oddness with map tiling is
1261 * appropriately. 1071 * evident
1262 */ 1072 */
1263 if (tmp->container == op) 1073 if (GET_MAP_OB (map, x, y) != this)
1074 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1075
1076 ms.bot = above; /* goes on above it. */
1077 }
1078
1079 above = 0;
1080 below = 0;
1081
1082 if (map->in_memory == MAP_SAVING)
1083 return;
1084
1085 int check_walk_off = !flag [FLAG_NO_APPLY];
1086
1087 for (tmp = ms.bot; tmp; tmp = tmp->above)
1088 {
1089 /* No point updating the players look faces if he is the object
1090 * being removed.
1091 */
1092
1093 if (tmp->type == PLAYER && tmp != this)
1264 { 1094 {
1265 CLEAR_FLAG (op, FLAG_APPLIED); 1095 /* If a container that the player is currently using somehow gets
1096 * removed (most likely destroyed), update the player view
1097 * appropriately.
1098 */
1099 if (tmp->container == this)
1100 {
1101 flag [FLAG_APPLIED] = 0;
1266 tmp->container = NULL; 1102 tmp->container = 0;
1103 }
1104
1105 if (tmp->contr->ns)
1106 tmp->contr->ns->floorbox_update ();
1267 } 1107 }
1268 1108
1269 tmp->contr->socket.update_look = 1; 1109 /* See if object moving off should effect something */
1110 if (check_walk_off
1111 && ((move_type & tmp->move_off)
1112 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0))
1113 {
1114 move_apply (tmp, this, 0);
1115
1116 if (destroyed ())
1117 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1118 }
1119
1120 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */
1121 //TODO: why is this horrible hacka fix? get rid of this code=bug! (schmorp)
1122 if (tmp->above == tmp)
1123 tmp->above = 0;
1124
1125 last = tmp;
1270 } 1126 }
1271 /* See if player moving off should effect something */
1272 if (check_walk_off && ((op->move_type & tmp->move_off) && (op->move_type & ~tmp->move_off & ~tmp->move_block) == 0))
1273 {
1274 move_apply (tmp, op, NULL);
1275 1127
1276 if (was_destroyed (op, tag))
1277 {
1278 LOG (llevError, "BUG: remove_ob(): name %s, archname %s destroyed " "leaving object\n", &tmp->name, &tmp->arch->name);
1279 }
1280 }
1281
1282 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */
1283
1284 if (tmp->above == tmp)
1285 tmp->above = NULL;
1286
1287 last = tmp;
1288 }
1289
1290 /* last == NULL of there are no objects on this space */ 1128 /* last == NULL if there are no objects on this space */
1291 if (last == NULL) 1129 //TODO: this makes little sense, why only update the topmost object?
1292 { 1130 if (!last)
1293 /* set P_NEED_UPDATE, otherwise update_position will complain. In theory, 1131 map->at (x, y).flags_ = 0;
1294 * we could preserve the flags (GET_MAP_FLAGS), but update_position figures
1295 * those out anyways, and if there are any flags set right now, they won't
1296 * be correct anyways.
1297 */
1298 SET_MAP_FLAGS (op->map, op->x, op->y, P_NEED_UPDATE);
1299 update_position (op->map, op->x, op->y);
1300 }
1301 else 1132 else
1302 update_object (last, UP_OBJ_REMOVE); 1133 update_object (last, UP_OBJ_REMOVE);
1303 1134
1304 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) || (op->glow_radius != 0)) 1135 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1305 update_all_los (op->map, op->x, op->y); 1136 update_all_los (map, x, y);
1137 }
1306} 1138}
1307 1139
1308/* 1140/*
1309 * merge_ob(op,top): 1141 * merge_ob(op,top):
1310 * 1142 *
1311 * This function goes through all objects below and including top, and 1143 * This function goes through all objects below and including top, and
1312 * merges op to the first matching object. 1144 * merges op to the first matching object.
1313 * If top is NULL, it is calculated. 1145 * If top is NULL, it is calculated.
1314 * Returns pointer to object if it succeded in the merge, otherwise NULL 1146 * Returns pointer to object if it succeded in the merge, otherwise NULL
1315 */ 1147 */
1316
1317object * 1148object *
1318merge_ob (object *op, object *top) 1149merge_ob (object *op, object *top)
1319{ 1150{
1320 if (!op->nrof) 1151 if (!op->nrof)
1321 return 0; 1152 return 0;
1322 if (top == NULL) 1153
1154 if (top)
1323 for (top = op; top != NULL && top->above != NULL; top = top->above); 1155 for (top = op; top && top->above; top = top->above)
1156 ;
1157
1324 for (; top != NULL; top = top->below) 1158 for (; top; top = top->below)
1325 { 1159 {
1326 if (top == op) 1160 if (top == op)
1327 continue; 1161 continue;
1328 if (CAN_MERGE (op, top)) 1162
1163 if (object::can_merge (op, top))
1329 { 1164 {
1330 top->nrof += op->nrof; 1165 top->nrof += op->nrof;
1331 1166
1332/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/ 1167/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/
1333 op->weight = 0; /* Don't want any adjustements now */ 1168 op->weight = 0; /* Don't want any adjustements now */
1334 remove_ob (op); 1169 op->destroy ();
1335 free_object (op);
1336 return top; 1170 return top;
1337 } 1171 }
1338 } 1172 }
1173
1339 return NULL; 1174 return 0;
1340} 1175}
1341 1176
1177void
1178object::expand_tail ()
1179{
1180 if (more)
1181 return;
1182
1183 object *prev = this;
1184
1185 for (archetype *at = arch->more; at; at = at->more)
1186 {
1187 object *op = arch_to_object (at);
1188
1189 op->name = name;
1190 op->name_pl = name_pl;
1191 op->title = title;
1192
1193 op->head = this;
1194 prev->more = op;
1195
1196 prev = op;
1197 }
1198}
1199
1342/* 1200/*
1343 * same as insert_ob_in_map except it handle separate coordinates and do a clean 1201 * same as insert_ob_in_map except it handles separate coordinates and does a clean
1344 * job preparing multi-part monsters 1202 * job preparing multi-part monsters.
1345 */ 1203 */
1346object * 1204object *
1347insert_ob_in_map_at (object *op, mapstruct *m, object *originator, int flag, int x, int y) 1205insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1348{ 1206{
1349 object *
1350 tmp;
1351
1352 if (op->head)
1353 op = op->head;
1354 for (tmp = op; tmp; tmp = tmp->more) 1207 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1355 { 1208 {
1356 tmp->x = x + tmp->arch->clone.x; 1209 tmp->x = x + tmp->arch->clone.x;
1357 tmp->y = y + tmp->arch->clone.y; 1210 tmp->y = y + tmp->arch->clone.y;
1358 } 1211 }
1212
1359 return insert_ob_in_map (op, m, originator, flag); 1213 return insert_ob_in_map (op, m, originator, flag);
1360} 1214}
1361 1215
1362/* 1216/*
1363 * insert_ob_in_map (op, map, originator, flag): 1217 * insert_ob_in_map (op, map, originator, flag):
… …
1377 * Return value: 1231 * Return value:
1378 * new object if 'op' was merged with other object 1232 * new object if 'op' was merged with other object
1379 * NULL if 'op' was destroyed 1233 * NULL if 'op' was destroyed
1380 * just 'op' otherwise 1234 * just 'op' otherwise
1381 */ 1235 */
1382
1383object * 1236object *
1384insert_ob_in_map (object *op, mapstruct *m, object *originator, int flag) 1237insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1385{ 1238{
1239 assert (!op->flag [FLAG_FREED]);
1240
1386 object *tmp, *top, *floor = NULL; 1241 object *tmp, *top, *floor = NULL;
1387 sint16 x, y;
1388 1242
1389 if (QUERY_FLAG (op, FLAG_FREED)) 1243 op->remove ();
1390 {
1391 LOG (llevError, "Trying to insert freed object!\n");
1392 return NULL;
1393 }
1394 1244
1395 if (m == NULL) 1245#if 0
1396 { 1246 if (!m->active != !op->active)
1397 dump_object (op); 1247 if (m->active)
1398 LOG (llevError, "Trying to insert in null-map!\n%s\n", errmsg); 1248 op->activate_recursive ();
1399 return op; 1249 else
1400 } 1250 op->deactivate_recursive ();
1251#endif
1401 1252
1402 if (out_of_map (m, op->x, op->y)) 1253 if (out_of_map (m, op->x, op->y))
1403 { 1254 {
1404 dump_object (op);
1405 LOG (llevError, "Trying to insert object outside the map.\n%s\n", errmsg); 1255 LOG (llevError, "Trying to insert object outside the map.\n%s\n", op->debug_desc ());
1406#ifdef MANY_CORES 1256#ifdef MANY_CORES
1407 /* Better to catch this here, as otherwise the next use of this object 1257 /* Better to catch this here, as otherwise the next use of this object
1408 * is likely to cause a crash. Better to find out where it is getting 1258 * is likely to cause a crash. Better to find out where it is getting
1409 * improperly inserted. 1259 * improperly inserted.
1410 */ 1260 */
1411 abort (); 1261 abort ();
1412#endif 1262#endif
1413 return op; 1263 return op;
1414 } 1264 }
1415 1265
1416 if (!QUERY_FLAG (op, FLAG_REMOVED))
1417 {
1418 dump_object (op);
1419 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", errmsg);
1420 return op;
1421 }
1422
1423 if (op->more != NULL)
1424 {
1425 /* The part may be on a different map. */
1426
1427 object *more = op->more; 1266 if (object *more = op->more)
1428 1267 {
1429 /* We really need the caller to normalize coordinates - if
1430 * we set the map, that doesn't work if the location is within
1431 * a map and this is straddling an edge. So only if coordinate
1432 * is clear wrong do we normalize it.
1433 */
1434 if (OUT_OF_REAL_MAP (more->map, more->x, more->y))
1435 more->map = get_map_from_coord (m, &more->x, &more->y);
1436 else if (!more->map)
1437 {
1438 /* For backwards compatibility - when not dealing with tiled maps,
1439 * more->map should always point to the parent.
1440 */
1441 more->map = m;
1442 }
1443
1444 if (insert_ob_in_map (more, more->map, originator, flag) == NULL) 1268 if (!insert_ob_in_map (more, m, originator, flag))
1445 { 1269 {
1446 if (!op->head) 1270 if (!op->head)
1447 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n"); 1271 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n");
1448 1272
1449 return NULL; 1273 return 0;
1450 } 1274 }
1451 } 1275 }
1452 1276
1453 CLEAR_FLAG (op, FLAG_REMOVED); 1277 CLEAR_FLAG (op, FLAG_REMOVED);
1454 1278
1455 /* Ideally, the caller figures this out. However, it complicates a lot 1279 /* Ideally, the caller figures this out. However, it complicates a lot
1456 * of areas of callers (eg, anything that uses find_free_spot would now 1280 * of areas of callers (eg, anything that uses find_free_spot would now
1457 * need extra work 1281 * need extra work
1458 */ 1282 */
1459 op->map = get_map_from_coord (m, &op->x, &op->y); 1283 if (!xy_normalise (m, op->x, op->y))
1460 x = op->x; 1284 return 0;
1461 y = op->y; 1285
1286 op->map = m;
1287 mapspace &ms = op->ms ();
1462 1288
1463 /* this has to be done after we translate the coordinates. 1289 /* this has to be done after we translate the coordinates.
1464 */ 1290 */
1465 if (op->nrof && !(flag & INS_NO_MERGE)) 1291 if (op->nrof && !(flag & INS_NO_MERGE))
1466 for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above) 1292 for (tmp = ms.bot; tmp; tmp = tmp->above)
1467 if (CAN_MERGE (op, tmp)) 1293 if (object::can_merge (op, tmp))
1468 { 1294 {
1469 op->nrof += tmp->nrof; 1295 op->nrof += tmp->nrof;
1470 remove_ob (tmp); 1296 tmp->destroy ();
1471 free_object (tmp);
1472 } 1297 }
1473 1298
1474 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1299 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1475 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1300 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1476 1301
… …
1489 op->below = originator->below; 1314 op->below = originator->below;
1490 1315
1491 if (op->below) 1316 if (op->below)
1492 op->below->above = op; 1317 op->below->above = op;
1493 else 1318 else
1494 SET_MAP_OB (op->map, op->x, op->y, op); 1319 ms.bot = op;
1495 1320
1496 /* since *below* originator, no need to update top */ 1321 /* since *below* originator, no need to update top */
1497 originator->below = op; 1322 originator->below = op;
1498 } 1323 }
1499 else 1324 else
1500 { 1325 {
1326 top = ms.bot;
1327
1501 /* If there are other objects, then */ 1328 /* If there are other objects, then */
1502 if ((!(flag & INS_MAP_LOAD)) && ((top = GET_MAP_OB (op->map, op->x, op->y)) != NULL)) 1329 if ((!(flag & INS_MAP_LOAD)) && top)
1503 { 1330 {
1504 object *last = NULL; 1331 object *last = 0;
1505 1332
1506 /* 1333 /*
1507 * If there are multiple objects on this space, we do some trickier handling. 1334 * If there are multiple objects on this space, we do some trickier handling.
1508 * We've already dealt with merging if appropriate. 1335 * We've already dealt with merging if appropriate.
1509 * Generally, we want to put the new object on top. But if 1336 * Generally, we want to put the new object on top. But if
… …
1513 * once we get to them. This reduces the need to traverse over all of 1340 * once we get to them. This reduces the need to traverse over all of
1514 * them when adding another one - this saves quite a bit of cpu time 1341 * them when adding another one - this saves quite a bit of cpu time
1515 * when lots of spells are cast in one area. Currently, it is presumed 1342 * when lots of spells are cast in one area. Currently, it is presumed
1516 * that flying non pickable objects are spell objects. 1343 * that flying non pickable objects are spell objects.
1517 */ 1344 */
1518 1345 for (top = ms.bot; top; top = top->above)
1519 while (top != NULL)
1520 { 1346 {
1521 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1347 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))
1522 floor = top; 1348 floor = top;
1523 1349
1524 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1350 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))
… …
1527 top = top->below; 1353 top = top->below;
1528 break; 1354 break;
1529 } 1355 }
1530 1356
1531 last = top; 1357 last = top;
1532 top = top->above;
1533 } 1358 }
1534 1359
1535 /* Don't want top to be NULL, so set it to the last valid object */ 1360 /* Don't want top to be NULL, so set it to the last valid object */
1536 top = last; 1361 top = last;
1537 1362
… …
1539 * looks like instead of lots of conditions here. 1364 * looks like instead of lots of conditions here.
1540 * makes things faster, and effectively the same result. 1365 * makes things faster, and effectively the same result.
1541 */ 1366 */
1542 1367
1543 /* Have object 'fall below' other objects that block view. 1368 /* Have object 'fall below' other objects that block view.
1544 * Unless those objects are exits, type 66 1369 * Unless those objects are exits.
1545 * If INS_ON_TOP is used, don't do this processing 1370 * If INS_ON_TOP is used, don't do this processing
1546 * Need to find the object that in fact blocks view, otherwise 1371 * Need to find the object that in fact blocks view, otherwise
1547 * stacking is a bit odd. 1372 * stacking is a bit odd.
1548 */ 1373 */
1549 if (!(flag & INS_ON_TOP) && 1374 if (!(flag & INS_ON_TOP)
1550 (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_BLOCKSVIEW) && (op->face && !op->face->visibility)) 1375 && ms.flags () & P_BLOCKSVIEW
1376 && (op->face && !faces [op->face].visibility))
1551 { 1377 {
1552 for (last = top; last != floor; last = last->below) 1378 for (last = top; last != floor; last = last->below)
1553 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1379 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1554 break; 1380 break;
1381
1555 /* Check to see if we found the object that blocks view, 1382 /* Check to see if we found the object that blocks view,
1556 * and make sure we have a below pointer for it so that 1383 * and make sure we have a below pointer for it so that
1557 * we can get inserted below this one, which requires we 1384 * we can get inserted below this one, which requires we
1558 * set top to the object below us. 1385 * set top to the object below us.
1559 */ 1386 */
… …
1561 top = last->below; 1388 top = last->below;
1562 } 1389 }
1563 } /* If objects on this space */ 1390 } /* If objects on this space */
1564 1391
1565 if (flag & INS_MAP_LOAD) 1392 if (flag & INS_MAP_LOAD)
1566 top = GET_MAP_TOP (op->map, op->x, op->y); 1393 top = ms.top;
1567 1394
1568 if (flag & INS_ABOVE_FLOOR_ONLY) 1395 if (flag & INS_ABOVE_FLOOR_ONLY)
1569 top = floor; 1396 top = floor;
1570 1397
1571 /* Top is the object that our object (op) is going to get inserted above. 1398 /* Top is the object that our object (op) is going to get inserted above.
1572 */ 1399 */
1573 1400
1574 /* First object on this space */ 1401 /* First object on this space */
1575 if (!top) 1402 if (!top)
1576 { 1403 {
1577 op->above = GET_MAP_OB (op->map, op->x, op->y); 1404 op->above = ms.bot;
1578 1405
1579 if (op->above) 1406 if (op->above)
1580 op->above->below = op; 1407 op->above->below = op;
1581 1408
1582 op->below = NULL; 1409 op->below = 0;
1583 SET_MAP_OB (op->map, op->x, op->y, op); 1410 ms.bot = op;
1584 } 1411 }
1585 else 1412 else
1586 { /* get inserted into the stack above top */ 1413 { /* get inserted into the stack above top */
1587 op->above = top->above; 1414 op->above = top->above;
1588 1415
… …
1591 1418
1592 op->below = top; 1419 op->below = top;
1593 top->above = op; 1420 top->above = op;
1594 } 1421 }
1595 1422
1596 if (op->above == NULL) 1423 if (!op->above)
1597 SET_MAP_TOP (op->map, op->x, op->y, op); 1424 ms.top = op;
1598 } /* else not INS_BELOW_ORIGINATOR */ 1425 } /* else not INS_BELOW_ORIGINATOR */
1599 1426
1600 if (op->type == PLAYER) 1427 if (op->type == PLAYER)
1428 {
1601 op->contr->do_los = 1; 1429 op->contr->do_los = 1;
1430 ++op->map->players;
1431 op->map->touch ();
1432 }
1433
1434 op->map->dirty = true;
1602 1435
1603 /* If we have a floor, we know the player, if any, will be above 1436 /* If we have a floor, we know the player, if any, will be above
1604 * it, so save a few ticks and start from there. 1437 * it, so save a few ticks and start from there.
1605 */ 1438 */
1606 if (!(flag & INS_MAP_LOAD)) 1439 if (!(flag & INS_MAP_LOAD))
1607 for (tmp = floor ? floor : GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1440 if (object *pl = ms.player ())
1608 if (tmp->type == PLAYER) 1441 if (pl->contr->ns)
1609 tmp->contr->socket.update_look = 1; 1442 pl->contr->ns->floorbox_update ();
1610 1443
1611 /* If this object glows, it may affect lighting conditions that are 1444 /* If this object glows, it may affect lighting conditions that are
1612 * visible to others on this map. But update_all_los is really 1445 * visible to others on this map. But update_all_los is really
1613 * an inefficient way to do this, as it means los for all players 1446 * an inefficient way to do this, as it means los for all players
1614 * on the map will get recalculated. The players could very well 1447 * on the map will get recalculated. The players could very well
1615 * be far away from this change and not affected in any way - 1448 * be far away from this change and not affected in any way -
1616 * this should get redone to only look for players within range, 1449 * this should get redone to only look for players within range,
1617 * or just updating the P_NEED_UPDATE for spaces within this area 1450 * or just updating the P_UPTODATE for spaces within this area
1618 * of effect may be sufficient. 1451 * of effect may be sufficient.
1619 */ 1452 */
1620 if (MAP_DARKNESS (op->map) && (op->glow_radius != 0)) 1453 if (op->map->darkness && (op->glow_radius != 0))
1621 update_all_los (op->map, op->x, op->y); 1454 update_all_los (op->map, op->x, op->y);
1622 1455
1623 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1456 /* updates flags (blocked, alive, no magic, etc) for this map space */
1624 update_object (op, UP_OBJ_INSERT); 1457 update_object (op, UP_OBJ_INSERT);
1625 1458
1459 INVOKE_OBJECT (INSERT, op);
1460
1626 /* Don't know if moving this to the end will break anything. However, 1461 /* Don't know if moving this to the end will break anything. However,
1627 * we want to have update_look set above before calling this. 1462 * we want to have floorbox_update called before calling this.
1628 * 1463 *
1629 * check_move_on() must be after this because code called from 1464 * check_move_on() must be after this because code called from
1630 * check_move_on() depends on correct map flags (so functions like 1465 * check_move_on() depends on correct map flags (so functions like
1631 * blocked() and wall() work properly), and these flags are updated by 1466 * blocked() and wall() work properly), and these flags are updated by
1632 * update_object(). 1467 * update_object().
… …
1634 1469
1635 /* if this is not the head or flag has been passed, don't check walk on status */ 1470 /* if this is not the head or flag has been passed, don't check walk on status */
1636 if (!(flag & INS_NO_WALK_ON) && !op->head) 1471 if (!(flag & INS_NO_WALK_ON) && !op->head)
1637 { 1472 {
1638 if (check_move_on (op, originator)) 1473 if (check_move_on (op, originator))
1639 return NULL; 1474 return 0;
1640 1475
1641 /* If we are a multi part object, lets work our way through the check 1476 /* If we are a multi part object, lets work our way through the check
1642 * walk on's. 1477 * walk on's.
1643 */ 1478 */
1644 for (tmp = op->more; tmp != NULL; tmp = tmp->more) 1479 for (tmp = op->more; tmp != NULL; tmp = tmp->more)
1645 if (check_move_on (tmp, originator)) 1480 if (check_move_on (tmp, originator))
1646 return NULL; 1481 return 0;
1647 } 1482 }
1648 1483
1649 return op; 1484 return op;
1650} 1485}
1651 1486
1652/* this function inserts an object in the map, but if it 1487/* this function inserts an object in the map, but if it
1653 * finds an object of its own type, it'll remove that one first. 1488 * finds an object of its own type, it'll remove that one first.
1654 * op is the object to insert it under: supplies x and the map. 1489 * op is the object to insert it under: supplies x and the map.
1655 */ 1490 */
1656void 1491void
1657replace_insert_ob_in_map (const char *arch_string, object *op) 1492replace_insert_ob_in_map (const char *arch_string, object *op)
1658{ 1493{
1659 object *tmp;
1660 object *tmp1; 1494 object *tmp, *tmp1;
1661 1495
1662 /* first search for itself and remove any old instances */ 1496 /* first search for itself and remove any old instances */
1663 1497
1664 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1498 for (tmp = op->ms ().bot; tmp; tmp = tmp->above)
1665 {
1666 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */ 1499 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */
1667 { 1500 tmp->destroy ();
1668 remove_ob (tmp);
1669 free_object (tmp);
1670 }
1671 }
1672 1501
1673 tmp1 = arch_to_object (find_archetype (arch_string)); 1502 tmp1 = arch_to_object (archetype::find (arch_string));
1674 1503
1675 tmp1->x = op->x; 1504 tmp1->x = op->x;
1676 tmp1->y = op->y; 1505 tmp1->y = op->y;
1677 insert_ob_in_map (tmp1, op->map, op, 0); 1506 insert_ob_in_map (tmp1, op->map, op, 0);
1507}
1508
1509object *
1510object::insert_at (object *where, object *originator, int flags)
1511{
1512 return where->map->insert (this, where->x, where->y, originator, flags);
1678} 1513}
1679 1514
1680/* 1515/*
1681 * get_split_ob(ob,nr) splits up ob into two parts. The part which 1516 * get_split_ob(ob,nr) splits up ob into two parts. The part which
1682 * is returned contains nr objects, and the remaining parts contains 1517 * is returned contains nr objects, and the remaining parts contains
1683 * the rest (or is removed and freed if that number is 0). 1518 * the rest (or is removed and freed if that number is 0).
1684 * On failure, NULL is returned, and the reason put into the 1519 * On failure, NULL is returned, and the reason put into the
1685 * global static errmsg array. 1520 * global static errmsg array.
1686 */ 1521 */
1687
1688object * 1522object *
1689get_split_ob (object *orig_ob, uint32 nr) 1523get_split_ob (object *orig_ob, uint32 nr)
1690{ 1524{
1691 object * 1525 object *newob;
1692 newob;
1693 int
1694 is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0); 1526 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1695 1527
1696 if (orig_ob->nrof < nr) 1528 if (orig_ob->nrof < nr)
1697 { 1529 {
1698 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name); 1530 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1699 return NULL; 1531 return NULL;
1700 } 1532 }
1533
1701 newob = object_create_clone (orig_ob); 1534 newob = object_create_clone (orig_ob);
1535
1702 if ((orig_ob->nrof -= nr) < 1) 1536 if ((orig_ob->nrof -= nr) < 1)
1703 { 1537 orig_ob->destroy (1);
1704 if (!is_removed)
1705 remove_ob (orig_ob);
1706 free_object2 (orig_ob, 1);
1707 }
1708 else if (!is_removed) 1538 else if (!is_removed)
1709 { 1539 {
1710 if (orig_ob->env != NULL) 1540 if (orig_ob->env != NULL)
1711 sub_weight (orig_ob->env, orig_ob->weight * nr); 1541 sub_weight (orig_ob->env, orig_ob->weight * nr);
1712 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY) 1542 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY)
… …
1714 strcpy (errmsg, "Tried to split object whose map is not in memory."); 1544 strcpy (errmsg, "Tried to split object whose map is not in memory.");
1715 LOG (llevDebug, "Error, Tried to split object whose map is not in memory.\n"); 1545 LOG (llevDebug, "Error, Tried to split object whose map is not in memory.\n");
1716 return NULL; 1546 return NULL;
1717 } 1547 }
1718 } 1548 }
1549
1719 newob->nrof = nr; 1550 newob->nrof = nr;
1720 1551
1721 return newob; 1552 return newob;
1722} 1553}
1723 1554
… …
1726 * the amount of an object. If the amount reaches 0, the object 1557 * the amount of an object. If the amount reaches 0, the object
1727 * is subsequently removed and freed. 1558 * is subsequently removed and freed.
1728 * 1559 *
1729 * Return value: 'op' if something is left, NULL if the amount reached 0 1560 * Return value: 'op' if something is left, NULL if the amount reached 0
1730 */ 1561 */
1731
1732object * 1562object *
1733decrease_ob_nr (object *op, uint32 i) 1563decrease_ob_nr (object *op, uint32 i)
1734{ 1564{
1735 object * 1565 object *tmp;
1736 tmp;
1737 player *
1738 pl;
1739 1566
1740 if (i == 0) /* objects with op->nrof require this check */ 1567 if (i == 0) /* objects with op->nrof require this check */
1741 return op; 1568 return op;
1742 1569
1743 if (i > op->nrof) 1570 if (i > op->nrof)
1744 i = op->nrof; 1571 i = op->nrof;
1745 1572
1746 if (QUERY_FLAG (op, FLAG_REMOVED)) 1573 if (QUERY_FLAG (op, FLAG_REMOVED))
1747 {
1748 op->nrof -= i; 1574 op->nrof -= i;
1749 }
1750 else if (op->env != NULL) 1575 else if (op->env)
1751 { 1576 {
1752 /* is this object in the players inventory, or sub container 1577 /* is this object in the players inventory, or sub container
1753 * therein? 1578 * therein?
1754 */ 1579 */
1755 tmp = is_player_inv (op->env); 1580 tmp = op->in_player ();
1756 /* nope. Is this a container the player has opened? 1581 /* nope. Is this a container the player has opened?
1757 * If so, set tmp to that player. 1582 * If so, set tmp to that player.
1758 * IMO, searching through all the players will mostly 1583 * IMO, searching through all the players will mostly
1759 * likely be quicker than following op->env to the map, 1584 * likely be quicker than following op->env to the map,
1760 * and then searching the map for a player. 1585 * and then searching the map for a player.
1761 */ 1586 */
1762 if (!tmp) 1587 if (!tmp)
1763 { 1588 for_all_players (pl)
1764 for (pl = first_player; pl; pl = pl->next)
1765 if (pl->ob->container == op->env) 1589 if (pl->ob->container == op->env)
1590 {
1591 tmp = pl->ob;
1766 break; 1592 break;
1767 if (pl)
1768 tmp = pl->ob;
1769 else
1770 tmp = NULL;
1771 } 1593 }
1772 1594
1773 if (i < op->nrof) 1595 if (i < op->nrof)
1774 { 1596 {
1775 sub_weight (op->env, op->weight * i); 1597 sub_weight (op->env, op->weight * i);
1776 op->nrof -= i; 1598 op->nrof -= i;
1777 if (tmp) 1599 if (tmp)
1778 {
1779 esrv_send_item (tmp, op); 1600 esrv_send_item (tmp, op);
1780 }
1781 } 1601 }
1782 else 1602 else
1783 { 1603 {
1784 remove_ob (op); 1604 op->remove ();
1785 op->nrof = 0; 1605 op->nrof = 0;
1786 if (tmp) 1606 if (tmp)
1787 {
1788 esrv_del_item (tmp->contr, op->count); 1607 esrv_del_item (tmp->contr, op->count);
1789 }
1790 } 1608 }
1791 } 1609 }
1792 else 1610 else
1793 { 1611 {
1794 object *
1795 above = op->above; 1612 object *above = op->above;
1796 1613
1797 if (i < op->nrof) 1614 if (i < op->nrof)
1798 {
1799 op->nrof -= i; 1615 op->nrof -= i;
1800 }
1801 else 1616 else
1802 { 1617 {
1803 remove_ob (op); 1618 op->remove ();
1804 op->nrof = 0; 1619 op->nrof = 0;
1805 } 1620 }
1621
1806 /* Since we just removed op, op->above is null */ 1622 /* Since we just removed op, op->above is null */
1807 for (tmp = above; tmp != NULL; tmp = tmp->above) 1623 for (tmp = above; tmp; tmp = tmp->above)
1808 if (tmp->type == PLAYER) 1624 if (tmp->type == PLAYER)
1809 { 1625 {
1810 if (op->nrof) 1626 if (op->nrof)
1811 esrv_send_item (tmp, op); 1627 esrv_send_item (tmp, op);
1812 else 1628 else
1813 esrv_del_item (tmp->contr, op->count); 1629 esrv_del_item (tmp->contr, op->count);
1814 } 1630 }
1815 } 1631 }
1816 1632
1817 if (op->nrof) 1633 if (op->nrof)
1818 {
1819 return op; 1634 return op;
1820 }
1821 else 1635 else
1822 { 1636 {
1823 free_object (op); 1637 op->destroy ();
1824 return NULL; 1638 return 0;
1825 } 1639 }
1826} 1640}
1827 1641
1828/* 1642/*
1829 * add_weight(object, weight) adds the specified weight to an object, 1643 * add_weight(object, weight) adds the specified weight to an object,
1830 * and also updates how much the environment(s) is/are carrying. 1644 * and also updates how much the environment(s) is/are carrying.
1831 */ 1645 */
1832
1833void 1646void
1834add_weight (object *op, signed long weight) 1647add_weight (object *op, signed long weight)
1835{ 1648{
1836 while (op != NULL) 1649 while (op != NULL)
1837 { 1650 {
1838 if (op->type == CONTAINER) 1651 if (op->type == CONTAINER)
1839 {
1840 weight = (signed long) (weight * (100 - op->stats.Str) / 100); 1652 weight = (signed long) (weight * (100 - op->stats.Str) / 100);
1841 } 1653
1842 op->carrying += weight; 1654 op->carrying += weight;
1843 op = op->env; 1655 op = op->env;
1844 } 1656 }
1845} 1657}
1846 1658
1659object *
1660insert_ob_in_ob (object *op, object *where)
1661{
1662 if (!where)
1663 {
1664 char *dump = dump_object (op);
1665 LOG (llevError, "Trying to put object in NULL.\n%s\n", dump);
1666 free (dump);
1667 return op;
1668 }
1669
1670 if (where->head)
1671 {
1672 LOG (llevDebug, "Warning: Tried to insert object into wrong part of multipart object.\n");
1673 where = where->head;
1674 }
1675
1676 return where->insert (op);
1677}
1678
1847/* 1679/*
1848 * insert_ob_in_ob(op,environment): 1680 * env->insert (op)
1849 * This function inserts the object op in the linked list 1681 * This function inserts the object op in the linked list
1850 * inside the object environment. 1682 * inside the object environment.
1851 * 1683 *
1852 * Eneq(@csd.uu.se): Altered insert_ob_in_ob to make things picked up enter
1853 * the inventory at the last position or next to other objects of the same
1854 * type.
1855 * Frank: Now sorted by type, archetype and magic!
1856 *
1857 * The function returns now pointer to inserted item, and return value can 1684 * The function returns now pointer to inserted item, and return value can
1858 * be != op, if items are merged. -Tero 1685 * be != op, if items are merged. -Tero
1859 */ 1686 */
1860
1861object * 1687object *
1862insert_ob_in_ob (object *op, object *where) 1688object::insert (object *op)
1863{ 1689{
1864 object * 1690 object *tmp, *otmp;
1865 tmp, *
1866 otmp;
1867 1691
1868 if (!QUERY_FLAG (op, FLAG_REMOVED)) 1692 if (!QUERY_FLAG (op, FLAG_REMOVED))
1869 { 1693 op->remove ();
1870 dump_object (op); 1694
1871 LOG (llevError, "Trying to insert (ob) inserted object.\n%s\n", errmsg);
1872 return op;
1873 }
1874 if (where == NULL)
1875 {
1876 dump_object (op);
1877 LOG (llevError, "Trying to put object in NULL.\n%s\n", errmsg);
1878 return op;
1879 }
1880 if (where->head)
1881 {
1882 LOG (llevDebug, "Warning: Tried to insert object wrong part of multipart object.\n");
1883 where = where->head;
1884 }
1885 if (op->more) 1695 if (op->more)
1886 { 1696 {
1887 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count); 1697 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);
1888 return op; 1698 return op;
1889 } 1699 }
1700
1890 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL); 1701 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL);
1891 CLEAR_FLAG (op, FLAG_REMOVED); 1702 CLEAR_FLAG (op, FLAG_REMOVED);
1892 if (op->nrof) 1703 if (op->nrof)
1893 { 1704 {
1894 for (tmp = where->inv; tmp != NULL; tmp = tmp->below) 1705 for (tmp = inv; tmp != NULL; tmp = tmp->below)
1895 if (CAN_MERGE (tmp, op)) 1706 if (object::can_merge (tmp, op))
1896 { 1707 {
1897 /* return the original object and remove inserted object 1708 /* return the original object and remove inserted object
1898 (client needs the original object) */ 1709 (client needs the original object) */
1899 tmp->nrof += op->nrof; 1710 tmp->nrof += op->nrof;
1900 /* Weight handling gets pretty funky. Since we are adding to 1711 /* Weight handling gets pretty funky. Since we are adding to
1901 * tmp->nrof, we need to increase the weight. 1712 * tmp->nrof, we need to increase the weight.
1902 */ 1713 */
1903 add_weight (where, op->weight * op->nrof); 1714 add_weight (this, op->weight * op->nrof);
1904 SET_FLAG (op, FLAG_REMOVED); 1715 SET_FLAG (op, FLAG_REMOVED);
1905 free_object (op); /* free the inserted object */ 1716 op->destroy (); /* free the inserted object */
1906 op = tmp; 1717 op = tmp;
1907 remove_ob (op); /* and fix old object's links */ 1718 op->remove (); /* and fix old object's links */
1908 CLEAR_FLAG (op, FLAG_REMOVED); 1719 CLEAR_FLAG (op, FLAG_REMOVED);
1909 break; 1720 break;
1910 } 1721 }
1911 1722
1912 /* I assume combined objects have no inventory 1723 /* I assume combined objects have no inventory
1913 * We add the weight - this object could have just been removed 1724 * We add the weight - this object could have just been removed
1914 * (if it was possible to merge). calling remove_ob will subtract 1725 * (if it was possible to merge). calling remove_ob will subtract
1915 * the weight, so we need to add it in again, since we actually do 1726 * the weight, so we need to add it in again, since we actually do
1916 * the linking below 1727 * the linking below
1917 */ 1728 */
1918 add_weight (where, op->weight * op->nrof); 1729 add_weight (this, op->weight * op->nrof);
1919 } 1730 }
1920 else 1731 else
1921 add_weight (where, (op->weight + op->carrying)); 1732 add_weight (this, (op->weight + op->carrying));
1922 1733
1923 otmp = is_player_inv (where); 1734 otmp = this->in_player ();
1924 if (otmp && otmp->contr != NULL) 1735 if (otmp && otmp->contr)
1925 {
1926 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1736 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1927 fix_player (otmp); 1737 otmp->update_stats ();
1928 }
1929 1738
1930 op->map = NULL; 1739 op->map = 0;
1931 op->env = where; 1740 op->env = this;
1932 op->above = NULL; 1741 op->above = 0;
1933 op->below = NULL; 1742 op->below = 0;
1934 op->x = 0, op->y = 0; 1743 op->x = 0, op->y = 0;
1935 1744
1936 /* reset the light list and los of the players on the map */ 1745 /* reset the light list and los of the players on the map */
1937 if ((op->glow_radius != 0) && where->map) 1746 if ((op->glow_radius != 0) && map)
1938 { 1747 {
1939#ifdef DEBUG_LIGHTS 1748#ifdef DEBUG_LIGHTS
1940 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name); 1749 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1941#endif /* DEBUG_LIGHTS */ 1750#endif /* DEBUG_LIGHTS */
1942 if (MAP_DARKNESS (where->map)) 1751 if (map->darkness)
1943 update_all_los (where->map, where->x, where->y); 1752 update_all_los (map, x, y);
1944 } 1753 }
1945 1754
1946 /* Client has no idea of ordering so lets not bother ordering it here. 1755 /* Client has no idea of ordering so lets not bother ordering it here.
1947 * It sure simplifies this function... 1756 * It sure simplifies this function...
1948 */ 1757 */
1949 if (where->inv == NULL) 1758 if (!inv)
1950 where->inv = op; 1759 inv = op;
1951 else 1760 else
1952 { 1761 {
1953 op->below = where->inv; 1762 op->below = inv;
1954 op->below->above = op; 1763 op->below->above = op;
1955 where->inv = op; 1764 inv = op;
1956 } 1765 }
1766
1767 INVOKE_OBJECT (INSERT, this);
1768
1957 return op; 1769 return op;
1958} 1770}
1959 1771
1960/* 1772/*
1961 * Checks if any objects has a move_type that matches objects 1773 * Checks if any objects has a move_type that matches objects
… …
1975 * 1787 *
1976 * MSW 2001-07-08: Check all objects on space, not just those below 1788 * MSW 2001-07-08: Check all objects on space, not just those below
1977 * object being inserted. insert_ob_in_map may not put new objects 1789 * object being inserted. insert_ob_in_map may not put new objects
1978 * on top. 1790 * on top.
1979 */ 1791 */
1980
1981int 1792int
1982check_move_on (object *op, object *originator) 1793check_move_on (object *op, object *originator)
1983{ 1794{
1984 object *tmp; 1795 object *tmp;
1985 tag_t tag;
1986 mapstruct *m = op->map; 1796 maptile *m = op->map;
1987 int x = op->x, y = op->y; 1797 int x = op->x, y = op->y;
1988 1798
1989 MoveType move_on, move_slow, move_block; 1799 MoveType move_on, move_slow, move_block;
1990 1800
1991 if (QUERY_FLAG (op, FLAG_NO_APPLY)) 1801 if (QUERY_FLAG (op, FLAG_NO_APPLY))
1992 return 0; 1802 return 0;
1993
1994 tag = op->count;
1995 1803
1996 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y); 1804 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
1997 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y); 1805 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
1998 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y); 1806 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
1999 1807
… …
2015 1823
2016 /* The objects have to be checked from top to bottom. 1824 /* The objects have to be checked from top to bottom.
2017 * Hence, we first go to the top: 1825 * Hence, we first go to the top:
2018 */ 1826 */
2019 1827
2020 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL && tmp->above != NULL; tmp = tmp->above) 1828 for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
2021 { 1829 {
2022 /* Trim the search when we find the first other spell effect 1830 /* Trim the search when we find the first other spell effect
2023 * this helps performance so that if a space has 50 spell objects, 1831 * this helps performance so that if a space has 50 spell objects,
2024 * we don't need to check all of them. 1832 * we don't need to check all of them.
2025 */ 1833 */
… …
2042 { 1850 {
2043 if ((!op->move_type && tmp->move_slow & MOVE_WALK) || 1851 if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
2044 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0)) 1852 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
2045 { 1853 {
2046 1854
1855 float
2047 float diff = tmp->move_slow_penalty * FABS (op->speed); 1856 diff = tmp->move_slow_penalty * fabs (op->speed);
2048 1857
2049 if (op->type == PLAYER) 1858 if (op->type == PLAYER)
2050 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) || 1859 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) ||
2051 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN))) 1860 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN)))
2052 diff /= 4.0; 1861 diff /= 4.0;
… …
2059 if ((!op->move_type && tmp->move_on & MOVE_WALK) || 1868 if ((!op->move_type && tmp->move_on & MOVE_WALK) ||
2060 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0)) 1869 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0))
2061 { 1870 {
2062 move_apply (tmp, op, originator); 1871 move_apply (tmp, op, originator);
2063 1872
2064 if (was_destroyed (op, tag)) 1873 if (op->destroyed ())
2065 return 1; 1874 return 1;
2066 1875
2067 /* what the person/creature stepped onto has moved the object 1876 /* what the person/creature stepped onto has moved the object
2068 * someplace new. Don't process any further - if we did, 1877 * someplace new. Don't process any further - if we did,
2069 * have a feeling strange problems would result. 1878 * have a feeling strange problems would result.
… …
2079/* 1888/*
2080 * present_arch(arch, map, x, y) searches for any objects with 1889 * present_arch(arch, map, x, y) searches for any objects with
2081 * a matching archetype at the given map and coordinates. 1890 * a matching archetype at the given map and coordinates.
2082 * The first matching object is returned, or NULL if none. 1891 * The first matching object is returned, or NULL if none.
2083 */ 1892 */
2084
2085object * 1893object *
2086present_arch (const archetype *at, mapstruct *m, int x, int y) 1894present_arch (const archetype *at, maptile *m, int x, int y)
2087{ 1895{
2088 object *
2089 tmp;
2090
2091 if (m == NULL || out_of_map (m, x, y)) 1896 if (!m || out_of_map (m, x, y))
2092 { 1897 {
2093 LOG (llevError, "Present_arch called outside map.\n"); 1898 LOG (llevError, "Present_arch called outside map.\n");
2094 return NULL; 1899 return NULL;
2095 } 1900 }
2096 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1901
1902 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
2097 if (tmp->arch == at) 1903 if (tmp->arch == at)
2098 return tmp; 1904 return tmp;
1905
2099 return NULL; 1906 return NULL;
2100} 1907}
2101 1908
2102/* 1909/*
2103 * present(type, map, x, y) searches for any objects with 1910 * present(type, map, x, y) searches for any objects with
2104 * a matching type variable at the given map and coordinates. 1911 * a matching type variable at the given map and coordinates.
2105 * The first matching object is returned, or NULL if none. 1912 * The first matching object is returned, or NULL if none.
2106 */ 1913 */
2107
2108object * 1914object *
2109present (unsigned char type, mapstruct *m, int x, int y) 1915present (unsigned char type, maptile *m, int x, int y)
2110{ 1916{
2111 object *
2112 tmp;
2113
2114 if (out_of_map (m, x, y)) 1917 if (out_of_map (m, x, y))
2115 { 1918 {
2116 LOG (llevError, "Present called outside map.\n"); 1919 LOG (llevError, "Present called outside map.\n");
2117 return NULL; 1920 return NULL;
2118 } 1921 }
2119 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1922
1923 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
2120 if (tmp->type == type) 1924 if (tmp->type == type)
2121 return tmp; 1925 return tmp;
1926
2122 return NULL; 1927 return NULL;
2123} 1928}
2124 1929
2125/* 1930/*
2126 * present_in_ob(type, object) searches for any objects with 1931 * present_in_ob(type, object) searches for any objects with
2127 * a matching type variable in the inventory of the given object. 1932 * a matching type variable in the inventory of the given object.
2128 * The first matching object is returned, or NULL if none. 1933 * The first matching object is returned, or NULL if none.
2129 */ 1934 */
2130
2131object * 1935object *
2132present_in_ob (unsigned char type, const object *op) 1936present_in_ob (unsigned char type, const object *op)
2133{ 1937{
2134 object *
2135 tmp;
2136
2137 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1938 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2138 if (tmp->type == type) 1939 if (tmp->type == type)
2139 return tmp; 1940 return tmp;
1941
2140 return NULL; 1942 return NULL;
2141} 1943}
2142 1944
2143/* 1945/*
2144 * present_in_ob (type, str, object) searches for any objects with 1946 * present_in_ob (type, str, object) searches for any objects with
… …
2152 * str is the string to match against. Note that we match against 1954 * str is the string to match against. Note that we match against
2153 * the object name, not the archetype name. this is so that the 1955 * the object name, not the archetype name. this is so that the
2154 * spell code can use one object type (force), but change it's name 1956 * spell code can use one object type (force), but change it's name
2155 * to be unique. 1957 * to be unique.
2156 */ 1958 */
2157
2158object * 1959object *
2159present_in_ob_by_name (int type, const char *str, const object *op) 1960present_in_ob_by_name (int type, const char *str, const object *op)
2160{ 1961{
2161 object *
2162 tmp;
2163
2164 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1962 for (object *tmp = op->inv; tmp; tmp = tmp->below)
2165 {
2166 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name))) 1963 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name)))
2167 return tmp; 1964 return tmp;
2168 } 1965
2169 return NULL; 1966 return 0;
2170} 1967}
2171 1968
2172/* 1969/*
2173 * present_arch_in_ob(archetype, object) searches for any objects with 1970 * present_arch_in_ob(archetype, object) searches for any objects with
2174 * a matching archetype in the inventory of the given object. 1971 * a matching archetype in the inventory of the given object.
2175 * The first matching object is returned, or NULL if none. 1972 * The first matching object is returned, or NULL if none.
2176 */ 1973 */
2177
2178object * 1974object *
2179present_arch_in_ob (const archetype *at, const object *op) 1975present_arch_in_ob (const archetype *at, const object *op)
2180{ 1976{
2181 object *
2182 tmp;
2183
2184 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1977 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2185 if (tmp->arch == at) 1978 if (tmp->arch == at)
2186 return tmp; 1979 return tmp;
1980
2187 return NULL; 1981 return NULL;
2188} 1982}
2189 1983
2190/* 1984/*
2191 * activate recursively a flag on an object inventory 1985 * activate recursively a flag on an object inventory
2192 */ 1986 */
2193void 1987void
2194flag_inv (object *op, int flag) 1988flag_inv (object *op, int flag)
2195{ 1989{
2196 object *
2197 tmp;
2198
2199 if (op->inv) 1990 if (op->inv)
2200 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1991 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2201 { 1992 {
2202 SET_FLAG (tmp, flag); 1993 SET_FLAG (tmp, flag);
2203 flag_inv (tmp, flag); 1994 flag_inv (tmp, flag);
2204 } 1995 }
2205} /* 1996}
1997
1998/*
2206 * desactivate recursively a flag on an object inventory 1999 * deactivate recursively a flag on an object inventory
2207 */ 2000 */
2208void 2001void
2209unflag_inv (object *op, int flag) 2002unflag_inv (object *op, int flag)
2210{ 2003{
2211 object *
2212 tmp;
2213
2214 if (op->inv) 2004 if (op->inv)
2215 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 2005 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2216 { 2006 {
2217 CLEAR_FLAG (tmp, flag); 2007 CLEAR_FLAG (tmp, flag);
2218 unflag_inv (tmp, flag); 2008 unflag_inv (tmp, flag);
2219 } 2009 }
2220}
2221
2222/*
2223 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in
2224 * all it's inventory (recursively).
2225 * If checksums are used, a player will get set_cheat called for
2226 * him/her-self and all object carried by a call to this function.
2227 */
2228
2229void
2230set_cheat (object *op)
2231{
2232 SET_FLAG (op, FLAG_WAS_WIZ);
2233 flag_inv (op, FLAG_WAS_WIZ);
2234} 2010}
2235 2011
2236/* 2012/*
2237 * find_free_spot(object, map, x, y, start, stop) will search for 2013 * find_free_spot(object, map, x, y, start, stop) will search for
2238 * a spot at the given map and coordinates which will be able to contain 2014 * a spot at the given map and coordinates which will be able to contain
… …
2252 * because arch_blocked (now ob_blocked) needs to know the movement type 2028 * because arch_blocked (now ob_blocked) needs to know the movement type
2253 * to know if the space in question will block the object. We can't use 2029 * to know if the space in question will block the object. We can't use
2254 * the archetype because that isn't correct if the monster has been 2030 * the archetype because that isn't correct if the monster has been
2255 * customized, changed states, etc. 2031 * customized, changed states, etc.
2256 */ 2032 */
2257
2258int 2033int
2259find_free_spot (const object *ob, mapstruct *m, int x, int y, int start, int stop) 2034find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)
2260{ 2035{
2261 int
2262 i,
2263 index = 0, flag; 2036 int index = 0, flag;
2264 static int
2265 altern[SIZEOFFREE]; 2037 int altern[SIZEOFFREE];
2266 2038
2267 for (i = start; i < stop; i++) 2039 for (int i = start; i < stop; i++)
2268 { 2040 {
2269 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]); 2041 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]);
2270 if (!flag) 2042 if (!flag)
2271 altern[index++] = i; 2043 altern [index++] = i;
2272 2044
2273 /* Basically, if we find a wall on a space, we cut down the search size. 2045 /* Basically, if we find a wall on a space, we cut down the search size.
2274 * In this way, we won't return spaces that are on another side of a wall. 2046 * In this way, we won't return spaces that are on another side of a wall.
2275 * This mostly work, but it cuts down the search size in all directions - 2047 * This mostly work, but it cuts down the search size in all directions -
2276 * if the space being examined only has a wall to the north and empty 2048 * if the space being examined only has a wall to the north and empty
2277 * spaces in all the other directions, this will reduce the search space 2049 * spaces in all the other directions, this will reduce the search space
2278 * to only the spaces immediately surrounding the target area, and 2050 * to only the spaces immediately surrounding the target area, and
2279 * won't look 2 spaces south of the target space. 2051 * won't look 2 spaces south of the target space.
2280 */ 2052 */
2281 else if ((flag & AB_NO_PASS) && maxfree[i] < stop) 2053 else if ((flag & P_NO_PASS) && maxfree[i] < stop)
2282 stop = maxfree[i]; 2054 stop = maxfree[i];
2283 } 2055 }
2056
2284 if (!index) 2057 if (!index)
2285 return -1; 2058 return -1;
2059
2286 return altern[RANDOM () % index]; 2060 return altern [rndm (index)];
2287} 2061}
2288 2062
2289/* 2063/*
2290 * find_first_free_spot(archetype, mapstruct, x, y) works like 2064 * find_first_free_spot(archetype, maptile, x, y) works like
2291 * find_free_spot(), but it will search max number of squares. 2065 * find_free_spot(), but it will search max number of squares.
2292 * But it will return the first available spot, not a random choice. 2066 * But it will return the first available spot, not a random choice.
2293 * Changed 0.93.2: Have it return -1 if there is no free spot available. 2067 * Changed 0.93.2: Have it return -1 if there is no free spot available.
2294 */ 2068 */
2295
2296int 2069int
2297find_first_free_spot (const object *ob, mapstruct *m, int x, int y) 2070find_first_free_spot (const object *ob, maptile *m, int x, int y)
2298{ 2071{
2299 int
2300 i;
2301
2302 for (i = 0; i < SIZEOFFREE; i++) 2072 for (int i = 0; i < SIZEOFFREE; i++)
2303 {
2304 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i])) 2073 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]))
2305 return i; 2074 return i;
2306 } 2075
2307 return -1; 2076 return -1;
2308} 2077}
2309 2078
2310/* 2079/*
2311 * The function permute(arr, begin, end) randomly reorders the array 2080 * The function permute(arr, begin, end) randomly reorders the array
2312 * arr[begin..end-1]. 2081 * arr[begin..end-1].
2082 * now uses a fisher-yates shuffle, old permute was broken
2313 */ 2083 */
2314static void 2084static void
2315permute (int *arr, int begin, int end) 2085permute (int *arr, int begin, int end)
2316{ 2086{
2317 int 2087 arr += begin;
2318 i,
2319 j,
2320 tmp,
2321 len;
2322
2323 len = end - begin; 2088 end -= begin;
2324 for (i = begin; i < end; i++)
2325 {
2326 j = begin + RANDOM () % len;
2327 2089
2328 tmp = arr[i]; 2090 while (--end)
2329 arr[i] = arr[j]; 2091 swap (arr [end], arr [rndm (end + 1)]);
2330 arr[j] = tmp;
2331 }
2332} 2092}
2333 2093
2334/* new function to make monster searching more efficient, and effective! 2094/* new function to make monster searching more efficient, and effective!
2335 * This basically returns a randomized array (in the passed pointer) of 2095 * This basically returns a randomized array (in the passed pointer) of
2336 * the spaces to find monsters. In this way, it won't always look for 2096 * the spaces to find monsters. In this way, it won't always look for
… …
2339 * the 3x3 area will be searched, just not in a predictable order. 2099 * the 3x3 area will be searched, just not in a predictable order.
2340 */ 2100 */
2341void 2101void
2342get_search_arr (int *search_arr) 2102get_search_arr (int *search_arr)
2343{ 2103{
2344 int 2104 int i;
2345 i;
2346 2105
2347 for (i = 0; i < SIZEOFFREE; i++) 2106 for (i = 0; i < SIZEOFFREE; i++)
2348 {
2349 search_arr[i] = i; 2107 search_arr[i] = i;
2350 }
2351 2108
2352 permute (search_arr, 1, SIZEOFFREE1 + 1); 2109 permute (search_arr, 1, SIZEOFFREE1 + 1);
2353 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1); 2110 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1);
2354 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE); 2111 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE);
2355} 2112}
… …
2364 * Perhaps incorrectly, but I'm making the assumption that exclude 2121 * Perhaps incorrectly, but I'm making the assumption that exclude
2365 * is actually want is going to try and move there. We need this info 2122 * is actually want is going to try and move there. We need this info
2366 * because we have to know what movement the thing looking to move 2123 * because we have to know what movement the thing looking to move
2367 * there is capable of. 2124 * there is capable of.
2368 */ 2125 */
2369
2370int 2126int
2371find_dir (mapstruct *m, int x, int y, object *exclude) 2127find_dir (maptile *m, int x, int y, object *exclude)
2372{ 2128{
2373 int
2374 i,
2375 max = SIZEOFFREE, mflags; 2129 int i, max = SIZEOFFREE, mflags;
2376 sint16 2130
2377 nx, 2131 sint16 nx, ny;
2378 ny;
2379 object * 2132 object *tmp;
2380 tmp; 2133 maptile *mp;
2381 mapstruct * 2134
2382 mp; 2135 MoveType blocked, move_type;
2383 MoveType
2384 blocked,
2385 move_type;
2386 2136
2387 if (exclude && exclude->head) 2137 if (exclude && exclude->head)
2388 { 2138 {
2389 exclude = exclude->head; 2139 exclude = exclude->head;
2390 move_type = exclude->move_type; 2140 move_type = exclude->move_type;
… …
2400 mp = m; 2150 mp = m;
2401 nx = x + freearr_x[i]; 2151 nx = x + freearr_x[i];
2402 ny = y + freearr_y[i]; 2152 ny = y + freearr_y[i];
2403 2153
2404 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2154 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);
2155
2405 if (mflags & P_OUT_OF_MAP) 2156 if (mflags & P_OUT_OF_MAP)
2406 {
2407 max = maxfree[i]; 2157 max = maxfree[i];
2408 }
2409 else 2158 else
2410 { 2159 {
2411 blocked = GET_MAP_MOVE_BLOCK (mp, nx, ny); 2160 mapspace &ms = mp->at (nx, ny);
2161
2162 blocked = ms.move_block;
2412 2163
2413 if ((move_type & blocked) == move_type) 2164 if ((move_type & blocked) == move_type)
2414 {
2415 max = maxfree[i]; 2165 max = maxfree[i];
2416 }
2417 else if (mflags & P_IS_ALIVE) 2166 else if (mflags & P_IS_ALIVE)
2418 { 2167 {
2419 for (tmp = GET_MAP_OB (mp, nx, ny); tmp != NULL; tmp = tmp->above) 2168 for (tmp = ms.bot; tmp; tmp = tmp->above)
2420 { 2169 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)
2421 if ((QUERY_FLAG (tmp, FLAG_MONSTER) || tmp->type == PLAYER) && (tmp != exclude || (tmp->head && tmp->head != exclude))) 2170 && (tmp != exclude || (tmp->head && tmp->head != exclude)))
2422 {
2423 break; 2171 break;
2424 } 2172
2425 }
2426 if (tmp) 2173 if (tmp)
2427 {
2428 return freedir[i]; 2174 return freedir[i];
2429 }
2430 } 2175 }
2431 } 2176 }
2432 } 2177 }
2178
2433 return 0; 2179 return 0;
2434} 2180}
2435 2181
2436/* 2182/*
2437 * distance(object 1, object 2) will return the square of the 2183 * distance(object 1, object 2) will return the square of the
2438 * distance between the two given objects. 2184 * distance between the two given objects.
2439 */ 2185 */
2440
2441int 2186int
2442distance (const object *ob1, const object *ob2) 2187distance (const object *ob1, const object *ob2)
2443{ 2188{
2444 int
2445 i;
2446
2447 i = (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y); 2189 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2448 return i;
2449} 2190}
2450 2191
2451/* 2192/*
2452 * find_dir_2(delta-x,delta-y) will return a direction in which 2193 * find_dir_2(delta-x,delta-y) will return a direction in which
2453 * an object which has subtracted the x and y coordinates of another 2194 * an object which has subtracted the x and y coordinates of another
2454 * object, needs to travel toward it. 2195 * object, needs to travel toward it.
2455 */ 2196 */
2456
2457int 2197int
2458find_dir_2 (int x, int y) 2198find_dir_2 (int x, int y)
2459{ 2199{
2460 int 2200 int q;
2461 q;
2462 2201
2463 if (y) 2202 if (y)
2464 q = x * 100 / y; 2203 q = x * 100 / y;
2465 else if (x) 2204 else if (x)
2466 q = -300 * x; 2205 q = -300 * x;
… …
2491 2230
2492 return 3; 2231 return 3;
2493} 2232}
2494 2233
2495/* 2234/*
2496 * absdir(int): Returns a number between 1 and 8, which represent
2497 * the "absolute" direction of a number (it actually takes care of
2498 * "overflow" in previous calculations of a direction).
2499 */
2500
2501int
2502absdir (int d)
2503{
2504 while (d < 1)
2505 d += 8;
2506 while (d > 8)
2507 d -= 8;
2508 return d;
2509}
2510
2511/*
2512 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is 2235 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is
2513 * between two directions (which are expected to be absolute (see absdir()) 2236 * between two directions (which are expected to be absolute (see absdir())
2514 */ 2237 */
2515
2516int 2238int
2517dirdiff (int dir1, int dir2) 2239dirdiff (int dir1, int dir2)
2518{ 2240{
2519 int 2241 int d;
2520 d;
2521 2242
2522 d = abs (dir1 - dir2); 2243 d = abs (dir1 - dir2);
2523 if (d > 4) 2244 if (d > 4)
2524 d = 8 - d; 2245 d = 8 - d;
2246
2525 return d; 2247 return d;
2526} 2248}
2527 2249
2528/* peterm: 2250/* peterm:
2529 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster. 2251 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster.
… …
2532 * This basically means that if direction is 15, then it could either go 2254 * This basically means that if direction is 15, then it could either go
2533 * direction 4, 14, or 16 to get back to where we are. 2255 * direction 4, 14, or 16 to get back to where we are.
2534 * Moved from spell_util.c to object.c with the other related direction 2256 * Moved from spell_util.c to object.c with the other related direction
2535 * functions. 2257 * functions.
2536 */ 2258 */
2537
2538int
2539 reduction_dir[SIZEOFFREE][3] = { 2259int reduction_dir[SIZEOFFREE][3] = {
2540 {0, 0, 0}, /* 0 */ 2260 {0, 0, 0}, /* 0 */
2541 {0, 0, 0}, /* 1 */ 2261 {0, 0, 0}, /* 1 */
2542 {0, 0, 0}, /* 2 */ 2262 {0, 0, 0}, /* 2 */
2543 {0, 0, 0}, /* 3 */ 2263 {0, 0, 0}, /* 3 */
2544 {0, 0, 0}, /* 4 */ 2264 {0, 0, 0}, /* 4 */
… …
2592 * find a path to that monster that we found. If not, 2312 * find a path to that monster that we found. If not,
2593 * we don't bother going toward it. Returns 1 if we 2313 * we don't bother going toward it. Returns 1 if we
2594 * can see a direct way to get it 2314 * can see a direct way to get it
2595 * Modified to be map tile aware -.MSW 2315 * Modified to be map tile aware -.MSW
2596 */ 2316 */
2597
2598
2599int 2317int
2600can_see_monsterP (mapstruct *m, int x, int y, int dir) 2318can_see_monsterP (maptile *m, int x, int y, int dir)
2601{ 2319{
2602 sint16 2320 sint16 dx, dy;
2603 dx,
2604 dy;
2605 int
2606 mflags; 2321 int mflags;
2607 2322
2608 if (dir < 0) 2323 if (dir < 0)
2609 return 0; /* exit condition: invalid direction */ 2324 return 0; /* exit condition: invalid direction */
2610 2325
2611 dx = x + freearr_x[dir]; 2326 dx = x + freearr_x[dir];
… …
2624 return 0; 2339 return 0;
2625 2340
2626 /* yes, can see. */ 2341 /* yes, can see. */
2627 if (dir < 9) 2342 if (dir < 9)
2628 return 1; 2343 return 1;
2344
2629 return can_see_monsterP (m, x, y, reduction_dir[dir][0]) | 2345 return can_see_monsterP (m, x, y, reduction_dir[dir][0])
2630 can_see_monsterP (m, x, y, reduction_dir[dir][1]) | can_see_monsterP (m, x, y, reduction_dir[dir][2]); 2346 | can_see_monsterP (m, x, y, reduction_dir[dir][1])
2347 | can_see_monsterP (m, x, y, reduction_dir[dir][2]);
2631} 2348}
2632
2633
2634 2349
2635/* 2350/*
2636 * can_pick(picker, item): finds out if an object is possible to be 2351 * can_pick(picker, item): finds out if an object is possible to be
2637 * picked up by the picker. Returnes 1 if it can be 2352 * picked up by the picker. Returnes 1 if it can be
2638 * picked up, otherwise 0. 2353 * picked up, otherwise 0.
… …
2649 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2364 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2650 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2365 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2651 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2366 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));
2652} 2367}
2653 2368
2654
2655/* 2369/*
2656 * create clone from object to another 2370 * create clone from object to another
2657 */ 2371 */
2658object * 2372object *
2659object_create_clone (object *asrc) 2373object_create_clone (object *asrc)
2660{ 2374{
2661 object *
2662 dst = NULL, *tmp, *src, *part, *prev, *item; 2375 object *dst = 0, *tmp, *src, *part, *prev, *item;
2663 2376
2664 if (!asrc) 2377 if (!asrc)
2665 return NULL; 2378 return 0;
2379
2666 src = asrc; 2380 src = asrc;
2667 if (src->head) 2381 if (src->head)
2668 src = src->head; 2382 src = src->head;
2669 2383
2670 prev = NULL; 2384 prev = 0;
2671 for (part = src; part; part = part->more) 2385 for (part = src; part; part = part->more)
2672 { 2386 {
2673 tmp = get_object (); 2387 tmp = part->clone ();
2674 copy_object (part, tmp);
2675 tmp->x -= src->x; 2388 tmp->x -= src->x;
2676 tmp->y -= src->y; 2389 tmp->y -= src->y;
2390
2677 if (!part->head) 2391 if (!part->head)
2678 { 2392 {
2679 dst = tmp; 2393 dst = tmp;
2680 tmp->head = NULL; 2394 tmp->head = 0;
2681 } 2395 }
2682 else 2396 else
2683 {
2684 tmp->head = dst; 2397 tmp->head = dst;
2685 } 2398
2686 tmp->more = NULL; 2399 tmp->more = 0;
2400
2687 if (prev) 2401 if (prev)
2688 prev->more = tmp; 2402 prev->more = tmp;
2403
2689 prev = tmp; 2404 prev = tmp;
2690 } 2405 }
2691 2406
2692 /*** copy inventory ***/
2693 for (item = src->inv; item; item = item->below) 2407 for (item = src->inv; item; item = item->below)
2694 {
2695 (void) insert_ob_in_ob (object_create_clone (item), dst); 2408 insert_ob_in_ob (object_create_clone (item), dst);
2696 }
2697 2409
2698 return dst; 2410 return dst;
2699}
2700
2701/* return true if the object was destroyed, 0 otherwise */
2702int
2703was_destroyed (const object *op, tag_t old_tag)
2704{
2705 /* checking for FLAG_FREED isn't necessary, but makes this function more
2706 * robust */
2707 return op->count != old_tag || QUERY_FLAG (op, FLAG_FREED);
2708}
2709
2710/* GROS - Creates an object using a string representing its content. */
2711
2712/* Basically, we save the content of the string to a temp file, then call */
2713
2714/* load_object on it. I admit it is a highly inefficient way to make things, */
2715
2716/* but it was simple to make and allows reusing the load_object function. */
2717
2718/* Remember not to use load_object_str in a time-critical situation. */
2719
2720/* Also remember that multiparts objects are not supported for now. */
2721
2722object *
2723load_object_str (const char *obstr)
2724{
2725 object *
2726 op;
2727 char
2728 filename[MAX_BUF];
2729
2730 sprintf (filename, "%s/cfloadobstr2044", settings.tmpdir);
2731
2732 FILE *
2733 tempfile = fopen (filename, "w");
2734
2735 if (tempfile == NULL)
2736 {
2737 LOG (llevError, "Error - Unable to access load object temp file\n");
2738 return NULL;
2739 };
2740 fprintf (tempfile, obstr);
2741 fclose (tempfile);
2742
2743 op = get_object ();
2744
2745 object_thawer
2746 thawer (filename);
2747
2748 if (thawer)
2749 load_object (thawer, op, 0);
2750
2751 LOG (llevDebug, " load str completed, object=%s\n", &op->name);
2752 CLEAR_FLAG (op, FLAG_REMOVED);
2753
2754 return op;
2755} 2411}
2756 2412
2757/* This returns the first object in who's inventory that 2413/* This returns the first object in who's inventory that
2758 * has the same type and subtype match. 2414 * has the same type and subtype match.
2759 * returns NULL if no match. 2415 * returns NULL if no match.
2760 */ 2416 */
2761object * 2417object *
2762find_obj_by_type_subtype (const object *who, int type, int subtype) 2418find_obj_by_type_subtype (const object *who, int type, int subtype)
2763{ 2419{
2764 object *
2765 tmp;
2766
2767 for (tmp = who->inv; tmp; tmp = tmp->below) 2420 for (object *tmp = who->inv; tmp; tmp = tmp->below)
2768 if (tmp->type == type && tmp->subtype == subtype) 2421 if (tmp->type == type && tmp->subtype == subtype)
2769 return tmp; 2422 return tmp;
2770 2423
2771 return NULL; 2424 return 0;
2772} 2425}
2773 2426
2774/* If ob has a field named key, return the link from the list, 2427/* If ob has a field named key, return the link from the list,
2775 * otherwise return NULL. 2428 * otherwise return NULL.
2776 * 2429 *
… …
2778 * do the desired thing. 2431 * do the desired thing.
2779 */ 2432 */
2780key_value * 2433key_value *
2781get_ob_key_link (const object *ob, const char *key) 2434get_ob_key_link (const object *ob, const char *key)
2782{ 2435{
2783 key_value *
2784 link;
2785
2786 for (link = ob->key_values; link != NULL; link = link->next) 2436 for (key_value *link = ob->key_values; link; link = link->next)
2787 {
2788 if (link->key == key) 2437 if (link->key == key)
2789 {
2790 return link; 2438 return link;
2791 }
2792 }
2793 2439
2794 return NULL; 2440 return 0;
2795} 2441}
2796 2442
2797/* 2443/*
2798 * Returns the value of op has an extra_field for key, or NULL. 2444 * Returns the value of op has an extra_field for key, or NULL.
2799 * 2445 *
… …
2802 * The returned string is shared. 2448 * The returned string is shared.
2803 */ 2449 */
2804const char * 2450const char *
2805get_ob_key_value (const object *op, const char *const key) 2451get_ob_key_value (const object *op, const char *const key)
2806{ 2452{
2807 key_value * 2453 key_value *link;
2808 link; 2454 shstr_cmp canonical_key (key);
2809 const char *
2810 canonical_key;
2811 2455
2812 canonical_key = shstr::find (key);
2813
2814 if (canonical_key == NULL) 2456 if (!canonical_key)
2815 { 2457 {
2816 /* 1. There being a field named key on any object 2458 /* 1. There being a field named key on any object
2817 * implies there'd be a shared string to find. 2459 * implies there'd be a shared string to find.
2818 * 2. Since there isn't, no object has this field. 2460 * 2. Since there isn't, no object has this field.
2819 * 3. Therefore, *this* object doesn't have this field. 2461 * 3. Therefore, *this* object doesn't have this field.
2820 */ 2462 */
2821 return NULL; 2463 return 0;
2822 } 2464 }
2823 2465
2824 /* This is copied from get_ob_key_link() above - 2466 /* This is copied from get_ob_key_link() above -
2825 * only 4 lines, and saves the function call overhead. 2467 * only 4 lines, and saves the function call overhead.
2826 */ 2468 */
2827 for (link = op->key_values; link != NULL; link = link->next) 2469 for (link = op->key_values; link; link = link->next)
2828 {
2829 if (link->key == canonical_key) 2470 if (link->key == canonical_key)
2830 {
2831 return link->value; 2471 return link->value;
2832 } 2472
2833 }
2834 return NULL; 2473 return 0;
2835} 2474}
2836
2837 2475
2838/* 2476/*
2839 * Updates the canonical_key in op to value. 2477 * Updates the canonical_key in op to value.
2840 * 2478 *
2841 * canonical_key is a shared string (value doesn't have to be). 2479 * canonical_key is a shared string (value doesn't have to be).
… …
2846 * Returns TRUE on success. 2484 * Returns TRUE on success.
2847 */ 2485 */
2848int 2486int
2849set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key) 2487set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2850{ 2488{
2851 key_value *
2852 field = NULL, *last = NULL; 2489 key_value *field = NULL, *last = NULL;
2853 2490
2854 for (field = op->key_values; field != NULL; field = field->next) 2491 for (field = op->key_values; field != NULL; field = field->next)
2855 { 2492 {
2856 if (field->key != canonical_key) 2493 if (field->key != canonical_key)
2857 { 2494 {
… …
2875 if (last) 2512 if (last)
2876 last->next = field->next; 2513 last->next = field->next;
2877 else 2514 else
2878 op->key_values = field->next; 2515 op->key_values = field->next;
2879 2516
2880 delete
2881 field; 2517 delete field;
2882 } 2518 }
2883 } 2519 }
2884 return TRUE; 2520 return TRUE;
2885 } 2521 }
2886 /* IF we get here, key doesn't exist */ 2522 /* IF we get here, key doesn't exist */
2887 2523
2888 /* No field, we'll have to add it. */ 2524 /* No field, we'll have to add it. */
2889 2525
2890 if (!add_key) 2526 if (!add_key)
2891 {
2892 return FALSE; 2527 return FALSE;
2893 } 2528
2894 /* There isn't any good reason to store a null 2529 /* There isn't any good reason to store a null
2895 * value in the key/value list. If the archetype has 2530 * value in the key/value list. If the archetype has
2896 * this key, then we should also have it, so shouldn't 2531 * this key, then we should also have it, so shouldn't
2897 * be here. If user wants to store empty strings, 2532 * be here. If user wants to store empty strings,
2898 * should pass in "" 2533 * should pass in ""
… …
2921 * Returns TRUE on success. 2556 * Returns TRUE on success.
2922 */ 2557 */
2923int 2558int
2924set_ob_key_value (object *op, const char *key, const char *value, int add_key) 2559set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2925{ 2560{
2926 shstr
2927 key_ (key); 2561 shstr key_ (key);
2928 2562
2929 return set_ob_key_value_s (op, key_, value, add_key); 2563 return set_ob_key_value_s (op, key_, value, add_key);
2930} 2564}
2565
2566object::depth_iterator::depth_iterator (object *container)
2567: iterator_base (container)
2568{
2569 while (item->inv)
2570 item = item->inv;
2571}
2572
2573void
2574object::depth_iterator::next ()
2575{
2576 if (item->below)
2577 {
2578 item = item->below;
2579
2580 while (item->inv)
2581 item = item->inv;
2582 }
2583 else
2584 item = item->env;
2585}
2586
2587
2588const char *
2589object::flag_desc (char *desc, int len) const
2590{
2591 char *p = desc;
2592 bool first = true;
2593
2594 *p = 0;
2595
2596 for (int i = 0; i < NUM_FLAGS; i++)
2597 {
2598 if (len <= 10) // magic constant!
2599 {
2600 snprintf (p, len, ",...");
2601 break;
2602 }
2603
2604 if (flag [i])
2605 {
2606 int cnt = snprintf (p, len, "%s%d", first ? "" : ",", i);
2607 len -= cnt;
2608 p += cnt;
2609 first = false;
2610 }
2611 }
2612
2613 return desc;
2614}
2615
2616// return a suitable string describing an object in enough detail to find it
2617const char *
2618object::debug_desc (char *info) const
2619{
2620 char flagdesc[512];
2621 char info2[256 * 4];
2622 char *p = info;
2623
2624 p += snprintf (p, 512, "{cnt:%d,uuid:<1.%" PRIx64 ">,name:\"%s\"%s%s,flags:[%s],type:%d}",
2625 count, uuid.seq,
2626 &name,
2627 title ? "\",title:\"" : "",
2628 title ? (const char *)title : "",
2629 flag_desc (flagdesc, 512), type);
2630
2631 if (env)
2632 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2633
2634 if (map)
2635 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2636
2637 return info;
2638}
2639
2640const char *
2641object::debug_desc () const
2642{
2643 static char info[3][256 * 4];
2644 static int info_idx;
2645
2646 return debug_desc (info [++info_idx % 3]);
2647}
2648
2649struct region *
2650object::region () const
2651{
2652 return map ? map->region (x, y)
2653 : region::default_region ();
2654}
2655
2656const materialtype_t *
2657object::dominant_material () const
2658{
2659 if (materialtype_t *mat = name_to_material (materialname))
2660 return mat;
2661
2662 // omfg this is slow, this has to be temporary :)
2663 shstr unknown ("unknown");
2664
2665 return name_to_material (unknown);
2666}
2667
2668void
2669object::open_container (object *new_container)
2670{
2671 if (container == new_container)
2672 return;
2673
2674 if (object *old_container = container)
2675 {
2676 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))
2677 return;
2678
2679#if 0
2680 // remove the "Close old_container" object.
2681 if (object *closer = old_container->inv)
2682 if (closer->type == CLOSE_CON)
2683 closer->destroy ();
2684#endif
2685
2686 old_container->flag [FLAG_APPLIED] = 0;
2687 container = 0;
2688
2689 esrv_update_item (UPD_FLAGS, this, old_container);
2690 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container));
2691 }
2692
2693 if (new_container)
2694 {
2695 if (INVOKE_OBJECT (OPEN, new_container, ARG_OBJECT (this)))
2696 return;
2697
2698 // TODO: this does not seem to serve any purpose anymore?
2699#if 0
2700 // insert the "Close Container" object.
2701 if (archetype *closer = new_container->other_arch)
2702 {
2703 object *closer = arch_to_object (new_container->other_arch);
2704 closer->flag [FLAG_NO_MAP_SAVE] = 1;
2705 new_container->insert (closer);
2706 }
2707#endif
2708
2709 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container));
2710
2711 new_container->flag [FLAG_APPLIED] = 1;
2712 container = new_container;
2713
2714 esrv_update_item (UPD_FLAGS, this, new_container);
2715 esrv_send_inventory (this, new_container);
2716 }
2717}
2718
2719

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines