ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.39 by root, Wed Sep 13 02:05:19 2006 UTC vs.
Revision 1.152 by root, Thu May 17 14:14:54 2007 UTC

1
2/* 1/*
3 CrossFire, A Multiplayer game for X-windows 2 * CrossFire, A Multiplayer game
4 3 *
4 * Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team
5 Copyright (C) 2001 Mark Wedel & Crossfire Development Team 5 * Copyright (C) 2001 Mark Wedel & Crossfire Development Team
6 Copyright (C) 1992 Frank Tore Johansen 6 * Copyright (C) 1992 Frank Tore Johansen
7 7 *
8 This program is free software; you can redistribute it and/or modify 8 * This program is free software; you can redistribute it and/or modify
9 it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
10 the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation; either version 2 of the License, or
11 (at your option) any later version. 11 * (at your option) any later version.
12 12 *
13 This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 GNU General Public License for more details. 16 * GNU General Public License for more details.
17 17 *
18 You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
19 along with this program; if not, write to the Free Software 19 * along with this program; if not, write to the Free Software
20 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. 20 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
21 21 *
22 The authors can be reached via e-mail at crossfire-devel@real-time.com 22 * The authors can be reached via e-mail at <crossfire@schmorp.de>
23*/ 23 */
24 24
25/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects. 25/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
26 sub/add_weight will transcend the environment updating the carrying 26 sub/add_weight will transcend the environment updating the carrying
27 variable. */ 27 variable. */
28#include <global.h> 28#include <global.h>
29#include <stdio.h> 29#include <stdio.h>
30#include <sys/types.h> 30#include <sys/types.h>
31#include <sys/uio.h> 31#include <sys/uio.h>
32#include <object.h> 32#include <object.h>
33#include <funcpoint.h> 33#include <funcpoint.h>
34#include <sproto.h>
34#include <loader.h> 35#include <loader.h>
36
37#include <bitset>
35 38
36int nrofallocobjects = 0; 39int nrofallocobjects = 0;
37static UUID uuid; 40static UUID uuid;
38const uint64 UUID_SKIP = 1<<19; 41const uint64 UUID_SKIP = 1<<19;
39 42
40object *objects; /* Pointer to the list of used objects */ 43objectvec objects;
41object *active_objects; /* List of active objects that need to be processed */ 44activevec actives;
42 45
43short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 46short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
44 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1 47 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1
45}; 48};
46short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, 49short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
106 _exit (1); 109 _exit (1);
107 } 110 }
108 111
109 uuid.seq = uid; 112 uuid.seq = uid;
110 write_uuid (); 113 write_uuid ();
111 LOG (llevDebug, "read UID: %lld\n", uid); 114 LOG (llevDebug, "read UID: %" PRId64 "\n", uid);
112 fclose (fp); 115 fclose (fp);
113} 116}
114 117
115UUID 118UUID
116gen_uuid () 119gen_uuid ()
141 * objects with lists are rare, and lists stay short. If not, use a 144 * objects with lists are rare, and lists stay short. If not, use a
142 * different structure or at least keep the lists sorted... 145 * different structure or at least keep the lists sorted...
143 */ 146 */
144 147
145 /* For each field in wants, */ 148 /* For each field in wants, */
146 for (wants_field = wants->key_values; wants_field != NULL; wants_field = wants_field->next) 149 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)
147 { 150 {
148 key_value *has_field; 151 key_value *has_field;
149 152
150 /* Look for a field in has with the same key. */ 153 /* Look for a field in has with the same key. */
151 has_field = get_ob_key_link (has, wants_field->key); 154 has_field = get_ob_key_link (has, wants_field->key);
185 * 188 *
186 * Note that this function appears a lot longer than the macro it 189 * Note that this function appears a lot longer than the macro it
187 * replaces - this is mostly for clarity - a decent compiler should hopefully 190 * replaces - this is mostly for clarity - a decent compiler should hopefully
188 * reduce this to the same efficiency. 191 * reduce this to the same efficiency.
189 * 192 *
190 * Check nrof variable *before* calling CAN_MERGE() 193 * Check nrof variable *before* calling can_merge()
191 * 194 *
192 * Improvements made with merge: Better checking on potion, and also 195 * Improvements made with merge: Better checking on potion, and also
193 * check weight 196 * check weight
194 */ 197 */
195
196bool object::can_merge (object *ob1, object *ob2) 198bool object::can_merge_slow (object *ob1, object *ob2)
197{ 199{
198 /* A couple quicksanity checks */ 200 /* A couple quicksanity checks */
199 if ((ob1 == ob2) || (ob1->type != ob2->type)) 201 if (ob1 == ob2
202 || ob1->type != ob2->type
203 || ob1->speed != ob2->speed
204 || ob1->value != ob2->value
205 || ob1->name != ob2->name)
200 return 0; 206 return 0;
201 207
202 if (ob1->speed != ob2->speed) 208 //TODO: this ain't working well, use nicer and correct overflow check
203 return 0;
204
205 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that 209 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that
206 * value could not be stored in a sint32 (which unfortunately sometimes is 210 * value could not be stored in a sint32 (which unfortunately sometimes is
207 * used to store nrof). 211 * used to store nrof).
208 */ 212 */
209 if (ob1->nrof + ob2->nrof >= 1UL << 31) 213 if (ob1->nrof + ob2->nrof >= 1UL << 31)
219 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 223 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
220 224
221 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 225 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
222 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 226 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
223 227
224 228 if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any ()
225 /* the 0x400000 on flags2 is FLAG_INV_LOCK. I don't think something 229 || ob1->arch != ob2->arch
226 * being locked in inventory should prevent merging.
227 * 0x4 in flags3 is CLIENT_SENT
228 */
229 if ((ob1->arch != ob2->arch) ||
230 (ob1->flags[0] != ob2->flags[0]) ||
231 (ob1->flags[1] != ob2->flags[1]) ||
232 ((ob1->flags[2] & ~0x400000) != (ob2->flags[2] & ~0x400000)) ||
233 ((ob1->flags[3] & ~0x4) != (ob2->flags[3] & ~0x4)) ||
234 (ob1->name != ob2->name) || 230 || ob1->name != ob2->name
235 (ob1->title != ob2->title) || 231 || ob1->title != ob2->title
236 (ob1->msg != ob2->msg) || 232 || ob1->msg != ob2->msg
237 (ob1->weight != ob2->weight) || 233 || ob1->weight != ob2->weight
238 (memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist)) != 0) || 234 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
239 (memcmp (&ob1->stats, &ob2->stats, sizeof (ob1->stats)) != 0) || 235 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
240 (ob1->attacktype != ob2->attacktype) || 236 || ob1->attacktype != ob2->attacktype
241 (ob1->magic != ob2->magic) || 237 || ob1->magic != ob2->magic
242 (ob1->slaying != ob2->slaying) || 238 || ob1->slaying != ob2->slaying
243 (ob1->skill != ob2->skill) || 239 || ob1->skill != ob2->skill
244 (ob1->value != ob2->value) || 240 || ob1->value != ob2->value
245 (ob1->animation_id != ob2->animation_id) || 241 || ob1->animation_id != ob2->animation_id
246 (ob1->client_type != ob2->client_type) || 242 || ob1->client_type != ob2->client_type
247 (ob1->materialname != ob2->materialname) || 243 || ob1->materialname != ob2->materialname
248 (ob1->lore != ob2->lore) || 244 || ob1->lore != ob2->lore
249 (ob1->subtype != ob2->subtype) || 245 || ob1->subtype != ob2->subtype
250 (ob1->move_type != ob2->move_type) || 246 || ob1->move_type != ob2->move_type
251 (ob1->move_block != ob2->move_block) || 247 || ob1->move_block != ob2->move_block
252 (ob1->move_allow != ob2->move_allow) || 248 || ob1->move_allow != ob2->move_allow
253 (ob1->move_on != ob2->move_on) || 249 || ob1->move_on != ob2->move_on
254 (ob1->move_off != ob2->move_off) || (ob1->move_slow != ob2->move_slow) || (ob1->move_slow_penalty != ob2->move_slow_penalty)) 250 || ob1->move_off != ob2->move_off
251 || ob1->move_slow != ob2->move_slow
252 || ob1->move_slow_penalty != ob2->move_slow_penalty)
255 return 0; 253 return 0;
256 254
257 /* This is really a spellbook check - really, we should 255 /* This is really a spellbook check - really, we should
258 * check all objects in the inventory. 256 * check all objects in the inventory.
259 */ 257 */
262 /* if one object has inventory but the other doesn't, not equiv */ 260 /* if one object has inventory but the other doesn't, not equiv */
263 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv)) 261 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv))
264 return 0; 262 return 0;
265 263
266 /* Now check to see if the two inventory objects could merge */ 264 /* Now check to see if the two inventory objects could merge */
267 if (!CAN_MERGE (ob1->inv, ob2->inv)) 265 if (!object::can_merge (ob1->inv, ob2->inv))
268 return 0; 266 return 0;
269 267
270 /* inventory ok - still need to check rest of this object to see 268 /* inventory ok - still need to check rest of this object to see
271 * if it is valid. 269 * if it is valid.
272 */ 270 */
281 279
282 /* Note sure why the following is the case - either the object has to 280 /* Note sure why the following is the case - either the object has to
283 * be animated or have a very low speed. Is this an attempted monster 281 * be animated or have a very low speed. Is this an attempted monster
284 * check? 282 * check?
285 */ 283 */
286 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && FABS ((ob1)->speed) > MIN_ACTIVE_SPEED) 284 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && ob1->has_active_speed ())
287 return 0; 285 return 0;
288 286
289 switch (ob1->type) 287 switch (ob1->type)
290 { 288 {
291 case SCROLL: 289 case SCROLL:
327sum_weight (object *op) 325sum_weight (object *op)
328{ 326{
329 long sum; 327 long sum;
330 object *inv; 328 object *inv;
331 329
332 for (sum = 0, inv = op->inv; inv != NULL; inv = inv->below) 330 for (sum = 0, inv = op->inv; inv; inv = inv->below)
333 { 331 {
334 if (inv->inv) 332 if (inv->inv)
335 sum_weight (inv); 333 sum_weight (inv);
334
336 sum += inv->carrying + inv->weight * (inv->nrof ? inv->nrof : 1); 335 sum += inv->carrying + inv->weight * (inv->nrof ? inv->nrof : 1);
337 } 336 }
338 337
339 if (op->type == CONTAINER && op->stats.Str) 338 if (op->type == CONTAINER && op->stats.Str)
340 sum = (sum * (100 - op->stats.Str)) / 100; 339 sum = (sum * (100 - op->stats.Str)) / 100;
356 op = op->env; 355 op = op->env;
357 return op; 356 return op;
358} 357}
359 358
360/* 359/*
361 * Eneq(@csd.uu.se): Since we can have items buried in a character we need
362 * a better check. We basically keeping traversing up until we can't
363 * or find a player.
364 */
365
366object *
367is_player_inv (object *op)
368{
369 for (; op != NULL && op->type != PLAYER; op = op->env)
370 if (op->env == op)
371 op->env = NULL;
372 return op;
373}
374
375/*
376 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump. 360 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
377 * Some error messages. 361 * Some error messages.
378 * The result of the dump is stored in the static global errmsg array. 362 * The result of the dump is stored in the static global errmsg array.
379 */ 363 */
380 364char *
381void
382dump_object2 (object *op)
383{
384 errmsg[0] = 0;
385 return;
386 //TODO//D#d#
387#if 0
388 char *cp;
389
390/* object *tmp;*/
391
392 if (op->arch != NULL)
393 {
394 strcat (errmsg, "arch ");
395 strcat (errmsg, op->arch->name ? op->arch->name : "(null)");
396 strcat (errmsg, "\n");
397 if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
398 strcat (errmsg, cp);
399# if 0
400 /* Don't dump player diffs - they are too long, mostly meaningless, and
401 * will overflow the buffer.
402 * Changed so that we don't dump inventory either. This may
403 * also overflow the buffer.
404 */
405 if (op->type != PLAYER && (cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
406 strcat (errmsg, cp);
407 for (tmp = op->inv; tmp; tmp = tmp->below)
408 dump_object2 (tmp);
409# endif
410 strcat (errmsg, "end\n");
411 }
412 else
413 {
414 strcat (errmsg, "Object ");
415 if (op->name == NULL)
416 strcat (errmsg, "(null)");
417 else
418 strcat (errmsg, op->name);
419 strcat (errmsg, "\n");
420# if 0
421 if ((cp = get_ob_diff (op, &empty_archetype->clone)) != NULL)
422 strcat (errmsg, cp);
423 for (tmp = op->inv; tmp; tmp = tmp->below)
424 dump_object2 (tmp);
425# endif
426 strcat (errmsg, "end\n");
427 }
428#endif
429}
430
431/*
432 * Dumps an object. Returns output in the static global errmsg array.
433 */
434
435void
436dump_object (object *op) 365dump_object (object *op)
437{ 366{
438 if (op == NULL) 367 if (!op)
439 { 368 return strdup ("[NULLOBJ]");
440 strcpy (errmsg, "[NULL pointer]");
441 return;
442 }
443 errmsg[0] = '\0';
444 dump_object2 (op);
445}
446 369
447void 370 object_freezer freezer;
448dump_all_objects (void) 371 op->write (freezer);
449{ 372 return freezer.as_string ();
450 object *op;
451
452 for (op = objects; op != NULL; op = op->next)
453 {
454 dump_object (op);
455 fprintf (logfile, "Object %d\n:%s\n", op->count, errmsg);
456 }
457} 373}
458 374
459/* 375/*
460 * get_nearest_part(multi-object, object 2) returns the part of the 376 * get_nearest_part(multi-object, object 2) returns the part of the
461 * multi-object 1 which is closest to the second object. 377 * multi-object 1 which is closest to the second object.
477} 393}
478 394
479/* 395/*
480 * Returns the object which has the count-variable equal to the argument. 396 * Returns the object which has the count-variable equal to the argument.
481 */ 397 */
482
483object * 398object *
484find_object (tag_t i) 399find_object (tag_t i)
485{ 400{
486 object *op; 401 for_all_objects (op)
487
488 for (op = objects; op != NULL; op = op->next)
489 if (op->count == i) 402 if (op->count == i)
490 break;
491 return op; 403 return op;
404
405 return 0;
492} 406}
493 407
494/* 408/*
495 * Returns the first object which has a name equal to the argument. 409 * Returns the first object which has a name equal to the argument.
496 * Used only by the patch command, but not all that useful. 410 * Used only by the patch command, but not all that useful.
497 * Enables features like "patch <name-of-other-player> food 999" 411 * Enables features like "patch <name-of-other-player> food 999"
498 */ 412 */
499
500object * 413object *
501find_object_name (const char *str) 414find_object_name (const char *str)
502{ 415{
503 shstr_cmp str_ (str); 416 shstr_cmp str_ (str);
504 object *op; 417 object *op;
505 418
506 for (op = objects; op != NULL; op = op->next) 419 for_all_objects (op)
507 if (op->name == str_) 420 if (op->name == str_)
508 break; 421 break;
509 422
510 return op; 423 return op;
511} 424}
512 425
513void 426void
514free_all_object_data () 427free_all_object_data ()
515{ 428{
516 LOG (llevDebug, "%d allocated objects\n", nrofallocobjects); 429 LOG (llevDebug, "%d allocated objects\n", nrofallocobjects);
517}
518
519/*
520 * Returns the object which this object marks as being the owner.
521 * A id-scheme is used to avoid pointing to objects which have been
522 * freed and are now reused. If this is detected, the owner is
523 * set to NULL, and NULL is returned.
524 * Changed 2004-02-12 - if the player is setting at the play again
525 * prompt, he is removed, and we don't want to treat him as an owner of
526 * anything, so check removed flag. I don't expect that this should break
527 * anything - once an object is removed, it is basically dead anyways.
528 */
529object *
530object::get_owner ()
531{
532 if (!owner
533 || QUERY_FLAG (owner, FLAG_FREED)
534 || QUERY_FLAG (owner, FLAG_REMOVED))
535 owner = 0;
536
537 return owner;
538} 430}
539 431
540/* 432/*
541 * Sets the owner and sets the skill and exp pointers to owner's current 433 * Sets the owner and sets the skill and exp pointers to owner's current
542 * skill and experience objects. 434 * skill and experience objects.
558 owner = owner->owner; 450 owner = owner->owner;
559 451
560 this->owner = owner; 452 this->owner = owner;
561} 453}
562 454
455int
456object::slottype () const
457{
458 if (type == SKILL)
459 {
460 if (IS_COMBAT_SKILL (subtype)) return slot_combat;
461 if (IS_RANGED_SKILL (subtype)) return slot_ranged;
462 }
463 else
464 {
465 if (slot [body_combat].info) return slot_combat;
466 if (slot [body_range ].info) return slot_ranged;
467 }
468
469 return slot_none;
470}
471
472bool
473object::change_weapon (object *ob)
474{
475 if (current_weapon == ob)
476 return true;
477
478 if (chosen_skill)
479 chosen_skill->flag [FLAG_APPLIED] = false;
480
481 current_weapon = ob;
482 chosen_skill = !ob || ob->type == SKILL ? ob : find_skill_by_name (this, ob->skill);
483
484 if (chosen_skill)
485 chosen_skill->flag [FLAG_APPLIED] = true;
486
487 update_stats ();
488
489 if (ob)
490 {
491 // now check wether any body locations became invalid, in which case
492 // we cannot apply the weapon at the moment.
493 for (int i = 0; i < NUM_BODY_LOCATIONS; ++i)
494 if (slot[i].used < 0)
495 {
496 current_weapon = chosen_skill = 0;
497 update_stats ();
498
499 new_draw_info_format (NDI_UNIQUE, 0, this,
500 "You try to balance your applied items all at once, but the %s is too much. "
501 "You need to unapply some items first.", &ob->name);
502 return false;
503 }
504
505 //new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name);
506 }
507 else
508 ;//new_draw_info_format (NDI_UNIQUE, 0, this, "You unwield your weapons.");
509
510 if (ob && !ob->flag [FLAG_APPLIED] && ob->type != SPELL)
511 {
512 LOG (llevError | logBacktrace, "%s changed to unapplied weapon %s",
513 &name, ob->debug_desc ());
514 return false;
515 }
516
517 return true;
518}
519
563/* Zero the key_values on op, decrementing the shared-string 520/* Zero the key_values on op, decrementing the shared-string
564 * refcounts and freeing the links. 521 * refcounts and freeing the links.
565 */ 522 */
566static void 523static void
567free_key_values (object *op) 524free_key_values (object *op)
568{ 525{
569 for (key_value *i = op->key_values; i != 0;) 526 for (key_value *i = op->key_values; i; )
570 { 527 {
571 key_value *next = i->next; 528 key_value *next = i->next;
572 delete i; 529 delete i;
573 530
574 i = next; 531 i = next;
575 } 532 }
576 533
577 op->key_values = 0; 534 op->key_values = 0;
578} 535}
579 536
580void object::clear () 537object &
538object::operator =(const object &src)
581{ 539{
582 attachable_base::clear (); 540 bool is_freed = flag [FLAG_FREED];
541 bool is_removed = flag [FLAG_REMOVED];
583 542
584 free_key_values (this); 543 *(object_copy *)this = src;
585 544
586 owner = 0; 545 flag [FLAG_FREED] = is_freed;
587 name = 0; 546 flag [FLAG_REMOVED] = is_removed;
588 name_pl = 0;
589 title = 0;
590 race = 0;
591 slaying = 0;
592 skill = 0;
593 msg = 0;
594 lore = 0;
595 custom_name = 0;
596 materialname = 0;
597 contr = 0;
598 below = 0;
599 above = 0;
600 inv = 0;
601 container = 0;
602 env = 0;
603 more = 0;
604 head = 0;
605 map = 0;
606 active_next = 0;
607 active_prev = 0;
608
609 memset (static_cast<object_pod *>(this), 0, sizeof (object_pod));
610
611 SET_FLAG (this, FLAG_REMOVED);
612
613 /* What is not cleared is next, prev, and count */
614
615 expmul = 1.0;
616 face = blank_face;
617 attacked_by_count = -1;
618
619 if (settings.casting_time)
620 casting_time = -1;
621}
622
623void object::clone (object *destination)
624{
625 *(object_copy *)destination = *this;
626 *(object_pod *)destination = *this;
627
628 if (self || cb)
629 INVOKE_OBJECT (CLONE, this, ARG_OBJECT (destination));
630}
631
632/*
633 * copy object first frees everything allocated by the second object,
634 * and then copies the contends of the first object into the second
635 * object, allocating what needs to be allocated. Basically, any
636 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
637 * if the first object is freed, the pointers in the new object
638 * will point at garbage.
639 */
640void
641copy_object (object *op2, object *op)
642{
643 bool is_freed = QUERY_FLAG (op, FLAG_FREED);
644 bool is_removed = QUERY_FLAG (op, FLAG_REMOVED);
645
646 op2->clone (op);
647
648 if (is_freed)
649 SET_FLAG (op, FLAG_FREED);
650 if (is_removed)
651 SET_FLAG (op, FLAG_REMOVED);
652
653 if (op2->speed < 0)
654 op->speed_left = op2->speed_left - RANDOM () % 200 / 100.0;
655 547
656 /* Copy over key_values, if any. */ 548 /* Copy over key_values, if any. */
657 if (op2->key_values) 549 if (src.key_values)
658 { 550 {
659 key_value *tail = 0; 551 key_value *tail = 0;
660 key_value *i;
661
662 op->key_values = 0; 552 key_values = 0;
663 553
664 for (i = op2->key_values; i; i = i->next) 554 for (key_value *i = src.key_values; i; i = i->next)
665 { 555 {
666 key_value *new_link = new key_value; 556 key_value *new_link = new key_value;
667 557
668 new_link->next = 0; 558 new_link->next = 0;
669 new_link->key = i->key; 559 new_link->key = i->key;
670 new_link->value = i->value; 560 new_link->value = i->value;
671 561
672 /* Try and be clever here, too. */ 562 /* Try and be clever here, too. */
673 if (!op->key_values) 563 if (!key_values)
674 { 564 {
675 op->key_values = new_link; 565 key_values = new_link;
676 tail = new_link; 566 tail = new_link;
677 } 567 }
678 else 568 else
679 { 569 {
680 tail->next = new_link; 570 tail->next = new_link;
681 tail = new_link; 571 tail = new_link;
682 } 572 }
683 } 573 }
684 } 574 }
575}
685 576
686 update_ob_speed (op); 577/*
578 * copy_to first frees everything allocated by the dst object,
579 * and then copies the contents of itself into the second
580 * object, allocating what needs to be allocated. Basically, any
581 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
582 * if the first object is freed, the pointers in the new object
583 * will point at garbage.
584 */
585void
586object::copy_to (object *dst)
587{
588 *dst = *this;
589
590 if (speed < 0)
591 dst->speed_left = speed_left - rndm ();
592
593 dst->set_speed (dst->speed);
594}
595
596void
597object::instantiate ()
598{
599 if (!uuid.seq) // HACK
600 uuid = gen_uuid ();
601
602 speed_left = -0.1f;
603 /* copy the body_info to the body_used - this is only really
604 * need for monsters, but doesn't hurt to do it for everything.
605 * by doing so, when a monster is created, it has good starting
606 * values for the body_used info, so when items are created
607 * for it, they can be properly equipped.
608 */
609 for (int i = NUM_BODY_LOCATIONS; i--; )
610 slot[i].used = slot[i].info;
611
612 attachable::instantiate ();
613}
614
615object *
616object::clone ()
617{
618 object *neu = create ();
619 copy_to (neu);
620 return neu;
687} 621}
688 622
689/* 623/*
690 * If an object with the IS_TURNABLE() flag needs to be turned due 624 * If an object with the IS_TURNABLE() flag needs to be turned due
691 * to the closest player being on the other side, this function can 625 * to the closest player being on the other side, this function can
692 * be called to update the face variable, _and_ how it looks on the map. 626 * be called to update the face variable, _and_ how it looks on the map.
693 */ 627 */
694
695void 628void
696update_turn_face (object *op) 629update_turn_face (object *op)
697{ 630{
698 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || op->arch == NULL) 631 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || !op->arch)
699 return; 632 return;
633
700 SET_ANIMATION (op, op->direction); 634 SET_ANIMATION (op, op->direction);
701 update_object (op, UP_OBJ_FACE); 635 update_object (op, UP_OBJ_FACE);
702} 636}
703 637
704/* 638/*
705 * Updates the speed of an object. If the speed changes from 0 to another 639 * Updates the speed of an object. If the speed changes from 0 to another
706 * value, or vice versa, then add/remove the object from the active list. 640 * value, or vice versa, then add/remove the object from the active list.
707 * This function needs to be called whenever the speed of an object changes. 641 * This function needs to be called whenever the speed of an object changes.
708 */ 642 */
709void 643void
710update_ob_speed (object *op) 644object::set_speed (float speed)
711{ 645{
712 extern int arch_init; 646 if (flag [FLAG_FREED] && speed)
713
714 /* No reason putting the archetypes objects on the speed list,
715 * since they never really need to be updated.
716 */
717
718 if (QUERY_FLAG (op, FLAG_FREED) && op->speed)
719 { 647 {
720 LOG (llevError, "Object %s is freed but has speed.\n", &op->name); 648 LOG (llevError, "Object %s is freed but has speed.\n", &name);
721#ifdef MANY_CORES
722 abort ();
723#else
724 op->speed = 0; 649 speed = 0;
725#endif
726 }
727
728 if (arch_init)
729 return;
730
731 if (FABS (op->speed) > MIN_ACTIVE_SPEED)
732 { 650 }
733 /* If already on active list, don't do anything */
734 if (op->active_next || op->active_prev || op == active_objects)
735 return;
736 651
737 /* process_events() expects us to insert the object at the beginning 652 this->speed = speed;
738 * of the list. */
739 op->active_next = active_objects;
740 653
741 if (op->active_next != NULL) 654 if (has_active_speed ())
742 op->active_next->active_prev = op; 655 activate ();
743
744 active_objects = op;
745 }
746 else 656 else
747 { 657 deactivate ();
748 /* If not on the active list, nothing needs to be done */
749 if (!op->active_next && !op->active_prev && op != active_objects)
750 return;
751
752 if (op->active_prev == NULL)
753 {
754 active_objects = op->active_next;
755
756 if (op->active_next != NULL)
757 op->active_next->active_prev = NULL;
758 }
759 else
760 {
761 op->active_prev->active_next = op->active_next;
762
763 if (op->active_next)
764 op->active_next->active_prev = op->active_prev;
765 }
766
767 op->active_next = NULL;
768 op->active_prev = NULL;
769 }
770} 658}
771 659
772/* This function removes object 'op' from the list of active
773 * objects.
774 * This should only be used for style maps or other such
775 * reference maps where you don't want an object that isn't
776 * in play chewing up cpu time getting processed.
777 * The reverse of this is to call update_ob_speed, which
778 * will do the right thing based on the speed of the object.
779 */
780void
781remove_from_active_list (object *op)
782{
783 /* If not on the active list, nothing needs to be done */
784 if (!op->active_next && !op->active_prev && op != active_objects)
785 return;
786
787 if (op->active_prev == NULL)
788 {
789 active_objects = op->active_next;
790 if (op->active_next != NULL)
791 op->active_next->active_prev = NULL;
792 }
793 else
794 {
795 op->active_prev->active_next = op->active_next;
796 if (op->active_next)
797 op->active_next->active_prev = op->active_prev;
798 }
799 op->active_next = NULL;
800 op->active_prev = NULL;
801}
802
803/* 660/*
804 * update_object() updates the array which represents the map. 661 * update_object() updates the the map.
805 * It takes into account invisible objects (and represent squares covered 662 * It takes into account invisible objects (and represent squares covered
806 * by invisible objects by whatever is below them (unless it's another 663 * by invisible objects by whatever is below them (unless it's another
807 * invisible object, etc...) 664 * invisible object, etc...)
808 * If the object being updated is beneath a player, the look-window 665 * If the object being updated is beneath a player, the look-window
809 * of that player is updated (this might be a suboptimal way of 666 * of that player is updated (this might be a suboptimal way of
810 * updating that window, though, since update_object() is called _often_) 667 * updating that window, though, since update_object() is called _often_)
811 * 668 *
812 * action is a hint of what the caller believes need to be done. 669 * action is a hint of what the caller believes need to be done.
813 * For example, if the only thing that has changed is the face (due to
814 * an animation), we don't need to call update_position until that actually
815 * comes into view of a player. OTOH, many other things, like addition/removal
816 * of walls or living creatures may need us to update the flags now.
817 * current action are: 670 * current action are:
818 * UP_OBJ_INSERT: op was inserted 671 * UP_OBJ_INSERT: op was inserted
819 * UP_OBJ_REMOVE: op was removed 672 * UP_OBJ_REMOVE: op was removed
820 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update 673 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update
821 * as that is easier than trying to look at what may have changed. 674 * as that is easier than trying to look at what may have changed.
822 * UP_OBJ_FACE: only the objects face has changed. 675 * UP_OBJ_FACE: only the objects face has changed.
823 */ 676 */
824
825void 677void
826update_object (object *op, int action) 678update_object (object *op, int action)
827{ 679{
828 int update_now = 0, flags;
829 MoveType move_on, move_off, move_block, move_slow;
830
831 if (op == NULL) 680 if (op == NULL)
832 { 681 {
833 /* this should never happen */ 682 /* this should never happen */
834 LOG (llevDebug, "update_object() called for NULL object.\n"); 683 LOG (llevDebug, "update_object() called for NULL object.\n");
835 return; 684 return;
836 } 685 }
837 686
838 if (op->env != NULL) 687 if (op->env)
839 { 688 {
840 /* Animation is currently handled by client, so nothing 689 /* Animation is currently handled by client, so nothing
841 * to do in this case. 690 * to do in this case.
842 */ 691 */
843 return; 692 return;
848 */ 697 */
849 if (!op->map || op->map->in_memory == MAP_SAVING) 698 if (!op->map || op->map->in_memory == MAP_SAVING)
850 return; 699 return;
851 700
852 /* make sure the object is within map boundaries */ 701 /* make sure the object is within map boundaries */
853 if (op->x < 0 || op->x >= MAP_WIDTH (op->map) || op->y < 0 || op->y >= MAP_HEIGHT (op->map)) 702 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
854 { 703 {
855 LOG (llevError, "update_object() called for object out of map!\n"); 704 LOG (llevError, "update_object() called for object out of map!\n");
856#ifdef MANY_CORES 705#ifdef MANY_CORES
857 abort (); 706 abort ();
858#endif 707#endif
859 return; 708 return;
860 } 709 }
861 710
862 flags = GET_MAP_FLAGS (op->map, op->x, op->y); 711 mapspace &m = op->ms ();
863 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NEED_UPDATE);
864 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
865 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
866 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
867 move_off = GET_MAP_MOVE_OFF (op->map, op->x, op->y);
868 712
713 if (!(m.flags_ & P_UPTODATE))
714 /* nop */;
869 if (action == UP_OBJ_INSERT) 715 else if (action == UP_OBJ_INSERT)
870 { 716 {
717 // this is likely overkill, TODO: revisit (schmorp)
871 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(flags & P_BLOCKSVIEW)) 718 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
872 update_now = 1;
873
874 if (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(flags & P_NO_MAGIC)) 719 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
875 update_now = 1; 720 || (op->type == PLAYER && !(m.flags_ & P_PLAYER))
876 721 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
722 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
877 if (QUERY_FLAG (op, FLAG_DAMNED) && !(flags & P_NO_CLERIC)) 723 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
878 update_now = 1;
879
880 if (QUERY_FLAG (op, FLAG_ALIVE) && !(flags & P_IS_ALIVE))
881 update_now = 1;
882
883 if (op->type == SAFE_GROUND && !(flags & P_SAFE))
884 update_now = 1;
885
886 if ((move_on | op->move_on) != move_on) 724 || (m.move_on | op->move_on ) != m.move_on
887 update_now = 1;
888
889 if ((move_off | op->move_off) != move_off) 725 || (m.move_off | op->move_off ) != m.move_off
890 update_now = 1; 726 || (m.move_slow | op->move_slow) != m.move_slow
891
892 /* This isn't perfect, but I don't expect a lot of objects to 727 /* This isn't perfect, but I don't expect a lot of objects to
893 * to have move_allow right now. 728 * to have move_allow right now.
894 */ 729 */
895 if (((move_block | op->move_block) & ~op->move_allow) != move_block) 730 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
896 update_now = 1; 731 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
897 732 m.flags_ = 0;
898 if ((move_slow | op->move_slow) != move_slow)
899 update_now = 1;
900 } 733 }
901 /* if the object is being removed, we can't make intelligent 734 /* if the object is being removed, we can't make intelligent
902 * decisions, because remove_ob can't really pass the object 735 * decisions, because remove_ob can't really pass the object
903 * that is being removed. 736 * that is being removed.
904 */ 737 */
905 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 738 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
906 update_now = 1; 739 m.flags_ = 0;
907 else if (action == UP_OBJ_FACE) 740 else if (action == UP_OBJ_FACE)
908 /* Nothing to do for that case */ ; 741 /* Nothing to do for that case */ ;
909 else 742 else
910 LOG (llevError, "update_object called with invalid action: %d\n", action); 743 LOG (llevError, "update_object called with invalid action: %d\n", action);
911 744
912 if (update_now)
913 {
914 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NO_ERROR | P_NEED_UPDATE);
915 update_position (op->map, op->x, op->y);
916 }
917
918 if (op->more != NULL) 745 if (op->more)
919 update_object (op->more, action); 746 update_object (op->more, action);
920}
921
922static unordered_vector<object *> mortals;
923static std::vector<object *, slice_allocator <object *> > freed;
924
925void object::free_mortals ()
926{
927 for (unordered_vector<object *>::iterator i = mortals.begin (); i != mortals.end ();)
928 if ((*i)->refcnt)
929 ++i; // further delay freeing
930 else
931 {
932 freed.push_back (*i);//D
933 //delete *i;
934 mortals.erase (i);
935 }
936
937 if (mortals.size() && 0)//D
938 LOG (llevDebug, "%d objects in mortal queue\n", mortals.size());//D
939} 747}
940 748
941object::object () 749object::object ()
942{ 750{
943 SET_FLAG (this, FLAG_REMOVED); 751 SET_FLAG (this, FLAG_REMOVED);
944 752
945 expmul = 1.0; 753 expmul = 1.0;
946 face = blank_face; 754 face = blank_face;
947 attacked_by_count = -1;
948} 755}
949 756
950object::~object () 757object::~object ()
951{ 758{
759 unlink ();
760
952 free_key_values (this); 761 free_key_values (this);
953} 762}
954 763
764static int object_count;
765
955void object::link () 766void object::link ()
956{ 767{
768 assert (!index);//D
769 uuid = gen_uuid ();
957 count = ++ob_count; 770 count = ++object_count;
958 771
959 prev = 0; 772 refcnt_inc ();
960 next = objects; 773 objects.insert (this);
961
962 if (objects)
963 objects->prev = this;
964
965 objects = this;
966} 774}
967 775
968void object::unlink () 776void object::unlink ()
969{ 777{
970 count = 0;
971 uuid = gen_uuid ();
972
973 if (this == objects)
974 objects = next;
975
976 /* Remove this object from the list of used objects */
977 if (prev)
978 {
979 prev->next = next;
980 prev = 0;
981 }
982
983 if (next) 778 if (!index)
779 return;
780
781 objects.erase (this);
782 refcnt_dec ();
783}
784
785void
786object::activate ()
787{
788 /* If already on active list, don't do anything */
789 if (active)
790 return;
791
792 if (has_active_speed ())
793 actives.insert (this);
794}
795
796void
797object::activate_recursive ()
798{
799 activate ();
800
801 for (object *op = inv; op; op = op->below)
802 op->activate_recursive ();
803}
804
805/* This function removes object 'op' from the list of active
806 * objects.
807 * This should only be used for style maps or other such
808 * reference maps where you don't want an object that isn't
809 * in play chewing up cpu time getting processed.
810 * The reverse of this is to call update_ob_speed, which
811 * will do the right thing based on the speed of the object.
812 */
813void
814object::deactivate ()
815{
816 /* If not on the active list, nothing needs to be done */
817 if (!active)
818 return;
819
820 actives.erase (this);
821}
822
823void
824object::deactivate_recursive ()
825{
826 for (object *op = inv; op; op = op->below)
827 op->deactivate_recursive ();
828
829 deactivate ();
830}
831
832void
833object::set_flag_inv (int flag, int value)
834{
835 for (object *op = inv; op; op = op->below)
836 {
837 op->flag [flag] = value;
838 op->set_flag_inv (flag, value);
984 { 839 }
985 next->prev = prev; 840}
986 next = 0; 841
842/*
843 * Remove and free all objects in the inventory of the given object.
844 * object.c ?
845 */
846void
847object::destroy_inv (bool drop_to_ground)
848{
849 // need to check first, because the checks below might segfault
850 // as we might be on an invalid mapspace and crossfire code
851 // is too buggy to ensure that the inventory is empty.
852 // corollary: if you create arrows etc. with stuff in tis inventory,
853 // cf will crash below with off-map x and y
854 if (!inv)
855 return;
856
857 /* Only if the space blocks everything do we not process -
858 * if some form of movement is allowed, let objects
859 * drop on that space.
860 */
861 if (!drop_to_ground
862 || !map
863 || map->in_memory != MAP_IN_MEMORY
864 || map->nodrop
865 || ms ().move_block == MOVE_ALL)
866 {
867 while (inv)
868 {
869 inv->destroy_inv (drop_to_ground);
870 inv->destroy ();
871 }
872 }
873 else
874 { /* Put objects in inventory onto this space */
875 while (inv)
876 {
877 object *op = inv;
878
879 if (op->flag [FLAG_STARTEQUIP]
880 || op->flag [FLAG_NO_DROP]
881 || op->type == RUNE
882 || op->type == TRAP
883 || op->flag [FLAG_IS_A_TEMPLATE]
884 || op->flag [FLAG_DESTROY_ON_DEATH])
885 op->destroy ();
886 else
887 map->insert (op, x, y);
888 }
987 } 889 }
988} 890}
989 891
990object *object::create () 892object *object::create ()
991{ 893{
992 object *op;
993
994 if (freed.empty ())
995 op = new object; 894 object *op = new object;
996 else
997 {
998 // highly annoying, but the only way to get it stable right now
999 op = freed.back ();
1000 freed.pop_back ();
1001 op->~object ();
1002 new ((void *) op) object;
1003 }
1004
1005 op->link (); 895 op->link ();
1006 return op; 896 return op;
1007} 897}
1008 898
1009/* 899void
1010 * free_object() frees everything allocated by an object, removes 900object::do_destroy ()
1011 * it from the list of used objects, and puts it on the list of
1012 * free objects. The IS_FREED() flag is set in the object.
1013 * The object must have been removed by remove_ob() first for
1014 * this function to succeed.
1015 *
1016 * If free_inventory is set, free inventory as well. Else drop items in
1017 * inventory to the ground.
1018 */
1019void object::free (bool free_inventory)
1020{ 901{
1021 if (QUERY_FLAG (this, FLAG_FREED)) 902 attachable::do_destroy ();
903
904 if (flag [FLAG_IS_LINKED])
905 remove_button_link (this);
906
907 if (flag [FLAG_FRIENDLY])
908 remove_friendly_object (this);
909
910 if (!flag [FLAG_REMOVED])
911 remove ();
912
913 destroy_inv (true);
914
915 deactivate ();
916 unlink ();
917
918 flag [FLAG_FREED] = 1;
919
920 // hack to ensure that freed objects still have a valid map
921 {
922 static maptile *freed_map; // freed objects are moved here to avoid crashes
923
924 if (!freed_map)
925 {
926 freed_map = new maptile;
927
928 freed_map->name = "/internal/freed_objects_map";
929 freed_map->width = 3;
930 freed_map->height = 3;
931
932 freed_map->alloc ();
933 freed_map->in_memory = MAP_IN_MEMORY;
934 }
935
936 map = freed_map;
937 x = 1;
938 y = 1;
939 }
940
941 head = 0;
942
943 if (more)
944 {
945 more->destroy ();
946 more = 0;
947 }
948
949 // clear those pointers that likely might have circular references to us
950 owner = 0;
951 enemy = 0;
952 attacked_by = 0;
953}
954
955void
956object::destroy (bool destroy_inventory)
957{
958 if (destroyed ())
1022 return; 959 return;
1023 960
1024 if (QUERY_FLAG (this, FLAG_FRIENDLY)) 961 if (destroy_inventory)
1025 remove_friendly_object (this); 962 destroy_inv (false);
1026 963
1027 if (!QUERY_FLAG (this, FLAG_REMOVED)) 964 attachable::destroy ();
1028 remove_ob (this);
1029
1030 SET_FLAG (this, FLAG_FREED);
1031
1032 if (more)
1033 {
1034 more->free (free_inventory);
1035 more = 0;
1036 }
1037
1038 if (inv)
1039 {
1040 /* Only if the space blocks everything do we not process -
1041 * if some form of movement is allowed, let objects
1042 * drop on that space.
1043 */
1044 if (free_inventory || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL)
1045 {
1046 object *op = inv;
1047
1048 while (op)
1049 {
1050 object *tmp = op->below;
1051 op->free (free_inventory);
1052 op = tmp;
1053 }
1054 }
1055 else
1056 { /* Put objects in inventory onto this space */
1057 object *op = inv;
1058
1059 while (op)
1060 {
1061 object *tmp = op->below;
1062
1063 remove_ob (op);
1064
1065 if (QUERY_FLAG (op, FLAG_STARTEQUIP)
1066 || QUERY_FLAG (op, FLAG_NO_DROP) || op->type == RUNE || op->type == TRAP || QUERY_FLAG (op, FLAG_IS_A_TEMPLATE))
1067 free_object (op);
1068 else
1069 {
1070 op->x = x;
1071 op->y = y;
1072 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
1073 }
1074
1075 op = tmp;
1076 }
1077 }
1078 }
1079
1080 owner = 0;
1081
1082 /* Remove object from the active list */
1083 speed = 0;
1084 update_ob_speed (this);
1085
1086 unlink ();
1087
1088 mortals.push_back (this);
1089} 965}
1090 966
1091/* 967/*
1092 * sub_weight() recursively (outwards) subtracts a number from the 968 * sub_weight() recursively (outwards) subtracts a number from the
1093 * weight of an object (and what is carried by it's environment(s)). 969 * weight of an object (and what is carried by it's environment(s)).
1094 */ 970 */
1095
1096void 971void
1097sub_weight (object *op, signed long weight) 972sub_weight (object *op, signed long weight)
1098{ 973{
1099 while (op != NULL) 974 while (op != NULL)
1100 { 975 {
1101 if (op->type == CONTAINER) 976 if (op->type == CONTAINER)
1102 {
1103 weight = (signed long) (weight * (100 - op->stats.Str) / 100); 977 weight = (signed long) (weight * (100 - op->stats.Str) / 100);
1104 } 978
1105 op->carrying -= weight; 979 op->carrying -= weight;
1106 op = op->env; 980 op = op->env;
1107 } 981 }
1108} 982}
1109 983
1110/* remove_ob(op): 984/* op->remove ():
1111 * This function removes the object op from the linked list of objects 985 * This function removes the object op from the linked list of objects
1112 * which it is currently tied to. When this function is done, the 986 * which it is currently tied to. When this function is done, the
1113 * object will have no environment. If the object previously had an 987 * object will have no environment. If the object previously had an
1114 * environment, the x and y coordinates will be updated to 988 * environment, the x and y coordinates will be updated to
1115 * the previous environment. 989 * the previous environment.
1116 * Beware: This function is called from the editor as well!
1117 */ 990 */
1118
1119void 991void
1120remove_ob (object *op) 992object::do_remove ()
1121{ 993{
994 object *tmp, *last = 0;
1122 object * 995 object *otmp;
1123 tmp, *
1124 last = NULL;
1125 object *
1126 otmp;
1127 996
1128 tag_t
1129 tag;
1130 int
1131 check_walk_off;
1132 mapstruct *
1133 m;
1134
1135 sint16
1136 x,
1137 y;
1138
1139 if (QUERY_FLAG (op, FLAG_REMOVED)) 997 if (QUERY_FLAG (this, FLAG_REMOVED))
1140 return; 998 return;
1141 999
1142 SET_FLAG (op, FLAG_REMOVED); 1000 SET_FLAG (this, FLAG_REMOVED);
1001 INVOKE_OBJECT (REMOVE, this);
1143 1002
1144 if (op->more != NULL) 1003 if (more)
1145 remove_ob (op->more); 1004 more->remove ();
1146 1005
1147 /* 1006 /*
1148 * In this case, the object to be removed is in someones 1007 * In this case, the object to be removed is in someones
1149 * inventory. 1008 * inventory.
1150 */ 1009 */
1151 if (op->env != NULL) 1010 if (env)
1152 { 1011 {
1153 if (op->nrof) 1012 if (nrof)
1154 sub_weight (op->env, op->weight * op->nrof); 1013 sub_weight (env, weight * nrof);
1155 else 1014 else
1156 sub_weight (op->env, op->weight + op->carrying); 1015 sub_weight (env, weight + carrying);
1157 1016
1158 /* NO_FIX_PLAYER is set when a great many changes are being 1017 /* NO_FIX_PLAYER is set when a great many changes are being
1159 * made to players inventory. If set, avoiding the call 1018 * made to players inventory. If set, avoiding the call
1160 * to save cpu time. 1019 * to save cpu time.
1161 */ 1020 */
1162 if ((otmp = is_player_inv (op->env)) != NULL && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1021 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1163 fix_player (otmp); 1022 otmp->update_stats ();
1164 1023
1165 if (op->above != NULL) 1024 if (above)
1166 op->above->below = op->below; 1025 above->below = below;
1167 else 1026 else
1168 op->env->inv = op->below; 1027 env->inv = below;
1169 1028
1170 if (op->below != NULL) 1029 if (below)
1171 op->below->above = op->above; 1030 below->above = above;
1172 1031
1173 /* we set up values so that it could be inserted into 1032 /* we set up values so that it could be inserted into
1174 * the map, but we don't actually do that - it is up 1033 * the map, but we don't actually do that - it is up
1175 * to the caller to decide what we want to do. 1034 * to the caller to decide what we want to do.
1176 */ 1035 */
1177 op->x = op->env->x, op->y = op->env->y; 1036 x = env->x, y = env->y;
1178 op->map = op->env->map; 1037 map = env->map;
1179 op->above = NULL, op->below = NULL; 1038 above = 0, below = 0;
1180 op->env = NULL; 1039 env = 0;
1181 } 1040 }
1182 else if (op->map) 1041 else if (map)
1183 { 1042 {
1184 x = op->x; 1043 if (type == PLAYER)
1185 y = op->y;
1186 m = get_map_from_coord (op->map, &x, &y);
1187
1188 if (!m)
1189 { 1044 {
1190 LOG (llevError, "remove_ob called when object was on map but appears to not be within valid coordinates? %s (%d,%d)\n", 1045 // leaving a spot always closes any open container on the ground
1191 op->map->path, op->x, op->y); 1046 if (container && !container->env)
1192 /* in old days, we used to set x and y to 0 and continue. 1047 // this causes spurious floorbox updates, but it ensures
1193 * it seems if we get into this case, something is probablye 1048 // that the CLOSE event is being sent.
1194 * screwed up and should be fixed. 1049 close_container ();
1195 */ 1050
1196 abort (); 1051 --map->players;
1052 map->touch ();
1197 } 1053 }
1198 1054
1199 if (op->map != m) 1055 map->dirty = true;
1200 LOG (llevDebug, "remove_ob: Object not really on map it claimed to be on? %s != %s, %d,%d != %d,%d\n", 1056 mapspace &ms = this->ms ();
1201 op->map->path, m->path, op->x, op->y, x, y);
1202
1203 /* Re did the following section of code - it looks like it had
1204 * lots of logic for things we no longer care about
1205 */
1206 1057
1207 /* link the object above us */ 1058 /* link the object above us */
1208 if (op->above) 1059 if (above)
1209 op->above->below = op->below; 1060 above->below = below;
1210 else 1061 else
1211 SET_MAP_TOP (m, x, y, op->below); /* we were top, set new top */ 1062 ms.top = below; /* we were top, set new top */
1212 1063
1213 /* Relink the object below us, if there is one */ 1064 /* Relink the object below us, if there is one */
1214 if (op->below) 1065 if (below)
1215 op->below->above = op->above; 1066 below->above = above;
1216 else 1067 else
1217 { 1068 {
1218 /* Nothing below, which means we need to relink map object for this space 1069 /* Nothing below, which means we need to relink map object for this space
1219 * use translated coordinates in case some oddness with map tiling is 1070 * use translated coordinates in case some oddness with map tiling is
1220 * evident 1071 * evident
1221 */ 1072 */
1222 if (GET_MAP_OB (m, x, y) != op) 1073 if (GET_MAP_OB (map, x, y) != this)
1223 {
1224 dump_object (op);
1225 LOG (llevError,
1226 "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom?\n%s\n", errmsg); 1074 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1227 dump_object (GET_MAP_OB (m, x, y));
1228 LOG (llevError, "%s\n", errmsg);
1229 }
1230 1075
1231 SET_MAP_OB (m, x, y, op->above); /* goes on above it. */ 1076 ms.bot = above; /* goes on above it. */
1232 } 1077 }
1233 1078
1234 op->above = 0; 1079 above = 0;
1235 op->below = 0; 1080 below = 0;
1236 1081
1237 if (op->map->in_memory == MAP_SAVING) 1082 if (map->in_memory == MAP_SAVING)
1238 return; 1083 return;
1239 1084
1240 tag = op->count; 1085 int check_walk_off = !flag [FLAG_NO_APPLY];
1241 check_walk_off = !QUERY_FLAG (op, FLAG_NO_APPLY);
1242 1086
1243 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1087 for (tmp = ms.bot; tmp; tmp = tmp->above)
1244 { 1088 {
1245 /* No point updating the players look faces if he is the object 1089 /* No point updating the players look faces if he is the object
1246 * being removed. 1090 * being removed.
1247 */ 1091 */
1248 1092
1249 if (tmp->type == PLAYER && tmp != op) 1093 if (tmp->type == PLAYER && tmp != this)
1250 { 1094 {
1251 /* If a container that the player is currently using somehow gets 1095 /* If a container that the player is currently using somehow gets
1252 * removed (most likely destroyed), update the player view 1096 * removed (most likely destroyed), update the player view
1253 * appropriately. 1097 * appropriately.
1254 */ 1098 */
1255 if (tmp->container == op) 1099 if (tmp->container == this)
1256 { 1100 {
1257 CLEAR_FLAG (op, FLAG_APPLIED); 1101 flag [FLAG_APPLIED] = 0;
1258 tmp->container = NULL; 1102 tmp->container = 0;
1259 } 1103 }
1260 1104
1261 tmp->contr->socket.update_look = 1; 1105 if (tmp->contr->ns)
1106 tmp->contr->ns->floorbox_update ();
1262 } 1107 }
1263 1108
1264 /* See if player moving off should effect something */ 1109 /* See if object moving off should effect something */
1265 if (check_walk_off && ((op->move_type & tmp->move_off) && (op->move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1110 if (check_walk_off
1111 && ((move_type & tmp->move_off)
1112 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0))
1266 { 1113 {
1267 move_apply (tmp, op, NULL); 1114 move_apply (tmp, this, 0);
1268 1115
1269 if (was_destroyed (op, tag)) 1116 if (destroyed ())
1270 {
1271 LOG (llevError, "BUG: remove_ob(): name %s, archname %s destroyed " "leaving object\n", &tmp->name, &tmp->arch->name); 1117 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1272 }
1273 } 1118 }
1274 1119
1275 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */ 1120 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */
1276 1121 //TODO: why is this horrible hacka fix? get rid of this code=bug! (schmorp)
1277 if (tmp->above == tmp) 1122 if (tmp->above == tmp)
1278 tmp->above = NULL; 1123 tmp->above = 0;
1279 1124
1280 last = tmp; 1125 last = tmp;
1281 } 1126 }
1282 1127
1283 /* last == NULL of there are no objects on this space */ 1128 /* last == NULL if there are no objects on this space */
1129 //TODO: this makes little sense, why only update the topmost object?
1284 if (last == NULL) 1130 if (!last)
1285 { 1131 map->at (x, y).flags_ = 0;
1286 /* set P_NEED_UPDATE, otherwise update_position will complain. In theory,
1287 * we could preserve the flags (GET_MAP_FLAGS), but update_position figures
1288 * those out anyways, and if there are any flags set right now, they won't
1289 * be correct anyways.
1290 */
1291 SET_MAP_FLAGS (op->map, op->x, op->y, P_NEED_UPDATE);
1292 update_position (op->map, op->x, op->y);
1293 }
1294 else 1132 else
1295 update_object (last, UP_OBJ_REMOVE); 1133 update_object (last, UP_OBJ_REMOVE);
1296 1134
1297 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) || (op->glow_radius != 0)) 1135 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1298 update_all_los (op->map, op->x, op->y); 1136 update_all_los (map, x, y);
1299 } 1137 }
1300} 1138}
1301 1139
1302/* 1140/*
1303 * merge_ob(op,top): 1141 * merge_ob(op,top):
1311merge_ob (object *op, object *top) 1149merge_ob (object *op, object *top)
1312{ 1150{
1313 if (!op->nrof) 1151 if (!op->nrof)
1314 return 0; 1152 return 0;
1315 1153
1316 if (top == NULL) 1154 if (top)
1317 for (top = op; top != NULL && top->above != NULL; top = top->above); 1155 for (top = op; top && top->above; top = top->above)
1156 ;
1318 1157
1319 for (; top != NULL; top = top->below) 1158 for (; top; top = top->below)
1320 { 1159 {
1321 if (top == op) 1160 if (top == op)
1322 continue; 1161 continue;
1323 if (CAN_MERGE (op, top)) 1162
1163 if (object::can_merge (op, top))
1324 { 1164 {
1325 top->nrof += op->nrof; 1165 top->nrof += op->nrof;
1326 1166
1327/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/ 1167/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/
1328 op->weight = 0; /* Don't want any adjustements now */ 1168 op->weight = 0; /* Don't want any adjustements now */
1329 remove_ob (op); 1169 op->destroy ();
1330 free_object (op);
1331 return top; 1170 return top;
1332 } 1171 }
1333 } 1172 }
1334 1173
1335 return NULL; 1174 return 0;
1336} 1175}
1337 1176
1177void
1178object::expand_tail ()
1179{
1180 if (more)
1181 return;
1182
1183 object *prev = this;
1184
1185 for (archetype *at = arch->more; at; at = at->more)
1186 {
1187 object *op = arch_to_object (at);
1188
1189 op->name = name;
1190 op->name_pl = name_pl;
1191 op->title = title;
1192
1193 op->head = this;
1194 prev->more = op;
1195
1196 prev = op;
1197 }
1198}
1199
1338/* 1200/*
1339 * same as insert_ob_in_map except it handle separate coordinates and do a clean 1201 * same as insert_ob_in_map except it handles separate coordinates and does a clean
1340 * job preparing multi-part monsters 1202 * job preparing multi-part monsters.
1341 */ 1203 */
1342object * 1204object *
1343insert_ob_in_map_at (object *op, mapstruct *m, object *originator, int flag, int x, int y) 1205insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1344{ 1206{
1345 object *tmp;
1346
1347 if (op->head)
1348 op = op->head;
1349
1350 for (tmp = op; tmp; tmp = tmp->more) 1207 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1351 { 1208 {
1352 tmp->x = x + tmp->arch->clone.x; 1209 tmp->x = x + tmp->arch->clone.x;
1353 tmp->y = y + tmp->arch->clone.y; 1210 tmp->y = y + tmp->arch->clone.y;
1354 } 1211 }
1355 1212
1374 * Return value: 1231 * Return value:
1375 * new object if 'op' was merged with other object 1232 * new object if 'op' was merged with other object
1376 * NULL if 'op' was destroyed 1233 * NULL if 'op' was destroyed
1377 * just 'op' otherwise 1234 * just 'op' otherwise
1378 */ 1235 */
1379
1380object * 1236object *
1381insert_ob_in_map (object *op, mapstruct *m, object *originator, int flag) 1237insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1382{ 1238{
1239 assert (!op->flag [FLAG_FREED]);
1240
1383 object *tmp, *top, *floor = NULL; 1241 object *tmp, *top, *floor = NULL;
1384 sint16 x, y;
1385 1242
1386 if (QUERY_FLAG (op, FLAG_FREED)) 1243 op->remove ();
1387 {
1388 LOG (llevError, "Trying to insert freed object!\n");
1389 return NULL;
1390 }
1391 1244
1392 if (m == NULL) 1245#if 0
1393 { 1246 if (!m->active != !op->active)
1394 dump_object (op); 1247 if (m->active)
1395 LOG (llevError, "Trying to insert in null-map!\n%s\n", errmsg); 1248 op->activate_recursive ();
1396 return op; 1249 else
1397 } 1250 op->deactivate_recursive ();
1251#endif
1398 1252
1399 if (out_of_map (m, op->x, op->y)) 1253 if (out_of_map (m, op->x, op->y))
1400 { 1254 {
1401 dump_object (op);
1402 LOG (llevError, "Trying to insert object outside the map.\n%s\n", errmsg); 1255 LOG (llevError, "Trying to insert object outside the map.\n%s\n", op->debug_desc ());
1403#ifdef MANY_CORES 1256#ifdef MANY_CORES
1404 /* Better to catch this here, as otherwise the next use of this object 1257 /* Better to catch this here, as otherwise the next use of this object
1405 * is likely to cause a crash. Better to find out where it is getting 1258 * is likely to cause a crash. Better to find out where it is getting
1406 * improperly inserted. 1259 * improperly inserted.
1407 */ 1260 */
1408 abort (); 1261 abort ();
1409#endif 1262#endif
1410 return op; 1263 return op;
1411 } 1264 }
1412 1265
1413 if (!QUERY_FLAG (op, FLAG_REMOVED))
1414 {
1415 dump_object (op);
1416 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", errmsg);
1417 return op;
1418 }
1419
1420 if (op->more != NULL)
1421 {
1422 /* The part may be on a different map. */
1423
1424 object *more = op->more; 1266 if (object *more = op->more)
1425 1267 {
1426 /* We really need the caller to normalize coordinates - if
1427 * we set the map, that doesn't work if the location is within
1428 * a map and this is straddling an edge. So only if coordinate
1429 * is clear wrong do we normalize it.
1430 */
1431 if (OUT_OF_REAL_MAP (more->map, more->x, more->y))
1432 more->map = get_map_from_coord (m, &more->x, &more->y);
1433 else if (!more->map)
1434 {
1435 /* For backwards compatibility - when not dealing with tiled maps,
1436 * more->map should always point to the parent.
1437 */
1438 more->map = m;
1439 }
1440
1441 if (insert_ob_in_map (more, more->map, originator, flag) == NULL) 1268 if (!insert_ob_in_map (more, m, originator, flag))
1442 { 1269 {
1443 if (!op->head) 1270 if (!op->head)
1444 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n"); 1271 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n");
1445 1272
1446 return NULL; 1273 return 0;
1447 } 1274 }
1448 } 1275 }
1449 1276
1450 CLEAR_FLAG (op, FLAG_REMOVED); 1277 CLEAR_FLAG (op, FLAG_REMOVED);
1451 1278
1452 /* Ideally, the caller figures this out. However, it complicates a lot 1279 /* Ideally, the caller figures this out. However, it complicates a lot
1453 * of areas of callers (eg, anything that uses find_free_spot would now 1280 * of areas of callers (eg, anything that uses find_free_spot would now
1454 * need extra work 1281 * need extra work
1455 */ 1282 */
1456 op->map = get_map_from_coord (m, &op->x, &op->y); 1283 if (!xy_normalise (m, op->x, op->y))
1457 x = op->x; 1284 return 0;
1458 y = op->y; 1285
1286 op->map = m;
1287 mapspace &ms = op->ms ();
1459 1288
1460 /* this has to be done after we translate the coordinates. 1289 /* this has to be done after we translate the coordinates.
1461 */ 1290 */
1462 if (op->nrof && !(flag & INS_NO_MERGE)) 1291 if (op->nrof && !(flag & INS_NO_MERGE))
1463 for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above) 1292 for (tmp = ms.bot; tmp; tmp = tmp->above)
1464 if (CAN_MERGE (op, tmp)) 1293 if (object::can_merge (op, tmp))
1465 { 1294 {
1466 op->nrof += tmp->nrof; 1295 op->nrof += tmp->nrof;
1467 remove_ob (tmp); 1296 tmp->destroy ();
1468 free_object (tmp);
1469 } 1297 }
1470 1298
1471 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1299 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1472 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1300 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1473 1301
1486 op->below = originator->below; 1314 op->below = originator->below;
1487 1315
1488 if (op->below) 1316 if (op->below)
1489 op->below->above = op; 1317 op->below->above = op;
1490 else 1318 else
1491 SET_MAP_OB (op->map, op->x, op->y, op); 1319 ms.bot = op;
1492 1320
1493 /* since *below* originator, no need to update top */ 1321 /* since *below* originator, no need to update top */
1494 originator->below = op; 1322 originator->below = op;
1495 } 1323 }
1496 else 1324 else
1497 { 1325 {
1326 top = ms.bot;
1327
1498 /* If there are other objects, then */ 1328 /* If there are other objects, then */
1499 if ((!(flag & INS_MAP_LOAD)) && ((top = GET_MAP_OB (op->map, op->x, op->y)) != NULL)) 1329 if ((!(flag & INS_MAP_LOAD)) && top)
1500 { 1330 {
1501 object *last = NULL; 1331 object *last = 0;
1502 1332
1503 /* 1333 /*
1504 * If there are multiple objects on this space, we do some trickier handling. 1334 * If there are multiple objects on this space, we do some trickier handling.
1505 * We've already dealt with merging if appropriate. 1335 * We've already dealt with merging if appropriate.
1506 * Generally, we want to put the new object on top. But if 1336 * Generally, we want to put the new object on top. But if
1510 * once we get to them. This reduces the need to traverse over all of 1340 * once we get to them. This reduces the need to traverse over all of
1511 * them when adding another one - this saves quite a bit of cpu time 1341 * them when adding another one - this saves quite a bit of cpu time
1512 * when lots of spells are cast in one area. Currently, it is presumed 1342 * when lots of spells are cast in one area. Currently, it is presumed
1513 * that flying non pickable objects are spell objects. 1343 * that flying non pickable objects are spell objects.
1514 */ 1344 */
1515 1345 for (top = ms.bot; top; top = top->above)
1516 while (top != NULL)
1517 { 1346 {
1518 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1347 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))
1519 floor = top; 1348 floor = top;
1520 1349
1521 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1350 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))
1524 top = top->below; 1353 top = top->below;
1525 break; 1354 break;
1526 } 1355 }
1527 1356
1528 last = top; 1357 last = top;
1529 top = top->above;
1530 } 1358 }
1531 1359
1532 /* Don't want top to be NULL, so set it to the last valid object */ 1360 /* Don't want top to be NULL, so set it to the last valid object */
1533 top = last; 1361 top = last;
1534 1362
1536 * looks like instead of lots of conditions here. 1364 * looks like instead of lots of conditions here.
1537 * makes things faster, and effectively the same result. 1365 * makes things faster, and effectively the same result.
1538 */ 1366 */
1539 1367
1540 /* Have object 'fall below' other objects that block view. 1368 /* Have object 'fall below' other objects that block view.
1541 * Unless those objects are exits, type 66 1369 * Unless those objects are exits.
1542 * If INS_ON_TOP is used, don't do this processing 1370 * If INS_ON_TOP is used, don't do this processing
1543 * Need to find the object that in fact blocks view, otherwise 1371 * Need to find the object that in fact blocks view, otherwise
1544 * stacking is a bit odd. 1372 * stacking is a bit odd.
1545 */ 1373 */
1546 if (!(flag & INS_ON_TOP) && 1374 if (!(flag & INS_ON_TOP)
1547 (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_BLOCKSVIEW) && (op->face && !op->face->visibility)) 1375 && ms.flags () & P_BLOCKSVIEW
1376 && (op->face && !faces [op->face].visibility))
1548 { 1377 {
1549 for (last = top; last != floor; last = last->below) 1378 for (last = top; last != floor; last = last->below)
1550 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1379 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1551 break; 1380 break;
1381
1552 /* Check to see if we found the object that blocks view, 1382 /* Check to see if we found the object that blocks view,
1553 * and make sure we have a below pointer for it so that 1383 * and make sure we have a below pointer for it so that
1554 * we can get inserted below this one, which requires we 1384 * we can get inserted below this one, which requires we
1555 * set top to the object below us. 1385 * set top to the object below us.
1556 */ 1386 */
1558 top = last->below; 1388 top = last->below;
1559 } 1389 }
1560 } /* If objects on this space */ 1390 } /* If objects on this space */
1561 1391
1562 if (flag & INS_MAP_LOAD) 1392 if (flag & INS_MAP_LOAD)
1563 top = GET_MAP_TOP (op->map, op->x, op->y); 1393 top = ms.top;
1564 1394
1565 if (flag & INS_ABOVE_FLOOR_ONLY) 1395 if (flag & INS_ABOVE_FLOOR_ONLY)
1566 top = floor; 1396 top = floor;
1567 1397
1568 /* Top is the object that our object (op) is going to get inserted above. 1398 /* Top is the object that our object (op) is going to get inserted above.
1569 */ 1399 */
1570 1400
1571 /* First object on this space */ 1401 /* First object on this space */
1572 if (!top) 1402 if (!top)
1573 { 1403 {
1574 op->above = GET_MAP_OB (op->map, op->x, op->y); 1404 op->above = ms.bot;
1575 1405
1576 if (op->above) 1406 if (op->above)
1577 op->above->below = op; 1407 op->above->below = op;
1578 1408
1579 op->below = NULL; 1409 op->below = 0;
1580 SET_MAP_OB (op->map, op->x, op->y, op); 1410 ms.bot = op;
1581 } 1411 }
1582 else 1412 else
1583 { /* get inserted into the stack above top */ 1413 { /* get inserted into the stack above top */
1584 op->above = top->above; 1414 op->above = top->above;
1585 1415
1588 1418
1589 op->below = top; 1419 op->below = top;
1590 top->above = op; 1420 top->above = op;
1591 } 1421 }
1592 1422
1593 if (op->above == NULL) 1423 if (!op->above)
1594 SET_MAP_TOP (op->map, op->x, op->y, op); 1424 ms.top = op;
1595 } /* else not INS_BELOW_ORIGINATOR */ 1425 } /* else not INS_BELOW_ORIGINATOR */
1596 1426
1597 if (op->type == PLAYER) 1427 if (op->type == PLAYER)
1428 {
1598 op->contr->do_los = 1; 1429 op->contr->do_los = 1;
1430 ++op->map->players;
1431 op->map->touch ();
1432 }
1433
1434 op->map->dirty = true;
1599 1435
1600 /* If we have a floor, we know the player, if any, will be above 1436 /* If we have a floor, we know the player, if any, will be above
1601 * it, so save a few ticks and start from there. 1437 * it, so save a few ticks and start from there.
1602 */ 1438 */
1603 if (!(flag & INS_MAP_LOAD)) 1439 if (!(flag & INS_MAP_LOAD))
1604 for (tmp = floor ? floor : GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1440 if (object *pl = ms.player ())
1605 if (tmp->type == PLAYER) 1441 if (pl->contr->ns)
1606 tmp->contr->socket.update_look = 1; 1442 pl->contr->ns->floorbox_update ();
1607 1443
1608 /* If this object glows, it may affect lighting conditions that are 1444 /* If this object glows, it may affect lighting conditions that are
1609 * visible to others on this map. But update_all_los is really 1445 * visible to others on this map. But update_all_los is really
1610 * an inefficient way to do this, as it means los for all players 1446 * an inefficient way to do this, as it means los for all players
1611 * on the map will get recalculated. The players could very well 1447 * on the map will get recalculated. The players could very well
1612 * be far away from this change and not affected in any way - 1448 * be far away from this change and not affected in any way -
1613 * this should get redone to only look for players within range, 1449 * this should get redone to only look for players within range,
1614 * or just updating the P_NEED_UPDATE for spaces within this area 1450 * or just updating the P_UPTODATE for spaces within this area
1615 * of effect may be sufficient. 1451 * of effect may be sufficient.
1616 */ 1452 */
1617 if (MAP_DARKNESS (op->map) && (op->glow_radius != 0)) 1453 if (op->map->darkness && (op->glow_radius != 0))
1618 update_all_los (op->map, op->x, op->y); 1454 update_all_los (op->map, op->x, op->y);
1619 1455
1620 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1456 /* updates flags (blocked, alive, no magic, etc) for this map space */
1621 update_object (op, UP_OBJ_INSERT); 1457 update_object (op, UP_OBJ_INSERT);
1622 1458
1459 INVOKE_OBJECT (INSERT, op);
1460
1623 /* Don't know if moving this to the end will break anything. However, 1461 /* Don't know if moving this to the end will break anything. However,
1624 * we want to have update_look set above before calling this. 1462 * we want to have floorbox_update called before calling this.
1625 * 1463 *
1626 * check_move_on() must be after this because code called from 1464 * check_move_on() must be after this because code called from
1627 * check_move_on() depends on correct map flags (so functions like 1465 * check_move_on() depends on correct map flags (so functions like
1628 * blocked() and wall() work properly), and these flags are updated by 1466 * blocked() and wall() work properly), and these flags are updated by
1629 * update_object(). 1467 * update_object().
1631 1469
1632 /* if this is not the head or flag has been passed, don't check walk on status */ 1470 /* if this is not the head or flag has been passed, don't check walk on status */
1633 if (!(flag & INS_NO_WALK_ON) && !op->head) 1471 if (!(flag & INS_NO_WALK_ON) && !op->head)
1634 { 1472 {
1635 if (check_move_on (op, originator)) 1473 if (check_move_on (op, originator))
1636 return NULL; 1474 return 0;
1637 1475
1638 /* If we are a multi part object, lets work our way through the check 1476 /* If we are a multi part object, lets work our way through the check
1639 * walk on's. 1477 * walk on's.
1640 */ 1478 */
1641 for (tmp = op->more; tmp != NULL; tmp = tmp->more) 1479 for (tmp = op->more; tmp != NULL; tmp = tmp->more)
1642 if (check_move_on (tmp, originator)) 1480 if (check_move_on (tmp, originator))
1643 return NULL; 1481 return 0;
1644 } 1482 }
1645 1483
1646 return op; 1484 return op;
1647} 1485}
1648 1486
1649/* this function inserts an object in the map, but if it 1487/* this function inserts an object in the map, but if it
1650 * finds an object of its own type, it'll remove that one first. 1488 * finds an object of its own type, it'll remove that one first.
1651 * op is the object to insert it under: supplies x and the map. 1489 * op is the object to insert it under: supplies x and the map.
1652 */ 1490 */
1653void 1491void
1654replace_insert_ob_in_map (const char *arch_string, object *op) 1492replace_insert_ob_in_map (const char *arch_string, object *op)
1655{ 1493{
1656 object * 1494 object *tmp, *tmp1;
1657 tmp;
1658 object *
1659 tmp1;
1660 1495
1661 /* first search for itself and remove any old instances */ 1496 /* first search for itself and remove any old instances */
1662 1497
1663 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1498 for (tmp = op->ms ().bot; tmp; tmp = tmp->above)
1664 {
1665 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */ 1499 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */
1666 { 1500 tmp->destroy ();
1667 remove_ob (tmp);
1668 free_object (tmp);
1669 }
1670 }
1671 1501
1672 tmp1 = arch_to_object (find_archetype (arch_string)); 1502 tmp1 = arch_to_object (archetype::find (arch_string));
1673 1503
1674 tmp1->x = op->x; 1504 tmp1->x = op->x;
1675 tmp1->y = op->y; 1505 tmp1->y = op->y;
1676 insert_ob_in_map (tmp1, op->map, op, 0); 1506 insert_ob_in_map (tmp1, op->map, op, 0);
1507}
1508
1509object *
1510object::insert_at (object *where, object *originator, int flags)
1511{
1512 return where->map->insert (this, where->x, where->y, originator, flags);
1677} 1513}
1678 1514
1679/* 1515/*
1680 * get_split_ob(ob,nr) splits up ob into two parts. The part which 1516 * get_split_ob(ob,nr) splits up ob into two parts. The part which
1681 * is returned contains nr objects, and the remaining parts contains 1517 * is returned contains nr objects, and the remaining parts contains
1682 * the rest (or is removed and freed if that number is 0). 1518 * the rest (or is removed and freed if that number is 0).
1683 * On failure, NULL is returned, and the reason put into the 1519 * On failure, NULL is returned, and the reason put into the
1684 * global static errmsg array. 1520 * global static errmsg array.
1685 */ 1521 */
1686
1687object * 1522object *
1688get_split_ob (object *orig_ob, uint32 nr) 1523get_split_ob (object *orig_ob, uint32 nr)
1689{ 1524{
1690 object * 1525 object *newob;
1691 newob;
1692 int
1693 is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0); 1526 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1694 1527
1695 if (orig_ob->nrof < nr) 1528 if (orig_ob->nrof < nr)
1696 { 1529 {
1697 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name); 1530 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1698 return NULL; 1531 return NULL;
1699 } 1532 }
1700 1533
1701 newob = object_create_clone (orig_ob); 1534 newob = object_create_clone (orig_ob);
1702 1535
1703 if ((orig_ob->nrof -= nr) < 1) 1536 if ((orig_ob->nrof -= nr) < 1)
1704 { 1537 orig_ob->destroy (1);
1705 if (!is_removed)
1706 remove_ob (orig_ob);
1707 free_object2 (orig_ob, 1);
1708 }
1709 else if (!is_removed) 1538 else if (!is_removed)
1710 { 1539 {
1711 if (orig_ob->env != NULL) 1540 if (orig_ob->env != NULL)
1712 sub_weight (orig_ob->env, orig_ob->weight * nr); 1541 sub_weight (orig_ob->env, orig_ob->weight * nr);
1713 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY) 1542 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY)
1728 * the amount of an object. If the amount reaches 0, the object 1557 * the amount of an object. If the amount reaches 0, the object
1729 * is subsequently removed and freed. 1558 * is subsequently removed and freed.
1730 * 1559 *
1731 * Return value: 'op' if something is left, NULL if the amount reached 0 1560 * Return value: 'op' if something is left, NULL if the amount reached 0
1732 */ 1561 */
1733
1734object * 1562object *
1735decrease_ob_nr (object *op, uint32 i) 1563decrease_ob_nr (object *op, uint32 i)
1736{ 1564{
1737 object *tmp; 1565 object *tmp;
1738 player *pl;
1739 1566
1740 if (i == 0) /* objects with op->nrof require this check */ 1567 if (i == 0) /* objects with op->nrof require this check */
1741 return op; 1568 return op;
1742 1569
1743 if (i > op->nrof) 1570 if (i > op->nrof)
1744 i = op->nrof; 1571 i = op->nrof;
1745 1572
1746 if (QUERY_FLAG (op, FLAG_REMOVED)) 1573 if (QUERY_FLAG (op, FLAG_REMOVED))
1747 op->nrof -= i; 1574 op->nrof -= i;
1748 else if (op->env != NULL) 1575 else if (op->env)
1749 { 1576 {
1750 /* is this object in the players inventory, or sub container 1577 /* is this object in the players inventory, or sub container
1751 * therein? 1578 * therein?
1752 */ 1579 */
1753 tmp = is_player_inv (op->env); 1580 tmp = op->in_player ();
1754 /* nope. Is this a container the player has opened? 1581 /* nope. Is this a container the player has opened?
1755 * If so, set tmp to that player. 1582 * If so, set tmp to that player.
1756 * IMO, searching through all the players will mostly 1583 * IMO, searching through all the players will mostly
1757 * likely be quicker than following op->env to the map, 1584 * likely be quicker than following op->env to the map,
1758 * and then searching the map for a player. 1585 * and then searching the map for a player.
1759 */ 1586 */
1760 if (!tmp) 1587 if (!tmp)
1761 { 1588 for_all_players (pl)
1762 for (pl = first_player; pl; pl = pl->next)
1763 if (pl->ob->container == op->env) 1589 if (pl->ob->container == op->env)
1590 {
1591 tmp = pl->ob;
1764 break; 1592 break;
1765 if (pl)
1766 tmp = pl->ob;
1767 else
1768 tmp = NULL;
1769 } 1593 }
1770 1594
1771 if (i < op->nrof) 1595 if (i < op->nrof)
1772 { 1596 {
1773 sub_weight (op->env, op->weight * i); 1597 sub_weight (op->env, op->weight * i);
1774 op->nrof -= i; 1598 op->nrof -= i;
1775 if (tmp) 1599 if (tmp)
1776 {
1777 esrv_send_item (tmp, op); 1600 esrv_send_item (tmp, op);
1778 }
1779 } 1601 }
1780 else 1602 else
1781 { 1603 {
1782 remove_ob (op); 1604 op->remove ();
1783 op->nrof = 0; 1605 op->nrof = 0;
1784 if (tmp) 1606 if (tmp)
1785 {
1786 esrv_del_item (tmp->contr, op->count); 1607 esrv_del_item (tmp->contr, op->count);
1787 }
1788 } 1608 }
1789 } 1609 }
1790 else 1610 else
1791 { 1611 {
1792 object *above = op->above; 1612 object *above = op->above;
1793 1613
1794 if (i < op->nrof) 1614 if (i < op->nrof)
1795 op->nrof -= i; 1615 op->nrof -= i;
1796 else 1616 else
1797 { 1617 {
1798 remove_ob (op); 1618 op->remove ();
1799 op->nrof = 0; 1619 op->nrof = 0;
1800 } 1620 }
1801 1621
1802 /* Since we just removed op, op->above is null */ 1622 /* Since we just removed op, op->above is null */
1803 for (tmp = above; tmp != NULL; tmp = tmp->above) 1623 for (tmp = above; tmp; tmp = tmp->above)
1804 if (tmp->type == PLAYER) 1624 if (tmp->type == PLAYER)
1805 { 1625 {
1806 if (op->nrof) 1626 if (op->nrof)
1807 esrv_send_item (tmp, op); 1627 esrv_send_item (tmp, op);
1808 else 1628 else
1812 1632
1813 if (op->nrof) 1633 if (op->nrof)
1814 return op; 1634 return op;
1815 else 1635 else
1816 { 1636 {
1817 free_object (op); 1637 op->destroy ();
1818 return NULL; 1638 return 0;
1819 } 1639 }
1820} 1640}
1821 1641
1822/* 1642/*
1823 * add_weight(object, weight) adds the specified weight to an object, 1643 * add_weight(object, weight) adds the specified weight to an object,
1824 * and also updates how much the environment(s) is/are carrying. 1644 * and also updates how much the environment(s) is/are carrying.
1825 */ 1645 */
1826
1827void 1646void
1828add_weight (object *op, signed long weight) 1647add_weight (object *op, signed long weight)
1829{ 1648{
1830 while (op != NULL) 1649 while (op != NULL)
1831 { 1650 {
1835 op->carrying += weight; 1654 op->carrying += weight;
1836 op = op->env; 1655 op = op->env;
1837 } 1656 }
1838} 1657}
1839 1658
1659object *
1660insert_ob_in_ob (object *op, object *where)
1661{
1662 if (!where)
1663 {
1664 char *dump = dump_object (op);
1665 LOG (llevError, "Trying to put object in NULL.\n%s\n", dump);
1666 free (dump);
1667 return op;
1668 }
1669
1670 if (where->head)
1671 {
1672 LOG (llevDebug, "Warning: Tried to insert object into wrong part of multipart object.\n");
1673 where = where->head;
1674 }
1675
1676 return where->insert (op);
1677}
1678
1840/* 1679/*
1841 * insert_ob_in_ob(op,environment): 1680 * env->insert (op)
1842 * This function inserts the object op in the linked list 1681 * This function inserts the object op in the linked list
1843 * inside the object environment. 1682 * inside the object environment.
1844 * 1683 *
1845 * Eneq(@csd.uu.se): Altered insert_ob_in_ob to make things picked up enter
1846 * the inventory at the last position or next to other objects of the same
1847 * type.
1848 * Frank: Now sorted by type, archetype and magic!
1849 *
1850 * The function returns now pointer to inserted item, and return value can 1684 * The function returns now pointer to inserted item, and return value can
1851 * be != op, if items are merged. -Tero 1685 * be != op, if items are merged. -Tero
1852 */ 1686 */
1853
1854object * 1687object *
1855insert_ob_in_ob (object *op, object *where) 1688object::insert (object *op)
1856{ 1689{
1857 object * 1690 object *tmp, *otmp;
1858 tmp, *
1859 otmp;
1860 1691
1861 if (!QUERY_FLAG (op, FLAG_REMOVED)) 1692 if (!QUERY_FLAG (op, FLAG_REMOVED))
1862 { 1693 op->remove ();
1863 dump_object (op);
1864 LOG (llevError, "Trying to insert (ob) inserted object.\n%s\n", errmsg);
1865 return op;
1866 }
1867
1868 if (where == NULL)
1869 {
1870 dump_object (op);
1871 LOG (llevError, "Trying to put object in NULL.\n%s\n", errmsg);
1872 return op;
1873 }
1874
1875 if (where->head)
1876 {
1877 LOG (llevDebug, "Warning: Tried to insert object wrong part of multipart object.\n");
1878 where = where->head;
1879 }
1880 1694
1881 if (op->more) 1695 if (op->more)
1882 { 1696 {
1883 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count); 1697 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);
1884 return op; 1698 return op;
1886 1700
1887 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL); 1701 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL);
1888 CLEAR_FLAG (op, FLAG_REMOVED); 1702 CLEAR_FLAG (op, FLAG_REMOVED);
1889 if (op->nrof) 1703 if (op->nrof)
1890 { 1704 {
1891 for (tmp = where->inv; tmp != NULL; tmp = tmp->below) 1705 for (tmp = inv; tmp != NULL; tmp = tmp->below)
1892 if (CAN_MERGE (tmp, op)) 1706 if (object::can_merge (tmp, op))
1893 { 1707 {
1894 /* return the original object and remove inserted object 1708 /* return the original object and remove inserted object
1895 (client needs the original object) */ 1709 (client needs the original object) */
1896 tmp->nrof += op->nrof; 1710 tmp->nrof += op->nrof;
1897 /* Weight handling gets pretty funky. Since we are adding to 1711 /* Weight handling gets pretty funky. Since we are adding to
1898 * tmp->nrof, we need to increase the weight. 1712 * tmp->nrof, we need to increase the weight.
1899 */ 1713 */
1900 add_weight (where, op->weight * op->nrof); 1714 add_weight (this, op->weight * op->nrof);
1901 SET_FLAG (op, FLAG_REMOVED); 1715 SET_FLAG (op, FLAG_REMOVED);
1902 free_object (op); /* free the inserted object */ 1716 op->destroy (); /* free the inserted object */
1903 op = tmp; 1717 op = tmp;
1904 remove_ob (op); /* and fix old object's links */ 1718 op->remove (); /* and fix old object's links */
1905 CLEAR_FLAG (op, FLAG_REMOVED); 1719 CLEAR_FLAG (op, FLAG_REMOVED);
1906 break; 1720 break;
1907 } 1721 }
1908 1722
1909 /* I assume combined objects have no inventory 1723 /* I assume combined objects have no inventory
1910 * We add the weight - this object could have just been removed 1724 * We add the weight - this object could have just been removed
1911 * (if it was possible to merge). calling remove_ob will subtract 1725 * (if it was possible to merge). calling remove_ob will subtract
1912 * the weight, so we need to add it in again, since we actually do 1726 * the weight, so we need to add it in again, since we actually do
1913 * the linking below 1727 * the linking below
1914 */ 1728 */
1915 add_weight (where, op->weight * op->nrof); 1729 add_weight (this, op->weight * op->nrof);
1916 } 1730 }
1917 else 1731 else
1918 add_weight (where, (op->weight + op->carrying)); 1732 add_weight (this, (op->weight + op->carrying));
1919 1733
1920 otmp = is_player_inv (where); 1734 otmp = this->in_player ();
1921 if (otmp && otmp->contr != NULL) 1735 if (otmp && otmp->contr)
1922 {
1923 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1736 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1924 fix_player (otmp); 1737 otmp->update_stats ();
1925 }
1926 1738
1927 op->map = NULL; 1739 op->map = 0;
1928 op->env = where; 1740 op->env = this;
1929 op->above = NULL; 1741 op->above = 0;
1930 op->below = NULL; 1742 op->below = 0;
1931 op->x = 0, op->y = 0; 1743 op->x = 0, op->y = 0;
1932 1744
1933 /* reset the light list and los of the players on the map */ 1745 /* reset the light list and los of the players on the map */
1934 if ((op->glow_radius != 0) && where->map) 1746 if ((op->glow_radius != 0) && map)
1935 { 1747 {
1936#ifdef DEBUG_LIGHTS 1748#ifdef DEBUG_LIGHTS
1937 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name); 1749 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1938#endif /* DEBUG_LIGHTS */ 1750#endif /* DEBUG_LIGHTS */
1939 if (MAP_DARKNESS (where->map)) 1751 if (map->darkness)
1940 update_all_los (where->map, where->x, where->y); 1752 update_all_los (map, x, y);
1941 } 1753 }
1942 1754
1943 /* Client has no idea of ordering so lets not bother ordering it here. 1755 /* Client has no idea of ordering so lets not bother ordering it here.
1944 * It sure simplifies this function... 1756 * It sure simplifies this function...
1945 */ 1757 */
1946 if (where->inv == NULL) 1758 if (!inv)
1947 where->inv = op; 1759 inv = op;
1948 else 1760 else
1949 { 1761 {
1950 op->below = where->inv; 1762 op->below = inv;
1951 op->below->above = op; 1763 op->below->above = op;
1952 where->inv = op; 1764 inv = op;
1953 } 1765 }
1766
1767 INVOKE_OBJECT (INSERT, this);
1768
1954 return op; 1769 return op;
1955} 1770}
1956 1771
1957/* 1772/*
1958 * Checks if any objects has a move_type that matches objects 1773 * Checks if any objects has a move_type that matches objects
1972 * 1787 *
1973 * MSW 2001-07-08: Check all objects on space, not just those below 1788 * MSW 2001-07-08: Check all objects on space, not just those below
1974 * object being inserted. insert_ob_in_map may not put new objects 1789 * object being inserted. insert_ob_in_map may not put new objects
1975 * on top. 1790 * on top.
1976 */ 1791 */
1977
1978int 1792int
1979check_move_on (object *op, object *originator) 1793check_move_on (object *op, object *originator)
1980{ 1794{
1981 object * 1795 object *tmp;
1982 tmp; 1796 maptile *m = op->map;
1983 tag_t
1984 tag;
1985 mapstruct *
1986 m = op->map;
1987 int
1988 x = op->x, y = op->y; 1797 int x = op->x, y = op->y;
1989 1798
1990 MoveType 1799 MoveType move_on, move_slow, move_block;
1991 move_on,
1992 move_slow,
1993 move_block;
1994 1800
1995 if (QUERY_FLAG (op, FLAG_NO_APPLY)) 1801 if (QUERY_FLAG (op, FLAG_NO_APPLY))
1996 return 0; 1802 return 0;
1997
1998 tag = op->count;
1999 1803
2000 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y); 1804 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
2001 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y); 1805 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
2002 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y); 1806 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
2003 1807
2019 1823
2020 /* The objects have to be checked from top to bottom. 1824 /* The objects have to be checked from top to bottom.
2021 * Hence, we first go to the top: 1825 * Hence, we first go to the top:
2022 */ 1826 */
2023 1827
2024 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL && tmp->above != NULL; tmp = tmp->above) 1828 for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
2025 { 1829 {
2026 /* Trim the search when we find the first other spell effect 1830 /* Trim the search when we find the first other spell effect
2027 * this helps performance so that if a space has 50 spell objects, 1831 * this helps performance so that if a space has 50 spell objects,
2028 * we don't need to check all of them. 1832 * we don't need to check all of them.
2029 */ 1833 */
2047 if ((!op->move_type && tmp->move_slow & MOVE_WALK) || 1851 if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
2048 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0)) 1852 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
2049 { 1853 {
2050 1854
2051 float 1855 float
2052 diff = tmp->move_slow_penalty * FABS (op->speed); 1856 diff = tmp->move_slow_penalty * fabs (op->speed);
2053 1857
2054 if (op->type == PLAYER) 1858 if (op->type == PLAYER)
2055 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) || 1859 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) ||
2056 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN))) 1860 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN)))
2057 diff /= 4.0; 1861 diff /= 4.0;
2064 if ((!op->move_type && tmp->move_on & MOVE_WALK) || 1868 if ((!op->move_type && tmp->move_on & MOVE_WALK) ||
2065 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0)) 1869 ((op->move_type & tmp->move_on) && (op->move_type & ~tmp->move_on & ~tmp->move_block) == 0))
2066 { 1870 {
2067 move_apply (tmp, op, originator); 1871 move_apply (tmp, op, originator);
2068 1872
2069 if (was_destroyed (op, tag)) 1873 if (op->destroyed ())
2070 return 1; 1874 return 1;
2071 1875
2072 /* what the person/creature stepped onto has moved the object 1876 /* what the person/creature stepped onto has moved the object
2073 * someplace new. Don't process any further - if we did, 1877 * someplace new. Don't process any further - if we did,
2074 * have a feeling strange problems would result. 1878 * have a feeling strange problems would result.
2084/* 1888/*
2085 * present_arch(arch, map, x, y) searches for any objects with 1889 * present_arch(arch, map, x, y) searches for any objects with
2086 * a matching archetype at the given map and coordinates. 1890 * a matching archetype at the given map and coordinates.
2087 * The first matching object is returned, or NULL if none. 1891 * The first matching object is returned, or NULL if none.
2088 */ 1892 */
2089
2090object * 1893object *
2091present_arch (const archetype *at, mapstruct *m, int x, int y) 1894present_arch (const archetype *at, maptile *m, int x, int y)
2092{ 1895{
2093 object *
2094 tmp;
2095
2096 if (m == NULL || out_of_map (m, x, y)) 1896 if (!m || out_of_map (m, x, y))
2097 { 1897 {
2098 LOG (llevError, "Present_arch called outside map.\n"); 1898 LOG (llevError, "Present_arch called outside map.\n");
2099 return NULL; 1899 return NULL;
2100 } 1900 }
2101 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1901
1902 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
2102 if (tmp->arch == at) 1903 if (tmp->arch == at)
2103 return tmp; 1904 return tmp;
1905
2104 return NULL; 1906 return NULL;
2105} 1907}
2106 1908
2107/* 1909/*
2108 * present(type, map, x, y) searches for any objects with 1910 * present(type, map, x, y) searches for any objects with
2109 * a matching type variable at the given map and coordinates. 1911 * a matching type variable at the given map and coordinates.
2110 * The first matching object is returned, or NULL if none. 1912 * The first matching object is returned, or NULL if none.
2111 */ 1913 */
2112
2113object * 1914object *
2114present (unsigned char type, mapstruct *m, int x, int y) 1915present (unsigned char type, maptile *m, int x, int y)
2115{ 1916{
2116 object *
2117 tmp;
2118
2119 if (out_of_map (m, x, y)) 1917 if (out_of_map (m, x, y))
2120 { 1918 {
2121 LOG (llevError, "Present called outside map.\n"); 1919 LOG (llevError, "Present called outside map.\n");
2122 return NULL; 1920 return NULL;
2123 } 1921 }
2124 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1922
1923 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
2125 if (tmp->type == type) 1924 if (tmp->type == type)
2126 return tmp; 1925 return tmp;
1926
2127 return NULL; 1927 return NULL;
2128} 1928}
2129 1929
2130/* 1930/*
2131 * present_in_ob(type, object) searches for any objects with 1931 * present_in_ob(type, object) searches for any objects with
2132 * a matching type variable in the inventory of the given object. 1932 * a matching type variable in the inventory of the given object.
2133 * The first matching object is returned, or NULL if none. 1933 * The first matching object is returned, or NULL if none.
2134 */ 1934 */
2135
2136object * 1935object *
2137present_in_ob (unsigned char type, const object *op) 1936present_in_ob (unsigned char type, const object *op)
2138{ 1937{
2139 object *
2140 tmp;
2141
2142 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1938 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2143 if (tmp->type == type) 1939 if (tmp->type == type)
2144 return tmp; 1940 return tmp;
1941
2145 return NULL; 1942 return NULL;
2146} 1943}
2147 1944
2148/* 1945/*
2149 * present_in_ob (type, str, object) searches for any objects with 1946 * present_in_ob (type, str, object) searches for any objects with
2157 * str is the string to match against. Note that we match against 1954 * str is the string to match against. Note that we match against
2158 * the object name, not the archetype name. this is so that the 1955 * the object name, not the archetype name. this is so that the
2159 * spell code can use one object type (force), but change it's name 1956 * spell code can use one object type (force), but change it's name
2160 * to be unique. 1957 * to be unique.
2161 */ 1958 */
2162
2163object * 1959object *
2164present_in_ob_by_name (int type, const char *str, const object *op) 1960present_in_ob_by_name (int type, const char *str, const object *op)
2165{ 1961{
2166 object *
2167 tmp;
2168
2169 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1962 for (object *tmp = op->inv; tmp; tmp = tmp->below)
2170 {
2171 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name))) 1963 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name)))
2172 return tmp; 1964 return tmp;
2173 } 1965
2174 return NULL; 1966 return 0;
2175} 1967}
2176 1968
2177/* 1969/*
2178 * present_arch_in_ob(archetype, object) searches for any objects with 1970 * present_arch_in_ob(archetype, object) searches for any objects with
2179 * a matching archetype in the inventory of the given object. 1971 * a matching archetype in the inventory of the given object.
2180 * The first matching object is returned, or NULL if none. 1972 * The first matching object is returned, or NULL if none.
2181 */ 1973 */
2182
2183object * 1974object *
2184present_arch_in_ob (const archetype *at, const object *op) 1975present_arch_in_ob (const archetype *at, const object *op)
2185{ 1976{
2186 object *
2187 tmp;
2188
2189 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1977 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2190 if (tmp->arch == at) 1978 if (tmp->arch == at)
2191 return tmp; 1979 return tmp;
1980
2192 return NULL; 1981 return NULL;
2193} 1982}
2194 1983
2195/* 1984/*
2196 * activate recursively a flag on an object inventory 1985 * activate recursively a flag on an object inventory
2197 */ 1986 */
2198void 1987void
2199flag_inv (object *op, int flag) 1988flag_inv (object *op, int flag)
2200{ 1989{
2201 object *
2202 tmp;
2203
2204 if (op->inv) 1990 if (op->inv)
2205 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1991 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2206 { 1992 {
2207 SET_FLAG (tmp, flag); 1993 SET_FLAG (tmp, flag);
2208 flag_inv (tmp, flag); 1994 flag_inv (tmp, flag);
2209 } 1995 }
2210} /* 1996}
1997
1998/*
2211 * desactivate recursively a flag on an object inventory 1999 * deactivate recursively a flag on an object inventory
2212 */ 2000 */
2213void 2001void
2214unflag_inv (object *op, int flag) 2002unflag_inv (object *op, int flag)
2215{ 2003{
2216 object *
2217 tmp;
2218
2219 if (op->inv) 2004 if (op->inv)
2220 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 2005 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2221 { 2006 {
2222 CLEAR_FLAG (tmp, flag); 2007 CLEAR_FLAG (tmp, flag);
2223 unflag_inv (tmp, flag); 2008 unflag_inv (tmp, flag);
2224 } 2009 }
2225}
2226
2227/*
2228 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in
2229 * all it's inventory (recursively).
2230 * If checksums are used, a player will get set_cheat called for
2231 * him/her-self and all object carried by a call to this function.
2232 */
2233
2234void
2235set_cheat (object *op)
2236{
2237 SET_FLAG (op, FLAG_WAS_WIZ);
2238 flag_inv (op, FLAG_WAS_WIZ);
2239} 2010}
2240 2011
2241/* 2012/*
2242 * find_free_spot(object, map, x, y, start, stop) will search for 2013 * find_free_spot(object, map, x, y, start, stop) will search for
2243 * a spot at the given map and coordinates which will be able to contain 2014 * a spot at the given map and coordinates which will be able to contain
2257 * because arch_blocked (now ob_blocked) needs to know the movement type 2028 * because arch_blocked (now ob_blocked) needs to know the movement type
2258 * to know if the space in question will block the object. We can't use 2029 * to know if the space in question will block the object. We can't use
2259 * the archetype because that isn't correct if the monster has been 2030 * the archetype because that isn't correct if the monster has been
2260 * customized, changed states, etc. 2031 * customized, changed states, etc.
2261 */ 2032 */
2262
2263int 2033int
2264find_free_spot (const object *ob, mapstruct *m, int x, int y, int start, int stop) 2034find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)
2265{ 2035{
2266 int
2267 i,
2268 index = 0, flag; 2036 int index = 0, flag;
2269 static int
2270 altern[SIZEOFFREE]; 2037 int altern[SIZEOFFREE];
2271 2038
2272 for (i = start; i < stop; i++) 2039 for (int i = start; i < stop; i++)
2273 { 2040 {
2274 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]); 2041 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]);
2275 if (!flag) 2042 if (!flag)
2276 altern[index++] = i; 2043 altern [index++] = i;
2277 2044
2278 /* Basically, if we find a wall on a space, we cut down the search size. 2045 /* Basically, if we find a wall on a space, we cut down the search size.
2279 * In this way, we won't return spaces that are on another side of a wall. 2046 * In this way, we won't return spaces that are on another side of a wall.
2280 * This mostly work, but it cuts down the search size in all directions - 2047 * This mostly work, but it cuts down the search size in all directions -
2281 * if the space being examined only has a wall to the north and empty 2048 * if the space being examined only has a wall to the north and empty
2282 * spaces in all the other directions, this will reduce the search space 2049 * spaces in all the other directions, this will reduce the search space
2283 * to only the spaces immediately surrounding the target area, and 2050 * to only the spaces immediately surrounding the target area, and
2284 * won't look 2 spaces south of the target space. 2051 * won't look 2 spaces south of the target space.
2285 */ 2052 */
2286 else if ((flag & AB_NO_PASS) && maxfree[i] < stop) 2053 else if ((flag & P_NO_PASS) && maxfree[i] < stop)
2287 stop = maxfree[i]; 2054 stop = maxfree[i];
2288 } 2055 }
2056
2289 if (!index) 2057 if (!index)
2290 return -1; 2058 return -1;
2059
2291 return altern[RANDOM () % index]; 2060 return altern [rndm (index)];
2292} 2061}
2293 2062
2294/* 2063/*
2295 * find_first_free_spot(archetype, mapstruct, x, y) works like 2064 * find_first_free_spot(archetype, maptile, x, y) works like
2296 * find_free_spot(), but it will search max number of squares. 2065 * find_free_spot(), but it will search max number of squares.
2297 * But it will return the first available spot, not a random choice. 2066 * But it will return the first available spot, not a random choice.
2298 * Changed 0.93.2: Have it return -1 if there is no free spot available. 2067 * Changed 0.93.2: Have it return -1 if there is no free spot available.
2299 */ 2068 */
2300
2301int 2069int
2302find_first_free_spot (const object *ob, mapstruct *m, int x, int y) 2070find_first_free_spot (const object *ob, maptile *m, int x, int y)
2303{ 2071{
2304 int
2305 i;
2306
2307 for (i = 0; i < SIZEOFFREE; i++) 2072 for (int i = 0; i < SIZEOFFREE; i++)
2308 {
2309 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i])) 2073 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]))
2310 return i; 2074 return i;
2311 } 2075
2312 return -1; 2076 return -1;
2313} 2077}
2314 2078
2315/* 2079/*
2316 * The function permute(arr, begin, end) randomly reorders the array 2080 * The function permute(arr, begin, end) randomly reorders the array
2317 * arr[begin..end-1]. 2081 * arr[begin..end-1].
2082 * now uses a fisher-yates shuffle, old permute was broken
2318 */ 2083 */
2319static void 2084static void
2320permute (int *arr, int begin, int end) 2085permute (int *arr, int begin, int end)
2321{ 2086{
2322 int 2087 arr += begin;
2323 i,
2324 j,
2325 tmp,
2326 len;
2327
2328 len = end - begin; 2088 end -= begin;
2329 for (i = begin; i < end; i++)
2330 {
2331 j = begin + RANDOM () % len;
2332 2089
2333 tmp = arr[i]; 2090 while (--end)
2334 arr[i] = arr[j]; 2091 swap (arr [end], arr [rndm (end + 1)]);
2335 arr[j] = tmp;
2336 }
2337} 2092}
2338 2093
2339/* new function to make monster searching more efficient, and effective! 2094/* new function to make monster searching more efficient, and effective!
2340 * This basically returns a randomized array (in the passed pointer) of 2095 * This basically returns a randomized array (in the passed pointer) of
2341 * the spaces to find monsters. In this way, it won't always look for 2096 * the spaces to find monsters. In this way, it won't always look for
2344 * the 3x3 area will be searched, just not in a predictable order. 2099 * the 3x3 area will be searched, just not in a predictable order.
2345 */ 2100 */
2346void 2101void
2347get_search_arr (int *search_arr) 2102get_search_arr (int *search_arr)
2348{ 2103{
2349 int 2104 int i;
2350 i;
2351 2105
2352 for (i = 0; i < SIZEOFFREE; i++) 2106 for (i = 0; i < SIZEOFFREE; i++)
2353 {
2354 search_arr[i] = i; 2107 search_arr[i] = i;
2355 }
2356 2108
2357 permute (search_arr, 1, SIZEOFFREE1 + 1); 2109 permute (search_arr, 1, SIZEOFFREE1 + 1);
2358 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1); 2110 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1);
2359 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE); 2111 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE);
2360} 2112}
2369 * Perhaps incorrectly, but I'm making the assumption that exclude 2121 * Perhaps incorrectly, but I'm making the assumption that exclude
2370 * is actually want is going to try and move there. We need this info 2122 * is actually want is going to try and move there. We need this info
2371 * because we have to know what movement the thing looking to move 2123 * because we have to know what movement the thing looking to move
2372 * there is capable of. 2124 * there is capable of.
2373 */ 2125 */
2374
2375int 2126int
2376find_dir (mapstruct *m, int x, int y, object *exclude) 2127find_dir (maptile *m, int x, int y, object *exclude)
2377{ 2128{
2378 int
2379 i,
2380 max = SIZEOFFREE, mflags; 2129 int i, max = SIZEOFFREE, mflags;
2381 2130
2382 sint16 nx, ny; 2131 sint16 nx, ny;
2383 object * 2132 object *tmp;
2384 tmp; 2133 maptile *mp;
2385 mapstruct *
2386 mp;
2387 2134
2388 MoveType blocked, move_type; 2135 MoveType blocked, move_type;
2389 2136
2390 if (exclude && exclude->head) 2137 if (exclude && exclude->head)
2391 { 2138 {
2403 mp = m; 2150 mp = m;
2404 nx = x + freearr_x[i]; 2151 nx = x + freearr_x[i];
2405 ny = y + freearr_y[i]; 2152 ny = y + freearr_y[i];
2406 2153
2407 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2154 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);
2155
2408 if (mflags & P_OUT_OF_MAP) 2156 if (mflags & P_OUT_OF_MAP)
2409 {
2410 max = maxfree[i]; 2157 max = maxfree[i];
2411 }
2412 else 2158 else
2413 { 2159 {
2414 blocked = GET_MAP_MOVE_BLOCK (mp, nx, ny); 2160 mapspace &ms = mp->at (nx, ny);
2161
2162 blocked = ms.move_block;
2415 2163
2416 if ((move_type & blocked) == move_type) 2164 if ((move_type & blocked) == move_type)
2417 {
2418 max = maxfree[i]; 2165 max = maxfree[i];
2419 }
2420 else if (mflags & P_IS_ALIVE) 2166 else if (mflags & P_IS_ALIVE)
2421 { 2167 {
2422 for (tmp = GET_MAP_OB (mp, nx, ny); tmp != NULL; tmp = tmp->above) 2168 for (tmp = ms.bot; tmp; tmp = tmp->above)
2423 { 2169 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)
2424 if ((QUERY_FLAG (tmp, FLAG_MONSTER) || tmp->type == PLAYER) && (tmp != exclude || (tmp->head && tmp->head != exclude))) 2170 && (tmp != exclude || (tmp->head && tmp->head != exclude)))
2425 {
2426 break; 2171 break;
2427 } 2172
2428 }
2429 if (tmp) 2173 if (tmp)
2430 {
2431 return freedir[i]; 2174 return freedir[i];
2432 }
2433 } 2175 }
2434 } 2176 }
2435 } 2177 }
2178
2436 return 0; 2179 return 0;
2437} 2180}
2438 2181
2439/* 2182/*
2440 * distance(object 1, object 2) will return the square of the 2183 * distance(object 1, object 2) will return the square of the
2441 * distance between the two given objects. 2184 * distance between the two given objects.
2442 */ 2185 */
2443
2444int 2186int
2445distance (const object *ob1, const object *ob2) 2187distance (const object *ob1, const object *ob2)
2446{ 2188{
2447 int
2448 i;
2449
2450 i = (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y); 2189 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2451 return i;
2452} 2190}
2453 2191
2454/* 2192/*
2455 * find_dir_2(delta-x,delta-y) will return a direction in which 2193 * find_dir_2(delta-x,delta-y) will return a direction in which
2456 * an object which has subtracted the x and y coordinates of another 2194 * an object which has subtracted the x and y coordinates of another
2457 * object, needs to travel toward it. 2195 * object, needs to travel toward it.
2458 */ 2196 */
2459
2460int 2197int
2461find_dir_2 (int x, int y) 2198find_dir_2 (int x, int y)
2462{ 2199{
2463 int 2200 int q;
2464 q;
2465 2201
2466 if (y) 2202 if (y)
2467 q = x * 100 / y; 2203 q = x * 100 / y;
2468 else if (x) 2204 else if (x)
2469 q = -300 * x; 2205 q = -300 * x;
2494 2230
2495 return 3; 2231 return 3;
2496} 2232}
2497 2233
2498/* 2234/*
2499 * absdir(int): Returns a number between 1 and 8, which represent
2500 * the "absolute" direction of a number (it actually takes care of
2501 * "overflow" in previous calculations of a direction).
2502 */
2503
2504int
2505absdir (int d)
2506{
2507 while (d < 1)
2508 d += 8;
2509 while (d > 8)
2510 d -= 8;
2511 return d;
2512}
2513
2514/*
2515 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is 2235 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is
2516 * between two directions (which are expected to be absolute (see absdir()) 2236 * between two directions (which are expected to be absolute (see absdir())
2517 */ 2237 */
2518
2519int 2238int
2520dirdiff (int dir1, int dir2) 2239dirdiff (int dir1, int dir2)
2521{ 2240{
2522 int 2241 int d;
2523 d;
2524 2242
2525 d = abs (dir1 - dir2); 2243 d = abs (dir1 - dir2);
2526 if (d > 4) 2244 if (d > 4)
2527 d = 8 - d; 2245 d = 8 - d;
2246
2528 return d; 2247 return d;
2529} 2248}
2530 2249
2531/* peterm: 2250/* peterm:
2532 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster. 2251 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster.
2535 * This basically means that if direction is 15, then it could either go 2254 * This basically means that if direction is 15, then it could either go
2536 * direction 4, 14, or 16 to get back to where we are. 2255 * direction 4, 14, or 16 to get back to where we are.
2537 * Moved from spell_util.c to object.c with the other related direction 2256 * Moved from spell_util.c to object.c with the other related direction
2538 * functions. 2257 * functions.
2539 */ 2258 */
2540
2541int
2542 reduction_dir[SIZEOFFREE][3] = { 2259int reduction_dir[SIZEOFFREE][3] = {
2543 {0, 0, 0}, /* 0 */ 2260 {0, 0, 0}, /* 0 */
2544 {0, 0, 0}, /* 1 */ 2261 {0, 0, 0}, /* 1 */
2545 {0, 0, 0}, /* 2 */ 2262 {0, 0, 0}, /* 2 */
2546 {0, 0, 0}, /* 3 */ 2263 {0, 0, 0}, /* 3 */
2547 {0, 0, 0}, /* 4 */ 2264 {0, 0, 0}, /* 4 */
2595 * find a path to that monster that we found. If not, 2312 * find a path to that monster that we found. If not,
2596 * we don't bother going toward it. Returns 1 if we 2313 * we don't bother going toward it. Returns 1 if we
2597 * can see a direct way to get it 2314 * can see a direct way to get it
2598 * Modified to be map tile aware -.MSW 2315 * Modified to be map tile aware -.MSW
2599 */ 2316 */
2600
2601
2602int 2317int
2603can_see_monsterP (mapstruct *m, int x, int y, int dir) 2318can_see_monsterP (maptile *m, int x, int y, int dir)
2604{ 2319{
2605 sint16 dx, dy; 2320 sint16 dx, dy;
2606 int
2607 mflags; 2321 int mflags;
2608 2322
2609 if (dir < 0) 2323 if (dir < 0)
2610 return 0; /* exit condition: invalid direction */ 2324 return 0; /* exit condition: invalid direction */
2611 2325
2612 dx = x + freearr_x[dir]; 2326 dx = x + freearr_x[dir];
2625 return 0; 2339 return 0;
2626 2340
2627 /* yes, can see. */ 2341 /* yes, can see. */
2628 if (dir < 9) 2342 if (dir < 9)
2629 return 1; 2343 return 1;
2344
2630 return can_see_monsterP (m, x, y, reduction_dir[dir][0]) | 2345 return can_see_monsterP (m, x, y, reduction_dir[dir][0])
2631 can_see_monsterP (m, x, y, reduction_dir[dir][1]) | can_see_monsterP (m, x, y, reduction_dir[dir][2]); 2346 | can_see_monsterP (m, x, y, reduction_dir[dir][1])
2347 | can_see_monsterP (m, x, y, reduction_dir[dir][2]);
2632} 2348}
2633
2634
2635 2349
2636/* 2350/*
2637 * can_pick(picker, item): finds out if an object is possible to be 2351 * can_pick(picker, item): finds out if an object is possible to be
2638 * picked up by the picker. Returnes 1 if it can be 2352 * picked up by the picker. Returnes 1 if it can be
2639 * picked up, otherwise 0. 2353 * picked up, otherwise 0.
2650 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2364 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2651 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2365 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2652 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2366 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));
2653} 2367}
2654 2368
2655
2656/* 2369/*
2657 * create clone from object to another 2370 * create clone from object to another
2658 */ 2371 */
2659object * 2372object *
2660object_create_clone (object *asrc) 2373object_create_clone (object *asrc)
2661{ 2374{
2662 object *
2663 dst = NULL, *tmp, *src, *part, *prev, *item; 2375 object *dst = 0, *tmp, *src, *part, *prev, *item;
2664 2376
2665 if (!asrc) 2377 if (!asrc)
2666 return NULL; 2378 return 0;
2379
2667 src = asrc; 2380 src = asrc;
2668 if (src->head) 2381 if (src->head)
2669 src = src->head; 2382 src = src->head;
2670 2383
2671 prev = NULL; 2384 prev = 0;
2672 for (part = src; part; part = part->more) 2385 for (part = src; part; part = part->more)
2673 { 2386 {
2674 tmp = get_object (); 2387 tmp = part->clone ();
2675 copy_object (part, tmp);
2676 tmp->x -= src->x; 2388 tmp->x -= src->x;
2677 tmp->y -= src->y; 2389 tmp->y -= src->y;
2390
2678 if (!part->head) 2391 if (!part->head)
2679 { 2392 {
2680 dst = tmp; 2393 dst = tmp;
2681 tmp->head = NULL; 2394 tmp->head = 0;
2682 } 2395 }
2683 else 2396 else
2684 {
2685 tmp->head = dst; 2397 tmp->head = dst;
2686 } 2398
2687 tmp->more = NULL; 2399 tmp->more = 0;
2400
2688 if (prev) 2401 if (prev)
2689 prev->more = tmp; 2402 prev->more = tmp;
2403
2690 prev = tmp; 2404 prev = tmp;
2691 } 2405 }
2692 2406
2693 /*** copy inventory ***/
2694 for (item = src->inv; item; item = item->below) 2407 for (item = src->inv; item; item = item->below)
2695 {
2696 (void) insert_ob_in_ob (object_create_clone (item), dst); 2408 insert_ob_in_ob (object_create_clone (item), dst);
2697 }
2698 2409
2699 return dst; 2410 return dst;
2700}
2701
2702/* return true if the object was destroyed, 0 otherwise */
2703int
2704was_destroyed (const object *op, tag_t old_tag)
2705{
2706 /* checking for FLAG_FREED isn't necessary, but makes this function more
2707 * robust */
2708 return op->count != old_tag || QUERY_FLAG (op, FLAG_FREED);
2709}
2710
2711/* GROS - Creates an object using a string representing its content. */
2712
2713/* Basically, we save the content of the string to a temp file, then call */
2714
2715/* load_object on it. I admit it is a highly inefficient way to make things, */
2716
2717/* but it was simple to make and allows reusing the load_object function. */
2718
2719/* Remember not to use load_object_str in a time-critical situation. */
2720
2721/* Also remember that multiparts objects are not supported for now. */
2722
2723object *
2724load_object_str (const char *obstr)
2725{
2726 object *
2727 op;
2728 char
2729 filename[MAX_BUF];
2730
2731 sprintf (filename, "%s/cfloadobstr2044", settings.tmpdir);
2732
2733 FILE *
2734 tempfile = fopen (filename, "w");
2735
2736 if (tempfile == NULL)
2737 {
2738 LOG (llevError, "Error - Unable to access load object temp file\n");
2739 return NULL;
2740 };
2741 fprintf (tempfile, obstr);
2742 fclose (tempfile);
2743
2744 op = get_object ();
2745
2746 object_thawer thawer (filename);
2747
2748 if (thawer)
2749 load_object (thawer, op, 0);
2750
2751 LOG (llevDebug, " load str completed, object=%s\n", &op->name);
2752 CLEAR_FLAG (op, FLAG_REMOVED);
2753
2754 return op;
2755} 2411}
2756 2412
2757/* This returns the first object in who's inventory that 2413/* This returns the first object in who's inventory that
2758 * has the same type and subtype match. 2414 * has the same type and subtype match.
2759 * returns NULL if no match. 2415 * returns NULL if no match.
2760 */ 2416 */
2761object * 2417object *
2762find_obj_by_type_subtype (const object *who, int type, int subtype) 2418find_obj_by_type_subtype (const object *who, int type, int subtype)
2763{ 2419{
2764 object *
2765 tmp;
2766
2767 for (tmp = who->inv; tmp; tmp = tmp->below) 2420 for (object *tmp = who->inv; tmp; tmp = tmp->below)
2768 if (tmp->type == type && tmp->subtype == subtype) 2421 if (tmp->type == type && tmp->subtype == subtype)
2769 return tmp; 2422 return tmp;
2770 2423
2771 return NULL; 2424 return 0;
2772} 2425}
2773 2426
2774/* If ob has a field named key, return the link from the list, 2427/* If ob has a field named key, return the link from the list,
2775 * otherwise return NULL. 2428 * otherwise return NULL.
2776 * 2429 *
2778 * do the desired thing. 2431 * do the desired thing.
2779 */ 2432 */
2780key_value * 2433key_value *
2781get_ob_key_link (const object *ob, const char *key) 2434get_ob_key_link (const object *ob, const char *key)
2782{ 2435{
2783 key_value *
2784 link;
2785
2786 for (link = ob->key_values; link != NULL; link = link->next) 2436 for (key_value *link = ob->key_values; link; link = link->next)
2787 {
2788 if (link->key == key) 2437 if (link->key == key)
2789 {
2790 return link; 2438 return link;
2791 }
2792 }
2793 2439
2794 return NULL; 2440 return 0;
2795} 2441}
2796 2442
2797/* 2443/*
2798 * Returns the value of op has an extra_field for key, or NULL. 2444 * Returns the value of op has an extra_field for key, or NULL.
2799 * 2445 *
2824 if (link->key == canonical_key) 2470 if (link->key == canonical_key)
2825 return link->value; 2471 return link->value;
2826 2472
2827 return 0; 2473 return 0;
2828} 2474}
2829
2830 2475
2831/* 2476/*
2832 * Updates the canonical_key in op to value. 2477 * Updates the canonical_key in op to value.
2833 * 2478 *
2834 * canonical_key is a shared string (value doesn't have to be). 2479 * canonical_key is a shared string (value doesn't have to be).
2839 * Returns TRUE on success. 2484 * Returns TRUE on success.
2840 */ 2485 */
2841int 2486int
2842set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key) 2487set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2843{ 2488{
2844 key_value *
2845 field = NULL, *last = NULL; 2489 key_value *field = NULL, *last = NULL;
2846 2490
2847 for (field = op->key_values; field != NULL; field = field->next) 2491 for (field = op->key_values; field != NULL; field = field->next)
2848 { 2492 {
2849 if (field->key != canonical_key) 2493 if (field->key != canonical_key)
2850 { 2494 {
2878 /* IF we get here, key doesn't exist */ 2522 /* IF we get here, key doesn't exist */
2879 2523
2880 /* No field, we'll have to add it. */ 2524 /* No field, we'll have to add it. */
2881 2525
2882 if (!add_key) 2526 if (!add_key)
2883 {
2884 return FALSE; 2527 return FALSE;
2885 } 2528
2886 /* There isn't any good reason to store a null 2529 /* There isn't any good reason to store a null
2887 * value in the key/value list. If the archetype has 2530 * value in the key/value list. If the archetype has
2888 * this key, then we should also have it, so shouldn't 2531 * this key, then we should also have it, so shouldn't
2889 * be here. If user wants to store empty strings, 2532 * be here. If user wants to store empty strings,
2890 * should pass in "" 2533 * should pass in ""
2939 } 2582 }
2940 else 2583 else
2941 item = item->env; 2584 item = item->env;
2942} 2585}
2943 2586
2587
2588const char *
2589object::flag_desc (char *desc, int len) const
2590{
2591 char *p = desc;
2592 bool first = true;
2593
2594 *p = 0;
2595
2596 for (int i = 0; i < NUM_FLAGS; i++)
2597 {
2598 if (len <= 10) // magic constant!
2599 {
2600 snprintf (p, len, ",...");
2601 break;
2602 }
2603
2604 if (flag [i])
2605 {
2606 int cnt = snprintf (p, len, "%s%d", first ? "" : ",", i);
2607 len -= cnt;
2608 p += cnt;
2609 first = false;
2610 }
2611 }
2612
2613 return desc;
2614}
2615
2944// return a suitable string describing an objetc in enough detail to find it 2616// return a suitable string describing an object in enough detail to find it
2945const char * 2617const char *
2946object::debug_desc (char *info) const 2618object::debug_desc (char *info) const
2947{ 2619{
2620 char flagdesc[512];
2948 char info2[256 * 3]; 2621 char info2[256 * 4];
2949 char *p = info; 2622 char *p = info;
2950 2623
2951 p += snprintf (p, 256, "%d=\"%s%s%s\"", 2624 p += snprintf (p, 512, "{cnt:%d,uuid:<1.%" PRIx64 ">,name:\"%s\"%s%s,flags:[%s],type:%d}",
2952 count, 2625 count, uuid.seq,
2953 &name, 2626 &name,
2954 title ? " " : "", 2627 title ? "\",title:\"" : "",
2955 title ? (const char *)title : ""); 2628 title ? (const char *)title : "",
2629 flag_desc (flagdesc, 512), type);
2956 2630
2957 if (env) 2631 if (env)
2958 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2632 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2959 2633
2960 if (map) 2634 if (map)
2961 p += snprintf (p, 256, "(on %s@%d+%d)", map->path, x, y); 2635 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2962 2636
2963 return info; 2637 return info;
2964} 2638}
2965 2639
2966const char * 2640const char *
2967object::debug_desc () const 2641object::debug_desc () const
2968{ 2642{
2969 static char info[256 * 3]; 2643 static char info[3][256 * 4];
2644 static int info_idx;
2645
2970 return debug_desc (info); 2646 return debug_desc (info [++info_idx % 3]);
2971} 2647}
2972 2648
2649struct region *
2650object::region () const
2651{
2652 return map ? map->region (x, y)
2653 : region::default_region ();
2654}
2655
2656const materialtype_t *
2657object::dominant_material () const
2658{
2659 if (materialtype_t *mat = name_to_material (materialname))
2660 return mat;
2661
2662 // omfg this is slow, this has to be temporary :)
2663 shstr unknown ("unknown");
2664
2665 return name_to_material (unknown);
2666}
2667
2668void
2669object::open_container (object *new_container)
2670{
2671 if (container == new_container)
2672 return;
2673
2674 if (object *old_container = container)
2675 {
2676 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))
2677 return;
2678
2679#if 0
2680 // remove the "Close old_container" object.
2681 if (object *closer = old_container->inv)
2682 if (closer->type == CLOSE_CON)
2683 closer->destroy ();
2684#endif
2685
2686 old_container->flag [FLAG_APPLIED] = 0;
2687 container = 0;
2688
2689 esrv_update_item (UPD_FLAGS, this, old_container);
2690 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container));
2691 }
2692
2693 if (new_container)
2694 {
2695 if (INVOKE_OBJECT (OPEN, new_container, ARG_OBJECT (this)))
2696 return;
2697
2698 // TODO: this does not seem to serve any purpose anymore?
2699#if 0
2700 // insert the "Close Container" object.
2701 if (archetype *closer = new_container->other_arch)
2702 {
2703 object *closer = arch_to_object (new_container->other_arch);
2704 closer->flag [FLAG_NO_MAP_SAVE] = 1;
2705 new_container->insert (closer);
2706 }
2707#endif
2708
2709 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container));
2710
2711 new_container->flag [FLAG_APPLIED] = 1;
2712 container = new_container;
2713
2714 esrv_update_item (UPD_FLAGS, this, new_container);
2715 esrv_send_inventory (this, new_container);
2716 }
2717}
2718
2719

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines