ViewVC Help

View File | Revision Log | Show Annotations | Download File

/cvs/deliantra/server/common/object.C

Comparing deliantra/server/common/object.C (file contents):
Revision 1.164 by root, Thu Jul 5 08:10:29 2007 UTC vs.
Revision 1.283 by root, Sat Feb 21 06:25:46 2009 UTC

1	/*	1	/*
2	* This file is part of Crossfire TRT, the Roguelike Realtime MORPG.	2	* This file is part of Deliantra, the Roguelike Realtime MMORPG.
3	*	3	*
4	* Copyright (©) 2005,2006,2007 Marc Alexander Lehmann / Robin Redeker / the Crossfire TRT team	4	* Copyright (©) 2005,2006,2007,2008,2009 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5	* Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team	5	* Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team
6	* Copyright (©) 1992,2007 Frank Tore Johansen	6	* Copyright (©) 1992,2007 Frank Tore Johansen
7	*	7	*
8	* Crossfire TRT is free software: you can redistribute it and/or modify	8	* Deliantra is free software: you can redistribute it and/or modify
9	* it under the terms of the GNU General Public License as published by	9	* it under the terms of the GNU General Public License as published by
10	* the Free Software Foundation, either version 3 of the License, or	10	* the Free Software Foundation, either version 3 of the License, or
11	* (at your option) any later version.	11	* (at your option) any later version.
12	*	12	*
13	* This program is distributed in the hope that it will be useful,	13	* This program is distributed in the hope that it will be useful,
…		…
16	* GNU General Public License for more details.	16	* GNU General Public License for more details.
17	*	17	*
18	* You should have received a copy of the GNU General Public License	18	* You should have received a copy of the GNU General Public License
19	* along with this program. If not, see <http://www.gnu.org/licenses/>.	19	* along with this program. If not, see <http://www.gnu.org/licenses/>.
20	*	20	*
21	* The authors can be reached via e-mail to <crossfire@schmorp.de>	21	* The authors can be reached via e-mail to <support@deliantra.net>
22	*/	22	*/
23		23
24	/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
25	sub/add_weight will transcend the environment updating the carrying
26	variable. */
27	#include <global.h>	24	#include <global.h>
28	#include <stdio.h>	25	#include <stdio.h>
29	#include <sys/types.h>	26	#include <sys/types.h>
30	#include <sys/uio.h>	27	#include <sys/uio.h>
31	#include <object.h>	28	#include <object.h>
32	#include <funcpoint.h>
33	#include <sproto.h>	29	#include <sproto.h>
34	#include <loader.h>	30	#include <loader.h>
35		31
36	#include <bitset>	32	#include <bitset>
37		33
38	int nrofallocobjects = 0;	34	UUID UUID::cur;
39	static UUID uuid;	35	static uint64_t seq_next_save;
40	const uint64 UUID_SKIP = 1<<19;	36	static const uint64 UUID_GAP = 1<<19;
		37	uint32_t mapspace::smellcount = 10000;
41		38
42	objectvec objects;	39	objectvec objects;
43	activevec actives;	40	activevec actives;
44		41
45	short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,	42	short freearr_x[SIZEOFFREE] = {
		43	0,
		44	0, 1, 1, 1, 0, -1, -1, -1,
		45	0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
46	0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1	46	0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1
47	};	47	};
48	short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,	48	short freearr_y[SIZEOFFREE] = {
		49	0,
		50	-1, -1, 0, 1, 1, 1, 0, -1,
		51	-2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
49	-3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3	52	-3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3
50	};	53	};
51	int maxfree[SIZEOFFREE] = { 0, 9, 10, 13, 14, 17, 18, 21, 22, 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45,	54	int maxfree[SIZEOFFREE] = {
		55	0,
		56	9, 10, 13, 14, 17, 18, 21, 22,
		57	25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
52	48, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49	58	49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
53	};	59	};
54	int freedir[SIZEOFFREE] = {	60	int freedir[SIZEOFFREE] = {
55	0, 1, 2, 3, 4, 5, 6, 7, 8, 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,	61	0,
		62	1, 2, 3, 4, 5, 6, 7, 8,
		63	1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,
56	1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8	64	1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8
57	};	65	};
58		66
59	static void	67	static void
60	write_uuid (void)	68	write_uuid (uval64 skip, bool sync)
61	{	69	{
62	char filename1[MAX_BUF], filename2[MAX_BUF];	70	CALL_BEGIN (2);
63		71	CALL_ARG_SV (newSVval64 (skip));
64	sprintf (filename1, "%s/uuid", settings.localdir);	72	CALL_ARG_SV (boolSV (sync));
65	sprintf (filename2, "%s/uuid~", settings.localdir);	73	CALL_CALL ("cf::write_uuid", G_DISCARD);
66		74	CALL_END;
67	FILE *fp;
68
69	if (!(fp = fopen (filename2, "w")))
70	{
71	LOG (llevError, "ERROR: cannot open %s for writing, unable to write UUID!\n", filename2);
72	return;
73	}
74
75	fprintf (fp, "<1,%llx>\n", (unsigned long long)uuid.seq + UUID_SKIP * 2);
76	fclose (fp);
77	rename (filename2, filename1);
78	}	75	}
79		76
80	static void	77	static void
81	read_uuid (void)	78	read_uuid (void)
82	{	79	{
83	char filename[MAX_BUF];	80	char filename[MAX_BUF];
84		81
85	sprintf (filename, "%s/uuid", settings.localdir);	82	sprintf (filename, "%s/uuid", settings.localdir);
		83
		84	seq_next_save = 0;
86		85
87	FILE *fp;	86	FILE *fp;
88		87
89	if (!(fp = fopen (filename, "r")))	88	if (!(fp = fopen (filename, "r")))
90	{	89	{
91	if (errno == ENOENT)	90	if (errno == ENOENT)
92	{	91	{
93	LOG (llevInfo, "RESET uid to 1\n");	92	LOG (llevInfo, "RESET uid to 1\n");
94	uuid.seq = 0;	93	UUID::cur.seq = 0;
95	write_uuid ();	94	write_uuid (UUID_GAP, true);
96	return;	95	return;
97	}	96	}
98		97
99	LOG (llevError, "FATAL: cannot open %s for reading!\n", filename);	98	LOG (llevError, "FATAL: cannot open %s for reading!\n", filename);
100	_exit (1);	99	_exit (1);
101	}	100	}
102		101
103	int version;	102	UUID::BUF buf;
104	unsigned long long uid;	103	buf[0] = 0;
105	if (2 != fscanf (fp, "<%d,%llx>\n", &version, &uid) || version != 1)	104	fgets (buf, sizeof (buf), fp);
		105
		106	if (!UUID::cur.parse (buf))
106	{	107	{
107	LOG (llevError, "FATAL: error reading uid from %s!\n", filename);	108	LOG (llevError, "FATAL: error reading uid from %s (%s)!\n", filename, buf);
108	_exit (1);	109	_exit (1);
109	}	110	}
110		111
111	uuid.seq = uid;	112	LOG (llevDebug, "read UUID: %s\n", UUID::cur.c_str ());
112	write_uuid ();	113
113	LOG (llevDebug, "read UID: %" PRId64 "\n", uid);	114	write_uuid (UUID_GAP, true);
114	fclose (fp);	115	fclose (fp);
115	}	116	}
116		117
117	UUID	118	UUID
118	gen_uuid ()	119	UUID::gen ()
119	{	120	{
120	UUID uid;	121	UUID uid;
121		122
122	uid.seq = ++uuid.seq;	123	uid.seq = ++cur.seq;
123		124
124	if (!(uuid.seq & (UUID_SKIP - 1)))	125	if (expect_false (cur.seq >= seq_next_save))
125	write_uuid ();	126	{
		127	seq_next_save = UUID::cur.seq + (UUID_GAP >> 1);
		128	write_uuid (UUID_GAP, false);
		129	}
		130
126		131
127	return uid;	132	return uid;
128	}	133	}
129		134
130	void	135	void
131	init_uuid ()	136	UUID::init ()
132	{	137	{
133	read_uuid ();	138	read_uuid ();
134	}	139	}
135		140
136	/* Returns TRUE if every key_values in wants has a partner with the same value in has. */	141	/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
137	static int	142	static bool
138	compare_ob_value_lists_one (const object *wants, const object *has)	143	compare_ob_value_lists_one (const object *wants, const object *has)
139	{	144	{
140	key_value *wants_field;
141
142	/* n-squared behaviour (see get_ob_key_link()), but I'm hoping both	145	/* n-squared behaviour (see kv_get), but I'm hoping both
143	* objects with lists are rare, and lists stay short. If not, use a	146	* objects with lists are rare, and lists stay short. If not, use a
144	* different structure or at least keep the lists sorted...	147	* different structure or at least keep the lists sorted...
145	*/	148	*/
146		149
147	/* For each field in wants, */	150	/* For each field in wants, */
148	for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)	151	for (key_value *kv = wants->key_values; kv; kv = kv->next)
149	{	152	if (has->kv_get (kv->key) != kv->value)
150	key_value *has_field;	153	return false;
151
152	/* Look for a field in has with the same key. */
153	has_field = get_ob_key_link (has, wants_field->key);
154
155	if (has_field == NULL)
156	{
157	/* No field with that name. */
158	return FALSE;
159	}
160
161	/* Found the matching field. */
162	if (has_field->value != wants_field->value)
163	{
164	/* Values don't match, so this half of the comparison is false. */
165	return FALSE;
166	}
167
168	/* If we get here, we found a match. Now for the next field in wants. */
169	}
170		154
171	/* If we get here, every field in wants has a matching field in has. */	155	/* If we get here, every field in wants has a matching field in has. */
172	return TRUE;	156	return true;
173	}	157	}
174		158
175	/* Returns TRUE if ob1 has the same key_values as ob2. */	159	/* Returns TRUE if ob1 has the same key_values as ob2. */
176	static int	160	static bool
177	compare_ob_value_lists (const object *ob1, const object *ob2)	161	compare_ob_value_lists (const object *ob1, const object *ob2)
178	{	162	{
179	/* However, there may be fields in has which aren't partnered in wants,	163	/* However, there may be fields in has which aren't partnered in wants,
180	* so we need to run the comparison *twice*. :(	164	* so we need to run the comparison *twice*. :(
181	*/	165	*/
182	return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1);	166	return compare_ob_value_lists_one (ob1, ob2)
		167	&& compare_ob_value_lists_one (ob2, ob1);
183	}	168	}
184		169
185	/* Function examines the 2 objects given to it, and returns true if	170	/* Function examines the 2 objects given to it, and returns true if
186	* they can be merged together.	171	* they can be merged together.
187	*	172	*
…		…
202	|| ob1->speed != ob2->speed	187	|| ob1->speed != ob2->speed
203	|| ob1->value != ob2->value	188	|| ob1->value != ob2->value
204	|| ob1->name != ob2->name)	189	|| ob1->name != ob2->name)
205	return 0;	190	return 0;
206		191
207	//TODO: this ain't working well, use nicer and correct overflow check
208	/* Do not merge objects if nrof would overflow. We use 1UL<<31 since that	192	/* Do not merge objects if nrof would overflow, assume nrof
209	* value could not be stored in a sint32 (which unfortunately sometimes is	193	* is always 0 .. 2**31-1 */
210	* used to store nrof).	194	if (ob1->nrof > 0x7fffffff - ob2->nrof)
211	*/
212	if (ob1->nrof + ob2->nrof >= 1UL << 31)
213	return 0;	195	return 0;
214		196
215	/* If the objects have been identified, set the BEEN_APPLIED flag.	197	/* If the objects have been identified, set the BEEN_APPLIED flag.
216	* This is to the comparison of the flags below will be OK. We	198	* This is to the comparison of the flags below will be OK. We
217	* just can't ignore the been applied or identified flags, as they	199	* just can't ignore the been applied or identified flags, as they
218	* are not equal - just if it has been identified, the been_applied	200	* are not equal - just if it has been identified, the been_applied
219	* flags lose any meaning.	201	* flags lose any meaning.
220	*/	202	*/
221	if (QUERY_FLAG (ob1, FLAG_IDENTIFIED))	203	if (QUERY_FLAG (ob1, FLAG_IDENTIFIED))
222	SET_FLAG (ob1, FLAG_BEEN_APPLIED);	204	SET_FLAG (ob1, FLAG_BEEN_APPLIED);
223		205
224	if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))	206	if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
225	SET_FLAG (ob2, FLAG_BEEN_APPLIED);	207	SET_FLAG (ob2, FLAG_BEEN_APPLIED);
226		208
227	if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any ()	209	if (ob1->arch->archname != ob2->arch->archname
228	|| ob1->arch != ob2->arch
229	|| ob1->name != ob2->name	210	|| ob1->name != ob2->name
230	|| ob1->title != ob2->title	211	|| ob1->title != ob2->title
231	|| ob1->msg != ob2->msg	212	|| ob1->msg != ob2->msg
232	|| ob1->weight != ob2->weight	213	|| ob1->weight != ob2->weight
233	|| memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
234	|| memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
235	|| ob1->attacktype != ob2->attacktype	214	|| ob1->attacktype != ob2->attacktype
236	|| ob1->magic != ob2->magic	215	|| ob1->magic != ob2->magic
237	|| ob1->slaying != ob2->slaying	216	|| ob1->slaying != ob2->slaying
238	|| ob1->skill != ob2->skill	217	|| ob1->skill != ob2->skill
239	|| ob1->value != ob2->value	218	|| ob1->value != ob2->value
240	|| ob1->animation_id != ob2->animation_id	219	|| ob1->animation_id != ob2->animation_id
		220	|| (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependent on each other
241	|| ob1->client_type != ob2->client_type	221	|| ob1->client_type != ob2->client_type
242	|| ob1->materialname != ob2->materialname	222	|| ob1->materialname != ob2->materialname
243	|| ob1->lore != ob2->lore	223	|| ob1->lore != ob2->lore
244	|| ob1->subtype != ob2->subtype	224	|| ob1->subtype != ob2->subtype
245	|| ob1->move_type != ob2->move_type	225	|| ob1->move_type != ob2->move_type
246	|| ob1->move_block != ob2->move_block	226	|| ob1->move_block != ob2->move_block
247	|| ob1->move_allow != ob2->move_allow	227	|| ob1->move_allow != ob2->move_allow
248	|| ob1->move_on != ob2->move_on	228	|| ob1->move_on != ob2->move_on
249	|| ob1->move_off != ob2->move_off	229	|| ob1->move_off != ob2->move_off
250	|| ob1->move_slow != ob2->move_slow	230	|| ob1->move_slow != ob2->move_slow
251	|| ob1->move_slow_penalty != ob2->move_slow_penalty)	231	|| ob1->move_slow_penalty != ob2->move_slow_penalty
		232	|| memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
		233	|| memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
252	return 0;	234	return 0;
253		235
		236	if ((ob1->flag ^ ob2->flag)
		237	.reset (FLAG_INV_LOCKED)
		238	.reset (FLAG_REMOVED)
		239	.any ())
		240	return 0;
		241
254	/* This is really a spellbook check - really, we should	242	/* This is really a spellbook check - we should in general
255	* check all objects in the inventory.	243	* not merge objects with real inventories, as splitting them
		244	* is hard.
256	*/	245	*/
257	if (ob1->inv || ob2->inv)	246	if (ob1->inv || ob2->inv)
258	{	247	{
259	/* if one object has inventory but the other doesn't, not equiv */	248	if (!(ob1->inv && ob2->inv))
260	if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv))	249	return 0; /* inventories differ in length */
261	return 0;
262		250
263	/* Now check to see if the two inventory objects could merge */	251	if (ob1->inv->below || ob2->inv->below)
		252	return 0; /* more than one object in inv */
		253
264	if (!object::can_merge (ob1->inv, ob2->inv))	254	if (!object::can_merge (ob1->inv, ob2->inv))
265	return 0;	255	return 0; /* inventory objects differ */
266		256
267	/* inventory ok - still need to check rest of this object to see	257	/* inventory ok - still need to check rest of this object to see
268	* if it is valid.	258	* if it is valid.
269	*/	259	*/
270	}	260	}
…		…
289	if (ob1->level != ob2->level)	279	if (ob1->level != ob2->level)
290	return 0;	280	return 0;
291	break;	281	break;
292	}	282	}
293		283
294	if (ob1->key_values != NULL || ob2->key_values != NULL)	284	if (ob1->key_values || ob2->key_values)
295	{	285	{
296	/* At least one of these has key_values. */	286	/* At least one of these has key_values. */
297	if ((ob1->key_values == NULL) != (ob2->key_values == NULL))	287	if ((!ob1->key_values) != (!ob2->key_values))
298	/* One has fields, but the other one doesn't. */	288	return 0; /* One has fields, but the other one doesn't. */
		289
		290	if (!compare_ob_value_lists (ob1, ob2))
299	return 0;	291	return 0;
300	else if (!compare_ob_value_lists (ob1, ob2))
301	return 0;
302	}	292	}
303		293
304	//TODO: generate an event or call into perl for additional checks
305	if (ob1->self || ob2->self)	294	if (ob1->self || ob2->self)
306	{	295	{
307	ob1->optimise ();	296	ob1->optimise ();
308	ob2->optimise ();	297	ob2->optimise ();
309		298
310	if (ob1->self || ob2->self)	299	if (ob1->self || ob2->self)
		300	{
		301	int k1 = ob1->self ? HvTOTALKEYS (ob1->self) : 0;
		302	int k2 = ob2->self ? HvTOTALKEYS (ob2->self) : 0;
		303
		304	if (k1 != k2)
311	return 0;	305	return 0;
		306
		307	if (k1 == 0)
		308	return 1;
		309
		310	if (!cfperl_can_merge (ob1, ob2))
		311	return 0;
		312	}
312	}	313	}
313		314
314	/* Everything passes, must be OK. */	315	/* Everything passes, must be OK. */
315	return 1;	316	return 1;
316	}	317	}
317		318
		319	// find player who can see this object
		320	object *
		321	object::visible_to () const
		322	{
		323	if (client_visible () && !flag [FLAG_REMOVED])
		324	{
		325	// see if we are in a container of sorts
		326	if (env)
		327	{
		328	// the player inventory itself is always visible
		329	if (env->is_player ())
		330	return env;
		331
		332	// else a player could have our env open
		333	object *envest = env->outer_env ();
		334
		335	// the player itself is always on a map, so we will find him here
		336	// even if our inv is in a player.
		337	if (envest->is_on_map ())
		338	if (object *pl = envest->ms ().player ())
		339	if (pl->container == env)
		340	return pl;
		341	}
		342	else
		343	{
		344	// maybe there is a player standing on the same mapspace
		345	// this will catch the case where "this" is a player
		346	if (object *pl = ms ().player ())
		347	if ((!pl->container && pl->contr->ns && !pl->contr->ns->update_look)
		348	|| this == pl->container)
		349	return pl;
		350	}
		351	}
		352
		353	return 0;
		354	}
		355
		356	// adjust weight per container type ("of holding")
		357	static sint32
		358	weight_adjust_for (object *op, sint32 weight)
		359	{
		360	return op->type == CONTAINER
		361	? lerp (weight, 0, 100, 0, 100 - op->stats.Str)
		362	: weight;
		363	}
		364
318	/*	365	/*
		366	* adjust_weight(object, weight) adds the specified weight to an object,
		367	* and also updates how much the environment(s) is/are carrying.
		368	*/
		369	static void
		370	adjust_weight (object *op, sint32 weight)
		371	{
		372	while (op)
		373	{
		374	// adjust by actual difference to account for rounding errors
		375	// i.e. (w2 - w1) / f != w2 / f - w1 / f and the latter is correct
		376	weight = weight_adjust_for (op, op->carrying)
		377	- weight_adjust_for (op, op->carrying - weight);
		378
		379	if (!weight)
		380	return;
		381
		382	op->carrying += weight;
		383
		384	if (object *pl = op->visible_to ())
		385	if (pl != op) // player is handled lazily
		386	esrv_update_item (UPD_WEIGHT, pl, op);
		387
		388	op = op->env;
		389	}
		390	}
		391
		392	/*
319	* sum_weight() is a recursive function which calculates the weight	393	* this is a recursive function which calculates the weight
320	* an object is carrying. It goes through in figures out how much	394	* an object is carrying. It goes through op and figures out how much
321	* containers are carrying, and sums it up.	395	* containers are carrying, and sums it up.
322	*/	396	*/
323	long	397	void
324	sum_weight (object *op)	398	object::update_weight ()
325	{	399	{
326	long sum;	400	sint32 sum = 0;
327	object *inv;
328		401
329	for (sum = 0, inv = op->inv; inv; inv = inv->below)	402	for (object *op = inv; op; op = op->below)
330	{	403	{
331	if (inv->inv)	404	if (op->inv)
332	sum_weight (inv);	405	op->update_weight ();
333		406
334	sum += inv->carrying + inv->weight * (inv->nrof ? inv->nrof : 1);	407	sum += op->total_weight ();
		408	}
		409
		410	sum = weight_adjust_for (this, sum);
		411
		412	if (sum != carrying)
335	}	413	{
336
337	if (op->type == CONTAINER && op->stats.Str)
338	sum = (sum * (100 - op->stats.Str)) / 100;
339
340	if (op->carrying != sum)
341	op->carrying = sum;	414	carrying = sum;
342		415
343	return sum;	416	if (object *pl = visible_to ())
		417	if (pl != this) // player is handled lazily
		418	esrv_update_item (UPD_WEIGHT, pl, this);
		419	}
344	}	420	}
345		421
346	/**	422	/*
347	* Return the outermost environment object for a given object.	423	* Used by: Server DM commands: dumpbelow, dump. Some error messages.
348	*/
349
350	object *
351	object_get_env_recursive (object *op)
352	{
353	while (op->env != NULL)
354	op = op->env;
355	return op;
356	}
357
358	/*
359	* Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
360	* Some error messages.
361	* The result of the dump is stored in the static global errmsg array.
362	*/	424	*/
363	char *	425	char *
364	dump_object (object *op)	426	dump_object (object *op)
365	{	427	{
366	if (!op)	428	if (!op)
…		…
374	/*	436	/*
375	* get_nearest_part(multi-object, object 2) returns the part of the	437	* get_nearest_part(multi-object, object 2) returns the part of the
376	* multi-object 1 which is closest to the second object.	438	* multi-object 1 which is closest to the second object.
377	* If it's not a multi-object, it is returned.	439	* If it's not a multi-object, it is returned.
378	*/	440	*/
379
380	object *	441	object *
381	get_nearest_part (object *op, const object *pl)	442	get_nearest_part (object *op, const object *pl)
382	{	443	{
383	object *tmp, *closest;	444	object *tmp, *closest;
384	int last_dist, i;	445	int last_dist, i;
385		446
386	if (op->more == NULL)	447	if (!op->more)
387	return op;	448	return op;
		449
388	for (last_dist = distance (op, pl), closest = op, tmp = op->more; tmp != NULL; tmp = tmp->more)	450	for (last_dist = distance (op, pl), closest = op, tmp = op->more;
		451	tmp;
		452	tmp = tmp->more)
389	if ((i = distance (tmp, pl)) < last_dist)	453	if ((i = distance (tmp, pl)) < last_dist)
390	closest = tmp, last_dist = i;	454	closest = tmp, last_dist = i;
		455
391	return closest;	456	return closest;
392	}	457	}
393		458
394	/*	459	/*
395	* Returns the object which has the count-variable equal to the argument.	460	* Returns the object which has the count-variable equal to the argument.
		461	* VERRRY slow.
396	*/	462	*/
397	object *	463	object *
398	find_object (tag_t i)	464	find_object (tag_t i)
399	{	465	{
400	for_all_objects (op)	466	for_all_objects (op)
…		…
411	*/	477	*/
412	object *	478	object *
413	find_object_name (const char *str)	479	find_object_name (const char *str)
414	{	480	{
415	shstr_cmp str_ (str);	481	shstr_cmp str_ (str);
416	object *op;
417		482
		483	if (str_)
418	for_all_objects (op)	484	for_all_objects (op)
419	if (op->name == str_)	485	if (op->name == str_)
420	break;	486	return op;
421		487
422	return op;	488	return 0;
423	}
424
425	void
426	free_all_object_data ()
427	{
428	LOG (llevDebug, "%d allocated objects\n", nrofallocobjects);
429	}	489	}
430		490
431	/*	491	/*
432	* Sets the owner and sets the skill and exp pointers to owner's current	492	* Sets the owner and sets the skill and exp pointers to owner's current
433	* skill and experience objects.	493	* skill and experience objects.
		494	* ACTUALLY NO! investigate! TODO
434	*/	495	*/
435	void	496	void
436	object::set_owner (object *owner)	497	object::set_owner (object *owner)
437	{	498	{
		499	// allow objects which own objects
438	if (!owner)	500	if (owner)
439	return;
440
441	/* next line added to allow objects which own objects */
442	/* Add a check for ownercounts in here, as I got into an endless loop
443	* with the fireball owning a poison cloud which then owned the
444	* fireball. I believe that was caused by one of the objects getting
445	* freed and then another object replacing it. Since the ownercounts
446	* didn't match, this check is valid and I believe that cause is valid.
447	*/
448	while (owner->owner)	501	while (owner->owner)
449	owner = owner->owner;	502	owner = owner->owner;
		503
		504	if (flag [FLAG_FREED])
		505	{
		506	LOG (llevError | logBacktrace, "tried to set owner of %s to %s\n", debug_desc (), owner->debug_desc ());
		507	return;
		508	}
450		509
451	this->owner = owner;	510	this->owner = owner;
452	}	511	}
453		512
454	int	513	int
…		…
532	}	591	}
533		592
534	op->key_values = 0;	593	op->key_values = 0;
535	}	594	}
536		595
537	object &	596	/*
538	object::operator =(const object &src)	597	* copy_to first frees everything allocated by the dst object,
		598	* and then copies the contents of itself into the second
		599	* object, allocating what needs to be allocated. Basically, any
		600	* data that is malloc'd needs to be re-malloc/copied. Otherwise,
		601	* if the first object is freed, the pointers in the new object
		602	* will point at garbage.
		603	*/
		604	void
		605	object::copy_to (object *dst)
539	{	606	{
540	bool is_freed = flag [FLAG_FREED];	607	dst->remove ();
541	bool is_removed = flag [FLAG_REMOVED];
542
543	*(object_copy *)this = src;	608	*(object_copy *)dst = *this;
544
545	flag [FLAG_FREED] = is_freed;
546	flag [FLAG_REMOVED] = is_removed;	609	dst->flag [FLAG_REMOVED] = true;
547		610
548	/* Copy over key_values, if any. */	611	/* Copy over key_values, if any. */
549	if (src.key_values)	612	if (key_values)
550	{	613	{
551	key_value *tail = 0;	614	key_value *tail = 0;
552	key_values = 0;	615	dst->key_values = 0;
553		616
554	for (key_value *i = src.key_values; i; i = i->next)	617	for (key_value *i = key_values; i; i = i->next)
555	{	618	{
556	key_value *new_link = new key_value;	619	key_value *new_link = new key_value;
557		620
558	new_link->next = 0;	621	new_link->next = 0;
559	new_link->key = i->key;	622	new_link->key = i->key;
560	new_link->value = i->value;	623	new_link->value = i->value;
561		624
562	/* Try and be clever here, too. */	625	/* Try and be clever here, too. */
563	if (!key_values)	626	if (!dst->key_values)
564	{	627	{
565	key_values = new_link;	628	dst->key_values = new_link;
566	tail = new_link;	629	tail = new_link;
567	}	630	}
568	else	631	else
569	{	632	{
570	tail->next = new_link;	633	tail->next = new_link;
571	tail = new_link;	634	tail = new_link;
572	}	635	}
573	}	636	}
574	}	637	}
575	}
576
577	/*
578	* copy_to first frees everything allocated by the dst object,
579	* and then copies the contents of itself into the second
580	* object, allocating what needs to be allocated. Basically, any
581	* data that is malloc'd needs to be re-malloc/copied. Otherwise,
582	* if the first object is freed, the pointers in the new object
583	* will point at garbage.
584	*/
585	void
586	object::copy_to (object *dst)
587	{
588	*dst = *this;
589		638
590	if (speed < 0)	639	if (speed < 0)
591	dst->speed_left = speed_left - rndm ();	640	dst->speed_left -= rndm ();
592		641
593	dst->set_speed (dst->speed);	642	dst->activate ();
594	}	643	}
595		644
596	void	645	void
597	object::instantiate ()	646	object::instantiate ()
598	{	647	{
599	if (!uuid.seq) // HACK	648	if (!uuid.seq) // HACK
600	uuid = gen_uuid ();	649	uuid = UUID::gen ();
601		650
602	speed_left = -0.1f;	651	speed_left = -0.1f;
603	/* copy the body_info to the body_used - this is only really	652	/* copy the body_info to the body_used - this is only really
604	* need for monsters, but doesn't hurt to do it for everything.	653	* need for monsters, but doesn't hurt to do it for everything.
605	* by doing so, when a monster is created, it has good starting	654	* by doing so, when a monster is created, it has good starting
…		…
615	object *	664	object *
616	object::clone ()	665	object::clone ()
617	{	666	{
618	object *neu = create ();	667	object *neu = create ();
619	copy_to (neu);	668	copy_to (neu);
		669	neu->map = map; // not copied by copy_to
620	return neu;	670	return neu;
621	}	671	}
622		672
623	/*	673	/*
624	* If an object with the IS_TURNABLE() flag needs to be turned due	674	* If an object with the IS_TURNABLE() flag needs to be turned due
…		…
675	* UP_OBJ_FACE: only the objects face has changed.	725	* UP_OBJ_FACE: only the objects face has changed.
676	*/	726	*/
677	void	727	void
678	update_object (object *op, int action)	728	update_object (object *op, int action)
679	{	729	{
680	if (op == NULL)	730	if (!op)
681	{	731	{
682	/* this should never happen */	732	/* this should never happen */
683	LOG (llevDebug, "update_object() called for NULL object.\n");	733	LOG (llevError | logBacktrace, "update_object() called for NULL object.\n");
684	return;	734	return;
685	}	735	}
686		736
687	if (op->env)	737	if (!op->is_on_map ())
688	{	738	{
689	/* Animation is currently handled by client, so nothing	739	/* Animation is currently handled by client, so nothing
690	* to do in this case.	740	* to do in this case.
691	*/	741	*/
692	return;	742	return;
693	}	743	}
694
695	/* If the map is saving, don't do anything as everything is
696	* going to get freed anyways.
697	*/
698	if (!op->map || op->map->in_memory == MAP_SAVING)
699	return;
700		744
701	/* make sure the object is within map boundaries */	745	/* make sure the object is within map boundaries */
702	if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)	746	if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
703	{	747	{
704	LOG (llevError, "update_object() called for object out of map!\n");	748	LOG (llevError, "update_object() called for object out of map!\n");
…		…
715	else if (action == UP_OBJ_INSERT)	759	else if (action == UP_OBJ_INSERT)
716	{	760	{
717	// this is likely overkill, TODO: revisit (schmorp)	761	// this is likely overkill, TODO: revisit (schmorp)
718	if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))	762	if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
719	|| (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))	763	|| (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
720	|| (op->type == PLAYER && !(m.flags_ & P_PLAYER))	764	|| (op->is_player () && !(m.flags_ & P_PLAYER))
721	|| (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))	765	|| (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
722	|| (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))	766	|| (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
723	|| (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))	767	|| (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
724	|| (m.move_on | op->move_on ) != m.move_on	768	|| (m.move_on | op->move_on ) != m.move_on
725	|| (m.move_off | op->move_off ) != m.move_off	769	|| (m.move_off | op->move_off ) != m.move_off
726	|| (m.move_slow | op->move_slow) != m.move_slow	770	|| (m.move_slow | op->move_slow) != m.move_slow
727	/* This isn't perfect, but I don't expect a lot of objects to	771	/* This isn't perfect, but I don't expect a lot of objects to
728	* to have move_allow right now.	772	* have move_allow right now.
729	*/	773	*/
730	|| ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block	774	|| ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
731	|| 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)	775	|| 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
732	m.flags_ = 0;	776	m.invalidate ();
733	}	777	}
734	/* if the object is being removed, we can't make intelligent	778	/* if the object is being removed, we can't make intelligent
735	* decisions, because remove_ob can't really pass the object	779	* decisions, because remove_ob can't really pass the object
736	* that is being removed.	780	* that is being removed.
737	*/	781	*/
738	else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)	782	else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
739	m.flags_ = 0;	783	m.invalidate ();
740	else if (action == UP_OBJ_FACE)	784	else if (action == UP_OBJ_FACE)
741	/* Nothing to do for that case */ ;	785	/* Nothing to do for that case */ ;
742	else	786	else
743	LOG (llevError, "update_object called with invalid action: %d\n", action);	787	LOG (llevError, "update_object called with invalid action: %d\n", action);
744		788
…		…
764	static int object_count;	808	static int object_count;
765		809
766	void object::link ()	810	void object::link ()
767	{	811	{
768	assert (!index);//D	812	assert (!index);//D
769	uuid = gen_uuid ();	813	uuid = UUID::gen ();
770	count = ++object_count;	814	count = ++object_count;
771		815
772	refcnt_inc ();	816	refcnt_inc ();
773	objects.insert (this);	817	objects.insert (this);
774	}	818	}
…		…
786	object::activate ()	830	object::activate ()
787	{	831	{
788	/* If already on active list, don't do anything */	832	/* If already on active list, don't do anything */
789	if (active)	833	if (active)
790	return;	834	return;
		835
		836	if (has_active_speed () && flag [FLAG_FREED]) LOG (llevError | logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
		837	if (has_active_speed () && flag [FLAG_DEBUG]) LOG (llevError | logBacktrace, "BUG: tried to activate DEBUG object %s\n", debug_desc ());//D temp
791		838
792	if (has_active_speed ())	839	if (has_active_speed ())
793	actives.insert (this);	840	actives.insert (this);
794	}	841	}
795		842
…		…
847	object::destroy_inv (bool drop_to_ground)	894	object::destroy_inv (bool drop_to_ground)
848	{	895	{
849	// need to check first, because the checks below might segfault	896	// need to check first, because the checks below might segfault
850	// as we might be on an invalid mapspace and crossfire code	897	// as we might be on an invalid mapspace and crossfire code
851	// is too buggy to ensure that the inventory is empty.	898	// is too buggy to ensure that the inventory is empty.
852	// corollary: if you create arrows etc. with stuff in tis inventory,	899	// corollary: if you create arrows etc. with stuff in its inventory,
853	// cf will crash below with off-map x and y	900	// cf will crash below with off-map x and y
854	if (!inv)	901	if (!inv)
855	return;	902	return;
856		903
857	/* Only if the space blocks everything do we not process -	904	/* Only if the space blocks everything do we not process -
858	* if some form of movement is allowed, let objects	905	* if some form of movement is allowed, let objects
859	* drop on that space.	906	* drop on that space.
860	*/	907	*/
861	if (!drop_to_ground	908	if (!drop_to_ground
862	|| !map	909	|| !map
863	|| map->in_memory != MAP_IN_MEMORY	910	|| map->in_memory != MAP_ACTIVE
864	|| map->nodrop	911	|| map->no_drop
865	|| ms ().move_block == MOVE_ALL)	912	|| ms ().move_block == MOVE_ALL)
866	{	913	{
867	while (inv)	914	while (inv)
868	{
869	inv->destroy_inv (drop_to_ground);
870	inv->destroy ();	915	inv->destroy ();
871	}
872	}	916	}
873	else	917	else
874	{ /* Put objects in inventory onto this space */	918	{ /* Put objects in inventory onto this space */
875	while (inv)	919	while (inv)
876	{	920	{
…		…
894	object *op = new object;	938	object *op = new object;
895	op->link ();	939	op->link ();
896	return op;	940	return op;
897	}	941	}
898		942
		943	static struct freed_map : maptile
		944	{
		945	freed_map ()
		946	{
		947	path = "<freed objects map>";
		948	name = "/internal/freed_objects_map";
		949	width = 3;
		950	height = 3;
		951	no_drop = 1;
		952	no_reset = 1;
		953
		954	alloc ();
		955	in_memory = MAP_ACTIVE;
		956	}
		957
		958	~freed_map ()
		959	{
		960	destroy ();
		961	}
		962	} freed_map; // freed objects are moved here to avoid crashes
		963
899	void	964	void
900	object::do_destroy ()	965	object::do_destroy ()
901	{	966	{
902	attachable::do_destroy ();
903
904	if (flag [FLAG_IS_LINKED])	967	if (flag [FLAG_IS_LINKED])
905	remove_button_link (this);	968	remove_link ();
906		969
907	if (flag [FLAG_FRIENDLY])	970	if (flag [FLAG_FRIENDLY])
908	remove_friendly_object (this);	971	remove_friendly_object (this);
909		972
910	if (!flag [FLAG_REMOVED])
911	remove ();	973	remove ();
912		974
913	destroy_inv (true);	975	attachable::do_destroy ();
914		976
915	deactivate ();	977	deactivate ();
916	unlink ();	978	unlink ();
917		979
918	flag [FLAG_FREED] = 1;	980	flag [FLAG_FREED] = 1;
919		981
920	// hack to ensure that freed objects still have a valid map	982	// hack to ensure that freed objects still have a valid map
921	{
922	static maptile *freed_map; // freed objects are moved here to avoid crashes
923
924	if (!freed_map)
925	{
926	freed_map = new maptile;
927
928	freed_map->name = "/internal/freed_objects_map";
929	freed_map->width = 3;
930	freed_map->height = 3;
931
932	freed_map->alloc ();
933	freed_map->in_memory = MAP_IN_MEMORY;
934	}
935
936	map = freed_map;	983	map = &freed_map;
937	x = 1;	984	x = 1;
938	y = 1;	985	y = 1;
939	}
940		986
941	if (more)	987	if (more)
942	{	988	{
943	more->destroy ();	989	more->destroy ();
944	more = 0;	990	more = 0;
…		…
952	attacked_by = 0;	998	attacked_by = 0;
953	current_weapon = 0;	999	current_weapon = 0;
954	}	1000	}
955		1001
956	void	1002	void
957	object::destroy (bool destroy_inventory)	1003	object::destroy ()
958	{	1004	{
959	if (destroyed ())	1005	if (destroyed ())
960	return;	1006	return;
961		1007
962	if (destroy_inventory)	1008	if (!is_head () && !head->destroyed ())
		1009	{
		1010	LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
		1011	head->destroy ();
		1012	return;
		1013	}
		1014
963	destroy_inv (false);	1015	destroy_inv (false);
		1016
		1017	if (is_head ())
		1018	if (sound_destroy)
		1019	play_sound (sound_destroy);
		1020	else if (flag [FLAG_MONSTER])
		1021	play_sound (sound_find ("monster_destroy")); // quick hack, too lazy to create a generic mechanism
964		1022
965	attachable::destroy ();	1023	attachable::destroy ();
966	}
967
968	/*
969	* sub_weight() recursively (outwards) subtracts a number from the
970	* weight of an object (and what is carried by it's environment(s)).
971	*/
972	void
973	sub_weight (object *op, signed long weight)
974	{
975	while (op != NULL)
976	{
977	if (op->type == CONTAINER)
978	weight = (signed long) (weight * (100 - op->stats.Str) / 100);
979
980	op->carrying -= weight;
981	op = op->env;
982	}
983	}	1024	}
984		1025
985	/* op->remove ():	1026	/* op->remove ():
986	* This function removes the object op from the linked list of objects	1027	* This function removes the object op from the linked list of objects
987	* which it is currently tied to. When this function is done, the	1028	* which it is currently tied to. When this function is done, the
…		…
993	object::do_remove ()	1034	object::do_remove ()
994	{	1035	{
995	object *tmp, *last = 0;	1036	object *tmp, *last = 0;
996	object *otmp;	1037	object *otmp;
997		1038
998	if (QUERY_FLAG (this, FLAG_REMOVED))	1039	if (flag [FLAG_REMOVED])
999	return;	1040	return;
1000		1041
1001	SET_FLAG (this, FLAG_REMOVED);
1002	INVOKE_OBJECT (REMOVE, this);	1042	INVOKE_OBJECT (REMOVE, this);
		1043
		1044	flag [FLAG_REMOVED] = true;
1003		1045
1004	if (more)	1046	if (more)
1005	more->remove ();	1047	more->remove ();
1006		1048
1007	/*	1049	/*
1008	* In this case, the object to be removed is in someones	1050	* In this case, the object to be removed is in someones
1009	* inventory.	1051	* inventory.
1010	*/	1052	*/
1011	if (env)	1053	if (env)
1012	{	1054	{
1013	if (nrof)	1055	flag [FLAG_REMOVED] = false; // hack around the issue of visible_to checking flag_removed
1014	sub_weight (env, weight * nrof);	1056	if (object *pl = visible_to ())
1015	else	1057	esrv_del_item (pl->contr, count);
1016	sub_weight (env, weight + carrying);	1058	flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
		1059
		1060	adjust_weight (env, -total_weight ());
		1061
		1062	object *pl = in_player ();
		1063
		1064	/* we set up values so that it could be inserted into
		1065	* the map, but we don't actually do that - it is up
		1066	* to the caller to decide what we want to do.
		1067	*/
		1068	map = env->map;
		1069	x = env->x;
		1070	y = env->y;
		1071
		1072	// make sure cmov optimisation is applicable
		1073	*(above ? &above->below : &env->inv) = below;
		1074	*(below ? &below->above : &above ) = above; // &above is just a dummy
		1075
		1076	above = 0;
		1077	below = 0;
		1078	env = 0;
1017		1079
1018	/* NO_FIX_PLAYER is set when a great many changes are being	1080	/* NO_FIX_PLAYER is set when a great many changes are being
1019	* made to players inventory. If set, avoiding the call	1081	* made to players inventory. If set, avoiding the call
1020	* to save cpu time.	1082	* to save cpu time.
1021	*/	1083	*/
1022	if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))	1084	if (pl)
		1085	if (pl->is_player () && (glow_radius || !QUERY_FLAG (pl, FLAG_NO_FIX_PLAYER)))
		1086	{
1023	otmp->update_stats ();	1087	pl->update_stats ();
1024		1088
1025	if (above)	1089	if (glow_radius && pl->is_on_map ())
1026	above->below = below;	1090	update_all_los (pl->map, pl->x, pl->y);
1027	else	1091	}
1028	env->inv = below;
1029
1030	if (below)
1031	below->above = above;
1032
1033	/* we set up values so that it could be inserted into
1034	* the map, but we don't actually do that - it is up
1035	* to the caller to decide what we want to do.
1036	*/
1037	x = env->x, y = env->y;
1038	map = env->map;
1039	above = 0, below = 0;
1040	env = 0;
1041	}	1092	}
1042	else if (map)	1093	else if (map)
1043	{	1094	{
1044	if (type == PLAYER)
1045	{
1046	// leaving a spot always closes any open container on the ground
1047	if (container && !container->env)
1048	// this causes spurious floorbox updates, but it ensures
1049	// that the CLOSE event is being sent.
1050	close_container ();
1051
1052	--map->players;
1053	map->touch ();
1054	}
1055
1056	map->dirty = true;	1095	map->dirty = true;
1057	mapspace &ms = this->ms ();	1096	mapspace &ms = this->ms ();
1058		1097
		1098	if (object *pl = ms.player ())
		1099	{
		1100	if (is_player ())
		1101	{
		1102	if (!flag [FLAG_WIZPASS])
		1103	ms.smell = ++mapspace::smellcount; // remember the smell of the player
		1104
		1105	// leaving a spot always closes any open container on the ground
		1106	if (container && !container->env)
		1107	// this causes spurious floorbox updates, but it ensures
		1108	// that the CLOSE event is being sent.
		1109	close_container ();
		1110
		1111	--map->players;
		1112	map->touch ();
		1113	}
		1114	else if (pl->container == this)
		1115	{
		1116	// removing a container should close it
		1117	close_container ();
		1118	}
		1119
		1120	esrv_del_item (pl->contr, count);
		1121	}
		1122
1059	/* link the object above us */	1123	/* link the object above us */
1060	if (above)	1124	// re-link, make sure compiler can easily use cmove
1061	above->below = below;	1125	*(above ? &above->below : &ms.top) = below;
1062	else	1126	*(below ? &below->above : &ms.bot) = above;
1063	ms.top = below; /* we were top, set new top */
1064
1065	/* Relink the object below us, if there is one */
1066	if (below)
1067	below->above = above;
1068	else
1069	{
1070	/* Nothing below, which means we need to relink map object for this space
1071	* use translated coordinates in case some oddness with map tiling is
1072	* evident
1073	*/
1074	if (GET_MAP_OB (map, x, y) != this)
1075	LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1076
1077	ms.bot = above; /* goes on above it. */
1078	}
1079		1127
1080	above = 0;	1128	above = 0;
1081	below = 0;	1129	below = 0;
1082		1130
		1131	ms.invalidate ();
		1132
1083	if (map->in_memory == MAP_SAVING)	1133	if (map->in_memory == MAP_SAVING)
1084	return;	1134	return;
1085		1135
1086	int check_walk_off = !flag [FLAG_NO_APPLY];	1136	int check_walk_off = !flag [FLAG_NO_APPLY];
		1137
		1138	if (object *pl = ms.player ())
		1139	{
		1140	if (pl->container == this)
		1141	/* If a container that the player is currently using somehow gets
		1142	* removed (most likely destroyed), update the player view
		1143	* appropriately.
		1144	*/
		1145	pl->close_container ();
		1146
		1147	//TODO: the floorbox prev/next might need updating
		1148	//esrv_del_item (pl->contr, count);
		1149	//TODO: update floorbox to preserve ordering
		1150	if (pl->contr->ns)
		1151	pl->contr->ns->floorbox_update ();
		1152	}
1087		1153
1088	for (tmp = ms.bot; tmp; tmp = tmp->above)	1154	for (tmp = ms.bot; tmp; tmp = tmp->above)
1089	{	1155	{
1090	/* No point updating the players look faces if he is the object	1156	/* No point updating the players look faces if he is the object
1091	* being removed.	1157	* being removed.
1092	*/	1158	*/
1093
1094	if (tmp->type == PLAYER && tmp != this)
1095	{
1096	/* If a container that the player is currently using somehow gets
1097	* removed (most likely destroyed), update the player view
1098	* appropriately.
1099	*/
1100	if (tmp->container == this)
1101	{
1102	flag [FLAG_APPLIED] = 0;
1103	tmp->container = 0;
1104	}
1105
1106	if (tmp->contr->ns)
1107	tmp->contr->ns->floorbox_update ();
1108	}
1109		1159
1110	/* See if object moving off should effect something */	1160	/* See if object moving off should effect something */
1111	if (check_walk_off	1161	if (check_walk_off
1112	&& ((move_type & tmp->move_off)	1162	&& ((move_type & tmp->move_off)
1113	&& (move_type & ~tmp->move_off & ~tmp->move_block) == 0))	1163	&& (move_type & ~tmp->move_off & ~tmp->move_block) == 0))
…		…
1119	}	1169	}
1120		1170
1121	last = tmp;	1171	last = tmp;
1122	}	1172	}
1123		1173
1124	/* last == NULL if there are no objects on this space */	1174	if (affects_los ())
1125	//TODO: this makes little sense, why only update the topmost object?
1126	if (!last)
1127	map->at (x, y).flags_ = 0;
1128	else
1129	update_object (last, UP_OBJ_REMOVE);
1130
1131	if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1132	update_all_los (map, x, y);	1175	update_all_los (map, x, y);
1133	}	1176	}
1134	}	1177	}
1135		1178
1136	/*	1179	/*
…		…
1145	merge_ob (object *op, object *top)	1188	merge_ob (object *op, object *top)
1146	{	1189	{
1147	if (!op->nrof)	1190	if (!op->nrof)
1148	return 0;	1191	return 0;
1149		1192
1150	if (top)	1193	if (!top)
1151	for (top = op; top && top->above; top = top->above)	1194	for (top = op; top && top->above; top = top->above)
1152	;	1195	;
1153		1196
1154	for (; top; top = top->below)	1197	for (; top; top = top->below)
1155	{
1156	if (top == op)
1157	continue;
1158
1159	if (object::can_merge (op, top))	1198	if (object::can_merge (op, top))
1160	{	1199	{
1161	top->nrof += op->nrof;	1200	top->nrof += op->nrof;
1162		1201
1163	/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/	1202	if (object *pl = top->visible_to ())
1164	op->weight = 0; /* Don't want any adjustements now */	1203	esrv_update_item (UPD_NROF, pl, top);
		1204
		1205	op->weight = 0; // cancel the addition above
		1206	op->carrying = 0; // must be 0 already
		1207
1165	op->destroy ();	1208	op->destroy ();
		1209
1166	return top;	1210	return top;
1167	}	1211	}
1168	}
1169		1212
1170	return 0;	1213	return 0;
1171	}	1214	}
1172		1215
1173	void	1216	void
…		…
1198	* job preparing multi-part monsters.	1241	* job preparing multi-part monsters.
1199	*/	1242	*/
1200	object *	1243	object *
1201	insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)	1244	insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1202	{	1245	{
		1246	op->remove ();
		1247
1203	for (object *tmp = op->head_ (); tmp; tmp = tmp->more)	1248	for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1204	{	1249	{
1205	tmp->x = x + tmp->arch->x;	1250	tmp->x = x + tmp->arch->x;
1206	tmp->y = y + tmp->arch->y;	1251	tmp->y = y + tmp->arch->y;
1207	}	1252	}
…		…
1230	* just 'op' otherwise	1275	* just 'op' otherwise
1231	*/	1276	*/
1232	object *	1277	object *
1233	insert_ob_in_map (object *op, maptile *m, object *originator, int flag)	1278	insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1234	{	1279	{
1235	assert (!op->flag [FLAG_FREED]);
1236
1237	object *top, *floor = NULL;
1238
1239	op->remove ();	1280	op->remove ();
1240		1281
1241	#if 0	1282	if (m == &freed_map)//D TODO: remove soon
1242	if (!m->active != !op->active)
1243	if (m->active)
1244	op->activate_recursive ();
1245	else
1246	op->deactivate_recursive ();
1247	#endif
1248
1249	if (out_of_map (m, op->x, op->y))
1250	{	1283	{//D
1251	LOG (llevError, "Trying to insert object outside the map.\n%s\n", op->debug_desc ());	1284	LOG (llevError | logBacktrace, "tries to insret object on freed objects map: %s", op->debug_desc ());//D
1252	#ifdef MANY_CORES
1253	/* Better to catch this here, as otherwise the next use of this object
1254	* is likely to cause a crash. Better to find out where it is getting
1255	* improperly inserted.
1256	*/
1257	abort ();
1258	#endif
1259	return op;
1260	}	1285	}//D
1261
1262	if (object *more = op->more)
1263	if (!insert_ob_in_map (more, m, originator, flag))
1264	return 0;
1265
1266	CLEAR_FLAG (op, FLAG_REMOVED);
1267		1286
1268	/* Ideally, the caller figures this out. However, it complicates a lot	1287	/* Ideally, the caller figures this out. However, it complicates a lot
1269	* of areas of callers (eg, anything that uses find_free_spot would now	1288	* of areas of callers (eg, anything that uses find_free_spot would now
1270	* need extra work	1289	* need extra work
1271	*/	1290	*/
		1291	maptile *newmap = m;
1272	if (!xy_normalise (m, op->x, op->y))	1292	if (!xy_normalise (newmap, op->x, op->y))
		1293	{
		1294	op->head_ ()->destroy ();// remove head_ once all tail object destroyers found
1273	return 0;	1295	return 0;
		1296	}
1274		1297
		1298	if (object *more = op->more)
		1299	if (!insert_ob_in_map (more, m, originator, flag))
		1300	return 0;
		1301
		1302	op->flag [FLAG_REMOVED] = false;
		1303	op->env = 0;
1275	op->map = m;	1304	op->map = newmap;
		1305
1276	mapspace &ms = op->ms ();	1306	mapspace &ms = op->ms ();
1277		1307
1278	/* this has to be done after we translate the coordinates.	1308	/* this has to be done after we translate the coordinates.
1279	*/	1309	*/
1280	if (op->nrof && !(flag & INS_NO_MERGE))	1310	if (op->nrof && !(flag & INS_NO_MERGE))
1281	for (object *tmp = ms.bot; tmp; tmp = tmp->above)	1311	for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1282	if (object::can_merge (op, tmp))	1312	if (object::can_merge (op, tmp))
1283	{	1313	{
		1314	// TODO: we actually want to update tmp, not op,
		1315	// but some caller surely breaks when we return tmp
		1316	// from here :/
1284	op->nrof += tmp->nrof;	1317	op->nrof += tmp->nrof;
1285	tmp->destroy ();	1318	tmp->destroy ();
1286	}	1319	}
1287		1320
1288	CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */	1321	CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
…		…
1297	{	1330	{
1298	LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");	1331	LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1299	abort ();	1332	abort ();
1300	}	1333	}
1301		1334
		1335	if (!originator->is_on_map ())
		1336	{
		1337	LOG (llevError, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
		1338	op->debug_desc (), originator->debug_desc ());
		1339	abort ();
		1340	}
		1341
1302	op->above = originator;	1342	op->above = originator;
1303	op->below = originator->below;	1343	op->below = originator->below;
1304
1305	if (op->below)
1306	op->below->above = op;
1307	else
1308	ms.bot = op;
1309
1310	/* since *below* originator, no need to update top */
1311	originator->below = op;	1344	originator->below = op;
		1345
		1346	*(op->below ? &op->below->above : &ms.bot) = op;
1312	}	1347	}
1313	else	1348	else
1314	{	1349	{
1315	top = ms.bot;	1350	object *floor = 0;
		1351	object *top = ms.top;
1316		1352
1317	/* If there are other objects, then */	1353	/* If there are other objects, then */
1318	if ((!(flag & INS_MAP_LOAD)) && top)	1354	if (top)
1319	{	1355	{
1320	object *last = 0;
1321
1322	/*	1356	/*
1323	* If there are multiple objects on this space, we do some trickier handling.	1357	* If there are multiple objects on this space, we do some trickier handling.
1324	* We've already dealt with merging if appropriate.	1358	* We've already dealt with merging if appropriate.
1325	* Generally, we want to put the new object on top. But if	1359	* Generally, we want to put the new object on top. But if
1326	* flag contains INS_ABOVE_FLOOR_ONLY, once we find the last	1360	* flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
…		…
1329	* once we get to them. This reduces the need to traverse over all of	1363	* once we get to them. This reduces the need to traverse over all of
1330	* them when adding another one - this saves quite a bit of cpu time	1364	* them when adding another one - this saves quite a bit of cpu time
1331	* when lots of spells are cast in one area. Currently, it is presumed	1365	* when lots of spells are cast in one area. Currently, it is presumed
1332	* that flying non pickable objects are spell objects.	1366	* that flying non pickable objects are spell objects.
1333	*/	1367	*/
1334	for (top = ms.bot; top; top = top->above)	1368	for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1335	{	1369	{
1336	if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))	1370	if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) || QUERY_FLAG (tmp, FLAG_OVERLAY_FLOOR))
1337	floor = top;	1371	floor = tmp;
1338		1372
1339	if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))	1373	if (QUERY_FLAG (tmp, FLAG_NO_PICK) && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (tmp, FLAG_IS_FLOOR))
1340	{	1374	{
1341	/* We insert above top, so we want this object below this */	1375	/* We insert above top, so we want this object below this */
1342	top = top->below;	1376	top = tmp->below;
1343	break;	1377	break;
1344	}	1378	}
1345		1379
1346	last = top;	1380	top = tmp;
1347	}	1381	}
1348
1349	/* Don't want top to be NULL, so set it to the last valid object */
1350	top = last;
1351		1382
1352	/* We let update_position deal with figuring out what the space	1383	/* We let update_position deal with figuring out what the space
1353	* looks like instead of lots of conditions here.	1384	* looks like instead of lots of conditions here.
1354	* makes things faster, and effectively the same result.	1385	* makes things faster, and effectively the same result.
1355	*/	1386	*/
…		…
1362	*/	1393	*/
1363	if (!(flag & INS_ON_TOP)	1394	if (!(flag & INS_ON_TOP)
1364	&& ms.flags () & P_BLOCKSVIEW	1395	&& ms.flags () & P_BLOCKSVIEW
1365	&& (op->face && !faces [op->face].visibility))	1396	&& (op->face && !faces [op->face].visibility))
1366	{	1397	{
		1398	object *last;
		1399
1367	for (last = top; last != floor; last = last->below)	1400	for (last = top; last != floor; last = last->below)
1368	if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))	1401	if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1369	break;	1402	break;
1370		1403
1371	/* Check to see if we found the object that blocks view,	1404	/* Check to see if we found the object that blocks view,
…		…
1376	if (last && last->below && last != floor)	1409	if (last && last->below && last != floor)
1377	top = last->below;	1410	top = last->below;
1378	}	1411	}
1379	} /* If objects on this space */	1412	} /* If objects on this space */
1380		1413
1381	if (flag & INS_MAP_LOAD)
1382	top = ms.top;
1383
1384	if (flag & INS_ABOVE_FLOOR_ONLY)	1414	if (flag & INS_ABOVE_FLOOR_ONLY)
1385	top = floor;	1415	top = floor;
1386		1416
1387	/* Top is the object that our object (op) is going to get inserted above.	1417	// insert object above top, or bottom-most if top = 0
1388	*/
1389
1390	/* First object on this space */
1391	if (!top)	1418	if (!top)
1392	{	1419	{
		1420	op->below = 0;
1393	op->above = ms.bot;	1421	op->above = ms.bot;
1394
1395	if (op->above)
1396	op->above->below = op;
1397
1398	op->below = 0;
1399	ms.bot = op;	1422	ms.bot = op;
		1423
		1424	*(op->above ? &op->above->below : &ms.top) = op;
1400	}	1425	}
1401	else	1426	else
1402	{ /* get inserted into the stack above top */	1427	{
1403	op->above = top->above;	1428	op->above = top->above;
1404
1405	if (op->above)
1406	op->above->below = op;	1429	top->above = op;
1407		1430
1408	op->below = top;	1431	op->below = top;
1409	top->above = op;	1432	*(op->above ? &op->above->below : &ms.top) = op;
1410	}	1433	}
		1434	}
1411		1435
1412	if (!op->above)	1436	if (op->is_player ())
1413	ms.top = op;
1414	} /* else not INS_BELOW_ORIGINATOR */
1415
1416	if (op->type == PLAYER)
1417	{	1437	{
1418	op->contr->do_los = 1;	1438	op->contr->do_los = 1;
1419	++op->map->players;	1439	++op->map->players;
1420	op->map->touch ();	1440	op->map->touch ();
1421	}	1441	}
1422		1442
1423	op->map->dirty = true;	1443	op->map->dirty = true;
1424		1444
1425	/* If we have a floor, we know the player, if any, will be above
1426	* it, so save a few ticks and start from there.
1427	*/
1428	if (!(flag & INS_MAP_LOAD))
1429	if (object *pl = ms.player ())	1445	if (object *pl = ms.player ())
		1446	//TODO: the floorbox prev/next might need updating
		1447	//esrv_send_item (pl, op);
		1448	//TODO: update floorbox to preserve ordering
1430	if (pl->contr->ns)	1449	if (pl->contr->ns)
1431	pl->contr->ns->floorbox_update ();	1450	pl->contr->ns->floorbox_update ();
1432		1451
1433	/* If this object glows, it may affect lighting conditions that are	1452	/* If this object glows, it may affect lighting conditions that are
1434	* visible to others on this map. But update_all_los is really	1453	* visible to others on this map. But update_all_los is really
1435	* an inefficient way to do this, as it means los for all players	1454	* an inefficient way to do this, as it means los for all players
1436	* on the map will get recalculated. The players could very well	1455	* on the map will get recalculated. The players could very well
1437	* be far away from this change and not affected in any way -	1456	* be far away from this change and not affected in any way -
1438	* this should get redone to only look for players within range,	1457	* this should get redone to only look for players within range,
1439	* or just updating the P_UPTODATE for spaces within this area	1458	* or just updating the P_UPTODATE for spaces within this area
1440	* of effect may be sufficient.	1459	* of effect may be sufficient.
1441	*/	1460	*/
1442	if (op->map->darkness && (op->glow_radius != 0))	1461	if (op->affects_los ())
		1462	{
		1463	op->ms ().invalidate ();
1443	update_all_los (op->map, op->x, op->y);	1464	update_all_los (op->map, op->x, op->y);
		1465	}
1444		1466
1445	/* updates flags (blocked, alive, no magic, etc) for this map space */	1467	/* updates flags (blocked, alive, no magic, etc) for this map space */
1446	update_object (op, UP_OBJ_INSERT);	1468	update_object (op, UP_OBJ_INSERT);
1447		1469
1448	INVOKE_OBJECT (INSERT, op);	1470	INVOKE_OBJECT (INSERT, op);
…		…
1476	/* this function inserts an object in the map, but if it	1498	/* this function inserts an object in the map, but if it
1477	* finds an object of its own type, it'll remove that one first.	1499	* finds an object of its own type, it'll remove that one first.
1478	* op is the object to insert it under: supplies x and the map.	1500	* op is the object to insert it under: supplies x and the map.
1479	*/	1501	*/
1480	void	1502	void
1481	replace_insert_ob_in_map (const char *arch_string, object *op)	1503	replace_insert_ob_in_map (shstr_tmp archname, object *op)
1482	{	1504	{
1483	object *tmp, *tmp1;
1484
1485	/* first search for itself and remove any old instances */	1505	/* first search for itself and remove any old instances */
1486		1506
1487	for (tmp = op->ms ().bot; tmp; tmp = tmp->above)	1507	for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1488	if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */	1508	if (tmp->arch->archname == archname) /* same archetype */
1489	tmp->destroy ();	1509	tmp->destroy ();
1490		1510
1491	tmp1 = arch_to_object (archetype::find (arch_string));	1511	object *tmp = arch_to_object (archetype::find (archname));
1492		1512
1493	tmp1->x = op->x;	1513	tmp->x = op->x;
1494	tmp1->y = op->y;	1514	tmp->y = op->y;
		1515
1495	insert_ob_in_map (tmp1, op->map, op, 0);	1516	insert_ob_in_map (tmp, op->map, op, 0);
1496	}	1517	}
1497		1518
1498	object *	1519	object *
1499	object::insert_at (object *where, object *originator, int flags)	1520	object::insert_at (object *where, object *originator, int flags)
1500	{	1521	{
		1522	if (where->env)
		1523	return where->env->insert (this);
		1524	else
1501	return where->map->insert (this, where->x, where->y, originator, flags);	1525	return where->map->insert (this, where->x, where->y, originator, flags);
1502	}	1526	}
1503		1527
1504	/*	1528	/*
1505	* get_split_ob(ob,nr) splits up ob into two parts. The part which
1506	* is returned contains nr objects, and the remaining parts contains
1507	* the rest (or is removed and freed if that number is 0).
1508	* On failure, NULL is returned, and the reason put into the
1509	* global static errmsg array.
1510	*/
1511	object *
1512	get_split_ob (object *orig_ob, uint32 nr)
1513	{
1514	object *newob;
1515	int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1516
1517	if (orig_ob->nrof < nr)
1518	{
1519	sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1520	return NULL;
1521	}
1522
1523	newob = object_create_clone (orig_ob);
1524
1525	if ((orig_ob->nrof -= nr) < 1)
1526	orig_ob->destroy (1);
1527	else if (!is_removed)
1528	{
1529	if (orig_ob->env != NULL)
1530	sub_weight (orig_ob->env, orig_ob->weight * nr);
1531	if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY)
1532	{
1533	strcpy (errmsg, "Tried to split object whose map is not in memory.");
1534	LOG (llevDebug, "Error, Tried to split object whose map is not in memory.\n");
1535	return NULL;
1536	}
1537	}
1538
1539	newob->nrof = nr;
1540
1541	return newob;
1542	}
1543
1544	/*
1545	* decrease_ob_nr(object, number) decreases a specified number from	1529	* decrease(object, number) decreases a specified number from
1546	* the amount of an object. If the amount reaches 0, the object	1530	* the amount of an object. If the amount reaches 0, the object
1547	* is subsequently removed and freed.	1531	* is subsequently removed and freed.
1548	*	1532	*
1549	* Return value: 'op' if something is left, NULL if the amount reached 0	1533	* Return value: 'op' if something is left, NULL if the amount reached 0
1550	*/	1534	*/
		1535	bool
		1536	object::decrease (sint32 nr)
		1537	{
		1538	if (!nr)
		1539	return true;
		1540
		1541	nr = min (nr, nrof);
		1542
		1543	if (nrof > nr)
		1544	{
		1545	nrof -= nr;
		1546	adjust_weight (env, -weight * max (1, nr)); // carrying == 0
		1547
		1548	if (object *pl = visible_to ())
		1549	esrv_update_item (UPD_NROF, pl, this);
		1550
		1551	return true;
		1552	}
		1553	else
		1554	{
		1555	destroy ();
		1556	return false;
		1557	}
		1558	}
		1559
		1560	/*
		1561	* split(ob,nr) splits up ob into two parts. The part which
		1562	* is returned contains nr objects, and the remaining parts contains
		1563	* the rest (or is removed and returned if that number is 0).
		1564	* On failure, NULL is returned.
		1565	*/
1551	object *	1566	object *
1552	decrease_ob_nr (object *op, uint32 i)	1567	object::split (sint32 nr)
1553	{	1568	{
1554	object *tmp;	1569	int have = number_of ();
1555		1570
1556	if (i == 0) /* objects with op->nrof require this check */	1571	if (have < nr)
1557	return op;	1572	return 0;
1558		1573	else if (have == nr)
1559	if (i > op->nrof)
1560	i = op->nrof;
1561
1562	if (QUERY_FLAG (op, FLAG_REMOVED))
1563	op->nrof -= i;
1564	else if (op->env)
1565	{	1574	{
1566	/* is this object in the players inventory, or sub container
1567	* therein?
1568	*/
1569	tmp = op->in_player ();
1570	/* nope. Is this a container the player has opened?
1571	* If so, set tmp to that player.
1572	* IMO, searching through all the players will mostly
1573	* likely be quicker than following op->env to the map,
1574	* and then searching the map for a player.
1575	*/
1576	if (!tmp)
1577	for_all_players (pl)
1578	if (pl->ob->container == op->env)
1579	{
1580	tmp = pl->ob;
1581	break;
1582	}
1583
1584	if (i < op->nrof)
1585	{
1586	sub_weight (op->env, op->weight * i);
1587	op->nrof -= i;
1588	if (tmp)
1589	esrv_send_item (tmp, op);
1590	}
1591	else
1592	{
1593	op->remove ();	1575	remove ();
1594	op->nrof = 0;	1576	return this;
1595	if (tmp)
1596	esrv_del_item (tmp->contr, op->count);
1597	}
1598	}	1577	}
1599	else	1578	else
1600	{	1579	{
1601	object *above = op->above;	1580	decrease (nr);
1602		1581
1603	if (i < op->nrof)	1582	object *op = deep_clone ();
1604	op->nrof -= i;	1583	op->nrof = nr;
1605	else
1606	{
1607	op->remove ();
1608	op->nrof = 0;
1609	}
1610
1611	/* Since we just removed op, op->above is null */
1612	for (tmp = above; tmp; tmp = tmp->above)
1613	if (tmp->type == PLAYER)
1614	{
1615	if (op->nrof)
1616	esrv_send_item (tmp, op);
1617	else
1618	esrv_del_item (tmp->contr, op->count);
1619	}
1620	}
1621
1622	if (op->nrof)
1623	return op;	1584	return op;
1624	else
1625	{
1626	op->destroy ();
1627	return 0;
1628	}
1629	}
1630
1631	/*
1632	* add_weight(object, weight) adds the specified weight to an object,
1633	* and also updates how much the environment(s) is/are carrying.
1634	*/
1635	void
1636	add_weight (object *op, signed long weight)
1637	{
1638	while (op != NULL)
1639	{
1640	if (op->type == CONTAINER)
1641	weight = (signed long) (weight * (100 - op->stats.Str) / 100);
1642
1643	op->carrying += weight;
1644	op = op->env;
1645	}	1585	}
1646	}	1586	}
1647		1587
1648	object *	1588	object *
1649	insert_ob_in_ob (object *op, object *where)	1589	insert_ob_in_ob (object *op, object *where)
…		…
1674	* be != op, if items are merged. -Tero	1614	* be != op, if items are merged. -Tero
1675	*/	1615	*/
1676	object *	1616	object *
1677	object::insert (object *op)	1617	object::insert (object *op)
1678	{	1618	{
1679	object *tmp, *otmp;
1680
1681	if (!QUERY_FLAG (op, FLAG_REMOVED))
1682	op->remove ();
1683
1684	if (op->more)	1619	if (op->more)
1685	{	1620	{
1686	LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);	1621	LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);
1687	return op;	1622	return op;
1688	}	1623	}
1689		1624
1690	CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL);	1625	op->remove ();
1691	CLEAR_FLAG (op, FLAG_REMOVED);	1626
		1627	op->flag [FLAG_OBJ_ORIGINAL] = 0;
		1628
1692	if (op->nrof)	1629	if (op->nrof)
1693	{
1694	for (tmp = inv; tmp != NULL; tmp = tmp->below)	1630	for (object *tmp = inv; tmp; tmp = tmp->below)
1695	if (object::can_merge (tmp, op))	1631	if (object::can_merge (tmp, op))
1696	{	1632	{
1697	/* return the original object and remove inserted object	1633	/* return the original object and remove inserted object
1698	(client needs the original object) */	1634	(client needs the original object) */
1699	tmp->nrof += op->nrof;	1635	tmp->nrof += op->nrof;
1700	/* Weight handling gets pretty funky. Since we are adding to	1636
1701	* tmp->nrof, we need to increase the weight.	1637	if (object *pl = tmp->visible_to ())
1702	*/	1638	esrv_update_item (UPD_NROF, pl, tmp);
		1639
1703	add_weight (this, op->weight * op->nrof);	1640	adjust_weight (this, op->total_weight ());
1704	SET_FLAG (op, FLAG_REMOVED);	1641
1705	op->destroy (); /* free the inserted object */	1642	op->destroy ();
1706	op = tmp;	1643	op = tmp;
1707	op->remove (); /* and fix old object's links */	1644	goto inserted;
1708	CLEAR_FLAG (op, FLAG_REMOVED);
1709	break;
1710	}	1645	}
1711		1646
1712	/* I assume combined objects have no inventory	1647	op->owner = 0; // it's his/hers now. period.
1713	* We add the weight - this object could have just been removed
1714	* (if it was possible to merge). calling remove_ob will subtract
1715	* the weight, so we need to add it in again, since we actually do
1716	* the linking below
1717	*/
1718	add_weight (this, op->weight * op->nrof);
1719	}
1720	else
1721	add_weight (this, (op->weight + op->carrying));
1722
1723	otmp = this->in_player ();
1724	if (otmp && otmp->contr)
1725	if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1726	otmp->update_stats ();
1727
1728	op->map = 0;	1648	op->map = 0;
1729	op->env = this;	1649	op->x = 0;
		1650	op->y = 0;
		1651
1730	op->above = 0;	1652	op->above = 0;
1731	op->below = 0;	1653	op->below = inv;
1732	op->x = 0, op->y = 0;	1654	op->env = this;
1733		1655
		1656	if (inv)
		1657	inv->above = op;
		1658
		1659	inv = op;
		1660
		1661	op->flag [FLAG_REMOVED] = 0;
		1662
		1663	if (object *pl = op->visible_to ())
		1664	esrv_send_item (pl, op);
		1665
		1666	adjust_weight (this, op->total_weight ());
		1667
		1668	inserted:
1734	/* reset the light list and los of the players on the map */	1669	/* reset the light list and los of the players on the map */
1735	if ((op->glow_radius != 0) && map)	1670	if (op->glow_radius && is_on_map ())
1736	{	1671	{
1737	#ifdef DEBUG_LIGHTS	1672	update_stats ();
1738	LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1739	#endif /* DEBUG_LIGHTS */
1740	if (map->darkness)
1741	update_all_los (map, x, y);	1673	update_all_los (map, x, y);
1742	}
1743
1744	/* Client has no idea of ordering so lets not bother ordering it here.
1745	* It sure simplifies this function...
1746	*/
1747	if (!inv)
1748	inv = op;
1749	else
1750	{	1674	}
1751	op->below = inv;	1675	else if (is_player () && !flag [FLAG_NO_FIX_PLAYER])
1752	op->below->above = op;	1676	// if this is a player's inventory, update stats
1753	inv = op;	1677	update_stats ();
1754	}
1755		1678
1756	INVOKE_OBJECT (INSERT, this);	1679	INVOKE_OBJECT (INSERT, this);
1757		1680
1758	return op;	1681	return op;
1759	}	1682	}
…		…
1842	{	1765	{
1843		1766
1844	float	1767	float
1845	diff = tmp->move_slow_penalty * fabs (op->speed);	1768	diff = tmp->move_slow_penalty * fabs (op->speed);
1846		1769
1847	if (op->type == PLAYER)	1770	if (op->is_player ())
1848	if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) ||	1771	if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) ||
1849	(QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN)))	1772	(QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN)))
1850	diff /= 4.0;	1773	diff /= 4.0;
1851		1774
1852	op->speed_left -= diff;	1775	op->speed_left -= diff;
…		…
1887	LOG (llevError, "Present_arch called outside map.\n");	1810	LOG (llevError, "Present_arch called outside map.\n");
1888	return NULL;	1811	return NULL;
1889	}	1812	}
1890		1813
1891	for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)	1814	for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1892	if (tmp->arch == at)	1815	if (tmp->arch->archname == at->archname)
1893	return tmp;	1816	return tmp;
1894		1817
1895	return NULL;	1818	return NULL;
1896	}	1819	}
1897		1820
…		…
1961	* The first matching object is returned, or NULL if none.	1884	* The first matching object is returned, or NULL if none.
1962	*/	1885	*/
1963	object *	1886	object *
1964	present_arch_in_ob (const archetype *at, const object *op)	1887	present_arch_in_ob (const archetype *at, const object *op)
1965	{	1888	{
1966	for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)	1889	for (object *tmp = op->inv; tmp; tmp = tmp->below)
1967	if (tmp->arch == at)	1890	if (tmp->arch->archname == at->archname)
1968	return tmp;	1891	return tmp;
1969		1892
1970	return NULL;	1893	return NULL;
1971	}	1894	}
1972		1895
…		…
1974	* activate recursively a flag on an object inventory	1897	* activate recursively a flag on an object inventory
1975	*/	1898	*/
1976	void	1899	void
1977	flag_inv (object *op, int flag)	1900	flag_inv (object *op, int flag)
1978	{	1901	{
1979	if (op->inv)
1980	for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)	1902	for (object *tmp = op->inv; tmp; tmp = tmp->below)
1981	{	1903	{
1982	SET_FLAG (tmp, flag);	1904	SET_FLAG (tmp, flag);
1983	flag_inv (tmp, flag);	1905	flag_inv (tmp, flag);
1984	}	1906	}
1985	}	1907	}
1986		1908
1987	/*	1909	/*
1988	* deactivate recursively a flag on an object inventory	1910	* deactivate recursively a flag on an object inventory
1989	*/	1911	*/
1990	void	1912	void
1991	unflag_inv (object *op, int flag)	1913	unflag_inv (object *op, int flag)
1992	{	1914	{
1993	if (op->inv)
1994	for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)	1915	for (object *tmp = op->inv; tmp; tmp = tmp->below)
1995	{	1916	{
1996	CLEAR_FLAG (tmp, flag);	1917	CLEAR_FLAG (tmp, flag);
1997	unflag_inv (tmp, flag);	1918	unflag_inv (tmp, flag);
1998	}	1919	}
1999	}	1920	}
2000		1921
2001	/*	1922	/*
2002	* find_free_spot(object, map, x, y, start, stop) will search for	1923	* find_free_spot(object, map, x, y, start, stop) will search for
2003	* a spot at the given map and coordinates which will be able to contain	1924	* a spot at the given map and coordinates which will be able to contain
…		…
2005	* to search (see the freearr_x/y[] definition).	1926	* to search (see the freearr_x/y[] definition).
2006	* It returns a random choice among the alternatives found.	1927	* It returns a random choice among the alternatives found.
2007	* start and stop are where to start relative to the free_arr array (1,9	1928	* start and stop are where to start relative to the free_arr array (1,9
2008	* does all 4 immediate directions). This returns the index into the	1929	* does all 4 immediate directions). This returns the index into the
2009	* array of the free spot, -1 if no spot available (dir 0 = x,y)	1930	* array of the free spot, -1 if no spot available (dir 0 = x,y)
2010	* Note - this only checks to see if there is space for the head of the
2011	* object - if it is a multispace object, this should be called for all
2012	* pieces.
2013	* Note2: This function does correctly handle tiled maps, but does not	1931	* Note: This function does correctly handle tiled maps, but does not
2014	* inform the caller. However, insert_ob_in_map will update as	1932	* inform the caller. However, insert_ob_in_map will update as
2015	* necessary, so the caller shouldn't need to do any special work.	1933	* necessary, so the caller shouldn't need to do any special work.
2016	* Note - updated to take an object instead of archetype - this is necessary	1934	* Note - updated to take an object instead of archetype - this is necessary
2017	* because arch_blocked (now ob_blocked) needs to know the movement type	1935	* because arch_blocked (now ob_blocked) needs to know the movement type
2018	* to know if the space in question will block the object. We can't use	1936	* to know if the space in question will block the object. We can't use
…		…
2020	* customized, changed states, etc.	1938	* customized, changed states, etc.
2021	*/	1939	*/
2022	int	1940	int
2023	find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)	1941	find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)
2024	{	1942	{
		1943	int altern[SIZEOFFREE];
2025	int index = 0, flag;	1944	int index = 0, flag;
2026	int altern[SIZEOFFREE];
2027		1945
2028	for (int i = start; i < stop; i++)	1946	for (int i = start; i < stop; i++)
2029	{	1947	{
2030	flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]);	1948	mapxy pos (m, x, y); pos.move (i);
2031	if (!flag)	1949
		1950	if (!pos.normalise ())
		1951	continue;
		1952
		1953	mapspace &ms = *pos;
		1954
		1955	if (ms.flags () & P_IS_ALIVE)
		1956	continue;
		1957
		1958	/* However, often
		1959	* ob doesn't have any move type (when used to place exits)
		1960	* so the AND operation in OB_TYPE_MOVE_BLOCK doesn't work.
		1961	*/
		1962	if (ob && ob->move_type == 0 && ms.move_block != MOVE_ALL)
		1963	{
2032	altern [index++] = i;	1964	altern [index++] = i;
		1965	continue;
		1966	}
2033		1967
2034	/* Basically, if we find a wall on a space, we cut down the search size.	1968	/* Basically, if we find a wall on a space, we cut down the search size.
2035	* In this way, we won't return spaces that are on another side of a wall.	1969	* In this way, we won't return spaces that are on another side of a wall.
2036	* This mostly work, but it cuts down the search size in all directions -	1970	* This mostly work, but it cuts down the search size in all directions -
2037	* if the space being examined only has a wall to the north and empty	1971	* if the space being examined only has a wall to the north and empty
2038	* spaces in all the other directions, this will reduce the search space	1972	* spaces in all the other directions, this will reduce the search space
2039	* to only the spaces immediately surrounding the target area, and	1973	* to only the spaces immediately surrounding the target area, and
2040	* won't look 2 spaces south of the target space.	1974	* won't look 2 spaces south of the target space.
2041	*/	1975	*/
2042	else if ((flag & P_NO_PASS) && maxfree[i] < stop)	1976	if (ms.move_block == MOVE_ALL && maxfree[i] < stop)
		1977	{
2043	stop = maxfree[i];	1978	stop = maxfree[i];
		1979	continue;
		1980	}
		1981
		1982	/* Note it is intentional that we check ob - the movement type of the
		1983	* head of the object should correspond for the entire object.
		1984	*/
		1985	if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))
		1986	continue;
		1987
		1988	if (ob->blocked (pos.m, pos.x, pos.y))
		1989	continue;
		1990
		1991	altern [index++] = i;
2044	}	1992	}
2045		1993
2046	if (!index)	1994	if (!index)
2047	return -1;	1995	return -1;
2048		1996
…		…
2057	*/	2005	*/
2058	int	2006	int
2059	find_first_free_spot (const object *ob, maptile *m, int x, int y)	2007	find_first_free_spot (const object *ob, maptile *m, int x, int y)
2060	{	2008	{
2061	for (int i = 0; i < SIZEOFFREE; i++)	2009	for (int i = 0; i < SIZEOFFREE; i++)
2062	if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]))	2010	if (!ob->blocked (m, x + freearr_x[i], y + freearr_y[i]))
2063	return i;	2011	return i;
2064		2012
2065	return -1;	2013	return -1;
2066	}	2014	}
2067		2015
…		…
2113	* there is capable of.	2061	* there is capable of.
2114	*/	2062	*/
2115	int	2063	int
2116	find_dir (maptile *m, int x, int y, object *exclude)	2064	find_dir (maptile *m, int x, int y, object *exclude)
2117	{	2065	{
2118	int i, max = SIZEOFFREE, mflags;	2066	int max = SIZEOFFREE, mflags;
2119
2120	sint16 nx, ny;
2121	object *tmp;
2122	maptile *mp;
2123
2124	MoveType blocked, move_type;	2067	MoveType move_type;
2125		2068
2126	if (exclude && exclude->head_ () != exclude)	2069	if (exclude && exclude->head_ () != exclude)
2127	{	2070	{
2128	exclude = exclude->head;	2071	exclude = exclude->head;
2129	move_type = exclude->move_type;	2072	move_type = exclude->move_type;
…		…
2132	{	2075	{
2133	/* If we don't have anything, presume it can use all movement types. */	2076	/* If we don't have anything, presume it can use all movement types. */
2134	move_type = MOVE_ALL;	2077	move_type = MOVE_ALL;
2135	}	2078	}
2136		2079
2137	for (i = 1; i < max; i++)	2080	for (int i = 1; i < max; i++)
2138	{	2081	{
2139	mp = m;	2082	mapxy pos (m, x, y);
2140	nx = x + freearr_x[i];	2083	pos.move (i);
2141	ny = y + freearr_y[i];
2142		2084
2143	mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);	2085	if (!pos.normalise ())
2144
2145	if (mflags & P_OUT_OF_MAP)
2146	max = maxfree[i];	2086	max = maxfree[i];
2147	else	2087	else
2148	{	2088	{
2149	mapspace &ms = mp->at (nx, ny);	2089	mapspace &ms = *pos;
2150		2090
2151	blocked = ms.move_block;
2152
2153	if ((move_type & blocked) == move_type)	2091	if ((move_type & ms.move_block) == move_type)
2154	max = maxfree[i];	2092	max = maxfree [i];
2155	else if (mflags & P_IS_ALIVE)	2093	else if (ms.flags () & P_IS_ALIVE)
2156	{	2094	{
2157	for (tmp = ms.bot; tmp; tmp = tmp->above)	2095	for (object *tmp = ms.bot; tmp; tmp = tmp->above)
2158	if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)	2096	if ((tmp->flag [FLAG_MONSTER] || tmp->is_player ())
2159	&& (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))	2097	&& (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))
2160	break;
2161
2162	if (tmp)
2163	return freedir[i];	2098	return freedir [i];
2164	}	2099	}
2165	}	2100	}
2166	}	2101	}
2167		2102
2168	return 0;	2103	return 0;
…		…
2243	* This basically means that if direction is 15, then it could either go	2178	* This basically means that if direction is 15, then it could either go
2244	* direction 4, 14, or 16 to get back to where we are.	2179	* direction 4, 14, or 16 to get back to where we are.
2245	* Moved from spell_util.c to object.c with the other related direction	2180	* Moved from spell_util.c to object.c with the other related direction
2246	* functions.	2181	* functions.
2247	*/	2182	*/
2248	int reduction_dir[SIZEOFFREE][3] = {	2183	const int reduction_dir[SIZEOFFREE][3] = {
2249	{0, 0, 0}, /* 0 */	2184	{0, 0, 0}, /* 0 */
2250	{0, 0, 0}, /* 1 */	2185	{0, 0, 0}, /* 1 */
2251	{0, 0, 0}, /* 2 */	2186	{0, 0, 0}, /* 2 */
2252	{0, 0, 0}, /* 3 */	2187	{0, 0, 0}, /* 3 */
2253	{0, 0, 0}, /* 4 */	2188	{0, 0, 0}, /* 4 */
…		…
2344	* Cf 0.91.3 - don't let WIZ's pick up anything - will likely cause	2279	* Cf 0.91.3 - don't let WIZ's pick up anything - will likely cause
2345	* core dumps if they do.	2280	* core dumps if they do.
2346	*	2281	*
2347	* Add a check so we can't pick up invisible objects (0.93.8)	2282	* Add a check so we can't pick up invisible objects (0.93.8)
2348	*/	2283	*/
2349
2350	int	2284	int
2351	can_pick (const object *who, const object *item)	2285	can_pick (const object *who, const object *item)
2352	{	2286	{
2353	return /*QUERY_FLAG(who,FLAG_WIZ)|| */	2287	return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2354	(item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&	2288	(item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2355	!QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));	2289	!QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->is_player () || item->weight < who->weight / 3));
2356	}	2290	}
2357		2291
2358	/*	2292	/*
2359	* create clone from object to another	2293	* create clone from object to another
2360	*/	2294	*/
2361	object *	2295	object *
2362	object_create_clone (object *asrc)	2296	object::deep_clone ()
2363	{	2297	{
2364	object *dst = 0, *tmp, *src, *prev, *item;	2298	assert (("deep_clone called on non-head object", is_head ()));
2365		2299
2366	if (!asrc)	2300	object *dst = clone ();
2367	return 0;
2368		2301
2369	src = asrc->head_ ();	2302	object *prev = dst;
2370
2371	prev = 0;
2372	for (object *part = src; part; part = part->more)	2303	for (object *part = this->more; part; part = part->more)
2373	{	2304	{
2374	tmp = part->clone ();	2305	object *tmp = part->clone ();
2375	tmp->x -= src->x;
2376	tmp->y -= src->y;
2377
2378	if (!part->head)
2379	{
2380	dst = tmp;
2381	tmp->head = 0;
2382	}
2383	else
2384	tmp->head = dst;	2306	tmp->head = dst;
2385
2386	tmp->more = 0;
2387
2388	if (prev)
2389	prev->more = tmp;	2307	prev->more = tmp;
2390
2391	prev = tmp;	2308	prev = tmp;
2392	}	2309	}
2393		2310
2394	for (item = src->inv; item; item = item->below)	2311	for (object *item = inv; item; item = item->below)
2395	insert_ob_in_ob (object_create_clone (item), dst);	2312	insert_ob_in_ob (item->deep_clone (), dst);
2396		2313
2397	return dst;	2314	return dst;
2398	}	2315	}
2399		2316
2400	/* This returns the first object in who's inventory that	2317	/* This returns the first object in who's inventory that
…		…
2409	return tmp;	2326	return tmp;
2410		2327
2411	return 0;	2328	return 0;
2412	}	2329	}
2413		2330
2414	/* If ob has a field named key, return the link from the list,	2331	shstr_tmp
2415	* otherwise return NULL.	2332	object::kv_get (shstr_tmp key) const
2416	*
2417	* key must be a passed in shared string - otherwise, this won't
2418	* do the desired thing.
2419	*/
2420	key_value *
2421	get_ob_key_link (const object *ob, const char *key)
2422	{	2333	{
2423	for (key_value *link = ob->key_values; link; link = link->next)	2334	for (key_value *kv = key_values; kv; kv = kv->next)
2424	if (link->key == key)	2335	if (kv->key == key)
2425	return link;
2426
2427	return 0;
2428	}
2429
2430	/*
2431	* Returns the value of op has an extra_field for key, or NULL.
2432	*
2433	* The argument doesn't need to be a shared string.
2434	*
2435	* The returned string is shared.
2436	*/
2437	const char *
2438	get_ob_key_value (const object *op, const char *const key)
2439	{
2440	key_value *link;
2441	shstr_cmp canonical_key (key);
2442
2443	if (!canonical_key)
2444	{
2445	/* 1. There being a field named key on any object
2446	* implies there'd be a shared string to find.
2447	* 2. Since there isn't, no object has this field.
2448	* 3. Therefore, *this* object doesn't have this field.
2449	*/
2450	return 0;
2451	}
2452
2453	/* This is copied from get_ob_key_link() above -
2454	* only 4 lines, and saves the function call overhead.
2455	*/
2456	for (link = op->key_values; link; link = link->next)
2457	if (link->key == canonical_key)
2458	return link->value;	2336	return kv->value;
2459		2337
2460	return 0;	2338	return shstr ();
2461	}	2339	}
2462		2340
2463	/*	2341	void
2464	* Updates the canonical_key in op to value.	2342	object::kv_set (shstr_tmp key, shstr_tmp value)
2465	*
2466	* canonical_key is a shared string (value doesn't have to be).
2467	*
2468	* Unless add_key is TRUE, it won't add fields, only change the value of existing
2469	* keys.
2470	*
2471	* Returns TRUE on success.
2472	*/
2473	int
2474	set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2475	{	2343	{
2476	key_value *field = NULL, *last = NULL;	2344	for (key_value *kv = key_values; kv; kv = kv->next)
2477		2345	if (kv->key == key)
2478	for (field = op->key_values; field != NULL; field = field->next)
2479	{
2480	if (field->key != canonical_key)
2481	{	2346	{
2482	last = field;	2347	kv->value = value;
2483	continue;	2348	return;
2484	}	2349	}
2485		2350
2486	if (value)	2351	key_value *kv = new key_value;
2487	field->value = value;	2352
2488	else	2353	kv->next = key_values;
		2354	kv->key = key;
		2355	kv->value = value;
		2356
		2357	key_values = kv;
		2358	}
		2359
		2360	void
		2361	object::kv_del (shstr_tmp key)
		2362	{
		2363	for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
		2364	if ((*kvp)->key == key)
2489	{	2365	{
2490	/* Basically, if the archetype has this key set,	2366	key_value *kv = *kvp;
2491	* we need to store the null value so when we save	2367	*kvp = (*kvp)->next;
2492	* it, we save the empty value so that when we load,	2368	delete kv;
2493	* we get this value back again.	2369	return;
2494	*/
2495	if (get_ob_key_link (op->arch, canonical_key))
2496	field->value = 0;
2497	else
2498	{
2499	if (last)
2500	last->next = field->next;
2501	else
2502	op->key_values = field->next;
2503
2504	delete field;
2505	}
2506	}	2370	}
2507	return TRUE;
2508	}
2509	/* IF we get here, key doesn't exist */
2510
2511	/* No field, we'll have to add it. */
2512
2513	if (!add_key)
2514	return FALSE;
2515
2516	/* There isn't any good reason to store a null
2517	* value in the key/value list. If the archetype has
2518	* this key, then we should also have it, so shouldn't
2519	* be here. If user wants to store empty strings,
2520	* should pass in ""
2521	*/
2522	if (value == NULL)
2523	return TRUE;
2524
2525	field = new key_value;
2526
2527	field->key = canonical_key;
2528	field->value = value;
2529	/* Usual prepend-addition. */
2530	field->next = op->key_values;
2531	op->key_values = field;
2532
2533	return TRUE;
2534	}
2535
2536	/*
2537	* Updates the key in op to value.
2538	*
2539	* If add_key is FALSE, this will only update existing keys,
2540	* and not add new ones.
2541	* In general, should be little reason FALSE is ever passed in for add_key
2542	*
2543	* Returns TRUE on success.
2544	*/
2545	int
2546	set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2547	{
2548	shstr key_ (key);
2549
2550	return set_ob_key_value_s (op, key_, value, add_key);
2551	}	2371	}
2552		2372
2553	object::depth_iterator::depth_iterator (object *container)	2373	object::depth_iterator::depth_iterator (object *container)
2554	: iterator_base (container)	2374	: iterator_base (container)
2555	{	2375	{
…		…
2605	{	2425	{
2606	char flagdesc[512];	2426	char flagdesc[512];
2607	char info2[256 * 4];	2427	char info2[256 * 4];
2608	char *p = info;	2428	char *p = info;
2609		2429
2610	p += snprintf (p, 512, "{cnt:%d,uuid:<1.%" PRIx64 ">,name:\"%s\"%s%s,flags:[%s],type:%d}",	2430	p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2611	count, uuid.seq,	2431	count,
		2432	uuid.c_str (),
2612	&name,	2433	&name,
2613	title ? "\",title:\"" : "",	2434	title ? ",title:\"" : "",
2614	title ? (const char *)title : "",	2435	title ? (const char *)title : "",
		2436	title ? "\"" : "",
2615	flag_desc (flagdesc, 512), type);	2437	flag_desc (flagdesc, 512), type);
2616		2438
2617	if (env)	2439	if (!flag[FLAG_REMOVED] && env)
2618	p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));	2440	p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2619		2441
2620	if (map)	2442	if (map)
2621	p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);	2443	p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2622		2444
…		…
2640	}	2462	}
2641		2463
2642	const materialtype_t *	2464	const materialtype_t *
2643	object::dominant_material () const	2465	object::dominant_material () const
2644	{	2466	{
2645	if (materialtype_t *mat = name_to_material (materialname))	2467	if (materialtype_t *mt = name_to_material (materialname))
2646	return mat;	2468	return mt;
2647		2469
2648	// omfg this is slow, this has to be temporary :)
2649	shstr unknown ("unknown");
2650
2651	return name_to_material (unknown);	2470	return name_to_material (shstr_unknown);
2652	}	2471	}
2653		2472
2654	void	2473	void
2655	object::open_container (object *new_container)	2474	object::open_container (object *new_container)
2656	{	2475	{
2657	if (container == new_container)	2476	if (container == new_container)
2658	return;	2477	return;
2659		2478
2660	if (object *old_container = container)	2479	object *old_container = container;
		2480
		2481	if (old_container)
2661	{	2482	{
2662	if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))	2483	if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))
2663	return;	2484	return;
2664		2485
2665	#if 0	2486	#if 0
…		…
2667	if (object *closer = old_container->inv)	2488	if (object *closer = old_container->inv)
2668	if (closer->type == CLOSE_CON)	2489	if (closer->type == CLOSE_CON)
2669	closer->destroy ();	2490	closer->destroy ();
2670	#endif	2491	#endif
2671		2492
		2493	// make sure the container is available
		2494	esrv_send_item (this, old_container);
		2495
2672	old_container->flag [FLAG_APPLIED] = 0;	2496	old_container->flag [FLAG_APPLIED] = false;
2673	container = 0;	2497	container = 0;
2674		2498
		2499	// client needs item update to make it work, client bug requires this to be separate
2675	esrv_update_item (UPD_FLAGS, this, old_container);	2500	esrv_update_item (UPD_FLAGS, this, old_container);
		2501
2676	new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container));	2502	new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", old_container->query_name ());
		2503	play_sound (sound_find ("chest_close"));
2677	}	2504	}
2678		2505
2679	if (new_container)	2506	if (new_container)
2680	{	2507	{
2681	if (INVOKE_OBJECT (OPEN, new_container, ARG_OBJECT (this)))	2508	if (INVOKE_OBJECT (OPEN, new_container, ARG_OBJECT (this)))
…		…
2690	closer->flag [FLAG_NO_MAP_SAVE] = 1;	2517	closer->flag [FLAG_NO_MAP_SAVE] = 1;
2691	new_container->insert (closer);	2518	new_container->insert (closer);
2692	}	2519	}
2693	#endif	2520	#endif
2694		2521
2695	new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container));	2522	new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", new_container->query_name ());
2696		2523
		2524	// make sure the container is available, client bug requires this to be separate
		2525	esrv_send_item (this, new_container);
		2526
2697	new_container->flag [FLAG_APPLIED] = 1;	2527	new_container->flag [FLAG_APPLIED] = true;
2698	container = new_container;	2528	container = new_container;
2699		2529
		2530	// client needs flag change
2700	esrv_update_item (UPD_FLAGS, this, new_container);	2531	esrv_update_item (UPD_FLAGS, this, new_container);
2701	esrv_send_inventory (this, new_container);	2532	esrv_send_inventory (this, new_container);
		2533	play_sound (sound_find ("chest_open"));
2702	}	2534	}
		2535	// else if (!old_container->env && contr && contr->ns)
		2536	// contr->ns->floorbox_reset ();
2703	}	2537	}
2704		2538
2705	object *	2539	object *
2706	object::force_find (const shstr name)	2540	object::force_find (shstr_tmp name)
2707	{	2541	{
2708	/* cycle through his inventory to look for the MARK we want to	2542	/* cycle through his inventory to look for the MARK we want to
2709	* place	2543	* place
2710	*/	2544	*/
2711	for (object *tmp = inv; tmp; tmp = tmp->below)	2545	for (object *tmp = inv; tmp; tmp = tmp->below)
…		…
2713	return splay (tmp);	2547	return splay (tmp);
2714		2548
2715	return 0;	2549	return 0;
2716	}	2550	}
2717		2551
2718	void	2552	object *
2719	object::force_add (const shstr name, int duration)	2553	object::force_add (shstr_tmp name, int duration)
2720	{	2554	{
2721	if (object *force = force_find (name))	2555	if (object *force = force_find (name))
2722	force->destroy ();	2556	force->destroy ();
2723		2557
2724	object *force = get_archetype (FORCE_NAME);	2558	object *force = get_archetype (FORCE_NAME);
…		…
2729		2563
2730	force->set_speed (duration ? 1.f / duration : 0.f);	2564	force->set_speed (duration ? 1.f / duration : 0.f);
2731	force->flag [FLAG_IS_USED_UP] = true;	2565	force->flag [FLAG_IS_USED_UP] = true;
2732	force->flag [FLAG_APPLIED] = true;	2566	force->flag [FLAG_APPLIED] = true;
2733		2567
		2568	return insert (force);
		2569	}
		2570
		2571	void
		2572	object::play_sound (faceidx sound) const
		2573	{
		2574	if (!sound)
		2575	return;
		2576
		2577	if (is_on_map ())
		2578	map->play_sound (sound, x, y);
		2579	else if (object *pl = in_player ())
		2580	pl->contr->play_sound (sound);
		2581	}
		2582
		2583	void
		2584	object::say_msg (const char *msg) const
		2585	{
		2586	if (is_on_map ())
		2587	map->say_msg (msg, x, y);
		2588	else if (object *pl = in_player ())
		2589	pl->contr->play_sound (sound);
		2590	}
		2591
		2592	void
		2593	object::make_noise ()
		2594	{
		2595	// we do not model noise in the map, so instead put
		2596	// a temporary light into the noise source
		2597	// could use the map instead, but that's less reliable for our
		2598	// goal, which is to make invisibility a bit harder to exploit
		2599
		2600	// currently only works sensibly for players
		2601	if (!is_player ())
		2602	return;
		2603
		2604	// find old force, or create new one
		2605	object *force = force_find (shstr_noise_force);
		2606
		2607	if (force)
		2608	force->speed_left = -1.f; // patch old speed up
		2609	else
		2610	{
		2611	force = archetype::get (shstr_noise_force);
		2612
		2613	force->slaying = shstr_noise_force;
		2614	force->stats.food = 1;
		2615	force->speed_left = -1.f;
		2616
		2617	force->set_speed (1.f / 4.f);
		2618	force->flag [FLAG_IS_USED_UP] = true;
		2619	force->flag [FLAG_APPLIED] = true;
		2620
2734	insert (force);	2621	insert (force);
		2622	}
2735	}	2623	}
2736		2624
2737

Diff Legend

–	Removed lines
+	Added lines
<	Changed lines
>	Changed lines