| … | |
… | |
| 1231 | |
1231 | |
| 1232 | object *top, *floor = NULL; |
1232 | object *top, *floor = NULL; |
| 1233 | |
1233 | |
| 1234 | op->remove (); |
1234 | op->remove (); |
| 1235 | |
1235 | |
| 1236 | if (out_of_map (m, op->x, op->y)) |
|
|
| 1237 | { |
|
|
| 1238 | LOG (llevError, "Trying to insert object outside the map.\n%s\n", op->debug_desc ()); |
|
|
| 1239 | #ifdef MANY_CORES |
|
|
| 1240 | /* Better to catch this here, as otherwise the next use of this object |
|
|
| 1241 | * is likely to cause a crash. Better to find out where it is getting |
|
|
| 1242 | * improperly inserted. |
|
|
| 1243 | */ |
|
|
| 1244 | abort (); |
|
|
| 1245 | #endif |
|
|
| 1246 | return op; |
|
|
| 1247 | } |
|
|
| 1248 | |
|
|
| 1249 | if (object *more = op->more) |
|
|
| 1250 | if (!insert_ob_in_map (more, m, originator, flag)) |
|
|
| 1251 | return 0; |
|
|
| 1252 | |
|
|
| 1253 | CLEAR_FLAG (op, FLAG_REMOVED); |
|
|
| 1254 | |
|
|
| 1255 | /* Ideally, the caller figures this out. However, it complicates a lot |
1236 | /* Ideally, the caller figures this out. However, it complicates a lot |
| 1256 | * of areas of callers (eg, anything that uses find_free_spot would now |
1237 | * of areas of callers (eg, anything that uses find_free_spot would now |
| 1257 | * need extra work |
1238 | * need extra work |
| 1258 | */ |
1239 | */ |
| 1259 | if (!xy_normalise (m, op->x, op->y)) |
1240 | if (!xy_normalise (m, op->x, op->y)) |
|
|
1241 | { |
|
|
1242 | op->destroy (); |
| 1260 | return 0; |
1243 | return 0; |
|
|
1244 | } |
|
|
1245 | |
|
|
1246 | if (object *more = op->more) |
|
|
1247 | if (!insert_ob_in_map (more, m, originator, flag)) |
|
|
1248 | return 0; |
|
|
1249 | |
|
|
1250 | CLEAR_FLAG (op, FLAG_REMOVED); |
| 1261 | |
1251 | |
| 1262 | op->map = m; |
1252 | op->map = m; |
| 1263 | mapspace &ms = op->ms (); |
1253 | mapspace &ms = op->ms (); |
| 1264 | |
1254 | |
| 1265 | /* this has to be done after we translate the coordinates. |
1255 | /* this has to be done after we translate the coordinates. |
| … | |
… | |
| 2001 | * customized, changed states, etc. |
1991 | * customized, changed states, etc. |
| 2002 | */ |
1992 | */ |
| 2003 | int |
1993 | int |
| 2004 | find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop) |
1994 | find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop) |
| 2005 | { |
1995 | { |
|
|
1996 | int altern[SIZEOFFREE]; |
| 2006 | int index = 0, flag; |
1997 | int index = 0, flag; |
| 2007 | int altern[SIZEOFFREE]; |
|
|
| 2008 | |
1998 | |
| 2009 | for (int i = start; i < stop; i++) |
1999 | for (int i = start; i < stop; i++) |
| 2010 | { |
2000 | { |
| 2011 | flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]); |
2001 | mapxy pos (m, x, y); pos.move (i); |
| 2012 | if (!flag) |
2002 | |
|
|
2003 | if (!pos.normalise ()) |
|
|
2004 | continue; |
|
|
2005 | |
|
|
2006 | mapspace &ms = *pos; |
|
|
2007 | |
|
|
2008 | if (ms.flags () & P_IS_ALIVE) |
|
|
2009 | continue; |
|
|
2010 | |
|
|
2011 | /* However, often |
|
|
2012 | * ob doesn't have any move type (when used to place exits) |
|
|
2013 | * so the AND operation in OB_TYPE_MOVE_BLOCK doesn't work. |
|
|
2014 | */ |
|
|
2015 | if (ob->move_type == 0 && ms.move_block != MOVE_ALL) |
|
|
2016 | { |
| 2013 | altern [index++] = i; |
2017 | altern [index++] = i; |
|
|
2018 | continue; |
|
|
2019 | } |
| 2014 | |
2020 | |
| 2015 | /* Basically, if we find a wall on a space, we cut down the search size. |
2021 | /* Basically, if we find a wall on a space, we cut down the search size. |
| 2016 | * In this way, we won't return spaces that are on another side of a wall. |
2022 | * In this way, we won't return spaces that are on another side of a wall. |
| 2017 | * This mostly work, but it cuts down the search size in all directions - |
2023 | * This mostly work, but it cuts down the search size in all directions - |
| 2018 | * if the space being examined only has a wall to the north and empty |
2024 | * if the space being examined only has a wall to the north and empty |
| 2019 | * spaces in all the other directions, this will reduce the search space |
2025 | * spaces in all the other directions, this will reduce the search space |
| 2020 | * to only the spaces immediately surrounding the target area, and |
2026 | * to only the spaces immediately surrounding the target area, and |
| 2021 | * won't look 2 spaces south of the target space. |
2027 | * won't look 2 spaces south of the target space. |
| 2022 | */ |
2028 | */ |
| 2023 | else if ((flag & P_NO_PASS) && maxfree[i] < stop) |
2029 | if (ms.move_block == MOVE_ALL && maxfree[i] < stop) |
|
|
2030 | { |
| 2024 | stop = maxfree[i]; |
2031 | stop = maxfree[i]; |
|
|
2032 | continue; |
|
|
2033 | } |
|
|
2034 | |
|
|
2035 | /* Note it is intentional that we check ob - the movement type of the |
|
|
2036 | * head of the object should correspond for the entire object. |
|
|
2037 | */ |
|
|
2038 | if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block)) |
|
|
2039 | continue; |
|
|
2040 | |
|
|
2041 | altern [index++] = i; |
| 2025 | } |
2042 | } |
| 2026 | |
2043 | |
| 2027 | if (!index) |
2044 | if (!index) |
| 2028 | return -1; |
2045 | return -1; |
| 2029 | |
2046 | |
| … | |
… | |
| 2038 | */ |
2055 | */ |
| 2039 | int |
2056 | int |
| 2040 | find_first_free_spot (const object *ob, maptile *m, int x, int y) |
2057 | find_first_free_spot (const object *ob, maptile *m, int x, int y) |
| 2041 | { |
2058 | { |
| 2042 | for (int i = 0; i < SIZEOFFREE; i++) |
2059 | for (int i = 0; i < SIZEOFFREE; i++) |
| 2043 | if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i])) |
2060 | if (!ob->blocked (m, x + freearr_x[i], y + freearr_y[i])) |
| 2044 | return i; |
2061 | return i; |
| 2045 | |
2062 | |
| 2046 | return -1; |
2063 | return -1; |
| 2047 | } |
2064 | } |
| 2048 | |
2065 | |
