ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.194 by root, Tue Oct 16 00:30:24 2007 UTC vs.
Revision 1.230 by root, Sun May 4 08:25:32 2008 UTC

1/* 1/*
2 * This file is part of Crossfire TRT, the Roguelike Realtime MORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007 Marc Alexander Lehmann / Robin Redeker / the Crossfire TRT team 4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 * 7 *
8 * Crossfire TRT is free software: you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify
9 * it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
10 * the Free Software Foundation, either version 3 of the License, or 10 * the Free Software Foundation, either version 3 of the License, or
11 * (at your option) any later version. 11 * (at your option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
19 * along with this program. If not, see <http://www.gnu.org/licenses/>. 19 * along with this program. If not, see <http://www.gnu.org/licenses/>.
20 * 20 *
21 * The authors can be reached via e-mail to <crossfire@schmorp.de> 21 * The authors can be reached via e-mail to <support@deliantra.net>
22 */ 22 */
23 23
24/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
25 sub/add_weight will transcend the environment updating the carrying
26 variable. */
27#include <global.h> 24#include <global.h>
28#include <stdio.h> 25#include <stdio.h>
29#include <sys/types.h> 26#include <sys/types.h>
30#include <sys/uio.h> 27#include <sys/uio.h>
31#include <object.h> 28#include <object.h>
32#include <funcpoint.h>
33#include <sproto.h> 29#include <sproto.h>
34#include <loader.h> 30#include <loader.h>
35 31
36#include <bitset> 32#include <bitset>
37 33
38int nrofallocobjects = 0; 34UUID UUID::cur;
39static UUID uuid; 35static uint64_t seq_next_save;
40const uint64 UUID_SKIP = 1<<19; 36static const uint64 UUID_GAP = 1<<19;
41 37
42objectvec objects; 38objectvec objects;
43activevec actives; 39activevec actives;
44 40
45short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 41short freearr_x[SIZEOFFREE] = {
42 0,
43 0, 1, 1, 1, 0, -1, -1, -1,
44 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
46 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1 45 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1
47}; 46};
48short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, 47short freearr_y[SIZEOFFREE] = {
48 0,
49 -1, -1, 0, 1, 1, 1, 0, -1,
50 -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
49 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3 51 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3
50}; 52};
51int maxfree[SIZEOFFREE] = { 0, 9, 10, 13, 14, 17, 18, 21, 22, 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 53int maxfree[SIZEOFFREE] = {
54 0,
55 9, 10, 13, 14, 17, 18, 21, 22,
56 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
52 48, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49 57 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
53}; 58};
54int freedir[SIZEOFFREE] = { 59int freedir[SIZEOFFREE] = {
55 0, 1, 2, 3, 4, 5, 6, 7, 8, 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8, 60 0,
61 1, 2, 3, 4, 5, 6, 7, 8,
62 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,
56 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8 63 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8
57}; 64};
58 65
59static void 66static void
60write_uuid (void) 67write_uuid (uval64 skip, bool sync)
61{ 68{
62 char filename1[MAX_BUF], filename2[MAX_BUF]; 69 CALL_BEGIN (2);
63 70 CALL_ARG_SV (newSVval64 (skip));
64 sprintf (filename1, "%s/uuid", settings.localdir); 71 CALL_ARG_SV (boolSV (sync));
65 sprintf (filename2, "%s/uuid~", settings.localdir); 72 CALL_CALL ("cf::write_uuid", G_DISCARD);
66 73 CALL_END;
67 FILE *fp;
68
69 if (!(fp = fopen (filename2, "w")))
70 {
71 LOG (llevError, "ERROR: cannot open %s for writing, unable to write UUID!\n", filename2);
72 return;
73 }
74
75 fprintf (fp, "<1,%llx>\n", (unsigned long long)uuid.seq + UUID_SKIP * 2);
76 fclose (fp);
77 rename (filename2, filename1);
78} 74}
79 75
80static void 76static void
81read_uuid (void) 77read_uuid (void)
82{ 78{
83 char filename[MAX_BUF]; 79 char filename[MAX_BUF];
84 80
85 sprintf (filename, "%s/uuid", settings.localdir); 81 sprintf (filename, "%s/uuid", settings.localdir);
82
83 seq_next_save = 0;
86 84
87 FILE *fp; 85 FILE *fp;
88 86
89 if (!(fp = fopen (filename, "r"))) 87 if (!(fp = fopen (filename, "r")))
90 { 88 {
91 if (errno == ENOENT) 89 if (errno == ENOENT)
92 { 90 {
93 LOG (llevInfo, "RESET uid to 1\n"); 91 LOG (llevInfo, "RESET uid to 1\n");
94 uuid.seq = 0; 92 UUID::cur.seq = 0;
95 write_uuid (); 93 write_uuid (UUID_GAP, true);
96 return; 94 return;
97 } 95 }
98 96
99 LOG (llevError, "FATAL: cannot open %s for reading!\n", filename); 97 LOG (llevError, "FATAL: cannot open %s for reading!\n", filename);
100 _exit (1); 98 _exit (1);
101 } 99 }
102 100
103 int version; 101 UUID::BUF buf;
104 unsigned long long uid; 102 buf[0] = 0;
105 if (2 != fscanf (fp, "<%d,%llx>\n", &version, &uid) || version != 1) 103 fgets (buf, sizeof (buf), fp);
104
105 if (!UUID::cur.parse (buf))
106 { 106 {
107 LOG (llevError, "FATAL: error reading uid from %s!\n", filename); 107 LOG (llevError, "FATAL: error reading uid from %s (%s)!\n", filename, buf);
108 _exit (1); 108 _exit (1);
109 } 109 }
110 110
111 uuid.seq = uid; 111 LOG (llevDebug, "read UUID: %s\n", UUID::cur.c_str ());
112 write_uuid (); 112
113 LOG (llevDebug, "read UID: %" PRId64 "\n", uid); 113 write_uuid (UUID_GAP, true);
114 fclose (fp); 114 fclose (fp);
115} 115}
116 116
117UUID 117UUID
118gen_uuid () 118UUID::gen ()
119{ 119{
120 UUID uid; 120 UUID uid;
121 121
122 uid.seq = ++uuid.seq; 122 uid.seq = ++cur.seq;
123 123
124 if (!(uuid.seq & (UUID_SKIP - 1))) 124 if (expect_false (cur.seq >= seq_next_save))
125 write_uuid (); 125 {
126 seq_next_save = UUID::cur.seq + (UUID_GAP >> 1);
127 write_uuid (UUID_GAP, false);
128 }
129
126 130
127 return uid; 131 return uid;
128} 132}
129 133
130void 134void
131init_uuid () 135UUID::init ()
132{ 136{
133 read_uuid (); 137 read_uuid ();
134} 138}
135 139
136/* Returns TRUE if every key_values in wants has a partner with the same value in has. */ 140/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
137static int 141static bool
138compare_ob_value_lists_one (const object *wants, const object *has) 142compare_ob_value_lists_one (const object *wants, const object *has)
139{ 143{
140 key_value *wants_field;
141
142 /* n-squared behaviour (see get_ob_key_link()), but I'm hoping both 144 /* n-squared behaviour (see kv_get), but I'm hoping both
143 * objects with lists are rare, and lists stay short. If not, use a 145 * objects with lists are rare, and lists stay short. If not, use a
144 * different structure or at least keep the lists sorted... 146 * different structure or at least keep the lists sorted...
145 */ 147 */
146 148
147 /* For each field in wants, */ 149 /* For each field in wants, */
148 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next) 150 for (key_value *kv = wants->key_values; kv; kv = kv->next)
149 { 151 if (has->kv_get (kv->key) != kv->value)
150 key_value *has_field; 152 return false;
151
152 /* Look for a field in has with the same key. */
153 has_field = get_ob_key_link (has, wants_field->key);
154
155 if (has_field == NULL)
156 {
157 /* No field with that name. */
158 return FALSE;
159 }
160
161 /* Found the matching field. */
162 if (has_field->value != wants_field->value)
163 {
164 /* Values don't match, so this half of the comparison is false. */
165 return FALSE;
166 }
167
168 /* If we get here, we found a match. Now for the next field in wants. */
169 }
170 153
171 /* If we get here, every field in wants has a matching field in has. */ 154 /* If we get here, every field in wants has a matching field in has. */
172 return TRUE; 155 return true;
173} 156}
174 157
175/* Returns TRUE if ob1 has the same key_values as ob2. */ 158/* Returns TRUE if ob1 has the same key_values as ob2. */
176static int 159static bool
177compare_ob_value_lists (const object *ob1, const object *ob2) 160compare_ob_value_lists (const object *ob1, const object *ob2)
178{ 161{
179 /* However, there may be fields in has which aren't partnered in wants, 162 /* However, there may be fields in has which aren't partnered in wants,
180 * so we need to run the comparison *twice*. :( 163 * so we need to run the comparison *twice*. :(
181 */ 164 */
182 return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1); 165 return compare_ob_value_lists_one (ob1, ob2)
166 && compare_ob_value_lists_one (ob2, ob1);
183} 167}
184 168
185/* Function examines the 2 objects given to it, and returns true if 169/* Function examines the 2 objects given to it, and returns true if
186 * they can be merged together. 170 * they can be merged together.
187 * 171 *
202 || ob1->speed != ob2->speed 186 || ob1->speed != ob2->speed
203 || ob1->value != ob2->value 187 || ob1->value != ob2->value
204 || ob1->name != ob2->name) 188 || ob1->name != ob2->name)
205 return 0; 189 return 0;
206 190
207 //TODO: this ain't working well, use nicer and correct overflow check 191 /* Do not merge objects if nrof would overflow. First part checks
208 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that 192 * for unsigned overflow (2c), second part checks whether the result
209 * value could not be stored in a sint32 (which unfortunately sometimes is 193 * would fit into a 32 bit signed int, which is often used to hold
210 * used to store nrof). 194 * nrof values.
211 */ 195 */
212 if (ob1->nrof + ob2->nrof >= 1UL << 31) 196 if (~ob1->nrof < ob2->nrof || ob1->nrof + ob2->nrof > (1UL << 31))
213 return 0; 197 return 0;
214 198
215 /* If the objects have been identified, set the BEEN_APPLIED flag. 199 /* If the objects have been identified, set the BEEN_APPLIED flag.
216 * This is to the comparison of the flags below will be OK. We 200 * This is to the comparison of the flags below will be OK. We
217 * just can't ignore the been applied or identified flags, as they 201 * just can't ignore the been applied or identified flags, as they
218 * are not equal - just if it has been identified, the been_applied 202 * are not equal - just if it has been identified, the been_applied
219 * flags lose any meaning. 203 * flags lose any meaning.
220 */ 204 */
221 if (QUERY_FLAG (ob1, FLAG_IDENTIFIED)) 205 if (QUERY_FLAG (ob1, FLAG_IDENTIFIED))
222 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 206 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
223 207
224 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 208 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
225 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 209 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
226 210
227 if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any () 211 if (ob1->arch->name != ob2->arch->name
228 || ob1->arch != ob2->arch
229 || ob1->name != ob2->name 212 || ob1->name != ob2->name
230 || ob1->title != ob2->title 213 || ob1->title != ob2->title
231 || ob1->msg != ob2->msg 214 || ob1->msg != ob2->msg
232 || ob1->weight != ob2->weight 215 || ob1->weight != ob2->weight
233 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
234 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
235 || ob1->attacktype != ob2->attacktype 216 || ob1->attacktype != ob2->attacktype
236 || ob1->magic != ob2->magic 217 || ob1->magic != ob2->magic
237 || ob1->slaying != ob2->slaying 218 || ob1->slaying != ob2->slaying
238 || ob1->skill != ob2->skill 219 || ob1->skill != ob2->skill
239 || ob1->value != ob2->value 220 || ob1->value != ob2->value
246 || ob1->move_block != ob2->move_block 227 || ob1->move_block != ob2->move_block
247 || ob1->move_allow != ob2->move_allow 228 || ob1->move_allow != ob2->move_allow
248 || ob1->move_on != ob2->move_on 229 || ob1->move_on != ob2->move_on
249 || ob1->move_off != ob2->move_off 230 || ob1->move_off != ob2->move_off
250 || ob1->move_slow != ob2->move_slow 231 || ob1->move_slow != ob2->move_slow
251 || ob1->move_slow_penalty != ob2->move_slow_penalty) 232 || ob1->move_slow_penalty != ob2->move_slow_penalty
233 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
234 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
252 return 0; 235 return 0;
253 236
237 if ((ob1->flag ^ ob2->flag)
238 .reset (FLAG_INV_LOCKED)
239 .reset (FLAG_CLIENT_SENT)
240 .reset (FLAG_REMOVED)
241 .any ())
242 return 0;
243
254 /* This is really a spellbook check - really, we should 244 /* This is really a spellbook check - we should in general
255 * check all objects in the inventory. 245 * not merge objects with real inventories, as splitting them
246 * is hard.
256 */ 247 */
257 if (ob1->inv || ob2->inv) 248 if (ob1->inv || ob2->inv)
258 { 249 {
259 if (!(ob1->inv && ob2->inv)) 250 if (!(ob1->inv && ob2->inv))
260 return 0; /* inventories differ in length */ 251 return 0; /* inventories differ in length */
261 252
262 if (ob1->inv->below || ob2->inv->below) 253 if (ob1->inv->below || ob2->inv->below)
263 return 0; /* more than one object in inv */ 254 return 0; /* more than one object in inv */
264 255
265 if (!object::can_merge (ob1->inv, ob2->inv)) 256 if (!object::can_merge (ob1->inv, ob2->inv))
266 return 0; /* inventory objexts differ */ 257 return 0; /* inventory objects differ */
267 258
268 /* inventory ok - still need to check rest of this object to see 259 /* inventory ok - still need to check rest of this object to see
269 * if it is valid. 260 * if it is valid.
270 */ 261 */
271 } 262 }
290 if (ob1->level != ob2->level) 281 if (ob1->level != ob2->level)
291 return 0; 282 return 0;
292 break; 283 break;
293 } 284 }
294 285
295 if (ob1->key_values != NULL || ob2->key_values != NULL) 286 if (ob1->key_values || ob2->key_values)
296 { 287 {
297 /* At least one of these has key_values. */ 288 /* At least one of these has key_values. */
298 if ((ob1->key_values == NULL) != (ob2->key_values == NULL)) 289 if ((!ob1->key_values) != (!ob2->key_values))
299 /* One has fields, but the other one doesn't. */ 290 return 0; /* One has fields, but the other one doesn't. */
300 return 0; 291
301 else if (!compare_ob_value_lists (ob1, ob2)) 292 if (!compare_ob_value_lists (ob1, ob2))
302 return 0; 293 return 0;
303 } 294 }
304 295
305 if (ob1->self || ob2->self) 296 if (ob1->self || ob2->self)
306 { 297 {
307 ob1->optimise (); 298 ob1->optimise ();
308 ob2->optimise (); 299 ob2->optimise ();
309 300
310 if (ob1->self || ob2->self) 301 if (ob1->self || ob2->self)
311 { 302 {
312 int k1 = ob1->self ? HvTOTALKEYS (SvRV (ob1->self)) : 0; 303 int k1 = ob1->self ? HvTOTALKEYS (ob1->self) : 0;
313 int k2 = ob2->self ? HvTOTALKEYS (SvRV (ob2->self)) : 0; 304 int k2 = ob2->self ? HvTOTALKEYS (ob2->self) : 0;
314 305
315 if (k1 != k2) 306 if (k1 != k2)
316 return 0; 307 return 0;
308
317 else if (k1 == 0) 309 if (k1 == 0)
318 return 1; 310 return 1;
311
319 else if (!cfperl_can_merge (ob1, ob2)) 312 if (!cfperl_can_merge (ob1, ob2))
320 return 0; 313 return 0;
321 } 314 }
322 } 315 }
323 316
324 /* Everything passes, must be OK. */ 317 /* Everything passes, must be OK. */
325 return 1; 318 return 1;
326} 319}
327 320
321// find player who can see this object
322object *
323object::visible_to () const
324{
325 if (client_visible () && !flag [FLAG_REMOVED])
326 {
327 // see if we are in a container of sorts
328 if (env)
329 {
330 // the player inventory itself is always visible
331 if (env->type == PLAYER)
332 return env;
333
334 // else a player could have our env open
335 object *envest = env->outer_env ();
336
337 // the player itself is always on a map, so we will find him here
338 // even if our inv is in a player.
339 if (envest->is_on_map ())
340 if (object *pl = envest->ms ().player ())
341 if (pl->container == env)
342 return pl;
343 }
344 else
345 {
346 // maybe there is a player standing on the same mapspace
347 // this will catch the case where "this" is a player
348 if (object *pl = ms ().player ())
349 if (!pl->container || this == pl->container)
350 return pl;
351 }
352 }
353
354 return 0;
355}
356
357// adjust weight per container type ("of holding")
358static sint32
359weight_adjust (object *op, sint32 weight)
360{
361 return op->type == CONTAINER
362 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str)
363 : weight;
364}
365
328/* 366/*
367 * adjust_weight(object, weight) adds the specified weight to an object,
368 * and also updates how much the environment(s) is/are carrying.
369 */
370static void
371adjust_weight (object *op, sint32 weight)
372{
373 while (op)
374 {
375 weight = weight_adjust (op, weight);
376
377 if (!weight)
378 return;
379
380 op->carrying += weight;
381
382 if (object *pl = op->visible_to ())
383 if (pl != op) // player is handled lazily
384 esrv_update_item (UPD_WEIGHT, pl, op);
385
386 op = op->env;
387 }
388}
389
390/*
329 * sum_weight() is a recursive function which calculates the weight 391 * this is a recursive function which calculates the weight
330 * an object is carrying. It goes through in figures out how much 392 * an object is carrying. It goes through op and figures out how much
331 * containers are carrying, and sums it up. 393 * containers are carrying, and sums it up.
332 */ 394 */
333long 395void
334sum_weight (object *op) 396object::update_weight ()
335{ 397{
336 long sum; 398 sint32 sum = 0;
337 object *inv;
338 399
339 for (sum = 0, inv = op->inv; inv; inv = inv->below) 400 for (object *op = inv; op; op = op->below)
340 { 401 {
341 if (inv->inv) 402 if (op->inv)
342 sum_weight (inv); 403 op->update_weight ();
343 404
344 sum += inv->carrying + inv->weight * (inv->nrof ? inv->nrof : 1); 405 sum += op->total_weight ();
406 }
407
408 sum = weight_adjust (this, sum);
409
410 if (sum != carrying)
345 } 411 {
346
347 if (op->type == CONTAINER && op->stats.Str)
348 sum = (sum * (100 - op->stats.Str)) / 100;
349
350 if (op->carrying != sum)
351 op->carrying = sum; 412 carrying = sum;
352 413
353 return sum; 414 if (object *pl = visible_to ())
415 if (pl != this) // player is handled lazily
416 esrv_update_item (UPD_WEIGHT, pl, this);
417 }
354} 418}
355 419
356/** 420/*
357 * Return the outermost environment object for a given object. 421 * Used by: Server DM commands: dumpbelow, dump. Some error messages.
358 */
359
360object *
361object_get_env_recursive (object *op)
362{
363 while (op->env != NULL)
364 op = op->env;
365 return op;
366}
367
368/*
369 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
370 * Some error messages.
371 * The result of the dump is stored in the static global errmsg array.
372 */ 422 */
373char * 423char *
374dump_object (object *op) 424dump_object (object *op)
375{ 425{
376 if (!op) 426 if (!op)
390get_nearest_part (object *op, const object *pl) 440get_nearest_part (object *op, const object *pl)
391{ 441{
392 object *tmp, *closest; 442 object *tmp, *closest;
393 int last_dist, i; 443 int last_dist, i;
394 444
395 if (op->more == NULL) 445 if (!op->more)
396 return op; 446 return op;
447
397 for (last_dist = distance (op, pl), closest = op, tmp = op->more; tmp != NULL; tmp = tmp->more) 448 for (last_dist = distance (op, pl), closest = op, tmp = op->more;
449 tmp;
450 tmp = tmp->more)
398 if ((i = distance (tmp, pl)) < last_dist) 451 if ((i = distance (tmp, pl)) < last_dist)
399 closest = tmp, last_dist = i; 452 closest = tmp, last_dist = i;
453
400 return closest; 454 return closest;
401} 455}
402 456
403/* 457/*
404 * Returns the object which has the count-variable equal to the argument. 458 * Returns the object which has the count-variable equal to the argument.
459 * VERRRY slow.
405 */ 460 */
406object * 461object *
407find_object (tag_t i) 462find_object (tag_t i)
408{ 463{
409 for_all_objects (op) 464 for_all_objects (op)
427 for_all_objects (op) 482 for_all_objects (op)
428 if (op->name == str_) 483 if (op->name == str_)
429 break; 484 break;
430 485
431 return op; 486 return op;
432}
433
434void
435free_all_object_data ()
436{
437 LOG (llevDebug, "%d allocated objects\n", nrofallocobjects);
438} 487}
439 488
440/* 489/*
441 * Sets the owner and sets the skill and exp pointers to owner's current 490 * Sets the owner and sets the skill and exp pointers to owner's current
442 * skill and experience objects. 491 * skill and experience objects.
447{ 496{
448 // allow objects which own objects 497 // allow objects which own objects
449 if (owner) 498 if (owner)
450 while (owner->owner) 499 while (owner->owner)
451 owner = owner->owner; 500 owner = owner->owner;
501
502 if (flag [FLAG_FREED])
503 {
504 LOG (llevError | logBacktrace, "tried to set owner of %s to %s\n", debug_desc (), owner->debug_desc ());
505 return;
506 }
452 507
453 this->owner = owner; 508 this->owner = owner;
454} 509}
455 510
456int 511int
534 } 589 }
535 590
536 op->key_values = 0; 591 op->key_values = 0;
537} 592}
538 593
539object & 594/*
540object::operator =(const object &src) 595 * copy_to first frees everything allocated by the dst object,
596 * and then copies the contents of itself into the second
597 * object, allocating what needs to be allocated. Basically, any
598 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
599 * if the first object is freed, the pointers in the new object
600 * will point at garbage.
601 */
602void
603object::copy_to (object *dst)
541{ 604{
542 bool is_freed = flag [FLAG_FREED]; 605 dst->remove ();
543 bool is_removed = flag [FLAG_REMOVED];
544
545 *(object_copy *)this = src; 606 *(object_copy *)dst = *this;
546
547 flag [FLAG_FREED] = is_freed;
548 flag [FLAG_REMOVED] = is_removed; 607 dst->flag [FLAG_REMOVED] = true;
549 608
550 /* Copy over key_values, if any. */ 609 /* Copy over key_values, if any. */
551 if (src.key_values) 610 if (key_values)
552 { 611 {
553 key_value *tail = 0; 612 key_value *tail = 0;
554 key_values = 0; 613 dst->key_values = 0;
555 614
556 for (key_value *i = src.key_values; i; i = i->next) 615 for (key_value *i = key_values; i; i = i->next)
557 { 616 {
558 key_value *new_link = new key_value; 617 key_value *new_link = new key_value;
559 618
560 new_link->next = 0; 619 new_link->next = 0;
561 new_link->key = i->key; 620 new_link->key = i->key;
562 new_link->value = i->value; 621 new_link->value = i->value;
563 622
564 /* Try and be clever here, too. */ 623 /* Try and be clever here, too. */
565 if (!key_values) 624 if (!dst->key_values)
566 { 625 {
567 key_values = new_link; 626 dst->key_values = new_link;
568 tail = new_link; 627 tail = new_link;
569 } 628 }
570 else 629 else
571 { 630 {
572 tail->next = new_link; 631 tail->next = new_link;
573 tail = new_link; 632 tail = new_link;
574 } 633 }
575 } 634 }
576 } 635 }
577}
578
579/*
580 * copy_to first frees everything allocated by the dst object,
581 * and then copies the contents of itself into the second
582 * object, allocating what needs to be allocated. Basically, any
583 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
584 * if the first object is freed, the pointers in the new object
585 * will point at garbage.
586 */
587void
588object::copy_to (object *dst)
589{
590 *dst = *this;
591 636
592 if (speed < 0) 637 if (speed < 0)
593 dst->speed_left -= rndm (); 638 dst->speed_left -= rndm ();
594 639
595 dst->set_speed (dst->speed); 640 dst->set_speed (dst->speed);
597 642
598void 643void
599object::instantiate () 644object::instantiate ()
600{ 645{
601 if (!uuid.seq) // HACK 646 if (!uuid.seq) // HACK
602 uuid = gen_uuid (); 647 uuid = UUID::gen ();
603 648
604 speed_left = -0.1f; 649 speed_left = -0.1f;
605 /* copy the body_info to the body_used - this is only really 650 /* copy the body_info to the body_used - this is only really
606 * need for monsters, but doesn't hurt to do it for everything. 651 * need for monsters, but doesn't hurt to do it for everything.
607 * by doing so, when a monster is created, it has good starting 652 * by doing so, when a monster is created, it has good starting
617object * 662object *
618object::clone () 663object::clone ()
619{ 664{
620 object *neu = create (); 665 object *neu = create ();
621 copy_to (neu); 666 copy_to (neu);
667 neu->map = map; // not copied by copy_to
622 return neu; 668 return neu;
623} 669}
624 670
625/* 671/*
626 * If an object with the IS_TURNABLE() flag needs to be turned due 672 * If an object with the IS_TURNABLE() flag needs to be turned due
677 * UP_OBJ_FACE: only the objects face has changed. 723 * UP_OBJ_FACE: only the objects face has changed.
678 */ 724 */
679void 725void
680update_object (object *op, int action) 726update_object (object *op, int action)
681{ 727{
682 if (op == NULL) 728 if (!op)
683 { 729 {
684 /* this should never happen */ 730 /* this should never happen */
685 LOG (llevDebug, "update_object() called for NULL object.\n"); 731 LOG (llevError | logBacktrace, "update_object() called for NULL object.\n");
686 return; 732 return;
687 } 733 }
688 734
689 if (op->env) 735 if (!op->is_on_map ())
690 { 736 {
691 /* Animation is currently handled by client, so nothing 737 /* Animation is currently handled by client, so nothing
692 * to do in this case. 738 * to do in this case.
693 */ 739 */
694 return; 740 return;
695 } 741 }
696
697 /* If the map is saving, don't do anything as everything is
698 * going to get freed anyways.
699 */
700 if (!op->map || op->map->in_memory == MAP_SAVING)
701 return;
702 742
703 /* make sure the object is within map boundaries */ 743 /* make sure the object is within map boundaries */
704 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height) 744 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
705 { 745 {
706 LOG (llevError, "update_object() called for object out of map!\n"); 746 LOG (llevError, "update_object() called for object out of map!\n");
766static int object_count; 806static int object_count;
767 807
768void object::link () 808void object::link ()
769{ 809{
770 assert (!index);//D 810 assert (!index);//D
771 uuid = gen_uuid (); 811 uuid = UUID::gen ();
772 count = ++object_count; 812 count = ++object_count;
773 813
774 refcnt_inc (); 814 refcnt_inc ();
775 objects.insert (this); 815 objects.insert (this);
776} 816}
849object::destroy_inv (bool drop_to_ground) 889object::destroy_inv (bool drop_to_ground)
850{ 890{
851 // need to check first, because the checks below might segfault 891 // need to check first, because the checks below might segfault
852 // as we might be on an invalid mapspace and crossfire code 892 // as we might be on an invalid mapspace and crossfire code
853 // is too buggy to ensure that the inventory is empty. 893 // is too buggy to ensure that the inventory is empty.
854 // corollary: if you create arrows etc. with stuff in tis inventory, 894 // corollary: if you create arrows etc. with stuff in its inventory,
855 // cf will crash below with off-map x and y 895 // cf will crash below with off-map x and y
856 if (!inv) 896 if (!inv)
857 return; 897 return;
858 898
859 /* Only if the space blocks everything do we not process - 899 /* Only if the space blocks everything do we not process -
860 * if some form of movement is allowed, let objects 900 * if some form of movement is allowed, let objects
861 * drop on that space. 901 * drop on that space.
862 */ 902 */
863 if (!drop_to_ground 903 if (!drop_to_ground
864 || !map 904 || !map
865 || map->in_memory != MAP_IN_MEMORY 905 || map->in_memory != MAP_ACTIVE
866 || map->nodrop 906 || map->nodrop
867 || ms ().move_block == MOVE_ALL) 907 || ms ().move_block == MOVE_ALL)
868 { 908 {
869 while (inv) 909 while (inv)
870 { 910 {
871 inv->destroy_inv (drop_to_ground); 911 inv->destroy_inv (false);
872 inv->destroy (); 912 inv->destroy ();
873 } 913 }
874 } 914 }
875 else 915 else
876 { /* Put objects in inventory onto this space */ 916 { /* Put objects in inventory onto this space */
882 || op->flag [FLAG_NO_DROP] 922 || op->flag [FLAG_NO_DROP]
883 || op->type == RUNE 923 || op->type == RUNE
884 || op->type == TRAP 924 || op->type == TRAP
885 || op->flag [FLAG_IS_A_TEMPLATE] 925 || op->flag [FLAG_IS_A_TEMPLATE]
886 || op->flag [FLAG_DESTROY_ON_DEATH]) 926 || op->flag [FLAG_DESTROY_ON_DEATH])
887 op->destroy (); 927 op->destroy (true);
888 else 928 else
889 map->insert (op, x, y); 929 map->insert (op, x, y);
890 } 930 }
891 } 931 }
892} 932}
896 object *op = new object; 936 object *op = new object;
897 op->link (); 937 op->link ();
898 return op; 938 return op;
899} 939}
900 940
941static struct freed_map : maptile
942{
943 freed_map ()
944 {
945 path = "<freed objects map>";
946 name = "/internal/freed_objects_map";
947 width = 3;
948 height = 3;
949 nodrop = 1;
950
951 alloc ();
952 in_memory = MAP_ACTIVE;
953 }
954
955 ~freed_map ()
956 {
957 destroy ();
958 }
959} freed_map; // freed objects are moved here to avoid crashes
960
901void 961void
902object::do_destroy () 962object::do_destroy ()
903{ 963{
904 attachable::do_destroy ();
905
906 if (flag [FLAG_IS_LINKED]) 964 if (flag [FLAG_IS_LINKED])
907 remove_button_link (this); 965 remove_button_link (this);
908 966
909 if (flag [FLAG_FRIENDLY]) 967 if (flag [FLAG_FRIENDLY])
910 remove_friendly_object (this); 968 remove_friendly_object (this);
911 969
912 if (!flag [FLAG_REMOVED])
913 remove (); 970 remove ();
914 971
915 destroy_inv (true); 972 attachable::do_destroy ();
916 973
917 deactivate (); 974 deactivate ();
918 unlink (); 975 unlink ();
919 976
920 flag [FLAG_FREED] = 1; 977 flag [FLAG_FREED] = 1;
921 978
922 // hack to ensure that freed objects still have a valid map 979 // hack to ensure that freed objects still have a valid map
923 {
924 static maptile *freed_map; // freed objects are moved here to avoid crashes
925
926 if (!freed_map)
927 {
928 freed_map = new maptile;
929
930 freed_map->path = "<freed objects map>";
931 freed_map->name = "/internal/freed_objects_map";
932 freed_map->width = 3;
933 freed_map->height = 3;
934
935 freed_map->alloc ();
936 freed_map->in_memory = MAP_IN_MEMORY;
937 }
938
939 map = freed_map; 980 map = &freed_map;
940 x = 1; 981 x = 1;
941 y = 1; 982 y = 1;
942 }
943 983
944 if (more) 984 if (more)
945 { 985 {
946 more->destroy (); 986 more->destroy ();
947 more = 0; 987 more = 0;
960object::destroy (bool destroy_inventory) 1000object::destroy (bool destroy_inventory)
961{ 1001{
962 if (destroyed ()) 1002 if (destroyed ())
963 return; 1003 return;
964 1004
1005 if (!is_head () && !head->destroyed ())
1006 {
1007 LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
1008 head->destroy (destroy_inventory);
1009 return;
1010 }
1011
965 if (destroy_inventory) 1012 destroy_inv (!destroy_inventory);
966 destroy_inv (false);
967 1013
968 if (is_head ()) 1014 if (is_head ())
969 if (sound_destroy) 1015 if (sound_destroy)
970 play_sound (sound_destroy); 1016 play_sound (sound_destroy);
971 else if (flag [FLAG_MONSTER]) 1017 else if (flag [FLAG_MONSTER])
972 play_sound (sound_find ("monster_destroy")); // quick hack, too lazy to create a generic mechanism 1018 play_sound (sound_find ("monster_destroy")); // quick hack, too lazy to create a generic mechanism
973 1019
974 attachable::destroy (); 1020 attachable::destroy ();
975}
976
977/*
978 * sub_weight() recursively (outwards) subtracts a number from the
979 * weight of an object (and what is carried by it's environment(s)).
980 */
981void
982sub_weight (object *op, signed long weight)
983{
984 while (op != NULL)
985 {
986 if (op->type == CONTAINER)
987 weight = (signed long) (weight * (100 - op->stats.Str) / 100);
988
989 op->carrying -= weight;
990 op = op->env;
991 }
992} 1021}
993 1022
994/* op->remove (): 1023/* op->remove ():
995 * This function removes the object op from the linked list of objects 1024 * This function removes the object op from the linked list of objects
996 * which it is currently tied to. When this function is done, the 1025 * which it is currently tied to. When this function is done, the
1002object::do_remove () 1031object::do_remove ()
1003{ 1032{
1004 object *tmp, *last = 0; 1033 object *tmp, *last = 0;
1005 object *otmp; 1034 object *otmp;
1006 1035
1007 if (QUERY_FLAG (this, FLAG_REMOVED)) 1036 if (flag [FLAG_REMOVED])
1008 return; 1037 return;
1009 1038
1010 SET_FLAG (this, FLAG_REMOVED);
1011 INVOKE_OBJECT (REMOVE, this); 1039 INVOKE_OBJECT (REMOVE, this);
1040
1041 flag [FLAG_REMOVED] = true;
1012 1042
1013 if (more) 1043 if (more)
1014 more->remove (); 1044 more->remove ();
1015 1045
1016 /* 1046 /*
1017 * In this case, the object to be removed is in someones 1047 * In this case, the object to be removed is in someones
1018 * inventory. 1048 * inventory.
1019 */ 1049 */
1020 if (env) 1050 if (env)
1021 { 1051 {
1052 flag [FLAG_REMOVED] = false; // hack around the issue of visible_to checking flag_removed
1053 if (object *pl = visible_to ())
1054 esrv_del_item (pl->contr, count);
1055 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
1056
1057 adjust_weight (env, -total_weight ());
1058
1059 *(above ? &above->below : &env->inv) = below;
1060
1022 if (nrof) 1061 if (below)
1023 sub_weight (env, weight * nrof); 1062 below->above = above;
1024 else 1063
1025 sub_weight (env, weight + carrying); 1064 /* we set up values so that it could be inserted into
1065 * the map, but we don't actually do that - it is up
1066 * to the caller to decide what we want to do.
1067 */
1068 map = env->map;
1069 x = env->x;
1070 y = env->y;
1071 above = 0;
1072 below = 0;
1073 env = 0;
1026 1074
1027 /* NO_FIX_PLAYER is set when a great many changes are being 1075 /* NO_FIX_PLAYER is set when a great many changes are being
1028 * made to players inventory. If set, avoiding the call 1076 * made to players inventory. If set, avoiding the call
1029 * to save cpu time. 1077 * to save cpu time.
1030 */ 1078 */
1031 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1079 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1032 otmp->update_stats (); 1080 otmp->update_stats ();
1033
1034 if (above)
1035 above->below = below;
1036 else
1037 env->inv = below;
1038
1039 if (below)
1040 below->above = above;
1041
1042 /* we set up values so that it could be inserted into
1043 * the map, but we don't actually do that - it is up
1044 * to the caller to decide what we want to do.
1045 */
1046 x = env->x, y = env->y;
1047 map = env->map;
1048 above = 0, below = 0;
1049 env = 0;
1050 } 1081 }
1051 else if (map) 1082 else if (map)
1052 { 1083 {
1053 if (type == PLAYER)
1054 {
1055 // leaving a spot always closes any open container on the ground
1056 if (container && !container->env)
1057 // this causes spurious floorbox updates, but it ensures
1058 // that the CLOSE event is being sent.
1059 close_container ();
1060
1061 --map->players;
1062 map->touch ();
1063 }
1064
1065 map->dirty = true; 1084 map->dirty = true;
1066 mapspace &ms = this->ms (); 1085 mapspace &ms = this->ms ();
1086
1087 if (object *pl = ms.player ())
1088 {
1089 if (type == PLAYER) // this == pl(!)
1090 {
1091 // leaving a spot always closes any open container on the ground
1092 if (container && !container->env)
1093 // this causes spurious floorbox updates, but it ensures
1094 // that the CLOSE event is being sent.
1095 close_container ();
1096
1097 --map->players;
1098 map->touch ();
1099 }
1100 else if (pl->container == this)
1101 {
1102 // removing a container should close it
1103 close_container ();
1104 }
1105
1106 esrv_del_item (pl->contr, count);
1107 }
1067 1108
1068 /* link the object above us */ 1109 /* link the object above us */
1069 if (above) 1110 if (above)
1070 above->below = below; 1111 above->below = below;
1071 else 1112 else
1101 * removed (most likely destroyed), update the player view 1142 * removed (most likely destroyed), update the player view
1102 * appropriately. 1143 * appropriately.
1103 */ 1144 */
1104 pl->close_container (); 1145 pl->close_container ();
1105 1146
1147 //TODO: the floorbox prev/next might need updating
1148 //esrv_del_item (pl->contr, count);
1149 //TODO: update floorbox to preserve ordering
1150 if (pl->contr->ns)
1106 pl->contr->ns->floorbox_update (); 1151 pl->contr->ns->floorbox_update ();
1107 } 1152 }
1108 1153
1109 for (tmp = ms.bot; tmp; tmp = tmp->above) 1154 for (tmp = ms.bot; tmp; tmp = tmp->above)
1110 { 1155 {
1111 /* No point updating the players look faces if he is the object 1156 /* No point updating the players look faces if he is the object
1155 if (!top) 1200 if (!top)
1156 for (top = op; top && top->above; top = top->above) 1201 for (top = op; top && top->above; top = top->above)
1157 ; 1202 ;
1158 1203
1159 for (; top; top = top->below) 1204 for (; top; top = top->below)
1160 {
1161 if (top == op)
1162 continue;
1163
1164 if (object::can_merge (op, top)) 1205 if (object::can_merge (op, top))
1165 { 1206 {
1166 top->nrof += op->nrof; 1207 top->nrof += op->nrof;
1167 1208
1168/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/ 1209 if (object *pl = top->visible_to ())
1169 op->weight = 0; /* Don't want any adjustements now */ 1210 esrv_update_item (UPD_NROF, pl, top);
1211
1212 op->weight = 0; // cancel the addition above
1213 op->carrying = 0; // must be 0 already
1214
1170 op->destroy (); 1215 op->destroy (1);
1216
1171 return top; 1217 return top;
1172 } 1218 }
1173 }
1174 1219
1175 return 0; 1220 return 0;
1176} 1221}
1177 1222
1178void 1223void
1237object * 1282object *
1238insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1283insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1239{ 1284{
1240 assert (!op->flag [FLAG_FREED]); 1285 assert (!op->flag [FLAG_FREED]);
1241 1286
1242 object *top, *floor = NULL;
1243
1244 op->remove (); 1287 op->remove ();
1245 1288
1246 /* Ideally, the caller figures this out. However, it complicates a lot 1289 /* Ideally, the caller figures this out. However, it complicates a lot
1247 * of areas of callers (eg, anything that uses find_free_spot would now 1290 * of areas of callers (eg, anything that uses find_free_spot would now
1248 * need extra work 1291 * need extra work
1249 */ 1292 */
1250 if (!xy_normalise (m, op->x, op->y)) 1293 if (!xy_normalise (m, op->x, op->y))
1251 { 1294 {
1252 op->destroy (); 1295 op->destroy (1);
1253 return 0; 1296 return 0;
1254 } 1297 }
1255 1298
1256 if (object *more = op->more) 1299 if (object *more = op->more)
1257 if (!insert_ob_in_map (more, m, originator, flag)) 1300 if (!insert_ob_in_map (more, m, originator, flag))
1266 */ 1309 */
1267 if (op->nrof && !(flag & INS_NO_MERGE)) 1310 if (op->nrof && !(flag & INS_NO_MERGE))
1268 for (object *tmp = ms.bot; tmp; tmp = tmp->above) 1311 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1269 if (object::can_merge (op, tmp)) 1312 if (object::can_merge (op, tmp))
1270 { 1313 {
1314 // TODO: we atcually want to update tmp, not op,
1315 // but some caller surely breaks when we return tmp
1316 // from here :/
1271 op->nrof += tmp->nrof; 1317 op->nrof += tmp->nrof;
1272 tmp->destroy (); 1318 tmp->destroy (1);
1273 } 1319 }
1274 1320
1275 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1321 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1276 CLEAR_FLAG (op, FLAG_INV_LOCKED); 1322 CLEAR_FLAG (op, FLAG_INV_LOCKED);
1277 1323
1297 /* since *below* originator, no need to update top */ 1343 /* since *below* originator, no need to update top */
1298 originator->below = op; 1344 originator->below = op;
1299 } 1345 }
1300 else 1346 else
1301 { 1347 {
1348 object *top, *floor = NULL;
1349
1302 top = ms.bot; 1350 top = ms.bot;
1303 1351
1304 /* If there are other objects, then */ 1352 /* If there are other objects, then */
1305 if (top) 1353 if (top)
1306 { 1354 {
1405 } 1453 }
1406 1454
1407 op->map->dirty = true; 1455 op->map->dirty = true;
1408 1456
1409 if (object *pl = ms.player ()) 1457 if (object *pl = ms.player ())
1458 //TODO: the floorbox prev/next might need updating
1459 //esrv_send_item (pl, op);
1460 //TODO: update floorbox to preserve ordering
1461 if (pl->contr->ns)
1410 pl->contr->ns->floorbox_update (); 1462 pl->contr->ns->floorbox_update ();
1411 1463
1412 /* If this object glows, it may affect lighting conditions that are 1464 /* If this object glows, it may affect lighting conditions that are
1413 * visible to others on this map. But update_all_los is really 1465 * visible to others on this map. But update_all_los is really
1414 * an inefficient way to do this, as it means los for all players 1466 * an inefficient way to do this, as it means los for all players
1415 * on the map will get recalculated. The players could very well 1467 * on the map will get recalculated. The players could very well
1457 * op is the object to insert it under: supplies x and the map. 1509 * op is the object to insert it under: supplies x and the map.
1458 */ 1510 */
1459void 1511void
1460replace_insert_ob_in_map (const char *arch_string, object *op) 1512replace_insert_ob_in_map (const char *arch_string, object *op)
1461{ 1513{
1462 object *tmp, *tmp1;
1463
1464 /* first search for itself and remove any old instances */ 1514 /* first search for itself and remove any old instances */
1465 1515
1466 for (tmp = op->ms ().bot; tmp; tmp = tmp->above) 1516 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1467 if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */ 1517 if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */
1468 tmp->destroy (); 1518 tmp->destroy (1);
1469 1519
1470 tmp1 = arch_to_object (archetype::find (arch_string)); 1520 object *tmp = arch_to_object (archetype::find (arch_string));
1471 1521
1472 tmp1->x = op->x; 1522 tmp->x = op->x;
1473 tmp1->y = op->y; 1523 tmp->y = op->y;
1524
1474 insert_ob_in_map (tmp1, op->map, op, 0); 1525 insert_ob_in_map (tmp, op->map, op, 0);
1475} 1526}
1476 1527
1477object * 1528object *
1478object::insert_at (object *where, object *originator, int flags) 1529object::insert_at (object *where, object *originator, int flags)
1479{ 1530{
1531 if (where->env)
1532 return where->env->insert (this);
1533 else
1480 return where->map->insert (this, where->x, where->y, originator, flags); 1534 return where->map->insert (this, where->x, where->y, originator, flags);
1481} 1535}
1482 1536
1483/* 1537/*
1484 * get_split_ob(ob,nr) splits up ob into two parts. The part which
1485 * is returned contains nr objects, and the remaining parts contains
1486 * the rest (or is removed and freed if that number is 0).
1487 * On failure, NULL is returned, and the reason put into the
1488 * global static errmsg array.
1489 */
1490object *
1491get_split_ob (object *orig_ob, uint32 nr)
1492{
1493 object *newob;
1494 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1495
1496 if (orig_ob->nrof < nr)
1497 {
1498 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1499 return NULL;
1500 }
1501
1502 newob = object_create_clone (orig_ob);
1503
1504 if ((orig_ob->nrof -= nr) < 1)
1505 orig_ob->destroy (1);
1506 else if (!is_removed)
1507 {
1508 if (orig_ob->env != NULL)
1509 sub_weight (orig_ob->env, orig_ob->weight * nr);
1510 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY)
1511 {
1512 strcpy (errmsg, "Tried to split object whose map is not in memory.");
1513 LOG (llevDebug, "Error, Tried to split object whose map is not in memory.\n");
1514 return NULL;
1515 }
1516 }
1517
1518 newob->nrof = nr;
1519
1520 return newob;
1521}
1522
1523/*
1524 * decrease_ob_nr(object, number) decreases a specified number from 1538 * decrease(object, number) decreases a specified number from
1525 * the amount of an object. If the amount reaches 0, the object 1539 * the amount of an object. If the amount reaches 0, the object
1526 * is subsequently removed and freed. 1540 * is subsequently removed and freed.
1527 * 1541 *
1528 * Return value: 'op' if something is left, NULL if the amount reached 0 1542 * Return value: 'op' if something is left, NULL if the amount reached 0
1529 */ 1543 */
1544bool
1545object::decrease (sint32 nr)
1546{
1547 if (!nr)
1548 return true;
1549
1550 nr = min (nr, nrof);
1551
1552 nrof -= nr;
1553
1554 if (nrof)
1555 {
1556 adjust_weight (env, -weight * nr); // carrying == 0
1557
1558 if (object *pl = visible_to ())
1559 esrv_update_item (UPD_NROF, pl, this);
1560
1561 return true;
1562 }
1563 else
1564 {
1565 destroy (1);
1566 return false;
1567 }
1568}
1569
1570/*
1571 * split(ob,nr) splits up ob into two parts. The part which
1572 * is returned contains nr objects, and the remaining parts contains
1573 * the rest (or is removed and returned if that number is 0).
1574 * On failure, NULL is returned.
1575 */
1530object * 1576object *
1531decrease_ob_nr (object *op, uint32 i) 1577object::split (sint32 nr)
1532{ 1578{
1533 object *tmp; 1579 int have = number_of ();
1534 1580
1535 if (i == 0) /* objects with op->nrof require this check */ 1581 if (have < nr)
1536 return op; 1582 return 0;
1537 1583 else if (have == nr)
1538 if (i > op->nrof)
1539 i = op->nrof;
1540
1541 if (QUERY_FLAG (op, FLAG_REMOVED))
1542 op->nrof -= i;
1543 else if (op->env)
1544 { 1584 {
1545 /* is this object in the players inventory, or sub container
1546 * therein?
1547 */
1548 tmp = op->in_player ();
1549 /* nope. Is this a container the player has opened?
1550 * If so, set tmp to that player.
1551 * IMO, searching through all the players will mostly
1552 * likely be quicker than following op->env to the map,
1553 * and then searching the map for a player.
1554 */
1555 if (!tmp)
1556 for_all_players (pl)
1557 if (pl->ob->container == op->env)
1558 {
1559 tmp = pl->ob;
1560 break;
1561 }
1562
1563 if (i < op->nrof)
1564 {
1565 sub_weight (op->env, op->weight * i);
1566 op->nrof -= i;
1567 if (tmp)
1568 esrv_send_item (tmp, op);
1569 }
1570 else
1571 {
1572 op->remove (); 1585 remove ();
1573 op->nrof = 0; 1586 return this;
1574 if (tmp)
1575 esrv_del_item (tmp->contr, op->count);
1576 }
1577 } 1587 }
1578 else 1588 else
1579 { 1589 {
1580 object *above = op->above; 1590 decrease (nr);
1581 1591
1582 if (i < op->nrof) 1592 object *op = deep_clone ();
1583 op->nrof -= i; 1593 op->nrof = nr;
1584 else
1585 {
1586 op->remove ();
1587 op->nrof = 0;
1588 }
1589
1590 /* Since we just removed op, op->above is null */
1591 for (tmp = above; tmp; tmp = tmp->above)
1592 if (tmp->type == PLAYER)
1593 {
1594 if (op->nrof)
1595 esrv_send_item (tmp, op);
1596 else
1597 esrv_del_item (tmp->contr, op->count);
1598 }
1599 }
1600
1601 if (op->nrof)
1602 return op; 1594 return op;
1603 else
1604 {
1605 op->destroy ();
1606 return 0;
1607 }
1608}
1609
1610/*
1611 * add_weight(object, weight) adds the specified weight to an object,
1612 * and also updates how much the environment(s) is/are carrying.
1613 */
1614void
1615add_weight (object *op, signed long weight)
1616{
1617 while (op != NULL)
1618 {
1619 if (op->type == CONTAINER)
1620 weight = (signed long) (weight * (100 - op->stats.Str) / 100);
1621
1622 op->carrying += weight;
1623 op = op->env;
1624 } 1595 }
1625} 1596}
1626 1597
1627object * 1598object *
1628insert_ob_in_ob (object *op, object *where) 1599insert_ob_in_ob (object *op, object *where)
1653 * be != op, if items are merged. -Tero 1624 * be != op, if items are merged. -Tero
1654 */ 1625 */
1655object * 1626object *
1656object::insert (object *op) 1627object::insert (object *op)
1657{ 1628{
1658 if (!QUERY_FLAG (op, FLAG_REMOVED))
1659 op->remove ();
1660
1661 if (op->more) 1629 if (op->more)
1662 { 1630 {
1663 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count); 1631 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);
1664 return op; 1632 return op;
1665 } 1633 }
1666 1634
1667 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL); 1635 op->remove ();
1668 CLEAR_FLAG (op, FLAG_REMOVED); 1636
1637 op->flag [FLAG_OBJ_ORIGINAL] = 0;
1669 1638
1670 if (op->nrof) 1639 if (op->nrof)
1671 {
1672 for (object *tmp = inv; tmp; tmp = tmp->below) 1640 for (object *tmp = inv; tmp; tmp = tmp->below)
1673 if (object::can_merge (tmp, op)) 1641 if (object::can_merge (tmp, op))
1674 { 1642 {
1675 /* return the original object and remove inserted object 1643 /* return the original object and remove inserted object
1676 (client needs the original object) */ 1644 (client needs the original object) */
1677 tmp->nrof += op->nrof; 1645 tmp->nrof += op->nrof;
1678 /* Weight handling gets pretty funky. Since we are adding to 1646
1679 * tmp->nrof, we need to increase the weight. 1647 if (object *pl = tmp->visible_to ())
1680 */ 1648 esrv_update_item (UPD_NROF, pl, tmp);
1649
1681 add_weight (this, op->weight * op->nrof); 1650 adjust_weight (this, op->total_weight ());
1682 SET_FLAG (op, FLAG_REMOVED); 1651
1683 op->destroy (); /* free the inserted object */ 1652 op->destroy (1);
1684 op = tmp; 1653 op = tmp;
1685 op->remove (); /* and fix old object's links */ 1654 goto inserted;
1686 CLEAR_FLAG (op, FLAG_REMOVED);
1687 break;
1688 } 1655 }
1689 1656
1690 /* I assume combined objects have no inventory
1691 * We add the weight - this object could have just been removed
1692 * (if it was possible to merge). calling remove_ob will subtract
1693 * the weight, so we need to add it in again, since we actually do
1694 * the linking below
1695 */
1696 add_weight (this, op->weight * op->nrof);
1697 }
1698 else
1699 add_weight (this, (op->weight + op->carrying));
1700
1701 if (object *otmp = this->in_player ())
1702 if (otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1703 otmp->update_stats ();
1704
1705 op->owner = 0; // its his/hers now. period. 1657 op->owner = 0; // it's his/hers now. period.
1706 op->map = 0; 1658 op->map = 0;
1659 op->x = 0;
1660 op->y = 0;
1661
1662 op->above = 0;
1663 op->below = inv;
1707 op->env = this; 1664 op->env = this;
1708 op->above = 0;
1709 op->below = 0;
1710 op->x = op->y = 0;
1711 1665
1666 if (inv)
1667 inv->above = op;
1668
1669 inv = op;
1670
1671 op->flag [FLAG_REMOVED] = 0;
1672
1673 if (object *pl = op->visible_to ())
1674 esrv_send_item (pl, op);
1675
1676 adjust_weight (this, op->total_weight ());
1677
1678inserted:
1712 /* reset the light list and los of the players on the map */ 1679 /* reset the light list and los of the players on the map */
1713 if (op->glow_radius && map) 1680 if (op->glow_radius && map && map->darkness)
1714 {
1715#ifdef DEBUG_LIGHTS
1716 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1717#endif /* DEBUG_LIGHTS */
1718 if (map->darkness)
1719 update_all_los (map, x, y); 1681 update_all_los (map, x, y);
1720 }
1721 1682
1722 /* Client has no idea of ordering so lets not bother ordering it here. 1683 // if this is a player's inventory, update stats
1723 * It sure simplifies this function... 1684 if (type == PLAYER && !flag [FLAG_NO_FIX_PLAYER])
1724 */ 1685 update_stats ();
1725 if (!inv)
1726 inv = op;
1727 else
1728 {
1729 op->below = inv;
1730 op->below->above = op;
1731 inv = op;
1732 }
1733 1686
1734 INVOKE_OBJECT (INSERT, this); 1687 INVOKE_OBJECT (INSERT, this);
1735 1688
1736 return op; 1689 return op;
1737} 1690}
1952 * activate recursively a flag on an object inventory 1905 * activate recursively a flag on an object inventory
1953 */ 1906 */
1954void 1907void
1955flag_inv (object *op, int flag) 1908flag_inv (object *op, int flag)
1956{ 1909{
1957 if (op->inv)
1958 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below) 1910 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1959 { 1911 {
1960 SET_FLAG (tmp, flag); 1912 SET_FLAG (tmp, flag);
1961 flag_inv (tmp, flag); 1913 flag_inv (tmp, flag);
1962 } 1914 }
1963} 1915}
1964 1916
1965/* 1917/*
1966 * deactivate recursively a flag on an object inventory 1918 * deactivate recursively a flag on an object inventory
1967 */ 1919 */
1968void 1920void
1969unflag_inv (object *op, int flag) 1921unflag_inv (object *op, int flag)
1970{ 1922{
1971 if (op->inv)
1972 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below) 1923 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1973 { 1924 {
1974 CLEAR_FLAG (tmp, flag); 1925 CLEAR_FLAG (tmp, flag);
1975 unflag_inv (tmp, flag); 1926 unflag_inv (tmp, flag);
1976 } 1927 }
1977} 1928}
1978 1929
1979/* 1930/*
1980 * find_free_spot(object, map, x, y, start, stop) will search for 1931 * find_free_spot(object, map, x, y, start, stop) will search for
1981 * a spot at the given map and coordinates which will be able to contain 1932 * a spot at the given map and coordinates which will be able to contain
1983 * to search (see the freearr_x/y[] definition). 1934 * to search (see the freearr_x/y[] definition).
1984 * It returns a random choice among the alternatives found. 1935 * It returns a random choice among the alternatives found.
1985 * start and stop are where to start relative to the free_arr array (1,9 1936 * start and stop are where to start relative to the free_arr array (1,9
1986 * does all 4 immediate directions). This returns the index into the 1937 * does all 4 immediate directions). This returns the index into the
1987 * array of the free spot, -1 if no spot available (dir 0 = x,y) 1938 * array of the free spot, -1 if no spot available (dir 0 = x,y)
1988 * Note - this only checks to see if there is space for the head of the
1989 * object - if it is a multispace object, this should be called for all
1990 * pieces.
1991 * Note2: This function does correctly handle tiled maps, but does not 1939 * Note: This function does correctly handle tiled maps, but does not
1992 * inform the caller. However, insert_ob_in_map will update as 1940 * inform the caller. However, insert_ob_in_map will update as
1993 * necessary, so the caller shouldn't need to do any special work. 1941 * necessary, so the caller shouldn't need to do any special work.
1994 * Note - updated to take an object instead of archetype - this is necessary 1942 * Note - updated to take an object instead of archetype - this is necessary
1995 * because arch_blocked (now ob_blocked) needs to know the movement type 1943 * because arch_blocked (now ob_blocked) needs to know the movement type
1996 * to know if the space in question will block the object. We can't use 1944 * to know if the space in question will block the object. We can't use
2017 1965
2018 /* However, often 1966 /* However, often
2019 * ob doesn't have any move type (when used to place exits) 1967 * ob doesn't have any move type (when used to place exits)
2020 * so the AND operation in OB_TYPE_MOVE_BLOCK doesn't work. 1968 * so the AND operation in OB_TYPE_MOVE_BLOCK doesn't work.
2021 */ 1969 */
2022 if (ob->move_type == 0 && ms.move_block != MOVE_ALL) 1970 if (ob && ob->move_type == 0 && ms.move_block != MOVE_ALL)
2023 { 1971 {
2024 altern [index++] = i; 1972 altern [index++] = i;
2025 continue; 1973 continue;
2026 } 1974 }
2027 1975
2041 1989
2042 /* Note it is intentional that we check ob - the movement type of the 1990 /* Note it is intentional that we check ob - the movement type of the
2043 * head of the object should correspond for the entire object. 1991 * head of the object should correspond for the entire object.
2044 */ 1992 */
2045 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block)) 1993 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))
1994 continue;
1995
1996 if (ob->blocked (m, pos.x, pos.y))
2046 continue; 1997 continue;
2047 1998
2048 altern [index++] = i; 1999 altern [index++] = i;
2049 } 2000 }
2050 2001
2361 2312
2362/* 2313/*
2363 * create clone from object to another 2314 * create clone from object to another
2364 */ 2315 */
2365object * 2316object *
2366object_create_clone (object *asrc) 2317object::deep_clone ()
2367{ 2318{
2368 object *dst = 0, *tmp, *src, *prev, *item; 2319 assert (("deep_clone called on non-head object", is_head ()));
2369 2320
2370 if (!asrc) 2321 object *dst = clone ();
2371 return 0;
2372 2322
2373 src = asrc->head_ (); 2323 object *prev = dst;
2374
2375 prev = 0;
2376 for (object *part = src; part; part = part->more) 2324 for (object *part = this->more; part; part = part->more)
2377 { 2325 {
2378 tmp = part->clone (); 2326 object *tmp = part->clone ();
2379 tmp->x -= src->x;
2380 tmp->y -= src->y;
2381
2382 if (!part->head)
2383 {
2384 dst = tmp;
2385 tmp->head = 0;
2386 }
2387 else
2388 tmp->head = dst; 2327 tmp->head = dst;
2389
2390 tmp->more = 0;
2391
2392 if (prev)
2393 prev->more = tmp; 2328 prev->more = tmp;
2394
2395 prev = tmp; 2329 prev = tmp;
2396 } 2330 }
2397 2331
2398 for (item = src->inv; item; item = item->below) 2332 for (object *item = inv; item; item = item->below)
2399 insert_ob_in_ob (object_create_clone (item), dst); 2333 insert_ob_in_ob (item->deep_clone (), dst);
2400 2334
2401 return dst; 2335 return dst;
2402} 2336}
2403 2337
2404/* This returns the first object in who's inventory that 2338/* This returns the first object in who's inventory that
2413 return tmp; 2347 return tmp;
2414 2348
2415 return 0; 2349 return 0;
2416} 2350}
2417 2351
2418/* If ob has a field named key, return the link from the list, 2352const shstr &
2419 * otherwise return NULL. 2353object::kv_get (const shstr &key) const
2420 *
2421 * key must be a passed in shared string - otherwise, this won't
2422 * do the desired thing.
2423 */
2424key_value *
2425get_ob_key_link (const object *ob, const char *key)
2426{ 2354{
2427 for (key_value *link = ob->key_values; link; link = link->next) 2355 for (key_value *kv = key_values; kv; kv = kv->next)
2428 if (link->key == key) 2356 if (kv->key == key)
2429 return link;
2430
2431 return 0;
2432}
2433
2434/*
2435 * Returns the value of op has an extra_field for key, or NULL.
2436 *
2437 * The argument doesn't need to be a shared string.
2438 *
2439 * The returned string is shared.
2440 */
2441const char *
2442get_ob_key_value (const object *op, const char *const key)
2443{
2444 key_value *link;
2445 shstr_cmp canonical_key (key);
2446
2447 if (!canonical_key)
2448 {
2449 /* 1. There being a field named key on any object
2450 * implies there'd be a shared string to find.
2451 * 2. Since there isn't, no object has this field.
2452 * 3. Therefore, *this* object doesn't have this field.
2453 */
2454 return 0;
2455 }
2456
2457 /* This is copied from get_ob_key_link() above -
2458 * only 4 lines, and saves the function call overhead.
2459 */
2460 for (link = op->key_values; link; link = link->next)
2461 if (link->key == canonical_key)
2462 return link->value; 2357 return kv->value;
2463 2358
2464 return 0; 2359 return shstr_null;
2465} 2360}
2466 2361
2467/* 2362void
2468 * Updates the canonical_key in op to value. 2363object::kv_set (const shstr &key, const shstr &value)
2469 *
2470 * canonical_key is a shared string (value doesn't have to be).
2471 *
2472 * Unless add_key is TRUE, it won't add fields, only change the value of existing
2473 * keys.
2474 *
2475 * Returns TRUE on success.
2476 */
2477int
2478set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2479{ 2364{
2480 key_value *field = NULL, *last = NULL; 2365 for (key_value *kv = key_values; kv; kv = kv->next)
2481 2366 if (kv->key == key)
2482 for (field = op->key_values; field != NULL; field = field->next)
2483 {
2484 if (field->key != canonical_key)
2485 { 2367 {
2486 last = field; 2368 kv->value = value;
2487 continue; 2369 return;
2488 } 2370 }
2489 2371
2490 if (value) 2372 key_value *kv = new key_value;
2491 field->value = value; 2373
2492 else 2374 kv->next = key_values;
2375 kv->key = key;
2376 kv->value = value;
2377
2378 key_values = kv;
2379}
2380
2381void
2382object::kv_del (const shstr &key)
2383{
2384 for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
2385 if ((*kvp)->key == key)
2493 { 2386 {
2494 /* Basically, if the archetype has this key set, 2387 key_value *kv = *kvp;
2495 * we need to store the null value so when we save 2388 *kvp = (*kvp)->next;
2496 * it, we save the empty value so that when we load, 2389 delete kv;
2497 * we get this value back again. 2390 return;
2498 */
2499 if (get_ob_key_link (op->arch, canonical_key))
2500 field->value = 0;
2501 else
2502 {
2503 if (last)
2504 last->next = field->next;
2505 else
2506 op->key_values = field->next;
2507
2508 delete field;
2509 }
2510 } 2391 }
2511 return TRUE;
2512 }
2513 /* IF we get here, key doesn't exist */
2514
2515 /* No field, we'll have to add it. */
2516
2517 if (!add_key)
2518 return FALSE;
2519
2520 /* There isn't any good reason to store a null
2521 * value in the key/value list. If the archetype has
2522 * this key, then we should also have it, so shouldn't
2523 * be here. If user wants to store empty strings,
2524 * should pass in ""
2525 */
2526 if (value == NULL)
2527 return TRUE;
2528
2529 field = new key_value;
2530
2531 field->key = canonical_key;
2532 field->value = value;
2533 /* Usual prepend-addition. */
2534 field->next = op->key_values;
2535 op->key_values = field;
2536
2537 return TRUE;
2538}
2539
2540/*
2541 * Updates the key in op to value.
2542 *
2543 * If add_key is FALSE, this will only update existing keys,
2544 * and not add new ones.
2545 * In general, should be little reason FALSE is ever passed in for add_key
2546 *
2547 * Returns TRUE on success.
2548 */
2549int
2550set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2551{
2552 shstr key_ (key);
2553
2554 return set_ob_key_value_s (op, key_, value, add_key);
2555} 2392}
2556 2393
2557object::depth_iterator::depth_iterator (object *container) 2394object::depth_iterator::depth_iterator (object *container)
2558: iterator_base (container) 2395: iterator_base (container)
2559{ 2396{
2609{ 2446{
2610 char flagdesc[512]; 2447 char flagdesc[512];
2611 char info2[256 * 4]; 2448 char info2[256 * 4];
2612 char *p = info; 2449 char *p = info;
2613 2450
2614 p += snprintf (p, 512, "{cnt:%d,uuid:<1.%" PRIx64 ">,name:\"%s\"%s%s,flags:[%s],type:%d}", 2451 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s,flags:[%s],type:%d}",
2615 count, uuid.seq, 2452 count,
2453 uuid.c_str (),
2616 &name, 2454 &name,
2617 title ? "\",title:\"" : "", 2455 title ? "\",title:\"" : "",
2618 title ? (const char *)title : "", 2456 title ? (const char *)title : "",
2619 flag_desc (flagdesc, 512), type); 2457 flag_desc (flagdesc, 512), type);
2620 2458
2621 if (!this->flag[FLAG_REMOVED] && env) 2459 if (!flag[FLAG_REMOVED] && env)
2622 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2460 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2623 2461
2624 if (map) 2462 if (map)
2625 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y); 2463 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2626 2464
2656object::open_container (object *new_container) 2494object::open_container (object *new_container)
2657{ 2495{
2658 if (container == new_container) 2496 if (container == new_container)
2659 return; 2497 return;
2660 2498
2661 if (object *old_container = container) 2499 object *old_container = container;
2500
2501 if (old_container)
2662 { 2502 {
2663 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this))) 2503 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))
2664 return; 2504 return;
2665 2505
2666#if 0 2506#if 0
2668 if (object *closer = old_container->inv) 2508 if (object *closer = old_container->inv)
2669 if (closer->type == CLOSE_CON) 2509 if (closer->type == CLOSE_CON)
2670 closer->destroy (); 2510 closer->destroy ();
2671#endif 2511#endif
2672 2512
2513 // make sure the container is available
2514 esrv_send_item (this, old_container);
2515
2673 old_container->flag [FLAG_APPLIED] = 0; 2516 old_container->flag [FLAG_APPLIED] = false;
2674 container = 0; 2517 container = 0;
2675 2518
2519 // client needs item update to make it work, client bug requires this to be separate
2676 esrv_update_item (UPD_FLAGS, this, old_container); 2520 esrv_update_item (UPD_FLAGS, this, old_container);
2521
2677 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container)); 2522 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container));
2678 play_sound (sound_find ("chest_close")); 2523 play_sound (sound_find ("chest_close"));
2679 } 2524 }
2680 2525
2681 if (new_container) 2526 if (new_container)
2694 } 2539 }
2695#endif 2540#endif
2696 2541
2697 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container)); 2542 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container));
2698 2543
2544 // make sure the container is available, client bug requires this to be separate
2545 esrv_send_item (this, new_container);
2546
2699 new_container->flag [FLAG_APPLIED] = 1; 2547 new_container->flag [FLAG_APPLIED] = true;
2700 container = new_container; 2548 container = new_container;
2701 2549
2550 // client needs flag change
2702 esrv_update_item (UPD_FLAGS, this, new_container); 2551 esrv_update_item (UPD_FLAGS, this, new_container);
2703 esrv_send_inventory (this, new_container); 2552 esrv_send_inventory (this, new_container);
2704 play_sound (sound_find ("chest_open")); 2553 play_sound (sound_find ("chest_open"));
2705 } 2554 }
2555// else if (!old_container->env && contr && contr->ns)
2556// contr->ns->floorbox_reset ();
2706} 2557}
2707 2558
2708object * 2559object *
2709object::force_find (const shstr name) 2560object::force_find (const shstr name)
2710{ 2561{
2736 2587
2737 insert (force); 2588 insert (force);
2738} 2589}
2739 2590
2740void 2591void
2741object::play_sound (faceidx sound) const 2592object::play_sound (faceidx sound)
2742{ 2593{
2743 if (!sound) 2594 if (!sound)
2744 return; 2595 return;
2745 2596
2746 if (flag [FLAG_REMOVED]) 2597 if (flag [FLAG_REMOVED])

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines