ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.194 by root, Tue Oct 16 00:30:24 2007 UTC vs.
Revision 1.279 by root, Thu Jan 8 03:03:23 2009 UTC

1/* 1/*
2 * This file is part of Crossfire TRT, the Roguelike Realtime MORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007 Marc Alexander Lehmann / Robin Redeker / the Crossfire TRT team 4 * Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 * 7 *
8 * Crossfire TRT is free software: you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify
9 * it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
10 * the Free Software Foundation, either version 3 of the License, or 10 * the Free Software Foundation, either version 3 of the License, or
11 * (at your option) any later version. 11 * (at your option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the GNU General Public License
19 * along with this program. If not, see <http://www.gnu.org/licenses/>. 19 * along with this program. If not, see <http://www.gnu.org/licenses/>.
20 * 20 *
21 * The authors can be reached via e-mail to <crossfire@schmorp.de> 21 * The authors can be reached via e-mail to <support@deliantra.net>
22 */ 22 */
23 23
24/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
25 sub/add_weight will transcend the environment updating the carrying
26 variable. */
27#include <global.h> 24#include <global.h>
28#include <stdio.h> 25#include <stdio.h>
29#include <sys/types.h> 26#include <sys/types.h>
30#include <sys/uio.h> 27#include <sys/uio.h>
31#include <object.h> 28#include <object.h>
32#include <funcpoint.h>
33#include <sproto.h> 29#include <sproto.h>
34#include <loader.h> 30#include <loader.h>
35 31
36#include <bitset> 32#include <bitset>
37 33
38int nrofallocobjects = 0; 34UUID UUID::cur;
39static UUID uuid; 35static uint64_t seq_next_save;
40const uint64 UUID_SKIP = 1<<19; 36static const uint64 UUID_GAP = 1<<19;
37uint32_t mapspace::smellcount = 10000;
41 38
42objectvec objects; 39objectvec objects;
43activevec actives; 40activevec actives;
44 41
45short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 42short freearr_x[SIZEOFFREE] = {
43 0,
44 0, 1, 1, 1, 0, -1, -1, -1,
45 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
46 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1 46 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1
47}; 47};
48short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, 48short freearr_y[SIZEOFFREE] = {
49 0,
50 -1, -1, 0, 1, 1, 1, 0, -1,
51 -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
49 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3 52 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3
50}; 53};
51int maxfree[SIZEOFFREE] = { 0, 9, 10, 13, 14, 17, 18, 21, 22, 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 54int maxfree[SIZEOFFREE] = {
55 0,
56 9, 10, 13, 14, 17, 18, 21, 22,
57 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
52 48, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49 58 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
53}; 59};
54int freedir[SIZEOFFREE] = { 60int freedir[SIZEOFFREE] = {
55 0, 1, 2, 3, 4, 5, 6, 7, 8, 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8, 61 0,
62 1, 2, 3, 4, 5, 6, 7, 8,
63 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,
56 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8 64 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8
57}; 65};
58 66
59static void 67static void
60write_uuid (void) 68write_uuid (uval64 skip, bool sync)
61{ 69{
62 char filename1[MAX_BUF], filename2[MAX_BUF]; 70 CALL_BEGIN (2);
63 71 CALL_ARG_SV (newSVval64 (skip));
64 sprintf (filename1, "%s/uuid", settings.localdir); 72 CALL_ARG_SV (boolSV (sync));
65 sprintf (filename2, "%s/uuid~", settings.localdir); 73 CALL_CALL ("cf::write_uuid", G_DISCARD);
66 74 CALL_END;
67 FILE *fp;
68
69 if (!(fp = fopen (filename2, "w")))
70 {
71 LOG (llevError, "ERROR: cannot open %s for writing, unable to write UUID!\n", filename2);
72 return;
73 }
74
75 fprintf (fp, "<1,%llx>\n", (unsigned long long)uuid.seq + UUID_SKIP * 2);
76 fclose (fp);
77 rename (filename2, filename1);
78} 75}
79 76
80static void 77static void
81read_uuid (void) 78read_uuid (void)
82{ 79{
83 char filename[MAX_BUF]; 80 char filename[MAX_BUF];
84 81
85 sprintf (filename, "%s/uuid", settings.localdir); 82 sprintf (filename, "%s/uuid", settings.localdir);
83
84 seq_next_save = 0;
86 85
87 FILE *fp; 86 FILE *fp;
88 87
89 if (!(fp = fopen (filename, "r"))) 88 if (!(fp = fopen (filename, "r")))
90 { 89 {
91 if (errno == ENOENT) 90 if (errno == ENOENT)
92 { 91 {
93 LOG (llevInfo, "RESET uid to 1\n"); 92 LOG (llevInfo, "RESET uid to 1\n");
94 uuid.seq = 0; 93 UUID::cur.seq = 0;
95 write_uuid (); 94 write_uuid (UUID_GAP, true);
96 return; 95 return;
97 } 96 }
98 97
99 LOG (llevError, "FATAL: cannot open %s for reading!\n", filename); 98 LOG (llevError, "FATAL: cannot open %s for reading!\n", filename);
100 _exit (1); 99 _exit (1);
101 } 100 }
102 101
103 int version; 102 UUID::BUF buf;
104 unsigned long long uid; 103 buf[0] = 0;
105 if (2 != fscanf (fp, "<%d,%llx>\n", &version, &uid) || version != 1) 104 fgets (buf, sizeof (buf), fp);
105
106 if (!UUID::cur.parse (buf))
106 { 107 {
107 LOG (llevError, "FATAL: error reading uid from %s!\n", filename); 108 LOG (llevError, "FATAL: error reading uid from %s (%s)!\n", filename, buf);
108 _exit (1); 109 _exit (1);
109 } 110 }
110 111
111 uuid.seq = uid; 112 LOG (llevDebug, "read UUID: %s\n", UUID::cur.c_str ());
112 write_uuid (); 113
113 LOG (llevDebug, "read UID: %" PRId64 "\n", uid); 114 write_uuid (UUID_GAP, true);
114 fclose (fp); 115 fclose (fp);
115} 116}
116 117
117UUID 118UUID
118gen_uuid () 119UUID::gen ()
119{ 120{
120 UUID uid; 121 UUID uid;
121 122
122 uid.seq = ++uuid.seq; 123 uid.seq = ++cur.seq;
123 124
124 if (!(uuid.seq & (UUID_SKIP - 1))) 125 if (expect_false (cur.seq >= seq_next_save))
125 write_uuid (); 126 {
127 seq_next_save = UUID::cur.seq + (UUID_GAP >> 1);
128 write_uuid (UUID_GAP, false);
129 }
130
126 131
127 return uid; 132 return uid;
128} 133}
129 134
130void 135void
131init_uuid () 136UUID::init ()
132{ 137{
133 read_uuid (); 138 read_uuid ();
134} 139}
135 140
136/* Returns TRUE if every key_values in wants has a partner with the same value in has. */ 141/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
137static int 142static bool
138compare_ob_value_lists_one (const object *wants, const object *has) 143compare_ob_value_lists_one (const object *wants, const object *has)
139{ 144{
140 key_value *wants_field;
141
142 /* n-squared behaviour (see get_ob_key_link()), but I'm hoping both 145 /* n-squared behaviour (see kv_get), but I'm hoping both
143 * objects with lists are rare, and lists stay short. If not, use a 146 * objects with lists are rare, and lists stay short. If not, use a
144 * different structure or at least keep the lists sorted... 147 * different structure or at least keep the lists sorted...
145 */ 148 */
146 149
147 /* For each field in wants, */ 150 /* For each field in wants, */
148 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next) 151 for (key_value *kv = wants->key_values; kv; kv = kv->next)
149 { 152 if (has->kv_get (kv->key) != kv->value)
150 key_value *has_field; 153 return false;
151
152 /* Look for a field in has with the same key. */
153 has_field = get_ob_key_link (has, wants_field->key);
154
155 if (has_field == NULL)
156 {
157 /* No field with that name. */
158 return FALSE;
159 }
160
161 /* Found the matching field. */
162 if (has_field->value != wants_field->value)
163 {
164 /* Values don't match, so this half of the comparison is false. */
165 return FALSE;
166 }
167
168 /* If we get here, we found a match. Now for the next field in wants. */
169 }
170 154
171 /* If we get here, every field in wants has a matching field in has. */ 155 /* If we get here, every field in wants has a matching field in has. */
172 return TRUE; 156 return true;
173} 157}
174 158
175/* Returns TRUE if ob1 has the same key_values as ob2. */ 159/* Returns TRUE if ob1 has the same key_values as ob2. */
176static int 160static bool
177compare_ob_value_lists (const object *ob1, const object *ob2) 161compare_ob_value_lists (const object *ob1, const object *ob2)
178{ 162{
179 /* However, there may be fields in has which aren't partnered in wants, 163 /* However, there may be fields in has which aren't partnered in wants,
180 * so we need to run the comparison *twice*. :( 164 * so we need to run the comparison *twice*. :(
181 */ 165 */
182 return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1); 166 return compare_ob_value_lists_one (ob1, ob2)
167 && compare_ob_value_lists_one (ob2, ob1);
183} 168}
184 169
185/* Function examines the 2 objects given to it, and returns true if 170/* Function examines the 2 objects given to it, and returns true if
186 * they can be merged together. 171 * they can be merged together.
187 * 172 *
202 || ob1->speed != ob2->speed 187 || ob1->speed != ob2->speed
203 || ob1->value != ob2->value 188 || ob1->value != ob2->value
204 || ob1->name != ob2->name) 189 || ob1->name != ob2->name)
205 return 0; 190 return 0;
206 191
207 //TODO: this ain't working well, use nicer and correct overflow check
208 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that 192 /* Do not merge objects if nrof would overflow, assume nrof
209 * value could not be stored in a sint32 (which unfortunately sometimes is 193 * is always 0 .. 2**31-1 */
210 * used to store nrof). 194 if (ob1->nrof > 0x7fffffff - ob2->nrof)
211 */
212 if (ob1->nrof + ob2->nrof >= 1UL << 31)
213 return 0; 195 return 0;
214 196
215 /* If the objects have been identified, set the BEEN_APPLIED flag. 197 /* If the objects have been identified, set the BEEN_APPLIED flag.
216 * This is to the comparison of the flags below will be OK. We 198 * This is to the comparison of the flags below will be OK. We
217 * just can't ignore the been applied or identified flags, as they 199 * just can't ignore the been applied or identified flags, as they
218 * are not equal - just if it has been identified, the been_applied 200 * are not equal - just if it has been identified, the been_applied
219 * flags lose any meaning. 201 * flags lose any meaning.
220 */ 202 */
221 if (QUERY_FLAG (ob1, FLAG_IDENTIFIED)) 203 if (QUERY_FLAG (ob1, FLAG_IDENTIFIED))
222 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 204 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
223 205
224 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 206 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
225 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 207 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
226 208
227 if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any () 209 if (ob1->arch->archname != ob2->arch->archname
228 || ob1->arch != ob2->arch
229 || ob1->name != ob2->name 210 || ob1->name != ob2->name
230 || ob1->title != ob2->title 211 || ob1->title != ob2->title
231 || ob1->msg != ob2->msg 212 || ob1->msg != ob2->msg
232 || ob1->weight != ob2->weight 213 || ob1->weight != ob2->weight
233 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
234 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
235 || ob1->attacktype != ob2->attacktype 214 || ob1->attacktype != ob2->attacktype
236 || ob1->magic != ob2->magic 215 || ob1->magic != ob2->magic
237 || ob1->slaying != ob2->slaying 216 || ob1->slaying != ob2->slaying
238 || ob1->skill != ob2->skill 217 || ob1->skill != ob2->skill
239 || ob1->value != ob2->value 218 || ob1->value != ob2->value
240 || ob1->animation_id != ob2->animation_id 219 || ob1->animation_id != ob2->animation_id
220 || (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependent on each other
241 || ob1->client_type != ob2->client_type 221 || ob1->client_type != ob2->client_type
242 || ob1->materialname != ob2->materialname 222 || ob1->materialname != ob2->materialname
243 || ob1->lore != ob2->lore 223 || ob1->lore != ob2->lore
244 || ob1->subtype != ob2->subtype 224 || ob1->subtype != ob2->subtype
245 || ob1->move_type != ob2->move_type 225 || ob1->move_type != ob2->move_type
246 || ob1->move_block != ob2->move_block 226 || ob1->move_block != ob2->move_block
247 || ob1->move_allow != ob2->move_allow 227 || ob1->move_allow != ob2->move_allow
248 || ob1->move_on != ob2->move_on 228 || ob1->move_on != ob2->move_on
249 || ob1->move_off != ob2->move_off 229 || ob1->move_off != ob2->move_off
250 || ob1->move_slow != ob2->move_slow 230 || ob1->move_slow != ob2->move_slow
251 || ob1->move_slow_penalty != ob2->move_slow_penalty) 231 || ob1->move_slow_penalty != ob2->move_slow_penalty
232 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
233 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
252 return 0; 234 return 0;
253 235
236 if ((ob1->flag ^ ob2->flag)
237 .reset (FLAG_INV_LOCKED)
238 .reset (FLAG_REMOVED)
239 .any ())
240 return 0;
241
254 /* This is really a spellbook check - really, we should 242 /* This is really a spellbook check - we should in general
255 * check all objects in the inventory. 243 * not merge objects with real inventories, as splitting them
244 * is hard.
256 */ 245 */
257 if (ob1->inv || ob2->inv) 246 if (ob1->inv || ob2->inv)
258 { 247 {
259 if (!(ob1->inv && ob2->inv)) 248 if (!(ob1->inv && ob2->inv))
260 return 0; /* inventories differ in length */ 249 return 0; /* inventories differ in length */
261 250
262 if (ob1->inv->below || ob2->inv->below) 251 if (ob1->inv->below || ob2->inv->below)
263 return 0; /* more than one object in inv */ 252 return 0; /* more than one object in inv */
264 253
265 if (!object::can_merge (ob1->inv, ob2->inv)) 254 if (!object::can_merge (ob1->inv, ob2->inv))
266 return 0; /* inventory objexts differ */ 255 return 0; /* inventory objects differ */
267 256
268 /* inventory ok - still need to check rest of this object to see 257 /* inventory ok - still need to check rest of this object to see
269 * if it is valid. 258 * if it is valid.
270 */ 259 */
271 } 260 }
290 if (ob1->level != ob2->level) 279 if (ob1->level != ob2->level)
291 return 0; 280 return 0;
292 break; 281 break;
293 } 282 }
294 283
295 if (ob1->key_values != NULL || ob2->key_values != NULL) 284 if (ob1->key_values || ob2->key_values)
296 { 285 {
297 /* At least one of these has key_values. */ 286 /* At least one of these has key_values. */
298 if ((ob1->key_values == NULL) != (ob2->key_values == NULL)) 287 if ((!ob1->key_values) != (!ob2->key_values))
299 /* One has fields, but the other one doesn't. */ 288 return 0; /* One has fields, but the other one doesn't. */
300 return 0; 289
301 else if (!compare_ob_value_lists (ob1, ob2)) 290 if (!compare_ob_value_lists (ob1, ob2))
302 return 0; 291 return 0;
303 } 292 }
304 293
305 if (ob1->self || ob2->self) 294 if (ob1->self || ob2->self)
306 { 295 {
307 ob1->optimise (); 296 ob1->optimise ();
308 ob2->optimise (); 297 ob2->optimise ();
309 298
310 if (ob1->self || ob2->self) 299 if (ob1->self || ob2->self)
311 { 300 {
312 int k1 = ob1->self ? HvTOTALKEYS (SvRV (ob1->self)) : 0; 301 int k1 = ob1->self ? HvTOTALKEYS (ob1->self) : 0;
313 int k2 = ob2->self ? HvTOTALKEYS (SvRV (ob2->self)) : 0; 302 int k2 = ob2->self ? HvTOTALKEYS (ob2->self) : 0;
314 303
315 if (k1 != k2) 304 if (k1 != k2)
316 return 0; 305 return 0;
306
317 else if (k1 == 0) 307 if (k1 == 0)
318 return 1; 308 return 1;
309
319 else if (!cfperl_can_merge (ob1, ob2)) 310 if (!cfperl_can_merge (ob1, ob2))
320 return 0; 311 return 0;
321 } 312 }
322 } 313 }
323 314
324 /* Everything passes, must be OK. */ 315 /* Everything passes, must be OK. */
325 return 1; 316 return 1;
326} 317}
327 318
319// find player who can see this object
320object *
321object::visible_to () const
322{
323 if (client_visible () && !flag [FLAG_REMOVED])
324 {
325 // see if we are in a container of sorts
326 if (env)
327 {
328 // the player inventory itself is always visible
329 if (env->is_player ())
330 return env;
331
332 // else a player could have our env open
333 object *envest = env->outer_env ();
334
335 // the player itself is always on a map, so we will find him here
336 // even if our inv is in a player.
337 if (envest->is_on_map ())
338 if (object *pl = envest->ms ().player ())
339 if (pl->container == env)
340 return pl;
341 }
342 else
343 {
344 // maybe there is a player standing on the same mapspace
345 // this will catch the case where "this" is a player
346 if (object *pl = ms ().player ())
347 if ((!pl->container && pl->contr->ns && !pl->contr->ns->update_look)
348 || this == pl->container)
349 return pl;
350 }
351 }
352
353 return 0;
354}
355
356// adjust weight per container type ("of holding")
357static sint32
358weight_adjust_for (object *op, sint32 weight)
359{
360 return op->type == CONTAINER
361 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str)
362 : weight;
363}
364
328/* 365/*
366 * adjust_weight(object, weight) adds the specified weight to an object,
367 * and also updates how much the environment(s) is/are carrying.
368 */
369static void
370adjust_weight (object *op, sint32 weight)
371{
372 while (op)
373 {
374 // adjust by actual difference to account for rounding errors
375 // i.e. (w2 - w1) / f != w2 / f - w1 / f and the latter is correct
376 weight = weight_adjust_for (op, op->carrying)
377 - weight_adjust_for (op, op->carrying - weight);
378
379 if (!weight)
380 return;
381
382 op->carrying += weight;
383
384 if (object *pl = op->visible_to ())
385 if (pl != op) // player is handled lazily
386 esrv_update_item (UPD_WEIGHT, pl, op);
387
388 op = op->env;
389 }
390}
391
392/*
329 * sum_weight() is a recursive function which calculates the weight 393 * this is a recursive function which calculates the weight
330 * an object is carrying. It goes through in figures out how much 394 * an object is carrying. It goes through op and figures out how much
331 * containers are carrying, and sums it up. 395 * containers are carrying, and sums it up.
332 */ 396 */
333long 397void
334sum_weight (object *op) 398object::update_weight ()
335{ 399{
336 long sum; 400 sint32 sum = 0;
337 object *inv;
338 401
339 for (sum = 0, inv = op->inv; inv; inv = inv->below) 402 for (object *op = inv; op; op = op->below)
340 { 403 {
341 if (inv->inv) 404 if (op->inv)
342 sum_weight (inv); 405 op->update_weight ();
343 406
344 sum += inv->carrying + inv->weight * (inv->nrof ? inv->nrof : 1); 407 sum += op->total_weight ();
408 }
409
410 sum = weight_adjust_for (this, sum);
411
412 if (sum != carrying)
345 } 413 {
346
347 if (op->type == CONTAINER && op->stats.Str)
348 sum = (sum * (100 - op->stats.Str)) / 100;
349
350 if (op->carrying != sum)
351 op->carrying = sum; 414 carrying = sum;
352 415
353 return sum; 416 if (object *pl = visible_to ())
417 if (pl != this) // player is handled lazily
418 esrv_update_item (UPD_WEIGHT, pl, this);
419 }
354} 420}
355 421
356/** 422/*
357 * Return the outermost environment object for a given object. 423 * Used by: Server DM commands: dumpbelow, dump. Some error messages.
358 */
359
360object *
361object_get_env_recursive (object *op)
362{
363 while (op->env != NULL)
364 op = op->env;
365 return op;
366}
367
368/*
369 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
370 * Some error messages.
371 * The result of the dump is stored in the static global errmsg array.
372 */ 424 */
373char * 425char *
374dump_object (object *op) 426dump_object (object *op)
375{ 427{
376 if (!op) 428 if (!op)
390get_nearest_part (object *op, const object *pl) 442get_nearest_part (object *op, const object *pl)
391{ 443{
392 object *tmp, *closest; 444 object *tmp, *closest;
393 int last_dist, i; 445 int last_dist, i;
394 446
395 if (op->more == NULL) 447 if (!op->more)
396 return op; 448 return op;
449
397 for (last_dist = distance (op, pl), closest = op, tmp = op->more; tmp != NULL; tmp = tmp->more) 450 for (last_dist = distance (op, pl), closest = op, tmp = op->more;
451 tmp;
452 tmp = tmp->more)
398 if ((i = distance (tmp, pl)) < last_dist) 453 if ((i = distance (tmp, pl)) < last_dist)
399 closest = tmp, last_dist = i; 454 closest = tmp, last_dist = i;
455
400 return closest; 456 return closest;
401} 457}
402 458
403/* 459/*
404 * Returns the object which has the count-variable equal to the argument. 460 * Returns the object which has the count-variable equal to the argument.
461 * VERRRY slow.
405 */ 462 */
406object * 463object *
407find_object (tag_t i) 464find_object (tag_t i)
408{ 465{
409 for_all_objects (op) 466 for_all_objects (op)
420 */ 477 */
421object * 478object *
422find_object_name (const char *str) 479find_object_name (const char *str)
423{ 480{
424 shstr_cmp str_ (str); 481 shstr_cmp str_ (str);
425 object *op;
426 482
483 if (str_)
427 for_all_objects (op) 484 for_all_objects (op)
428 if (op->name == str_) 485 if (op->name == str_)
429 break; 486 return op;
430 487
431 return op; 488 return 0;
432}
433
434void
435free_all_object_data ()
436{
437 LOG (llevDebug, "%d allocated objects\n", nrofallocobjects);
438} 489}
439 490
440/* 491/*
441 * Sets the owner and sets the skill and exp pointers to owner's current 492 * Sets the owner and sets the skill and exp pointers to owner's current
442 * skill and experience objects. 493 * skill and experience objects.
447{ 498{
448 // allow objects which own objects 499 // allow objects which own objects
449 if (owner) 500 if (owner)
450 while (owner->owner) 501 while (owner->owner)
451 owner = owner->owner; 502 owner = owner->owner;
503
504 if (flag [FLAG_FREED])
505 {
506 LOG (llevError | logBacktrace, "tried to set owner of %s to %s\n", debug_desc (), owner->debug_desc ());
507 return;
508 }
452 509
453 this->owner = owner; 510 this->owner = owner;
454} 511}
455 512
456int 513int
534 } 591 }
535 592
536 op->key_values = 0; 593 op->key_values = 0;
537} 594}
538 595
539object & 596/*
540object::operator =(const object &src) 597 * copy_to first frees everything allocated by the dst object,
598 * and then copies the contents of itself into the second
599 * object, allocating what needs to be allocated. Basically, any
600 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
601 * if the first object is freed, the pointers in the new object
602 * will point at garbage.
603 */
604void
605object::copy_to (object *dst)
541{ 606{
542 bool is_freed = flag [FLAG_FREED]; 607 dst->remove ();
543 bool is_removed = flag [FLAG_REMOVED];
544
545 *(object_copy *)this = src; 608 *(object_copy *)dst = *this;
546
547 flag [FLAG_FREED] = is_freed;
548 flag [FLAG_REMOVED] = is_removed; 609 dst->flag [FLAG_REMOVED] = true;
549 610
550 /* Copy over key_values, if any. */ 611 /* Copy over key_values, if any. */
551 if (src.key_values) 612 if (key_values)
552 { 613 {
553 key_value *tail = 0; 614 key_value *tail = 0;
554 key_values = 0; 615 dst->key_values = 0;
555 616
556 for (key_value *i = src.key_values; i; i = i->next) 617 for (key_value *i = key_values; i; i = i->next)
557 { 618 {
558 key_value *new_link = new key_value; 619 key_value *new_link = new key_value;
559 620
560 new_link->next = 0; 621 new_link->next = 0;
561 new_link->key = i->key; 622 new_link->key = i->key;
562 new_link->value = i->value; 623 new_link->value = i->value;
563 624
564 /* Try and be clever here, too. */ 625 /* Try and be clever here, too. */
565 if (!key_values) 626 if (!dst->key_values)
566 { 627 {
567 key_values = new_link; 628 dst->key_values = new_link;
568 tail = new_link; 629 tail = new_link;
569 } 630 }
570 else 631 else
571 { 632 {
572 tail->next = new_link; 633 tail->next = new_link;
573 tail = new_link; 634 tail = new_link;
574 } 635 }
575 } 636 }
576 } 637 }
577}
578
579/*
580 * copy_to first frees everything allocated by the dst object,
581 * and then copies the contents of itself into the second
582 * object, allocating what needs to be allocated. Basically, any
583 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
584 * if the first object is freed, the pointers in the new object
585 * will point at garbage.
586 */
587void
588object::copy_to (object *dst)
589{
590 *dst = *this;
591 638
592 if (speed < 0) 639 if (speed < 0)
593 dst->speed_left -= rndm (); 640 dst->speed_left -= rndm ();
594 641
595 dst->set_speed (dst->speed); 642 dst->activate ();
596} 643}
597 644
598void 645void
599object::instantiate () 646object::instantiate ()
600{ 647{
601 if (!uuid.seq) // HACK 648 if (!uuid.seq) // HACK
602 uuid = gen_uuid (); 649 uuid = UUID::gen ();
603 650
604 speed_left = -0.1f; 651 speed_left = -0.1f;
605 /* copy the body_info to the body_used - this is only really 652 /* copy the body_info to the body_used - this is only really
606 * need for monsters, but doesn't hurt to do it for everything. 653 * need for monsters, but doesn't hurt to do it for everything.
607 * by doing so, when a monster is created, it has good starting 654 * by doing so, when a monster is created, it has good starting
617object * 664object *
618object::clone () 665object::clone ()
619{ 666{
620 object *neu = create (); 667 object *neu = create ();
621 copy_to (neu); 668 copy_to (neu);
669 neu->map = map; // not copied by copy_to
622 return neu; 670 return neu;
623} 671}
624 672
625/* 673/*
626 * If an object with the IS_TURNABLE() flag needs to be turned due 674 * If an object with the IS_TURNABLE() flag needs to be turned due
677 * UP_OBJ_FACE: only the objects face has changed. 725 * UP_OBJ_FACE: only the objects face has changed.
678 */ 726 */
679void 727void
680update_object (object *op, int action) 728update_object (object *op, int action)
681{ 729{
682 if (op == NULL) 730 if (!op)
683 { 731 {
684 /* this should never happen */ 732 /* this should never happen */
685 LOG (llevDebug, "update_object() called for NULL object.\n"); 733 LOG (llevError | logBacktrace, "update_object() called for NULL object.\n");
686 return; 734 return;
687 } 735 }
688 736
689 if (op->env) 737 if (!op->is_on_map ())
690 { 738 {
691 /* Animation is currently handled by client, so nothing 739 /* Animation is currently handled by client, so nothing
692 * to do in this case. 740 * to do in this case.
693 */ 741 */
694 return; 742 return;
695 } 743 }
696
697 /* If the map is saving, don't do anything as everything is
698 * going to get freed anyways.
699 */
700 if (!op->map || op->map->in_memory == MAP_SAVING)
701 return;
702 744
703 /* make sure the object is within map boundaries */ 745 /* make sure the object is within map boundaries */
704 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height) 746 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
705 { 747 {
706 LOG (llevError, "update_object() called for object out of map!\n"); 748 LOG (llevError, "update_object() called for object out of map!\n");
717 else if (action == UP_OBJ_INSERT) 759 else if (action == UP_OBJ_INSERT)
718 { 760 {
719 // this is likely overkill, TODO: revisit (schmorp) 761 // this is likely overkill, TODO: revisit (schmorp)
720 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW)) 762 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
721 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC)) 763 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
722 || (op->type == PLAYER && !(m.flags_ & P_PLAYER)) 764 || (op->is_player () && !(m.flags_ & P_PLAYER))
723 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE)) 765 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
724 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE)) 766 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
725 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC)) 767 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
726 || (m.move_on | op->move_on ) != m.move_on 768 || (m.move_on | op->move_on ) != m.move_on
727 || (m.move_off | op->move_off ) != m.move_off 769 || (m.move_off | op->move_off ) != m.move_off
728 || (m.move_slow | op->move_slow) != m.move_slow 770 || (m.move_slow | op->move_slow) != m.move_slow
729 /* This isn't perfect, but I don't expect a lot of objects to 771 /* This isn't perfect, but I don't expect a lot of objects to
730 * to have move_allow right now. 772 * have move_allow right now.
731 */ 773 */
732 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block 774 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
733 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp) 775 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
734 m.flags_ = 0; 776 m.invalidate ();
735 } 777 }
736 /* if the object is being removed, we can't make intelligent 778 /* if the object is being removed, we can't make intelligent
737 * decisions, because remove_ob can't really pass the object 779 * decisions, because remove_ob can't really pass the object
738 * that is being removed. 780 * that is being removed.
739 */ 781 */
740 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 782 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
741 m.flags_ = 0; 783 m.invalidate ();
742 else if (action == UP_OBJ_FACE) 784 else if (action == UP_OBJ_FACE)
743 /* Nothing to do for that case */ ; 785 /* Nothing to do for that case */ ;
744 else 786 else
745 LOG (llevError, "update_object called with invalid action: %d\n", action); 787 LOG (llevError, "update_object called with invalid action: %d\n", action);
746 788
766static int object_count; 808static int object_count;
767 809
768void object::link () 810void object::link ()
769{ 811{
770 assert (!index);//D 812 assert (!index);//D
771 uuid = gen_uuid (); 813 uuid = UUID::gen ();
772 count = ++object_count; 814 count = ++object_count;
773 815
774 refcnt_inc (); 816 refcnt_inc ();
775 objects.insert (this); 817 objects.insert (this);
776} 818}
788object::activate () 830object::activate ()
789{ 831{
790 /* If already on active list, don't do anything */ 832 /* If already on active list, don't do anything */
791 if (active) 833 if (active)
792 return; 834 return;
835
836 if (has_active_speed () && flag [FLAG_FREED]) LOG (llevError | logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
837 if (has_active_speed () && flag [FLAG_DEBUG]) LOG (llevError | logBacktrace, "BUG: tried to activate DEBUG object %s\n", debug_desc ());//D temp
793 838
794 if (has_active_speed ()) 839 if (has_active_speed ())
795 actives.insert (this); 840 actives.insert (this);
796} 841}
797 842
849object::destroy_inv (bool drop_to_ground) 894object::destroy_inv (bool drop_to_ground)
850{ 895{
851 // need to check first, because the checks below might segfault 896 // need to check first, because the checks below might segfault
852 // as we might be on an invalid mapspace and crossfire code 897 // as we might be on an invalid mapspace and crossfire code
853 // is too buggy to ensure that the inventory is empty. 898 // is too buggy to ensure that the inventory is empty.
854 // corollary: if you create arrows etc. with stuff in tis inventory, 899 // corollary: if you create arrows etc. with stuff in its inventory,
855 // cf will crash below with off-map x and y 900 // cf will crash below with off-map x and y
856 if (!inv) 901 if (!inv)
857 return; 902 return;
858 903
859 /* Only if the space blocks everything do we not process - 904 /* Only if the space blocks everything do we not process -
860 * if some form of movement is allowed, let objects 905 * if some form of movement is allowed, let objects
861 * drop on that space. 906 * drop on that space.
862 */ 907 */
863 if (!drop_to_ground 908 if (!drop_to_ground
864 || !map 909 || !map
865 || map->in_memory != MAP_IN_MEMORY 910 || map->in_memory != MAP_ACTIVE
866 || map->nodrop 911 || map->no_drop
867 || ms ().move_block == MOVE_ALL) 912 || ms ().move_block == MOVE_ALL)
868 { 913 {
869 while (inv) 914 while (inv)
870 {
871 inv->destroy_inv (drop_to_ground);
872 inv->destroy (); 915 inv->destroy ();
873 }
874 } 916 }
875 else 917 else
876 { /* Put objects in inventory onto this space */ 918 { /* Put objects in inventory onto this space */
877 while (inv) 919 while (inv)
878 { 920 {
896 object *op = new object; 938 object *op = new object;
897 op->link (); 939 op->link ();
898 return op; 940 return op;
899} 941}
900 942
943static struct freed_map : maptile
944{
945 freed_map ()
946 {
947 path = "<freed objects map>";
948 name = "/internal/freed_objects_map";
949 width = 3;
950 height = 3;
951 no_drop = 1;
952 no_reset = 1;
953
954 alloc ();
955 in_memory = MAP_ACTIVE;
956 }
957
958 ~freed_map ()
959 {
960 destroy ();
961 }
962} freed_map; // freed objects are moved here to avoid crashes
963
901void 964void
902object::do_destroy () 965object::do_destroy ()
903{ 966{
904 attachable::do_destroy ();
905
906 if (flag [FLAG_IS_LINKED]) 967 if (flag [FLAG_IS_LINKED])
907 remove_button_link (this); 968 remove_link ();
908 969
909 if (flag [FLAG_FRIENDLY]) 970 if (flag [FLAG_FRIENDLY])
910 remove_friendly_object (this); 971 remove_friendly_object (this);
911 972
912 if (!flag [FLAG_REMOVED])
913 remove (); 973 remove ();
914 974
915 destroy_inv (true); 975 attachable::do_destroy ();
916 976
917 deactivate (); 977 deactivate ();
918 unlink (); 978 unlink ();
919 979
920 flag [FLAG_FREED] = 1; 980 flag [FLAG_FREED] = 1;
921 981
922 // hack to ensure that freed objects still have a valid map 982 // hack to ensure that freed objects still have a valid map
923 {
924 static maptile *freed_map; // freed objects are moved here to avoid crashes
925
926 if (!freed_map)
927 {
928 freed_map = new maptile;
929
930 freed_map->path = "<freed objects map>";
931 freed_map->name = "/internal/freed_objects_map";
932 freed_map->width = 3;
933 freed_map->height = 3;
934
935 freed_map->alloc ();
936 freed_map->in_memory = MAP_IN_MEMORY;
937 }
938
939 map = freed_map; 983 map = &freed_map;
940 x = 1; 984 x = 1;
941 y = 1; 985 y = 1;
942 }
943 986
944 if (more) 987 if (more)
945 { 988 {
946 more->destroy (); 989 more->destroy ();
947 more = 0; 990 more = 0;
955 attacked_by = 0; 998 attacked_by = 0;
956 current_weapon = 0; 999 current_weapon = 0;
957} 1000}
958 1001
959void 1002void
960object::destroy (bool destroy_inventory) 1003object::destroy ()
961{ 1004{
962 if (destroyed ()) 1005 if (destroyed ())
963 return; 1006 return;
964 1007
965 if (destroy_inventory) 1008 if (!is_head () && !head->destroyed ())
1009 {
1010 LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
1011 head->destroy ();
1012 return;
1013 }
1014
966 destroy_inv (false); 1015 destroy_inv (false);
967 1016
968 if (is_head ()) 1017 if (is_head ())
969 if (sound_destroy) 1018 if (sound_destroy)
970 play_sound (sound_destroy); 1019 play_sound (sound_destroy);
971 else if (flag [FLAG_MONSTER]) 1020 else if (flag [FLAG_MONSTER])
972 play_sound (sound_find ("monster_destroy")); // quick hack, too lazy to create a generic mechanism 1021 play_sound (sound_find ("monster_destroy")); // quick hack, too lazy to create a generic mechanism
973 1022
974 attachable::destroy (); 1023 attachable::destroy ();
975}
976
977/*
978 * sub_weight() recursively (outwards) subtracts a number from the
979 * weight of an object (and what is carried by it's environment(s)).
980 */
981void
982sub_weight (object *op, signed long weight)
983{
984 while (op != NULL)
985 {
986 if (op->type == CONTAINER)
987 weight = (signed long) (weight * (100 - op->stats.Str) / 100);
988
989 op->carrying -= weight;
990 op = op->env;
991 }
992} 1024}
993 1025
994/* op->remove (): 1026/* op->remove ():
995 * This function removes the object op from the linked list of objects 1027 * This function removes the object op from the linked list of objects
996 * which it is currently tied to. When this function is done, the 1028 * which it is currently tied to. When this function is done, the
1002object::do_remove () 1034object::do_remove ()
1003{ 1035{
1004 object *tmp, *last = 0; 1036 object *tmp, *last = 0;
1005 object *otmp; 1037 object *otmp;
1006 1038
1007 if (QUERY_FLAG (this, FLAG_REMOVED)) 1039 if (flag [FLAG_REMOVED])
1008 return; 1040 return;
1009 1041
1010 SET_FLAG (this, FLAG_REMOVED);
1011 INVOKE_OBJECT (REMOVE, this); 1042 INVOKE_OBJECT (REMOVE, this);
1043
1044 flag [FLAG_REMOVED] = true;
1012 1045
1013 if (more) 1046 if (more)
1014 more->remove (); 1047 more->remove ();
1015 1048
1016 /* 1049 /*
1017 * In this case, the object to be removed is in someones 1050 * In this case, the object to be removed is in someones
1018 * inventory. 1051 * inventory.
1019 */ 1052 */
1020 if (env) 1053 if (env)
1021 { 1054 {
1022 if (nrof) 1055 flag [FLAG_REMOVED] = false; // hack around the issue of visible_to checking flag_removed
1023 sub_weight (env, weight * nrof); 1056 if (object *pl = visible_to ())
1024 else 1057 esrv_del_item (pl->contr, count);
1025 sub_weight (env, weight + carrying); 1058 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
1059
1060 adjust_weight (env, -total_weight ());
1061
1062 object *pl = in_player ();
1063
1064 /* we set up values so that it could be inserted into
1065 * the map, but we don't actually do that - it is up
1066 * to the caller to decide what we want to do.
1067 */
1068 map = env->map;
1069 x = env->x;
1070 y = env->y;
1071
1072 // make sure cmov optimisation is applicable
1073 *(above ? &above->below : &env->inv) = below;
1074 *(below ? &below->above : &above ) = above; // &above is just a dummy
1075
1076 above = 0;
1077 below = 0;
1078 env = 0;
1026 1079
1027 /* NO_FIX_PLAYER is set when a great many changes are being 1080 /* NO_FIX_PLAYER is set when a great many changes are being
1028 * made to players inventory. If set, avoiding the call 1081 * made to players inventory. If set, avoiding the call
1029 * to save cpu time. 1082 * to save cpu time.
1030 */ 1083 */
1031 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1084 if (pl)
1085 if (pl->is_player () && (glow_radius || !QUERY_FLAG (pl, FLAG_NO_FIX_PLAYER)))
1086 {
1032 otmp->update_stats (); 1087 pl->update_stats ();
1033 1088
1034 if (above) 1089 if (glow_radius && pl->is_on_map ())
1035 above->below = below; 1090 update_all_los (pl->map, pl->x, pl->y);
1036 else 1091 }
1037 env->inv = below;
1038
1039 if (below)
1040 below->above = above;
1041
1042 /* we set up values so that it could be inserted into
1043 * the map, but we don't actually do that - it is up
1044 * to the caller to decide what we want to do.
1045 */
1046 x = env->x, y = env->y;
1047 map = env->map;
1048 above = 0, below = 0;
1049 env = 0;
1050 } 1092 }
1051 else if (map) 1093 else if (map)
1052 { 1094 {
1053 if (type == PLAYER)
1054 {
1055 // leaving a spot always closes any open container on the ground
1056 if (container && !container->env)
1057 // this causes spurious floorbox updates, but it ensures
1058 // that the CLOSE event is being sent.
1059 close_container ();
1060
1061 --map->players;
1062 map->touch ();
1063 }
1064
1065 map->dirty = true; 1095 map->dirty = true;
1066 mapspace &ms = this->ms (); 1096 mapspace &ms = this->ms ();
1067 1097
1098 if (object *pl = ms.player ())
1099 {
1100 if (is_player ())
1101 {
1102 if (!flag [FLAG_WIZPASS])
1103 ms.smell = ++mapspace::smellcount; // remember the smell of the player
1104
1105 // leaving a spot always closes any open container on the ground
1106 if (container && !container->env)
1107 // this causes spurious floorbox updates, but it ensures
1108 // that the CLOSE event is being sent.
1109 close_container ();
1110
1111 --map->players;
1112 map->touch ();
1113 }
1114 else if (pl->container == this)
1115 {
1116 // removing a container should close it
1117 close_container ();
1118 }
1119
1120 esrv_del_item (pl->contr, count);
1121 }
1122
1068 /* link the object above us */ 1123 /* link the object above us */
1069 if (above) 1124 // re-link, make sure compiler can easily use cmove
1070 above->below = below; 1125 *(above ? &above->below : &ms.top) = below;
1071 else 1126 *(below ? &below->above : &ms.bot) = above;
1072 ms.top = below; /* we were top, set new top */
1073
1074 /* Relink the object below us, if there is one */
1075 if (below)
1076 below->above = above;
1077 else
1078 {
1079 /* Nothing below, which means we need to relink map object for this space
1080 * use translated coordinates in case some oddness with map tiling is
1081 * evident
1082 */
1083 if (GET_MAP_OB (map, x, y) != this)
1084 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1085
1086 ms.bot = above; /* goes on above it. */
1087 }
1088 1127
1089 above = 0; 1128 above = 0;
1090 below = 0; 1129 below = 0;
1130
1131 ms.invalidate ();
1091 1132
1092 if (map->in_memory == MAP_SAVING) 1133 if (map->in_memory == MAP_SAVING)
1093 return; 1134 return;
1094 1135
1095 int check_walk_off = !flag [FLAG_NO_APPLY]; 1136 int check_walk_off = !flag [FLAG_NO_APPLY];
1101 * removed (most likely destroyed), update the player view 1142 * removed (most likely destroyed), update the player view
1102 * appropriately. 1143 * appropriately.
1103 */ 1144 */
1104 pl->close_container (); 1145 pl->close_container ();
1105 1146
1147 //TODO: the floorbox prev/next might need updating
1148 //esrv_del_item (pl->contr, count);
1149 //TODO: update floorbox to preserve ordering
1150 if (pl->contr->ns)
1106 pl->contr->ns->floorbox_update (); 1151 pl->contr->ns->floorbox_update ();
1107 } 1152 }
1108 1153
1109 for (tmp = ms.bot; tmp; tmp = tmp->above) 1154 for (tmp = ms.bot; tmp; tmp = tmp->above)
1110 { 1155 {
1111 /* No point updating the players look faces if he is the object 1156 /* No point updating the players look faces if he is the object
1124 } 1169 }
1125 1170
1126 last = tmp; 1171 last = tmp;
1127 } 1172 }
1128 1173
1129 /* last == NULL if there are no objects on this space */ 1174 if (affects_los ())
1130 //TODO: this makes little sense, why only update the topmost object?
1131 if (!last)
1132 map->at (x, y).flags_ = 0;
1133 else
1134 update_object (last, UP_OBJ_REMOVE);
1135
1136 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1137 update_all_los (map, x, y); 1175 update_all_los (map, x, y);
1138 } 1176 }
1139} 1177}
1140 1178
1141/* 1179/*
1155 if (!top) 1193 if (!top)
1156 for (top = op; top && top->above; top = top->above) 1194 for (top = op; top && top->above; top = top->above)
1157 ; 1195 ;
1158 1196
1159 for (; top; top = top->below) 1197 for (; top; top = top->below)
1160 {
1161 if (top == op)
1162 continue;
1163
1164 if (object::can_merge (op, top)) 1198 if (object::can_merge (op, top))
1165 { 1199 {
1166 top->nrof += op->nrof; 1200 top->nrof += op->nrof;
1167 1201
1168/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/ 1202 if (object *pl = top->visible_to ())
1169 op->weight = 0; /* Don't want any adjustements now */ 1203 esrv_update_item (UPD_NROF, pl, top);
1204
1205 op->weight = 0; // cancel the addition above
1206 op->carrying = 0; // must be 0 already
1207
1170 op->destroy (); 1208 op->destroy ();
1209
1171 return top; 1210 return top;
1172 } 1211 }
1173 }
1174 1212
1175 return 0; 1213 return 0;
1176} 1214}
1177 1215
1178void 1216void
1203 * job preparing multi-part monsters. 1241 * job preparing multi-part monsters.
1204 */ 1242 */
1205object * 1243object *
1206insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1244insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1207{ 1245{
1246 op->remove ();
1247
1208 for (object *tmp = op->head_ (); tmp; tmp = tmp->more) 1248 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1209 { 1249 {
1210 tmp->x = x + tmp->arch->x; 1250 tmp->x = x + tmp->arch->x;
1211 tmp->y = y + tmp->arch->y; 1251 tmp->y = y + tmp->arch->y;
1212 } 1252 }
1235 * just 'op' otherwise 1275 * just 'op' otherwise
1236 */ 1276 */
1237object * 1277object *
1238insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1278insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1239{ 1279{
1240 assert (!op->flag [FLAG_FREED]);
1241
1242 object *top, *floor = NULL;
1243
1244 op->remove (); 1280 op->remove ();
1281
1282 if (m == &freed_map)//D TODO: remove soon
1283 {//D
1284 LOG (llevError | logBacktrace, "tries to insret object on freed objects map: %s", op->debug_desc ());//D
1285 }//D
1245 1286
1246 /* Ideally, the caller figures this out. However, it complicates a lot 1287 /* Ideally, the caller figures this out. However, it complicates a lot
1247 * of areas of callers (eg, anything that uses find_free_spot would now 1288 * of areas of callers (eg, anything that uses find_free_spot would now
1248 * need extra work 1289 * need extra work
1249 */ 1290 */
1291 maptile *newmap = m;
1250 if (!xy_normalise (m, op->x, op->y)) 1292 if (!xy_normalise (newmap, op->x, op->y))
1251 { 1293 {
1252 op->destroy (); 1294 op->head_ ()->destroy ();// remove head_ once all tail object destroyers found
1253 return 0; 1295 return 0;
1254 } 1296 }
1255 1297
1256 if (object *more = op->more) 1298 if (object *more = op->more)
1257 if (!insert_ob_in_map (more, m, originator, flag)) 1299 if (!insert_ob_in_map (more, m, originator, flag))
1258 return 0; 1300 return 0;
1259 1301
1260 CLEAR_FLAG (op, FLAG_REMOVED); 1302 CLEAR_FLAG (op, FLAG_REMOVED);
1261 1303
1262 op->map = m; 1304 op->map = newmap;
1263 mapspace &ms = op->ms (); 1305 mapspace &ms = op->ms ();
1264 1306
1265 /* this has to be done after we translate the coordinates. 1307 /* this has to be done after we translate the coordinates.
1266 */ 1308 */
1267 if (op->nrof && !(flag & INS_NO_MERGE)) 1309 if (op->nrof && !(flag & INS_NO_MERGE))
1268 for (object *tmp = ms.bot; tmp; tmp = tmp->above) 1310 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1269 if (object::can_merge (op, tmp)) 1311 if (object::can_merge (op, tmp))
1270 { 1312 {
1313 // TODO: we actually want to update tmp, not op,
1314 // but some caller surely breaks when we return tmp
1315 // from here :/
1271 op->nrof += tmp->nrof; 1316 op->nrof += tmp->nrof;
1272 tmp->destroy (); 1317 tmp->destroy ();
1273 } 1318 }
1274 1319
1275 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1320 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1284 { 1329 {
1285 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n"); 1330 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1286 abort (); 1331 abort ();
1287 } 1332 }
1288 1333
1334 if (!originator->is_on_map ())
1335 LOG (llevDebug | logBacktrace, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
1336 op->debug_desc (), originator->debug_desc ());
1337
1289 op->above = originator; 1338 op->above = originator;
1290 op->below = originator->below; 1339 op->below = originator->below;
1291
1292 if (op->below)
1293 op->below->above = op;
1294 else
1295 ms.bot = op;
1296
1297 /* since *below* originator, no need to update top */
1298 originator->below = op; 1340 originator->below = op;
1341
1342 *(op->below ? &op->below->above : &ms.bot) = op;
1299 } 1343 }
1300 else 1344 else
1301 { 1345 {
1302 top = ms.bot; 1346 object *floor = 0;
1347 object *top = ms.top;
1303 1348
1304 /* If there are other objects, then */ 1349 /* If there are other objects, then */
1305 if (top) 1350 if (top)
1306 { 1351 {
1307 object *last = 0;
1308
1309 /* 1352 /*
1310 * If there are multiple objects on this space, we do some trickier handling. 1353 * If there are multiple objects on this space, we do some trickier handling.
1311 * We've already dealt with merging if appropriate. 1354 * We've already dealt with merging if appropriate.
1312 * Generally, we want to put the new object on top. But if 1355 * Generally, we want to put the new object on top. But if
1313 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last 1356 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
1316 * once we get to them. This reduces the need to traverse over all of 1359 * once we get to them. This reduces the need to traverse over all of
1317 * them when adding another one - this saves quite a bit of cpu time 1360 * them when adding another one - this saves quite a bit of cpu time
1318 * when lots of spells are cast in one area. Currently, it is presumed 1361 * when lots of spells are cast in one area. Currently, it is presumed
1319 * that flying non pickable objects are spell objects. 1362 * that flying non pickable objects are spell objects.
1320 */ 1363 */
1321 for (top = ms.bot; top; top = top->above) 1364 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1322 { 1365 {
1323 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1366 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) || QUERY_FLAG (tmp, FLAG_OVERLAY_FLOOR))
1324 floor = top; 1367 floor = tmp;
1325 1368
1326 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1369 if (QUERY_FLAG (tmp, FLAG_NO_PICK) && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (tmp, FLAG_IS_FLOOR))
1327 { 1370 {
1328 /* We insert above top, so we want this object below this */ 1371 /* We insert above top, so we want this object below this */
1329 top = top->below; 1372 top = tmp->below;
1330 break; 1373 break;
1331 } 1374 }
1332 1375
1333 last = top; 1376 top = tmp;
1334 } 1377 }
1335
1336 /* Don't want top to be NULL, so set it to the last valid object */
1337 top = last;
1338 1378
1339 /* We let update_position deal with figuring out what the space 1379 /* We let update_position deal with figuring out what the space
1340 * looks like instead of lots of conditions here. 1380 * looks like instead of lots of conditions here.
1341 * makes things faster, and effectively the same result. 1381 * makes things faster, and effectively the same result.
1342 */ 1382 */
1349 */ 1389 */
1350 if (!(flag & INS_ON_TOP) 1390 if (!(flag & INS_ON_TOP)
1351 && ms.flags () & P_BLOCKSVIEW 1391 && ms.flags () & P_BLOCKSVIEW
1352 && (op->face && !faces [op->face].visibility)) 1392 && (op->face && !faces [op->face].visibility))
1353 { 1393 {
1394 object *last;
1395
1354 for (last = top; last != floor; last = last->below) 1396 for (last = top; last != floor; last = last->below)
1355 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1397 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1356 break; 1398 break;
1357 1399
1358 /* Check to see if we found the object that blocks view, 1400 /* Check to see if we found the object that blocks view,
1366 } /* If objects on this space */ 1408 } /* If objects on this space */
1367 1409
1368 if (flag & INS_ABOVE_FLOOR_ONLY) 1410 if (flag & INS_ABOVE_FLOOR_ONLY)
1369 top = floor; 1411 top = floor;
1370 1412
1371 /* Top is the object that our object (op) is going to get inserted above. 1413 // insert object above top, or bottom-most if top = 0
1372 */
1373
1374 /* First object on this space */
1375 if (!top) 1414 if (!top)
1376 { 1415 {
1416 op->below = 0;
1377 op->above = ms.bot; 1417 op->above = ms.bot;
1378
1379 if (op->above)
1380 op->above->below = op;
1381
1382 op->below = 0;
1383 ms.bot = op; 1418 ms.bot = op;
1419
1420 *(op->above ? &op->above->below : &ms.top) = op;
1384 } 1421 }
1385 else 1422 else
1386 { /* get inserted into the stack above top */ 1423 {
1387 op->above = top->above; 1424 op->above = top->above;
1388
1389 if (op->above)
1390 op->above->below = op; 1425 top->above = op;
1391 1426
1392 op->below = top; 1427 op->below = top;
1393 top->above = op; 1428 *(op->above ? &op->above->below : &ms.top) = op;
1394 } 1429 }
1430 }
1395 1431
1396 if (!op->above) 1432 if (op->is_player ())
1397 ms.top = op;
1398 } /* else not INS_BELOW_ORIGINATOR */
1399
1400 if (op->type == PLAYER)
1401 { 1433 {
1402 op->contr->do_los = 1; 1434 op->contr->do_los = 1;
1403 ++op->map->players; 1435 ++op->map->players;
1404 op->map->touch (); 1436 op->map->touch ();
1405 } 1437 }
1406 1438
1407 op->map->dirty = true; 1439 op->map->dirty = true;
1408 1440
1409 if (object *pl = ms.player ()) 1441 if (object *pl = ms.player ())
1442 //TODO: the floorbox prev/next might need updating
1443 //esrv_send_item (pl, op);
1444 //TODO: update floorbox to preserve ordering
1445 if (pl->contr->ns)
1410 pl->contr->ns->floorbox_update (); 1446 pl->contr->ns->floorbox_update ();
1411 1447
1412 /* If this object glows, it may affect lighting conditions that are 1448 /* If this object glows, it may affect lighting conditions that are
1413 * visible to others on this map. But update_all_los is really 1449 * visible to others on this map. But update_all_los is really
1414 * an inefficient way to do this, as it means los for all players 1450 * an inefficient way to do this, as it means los for all players
1415 * on the map will get recalculated. The players could very well 1451 * on the map will get recalculated. The players could very well
1416 * be far away from this change and not affected in any way - 1452 * be far away from this change and not affected in any way -
1417 * this should get redone to only look for players within range, 1453 * this should get redone to only look for players within range,
1418 * or just updating the P_UPTODATE for spaces within this area 1454 * or just updating the P_UPTODATE for spaces within this area
1419 * of effect may be sufficient. 1455 * of effect may be sufficient.
1420 */ 1456 */
1421 if (op->map->darkness && (op->glow_radius != 0)) 1457 if (op->affects_los ())
1458 {
1459 op->ms ().invalidate ();
1422 update_all_los (op->map, op->x, op->y); 1460 update_all_los (op->map, op->x, op->y);
1461 }
1423 1462
1424 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1463 /* updates flags (blocked, alive, no magic, etc) for this map space */
1425 update_object (op, UP_OBJ_INSERT); 1464 update_object (op, UP_OBJ_INSERT);
1426 1465
1427 INVOKE_OBJECT (INSERT, op); 1466 INVOKE_OBJECT (INSERT, op);
1455/* this function inserts an object in the map, but if it 1494/* this function inserts an object in the map, but if it
1456 * finds an object of its own type, it'll remove that one first. 1495 * finds an object of its own type, it'll remove that one first.
1457 * op is the object to insert it under: supplies x and the map. 1496 * op is the object to insert it under: supplies x and the map.
1458 */ 1497 */
1459void 1498void
1460replace_insert_ob_in_map (const char *arch_string, object *op) 1499replace_insert_ob_in_map (shstr_tmp archname, object *op)
1461{ 1500{
1462 object *tmp, *tmp1;
1463
1464 /* first search for itself and remove any old instances */ 1501 /* first search for itself and remove any old instances */
1465 1502
1466 for (tmp = op->ms ().bot; tmp; tmp = tmp->above) 1503 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1467 if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */ 1504 if (tmp->arch->archname == archname) /* same archetype */
1468 tmp->destroy (); 1505 tmp->destroy ();
1469 1506
1470 tmp1 = arch_to_object (archetype::find (arch_string)); 1507 object *tmp = arch_to_object (archetype::find (archname));
1471 1508
1472 tmp1->x = op->x; 1509 tmp->x = op->x;
1473 tmp1->y = op->y; 1510 tmp->y = op->y;
1511
1474 insert_ob_in_map (tmp1, op->map, op, 0); 1512 insert_ob_in_map (tmp, op->map, op, 0);
1475} 1513}
1476 1514
1477object * 1515object *
1478object::insert_at (object *where, object *originator, int flags) 1516object::insert_at (object *where, object *originator, int flags)
1479{ 1517{
1518 if (where->env)
1519 return where->env->insert (this);
1520 else
1480 return where->map->insert (this, where->x, where->y, originator, flags); 1521 return where->map->insert (this, where->x, where->y, originator, flags);
1481} 1522}
1482 1523
1483/* 1524/*
1484 * get_split_ob(ob,nr) splits up ob into two parts. The part which
1485 * is returned contains nr objects, and the remaining parts contains
1486 * the rest (or is removed and freed if that number is 0).
1487 * On failure, NULL is returned, and the reason put into the
1488 * global static errmsg array.
1489 */
1490object *
1491get_split_ob (object *orig_ob, uint32 nr)
1492{
1493 object *newob;
1494 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1495
1496 if (orig_ob->nrof < nr)
1497 {
1498 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1499 return NULL;
1500 }
1501
1502 newob = object_create_clone (orig_ob);
1503
1504 if ((orig_ob->nrof -= nr) < 1)
1505 orig_ob->destroy (1);
1506 else if (!is_removed)
1507 {
1508 if (orig_ob->env != NULL)
1509 sub_weight (orig_ob->env, orig_ob->weight * nr);
1510 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY)
1511 {
1512 strcpy (errmsg, "Tried to split object whose map is not in memory.");
1513 LOG (llevDebug, "Error, Tried to split object whose map is not in memory.\n");
1514 return NULL;
1515 }
1516 }
1517
1518 newob->nrof = nr;
1519
1520 return newob;
1521}
1522
1523/*
1524 * decrease_ob_nr(object, number) decreases a specified number from 1525 * decrease(object, number) decreases a specified number from
1525 * the amount of an object. If the amount reaches 0, the object 1526 * the amount of an object. If the amount reaches 0, the object
1526 * is subsequently removed and freed. 1527 * is subsequently removed and freed.
1527 * 1528 *
1528 * Return value: 'op' if something is left, NULL if the amount reached 0 1529 * Return value: 'op' if something is left, NULL if the amount reached 0
1529 */ 1530 */
1531bool
1532object::decrease (sint32 nr)
1533{
1534 if (!nr)
1535 return true;
1536
1537 nr = min (nr, nrof);
1538
1539 if (nrof > nr)
1540 {
1541 nrof -= nr;
1542 adjust_weight (env, -weight * max (1, nr)); // carrying == 0
1543
1544 if (object *pl = visible_to ())
1545 esrv_update_item (UPD_NROF, pl, this);
1546
1547 return true;
1548 }
1549 else
1550 {
1551 destroy ();
1552 return false;
1553 }
1554}
1555
1556/*
1557 * split(ob,nr) splits up ob into two parts. The part which
1558 * is returned contains nr objects, and the remaining parts contains
1559 * the rest (or is removed and returned if that number is 0).
1560 * On failure, NULL is returned.
1561 */
1530object * 1562object *
1531decrease_ob_nr (object *op, uint32 i) 1563object::split (sint32 nr)
1532{ 1564{
1533 object *tmp; 1565 int have = number_of ();
1534 1566
1535 if (i == 0) /* objects with op->nrof require this check */ 1567 if (have < nr)
1536 return op; 1568 return 0;
1537 1569 else if (have == nr)
1538 if (i > op->nrof)
1539 i = op->nrof;
1540
1541 if (QUERY_FLAG (op, FLAG_REMOVED))
1542 op->nrof -= i;
1543 else if (op->env)
1544 { 1570 {
1545 /* is this object in the players inventory, or sub container
1546 * therein?
1547 */
1548 tmp = op->in_player ();
1549 /* nope. Is this a container the player has opened?
1550 * If so, set tmp to that player.
1551 * IMO, searching through all the players will mostly
1552 * likely be quicker than following op->env to the map,
1553 * and then searching the map for a player.
1554 */
1555 if (!tmp)
1556 for_all_players (pl)
1557 if (pl->ob->container == op->env)
1558 {
1559 tmp = pl->ob;
1560 break;
1561 }
1562
1563 if (i < op->nrof)
1564 {
1565 sub_weight (op->env, op->weight * i);
1566 op->nrof -= i;
1567 if (tmp)
1568 esrv_send_item (tmp, op);
1569 }
1570 else
1571 {
1572 op->remove (); 1571 remove ();
1573 op->nrof = 0; 1572 return this;
1574 if (tmp)
1575 esrv_del_item (tmp->contr, op->count);
1576 }
1577 } 1573 }
1578 else 1574 else
1579 { 1575 {
1580 object *above = op->above; 1576 decrease (nr);
1581 1577
1582 if (i < op->nrof) 1578 object *op = deep_clone ();
1583 op->nrof -= i; 1579 op->nrof = nr;
1584 else
1585 {
1586 op->remove ();
1587 op->nrof = 0;
1588 }
1589
1590 /* Since we just removed op, op->above is null */
1591 for (tmp = above; tmp; tmp = tmp->above)
1592 if (tmp->type == PLAYER)
1593 {
1594 if (op->nrof)
1595 esrv_send_item (tmp, op);
1596 else
1597 esrv_del_item (tmp->contr, op->count);
1598 }
1599 }
1600
1601 if (op->nrof)
1602 return op; 1580 return op;
1603 else
1604 {
1605 op->destroy ();
1606 return 0;
1607 }
1608}
1609
1610/*
1611 * add_weight(object, weight) adds the specified weight to an object,
1612 * and also updates how much the environment(s) is/are carrying.
1613 */
1614void
1615add_weight (object *op, signed long weight)
1616{
1617 while (op != NULL)
1618 {
1619 if (op->type == CONTAINER)
1620 weight = (signed long) (weight * (100 - op->stats.Str) / 100);
1621
1622 op->carrying += weight;
1623 op = op->env;
1624 } 1581 }
1625} 1582}
1626 1583
1627object * 1584object *
1628insert_ob_in_ob (object *op, object *where) 1585insert_ob_in_ob (object *op, object *where)
1653 * be != op, if items are merged. -Tero 1610 * be != op, if items are merged. -Tero
1654 */ 1611 */
1655object * 1612object *
1656object::insert (object *op) 1613object::insert (object *op)
1657{ 1614{
1658 if (!QUERY_FLAG (op, FLAG_REMOVED))
1659 op->remove ();
1660
1661 if (op->more) 1615 if (op->more)
1662 { 1616 {
1663 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count); 1617 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);
1664 return op; 1618 return op;
1665 } 1619 }
1666 1620
1667 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL); 1621 op->remove ();
1668 CLEAR_FLAG (op, FLAG_REMOVED); 1622
1623 op->flag [FLAG_OBJ_ORIGINAL] = 0;
1669 1624
1670 if (op->nrof) 1625 if (op->nrof)
1671 {
1672 for (object *tmp = inv; tmp; tmp = tmp->below) 1626 for (object *tmp = inv; tmp; tmp = tmp->below)
1673 if (object::can_merge (tmp, op)) 1627 if (object::can_merge (tmp, op))
1674 { 1628 {
1675 /* return the original object and remove inserted object 1629 /* return the original object and remove inserted object
1676 (client needs the original object) */ 1630 (client needs the original object) */
1677 tmp->nrof += op->nrof; 1631 tmp->nrof += op->nrof;
1678 /* Weight handling gets pretty funky. Since we are adding to 1632
1679 * tmp->nrof, we need to increase the weight. 1633 if (object *pl = tmp->visible_to ())
1680 */ 1634 esrv_update_item (UPD_NROF, pl, tmp);
1635
1681 add_weight (this, op->weight * op->nrof); 1636 adjust_weight (this, op->total_weight ());
1682 SET_FLAG (op, FLAG_REMOVED); 1637
1683 op->destroy (); /* free the inserted object */ 1638 op->destroy ();
1684 op = tmp; 1639 op = tmp;
1685 op->remove (); /* and fix old object's links */ 1640 goto inserted;
1686 CLEAR_FLAG (op, FLAG_REMOVED);
1687 break;
1688 } 1641 }
1689 1642
1690 /* I assume combined objects have no inventory
1691 * We add the weight - this object could have just been removed
1692 * (if it was possible to merge). calling remove_ob will subtract
1693 * the weight, so we need to add it in again, since we actually do
1694 * the linking below
1695 */
1696 add_weight (this, op->weight * op->nrof);
1697 }
1698 else
1699 add_weight (this, (op->weight + op->carrying));
1700
1701 if (object *otmp = this->in_player ())
1702 if (otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1703 otmp->update_stats ();
1704
1705 op->owner = 0; // its his/hers now. period. 1643 op->owner = 0; // it's his/hers now. period.
1706 op->map = 0; 1644 op->map = 0;
1645 op->x = 0;
1646 op->y = 0;
1647
1648 op->above = 0;
1649 op->below = inv;
1707 op->env = this; 1650 op->env = this;
1708 op->above = 0;
1709 op->below = 0;
1710 op->x = op->y = 0;
1711 1651
1652 if (inv)
1653 inv->above = op;
1654
1655 inv = op;
1656
1657 op->flag [FLAG_REMOVED] = 0;
1658
1659 if (object *pl = op->visible_to ())
1660 esrv_send_item (pl, op);
1661
1662 adjust_weight (this, op->total_weight ());
1663
1664inserted:
1712 /* reset the light list and los of the players on the map */ 1665 /* reset the light list and los of the players on the map */
1713 if (op->glow_radius && map) 1666 if (op->glow_radius && is_on_map ())
1714 { 1667 {
1715#ifdef DEBUG_LIGHTS 1668 update_stats ();
1716 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1717#endif /* DEBUG_LIGHTS */
1718 if (map->darkness)
1719 update_all_los (map, x, y); 1669 update_all_los (map, x, y);
1720 }
1721
1722 /* Client has no idea of ordering so lets not bother ordering it here.
1723 * It sure simplifies this function...
1724 */
1725 if (!inv)
1726 inv = op;
1727 else
1728 { 1670 }
1729 op->below = inv; 1671 else if (is_player () && !flag [FLAG_NO_FIX_PLAYER])
1730 op->below->above = op; 1672 // if this is a player's inventory, update stats
1731 inv = op; 1673 update_stats ();
1732 }
1733 1674
1734 INVOKE_OBJECT (INSERT, this); 1675 INVOKE_OBJECT (INSERT, this);
1735 1676
1736 return op; 1677 return op;
1737} 1678}
1820 { 1761 {
1821 1762
1822 float 1763 float
1823 diff = tmp->move_slow_penalty * fabs (op->speed); 1764 diff = tmp->move_slow_penalty * fabs (op->speed);
1824 1765
1825 if (op->type == PLAYER) 1766 if (op->is_player ())
1826 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) || 1767 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) ||
1827 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN))) 1768 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN)))
1828 diff /= 4.0; 1769 diff /= 4.0;
1829 1770
1830 op->speed_left -= diff; 1771 op->speed_left -= diff;
1865 LOG (llevError, "Present_arch called outside map.\n"); 1806 LOG (llevError, "Present_arch called outside map.\n");
1866 return NULL; 1807 return NULL;
1867 } 1808 }
1868 1809
1869 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above) 1810 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1870 if (tmp->arch == at) 1811 if (tmp->arch->archname == at->archname)
1871 return tmp; 1812 return tmp;
1872 1813
1873 return NULL; 1814 return NULL;
1874} 1815}
1875 1816
1939 * The first matching object is returned, or NULL if none. 1880 * The first matching object is returned, or NULL if none.
1940 */ 1881 */
1941object * 1882object *
1942present_arch_in_ob (const archetype *at, const object *op) 1883present_arch_in_ob (const archetype *at, const object *op)
1943{ 1884{
1944 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below) 1885 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1945 if (tmp->arch == at) 1886 if (tmp->arch->archname == at->archname)
1946 return tmp; 1887 return tmp;
1947 1888
1948 return NULL; 1889 return NULL;
1949} 1890}
1950 1891
1952 * activate recursively a flag on an object inventory 1893 * activate recursively a flag on an object inventory
1953 */ 1894 */
1954void 1895void
1955flag_inv (object *op, int flag) 1896flag_inv (object *op, int flag)
1956{ 1897{
1957 if (op->inv)
1958 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below) 1898 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1959 { 1899 {
1960 SET_FLAG (tmp, flag); 1900 SET_FLAG (tmp, flag);
1961 flag_inv (tmp, flag); 1901 flag_inv (tmp, flag);
1962 } 1902 }
1963} 1903}
1964 1904
1965/* 1905/*
1966 * deactivate recursively a flag on an object inventory 1906 * deactivate recursively a flag on an object inventory
1967 */ 1907 */
1968void 1908void
1969unflag_inv (object *op, int flag) 1909unflag_inv (object *op, int flag)
1970{ 1910{
1971 if (op->inv)
1972 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below) 1911 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1973 { 1912 {
1974 CLEAR_FLAG (tmp, flag); 1913 CLEAR_FLAG (tmp, flag);
1975 unflag_inv (tmp, flag); 1914 unflag_inv (tmp, flag);
1976 } 1915 }
1977} 1916}
1978 1917
1979/* 1918/*
1980 * find_free_spot(object, map, x, y, start, stop) will search for 1919 * find_free_spot(object, map, x, y, start, stop) will search for
1981 * a spot at the given map and coordinates which will be able to contain 1920 * a spot at the given map and coordinates which will be able to contain
1983 * to search (see the freearr_x/y[] definition). 1922 * to search (see the freearr_x/y[] definition).
1984 * It returns a random choice among the alternatives found. 1923 * It returns a random choice among the alternatives found.
1985 * start and stop are where to start relative to the free_arr array (1,9 1924 * start and stop are where to start relative to the free_arr array (1,9
1986 * does all 4 immediate directions). This returns the index into the 1925 * does all 4 immediate directions). This returns the index into the
1987 * array of the free spot, -1 if no spot available (dir 0 = x,y) 1926 * array of the free spot, -1 if no spot available (dir 0 = x,y)
1988 * Note - this only checks to see if there is space for the head of the
1989 * object - if it is a multispace object, this should be called for all
1990 * pieces.
1991 * Note2: This function does correctly handle tiled maps, but does not 1927 * Note: This function does correctly handle tiled maps, but does not
1992 * inform the caller. However, insert_ob_in_map will update as 1928 * inform the caller. However, insert_ob_in_map will update as
1993 * necessary, so the caller shouldn't need to do any special work. 1929 * necessary, so the caller shouldn't need to do any special work.
1994 * Note - updated to take an object instead of archetype - this is necessary 1930 * Note - updated to take an object instead of archetype - this is necessary
1995 * because arch_blocked (now ob_blocked) needs to know the movement type 1931 * because arch_blocked (now ob_blocked) needs to know the movement type
1996 * to know if the space in question will block the object. We can't use 1932 * to know if the space in question will block the object. We can't use
2017 1953
2018 /* However, often 1954 /* However, often
2019 * ob doesn't have any move type (when used to place exits) 1955 * ob doesn't have any move type (when used to place exits)
2020 * so the AND operation in OB_TYPE_MOVE_BLOCK doesn't work. 1956 * so the AND operation in OB_TYPE_MOVE_BLOCK doesn't work.
2021 */ 1957 */
2022 if (ob->move_type == 0 && ms.move_block != MOVE_ALL) 1958 if (ob && ob->move_type == 0 && ms.move_block != MOVE_ALL)
2023 { 1959 {
2024 altern [index++] = i; 1960 altern [index++] = i;
2025 continue; 1961 continue;
2026 } 1962 }
2027 1963
2043 * head of the object should correspond for the entire object. 1979 * head of the object should correspond for the entire object.
2044 */ 1980 */
2045 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block)) 1981 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))
2046 continue; 1982 continue;
2047 1983
1984 if (ob->blocked (pos.m, pos.x, pos.y))
1985 continue;
1986
2048 altern [index++] = i; 1987 altern [index++] = i;
2049 } 1988 }
2050 1989
2051 if (!index) 1990 if (!index)
2052 return -1; 1991 return -1;
2118 * there is capable of. 2057 * there is capable of.
2119 */ 2058 */
2120int 2059int
2121find_dir (maptile *m, int x, int y, object *exclude) 2060find_dir (maptile *m, int x, int y, object *exclude)
2122{ 2061{
2123 int i, max = SIZEOFFREE, mflags; 2062 int max = SIZEOFFREE, mflags;
2124
2125 sint16 nx, ny;
2126 object *tmp;
2127 maptile *mp;
2128
2129 MoveType blocked, move_type; 2063 MoveType move_type;
2130 2064
2131 if (exclude && exclude->head_ () != exclude) 2065 if (exclude && exclude->head_ () != exclude)
2132 { 2066 {
2133 exclude = exclude->head; 2067 exclude = exclude->head;
2134 move_type = exclude->move_type; 2068 move_type = exclude->move_type;
2137 { 2071 {
2138 /* If we don't have anything, presume it can use all movement types. */ 2072 /* If we don't have anything, presume it can use all movement types. */
2139 move_type = MOVE_ALL; 2073 move_type = MOVE_ALL;
2140 } 2074 }
2141 2075
2142 for (i = 1; i < max; i++) 2076 for (int i = 1; i < max; i++)
2143 { 2077 {
2144 mp = m; 2078 mapxy pos (m, x, y);
2145 nx = x + freearr_x[i]; 2079 pos.move (i);
2146 ny = y + freearr_y[i];
2147 2080
2148 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2081 if (!pos.normalise ())
2149
2150 if (mflags & P_OUT_OF_MAP)
2151 max = maxfree[i]; 2082 max = maxfree[i];
2152 else 2083 else
2153 { 2084 {
2154 mapspace &ms = mp->at (nx, ny); 2085 mapspace &ms = *pos;
2155 2086
2156 blocked = ms.move_block;
2157
2158 if ((move_type & blocked) == move_type) 2087 if ((move_type & ms.move_block) == move_type)
2159 max = maxfree[i]; 2088 max = maxfree [i];
2160 else if (mflags & P_IS_ALIVE) 2089 else if (ms.flags () & P_IS_ALIVE)
2161 { 2090 {
2162 for (tmp = ms.bot; tmp; tmp = tmp->above) 2091 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
2163 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER) 2092 if ((tmp->flag [FLAG_MONSTER] || tmp->is_player ())
2164 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude))) 2093 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))
2165 break;
2166
2167 if (tmp)
2168 return freedir[i]; 2094 return freedir [i];
2169 } 2095 }
2170 } 2096 }
2171 } 2097 }
2172 2098
2173 return 0; 2099 return 0;
2248 * This basically means that if direction is 15, then it could either go 2174 * This basically means that if direction is 15, then it could either go
2249 * direction 4, 14, or 16 to get back to where we are. 2175 * direction 4, 14, or 16 to get back to where we are.
2250 * Moved from spell_util.c to object.c with the other related direction 2176 * Moved from spell_util.c to object.c with the other related direction
2251 * functions. 2177 * functions.
2252 */ 2178 */
2253int reduction_dir[SIZEOFFREE][3] = { 2179const int reduction_dir[SIZEOFFREE][3] = {
2254 {0, 0, 0}, /* 0 */ 2180 {0, 0, 0}, /* 0 */
2255 {0, 0, 0}, /* 1 */ 2181 {0, 0, 0}, /* 1 */
2256 {0, 0, 0}, /* 2 */ 2182 {0, 0, 0}, /* 2 */
2257 {0, 0, 0}, /* 3 */ 2183 {0, 0, 0}, /* 3 */
2258 {0, 0, 0}, /* 4 */ 2184 {0, 0, 0}, /* 4 */
2354int 2280int
2355can_pick (const object *who, const object *item) 2281can_pick (const object *who, const object *item)
2356{ 2282{
2357 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2283 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2358 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2284 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2359 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2285 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->is_player () || item->weight < who->weight / 3));
2360} 2286}
2361 2287
2362/* 2288/*
2363 * create clone from object to another 2289 * create clone from object to another
2364 */ 2290 */
2365object * 2291object *
2366object_create_clone (object *asrc) 2292object::deep_clone ()
2367{ 2293{
2368 object *dst = 0, *tmp, *src, *prev, *item; 2294 assert (("deep_clone called on non-head object", is_head ()));
2369 2295
2370 if (!asrc) 2296 object *dst = clone ();
2371 return 0;
2372 2297
2373 src = asrc->head_ (); 2298 object *prev = dst;
2374
2375 prev = 0;
2376 for (object *part = src; part; part = part->more) 2299 for (object *part = this->more; part; part = part->more)
2377 { 2300 {
2378 tmp = part->clone (); 2301 object *tmp = part->clone ();
2379 tmp->x -= src->x;
2380 tmp->y -= src->y;
2381
2382 if (!part->head)
2383 {
2384 dst = tmp;
2385 tmp->head = 0;
2386 }
2387 else
2388 tmp->head = dst; 2302 tmp->head = dst;
2389
2390 tmp->more = 0;
2391
2392 if (prev)
2393 prev->more = tmp; 2303 prev->more = tmp;
2394
2395 prev = tmp; 2304 prev = tmp;
2396 } 2305 }
2397 2306
2398 for (item = src->inv; item; item = item->below) 2307 for (object *item = inv; item; item = item->below)
2399 insert_ob_in_ob (object_create_clone (item), dst); 2308 insert_ob_in_ob (item->deep_clone (), dst);
2400 2309
2401 return dst; 2310 return dst;
2402} 2311}
2403 2312
2404/* This returns the first object in who's inventory that 2313/* This returns the first object in who's inventory that
2413 return tmp; 2322 return tmp;
2414 2323
2415 return 0; 2324 return 0;
2416} 2325}
2417 2326
2418/* If ob has a field named key, return the link from the list, 2327shstr_tmp
2419 * otherwise return NULL. 2328object::kv_get (shstr_tmp key) const
2420 *
2421 * key must be a passed in shared string - otherwise, this won't
2422 * do the desired thing.
2423 */
2424key_value *
2425get_ob_key_link (const object *ob, const char *key)
2426{ 2329{
2427 for (key_value *link = ob->key_values; link; link = link->next) 2330 for (key_value *kv = key_values; kv; kv = kv->next)
2428 if (link->key == key) 2331 if (kv->key == key)
2429 return link;
2430
2431 return 0;
2432}
2433
2434/*
2435 * Returns the value of op has an extra_field for key, or NULL.
2436 *
2437 * The argument doesn't need to be a shared string.
2438 *
2439 * The returned string is shared.
2440 */
2441const char *
2442get_ob_key_value (const object *op, const char *const key)
2443{
2444 key_value *link;
2445 shstr_cmp canonical_key (key);
2446
2447 if (!canonical_key)
2448 {
2449 /* 1. There being a field named key on any object
2450 * implies there'd be a shared string to find.
2451 * 2. Since there isn't, no object has this field.
2452 * 3. Therefore, *this* object doesn't have this field.
2453 */
2454 return 0;
2455 }
2456
2457 /* This is copied from get_ob_key_link() above -
2458 * only 4 lines, and saves the function call overhead.
2459 */
2460 for (link = op->key_values; link; link = link->next)
2461 if (link->key == canonical_key)
2462 return link->value; 2332 return kv->value;
2463 2333
2464 return 0; 2334 return shstr ();
2465} 2335}
2466 2336
2467/* 2337void
2468 * Updates the canonical_key in op to value. 2338object::kv_set (shstr_tmp key, shstr_tmp value)
2469 *
2470 * canonical_key is a shared string (value doesn't have to be).
2471 *
2472 * Unless add_key is TRUE, it won't add fields, only change the value of existing
2473 * keys.
2474 *
2475 * Returns TRUE on success.
2476 */
2477int
2478set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2479{ 2339{
2480 key_value *field = NULL, *last = NULL; 2340 for (key_value *kv = key_values; kv; kv = kv->next)
2481 2341 if (kv->key == key)
2482 for (field = op->key_values; field != NULL; field = field->next)
2483 {
2484 if (field->key != canonical_key)
2485 { 2342 {
2486 last = field; 2343 kv->value = value;
2487 continue; 2344 return;
2488 } 2345 }
2489 2346
2490 if (value) 2347 key_value *kv = new key_value;
2491 field->value = value; 2348
2492 else 2349 kv->next = key_values;
2350 kv->key = key;
2351 kv->value = value;
2352
2353 key_values = kv;
2354}
2355
2356void
2357object::kv_del (shstr_tmp key)
2358{
2359 for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
2360 if ((*kvp)->key == key)
2493 { 2361 {
2494 /* Basically, if the archetype has this key set, 2362 key_value *kv = *kvp;
2495 * we need to store the null value so when we save 2363 *kvp = (*kvp)->next;
2496 * it, we save the empty value so that when we load, 2364 delete kv;
2497 * we get this value back again. 2365 return;
2498 */
2499 if (get_ob_key_link (op->arch, canonical_key))
2500 field->value = 0;
2501 else
2502 {
2503 if (last)
2504 last->next = field->next;
2505 else
2506 op->key_values = field->next;
2507
2508 delete field;
2509 }
2510 } 2366 }
2511 return TRUE;
2512 }
2513 /* IF we get here, key doesn't exist */
2514
2515 /* No field, we'll have to add it. */
2516
2517 if (!add_key)
2518 return FALSE;
2519
2520 /* There isn't any good reason to store a null
2521 * value in the key/value list. If the archetype has
2522 * this key, then we should also have it, so shouldn't
2523 * be here. If user wants to store empty strings,
2524 * should pass in ""
2525 */
2526 if (value == NULL)
2527 return TRUE;
2528
2529 field = new key_value;
2530
2531 field->key = canonical_key;
2532 field->value = value;
2533 /* Usual prepend-addition. */
2534 field->next = op->key_values;
2535 op->key_values = field;
2536
2537 return TRUE;
2538}
2539
2540/*
2541 * Updates the key in op to value.
2542 *
2543 * If add_key is FALSE, this will only update existing keys,
2544 * and not add new ones.
2545 * In general, should be little reason FALSE is ever passed in for add_key
2546 *
2547 * Returns TRUE on success.
2548 */
2549int
2550set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2551{
2552 shstr key_ (key);
2553
2554 return set_ob_key_value_s (op, key_, value, add_key);
2555} 2367}
2556 2368
2557object::depth_iterator::depth_iterator (object *container) 2369object::depth_iterator::depth_iterator (object *container)
2558: iterator_base (container) 2370: iterator_base (container)
2559{ 2371{
2609{ 2421{
2610 char flagdesc[512]; 2422 char flagdesc[512];
2611 char info2[256 * 4]; 2423 char info2[256 * 4];
2612 char *p = info; 2424 char *p = info;
2613 2425
2614 p += snprintf (p, 512, "{cnt:%d,uuid:<1.%" PRIx64 ">,name:\"%s\"%s%s,flags:[%s],type:%d}", 2426 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2615 count, uuid.seq, 2427 count,
2428 uuid.c_str (),
2616 &name, 2429 &name,
2617 title ? "\",title:\"" : "", 2430 title ? ",title:\"" : "",
2618 title ? (const char *)title : "", 2431 title ? (const char *)title : "",
2432 title ? "\"" : "",
2619 flag_desc (flagdesc, 512), type); 2433 flag_desc (flagdesc, 512), type);
2620 2434
2621 if (!this->flag[FLAG_REMOVED] && env) 2435 if (!flag[FLAG_REMOVED] && env)
2622 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2436 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2623 2437
2624 if (map) 2438 if (map)
2625 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y); 2439 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2626 2440
2656object::open_container (object *new_container) 2470object::open_container (object *new_container)
2657{ 2471{
2658 if (container == new_container) 2472 if (container == new_container)
2659 return; 2473 return;
2660 2474
2661 if (object *old_container = container) 2475 object *old_container = container;
2476
2477 if (old_container)
2662 { 2478 {
2663 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this))) 2479 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))
2664 return; 2480 return;
2665 2481
2666#if 0 2482#if 0
2668 if (object *closer = old_container->inv) 2484 if (object *closer = old_container->inv)
2669 if (closer->type == CLOSE_CON) 2485 if (closer->type == CLOSE_CON)
2670 closer->destroy (); 2486 closer->destroy ();
2671#endif 2487#endif
2672 2488
2489 // make sure the container is available
2490 esrv_send_item (this, old_container);
2491
2673 old_container->flag [FLAG_APPLIED] = 0; 2492 old_container->flag [FLAG_APPLIED] = false;
2674 container = 0; 2493 container = 0;
2675 2494
2495 // client needs item update to make it work, client bug requires this to be separate
2676 esrv_update_item (UPD_FLAGS, this, old_container); 2496 esrv_update_item (UPD_FLAGS, this, old_container);
2497
2677 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container)); 2498 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container));
2678 play_sound (sound_find ("chest_close")); 2499 play_sound (sound_find ("chest_close"));
2679 } 2500 }
2680 2501
2681 if (new_container) 2502 if (new_container)
2694 } 2515 }
2695#endif 2516#endif
2696 2517
2697 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container)); 2518 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container));
2698 2519
2520 // make sure the container is available, client bug requires this to be separate
2521 esrv_send_item (this, new_container);
2522
2699 new_container->flag [FLAG_APPLIED] = 1; 2523 new_container->flag [FLAG_APPLIED] = true;
2700 container = new_container; 2524 container = new_container;
2701 2525
2526 // client needs flag change
2702 esrv_update_item (UPD_FLAGS, this, new_container); 2527 esrv_update_item (UPD_FLAGS, this, new_container);
2703 esrv_send_inventory (this, new_container); 2528 esrv_send_inventory (this, new_container);
2704 play_sound (sound_find ("chest_open")); 2529 play_sound (sound_find ("chest_open"));
2705 } 2530 }
2531// else if (!old_container->env && contr && contr->ns)
2532// contr->ns->floorbox_reset ();
2706} 2533}
2707 2534
2708object * 2535object *
2709object::force_find (const shstr name) 2536object::force_find (shstr_tmp name)
2710{ 2537{
2711 /* cycle through his inventory to look for the MARK we want to 2538 /* cycle through his inventory to look for the MARK we want to
2712 * place 2539 * place
2713 */ 2540 */
2714 for (object *tmp = inv; tmp; tmp = tmp->below) 2541 for (object *tmp = inv; tmp; tmp = tmp->below)
2716 return splay (tmp); 2543 return splay (tmp);
2717 2544
2718 return 0; 2545 return 0;
2719} 2546}
2720 2547
2721void 2548object *
2722object::force_add (const shstr name, int duration) 2549object::force_add (shstr_tmp name, int duration)
2723{ 2550{
2724 if (object *force = force_find (name)) 2551 if (object *force = force_find (name))
2725 force->destroy (); 2552 force->destroy ();
2726 2553
2727 object *force = get_archetype (FORCE_NAME); 2554 object *force = get_archetype (FORCE_NAME);
2732 2559
2733 force->set_speed (duration ? 1.f / duration : 0.f); 2560 force->set_speed (duration ? 1.f / duration : 0.f);
2734 force->flag [FLAG_IS_USED_UP] = true; 2561 force->flag [FLAG_IS_USED_UP] = true;
2735 force->flag [FLAG_APPLIED] = true; 2562 force->flag [FLAG_APPLIED] = true;
2736 2563
2737 insert (force); 2564 return insert (force);
2738} 2565}
2739 2566
2740void 2567void
2741object::play_sound (faceidx sound) const 2568object::play_sound (faceidx sound)
2742{ 2569{
2743 if (!sound) 2570 if (!sound)
2744 return; 2571 return;
2745 2572
2746 if (flag [FLAG_REMOVED]) 2573 if (flag [FLAG_REMOVED])
2753 } 2580 }
2754 else 2581 else
2755 map->play_sound (sound, x, y); 2582 map->play_sound (sound, x, y);
2756} 2583}
2757 2584
2585void
2586object::make_noise ()
2587{
2588 // we do not model noise in the map, so instead put
2589 // a temporary light into the noise source
2590 // could use the map instead, but that's less reliable for our
2591 // goal, which is to make invisibility a bit harder to exploit
2592
2593 // currently only works sensibly for players
2594 if (!is_player ())
2595 return;
2596
2597 // find old force, or create new one
2598 object *force = force_find (shstr_noise_force);
2599
2600 if (force)
2601 force->speed_left = -1.f; // patch old speed up
2602 else
2603 {
2604 force = archetype::get (shstr_noise_force);
2605
2606 force->slaying = shstr_noise_force;
2607 force->stats.food = 1;
2608 force->speed_left = -1.f;
2609
2610 force->set_speed (1.f / 4.f);
2611 force->flag [FLAG_IS_USED_UP] = true;
2612 force->flag [FLAG_APPLIED] = true;
2613
2614 insert (force);
2615 }
2616}
2617

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines