ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.201 by root, Tue Jan 22 16:22:45 2008 UTC vs.
Revision 1.290 by sf-marcmagus, Sun Oct 11 05:43:35 2009 UTC

1/* 1/*
2 * This file is part of Deliantra, the Roguelike Realtime MMORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007 Marc Alexander Lehmann / Robin Redeker / the Deliantra team 4 * Copyright (©) 2005,2006,2007,2008,2009 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 * 7 *
8 * Deliantra is free software: you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify
9 * it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
19 * along with this program. If not, see <http://www.gnu.org/licenses/>. 19 * along with this program. If not, see <http://www.gnu.org/licenses/>.
20 * 20 *
21 * The authors can be reached via e-mail to <support@deliantra.net> 21 * The authors can be reached via e-mail to <support@deliantra.net>
22 */ 22 */
23 23
24/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
25 sub/add_weight will transcend the environment updating the carrying
26 variable. */
27#include <global.h> 24#include <global.h>
28#include <stdio.h> 25#include <stdio.h>
29#include <sys/types.h> 26#include <sys/types.h>
30#include <sys/uio.h> 27#include <sys/uio.h>
31#include <object.h> 28#include <object.h>
32#include <funcpoint.h>
33#include <sproto.h> 29#include <sproto.h>
34#include <loader.h> 30#include <loader.h>
35 31
36#include <bitset> 32#include <bitset>
37 33
38int nrofallocobjects = 0; 34UUID UUID::cur;
39static UUID uuid; 35static uint64_t seq_next_save;
40const uint64 UUID_SKIP = 1<<19; 36static const uint64 UUID_GAP = 1<<19;
37uint32_t mapspace::smellcount = 10000;
41 38
42objectvec objects; 39objectvec objects;
43activevec actives; 40activevec actives;
44 41
45short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 42short freearr_x[SIZEOFFREE] = {
43 0,
44 0, 1, 1, 1, 0, -1, -1, -1,
45 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
46 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1 46 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1
47}; 47};
48short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, 48short freearr_y[SIZEOFFREE] = {
49 0,
50 -1, -1, 0, 1, 1, 1, 0, -1,
51 -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
49 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3 52 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3
50}; 53};
51int maxfree[SIZEOFFREE] = { 0, 9, 10, 13, 14, 17, 18, 21, 22, 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 54int maxfree[SIZEOFFREE] = {
55 0,
56 9, 10, 13, 14, 17, 18, 21, 22,
57 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
52 48, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49 58 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
53}; 59};
54int freedir[SIZEOFFREE] = { 60int freedir[SIZEOFFREE] = {
55 0, 1, 2, 3, 4, 5, 6, 7, 8, 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8, 61 0,
62 1, 2, 3, 4, 5, 6, 7, 8,
63 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,
56 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8 64 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8
57}; 65};
58 66
59static void 67static void
60write_uuid (void) 68write_uuid (uval64 skip, bool sync)
61{ 69{
62 char filename1[MAX_BUF], filename2[MAX_BUF]; 70 CALL_BEGIN (2);
63 71 CALL_ARG_SV (newSVval64 (skip));
64 sprintf (filename1, "%s/uuid", settings.localdir); 72 CALL_ARG_SV (boolSV (sync));
65 sprintf (filename2, "%s/uuid~", settings.localdir); 73 CALL_CALL ("cf::write_uuid", G_DISCARD);
66 74 CALL_END;
67 FILE *fp;
68
69 if (!(fp = fopen (filename2, "w")))
70 {
71 LOG (llevError, "ERROR: cannot open %s for writing, unable to write UUID!\n", filename2);
72 return;
73 }
74
75 fprintf (fp, "<1,%llx>\n", (unsigned long long)uuid.seq + UUID_SKIP * 2);
76 fclose (fp);
77 rename (filename2, filename1);
78} 75}
79 76
80static void 77static void
81read_uuid (void) 78read_uuid (void)
82{ 79{
83 char filename[MAX_BUF]; 80 char filename[MAX_BUF];
84 81
85 sprintf (filename, "%s/uuid", settings.localdir); 82 sprintf (filename, "%s/uuid", settings.localdir);
83
84 seq_next_save = 0;
86 85
87 FILE *fp; 86 FILE *fp;
88 87
89 if (!(fp = fopen (filename, "r"))) 88 if (!(fp = fopen (filename, "r")))
90 { 89 {
91 if (errno == ENOENT) 90 if (errno == ENOENT)
92 { 91 {
93 LOG (llevInfo, "RESET uid to 1\n"); 92 LOG (llevInfo, "RESET uid to 1\n");
94 uuid.seq = 0; 93 UUID::cur.seq = 0;
95 write_uuid (); 94 write_uuid (UUID_GAP, true);
96 return; 95 return;
97 } 96 }
98 97
99 LOG (llevError, "FATAL: cannot open %s for reading!\n", filename); 98 LOG (llevError, "FATAL: cannot open %s for reading!\n", filename);
100 _exit (1); 99 _exit (1);
101 } 100 }
102 101
103 int version; 102 UUID::BUF buf;
104 unsigned long long uid; 103 buf[0] = 0;
105 if (2 != fscanf (fp, "<%d,%llx>\n", &version, &uid) || version != 1) 104 fgets (buf, sizeof (buf), fp);
105
106 if (!UUID::cur.parse (buf))
106 { 107 {
107 LOG (llevError, "FATAL: error reading uid from %s!\n", filename); 108 LOG (llevError, "FATAL: error reading uid from %s (%s)!\n", filename, buf);
108 _exit (1); 109 _exit (1);
109 } 110 }
110 111
111 uuid.seq = uid; 112 LOG (llevDebug, "read UUID: %s\n", UUID::cur.c_str ());
112 write_uuid (); 113
113 LOG (llevDebug, "read UID: %" PRId64 "\n", uid); 114 write_uuid (UUID_GAP, true);
114 fclose (fp); 115 fclose (fp);
115} 116}
116 117
117UUID 118UUID
118gen_uuid () 119UUID::gen ()
119{ 120{
120 UUID uid; 121 UUID uid;
121 122
122 uid.seq = ++uuid.seq; 123 uid.seq = ++cur.seq;
123 124
124 if (!(uuid.seq & (UUID_SKIP - 1))) 125 if (expect_false (cur.seq >= seq_next_save))
125 write_uuid (); 126 {
127 seq_next_save = UUID::cur.seq + (UUID_GAP >> 1);
128 write_uuid (UUID_GAP, false);
129 }
130
126 131
127 return uid; 132 return uid;
128} 133}
129 134
130void 135void
131init_uuid () 136UUID::init ()
132{ 137{
133 read_uuid (); 138 read_uuid ();
134} 139}
135 140
136/* Returns TRUE if every key_values in wants has a partner with the same value in has. */ 141/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
137static int 142static bool
138compare_ob_value_lists_one (const object *wants, const object *has) 143compare_ob_value_lists_one (const object *wants, const object *has)
139{ 144{
140 key_value *wants_field;
141
142 /* n-squared behaviour (see get_ob_key_link()), but I'm hoping both 145 /* n-squared behaviour (see kv_get), but I'm hoping both
143 * objects with lists are rare, and lists stay short. If not, use a 146 * objects with lists are rare, and lists stay short. If not, use a
144 * different structure or at least keep the lists sorted... 147 * different structure or at least keep the lists sorted...
145 */ 148 */
146 149
147 /* For each field in wants, */ 150 /* For each field in wants, */
148 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next) 151 for (key_value *kv = wants->key_values; kv; kv = kv->next)
149 { 152 if (has->kv_get (kv->key) != kv->value)
150 key_value *has_field; 153 return false;
151
152 /* Look for a field in has with the same key. */
153 has_field = get_ob_key_link (has, wants_field->key);
154
155 if (has_field == NULL)
156 {
157 /* No field with that name. */
158 return FALSE;
159 }
160
161 /* Found the matching field. */
162 if (has_field->value != wants_field->value)
163 {
164 /* Values don't match, so this half of the comparison is false. */
165 return FALSE;
166 }
167
168 /* If we get here, we found a match. Now for the next field in wants. */
169 }
170 154
171 /* If we get here, every field in wants has a matching field in has. */ 155 /* If we get here, every field in wants has a matching field in has. */
172 return TRUE; 156 return true;
173} 157}
174 158
175/* Returns TRUE if ob1 has the same key_values as ob2. */ 159/* Returns TRUE if ob1 has the same key_values as ob2. */
176static int 160static bool
177compare_ob_value_lists (const object *ob1, const object *ob2) 161compare_ob_value_lists (const object *ob1, const object *ob2)
178{ 162{
179 /* However, there may be fields in has which aren't partnered in wants, 163 /* However, there may be fields in has which aren't partnered in wants,
180 * so we need to run the comparison *twice*. :( 164 * so we need to run the comparison *twice*. :(
181 */ 165 */
182 return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1); 166 return compare_ob_value_lists_one (ob1, ob2)
167 && compare_ob_value_lists_one (ob2, ob1);
183} 168}
184 169
185/* Function examines the 2 objects given to it, and returns true if 170/* Function examines the 2 objects given to it, and returns true if
186 * they can be merged together. 171 * they can be merged together.
187 * 172 *
202 || ob1->speed != ob2->speed 187 || ob1->speed != ob2->speed
203 || ob1->value != ob2->value 188 || ob1->value != ob2->value
204 || ob1->name != ob2->name) 189 || ob1->name != ob2->name)
205 return 0; 190 return 0;
206 191
207 //TODO: this ain't working well, use nicer and correct overflow check
208 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that 192 /* Do not merge objects if nrof would overflow, assume nrof
209 * value could not be stored in a sint32 (which unfortunately sometimes is 193 * is always 0 .. 2**31-1 */
210 * used to store nrof). 194 if (ob1->nrof > 0x7fffffff - ob2->nrof)
211 */
212 if (ob1->nrof + ob2->nrof >= 1UL << 31)
213 return 0; 195 return 0;
214 196
215 /* If the objects have been identified, set the BEEN_APPLIED flag. 197 /* If the objects have been identified, set the BEEN_APPLIED flag.
216 * This is to the comparison of the flags below will be OK. We 198 * This is to the comparison of the flags below will be OK. We
217 * just can't ignore the been applied or identified flags, as they 199 * just can't ignore the been applied or identified flags, as they
218 * are not equal - just if it has been identified, the been_applied 200 * are not equal - just if it has been identified, the been_applied
219 * flags lose any meaning. 201 * flags lose any meaning.
220 */ 202 */
221 if (QUERY_FLAG (ob1, FLAG_IDENTIFIED)) 203 if (QUERY_FLAG (ob1, FLAG_IDENTIFIED))
222 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 204 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
223 205
224 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 206 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
225 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 207 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
226 208
227 if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any () 209 if (ob1->arch->archname != ob2->arch->archname
228 || ob1->arch != ob2->arch
229 || ob1->name != ob2->name 210 || ob1->name != ob2->name
230 || ob1->title != ob2->title 211 || ob1->title != ob2->title
231 || ob1->msg != ob2->msg 212 || ob1->msg != ob2->msg
232 || ob1->weight != ob2->weight 213 || ob1->weight != ob2->weight
233 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
234 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
235 || ob1->attacktype != ob2->attacktype 214 || ob1->attacktype != ob2->attacktype
236 || ob1->magic != ob2->magic 215 || ob1->magic != ob2->magic
237 || ob1->slaying != ob2->slaying 216 || ob1->slaying != ob2->slaying
238 || ob1->skill != ob2->skill 217 || ob1->skill != ob2->skill
239 || ob1->value != ob2->value 218 || ob1->value != ob2->value
240 || ob1->animation_id != ob2->animation_id 219 || ob1->animation_id != ob2->animation_id
220 || (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependent on each other
241 || ob1->client_type != ob2->client_type 221 || ob1->client_type != ob2->client_type
242 || ob1->materialname != ob2->materialname 222 || ob1->materialname != ob2->materialname
243 || ob1->lore != ob2->lore 223 || ob1->lore != ob2->lore
244 || ob1->subtype != ob2->subtype 224 || ob1->subtype != ob2->subtype
245 || ob1->move_type != ob2->move_type 225 || ob1->move_type != ob2->move_type
246 || ob1->move_block != ob2->move_block 226 || ob1->move_block != ob2->move_block
247 || ob1->move_allow != ob2->move_allow 227 || ob1->move_allow != ob2->move_allow
248 || ob1->move_on != ob2->move_on 228 || ob1->move_on != ob2->move_on
249 || ob1->move_off != ob2->move_off 229 || ob1->move_off != ob2->move_off
250 || ob1->move_slow != ob2->move_slow 230 || ob1->move_slow != ob2->move_slow
251 || ob1->move_slow_penalty != ob2->move_slow_penalty) 231 || ob1->move_slow_penalty != ob2->move_slow_penalty
232 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
233 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
252 return 0; 234 return 0;
253 235
236 if ((ob1->flag ^ ob2->flag)
237 .reset (FLAG_INV_LOCKED)
238 .reset (FLAG_REMOVED)
239 .any ())
240 return 0;
241
254 /* This is really a spellbook check - really, we should 242 /* This is really a spellbook check - we should in general
255 * check all objects in the inventory. 243 * not merge objects with real inventories, as splitting them
244 * is hard.
256 */ 245 */
257 if (ob1->inv || ob2->inv) 246 if (ob1->inv || ob2->inv)
258 { 247 {
259 if (!(ob1->inv && ob2->inv)) 248 if (!(ob1->inv && ob2->inv))
260 return 0; /* inventories differ in length */ 249 return 0; /* inventories differ in length */
261 250
262 if (ob1->inv->below || ob2->inv->below) 251 if (ob1->inv->below || ob2->inv->below)
263 return 0; /* more than one object in inv */ 252 return 0; /* more than one object in inv */
264 253
265 if (!object::can_merge (ob1->inv, ob2->inv)) 254 if (!object::can_merge (ob1->inv, ob2->inv))
266 return 0; /* inventory objexts differ */ 255 return 0; /* inventory objects differ */
267 256
268 /* inventory ok - still need to check rest of this object to see 257 /* inventory ok - still need to check rest of this object to see
269 * if it is valid. 258 * if it is valid.
270 */ 259 */
271 } 260 }
290 if (ob1->level != ob2->level) 279 if (ob1->level != ob2->level)
291 return 0; 280 return 0;
292 break; 281 break;
293 } 282 }
294 283
295 if (ob1->key_values != NULL || ob2->key_values != NULL) 284 if (ob1->key_values || ob2->key_values)
296 { 285 {
297 /* At least one of these has key_values. */ 286 /* At least one of these has key_values. */
298 if ((ob1->key_values == NULL) != (ob2->key_values == NULL)) 287 if ((!ob1->key_values) != (!ob2->key_values))
299 /* One has fields, but the other one doesn't. */ 288 return 0; /* One has fields, but the other one doesn't. */
300 return 0; 289
301 else if (!compare_ob_value_lists (ob1, ob2)) 290 if (!compare_ob_value_lists (ob1, ob2))
302 return 0; 291 return 0;
303 } 292 }
304 293
305 if (ob1->self || ob2->self) 294 if (ob1->self || ob2->self)
306 { 295 {
312 int k1 = ob1->self ? HvTOTALKEYS (ob1->self) : 0; 301 int k1 = ob1->self ? HvTOTALKEYS (ob1->self) : 0;
313 int k2 = ob2->self ? HvTOTALKEYS (ob2->self) : 0; 302 int k2 = ob2->self ? HvTOTALKEYS (ob2->self) : 0;
314 303
315 if (k1 != k2) 304 if (k1 != k2)
316 return 0; 305 return 0;
306
317 else if (k1 == 0) 307 if (k1 == 0)
318 return 1; 308 return 1;
309
319 else if (!cfperl_can_merge (ob1, ob2)) 310 if (!cfperl_can_merge (ob1, ob2))
320 return 0; 311 return 0;
321 } 312 }
322 } 313 }
323 314
324 /* Everything passes, must be OK. */ 315 /* Everything passes, must be OK. */
325 return 1; 316 return 1;
326} 317}
327 318
319// find player who can see this object
320object *
321object::visible_to () const
322{
323 if (client_visible () && !flag [FLAG_REMOVED])
324 {
325 // see if we are in a container of sorts
326 if (env)
327 {
328 // the player inventory itself is always visible
329 if (env->is_player ())
330 return env;
331
332 // else a player could have our env open
333 object *envest = env->outer_env_or_self ();
334
335 // the player itself is always on a map, so we will find him here
336 // even if our inv is in a player.
337 if (envest->is_on_map ())
338 if (object *pl = envest->ms ().player ())
339 if (pl->container == env)
340 return pl;
341 }
342 else
343 {
344 // maybe there is a player standing on the same mapspace
345 // this will catch the case where "this" is a player
346 if (object *pl = ms ().player ())
347 if ((!pl->container && pl->contr->ns && !pl->contr->ns->update_look)
348 || this == pl->container)
349 return pl;
350 }
351 }
352
353 return 0;
354}
355
356// adjust weight per container type ("of holding")
357static sint32
358weight_adjust_for (object *op, sint32 weight)
359{
360 return op->type == CONTAINER
361 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str)
362 : weight;
363}
364
328/* 365/*
366 * adjust_weight(object, weight) adds the specified weight to an object,
367 * and also updates how much the environment(s) is/are carrying.
368 */
369static void
370adjust_weight (object *op, sint32 weight)
371{
372 while (op)
373 {
374 // adjust by actual difference to account for rounding errors
375 // i.e. (w2 - w1) / f != w2 / f - w1 / f and the latter is correct
376 weight = weight_adjust_for (op, op->carrying)
377 - weight_adjust_for (op, op->carrying - weight);
378
379 if (!weight)
380 return;
381
382 op->carrying += weight;
383
384 if (object *pl = op->visible_to ())
385 if (pl != op) // player is handled lazily
386 esrv_update_item (UPD_WEIGHT, pl, op);
387
388 op = op->env;
389 }
390}
391
392/*
329 * sum_weight() is a recursive function which calculates the weight 393 * this is a recursive function which calculates the weight
330 * an object is carrying. It goes through in figures out how much 394 * an object is carrying. It goes through op and figures out how much
331 * containers are carrying, and sums it up. 395 * containers are carrying, and sums it up.
332 */ 396 */
333long 397void
334sum_weight (object *op) 398object::update_weight ()
335{ 399{
336 long sum; 400 sint32 sum = 0;
337 object *inv;
338 401
339 for (sum = 0, inv = op->inv; inv; inv = inv->below) 402 for (object *op = inv; op; op = op->below)
340 { 403 {
341 if (inv->inv) 404 if (op->inv)
342 sum_weight (inv); 405 op->update_weight ();
343 406
344 sum += inv->carrying + inv->weight * (inv->nrof ? inv->nrof : 1); 407 sum += op->total_weight ();
408 }
409
410 sum = weight_adjust_for (this, sum);
411
412 if (sum != carrying)
345 } 413 {
346
347 if (op->type == CONTAINER && op->stats.Str)
348 sum = (sum * (100 - op->stats.Str)) / 100;
349
350 if (op->carrying != sum)
351 op->carrying = sum; 414 carrying = sum;
352 415
353 return sum; 416 if (object *pl = visible_to ())
417 if (pl != this) // player is handled lazily
418 esrv_update_item (UPD_WEIGHT, pl, this);
419 }
354} 420}
355 421
356/** 422/*
357 * Return the outermost environment object for a given object. 423 * Used by: Server DM commands: dumpbelow, dump. Some error messages.
358 */
359
360object *
361object_get_env_recursive (object *op)
362{
363 while (op->env != NULL)
364 op = op->env;
365 return op;
366}
367
368/*
369 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
370 * Some error messages.
371 * The result of the dump is stored in the static global errmsg array.
372 */ 424 */
373char * 425char *
374dump_object (object *op) 426dump_object (object *op)
375{ 427{
376 if (!op) 428 if (!op)
379 object_freezer freezer; 431 object_freezer freezer;
380 op->write (freezer); 432 op->write (freezer);
381 return freezer.as_string (); 433 return freezer.as_string ();
382} 434}
383 435
436char *
437object::as_string ()
438{
439 return dump_object (this);
440}
441
384/* 442/*
385 * get_nearest_part(multi-object, object 2) returns the part of the 443 * get_nearest_part(multi-object, object 2) returns the part of the
386 * multi-object 1 which is closest to the second object. 444 * multi-object 1 which is closest to the second object.
387 * If it's not a multi-object, it is returned. 445 * If it's not a multi-object, it is returned.
388 */ 446 */
390get_nearest_part (object *op, const object *pl) 448get_nearest_part (object *op, const object *pl)
391{ 449{
392 object *tmp, *closest; 450 object *tmp, *closest;
393 int last_dist, i; 451 int last_dist, i;
394 452
395 if (op->more == NULL) 453 if (!op->more)
396 return op; 454 return op;
455
397 for (last_dist = distance (op, pl), closest = op, tmp = op->more; tmp != NULL; tmp = tmp->more) 456 for (last_dist = distance (op, pl), closest = op, tmp = op->more;
457 tmp;
458 tmp = tmp->more)
398 if ((i = distance (tmp, pl)) < last_dist) 459 if ((i = distance (tmp, pl)) < last_dist)
399 closest = tmp, last_dist = i; 460 closest = tmp, last_dist = i;
461
400 return closest; 462 return closest;
401} 463}
402 464
403/* 465/*
404 * Returns the object which has the count-variable equal to the argument. 466 * Returns the object which has the count-variable equal to the argument.
467 * VERRRY slow.
405 */ 468 */
406object * 469object *
407find_object (tag_t i) 470find_object (tag_t i)
408{ 471{
409 for_all_objects (op) 472 for_all_objects (op)
420 */ 483 */
421object * 484object *
422find_object_name (const char *str) 485find_object_name (const char *str)
423{ 486{
424 shstr_cmp str_ (str); 487 shstr_cmp str_ (str);
425 object *op;
426 488
489 if (str_)
427 for_all_objects (op) 490 for_all_objects (op)
428 if (op->name == str_) 491 if (op->name == str_)
429 break; 492 return op;
430 493
431 return op; 494 return 0;
432}
433
434void
435free_all_object_data ()
436{
437 LOG (llevDebug, "%d allocated objects\n", nrofallocobjects);
438} 495}
439 496
440/* 497/*
441 * Sets the owner and sets the skill and exp pointers to owner's current 498 * Sets the owner and sets the skill and exp pointers to owner's current
442 * skill and experience objects. 499 * skill and experience objects.
504 update_stats (); 561 update_stats ();
505 562
506 new_draw_info_format (NDI_UNIQUE, 0, this, 563 new_draw_info_format (NDI_UNIQUE, 0, this,
507 "You try to balance all your items at once, " 564 "You try to balance all your items at once, "
508 "but the %s is just too much for your body. " 565 "but the %s is just too much for your body. "
509 "[You need to unapply some items first.]", &ob->name); 566 "[You need to unapply some items first - use the 'body' command to see "
567 "how many items you cna wera on a specific body part.]", &ob->name);
510 return false; 568 return false;
511 } 569 }
512 570
513 //new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name); 571 //new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name);
514 } 572 }
540 } 598 }
541 599
542 op->key_values = 0; 600 op->key_values = 0;
543} 601}
544 602
545object & 603/*
546object::operator =(const object &src) 604 * copy_to first frees everything allocated by the dst object,
605 * and then copies the contents of itself into the second
606 * object, allocating what needs to be allocated. Basically, any
607 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
608 * if the first object is freed, the pointers in the new object
609 * will point at garbage.
610 */
611void
612object::copy_to (object *dst)
547{ 613{
548 bool is_freed = flag [FLAG_FREED]; 614 dst->remove ();
549 bool is_removed = flag [FLAG_REMOVED];
550
551 *(object_copy *)this = src; 615 *(object_copy *)dst = *this;
552
553 flag [FLAG_FREED] = is_freed;
554 flag [FLAG_REMOVED] = is_removed; 616 dst->flag [FLAG_REMOVED] = true;
555 617
556 /* Copy over key_values, if any. */ 618 /* Copy over key_values, if any. */
557 if (src.key_values) 619 if (key_values)
558 { 620 {
559 key_value *tail = 0; 621 key_value *tail = 0;
560 key_values = 0; 622 dst->key_values = 0;
561 623
562 for (key_value *i = src.key_values; i; i = i->next) 624 for (key_value *i = key_values; i; i = i->next)
563 { 625 {
564 key_value *new_link = new key_value; 626 key_value *new_link = new key_value;
565 627
566 new_link->next = 0; 628 new_link->next = 0;
567 new_link->key = i->key; 629 new_link->key = i->key;
568 new_link->value = i->value; 630 new_link->value = i->value;
569 631
570 /* Try and be clever here, too. */ 632 /* Try and be clever here, too. */
571 if (!key_values) 633 if (!dst->key_values)
572 { 634 {
573 key_values = new_link; 635 dst->key_values = new_link;
574 tail = new_link; 636 tail = new_link;
575 } 637 }
576 else 638 else
577 { 639 {
578 tail->next = new_link; 640 tail->next = new_link;
579 tail = new_link; 641 tail = new_link;
580 } 642 }
581 } 643 }
582 } 644 }
583}
584
585/*
586 * copy_to first frees everything allocated by the dst object,
587 * and then copies the contents of itself into the second
588 * object, allocating what needs to be allocated. Basically, any
589 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
590 * if the first object is freed, the pointers in the new object
591 * will point at garbage.
592 */
593void
594object::copy_to (object *dst)
595{
596 *dst = *this;
597 645
598 if (speed < 0) 646 if (speed < 0)
599 dst->speed_left -= rndm (); 647 dst->speed_left -= rndm ();
600 648
601 dst->set_speed (dst->speed); 649 dst->activate ();
602} 650}
603 651
604void 652void
605object::instantiate () 653object::instantiate ()
606{ 654{
607 if (!uuid.seq) // HACK 655 if (!uuid.seq) // HACK
608 uuid = gen_uuid (); 656 uuid = UUID::gen ();
609 657
610 speed_left = -0.1f; 658 speed_left = -0.1f;
611 /* copy the body_info to the body_used - this is only really 659 /* copy the body_info to the body_used - this is only really
612 * need for monsters, but doesn't hurt to do it for everything. 660 * need for monsters, but doesn't hurt to do it for everything.
613 * by doing so, when a monster is created, it has good starting 661 * by doing so, when a monster is created, it has good starting
623object * 671object *
624object::clone () 672object::clone ()
625{ 673{
626 object *neu = create (); 674 object *neu = create ();
627 copy_to (neu); 675 copy_to (neu);
676 neu->map = map; // not copied by copy_to
628 return neu; 677 return neu;
629} 678}
630 679
631/* 680/*
632 * If an object with the IS_TURNABLE() flag needs to be turned due 681 * If an object with the IS_TURNABLE() flag needs to be turned due
683 * UP_OBJ_FACE: only the objects face has changed. 732 * UP_OBJ_FACE: only the objects face has changed.
684 */ 733 */
685void 734void
686update_object (object *op, int action) 735update_object (object *op, int action)
687{ 736{
688 if (op == NULL) 737 if (!op)
689 { 738 {
690 /* this should never happen */ 739 /* this should never happen */
691 LOG (llevDebug, "update_object() called for NULL object.\n"); 740 LOG (llevError | logBacktrace, "update_object() called for NULL object.\n");
692 return; 741 return;
693 } 742 }
694 743
695 if (op->env) 744 if (!op->is_on_map ())
696 { 745 {
697 /* Animation is currently handled by client, so nothing 746 /* Animation is currently handled by client, so nothing
698 * to do in this case. 747 * to do in this case.
699 */ 748 */
700 return; 749 return;
701 } 750 }
702
703 /* If the map is saving, don't do anything as everything is
704 * going to get freed anyways.
705 */
706 if (!op->map || op->map->in_memory == MAP_SAVING)
707 return;
708 751
709 /* make sure the object is within map boundaries */ 752 /* make sure the object is within map boundaries */
710 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height) 753 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
711 { 754 {
712 LOG (llevError, "update_object() called for object out of map!\n"); 755 LOG (llevError, "update_object() called for object out of map!\n");
723 else if (action == UP_OBJ_INSERT) 766 else if (action == UP_OBJ_INSERT)
724 { 767 {
725 // this is likely overkill, TODO: revisit (schmorp) 768 // this is likely overkill, TODO: revisit (schmorp)
726 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW)) 769 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
727 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC)) 770 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
728 || (op->type == PLAYER && !(m.flags_ & P_PLAYER)) 771 || (op->is_player () && !(m.flags_ & P_PLAYER))
729 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE)) 772 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
730 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE)) 773 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
731 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC)) 774 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
732 || (m.move_on | op->move_on ) != m.move_on 775 || (m.move_on | op->move_on ) != m.move_on
733 || (m.move_off | op->move_off ) != m.move_off 776 || (m.move_off | op->move_off ) != m.move_off
734 || (m.move_slow | op->move_slow) != m.move_slow 777 || (m.move_slow | op->move_slow) != m.move_slow
735 /* This isn't perfect, but I don't expect a lot of objects to 778 /* This isn't perfect, but I don't expect a lot of objects to
736 * to have move_allow right now. 779 * have move_allow right now.
737 */ 780 */
738 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block 781 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
739 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp) 782 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
740 m.flags_ = 0; 783 m.invalidate ();
741 } 784 }
742 /* if the object is being removed, we can't make intelligent 785 /* if the object is being removed, we can't make intelligent
743 * decisions, because remove_ob can't really pass the object 786 * decisions, because remove_ob can't really pass the object
744 * that is being removed. 787 * that is being removed.
745 */ 788 */
746 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 789 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
747 m.flags_ = 0; 790 m.invalidate ();
748 else if (action == UP_OBJ_FACE) 791 else if (action == UP_OBJ_FACE)
749 /* Nothing to do for that case */ ; 792 /* Nothing to do for that case */ ;
750 else 793 else
751 LOG (llevError, "update_object called with invalid action: %d\n", action); 794 LOG (llevError, "update_object called with invalid action: %d\n", action);
752 795
756 799
757object::object () 800object::object ()
758{ 801{
759 SET_FLAG (this, FLAG_REMOVED); 802 SET_FLAG (this, FLAG_REMOVED);
760 803
761 expmul = 1.0; 804 //expmul = 1.0; declared const for the time being
762 face = blank_face; 805 face = blank_face;
763} 806}
764 807
765object::~object () 808object::~object ()
766{ 809{
772static int object_count; 815static int object_count;
773 816
774void object::link () 817void object::link ()
775{ 818{
776 assert (!index);//D 819 assert (!index);//D
777 uuid = gen_uuid (); 820 uuid = UUID::gen ();
778 count = ++object_count; 821 count = ++object_count;
779 822
780 refcnt_inc (); 823 refcnt_inc ();
781 objects.insert (this); 824 objects.insert (this);
782} 825}
796 /* If already on active list, don't do anything */ 839 /* If already on active list, don't do anything */
797 if (active) 840 if (active)
798 return; 841 return;
799 842
800 if (has_active_speed ()) 843 if (has_active_speed ())
844 {
845 if (flag [FLAG_FREED])
846 LOG (llevError | logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
847
801 actives.insert (this); 848 actives.insert (this);
849 }
802} 850}
803 851
804void 852void
805object::activate_recursive () 853object::activate_recursive ()
806{ 854{
855object::destroy_inv (bool drop_to_ground) 903object::destroy_inv (bool drop_to_ground)
856{ 904{
857 // need to check first, because the checks below might segfault 905 // need to check first, because the checks below might segfault
858 // as we might be on an invalid mapspace and crossfire code 906 // as we might be on an invalid mapspace and crossfire code
859 // is too buggy to ensure that the inventory is empty. 907 // is too buggy to ensure that the inventory is empty.
860 // corollary: if you create arrows etc. with stuff in tis inventory, 908 // corollary: if you create arrows etc. with stuff in its inventory,
861 // cf will crash below with off-map x and y 909 // cf will crash below with off-map x and y
862 if (!inv) 910 if (!inv)
863 return; 911 return;
864 912
865 /* Only if the space blocks everything do we not process - 913 /* Only if the space blocks everything do we not process -
866 * if some form of movement is allowed, let objects 914 * if some form of movement is allowed, let objects
867 * drop on that space. 915 * drop on that space.
868 */ 916 */
869 if (!drop_to_ground 917 if (!drop_to_ground
870 || !map 918 || !map
871 || map->in_memory != MAP_IN_MEMORY 919 || map->in_memory != MAP_ACTIVE
872 || map->nodrop 920 || map->no_drop
873 || ms ().move_block == MOVE_ALL) 921 || ms ().move_block == MOVE_ALL)
874 { 922 {
875 while (inv) 923 while (inv)
876 {
877 inv->destroy_inv (drop_to_ground);
878 inv->destroy (); 924 inv->destroy ();
879 }
880 } 925 }
881 else 926 else
882 { /* Put objects in inventory onto this space */ 927 { /* Put objects in inventory onto this space */
883 while (inv) 928 while (inv)
884 { 929 {
902 object *op = new object; 947 object *op = new object;
903 op->link (); 948 op->link ();
904 return op; 949 return op;
905} 950}
906 951
952static struct freed_map : maptile
953{
954 freed_map ()
955 {
956 path = "<freed objects map>";
957 name = "/internal/freed_objects_map";
958 width = 3;
959 height = 3;
960 no_drop = 1;
961 no_reset = 1;
962
963 alloc ();
964 in_memory = MAP_ACTIVE;
965 }
966
967 ~freed_map ()
968 {
969 destroy ();
970 }
971} freed_map; // freed objects are moved here to avoid crashes
972
907void 973void
908object::do_destroy () 974object::do_destroy ()
909{ 975{
910 attachable::do_destroy ();
911
912 if (flag [FLAG_IS_LINKED]) 976 if (flag [FLAG_IS_LINKED])
913 remove_button_link (this); 977 remove_link ();
914 978
915 if (flag [FLAG_FRIENDLY]) 979 if (flag [FLAG_FRIENDLY])
916 remove_friendly_object (this); 980 remove_friendly_object (this);
917 981
918 if (!flag [FLAG_REMOVED])
919 remove (); 982 remove ();
920 983
921 destroy_inv (true); 984 attachable::do_destroy ();
922 985
923 deactivate (); 986 deactivate ();
924 unlink (); 987 unlink ();
925 988
926 flag [FLAG_FREED] = 1; 989 flag [FLAG_FREED] = 1;
927 990
928 // hack to ensure that freed objects still have a valid map 991 // hack to ensure that freed objects still have a valid map
929 {
930 static maptile *freed_map; // freed objects are moved here to avoid crashes
931
932 if (!freed_map)
933 {
934 freed_map = new maptile;
935
936 freed_map->path = "<freed objects map>";
937 freed_map->name = "/internal/freed_objects_map";
938 freed_map->width = 3;
939 freed_map->height = 3;
940 freed_map->nodrop = 1;
941
942 freed_map->alloc ();
943 freed_map->in_memory = MAP_IN_MEMORY;
944 }
945
946 map = freed_map; 992 map = &freed_map;
947 x = 1; 993 x = 1;
948 y = 1; 994 y = 1;
949 }
950 995
951 if (more) 996 if (more)
952 { 997 {
953 more->destroy (); 998 more->destroy ();
954 more = 0; 999 more = 0;
962 attacked_by = 0; 1007 attacked_by = 0;
963 current_weapon = 0; 1008 current_weapon = 0;
964} 1009}
965 1010
966void 1011void
967object::destroy (bool destroy_inventory) 1012object::destroy ()
968{ 1013{
969 if (destroyed ()) 1014 if (destroyed ())
970 return; 1015 return;
971 1016
972 if (destroy_inventory) 1017 if (!is_head () && !head->destroyed ())
1018 {
1019 LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
1020 head->destroy ();
1021 return;
1022 }
1023
973 destroy_inv (false); 1024 destroy_inv (false);
974 1025
975 if (is_head ()) 1026 if (is_head ())
976 if (sound_destroy) 1027 if (sound_destroy)
977 play_sound (sound_destroy); 1028 play_sound (sound_destroy);
978 else if (flag [FLAG_MONSTER]) 1029 else if (flag [FLAG_MONSTER])
979 play_sound (sound_find ("monster_destroy")); // quick hack, too lazy to create a generic mechanism 1030 play_sound (sound_find ("monster_destroy")); // quick hack, too lazy to create a generic mechanism
980 1031
981 attachable::destroy (); 1032 attachable::destroy ();
982}
983
984/*
985 * sub_weight() recursively (outwards) subtracts a number from the
986 * weight of an object (and what is carried by it's environment(s)).
987 */
988void
989sub_weight (object *op, signed long weight)
990{
991 while (op != NULL)
992 {
993 if (op->type == CONTAINER)
994 weight = (signed long) (weight * (100 - op->stats.Str) / 100);
995
996 op->carrying -= weight;
997 op = op->env;
998 }
999} 1033}
1000 1034
1001/* op->remove (): 1035/* op->remove ():
1002 * This function removes the object op from the linked list of objects 1036 * This function removes the object op from the linked list of objects
1003 * which it is currently tied to. When this function is done, the 1037 * which it is currently tied to. When this function is done, the
1009object::do_remove () 1043object::do_remove ()
1010{ 1044{
1011 object *tmp, *last = 0; 1045 object *tmp, *last = 0;
1012 object *otmp; 1046 object *otmp;
1013 1047
1014 if (QUERY_FLAG (this, FLAG_REMOVED)) 1048 if (flag [FLAG_REMOVED])
1015 return; 1049 return;
1016 1050
1017 SET_FLAG (this, FLAG_REMOVED);
1018 INVOKE_OBJECT (REMOVE, this); 1051 INVOKE_OBJECT (REMOVE, this);
1052
1053 flag [FLAG_REMOVED] = true;
1019 1054
1020 if (more) 1055 if (more)
1021 more->remove (); 1056 more->remove ();
1022 1057
1023 /* 1058 /*
1024 * In this case, the object to be removed is in someones 1059 * In this case, the object to be removed is in someones
1025 * inventory. 1060 * inventory.
1026 */ 1061 */
1027 if (env) 1062 if (env)
1028 { 1063 {
1029 if (nrof) 1064 flag [FLAG_REMOVED] = false; // hack around the issue of visible_to checking flag_removed
1030 sub_weight (env, weight * nrof); 1065 if (object *pl = visible_to ())
1031 else 1066 esrv_del_item (pl->contr, count);
1032 sub_weight (env, weight + carrying); 1067 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
1068
1069 adjust_weight (env, -total_weight ());
1070
1071 object *pl = in_player ();
1072
1073 /* we set up values so that it could be inserted into
1074 * the map, but we don't actually do that - it is up
1075 * to the caller to decide what we want to do.
1076 */
1077 map = env->map;
1078 x = env->x;
1079 y = env->y;
1080
1081 // make sure cmov optimisation is applicable
1082 *(above ? &above->below : &env->inv) = below;
1083 *(below ? &below->above : &above ) = above; // &above is just a dummy
1084
1085 above = 0;
1086 below = 0;
1087 env = 0;
1033 1088
1034 /* NO_FIX_PLAYER is set when a great many changes are being 1089 /* NO_FIX_PLAYER is set when a great many changes are being
1035 * made to players inventory. If set, avoiding the call 1090 * made to players inventory. If set, avoiding the call
1036 * to save cpu time. 1091 * to save cpu time.
1037 */ 1092 */
1038 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1093 if (pl)
1094 if (pl->is_player () && (glow_radius || !QUERY_FLAG (pl, FLAG_NO_FIX_PLAYER)))
1095 {
1039 otmp->update_stats (); 1096 pl->update_stats ();
1040 1097
1041 if (above) 1098 if (glow_radius && pl->is_on_map ())
1042 above->below = below; 1099 update_all_los (pl->map, pl->x, pl->y);
1043 else 1100 }
1044 env->inv = below;
1045
1046 if (below)
1047 below->above = above;
1048
1049 /* we set up values so that it could be inserted into
1050 * the map, but we don't actually do that - it is up
1051 * to the caller to decide what we want to do.
1052 */
1053 x = env->x, y = env->y;
1054 map = env->map;
1055 above = 0, below = 0;
1056 env = 0;
1057 } 1101 }
1058 else if (map) 1102 else if (map)
1059 { 1103 {
1060 if (type == PLAYER)
1061 {
1062 // leaving a spot always closes any open container on the ground
1063 if (container && !container->env)
1064 // this causes spurious floorbox updates, but it ensures
1065 // that the CLOSE event is being sent.
1066 close_container ();
1067
1068 --map->players;
1069 map->touch ();
1070 }
1071
1072 map->dirty = true; 1104 map->dirty = true;
1073 mapspace &ms = this->ms (); 1105 mapspace &ms = this->ms ();
1074 1106
1107 if (object *pl = ms.player ())
1108 {
1109 if (is_player ())
1110 {
1111 if (!flag [FLAG_WIZPASS])
1112 ms.smell = ++mapspace::smellcount; // remember the smell of the player
1113
1114 // leaving a spot always closes any open container on the ground
1115 if (container && !container->env)
1116 // this causes spurious floorbox updates, but it ensures
1117 // that the CLOSE event is being sent.
1118 close_container ();
1119
1120 --map->players;
1121 map->touch ();
1122 }
1123 else if (pl->container == this)
1124 {
1125 // removing a container should close it
1126 close_container ();
1127 }
1128
1129 esrv_del_item (pl->contr, count);
1130 }
1131
1075 /* link the object above us */ 1132 /* link the object above us */
1076 if (above) 1133 // re-link, make sure compiler can easily use cmove
1077 above->below = below; 1134 *(above ? &above->below : &ms.top) = below;
1078 else 1135 *(below ? &below->above : &ms.bot) = above;
1079 ms.top = below; /* we were top, set new top */
1080
1081 /* Relink the object below us, if there is one */
1082 if (below)
1083 below->above = above;
1084 else
1085 {
1086 /* Nothing below, which means we need to relink map object for this space
1087 * use translated coordinates in case some oddness with map tiling is
1088 * evident
1089 */
1090 if (GET_MAP_OB (map, x, y) != this)
1091 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1092
1093 ms.bot = above; /* goes on above it. */
1094 }
1095 1136
1096 above = 0; 1137 above = 0;
1097 below = 0; 1138 below = 0;
1139
1140 ms.invalidate ();
1098 1141
1099 if (map->in_memory == MAP_SAVING) 1142 if (map->in_memory == MAP_SAVING)
1100 return; 1143 return;
1101 1144
1102 int check_walk_off = !flag [FLAG_NO_APPLY]; 1145 int check_walk_off = !flag [FLAG_NO_APPLY];
1108 * removed (most likely destroyed), update the player view 1151 * removed (most likely destroyed), update the player view
1109 * appropriately. 1152 * appropriately.
1110 */ 1153 */
1111 pl->close_container (); 1154 pl->close_container ();
1112 1155
1156 //TODO: the floorbox prev/next might need updating
1157 //esrv_del_item (pl->contr, count);
1158 //TODO: update floorbox to preserve ordering
1159 if (pl->contr->ns)
1113 pl->contr->ns->floorbox_update (); 1160 pl->contr->ns->floorbox_update ();
1114 } 1161 }
1115 1162
1116 for (tmp = ms.bot; tmp; tmp = tmp->above) 1163 for (tmp = ms.bot; tmp; tmp = tmp->above)
1117 { 1164 {
1118 /* No point updating the players look faces if he is the object 1165 /* No point updating the players look faces if he is the object
1131 } 1178 }
1132 1179
1133 last = tmp; 1180 last = tmp;
1134 } 1181 }
1135 1182
1136 /* last == NULL if there are no objects on this space */ 1183 if (affects_los ())
1137 //TODO: this makes little sense, why only update the topmost object?
1138 if (!last)
1139 map->at (x, y).flags_ = 0;
1140 else
1141 update_object (last, UP_OBJ_REMOVE);
1142
1143 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1144 update_all_los (map, x, y); 1184 update_all_los (map, x, y);
1145 } 1185 }
1146} 1186}
1147 1187
1148/* 1188/*
1162 if (!top) 1202 if (!top)
1163 for (top = op; top && top->above; top = top->above) 1203 for (top = op; top && top->above; top = top->above)
1164 ; 1204 ;
1165 1205
1166 for (; top; top = top->below) 1206 for (; top; top = top->below)
1167 {
1168 if (top == op)
1169 continue;
1170
1171 if (object::can_merge (op, top)) 1207 if (object::can_merge (op, top))
1172 { 1208 {
1173 top->nrof += op->nrof; 1209 top->nrof += op->nrof;
1174 1210
1175/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/ 1211 if (object *pl = top->visible_to ())
1176 op->weight = 0; /* Don't want any adjustements now */ 1212 esrv_update_item (UPD_NROF, pl, top);
1213
1214 op->weight = 0; // cancel the addition above
1215 op->carrying = 0; // must be 0 already
1216
1177 op->destroy (); 1217 op->destroy ();
1218
1178 return top; 1219 return top;
1179 } 1220 }
1180 }
1181 1221
1182 return 0; 1222 return 0;
1183} 1223}
1184 1224
1185void 1225void
1210 * job preparing multi-part monsters. 1250 * job preparing multi-part monsters.
1211 */ 1251 */
1212object * 1252object *
1213insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1253insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1214{ 1254{
1255 op->remove ();
1256
1215 for (object *tmp = op->head_ (); tmp; tmp = tmp->more) 1257 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1216 { 1258 {
1217 tmp->x = x + tmp->arch->x; 1259 tmp->x = x + tmp->arch->x;
1218 tmp->y = y + tmp->arch->y; 1260 tmp->y = y + tmp->arch->y;
1219 } 1261 }
1242 * just 'op' otherwise 1284 * just 'op' otherwise
1243 */ 1285 */
1244object * 1286object *
1245insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1287insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1246{ 1288{
1247 assert (!op->flag [FLAG_FREED]);
1248
1249 object *top, *floor = NULL;
1250
1251 op->remove (); 1289 op->remove ();
1290
1291 if (m == &freed_map)//D TODO: remove soon
1292 {//D
1293 LOG (llevError | logBacktrace, "tries to insret object on freed objects map: %s", op->debug_desc ());//D
1294 }//D
1252 1295
1253 /* Ideally, the caller figures this out. However, it complicates a lot 1296 /* Ideally, the caller figures this out. However, it complicates a lot
1254 * of areas of callers (eg, anything that uses find_free_spot would now 1297 * of areas of callers (eg, anything that uses find_free_spot would now
1255 * need extra work 1298 * need extra work
1256 */ 1299 */
1300 maptile *newmap = m;
1257 if (!xy_normalise (m, op->x, op->y)) 1301 if (!xy_normalise (newmap, op->x, op->y))
1258 { 1302 {
1259 op->destroy (); 1303 op->head_ ()->destroy ();// remove head_ once all tail object destroyers found
1260 return 0; 1304 return 0;
1261 } 1305 }
1262 1306
1263 if (object *more = op->more) 1307 if (object *more = op->more)
1264 if (!insert_ob_in_map (more, m, originator, flag)) 1308 if (!insert_ob_in_map (more, m, originator, flag))
1265 return 0; 1309 return 0;
1266 1310
1267 CLEAR_FLAG (op, FLAG_REMOVED); 1311 op->flag [FLAG_REMOVED] = false;
1268 1312 op->env = 0;
1269 op->map = m; 1313 op->map = newmap;
1314
1270 mapspace &ms = op->ms (); 1315 mapspace &ms = op->ms ();
1271 1316
1272 /* this has to be done after we translate the coordinates. 1317 /* this has to be done after we translate the coordinates.
1273 */ 1318 */
1274 if (op->nrof && !(flag & INS_NO_MERGE)) 1319 if (op->nrof && !(flag & INS_NO_MERGE))
1275 for (object *tmp = ms.bot; tmp; tmp = tmp->above) 1320 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1276 if (object::can_merge (op, tmp)) 1321 if (object::can_merge (op, tmp))
1277 { 1322 {
1323 // TODO: we actually want to update tmp, not op,
1324 // but some caller surely breaks when we return tmp
1325 // from here :/
1278 op->nrof += tmp->nrof; 1326 op->nrof += tmp->nrof;
1279 tmp->destroy (); 1327 tmp->destroy ();
1280 } 1328 }
1281 1329
1282 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1330 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1291 { 1339 {
1292 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n"); 1340 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1293 abort (); 1341 abort ();
1294 } 1342 }
1295 1343
1344 if (!originator->is_on_map ())
1345 {
1346 LOG (llevError, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
1347 op->debug_desc (), originator->debug_desc ());
1348 abort ();
1349 }
1350
1296 op->above = originator; 1351 op->above = originator;
1297 op->below = originator->below; 1352 op->below = originator->below;
1298
1299 if (op->below)
1300 op->below->above = op;
1301 else
1302 ms.bot = op;
1303
1304 /* since *below* originator, no need to update top */
1305 originator->below = op; 1353 originator->below = op;
1354
1355 *(op->below ? &op->below->above : &ms.bot) = op;
1306 } 1356 }
1307 else 1357 else
1308 { 1358 {
1309 top = ms.bot; 1359 object *floor = 0;
1360 object *top = ms.top;
1310 1361
1311 /* If there are other objects, then */ 1362 /* If there are other objects, then */
1312 if (top) 1363 if (top)
1313 { 1364 {
1314 object *last = 0;
1315
1316 /* 1365 /*
1317 * If there are multiple objects on this space, we do some trickier handling. 1366 * If there are multiple objects on this space, we do some trickier handling.
1318 * We've already dealt with merging if appropriate. 1367 * We've already dealt with merging if appropriate.
1319 * Generally, we want to put the new object on top. But if 1368 * Generally, we want to put the new object on top. But if
1320 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last 1369 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
1323 * once we get to them. This reduces the need to traverse over all of 1372 * once we get to them. This reduces the need to traverse over all of
1324 * them when adding another one - this saves quite a bit of cpu time 1373 * them when adding another one - this saves quite a bit of cpu time
1325 * when lots of spells are cast in one area. Currently, it is presumed 1374 * when lots of spells are cast in one area. Currently, it is presumed
1326 * that flying non pickable objects are spell objects. 1375 * that flying non pickable objects are spell objects.
1327 */ 1376 */
1328 for (top = ms.bot; top; top = top->above) 1377 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1329 { 1378 {
1330 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1379 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) || QUERY_FLAG (tmp, FLAG_OVERLAY_FLOOR))
1331 floor = top; 1380 floor = tmp;
1332 1381
1333 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1382 if (QUERY_FLAG (tmp, FLAG_NO_PICK) && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (tmp, FLAG_IS_FLOOR))
1334 { 1383 {
1335 /* We insert above top, so we want this object below this */ 1384 /* We insert above top, so we want this object below this */
1336 top = top->below; 1385 top = tmp->below;
1337 break; 1386 break;
1338 } 1387 }
1339 1388
1340 last = top; 1389 top = tmp;
1341 } 1390 }
1342
1343 /* Don't want top to be NULL, so set it to the last valid object */
1344 top = last;
1345 1391
1346 /* We let update_position deal with figuring out what the space 1392 /* We let update_position deal with figuring out what the space
1347 * looks like instead of lots of conditions here. 1393 * looks like instead of lots of conditions here.
1348 * makes things faster, and effectively the same result. 1394 * makes things faster, and effectively the same result.
1349 */ 1395 */
1356 */ 1402 */
1357 if (!(flag & INS_ON_TOP) 1403 if (!(flag & INS_ON_TOP)
1358 && ms.flags () & P_BLOCKSVIEW 1404 && ms.flags () & P_BLOCKSVIEW
1359 && (op->face && !faces [op->face].visibility)) 1405 && (op->face && !faces [op->face].visibility))
1360 { 1406 {
1407 object *last;
1408
1361 for (last = top; last != floor; last = last->below) 1409 for (last = top; last != floor; last = last->below)
1362 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1410 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1363 break; 1411 break;
1364 1412
1365 /* Check to see if we found the object that blocks view, 1413 /* Check to see if we found the object that blocks view,
1373 } /* If objects on this space */ 1421 } /* If objects on this space */
1374 1422
1375 if (flag & INS_ABOVE_FLOOR_ONLY) 1423 if (flag & INS_ABOVE_FLOOR_ONLY)
1376 top = floor; 1424 top = floor;
1377 1425
1378 /* Top is the object that our object (op) is going to get inserted above. 1426 // insert object above top, or bottom-most if top = 0
1379 */
1380
1381 /* First object on this space */
1382 if (!top) 1427 if (!top)
1383 { 1428 {
1429 op->below = 0;
1384 op->above = ms.bot; 1430 op->above = ms.bot;
1385
1386 if (op->above)
1387 op->above->below = op;
1388
1389 op->below = 0;
1390 ms.bot = op; 1431 ms.bot = op;
1432
1433 *(op->above ? &op->above->below : &ms.top) = op;
1391 } 1434 }
1392 else 1435 else
1393 { /* get inserted into the stack above top */ 1436 {
1394 op->above = top->above; 1437 op->above = top->above;
1395
1396 if (op->above)
1397 op->above->below = op; 1438 top->above = op;
1398 1439
1399 op->below = top; 1440 op->below = top;
1400 top->above = op; 1441 *(op->above ? &op->above->below : &ms.top) = op;
1401 } 1442 }
1443 }
1402 1444
1403 if (!op->above) 1445 if (op->is_player ())
1404 ms.top = op;
1405 } /* else not INS_BELOW_ORIGINATOR */
1406
1407 if (op->type == PLAYER)
1408 { 1446 {
1409 op->contr->do_los = 1; 1447 op->contr->do_los = 1;
1410 ++op->map->players; 1448 ++op->map->players;
1411 op->map->touch (); 1449 op->map->touch ();
1412 } 1450 }
1413 1451
1414 op->map->dirty = true; 1452 op->map->dirty = true;
1415 1453
1416 if (object *pl = ms.player ()) 1454 if (object *pl = ms.player ())
1455 //TODO: the floorbox prev/next might need updating
1456 //esrv_send_item (pl, op);
1457 //TODO: update floorbox to preserve ordering
1458 if (pl->contr->ns)
1417 pl->contr->ns->floorbox_update (); 1459 pl->contr->ns->floorbox_update ();
1418 1460
1419 /* If this object glows, it may affect lighting conditions that are 1461 /* If this object glows, it may affect lighting conditions that are
1420 * visible to others on this map. But update_all_los is really 1462 * visible to others on this map. But update_all_los is really
1421 * an inefficient way to do this, as it means los for all players 1463 * an inefficient way to do this, as it means los for all players
1422 * on the map will get recalculated. The players could very well 1464 * on the map will get recalculated. The players could very well
1423 * be far away from this change and not affected in any way - 1465 * be far away from this change and not affected in any way -
1424 * this should get redone to only look for players within range, 1466 * this should get redone to only look for players within range,
1425 * or just updating the P_UPTODATE for spaces within this area 1467 * or just updating the P_UPTODATE for spaces within this area
1426 * of effect may be sufficient. 1468 * of effect may be sufficient.
1427 */ 1469 */
1428 if (op->map->darkness && (op->glow_radius != 0)) 1470 if (op->affects_los ())
1471 {
1472 op->ms ().invalidate ();
1429 update_all_los (op->map, op->x, op->y); 1473 update_all_los (op->map, op->x, op->y);
1474 }
1430 1475
1431 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1476 /* updates flags (blocked, alive, no magic, etc) for this map space */
1432 update_object (op, UP_OBJ_INSERT); 1477 update_object (op, UP_OBJ_INSERT);
1433 1478
1434 INVOKE_OBJECT (INSERT, op); 1479 INVOKE_OBJECT (INSERT, op);
1441 * blocked() and wall() work properly), and these flags are updated by 1486 * blocked() and wall() work properly), and these flags are updated by
1442 * update_object(). 1487 * update_object().
1443 */ 1488 */
1444 1489
1445 /* if this is not the head or flag has been passed, don't check walk on status */ 1490 /* if this is not the head or flag has been passed, don't check walk on status */
1446 if (!(flag & INS_NO_WALK_ON) && op->head_ () == op) 1491 if (!(flag & INS_NO_WALK_ON) && op->is_head ())
1447 { 1492 {
1448 if (check_move_on (op, originator)) 1493 if (check_move_on (op, originator))
1449 return 0; 1494 return 0;
1450 1495
1451 /* If we are a multi part object, lets work our way through the check 1496 /* If we are a multi part object, lets work our way through the check
1462/* this function inserts an object in the map, but if it 1507/* this function inserts an object in the map, but if it
1463 * finds an object of its own type, it'll remove that one first. 1508 * finds an object of its own type, it'll remove that one first.
1464 * op is the object to insert it under: supplies x and the map. 1509 * op is the object to insert it under: supplies x and the map.
1465 */ 1510 */
1466void 1511void
1467replace_insert_ob_in_map (const char *arch_string, object *op) 1512replace_insert_ob_in_map (shstr_tmp archname, object *op)
1468{ 1513{
1469 object *tmp, *tmp1;
1470
1471 /* first search for itself and remove any old instances */ 1514 /* first search for itself and remove any old instances */
1472 1515
1473 for (tmp = op->ms ().bot; tmp; tmp = tmp->above) 1516 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1474 if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */ 1517 if (tmp->arch->archname == archname) /* same archetype */
1475 tmp->destroy (); 1518 tmp->destroy ();
1476 1519
1477 tmp1 = arch_to_object (archetype::find (arch_string)); 1520 object *tmp = arch_to_object (archetype::find (archname));
1478 1521
1479 tmp1->x = op->x; 1522 tmp->x = op->x;
1480 tmp1->y = op->y; 1523 tmp->y = op->y;
1524
1481 insert_ob_in_map (tmp1, op->map, op, 0); 1525 insert_ob_in_map (tmp, op->map, op, 0);
1482} 1526}
1483 1527
1484object * 1528object *
1485object::insert_at (object *where, object *originator, int flags) 1529object::insert_at (object *where, object *originator, int flags)
1486{ 1530{
1531 if (where->env)
1532 return where->env->insert (this);
1533 else
1487 return where->map->insert (this, where->x, where->y, originator, flags); 1534 return where->map->insert (this, where->x, where->y, originator, flags);
1488} 1535}
1489 1536
1490/* 1537/*
1491 * get_split_ob(ob,nr) splits up ob into two parts. The part which
1492 * is returned contains nr objects, and the remaining parts contains
1493 * the rest (or is removed and freed if that number is 0).
1494 * On failure, NULL is returned, and the reason put into the
1495 * global static errmsg array.
1496 */
1497object *
1498get_split_ob (object *orig_ob, uint32 nr)
1499{
1500 object *newob;
1501 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1502
1503 if (orig_ob->nrof < nr)
1504 {
1505 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1506 return NULL;
1507 }
1508
1509 newob = object_create_clone (orig_ob);
1510
1511 if ((orig_ob->nrof -= nr) < 1)
1512 orig_ob->destroy (1);
1513 else if (!is_removed)
1514 {
1515 if (orig_ob->env != NULL)
1516 sub_weight (orig_ob->env, orig_ob->weight * nr);
1517 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY)
1518 {
1519 strcpy (errmsg, "Tried to split object whose map is not in memory.");
1520 LOG (llevDebug, "Error, Tried to split object whose map is not in memory.\n");
1521 return NULL;
1522 }
1523 }
1524
1525 newob->nrof = nr;
1526
1527 return newob;
1528}
1529
1530/*
1531 * decrease_ob_nr(object, number) decreases a specified number from 1538 * decrease(object, number) decreases a specified number from
1532 * the amount of an object. If the amount reaches 0, the object 1539 * the amount of an object. If the amount reaches 0, the object
1533 * is subsequently removed and freed. 1540 * is subsequently removed and freed.
1534 * 1541 *
1535 * Return value: 'op' if something is left, NULL if the amount reached 0 1542 * Return value: 'op' if something is left, NULL if the amount reached 0
1536 */ 1543 */
1544bool
1545object::decrease (sint32 nr)
1546{
1547 if (!nr)
1548 return true;
1549
1550 nr = min (nr, nrof);
1551
1552 if (nrof > nr)
1553 {
1554 nrof -= nr;
1555 adjust_weight (env, -weight * max (1, nr)); // carrying == 0
1556
1557 if (object *pl = visible_to ())
1558 esrv_update_item (UPD_NROF, pl, this);
1559
1560 return true;
1561 }
1562 else
1563 {
1564 destroy ();
1565 return false;
1566 }
1567}
1568
1569/*
1570 * split(ob,nr) splits up ob into two parts. The part which
1571 * is returned contains nr objects, and the remaining parts contains
1572 * the rest (or is removed and returned if that number is 0).
1573 * On failure, NULL is returned.
1574 */
1537object * 1575object *
1538decrease_ob_nr (object *op, uint32 i) 1576object::split (sint32 nr)
1539{ 1577{
1540 object *tmp; 1578 int have = number_of ();
1541 1579
1542 if (i == 0) /* objects with op->nrof require this check */ 1580 if (have < nr)
1543 return op; 1581 return 0;
1544 1582 else if (have == nr)
1545 if (i > op->nrof)
1546 i = op->nrof;
1547
1548 if (QUERY_FLAG (op, FLAG_REMOVED))
1549 op->nrof -= i;
1550 else if (op->env)
1551 { 1583 {
1552 /* is this object in the players inventory, or sub container
1553 * therein?
1554 */
1555 tmp = op->in_player ();
1556 /* nope. Is this a container the player has opened?
1557 * If so, set tmp to that player.
1558 * IMO, searching through all the players will mostly
1559 * likely be quicker than following op->env to the map,
1560 * and then searching the map for a player.
1561 */
1562 if (!tmp)
1563 for_all_players (pl)
1564 if (pl->ob->container == op->env)
1565 {
1566 tmp = pl->ob;
1567 break;
1568 }
1569
1570 if (i < op->nrof)
1571 {
1572 sub_weight (op->env, op->weight * i);
1573 op->nrof -= i;
1574 if (tmp)
1575 esrv_send_item (tmp, op);
1576 }
1577 else
1578 {
1579 op->remove (); 1584 remove ();
1580 op->nrof = 0; 1585 return this;
1581 if (tmp)
1582 esrv_del_item (tmp->contr, op->count);
1583 }
1584 } 1586 }
1585 else 1587 else
1586 { 1588 {
1587 object *above = op->above; 1589 decrease (nr);
1588 1590
1589 if (i < op->nrof) 1591 object *op = deep_clone ();
1590 op->nrof -= i; 1592 op->nrof = nr;
1591 else
1592 {
1593 op->remove ();
1594 op->nrof = 0;
1595 }
1596
1597 /* Since we just removed op, op->above is null */
1598 for (tmp = above; tmp; tmp = tmp->above)
1599 if (tmp->type == PLAYER)
1600 {
1601 if (op->nrof)
1602 esrv_send_item (tmp, op);
1603 else
1604 esrv_del_item (tmp->contr, op->count);
1605 }
1606 }
1607
1608 if (op->nrof)
1609 return op; 1593 return op;
1610 else
1611 {
1612 op->destroy ();
1613 return 0;
1614 }
1615}
1616
1617/*
1618 * add_weight(object, weight) adds the specified weight to an object,
1619 * and also updates how much the environment(s) is/are carrying.
1620 */
1621void
1622add_weight (object *op, signed long weight)
1623{
1624 while (op != NULL)
1625 {
1626 if (op->type == CONTAINER)
1627 weight = (signed long) (weight * (100 - op->stats.Str) / 100);
1628
1629 op->carrying += weight;
1630 op = op->env;
1631 } 1594 }
1632} 1595}
1633 1596
1634object * 1597object *
1635insert_ob_in_ob (object *op, object *where) 1598insert_ob_in_ob (object *op, object *where)
1660 * be != op, if items are merged. -Tero 1623 * be != op, if items are merged. -Tero
1661 */ 1624 */
1662object * 1625object *
1663object::insert (object *op) 1626object::insert (object *op)
1664{ 1627{
1665 if (!QUERY_FLAG (op, FLAG_REMOVED))
1666 op->remove ();
1667
1668 if (op->more) 1628 if (op->more)
1669 { 1629 {
1670 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count); 1630 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);
1671 return op; 1631 return op;
1672 } 1632 }
1673 1633
1674 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL); 1634 op->remove ();
1675 CLEAR_FLAG (op, FLAG_REMOVED); 1635
1636 op->flag [FLAG_OBJ_ORIGINAL] = 0;
1676 1637
1677 if (op->nrof) 1638 if (op->nrof)
1678 {
1679 for (object *tmp = inv; tmp; tmp = tmp->below) 1639 for (object *tmp = inv; tmp; tmp = tmp->below)
1680 if (object::can_merge (tmp, op)) 1640 if (object::can_merge (tmp, op))
1681 { 1641 {
1682 /* return the original object and remove inserted object 1642 /* return the original object and remove inserted object
1683 (client needs the original object) */ 1643 (client needs the original object) */
1684 tmp->nrof += op->nrof; 1644 tmp->nrof += op->nrof;
1685 /* Weight handling gets pretty funky. Since we are adding to 1645
1686 * tmp->nrof, we need to increase the weight. 1646 if (object *pl = tmp->visible_to ())
1687 */ 1647 esrv_update_item (UPD_NROF, pl, tmp);
1648
1688 add_weight (this, op->weight * op->nrof); 1649 adjust_weight (this, op->total_weight ());
1689 SET_FLAG (op, FLAG_REMOVED); 1650
1690 op->destroy (); /* free the inserted object */ 1651 op->destroy ();
1691 op = tmp; 1652 op = tmp;
1692 op->remove (); /* and fix old object's links */ 1653 goto inserted;
1693 CLEAR_FLAG (op, FLAG_REMOVED);
1694 break;
1695 } 1654 }
1696 1655
1697 /* I assume combined objects have no inventory
1698 * We add the weight - this object could have just been removed
1699 * (if it was possible to merge). calling remove_ob will subtract
1700 * the weight, so we need to add it in again, since we actually do
1701 * the linking below
1702 */
1703 add_weight (this, op->weight * op->nrof);
1704 }
1705 else
1706 add_weight (this, (op->weight + op->carrying));
1707
1708 if (object *otmp = this->in_player ())
1709 if (otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1710 otmp->update_stats ();
1711
1712 op->owner = 0; // its his/hers now. period. 1656 op->owner = 0; // it's his/hers now. period.
1713 op->map = 0; 1657 op->map = 0;
1658 op->x = 0;
1659 op->y = 0;
1660
1661 op->above = 0;
1662 op->below = inv;
1714 op->env = this; 1663 op->env = this;
1715 op->above = 0;
1716 op->below = 0;
1717 op->x = op->y = 0;
1718 1664
1665 if (inv)
1666 inv->above = op;
1667
1668 inv = op;
1669
1670 op->flag [FLAG_REMOVED] = 0;
1671
1672 if (object *pl = op->visible_to ())
1673 esrv_send_item (pl, op);
1674
1675 adjust_weight (this, op->total_weight ());
1676
1677inserted:
1719 /* reset the light list and los of the players on the map */ 1678 /* reset the light list and los of the players on the map */
1720 if (op->glow_radius && map) 1679 if (op->glow_radius && is_on_map ())
1721 { 1680 {
1722#ifdef DEBUG_LIGHTS 1681 update_stats ();
1723 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1724#endif /* DEBUG_LIGHTS */
1725 if (map->darkness)
1726 update_all_los (map, x, y); 1682 update_all_los (map, x, y);
1727 }
1728
1729 /* Client has no idea of ordering so lets not bother ordering it here.
1730 * It sure simplifies this function...
1731 */
1732 if (!inv)
1733 inv = op;
1734 else
1735 { 1683 }
1736 op->below = inv; 1684 else if (is_player () && !flag [FLAG_NO_FIX_PLAYER])
1737 op->below->above = op; 1685 // if this is a player's inventory, update stats
1738 inv = op; 1686 update_stats ();
1739 }
1740 1687
1741 INVOKE_OBJECT (INSERT, this); 1688 INVOKE_OBJECT (INSERT, this);
1742 1689
1743 return op; 1690 return op;
1744} 1691}
1764 * on top. 1711 * on top.
1765 */ 1712 */
1766int 1713int
1767check_move_on (object *op, object *originator) 1714check_move_on (object *op, object *originator)
1768{ 1715{
1716 if (QUERY_FLAG (op, FLAG_NO_APPLY))
1717 return 0;
1718
1769 object *tmp; 1719 object *tmp;
1770 maptile *m = op->map; 1720 maptile *m = op->map;
1771 int x = op->x, y = op->y; 1721 int x = op->x, y = op->y;
1772 1722
1773 MoveType move_on, move_slow, move_block; 1723 mapspace &ms = m->at (x, y);
1774 1724
1775 if (QUERY_FLAG (op, FLAG_NO_APPLY)) 1725 ms.update ();
1776 return 0;
1777 1726
1778 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y); 1727 MoveType move_on = ms.move_on;
1779 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y); 1728 MoveType move_slow = ms.move_slow;
1780 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y); 1729 MoveType move_block = ms.move_block;
1781 1730
1782 /* if nothing on this space will slow op down or be applied, 1731 /* if nothing on this space will slow op down or be applied,
1783 * no need to do checking below. have to make sure move_type 1732 * no need to do checking below. have to make sure move_type
1784 * is set, as lots of objects don't have it set - we treat that 1733 * is set, as lots of objects don't have it set - we treat that
1785 * as walking. 1734 * as walking.
1796 return 0; 1745 return 0;
1797 1746
1798 /* The objects have to be checked from top to bottom. 1747 /* The objects have to be checked from top to bottom.
1799 * Hence, we first go to the top: 1748 * Hence, we first go to the top:
1800 */ 1749 */
1801 1750 for (object *next, *tmp = ms.top; tmp; tmp = next)
1802 for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1803 {
1804 /* Trim the search when we find the first other spell effect
1805 * this helps performance so that if a space has 50 spell objects,
1806 * we don't need to check all of them.
1807 */
1808 if ((tmp->move_type & MOVE_FLY_LOW) && QUERY_FLAG (tmp, FLAG_NO_PICK))
1809 break;
1810 } 1751 {
1752 next = tmp->below;
1811 1753
1812 for (; tmp; tmp = tmp->below)
1813 {
1814 if (tmp == op) 1754 if (tmp == op)
1815 continue; /* Can't apply yourself */ 1755 continue; /* Can't apply yourself */
1816 1756
1817 /* Check to see if one of the movement types should be slowed down. 1757 /* Check to see if one of the movement types should be slowed down.
1818 * Second check makes sure that the movement types not being slowed 1758 * Second check makes sure that the movement types not being slowed
1823 if (!QUERY_FLAG (op, FLAG_WIZPASS)) 1763 if (!QUERY_FLAG (op, FLAG_WIZPASS))
1824 { 1764 {
1825 if ((!op->move_type && tmp->move_slow & MOVE_WALK) || 1765 if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
1826 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0)) 1766 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
1827 { 1767 {
1828
1829 float
1830 diff = tmp->move_slow_penalty * fabs (op->speed); 1768 float diff = tmp->move_slow_penalty * fabs (op->speed);
1831 1769
1832 if (op->type == PLAYER) 1770 if (op->is_player ())
1833 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) || 1771 if ((tmp->flag [FLAG_IS_HILLY ] && find_skill_by_number (op, SK_CLIMBING)) ||
1834 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN))) 1772 (tmp->flag [FLAG_IS_WOODED] && find_skill_by_number (op, SK_WOODSMAN)))
1835 diff /= 4.0; 1773 diff /= 4.0;
1836 1774
1837 op->speed_left -= diff; 1775 op->speed_left -= diff;
1838 } 1776 }
1839 } 1777 }
1872 LOG (llevError, "Present_arch called outside map.\n"); 1810 LOG (llevError, "Present_arch called outside map.\n");
1873 return NULL; 1811 return NULL;
1874 } 1812 }
1875 1813
1876 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above) 1814 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1877 if (tmp->arch == at) 1815 if (tmp->arch->archname == at->archname)
1878 return tmp; 1816 return tmp;
1879 1817
1880 return NULL; 1818 return NULL;
1881} 1819}
1882 1820
1946 * The first matching object is returned, or NULL if none. 1884 * The first matching object is returned, or NULL if none.
1947 */ 1885 */
1948object * 1886object *
1949present_arch_in_ob (const archetype *at, const object *op) 1887present_arch_in_ob (const archetype *at, const object *op)
1950{ 1888{
1951 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below) 1889 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1952 if (tmp->arch == at) 1890 if (tmp->arch->archname == at->archname)
1953 return tmp; 1891 return tmp;
1954 1892
1955 return NULL; 1893 return NULL;
1956} 1894}
1957 1895
2045 * head of the object should correspond for the entire object. 1983 * head of the object should correspond for the entire object.
2046 */ 1984 */
2047 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block)) 1985 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))
2048 continue; 1986 continue;
2049 1987
2050 if (ob->blocked (m, pos.x, pos.y)) 1988 if (ob->blocked (pos.m, pos.x, pos.y))
2051 continue; 1989 continue;
2052 1990
2053 altern [index++] = i; 1991 altern [index++] = i;
2054 } 1992 }
2055 1993
2123 * there is capable of. 2061 * there is capable of.
2124 */ 2062 */
2125int 2063int
2126find_dir (maptile *m, int x, int y, object *exclude) 2064find_dir (maptile *m, int x, int y, object *exclude)
2127{ 2065{
2128 int i, max = SIZEOFFREE, mflags; 2066 int max = SIZEOFFREE, mflags;
2129
2130 sint16 nx, ny;
2131 object *tmp;
2132 maptile *mp;
2133
2134 MoveType blocked, move_type; 2067 MoveType move_type;
2135 2068
2136 if (exclude && exclude->head_ () != exclude) 2069 if (exclude && exclude->head_ () != exclude)
2137 { 2070 {
2138 exclude = exclude->head; 2071 exclude = exclude->head;
2139 move_type = exclude->move_type; 2072 move_type = exclude->move_type;
2142 { 2075 {
2143 /* If we don't have anything, presume it can use all movement types. */ 2076 /* If we don't have anything, presume it can use all movement types. */
2144 move_type = MOVE_ALL; 2077 move_type = MOVE_ALL;
2145 } 2078 }
2146 2079
2147 for (i = 1; i < max; i++) 2080 for (int i = 1; i < max; i++)
2148 { 2081 {
2149 mp = m; 2082 mapxy pos (m, x, y);
2150 nx = x + freearr_x[i]; 2083 pos.move (i);
2151 ny = y + freearr_y[i];
2152 2084
2153 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2085 if (!pos.normalise ())
2154
2155 if (mflags & P_OUT_OF_MAP)
2156 max = maxfree[i]; 2086 max = maxfree[i];
2157 else 2087 else
2158 { 2088 {
2159 mapspace &ms = mp->at (nx, ny); 2089 mapspace &ms = *pos;
2160 2090
2161 blocked = ms.move_block;
2162
2163 if ((move_type & blocked) == move_type) 2091 if ((move_type & ms.move_block) == move_type)
2164 max = maxfree[i]; 2092 max = maxfree [i];
2165 else if (mflags & P_IS_ALIVE) 2093 else if (ms.flags () & P_IS_ALIVE)
2166 { 2094 {
2167 for (tmp = ms.bot; tmp; tmp = tmp->above) 2095 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
2168 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER) 2096 if ((tmp->flag [FLAG_MONSTER] || tmp->is_player ())
2169 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude))) 2097 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))
2170 break;
2171
2172 if (tmp)
2173 return freedir[i]; 2098 return freedir [i];
2174 } 2099 }
2175 } 2100 }
2176 } 2101 }
2177 2102
2178 return 0; 2103 return 0;
2253 * This basically means that if direction is 15, then it could either go 2178 * This basically means that if direction is 15, then it could either go
2254 * direction 4, 14, or 16 to get back to where we are. 2179 * direction 4, 14, or 16 to get back to where we are.
2255 * Moved from spell_util.c to object.c with the other related direction 2180 * Moved from spell_util.c to object.c with the other related direction
2256 * functions. 2181 * functions.
2257 */ 2182 */
2258int reduction_dir[SIZEOFFREE][3] = { 2183const int reduction_dir[SIZEOFFREE][3] = {
2259 {0, 0, 0}, /* 0 */ 2184 {0, 0, 0}, /* 0 */
2260 {0, 0, 0}, /* 1 */ 2185 {0, 0, 0}, /* 1 */
2261 {0, 0, 0}, /* 2 */ 2186 {0, 0, 0}, /* 2 */
2262 {0, 0, 0}, /* 3 */ 2187 {0, 0, 0}, /* 3 */
2263 {0, 0, 0}, /* 4 */ 2188 {0, 0, 0}, /* 4 */
2359int 2284int
2360can_pick (const object *who, const object *item) 2285can_pick (const object *who, const object *item)
2361{ 2286{
2362 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2287 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2363 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2288 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2364 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2289 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->is_player () || item->weight < who->weight / 3));
2365} 2290}
2366 2291
2367/* 2292/*
2368 * create clone from object to another 2293 * create clone from object to another
2369 */ 2294 */
2370object * 2295object *
2371object_create_clone (object *asrc) 2296object::deep_clone ()
2372{ 2297{
2373 object *dst = 0, *tmp, *src, *prev, *item; 2298 assert (("deep_clone called on non-head object", is_head ()));
2374 2299
2375 if (!asrc) 2300 object *dst = clone ();
2376 return 0;
2377 2301
2378 src = asrc->head_ (); 2302 object *prev = dst;
2379
2380 prev = 0;
2381 for (object *part = src; part; part = part->more) 2303 for (object *part = this->more; part; part = part->more)
2382 { 2304 {
2383 tmp = part->clone (); 2305 object *tmp = part->clone ();
2384 tmp->x -= src->x;
2385 tmp->y -= src->y;
2386
2387 if (!part->head)
2388 {
2389 dst = tmp;
2390 tmp->head = 0;
2391 }
2392 else
2393 tmp->head = dst; 2306 tmp->head = dst;
2394
2395 tmp->more = 0;
2396
2397 if (prev)
2398 prev->more = tmp; 2307 prev->more = tmp;
2399
2400 prev = tmp; 2308 prev = tmp;
2401 } 2309 }
2402 2310
2403 for (item = src->inv; item; item = item->below) 2311 for (object *item = inv; item; item = item->below)
2404 insert_ob_in_ob (object_create_clone (item), dst); 2312 insert_ob_in_ob (item->deep_clone (), dst);
2405 2313
2406 return dst; 2314 return dst;
2407} 2315}
2408 2316
2409/* This returns the first object in who's inventory that 2317/* This returns the first object in who's inventory that
2418 return tmp; 2326 return tmp;
2419 2327
2420 return 0; 2328 return 0;
2421} 2329}
2422 2330
2423/* If ob has a field named key, return the link from the list, 2331shstr_tmp
2424 * otherwise return NULL. 2332object::kv_get (shstr_tmp key) const
2425 *
2426 * key must be a passed in shared string - otherwise, this won't
2427 * do the desired thing.
2428 */
2429key_value *
2430get_ob_key_link (const object *ob, const char *key)
2431{ 2333{
2432 for (key_value *link = ob->key_values; link; link = link->next) 2334 for (key_value *kv = key_values; kv; kv = kv->next)
2433 if (link->key == key) 2335 if (kv->key == key)
2434 return link;
2435
2436 return 0;
2437}
2438
2439/*
2440 * Returns the value of op has an extra_field for key, or NULL.
2441 *
2442 * The argument doesn't need to be a shared string.
2443 *
2444 * The returned string is shared.
2445 */
2446const char *
2447get_ob_key_value (const object *op, const char *const key)
2448{
2449 key_value *link;
2450 shstr_cmp canonical_key (key);
2451
2452 if (!canonical_key)
2453 {
2454 /* 1. There being a field named key on any object
2455 * implies there'd be a shared string to find.
2456 * 2. Since there isn't, no object has this field.
2457 * 3. Therefore, *this* object doesn't have this field.
2458 */
2459 return 0;
2460 }
2461
2462 /* This is copied from get_ob_key_link() above -
2463 * only 4 lines, and saves the function call overhead.
2464 */
2465 for (link = op->key_values; link; link = link->next)
2466 if (link->key == canonical_key)
2467 return link->value; 2336 return kv->value;
2468 2337
2469 return 0; 2338 return shstr ();
2470} 2339}
2471 2340
2472/* 2341void
2473 * Updates the canonical_key in op to value. 2342object::kv_set (shstr_tmp key, shstr_tmp value)
2474 *
2475 * canonical_key is a shared string (value doesn't have to be).
2476 *
2477 * Unless add_key is TRUE, it won't add fields, only change the value of existing
2478 * keys.
2479 *
2480 * Returns TRUE on success.
2481 */
2482int
2483set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2484{ 2343{
2485 key_value *field = NULL, *last = NULL; 2344 for (key_value *kv = key_values; kv; kv = kv->next)
2486 2345 if (kv->key == key)
2487 for (field = op->key_values; field != NULL; field = field->next)
2488 {
2489 if (field->key != canonical_key)
2490 { 2346 {
2491 last = field; 2347 kv->value = value;
2492 continue; 2348 return;
2493 } 2349 }
2494 2350
2495 if (value) 2351 key_value *kv = new key_value;
2496 field->value = value; 2352
2497 else 2353 kv->next = key_values;
2354 kv->key = key;
2355 kv->value = value;
2356
2357 key_values = kv;
2358}
2359
2360void
2361object::kv_del (shstr_tmp key)
2362{
2363 for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
2364 if ((*kvp)->key == key)
2498 { 2365 {
2499 /* Basically, if the archetype has this key set, 2366 key_value *kv = *kvp;
2500 * we need to store the null value so when we save 2367 *kvp = (*kvp)->next;
2501 * it, we save the empty value so that when we load, 2368 delete kv;
2502 * we get this value back again. 2369 return;
2503 */
2504 if (get_ob_key_link (op->arch, canonical_key))
2505 field->value = 0;
2506 else
2507 {
2508 if (last)
2509 last->next = field->next;
2510 else
2511 op->key_values = field->next;
2512
2513 delete field;
2514 }
2515 } 2370 }
2516 return TRUE;
2517 }
2518 /* IF we get here, key doesn't exist */
2519
2520 /* No field, we'll have to add it. */
2521
2522 if (!add_key)
2523 return FALSE;
2524
2525 /* There isn't any good reason to store a null
2526 * value in the key/value list. If the archetype has
2527 * this key, then we should also have it, so shouldn't
2528 * be here. If user wants to store empty strings,
2529 * should pass in ""
2530 */
2531 if (value == NULL)
2532 return TRUE;
2533
2534 field = new key_value;
2535
2536 field->key = canonical_key;
2537 field->value = value;
2538 /* Usual prepend-addition. */
2539 field->next = op->key_values;
2540 op->key_values = field;
2541
2542 return TRUE;
2543}
2544
2545/*
2546 * Updates the key in op to value.
2547 *
2548 * If add_key is FALSE, this will only update existing keys,
2549 * and not add new ones.
2550 * In general, should be little reason FALSE is ever passed in for add_key
2551 *
2552 * Returns TRUE on success.
2553 */
2554int
2555set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2556{
2557 shstr key_ (key);
2558
2559 return set_ob_key_value_s (op, key_, value, add_key);
2560} 2371}
2561 2372
2562object::depth_iterator::depth_iterator (object *container) 2373object::depth_iterator::depth_iterator (object *container)
2563: iterator_base (container) 2374: iterator_base (container)
2564{ 2375{
2614{ 2425{
2615 char flagdesc[512]; 2426 char flagdesc[512];
2616 char info2[256 * 4]; 2427 char info2[256 * 4];
2617 char *p = info; 2428 char *p = info;
2618 2429
2619 p += snprintf (p, 512, "{cnt:%d,uuid:<1.%" PRIx64 ">,name:\"%s\"%s%s,flags:[%s],type:%d}", 2430 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2620 count, uuid.seq, 2431 count,
2432 uuid.c_str (),
2621 &name, 2433 &name,
2622 title ? "\",title:\"" : "", 2434 title ? ",title:\"" : "",
2623 title ? (const char *)title : "", 2435 title ? (const char *)title : "",
2436 title ? "\"" : "",
2624 flag_desc (flagdesc, 512), type); 2437 flag_desc (flagdesc, 512), type);
2625 2438
2626 if (!this->flag[FLAG_REMOVED] && env) 2439 if (!flag[FLAG_REMOVED] && env)
2627 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2440 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2628 2441
2629 if (map) 2442 if (map)
2630 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y); 2443 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2631 2444
2661object::open_container (object *new_container) 2474object::open_container (object *new_container)
2662{ 2475{
2663 if (container == new_container) 2476 if (container == new_container)
2664 return; 2477 return;
2665 2478
2666 if (object *old_container = container) 2479 object *old_container = container;
2480
2481 if (old_container)
2667 { 2482 {
2668 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this))) 2483 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))
2669 return; 2484 return;
2670 2485
2671#if 0 2486#if 0
2673 if (object *closer = old_container->inv) 2488 if (object *closer = old_container->inv)
2674 if (closer->type == CLOSE_CON) 2489 if (closer->type == CLOSE_CON)
2675 closer->destroy (); 2490 closer->destroy ();
2676#endif 2491#endif
2677 2492
2493 // make sure the container is available
2494 esrv_send_item (this, old_container);
2495
2678 old_container->flag [FLAG_APPLIED] = 0; 2496 old_container->flag [FLAG_APPLIED] = false;
2679 container = 0; 2497 container = 0;
2680 2498
2499 // client needs item update to make it work, client bug requires this to be separate
2681 esrv_update_item (UPD_FLAGS, this, old_container); 2500 esrv_update_item (UPD_FLAGS, this, old_container);
2501
2682 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container)); 2502 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", old_container->query_name ());
2683 play_sound (sound_find ("chest_close")); 2503 play_sound (sound_find ("chest_close"));
2684 } 2504 }
2685 2505
2686 if (new_container) 2506 if (new_container)
2687 { 2507 {
2697 closer->flag [FLAG_NO_MAP_SAVE] = 1; 2517 closer->flag [FLAG_NO_MAP_SAVE] = 1;
2698 new_container->insert (closer); 2518 new_container->insert (closer);
2699 } 2519 }
2700#endif 2520#endif
2701 2521
2702 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container)); 2522 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", new_container->query_name ());
2703 2523
2524 // make sure the container is available, client bug requires this to be separate
2525 esrv_send_item (this, new_container);
2526
2704 new_container->flag [FLAG_APPLIED] = 1; 2527 new_container->flag [FLAG_APPLIED] = true;
2705 container = new_container; 2528 container = new_container;
2706 2529
2530 // client needs flag change
2707 esrv_update_item (UPD_FLAGS, this, new_container); 2531 esrv_update_item (UPD_FLAGS, this, new_container);
2708 esrv_send_inventory (this, new_container); 2532 esrv_send_inventory (this, new_container);
2709 play_sound (sound_find ("chest_open")); 2533 play_sound (sound_find ("chest_open"));
2710 } 2534 }
2535// else if (!old_container->env && contr && contr->ns)
2536// contr->ns->floorbox_reset ();
2711} 2537}
2712 2538
2713object * 2539object *
2714object::force_find (const shstr name) 2540object::force_find (shstr_tmp name)
2715{ 2541{
2716 /* cycle through his inventory to look for the MARK we want to 2542 /* cycle through his inventory to look for the MARK we want to
2717 * place 2543 * place
2718 */ 2544 */
2719 for (object *tmp = inv; tmp; tmp = tmp->below) 2545 for (object *tmp = inv; tmp; tmp = tmp->below)
2722 2548
2723 return 0; 2549 return 0;
2724} 2550}
2725 2551
2726void 2552void
2553object::force_set_timer (int duration)
2554{
2555 this->duration = 1;
2556 this->speed_left = -1.f;
2557
2558 this->set_speed (duration ? 1.f / duration : 0.f);
2559}
2560
2561object *
2727object::force_add (const shstr name, int duration) 2562object::force_add (shstr_tmp name, int duration)
2728{ 2563{
2729 if (object *force = force_find (name)) 2564 if (object *force = force_find (name))
2730 force->destroy (); 2565 force->destroy ();
2731 2566
2732 object *force = get_archetype (FORCE_NAME); 2567 object *force = get_archetype (FORCE_NAME);
2733 2568
2734 force->slaying = name; 2569 force->slaying = name;
2735 force->stats.food = 1;
2736 force->speed_left = -1.f;
2737 2570
2738 force->set_speed (duration ? 1.f / duration : 0.f); 2571 force->force_set_timer (duration);
2739 force->flag [FLAG_IS_USED_UP] = true; 2572
2740 force->flag [FLAG_APPLIED] = true; 2573 force->flag [FLAG_APPLIED] = true;
2741 2574
2742 insert (force); 2575 return insert (force);
2743} 2576}
2744 2577
2745void 2578void
2746object::play_sound (faceidx sound) const 2579object::play_sound (faceidx sound) const
2747{ 2580{
2748 if (!sound) 2581 if (!sound)
2749 return; 2582 return;
2750 2583
2751 if (flag [FLAG_REMOVED]) 2584 if (is_on_map ())
2585 map->play_sound (sound, x, y);
2586 else if (object *pl = in_player ())
2587 pl->contr->play_sound (sound);
2588}
2589
2590void
2591object::say_msg (const char *msg) const
2592{
2593 if (is_on_map ())
2594 map->say_msg (msg, x, y);
2595 else if (object *pl = in_player ())
2596 pl->contr->play_sound (sound);
2597}
2598
2599void
2600object::make_noise ()
2601{
2602 // we do not model noise in the map, so instead put
2603 // a temporary light into the noise source
2604 // could use the map instead, but that's less reliable for our
2605 // goal, which is to make invisibility a bit harder to exploit
2606
2607 // currently only works sensibly for players
2608 if (!is_player ())
2752 return; 2609 return;
2753 2610
2754 if (env) 2611 // find old force, or create new one
2755 { 2612 object *force = force_find (shstr_noise_force);
2756 if (object *pl = in_player ()) 2613
2757 pl->contr->play_sound (sound); 2614 if (force)
2758 } 2615 force->speed_left = -1.f; // patch old speed up
2759 else 2616 else
2760 map->play_sound (sound, x, y); 2617 {
2761} 2618 force = archetype::get (shstr_noise_force);
2762 2619
2620 force->slaying = shstr_noise_force;
2621 force->stats.food = 1;
2622 force->speed_left = -1.f;
2623
2624 force->set_speed (1.f / 4.f);
2625 force->flag [FLAG_IS_USED_UP] = true;
2626 force->flag [FLAG_APPLIED] = true;
2627
2628 insert (force);
2629 }
2630}
2631

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines