ViewVC Help

View File | Revision Log | Show Annotations | Download File

/cvs/deliantra/server/common/object.C

Comparing deliantra/server/common/object.C (file contents):
Revision 1.202 by root, Thu Apr 10 15:35:15 2008 UTC vs.
Revision 1.242 by elmex, Wed May 7 21:00:02 2008 UTC

1	/*	1	/*
2	* This file is part of Deliantra, the Roguelike Realtime MMORPG.	2	* This file is part of Deliantra, the Roguelike Realtime MMORPG.
3	*	3	*
4	* Copyright (©) 2005,2006,2007 Marc Alexander Lehmann / Robin Redeker / the Deliantra team	4	* Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5	* Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team	5	* Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team
6	* Copyright (©) 1992,2007 Frank Tore Johansen	6	* Copyright (©) 1992,2007 Frank Tore Johansen
7	*	7	*
8	* Deliantra is free software: you can redistribute it and/or modify	8	* Deliantra is free software: you can redistribute it and/or modify
9	* it under the terms of the GNU General Public License as published by	9	* it under the terms of the GNU General Public License as published by
…		…
19	* along with this program. If not, see <http://www.gnu.org/licenses/>.	19	* along with this program. If not, see <http://www.gnu.org/licenses/>.
20	*	20	*
21	* The authors can be reached via e-mail to <support@deliantra.net>	21	* The authors can be reached via e-mail to <support@deliantra.net>
22	*/	22	*/
23		23
24	/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
25	sub/add_weight will transcend the environment updating the carrying
26	variable. */
27	#include <global.h>	24	#include <global.h>
28	#include <stdio.h>	25	#include <stdio.h>
29	#include <sys/types.h>	26	#include <sys/types.h>
30	#include <sys/uio.h>	27	#include <sys/uio.h>
31	#include <object.h>	28	#include <object.h>
32	#include <funcpoint.h>
33	#include <sproto.h>	29	#include <sproto.h>
34	#include <loader.h>	30	#include <loader.h>
35		31
36	#include <bitset>	32	#include <bitset>
37		33
38	UUID UUID::cur;	34	UUID UUID::cur;
		35	static uint64_t seq_next_save;
39	static const uint64 UUID_SKIP = 1<<19;	36	static const uint64 UUID_GAP = 1<<19;
40		37
41	objectvec objects;	38	objectvec objects;
42	activevec actives;	39	activevec actives;
43		40
44	short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,	41	short freearr_x[SIZEOFFREE] = {
		42	0,
		43	0, 1, 1, 1, 0, -1, -1, -1,
		44	0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
45	0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1	45	0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1
46	};	46	};
47	short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,	47	short freearr_y[SIZEOFFREE] = {
		48	0,
		49	-1, -1, 0, 1, 1, 1, 0, -1,
		50	-2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
48	-3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3	51	-3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3
49	};	52	};
50	int maxfree[SIZEOFFREE] = { 0, 9, 10, 13, 14, 17, 18, 21, 22, 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45,	53	int maxfree[SIZEOFFREE] = {
		54	0,
		55	9, 10, 13, 14, 17, 18, 21, 22,
		56	25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
51	48, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49	57	49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
52	};	58	};
53	int freedir[SIZEOFFREE] = {	59	int freedir[SIZEOFFREE] = {
54	0, 1, 2, 3, 4, 5, 6, 7, 8, 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,	60	0,
		61	1, 2, 3, 4, 5, 6, 7, 8,
		62	1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,
55	1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8	63	1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8
56	};	64	};
57		65
58	static void	66	static void
59	write_uuid (void)	67	write_uuid (uval64 skip, bool sync)
60	{	68	{
61	char filename1[MAX_BUF], filename2[MAX_BUF];	69	CALL_BEGIN (2);
62		70	CALL_ARG_SV (newSVval64 (skip));
63	sprintf (filename1, "%s/uuid", settings.localdir);	71	CALL_ARG_SV (boolSV (sync));
64	sprintf (filename2, "%s/uuid~", settings.localdir);	72	CALL_CALL ("cf::write_uuid", G_DISCARD);
65		73	CALL_END;
66	FILE *fp;
67
68	if (!(fp = fopen (filename2, "w")))
69	{
70	LOG (llevError, "ERROR: cannot open %s for writing, unable to write UUID!\n", filename2);
71	return;
72	}
73
74	fprintf (fp, "<1,%llx>\n", (unsigned long long)UUID::cur.seq + UUID_SKIP * 2);
75	fclose (fp);
76	rename (filename2, filename1);
77	}	74	}
78		75
79	static void	76	static void
80	read_uuid (void)	77	read_uuid (void)
81	{	78	{
82	char filename[MAX_BUF];	79	char filename[MAX_BUF];
83		80
84	sprintf (filename, "%s/uuid", settings.localdir);	81	sprintf (filename, "%s/uuid", settings.localdir);
		82
		83	seq_next_save = 0;
85		84
86	FILE *fp;	85	FILE *fp;
87		86
88	if (!(fp = fopen (filename, "r")))	87	if (!(fp = fopen (filename, "r")))
89	{	88	{
90	if (errno == ENOENT)	89	if (errno == ENOENT)
91	{	90	{
92	LOG (llevInfo, "RESET uid to 1\n");	91	LOG (llevInfo, "RESET uid to 1\n");
93	UUID::cur.seq = 0;	92	UUID::cur.seq = 0;
94	write_uuid ();	93	write_uuid (UUID_GAP, true);
95	return;	94	return;
96	}	95	}
97		96
98	LOG (llevError, "FATAL: cannot open %s for reading!\n", filename);	97	LOG (llevError, "FATAL: cannot open %s for reading!\n", filename);
99	_exit (1);	98	_exit (1);
100	}	99	}
101		100
102	int version;	101	UUID::BUF buf;
103	unsigned long long uid;	102	buf[0] = 0;
104	if (2 != fscanf (fp, "<%d,%llx>\n", &version, &uid) || version != 1)	103	fgets (buf, sizeof (buf), fp);
		104
		105	if (!UUID::cur.parse (buf))
105	{	106	{
106	LOG (llevError, "FATAL: error reading uid from %s!\n", filename);	107	LOG (llevError, "FATAL: error reading uid from %s (%s)!\n", filename, buf);
107	_exit (1);	108	_exit (1);
108	}	109	}
109		110
110	UUID::cur.seq = uid;	111	LOG (llevDebug, "read UUID: %s\n", UUID::cur.c_str ());
111	write_uuid ();	112
112	LOG (llevDebug, "read UID: %" PRId64 "\n", uid);	113	write_uuid (UUID_GAP, true);
113	fclose (fp);	114	fclose (fp);
114	}	115	}
115		116
116	UUID	117	UUID
117	UUID::gen ()	118	UUID::gen ()
118	{	119	{
119	UUID uid;	120	UUID uid;
120		121
121	uid.seq = ++cur.seq;	122	uid.seq = ++cur.seq;
122		123
123	if (!(cur.seq & (UUID_SKIP - 1)))	124	if (expect_false (cur.seq >= seq_next_save))
124	write_uuid ();	125	{
		126	seq_next_save = UUID::cur.seq + (UUID_GAP >> 1);
		127	write_uuid (UUID_GAP, false);
		128	}
		129
125		130
126	return uid;	131	return uid;
127	}	132	}
128		133
129	void	134	void
…		…
131	{	136	{
132	read_uuid ();	137	read_uuid ();
133	}	138	}
134		139
135	/* Returns TRUE if every key_values in wants has a partner with the same value in has. */	140	/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
136	static int	141	static bool
137	compare_ob_value_lists_one (const object *wants, const object *has)	142	compare_ob_value_lists_one (const object *wants, const object *has)
138	{	143	{
139	key_value *wants_field;
140
141	/* n-squared behaviour (see get_ob_key_link()), but I'm hoping both	144	/* n-squared behaviour (see kv_get), but I'm hoping both
142	* objects with lists are rare, and lists stay short. If not, use a	145	* objects with lists are rare, and lists stay short. If not, use a
143	* different structure or at least keep the lists sorted...	146	* different structure or at least keep the lists sorted...
144	*/	147	*/
145		148
146	/* For each field in wants, */	149	/* For each field in wants, */
147	for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)	150	for (key_value *kv = wants->key_values; kv; kv = kv->next)
148	{	151	if (has->kv_get (kv->key) != kv->value)
149	key_value *has_field;	152	return false;
150
151	/* Look for a field in has with the same key. */
152	has_field = get_ob_key_link (has, wants_field->key);
153
154	if (has_field == NULL)
155	{
156	/* No field with that name. */
157	return FALSE;
158	}
159
160	/* Found the matching field. */
161	if (has_field->value != wants_field->value)
162	{
163	/* Values don't match, so this half of the comparison is false. */
164	return FALSE;
165	}
166
167	/* If we get here, we found a match. Now for the next field in wants. */
168	}
169		153
170	/* If we get here, every field in wants has a matching field in has. */	154	/* If we get here, every field in wants has a matching field in has. */
171	return TRUE;	155	return true;
172	}	156	}
173		157
174	/* Returns TRUE if ob1 has the same key_values as ob2. */	158	/* Returns TRUE if ob1 has the same key_values as ob2. */
175	static int	159	static bool
176	compare_ob_value_lists (const object *ob1, const object *ob2)	160	compare_ob_value_lists (const object *ob1, const object *ob2)
177	{	161	{
178	/* However, there may be fields in has which aren't partnered in wants,	162	/* However, there may be fields in has which aren't partnered in wants,
179	* so we need to run the comparison *twice*. :(	163	* so we need to run the comparison *twice*. :(
180	*/	164	*/
181	return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1);	165	return compare_ob_value_lists_one (ob1, ob2)
		166	&& compare_ob_value_lists_one (ob2, ob1);
182	}	167	}
183		168
184	/* Function examines the 2 objects given to it, and returns true if	169	/* Function examines the 2 objects given to it, and returns true if
185	* they can be merged together.	170	* they can be merged together.
186	*	171	*
…		…
201	|| ob1->speed != ob2->speed	186	|| ob1->speed != ob2->speed
202	|| ob1->value != ob2->value	187	|| ob1->value != ob2->value
203	|| ob1->name != ob2->name)	188	|| ob1->name != ob2->name)
204	return 0;	189	return 0;
205		190
206	//TODO: this ain't working well, use nicer and correct overflow check	191	/* Do not merge objects if nrof would overflow. First part checks
207	/* Do not merge objects if nrof would overflow. We use 1UL<<31 since that	192	* for unsigned overflow (2c), second part checks whether the result
208	* value could not be stored in a sint32 (which unfortunately sometimes is	193	* would fit into a 32 bit signed int, which is often used to hold
209	* used to store nrof).	194	* nrof values.
210	*/	195	*/
211	if (ob1->nrof + ob2->nrof >= 1UL << 31)	196	if (~ob1->nrof < ob2->nrof || ob1->nrof + ob2->nrof > (1UL << 31))
212	return 0;	197	return 0;
213		198
214	/* If the objects have been identified, set the BEEN_APPLIED flag.	199	/* If the objects have been identified, set the BEEN_APPLIED flag.
215	* This is to the comparison of the flags below will be OK. We	200	* This is to the comparison of the flags below will be OK. We
216	* just can't ignore the been applied or identified flags, as they	201	* just can't ignore the been applied or identified flags, as they
217	* are not equal - just if it has been identified, the been_applied	202	* are not equal - just if it has been identified, the been_applied
218	* flags lose any meaning.	203	* flags lose any meaning.
219	*/	204	*/
220	if (QUERY_FLAG (ob1, FLAG_IDENTIFIED))	205	if (QUERY_FLAG (ob1, FLAG_IDENTIFIED))
221	SET_FLAG (ob1, FLAG_BEEN_APPLIED);	206	SET_FLAG (ob1, FLAG_BEEN_APPLIED);
222		207
223	if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))	208	if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
224	SET_FLAG (ob2, FLAG_BEEN_APPLIED);	209	SET_FLAG (ob2, FLAG_BEEN_APPLIED);
225		210
226	if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any ()	211	if (ob1->arch->name != ob2->arch->name
227	|| ob1->arch != ob2->arch
228	|| ob1->name != ob2->name	212	|| ob1->name != ob2->name
229	|| ob1->title != ob2->title	213	|| ob1->title != ob2->title
230	|| ob1->msg != ob2->msg	214	|| ob1->msg != ob2->msg
231	|| ob1->weight != ob2->weight	215	|| ob1->weight != ob2->weight
232	|| memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
233	|| memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
234	|| ob1->attacktype != ob2->attacktype	216	|| ob1->attacktype != ob2->attacktype
235	|| ob1->magic != ob2->magic	217	|| ob1->magic != ob2->magic
236	|| ob1->slaying != ob2->slaying	218	|| ob1->slaying != ob2->slaying
237	|| ob1->skill != ob2->skill	219	|| ob1->skill != ob2->skill
238	|| ob1->value != ob2->value	220	|| ob1->value != ob2->value
…		…
245	|| ob1->move_block != ob2->move_block	227	|| ob1->move_block != ob2->move_block
246	|| ob1->move_allow != ob2->move_allow	228	|| ob1->move_allow != ob2->move_allow
247	|| ob1->move_on != ob2->move_on	229	|| ob1->move_on != ob2->move_on
248	|| ob1->move_off != ob2->move_off	230	|| ob1->move_off != ob2->move_off
249	|| ob1->move_slow != ob2->move_slow	231	|| ob1->move_slow != ob2->move_slow
250	|| ob1->move_slow_penalty != ob2->move_slow_penalty)	232	|| ob1->move_slow_penalty != ob2->move_slow_penalty
		233	|| memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
		234	|| memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
251	return 0;	235	return 0;
252		236
		237	if ((ob1->flag ^ ob2->flag)
		238	.reset (FLAG_INV_LOCKED)
		239	.reset (FLAG_CLIENT_SENT)
		240	.reset (FLAG_REMOVED)
		241	.any ())
		242	return 0;
		243
253	/* This is really a spellbook check - really, we should	244	/* This is really a spellbook check - we should in general
254	* check all objects in the inventory.	245	* not merge objects with real inventories, as splitting them
		246	* is hard.
255	*/	247	*/
256	if (ob1->inv || ob2->inv)	248	if (ob1->inv || ob2->inv)
257	{	249	{
258	if (!(ob1->inv && ob2->inv))	250	if (!(ob1->inv && ob2->inv))
259	return 0; /* inventories differ in length */	251	return 0; /* inventories differ in length */
260		252
261	if (ob1->inv->below || ob2->inv->below)	253	if (ob1->inv->below || ob2->inv->below)
262	return 0; /* more than one object in inv */	254	return 0; /* more than one object in inv */
263		255
264	if (!object::can_merge (ob1->inv, ob2->inv))	256	if (!object::can_merge (ob1->inv, ob2->inv))
265	return 0; /* inventory objexts differ */	257	return 0; /* inventory objects differ */
266		258
267	/* inventory ok - still need to check rest of this object to see	259	/* inventory ok - still need to check rest of this object to see
268	* if it is valid.	260	* if it is valid.
269	*/	261	*/
270	}	262	}
…		…
289	if (ob1->level != ob2->level)	281	if (ob1->level != ob2->level)
290	return 0;	282	return 0;
291	break;	283	break;
292	}	284	}
293		285
294	if (ob1->key_values != NULL || ob2->key_values != NULL)	286	if (ob1->key_values || ob2->key_values)
295	{	287	{
296	/* At least one of these has key_values. */	288	/* At least one of these has key_values. */
297	if ((ob1->key_values == NULL) != (ob2->key_values == NULL))	289	if ((!ob1->key_values) != (!ob2->key_values))
298	/* One has fields, but the other one doesn't. */	290	return 0; /* One has fields, but the other one doesn't. */
299	return 0;	291
300	else if (!compare_ob_value_lists (ob1, ob2))	292	if (!compare_ob_value_lists (ob1, ob2))
301	return 0;	293	return 0;
302	}	294	}
303		295
304	if (ob1->self || ob2->self)	296	if (ob1->self || ob2->self)
305	{	297	{
…		…
311	int k1 = ob1->self ? HvTOTALKEYS (ob1->self) : 0;	303	int k1 = ob1->self ? HvTOTALKEYS (ob1->self) : 0;
312	int k2 = ob2->self ? HvTOTALKEYS (ob2->self) : 0;	304	int k2 = ob2->self ? HvTOTALKEYS (ob2->self) : 0;
313		305
314	if (k1 != k2)	306	if (k1 != k2)
315	return 0;	307	return 0;
		308
316	else if (k1 == 0)	309	if (k1 == 0)
317	return 1;	310	return 1;
		311
318	else if (!cfperl_can_merge (ob1, ob2))	312	if (!cfperl_can_merge (ob1, ob2))
319	return 0;	313	return 0;
320	}	314	}
321	}	315	}
322		316
323	/* Everything passes, must be OK. */	317	/* Everything passes, must be OK. */
324	return 1;	318	return 1;
325	}	319	}
326		320
		321	// find player who can see this object
		322	object *
		323	object::visible_to () const
		324	{
		325	if (client_visible () && !flag [FLAG_REMOVED])
		326	{
		327	// see if we are in a container of sorts
		328	if (env)
		329	{
		330	// the player inventory itself is always visible
		331	if (env->type == PLAYER)
		332	return env;
		333
		334	// else a player could have our env open
		335	object *envest = env->outer_env ();
		336
		337	// the player itself is always on a map, so we will find him here
		338	// even if our inv is in a player.
		339	if (envest->is_on_map ())
		340	if (object *pl = envest->ms ().player ())
		341	if (pl->container == env)
		342	return pl;
		343	}
		344	else
		345	{
		346	// maybe there is a player standing on the same mapspace
		347	// this will catch the case where "this" is a player
		348	if (object *pl = ms ().player ())
		349	if (!pl->container || this == pl->container)
		350	return pl;
		351	}
		352	}
		353
		354	return 0;
		355	}
		356
		357	// adjust weight per container type ("of holding")
		358	static sint32
		359	weight_adjust_for (object *op, sint32 weight)
		360	{
		361	return op->type == CONTAINER
		362	? lerp (weight, 0, 100, 0, 100 - op->stats.Str)
		363	: weight;
		364	}
		365
327	/*	366	/*
		367	* adjust_weight(object, weight) adds the specified weight to an object,
		368	* and also updates how much the environment(s) is/are carrying.
		369	*/
		370	static void
		371	adjust_weight (object *op, sint32 weight)
		372	{
		373	while (op)
		374	{
		375	// adjust by actual difference to account for rounding errors
		376	// i.e. (w2 - w1) / f != w2 / f - w1 / f and the latter is correct
		377	weight = weight_adjust_for (op, op->carrying)
		378	- weight_adjust_for (op, op->carrying - weight);
		379
		380	if (!weight)
		381	return;
		382
		383	op->carrying += weight;
		384
		385	if (object *pl = op->visible_to ())
		386	if (pl != op) // player is handled lazily
		387	esrv_update_item (UPD_WEIGHT, pl, op);
		388
		389	op = op->env;
		390	}
		391	}
		392
		393	/*
328	* sum_weight() is a recursive function which calculates the weight	394	* this is a recursive function which calculates the weight
329	* an object is carrying. It goes through in figures out how much	395	* an object is carrying. It goes through op and figures out how much
330	* containers are carrying, and sums it up.	396	* containers are carrying, and sums it up.
331	*/	397	*/
332	long	398	void
333	sum_weight (object *op)	399	object::update_weight ()
334	{	400	{
335	long sum;	401	sint32 sum = 0;
336	object *inv;
337		402
338	for (sum = 0, inv = op->inv; inv; inv = inv->below)	403	for (object *op = inv; op; op = op->below)
339	{	404	{
340	if (inv->inv)	405	if (op->inv)
341	sum_weight (inv);	406	op->update_weight ();
342		407
343	sum += inv->carrying + inv->weight * (inv->nrof ? inv->nrof : 1);	408	sum += op->total_weight ();
		409	}
		410
		411	sum = weight_adjust_for (this, sum);
		412
		413	if (sum != carrying)
344	}	414	{
345
346	if (op->type == CONTAINER && op->stats.Str)
347	sum = (sum * (100 - op->stats.Str)) / 100;
348
349	if (op->carrying != sum)
350	op->carrying = sum;	415	carrying = sum;
351		416
352	return sum;	417	if (object *pl = visible_to ())
		418	if (pl != this) // player is handled lazily
		419	esrv_update_item (UPD_WEIGHT, pl, this);
		420	}
353	}	421	}
354		422
355	/**	423	/*
356	* Return the outermost environment object for a given object.	424	* Used by: Server DM commands: dumpbelow, dump. Some error messages.
357	*/
358
359	object *
360	object_get_env_recursive (object *op)
361	{
362	while (op->env != NULL)
363	op = op->env;
364	return op;
365	}
366
367	/*
368	* Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
369	* Some error messages.
370	* The result of the dump is stored in the static global errmsg array.
371	*/	425	*/
372	char *	426	char *
373	dump_object (object *op)	427	dump_object (object *op)
374	{	428	{
375	if (!op)	429	if (!op)
…		…
389	get_nearest_part (object *op, const object *pl)	443	get_nearest_part (object *op, const object *pl)
390	{	444	{
391	object *tmp, *closest;	445	object *tmp, *closest;
392	int last_dist, i;	446	int last_dist, i;
393		447
394	if (op->more == NULL)	448	if (!op->more)
395	return op;	449	return op;
		450
396	for (last_dist = distance (op, pl), closest = op, tmp = op->more; tmp != NULL; tmp = tmp->more)	451	for (last_dist = distance (op, pl), closest = op, tmp = op->more;
		452	tmp;
		453	tmp = tmp->more)
397	if ((i = distance (tmp, pl)) < last_dist)	454	if ((i = distance (tmp, pl)) < last_dist)
398	closest = tmp, last_dist = i;	455	closest = tmp, last_dist = i;
		456
399	return closest;	457	return closest;
400	}	458	}
401		459
402	/*	460	/*
403	* Returns the object which has the count-variable equal to the argument.	461	* Returns the object which has the count-variable equal to the argument.
		462	* VERRRY slow.
404	*/	463	*/
405	object *	464	object *
406	find_object (tag_t i)	465	find_object (tag_t i)
407	{	466	{
408	for_all_objects (op)	467	for_all_objects (op)
…		…
533	}	592	}
534		593
535	op->key_values = 0;	594	op->key_values = 0;
536	}	595	}
537		596
538	object &	597	/*
539	object::operator =(const object &src)	598	* copy_to first frees everything allocated by the dst object,
		599	* and then copies the contents of itself into the second
		600	* object, allocating what needs to be allocated. Basically, any
		601	* data that is malloc'd needs to be re-malloc/copied. Otherwise,
		602	* if the first object is freed, the pointers in the new object
		603	* will point at garbage.
		604	*/
		605	void
		606	object::copy_to (object *dst)
540	{	607	{
541	bool is_freed = flag [FLAG_FREED];	608	dst->remove ();
542	bool is_removed = flag [FLAG_REMOVED];
543
544	*(object_copy *)this = src;	609	*(object_copy *)dst = *this;
545
546	flag [FLAG_FREED] = is_freed;
547	flag [FLAG_REMOVED] = is_removed;	610	dst->flag [FLAG_REMOVED] = true;
548		611
549	/* Copy over key_values, if any. */	612	/* Copy over key_values, if any. */
550	if (src.key_values)	613	if (key_values)
551	{	614	{
552	key_value *tail = 0;	615	key_value *tail = 0;
553	key_values = 0;	616	dst->key_values = 0;
554		617
555	for (key_value *i = src.key_values; i; i = i->next)	618	for (key_value *i = key_values; i; i = i->next)
556	{	619	{
557	key_value *new_link = new key_value;	620	key_value *new_link = new key_value;
558		621
559	new_link->next = 0;	622	new_link->next = 0;
560	new_link->key = i->key;	623	new_link->key = i->key;
561	new_link->value = i->value;	624	new_link->value = i->value;
562		625
563	/* Try and be clever here, too. */	626	/* Try and be clever here, too. */
564	if (!key_values)	627	if (!dst->key_values)
565	{	628	{
566	key_values = new_link;	629	dst->key_values = new_link;
567	tail = new_link;	630	tail = new_link;
568	}	631	}
569	else	632	else
570	{	633	{
571	tail->next = new_link;	634	tail->next = new_link;
572	tail = new_link;	635	tail = new_link;
573	}	636	}
574	}	637	}
575	}	638	}
576	}
577
578	/*
579	* copy_to first frees everything allocated by the dst object,
580	* and then copies the contents of itself into the second
581	* object, allocating what needs to be allocated. Basically, any
582	* data that is malloc'd needs to be re-malloc/copied. Otherwise,
583	* if the first object is freed, the pointers in the new object
584	* will point at garbage.
585	*/
586	void
587	object::copy_to (object *dst)
588	{
589	*dst = *this;
590		639
591	if (speed < 0)	640	if (speed < 0)
592	dst->speed_left -= rndm ();	641	dst->speed_left -= rndm ();
593		642
594	dst->set_speed (dst->speed);	643	dst->set_speed (dst->speed);
…		…
616	object *	665	object *
617	object::clone ()	666	object::clone ()
618	{	667	{
619	object *neu = create ();	668	object *neu = create ();
620	copy_to (neu);	669	copy_to (neu);
		670	neu->map = map; // not copied by copy_to
621	return neu;	671	return neu;
622	}	672	}
623		673
624	/*	674	/*
625	* If an object with the IS_TURNABLE() flag needs to be turned due	675	* If an object with the IS_TURNABLE() flag needs to be turned due
…		…
676	* UP_OBJ_FACE: only the objects face has changed.	726	* UP_OBJ_FACE: only the objects face has changed.
677	*/	727	*/
678	void	728	void
679	update_object (object *op, int action)	729	update_object (object *op, int action)
680	{	730	{
681	if (op == NULL)	731	if (!op)
682	{	732	{
683	/* this should never happen */	733	/* this should never happen */
684	LOG (llevDebug, "update_object() called for NULL object.\n");	734	LOG (llevError | logBacktrace, "update_object() called for NULL object.\n");
685	return;	735	return;
686	}	736	}
687		737
688	if (op->env)	738	if (!op->is_on_map ())
689	{	739	{
690	/* Animation is currently handled by client, so nothing	740	/* Animation is currently handled by client, so nothing
691	* to do in this case.	741	* to do in this case.
692	*/	742	*/
693	return;	743	return;
694	}	744	}
695
696	/* If the map is saving, don't do anything as everything is
697	* going to get freed anyways.
698	*/
699	if (!op->map || op->map->in_memory == MAP_SAVING)
700	return;
701		745
702	/* make sure the object is within map boundaries */	746	/* make sure the object is within map boundaries */
703	if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)	747	if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
704	{	748	{
705	LOG (llevError, "update_object() called for object out of map!\n");	749	LOG (llevError, "update_object() called for object out of map!\n");
…		…
848	object::destroy_inv (bool drop_to_ground)	892	object::destroy_inv (bool drop_to_ground)
849	{	893	{
850	// need to check first, because the checks below might segfault	894	// need to check first, because the checks below might segfault
851	// as we might be on an invalid mapspace and crossfire code	895	// as we might be on an invalid mapspace and crossfire code
852	// is too buggy to ensure that the inventory is empty.	896	// is too buggy to ensure that the inventory is empty.
853	// corollary: if you create arrows etc. with stuff in tis inventory,	897	// corollary: if you create arrows etc. with stuff in its inventory,
854	// cf will crash below with off-map x and y	898	// cf will crash below with off-map x and y
855	if (!inv)	899	if (!inv)
856	return;	900	return;
857		901
858	/* Only if the space blocks everything do we not process -	902	/* Only if the space blocks everything do we not process -
859	* if some form of movement is allowed, let objects	903	* if some form of movement is allowed, let objects
860	* drop on that space.	904	* drop on that space.
861	*/	905	*/
862	if (!drop_to_ground	906	if (!drop_to_ground
863	|| !map	907	|| !map
864	|| map->in_memory != MAP_IN_MEMORY	908	|| map->in_memory != MAP_ACTIVE
865	|| map->nodrop	909	|| map->no_drop
866	|| ms ().move_block == MOVE_ALL)	910	|| ms ().move_block == MOVE_ALL)
867	{	911	{
868	while (inv)	912	while (inv)
869	{	913	{
870	inv->destroy_inv (drop_to_ground);	914	inv->destroy_inv (false);
871	inv->destroy ();	915	inv->destroy ();
872	}	916	}
873	}	917	}
874	else	918	else
875	{ /* Put objects in inventory onto this space */	919	{ /* Put objects in inventory onto this space */
…		…
881	|| op->flag [FLAG_NO_DROP]	925	|| op->flag [FLAG_NO_DROP]
882	|| op->type == RUNE	926	|| op->type == RUNE
883	|| op->type == TRAP	927	|| op->type == TRAP
884	|| op->flag [FLAG_IS_A_TEMPLATE]	928	|| op->flag [FLAG_IS_A_TEMPLATE]
885	|| op->flag [FLAG_DESTROY_ON_DEATH])	929	|| op->flag [FLAG_DESTROY_ON_DEATH])
886	op->destroy ();	930	op->destroy (true);
887	else	931	else
888	map->insert (op, x, y);	932	map->insert (op, x, y);
889	}	933	}
890	}	934	}
891	}	935	}
…		…
895	object *op = new object;	939	object *op = new object;
896	op->link ();	940	op->link ();
897	return op;	941	return op;
898	}	942	}
899		943
		944	static struct freed_map : maptile
		945	{
		946	freed_map ()
		947	{
		948	path = "<freed objects map>";
		949	name = "/internal/freed_objects_map";
		950	width = 3;
		951	height = 3;
		952	no_drop = 1;
		953	no_reset = 1;
		954
		955	alloc ();
		956	in_memory = MAP_ACTIVE;
		957	}
		958
		959	~freed_map ()
		960	{
		961	destroy ();
		962	}
		963	} freed_map; // freed objects are moved here to avoid crashes
		964
900	void	965	void
901	object::do_destroy ()	966	object::do_destroy ()
902	{	967	{
903	attachable::do_destroy ();
904
905	if (flag [FLAG_IS_LINKED])	968	if (flag [FLAG_IS_LINKED])
906	remove_button_link (this);	969	remove_button_link (this);
907		970
908	if (flag [FLAG_FRIENDLY])	971	if (flag [FLAG_FRIENDLY])
909	remove_friendly_object (this);	972	remove_friendly_object (this);
910		973
911	if (!flag [FLAG_REMOVED])
912	remove ();	974	remove ();
913		975
914	destroy_inv (true);	976	attachable::do_destroy ();
915		977
916	deactivate ();	978	deactivate ();
917	unlink ();	979	unlink ();
918		980
919	flag [FLAG_FREED] = 1;	981	flag [FLAG_FREED] = 1;
920		982
921	// hack to ensure that freed objects still have a valid map	983	// hack to ensure that freed objects still have a valid map
922	{
923	static maptile *freed_map; // freed objects are moved here to avoid crashes
924
925	if (!freed_map)
926	{
927	freed_map = new maptile;
928
929	freed_map->path = "<freed objects map>";
930	freed_map->name = "/internal/freed_objects_map";
931	freed_map->width = 3;
932	freed_map->height = 3;
933	freed_map->nodrop = 1;
934
935	freed_map->alloc ();
936	freed_map->in_memory = MAP_IN_MEMORY;
937	}
938
939	map = freed_map;	984	map = &freed_map;
940	x = 1;	985	x = 1;
941	y = 1;	986	y = 1;
942	}
943		987
944	if (more)	988	if (more)
945	{	989	{
946	more->destroy ();	990	more->destroy ();
947	more = 0;	991	more = 0;
…		…
960	object::destroy (bool destroy_inventory)	1004	object::destroy (bool destroy_inventory)
961	{	1005	{
962	if (destroyed ())	1006	if (destroyed ())
963	return;	1007	return;
964		1008
		1009	if (!is_head () && !head->destroyed ())
		1010	{
		1011	LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
		1012	head->destroy (destroy_inventory);
		1013	return;
		1014	}
		1015
965	if (destroy_inventory)	1016	destroy_inv (!destroy_inventory);
966	destroy_inv (false);
967		1017
968	if (is_head ())	1018	if (is_head ())
969	if (sound_destroy)	1019	if (sound_destroy)
970	play_sound (sound_destroy);	1020	play_sound (sound_destroy);
971	else if (flag [FLAG_MONSTER])	1021	else if (flag [FLAG_MONSTER])
972	play_sound (sound_find ("monster_destroy")); // quick hack, too lazy to create a generic mechanism	1022	play_sound (sound_find ("monster_destroy")); // quick hack, too lazy to create a generic mechanism
973		1023
974	attachable::destroy ();	1024	attachable::destroy ();
975	}
976
977	/*
978	* sub_weight() recursively (outwards) subtracts a number from the
979	* weight of an object (and what is carried by it's environment(s)).
980	*/
981	void
982	sub_weight (object *op, signed long weight)
983	{
984	while (op != NULL)
985	{
986	if (op->type == CONTAINER)
987	weight = (signed long) (weight * (100 - op->stats.Str) / 100);
988
989	op->carrying -= weight;
990	op = op->env;
991	}
992	}	1025	}
993		1026
994	/* op->remove ():	1027	/* op->remove ():
995	* This function removes the object op from the linked list of objects	1028	* This function removes the object op from the linked list of objects
996	* which it is currently tied to. When this function is done, the	1029	* which it is currently tied to. When this function is done, the
…		…
1002	object::do_remove ()	1035	object::do_remove ()
1003	{	1036	{
1004	object *tmp, *last = 0;	1037	object *tmp, *last = 0;
1005	object *otmp;	1038	object *otmp;
1006		1039
1007	if (QUERY_FLAG (this, FLAG_REMOVED))	1040	if (flag [FLAG_REMOVED])
1008	return;	1041	return;
1009		1042
1010	SET_FLAG (this, FLAG_REMOVED);
1011	INVOKE_OBJECT (REMOVE, this);	1043	INVOKE_OBJECT (REMOVE, this);
		1044
		1045	flag [FLAG_REMOVED] = true;
1012		1046
1013	if (more)	1047	if (more)
1014	more->remove ();	1048	more->remove ();
1015		1049
1016	/*	1050	/*
1017	* In this case, the object to be removed is in someones	1051	* In this case, the object to be removed is in someones
1018	* inventory.	1052	* inventory.
1019	*/	1053	*/
1020	if (env)	1054	if (env)
1021	{	1055	{
1022	if (nrof)	1056	flag [FLAG_REMOVED] = false; // hack around the issue of visible_to checking flag_removed
1023	sub_weight (env, weight * nrof);	1057	if (object *pl = visible_to ())
1024	else	1058	esrv_del_item (pl->contr, count);
1025	sub_weight (env, weight + carrying);	1059	flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
		1060
		1061	adjust_weight (env, -total_weight ());
		1062
		1063	/* we set up values so that it could be inserted into
		1064	* the map, but we don't actually do that - it is up
		1065	* to the caller to decide what we want to do.
		1066	*/
		1067	map = env->map;
		1068	x = env->x;
		1069	y = env->y;
		1070
		1071	// make sure cmov optimisation is applicable
		1072	*(above ? &above->below : &env->inv) = below;
		1073	*(below ? &below->above : &above ) = above; // &above is just a dummy
		1074
		1075	above = 0;
		1076	below = 0;
		1077	env = 0;
1026		1078
1027	/* NO_FIX_PLAYER is set when a great many changes are being	1079	/* NO_FIX_PLAYER is set when a great many changes are being
1028	* made to players inventory. If set, avoiding the call	1080	* made to players inventory. If set, avoiding the call
1029	* to save cpu time.	1081	* to save cpu time.
1030	*/	1082	*/
1031	if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))	1083	if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1032	otmp->update_stats ();	1084	otmp->update_stats ();
1033
1034	if (above)
1035	above->below = below;
1036	else
1037	env->inv = below;
1038
1039	if (below)
1040	below->above = above;
1041
1042	/* we set up values so that it could be inserted into
1043	* the map, but we don't actually do that - it is up
1044	* to the caller to decide what we want to do.
1045	*/
1046	x = env->x, y = env->y;
1047	map = env->map;
1048	above = 0, below = 0;
1049	env = 0;
1050	}	1085	}
1051	else if (map)	1086	else if (map)
1052	{	1087	{
1053	if (type == PLAYER)
1054	{
1055	// leaving a spot always closes any open container on the ground
1056	if (container && !container->env)
1057	// this causes spurious floorbox updates, but it ensures
1058	// that the CLOSE event is being sent.
1059	close_container ();
1060
1061	--map->players;
1062	map->touch ();
1063	}
1064
1065	map->dirty = true;	1088	map->dirty = true;
1066	mapspace &ms = this->ms ();	1089	mapspace &ms = this->ms ();
1067		1090
		1091	if (object *pl = ms.player ())
		1092	{
		1093	if (type == PLAYER) // this == pl(!)
		1094	{
		1095	// leaving a spot always closes any open container on the ground
		1096	if (container && !container->env)
		1097	// this causes spurious floorbox updates, but it ensures
		1098	// that the CLOSE event is being sent.
		1099	close_container ();
		1100
		1101	--map->players;
		1102	map->touch ();
		1103	}
		1104	else if (pl->container == this)
		1105	{
		1106	// removing a container should close it
		1107	close_container ();
		1108	}
		1109
		1110	esrv_del_item (pl->contr, count);
		1111	}
		1112
1068	/* link the object above us */	1113	/* link the object above us */
1069	if (above)	1114	// re-link, make sure compiler can easily use cmove
1070	above->below = below;	1115	*(above ? &above->below : &ms.top) = below;
1071	else	1116	*(below ? &below->above : &ms.bot) = above;
1072	ms.top = below; /* we were top, set new top */
1073
1074	/* Relink the object below us, if there is one */
1075	if (below)
1076	below->above = above;
1077	else
1078	{
1079	/* Nothing below, which means we need to relink map object for this space
1080	* use translated coordinates in case some oddness with map tiling is
1081	* evident
1082	*/
1083	if (GET_MAP_OB (map, x, y) != this)
1084	LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1085
1086	ms.bot = above; /* goes on above it. */
1087	}
1088		1117
1089	above = 0;	1118	above = 0;
1090	below = 0;	1119	below = 0;
1091		1120
1092	if (map->in_memory == MAP_SAVING)	1121	if (map->in_memory == MAP_SAVING)
…		…
1101	* removed (most likely destroyed), update the player view	1130	* removed (most likely destroyed), update the player view
1102	* appropriately.	1131	* appropriately.
1103	*/	1132	*/
1104	pl->close_container ();	1133	pl->close_container ();
1105		1134
		1135	//TODO: the floorbox prev/next might need updating
		1136	//esrv_del_item (pl->contr, count);
		1137	//TODO: update floorbox to preserve ordering
		1138	if (pl->contr->ns)
1106	pl->contr->ns->floorbox_update ();	1139	pl->contr->ns->floorbox_update ();
1107	}	1140	}
1108		1141
1109	for (tmp = ms.bot; tmp; tmp = tmp->above)	1142	for (tmp = ms.bot; tmp; tmp = tmp->above)
1110	{	1143	{
1111	/* No point updating the players look faces if he is the object	1144	/* No point updating the players look faces if he is the object
…		…
1155	if (!top)	1188	if (!top)
1156	for (top = op; top && top->above; top = top->above)	1189	for (top = op; top && top->above; top = top->above)
1157	;	1190	;
1158		1191
1159	for (; top; top = top->below)	1192	for (; top; top = top->below)
1160	{
1161	if (top == op)
1162	continue;
1163
1164	if (object::can_merge (op, top))	1193	if (object::can_merge (op, top))
1165	{	1194	{
1166	top->nrof += op->nrof;	1195	top->nrof += op->nrof;
1167		1196
1168	/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/	1197	if (object *pl = top->visible_to ())
1169	op->weight = 0; /* Don't want any adjustements now */	1198	esrv_update_item (UPD_NROF, pl, top);
		1199
		1200	op->weight = 0; // cancel the addition above
		1201	op->carrying = 0; // must be 0 already
		1202
1170	op->destroy ();	1203	op->destroy (1);
		1204
1171	return top;	1205	return top;
1172	}	1206	}
1173	}
1174		1207
1175	return 0;	1208	return 0;
1176	}	1209	}
1177		1210
1178	void	1211	void
…		…
1235	* just 'op' otherwise	1268	* just 'op' otherwise
1236	*/	1269	*/
1237	object *	1270	object *
1238	insert_ob_in_map (object *op, maptile *m, object *originator, int flag)	1271	insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1239	{	1272	{
1240	assert (!op->flag [FLAG_FREED]);
1241
1242	object *top, *floor = NULL;
1243
1244	op->remove ();	1273	op->remove ();
1245		1274
1246	/* Ideally, the caller figures this out. However, it complicates a lot	1275	/* Ideally, the caller figures this out. However, it complicates a lot
1247	* of areas of callers (eg, anything that uses find_free_spot would now	1276	* of areas of callers (eg, anything that uses find_free_spot would now
1248	* need extra work	1277	* need extra work
1249	*/	1278	*/
1250	if (!xy_normalise (m, op->x, op->y))	1279	if (!xy_normalise (m, op->x, op->y))
1251	{	1280	{
1252	op->destroy ();	1281	op->head_ ()->destroy (1);// remove head_ once all tail object destroyers found
1253	return 0;	1282	return 0;
1254	}	1283	}
1255		1284
1256	if (object *more = op->more)	1285	if (object *more = op->more)
1257	if (!insert_ob_in_map (more, m, originator, flag))	1286	if (!insert_ob_in_map (more, m, originator, flag))
…		…
1266	*/	1295	*/
1267	if (op->nrof && !(flag & INS_NO_MERGE))	1296	if (op->nrof && !(flag & INS_NO_MERGE))
1268	for (object *tmp = ms.bot; tmp; tmp = tmp->above)	1297	for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1269	if (object::can_merge (op, tmp))	1298	if (object::can_merge (op, tmp))
1270	{	1299	{
		1300	// TODO: we actually want to update tmp, not op,
		1301	// but some caller surely breaks when we return tmp
		1302	// from here :/
1271	op->nrof += tmp->nrof;	1303	op->nrof += tmp->nrof;
1272	tmp->destroy ();	1304	tmp->destroy (1);
1273	}	1305	}
1274		1306
1275	CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */	1307	CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1276	CLEAR_FLAG (op, FLAG_INV_LOCKED);	1308	CLEAR_FLAG (op, FLAG_INV_LOCKED);
1277		1309
…		…
1284	{	1316	{
1285	LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");	1317	LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1286	abort ();	1318	abort ();
1287	}	1319	}
1288		1320
		1321	if (!originator->is_on_map ())
		1322	LOG (llevDebug | logBacktrace, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
		1323	op->debug_desc (), originator->debug_desc ());
		1324
1289	op->above = originator;	1325	op->above = originator;
1290	op->below = originator->below;	1326	op->below = originator->below;
1291
1292	if (op->below)
1293	op->below->above = op;
1294	else
1295	ms.bot = op;
1296
1297	/* since *below* originator, no need to update top */
1298	originator->below = op;	1327	originator->below = op;
		1328
		1329	*(op->below ? &op->below->above : &ms.bot) = op;
1299	}	1330	}
1300	else	1331	else
1301	{	1332	{
1302	top = ms.bot;	1333	object *floor = 0;
		1334	object *top = ms.top;
1303		1335
1304	/* If there are other objects, then */	1336	/* If there are other objects, then */
1305	if (top)	1337	if (top)
1306	{	1338	{
1307	object *last = 0;
1308
1309	/*	1339	/*
1310	* If there are multiple objects on this space, we do some trickier handling.	1340	* If there are multiple objects on this space, we do some trickier handling.
1311	* We've already dealt with merging if appropriate.	1341	* We've already dealt with merging if appropriate.
1312	* Generally, we want to put the new object on top. But if	1342	* Generally, we want to put the new object on top. But if
1313	* flag contains INS_ABOVE_FLOOR_ONLY, once we find the last	1343	* flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
…		…
1316	* once we get to them. This reduces the need to traverse over all of	1346	* once we get to them. This reduces the need to traverse over all of
1317	* them when adding another one - this saves quite a bit of cpu time	1347	* them when adding another one - this saves quite a bit of cpu time
1318	* when lots of spells are cast in one area. Currently, it is presumed	1348	* when lots of spells are cast in one area. Currently, it is presumed
1319	* that flying non pickable objects are spell objects.	1349	* that flying non pickable objects are spell objects.
1320	*/	1350	*/
1321	for (top = ms.bot; top; top = top->above)	1351	for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1322	{	1352	{
1323	if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))	1353	if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) || QUERY_FLAG (tmp, FLAG_OVERLAY_FLOOR))
1324	floor = top;	1354	floor = tmp;
1325		1355
1326	if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))	1356	if (QUERY_FLAG (tmp, FLAG_NO_PICK) && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (tmp, FLAG_IS_FLOOR))
1327	{	1357	{
1328	/* We insert above top, so we want this object below this */	1358	/* We insert above top, so we want this object below this */
1329	top = top->below;	1359	top = tmp->below;
1330	break;	1360	break;
1331	}	1361	}
1332		1362
1333	last = top;	1363	top = tmp;
1334	}	1364	}
1335
1336	/* Don't want top to be NULL, so set it to the last valid object */
1337	top = last;
1338		1365
1339	/* We let update_position deal with figuring out what the space	1366	/* We let update_position deal with figuring out what the space
1340	* looks like instead of lots of conditions here.	1367	* looks like instead of lots of conditions here.
1341	* makes things faster, and effectively the same result.	1368	* makes things faster, and effectively the same result.
1342	*/	1369	*/
…		…
1349	*/	1376	*/
1350	if (!(flag & INS_ON_TOP)	1377	if (!(flag & INS_ON_TOP)
1351	&& ms.flags () & P_BLOCKSVIEW	1378	&& ms.flags () & P_BLOCKSVIEW
1352	&& (op->face && !faces [op->face].visibility))	1379	&& (op->face && !faces [op->face].visibility))
1353	{	1380	{
		1381	object *last;
		1382
1354	for (last = top; last != floor; last = last->below)	1383	for (last = top; last != floor; last = last->below)
1355	if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))	1384	if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1356	break;	1385	break;
1357		1386
1358	/* Check to see if we found the object that blocks view,	1387	/* Check to see if we found the object that blocks view,
…		…
1366	} /* If objects on this space */	1395	} /* If objects on this space */
1367		1396
1368	if (flag & INS_ABOVE_FLOOR_ONLY)	1397	if (flag & INS_ABOVE_FLOOR_ONLY)
1369	top = floor;	1398	top = floor;
1370		1399
1371	/* Top is the object that our object (op) is going to get inserted above.	1400	// insert object above top, or bottom-most if top = 0
1372	*/
1373
1374	/* First object on this space */
1375	if (!top)	1401	if (!top)
1376	{	1402	{
		1403	op->below = 0;
1377	op->above = ms.bot;	1404	op->above = ms.bot;
1378
1379	if (op->above)
1380	op->above->below = op;
1381
1382	op->below = 0;
1383	ms.bot = op;	1405	ms.bot = op;
		1406
		1407	*(op->above ? &op->above->below : &ms.top) = op;
1384	}	1408	}
1385	else	1409	else
1386	{ /* get inserted into the stack above top */	1410	{
1387	op->above = top->above;	1411	op->above = top->above;
1388
1389	if (op->above)
1390	op->above->below = op;	1412	top->above = op;
1391		1413
1392	op->below = top;	1414	op->below = top;
1393	top->above = op;	1415	*(op->above ? &op->above->below : &ms.top) = op;
1394	}	1416	}
1395		1417	}
1396	if (!op->above)
1397	ms.top = op;
1398	} /* else not INS_BELOW_ORIGINATOR */
1399		1418
1400	if (op->type == PLAYER)	1419	if (op->type == PLAYER)
1401	{	1420	{
1402	op->contr->do_los = 1;	1421	op->contr->do_los = 1;
1403	++op->map->players;	1422	++op->map->players;
…		…
1405	}	1424	}
1406		1425
1407	op->map->dirty = true;	1426	op->map->dirty = true;
1408		1427
1409	if (object *pl = ms.player ())	1428	if (object *pl = ms.player ())
		1429	//TODO: the floorbox prev/next might need updating
		1430	//esrv_send_item (pl, op);
		1431	//TODO: update floorbox to preserve ordering
		1432	if (pl->contr->ns)
1410	pl->contr->ns->floorbox_update ();	1433	pl->contr->ns->floorbox_update ();
1411		1434
1412	/* If this object glows, it may affect lighting conditions that are	1435	/* If this object glows, it may affect lighting conditions that are
1413	* visible to others on this map. But update_all_los is really	1436	* visible to others on this map. But update_all_los is really
1414	* an inefficient way to do this, as it means los for all players	1437	* an inefficient way to do this, as it means los for all players
1415	* on the map will get recalculated. The players could very well	1438	* on the map will get recalculated. The players could very well
…		…
1457	* op is the object to insert it under: supplies x and the map.	1480	* op is the object to insert it under: supplies x and the map.
1458	*/	1481	*/
1459	void	1482	void
1460	replace_insert_ob_in_map (const char *arch_string, object *op)	1483	replace_insert_ob_in_map (const char *arch_string, object *op)
1461	{	1484	{
1462	object *tmp, *tmp1;
1463
1464	/* first search for itself and remove any old instances */	1485	/* first search for itself and remove any old instances */
1465		1486
1466	for (tmp = op->ms ().bot; tmp; tmp = tmp->above)	1487	for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1467	if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */	1488	if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */
1468	tmp->destroy ();	1489	tmp->destroy (1);
1469		1490
1470	tmp1 = arch_to_object (archetype::find (arch_string));	1491	object *tmp = arch_to_object (archetype::find (arch_string));
1471		1492
1472	tmp1->x = op->x;	1493	tmp->x = op->x;
1473	tmp1->y = op->y;	1494	tmp->y = op->y;
		1495
1474	insert_ob_in_map (tmp1, op->map, op, 0);	1496	insert_ob_in_map (tmp, op->map, op, 0);
1475	}	1497	}
1476		1498
1477	object *	1499	object *
1478	object::insert_at (object *where, object *originator, int flags)	1500	object::insert_at (object *where, object *originator, int flags)
1479	{	1501	{
		1502	if (where->env)
		1503	return where->env->insert (this);
		1504	else
1480	return where->map->insert (this, where->x, where->y, originator, flags);	1505	return where->map->insert (this, where->x, where->y, originator, flags);
1481	}	1506	}
1482		1507
1483	/*	1508	/*
1484	* get_split_ob(ob,nr) splits up ob into two parts. The part which
1485	* is returned contains nr objects, and the remaining parts contains
1486	* the rest (or is removed and freed if that number is 0).
1487	* On failure, NULL is returned, and the reason put into the
1488	* global static errmsg array.
1489	*/
1490	object *
1491	get_split_ob (object *orig_ob, uint32 nr)
1492	{
1493	object *newob;
1494	int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1495
1496	if (orig_ob->nrof < nr)
1497	{
1498	sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1499	return NULL;
1500	}
1501
1502	newob = object_create_clone (orig_ob);
1503
1504	if ((orig_ob->nrof -= nr) < 1)
1505	orig_ob->destroy (1);
1506	else if (!is_removed)
1507	{
1508	if (orig_ob->env != NULL)
1509	sub_weight (orig_ob->env, orig_ob->weight * nr);
1510	if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY)
1511	{
1512	strcpy (errmsg, "Tried to split object whose map is not in memory.");
1513	LOG (llevDebug, "Error, Tried to split object whose map is not in memory.\n");
1514	return NULL;
1515	}
1516	}
1517
1518	newob->nrof = nr;
1519
1520	return newob;
1521	}
1522
1523	/*
1524	* decrease_ob_nr(object, number) decreases a specified number from	1509	* decrease(object, number) decreases a specified number from
1525	* the amount of an object. If the amount reaches 0, the object	1510	* the amount of an object. If the amount reaches 0, the object
1526	* is subsequently removed and freed.	1511	* is subsequently removed and freed.
1527	*	1512	*
1528	* Return value: 'op' if something is left, NULL if the amount reached 0	1513	* Return value: 'op' if something is left, NULL if the amount reached 0
1529	*/	1514	*/
		1515	bool
		1516	object::decrease (sint32 nr)
		1517	{
		1518	if (!nr)
		1519	return true;
		1520
		1521	nr = min (nr, nrof);
		1522
		1523	nrof -= nr;
		1524
		1525	if (nrof)
		1526	{
		1527	adjust_weight (env, -weight * nr); // carrying == 0
		1528
		1529	if (object *pl = visible_to ())
		1530	esrv_update_item (UPD_NROF, pl, this);
		1531
		1532	return true;
		1533	}
		1534	else
		1535	{
		1536	destroy (1);
		1537	return false;
		1538	}
		1539	}
		1540
		1541	/*
		1542	* split(ob,nr) splits up ob into two parts. The part which
		1543	* is returned contains nr objects, and the remaining parts contains
		1544	* the rest (or is removed and returned if that number is 0).
		1545	* On failure, NULL is returned.
		1546	*/
1530	object *	1547	object *
1531	decrease_ob_nr (object *op, uint32 i)	1548	object::split (sint32 nr)
1532	{	1549	{
1533	object *tmp;	1550	int have = number_of ();
1534		1551
1535	if (i == 0) /* objects with op->nrof require this check */	1552	if (have < nr)
1536	return op;	1553	return 0;
1537		1554	else if (have == nr)
1538	if (i > op->nrof)
1539	i = op->nrof;
1540
1541	if (QUERY_FLAG (op, FLAG_REMOVED))
1542	op->nrof -= i;
1543	else if (op->env)
1544	{	1555	{
1545	/* is this object in the players inventory, or sub container
1546	* therein?
1547	*/
1548	tmp = op->in_player ();
1549	/* nope. Is this a container the player has opened?
1550	* If so, set tmp to that player.
1551	* IMO, searching through all the players will mostly
1552	* likely be quicker than following op->env to the map,
1553	* and then searching the map for a player.
1554	*/
1555	if (!tmp)
1556	for_all_players (pl)
1557	if (pl->ob->container == op->env)
1558	{
1559	tmp = pl->ob;
1560	break;
1561	}
1562
1563	if (i < op->nrof)
1564	{
1565	sub_weight (op->env, op->weight * i);
1566	op->nrof -= i;
1567	if (tmp)
1568	esrv_send_item (tmp, op);
1569	}
1570	else
1571	{
1572	op->remove ();	1556	remove ();
1573	op->nrof = 0;	1557	return this;
1574	if (tmp)
1575	esrv_del_item (tmp->contr, op->count);
1576	}
1577	}	1558	}
1578	else	1559	else
1579	{	1560	{
1580	object *above = op->above;	1561	decrease (nr);
1581		1562
1582	if (i < op->nrof)	1563	object *op = deep_clone ();
1583	op->nrof -= i;	1564	op->nrof = nr;
1584	else
1585	{
1586	op->remove ();
1587	op->nrof = 0;
1588	}
1589
1590	/* Since we just removed op, op->above is null */
1591	for (tmp = above; tmp; tmp = tmp->above)
1592	if (tmp->type == PLAYER)
1593	{
1594	if (op->nrof)
1595	esrv_send_item (tmp, op);
1596	else
1597	esrv_del_item (tmp->contr, op->count);
1598	}
1599	}
1600
1601	if (op->nrof)
1602	return op;	1565	return op;
1603	else
1604	{
1605	op->destroy ();
1606	return 0;
1607	}
1608	}
1609
1610	/*
1611	* add_weight(object, weight) adds the specified weight to an object,
1612	* and also updates how much the environment(s) is/are carrying.
1613	*/
1614	void
1615	add_weight (object *op, signed long weight)
1616	{
1617	while (op != NULL)
1618	{
1619	if (op->type == CONTAINER)
1620	weight = (signed long) (weight * (100 - op->stats.Str) / 100);
1621
1622	op->carrying += weight;
1623	op = op->env;
1624	}	1566	}
1625	}	1567	}
1626		1568
1627	object *	1569	object *
1628	insert_ob_in_ob (object *op, object *where)	1570	insert_ob_in_ob (object *op, object *where)
…		…
1653	* be != op, if items are merged. -Tero	1595	* be != op, if items are merged. -Tero
1654	*/	1596	*/
1655	object *	1597	object *
1656	object::insert (object *op)	1598	object::insert (object *op)
1657	{	1599	{
1658	if (!QUERY_FLAG (op, FLAG_REMOVED))
1659	op->remove ();
1660
1661	if (op->more)	1600	if (op->more)
1662	{	1601	{
1663	LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);	1602	LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);
1664	return op;	1603	return op;
1665	}	1604	}
1666		1605
1667	CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL);	1606	op->remove ();
1668	CLEAR_FLAG (op, FLAG_REMOVED);	1607
		1608	op->flag [FLAG_OBJ_ORIGINAL] = 0;
1669		1609
1670	if (op->nrof)	1610	if (op->nrof)
1671	{
1672	for (object *tmp = inv; tmp; tmp = tmp->below)	1611	for (object *tmp = inv; tmp; tmp = tmp->below)
1673	if (object::can_merge (tmp, op))	1612	if (object::can_merge (tmp, op))
1674	{	1613	{
1675	/* return the original object and remove inserted object	1614	/* return the original object and remove inserted object
1676	(client needs the original object) */	1615	(client needs the original object) */
1677	tmp->nrof += op->nrof;	1616	tmp->nrof += op->nrof;
1678	/* Weight handling gets pretty funky. Since we are adding to	1617
1679	* tmp->nrof, we need to increase the weight.	1618	if (object *pl = tmp->visible_to ())
1680	*/	1619	esrv_update_item (UPD_NROF, pl, tmp);
		1620
1681	add_weight (this, op->weight * op->nrof);	1621	adjust_weight (this, op->total_weight ());
1682	SET_FLAG (op, FLAG_REMOVED);	1622
1683	op->destroy (); /* free the inserted object */	1623	op->destroy (1);
1684	op = tmp;	1624	op = tmp;
1685	op->remove (); /* and fix old object's links */	1625	goto inserted;
1686	CLEAR_FLAG (op, FLAG_REMOVED);
1687	break;
1688	}	1626	}
1689		1627
1690	/* I assume combined objects have no inventory
1691	* We add the weight - this object could have just been removed
1692	* (if it was possible to merge). calling remove_ob will subtract
1693	* the weight, so we need to add it in again, since we actually do
1694	* the linking below
1695	*/
1696	add_weight (this, op->weight * op->nrof);
1697	}
1698	else
1699	add_weight (this, (op->weight + op->carrying));
1700
1701	if (object *otmp = this->in_player ())
1702	if (otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1703	otmp->update_stats ();
1704
1705	op->owner = 0; // its his/hers now. period.	1628	op->owner = 0; // it's his/hers now. period.
1706	op->map = 0;	1629	op->map = 0;
		1630	op->x = 0;
		1631	op->y = 0;
		1632
		1633	op->above = 0;
		1634	op->below = inv;
1707	op->env = this;	1635	op->env = this;
1708	op->above = 0;
1709	op->below = 0;
1710	op->x = op->y = 0;
1711		1636
		1637	if (inv)
		1638	inv->above = op;
		1639
		1640	inv = op;
		1641
		1642	op->flag [FLAG_REMOVED] = 0;
		1643
		1644	if (object *pl = op->visible_to ())
		1645	esrv_send_item (pl, op);
		1646
		1647	adjust_weight (this, op->total_weight ());
		1648
		1649	inserted:
1712	/* reset the light list and los of the players on the map */	1650	/* reset the light list and los of the players on the map */
1713	if (op->glow_radius && map)	1651	if (op->glow_radius && map && map->darkness)
1714	{
1715	#ifdef DEBUG_LIGHTS
1716	LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1717	#endif /* DEBUG_LIGHTS */
1718	if (map->darkness)
1719	update_all_los (map, x, y);	1652	update_all_los (map, x, y);
1720	}
1721		1653
1722	/* Client has no idea of ordering so lets not bother ordering it here.	1654	// if this is a player's inventory, update stats
1723	* It sure simplifies this function...	1655	if (type == PLAYER && !flag [FLAG_NO_FIX_PLAYER])
1724	*/	1656	update_stats ();
1725	if (!inv)
1726	inv = op;
1727	else
1728	{
1729	op->below = inv;
1730	op->below->above = op;
1731	inv = op;
1732	}
1733		1657
1734	INVOKE_OBJECT (INSERT, this);	1658	INVOKE_OBJECT (INSERT, this);
1735		1659
1736	return op;	1660	return op;
1737	}	1661	}
…		…
1865	LOG (llevError, "Present_arch called outside map.\n");	1789	LOG (llevError, "Present_arch called outside map.\n");
1866	return NULL;	1790	return NULL;
1867	}	1791	}
1868		1792
1869	for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)	1793	for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1870	if (tmp->arch == at)	1794	if (tmp->arch->archname == at->archname)
1871	return tmp;	1795	return tmp;
1872		1796
1873	return NULL;	1797	return NULL;
1874	}	1798	}
1875		1799
…		…
1939	* The first matching object is returned, or NULL if none.	1863	* The first matching object is returned, or NULL if none.
1940	*/	1864	*/
1941	object *	1865	object *
1942	present_arch_in_ob (const archetype *at, const object *op)	1866	present_arch_in_ob (const archetype *at, const object *op)
1943	{	1867	{
1944	for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)	1868	for (object *tmp = op->inv; tmp; tmp = tmp->below)
1945	if (tmp->arch == at)	1869	if (tmp->arch->archname == at->archname)
1946	return tmp;	1870	return tmp;
1947		1871
1948	return NULL;	1872	return NULL;
1949	}	1873	}
1950		1874
…		…
2359		2283
2360	/*	2284	/*
2361	* create clone from object to another	2285	* create clone from object to another
2362	*/	2286	*/
2363	object *	2287	object *
2364	object_create_clone (object *asrc)	2288	object::deep_clone ()
2365	{	2289	{
2366	object *dst = 0, *tmp, *src, *prev, *item;	2290	assert (("deep_clone called on non-head object", is_head ()));
2367		2291
2368	if (!asrc)	2292	object *dst = clone ();
2369	return 0;
2370		2293
2371	src = asrc->head_ ();	2294	object *prev = dst;
2372
2373	prev = 0;
2374	for (object *part = src; part; part = part->more)	2295	for (object *part = this->more; part; part = part->more)
2375	{	2296	{
2376	tmp = part->clone ();	2297	object *tmp = part->clone ();
2377	tmp->x -= src->x;
2378	tmp->y -= src->y;
2379
2380	if (!part->head)
2381	{
2382	dst = tmp;
2383	tmp->head = 0;
2384	}
2385	else
2386	tmp->head = dst;	2298	tmp->head = dst;
2387
2388	tmp->more = 0;
2389
2390	if (prev)
2391	prev->more = tmp;	2299	prev->more = tmp;
2392
2393	prev = tmp;	2300	prev = tmp;
2394	}	2301	}
2395		2302
2396	for (item = src->inv; item; item = item->below)	2303	for (object *item = inv; item; item = item->below)
2397	insert_ob_in_ob (object_create_clone (item), dst);	2304	insert_ob_in_ob (item->deep_clone (), dst);
2398		2305
2399	return dst;	2306	return dst;
2400	}	2307	}
2401		2308
2402	/* This returns the first object in who's inventory that	2309	/* This returns the first object in who's inventory that
…		…
2411	return tmp;	2318	return tmp;
2412		2319
2413	return 0;	2320	return 0;
2414	}	2321	}
2415		2322
2416	/* If ob has a field named key, return the link from the list,	2323	const shstr &
2417	* otherwise return NULL.	2324	object::kv_get (const shstr &key) const
2418	*
2419	* key must be a passed in shared string - otherwise, this won't
2420	* do the desired thing.
2421	*/
2422	key_value *
2423	get_ob_key_link (const object *ob, const char *key)
2424	{	2325	{
2425	for (key_value *link = ob->key_values; link; link = link->next)	2326	for (key_value *kv = key_values; kv; kv = kv->next)
2426	if (link->key == key)	2327	if (kv->key == key)
2427	return link;
2428
2429	return 0;
2430	}
2431
2432	/*
2433	* Returns the value of op has an extra_field for key, or NULL.
2434	*
2435	* The argument doesn't need to be a shared string.
2436	*
2437	* The returned string is shared.
2438	*/
2439	const char *
2440	get_ob_key_value (const object *op, const char *const key)
2441	{
2442	key_value *link;
2443	shstr_cmp canonical_key (key);
2444
2445	if (!canonical_key)
2446	{
2447	/* 1. There being a field named key on any object
2448	* implies there'd be a shared string to find.
2449	* 2. Since there isn't, no object has this field.
2450	* 3. Therefore, *this* object doesn't have this field.
2451	*/
2452	return 0;
2453	}
2454
2455	/* This is copied from get_ob_key_link() above -
2456	* only 4 lines, and saves the function call overhead.
2457	*/
2458	for (link = op->key_values; link; link = link->next)
2459	if (link->key == canonical_key)
2460	return link->value;	2328	return kv->value;
2461		2329
2462	return 0;	2330	return shstr_null;
2463	}	2331	}
2464		2332
2465	/*	2333	void
2466	* Updates the canonical_key in op to value.	2334	object::kv_set (const shstr &key, const shstr &value)
2467	*
2468	* canonical_key is a shared string (value doesn't have to be).
2469	*
2470	* Unless add_key is TRUE, it won't add fields, only change the value of existing
2471	* keys.
2472	*
2473	* Returns TRUE on success.
2474	*/
2475	int
2476	set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2477	{	2335	{
2478	key_value *field = NULL, *last = NULL;	2336	for (key_value *kv = key_values; kv; kv = kv->next)
2479		2337	if (kv->key == key)
2480	for (field = op->key_values; field != NULL; field = field->next)
2481	{
2482	if (field->key != canonical_key)
2483	{	2338	{
2484	last = field;	2339	kv->value = value;
2485	continue;	2340	return;
2486	}	2341	}
2487		2342
2488	if (value)	2343	key_value *kv = new key_value;
2489	field->value = value;	2344
2490	else	2345	kv->next = key_values;
		2346	kv->key = key;
		2347	kv->value = value;
		2348
		2349	key_values = kv;
		2350	}
		2351
		2352	void
		2353	object::kv_del (const shstr &key)
		2354	{
		2355	for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
		2356	if ((*kvp)->key == key)
2491	{	2357	{
2492	/* Basically, if the archetype has this key set,	2358	key_value *kv = *kvp;
2493	* we need to store the null value so when we save	2359	*kvp = (*kvp)->next;
2494	* it, we save the empty value so that when we load,	2360	delete kv;
2495	* we get this value back again.	2361	return;
2496	*/
2497	if (get_ob_key_link (op->arch, canonical_key))
2498	field->value = 0;
2499	else
2500	{
2501	if (last)
2502	last->next = field->next;
2503	else
2504	op->key_values = field->next;
2505
2506	delete field;
2507	}
2508	}	2362	}
2509	return TRUE;
2510	}
2511	/* IF we get here, key doesn't exist */
2512
2513	/* No field, we'll have to add it. */
2514
2515	if (!add_key)
2516	return FALSE;
2517
2518	/* There isn't any good reason to store a null
2519	* value in the key/value list. If the archetype has
2520	* this key, then we should also have it, so shouldn't
2521	* be here. If user wants to store empty strings,
2522	* should pass in ""
2523	*/
2524	if (value == NULL)
2525	return TRUE;
2526
2527	field = new key_value;
2528
2529	field->key = canonical_key;
2530	field->value = value;
2531	/* Usual prepend-addition. */
2532	field->next = op->key_values;
2533	op->key_values = field;
2534
2535	return TRUE;
2536	}
2537
2538	/*
2539	* Updates the key in op to value.
2540	*
2541	* If add_key is FALSE, this will only update existing keys,
2542	* and not add new ones.
2543	* In general, should be little reason FALSE is ever passed in for add_key
2544	*
2545	* Returns TRUE on success.
2546	*/
2547	int
2548	set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2549	{
2550	shstr key_ (key);
2551
2552	return set_ob_key_value_s (op, key_, value, add_key);
2553	}	2363	}
2554		2364
2555	object::depth_iterator::depth_iterator (object *container)	2365	object::depth_iterator::depth_iterator (object *container)
2556	: iterator_base (container)	2366	: iterator_base (container)
2557	{	2367	{
…		…
2607	{	2417	{
2608	char flagdesc[512];	2418	char flagdesc[512];
2609	char info2[256 * 4];	2419	char info2[256 * 4];
2610	char *p = info;	2420	char *p = info;
2611		2421
2612	p += snprintf (p, 512, "{cnt:%d,uuid:<1.%" PRIx64 ">,name:\"%s\"%s%s,flags:[%s],type:%d}",	2422	p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2613	count, uuid.seq,	2423	count,
		2424	uuid.c_str (),
2614	&name,	2425	&name,
2615	title ? "\",title:\"" : "",	2426	title ? ",title:\"" : "",
2616	title ? (const char *)title : "",	2427	title ? (const char *)title : "",
		2428	title ? "\"" : "",
2617	flag_desc (flagdesc, 512), type);	2429	flag_desc (flagdesc, 512), type);
2618		2430
2619	if (!this->flag[FLAG_REMOVED] && env)	2431	if (!flag[FLAG_REMOVED] && env)
2620	p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));	2432	p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2621		2433
2622	if (map)	2434	if (map)
2623	p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);	2435	p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2624		2436
…		…
2654	object::open_container (object *new_container)	2466	object::open_container (object *new_container)
2655	{	2467	{
2656	if (container == new_container)	2468	if (container == new_container)
2657	return;	2469	return;
2658		2470
2659	if (object *old_container = container)	2471	object *old_container = container;
		2472
		2473	if (old_container)
2660	{	2474	{
2661	if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))	2475	if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))
2662	return;	2476	return;
2663		2477
2664	#if 0	2478	#if 0
…		…
2666	if (object *closer = old_container->inv)	2480	if (object *closer = old_container->inv)
2667	if (closer->type == CLOSE_CON)	2481	if (closer->type == CLOSE_CON)
2668	closer->destroy ();	2482	closer->destroy ();
2669	#endif	2483	#endif
2670		2484
		2485	// make sure the container is available
		2486	esrv_send_item (this, old_container);
		2487
2671	old_container->flag [FLAG_APPLIED] = 0;	2488	old_container->flag [FLAG_APPLIED] = false;
2672	container = 0;	2489	container = 0;
2673		2490
		2491	// client needs item update to make it work, client bug requires this to be separate
2674	esrv_update_item (UPD_FLAGS, this, old_container);	2492	esrv_update_item (UPD_FLAGS, this, old_container);
		2493
2675	new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container));	2494	new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container));
2676	play_sound (sound_find ("chest_close"));	2495	play_sound (sound_find ("chest_close"));
2677	}	2496	}
2678		2497
2679	if (new_container)	2498	if (new_container)
…		…
2692	}	2511	}
2693	#endif	2512	#endif
2694		2513
2695	new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container));	2514	new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container));
2696		2515
		2516	// make sure the container is available, client bug requires this to be separate
		2517	esrv_send_item (this, new_container);
		2518
2697	new_container->flag [FLAG_APPLIED] = 1;	2519	new_container->flag [FLAG_APPLIED] = true;
2698	container = new_container;	2520	container = new_container;
2699		2521
		2522	// client needs flag change
2700	esrv_update_item (UPD_FLAGS, this, new_container);	2523	esrv_update_item (UPD_FLAGS, this, new_container);
2701	esrv_send_inventory (this, new_container);	2524	esrv_send_inventory (this, new_container);
2702	play_sound (sound_find ("chest_open"));	2525	play_sound (sound_find ("chest_open"));
2703	}	2526	}
		2527	// else if (!old_container->env && contr && contr->ns)
		2528	// contr->ns->floorbox_reset ();
2704	}	2529	}
2705		2530
2706	object *	2531	object *
2707	object::force_find (const shstr name)	2532	object::force_find (const shstr name)
2708	{	2533	{
…		…
2734		2559
2735	insert (force);	2560	insert (force);
2736	}	2561	}
2737		2562
2738	void	2563	void
2739	object::play_sound (faceidx sound) const	2564	object::play_sound (faceidx sound)
2740	{	2565	{
2741	if (!sound)	2566	if (!sound)
2742	return;	2567	return;
2743		2568
2744	if (flag [FLAG_REMOVED])	2569	if (flag [FLAG_REMOVED])

Diff Legend

–	Removed lines
+	Added lines
<	Changed lines
>	Changed lines