ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.204 by root, Fri Apr 11 17:01:52 2008 UTC vs.
Revision 1.295 by root, Fri Nov 6 13:03:34 2009 UTC

1/* 1/*
2 * This file is part of Deliantra, the Roguelike Realtime MMORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007 Marc Alexander Lehmann / Robin Redeker / the Deliantra team 4 * Copyright (©) 2005,2006,2007,2008,2009 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 * 7 *
8 * Deliantra is free software: you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify it under
9 * it under the terms of the GNU General Public License as published by 9 * the terms of the Affero GNU General Public License as published by the
10 * the Free Software Foundation, either version 3 of the License, or 10 * Free Software Foundation, either version 3 of the License, or (at your
11 * (at your option) any later version. 11 * option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the Affero GNU General Public License
19 * along with this program. If not, see <http://www.gnu.org/licenses/>. 19 * and the GNU General Public License along with this program. If not, see
20 * <http://www.gnu.org/licenses/>.
20 * 21 *
21 * The authors can be reached via e-mail to <support@deliantra.net> 22 * The authors can be reached via e-mail to <support@deliantra.net>
22 */ 23 */
23 24
24/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
25 sub/add_weight will transcend the environment updating the carrying
26 variable. */
27#include <global.h> 25#include <global.h>
28#include <stdio.h> 26#include <stdio.h>
29#include <sys/types.h> 27#include <sys/types.h>
30#include <sys/uio.h> 28#include <sys/uio.h>
31#include <object.h> 29#include <object.h>
32#include <funcpoint.h>
33#include <sproto.h> 30#include <sproto.h>
34#include <loader.h> 31#include <loader.h>
35 32
36#include <bitset> 33#include <bitset>
37 34
38UUID UUID::cur; 35UUID UUID::cur;
39static uint64_t seq_next_save; 36static uint64_t seq_next_save;
40static const uint64 UUID_GAP = 1<<19; 37static const uint64 UUID_GAP = 1<<19;
38uint32_t mapspace::smellcount = 10000;
41 39
42objectvec objects; 40objectvec objects;
43activevec actives; 41activevec actives;
42
43//+GPL
44 44
45short freearr_x[SIZEOFFREE] = { 45short freearr_x[SIZEOFFREE] = {
46 0, 46 0,
47 0, 1, 1, 1, 0, -1, -1, -1, 47 0, 1, 1, 1, 0, -1, -1, -1,
48 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 48 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
52 0, 52 0,
53 -1, -1, 0, 1, 1, 1, 0, -1, 53 -1, -1, 0, 1, 1, 1, 0, -1,
54 -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, 54 -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
55 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3 55 -3, -3, -3, -3, -2, -1, 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3
56}; 56};
57int maxfree[SIZEOFFREE] = {
58 0,
59 9, 10, 13, 14, 17, 18, 21, 22,
60 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
61 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
62};
63int freedir[SIZEOFFREE] = { 57int freedir[SIZEOFFREE] = {
64 0, 58 0,
65 1, 2, 3, 4, 5, 6, 7, 8, 59 1, 2, 3, 4, 5, 6, 7, 8,
66 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8, 60 1, 2, 2, 2, 3, 4, 4, 4, 5, 6, 6, 6, 7, 8, 8, 8,
67 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8 61 1, 2, 2, 2, 2, 2, 3, 4, 4, 4, 4, 4, 5, 6, 6, 6, 6, 6, 7, 8, 8, 8, 8, 8
62};
63
64static int maxfree[SIZEOFFREE] = {
65 0,
66 9, 10, 13, 14, 17, 18, 21, 22,
67 25, 26, 27, 30, 31, 32, 33, 36, 37, 39, 39, 42, 43, 44, 45, 48,
68 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49, 49
68}; 69};
69 70
70static void 71static void
71write_uuid (uval64 skip, bool sync) 72write_uuid (uval64 skip, bool sync)
72{ 73{
140{ 141{
141 read_uuid (); 142 read_uuid ();
142} 143}
143 144
144/* Returns TRUE if every key_values in wants has a partner with the same value in has. */ 145/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
145static int 146static bool
146compare_ob_value_lists_one (const object *wants, const object *has) 147compare_ob_value_lists_one (const object *wants, const object *has)
147{ 148{
148 key_value *wants_field;
149
150 /* n-squared behaviour (see get_ob_key_link()), but I'm hoping both 149 /* n-squared behaviour (see kv_get), but I'm hoping both
151 * objects with lists are rare, and lists stay short. If not, use a 150 * objects with lists are rare, and lists stay short. If not, use a
152 * different structure or at least keep the lists sorted... 151 * different structure or at least keep the lists sorted...
153 */ 152 */
154 153
155 /* For each field in wants, */ 154 /* For each field in wants, */
156 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next) 155 for (key_value *kv = wants->key_values; kv; kv = kv->next)
157 { 156 if (has->kv_get (kv->key) != kv->value)
158 key_value *has_field; 157 return false;
159
160 /* Look for a field in has with the same key. */
161 has_field = get_ob_key_link (has, wants_field->key);
162
163 if (has_field == NULL)
164 {
165 /* No field with that name. */
166 return FALSE;
167 }
168
169 /* Found the matching field. */
170 if (has_field->value != wants_field->value)
171 {
172 /* Values don't match, so this half of the comparison is false. */
173 return FALSE;
174 }
175
176 /* If we get here, we found a match. Now for the next field in wants. */
177 }
178 158
179 /* If we get here, every field in wants has a matching field in has. */ 159 /* If we get here, every field in wants has a matching field in has. */
180 return TRUE; 160 return true;
181} 161}
182 162
183/* Returns TRUE if ob1 has the same key_values as ob2. */ 163/* Returns TRUE if ob1 has the same key_values as ob2. */
184static int 164static bool
185compare_ob_value_lists (const object *ob1, const object *ob2) 165compare_ob_value_lists (const object *ob1, const object *ob2)
186{ 166{
187 /* However, there may be fields in has which aren't partnered in wants, 167 /* However, there may be fields in has which aren't partnered in wants,
188 * so we need to run the comparison *twice*. :( 168 * so we need to run the comparison *twice*. :(
189 */ 169 */
190 return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1); 170 return compare_ob_value_lists_one (ob1, ob2)
171 && compare_ob_value_lists_one (ob2, ob1);
191} 172}
192 173
193/* Function examines the 2 objects given to it, and returns true if 174/* Function examines the 2 objects given to it, and returns true if
194 * they can be merged together. 175 * they can be merged together.
195 * 176 *
210 || ob1->speed != ob2->speed 191 || ob1->speed != ob2->speed
211 || ob1->value != ob2->value 192 || ob1->value != ob2->value
212 || ob1->name != ob2->name) 193 || ob1->name != ob2->name)
213 return 0; 194 return 0;
214 195
215 //TODO: this ain't working well, use nicer and correct overflow check
216 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that 196 /* Do not merge objects if nrof would overflow, assume nrof
217 * value could not be stored in a sint32 (which unfortunately sometimes is 197 * is always 0 .. 2**31-1 */
218 * used to store nrof). 198 if (ob1->nrof > 0x7fffffff - ob2->nrof)
219 */
220 if (ob1->nrof + ob2->nrof >= 1UL << 31)
221 return 0; 199 return 0;
222 200
223 /* If the objects have been identified, set the BEEN_APPLIED flag. 201 /* If the objects have been identified, set the BEEN_APPLIED flag.
224 * This is to the comparison of the flags below will be OK. We 202 * This is to the comparison of the flags below will be OK. We
225 * just can't ignore the been applied or identified flags, as they 203 * just can't ignore the been applied or identified flags, as they
226 * are not equal - just if it has been identified, the been_applied 204 * are not equal - just if it has been identified, the been_applied
227 * flags lose any meaning. 205 * flags lose any meaning.
228 */ 206 */
229 if (QUERY_FLAG (ob1, FLAG_IDENTIFIED)) 207 if (QUERY_FLAG (ob1, FLAG_IDENTIFIED))
230 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 208 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
231 209
232 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 210 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
233 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 211 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
234 212
235 if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any () 213 if (ob1->arch->archname != ob2->arch->archname
236 || ob1->arch != ob2->arch
237 || ob1->name != ob2->name 214 || ob1->name != ob2->name
238 || ob1->title != ob2->title 215 || ob1->title != ob2->title
239 || ob1->msg != ob2->msg 216 || ob1->msg != ob2->msg
240 || ob1->weight != ob2->weight 217 || ob1->weight != ob2->weight
241 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
242 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
243 || ob1->attacktype != ob2->attacktype 218 || ob1->attacktype != ob2->attacktype
244 || ob1->magic != ob2->magic 219 || ob1->magic != ob2->magic
245 || ob1->slaying != ob2->slaying 220 || ob1->slaying != ob2->slaying
246 || ob1->skill != ob2->skill 221 || ob1->skill != ob2->skill
247 || ob1->value != ob2->value 222 || ob1->value != ob2->value
248 || ob1->animation_id != ob2->animation_id 223 || ob1->animation_id != ob2->animation_id
224 || (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependent on each other
249 || ob1->client_type != ob2->client_type 225 || ob1->client_type != ob2->client_type
250 || ob1->materialname != ob2->materialname 226 || ob1->materialname != ob2->materialname
251 || ob1->lore != ob2->lore 227 || ob1->lore != ob2->lore
252 || ob1->subtype != ob2->subtype 228 || ob1->subtype != ob2->subtype
253 || ob1->move_type != ob2->move_type 229 || ob1->move_type != ob2->move_type
254 || ob1->move_block != ob2->move_block 230 || ob1->move_block != ob2->move_block
255 || ob1->move_allow != ob2->move_allow 231 || ob1->move_allow != ob2->move_allow
256 || ob1->move_on != ob2->move_on 232 || ob1->move_on != ob2->move_on
257 || ob1->move_off != ob2->move_off 233 || ob1->move_off != ob2->move_off
258 || ob1->move_slow != ob2->move_slow 234 || ob1->move_slow != ob2->move_slow
259 || ob1->move_slow_penalty != ob2->move_slow_penalty) 235 || ob1->move_slow_penalty != ob2->move_slow_penalty
236 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
237 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
260 return 0; 238 return 0;
261 239
240 if ((ob1->flag ^ ob2->flag)
241 .reset (FLAG_INV_LOCKED)
242 .reset (FLAG_REMOVED)
243 .any ())
244 return 0;
245
262 /* This is really a spellbook check - really, we should 246 /* This is really a spellbook check - we should in general
263 * check all objects in the inventory. 247 * not merge objects with real inventories, as splitting them
248 * is hard.
264 */ 249 */
265 if (ob1->inv || ob2->inv) 250 if (ob1->inv || ob2->inv)
266 { 251 {
267 if (!(ob1->inv && ob2->inv)) 252 if (!(ob1->inv && ob2->inv))
268 return 0; /* inventories differ in length */ 253 return 0; /* inventories differ in length */
269 254
270 if (ob1->inv->below || ob2->inv->below) 255 if (ob1->inv->below || ob2->inv->below)
271 return 0; /* more than one object in inv */ 256 return 0; /* more than one object in inv */
272 257
273 if (!object::can_merge (ob1->inv, ob2->inv)) 258 if (!object::can_merge (ob1->inv, ob2->inv))
274 return 0; /* inventory objexts differ */ 259 return 0; /* inventory objects differ */
275 260
276 /* inventory ok - still need to check rest of this object to see 261 /* inventory ok - still need to check rest of this object to see
277 * if it is valid. 262 * if it is valid.
278 */ 263 */
279 } 264 }
298 if (ob1->level != ob2->level) 283 if (ob1->level != ob2->level)
299 return 0; 284 return 0;
300 break; 285 break;
301 } 286 }
302 287
303 if (ob1->key_values != NULL || ob2->key_values != NULL) 288 if (ob1->key_values || ob2->key_values)
304 { 289 {
305 /* At least one of these has key_values. */ 290 /* At least one of these has key_values. */
306 if ((ob1->key_values == NULL) != (ob2->key_values == NULL)) 291 if ((!ob1->key_values) != (!ob2->key_values))
307 /* One has fields, but the other one doesn't. */ 292 return 0; /* One has fields, but the other one doesn't. */
308 return 0; 293
309 else if (!compare_ob_value_lists (ob1, ob2)) 294 if (!compare_ob_value_lists (ob1, ob2))
310 return 0; 295 return 0;
311 } 296 }
312 297
313 if (ob1->self || ob2->self) 298 if (ob1->self || ob2->self)
314 { 299 {
320 int k1 = ob1->self ? HvTOTALKEYS (ob1->self) : 0; 305 int k1 = ob1->self ? HvTOTALKEYS (ob1->self) : 0;
321 int k2 = ob2->self ? HvTOTALKEYS (ob2->self) : 0; 306 int k2 = ob2->self ? HvTOTALKEYS (ob2->self) : 0;
322 307
323 if (k1 != k2) 308 if (k1 != k2)
324 return 0; 309 return 0;
310
325 else if (k1 == 0) 311 if (k1 == 0)
326 return 1; 312 return 1;
313
327 else if (!cfperl_can_merge (ob1, ob2)) 314 if (!cfperl_can_merge (ob1, ob2))
328 return 0; 315 return 0;
329 } 316 }
330 } 317 }
331 318
332 /* Everything passes, must be OK. */ 319 /* Everything passes, must be OK. */
333 return 1; 320 return 1;
334} 321}
335 322
323// find player who can see this object
324object *
325object::visible_to () const
326{
327 if (client_visible () && !flag [FLAG_REMOVED])
328 {
329 // see if we are in a container of sorts
330 if (env)
331 {
332 // the player inventory itself is always visible
333 if (env->is_player ())
334 return env;
335
336 // else a player could have our env open
337 object *envest = env->outer_env_or_self ();
338
339 // the player itself is always on a map, so we will find him here
340 // even if our inv is in a player.
341 if (envest->is_on_map ())
342 if (object *pl = envest->ms ().player ())
343 if (pl->container_ () == env)
344 return pl;
345 }
346 else
347 {
348 // maybe there is a player standing on the same mapspace
349 // this will catch the case where "this" is a player
350 if (object *pl = ms ().player ())
351 if ((pl->contr->ns && !pl->container_ () && !pl->contr->ns->update_look)
352 || pl->container_ () == this)
353 return pl;
354 }
355 }
356
357 return 0;
358}
359
360// adjust weight per container type ("of holding")
361static sint32
362weight_adjust_for (object *op, sint32 weight)
363{
364 return op->type == CONTAINER
365 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str)
366 : weight;
367}
368
336/* 369/*
370 * adjust_weight(object, weight) adds the specified weight to an object,
371 * and also updates how much the environment(s) is/are carrying.
372 */
373static void
374adjust_weight (object *op, sint32 weight)
375{
376 while (op)
377 {
378 // adjust by actual difference to account for rounding errors
379 // i.e. (w2 - w1) / f != w2 / f - w1 / f and the latter is correct
380 weight = weight_adjust_for (op, op->carrying)
381 - weight_adjust_for (op, op->carrying - weight);
382
383 if (!weight)
384 return;
385
386 op->carrying += weight;
387
388 if (object *pl = op->visible_to ())
389 if (pl != op) // player is handled lazily
390 esrv_update_item (UPD_WEIGHT, pl, op);
391
392 op = op->env;
393 }
394}
395
396/*
337 * sum_weight() is a recursive function which calculates the weight 397 * this is a recursive function which calculates the weight
338 * an object is carrying. It goes through in figures out how much 398 * an object is carrying. It goes through op and figures out how much
339 * containers are carrying, and sums it up. 399 * containers are carrying, and sums it up.
340 */ 400 */
341long 401void
342sum_weight (object *op) 402object::update_weight ()
343{ 403{
344 long sum; 404 sint32 sum = 0;
345 object *inv;
346 405
347 for (sum = 0, inv = op->inv; inv; inv = inv->below) 406 for (object *op = inv; op; op = op->below)
348 { 407 {
349 if (inv->inv) 408 if (op->inv)
350 sum_weight (inv); 409 op->update_weight ();
351 410
352 sum += inv->carrying + inv->weight * (inv->nrof ? inv->nrof : 1); 411 sum += op->total_weight ();
412 }
413
414 sum = weight_adjust_for (this, sum);
415
416 if (sum != carrying)
353 } 417 {
354
355 if (op->type == CONTAINER && op->stats.Str)
356 sum = (sum * (100 - op->stats.Str)) / 100;
357
358 if (op->carrying != sum)
359 op->carrying = sum; 418 carrying = sum;
360 419
361 return sum; 420 if (object *pl = visible_to ())
421 if (pl != this) // player is handled lazily
422 esrv_update_item (UPD_WEIGHT, pl, this);
423 }
362} 424}
363 425
364/** 426/*
365 * Return the outermost environment object for a given object. 427 * Used by: Server DM commands: dumpbelow, dump. Some error messages.
366 */
367
368object *
369object_get_env_recursive (object *op)
370{
371 while (op->env != NULL)
372 op = op->env;
373 return op;
374}
375
376/*
377 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
378 * Some error messages.
379 * The result of the dump is stored in the static global errmsg array.
380 */ 428 */
381char * 429char *
382dump_object (object *op) 430dump_object (object *op)
383{ 431{
384 if (!op) 432 if (!op)
387 object_freezer freezer; 435 object_freezer freezer;
388 op->write (freezer); 436 op->write (freezer);
389 return freezer.as_string (); 437 return freezer.as_string ();
390} 438}
391 439
440char *
441object::as_string ()
442{
443 return dump_object (this);
444}
445
392/* 446/*
393 * get_nearest_part(multi-object, object 2) returns the part of the 447 * get_nearest_part(multi-object, object 2) returns the part of the
394 * multi-object 1 which is closest to the second object. 448 * multi-object 1 which is closest to the second object.
395 * If it's not a multi-object, it is returned. 449 * If it's not a multi-object, it is returned.
396 */ 450 */
397object * 451static object *
398get_nearest_part (object *op, const object *pl) 452get_nearest_part (object *op, const object *pl)
399{ 453{
400 object *tmp, *closest; 454 object *tmp, *closest;
401 int last_dist, i; 455 int last_dist, i;
402 456
403 if (op->more == NULL) 457 if (!op->more)
404 return op; 458 return op;
459
405 for (last_dist = distance (op, pl), closest = op, tmp = op->more; tmp != NULL; tmp = tmp->more) 460 for (last_dist = distance (op, pl), closest = op, tmp = op->more;
461 tmp;
462 tmp = tmp->more)
406 if ((i = distance (tmp, pl)) < last_dist) 463 if ((i = distance (tmp, pl)) < last_dist)
407 closest = tmp, last_dist = i; 464 closest = tmp, last_dist = i;
465
408 return closest; 466 return closest;
409} 467}
410 468
411/* 469/*
412 * Returns the object which has the count-variable equal to the argument. 470 * Returns the object which has the count-variable equal to the argument.
471 * VERRRY slow.
413 */ 472 */
414object * 473object *
415find_object (tag_t i) 474find_object (tag_t i)
416{ 475{
417 for_all_objects (op) 476 for_all_objects (op)
428 */ 487 */
429object * 488object *
430find_object_name (const char *str) 489find_object_name (const char *str)
431{ 490{
432 shstr_cmp str_ (str); 491 shstr_cmp str_ (str);
433 object *op;
434 492
493 if (str_)
435 for_all_objects (op) 494 for_all_objects (op)
436 if (op->name == str_) 495 if (op->name == str_)
437 break; 496 return op;
438 497
439 return op; 498 return 0;
440} 499}
441 500
442/* 501/*
443 * Sets the owner and sets the skill and exp pointers to owner's current 502 * Sets the owner and sets the skill and exp pointers to owner's current
444 * skill and experience objects. 503 * skill and experience objects.
506 update_stats (); 565 update_stats ();
507 566
508 new_draw_info_format (NDI_UNIQUE, 0, this, 567 new_draw_info_format (NDI_UNIQUE, 0, this,
509 "You try to balance all your items at once, " 568 "You try to balance all your items at once, "
510 "but the %s is just too much for your body. " 569 "but the %s is just too much for your body. "
511 "[You need to unapply some items first.]", &ob->name); 570 "[You need to unapply some items first - use the 'body' command to see "
571 "how many items you cna wera on a specific body part.]", &ob->name);
512 return false; 572 return false;
513 } 573 }
514 574
515 //new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name); 575 //new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name);
516 } 576 }
542 } 602 }
543 603
544 op->key_values = 0; 604 op->key_values = 0;
545} 605}
546 606
547object & 607/*
548object::operator =(const object &src) 608 * copy_to first frees everything allocated by the dst object,
609 * and then copies the contents of itself into the second
610 * object, allocating what needs to be allocated. Basically, any
611 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
612 * if the first object is freed, the pointers in the new object
613 * will point at garbage.
614 */
615void
616object::copy_to (object *dst)
549{ 617{
550 bool is_freed = flag [FLAG_FREED]; 618 dst->remove ();
551 bool is_removed = flag [FLAG_REMOVED];
552
553 *(object_copy *)this = src; 619 *(object_copy *)dst = *this;
554
555 flag [FLAG_FREED] = is_freed;
556 flag [FLAG_REMOVED] = is_removed; 620 dst->flag [FLAG_REMOVED] = true;
557 621
558 /* Copy over key_values, if any. */ 622 /* Copy over key_values, if any. */
559 if (src.key_values) 623 if (key_values)
560 { 624 {
561 key_value *tail = 0; 625 key_value *tail = 0;
562 key_values = 0; 626 dst->key_values = 0;
563 627
564 for (key_value *i = src.key_values; i; i = i->next) 628 for (key_value *i = key_values; i; i = i->next)
565 { 629 {
566 key_value *new_link = new key_value; 630 key_value *new_link = new key_value;
567 631
568 new_link->next = 0; 632 new_link->next = 0;
569 new_link->key = i->key; 633 new_link->key = i->key;
570 new_link->value = i->value; 634 new_link->value = i->value;
571 635
572 /* Try and be clever here, too. */ 636 /* Try and be clever here, too. */
573 if (!key_values) 637 if (!dst->key_values)
574 { 638 {
575 key_values = new_link; 639 dst->key_values = new_link;
576 tail = new_link; 640 tail = new_link;
577 } 641 }
578 else 642 else
579 { 643 {
580 tail->next = new_link; 644 tail->next = new_link;
581 tail = new_link; 645 tail = new_link;
582 } 646 }
583 } 647 }
584 } 648 }
585}
586
587/*
588 * copy_to first frees everything allocated by the dst object,
589 * and then copies the contents of itself into the second
590 * object, allocating what needs to be allocated. Basically, any
591 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
592 * if the first object is freed, the pointers in the new object
593 * will point at garbage.
594 */
595void
596object::copy_to (object *dst)
597{
598 *dst = *this;
599 649
600 if (speed < 0) 650 if (speed < 0)
601 dst->speed_left -= rndm (); 651 dst->speed_left -= rndm ();
602 652
603 dst->set_speed (dst->speed); 653 dst->activate ();
604} 654}
605 655
606void 656void
607object::instantiate () 657object::instantiate ()
608{ 658{
625object * 675object *
626object::clone () 676object::clone ()
627{ 677{
628 object *neu = create (); 678 object *neu = create ();
629 copy_to (neu); 679 copy_to (neu);
680 neu->map = map; // not copied by copy_to
630 return neu; 681 return neu;
631} 682}
632 683
633/* 684/*
634 * If an object with the IS_TURNABLE() flag needs to be turned due 685 * If an object with the IS_TURNABLE() flag needs to be turned due
685 * UP_OBJ_FACE: only the objects face has changed. 736 * UP_OBJ_FACE: only the objects face has changed.
686 */ 737 */
687void 738void
688update_object (object *op, int action) 739update_object (object *op, int action)
689{ 740{
690 if (op == NULL) 741 if (!op)
691 { 742 {
692 /* this should never happen */ 743 /* this should never happen */
693 LOG (llevDebug, "update_object() called for NULL object.\n"); 744 LOG (llevError | logBacktrace, "update_object() called for NULL object.\n");
694 return; 745 return;
695 } 746 }
696 747
697 if (op->env) 748 if (!op->is_on_map ())
698 { 749 {
699 /* Animation is currently handled by client, so nothing 750 /* Animation is currently handled by client, so nothing
700 * to do in this case. 751 * to do in this case.
701 */ 752 */
702 return; 753 return;
703 } 754 }
704
705 /* If the map is saving, don't do anything as everything is
706 * going to get freed anyways.
707 */
708 if (!op->map || op->map->in_memory == MAP_SAVING)
709 return;
710 755
711 /* make sure the object is within map boundaries */ 756 /* make sure the object is within map boundaries */
712 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height) 757 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
713 { 758 {
714 LOG (llevError, "update_object() called for object out of map!\n"); 759 LOG (llevError, "update_object() called for object out of map!\n");
725 else if (action == UP_OBJ_INSERT) 770 else if (action == UP_OBJ_INSERT)
726 { 771 {
727 // this is likely overkill, TODO: revisit (schmorp) 772 // this is likely overkill, TODO: revisit (schmorp)
728 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW)) 773 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
729 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC)) 774 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
730 || (op->type == PLAYER && !(m.flags_ & P_PLAYER)) 775 || (op->is_player () && !(m.flags_ & P_PLAYER))
731 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE)) 776 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
732 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE)) 777 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
733 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC)) 778 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
734 || (m.move_on | op->move_on ) != m.move_on 779 || (m.move_on | op->move_on ) != m.move_on
735 || (m.move_off | op->move_off ) != m.move_off 780 || (m.move_off | op->move_off ) != m.move_off
736 || (m.move_slow | op->move_slow) != m.move_slow 781 || (m.move_slow | op->move_slow) != m.move_slow
737 /* This isn't perfect, but I don't expect a lot of objects to 782 /* This isn't perfect, but I don't expect a lot of objects to
738 * to have move_allow right now. 783 * have move_allow right now.
739 */ 784 */
740 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block 785 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
741 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp) 786 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
742 m.flags_ = 0; 787 m.invalidate ();
743 } 788 }
744 /* if the object is being removed, we can't make intelligent 789 /* if the object is being removed, we can't make intelligent
745 * decisions, because remove_ob can't really pass the object 790 * decisions, because remove_ob can't really pass the object
746 * that is being removed. 791 * that is being removed.
747 */ 792 */
748 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 793 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
749 m.flags_ = 0; 794 m.invalidate ();
750 else if (action == UP_OBJ_FACE) 795 else if (action == UP_OBJ_FACE)
751 /* Nothing to do for that case */ ; 796 /* Nothing to do for that case */ ;
752 else 797 else
753 LOG (llevError, "update_object called with invalid action: %d\n", action); 798 LOG (llevError, "update_object called with invalid action: %d\n", action);
754 799
758 803
759object::object () 804object::object ()
760{ 805{
761 SET_FLAG (this, FLAG_REMOVED); 806 SET_FLAG (this, FLAG_REMOVED);
762 807
763 expmul = 1.0; 808 //expmul = 1.0; declared const for the time being
764 face = blank_face; 809 face = blank_face;
765} 810}
766 811
767object::~object () 812object::~object ()
768{ 813{
798 /* If already on active list, don't do anything */ 843 /* If already on active list, don't do anything */
799 if (active) 844 if (active)
800 return; 845 return;
801 846
802 if (has_active_speed ()) 847 if (has_active_speed ())
848 {
849 if (flag [FLAG_FREED])
850 LOG (llevError | logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
851
803 actives.insert (this); 852 actives.insert (this);
853 }
804} 854}
805 855
806void 856void
807object::activate_recursive () 857object::activate_recursive ()
808{ 858{
857object::destroy_inv (bool drop_to_ground) 907object::destroy_inv (bool drop_to_ground)
858{ 908{
859 // need to check first, because the checks below might segfault 909 // need to check first, because the checks below might segfault
860 // as we might be on an invalid mapspace and crossfire code 910 // as we might be on an invalid mapspace and crossfire code
861 // is too buggy to ensure that the inventory is empty. 911 // is too buggy to ensure that the inventory is empty.
862 // corollary: if you create arrows etc. with stuff in tis inventory, 912 // corollary: if you create arrows etc. with stuff in its inventory,
863 // cf will crash below with off-map x and y 913 // cf will crash below with off-map x and y
864 if (!inv) 914 if (!inv)
865 return; 915 return;
866 916
867 /* Only if the space blocks everything do we not process - 917 /* Only if the space blocks everything do we not process -
868 * if some form of movement is allowed, let objects 918 * if some form of movement is allowed, let objects
869 * drop on that space. 919 * drop on that space.
870 */ 920 */
871 if (!drop_to_ground 921 if (!drop_to_ground
872 || !map 922 || !map
873 || map->in_memory != MAP_IN_MEMORY 923 || map->in_memory != MAP_ACTIVE
874 || map->nodrop 924 || map->no_drop
875 || ms ().move_block == MOVE_ALL) 925 || ms ().move_block == MOVE_ALL)
876 { 926 {
877 while (inv) 927 while (inv)
878 {
879 inv->destroy_inv (drop_to_ground);
880 inv->destroy (); 928 inv->destroy ();
881 }
882 } 929 }
883 else 930 else
884 { /* Put objects in inventory onto this space */ 931 { /* Put objects in inventory onto this space */
885 while (inv) 932 while (inv)
886 { 933 {
904 object *op = new object; 951 object *op = new object;
905 op->link (); 952 op->link ();
906 return op; 953 return op;
907} 954}
908 955
956static struct freed_map : maptile
957{
958 freed_map ()
959 {
960 path = "<freed objects map>";
961 name = "/internal/freed_objects_map";
962 width = 3;
963 height = 3;
964 no_drop = 1;
965 no_reset = 1;
966
967 alloc ();
968 in_memory = MAP_ACTIVE;
969 }
970
971 ~freed_map ()
972 {
973 destroy ();
974 }
975} freed_map; // freed objects are moved here to avoid crashes
976
909void 977void
910object::do_destroy () 978object::do_destroy ()
911{ 979{
912 attachable::do_destroy ();
913
914 if (flag [FLAG_IS_LINKED]) 980 if (flag [FLAG_IS_LINKED])
915 remove_button_link (this); 981 remove_link ();
916 982
917 if (flag [FLAG_FRIENDLY]) 983 if (flag [FLAG_FRIENDLY])
918 remove_friendly_object (this); 984 remove_friendly_object (this);
919 985
920 if (!flag [FLAG_REMOVED])
921 remove (); 986 remove ();
922 987
923 destroy_inv (true); 988 attachable::do_destroy ();
924 989
925 deactivate (); 990 deactivate ();
926 unlink (); 991 unlink ();
927 992
928 flag [FLAG_FREED] = 1; 993 flag [FLAG_FREED] = 1;
929 994
930 // hack to ensure that freed objects still have a valid map 995 // hack to ensure that freed objects still have a valid map
931 {
932 static maptile *freed_map; // freed objects are moved here to avoid crashes
933
934 if (!freed_map)
935 {
936 freed_map = new maptile;
937
938 freed_map->path = "<freed objects map>";
939 freed_map->name = "/internal/freed_objects_map";
940 freed_map->width = 3;
941 freed_map->height = 3;
942 freed_map->nodrop = 1;
943
944 freed_map->alloc ();
945 freed_map->in_memory = MAP_IN_MEMORY;
946 }
947
948 map = freed_map; 996 map = &freed_map;
949 x = 1; 997 x = 1;
950 y = 1; 998 y = 1;
951 }
952 999
953 if (more) 1000 if (more)
954 { 1001 {
955 more->destroy (); 1002 more->destroy ();
956 more = 0; 1003 more = 0;
964 attacked_by = 0; 1011 attacked_by = 0;
965 current_weapon = 0; 1012 current_weapon = 0;
966} 1013}
967 1014
968void 1015void
969object::destroy (bool destroy_inventory) 1016object::destroy ()
970{ 1017{
971 if (destroyed ()) 1018 if (destroyed ())
972 return; 1019 return;
973 1020
974 if (destroy_inventory) 1021 if (!is_head () && !head->destroyed ())
1022 {
1023 LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
1024 head->destroy ();
1025 return;
1026 }
1027
975 destroy_inv (false); 1028 destroy_inv (false);
976 1029
977 if (is_head ()) 1030 if (is_head ())
978 if (sound_destroy) 1031 if (sound_destroy)
979 play_sound (sound_destroy); 1032 play_sound (sound_destroy);
980 else if (flag [FLAG_MONSTER]) 1033 else if (flag [FLAG_MONSTER])
981 play_sound (sound_find ("monster_destroy")); // quick hack, too lazy to create a generic mechanism 1034 play_sound (sound_find ("monster_destroy")); // quick hack, too lazy to create a generic mechanism
982 1035
983 attachable::destroy (); 1036 attachable::destroy ();
984}
985
986/*
987 * sub_weight() recursively (outwards) subtracts a number from the
988 * weight of an object (and what is carried by it's environment(s)).
989 */
990void
991sub_weight (object *op, signed long weight)
992{
993 while (op != NULL)
994 {
995 if (op->type == CONTAINER)
996 weight = (signed long) (weight * (100 - op->stats.Str) / 100);
997
998 op->carrying -= weight;
999 op = op->env;
1000 }
1001} 1037}
1002 1038
1003/* op->remove (): 1039/* op->remove ():
1004 * This function removes the object op from the linked list of objects 1040 * This function removes the object op from the linked list of objects
1005 * which it is currently tied to. When this function is done, the 1041 * which it is currently tied to. When this function is done, the
1008 * the previous environment. 1044 * the previous environment.
1009 */ 1045 */
1010void 1046void
1011object::do_remove () 1047object::do_remove ()
1012{ 1048{
1013 object *tmp, *last = 0; 1049 if (flag [FLAG_REMOVED])
1014 object *otmp;
1015
1016 if (QUERY_FLAG (this, FLAG_REMOVED))
1017 return; 1050 return;
1018 1051
1019 SET_FLAG (this, FLAG_REMOVED);
1020 INVOKE_OBJECT (REMOVE, this); 1052 INVOKE_OBJECT (REMOVE, this);
1053
1054 flag [FLAG_REMOVED] = true;
1021 1055
1022 if (more) 1056 if (more)
1023 more->remove (); 1057 more->remove ();
1024 1058
1025 /* 1059 /*
1026 * In this case, the object to be removed is in someones 1060 * In this case, the object to be removed is in someones
1027 * inventory. 1061 * inventory.
1028 */ 1062 */
1029 if (env) 1063 if (env)
1030 { 1064 {
1031 if (nrof) 1065 flag [FLAG_REMOVED] = false; // hack around the issue of visible_to checking flag_removed
1032 sub_weight (env, weight * nrof); 1066 if (object *pl = visible_to ())
1033 else 1067 esrv_del_item (pl->contr, count);
1034 sub_weight (env, weight + carrying); 1068 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
1069
1070 adjust_weight (env, -total_weight ());
1071
1072 object *pl = in_player ();
1073
1074 /* we set up values so that it could be inserted into
1075 * the map, but we don't actually do that - it is up
1076 * to the caller to decide what we want to do.
1077 */
1078 map = env->map;
1079 x = env->x;
1080 y = env->y;
1081
1082 // make sure cmov optimisation is applicable
1083 *(above ? &above->below : &env->inv) = below;
1084 *(below ? &below->above : &above ) = above; // &above is just a dummy
1085
1086 above = 0;
1087 below = 0;
1088 env = 0;
1035 1089
1036 /* NO_FIX_PLAYER is set when a great many changes are being 1090 /* NO_FIX_PLAYER is set when a great many changes are being
1037 * made to players inventory. If set, avoiding the call 1091 * made to players inventory. If set, avoiding the call
1038 * to save cpu time. 1092 * to save cpu time.
1039 */ 1093 */
1040 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1094 if (pl)
1095 if (pl->is_player () && (glow_radius || !QUERY_FLAG (pl, FLAG_NO_FIX_PLAYER)))
1096 {
1041 otmp->update_stats (); 1097 pl->update_stats ();
1042 1098
1043 if (above) 1099 if (glow_radius && pl->is_on_map ())
1044 above->below = below; 1100 update_all_los (pl->map, pl->x, pl->y);
1045 else 1101 }
1046 env->inv = below;
1047
1048 if (below)
1049 below->above = above;
1050
1051 /* we set up values so that it could be inserted into
1052 * the map, but we don't actually do that - it is up
1053 * to the caller to decide what we want to do.
1054 */
1055 x = env->x, y = env->y;
1056 map = env->map;
1057 above = 0, below = 0;
1058 env = 0;
1059 } 1102 }
1060 else if (map) 1103 else if (map)
1061 { 1104 {
1062 if (type == PLAYER)
1063 {
1064 // leaving a spot always closes any open container on the ground
1065 if (container && !container->env)
1066 // this causes spurious floorbox updates, but it ensures
1067 // that the CLOSE event is being sent.
1068 close_container ();
1069
1070 --map->players;
1071 map->touch ();
1072 }
1073
1074 map->dirty = true; 1105 map->dirty = true;
1075 mapspace &ms = this->ms (); 1106 mapspace &ms = this->ms ();
1076 1107
1108 if (object *pl = ms.player ())
1109 {
1110 if (is_player ())
1111 {
1112 if (!flag [FLAG_WIZPASS])
1113 ms.smell = ++mapspace::smellcount; // remember the smell of the player
1114
1115 // leaving a spot always closes any open container on the ground
1116 if (container && !container->env)
1117 // this causes spurious floorbox updates, but it ensures
1118 // that the CLOSE event is being sent.
1119 close_container ();
1120
1121 --map->players;
1122 map->touch ();
1123 }
1124 else if (pl->container_ () == this)
1125 {
1126 // removing a container should close it
1127 close_container ();
1128 }
1129
1130 esrv_del_item (pl->contr, count);
1131 }
1132
1077 /* link the object above us */ 1133 /* link the object above us */
1078 if (above) 1134 // re-link, make sure compiler can easily use cmove
1079 above->below = below; 1135 *(above ? &above->below : &ms.top) = below;
1080 else 1136 *(below ? &below->above : &ms.bot) = above;
1081 ms.top = below; /* we were top, set new top */
1082
1083 /* Relink the object below us, if there is one */
1084 if (below)
1085 below->above = above;
1086 else
1087 {
1088 /* Nothing below, which means we need to relink map object for this space
1089 * use translated coordinates in case some oddness with map tiling is
1090 * evident
1091 */
1092 if (GET_MAP_OB (map, x, y) != this)
1093 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1094
1095 ms.bot = above; /* goes on above it. */
1096 }
1097 1137
1098 above = 0; 1138 above = 0;
1099 below = 0; 1139 below = 0;
1100 1140
1141 ms.invalidate ();
1142
1101 if (map->in_memory == MAP_SAVING) 1143 if (map->in_memory == MAP_SAVING)
1102 return; 1144 return;
1103 1145
1104 int check_walk_off = !flag [FLAG_NO_APPLY]; 1146 int check_walk_off = !flag [FLAG_NO_APPLY];
1105 1147
1106 if (object *pl = ms.player ()) 1148 if (object *pl = ms.player ())
1107 { 1149 {
1108 if (pl->container == this) 1150 if (pl->container_ () == this)
1109 /* If a container that the player is currently using somehow gets 1151 /* If a container that the player is currently using somehow gets
1110 * removed (most likely destroyed), update the player view 1152 * removed (most likely destroyed), update the player view
1111 * appropriately. 1153 * appropriately.
1112 */ 1154 */
1113 pl->close_container (); 1155 pl->close_container ();
1114 1156
1157 //TODO: the floorbox prev/next might need updating
1158 //esrv_del_item (pl->contr, count);
1159 //TODO: update floorbox to preserve ordering
1160 if (pl->contr->ns)
1115 pl->contr->ns->floorbox_update (); 1161 pl->contr->ns->floorbox_update ();
1116 } 1162 }
1117 1163
1164 if (check_walk_off)
1118 for (tmp = ms.bot; tmp; tmp = tmp->above) 1165 for (object *above, *tmp = ms.bot; tmp; tmp = above)
1119 { 1166 {
1167 above = tmp->above;
1168
1120 /* No point updating the players look faces if he is the object 1169 /* No point updating the players look faces if he is the object
1121 * being removed. 1170 * being removed.
1122 */ 1171 */
1123 1172
1124 /* See if object moving off should effect something */ 1173 /* See if object moving off should effect something */
1125 if (check_walk_off
1126 && ((move_type & tmp->move_off) 1174 if ((move_type & tmp->move_off)
1127 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1175 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)
1128 {
1129 move_apply (tmp, this, 0); 1176 move_apply (tmp, this, 0);
1130
1131 if (destroyed ())
1132 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1133 } 1177 }
1134 1178
1135 last = tmp; 1179 if (affects_los ())
1136 }
1137
1138 /* last == NULL if there are no objects on this space */
1139 //TODO: this makes little sense, why only update the topmost object?
1140 if (!last)
1141 map->at (x, y).flags_ = 0;
1142 else
1143 update_object (last, UP_OBJ_REMOVE);
1144
1145 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1146 update_all_los (map, x, y); 1180 update_all_los (map, x, y);
1147 } 1181 }
1148} 1182}
1149 1183
1150/* 1184/*
1164 if (!top) 1198 if (!top)
1165 for (top = op; top && top->above; top = top->above) 1199 for (top = op; top && top->above; top = top->above)
1166 ; 1200 ;
1167 1201
1168 for (; top; top = top->below) 1202 for (; top; top = top->below)
1169 {
1170 if (top == op)
1171 continue;
1172
1173 if (object::can_merge (op, top)) 1203 if (object::can_merge (op, top))
1174 { 1204 {
1175 top->nrof += op->nrof; 1205 top->nrof += op->nrof;
1176 1206
1177/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/ 1207 if (object *pl = top->visible_to ())
1178 op->weight = 0; /* Don't want any adjustements now */ 1208 esrv_update_item (UPD_NROF, pl, top);
1209
1210 op->weight = 0; // cancel the addition above
1211 op->carrying = 0; // must be 0 already
1212
1179 op->destroy (); 1213 op->destroy ();
1214
1180 return top; 1215 return top;
1181 } 1216 }
1182 }
1183 1217
1184 return 0; 1218 return 0;
1185} 1219}
1186 1220
1187void 1221void
1212 * job preparing multi-part monsters. 1246 * job preparing multi-part monsters.
1213 */ 1247 */
1214object * 1248object *
1215insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1249insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1216{ 1250{
1251 op->remove ();
1252
1217 for (object *tmp = op->head_ (); tmp; tmp = tmp->more) 1253 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1218 { 1254 {
1219 tmp->x = x + tmp->arch->x; 1255 tmp->x = x + tmp->arch->x;
1220 tmp->y = y + tmp->arch->y; 1256 tmp->y = y + tmp->arch->y;
1221 } 1257 }
1244 * just 'op' otherwise 1280 * just 'op' otherwise
1245 */ 1281 */
1246object * 1282object *
1247insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1283insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1248{ 1284{
1249 assert (!op->flag [FLAG_FREED]);
1250
1251 object *top, *floor = NULL;
1252
1253 op->remove (); 1285 op->remove ();
1286
1287 if (m == &freed_map)//D TODO: remove soon
1288 {//D
1289 LOG (llevError | logBacktrace, "tries to insret object on freed objects map: %s", op->debug_desc ());//D
1290 }//D
1254 1291
1255 /* Ideally, the caller figures this out. However, it complicates a lot 1292 /* Ideally, the caller figures this out. However, it complicates a lot
1256 * of areas of callers (eg, anything that uses find_free_spot would now 1293 * of areas of callers (eg, anything that uses find_free_spot would now
1257 * need extra work 1294 * need extra work
1258 */ 1295 */
1296 maptile *newmap = m;
1259 if (!xy_normalise (m, op->x, op->y)) 1297 if (!xy_normalise (newmap, op->x, op->y))
1260 { 1298 {
1261 op->destroy (); 1299 op->head_ ()->destroy ();// remove head_ once all tail object destroyers found
1262 return 0; 1300 return 0;
1263 } 1301 }
1264 1302
1265 if (object *more = op->more) 1303 if (object *more = op->more)
1266 if (!insert_ob_in_map (more, m, originator, flag)) 1304 if (!insert_ob_in_map (more, m, originator, flag))
1267 return 0; 1305 return 0;
1268 1306
1269 CLEAR_FLAG (op, FLAG_REMOVED); 1307 op->flag [FLAG_REMOVED] = false;
1270 1308 op->env = 0;
1271 op->map = m; 1309 op->map = newmap;
1310
1272 mapspace &ms = op->ms (); 1311 mapspace &ms = op->ms ();
1273 1312
1274 /* this has to be done after we translate the coordinates. 1313 /* this has to be done after we translate the coordinates.
1275 */ 1314 */
1276 if (op->nrof && !(flag & INS_NO_MERGE)) 1315 if (op->nrof && !(flag & INS_NO_MERGE))
1277 for (object *tmp = ms.bot; tmp; tmp = tmp->above) 1316 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1278 if (object::can_merge (op, tmp)) 1317 if (object::can_merge (op, tmp))
1279 { 1318 {
1319 // TODO: we actually want to update tmp, not op,
1320 // but some caller surely breaks when we return tmp
1321 // from here :/
1280 op->nrof += tmp->nrof; 1322 op->nrof += tmp->nrof;
1281 tmp->destroy (); 1323 tmp->destroy ();
1282 } 1324 }
1283 1325
1284 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1326 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1293 { 1335 {
1294 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n"); 1336 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1295 abort (); 1337 abort ();
1296 } 1338 }
1297 1339
1340 if (!originator->is_on_map ())
1341 {
1342 LOG (llevError, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
1343 op->debug_desc (), originator->debug_desc ());
1344 abort ();
1345 }
1346
1298 op->above = originator; 1347 op->above = originator;
1299 op->below = originator->below; 1348 op->below = originator->below;
1300
1301 if (op->below)
1302 op->below->above = op;
1303 else
1304 ms.bot = op;
1305
1306 /* since *below* originator, no need to update top */
1307 originator->below = op; 1349 originator->below = op;
1350
1351 *(op->below ? &op->below->above : &ms.bot) = op;
1308 } 1352 }
1309 else 1353 else
1310 { 1354 {
1311 top = ms.bot; 1355 object *floor = 0;
1356 object *top = ms.top;
1312 1357
1313 /* If there are other objects, then */ 1358 /* If there are other objects, then */
1314 if (top) 1359 if (top)
1315 { 1360 {
1316 object *last = 0;
1317
1318 /* 1361 /*
1319 * If there are multiple objects on this space, we do some trickier handling. 1362 * If there are multiple objects on this space, we do some trickier handling.
1320 * We've already dealt with merging if appropriate. 1363 * We've already dealt with merging if appropriate.
1321 * Generally, we want to put the new object on top. But if 1364 * Generally, we want to put the new object on top. But if
1322 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last 1365 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
1325 * once we get to them. This reduces the need to traverse over all of 1368 * once we get to them. This reduces the need to traverse over all of
1326 * them when adding another one - this saves quite a bit of cpu time 1369 * them when adding another one - this saves quite a bit of cpu time
1327 * when lots of spells are cast in one area. Currently, it is presumed 1370 * when lots of spells are cast in one area. Currently, it is presumed
1328 * that flying non pickable objects are spell objects. 1371 * that flying non pickable objects are spell objects.
1329 */ 1372 */
1330 for (top = ms.bot; top; top = top->above) 1373 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1331 { 1374 {
1332 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1375 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) || QUERY_FLAG (tmp, FLAG_OVERLAY_FLOOR))
1333 floor = top; 1376 floor = tmp;
1334 1377
1335 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1378 if (QUERY_FLAG (tmp, FLAG_NO_PICK) && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (tmp, FLAG_IS_FLOOR))
1336 { 1379 {
1337 /* We insert above top, so we want this object below this */ 1380 /* We insert above top, so we want this object below this */
1338 top = top->below; 1381 top = tmp->below;
1339 break; 1382 break;
1340 } 1383 }
1341 1384
1342 last = top; 1385 top = tmp;
1343 } 1386 }
1344
1345 /* Don't want top to be NULL, so set it to the last valid object */
1346 top = last;
1347 1387
1348 /* We let update_position deal with figuring out what the space 1388 /* We let update_position deal with figuring out what the space
1349 * looks like instead of lots of conditions here. 1389 * looks like instead of lots of conditions here.
1350 * makes things faster, and effectively the same result. 1390 * makes things faster, and effectively the same result.
1351 */ 1391 */
1358 */ 1398 */
1359 if (!(flag & INS_ON_TOP) 1399 if (!(flag & INS_ON_TOP)
1360 && ms.flags () & P_BLOCKSVIEW 1400 && ms.flags () & P_BLOCKSVIEW
1361 && (op->face && !faces [op->face].visibility)) 1401 && (op->face && !faces [op->face].visibility))
1362 { 1402 {
1403 object *last;
1404
1363 for (last = top; last != floor; last = last->below) 1405 for (last = top; last != floor; last = last->below)
1364 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1406 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1365 break; 1407 break;
1366 1408
1367 /* Check to see if we found the object that blocks view, 1409 /* Check to see if we found the object that blocks view,
1375 } /* If objects on this space */ 1417 } /* If objects on this space */
1376 1418
1377 if (flag & INS_ABOVE_FLOOR_ONLY) 1419 if (flag & INS_ABOVE_FLOOR_ONLY)
1378 top = floor; 1420 top = floor;
1379 1421
1380 /* Top is the object that our object (op) is going to get inserted above. 1422 // insert object above top, or bottom-most if top = 0
1381 */
1382
1383 /* First object on this space */
1384 if (!top) 1423 if (!top)
1385 { 1424 {
1425 op->below = 0;
1386 op->above = ms.bot; 1426 op->above = ms.bot;
1387
1388 if (op->above)
1389 op->above->below = op;
1390
1391 op->below = 0;
1392 ms.bot = op; 1427 ms.bot = op;
1428
1429 *(op->above ? &op->above->below : &ms.top) = op;
1393 } 1430 }
1394 else 1431 else
1395 { /* get inserted into the stack above top */ 1432 {
1396 op->above = top->above; 1433 op->above = top->above;
1397
1398 if (op->above)
1399 op->above->below = op; 1434 top->above = op;
1400 1435
1401 op->below = top; 1436 op->below = top;
1402 top->above = op; 1437 *(op->above ? &op->above->below : &ms.top) = op;
1403 } 1438 }
1439 }
1404 1440
1405 if (!op->above) 1441 if (op->is_player ())
1406 ms.top = op;
1407 } /* else not INS_BELOW_ORIGINATOR */
1408
1409 if (op->type == PLAYER)
1410 { 1442 {
1411 op->contr->do_los = 1; 1443 op->contr->do_los = 1;
1412 ++op->map->players; 1444 ++op->map->players;
1413 op->map->touch (); 1445 op->map->touch ();
1414 } 1446 }
1415 1447
1416 op->map->dirty = true; 1448 op->map->dirty = true;
1417 1449
1418 if (object *pl = ms.player ()) 1450 if (object *pl = ms.player ())
1451 //TODO: the floorbox prev/next might need updating
1452 //esrv_send_item (pl, op);
1453 //TODO: update floorbox to preserve ordering
1454 if (pl->contr->ns)
1419 pl->contr->ns->floorbox_update (); 1455 pl->contr->ns->floorbox_update ();
1420 1456
1421 /* If this object glows, it may affect lighting conditions that are 1457 /* If this object glows, it may affect lighting conditions that are
1422 * visible to others on this map. But update_all_los is really 1458 * visible to others on this map. But update_all_los is really
1423 * an inefficient way to do this, as it means los for all players 1459 * an inefficient way to do this, as it means los for all players
1424 * on the map will get recalculated. The players could very well 1460 * on the map will get recalculated. The players could very well
1425 * be far away from this change and not affected in any way - 1461 * be far away from this change and not affected in any way -
1426 * this should get redone to only look for players within range, 1462 * this should get redone to only look for players within range,
1427 * or just updating the P_UPTODATE for spaces within this area 1463 * or just updating the P_UPTODATE for spaces within this area
1428 * of effect may be sufficient. 1464 * of effect may be sufficient.
1429 */ 1465 */
1430 if (op->map->darkness && (op->glow_radius != 0)) 1466 if (op->affects_los ())
1467 {
1468 op->ms ().invalidate ();
1431 update_all_los (op->map, op->x, op->y); 1469 update_all_los (op->map, op->x, op->y);
1470 }
1432 1471
1433 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1472 /* updates flags (blocked, alive, no magic, etc) for this map space */
1434 update_object (op, UP_OBJ_INSERT); 1473 update_object (op, UP_OBJ_INSERT);
1435 1474
1436 INVOKE_OBJECT (INSERT, op); 1475 INVOKE_OBJECT (INSERT, op);
1443 * blocked() and wall() work properly), and these flags are updated by 1482 * blocked() and wall() work properly), and these flags are updated by
1444 * update_object(). 1483 * update_object().
1445 */ 1484 */
1446 1485
1447 /* if this is not the head or flag has been passed, don't check walk on status */ 1486 /* if this is not the head or flag has been passed, don't check walk on status */
1448 if (!(flag & INS_NO_WALK_ON) && op->head_ () == op) 1487 if (!(flag & INS_NO_WALK_ON) && op->is_head ())
1449 { 1488 {
1450 if (check_move_on (op, originator)) 1489 if (check_move_on (op, originator))
1451 return 0; 1490 return 0;
1452 1491
1453 /* If we are a multi part object, lets work our way through the check 1492 /* If we are a multi part object, lets work our way through the check
1464/* this function inserts an object in the map, but if it 1503/* this function inserts an object in the map, but if it
1465 * finds an object of its own type, it'll remove that one first. 1504 * finds an object of its own type, it'll remove that one first.
1466 * op is the object to insert it under: supplies x and the map. 1505 * op is the object to insert it under: supplies x and the map.
1467 */ 1506 */
1468void 1507void
1469replace_insert_ob_in_map (const char *arch_string, object *op) 1508replace_insert_ob_in_map (shstr_tmp archname, object *op)
1470{ 1509{
1471 object *tmp, *tmp1;
1472
1473 /* first search for itself and remove any old instances */ 1510 /* first search for itself and remove any old instances */
1474 1511
1475 for (tmp = op->ms ().bot; tmp; tmp = tmp->above) 1512 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1476 if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */ 1513 if (tmp->arch->archname == archname) /* same archetype */
1477 tmp->destroy (); 1514 tmp->destroy ();
1478 1515
1479 tmp1 = arch_to_object (archetype::find (arch_string)); 1516 object *tmp = arch_to_object (archetype::find (archname));
1480 1517
1481 tmp1->x = op->x; 1518 tmp->x = op->x;
1482 tmp1->y = op->y; 1519 tmp->y = op->y;
1520
1483 insert_ob_in_map (tmp1, op->map, op, 0); 1521 insert_ob_in_map (tmp, op->map, op, 0);
1484} 1522}
1485 1523
1486object * 1524object *
1487object::insert_at (object *where, object *originator, int flags) 1525object::insert_at (object *where, object *originator, int flags)
1488{ 1526{
1527 if (where->env)
1528 return where->env->insert (this);
1529 else
1489 return where->map->insert (this, where->x, where->y, originator, flags); 1530 return where->map->insert (this, where->x, where->y, originator, flags);
1490} 1531}
1491 1532
1492/* 1533/*
1493 * get_split_ob(ob,nr) splits up ob into two parts. The part which
1494 * is returned contains nr objects, and the remaining parts contains
1495 * the rest (or is removed and freed if that number is 0).
1496 * On failure, NULL is returned, and the reason put into the
1497 * global static errmsg array.
1498 */
1499object *
1500get_split_ob (object *orig_ob, uint32 nr)
1501{
1502 object *newob;
1503 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1504
1505 if (orig_ob->nrof < nr)
1506 {
1507 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1508 return NULL;
1509 }
1510
1511 newob = object_create_clone (orig_ob);
1512
1513 if ((orig_ob->nrof -= nr) < 1)
1514 orig_ob->destroy (1);
1515 else if (!is_removed)
1516 {
1517 if (orig_ob->env != NULL)
1518 sub_weight (orig_ob->env, orig_ob->weight * nr);
1519 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY)
1520 {
1521 strcpy (errmsg, "Tried to split object whose map is not in memory.");
1522 LOG (llevDebug, "Error, Tried to split object whose map is not in memory.\n");
1523 return NULL;
1524 }
1525 }
1526
1527 newob->nrof = nr;
1528
1529 return newob;
1530}
1531
1532/*
1533 * decrease_ob_nr(object, number) decreases a specified number from 1534 * decrease(object, number) decreases a specified number from
1534 * the amount of an object. If the amount reaches 0, the object 1535 * the amount of an object. If the amount reaches 0, the object
1535 * is subsequently removed and freed. 1536 * is subsequently removed and freed.
1536 * 1537 *
1537 * Return value: 'op' if something is left, NULL if the amount reached 0 1538 * Return value: 'op' if something is left, NULL if the amount reached 0
1538 */ 1539 */
1540bool
1541object::decrease (sint32 nr)
1542{
1543 if (!nr)
1544 return true;
1545
1546 nr = min (nr, nrof);
1547
1548 if (nrof > nr)
1549 {
1550 nrof -= nr;
1551 adjust_weight (env, -weight * max (1, nr)); // carrying == 0
1552
1553 if (object *pl = visible_to ())
1554 esrv_update_item (UPD_NROF, pl, this);
1555
1556 return true;
1557 }
1558 else
1559 {
1560 destroy ();
1561 return false;
1562 }
1563}
1564
1565/*
1566 * split(ob,nr) splits up ob into two parts. The part which
1567 * is returned contains nr objects, and the remaining parts contains
1568 * the rest (or is removed and returned if that number is 0).
1569 * On failure, NULL is returned.
1570 */
1539object * 1571object *
1540decrease_ob_nr (object *op, uint32 i) 1572object::split (sint32 nr)
1541{ 1573{
1542 object *tmp; 1574 int have = number_of ();
1543 1575
1544 if (i == 0) /* objects with op->nrof require this check */ 1576 if (have < nr)
1545 return op; 1577 return 0;
1546 1578 else if (have == nr)
1547 if (i > op->nrof)
1548 i = op->nrof;
1549
1550 if (QUERY_FLAG (op, FLAG_REMOVED))
1551 op->nrof -= i;
1552 else if (op->env)
1553 { 1579 {
1554 /* is this object in the players inventory, or sub container
1555 * therein?
1556 */
1557 tmp = op->in_player ();
1558 /* nope. Is this a container the player has opened?
1559 * If so, set tmp to that player.
1560 * IMO, searching through all the players will mostly
1561 * likely be quicker than following op->env to the map,
1562 * and then searching the map for a player.
1563 */
1564 if (!tmp)
1565 for_all_players (pl)
1566 if (pl->ob->container == op->env)
1567 {
1568 tmp = pl->ob;
1569 break;
1570 }
1571
1572 if (i < op->nrof)
1573 {
1574 sub_weight (op->env, op->weight * i);
1575 op->nrof -= i;
1576 if (tmp)
1577 esrv_send_item (tmp, op);
1578 }
1579 else
1580 {
1581 op->remove (); 1580 remove ();
1582 op->nrof = 0; 1581 return this;
1583 if (tmp)
1584 esrv_del_item (tmp->contr, op->count);
1585 }
1586 } 1582 }
1587 else 1583 else
1588 { 1584 {
1589 object *above = op->above; 1585 decrease (nr);
1590 1586
1591 if (i < op->nrof) 1587 object *op = deep_clone ();
1592 op->nrof -= i; 1588 op->nrof = nr;
1593 else
1594 {
1595 op->remove ();
1596 op->nrof = 0;
1597 }
1598
1599 /* Since we just removed op, op->above is null */
1600 for (tmp = above; tmp; tmp = tmp->above)
1601 if (tmp->type == PLAYER)
1602 {
1603 if (op->nrof)
1604 esrv_send_item (tmp, op);
1605 else
1606 esrv_del_item (tmp->contr, op->count);
1607 }
1608 }
1609
1610 if (op->nrof)
1611 return op; 1589 return op;
1612 else
1613 {
1614 op->destroy ();
1615 return 0;
1616 }
1617}
1618
1619/*
1620 * add_weight(object, weight) adds the specified weight to an object,
1621 * and also updates how much the environment(s) is/are carrying.
1622 */
1623void
1624add_weight (object *op, signed long weight)
1625{
1626 while (op != NULL)
1627 {
1628 if (op->type == CONTAINER)
1629 weight = (signed long) (weight * (100 - op->stats.Str) / 100);
1630
1631 op->carrying += weight;
1632 op = op->env;
1633 } 1590 }
1634} 1591}
1635 1592
1636object * 1593object *
1637insert_ob_in_ob (object *op, object *where) 1594insert_ob_in_ob (object *op, object *where)
1662 * be != op, if items are merged. -Tero 1619 * be != op, if items are merged. -Tero
1663 */ 1620 */
1664object * 1621object *
1665object::insert (object *op) 1622object::insert (object *op)
1666{ 1623{
1667 if (!QUERY_FLAG (op, FLAG_REMOVED))
1668 op->remove ();
1669
1670 if (op->more) 1624 if (op->more)
1671 { 1625 {
1672 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count); 1626 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);
1673 return op; 1627 return op;
1674 } 1628 }
1675 1629
1676 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL); 1630 op->remove ();
1677 CLEAR_FLAG (op, FLAG_REMOVED); 1631
1632 op->flag [FLAG_OBJ_ORIGINAL] = 0;
1678 1633
1679 if (op->nrof) 1634 if (op->nrof)
1680 {
1681 for (object *tmp = inv; tmp; tmp = tmp->below) 1635 for (object *tmp = inv; tmp; tmp = tmp->below)
1682 if (object::can_merge (tmp, op)) 1636 if (object::can_merge (tmp, op))
1683 { 1637 {
1684 /* return the original object and remove inserted object 1638 /* return the original object and remove inserted object
1685 (client needs the original object) */ 1639 (client needs the original object) */
1686 tmp->nrof += op->nrof; 1640 tmp->nrof += op->nrof;
1687 /* Weight handling gets pretty funky. Since we are adding to 1641
1688 * tmp->nrof, we need to increase the weight. 1642 if (object *pl = tmp->visible_to ())
1689 */ 1643 esrv_update_item (UPD_NROF, pl, tmp);
1644
1690 add_weight (this, op->weight * op->nrof); 1645 adjust_weight (this, op->total_weight ());
1691 SET_FLAG (op, FLAG_REMOVED); 1646
1692 op->destroy (); /* free the inserted object */ 1647 op->destroy ();
1693 op = tmp; 1648 op = tmp;
1694 op->remove (); /* and fix old object's links */ 1649 goto inserted;
1695 CLEAR_FLAG (op, FLAG_REMOVED);
1696 break;
1697 } 1650 }
1698 1651
1699 /* I assume combined objects have no inventory
1700 * We add the weight - this object could have just been removed
1701 * (if it was possible to merge). calling remove_ob will subtract
1702 * the weight, so we need to add it in again, since we actually do
1703 * the linking below
1704 */
1705 add_weight (this, op->weight * op->nrof);
1706 }
1707 else
1708 add_weight (this, (op->weight + op->carrying));
1709
1710 if (object *otmp = this->in_player ())
1711 if (otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1712 otmp->update_stats ();
1713
1714 op->owner = 0; // its his/hers now. period. 1652 op->owner = 0; // it's his/hers now. period.
1715 op->map = 0; 1653 op->map = 0;
1654 op->x = 0;
1655 op->y = 0;
1656
1657 op->above = 0;
1658 op->below = inv;
1716 op->env = this; 1659 op->env = this;
1717 op->above = 0;
1718 op->below = 0;
1719 op->x = op->y = 0;
1720 1660
1661 if (inv)
1662 inv->above = op;
1663
1664 inv = op;
1665
1666 op->flag [FLAG_REMOVED] = 0;
1667
1668 if (object *pl = op->visible_to ())
1669 esrv_send_item (pl, op);
1670
1671 adjust_weight (this, op->total_weight ());
1672
1673inserted:
1721 /* reset the light list and los of the players on the map */ 1674 /* reset the light list and los of the players on the map */
1722 if (op->glow_radius && map) 1675 if (op->glow_radius && is_on_map ())
1723 { 1676 {
1724#ifdef DEBUG_LIGHTS 1677 update_stats ();
1725 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1726#endif /* DEBUG_LIGHTS */
1727 if (map->darkness)
1728 update_all_los (map, x, y); 1678 update_all_los (map, x, y);
1729 }
1730
1731 /* Client has no idea of ordering so lets not bother ordering it here.
1732 * It sure simplifies this function...
1733 */
1734 if (!inv)
1735 inv = op;
1736 else
1737 { 1679 }
1738 op->below = inv; 1680 else if (is_player () && !flag [FLAG_NO_FIX_PLAYER])
1739 op->below->above = op; 1681 // if this is a player's inventory, update stats
1740 inv = op; 1682 update_stats ();
1741 }
1742 1683
1743 INVOKE_OBJECT (INSERT, this); 1684 INVOKE_OBJECT (INSERT, this);
1744 1685
1745 return op; 1686 return op;
1746} 1687}
1766 * on top. 1707 * on top.
1767 */ 1708 */
1768int 1709int
1769check_move_on (object *op, object *originator) 1710check_move_on (object *op, object *originator)
1770{ 1711{
1712 if (QUERY_FLAG (op, FLAG_NO_APPLY))
1713 return 0;
1714
1771 object *tmp; 1715 object *tmp;
1772 maptile *m = op->map; 1716 maptile *m = op->map;
1773 int x = op->x, y = op->y; 1717 int x = op->x, y = op->y;
1774 1718
1775 MoveType move_on, move_slow, move_block; 1719 mapspace &ms = m->at (x, y);
1776 1720
1777 if (QUERY_FLAG (op, FLAG_NO_APPLY)) 1721 ms.update ();
1778 return 0;
1779 1722
1780 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y); 1723 MoveType move_on = ms.move_on;
1781 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y); 1724 MoveType move_slow = ms.move_slow;
1782 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y); 1725 MoveType move_block = ms.move_block;
1783 1726
1784 /* if nothing on this space will slow op down or be applied, 1727 /* if nothing on this space will slow op down or be applied,
1785 * no need to do checking below. have to make sure move_type 1728 * no need to do checking below. have to make sure move_type
1786 * is set, as lots of objects don't have it set - we treat that 1729 * is set, as lots of objects don't have it set - we treat that
1787 * as walking. 1730 * as walking.
1798 return 0; 1741 return 0;
1799 1742
1800 /* The objects have to be checked from top to bottom. 1743 /* The objects have to be checked from top to bottom.
1801 * Hence, we first go to the top: 1744 * Hence, we first go to the top:
1802 */ 1745 */
1803 1746 for (object *next, *tmp = ms.top; tmp; tmp = next)
1804 for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1805 {
1806 /* Trim the search when we find the first other spell effect
1807 * this helps performance so that if a space has 50 spell objects,
1808 * we don't need to check all of them.
1809 */
1810 if ((tmp->move_type & MOVE_FLY_LOW) && QUERY_FLAG (tmp, FLAG_NO_PICK))
1811 break;
1812 } 1747 {
1748 next = tmp->below;
1813 1749
1814 for (; tmp; tmp = tmp->below)
1815 {
1816 if (tmp == op) 1750 if (tmp == op)
1817 continue; /* Can't apply yourself */ 1751 continue; /* Can't apply yourself */
1818 1752
1819 /* Check to see if one of the movement types should be slowed down. 1753 /* Check to see if one of the movement types should be slowed down.
1820 * Second check makes sure that the movement types not being slowed 1754 * Second check makes sure that the movement types not being slowed
1825 if (!QUERY_FLAG (op, FLAG_WIZPASS)) 1759 if (!QUERY_FLAG (op, FLAG_WIZPASS))
1826 { 1760 {
1827 if ((!op->move_type && tmp->move_slow & MOVE_WALK) || 1761 if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
1828 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0)) 1762 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
1829 { 1763 {
1830
1831 float
1832 diff = tmp->move_slow_penalty * fabs (op->speed); 1764 float diff = tmp->move_slow_penalty * fabs (op->speed);
1833 1765
1834 if (op->type == PLAYER) 1766 if (op->is_player ())
1835 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) || 1767 if ((tmp->flag [FLAG_IS_HILLY ] && find_skill_by_number (op, SK_CLIMBING)) ||
1836 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN))) 1768 (tmp->flag [FLAG_IS_WOODED] && find_skill_by_number (op, SK_WOODSMAN)))
1837 diff /= 4.0; 1769 diff /= 4.0;
1838 1770
1839 op->speed_left -= diff; 1771 op->speed_left -= diff;
1840 } 1772 }
1841 } 1773 }
1874 LOG (llevError, "Present_arch called outside map.\n"); 1806 LOG (llevError, "Present_arch called outside map.\n");
1875 return NULL; 1807 return NULL;
1876 } 1808 }
1877 1809
1878 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above) 1810 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1879 if (tmp->arch == at) 1811 if (tmp->arch->archname == at->archname)
1880 return tmp; 1812 return tmp;
1881 1813
1882 return NULL; 1814 return NULL;
1883} 1815}
1884 1816
1948 * The first matching object is returned, or NULL if none. 1880 * The first matching object is returned, or NULL if none.
1949 */ 1881 */
1950object * 1882object *
1951present_arch_in_ob (const archetype *at, const object *op) 1883present_arch_in_ob (const archetype *at, const object *op)
1952{ 1884{
1953 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below) 1885 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1954 if (tmp->arch == at) 1886 if (tmp->arch->archname == at->archname)
1955 return tmp; 1887 return tmp;
1956 1888
1957 return NULL; 1889 return NULL;
1958} 1890}
1959 1891
2047 * head of the object should correspond for the entire object. 1979 * head of the object should correspond for the entire object.
2048 */ 1980 */
2049 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block)) 1981 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))
2050 continue; 1982 continue;
2051 1983
2052 if (ob->blocked (m, pos.x, pos.y)) 1984 if (ob->blocked (pos.m, pos.x, pos.y))
2053 continue; 1985 continue;
2054 1986
2055 altern [index++] = i; 1987 altern [index++] = i;
2056 } 1988 }
2057 1989
2125 * there is capable of. 2057 * there is capable of.
2126 */ 2058 */
2127int 2059int
2128find_dir (maptile *m, int x, int y, object *exclude) 2060find_dir (maptile *m, int x, int y, object *exclude)
2129{ 2061{
2130 int i, max = SIZEOFFREE, mflags; 2062 int max = SIZEOFFREE, mflags;
2131
2132 sint16 nx, ny;
2133 object *tmp;
2134 maptile *mp;
2135
2136 MoveType blocked, move_type; 2063 MoveType move_type;
2137 2064
2138 if (exclude && exclude->head_ () != exclude) 2065 if (exclude && exclude->head_ () != exclude)
2139 { 2066 {
2140 exclude = exclude->head; 2067 exclude = exclude->head;
2141 move_type = exclude->move_type; 2068 move_type = exclude->move_type;
2144 { 2071 {
2145 /* If we don't have anything, presume it can use all movement types. */ 2072 /* If we don't have anything, presume it can use all movement types. */
2146 move_type = MOVE_ALL; 2073 move_type = MOVE_ALL;
2147 } 2074 }
2148 2075
2149 for (i = 1; i < max; i++) 2076 for (int i = 1; i < max; i++)
2150 { 2077 {
2151 mp = m; 2078 mapxy pos (m, x, y);
2152 nx = x + freearr_x[i]; 2079 pos.move (i);
2153 ny = y + freearr_y[i];
2154 2080
2155 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2081 if (!pos.normalise ())
2156
2157 if (mflags & P_OUT_OF_MAP)
2158 max = maxfree[i]; 2082 max = maxfree[i];
2159 else 2083 else
2160 { 2084 {
2161 mapspace &ms = mp->at (nx, ny); 2085 mapspace &ms = *pos;
2162 2086
2163 blocked = ms.move_block;
2164
2165 if ((move_type & blocked) == move_type) 2087 if ((move_type & ms.move_block) == move_type)
2166 max = maxfree[i]; 2088 max = maxfree [i];
2167 else if (mflags & P_IS_ALIVE) 2089 else if (ms.flags () & P_IS_ALIVE)
2168 { 2090 {
2169 for (tmp = ms.bot; tmp; tmp = tmp->above) 2091 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
2170 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER) 2092 if ((tmp->flag [FLAG_MONSTER] || tmp->is_player ())
2171 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude))) 2093 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))
2172 break;
2173
2174 if (tmp)
2175 return freedir[i]; 2094 return freedir [i];
2176 } 2095 }
2177 } 2096 }
2178 } 2097 }
2179 2098
2180 return 0; 2099 return 0;
2255 * This basically means that if direction is 15, then it could either go 2174 * This basically means that if direction is 15, then it could either go
2256 * direction 4, 14, or 16 to get back to where we are. 2175 * direction 4, 14, or 16 to get back to where we are.
2257 * Moved from spell_util.c to object.c with the other related direction 2176 * Moved from spell_util.c to object.c with the other related direction
2258 * functions. 2177 * functions.
2259 */ 2178 */
2260int reduction_dir[SIZEOFFREE][3] = { 2179static const int reduction_dir[SIZEOFFREE][3] = {
2261 {0, 0, 0}, /* 0 */ 2180 {0, 0, 0}, /* 0 */
2262 {0, 0, 0}, /* 1 */ 2181 {0, 0, 0}, /* 1 */
2263 {0, 0, 0}, /* 2 */ 2182 {0, 0, 0}, /* 2 */
2264 {0, 0, 0}, /* 3 */ 2183 {0, 0, 0}, /* 3 */
2265 {0, 0, 0}, /* 4 */ 2184 {0, 0, 0}, /* 4 */
2361int 2280int
2362can_pick (const object *who, const object *item) 2281can_pick (const object *who, const object *item)
2363{ 2282{
2364 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2283 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2365 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2284 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2366 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2285 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->is_player () || item->weight < who->weight / 3));
2367} 2286}
2368 2287
2369/* 2288/*
2370 * create clone from object to another 2289 * create clone from object to another
2371 */ 2290 */
2372object * 2291object *
2373object_create_clone (object *asrc) 2292object::deep_clone ()
2374{ 2293{
2375 object *dst = 0, *tmp, *src, *prev, *item; 2294 assert (("deep_clone called on non-head object", is_head ()));
2376 2295
2377 if (!asrc) 2296 object *dst = clone ();
2378 return 0;
2379 2297
2380 src = asrc->head_ (); 2298 object *prev = dst;
2381
2382 prev = 0;
2383 for (object *part = src; part; part = part->more) 2299 for (object *part = this->more; part; part = part->more)
2384 { 2300 {
2385 tmp = part->clone (); 2301 object *tmp = part->clone ();
2386 tmp->x -= src->x;
2387 tmp->y -= src->y;
2388
2389 if (!part->head)
2390 {
2391 dst = tmp;
2392 tmp->head = 0;
2393 }
2394 else
2395 tmp->head = dst; 2302 tmp->head = dst;
2396
2397 tmp->more = 0;
2398
2399 if (prev)
2400 prev->more = tmp; 2303 prev->more = tmp;
2401
2402 prev = tmp; 2304 prev = tmp;
2403 } 2305 }
2404 2306
2405 for (item = src->inv; item; item = item->below) 2307 for (object *item = inv; item; item = item->below)
2406 insert_ob_in_ob (object_create_clone (item), dst); 2308 insert_ob_in_ob (item->deep_clone (), dst);
2407 2309
2408 return dst; 2310 return dst;
2409} 2311}
2410 2312
2411/* This returns the first object in who's inventory that 2313/* This returns the first object in who's inventory that
2420 return tmp; 2322 return tmp;
2421 2323
2422 return 0; 2324 return 0;
2423} 2325}
2424 2326
2425/* If ob has a field named key, return the link from the list, 2327shstr_tmp
2426 * otherwise return NULL. 2328object::kv_get (shstr_tmp key) const
2427 *
2428 * key must be a passed in shared string - otherwise, this won't
2429 * do the desired thing.
2430 */
2431key_value *
2432get_ob_key_link (const object *ob, const char *key)
2433{ 2329{
2434 for (key_value *link = ob->key_values; link; link = link->next) 2330 for (key_value *kv = key_values; kv; kv = kv->next)
2435 if (link->key == key) 2331 if (kv->key == key)
2436 return link;
2437
2438 return 0;
2439}
2440
2441/*
2442 * Returns the value of op has an extra_field for key, or NULL.
2443 *
2444 * The argument doesn't need to be a shared string.
2445 *
2446 * The returned string is shared.
2447 */
2448const char *
2449get_ob_key_value (const object *op, const char *const key)
2450{
2451 key_value *link;
2452 shstr_cmp canonical_key (key);
2453
2454 if (!canonical_key)
2455 {
2456 /* 1. There being a field named key on any object
2457 * implies there'd be a shared string to find.
2458 * 2. Since there isn't, no object has this field.
2459 * 3. Therefore, *this* object doesn't have this field.
2460 */
2461 return 0;
2462 }
2463
2464 /* This is copied from get_ob_key_link() above -
2465 * only 4 lines, and saves the function call overhead.
2466 */
2467 for (link = op->key_values; link; link = link->next)
2468 if (link->key == canonical_key)
2469 return link->value; 2332 return kv->value;
2470 2333
2471 return 0; 2334 return shstr ();
2472} 2335}
2473 2336
2474/* 2337void
2475 * Updates the canonical_key in op to value. 2338object::kv_set (shstr_tmp key, shstr_tmp value)
2476 *
2477 * canonical_key is a shared string (value doesn't have to be).
2478 *
2479 * Unless add_key is TRUE, it won't add fields, only change the value of existing
2480 * keys.
2481 *
2482 * Returns TRUE on success.
2483 */
2484int
2485set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2486{ 2339{
2487 key_value *field = NULL, *last = NULL; 2340 for (key_value *kv = key_values; kv; kv = kv->next)
2488 2341 if (kv->key == key)
2489 for (field = op->key_values; field != NULL; field = field->next)
2490 {
2491 if (field->key != canonical_key)
2492 { 2342 {
2493 last = field; 2343 kv->value = value;
2494 continue; 2344 return;
2495 } 2345 }
2496 2346
2497 if (value) 2347 key_value *kv = new key_value;
2498 field->value = value; 2348
2499 else 2349 kv->next = key_values;
2350 kv->key = key;
2351 kv->value = value;
2352
2353 key_values = kv;
2354}
2355
2356void
2357object::kv_del (shstr_tmp key)
2358{
2359 for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
2360 if ((*kvp)->key == key)
2500 { 2361 {
2501 /* Basically, if the archetype has this key set, 2362 key_value *kv = *kvp;
2502 * we need to store the null value so when we save 2363 *kvp = (*kvp)->next;
2503 * it, we save the empty value so that when we load, 2364 delete kv;
2504 * we get this value back again. 2365 return;
2505 */
2506 if (get_ob_key_link (op->arch, canonical_key))
2507 field->value = 0;
2508 else
2509 {
2510 if (last)
2511 last->next = field->next;
2512 else
2513 op->key_values = field->next;
2514
2515 delete field;
2516 }
2517 } 2366 }
2518 return TRUE;
2519 }
2520 /* IF we get here, key doesn't exist */
2521
2522 /* No field, we'll have to add it. */
2523
2524 if (!add_key)
2525 return FALSE;
2526
2527 /* There isn't any good reason to store a null
2528 * value in the key/value list. If the archetype has
2529 * this key, then we should also have it, so shouldn't
2530 * be here. If user wants to store empty strings,
2531 * should pass in ""
2532 */
2533 if (value == NULL)
2534 return TRUE;
2535
2536 field = new key_value;
2537
2538 field->key = canonical_key;
2539 field->value = value;
2540 /* Usual prepend-addition. */
2541 field->next = op->key_values;
2542 op->key_values = field;
2543
2544 return TRUE;
2545}
2546
2547/*
2548 * Updates the key in op to value.
2549 *
2550 * If add_key is FALSE, this will only update existing keys,
2551 * and not add new ones.
2552 * In general, should be little reason FALSE is ever passed in for add_key
2553 *
2554 * Returns TRUE on success.
2555 */
2556int
2557set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2558{
2559 shstr key_ (key);
2560
2561 return set_ob_key_value_s (op, key_, value, add_key);
2562} 2367}
2563 2368
2564object::depth_iterator::depth_iterator (object *container) 2369object::depth_iterator::depth_iterator (object *container)
2565: iterator_base (container) 2370: iterator_base (container)
2566{ 2371{
2616{ 2421{
2617 char flagdesc[512]; 2422 char flagdesc[512];
2618 char info2[256 * 4]; 2423 char info2[256 * 4];
2619 char *p = info; 2424 char *p = info;
2620 2425
2621 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s,flags:[%s],type:%d}", 2426 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2622 count, 2427 count,
2623 uuid.c_str (), 2428 uuid.c_str (),
2624 &name, 2429 &name,
2625 title ? "\",title:\"" : "", 2430 title ? ",title:\"" : "",
2626 title ? (const char *)title : "", 2431 title ? (const char *)title : "",
2432 title ? "\"" : "",
2627 flag_desc (flagdesc, 512), type); 2433 flag_desc (flagdesc, 512), type);
2628 2434
2629 if (!this->flag[FLAG_REMOVED] && env) 2435 if (!flag[FLAG_REMOVED] && env)
2630 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2436 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2631 2437
2632 if (map) 2438 if (map)
2633 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y); 2439 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2634 2440
2664object::open_container (object *new_container) 2470object::open_container (object *new_container)
2665{ 2471{
2666 if (container == new_container) 2472 if (container == new_container)
2667 return; 2473 return;
2668 2474
2669 if (object *old_container = container) 2475 object *old_container = container;
2476
2477 if (old_container)
2670 { 2478 {
2671 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this))) 2479 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))
2672 return; 2480 return;
2673 2481
2674#if 0 2482#if 0
2676 if (object *closer = old_container->inv) 2484 if (object *closer = old_container->inv)
2677 if (closer->type == CLOSE_CON) 2485 if (closer->type == CLOSE_CON)
2678 closer->destroy (); 2486 closer->destroy ();
2679#endif 2487#endif
2680 2488
2489 // make sure the container is available
2490 esrv_send_item (this, old_container);
2491
2681 old_container->flag [FLAG_APPLIED] = 0; 2492 old_container->flag [FLAG_APPLIED] = false;
2682 container = 0; 2493 container = 0;
2683 2494
2495 // client needs item update to make it work, client bug requires this to be separate
2684 esrv_update_item (UPD_FLAGS, this, old_container); 2496 esrv_update_item (UPD_FLAGS, this, old_container);
2497
2685 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container)); 2498 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", old_container->query_name ());
2686 play_sound (sound_find ("chest_close")); 2499 play_sound (sound_find ("chest_close"));
2687 } 2500 }
2688 2501
2689 if (new_container) 2502 if (new_container)
2690 { 2503 {
2700 closer->flag [FLAG_NO_MAP_SAVE] = 1; 2513 closer->flag [FLAG_NO_MAP_SAVE] = 1;
2701 new_container->insert (closer); 2514 new_container->insert (closer);
2702 } 2515 }
2703#endif 2516#endif
2704 2517
2705 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container)); 2518 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", new_container->query_name ());
2706 2519
2520 // make sure the container is available, client bug requires this to be separate
2521 esrv_send_item (this, new_container);
2522
2707 new_container->flag [FLAG_APPLIED] = 1; 2523 new_container->flag [FLAG_APPLIED] = true;
2708 container = new_container; 2524 container = new_container;
2709 2525
2526 // client needs flag change
2710 esrv_update_item (UPD_FLAGS, this, new_container); 2527 esrv_update_item (UPD_FLAGS, this, new_container);
2711 esrv_send_inventory (this, new_container); 2528 esrv_send_inventory (this, new_container);
2712 play_sound (sound_find ("chest_open")); 2529 play_sound (sound_find ("chest_open"));
2713 } 2530 }
2531// else if (!old_container->env && contr && contr->ns)
2532// contr->ns->floorbox_reset ();
2714} 2533}
2715 2534
2716object * 2535object *
2717object::force_find (const shstr name) 2536object::force_find (shstr_tmp name)
2718{ 2537{
2719 /* cycle through his inventory to look for the MARK we want to 2538 /* cycle through his inventory to look for the MARK we want to
2720 * place 2539 * place
2721 */ 2540 */
2722 for (object *tmp = inv; tmp; tmp = tmp->below) 2541 for (object *tmp = inv; tmp; tmp = tmp->below)
2724 return splay (tmp); 2543 return splay (tmp);
2725 2544
2726 return 0; 2545 return 0;
2727} 2546}
2728 2547
2548//-GPL
2549
2729void 2550void
2551object::force_set_timer (int duration)
2552{
2553 this->duration = 1;
2554 this->speed_left = -1.f;
2555
2556 this->set_speed (duration ? 1.f / duration : 0.f);
2557}
2558
2559object *
2730object::force_add (const shstr name, int duration) 2560object::force_add (shstr_tmp name, int duration)
2731{ 2561{
2732 if (object *force = force_find (name)) 2562 if (object *force = force_find (name))
2733 force->destroy (); 2563 force->destroy ();
2734 2564
2735 object *force = get_archetype (FORCE_NAME); 2565 object *force = get_archetype (FORCE_NAME);
2736 2566
2737 force->slaying = name; 2567 force->slaying = name;
2738 force->stats.food = 1; 2568 force->force_set_timer (duration);
2739 force->speed_left = -1.f;
2740
2741 force->set_speed (duration ? 1.f / duration : 0.f);
2742 force->flag [FLAG_IS_USED_UP] = true;
2743 force->flag [FLAG_APPLIED] = true; 2569 force->flag [FLAG_APPLIED] = true;
2744 2570
2745 insert (force); 2571 return insert (force);
2746} 2572}
2747 2573
2748void 2574void
2749object::play_sound (faceidx sound) const 2575object::play_sound (faceidx sound) const
2750{ 2576{
2751 if (!sound) 2577 if (!sound)
2752 return; 2578 return;
2753 2579
2754 if (flag [FLAG_REMOVED]) 2580 if (is_on_map ())
2581 map->play_sound (sound, x, y);
2582 else if (object *pl = in_player ())
2583 pl->contr->play_sound (sound);
2584}
2585
2586void
2587object::say_msg (const char *msg) const
2588{
2589 if (is_on_map ())
2590 map->say_msg (msg, x, y);
2591 else if (object *pl = in_player ())
2592 pl->contr->play_sound (sound);
2593}
2594
2595void
2596object::make_noise ()
2597{
2598 // we do not model noise in the map, so instead put
2599 // a temporary light into the noise source
2600 // could use the map instead, but that's less reliable for our
2601 // goal, which is to make invisibility a bit harder to exploit
2602
2603 // currently only works sensibly for players
2604 if (!is_player ())
2755 return; 2605 return;
2756 2606
2757 if (env) 2607 // find old force, or create new one
2758 { 2608 object *force = force_find (shstr_noise_force);
2759 if (object *pl = in_player ()) 2609
2760 pl->contr->play_sound (sound); 2610 if (force)
2761 } 2611 force->speed_left = -1.f; // patch old speed up
2762 else 2612 else
2763 map->play_sound (sound, x, y); 2613 {
2764} 2614 force = archetype::get (shstr_noise_force);
2765 2615
2616 force->slaying = shstr_noise_force;
2617 force->stats.food = 1;
2618 force->speed_left = -1.f;
2619
2620 force->set_speed (1.f / 4.f);
2621 force->flag [FLAG_IS_USED_UP] = true;
2622 force->flag [FLAG_APPLIED] = true;
2623
2624 insert (force);
2625 }
2626}
2627

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines