ViewVC Help

View File | Revision Log | Show Annotations | Download File

/cvs/deliantra/server/common/object.C

Comparing deliantra/server/common/object.C (file contents):
Revision 1.205 by root, Sun Apr 13 01:34:08 2008 UTC vs.
Revision 1.274 by root, Sun Dec 28 03:58:36 2008 UTC

1	/*	1	/*
2	* This file is part of Deliantra, the Roguelike Realtime MMORPG.	2	* This file is part of Deliantra, the Roguelike Realtime MMORPG.
3	*	3	*
4	* Copyright (©) 2005,2006,2007 Marc Alexander Lehmann / Robin Redeker / the Deliantra team	4	* Copyright (©) 2005,2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5	* Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team	5	* Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team
6	* Copyright (©) 1992,2007 Frank Tore Johansen	6	* Copyright (©) 1992,2007 Frank Tore Johansen
7	*	7	*
8	* Deliantra is free software: you can redistribute it and/or modify	8	* Deliantra is free software: you can redistribute it and/or modify
9	* it under the terms of the GNU General Public License as published by	9	* it under the terms of the GNU General Public License as published by
…		…
19	* along with this program. If not, see <http://www.gnu.org/licenses/>.	19	* along with this program. If not, see <http://www.gnu.org/licenses/>.
20	*	20	*
21	* The authors can be reached via e-mail to <support@deliantra.net>	21	* The authors can be reached via e-mail to <support@deliantra.net>
22	*/	22	*/
23		23
24	/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
25	sub/add_weight will transcend the environment updating the carrying
26	variable. */
27	#include <global.h>	24	#include <global.h>
28	#include <stdio.h>	25	#include <stdio.h>
29	#include <sys/types.h>	26	#include <sys/types.h>
30	#include <sys/uio.h>	27	#include <sys/uio.h>
31	#include <object.h>	28	#include <object.h>
32	#include <funcpoint.h>
33	#include <sproto.h>	29	#include <sproto.h>
34	#include <loader.h>	30	#include <loader.h>
35		31
36	#include <bitset>	32	#include <bitset>
37		33
38	UUID UUID::cur;	34	UUID UUID::cur;
39	static uint64_t seq_next_save;	35	static uint64_t seq_next_save;
40	static const uint64 UUID_GAP = 1<<19;	36	static const uint64 UUID_GAP = 1<<19;
		37	uint32_t mapspace::smellcount = 10000;
41		38
42	objectvec objects;	39	objectvec objects;
43	activevec actives;	40	activevec actives;
44		41
45	short freearr_x[SIZEOFFREE] = {	42	short freearr_x[SIZEOFFREE] = {
…		…
143		140
144	/* Returns TRUE if every key_values in wants has a partner with the same value in has. */	141	/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
145	static bool	142	static bool
146	compare_ob_value_lists_one (const object *wants, const object *has)	143	compare_ob_value_lists_one (const object *wants, const object *has)
147	{	144	{
148	key_value *wants_field;
149
150	/* n-squared behaviour (see get_ob_key_link()), but I'm hoping both	145	/* n-squared behaviour (see kv_get), but I'm hoping both
151	* objects with lists are rare, and lists stay short. If not, use a	146	* objects with lists are rare, and lists stay short. If not, use a
152	* different structure or at least keep the lists sorted...	147	* different structure or at least keep the lists sorted...
153	*/	148	*/
154		149
155	/* For each field in wants, */	150	/* For each field in wants, */
156	for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)	151	for (key_value *kv = wants->key_values; kv; kv = kv->next)
157	{	152	if (has->kv_get (kv->key) != kv->value)
158	key_value *has_field;	153	return false;
159
160	/* Look for a field in has with the same key. */
161	has_field = get_ob_key_link (has, wants_field->key);
162
163	if (!has_field)
164	return 0; /* No field with that name. */
165
166	/* Found the matching field. */
167	if (has_field->value != wants_field->value)
168	return 0; /* Values don't match, so this half of the comparison is false. */
169
170	/* If we get here, we found a match. Now for the next field in wants. */
171	}
172		154
173	/* If we get here, every field in wants has a matching field in has. */	155	/* If we get here, every field in wants has a matching field in has. */
174	return 1;	156	return true;
175	}	157	}
176		158
177	/* Returns TRUE if ob1 has the same key_values as ob2. */	159	/* Returns TRUE if ob1 has the same key_values as ob2. */
178	static bool	160	static bool
179	compare_ob_value_lists (const object *ob1, const object *ob2)	161	compare_ob_value_lists (const object *ob1, const object *ob2)
180	{	162	{
181	/* However, there may be fields in has which aren't partnered in wants,	163	/* However, there may be fields in has which aren't partnered in wants,
182	* so we need to run the comparison *twice*. :(	164	* so we need to run the comparison *twice*. :(
183	*/	165	*/
184	return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1);	166	return compare_ob_value_lists_one (ob1, ob2)
		167	&& compare_ob_value_lists_one (ob2, ob1);
185	}	168	}
186		169
187	/* Function examines the 2 objects given to it, and returns true if	170	/* Function examines the 2 objects given to it, and returns true if
188	* they can be merged together.	171	* they can be merged together.
189	*	172	*
…		…
204	|| ob1->speed != ob2->speed	187	|| ob1->speed != ob2->speed
205	|| ob1->value != ob2->value	188	|| ob1->value != ob2->value
206	|| ob1->name != ob2->name)	189	|| ob1->name != ob2->name)
207	return 0;	190	return 0;
208		191
209	/* Do not merge objects if nrof would overflow. First part checks	192	/* Do not merge objects if nrof would overflow, assume nrof
210	* for unsigned overflow (2c), second part checks wether the result	193	* is always 0 .. 2**31-1 */
211	* would fit into a 32 bit signed int, which is often used to hold	194	if (ob1->nrof > 0x7fffffff - ob2->nrof)
212	* nrof values.
213	*/
214	if (~ob1->nrof < ob2->nrof || ob1->nrof + ob2->nrof > (1UL << 31))
215	return 0;	195	return 0;
216		196
217	/* If the objects have been identified, set the BEEN_APPLIED flag.	197	/* If the objects have been identified, set the BEEN_APPLIED flag.
218	* This is to the comparison of the flags below will be OK. We	198	* This is to the comparison of the flags below will be OK. We
219	* just can't ignore the been applied or identified flags, as they	199	* just can't ignore the been applied or identified flags, as they
…		…
224	SET_FLAG (ob1, FLAG_BEEN_APPLIED);	204	SET_FLAG (ob1, FLAG_BEEN_APPLIED);
225		205
226	if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))	206	if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
227	SET_FLAG (ob2, FLAG_BEEN_APPLIED);	207	SET_FLAG (ob2, FLAG_BEEN_APPLIED);
228		208
229	if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any ()	209	if (ob1->arch->archname != ob2->arch->archname
230	|| ob1->arch != ob2->arch
231	|| ob1->name != ob2->name	210	|| ob1->name != ob2->name
232	|| ob1->title != ob2->title	211	|| ob1->title != ob2->title
233	|| ob1->msg != ob2->msg	212	|| ob1->msg != ob2->msg
234	|| ob1->weight != ob2->weight	213	|| ob1->weight != ob2->weight
235	|| memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
236	|| memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
237	|| ob1->attacktype != ob2->attacktype	214	|| ob1->attacktype != ob2->attacktype
238	|| ob1->magic != ob2->magic	215	|| ob1->magic != ob2->magic
239	|| ob1->slaying != ob2->slaying	216	|| ob1->slaying != ob2->slaying
240	|| ob1->skill != ob2->skill	217	|| ob1->skill != ob2->skill
241	|| ob1->value != ob2->value	218	|| ob1->value != ob2->value
242	|| ob1->animation_id != ob2->animation_id	219	|| ob1->animation_id != ob2->animation_id
		220	|| (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependent on each other
243	|| ob1->client_type != ob2->client_type	221	|| ob1->client_type != ob2->client_type
244	|| ob1->materialname != ob2->materialname	222	|| ob1->materialname != ob2->materialname
245	|| ob1->lore != ob2->lore	223	|| ob1->lore != ob2->lore
246	|| ob1->subtype != ob2->subtype	224	|| ob1->subtype != ob2->subtype
247	|| ob1->move_type != ob2->move_type	225	|| ob1->move_type != ob2->move_type
248	|| ob1->move_block != ob2->move_block	226	|| ob1->move_block != ob2->move_block
249	|| ob1->move_allow != ob2->move_allow	227	|| ob1->move_allow != ob2->move_allow
250	|| ob1->move_on != ob2->move_on	228	|| ob1->move_on != ob2->move_on
251	|| ob1->move_off != ob2->move_off	229	|| ob1->move_off != ob2->move_off
252	|| ob1->move_slow != ob2->move_slow	230	|| ob1->move_slow != ob2->move_slow
253	|| ob1->move_slow_penalty != ob2->move_slow_penalty)	231	|| ob1->move_slow_penalty != ob2->move_slow_penalty
		232	|| memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
		233	|| memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
		234	return 0;
		235
		236	if ((ob1->flag ^ ob2->flag)
		237	.reset (FLAG_INV_LOCKED)
		238	.reset (FLAG_REMOVED)
		239	.any ())
254	return 0;	240	return 0;
255		241
256	/* This is really a spellbook check - we should in general	242	/* This is really a spellbook check - we should in general
257	* not merge objects with real inventories, as splitting them	243	* not merge objects with real inventories, as splitting them
258	* is hard.	244	* is hard.
…		…
297		283
298	if (ob1->key_values || ob2->key_values)	284	if (ob1->key_values || ob2->key_values)
299	{	285	{
300	/* At least one of these has key_values. */	286	/* At least one of these has key_values. */
301	if ((!ob1->key_values) != (!ob2->key_values))	287	if ((!ob1->key_values) != (!ob2->key_values))
302	/* One has fields, but the other one doesn't. */	288	return 0; /* One has fields, but the other one doesn't. */
303	return 0;	289
304	else if (!compare_ob_value_lists (ob1, ob2))	290	if (!compare_ob_value_lists (ob1, ob2))
305	return 0;	291	return 0;
306	}	292	}
307		293
308	if (ob1->self || ob2->self)	294	if (ob1->self || ob2->self)
309	{	295	{
…		…
315	int k1 = ob1->self ? HvTOTALKEYS (ob1->self) : 0;	301	int k1 = ob1->self ? HvTOTALKEYS (ob1->self) : 0;
316	int k2 = ob2->self ? HvTOTALKEYS (ob2->self) : 0;	302	int k2 = ob2->self ? HvTOTALKEYS (ob2->self) : 0;
317		303
318	if (k1 != k2)	304	if (k1 != k2)
319	return 0;	305	return 0;
		306
320	else if (k1 == 0)	307	if (k1 == 0)
321	return 1;	308	return 1;
		309
322	else if (!cfperl_can_merge (ob1, ob2))	310	if (!cfperl_can_merge (ob1, ob2))
323	return 0;	311	return 0;
324	}	312	}
325	}	313	}
326		314
327	/* Everything passes, must be OK. */	315	/* Everything passes, must be OK. */
328	return 1;	316	return 1;
329	}	317	}
330		318
		319	// find player who can see this object
		320	object *
		321	object::visible_to () const
		322	{
		323	if (client_visible () && !flag [FLAG_REMOVED])
		324	{
		325	// see if we are in a container of sorts
		326	if (env)
		327	{
		328	// the player inventory itself is always visible
		329	if (env->is_player ())
		330	return env;
		331
		332	// else a player could have our env open
		333	object *envest = env->outer_env ();
		334
		335	// the player itself is always on a map, so we will find him here
		336	// even if our inv is in a player.
		337	if (envest->is_on_map ())
		338	if (object *pl = envest->ms ().player ())
		339	if (pl->container == env)
		340	return pl;
		341	}
		342	else
		343	{
		344	// maybe there is a player standing on the same mapspace
		345	// this will catch the case where "this" is a player
		346	if (object *pl = ms ().player ())
		347	if ((!pl->container && pl->contr->ns && !pl->contr->ns->update_look)
		348	|| this == pl->container)
		349	return pl;
		350	}
		351	}
		352
		353	return 0;
		354	}
		355
		356	// adjust weight per container type ("of holding")
		357	static sint32
		358	weight_adjust_for (object *op, sint32 weight)
		359	{
		360	return op->type == CONTAINER
		361	? lerp (weight, 0, 100, 0, 100 - op->stats.Str)
		362	: weight;
		363	}
		364
331	/*	365	/*
		366	* adjust_weight(object, weight) adds the specified weight to an object,
		367	* and also updates how much the environment(s) is/are carrying.
		368	*/
		369	static void
		370	adjust_weight (object *op, sint32 weight)
		371	{
		372	while (op)
		373	{
		374	// adjust by actual difference to account for rounding errors
		375	// i.e. (w2 - w1) / f != w2 / f - w1 / f and the latter is correct
		376	weight = weight_adjust_for (op, op->carrying)
		377	- weight_adjust_for (op, op->carrying - weight);
		378
		379	if (!weight)
		380	return;
		381
		382	op->carrying += weight;
		383
		384	if (object *pl = op->visible_to ())
		385	if (pl != op) // player is handled lazily
		386	esrv_update_item (UPD_WEIGHT, pl, op);
		387
		388	op = op->env;
		389	}
		390	}
		391
		392	/*
332	* sum_weight() is a recursive function which calculates the weight	393	* this is a recursive function which calculates the weight
333	* an object is carrying. It goes through in figures out how much	394	* an object is carrying. It goes through op and figures out how much
334	* containers are carrying, and sums it up.	395	* containers are carrying, and sums it up.
335	*/	396	*/
336	long	397	void
337	sum_weight (object *op)	398	object::update_weight ()
338	{	399	{
339	long sum;	400	sint32 sum = 0;
340	object *inv;
341		401
342	for (sum = 0, inv = op->inv; inv; inv = inv->below)	402	for (object *op = inv; op; op = op->below)
343	{	403	{
344	if (inv->inv)	404	if (op->inv)
345	sum_weight (inv);	405	op->update_weight ();
346		406
347	sum += inv->carrying + inv->weight * (inv->nrof ? inv->nrof : 1);	407	sum += op->total_weight ();
		408	}
		409
		410	sum = weight_adjust_for (this, sum);
		411
		412	if (sum != carrying)
348	}	413	{
349
350	if (op->type == CONTAINER && op->stats.Str)
351	sum = (sum * (100 - op->stats.Str)) / 100;
352
353	if (op->carrying != sum)
354	op->carrying = sum;	414	carrying = sum;
355		415
356	return sum;	416	if (object *pl = visible_to ())
		417	if (pl != this) // player is handled lazily
		418	esrv_update_item (UPD_WEIGHT, pl, this);
		419	}
357	}	420	}
358		421
359	/**	422	/*
360	* Return the outermost environment object for a given object.	423	* Used by: Server DM commands: dumpbelow, dump. Some error messages.
361	*/
362
363	object *
364	object_get_env_recursive (object *op)
365	{
366	while (op->env != NULL)
367	op = op->env;
368	return op;
369	}
370
371	/*
372	* Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
373	* Some error messages.
374	* The result of the dump is stored in the static global errmsg array.
375	*/	424	*/
376	char *	425	char *
377	dump_object (object *op)	426	dump_object (object *op)
378	{	427	{
379	if (!op)	428	if (!op)
…		…
393	get_nearest_part (object *op, const object *pl)	442	get_nearest_part (object *op, const object *pl)
394	{	443	{
395	object *tmp, *closest;	444	object *tmp, *closest;
396	int last_dist, i;	445	int last_dist, i;
397		446
398	if (op->more == NULL)	447	if (!op->more)
399	return op;	448	return op;
		449
400	for (last_dist = distance (op, pl), closest = op, tmp = op->more; tmp != NULL; tmp = tmp->more)	450	for (last_dist = distance (op, pl), closest = op, tmp = op->more;
		451	tmp;
		452	tmp = tmp->more)
401	if ((i = distance (tmp, pl)) < last_dist)	453	if ((i = distance (tmp, pl)) < last_dist)
402	closest = tmp, last_dist = i;	454	closest = tmp, last_dist = i;
		455
403	return closest;	456	return closest;
404	}	457	}
405		458
406	/*	459	/*
407	* Returns the object which has the count-variable equal to the argument.	460	* Returns the object which has the count-variable equal to the argument.
		461	* VERRRY slow.
408	*/	462	*/
409	object *	463	object *
410	find_object (tag_t i)	464	find_object (tag_t i)
411	{	465	{
412	for_all_objects (op)	466	for_all_objects (op)
…		…
423	*/	477	*/
424	object *	478	object *
425	find_object_name (const char *str)	479	find_object_name (const char *str)
426	{	480	{
427	shstr_cmp str_ (str);	481	shstr_cmp str_ (str);
428	object *op;
429		482
		483	if (str_)
430	for_all_objects (op)	484	for_all_objects (op)
431	if (op->name == str_)	485	if (op->name == str_)
432	break;	486	return op;
433		487
434	return op;	488	return 0;
435	}	489	}
436		490
437	/*	491	/*
438	* Sets the owner and sets the skill and exp pointers to owner's current	492	* Sets the owner and sets the skill and exp pointers to owner's current
439	* skill and experience objects.	493	* skill and experience objects.
…		…
537	}	591	}
538		592
539	op->key_values = 0;	593	op->key_values = 0;
540	}	594	}
541		595
542	object &	596	/*
543	object::operator =(const object &src)	597	* copy_to first frees everything allocated by the dst object,
		598	* and then copies the contents of itself into the second
		599	* object, allocating what needs to be allocated. Basically, any
		600	* data that is malloc'd needs to be re-malloc/copied. Otherwise,
		601	* if the first object is freed, the pointers in the new object
		602	* will point at garbage.
		603	*/
		604	void
		605	object::copy_to (object *dst)
544	{	606	{
545	bool is_freed = flag [FLAG_FREED];	607	dst->remove ();
546	bool is_removed = flag [FLAG_REMOVED];
547
548	*(object_copy *)this = src;	608	*(object_copy *)dst = *this;
549
550	flag [FLAG_FREED] = is_freed;
551	flag [FLAG_REMOVED] = is_removed;	609	dst->flag [FLAG_REMOVED] = true;
552		610
553	/* Copy over key_values, if any. */	611	/* Copy over key_values, if any. */
554	if (src.key_values)	612	if (key_values)
555	{	613	{
556	key_value *tail = 0;	614	key_value *tail = 0;
557	key_values = 0;	615	dst->key_values = 0;
558		616
559	for (key_value *i = src.key_values; i; i = i->next)	617	for (key_value *i = key_values; i; i = i->next)
560	{	618	{
561	key_value *new_link = new key_value;	619	key_value *new_link = new key_value;
562		620
563	new_link->next = 0;	621	new_link->next = 0;
564	new_link->key = i->key;	622	new_link->key = i->key;
565	new_link->value = i->value;	623	new_link->value = i->value;
566		624
567	/* Try and be clever here, too. */	625	/* Try and be clever here, too. */
568	if (!key_values)	626	if (!dst->key_values)
569	{	627	{
570	key_values = new_link;	628	dst->key_values = new_link;
571	tail = new_link;	629	tail = new_link;
572	}	630	}
573	else	631	else
574	{	632	{
575	tail->next = new_link;	633	tail->next = new_link;
576	tail = new_link;	634	tail = new_link;
577	}	635	}
578	}	636	}
579	}	637	}
580	}
581
582	/*
583	* copy_to first frees everything allocated by the dst object,
584	* and then copies the contents of itself into the second
585	* object, allocating what needs to be allocated. Basically, any
586	* data that is malloc'd needs to be re-malloc/copied. Otherwise,
587	* if the first object is freed, the pointers in the new object
588	* will point at garbage.
589	*/
590	void
591	object::copy_to (object *dst)
592	{
593	*dst = *this;
594		638
595	if (speed < 0)	639	if (speed < 0)
596	dst->speed_left -= rndm ();	640	dst->speed_left -= rndm ();
597		641
598	dst->set_speed (dst->speed);	642	dst->activate ();
599	}	643	}
600		644
601	void	645	void
602	object::instantiate ()	646	object::instantiate ()
603	{	647	{
…		…
620	object *	664	object *
621	object::clone ()	665	object::clone ()
622	{	666	{
623	object *neu = create ();	667	object *neu = create ();
624	copy_to (neu);	668	copy_to (neu);
		669	neu->map = map; // not copied by copy_to
625	return neu;	670	return neu;
626	}	671	}
627		672
628	/*	673	/*
629	* If an object with the IS_TURNABLE() flag needs to be turned due	674	* If an object with the IS_TURNABLE() flag needs to be turned due
…		…
680	* UP_OBJ_FACE: only the objects face has changed.	725	* UP_OBJ_FACE: only the objects face has changed.
681	*/	726	*/
682	void	727	void
683	update_object (object *op, int action)	728	update_object (object *op, int action)
684	{	729	{
685	if (op == NULL)	730	if (!op)
686	{	731	{
687	/* this should never happen */	732	/* this should never happen */
688	LOG (llevDebug, "update_object() called for NULL object.\n");	733	LOG (llevError | logBacktrace, "update_object() called for NULL object.\n");
689	return;	734	return;
690	}	735	}
691		736
692	if (op->env)	737	if (!op->is_on_map ())
693	{	738	{
694	/* Animation is currently handled by client, so nothing	739	/* Animation is currently handled by client, so nothing
695	* to do in this case.	740	* to do in this case.
696	*/	741	*/
697	return;	742	return;
698	}	743	}
699
700	/* If the map is saving, don't do anything as everything is
701	* going to get freed anyways.
702	*/
703	if (!op->map || op->map->in_memory == MAP_SAVING)
704	return;
705		744
706	/* make sure the object is within map boundaries */	745	/* make sure the object is within map boundaries */
707	if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)	746	if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
708	{	747	{
709	LOG (llevError, "update_object() called for object out of map!\n");	748	LOG (llevError, "update_object() called for object out of map!\n");
…		…
720	else if (action == UP_OBJ_INSERT)	759	else if (action == UP_OBJ_INSERT)
721	{	760	{
722	// this is likely overkill, TODO: revisit (schmorp)	761	// this is likely overkill, TODO: revisit (schmorp)
723	if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))	762	if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
724	|| (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))	763	|| (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
725	|| (op->type == PLAYER && !(m.flags_ & P_PLAYER))	764	|| (op->is_player () && !(m.flags_ & P_PLAYER))
726	|| (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))	765	|| (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
727	|| (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))	766	|| (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
728	|| (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))	767	|| (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
729	|| (m.move_on | op->move_on ) != m.move_on	768	|| (m.move_on | op->move_on ) != m.move_on
730	|| (m.move_off | op->move_off ) != m.move_off	769	|| (m.move_off | op->move_off ) != m.move_off
731	|| (m.move_slow | op->move_slow) != m.move_slow	770	|| (m.move_slow | op->move_slow) != m.move_slow
732	/* This isn't perfect, but I don't expect a lot of objects to	771	/* This isn't perfect, but I don't expect a lot of objects to
733	* to have move_allow right now.	772	* have move_allow right now.
734	*/	773	*/
735	|| ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block	774	|| ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
736	|| 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)	775	|| 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
737	m.flags_ = 0;	776	m.invalidate ();
738	}	777	}
739	/* if the object is being removed, we can't make intelligent	778	/* if the object is being removed, we can't make intelligent
740	* decisions, because remove_ob can't really pass the object	779	* decisions, because remove_ob can't really pass the object
741	* that is being removed.	780	* that is being removed.
742	*/	781	*/
743	else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)	782	else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
744	m.flags_ = 0;	783	m.invalidate ();
745	else if (action == UP_OBJ_FACE)	784	else if (action == UP_OBJ_FACE)
746	/* Nothing to do for that case */ ;	785	/* Nothing to do for that case */ ;
747	else	786	else
748	LOG (llevError, "update_object called with invalid action: %d\n", action);	787	LOG (llevError, "update_object called with invalid action: %d\n", action);
749		788
…		…
791	object::activate ()	830	object::activate ()
792	{	831	{
793	/* If already on active list, don't do anything */	832	/* If already on active list, don't do anything */
794	if (active)	833	if (active)
795	return;	834	return;
		835
		836	if (has_active_speed () && flag [FLAG_FREED]) LOG (llevError | logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
		837	if (has_active_speed () && flag [FLAG_DEBUG]) LOG (llevError | logBacktrace, "BUG: tried to activate DEBUG object %s\n", debug_desc ());//D temp
796		838
797	if (has_active_speed ())	839	if (has_active_speed ())
798	actives.insert (this);	840	actives.insert (this);
799	}	841	}
800		842
…		…
852	object::destroy_inv (bool drop_to_ground)	894	object::destroy_inv (bool drop_to_ground)
853	{	895	{
854	// need to check first, because the checks below might segfault	896	// need to check first, because the checks below might segfault
855	// as we might be on an invalid mapspace and crossfire code	897	// as we might be on an invalid mapspace and crossfire code
856	// is too buggy to ensure that the inventory is empty.	898	// is too buggy to ensure that the inventory is empty.
857	// corollary: if you create arrows etc. with stuff in tis inventory,	899	// corollary: if you create arrows etc. with stuff in its inventory,
858	// cf will crash below with off-map x and y	900	// cf will crash below with off-map x and y
859	if (!inv)	901	if (!inv)
860	return;	902	return;
861		903
862	/* Only if the space blocks everything do we not process -	904	/* Only if the space blocks everything do we not process -
863	* if some form of movement is allowed, let objects	905	* if some form of movement is allowed, let objects
864	* drop on that space.	906	* drop on that space.
865	*/	907	*/
866	if (!drop_to_ground	908	if (!drop_to_ground
867	|| !map	909	|| !map
868	|| map->in_memory != MAP_IN_MEMORY	910	|| map->in_memory != MAP_ACTIVE
869	|| map->nodrop	911	|| map->no_drop
870	|| ms ().move_block == MOVE_ALL)	912	|| ms ().move_block == MOVE_ALL)
871	{	913	{
872	while (inv)	914	while (inv)
873	{
874	inv->destroy_inv (drop_to_ground);
875	inv->destroy ();	915	inv->destroy ();
876	}
877	}	916	}
878	else	917	else
879	{ /* Put objects in inventory onto this space */	918	{ /* Put objects in inventory onto this space */
880	while (inv)	919	while (inv)
881	{	920	{
…		…
899	object *op = new object;	938	object *op = new object;
900	op->link ();	939	op->link ();
901	return op;	940	return op;
902	}	941	}
903		942
		943	static struct freed_map : maptile
		944	{
		945	freed_map ()
		946	{
		947	path = "<freed objects map>";
		948	name = "/internal/freed_objects_map";
		949	width = 3;
		950	height = 3;
		951	no_drop = 1;
		952	no_reset = 1;
		953
		954	alloc ();
		955	in_memory = MAP_ACTIVE;
		956	}
		957
		958	~freed_map ()
		959	{
		960	destroy ();
		961	}
		962	} freed_map; // freed objects are moved here to avoid crashes
		963
904	void	964	void
905	object::do_destroy ()	965	object::do_destroy ()
906	{	966	{
907	attachable::do_destroy ();
908
909	if (flag [FLAG_IS_LINKED])	967	if (flag [FLAG_IS_LINKED])
910	remove_button_link (this);	968	remove_button_link (this);
911		969
912	if (flag [FLAG_FRIENDLY])	970	if (flag [FLAG_FRIENDLY])
913	remove_friendly_object (this);	971	remove_friendly_object (this);
914		972
915	if (!flag [FLAG_REMOVED])
916	remove ();	973	remove ();
917		974
918	destroy_inv (true);	975	attachable::do_destroy ();
919		976
920	deactivate ();	977	deactivate ();
921	unlink ();	978	unlink ();
922		979
923	flag [FLAG_FREED] = 1;	980	flag [FLAG_FREED] = 1;
924		981
925	// hack to ensure that freed objects still have a valid map	982	// hack to ensure that freed objects still have a valid map
926	{
927	static maptile *freed_map; // freed objects are moved here to avoid crashes
928
929	if (!freed_map)
930	{
931	freed_map = new maptile;
932
933	freed_map->path = "<freed objects map>";
934	freed_map->name = "/internal/freed_objects_map";
935	freed_map->width = 3;
936	freed_map->height = 3;
937	freed_map->nodrop = 1;
938
939	freed_map->alloc ();
940	freed_map->in_memory = MAP_IN_MEMORY;
941	}
942
943	map = freed_map;	983	map = &freed_map;
944	x = 1;	984	x = 1;
945	y = 1;	985	y = 1;
946	}
947		986
948	if (more)	987	if (more)
949	{	988	{
950	more->destroy ();	989	more->destroy ();
951	more = 0;	990	more = 0;
…		…
959	attacked_by = 0;	998	attacked_by = 0;
960	current_weapon = 0;	999	current_weapon = 0;
961	}	1000	}
962		1001
963	void	1002	void
964	object::destroy (bool destroy_inventory)	1003	object::destroy ()
965	{	1004	{
966	if (destroyed ())	1005	if (destroyed ())
967	return;	1006	return;
968		1007
969	if (destroy_inventory)	1008	if (!is_head () && !head->destroyed ())
		1009	{
		1010	LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
		1011	head->destroy ();
		1012	return;
		1013	}
		1014
970	destroy_inv (false);	1015	destroy_inv (false);
971		1016
972	if (is_head ())	1017	if (is_head ())
973	if (sound_destroy)	1018	if (sound_destroy)
974	play_sound (sound_destroy);	1019	play_sound (sound_destroy);
975	else if (flag [FLAG_MONSTER])	1020	else if (flag [FLAG_MONSTER])
976	play_sound (sound_find ("monster_destroy")); // quick hack, too lazy to create a generic mechanism	1021	play_sound (sound_find ("monster_destroy")); // quick hack, too lazy to create a generic mechanism
977		1022
978	attachable::destroy ();	1023	attachable::destroy ();
979	}
980
981	/*
982	* sub_weight() recursively (outwards) subtracts a number from the
983	* weight of an object (and what is carried by it's environment(s)).
984	*/
985	void
986	sub_weight (object *op, signed long weight)
987	{
988	while (op != NULL)
989	{
990	if (op->type == CONTAINER)
991	weight = (signed long) (weight * (100 - op->stats.Str) / 100);
992
993	op->carrying -= weight;
994	op = op->env;
995	}
996	}	1024	}
997		1025
998	/* op->remove ():	1026	/* op->remove ():
999	* This function removes the object op from the linked list of objects	1027	* This function removes the object op from the linked list of objects
1000	* which it is currently tied to. When this function is done, the	1028	* which it is currently tied to. When this function is done, the
…		…
1006	object::do_remove ()	1034	object::do_remove ()
1007	{	1035	{
1008	object *tmp, *last = 0;	1036	object *tmp, *last = 0;
1009	object *otmp;	1037	object *otmp;
1010		1038
1011	if (QUERY_FLAG (this, FLAG_REMOVED))	1039	if (flag [FLAG_REMOVED])
1012	return;	1040	return;
1013		1041
1014	SET_FLAG (this, FLAG_REMOVED);
1015	INVOKE_OBJECT (REMOVE, this);	1042	INVOKE_OBJECT (REMOVE, this);
		1043
		1044	flag [FLAG_REMOVED] = true;
1016		1045
1017	if (more)	1046	if (more)
1018	more->remove ();	1047	more->remove ();
1019		1048
1020	/*	1049	/*
1021	* In this case, the object to be removed is in someones	1050	* In this case, the object to be removed is in someones
1022	* inventory.	1051	* inventory.
1023	*/	1052	*/
1024	if (env)	1053	if (env)
1025	{	1054	{
1026	if (nrof)	1055	flag [FLAG_REMOVED] = false; // hack around the issue of visible_to checking flag_removed
1027	sub_weight (env, weight * nrof);	1056	if (object *pl = visible_to ())
1028	else	1057	esrv_del_item (pl->contr, count);
1029	sub_weight (env, weight + carrying);	1058	flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
		1059
		1060	adjust_weight (env, -total_weight ());
		1061
		1062	object *pl = in_player ();
		1063
		1064	/* we set up values so that it could be inserted into
		1065	* the map, but we don't actually do that - it is up
		1066	* to the caller to decide what we want to do.
		1067	*/
		1068	map = env->map;
		1069	x = env->x;
		1070	y = env->y;
		1071
		1072	// make sure cmov optimisation is applicable
		1073	*(above ? &above->below : &env->inv) = below;
		1074	*(below ? &below->above : &above ) = above; // &above is just a dummy
		1075
		1076	above = 0;
		1077	below = 0;
		1078	env = 0;
1030		1079
1031	/* NO_FIX_PLAYER is set when a great many changes are being	1080	/* NO_FIX_PLAYER is set when a great many changes are being
1032	* made to players inventory. If set, avoiding the call	1081	* made to players inventory. If set, avoiding the call
1033	* to save cpu time.	1082	* to save cpu time.
1034	*/	1083	*/
1035	if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))	1084	if (pl)
		1085	if (pl->is_player () && (glow_radius || !QUERY_FLAG (pl, FLAG_NO_FIX_PLAYER)))
		1086	{
1036	otmp->update_stats ();	1087	pl->update_stats ();
1037		1088
1038	if (above)	1089	if (glow_radius && pl->is_on_map ())
1039	above->below = below;	1090	update_all_los (pl->map, pl->x, pl->y);
1040	else	1091	}
1041	env->inv = below;
1042
1043	if (below)
1044	below->above = above;
1045
1046	/* we set up values so that it could be inserted into
1047	* the map, but we don't actually do that - it is up
1048	* to the caller to decide what we want to do.
1049	*/
1050	x = env->x, y = env->y;
1051	map = env->map;
1052	above = 0, below = 0;
1053	env = 0;
1054	}	1092	}
1055	else if (map)	1093	else if (map)
1056	{	1094	{
1057	if (type == PLAYER)
1058	{
1059	// leaving a spot always closes any open container on the ground
1060	if (container && !container->env)
1061	// this causes spurious floorbox updates, but it ensures
1062	// that the CLOSE event is being sent.
1063	close_container ();
1064
1065	--map->players;
1066	map->touch ();
1067	}
1068
1069	map->dirty = true;	1095	map->dirty = true;
1070	mapspace &ms = this->ms ();	1096	mapspace &ms = this->ms ();
1071		1097
		1098	if (object *pl = ms.player ())
		1099	{
		1100	if (is_player ())
		1101	{
		1102	if (!flag [FLAG_WIZPASS])
		1103	ms.smell = ++mapspace::smellcount; // remember the smell of the player
		1104
		1105	// leaving a spot always closes any open container on the ground
		1106	if (container && !container->env)
		1107	// this causes spurious floorbox updates, but it ensures
		1108	// that the CLOSE event is being sent.
		1109	close_container ();
		1110
		1111	--map->players;
		1112	map->touch ();
		1113	}
		1114	else if (pl->container == this)
		1115	{
		1116	// removing a container should close it
		1117	close_container ();
		1118	}
		1119
		1120	esrv_del_item (pl->contr, count);
		1121	}
		1122
1072	/* link the object above us */	1123	/* link the object above us */
1073	if (above)	1124	// re-link, make sure compiler can easily use cmove
1074	above->below = below;	1125	*(above ? &above->below : &ms.top) = below;
1075	else	1126	*(below ? &below->above : &ms.bot) = above;
1076	ms.top = below; /* we were top, set new top */
1077
1078	/* Relink the object below us, if there is one */
1079	if (below)
1080	below->above = above;
1081	else
1082	{
1083	/* Nothing below, which means we need to relink map object for this space
1084	* use translated coordinates in case some oddness with map tiling is
1085	* evident
1086	*/
1087	if (GET_MAP_OB (map, x, y) != this)
1088	LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1089
1090	ms.bot = above; /* goes on above it. */
1091	}
1092		1127
1093	above = 0;	1128	above = 0;
1094	below = 0;	1129	below = 0;
		1130
		1131	ms.invalidate ();
1095		1132
1096	if (map->in_memory == MAP_SAVING)	1133	if (map->in_memory == MAP_SAVING)
1097	return;	1134	return;
1098		1135
1099	int check_walk_off = !flag [FLAG_NO_APPLY];	1136	int check_walk_off = !flag [FLAG_NO_APPLY];
…		…
1105	* removed (most likely destroyed), update the player view	1142	* removed (most likely destroyed), update the player view
1106	* appropriately.	1143	* appropriately.
1107	*/	1144	*/
1108	pl->close_container ();	1145	pl->close_container ();
1109		1146
		1147	//TODO: the floorbox prev/next might need updating
		1148	//esrv_del_item (pl->contr, count);
		1149	//TODO: update floorbox to preserve ordering
		1150	if (pl->contr->ns)
1110	pl->contr->ns->floorbox_update ();	1151	pl->contr->ns->floorbox_update ();
1111	}	1152	}
1112		1153
1113	for (tmp = ms.bot; tmp; tmp = tmp->above)	1154	for (tmp = ms.bot; tmp; tmp = tmp->above)
1114	{	1155	{
1115	/* No point updating the players look faces if he is the object	1156	/* No point updating the players look faces if he is the object
…		…
1128	}	1169	}
1129		1170
1130	last = tmp;	1171	last = tmp;
1131	}	1172	}
1132		1173
1133	/* last == NULL if there are no objects on this space */	1174	if (affects_los ())
1134	//TODO: this makes little sense, why only update the topmost object?
1135	if (!last)
1136	map->at (x, y).flags_ = 0;
1137	else
1138	update_object (last, UP_OBJ_REMOVE);
1139
1140	if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1141	update_all_los (map, x, y);	1175	update_all_los (map, x, y);
1142	}	1176	}
1143	}	1177	}
1144		1178
1145	/*	1179	/*
…		…
1159	if (!top)	1193	if (!top)
1160	for (top = op; top && top->above; top = top->above)	1194	for (top = op; top && top->above; top = top->above)
1161	;	1195	;
1162		1196
1163	for (; top; top = top->below)	1197	for (; top; top = top->below)
1164	{
1165	if (top == op)
1166	continue;
1167
1168	if (object::can_merge (op, top))	1198	if (object::can_merge (op, top))
1169	{	1199	{
1170	top->nrof += op->nrof;	1200	top->nrof += op->nrof;
1171		1201
1172	/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/	1202	if (object *pl = top->visible_to ())
1173	op->weight = 0; /* Don't want any adjustements now */	1203	esrv_update_item (UPD_NROF, pl, top);
		1204
		1205	op->weight = 0; // cancel the addition above
		1206	op->carrying = 0; // must be 0 already
		1207
1174	op->destroy ();	1208	op->destroy ();
		1209
1175	return top;	1210	return top;
1176	}	1211	}
1177	}
1178		1212
1179	return 0;	1213	return 0;
1180	}	1214	}
1181		1215
1182	void	1216	void
…		…
1207	* job preparing multi-part monsters.	1241	* job preparing multi-part monsters.
1208	*/	1242	*/
1209	object *	1243	object *
1210	insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)	1244	insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1211	{	1245	{
		1246	op->remove ();
		1247
1212	for (object *tmp = op->head_ (); tmp; tmp = tmp->more)	1248	for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1213	{	1249	{
1214	tmp->x = x + tmp->arch->x;	1250	tmp->x = x + tmp->arch->x;
1215	tmp->y = y + tmp->arch->y;	1251	tmp->y = y + tmp->arch->y;
1216	}	1252	}
…		…
1239	* just 'op' otherwise	1275	* just 'op' otherwise
1240	*/	1276	*/
1241	object *	1277	object *
1242	insert_ob_in_map (object *op, maptile *m, object *originator, int flag)	1278	insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1243	{	1279	{
1244	assert (!op->flag [FLAG_FREED]);
1245
1246	object *top, *floor = NULL;
1247
1248	op->remove ();	1280	op->remove ();
		1281
		1282	if (m == &freed_map)//D TODO: remove soon
		1283	{//D
		1284	LOG (llevError | logBacktrace, "tries to insret object on freed objects map: %s", op->debug_desc ());//D
		1285	}//D
1249		1286
1250	/* Ideally, the caller figures this out. However, it complicates a lot	1287	/* Ideally, the caller figures this out. However, it complicates a lot
1251	* of areas of callers (eg, anything that uses find_free_spot would now	1288	* of areas of callers (eg, anything that uses find_free_spot would now
1252	* need extra work	1289	* need extra work
1253	*/	1290	*/
		1291	maptile *newmap = m;
1254	if (!xy_normalise (m, op->x, op->y))	1292	if (!xy_normalise (newmap, op->x, op->y))
1255	{	1293	{
1256	op->destroy ();	1294	op->head_ ()->destroy ();// remove head_ once all tail object destroyers found
1257	return 0;	1295	return 0;
1258	}	1296	}
1259		1297
1260	if (object *more = op->more)	1298	if (object *more = op->more)
1261	if (!insert_ob_in_map (more, m, originator, flag))	1299	if (!insert_ob_in_map (more, m, originator, flag))
1262	return 0;	1300	return 0;
1263		1301
1264	CLEAR_FLAG (op, FLAG_REMOVED);	1302	CLEAR_FLAG (op, FLAG_REMOVED);
1265		1303
1266	op->map = m;	1304	op->map = newmap;
1267	mapspace &ms = op->ms ();	1305	mapspace &ms = op->ms ();
1268		1306
1269	/* this has to be done after we translate the coordinates.	1307	/* this has to be done after we translate the coordinates.
1270	*/	1308	*/
1271	if (op->nrof && !(flag & INS_NO_MERGE))	1309	if (op->nrof && !(flag & INS_NO_MERGE))
1272	for (object *tmp = ms.bot; tmp; tmp = tmp->above)	1310	for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1273	if (object::can_merge (op, tmp))	1311	if (object::can_merge (op, tmp))
1274	{	1312	{
		1313	// TODO: we actually want to update tmp, not op,
		1314	// but some caller surely breaks when we return tmp
		1315	// from here :/
1275	op->nrof += tmp->nrof;	1316	op->nrof += tmp->nrof;
1276	tmp->destroy ();	1317	tmp->destroy ();
1277	}	1318	}
1278		1319
1279	CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */	1320	CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
…		…
1288	{	1329	{
1289	LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");	1330	LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1290	abort ();	1331	abort ();
1291	}	1332	}
1292		1333
		1334	if (!originator->is_on_map ())
		1335	LOG (llevDebug | logBacktrace, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
		1336	op->debug_desc (), originator->debug_desc ());
		1337
1293	op->above = originator;	1338	op->above = originator;
1294	op->below = originator->below;	1339	op->below = originator->below;
1295
1296	if (op->below)
1297	op->below->above = op;
1298	else
1299	ms.bot = op;
1300
1301	/* since *below* originator, no need to update top */
1302	originator->below = op;	1340	originator->below = op;
		1341
		1342	*(op->below ? &op->below->above : &ms.bot) = op;
1303	}	1343	}
1304	else	1344	else
1305	{	1345	{
1306	top = ms.bot;	1346	object *floor = 0;
		1347	object *top = ms.top;
1307		1348
1308	/* If there are other objects, then */	1349	/* If there are other objects, then */
1309	if (top)	1350	if (top)
1310	{	1351	{
1311	object *last = 0;
1312
1313	/*	1352	/*
1314	* If there are multiple objects on this space, we do some trickier handling.	1353	* If there are multiple objects on this space, we do some trickier handling.
1315	* We've already dealt with merging if appropriate.	1354	* We've already dealt with merging if appropriate.
1316	* Generally, we want to put the new object on top. But if	1355	* Generally, we want to put the new object on top. But if
1317	* flag contains INS_ABOVE_FLOOR_ONLY, once we find the last	1356	* flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
…		…
1320	* once we get to them. This reduces the need to traverse over all of	1359	* once we get to them. This reduces the need to traverse over all of
1321	* them when adding another one - this saves quite a bit of cpu time	1360	* them when adding another one - this saves quite a bit of cpu time
1322	* when lots of spells are cast in one area. Currently, it is presumed	1361	* when lots of spells are cast in one area. Currently, it is presumed
1323	* that flying non pickable objects are spell objects.	1362	* that flying non pickable objects are spell objects.
1324	*/	1363	*/
1325	for (top = ms.bot; top; top = top->above)	1364	for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1326	{	1365	{
1327	if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))	1366	if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) || QUERY_FLAG (tmp, FLAG_OVERLAY_FLOOR))
1328	floor = top;	1367	floor = tmp;
1329		1368
1330	if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))	1369	if (QUERY_FLAG (tmp, FLAG_NO_PICK) && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (tmp, FLAG_IS_FLOOR))
1331	{	1370	{
1332	/* We insert above top, so we want this object below this */	1371	/* We insert above top, so we want this object below this */
1333	top = top->below;	1372	top = tmp->below;
1334	break;	1373	break;
1335	}	1374	}
1336		1375
1337	last = top;	1376	top = tmp;
1338	}	1377	}
1339
1340	/* Don't want top to be NULL, so set it to the last valid object */
1341	top = last;
1342		1378
1343	/* We let update_position deal with figuring out what the space	1379	/* We let update_position deal with figuring out what the space
1344	* looks like instead of lots of conditions here.	1380	* looks like instead of lots of conditions here.
1345	* makes things faster, and effectively the same result.	1381	* makes things faster, and effectively the same result.
1346	*/	1382	*/
…		…
1353	*/	1389	*/
1354	if (!(flag & INS_ON_TOP)	1390	if (!(flag & INS_ON_TOP)
1355	&& ms.flags () & P_BLOCKSVIEW	1391	&& ms.flags () & P_BLOCKSVIEW
1356	&& (op->face && !faces [op->face].visibility))	1392	&& (op->face && !faces [op->face].visibility))
1357	{	1393	{
		1394	object *last;
		1395
1358	for (last = top; last != floor; last = last->below)	1396	for (last = top; last != floor; last = last->below)
1359	if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))	1397	if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1360	break;	1398	break;
1361		1399
1362	/* Check to see if we found the object that blocks view,	1400	/* Check to see if we found the object that blocks view,
…		…
1370	} /* If objects on this space */	1408	} /* If objects on this space */
1371		1409
1372	if (flag & INS_ABOVE_FLOOR_ONLY)	1410	if (flag & INS_ABOVE_FLOOR_ONLY)
1373	top = floor;	1411	top = floor;
1374		1412
1375	/* Top is the object that our object (op) is going to get inserted above.	1413	// insert object above top, or bottom-most if top = 0
1376	*/
1377
1378	/* First object on this space */
1379	if (!top)	1414	if (!top)
1380	{	1415	{
		1416	op->below = 0;
1381	op->above = ms.bot;	1417	op->above = ms.bot;
1382
1383	if (op->above)
1384	op->above->below = op;
1385
1386	op->below = 0;
1387	ms.bot = op;	1418	ms.bot = op;
		1419
		1420	*(op->above ? &op->above->below : &ms.top) = op;
1388	}	1421	}
1389	else	1422	else
1390	{ /* get inserted into the stack above top */	1423	{
1391	op->above = top->above;	1424	op->above = top->above;
1392
1393	if (op->above)
1394	op->above->below = op;	1425	top->above = op;
1395		1426
1396	op->below = top;	1427	op->below = top;
1397	top->above = op;	1428	*(op->above ? &op->above->below : &ms.top) = op;
1398	}	1429	}
		1430	}
1399		1431
1400	if (!op->above)	1432	if (op->is_player ())
1401	ms.top = op;
1402	} /* else not INS_BELOW_ORIGINATOR */
1403
1404	if (op->type == PLAYER)
1405	{	1433	{
1406	op->contr->do_los = 1;	1434	op->contr->do_los = 1;
1407	++op->map->players;	1435	++op->map->players;
1408	op->map->touch ();	1436	op->map->touch ();
1409	}	1437	}
1410		1438
1411	op->map->dirty = true;	1439	op->map->dirty = true;
1412		1440
1413	if (object *pl = ms.player ())	1441	if (object *pl = ms.player ())
		1442	//TODO: the floorbox prev/next might need updating
		1443	//esrv_send_item (pl, op);
		1444	//TODO: update floorbox to preserve ordering
		1445	if (pl->contr->ns)
1414	pl->contr->ns->floorbox_update ();	1446	pl->contr->ns->floorbox_update ();
1415		1447
1416	/* If this object glows, it may affect lighting conditions that are	1448	/* If this object glows, it may affect lighting conditions that are
1417	* visible to others on this map. But update_all_los is really	1449	* visible to others on this map. But update_all_los is really
1418	* an inefficient way to do this, as it means los for all players	1450	* an inefficient way to do this, as it means los for all players
1419	* on the map will get recalculated. The players could very well	1451	* on the map will get recalculated. The players could very well
1420	* be far away from this change and not affected in any way -	1452	* be far away from this change and not affected in any way -
1421	* this should get redone to only look for players within range,	1453	* this should get redone to only look for players within range,
1422	* or just updating the P_UPTODATE for spaces within this area	1454	* or just updating the P_UPTODATE for spaces within this area
1423	* of effect may be sufficient.	1455	* of effect may be sufficient.
1424	*/	1456	*/
1425	if (op->map->darkness && (op->glow_radius != 0))	1457	if (op->affects_los ())
		1458	{
		1459	op->ms ().invalidate ();
1426	update_all_los (op->map, op->x, op->y);	1460	update_all_los (op->map, op->x, op->y);
		1461	}
1427		1462
1428	/* updates flags (blocked, alive, no magic, etc) for this map space */	1463	/* updates flags (blocked, alive, no magic, etc) for this map space */
1429	update_object (op, UP_OBJ_INSERT);	1464	update_object (op, UP_OBJ_INSERT);
1430		1465
1431	INVOKE_OBJECT (INSERT, op);	1466	INVOKE_OBJECT (INSERT, op);
…		…
1461	* op is the object to insert it under: supplies x and the map.	1496	* op is the object to insert it under: supplies x and the map.
1462	*/	1497	*/
1463	void	1498	void
1464	replace_insert_ob_in_map (const char *arch_string, object *op)	1499	replace_insert_ob_in_map (const char *arch_string, object *op)
1465	{	1500	{
1466	object *tmp, *tmp1;
1467
1468	/* first search for itself and remove any old instances */	1501	/* first search for itself and remove any old instances */
1469		1502
1470	for (tmp = op->ms ().bot; tmp; tmp = tmp->above)	1503	for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1471	if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */	1504	if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */
1472	tmp->destroy ();	1505	tmp->destroy ();
1473		1506
1474	tmp1 = arch_to_object (archetype::find (arch_string));	1507	object *tmp = arch_to_object (archetype::find (arch_string));
1475		1508
1476	tmp1->x = op->x;	1509	tmp->x = op->x;
1477	tmp1->y = op->y;	1510	tmp->y = op->y;
		1511
1478	insert_ob_in_map (tmp1, op->map, op, 0);	1512	insert_ob_in_map (tmp, op->map, op, 0);
1479	}	1513	}
1480		1514
1481	object *	1515	object *
1482	object::insert_at (object *where, object *originator, int flags)	1516	object::insert_at (object *where, object *originator, int flags)
1483	{	1517	{
…		…
1486	else	1520	else
1487	return where->map->insert (this, where->x, where->y, originator, flags);	1521	return where->map->insert (this, where->x, where->y, originator, flags);
1488	}	1522	}
1489		1523
1490	/*	1524	/*
1491	* get_split_ob(ob,nr) splits up ob into two parts. The part which
1492	* is returned contains nr objects, and the remaining parts contains
1493	* the rest (or is removed and freed if that number is 0).
1494	* On failure, NULL is returned, and the reason put into the
1495	* global static errmsg array.
1496	*/
1497	object *
1498	get_split_ob (object *orig_ob, uint32 nr)
1499	{
1500	object *newob;
1501	int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1502
1503	if (orig_ob->nrof < nr)
1504	{
1505	sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1506	return NULL;
1507	}
1508
1509	newob = object_create_clone (orig_ob);
1510
1511	if ((orig_ob->nrof -= nr) < 1)
1512	orig_ob->destroy (1);
1513	else if (!is_removed)
1514	{
1515	if (orig_ob->env != NULL)
1516	sub_weight (orig_ob->env, orig_ob->weight * nr);
1517	if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_IN_MEMORY)
1518	{
1519	strcpy (errmsg, "Tried to split object whose map is not in memory.");
1520	LOG (llevDebug, "Error, Tried to split object whose map is not in memory.\n");
1521	return NULL;
1522	}
1523	}
1524
1525	newob->nrof = nr;
1526
1527	return newob;
1528	}
1529
1530	/*
1531	* decrease_ob_nr(object, number) decreases a specified number from	1525	* decrease(object, number) decreases a specified number from
1532	* the amount of an object. If the amount reaches 0, the object	1526	* the amount of an object. If the amount reaches 0, the object
1533	* is subsequently removed and freed.	1527	* is subsequently removed and freed.
1534	*	1528	*
1535	* Return value: 'op' if something is left, NULL if the amount reached 0	1529	* Return value: 'op' if something is left, NULL if the amount reached 0
1536	*/	1530	*/
		1531	bool
		1532	object::decrease (sint32 nr)
		1533	{
		1534	if (!nr)
		1535	return true;
		1536
		1537	nr = min (nr, nrof);
		1538
		1539	if (nrof > nr)
		1540	{
		1541	nrof -= nr;
		1542	adjust_weight (env, -weight * max (1, nr)); // carrying == 0
		1543
		1544	if (object *pl = visible_to ())
		1545	esrv_update_item (UPD_NROF, pl, this);
		1546
		1547	return true;
		1548	}
		1549	else
		1550	{
		1551	destroy ();
		1552	return false;
		1553	}
		1554	}
		1555
		1556	/*
		1557	* split(ob,nr) splits up ob into two parts. The part which
		1558	* is returned contains nr objects, and the remaining parts contains
		1559	* the rest (or is removed and returned if that number is 0).
		1560	* On failure, NULL is returned.
		1561	*/
1537	object *	1562	object *
1538	decrease_ob_nr (object *op, uint32 i)	1563	object::split (sint32 nr)
1539	{	1564	{
1540	object *tmp;	1565	int have = number_of ();
1541		1566
1542	if (i == 0) /* objects with op->nrof require this check */	1567	if (have < nr)
1543	return op;	1568	return 0;
1544		1569	else if (have == nr)
1545	if (i > op->nrof)
1546	i = op->nrof;
1547
1548	if (QUERY_FLAG (op, FLAG_REMOVED))
1549	op->nrof -= i;
1550	else if (op->env)
1551	{	1570	{
1552	/* is this object in the players inventory, or sub container
1553	* therein?
1554	*/
1555	tmp = op->in_player ();
1556	/* nope. Is this a container the player has opened?
1557	* If so, set tmp to that player.
1558	* IMO, searching through all the players will mostly
1559	* likely be quicker than following op->env to the map,
1560	* and then searching the map for a player.
1561	*/
1562	if (!tmp)
1563	for_all_players (pl)
1564	if (pl->ob->container == op->env)
1565	{
1566	tmp = pl->ob;
1567	break;
1568	}
1569
1570	if (i < op->nrof)
1571	{
1572	sub_weight (op->env, op->weight * i);
1573	op->nrof -= i;
1574	if (tmp)
1575	esrv_send_item (tmp, op);
1576	}
1577	else
1578	{
1579	op->remove ();	1571	remove ();
1580	op->nrof = 0;	1572	return this;
1581	if (tmp)
1582	esrv_del_item (tmp->contr, op->count);
1583	}
1584	}	1573	}
1585	else	1574	else
1586	{	1575	{
1587	object *above = op->above;	1576	decrease (nr);
1588		1577
1589	if (i < op->nrof)	1578	object *op = deep_clone ();
1590	op->nrof -= i;	1579	op->nrof = nr;
1591	else
1592	{
1593	op->remove ();
1594	op->nrof = 0;
1595	}
1596
1597	/* Since we just removed op, op->above is null */
1598	for (tmp = above; tmp; tmp = tmp->above)
1599	if (tmp->type == PLAYER)
1600	{
1601	if (op->nrof)
1602	esrv_send_item (tmp, op);
1603	else
1604	esrv_del_item (tmp->contr, op->count);
1605	}
1606	}
1607
1608	if (op->nrof)
1609	return op;	1580	return op;
1610	else
1611	{
1612	op->destroy ();
1613	return 0;
1614	}
1615	}
1616
1617	/*
1618	* add_weight(object, weight) adds the specified weight to an object,
1619	* and also updates how much the environment(s) is/are carrying.
1620	*/
1621	void
1622	add_weight (object *op, signed long weight)
1623	{
1624	while (op != NULL)
1625	{
1626	if (op->type == CONTAINER)
1627	weight = (signed long) (weight * (100 - op->stats.Str) / 100);
1628
1629	op->carrying += weight;
1630	op = op->env;
1631	}	1581	}
1632	}	1582	}
1633		1583
1634	object *	1584	object *
1635	insert_ob_in_ob (object *op, object *where)	1585	insert_ob_in_ob (object *op, object *where)
…		…
1660	* be != op, if items are merged. -Tero	1610	* be != op, if items are merged. -Tero
1661	*/	1611	*/
1662	object *	1612	object *
1663	object::insert (object *op)	1613	object::insert (object *op)
1664	{	1614	{
1665	if (!QUERY_FLAG (op, FLAG_REMOVED))
1666	op->remove ();
1667
1668	if (op->more)	1615	if (op->more)
1669	{	1616	{
1670	LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);	1617	LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);
1671	return op;	1618	return op;
1672	}	1619	}
1673		1620
1674	CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL);	1621	op->remove ();
1675	CLEAR_FLAG (op, FLAG_REMOVED);	1622
		1623	op->flag [FLAG_OBJ_ORIGINAL] = 0;
1676		1624
1677	if (op->nrof)	1625	if (op->nrof)
1678	{
1679	for (object *tmp = inv; tmp; tmp = tmp->below)	1626	for (object *tmp = inv; tmp; tmp = tmp->below)
1680	if (object::can_merge (tmp, op))	1627	if (object::can_merge (tmp, op))
1681	{	1628	{
1682	/* return the original object and remove inserted object	1629	/* return the original object and remove inserted object
1683	(client needs the original object) */	1630	(client needs the original object) */
1684	tmp->nrof += op->nrof;	1631	tmp->nrof += op->nrof;
1685	/* Weight handling gets pretty funky. Since we are adding to	1632
1686	* tmp->nrof, we need to increase the weight.	1633	if (object *pl = tmp->visible_to ())
1687	*/	1634	esrv_update_item (UPD_NROF, pl, tmp);
		1635
1688	add_weight (this, op->weight * op->nrof);	1636	adjust_weight (this, op->total_weight ());
1689	SET_FLAG (op, FLAG_REMOVED);	1637
1690	op->destroy (); /* free the inserted object */	1638	op->destroy ();
1691	op = tmp;	1639	op = tmp;
1692	op->remove (); /* and fix old object's links */	1640	goto inserted;
1693	CLEAR_FLAG (op, FLAG_REMOVED);
1694	break;
1695	}	1641	}
1696		1642
1697	/* I assume combined objects have no inventory
1698	* We add the weight - this object could have just been removed
1699	* (if it was possible to merge). calling remove_ob will subtract
1700	* the weight, so we need to add it in again, since we actually do
1701	* the linking below
1702	*/
1703	add_weight (this, op->weight * op->nrof);
1704	}
1705	else
1706	add_weight (this, (op->weight + op->carrying));
1707
1708	if (object *otmp = this->in_player ())
1709	if (otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1710	otmp->update_stats ();
1711
1712	op->owner = 0; // its his/hers now. period.	1643	op->owner = 0; // it's his/hers now. period.
1713	op->map = 0;	1644	op->map = 0;
		1645	op->x = 0;
		1646	op->y = 0;
		1647
		1648	op->above = 0;
		1649	op->below = inv;
1714	op->env = this;	1650	op->env = this;
1715	op->above = 0;
1716	op->below = 0;
1717	op->x = op->y = 0;
1718		1651
		1652	if (inv)
		1653	inv->above = op;
		1654
		1655	inv = op;
		1656
		1657	op->flag [FLAG_REMOVED] = 0;
		1658
		1659	if (object *pl = op->visible_to ())
		1660	esrv_send_item (pl, op);
		1661
		1662	adjust_weight (this, op->total_weight ());
		1663
		1664	inserted:
1719	/* reset the light list and los of the players on the map */	1665	/* reset the light list and los of the players on the map */
1720	if (op->glow_radius && map)	1666	if (op->glow_radius && is_on_map ())
1721	{	1667	{
1722	#ifdef DEBUG_LIGHTS	1668	update_stats ();
1723	LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1724	#endif /* DEBUG_LIGHTS */
1725	if (map->darkness)
1726	update_all_los (map, x, y);	1669	update_all_los (map, x, y);
1727	}
1728
1729	/* Client has no idea of ordering so lets not bother ordering it here.
1730	* It sure simplifies this function...
1731	*/
1732	if (!inv)
1733	inv = op;
1734	else
1735	{	1670	}
1736	op->below = inv;	1671	else if (is_player () && !flag [FLAG_NO_FIX_PLAYER])
1737	op->below->above = op;	1672	// if this is a player's inventory, update stats
1738	inv = op;	1673	update_stats ();
1739	}
1740		1674
1741	INVOKE_OBJECT (INSERT, this);	1675	INVOKE_OBJECT (INSERT, this);
1742		1676
1743	return op;	1677	return op;
1744	}	1678	}
…		…
1827	{	1761	{
1828		1762
1829	float	1763	float
1830	diff = tmp->move_slow_penalty * fabs (op->speed);	1764	diff = tmp->move_slow_penalty * fabs (op->speed);
1831		1765
1832	if (op->type == PLAYER)	1766	if (op->is_player ())
1833	if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) ||	1767	if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) ||
1834	(QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN)))	1768	(QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN)))
1835	diff /= 4.0;	1769	diff /= 4.0;
1836		1770
1837	op->speed_left -= diff;	1771	op->speed_left -= diff;
…		…
1872	LOG (llevError, "Present_arch called outside map.\n");	1806	LOG (llevError, "Present_arch called outside map.\n");
1873	return NULL;	1807	return NULL;
1874	}	1808	}
1875		1809
1876	for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)	1810	for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1877	if (tmp->arch == at)	1811	if (tmp->arch->archname == at->archname)
1878	return tmp;	1812	return tmp;
1879		1813
1880	return NULL;	1814	return NULL;
1881	}	1815	}
1882		1816
…		…
1946	* The first matching object is returned, or NULL if none.	1880	* The first matching object is returned, or NULL if none.
1947	*/	1881	*/
1948	object *	1882	object *
1949	present_arch_in_ob (const archetype *at, const object *op)	1883	present_arch_in_ob (const archetype *at, const object *op)
1950	{	1884	{
1951	for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)	1885	for (object *tmp = op->inv; tmp; tmp = tmp->below)
1952	if (tmp->arch == at)	1886	if (tmp->arch->archname == at->archname)
1953	return tmp;	1887	return tmp;
1954		1888
1955	return NULL;	1889	return NULL;
1956	}	1890	}
1957		1891
…		…
2045	* head of the object should correspond for the entire object.	1979	* head of the object should correspond for the entire object.
2046	*/	1980	*/
2047	if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))	1981	if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))
2048	continue;	1982	continue;
2049		1983
2050	if (ob->blocked (m, pos.x, pos.y))	1984	if (ob->blocked (pos.m, pos.x, pos.y))
2051	continue;	1985	continue;
2052		1986
2053	altern [index++] = i;	1987	altern [index++] = i;
2054	}	1988	}
2055		1989
…		…
2163	if ((move_type & blocked) == move_type)	2097	if ((move_type & blocked) == move_type)
2164	max = maxfree[i];	2098	max = maxfree[i];
2165	else if (mflags & P_IS_ALIVE)	2099	else if (mflags & P_IS_ALIVE)
2166	{	2100	{
2167	for (tmp = ms.bot; tmp; tmp = tmp->above)	2101	for (tmp = ms.bot; tmp; tmp = tmp->above)
2168	if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)	2102	if ((tmp->flag [FLAG_MONSTER] || tmp->is_player ())
2169	&& (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))	2103	&& (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))
2170	break;	2104	break;
2171		2105
2172	if (tmp)	2106	if (tmp)
2173	return freedir[i];	2107	return freedir[i];
…		…
2359	int	2293	int
2360	can_pick (const object *who, const object *item)	2294	can_pick (const object *who, const object *item)
2361	{	2295	{
2362	return /*QUERY_FLAG(who,FLAG_WIZ)|| */	2296	return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2363	(item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&	2297	(item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2364	!QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));	2298	!QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->is_player () || item->weight < who->weight / 3));
2365	}	2299	}
2366		2300
2367	/*	2301	/*
2368	* create clone from object to another	2302	* create clone from object to another
2369	*/	2303	*/
2370	object *	2304	object *
2371	object_create_clone (object *asrc)	2305	object::deep_clone ()
2372	{	2306	{
2373	object *dst = 0, *tmp, *src, *prev, *item;	2307	assert (("deep_clone called on non-head object", is_head ()));
2374		2308
2375	if (!asrc)	2309	object *dst = clone ();
2376	return 0;
2377		2310
2378	src = asrc->head_ ();	2311	object *prev = dst;
2379
2380	prev = 0;
2381	for (object *part = src; part; part = part->more)	2312	for (object *part = this->more; part; part = part->more)
2382	{	2313	{
2383	tmp = part->clone ();	2314	object *tmp = part->clone ();
2384	tmp->x -= src->x;
2385	tmp->y -= src->y;
2386
2387	if (!part->head)
2388	{
2389	dst = tmp;
2390	tmp->head = 0;
2391	}
2392	else
2393	tmp->head = dst;	2315	tmp->head = dst;
2394
2395	tmp->more = 0;
2396
2397	if (prev)
2398	prev->more = tmp;	2316	prev->more = tmp;
2399
2400	prev = tmp;	2317	prev = tmp;
2401	}	2318	}
2402		2319
2403	for (item = src->inv; item; item = item->below)	2320	for (object *item = inv; item; item = item->below)
2404	insert_ob_in_ob (object_create_clone (item), dst);	2321	insert_ob_in_ob (item->deep_clone (), dst);
2405		2322
2406	return dst;	2323	return dst;
2407	}	2324	}
2408		2325
2409	/* This returns the first object in who's inventory that	2326	/* This returns the first object in who's inventory that
…		…
2418	return tmp;	2335	return tmp;
2419		2336
2420	return 0;	2337	return 0;
2421	}	2338	}
2422		2339
2423	/* If ob has a field named key, return the link from the list,	2340	const shstr &
2424	* otherwise return NULL.	2341	object::kv_get (const shstr &key) const
2425	*
2426	* key must be a passed in shared string - otherwise, this won't
2427	* do the desired thing.
2428	*/
2429	key_value *
2430	get_ob_key_link (const object *ob, const char *key)
2431	{	2342	{
2432	for (key_value *link = ob->key_values; link; link = link->next)	2343	for (key_value *kv = key_values; kv; kv = kv->next)
2433	if (link->key == key)	2344	if (kv->key == key)
2434	return link;
2435
2436	return 0;
2437	}
2438
2439	/*
2440	* Returns the value of op has an extra_field for key, or NULL.
2441	*
2442	* The argument doesn't need to be a shared string.
2443	*
2444	* The returned string is shared.
2445	*/
2446	const char *
2447	get_ob_key_value (const object *op, const char *const key)
2448	{
2449	key_value *link;
2450	shstr_cmp canonical_key (key);
2451
2452	if (!canonical_key)
2453	{
2454	/* 1. There being a field named key on any object
2455	* implies there'd be a shared string to find.
2456	* 2. Since there isn't, no object has this field.
2457	* 3. Therefore, *this* object doesn't have this field.
2458	*/
2459	return 0;
2460	}
2461
2462	/* This is copied from get_ob_key_link() above -
2463	* only 4 lines, and saves the function call overhead.
2464	*/
2465	for (link = op->key_values; link; link = link->next)
2466	if (link->key == canonical_key)
2467	return link->value;	2345	return kv->value;
2468		2346
2469	return 0;	2347	return shstr_null;
2470	}	2348	}
2471		2349
2472	/*	2350	void
2473	* Updates the canonical_key in op to value.	2351	object::kv_set (const shstr &key, const shstr &value)
2474	*
2475	* canonical_key is a shared string (value doesn't have to be).
2476	*
2477	* Unless add_key is TRUE, it won't add fields, only change the value of existing
2478	* keys.
2479	*
2480	* Returns TRUE on success.
2481	*/
2482	int
2483	set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2484	{	2352	{
2485	key_value *field = NULL, *last = NULL;	2353	for (key_value *kv = key_values; kv; kv = kv->next)
2486		2354	if (kv->key == key)
2487	for (field = op->key_values; field != NULL; field = field->next)
2488	{
2489	if (field->key != canonical_key)
2490	{	2355	{
2491	last = field;	2356	kv->value = value;
2492	continue;	2357	return;
2493	}	2358	}
2494		2359
2495	if (value)	2360	key_value *kv = new key_value;
2496	field->value = value;	2361
2497	else	2362	kv->next = key_values;
		2363	kv->key = key;
		2364	kv->value = value;
		2365
		2366	key_values = kv;
		2367	}
		2368
		2369	void
		2370	object::kv_del (const shstr &key)
		2371	{
		2372	for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
		2373	if ((*kvp)->key == key)
2498	{	2374	{
2499	/* Basically, if the archetype has this key set,	2375	key_value *kv = *kvp;
2500	* we need to store the null value so when we save	2376	*kvp = (*kvp)->next;
2501	* it, we save the empty value so that when we load,	2377	delete kv;
2502	* we get this value back again.	2378	return;
2503	*/
2504	if (get_ob_key_link (op->arch, canonical_key))
2505	field->value = 0;
2506	else
2507	{
2508	if (last)
2509	last->next = field->next;
2510	else
2511	op->key_values = field->next;
2512
2513	delete field;
2514	}
2515	}	2379	}
2516	return TRUE;
2517	}
2518	/* IF we get here, key doesn't exist */
2519
2520	/* No field, we'll have to add it. */
2521
2522	if (!add_key)
2523	return FALSE;
2524
2525	/* There isn't any good reason to store a null
2526	* value in the key/value list. If the archetype has
2527	* this key, then we should also have it, so shouldn't
2528	* be here. If user wants to store empty strings,
2529	* should pass in ""
2530	*/
2531	if (value == NULL)
2532	return TRUE;
2533
2534	field = new key_value;
2535
2536	field->key = canonical_key;
2537	field->value = value;
2538	/* Usual prepend-addition. */
2539	field->next = op->key_values;
2540	op->key_values = field;
2541
2542	return TRUE;
2543	}
2544
2545	/*
2546	* Updates the key in op to value.
2547	*
2548	* If add_key is FALSE, this will only update existing keys,
2549	* and not add new ones.
2550	* In general, should be little reason FALSE is ever passed in for add_key
2551	*
2552	* Returns TRUE on success.
2553	*/
2554	int
2555	set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2556	{
2557	shstr key_ (key);
2558
2559	return set_ob_key_value_s (op, key_, value, add_key);
2560	}	2380	}
2561		2381
2562	object::depth_iterator::depth_iterator (object *container)	2382	object::depth_iterator::depth_iterator (object *container)
2563	: iterator_base (container)	2383	: iterator_base (container)
2564	{	2384	{
…		…
2614	{	2434	{
2615	char flagdesc[512];	2435	char flagdesc[512];
2616	char info2[256 * 4];	2436	char info2[256 * 4];
2617	char *p = info;	2437	char *p = info;
2618		2438
2619	p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s,flags:[%s],type:%d}",	2439	p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2620	count,	2440	count,
2621	uuid.c_str (),	2441	uuid.c_str (),
2622	&name,	2442	&name,
2623	title ? "\",title:\"" : "",	2443	title ? ",title:\"" : "",
2624	title ? (const char *)title : "",	2444	title ? (const char *)title : "",
		2445	title ? "\"" : "",
2625	flag_desc (flagdesc, 512), type);	2446	flag_desc (flagdesc, 512), type);
2626		2447
2627	if (!this->flag[FLAG_REMOVED] && env)	2448	if (!flag[FLAG_REMOVED] && env)
2628	p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));	2449	p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2629		2450
2630	if (map)	2451	if (map)
2631	p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);	2452	p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2632		2453
…		…
2662	object::open_container (object *new_container)	2483	object::open_container (object *new_container)
2663	{	2484	{
2664	if (container == new_container)	2485	if (container == new_container)
2665	return;	2486	return;
2666		2487
2667	if (object *old_container = container)	2488	object *old_container = container;
		2489
		2490	if (old_container)
2668	{	2491	{
2669	if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))	2492	if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))
2670	return;	2493	return;
2671		2494
2672	#if 0	2495	#if 0
…		…
2674	if (object *closer = old_container->inv)	2497	if (object *closer = old_container->inv)
2675	if (closer->type == CLOSE_CON)	2498	if (closer->type == CLOSE_CON)
2676	closer->destroy ();	2499	closer->destroy ();
2677	#endif	2500	#endif
2678		2501
		2502	// make sure the container is available
		2503	esrv_send_item (this, old_container);
		2504
2679	old_container->flag [FLAG_APPLIED] = 0;	2505	old_container->flag [FLAG_APPLIED] = false;
2680	container = 0;	2506	container = 0;
2681		2507
		2508	// client needs item update to make it work, client bug requires this to be separate
2682	esrv_update_item (UPD_FLAGS, this, old_container);	2509	esrv_update_item (UPD_FLAGS, this, old_container);
		2510
2683	new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container));	2511	new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container));
2684	play_sound (sound_find ("chest_close"));	2512	play_sound (sound_find ("chest_close"));
2685	}	2513	}
2686		2514
2687	if (new_container)	2515	if (new_container)
…		…
2700	}	2528	}
2701	#endif	2529	#endif
2702		2530
2703	new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container));	2531	new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container));
2704		2532
		2533	// make sure the container is available, client bug requires this to be separate
		2534	esrv_send_item (this, new_container);
		2535
2705	new_container->flag [FLAG_APPLIED] = 1;	2536	new_container->flag [FLAG_APPLIED] = true;
2706	container = new_container;	2537	container = new_container;
2707		2538
		2539	// client needs flag change
2708	esrv_update_item (UPD_FLAGS, this, new_container);	2540	esrv_update_item (UPD_FLAGS, this, new_container);
2709	esrv_send_inventory (this, new_container);	2541	esrv_send_inventory (this, new_container);
2710	play_sound (sound_find ("chest_open"));	2542	play_sound (sound_find ("chest_open"));
2711	}	2543	}
		2544	// else if (!old_container->env && contr && contr->ns)
		2545	// contr->ns->floorbox_reset ();
2712	}	2546	}
2713		2547
2714	object *	2548	object *
2715	object::force_find (const shstr name)	2549	object::force_find (const shstr name)
2716	{	2550	{
…		…
2722	return splay (tmp);	2556	return splay (tmp);
2723		2557
2724	return 0;	2558	return 0;
2725	}	2559	}
2726		2560
2727	void	2561	object *
2728	object::force_add (const shstr name, int duration)	2562	object::force_add (const shstr name, int duration)
2729	{	2563	{
2730	if (object *force = force_find (name))	2564	if (object *force = force_find (name))
2731	force->destroy ();	2565	force->destroy ();
2732		2566
…		…
2738		2572
2739	force->set_speed (duration ? 1.f / duration : 0.f);	2573	force->set_speed (duration ? 1.f / duration : 0.f);
2740	force->flag [FLAG_IS_USED_UP] = true;	2574	force->flag [FLAG_IS_USED_UP] = true;
2741	force->flag [FLAG_APPLIED] = true;	2575	force->flag [FLAG_APPLIED] = true;
2742		2576
2743	insert (force);	2577	return insert (force);
2744	}	2578	}
2745		2579
2746	void	2580	void
2747	object::play_sound (faceidx sound) const	2581	object::play_sound (faceidx sound)
2748	{	2582	{
2749	if (!sound)	2583	if (!sound)
2750	return;	2584	return;
2751		2585
2752	if (flag [FLAG_REMOVED])	2586	if (flag [FLAG_REMOVED])
…		…
2759	}	2593	}
2760	else	2594	else
2761	map->play_sound (sound, x, y);	2595	map->play_sound (sound, x, y);
2762	}	2596	}
2763		2597
		2598	void
		2599	object::make_noise ()
		2600	{
		2601	// we do not model noise in the map, so instead put
		2602	// a temporary light into the noise source
		2603	// could use the map instead, but that's less reliable for our
		2604	// goal, which is to make invisibility a bit harder to exploit
		2605
		2606	// currently only works sensibly for players
		2607	if (!is_player ())
		2608	return;
		2609
		2610	// find old force, or create new one
		2611	object *force = force_find (shstr_noise_force);
		2612
		2613	if (force)
		2614	force->speed_left = -1.f; // patch old speed up
		2615	else
		2616	{
		2617	force = archetype::get (shstr_noise_force);
		2618
		2619	force->slaying = shstr_noise_force;
		2620	force->stats.food = 1;
		2621	force->speed_left = -1.f;
		2622
		2623	force->set_speed (1.f / 4.f);
		2624	force->flag [FLAG_IS_USED_UP] = true;
		2625	force->flag [FLAG_APPLIED] = true;
		2626
		2627	insert (force);
		2628	}
		2629	}
		2630

Diff Legend

–	Removed lines
+	Added lines
<	Changed lines
>	Changed lines