ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.206 by root, Tue Apr 15 14:21:04 2008 UTC vs.
Revision 1.293 by root, Wed Oct 21 00:44:39 2009 UTC

1/* 1/*
2 * This file is part of Deliantra, the Roguelike Realtime MMORPG. 2 * This file is part of Deliantra, the Roguelike Realtime MMORPG.
3 * 3 *
4 * Copyright (©) 2005,2006,2007 Marc Alexander Lehmann / Robin Redeker / the Deliantra team 4 * Copyright (©) 2005,2006,2007,2008,2009 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team 5 * Copyright (©) 2001,2007 Mark Wedel & Crossfire Development Team
6 * Copyright (©) 1992,2007 Frank Tore Johansen 6 * Copyright (©) 1992,2007 Frank Tore Johansen
7 * 7 *
8 * Deliantra is free software: you can redistribute it and/or modify 8 * Deliantra is free software: you can redistribute it and/or modify it under
9 * it under the terms of the GNU General Public License as published by 9 * the terms of the Affero GNU General Public License as published by the
10 * the Free Software Foundation, either version 3 of the License, or 10 * Free Software Foundation, either version 3 of the License, or (at your
11 * (at your option) any later version. 11 * option) any later version.
12 * 12 *
13 * This program is distributed in the hope that it will be useful, 13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details. 16 * GNU General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU General Public License 18 * You should have received a copy of the Affero GNU General Public License
19 * along with this program. If not, see <http://www.gnu.org/licenses/>. 19 * and the GNU General Public License along with this program. If not, see
20 * <http://www.gnu.org/licenses/>.
20 * 21 *
21 * The authors can be reached via e-mail to <support@deliantra.net> 22 * The authors can be reached via e-mail to <support@deliantra.net>
22 */ 23 */
23 24
24/* Eneq(@csd.uu.se): Added weight-modifiers in environment of objects.
25 sub/add_weight will transcend the environment updating the carrying
26 variable. */
27#include <global.h> 25#include <global.h>
28#include <stdio.h> 26#include <stdio.h>
29#include <sys/types.h> 27#include <sys/types.h>
30#include <sys/uio.h> 28#include <sys/uio.h>
31#include <object.h> 29#include <object.h>
32#include <funcpoint.h>
33#include <sproto.h> 30#include <sproto.h>
34#include <loader.h> 31#include <loader.h>
35 32
36#include <bitset> 33#include <bitset>
37 34
38UUID UUID::cur; 35UUID UUID::cur;
39static uint64_t seq_next_save; 36static uint64_t seq_next_save;
40static const uint64 UUID_GAP = 1<<19; 37static const uint64 UUID_GAP = 1<<19;
38uint32_t mapspace::smellcount = 10000;
41 39
42objectvec objects; 40objectvec objects;
43activevec actives; 41activevec actives;
44 42
45short freearr_x[SIZEOFFREE] = { 43short freearr_x[SIZEOFFREE] = {
143 141
144/* Returns TRUE if every key_values in wants has a partner with the same value in has. */ 142/* Returns TRUE if every key_values in wants has a partner with the same value in has. */
145static bool 143static bool
146compare_ob_value_lists_one (const object *wants, const object *has) 144compare_ob_value_lists_one (const object *wants, const object *has)
147{ 145{
148 key_value *wants_field;
149
150 /* n-squared behaviour (see get_ob_key_link()), but I'm hoping both 146 /* n-squared behaviour (see kv_get), but I'm hoping both
151 * objects with lists are rare, and lists stay short. If not, use a 147 * objects with lists are rare, and lists stay short. If not, use a
152 * different structure or at least keep the lists sorted... 148 * different structure or at least keep the lists sorted...
153 */ 149 */
154 150
155 /* For each field in wants, */ 151 /* For each field in wants, */
156 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next) 152 for (key_value *kv = wants->key_values; kv; kv = kv->next)
157 { 153 if (has->kv_get (kv->key) != kv->value)
158 key_value *has_field; 154 return false;
159
160 /* Look for a field in has with the same key. */
161 has_field = get_ob_key_link (has, wants_field->key);
162
163 if (!has_field)
164 return 0; /* No field with that name. */
165
166 /* Found the matching field. */
167 if (has_field->value != wants_field->value)
168 return 0; /* Values don't match, so this half of the comparison is false. */
169
170 /* If we get here, we found a match. Now for the next field in wants. */
171 }
172 155
173 /* If we get here, every field in wants has a matching field in has. */ 156 /* If we get here, every field in wants has a matching field in has. */
174 return 1; 157 return true;
175} 158}
176 159
177/* Returns TRUE if ob1 has the same key_values as ob2. */ 160/* Returns TRUE if ob1 has the same key_values as ob2. */
178static bool 161static bool
179compare_ob_value_lists (const object *ob1, const object *ob2) 162compare_ob_value_lists (const object *ob1, const object *ob2)
180{ 163{
181 /* However, there may be fields in has which aren't partnered in wants, 164 /* However, there may be fields in has which aren't partnered in wants,
182 * so we need to run the comparison *twice*. :( 165 * so we need to run the comparison *twice*. :(
183 */ 166 */
184 return compare_ob_value_lists_one (ob1, ob2) && compare_ob_value_lists_one (ob2, ob1); 167 return compare_ob_value_lists_one (ob1, ob2)
168 && compare_ob_value_lists_one (ob2, ob1);
185} 169}
186 170
187/* Function examines the 2 objects given to it, and returns true if 171/* Function examines the 2 objects given to it, and returns true if
188 * they can be merged together. 172 * they can be merged together.
189 * 173 *
204 || ob1->speed != ob2->speed 188 || ob1->speed != ob2->speed
205 || ob1->value != ob2->value 189 || ob1->value != ob2->value
206 || ob1->name != ob2->name) 190 || ob1->name != ob2->name)
207 return 0; 191 return 0;
208 192
209 /* Do not merge objects if nrof would overflow. First part checks 193 /* Do not merge objects if nrof would overflow, assume nrof
210 * for unsigned overflow (2c), second part checks wether the result 194 * is always 0 .. 2**31-1 */
211 * would fit into a 32 bit signed int, which is often used to hold 195 if (ob1->nrof > 0x7fffffff - ob2->nrof)
212 * nrof values.
213 */
214 if (~ob1->nrof < ob2->nrof || ob1->nrof + ob2->nrof > (1UL << 31))
215 return 0; 196 return 0;
216 197
217 /* If the objects have been identified, set the BEEN_APPLIED flag. 198 /* If the objects have been identified, set the BEEN_APPLIED flag.
218 * This is to the comparison of the flags below will be OK. We 199 * This is to the comparison of the flags below will be OK. We
219 * just can't ignore the been applied or identified flags, as they 200 * just can't ignore the been applied or identified flags, as they
224 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 205 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
225 206
226 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 207 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
227 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 208 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
228 209
229 if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any () 210 if (ob1->arch->archname != ob2->arch->archname
230 || ob1->arch != ob2->arch
231 || ob1->name != ob2->name 211 || ob1->name != ob2->name
232 || ob1->title != ob2->title 212 || ob1->title != ob2->title
233 || ob1->msg != ob2->msg 213 || ob1->msg != ob2->msg
234 || ob1->weight != ob2->weight 214 || ob1->weight != ob2->weight
235 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
236 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
237 || ob1->attacktype != ob2->attacktype 215 || ob1->attacktype != ob2->attacktype
238 || ob1->magic != ob2->magic 216 || ob1->magic != ob2->magic
239 || ob1->slaying != ob2->slaying 217 || ob1->slaying != ob2->slaying
240 || ob1->skill != ob2->skill 218 || ob1->skill != ob2->skill
241 || ob1->value != ob2->value 219 || ob1->value != ob2->value
242 || ob1->animation_id != ob2->animation_id 220 || ob1->animation_id != ob2->animation_id
221 || (ob1->face != ob2->face && !ob1->animation_id) // face and animation are dependent on each other
243 || ob1->client_type != ob2->client_type 222 || ob1->client_type != ob2->client_type
244 || ob1->materialname != ob2->materialname 223 || ob1->materialname != ob2->materialname
245 || ob1->lore != ob2->lore 224 || ob1->lore != ob2->lore
246 || ob1->subtype != ob2->subtype 225 || ob1->subtype != ob2->subtype
247 || ob1->move_type != ob2->move_type 226 || ob1->move_type != ob2->move_type
248 || ob1->move_block != ob2->move_block 227 || ob1->move_block != ob2->move_block
249 || ob1->move_allow != ob2->move_allow 228 || ob1->move_allow != ob2->move_allow
250 || ob1->move_on != ob2->move_on 229 || ob1->move_on != ob2->move_on
251 || ob1->move_off != ob2->move_off 230 || ob1->move_off != ob2->move_off
252 || ob1->move_slow != ob2->move_slow 231 || ob1->move_slow != ob2->move_slow
253 || ob1->move_slow_penalty != ob2->move_slow_penalty) 232 || ob1->move_slow_penalty != ob2->move_slow_penalty
233 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
234 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats)))
235 return 0;
236
237 if ((ob1->flag ^ ob2->flag)
238 .reset (FLAG_INV_LOCKED)
239 .reset (FLAG_REMOVED)
240 .any ())
254 return 0; 241 return 0;
255 242
256 /* This is really a spellbook check - we should in general 243 /* This is really a spellbook check - we should in general
257 * not merge objects with real inventories, as splitting them 244 * not merge objects with real inventories, as splitting them
258 * is hard. 245 * is hard.
297 284
298 if (ob1->key_values || ob2->key_values) 285 if (ob1->key_values || ob2->key_values)
299 { 286 {
300 /* At least one of these has key_values. */ 287 /* At least one of these has key_values. */
301 if ((!ob1->key_values) != (!ob2->key_values)) 288 if ((!ob1->key_values) != (!ob2->key_values))
302 /* One has fields, but the other one doesn't. */ 289 return 0; /* One has fields, but the other one doesn't. */
303 return 0; 290
304 else if (!compare_ob_value_lists (ob1, ob2)) 291 if (!compare_ob_value_lists (ob1, ob2))
305 return 0; 292 return 0;
306 } 293 }
307 294
308 if (ob1->self || ob2->self) 295 if (ob1->self || ob2->self)
309 { 296 {
315 int k1 = ob1->self ? HvTOTALKEYS (ob1->self) : 0; 302 int k1 = ob1->self ? HvTOTALKEYS (ob1->self) : 0;
316 int k2 = ob2->self ? HvTOTALKEYS (ob2->self) : 0; 303 int k2 = ob2->self ? HvTOTALKEYS (ob2->self) : 0;
317 304
318 if (k1 != k2) 305 if (k1 != k2)
319 return 0; 306 return 0;
307
320 else if (k1 == 0) 308 if (k1 == 0)
321 return 1; 309 return 1;
310
322 else if (!cfperl_can_merge (ob1, ob2)) 311 if (!cfperl_can_merge (ob1, ob2))
323 return 0; 312 return 0;
324 } 313 }
325 } 314 }
326 315
327 /* Everything passes, must be OK. */ 316 /* Everything passes, must be OK. */
328 return 1; 317 return 1;
329} 318}
330 319
320// find player who can see this object
321object *
322object::visible_to () const
323{
324 if (client_visible () && !flag [FLAG_REMOVED])
325 {
326 // see if we are in a container of sorts
327 if (env)
328 {
329 // the player inventory itself is always visible
330 if (env->is_player ())
331 return env;
332
333 // else a player could have our env open
334 object *envest = env->outer_env_or_self ();
335
336 // the player itself is always on a map, so we will find him here
337 // even if our inv is in a player.
338 if (envest->is_on_map ())
339 if (object *pl = envest->ms ().player ())
340 if (pl->container_ () == env)
341 return pl;
342 }
343 else
344 {
345 // maybe there is a player standing on the same mapspace
346 // this will catch the case where "this" is a player
347 if (object *pl = ms ().player ())
348 if ((pl->contr->ns && !pl->container_ () && !pl->contr->ns->update_look)
349 || pl->container_ () == this)
350 return pl;
351 }
352 }
353
354 return 0;
355}
356
357// adjust weight per container type ("of holding")
358static sint32
359weight_adjust_for (object *op, sint32 weight)
360{
361 return op->type == CONTAINER
362 ? lerp (weight, 0, 100, 0, 100 - op->stats.Str)
363 : weight;
364}
365
331/* 366/*
367 * adjust_weight(object, weight) adds the specified weight to an object,
368 * and also updates how much the environment(s) is/are carrying.
369 */
370static void
371adjust_weight (object *op, sint32 weight)
372{
373 while (op)
374 {
375 // adjust by actual difference to account for rounding errors
376 // i.e. (w2 - w1) / f != w2 / f - w1 / f and the latter is correct
377 weight = weight_adjust_for (op, op->carrying)
378 - weight_adjust_for (op, op->carrying - weight);
379
380 if (!weight)
381 return;
382
383 op->carrying += weight;
384
385 if (object *pl = op->visible_to ())
386 if (pl != op) // player is handled lazily
387 esrv_update_item (UPD_WEIGHT, pl, op);
388
389 op = op->env;
390 }
391}
392
393/*
332 * sum_weight() is a recursive function which calculates the weight 394 * this is a recursive function which calculates the weight
333 * an object is carrying. It goes through in figures out how much 395 * an object is carrying. It goes through op and figures out how much
334 * containers are carrying, and sums it up. 396 * containers are carrying, and sums it up.
335 */ 397 */
336long 398void
337sum_weight (object *op) 399object::update_weight ()
338{ 400{
339 long sum; 401 sint32 sum = 0;
340 object *inv;
341 402
342 for (sum = 0, inv = op->inv; inv; inv = inv->below) 403 for (object *op = inv; op; op = op->below)
343 { 404 {
344 if (inv->inv) 405 if (op->inv)
345 sum_weight (inv); 406 op->update_weight ();
346 407
347 sum += inv->carrying + inv->weight * (inv->nrof ? inv->nrof : 1); 408 sum += op->total_weight ();
409 }
410
411 sum = weight_adjust_for (this, sum);
412
413 if (sum != carrying)
348 } 414 {
349
350 if (op->type == CONTAINER && op->stats.Str)
351 sum = (sum * (100 - op->stats.Str)) / 100;
352
353 if (op->carrying != sum)
354 op->carrying = sum; 415 carrying = sum;
355 416
356 return sum; 417 if (object *pl = visible_to ())
418 if (pl != this) // player is handled lazily
419 esrv_update_item (UPD_WEIGHT, pl, this);
420 }
357} 421}
358 422
359/** 423/*
360 * Return the outermost environment object for a given object. 424 * Used by: Server DM commands: dumpbelow, dump. Some error messages.
361 */
362
363object *
364object_get_env_recursive (object *op)
365{
366 while (op->env != NULL)
367 op = op->env;
368 return op;
369}
370
371/*
372 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
373 * Some error messages.
374 * The result of the dump is stored in the static global errmsg array.
375 */ 425 */
376char * 426char *
377dump_object (object *op) 427dump_object (object *op)
378{ 428{
379 if (!op) 429 if (!op)
382 object_freezer freezer; 432 object_freezer freezer;
383 op->write (freezer); 433 op->write (freezer);
384 return freezer.as_string (); 434 return freezer.as_string ();
385} 435}
386 436
437char *
438object::as_string ()
439{
440 return dump_object (this);
441}
442
387/* 443/*
388 * get_nearest_part(multi-object, object 2) returns the part of the 444 * get_nearest_part(multi-object, object 2) returns the part of the
389 * multi-object 1 which is closest to the second object. 445 * multi-object 1 which is closest to the second object.
390 * If it's not a multi-object, it is returned. 446 * If it's not a multi-object, it is returned.
391 */ 447 */
393get_nearest_part (object *op, const object *pl) 449get_nearest_part (object *op, const object *pl)
394{ 450{
395 object *tmp, *closest; 451 object *tmp, *closest;
396 int last_dist, i; 452 int last_dist, i;
397 453
398 if (op->more == NULL) 454 if (!op->more)
399 return op; 455 return op;
456
400 for (last_dist = distance (op, pl), closest = op, tmp = op->more; tmp != NULL; tmp = tmp->more) 457 for (last_dist = distance (op, pl), closest = op, tmp = op->more;
458 tmp;
459 tmp = tmp->more)
401 if ((i = distance (tmp, pl)) < last_dist) 460 if ((i = distance (tmp, pl)) < last_dist)
402 closest = tmp, last_dist = i; 461 closest = tmp, last_dist = i;
462
403 return closest; 463 return closest;
404} 464}
405 465
406/* 466/*
407 * Returns the object which has the count-variable equal to the argument. 467 * Returns the object which has the count-variable equal to the argument.
468 * VERRRY slow.
408 */ 469 */
409object * 470object *
410find_object (tag_t i) 471find_object (tag_t i)
411{ 472{
412 for_all_objects (op) 473 for_all_objects (op)
423 */ 484 */
424object * 485object *
425find_object_name (const char *str) 486find_object_name (const char *str)
426{ 487{
427 shstr_cmp str_ (str); 488 shstr_cmp str_ (str);
428 object *op;
429 489
490 if (str_)
430 for_all_objects (op) 491 for_all_objects (op)
431 if (op->name == str_) 492 if (op->name == str_)
432 break; 493 return op;
433 494
434 return op; 495 return 0;
435} 496}
436 497
437/* 498/*
438 * Sets the owner and sets the skill and exp pointers to owner's current 499 * Sets the owner and sets the skill and exp pointers to owner's current
439 * skill and experience objects. 500 * skill and experience objects.
501 update_stats (); 562 update_stats ();
502 563
503 new_draw_info_format (NDI_UNIQUE, 0, this, 564 new_draw_info_format (NDI_UNIQUE, 0, this,
504 "You try to balance all your items at once, " 565 "You try to balance all your items at once, "
505 "but the %s is just too much for your body. " 566 "but the %s is just too much for your body. "
506 "[You need to unapply some items first.]", &ob->name); 567 "[You need to unapply some items first - use the 'body' command to see "
568 "how many items you cna wera on a specific body part.]", &ob->name);
507 return false; 569 return false;
508 } 570 }
509 571
510 //new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name); 572 //new_draw_info_format (NDI_UNIQUE, 0, this, "You switch to your %s.", &ob->name);
511 } 573 }
537 } 599 }
538 600
539 op->key_values = 0; 601 op->key_values = 0;
540} 602}
541 603
542object & 604/*
543object::operator =(const object &src) 605 * copy_to first frees everything allocated by the dst object,
606 * and then copies the contents of itself into the second
607 * object, allocating what needs to be allocated. Basically, any
608 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
609 * if the first object is freed, the pointers in the new object
610 * will point at garbage.
611 */
612void
613object::copy_to (object *dst)
544{ 614{
545 bool is_freed = flag [FLAG_FREED]; 615 dst->remove ();
546 bool is_removed = flag [FLAG_REMOVED];
547
548 *(object_copy *)this = src; 616 *(object_copy *)dst = *this;
549
550 flag [FLAG_FREED] = is_freed;
551 flag [FLAG_REMOVED] = is_removed; 617 dst->flag [FLAG_REMOVED] = true;
552 618
553 /* Copy over key_values, if any. */ 619 /* Copy over key_values, if any. */
554 if (src.key_values) 620 if (key_values)
555 { 621 {
556 key_value *tail = 0; 622 key_value *tail = 0;
557 key_values = 0; 623 dst->key_values = 0;
558 624
559 for (key_value *i = src.key_values; i; i = i->next) 625 for (key_value *i = key_values; i; i = i->next)
560 { 626 {
561 key_value *new_link = new key_value; 627 key_value *new_link = new key_value;
562 628
563 new_link->next = 0; 629 new_link->next = 0;
564 new_link->key = i->key; 630 new_link->key = i->key;
565 new_link->value = i->value; 631 new_link->value = i->value;
566 632
567 /* Try and be clever here, too. */ 633 /* Try and be clever here, too. */
568 if (!key_values) 634 if (!dst->key_values)
569 { 635 {
570 key_values = new_link; 636 dst->key_values = new_link;
571 tail = new_link; 637 tail = new_link;
572 } 638 }
573 else 639 else
574 { 640 {
575 tail->next = new_link; 641 tail->next = new_link;
576 tail = new_link; 642 tail = new_link;
577 } 643 }
578 } 644 }
579 } 645 }
580}
581
582/*
583 * copy_to first frees everything allocated by the dst object,
584 * and then copies the contents of itself into the second
585 * object, allocating what needs to be allocated. Basically, any
586 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
587 * if the first object is freed, the pointers in the new object
588 * will point at garbage.
589 */
590void
591object::copy_to (object *dst)
592{
593 *dst = *this;
594 646
595 if (speed < 0) 647 if (speed < 0)
596 dst->speed_left -= rndm (); 648 dst->speed_left -= rndm ();
597 649
598 dst->set_speed (dst->speed); 650 dst->activate ();
599} 651}
600 652
601void 653void
602object::instantiate () 654object::instantiate ()
603{ 655{
620object * 672object *
621object::clone () 673object::clone ()
622{ 674{
623 object *neu = create (); 675 object *neu = create ();
624 copy_to (neu); 676 copy_to (neu);
677 neu->map = map; // not copied by copy_to
625 return neu; 678 return neu;
626} 679}
627 680
628/* 681/*
629 * If an object with the IS_TURNABLE() flag needs to be turned due 682 * If an object with the IS_TURNABLE() flag needs to be turned due
680 * UP_OBJ_FACE: only the objects face has changed. 733 * UP_OBJ_FACE: only the objects face has changed.
681 */ 734 */
682void 735void
683update_object (object *op, int action) 736update_object (object *op, int action)
684{ 737{
685 if (op == NULL) 738 if (!op)
686 { 739 {
687 /* this should never happen */ 740 /* this should never happen */
688 LOG (llevDebug, "update_object() called for NULL object.\n"); 741 LOG (llevError | logBacktrace, "update_object() called for NULL object.\n");
689 return; 742 return;
690 } 743 }
691 744
692 if (op->env) 745 if (!op->is_on_map ())
693 { 746 {
694 /* Animation is currently handled by client, so nothing 747 /* Animation is currently handled by client, so nothing
695 * to do in this case. 748 * to do in this case.
696 */ 749 */
697 return; 750 return;
698 } 751 }
699
700 /* If the map is saving, don't do anything as everything is
701 * going to get freed anyways.
702 */
703 if (!op->map || op->map->in_memory == MAP_SAVING)
704 return;
705 752
706 /* make sure the object is within map boundaries */ 753 /* make sure the object is within map boundaries */
707 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height) 754 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
708 { 755 {
709 LOG (llevError, "update_object() called for object out of map!\n"); 756 LOG (llevError, "update_object() called for object out of map!\n");
720 else if (action == UP_OBJ_INSERT) 767 else if (action == UP_OBJ_INSERT)
721 { 768 {
722 // this is likely overkill, TODO: revisit (schmorp) 769 // this is likely overkill, TODO: revisit (schmorp)
723 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW)) 770 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
724 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC)) 771 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
725 || (op->type == PLAYER && !(m.flags_ & P_PLAYER)) 772 || (op->is_player () && !(m.flags_ & P_PLAYER))
726 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE)) 773 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
727 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE)) 774 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
728 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC)) 775 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
729 || (m.move_on | op->move_on ) != m.move_on 776 || (m.move_on | op->move_on ) != m.move_on
730 || (m.move_off | op->move_off ) != m.move_off 777 || (m.move_off | op->move_off ) != m.move_off
731 || (m.move_slow | op->move_slow) != m.move_slow 778 || (m.move_slow | op->move_slow) != m.move_slow
732 /* This isn't perfect, but I don't expect a lot of objects to 779 /* This isn't perfect, but I don't expect a lot of objects to
733 * to have move_allow right now. 780 * have move_allow right now.
734 */ 781 */
735 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block 782 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
736 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp) 783 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
737 m.flags_ = 0; 784 m.invalidate ();
738 } 785 }
739 /* if the object is being removed, we can't make intelligent 786 /* if the object is being removed, we can't make intelligent
740 * decisions, because remove_ob can't really pass the object 787 * decisions, because remove_ob can't really pass the object
741 * that is being removed. 788 * that is being removed.
742 */ 789 */
743 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 790 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
744 m.flags_ = 0; 791 m.invalidate ();
745 else if (action == UP_OBJ_FACE) 792 else if (action == UP_OBJ_FACE)
746 /* Nothing to do for that case */ ; 793 /* Nothing to do for that case */ ;
747 else 794 else
748 LOG (llevError, "update_object called with invalid action: %d\n", action); 795 LOG (llevError, "update_object called with invalid action: %d\n", action);
749 796
753 800
754object::object () 801object::object ()
755{ 802{
756 SET_FLAG (this, FLAG_REMOVED); 803 SET_FLAG (this, FLAG_REMOVED);
757 804
758 expmul = 1.0; 805 //expmul = 1.0; declared const for the time being
759 face = blank_face; 806 face = blank_face;
760} 807}
761 808
762object::~object () 809object::~object ()
763{ 810{
793 /* If already on active list, don't do anything */ 840 /* If already on active list, don't do anything */
794 if (active) 841 if (active)
795 return; 842 return;
796 843
797 if (has_active_speed ()) 844 if (has_active_speed ())
845 {
846 if (flag [FLAG_FREED])
847 LOG (llevError | logBacktrace, "BUG: tried to activate freed object %s\n", debug_desc ());//D
848
798 actives.insert (this); 849 actives.insert (this);
850 }
799} 851}
800 852
801void 853void
802object::activate_recursive () 854object::activate_recursive ()
803{ 855{
852object::destroy_inv (bool drop_to_ground) 904object::destroy_inv (bool drop_to_ground)
853{ 905{
854 // need to check first, because the checks below might segfault 906 // need to check first, because the checks below might segfault
855 // as we might be on an invalid mapspace and crossfire code 907 // as we might be on an invalid mapspace and crossfire code
856 // is too buggy to ensure that the inventory is empty. 908 // is too buggy to ensure that the inventory is empty.
857 // corollary: if you create arrows etc. with stuff in tis inventory, 909 // corollary: if you create arrows etc. with stuff in its inventory,
858 // cf will crash below with off-map x and y 910 // cf will crash below with off-map x and y
859 if (!inv) 911 if (!inv)
860 return; 912 return;
861 913
862 /* Only if the space blocks everything do we not process - 914 /* Only if the space blocks everything do we not process -
864 * drop on that space. 916 * drop on that space.
865 */ 917 */
866 if (!drop_to_ground 918 if (!drop_to_ground
867 || !map 919 || !map
868 || map->in_memory != MAP_ACTIVE 920 || map->in_memory != MAP_ACTIVE
869 || map->nodrop 921 || map->no_drop
870 || ms ().move_block == MOVE_ALL) 922 || ms ().move_block == MOVE_ALL)
871 { 923 {
872 while (inv) 924 while (inv)
873 {
874 inv->destroy_inv (drop_to_ground);
875 inv->destroy (); 925 inv->destroy ();
876 }
877 } 926 }
878 else 927 else
879 { /* Put objects in inventory onto this space */ 928 { /* Put objects in inventory onto this space */
880 while (inv) 929 while (inv)
881 { 930 {
899 object *op = new object; 948 object *op = new object;
900 op->link (); 949 op->link ();
901 return op; 950 return op;
902} 951}
903 952
953static struct freed_map : maptile
954{
955 freed_map ()
956 {
957 path = "<freed objects map>";
958 name = "/internal/freed_objects_map";
959 width = 3;
960 height = 3;
961 no_drop = 1;
962 no_reset = 1;
963
964 alloc ();
965 in_memory = MAP_ACTIVE;
966 }
967
968 ~freed_map ()
969 {
970 destroy ();
971 }
972} freed_map; // freed objects are moved here to avoid crashes
973
904void 974void
905object::do_destroy () 975object::do_destroy ()
906{ 976{
907 attachable::do_destroy ();
908
909 if (flag [FLAG_IS_LINKED]) 977 if (flag [FLAG_IS_LINKED])
910 remove_button_link (this); 978 remove_link ();
911 979
912 if (flag [FLAG_FRIENDLY]) 980 if (flag [FLAG_FRIENDLY])
913 remove_friendly_object (this); 981 remove_friendly_object (this);
914 982
915 if (!flag [FLAG_REMOVED])
916 remove (); 983 remove ();
917 984
918 destroy_inv (true); 985 attachable::do_destroy ();
919 986
920 deactivate (); 987 deactivate ();
921 unlink (); 988 unlink ();
922 989
923 flag [FLAG_FREED] = 1; 990 flag [FLAG_FREED] = 1;
924 991
925 // hack to ensure that freed objects still have a valid map 992 // hack to ensure that freed objects still have a valid map
926 {
927 static maptile *freed_map; // freed objects are moved here to avoid crashes
928
929 if (!freed_map)
930 {
931 freed_map = new maptile;
932
933 freed_map->path = "<freed objects map>";
934 freed_map->name = "/internal/freed_objects_map";
935 freed_map->width = 3;
936 freed_map->height = 3;
937 freed_map->nodrop = 1;
938
939 freed_map->alloc ();
940 freed_map->in_memory = MAP_ACTIVE;
941 }
942
943 map = freed_map; 993 map = &freed_map;
944 x = 1; 994 x = 1;
945 y = 1; 995 y = 1;
946 }
947 996
948 if (more) 997 if (more)
949 { 998 {
950 more->destroy (); 999 more->destroy ();
951 more = 0; 1000 more = 0;
959 attacked_by = 0; 1008 attacked_by = 0;
960 current_weapon = 0; 1009 current_weapon = 0;
961} 1010}
962 1011
963void 1012void
964object::destroy (bool destroy_inventory) 1013object::destroy ()
965{ 1014{
966 if (destroyed ()) 1015 if (destroyed ())
967 return; 1016 return;
968 1017
969 if (destroy_inventory) 1018 if (!is_head () && !head->destroyed ())
1019 {
1020 LOG (llevError | logBacktrace, "tried to destroy the tail of an object");
1021 head->destroy ();
1022 return;
1023 }
1024
970 destroy_inv (false); 1025 destroy_inv (false);
971 1026
972 if (is_head ()) 1027 if (is_head ())
973 if (sound_destroy) 1028 if (sound_destroy)
974 play_sound (sound_destroy); 1029 play_sound (sound_destroy);
975 else if (flag [FLAG_MONSTER]) 1030 else if (flag [FLAG_MONSTER])
976 play_sound (sound_find ("monster_destroy")); // quick hack, too lazy to create a generic mechanism 1031 play_sound (sound_find ("monster_destroy")); // quick hack, too lazy to create a generic mechanism
977 1032
978 attachable::destroy (); 1033 attachable::destroy ();
979}
980
981/*
982 * sub_weight() recursively (outwards) subtracts a number from the
983 * weight of an object (and what is carried by it's environment(s)).
984 */
985void
986sub_weight (object *op, signed long weight)
987{
988 while (op != NULL)
989 {
990 if (op->type == CONTAINER)
991 weight = (signed long) (weight * (100 - op->stats.Str) / 100);
992
993 op->carrying -= weight;
994 op = op->env;
995 }
996} 1034}
997 1035
998/* op->remove (): 1036/* op->remove ():
999 * This function removes the object op from the linked list of objects 1037 * This function removes the object op from the linked list of objects
1000 * which it is currently tied to. When this function is done, the 1038 * which it is currently tied to. When this function is done, the
1003 * the previous environment. 1041 * the previous environment.
1004 */ 1042 */
1005void 1043void
1006object::do_remove () 1044object::do_remove ()
1007{ 1045{
1008 object *tmp, *last = 0; 1046 if (flag [FLAG_REMOVED])
1009 object *otmp;
1010
1011 if (QUERY_FLAG (this, FLAG_REMOVED))
1012 return; 1047 return;
1013 1048
1014 SET_FLAG (this, FLAG_REMOVED);
1015 INVOKE_OBJECT (REMOVE, this); 1049 INVOKE_OBJECT (REMOVE, this);
1050
1051 flag [FLAG_REMOVED] = true;
1016 1052
1017 if (more) 1053 if (more)
1018 more->remove (); 1054 more->remove ();
1019 1055
1020 /* 1056 /*
1021 * In this case, the object to be removed is in someones 1057 * In this case, the object to be removed is in someones
1022 * inventory. 1058 * inventory.
1023 */ 1059 */
1024 if (env) 1060 if (env)
1025 { 1061 {
1026 if (nrof) 1062 flag [FLAG_REMOVED] = false; // hack around the issue of visible_to checking flag_removed
1027 sub_weight (env, weight * nrof); 1063 if (object *pl = visible_to ())
1028 else 1064 esrv_del_item (pl->contr, count);
1029 sub_weight (env, weight + carrying); 1065 flag [FLAG_REMOVED] = true; // hack around the issue of visible_to checking flag_removed
1066
1067 adjust_weight (env, -total_weight ());
1068
1069 object *pl = in_player ();
1070
1071 /* we set up values so that it could be inserted into
1072 * the map, but we don't actually do that - it is up
1073 * to the caller to decide what we want to do.
1074 */
1075 map = env->map;
1076 x = env->x;
1077 y = env->y;
1078
1079 // make sure cmov optimisation is applicable
1080 *(above ? &above->below : &env->inv) = below;
1081 *(below ? &below->above : &above ) = above; // &above is just a dummy
1082
1083 above = 0;
1084 below = 0;
1085 env = 0;
1030 1086
1031 /* NO_FIX_PLAYER is set when a great many changes are being 1087 /* NO_FIX_PLAYER is set when a great many changes are being
1032 * made to players inventory. If set, avoiding the call 1088 * made to players inventory. If set, avoiding the call
1033 * to save cpu time. 1089 * to save cpu time.
1034 */ 1090 */
1035 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1091 if (pl)
1092 if (pl->is_player () && (glow_radius || !QUERY_FLAG (pl, FLAG_NO_FIX_PLAYER)))
1093 {
1036 otmp->update_stats (); 1094 pl->update_stats ();
1037 1095
1038 if (above) 1096 if (glow_radius && pl->is_on_map ())
1039 above->below = below; 1097 update_all_los (pl->map, pl->x, pl->y);
1040 else 1098 }
1041 env->inv = below;
1042
1043 if (below)
1044 below->above = above;
1045
1046 /* we set up values so that it could be inserted into
1047 * the map, but we don't actually do that - it is up
1048 * to the caller to decide what we want to do.
1049 */
1050 x = env->x, y = env->y;
1051 map = env->map;
1052 above = 0, below = 0;
1053 env = 0;
1054 } 1099 }
1055 else if (map) 1100 else if (map)
1056 { 1101 {
1057 if (type == PLAYER)
1058 {
1059 // leaving a spot always closes any open container on the ground
1060 if (container && !container->env)
1061 // this causes spurious floorbox updates, but it ensures
1062 // that the CLOSE event is being sent.
1063 close_container ();
1064
1065 --map->players;
1066 map->touch ();
1067 }
1068
1069 map->dirty = true; 1102 map->dirty = true;
1070 mapspace &ms = this->ms (); 1103 mapspace &ms = this->ms ();
1071 1104
1105 if (object *pl = ms.player ())
1106 {
1107 if (is_player ())
1108 {
1109 if (!flag [FLAG_WIZPASS])
1110 ms.smell = ++mapspace::smellcount; // remember the smell of the player
1111
1112 // leaving a spot always closes any open container on the ground
1113 if (container && !container->env)
1114 // this causes spurious floorbox updates, but it ensures
1115 // that the CLOSE event is being sent.
1116 close_container ();
1117
1118 --map->players;
1119 map->touch ();
1120 }
1121 else if (pl->container_ () == this)
1122 {
1123 // removing a container should close it
1124 close_container ();
1125 }
1126
1127 esrv_del_item (pl->contr, count);
1128 }
1129
1072 /* link the object above us */ 1130 /* link the object above us */
1073 if (above) 1131 // re-link, make sure compiler can easily use cmove
1074 above->below = below; 1132 *(above ? &above->below : &ms.top) = below;
1075 else 1133 *(below ? &below->above : &ms.bot) = above;
1076 ms.top = below; /* we were top, set new top */
1077
1078 /* Relink the object below us, if there is one */
1079 if (below)
1080 below->above = above;
1081 else
1082 {
1083 /* Nothing below, which means we need to relink map object for this space
1084 * use translated coordinates in case some oddness with map tiling is
1085 * evident
1086 */
1087 if (GET_MAP_OB (map, x, y) != this)
1088 LOG (llevError, "remove_ob: GET_MAP_OB does not return object to be removed even though it appears to be on the bottom? %s\n", debug_desc ());
1089
1090 ms.bot = above; /* goes on above it. */
1091 }
1092 1134
1093 above = 0; 1135 above = 0;
1094 below = 0; 1136 below = 0;
1095 1137
1138 ms.invalidate ();
1139
1096 if (map->in_memory == MAP_SAVING) 1140 if (map->in_memory == MAP_SAVING)
1097 return; 1141 return;
1098 1142
1099 int check_walk_off = !flag [FLAG_NO_APPLY]; 1143 int check_walk_off = !flag [FLAG_NO_APPLY];
1100 1144
1101 if (object *pl = ms.player ()) 1145 if (object *pl = ms.player ())
1102 { 1146 {
1103 if (pl->container == this) 1147 if (pl->container_ () == this)
1104 /* If a container that the player is currently using somehow gets 1148 /* If a container that the player is currently using somehow gets
1105 * removed (most likely destroyed), update the player view 1149 * removed (most likely destroyed), update the player view
1106 * appropriately. 1150 * appropriately.
1107 */ 1151 */
1108 pl->close_container (); 1152 pl->close_container ();
1109 1153
1154 //TODO: the floorbox prev/next might need updating
1155 //esrv_del_item (pl->contr, count);
1156 //TODO: update floorbox to preserve ordering
1157 if (pl->contr->ns)
1110 pl->contr->ns->floorbox_update (); 1158 pl->contr->ns->floorbox_update ();
1111 } 1159 }
1112 1160
1161 if (check_walk_off)
1113 for (tmp = ms.bot; tmp; tmp = tmp->above) 1162 for (object *above, *tmp = ms.bot; tmp; tmp = above)
1114 { 1163 {
1164 above = tmp->above;
1165
1115 /* No point updating the players look faces if he is the object 1166 /* No point updating the players look faces if he is the object
1116 * being removed. 1167 * being removed.
1117 */ 1168 */
1118 1169
1119 /* See if object moving off should effect something */ 1170 /* See if object moving off should effect something */
1120 if (check_walk_off
1121 && ((move_type & tmp->move_off) 1171 if ((move_type & tmp->move_off)
1122 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1172 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)
1123 {
1124 move_apply (tmp, this, 0); 1173 move_apply (tmp, this, 0);
1125
1126 if (destroyed ())
1127 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1128 } 1174 }
1129 1175
1130 last = tmp; 1176 if (affects_los ())
1131 }
1132
1133 /* last == NULL if there are no objects on this space */
1134 //TODO: this makes little sense, why only update the topmost object?
1135 if (!last)
1136 map->at (x, y).flags_ = 0;
1137 else
1138 update_object (last, UP_OBJ_REMOVE);
1139
1140 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1141 update_all_los (map, x, y); 1177 update_all_los (map, x, y);
1142 } 1178 }
1143} 1179}
1144 1180
1145/* 1181/*
1159 if (!top) 1195 if (!top)
1160 for (top = op; top && top->above; top = top->above) 1196 for (top = op; top && top->above; top = top->above)
1161 ; 1197 ;
1162 1198
1163 for (; top; top = top->below) 1199 for (; top; top = top->below)
1164 {
1165 if (top == op)
1166 continue;
1167
1168 if (object::can_merge (op, top)) 1200 if (object::can_merge (op, top))
1169 { 1201 {
1170 top->nrof += op->nrof; 1202 top->nrof += op->nrof;
1171 1203
1172/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/ 1204 if (object *pl = top->visible_to ())
1173 op->weight = 0; /* Don't want any adjustements now */ 1205 esrv_update_item (UPD_NROF, pl, top);
1206
1207 op->weight = 0; // cancel the addition above
1208 op->carrying = 0; // must be 0 already
1209
1174 op->destroy (); 1210 op->destroy ();
1211
1175 return top; 1212 return top;
1176 } 1213 }
1177 }
1178 1214
1179 return 0; 1215 return 0;
1180} 1216}
1181 1217
1182void 1218void
1207 * job preparing multi-part monsters. 1243 * job preparing multi-part monsters.
1208 */ 1244 */
1209object * 1245object *
1210insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1246insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1211{ 1247{
1248 op->remove ();
1249
1212 for (object *tmp = op->head_ (); tmp; tmp = tmp->more) 1250 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1213 { 1251 {
1214 tmp->x = x + tmp->arch->x; 1252 tmp->x = x + tmp->arch->x;
1215 tmp->y = y + tmp->arch->y; 1253 tmp->y = y + tmp->arch->y;
1216 } 1254 }
1239 * just 'op' otherwise 1277 * just 'op' otherwise
1240 */ 1278 */
1241object * 1279object *
1242insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1280insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1243{ 1281{
1244 assert (!op->flag [FLAG_FREED]);
1245
1246 object *top, *floor = NULL;
1247
1248 op->remove (); 1282 op->remove ();
1283
1284 if (m == &freed_map)//D TODO: remove soon
1285 {//D
1286 LOG (llevError | logBacktrace, "tries to insret object on freed objects map: %s", op->debug_desc ());//D
1287 }//D
1249 1288
1250 /* Ideally, the caller figures this out. However, it complicates a lot 1289 /* Ideally, the caller figures this out. However, it complicates a lot
1251 * of areas of callers (eg, anything that uses find_free_spot would now 1290 * of areas of callers (eg, anything that uses find_free_spot would now
1252 * need extra work 1291 * need extra work
1253 */ 1292 */
1293 maptile *newmap = m;
1254 if (!xy_normalise (m, op->x, op->y)) 1294 if (!xy_normalise (newmap, op->x, op->y))
1255 { 1295 {
1256 op->destroy (); 1296 op->head_ ()->destroy ();// remove head_ once all tail object destroyers found
1257 return 0; 1297 return 0;
1258 } 1298 }
1259 1299
1260 if (object *more = op->more) 1300 if (object *more = op->more)
1261 if (!insert_ob_in_map (more, m, originator, flag)) 1301 if (!insert_ob_in_map (more, m, originator, flag))
1262 return 0; 1302 return 0;
1263 1303
1264 CLEAR_FLAG (op, FLAG_REMOVED); 1304 op->flag [FLAG_REMOVED] = false;
1265 1305 op->env = 0;
1266 op->map = m; 1306 op->map = newmap;
1307
1267 mapspace &ms = op->ms (); 1308 mapspace &ms = op->ms ();
1268 1309
1269 /* this has to be done after we translate the coordinates. 1310 /* this has to be done after we translate the coordinates.
1270 */ 1311 */
1271 if (op->nrof && !(flag & INS_NO_MERGE)) 1312 if (op->nrof && !(flag & INS_NO_MERGE))
1272 for (object *tmp = ms.bot; tmp; tmp = tmp->above) 1313 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1273 if (object::can_merge (op, tmp)) 1314 if (object::can_merge (op, tmp))
1274 { 1315 {
1316 // TODO: we actually want to update tmp, not op,
1317 // but some caller surely breaks when we return tmp
1318 // from here :/
1275 op->nrof += tmp->nrof; 1319 op->nrof += tmp->nrof;
1276 tmp->destroy (); 1320 tmp->destroy ();
1277 } 1321 }
1278 1322
1279 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */ 1323 CLEAR_FLAG (op, FLAG_APPLIED); /* hack for fixing F_APPLIED in items of dead people */
1288 { 1332 {
1289 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n"); 1333 LOG (llevError, "insert_ob_in_map called with INS_BELOW_ORIGINATOR when originator not on same space!\n");
1290 abort (); 1334 abort ();
1291 } 1335 }
1292 1336
1337 if (!originator->is_on_map ())
1338 {
1339 LOG (llevError, "insert_ob_in_map(%s) called with INS_BELOW_ORIGINATOR when originator '%s' not on map",
1340 op->debug_desc (), originator->debug_desc ());
1341 abort ();
1342 }
1343
1293 op->above = originator; 1344 op->above = originator;
1294 op->below = originator->below; 1345 op->below = originator->below;
1295
1296 if (op->below)
1297 op->below->above = op;
1298 else
1299 ms.bot = op;
1300
1301 /* since *below* originator, no need to update top */
1302 originator->below = op; 1346 originator->below = op;
1347
1348 *(op->below ? &op->below->above : &ms.bot) = op;
1303 } 1349 }
1304 else 1350 else
1305 { 1351 {
1306 top = ms.bot; 1352 object *floor = 0;
1353 object *top = ms.top;
1307 1354
1308 /* If there are other objects, then */ 1355 /* If there are other objects, then */
1309 if (top) 1356 if (top)
1310 { 1357 {
1311 object *last = 0;
1312
1313 /* 1358 /*
1314 * If there are multiple objects on this space, we do some trickier handling. 1359 * If there are multiple objects on this space, we do some trickier handling.
1315 * We've already dealt with merging if appropriate. 1360 * We've already dealt with merging if appropriate.
1316 * Generally, we want to put the new object on top. But if 1361 * Generally, we want to put the new object on top. But if
1317 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last 1362 * flag contains INS_ABOVE_FLOOR_ONLY, once we find the last
1320 * once we get to them. This reduces the need to traverse over all of 1365 * once we get to them. This reduces the need to traverse over all of
1321 * them when adding another one - this saves quite a bit of cpu time 1366 * them when adding another one - this saves quite a bit of cpu time
1322 * when lots of spells are cast in one area. Currently, it is presumed 1367 * when lots of spells are cast in one area. Currently, it is presumed
1323 * that flying non pickable objects are spell objects. 1368 * that flying non pickable objects are spell objects.
1324 */ 1369 */
1325 for (top = ms.bot; top; top = top->above) 1370 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
1326 { 1371 {
1327 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1372 if (QUERY_FLAG (tmp, FLAG_IS_FLOOR) || QUERY_FLAG (tmp, FLAG_OVERLAY_FLOOR))
1328 floor = top; 1373 floor = tmp;
1329 1374
1330 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1375 if (QUERY_FLAG (tmp, FLAG_NO_PICK) && (tmp->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (tmp, FLAG_IS_FLOOR))
1331 { 1376 {
1332 /* We insert above top, so we want this object below this */ 1377 /* We insert above top, so we want this object below this */
1333 top = top->below; 1378 top = tmp->below;
1334 break; 1379 break;
1335 } 1380 }
1336 1381
1337 last = top; 1382 top = tmp;
1338 } 1383 }
1339
1340 /* Don't want top to be NULL, so set it to the last valid object */
1341 top = last;
1342 1384
1343 /* We let update_position deal with figuring out what the space 1385 /* We let update_position deal with figuring out what the space
1344 * looks like instead of lots of conditions here. 1386 * looks like instead of lots of conditions here.
1345 * makes things faster, and effectively the same result. 1387 * makes things faster, and effectively the same result.
1346 */ 1388 */
1353 */ 1395 */
1354 if (!(flag & INS_ON_TOP) 1396 if (!(flag & INS_ON_TOP)
1355 && ms.flags () & P_BLOCKSVIEW 1397 && ms.flags () & P_BLOCKSVIEW
1356 && (op->face && !faces [op->face].visibility)) 1398 && (op->face && !faces [op->face].visibility))
1357 { 1399 {
1400 object *last;
1401
1358 for (last = top; last != floor; last = last->below) 1402 for (last = top; last != floor; last = last->below)
1359 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1403 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1360 break; 1404 break;
1361 1405
1362 /* Check to see if we found the object that blocks view, 1406 /* Check to see if we found the object that blocks view,
1370 } /* If objects on this space */ 1414 } /* If objects on this space */
1371 1415
1372 if (flag & INS_ABOVE_FLOOR_ONLY) 1416 if (flag & INS_ABOVE_FLOOR_ONLY)
1373 top = floor; 1417 top = floor;
1374 1418
1375 /* Top is the object that our object (op) is going to get inserted above. 1419 // insert object above top, or bottom-most if top = 0
1376 */
1377
1378 /* First object on this space */
1379 if (!top) 1420 if (!top)
1380 { 1421 {
1422 op->below = 0;
1381 op->above = ms.bot; 1423 op->above = ms.bot;
1382
1383 if (op->above)
1384 op->above->below = op;
1385
1386 op->below = 0;
1387 ms.bot = op; 1424 ms.bot = op;
1425
1426 *(op->above ? &op->above->below : &ms.top) = op;
1388 } 1427 }
1389 else 1428 else
1390 { /* get inserted into the stack above top */ 1429 {
1391 op->above = top->above; 1430 op->above = top->above;
1392
1393 if (op->above)
1394 op->above->below = op; 1431 top->above = op;
1395 1432
1396 op->below = top; 1433 op->below = top;
1397 top->above = op; 1434 *(op->above ? &op->above->below : &ms.top) = op;
1398 } 1435 }
1436 }
1399 1437
1400 if (!op->above) 1438 if (op->is_player ())
1401 ms.top = op;
1402 } /* else not INS_BELOW_ORIGINATOR */
1403
1404 if (op->type == PLAYER)
1405 { 1439 {
1406 op->contr->do_los = 1; 1440 op->contr->do_los = 1;
1407 ++op->map->players; 1441 ++op->map->players;
1408 op->map->touch (); 1442 op->map->touch ();
1409 } 1443 }
1410 1444
1411 op->map->dirty = true; 1445 op->map->dirty = true;
1412 1446
1413 if (object *pl = ms.player ()) 1447 if (object *pl = ms.player ())
1448 //TODO: the floorbox prev/next might need updating
1449 //esrv_send_item (pl, op);
1450 //TODO: update floorbox to preserve ordering
1451 if (pl->contr->ns)
1414 pl->contr->ns->floorbox_update (); 1452 pl->contr->ns->floorbox_update ();
1415 1453
1416 /* If this object glows, it may affect lighting conditions that are 1454 /* If this object glows, it may affect lighting conditions that are
1417 * visible to others on this map. But update_all_los is really 1455 * visible to others on this map. But update_all_los is really
1418 * an inefficient way to do this, as it means los for all players 1456 * an inefficient way to do this, as it means los for all players
1419 * on the map will get recalculated. The players could very well 1457 * on the map will get recalculated. The players could very well
1420 * be far away from this change and not affected in any way - 1458 * be far away from this change and not affected in any way -
1421 * this should get redone to only look for players within range, 1459 * this should get redone to only look for players within range,
1422 * or just updating the P_UPTODATE for spaces within this area 1460 * or just updating the P_UPTODATE for spaces within this area
1423 * of effect may be sufficient. 1461 * of effect may be sufficient.
1424 */ 1462 */
1425 if (op->map->darkness && (op->glow_radius != 0)) 1463 if (op->affects_los ())
1464 {
1465 op->ms ().invalidate ();
1426 update_all_los (op->map, op->x, op->y); 1466 update_all_los (op->map, op->x, op->y);
1467 }
1427 1468
1428 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1469 /* updates flags (blocked, alive, no magic, etc) for this map space */
1429 update_object (op, UP_OBJ_INSERT); 1470 update_object (op, UP_OBJ_INSERT);
1430 1471
1431 INVOKE_OBJECT (INSERT, op); 1472 INVOKE_OBJECT (INSERT, op);
1438 * blocked() and wall() work properly), and these flags are updated by 1479 * blocked() and wall() work properly), and these flags are updated by
1439 * update_object(). 1480 * update_object().
1440 */ 1481 */
1441 1482
1442 /* if this is not the head or flag has been passed, don't check walk on status */ 1483 /* if this is not the head or flag has been passed, don't check walk on status */
1443 if (!(flag & INS_NO_WALK_ON) && op->head_ () == op) 1484 if (!(flag & INS_NO_WALK_ON) && op->is_head ())
1444 { 1485 {
1445 if (check_move_on (op, originator)) 1486 if (check_move_on (op, originator))
1446 return 0; 1487 return 0;
1447 1488
1448 /* If we are a multi part object, lets work our way through the check 1489 /* If we are a multi part object, lets work our way through the check
1459/* this function inserts an object in the map, but if it 1500/* this function inserts an object in the map, but if it
1460 * finds an object of its own type, it'll remove that one first. 1501 * finds an object of its own type, it'll remove that one first.
1461 * op is the object to insert it under: supplies x and the map. 1502 * op is the object to insert it under: supplies x and the map.
1462 */ 1503 */
1463void 1504void
1464replace_insert_ob_in_map (const char *arch_string, object *op) 1505replace_insert_ob_in_map (shstr_tmp archname, object *op)
1465{ 1506{
1466 object *tmp, *tmp1;
1467
1468 /* first search for itself and remove any old instances */ 1507 /* first search for itself and remove any old instances */
1469 1508
1470 for (tmp = op->ms ().bot; tmp; tmp = tmp->above) 1509 for (object *tmp = op->ms ().bot; tmp; tmp = tmp->above)
1471 if (!strcmp (tmp->arch->archname, arch_string)) /* same archetype */ 1510 if (tmp->arch->archname == archname) /* same archetype */
1472 tmp->destroy (); 1511 tmp->destroy ();
1473 1512
1474 tmp1 = arch_to_object (archetype::find (arch_string)); 1513 object *tmp = arch_to_object (archetype::find (archname));
1475 1514
1476 tmp1->x = op->x; 1515 tmp->x = op->x;
1477 tmp1->y = op->y; 1516 tmp->y = op->y;
1517
1478 insert_ob_in_map (tmp1, op->map, op, 0); 1518 insert_ob_in_map (tmp, op->map, op, 0);
1479} 1519}
1480 1520
1481object * 1521object *
1482object::insert_at (object *where, object *originator, int flags) 1522object::insert_at (object *where, object *originator, int flags)
1483{ 1523{
1486 else 1526 else
1487 return where->map->insert (this, where->x, where->y, originator, flags); 1527 return where->map->insert (this, where->x, where->y, originator, flags);
1488} 1528}
1489 1529
1490/* 1530/*
1491 * get_split_ob(ob,nr) splits up ob into two parts. The part which
1492 * is returned contains nr objects, and the remaining parts contains
1493 * the rest (or is removed and freed if that number is 0).
1494 * On failure, NULL is returned, and the reason put into the
1495 * global static errmsg array.
1496 */
1497object *
1498get_split_ob (object *orig_ob, uint32 nr)
1499{
1500 object *newob;
1501 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1502
1503 if (orig_ob->nrof < nr)
1504 {
1505 sprintf (errmsg, "There are only %d %ss.", orig_ob->nrof ? orig_ob->nrof : 1, &orig_ob->name);
1506 return NULL;
1507 }
1508
1509 newob = object_create_clone (orig_ob);
1510
1511 if ((orig_ob->nrof -= nr) < 1)
1512 orig_ob->destroy (1);
1513 else if (!is_removed)
1514 {
1515 if (orig_ob->env != NULL)
1516 sub_weight (orig_ob->env, orig_ob->weight * nr);
1517 if (orig_ob->env == NULL && orig_ob->map->in_memory != MAP_ACTIVE)
1518 {
1519 strcpy (errmsg, "Tried to split object whose map is not in memory.");
1520 LOG (llevDebug, "Error, Tried to split object whose map is not in memory.\n");
1521 return NULL;
1522 }
1523 }
1524
1525 newob->nrof = nr;
1526
1527 return newob;
1528}
1529
1530/*
1531 * decrease_ob_nr(object, number) decreases a specified number from 1531 * decrease(object, number) decreases a specified number from
1532 * the amount of an object. If the amount reaches 0, the object 1532 * the amount of an object. If the amount reaches 0, the object
1533 * is subsequently removed and freed. 1533 * is subsequently removed and freed.
1534 * 1534 *
1535 * Return value: 'op' if something is left, NULL if the amount reached 0 1535 * Return value: 'op' if something is left, NULL if the amount reached 0
1536 */ 1536 */
1537bool
1538object::decrease (sint32 nr)
1539{
1540 if (!nr)
1541 return true;
1542
1543 nr = min (nr, nrof);
1544
1545 if (nrof > nr)
1546 {
1547 nrof -= nr;
1548 adjust_weight (env, -weight * max (1, nr)); // carrying == 0
1549
1550 if (object *pl = visible_to ())
1551 esrv_update_item (UPD_NROF, pl, this);
1552
1553 return true;
1554 }
1555 else
1556 {
1557 destroy ();
1558 return false;
1559 }
1560}
1561
1562/*
1563 * split(ob,nr) splits up ob into two parts. The part which
1564 * is returned contains nr objects, and the remaining parts contains
1565 * the rest (or is removed and returned if that number is 0).
1566 * On failure, NULL is returned.
1567 */
1537object * 1568object *
1538decrease_ob_nr (object *op, uint32 i) 1569object::split (sint32 nr)
1539{ 1570{
1540 object *tmp; 1571 int have = number_of ();
1541 1572
1542 if (i == 0) /* objects with op->nrof require this check */ 1573 if (have < nr)
1543 return op; 1574 return 0;
1544 1575 else if (have == nr)
1545 if (i > op->nrof)
1546 i = op->nrof;
1547
1548 if (QUERY_FLAG (op, FLAG_REMOVED))
1549 op->nrof -= i;
1550 else if (op->env)
1551 { 1576 {
1552 /* is this object in the players inventory, or sub container
1553 * therein?
1554 */
1555 tmp = op->in_player ();
1556 /* nope. Is this a container the player has opened?
1557 * If so, set tmp to that player.
1558 * IMO, searching through all the players will mostly
1559 * likely be quicker than following op->env to the map,
1560 * and then searching the map for a player.
1561 */
1562 if (!tmp)
1563 for_all_players (pl)
1564 if (pl->ob->container == op->env)
1565 {
1566 tmp = pl->ob;
1567 break;
1568 }
1569
1570 if (i < op->nrof)
1571 {
1572 sub_weight (op->env, op->weight * i);
1573 op->nrof -= i;
1574 if (tmp)
1575 esrv_send_item (tmp, op);
1576 }
1577 else
1578 {
1579 op->remove (); 1577 remove ();
1580 op->nrof = 0; 1578 return this;
1581 if (tmp)
1582 esrv_del_item (tmp->contr, op->count);
1583 }
1584 } 1579 }
1585 else 1580 else
1586 { 1581 {
1587 object *above = op->above; 1582 decrease (nr);
1588 1583
1589 if (i < op->nrof) 1584 object *op = deep_clone ();
1590 op->nrof -= i; 1585 op->nrof = nr;
1591 else
1592 {
1593 op->remove ();
1594 op->nrof = 0;
1595 }
1596
1597 /* Since we just removed op, op->above is null */
1598 for (tmp = above; tmp; tmp = tmp->above)
1599 if (tmp->type == PLAYER)
1600 {
1601 if (op->nrof)
1602 esrv_send_item (tmp, op);
1603 else
1604 esrv_del_item (tmp->contr, op->count);
1605 }
1606 }
1607
1608 if (op->nrof)
1609 return op; 1586 return op;
1610 else
1611 {
1612 op->destroy ();
1613 return 0;
1614 }
1615}
1616
1617/*
1618 * add_weight(object, weight) adds the specified weight to an object,
1619 * and also updates how much the environment(s) is/are carrying.
1620 */
1621void
1622add_weight (object *op, signed long weight)
1623{
1624 while (op != NULL)
1625 {
1626 if (op->type == CONTAINER)
1627 weight = (signed long) (weight * (100 - op->stats.Str) / 100);
1628
1629 op->carrying += weight;
1630 op = op->env;
1631 } 1587 }
1632} 1588}
1633 1589
1634object * 1590object *
1635insert_ob_in_ob (object *op, object *where) 1591insert_ob_in_ob (object *op, object *where)
1660 * be != op, if items are merged. -Tero 1616 * be != op, if items are merged. -Tero
1661 */ 1617 */
1662object * 1618object *
1663object::insert (object *op) 1619object::insert (object *op)
1664{ 1620{
1665 if (!QUERY_FLAG (op, FLAG_REMOVED))
1666 op->remove ();
1667
1668 if (op->more) 1621 if (op->more)
1669 { 1622 {
1670 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count); 1623 LOG (llevError, "Tried to insert multipart object %s (%d)\n", &op->name, op->count);
1671 return op; 1624 return op;
1672 } 1625 }
1673 1626
1674 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL); 1627 op->remove ();
1675 CLEAR_FLAG (op, FLAG_REMOVED); 1628
1629 op->flag [FLAG_OBJ_ORIGINAL] = 0;
1676 1630
1677 if (op->nrof) 1631 if (op->nrof)
1678 {
1679 for (object *tmp = inv; tmp; tmp = tmp->below) 1632 for (object *tmp = inv; tmp; tmp = tmp->below)
1680 if (object::can_merge (tmp, op)) 1633 if (object::can_merge (tmp, op))
1681 { 1634 {
1682 /* return the original object and remove inserted object 1635 /* return the original object and remove inserted object
1683 (client needs the original object) */ 1636 (client needs the original object) */
1684 tmp->nrof += op->nrof; 1637 tmp->nrof += op->nrof;
1685 /* Weight handling gets pretty funky. Since we are adding to 1638
1686 * tmp->nrof, we need to increase the weight. 1639 if (object *pl = tmp->visible_to ())
1687 */ 1640 esrv_update_item (UPD_NROF, pl, tmp);
1641
1688 add_weight (this, op->weight * op->nrof); 1642 adjust_weight (this, op->total_weight ());
1689 SET_FLAG (op, FLAG_REMOVED); 1643
1690 op->destroy (); /* free the inserted object */ 1644 op->destroy ();
1691 op = tmp; 1645 op = tmp;
1692 op->remove (); /* and fix old object's links */ 1646 goto inserted;
1693 CLEAR_FLAG (op, FLAG_REMOVED);
1694 break;
1695 } 1647 }
1696 1648
1697 /* I assume combined objects have no inventory
1698 * We add the weight - this object could have just been removed
1699 * (if it was possible to merge). calling remove_ob will subtract
1700 * the weight, so we need to add it in again, since we actually do
1701 * the linking below
1702 */
1703 add_weight (this, op->weight * op->nrof);
1704 }
1705 else
1706 add_weight (this, (op->weight + op->carrying));
1707
1708 if (object *otmp = this->in_player ())
1709 if (otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1710 otmp->update_stats ();
1711
1712 op->owner = 0; // its his/hers now. period. 1649 op->owner = 0; // it's his/hers now. period.
1713 op->map = 0; 1650 op->map = 0;
1651 op->x = 0;
1652 op->y = 0;
1653
1654 op->above = 0;
1655 op->below = inv;
1714 op->env = this; 1656 op->env = this;
1715 op->above = 0;
1716 op->below = 0;
1717 op->x = op->y = 0;
1718 1657
1658 if (inv)
1659 inv->above = op;
1660
1661 inv = op;
1662
1663 op->flag [FLAG_REMOVED] = 0;
1664
1665 if (object *pl = op->visible_to ())
1666 esrv_send_item (pl, op);
1667
1668 adjust_weight (this, op->total_weight ());
1669
1670inserted:
1719 /* reset the light list and los of the players on the map */ 1671 /* reset the light list and los of the players on the map */
1720 if (op->glow_radius && map) 1672 if (op->glow_radius && is_on_map ())
1721 { 1673 {
1722#ifdef DEBUG_LIGHTS 1674 update_stats ();
1723 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1724#endif /* DEBUG_LIGHTS */
1725 if (map->darkness)
1726 update_all_los (map, x, y); 1675 update_all_los (map, x, y);
1727 }
1728
1729 /* Client has no idea of ordering so lets not bother ordering it here.
1730 * It sure simplifies this function...
1731 */
1732 if (!inv)
1733 inv = op;
1734 else
1735 { 1676 }
1736 op->below = inv; 1677 else if (is_player () && !flag [FLAG_NO_FIX_PLAYER])
1737 op->below->above = op; 1678 // if this is a player's inventory, update stats
1738 inv = op; 1679 update_stats ();
1739 }
1740 1680
1741 INVOKE_OBJECT (INSERT, this); 1681 INVOKE_OBJECT (INSERT, this);
1742 1682
1743 return op; 1683 return op;
1744} 1684}
1764 * on top. 1704 * on top.
1765 */ 1705 */
1766int 1706int
1767check_move_on (object *op, object *originator) 1707check_move_on (object *op, object *originator)
1768{ 1708{
1709 if (QUERY_FLAG (op, FLAG_NO_APPLY))
1710 return 0;
1711
1769 object *tmp; 1712 object *tmp;
1770 maptile *m = op->map; 1713 maptile *m = op->map;
1771 int x = op->x, y = op->y; 1714 int x = op->x, y = op->y;
1772 1715
1773 MoveType move_on, move_slow, move_block; 1716 mapspace &ms = m->at (x, y);
1774 1717
1775 if (QUERY_FLAG (op, FLAG_NO_APPLY)) 1718 ms.update ();
1776 return 0;
1777 1719
1778 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y); 1720 MoveType move_on = ms.move_on;
1779 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y); 1721 MoveType move_slow = ms.move_slow;
1780 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y); 1722 MoveType move_block = ms.move_block;
1781 1723
1782 /* if nothing on this space will slow op down or be applied, 1724 /* if nothing on this space will slow op down or be applied,
1783 * no need to do checking below. have to make sure move_type 1725 * no need to do checking below. have to make sure move_type
1784 * is set, as lots of objects don't have it set - we treat that 1726 * is set, as lots of objects don't have it set - we treat that
1785 * as walking. 1727 * as walking.
1796 return 0; 1738 return 0;
1797 1739
1798 /* The objects have to be checked from top to bottom. 1740 /* The objects have to be checked from top to bottom.
1799 * Hence, we first go to the top: 1741 * Hence, we first go to the top:
1800 */ 1742 */
1801 1743 for (object *next, *tmp = ms.top; tmp; tmp = next)
1802 for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1803 {
1804 /* Trim the search when we find the first other spell effect
1805 * this helps performance so that if a space has 50 spell objects,
1806 * we don't need to check all of them.
1807 */
1808 if ((tmp->move_type & MOVE_FLY_LOW) && QUERY_FLAG (tmp, FLAG_NO_PICK))
1809 break;
1810 } 1744 {
1745 next = tmp->below;
1811 1746
1812 for (; tmp; tmp = tmp->below)
1813 {
1814 if (tmp == op) 1747 if (tmp == op)
1815 continue; /* Can't apply yourself */ 1748 continue; /* Can't apply yourself */
1816 1749
1817 /* Check to see if one of the movement types should be slowed down. 1750 /* Check to see if one of the movement types should be slowed down.
1818 * Second check makes sure that the movement types not being slowed 1751 * Second check makes sure that the movement types not being slowed
1823 if (!QUERY_FLAG (op, FLAG_WIZPASS)) 1756 if (!QUERY_FLAG (op, FLAG_WIZPASS))
1824 { 1757 {
1825 if ((!op->move_type && tmp->move_slow & MOVE_WALK) || 1758 if ((!op->move_type && tmp->move_slow & MOVE_WALK) ||
1826 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0)) 1759 ((op->move_type & tmp->move_slow) && (op->move_type & ~tmp->move_slow & ~tmp->move_block) == 0))
1827 { 1760 {
1828
1829 float
1830 diff = tmp->move_slow_penalty * fabs (op->speed); 1761 float diff = tmp->move_slow_penalty * fabs (op->speed);
1831 1762
1832 if (op->type == PLAYER) 1763 if (op->is_player ())
1833 if ((QUERY_FLAG (tmp, FLAG_IS_HILLY) && find_skill_by_number (op, SK_CLIMBING)) || 1764 if ((tmp->flag [FLAG_IS_HILLY ] && find_skill_by_number (op, SK_CLIMBING)) ||
1834 (QUERY_FLAG (tmp, FLAG_IS_WOODED) && find_skill_by_number (op, SK_WOODSMAN))) 1765 (tmp->flag [FLAG_IS_WOODED] && find_skill_by_number (op, SK_WOODSMAN)))
1835 diff /= 4.0; 1766 diff /= 4.0;
1836 1767
1837 op->speed_left -= diff; 1768 op->speed_left -= diff;
1838 } 1769 }
1839 } 1770 }
1872 LOG (llevError, "Present_arch called outside map.\n"); 1803 LOG (llevError, "Present_arch called outside map.\n");
1873 return NULL; 1804 return NULL;
1874 } 1805 }
1875 1806
1876 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above) 1807 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1877 if (tmp->arch == at) 1808 if (tmp->arch->archname == at->archname)
1878 return tmp; 1809 return tmp;
1879 1810
1880 return NULL; 1811 return NULL;
1881} 1812}
1882 1813
1946 * The first matching object is returned, or NULL if none. 1877 * The first matching object is returned, or NULL if none.
1947 */ 1878 */
1948object * 1879object *
1949present_arch_in_ob (const archetype *at, const object *op) 1880present_arch_in_ob (const archetype *at, const object *op)
1950{ 1881{
1951 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below) 1882 for (object *tmp = op->inv; tmp; tmp = tmp->below)
1952 if (tmp->arch == at) 1883 if (tmp->arch->archname == at->archname)
1953 return tmp; 1884 return tmp;
1954 1885
1955 return NULL; 1886 return NULL;
1956} 1887}
1957 1888
2045 * head of the object should correspond for the entire object. 1976 * head of the object should correspond for the entire object.
2046 */ 1977 */
2047 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block)) 1978 if (OB_TYPE_MOVE_BLOCK (ob, ms.move_block))
2048 continue; 1979 continue;
2049 1980
2050 if (ob->blocked (m, pos.x, pos.y)) 1981 if (ob->blocked (pos.m, pos.x, pos.y))
2051 continue; 1982 continue;
2052 1983
2053 altern [index++] = i; 1984 altern [index++] = i;
2054 } 1985 }
2055 1986
2123 * there is capable of. 2054 * there is capable of.
2124 */ 2055 */
2125int 2056int
2126find_dir (maptile *m, int x, int y, object *exclude) 2057find_dir (maptile *m, int x, int y, object *exclude)
2127{ 2058{
2128 int i, max = SIZEOFFREE, mflags; 2059 int max = SIZEOFFREE, mflags;
2129
2130 sint16 nx, ny;
2131 object *tmp;
2132 maptile *mp;
2133
2134 MoveType blocked, move_type; 2060 MoveType move_type;
2135 2061
2136 if (exclude && exclude->head_ () != exclude) 2062 if (exclude && exclude->head_ () != exclude)
2137 { 2063 {
2138 exclude = exclude->head; 2064 exclude = exclude->head;
2139 move_type = exclude->move_type; 2065 move_type = exclude->move_type;
2142 { 2068 {
2143 /* If we don't have anything, presume it can use all movement types. */ 2069 /* If we don't have anything, presume it can use all movement types. */
2144 move_type = MOVE_ALL; 2070 move_type = MOVE_ALL;
2145 } 2071 }
2146 2072
2147 for (i = 1; i < max; i++) 2073 for (int i = 1; i < max; i++)
2148 { 2074 {
2149 mp = m; 2075 mapxy pos (m, x, y);
2150 nx = x + freearr_x[i]; 2076 pos.move (i);
2151 ny = y + freearr_y[i];
2152 2077
2153 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2078 if (!pos.normalise ())
2154
2155 if (mflags & P_OUT_OF_MAP)
2156 max = maxfree[i]; 2079 max = maxfree[i];
2157 else 2080 else
2158 { 2081 {
2159 mapspace &ms = mp->at (nx, ny); 2082 mapspace &ms = *pos;
2160 2083
2161 blocked = ms.move_block;
2162
2163 if ((move_type & blocked) == move_type) 2084 if ((move_type & ms.move_block) == move_type)
2164 max = maxfree[i]; 2085 max = maxfree [i];
2165 else if (mflags & P_IS_ALIVE) 2086 else if (ms.flags () & P_IS_ALIVE)
2166 { 2087 {
2167 for (tmp = ms.bot; tmp; tmp = tmp->above) 2088 for (object *tmp = ms.bot; tmp; tmp = tmp->above)
2168 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER) 2089 if ((tmp->flag [FLAG_MONSTER] || tmp->is_player ())
2169 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude))) 2090 && (tmp != exclude || (tmp->head_ () != tmp && tmp->head_ () != exclude)))
2170 break;
2171
2172 if (tmp)
2173 return freedir[i]; 2091 return freedir [i];
2174 } 2092 }
2175 } 2093 }
2176 } 2094 }
2177 2095
2178 return 0; 2096 return 0;
2253 * This basically means that if direction is 15, then it could either go 2171 * This basically means that if direction is 15, then it could either go
2254 * direction 4, 14, or 16 to get back to where we are. 2172 * direction 4, 14, or 16 to get back to where we are.
2255 * Moved from spell_util.c to object.c with the other related direction 2173 * Moved from spell_util.c to object.c with the other related direction
2256 * functions. 2174 * functions.
2257 */ 2175 */
2258int reduction_dir[SIZEOFFREE][3] = { 2176const int reduction_dir[SIZEOFFREE][3] = {
2259 {0, 0, 0}, /* 0 */ 2177 {0, 0, 0}, /* 0 */
2260 {0, 0, 0}, /* 1 */ 2178 {0, 0, 0}, /* 1 */
2261 {0, 0, 0}, /* 2 */ 2179 {0, 0, 0}, /* 2 */
2262 {0, 0, 0}, /* 3 */ 2180 {0, 0, 0}, /* 3 */
2263 {0, 0, 0}, /* 4 */ 2181 {0, 0, 0}, /* 4 */
2359int 2277int
2360can_pick (const object *who, const object *item) 2278can_pick (const object *who, const object *item)
2361{ 2279{
2362 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2280 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2363 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2281 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2364 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2282 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->is_player () || item->weight < who->weight / 3));
2365} 2283}
2366 2284
2367/* 2285/*
2368 * create clone from object to another 2286 * create clone from object to another
2369 */ 2287 */
2370object * 2288object *
2371object_create_clone (object *asrc) 2289object::deep_clone ()
2372{ 2290{
2373 object *dst = 0, *tmp, *src, *prev, *item; 2291 assert (("deep_clone called on non-head object", is_head ()));
2374 2292
2375 if (!asrc) 2293 object *dst = clone ();
2376 return 0;
2377 2294
2378 src = asrc->head_ (); 2295 object *prev = dst;
2379
2380 prev = 0;
2381 for (object *part = src; part; part = part->more) 2296 for (object *part = this->more; part; part = part->more)
2382 { 2297 {
2383 tmp = part->clone (); 2298 object *tmp = part->clone ();
2384 tmp->x -= src->x;
2385 tmp->y -= src->y;
2386
2387 if (!part->head)
2388 {
2389 dst = tmp;
2390 tmp->head = 0;
2391 }
2392 else
2393 tmp->head = dst; 2299 tmp->head = dst;
2394
2395 tmp->more = 0;
2396
2397 if (prev)
2398 prev->more = tmp; 2300 prev->more = tmp;
2399
2400 prev = tmp; 2301 prev = tmp;
2401 } 2302 }
2402 2303
2403 for (item = src->inv; item; item = item->below) 2304 for (object *item = inv; item; item = item->below)
2404 insert_ob_in_ob (object_create_clone (item), dst); 2305 insert_ob_in_ob (item->deep_clone (), dst);
2405 2306
2406 return dst; 2307 return dst;
2407} 2308}
2408 2309
2409/* This returns the first object in who's inventory that 2310/* This returns the first object in who's inventory that
2418 return tmp; 2319 return tmp;
2419 2320
2420 return 0; 2321 return 0;
2421} 2322}
2422 2323
2423/* If ob has a field named key, return the link from the list, 2324shstr_tmp
2424 * otherwise return NULL. 2325object::kv_get (shstr_tmp key) const
2425 *
2426 * key must be a passed in shared string - otherwise, this won't
2427 * do the desired thing.
2428 */
2429key_value *
2430get_ob_key_link (const object *ob, const char *key)
2431{ 2326{
2432 for (key_value *link = ob->key_values; link; link = link->next) 2327 for (key_value *kv = key_values; kv; kv = kv->next)
2433 if (link->key == key) 2328 if (kv->key == key)
2434 return link;
2435
2436 return 0;
2437}
2438
2439/*
2440 * Returns the value of op has an extra_field for key, or NULL.
2441 *
2442 * The argument doesn't need to be a shared string.
2443 *
2444 * The returned string is shared.
2445 */
2446const char *
2447get_ob_key_value (const object *op, const char *const key)
2448{
2449 key_value *link;
2450 shstr_cmp canonical_key (key);
2451
2452 if (!canonical_key)
2453 {
2454 /* 1. There being a field named key on any object
2455 * implies there'd be a shared string to find.
2456 * 2. Since there isn't, no object has this field.
2457 * 3. Therefore, *this* object doesn't have this field.
2458 */
2459 return 0;
2460 }
2461
2462 /* This is copied from get_ob_key_link() above -
2463 * only 4 lines, and saves the function call overhead.
2464 */
2465 for (link = op->key_values; link; link = link->next)
2466 if (link->key == canonical_key)
2467 return link->value; 2329 return kv->value;
2468 2330
2469 return 0; 2331 return shstr ();
2470} 2332}
2471 2333
2472/* 2334void
2473 * Updates the canonical_key in op to value. 2335object::kv_set (shstr_tmp key, shstr_tmp value)
2474 *
2475 * canonical_key is a shared string (value doesn't have to be).
2476 *
2477 * Unless add_key is TRUE, it won't add fields, only change the value of existing
2478 * keys.
2479 *
2480 * Returns TRUE on success.
2481 */
2482int
2483set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2484{ 2336{
2485 key_value *field = NULL, *last = NULL; 2337 for (key_value *kv = key_values; kv; kv = kv->next)
2486 2338 if (kv->key == key)
2487 for (field = op->key_values; field != NULL; field = field->next)
2488 {
2489 if (field->key != canonical_key)
2490 { 2339 {
2491 last = field; 2340 kv->value = value;
2492 continue; 2341 return;
2493 } 2342 }
2494 2343
2495 if (value) 2344 key_value *kv = new key_value;
2496 field->value = value; 2345
2497 else 2346 kv->next = key_values;
2347 kv->key = key;
2348 kv->value = value;
2349
2350 key_values = kv;
2351}
2352
2353void
2354object::kv_del (shstr_tmp key)
2355{
2356 for (key_value **kvp = &key_values; *kvp; kvp = &(*kvp)->next)
2357 if ((*kvp)->key == key)
2498 { 2358 {
2499 /* Basically, if the archetype has this key set, 2359 key_value *kv = *kvp;
2500 * we need to store the null value so when we save 2360 *kvp = (*kvp)->next;
2501 * it, we save the empty value so that when we load, 2361 delete kv;
2502 * we get this value back again. 2362 return;
2503 */
2504 if (get_ob_key_link (op->arch, canonical_key))
2505 field->value = 0;
2506 else
2507 {
2508 if (last)
2509 last->next = field->next;
2510 else
2511 op->key_values = field->next;
2512
2513 delete field;
2514 }
2515 } 2363 }
2516 return TRUE;
2517 }
2518 /* IF we get here, key doesn't exist */
2519
2520 /* No field, we'll have to add it. */
2521
2522 if (!add_key)
2523 return FALSE;
2524
2525 /* There isn't any good reason to store a null
2526 * value in the key/value list. If the archetype has
2527 * this key, then we should also have it, so shouldn't
2528 * be here. If user wants to store empty strings,
2529 * should pass in ""
2530 */
2531 if (value == NULL)
2532 return TRUE;
2533
2534 field = new key_value;
2535
2536 field->key = canonical_key;
2537 field->value = value;
2538 /* Usual prepend-addition. */
2539 field->next = op->key_values;
2540 op->key_values = field;
2541
2542 return TRUE;
2543}
2544
2545/*
2546 * Updates the key in op to value.
2547 *
2548 * If add_key is FALSE, this will only update existing keys,
2549 * and not add new ones.
2550 * In general, should be little reason FALSE is ever passed in for add_key
2551 *
2552 * Returns TRUE on success.
2553 */
2554int
2555set_ob_key_value (object *op, const char *key, const char *value, int add_key)
2556{
2557 shstr key_ (key);
2558
2559 return set_ob_key_value_s (op, key_, value, add_key);
2560} 2364}
2561 2365
2562object::depth_iterator::depth_iterator (object *container) 2366object::depth_iterator::depth_iterator (object *container)
2563: iterator_base (container) 2367: iterator_base (container)
2564{ 2368{
2614{ 2418{
2615 char flagdesc[512]; 2419 char flagdesc[512];
2616 char info2[256 * 4]; 2420 char info2[256 * 4];
2617 char *p = info; 2421 char *p = info;
2618 2422
2619 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s,flags:[%s],type:%d}", 2423 p += snprintf (p, 512, "{cnt:%d,uuid:%s,name:\"%s\"%s%s%s,flags:[%s],type:%d}",
2620 count, 2424 count,
2621 uuid.c_str (), 2425 uuid.c_str (),
2622 &name, 2426 &name,
2623 title ? "\",title:\"" : "", 2427 title ? ",title:\"" : "",
2624 title ? (const char *)title : "", 2428 title ? (const char *)title : "",
2429 title ? "\"" : "",
2625 flag_desc (flagdesc, 512), type); 2430 flag_desc (flagdesc, 512), type);
2626 2431
2627 if (!this->flag[FLAG_REMOVED] && env) 2432 if (!flag[FLAG_REMOVED] && env)
2628 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2433 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2629 2434
2630 if (map) 2435 if (map)
2631 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y); 2436 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2632 2437
2662object::open_container (object *new_container) 2467object::open_container (object *new_container)
2663{ 2468{
2664 if (container == new_container) 2469 if (container == new_container)
2665 return; 2470 return;
2666 2471
2667 if (object *old_container = container) 2472 object *old_container = container;
2473
2474 if (old_container)
2668 { 2475 {
2669 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this))) 2476 if (INVOKE_OBJECT (CLOSE, old_container, ARG_OBJECT (this)))
2670 return; 2477 return;
2671 2478
2672#if 0 2479#if 0
2674 if (object *closer = old_container->inv) 2481 if (object *closer = old_container->inv)
2675 if (closer->type == CLOSE_CON) 2482 if (closer->type == CLOSE_CON)
2676 closer->destroy (); 2483 closer->destroy ();
2677#endif 2484#endif
2678 2485
2486 // make sure the container is available
2487 esrv_send_item (this, old_container);
2488
2679 old_container->flag [FLAG_APPLIED] = 0; 2489 old_container->flag [FLAG_APPLIED] = false;
2680 container = 0; 2490 container = 0;
2681 2491
2492 // client needs item update to make it work, client bug requires this to be separate
2682 esrv_update_item (UPD_FLAGS, this, old_container); 2493 esrv_update_item (UPD_FLAGS, this, old_container);
2494
2683 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", query_name (old_container)); 2495 new_draw_info_format (NDI_UNIQUE, 0, this, "You close %s.", old_container->query_name ());
2684 play_sound (sound_find ("chest_close")); 2496 play_sound (sound_find ("chest_close"));
2685 } 2497 }
2686 2498
2687 if (new_container) 2499 if (new_container)
2688 { 2500 {
2698 closer->flag [FLAG_NO_MAP_SAVE] = 1; 2510 closer->flag [FLAG_NO_MAP_SAVE] = 1;
2699 new_container->insert (closer); 2511 new_container->insert (closer);
2700 } 2512 }
2701#endif 2513#endif
2702 2514
2703 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", query_name (new_container)); 2515 new_draw_info_format (NDI_UNIQUE, 0, this, "You open %s.", new_container->query_name ());
2704 2516
2517 // make sure the container is available, client bug requires this to be separate
2518 esrv_send_item (this, new_container);
2519
2705 new_container->flag [FLAG_APPLIED] = 1; 2520 new_container->flag [FLAG_APPLIED] = true;
2706 container = new_container; 2521 container = new_container;
2707 2522
2523 // client needs flag change
2708 esrv_update_item (UPD_FLAGS, this, new_container); 2524 esrv_update_item (UPD_FLAGS, this, new_container);
2709 esrv_send_inventory (this, new_container); 2525 esrv_send_inventory (this, new_container);
2710 play_sound (sound_find ("chest_open")); 2526 play_sound (sound_find ("chest_open"));
2711 } 2527 }
2528// else if (!old_container->env && contr && contr->ns)
2529// contr->ns->floorbox_reset ();
2712} 2530}
2713 2531
2714object * 2532object *
2715object::force_find (const shstr name) 2533object::force_find (shstr_tmp name)
2716{ 2534{
2717 /* cycle through his inventory to look for the MARK we want to 2535 /* cycle through his inventory to look for the MARK we want to
2718 * place 2536 * place
2719 */ 2537 */
2720 for (object *tmp = inv; tmp; tmp = tmp->below) 2538 for (object *tmp = inv; tmp; tmp = tmp->below)
2723 2541
2724 return 0; 2542 return 0;
2725} 2543}
2726 2544
2727void 2545void
2546object::force_set_timer (int duration)
2547{
2548 this->duration = 1;
2549 this->speed_left = -1.f;
2550
2551 this->set_speed (duration ? 1.f / duration : 0.f);
2552}
2553
2554object *
2728object::force_add (const shstr name, int duration) 2555object::force_add (shstr_tmp name, int duration)
2729{ 2556{
2730 if (object *force = force_find (name)) 2557 if (object *force = force_find (name))
2731 force->destroy (); 2558 force->destroy ();
2732 2559
2733 object *force = get_archetype (FORCE_NAME); 2560 object *force = get_archetype (FORCE_NAME);
2734 2561
2735 force->slaying = name; 2562 force->slaying = name;
2736 force->stats.food = 1;
2737 force->speed_left = -1.f;
2738 2563
2739 force->set_speed (duration ? 1.f / duration : 0.f); 2564 force->force_set_timer (duration);
2740 force->flag [FLAG_IS_USED_UP] = true; 2565
2741 force->flag [FLAG_APPLIED] = true; 2566 force->flag [FLAG_APPLIED] = true;
2742 2567
2743 insert (force); 2568 return insert (force);
2744} 2569}
2745 2570
2746void 2571void
2747object::play_sound (faceidx sound) const 2572object::play_sound (faceidx sound) const
2748{ 2573{
2749 if (!sound) 2574 if (!sound)
2750 return; 2575 return;
2751 2576
2752 if (flag [FLAG_REMOVED]) 2577 if (is_on_map ())
2578 map->play_sound (sound, x, y);
2579 else if (object *pl = in_player ())
2580 pl->contr->play_sound (sound);
2581}
2582
2583void
2584object::say_msg (const char *msg) const
2585{
2586 if (is_on_map ())
2587 map->say_msg (msg, x, y);
2588 else if (object *pl = in_player ())
2589 pl->contr->play_sound (sound);
2590}
2591
2592void
2593object::make_noise ()
2594{
2595 // we do not model noise in the map, so instead put
2596 // a temporary light into the noise source
2597 // could use the map instead, but that's less reliable for our
2598 // goal, which is to make invisibility a bit harder to exploit
2599
2600 // currently only works sensibly for players
2601 if (!is_player ())
2753 return; 2602 return;
2754 2603
2755 if (env) 2604 // find old force, or create new one
2756 { 2605 object *force = force_find (shstr_noise_force);
2757 if (object *pl = in_player ()) 2606
2758 pl->contr->play_sound (sound); 2607 if (force)
2759 } 2608 force->speed_left = -1.f; // patch old speed up
2760 else 2609 else
2761 map->play_sound (sound, x, y); 2610 {
2762} 2611 force = archetype::get (shstr_noise_force);
2763 2612
2613 force->slaying = shstr_noise_force;
2614 force->stats.food = 1;
2615 force->speed_left = -1.f;
2616
2617 force->set_speed (1.f / 4.f);
2618 force->flag [FLAG_IS_USED_UP] = true;
2619 force->flag [FLAG_APPLIED] = true;
2620
2621 insert (force);
2622 }
2623}
2624

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines